{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/83755783","pull_request_review_id":4578223,"id":83755783,"diff_hunk":"@@ -860,12 +860,33 @@ export class Viewer {\n     if (!this.hasCapability('fragment')) {\n       return Promise.resolve('');\n     }\n-    return this.sendMessageUnreliable_('fragment', undefined, true).then(\n+    return this.sendMessageUnreliable_('getFragment', undefined, true).then(\n       hash => hash || ''\n     );\n   }\n \n   /**\n+   * Update the fragment of the viewer if embedded in a viewer,\n+   * otherwise update the page url fragment\n+   * @param {string} fragment\n+   * @return {!Promise}\n+   */\n+  updateFragment(fragment) {\n+    if (!this.isEmbedded_) {\n+      if (this.win.history.replaceState) {\n+        const newUrl = this.win.location.href.split('#')[0] + '#' + fragment;\n+        this.win.history.replaceState({}, '', newUrl);\n+      }\n+      return Promise.resolve();\n+    }\n+    if (!this.hasCapability('fragment')) {\n+      return Promise.resolve();\n+    }\n+    return /** @type {!Promise} */ (this.sendMessageUnreliable_(","path":"src/service/viewer-impl.js","position":27,"original_position":27,"commit_id":"b8cfad332404610f8eab167ba7c9f34257dc257c","original_commit_id":"b8cfad332404610f8eab167ba7c9f34257dc257c","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"body":"When I send the message to viewer to let it update the fragment, the viewer should update the google.com url fragment with the `fragment` we provided. When amp page is embedded in search viewer, we want the share-tracking fragment update to be reflected in the google search url. Search viewer should do something like `win.history.replaceState` on their side.","created_at":"2016-10-17T23:25:59Z","updated_at":"2016-10-17T23:25:59Z","html_url":"https://github.com/ampproject/amphtml/pull/4762#discussion_r83755783","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4762","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/83755783"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4762#discussion_r83755783"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4762"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4762","id":83173225,"html_url":"https://github.com/ampproject/amphtml/pull/4762","diff_url":"https://github.com/ampproject/amphtml/pull/4762.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4762.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4762","number":4762,"state":"open","locked":false,"title":"Replace url fragment with outgoing share tracking fragment","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"body":"#3135 ","created_at":"2016-08-29T21:44:08Z","updated_at":"2016-10-17T23:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"572ff87031c7119b12197b551949359e8264daa7","assignee":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"assignees":[{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4762/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4762/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4762/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/b8cfad332404610f8eab167ba7c9f34257dc257c","head":{"label":"muxin:share-tracking-replace-url","ref":"share-tracking-replace-url","sha":"b8cfad332404610f8eab167ba7c9f34257dc257c","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"repo":{"id":58148082,"name":"amphtml","full_name":"muxin/amphtml","owner":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muxin/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/muxin/amphtml","forks_url":"https://api.github.com/repos/muxin/amphtml/forks","keys_url":"https://api.github.com/repos/muxin/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muxin/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muxin/amphtml/teams","hooks_url":"https://api.github.com/repos/muxin/amphtml/hooks","issue_events_url":"https://api.github.com/repos/muxin/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/muxin/amphtml/events","assignees_url":"https://api.github.com/repos/muxin/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/muxin/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/muxin/amphtml/tags","blobs_url":"https://api.github.com/repos/muxin/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muxin/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muxin/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/muxin/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muxin/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/muxin/amphtml/languages","stargazers_url":"https://api.github.com/repos/muxin/amphtml/stargazers","contributors_url":"https://api.github.com/repos/muxin/amphtml/contributors","subscribers_url":"https://api.github.com/repos/muxin/amphtml/subscribers","subscription_url":"https://api.github.com/repos/muxin/amphtml/subscription","commits_url":"https://api.github.com/repos/muxin/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/muxin/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/muxin/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/muxin/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/muxin/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/muxin/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muxin/amphtml/merges","archive_url":"https://api.github.com/repos/muxin/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muxin/amphtml/downloads","issues_url":"https://api.github.com/repos/muxin/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/muxin/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/muxin/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/muxin/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muxin/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/muxin/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/muxin/amphtml/deployments","created_at":"2016-05-05T17:18:38Z","updated_at":"2016-05-05T17:18:42Z","pushed_at":"2016-10-14T19:43:47Z","git_url":"git://github.com/muxin/amphtml.git","ssh_url":"git@github.com:muxin/amphtml.git","clone_url":"https://github.com/muxin/amphtml.git","svn_url":"https://github.com/muxin/amphtml","homepage":"https://ampproject.org","size":177368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"eb922c00c98717bdd7903343f9c916828bb6be52","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-10-17T22:31:34Z","pushed_at":"2016-10-17T23:17:49Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":218297,"stargazers_count":8816,"watchers_count":8816,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1327,"mirror_url":null,"open_issues_count":878,"forks":1327,"open_issues":878,"watchers":8816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4762"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4762"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4762"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4762/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4762/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4762/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/b8cfad332404610f8eab167ba7c9f34257dc257c"}}}}
{"actor":{"display_login":"muxin"}}