{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/53731565","id":53731565,"diff_hunk":"@@ -89,6 +91,17 @@ public static void createDeploymentService(final ManagementResourceRegistration\n                 .addDependency(NamingService.SERVICE_NAME)\n                 .addDependency(ConnectorServices.BOOTSTRAP_CONTEXT_SERVICE.append(bootStrapCtxName))\n                 .addDependency(ConnectorServices.RESOURCE_ADAPTER_DEPLOYER_SERVICE_PREFIX.append(connectorXmlDescriptor.getDeploymentName()));\n+        String raName = deployment;\n+        if (raxml.getId() != null) {\n+            raName = raxml.getId();\n+        }\n+        ServiceName parentName = ServiceName.of(ConnectorServices.RA_SERVICE, raName);\n+        for(ServiceName subServiceName: serviceRegistry.getServiceNames()) {\n+            if (parentName.isParentOf(subServiceName)","path":"connector/src/main/java/org/jboss/as/connector/util/RaServicesFactory.java","position":44,"original_position":44,"commit_id":"0c85daf87645bb565a50e9e4ba128d261321f011","original_commit_id":"0c85daf87645bb565a50e9e4ba128d261321f011","user":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"body":"Yes, the service with name: `parentName` holds the value of `Activation`, which  is used by the deployer service to do the deployment, so it needs to depend on this service.\r\n\r\nIn case of any child service like: `ConfigPropertiesService` available, this service(`parentName`) is an indirect dependency already, but I think it should be fine.","created_at":"2016-02-23T03:11:22Z","updated_at":"2016-02-23T03:11:22Z","html_url":"https://github.com/wildfly/wildfly/pull/8592#discussion_r53731565","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/8592","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/53731565"},"html":{"href":"https://github.com/wildfly/wildfly/pull/8592#discussion_r53731565"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/8592"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/8592","id":56569471,"html_url":"https://github.com/wildfly/wildfly/pull/8592","diff_url":"https://github.com/wildfly/wildfly/pull/8592.diff","patch_url":"https://github.com/wildfly/wildfly/pull/8592.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/8592","number":8592,"state":"open","locked":false,"title":"[WFLY-6035] Race condition during server start-up - config property of ConnectionDefinition is not injected","user":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"body":"Jira: https://issues.jboss.org/browse/WFLY-6035\r\n\r\n","created_at":"2016-01-20T06:35:52Z","updated_at":"2016-02-23T03:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e01883b5d9043a2d60c35a9d06e49bc90e447933","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/8592/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/8592/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/8592/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/0c85daf87645bb565a50e9e4ba128d261321f011","head":{"label":"gaol:WFLY-6035","ref":"WFLY-6035","sha":"0c85daf87645bb565a50e9e4ba128d261321f011","user":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"repo":{"id":15737635,"name":"wildfly","full_name":"gaol/wildfly","owner":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaol/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/gaol/wildfly","forks_url":"https://api.github.com/repos/gaol/wildfly/forks","keys_url":"https://api.github.com/repos/gaol/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaol/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaol/wildfly/teams","hooks_url":"https://api.github.com/repos/gaol/wildfly/hooks","issue_events_url":"https://api.github.com/repos/gaol/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/gaol/wildfly/events","assignees_url":"https://api.github.com/repos/gaol/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/gaol/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/gaol/wildfly/tags","blobs_url":"https://api.github.com/repos/gaol/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaol/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaol/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaol/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaol/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/gaol/wildfly/languages","stargazers_url":"https://api.github.com/repos/gaol/wildfly/stargazers","contributors_url":"https://api.github.com/repos/gaol/wildfly/contributors","subscribers_url":"https://api.github.com/repos/gaol/wildfly/subscribers","subscription_url":"https://api.github.com/repos/gaol/wildfly/subscription","commits_url":"https://api.github.com/repos/gaol/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaol/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaol/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaol/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaol/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/gaol/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaol/wildfly/merges","archive_url":"https://api.github.com/repos/gaol/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaol/wildfly/downloads","issues_url":"https://api.github.com/repos/gaol/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/gaol/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/gaol/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/gaol/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaol/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/gaol/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/gaol/wildfly/deployments","created_at":"2014-01-08T14:27:05Z","updated_at":"2014-01-08T14:27:15Z","pushed_at":"2016-02-22T15:53:28Z","git_url":"git://github.com/gaol/wildfly.git","ssh_url":"git@github.com:gaol/wildfly.git","clone_url":"https://github.com/gaol/wildfly.git","svn_url":"https://github.com/gaol/wildfly","homepage":"http://wildfly.org","size":140342,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"7df9d1634bfd77e9810207ab1f057a9d55ab578c","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"name":"wildfly","full_name":"wildfly/wildfly","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2016-02-23T01:50:50Z","pushed_at":"2016-02-22T23:08:45Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":228857,"stargazers_count":1556,"watchers_count":1556,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1541,"mirror_url":null,"open_issues_count":85,"forks":1541,"open_issues":85,"watchers":1556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/8592"},"html":{"href":"https://github.com/wildfly/wildfly/pull/8592"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/8592"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/8592/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/8592/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/8592/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/0c85daf87645bb565a50e9e4ba128d261321f011"}}}}