{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/52095939","id":52095939,"diff_hunk":"@@ -2160,11 +2160,12 @@ ReplicatedPG::cache_result_t ReplicatedPG::maybe_handle_cache_detail(\n       }\n \n       // Promote too?\n-      if (!op->need_skip_promote()) {\n-        maybe_promote(obc, missing_oid, oloc, in_hit_set,\n+      if (!op->need_skip_promote() && \n+          maybe_promote(obc, missing_oid, oloc, in_hit_set,\n \t              pool.info.min_write_recency_for_promote,\n \t\t      OpRequestRef(),\n-\t\t      promote_obc);\n+\t\t      promote_obc)) {\n+\treturn cache_result_t::BLOCKED_PROMOTE;","path":"src/osd/ReplicatedPG.cc","position":21,"original_position":21,"commit_id":"658ecbce0ca8e02744dc1ccc1048a5420e522159","original_commit_id":"658ecbce0ca8e02744dc1ccc1048a5420e522159","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"This hunk looks like an unrelated bug fix.. can you move it into a separate patch?","created_at":"2016-02-06T02:27:19Z","updated_at":"2016-02-06T02:27:19Z","html_url":"https://github.com/ceph/ceph/pull/7537#discussion_r52095939","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/7537","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/52095939"},"html":{"href":"https://github.com/ceph/ceph/pull/7537#discussion_r52095939"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7537"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7537","id":58436196,"html_url":"https://github.com/ceph/ceph/pull/7537","diff_url":"https://github.com/ceph/ceph/pull/7537.diff","patch_url":"https://github.com/ceph/ceph/pull/7537.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7537","number":7537,"state":"open","locked":false,"title":"OSD/ReplicatedPG: Fixes unneccessary object promotion when deleting f…","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"body":"…rom the cache that lacks hit_set configured.\r\n\r\nMinor cleanup nearby too.\r\n\r\nThis issue was mentioned at http://tracker.ceph.com/issues/13894 ( comment #12 and beyond ) but it's probably not the root cause of 13894.\r\n\r\nSigned-off-by: Igor Fedotov <ifedotov@mirantis.com>","created_at":"2016-02-05T14:38:11Z","updated_at":"2016-02-06T02:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8903ac8c1db104e65bd3fbf4aeea1e6cccbb1062","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/7537/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/7537/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7537/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/658ecbce0ca8e02744dc1ccc1048a5420e522159","head":{"label":"ifed01:wip-no-promote-for-delete-fix","ref":"wip-no-promote-for-delete-fix","sha":"658ecbce0ca8e02744dc1ccc1048a5420e522159","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"repo":{"id":42860525,"name":"ceph","full_name":"ifed01/ceph","owner":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifed01/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/ifed01/ceph","forks_url":"https://api.github.com/repos/ifed01/ceph/forks","keys_url":"https://api.github.com/repos/ifed01/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifed01/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifed01/ceph/teams","hooks_url":"https://api.github.com/repos/ifed01/ceph/hooks","issue_events_url":"https://api.github.com/repos/ifed01/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ifed01/ceph/events","assignees_url":"https://api.github.com/repos/ifed01/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ifed01/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ifed01/ceph/tags","blobs_url":"https://api.github.com/repos/ifed01/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifed01/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifed01/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifed01/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifed01/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ifed01/ceph/languages","stargazers_url":"https://api.github.com/repos/ifed01/ceph/stargazers","contributors_url":"https://api.github.com/repos/ifed01/ceph/contributors","subscribers_url":"https://api.github.com/repos/ifed01/ceph/subscribers","subscription_url":"https://api.github.com/repos/ifed01/ceph/subscription","commits_url":"https://api.github.com/repos/ifed01/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifed01/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifed01/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifed01/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifed01/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ifed01/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifed01/ceph/merges","archive_url":"https://api.github.com/repos/ifed01/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifed01/ceph/downloads","issues_url":"https://api.github.com/repos/ifed01/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ifed01/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ifed01/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ifed01/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifed01/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ifed01/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ifed01/ceph/deployments","created_at":"2015-09-21T10:49:23Z","updated_at":"2016-01-12T23:28:29Z","pushed_at":"2016-02-05T14:47:10Z","git_url":"git://github.com/ifed01/ceph.git","ssh_url":"git@github.com:ifed01/ceph.git","clone_url":"https://github.com/ifed01/ceph.git","svn_url":"https://github.com/ifed01/ceph","homepage":"http://ceph.com","size":154060,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"c4f9d2655323cc80630f88029234881b51e55306","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-02-05T18:57:31Z","pushed_at":"2016-02-06T02:24:39Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":182150,"stargazers_count":1861,"watchers_count":1861,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1130,"mirror_url":null,"open_issues_count":236,"forks":1130,"open_issues":236,"watchers":1861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7537"},"html":{"href":"https://github.com/ceph/ceph/pull/7537"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/7537"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/7537/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7537/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7537/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/658ecbce0ca8e02744dc1ccc1048a5420e522159"}}}}