{"action":"opened","number":33387,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387","id":86571864,"html_url":"https://github.com/kubernetes/kubernetes/pull/33387","diff_url":"https://github.com/kubernetes/kubernetes/pull/33387.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33387.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33387","number":33387,"state":"open","locked":false,"title":"Abstraction of endpoints in leaderelection code","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"**Problem Statement**:\r\nCurrently the Leader Election code is hard coded against the endpoints api.  This causes performance issues on large scale clusters due to incessant iptables refreshes, see: https://github.com/kubernetes/kubernetes/issues/26637 \r\n\r\nThe goal of this PR is to: \r\n\r\n- Abstract Endpoints out of the leader election code\r\n- Fix a known bug in the event recording \r\n\r\nfixes #18386\r\n\r\n**Special notes for your reviewer**:\r\nThis is a 1st pass at abstracting the details of endpoints our into an interface.  Any suggestions around how we we want to refactor this interface is welcome and could be addressed in either this PR or follow on PR. \r\n\r\n/cc @ncdc @wojtek-t @rrati ","created_at":"2016-09-23T19:57:46Z","updated_at":"2016-09-23T19:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":206,"closed_issues":78,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-09-23T19:57:46Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33387/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0b0a048139a1a3b9079ce8c86e4d09cd00de4b8d","head":{"label":"timothysc:resource_lock_abstraction","ref":"resource_lock_abstraction","sha":"0b0a048139a1a3b9079ce8c86e4d09cd00de4b8d","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"repo":{"id":28345483,"name":"kubernetes","full_name":"timothysc/kubernetes","owner":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timothysc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/timothysc/kubernetes","forks_url":"https://api.github.com/repos/timothysc/kubernetes/forks","keys_url":"https://api.github.com/repos/timothysc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timothysc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timothysc/kubernetes/teams","hooks_url":"https://api.github.com/repos/timothysc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/timothysc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/timothysc/kubernetes/events","assignees_url":"https://api.github.com/repos/timothysc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/timothysc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/timothysc/kubernetes/tags","blobs_url":"https://api.github.com/repos/timothysc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timothysc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timothysc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/timothysc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timothysc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/timothysc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/timothysc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/timothysc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/timothysc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/timothysc/kubernetes/subscription","commits_url":"https://api.github.com/repos/timothysc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/timothysc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/timothysc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/timothysc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/timothysc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/timothysc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timothysc/kubernetes/merges","archive_url":"https://api.github.com/repos/timothysc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timothysc/kubernetes/downloads","issues_url":"https://api.github.com/repos/timothysc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/timothysc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/timothysc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/timothysc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timothysc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/timothysc/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/timothysc/kubernetes/deployments","created_at":"2014-12-22T15:52:58Z","updated_at":"2015-03-06T19:21:46Z","pushed_at":"2016-09-23T19:37:44Z","git_url":"git://github.com/timothysc/kubernetes.git","ssh_url":"git@github.com:timothysc/kubernetes.git","clone_url":"https://github.com/timothysc/kubernetes.git","svn_url":"https://github.com/timothysc/kubernetes","homepage":null,"size":315916,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"33eabe675b15a607c5140bbf1e1fc0bac57f7baf","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-23T19:21:42Z","pushed_at":"2016-09-23T19:57:46Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":569120,"stargazers_count":17011,"watchers_count":17011,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5509,"mirror_url":null,"open_issues_count":4587,"forks":5509,"open_issues":4587,"watchers":17011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33387"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33387"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33387/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33387/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0b0a048139a1a3b9079ce8c86e4d09cd00de4b8d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":253,"deletions":111,"changed_files":6}}
{"actor":{"display_login":"timothysc"}}