{"action":"created","comment":{"url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/comments/83462316","pull_request_review_id":4306959,"id":83462316,"diff_hunk":"@@ -69,26 +69,66 @@ type inMemoryCounter struct {\n \tTags  map[string]string\n }\n \n-// getKey converts name+tags into a single string of the form\n-// \"name|tag1=value1|...|tagN=valueN\", where tag names are sorted alphabetically.\n-func (r *InMemoryStatsCollector) getKey(name string, tags map[string]string) string {\n+// MetricDescr describes a metric with tags\n+type MetricDescr struct {\n+\tName string\n+\tTags map[string]string\n+}\n+\n+// NewMetricDescr creates a new metric descriptor from the name and an even number\n+// of keyValues strings treates as alternating key, value pairs.\n+func NewMetricDescr(name string, keyValues ...string) MetricDescr {\n+\tm := MetricDescr{Name: name}\n+\tif len(keyValues)%2 != 0 {\n+\t\treturn m.WithTag(\"error\", \"uneven_keyValues_count\")","path":"stats_reporter.go","position":28,"original_position":28,"commit_id":"c770ebbb417611bb397b9affbb11a431fd59582b","original_commit_id":"c770ebbb417611bb397b9affbb11a431fd59582b","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"this is primarily a testing facility, where fluent syntax is more important. Returning (, error) breaks the flow without much benefits.","created_at":"2016-10-14T17:05:33Z","updated_at":"2016-10-14T17:05:33Z","html_url":"https://github.com/uber/jaeger-client-go/pull/53#discussion_r83462316","pull_request_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/comments/83462316"},"html":{"href":"https://github.com/uber/jaeger-client-go/pull/53#discussion_r83462316"},"pull_request":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53","id":89129711,"html_url":"https://github.com/uber/jaeger-client-go/pull/53","diff_url":"https://github.com/uber/jaeger-client-go/pull/53.diff","patch_url":"https://github.com/uber/jaeger-client-go/pull/53.patch","issue_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/53","number":53,"state":"open","locked":false,"title":"Fix logic for traces started/joined metric","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-13T03:09:21Z","updated_at":"2016-10-14T17:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02d31e833fd33b6501bb94d43f1246d1c17be13a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53/commits","review_comments_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53/comments","review_comment_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/53/comments","statuses_url":"https://api.github.com/repos/uber/jaeger-client-go/statuses/c770ebbb417611bb397b9affbb11a431fd59582b","head":{"label":"uber:fix-traces-started-joined-metrics","ref":"fix-traces-started-joined-metrics","sha":"c770ebbb417611bb397b9affbb11a431fd59582b","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56550961,"name":"jaeger-client-go","full_name":"uber/jaeger-client-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-go","description":"Jaeger Bindings for Go OpenTracing API.","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-go","forks_url":"https://api.github.com/repos/uber/jaeger-client-go/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-go/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-go/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-go/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-go/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-go/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-go/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-go/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-go/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-go/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-go/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-go/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-go/deployments","created_at":"2016-04-19T00:09:28Z","updated_at":"2016-10-09T01:56:04Z","pushed_at":"2016-10-14T03:42:24Z","git_url":"git://github.com/uber/jaeger-client-go.git","ssh_url":"git@github.com:uber/jaeger-client-go.git","clone_url":"https://github.com/uber/jaeger-client-go.git","svn_url":"https://github.com/uber/jaeger-client-go","homepage":"","size":350,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":17,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"fc42922d2775496b9ebe978b11260234f3ac127f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56550961,"name":"jaeger-client-go","full_name":"uber/jaeger-client-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-go","description":"Jaeger Bindings for Go OpenTracing API.","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-go","forks_url":"https://api.github.com/repos/uber/jaeger-client-go/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-go/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-go/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-go/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-go/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-go/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-go/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-go/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-go/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-go/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-go/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-go/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-go/deployments","created_at":"2016-04-19T00:09:28Z","updated_at":"2016-10-09T01:56:04Z","pushed_at":"2016-10-14T03:42:24Z","git_url":"git://github.com/uber/jaeger-client-go.git","ssh_url":"git@github.com:uber/jaeger-client-go.git","clone_url":"https://github.com/uber/jaeger-client-go.git","svn_url":"https://github.com/uber/jaeger-client-go","homepage":"","size":350,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53"},"html":{"href":"https://github.com/uber/jaeger-client-go/pull/53"},"issue":{"href":"https://api.github.com/repos/uber/jaeger-client-go/issues/53"},"comments":{"href":"https://api.github.com/repos/uber/jaeger-client-go/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/jaeger-client-go/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/uber/jaeger-client-go/statuses/c770ebbb417611bb397b9affbb11a431fd59582b"}}}}
{"actor":{"display_login":"yurishkuro"}}