{"action":"created","comment":{"url":"https://api.github.com/repos/prismicio/scala-kit/pulls/comments/73416663","id":73416663,"diff_hunk":"@@ -71,18 +71,16 @@ object HttpClient {\n       override def initChannel(ch: SocketChannel) = {\n         val p: ChannelPipeline = ch.pipeline()\n \n-        /** Proxy support disabled until stable release of Netty 4.1\n         proxy match {\n           case Some(ProxyServer(phost, pport, _, Some(username), Some(password), _, _, _)) =>\n             p.addLast(new HttpProxyHandler(new InetSocketAddress(phost, pport), username, password))\n           case Some(ProxyServer(phost, pport, _, _, _, _, _, _)) =>\n             p.addLast(new HttpProxyHandler(new InetSocketAddress(phost, pport)))\n           case _ => ()\n         }\n-          */\n \n         if (scheme == \"https\") {\n-          val sslCtx = SslContext.newClientContext(SslContext.defaultClientProvider())\n+          val sslCtx = SslContextBuilder.forClient().sslProvider(SslContext.defaultClientProvider()).build()","path":"src/main/scala/io/prismic/HttpClient.scala","position":36,"original_position":36,"commit_id":"986a83ce5f5749cefecd219ca16f812c58611b6f","original_commit_id":"986a83ce5f5749cefecd219ca16f812c58611b6f","user":{"login":"randak","id":2506770,"avatar_url":"https://avatars.githubusercontent.com/u/2506770?v=3","gravatar_id":"","url":"https://api.github.com/users/randak","html_url":"https://github.com/randak","followers_url":"https://api.github.com/users/randak/followers","following_url":"https://api.github.com/users/randak/following{/other_user}","gists_url":"https://api.github.com/users/randak/gists{/gist_id}","starred_url":"https://api.github.com/users/randak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randak/subscriptions","organizations_url":"https://api.github.com/users/randak/orgs","repos_url":"https://api.github.com/users/randak/repos","events_url":"https://api.github.com/users/randak/events{/privacy}","received_events_url":"https://api.github.com/users/randak/received_events","type":"User","site_admin":false},"body":"`SslContext.newClientContext` is deprecated.","created_at":"2016-08-03T20:41:35Z","updated_at":"2016-08-03T20:41:35Z","html_url":"https://github.com/prismicio/scala-kit/pull/40#discussion_r73416663","pull_request_url":"https://api.github.com/repos/prismicio/scala-kit/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/comments/73416663"},"html":{"href":"https://github.com/prismicio/scala-kit/pull/40#discussion_r73416663"},"pull_request":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/prismicio/scala-kit/pulls/40","id":79974934,"html_url":"https://github.com/prismicio/scala-kit/pull/40","diff_url":"https://github.com/prismicio/scala-kit/pull/40.diff","patch_url":"https://github.com/prismicio/scala-kit/pull/40.patch","issue_url":"https://api.github.com/repos/prismicio/scala-kit/issues/40","number":40,"state":"open","locked":false,"title":"Upgrading to Netty 4.1 and reintroducing proxy support","user":{"login":"randak","id":2506770,"avatar_url":"https://avatars.githubusercontent.com/u/2506770?v=3","gravatar_id":"","url":"https://api.github.com/users/randak","html_url":"https://github.com/randak","followers_url":"https://api.github.com/users/randak/followers","following_url":"https://api.github.com/users/randak/following{/other_user}","gists_url":"https://api.github.com/users/randak/gists{/gist_id}","starred_url":"https://api.github.com/users/randak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randak/subscriptions","organizations_url":"https://api.github.com/users/randak/orgs","repos_url":"https://api.github.com/users/randak/repos","events_url":"https://api.github.com/users/randak/events{/privacy}","received_events_url":"https://api.github.com/users/randak/received_events","type":"User","site_admin":false},"body":"Proxy support was removed from an earlier version of the scala-kit due to a lack of stability in Netty 4.1. Now that 4.1 is out, I've reintroduced proxy support. Additionally, I have added it to `previewSession` — it was previously impossible to use preview functionality behind a proxy. A couple of other changes have been made to remove references to deprecated Netty methods.","created_at":"2016-08-03T20:40:15Z","updated_at":"2016-08-03T20:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd3f1e6ebd0f36a30cc70f6a820e9dcf1af34a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prismicio/scala-kit/pulls/40/commits","review_comments_url":"https://api.github.com/repos/prismicio/scala-kit/pulls/40/comments","review_comment_url":"https://api.github.com/repos/prismicio/scala-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prismicio/scala-kit/issues/40/comments","statuses_url":"https://api.github.com/repos/prismicio/scala-kit/statuses/986a83ce5f5749cefecd219ca16f812c58611b6f","head":{"label":"randak:proxy-support","ref":"proxy-support","sha":"986a83ce5f5749cefecd219ca16f812c58611b6f","user":{"login":"randak","id":2506770,"avatar_url":"https://avatars.githubusercontent.com/u/2506770?v=3","gravatar_id":"","url":"https://api.github.com/users/randak","html_url":"https://github.com/randak","followers_url":"https://api.github.com/users/randak/followers","following_url":"https://api.github.com/users/randak/following{/other_user}","gists_url":"https://api.github.com/users/randak/gists{/gist_id}","starred_url":"https://api.github.com/users/randak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randak/subscriptions","organizations_url":"https://api.github.com/users/randak/orgs","repos_url":"https://api.github.com/users/randak/repos","events_url":"https://api.github.com/users/randak/events{/privacy}","received_events_url":"https://api.github.com/users/randak/received_events","type":"User","site_admin":false},"repo":{"id":47317448,"name":"scala-kit","full_name":"randak/scala-kit","owner":{"login":"randak","id":2506770,"avatar_url":"https://avatars.githubusercontent.com/u/2506770?v=3","gravatar_id":"","url":"https://api.github.com/users/randak","html_url":"https://github.com/randak","followers_url":"https://api.github.com/users/randak/followers","following_url":"https://api.github.com/users/randak/following{/other_user}","gists_url":"https://api.github.com/users/randak/gists{/gist_id}","starred_url":"https://api.github.com/users/randak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randak/subscriptions","organizations_url":"https://api.github.com/users/randak/orgs","repos_url":"https://api.github.com/users/randak/repos","events_url":"https://api.github.com/users/randak/events{/privacy}","received_events_url":"https://api.github.com/users/randak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/randak/scala-kit","description":"Development kit for the Scala language","fork":true,"url":"https://api.github.com/repos/randak/scala-kit","forks_url":"https://api.github.com/repos/randak/scala-kit/forks","keys_url":"https://api.github.com/repos/randak/scala-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randak/scala-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randak/scala-kit/teams","hooks_url":"https://api.github.com/repos/randak/scala-kit/hooks","issue_events_url":"https://api.github.com/repos/randak/scala-kit/issues/events{/number}","events_url":"https://api.github.com/repos/randak/scala-kit/events","assignees_url":"https://api.github.com/repos/randak/scala-kit/assignees{/user}","branches_url":"https://api.github.com/repos/randak/scala-kit/branches{/branch}","tags_url":"https://api.github.com/repos/randak/scala-kit/tags","blobs_url":"https://api.github.com/repos/randak/scala-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randak/scala-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randak/scala-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/randak/scala-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randak/scala-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/randak/scala-kit/languages","stargazers_url":"https://api.github.com/repos/randak/scala-kit/stargazers","contributors_url":"https://api.github.com/repos/randak/scala-kit/contributors","subscribers_url":"https://api.github.com/repos/randak/scala-kit/subscribers","subscription_url":"https://api.github.com/repos/randak/scala-kit/subscription","commits_url":"https://api.github.com/repos/randak/scala-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/randak/scala-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/randak/scala-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/randak/scala-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/randak/scala-kit/contents/{+path}","compare_url":"https://api.github.com/repos/randak/scala-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randak/scala-kit/merges","archive_url":"https://api.github.com/repos/randak/scala-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randak/scala-kit/downloads","issues_url":"https://api.github.com/repos/randak/scala-kit/issues{/number}","pulls_url":"https://api.github.com/repos/randak/scala-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/randak/scala-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/randak/scala-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randak/scala-kit/labels{/name}","releases_url":"https://api.github.com/repos/randak/scala-kit/releases{/id}","deployments_url":"https://api.github.com/repos/randak/scala-kit/deployments","created_at":"2015-12-03T08:06:25Z","updated_at":"2015-12-03T08:06:26Z","pushed_at":"2016-08-03T17:05:30Z","git_url":"git://github.com/randak/scala-kit.git","ssh_url":"git@github.com:randak/scala-kit.git","clone_url":"https://github.com/randak/scala-kit.git","svn_url":"https://github.com/randak/scala-kit","homepage":"","size":8731,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prismicio:master","ref":"master","sha":"750d7cf97abcab27e6c4265286ffc4762cf97e5a","user":{"login":"prismicio","id":4621061,"avatar_url":"https://avatars.githubusercontent.com/u/4621061?v=3","gravatar_id":"","url":"https://api.github.com/users/prismicio","html_url":"https://github.com/prismicio","followers_url":"https://api.github.com/users/prismicio/followers","following_url":"https://api.github.com/users/prismicio/following{/other_user}","gists_url":"https://api.github.com/users/prismicio/gists{/gist_id}","starred_url":"https://api.github.com/users/prismicio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismicio/subscriptions","organizations_url":"https://api.github.com/users/prismicio/orgs","repos_url":"https://api.github.com/users/prismicio/repos","events_url":"https://api.github.com/users/prismicio/events{/privacy}","received_events_url":"https://api.github.com/users/prismicio/received_events","type":"Organization","site_admin":false},"repo":{"id":11813840,"name":"scala-kit","full_name":"prismicio/scala-kit","owner":{"login":"prismicio","id":4621061,"avatar_url":"https://avatars.githubusercontent.com/u/4621061?v=3","gravatar_id":"","url":"https://api.github.com/users/prismicio","html_url":"https://github.com/prismicio","followers_url":"https://api.github.com/users/prismicio/followers","following_url":"https://api.github.com/users/prismicio/following{/other_user}","gists_url":"https://api.github.com/users/prismicio/gists{/gist_id}","starred_url":"https://api.github.com/users/prismicio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismicio/subscriptions","organizations_url":"https://api.github.com/users/prismicio/orgs","repos_url":"https://api.github.com/users/prismicio/repos","events_url":"https://api.github.com/users/prismicio/events{/privacy}","received_events_url":"https://api.github.com/users/prismicio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismicio/scala-kit","description":"Development kit for the Scala language","fork":false,"url":"https://api.github.com/repos/prismicio/scala-kit","forks_url":"https://api.github.com/repos/prismicio/scala-kit/forks","keys_url":"https://api.github.com/repos/prismicio/scala-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismicio/scala-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismicio/scala-kit/teams","hooks_url":"https://api.github.com/repos/prismicio/scala-kit/hooks","issue_events_url":"https://api.github.com/repos/prismicio/scala-kit/issues/events{/number}","events_url":"https://api.github.com/repos/prismicio/scala-kit/events","assignees_url":"https://api.github.com/repos/prismicio/scala-kit/assignees{/user}","branches_url":"https://api.github.com/repos/prismicio/scala-kit/branches{/branch}","tags_url":"https://api.github.com/repos/prismicio/scala-kit/tags","blobs_url":"https://api.github.com/repos/prismicio/scala-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismicio/scala-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismicio/scala-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismicio/scala-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismicio/scala-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/prismicio/scala-kit/languages","stargazers_url":"https://api.github.com/repos/prismicio/scala-kit/stargazers","contributors_url":"https://api.github.com/repos/prismicio/scala-kit/contributors","subscribers_url":"https://api.github.com/repos/prismicio/scala-kit/subscribers","subscription_url":"https://api.github.com/repos/prismicio/scala-kit/subscription","commits_url":"https://api.github.com/repos/prismicio/scala-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismicio/scala-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismicio/scala-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismicio/scala-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismicio/scala-kit/contents/{+path}","compare_url":"https://api.github.com/repos/prismicio/scala-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismicio/scala-kit/merges","archive_url":"https://api.github.com/repos/prismicio/scala-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismicio/scala-kit/downloads","issues_url":"https://api.github.com/repos/prismicio/scala-kit/issues{/number}","pulls_url":"https://api.github.com/repos/prismicio/scala-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/prismicio/scala-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/prismicio/scala-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismicio/scala-kit/labels{/name}","releases_url":"https://api.github.com/repos/prismicio/scala-kit/releases{/id}","deployments_url":"https://api.github.com/repos/prismicio/scala-kit/deployments","created_at":"2013-08-01T10:11:11Z","updated_at":"2016-02-13T20:00:10Z","pushed_at":"2016-08-03T20:40:15Z","git_url":"git://github.com/prismicio/scala-kit.git","ssh_url":"git@github.com:prismicio/scala-kit.git","clone_url":"https://github.com/prismicio/scala-kit.git","svn_url":"https://github.com/prismicio/scala-kit","homepage":"","size":8733,"stargazers_count":14,"watchers_count":14,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/40"},"html":{"href":"https://github.com/prismicio/scala-kit/pull/40"},"issue":{"href":"https://api.github.com/repos/prismicio/scala-kit/issues/40"},"comments":{"href":"https://api.github.com/repos/prismicio/scala-kit/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prismicio/scala-kit/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/prismicio/scala-kit/statuses/986a83ce5f5749cefecd219ca16f812c58611b6f"}}}}
{"actor":{"display_login":"randak"}}