{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/54987468","id":54987468,"diff_hunk":"@@ -220,10 +221,13 @@ func (s *APIServer) AddFlags(fs *pflag.FlagSet) {\n \tfs.StringVar(&s.AuthorizationConfig.WebhookConfigFile, \"authorization-webhook-config-file\", s.AuthorizationConfig.WebhookConfigFile, \"File with webhook configuration in kubeconfig format, used with --authorization-mode=Webhook. The API server will query the remote service to determine access on the API server's secure port.\")\n \tfs.StringVar(&s.AdmissionControl, \"admission-control\", s.AdmissionControl, \"Ordered list of plug-ins to do admission control of resources into cluster. Comma-delimited list of: \"+strings.Join(admission.GetPlugins(), \", \"))\n \tfs.StringVar(&s.AdmissionControlConfigFile, \"admission-control-config-file\", s.AdmissionControlConfigFile, \"File with admission control configuration.\")\n-\tfs.StringSliceVar(&s.EtcdServerList, \"etcd-servers\", s.EtcdServerList, \"List of etcd servers to watch (http://ip:port), comma separated. Mutually exclusive with -etcd-config\")\n+\tfs.StringSliceVar(&s.EtcdConfig.ServerList, \"etcd-servers\", s.EtcdConfig.ServerList, \"List of etcd servers to watch (http://ip:port), comma separated. Mutually exclusive with -etcd-config\")\n \tfs.StringSliceVar(&s.EtcdServersOverrides, \"etcd-servers-overrides\", s.EtcdServersOverrides, \"Per-resource etcd servers overrides, comma separated. The individual override format: group/resource#servers, where servers are http://ip:port, semicolon separated.\")","path":"cmd/kube-apiserver/app/options/options.go","position":61,"original_position":61,"commit_id":"70f9c2809a40c3c8c5e720b705f72d9fb3515cd0","original_commit_id":"5da4c5a9662d3ddab279658a05d6b67f14fc4865","user":{"login":"AdoHe","id":1555564,"avatar_url":"https://avatars.githubusercontent.com/u/1555564?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoHe","html_url":"https://github.com/AdoHe","followers_url":"https://api.github.com/users/AdoHe/followers","following_url":"https://api.github.com/users/AdoHe/following{/other_user}","gists_url":"https://api.github.com/users/AdoHe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoHe/subscriptions","organizations_url":"https://api.github.com/users/AdoHe/orgs","repos_url":"https://api.github.com/users/AdoHe/repos","events_url":"https://api.github.com/users/AdoHe/events{/privacy}","received_events_url":"https://api.github.com/users/AdoHe/received_events","type":"User","site_admin":false},"body":"Now `etcd-servers-overrides` has such format: `extensions/deployments#http://ip1:port1;http://ip2:port2`, if we want to support certificates override, this format can get quite complicated, not that user friendly, I agree with @lavalamp you would have to set up all your etcd clusters to accept the same client cert.","created_at":"2016-03-04T03:46:26Z","updated_at":"2016-03-04T03:46:26Z","html_url":"https://github.com/kubernetes/kubernetes/pull/21535#discussion_r54987468","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/54987468"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21535#discussion_r54987468"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535","id":59936703,"html_url":"https://github.com/kubernetes/kubernetes/pull/21535","diff_url":"https://github.com/kubernetes/kubernetes/pull/21535.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21535.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21535","number":21535,"state":"open","locked":false,"title":"restore ability to run against secured etcd","user":{"login":"AdoHe","id":1555564,"avatar_url":"https://avatars.githubusercontent.com/u/1555564?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoHe","html_url":"https://github.com/AdoHe","followers_url":"https://api.github.com/users/AdoHe/followers","following_url":"https://api.github.com/users/AdoHe/following{/other_user}","gists_url":"https://api.github.com/users/AdoHe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoHe/subscriptions","organizations_url":"https://api.github.com/users/AdoHe/orgs","repos_url":"https://api.github.com/users/AdoHe/repos","events_url":"https://api.github.com/users/AdoHe/events{/privacy}","received_events_url":"https://api.github.com/users/AdoHe/received_events","type":"User","site_admin":false},"body":"Fixes #18760","created_at":"2016-02-19T11:23:30Z","updated_at":"2016-03-04T03:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8aad462ea6dfae0e6024092d7792a85fbd8a993","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":143,"closed_issues":525,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2016-03-04T01:15:56Z","due_on":"2016-03-04T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21535/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/70f9c2809a40c3c8c5e720b705f72d9fb3515cd0","head":{"label":"AdoHe:restore_secure_etcd","ref":"restore_secure_etcd","sha":"70f9c2809a40c3c8c5e720b705f72d9fb3515cd0","user":{"login":"AdoHe","id":1555564,"avatar_url":"https://avatars.githubusercontent.com/u/1555564?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoHe","html_url":"https://github.com/AdoHe","followers_url":"https://api.github.com/users/AdoHe/followers","following_url":"https://api.github.com/users/AdoHe/following{/other_user}","gists_url":"https://api.github.com/users/AdoHe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoHe/subscriptions","organizations_url":"https://api.github.com/users/AdoHe/orgs","repos_url":"https://api.github.com/users/AdoHe/repos","events_url":"https://api.github.com/users/AdoHe/events{/privacy}","received_events_url":"https://api.github.com/users/AdoHe/received_events","type":"User","site_admin":false},"repo":{"id":49691929,"name":"kubernetes","full_name":"AdoHe/kubernetes","owner":{"login":"AdoHe","id":1555564,"avatar_url":"https://avatars.githubusercontent.com/u/1555564?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoHe","html_url":"https://github.com/AdoHe","followers_url":"https://api.github.com/users/AdoHe/followers","following_url":"https://api.github.com/users/AdoHe/following{/other_user}","gists_url":"https://api.github.com/users/AdoHe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoHe/subscriptions","organizations_url":"https://api.github.com/users/AdoHe/orgs","repos_url":"https://api.github.com/users/AdoHe/repos","events_url":"https://api.github.com/users/AdoHe/events{/privacy}","received_events_url":"https://api.github.com/users/AdoHe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdoHe/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/AdoHe/kubernetes","forks_url":"https://api.github.com/repos/AdoHe/kubernetes/forks","keys_url":"https://api.github.com/repos/AdoHe/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoHe/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoHe/kubernetes/teams","hooks_url":"https://api.github.com/repos/AdoHe/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/AdoHe/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/AdoHe/kubernetes/events","assignees_url":"https://api.github.com/repos/AdoHe/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/AdoHe/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/AdoHe/kubernetes/tags","blobs_url":"https://api.github.com/repos/AdoHe/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoHe/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoHe/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoHe/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoHe/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoHe/kubernetes/languages","stargazers_url":"https://api.github.com/repos/AdoHe/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/AdoHe/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/AdoHe/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/AdoHe/kubernetes/subscription","commits_url":"https://api.github.com/repos/AdoHe/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoHe/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoHe/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoHe/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoHe/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/AdoHe/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoHe/kubernetes/merges","archive_url":"https://api.github.com/repos/AdoHe/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoHe/kubernetes/downloads","issues_url":"https://api.github.com/repos/AdoHe/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/AdoHe/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoHe/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoHe/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoHe/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/AdoHe/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/AdoHe/kubernetes/deployments","created_at":"2016-01-15T02:46:21Z","updated_at":"2016-01-15T02:46:31Z","pushed_at":"2016-03-03T08:13:55Z","git_url":"git://github.com/AdoHe/kubernetes.git","ssh_url":"git@github.com:AdoHe/kubernetes.git","clone_url":"https://github.com/AdoHe/kubernetes.git","svn_url":"https://github.com/AdoHe/kubernetes","homepage":"http://kubernetes.io","size":176239,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"59a2b9732d120a2f8f742f949f3d3bee9cb4b48c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-04T02:27:04Z","pushed_at":"2016-03-04T03:45:56Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":334043,"stargazers_count":13026,"watchers_count":13026,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3742,"mirror_url":null,"open_issues_count":3004,"forks":3742,"open_issues":3004,"watchers":13026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21535"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21535"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21535/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21535/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/70f9c2809a40c3c8c5e720b705f72d9fb3515cd0"}}}}