{"action":"created","comment":{"url":"https://api.github.com/repos/krux/kafka-manager/pulls/comments/73622544","id":73622544,"diff_hunk":"@@ -75,4 +80,12 @@ object ClusterFeatures {\n \n     ClusterFeatures(buffer.toSet)\n   }\n+\n+  implicit val formats = Serialization.formats(FullTypeHints(List(classOf[ClusterFeatures])))\n+\n+  implicit def clusterFeaturesJSONW: JSONW[ClusterFeatures] = new JSONW[ClusterFeatures] {\n+    def write(a: ClusterFeatures) =\n+      makeObj((\"features\" -> toJSON(a.features.map(_.toString).toList))","path":"app/kafka/manager/features/KMFeature.scala","position":21,"original_position":21,"commit_id":"c81882fde16574f36459621a36d73c1686aa2ae1","original_commit_id":"c81882fde16574f36459621a36d73c1686aa2ae1","user":{"login":"jnewman","id":529919,"avatar_url":"https://avatars.githubusercontent.com/u/529919?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewman","html_url":"https://github.com/jnewman","followers_url":"https://api.github.com/users/jnewman/followers","following_url":"https://api.github.com/users/jnewman/following{/other_user}","gists_url":"https://api.github.com/users/jnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewman/subscriptions","organizations_url":"https://api.github.com/users/jnewman/orgs","repos_url":"https://api.github.com/users/jnewman/repos","events_url":"https://api.github.com/users/jnewman/events{/privacy}","received_events_url":"https://api.github.com/users/jnewman/received_events","type":"User","site_admin":false},"body":"Why does this need three `toList`","created_at":"2016-08-04T23:49:55Z","updated_at":"2016-08-04T23:49:55Z","html_url":"https://github.com/krux/kafka-manager/pull/3#discussion_r73622544","pull_request_url":"https://api.github.com/repos/krux/kafka-manager/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/comments/73622544"},"html":{"href":"https://github.com/krux/kafka-manager/pull/3#discussion_r73622544"},"pull_request":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/krux/kafka-manager/pulls/3","id":80120825,"html_url":"https://github.com/krux/kafka-manager/pull/3","diff_url":"https://github.com/krux/kafka-manager/pull/3.diff","patch_url":"https://github.com/krux/kafka-manager/pull/3.patch","issue_url":"https://api.github.com/repos/krux/kafka-manager/issues/3","number":3,"state":"open","locked":false,"title":"Add route for topic identities and change cluster list format","user":{"login":"kelseylam","id":10555857,"avatar_url":"https://avatars.githubusercontent.com/u/10555857?v=3","gravatar_id":"","url":"https://api.github.com/users/kelseylam","html_url":"https://github.com/kelseylam","followers_url":"https://api.github.com/users/kelseylam/followers","following_url":"https://api.github.com/users/kelseylam/following{/other_user}","gists_url":"https://api.github.com/users/kelseylam/gists{/gist_id}","starred_url":"https://api.github.com/users/kelseylam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelseylam/subscriptions","organizations_url":"https://api.github.com/users/kelseylam/orgs","repos_url":"https://api.github.com/users/kelseylam/repos","events_url":"https://api.github.com/users/kelseylam/events{/privacy}","received_events_url":"https://api.github.com/users/kelseylam/received_events","type":"User","site_admin":false},"body":"Added a route and method in KafkaStateCheck to get a list of topic identities for a given cluster. Wrote JSONW write methods for topic identities and related classes to convert them to jsons using toJSON. Changed clusters api call to not query based on status anymore and instead output a list of active clusters and a list of pending clusters. ","created_at":"2016-08-04T17:50:00Z","updated_at":"2016-08-04T23:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc32aa555d7f556e3205bc675f8e9c940e8965c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krux/kafka-manager/pulls/3/commits","review_comments_url":"https://api.github.com/repos/krux/kafka-manager/pulls/3/comments","review_comment_url":"https://api.github.com/repos/krux/kafka-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krux/kafka-manager/issues/3/comments","statuses_url":"https://api.github.com/repos/krux/kafka-manager/statuses/c81882fde16574f36459621a36d73c1686aa2ae1","head":{"label":"krux:topic-identities","ref":"topic-identities","sha":"c81882fde16574f36459621a36d73c1686aa2ae1","user":{"login":"krux","id":72871,"avatar_url":"https://avatars.githubusercontent.com/u/72871?v=3","gravatar_id":"","url":"https://api.github.com/users/krux","html_url":"https://github.com/krux","followers_url":"https://api.github.com/users/krux/followers","following_url":"https://api.github.com/users/krux/following{/other_user}","gists_url":"https://api.github.com/users/krux/gists{/gist_id}","starred_url":"https://api.github.com/users/krux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krux/subscriptions","organizations_url":"https://api.github.com/users/krux/orgs","repos_url":"https://api.github.com/users/krux/repos","events_url":"https://api.github.com/users/krux/events{/privacy}","received_events_url":"https://api.github.com/users/krux/received_events","type":"Organization","site_admin":false},"repo":{"id":30330711,"name":"kafka-manager","full_name":"krux/kafka-manager","owner":{"login":"krux","id":72871,"avatar_url":"https://avatars.githubusercontent.com/u/72871?v=3","gravatar_id":"","url":"https://api.github.com/users/krux","html_url":"https://github.com/krux","followers_url":"https://api.github.com/users/krux/followers","following_url":"https://api.github.com/users/krux/following{/other_user}","gists_url":"https://api.github.com/users/krux/gists{/gist_id}","starred_url":"https://api.github.com/users/krux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krux/subscriptions","organizations_url":"https://api.github.com/users/krux/orgs","repos_url":"https://api.github.com/users/krux/repos","events_url":"https://api.github.com/users/krux/events{/privacy}","received_events_url":"https://api.github.com/users/krux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krux/kafka-manager","description":"A tool for managing Apache Kafka.","fork":true,"url":"https://api.github.com/repos/krux/kafka-manager","forks_url":"https://api.github.com/repos/krux/kafka-manager/forks","keys_url":"https://api.github.com/repos/krux/kafka-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krux/kafka-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krux/kafka-manager/teams","hooks_url":"https://api.github.com/repos/krux/kafka-manager/hooks","issue_events_url":"https://api.github.com/repos/krux/kafka-manager/issues/events{/number}","events_url":"https://api.github.com/repos/krux/kafka-manager/events","assignees_url":"https://api.github.com/repos/krux/kafka-manager/assignees{/user}","branches_url":"https://api.github.com/repos/krux/kafka-manager/branches{/branch}","tags_url":"https://api.github.com/repos/krux/kafka-manager/tags","blobs_url":"https://api.github.com/repos/krux/kafka-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krux/kafka-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krux/kafka-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/krux/kafka-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krux/kafka-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/krux/kafka-manager/languages","stargazers_url":"https://api.github.com/repos/krux/kafka-manager/stargazers","contributors_url":"https://api.github.com/repos/krux/kafka-manager/contributors","subscribers_url":"https://api.github.com/repos/krux/kafka-manager/subscribers","subscription_url":"https://api.github.com/repos/krux/kafka-manager/subscription","commits_url":"https://api.github.com/repos/krux/kafka-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/krux/kafka-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/krux/kafka-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/krux/kafka-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/krux/kafka-manager/contents/{+path}","compare_url":"https://api.github.com/repos/krux/kafka-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krux/kafka-manager/merges","archive_url":"https://api.github.com/repos/krux/kafka-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krux/kafka-manager/downloads","issues_url":"https://api.github.com/repos/krux/kafka-manager/issues{/number}","pulls_url":"https://api.github.com/repos/krux/kafka-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/krux/kafka-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/krux/kafka-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krux/kafka-manager/labels{/name}","releases_url":"https://api.github.com/repos/krux/kafka-manager/releases{/id}","deployments_url":"https://api.github.com/repos/krux/kafka-manager/deployments","created_at":"2015-02-05T01:16:02Z","updated_at":"2016-07-22T21:20:57Z","pushed_at":"2016-08-04T17:50:00Z","git_url":"git://github.com/krux/kafka-manager.git","ssh_url":"git@github.com:krux/kafka-manager.git","clone_url":"https://github.com/krux/kafka-manager.git","svn_url":"https://github.com/krux/kafka-manager","homepage":"","size":2671,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"krux:master","ref":"master","sha":"6527e012b64070e93dafb63dc852e31fb5055858","user":{"login":"krux","id":72871,"avatar_url":"https://avatars.githubusercontent.com/u/72871?v=3","gravatar_id":"","url":"https://api.github.com/users/krux","html_url":"https://github.com/krux","followers_url":"https://api.github.com/users/krux/followers","following_url":"https://api.github.com/users/krux/following{/other_user}","gists_url":"https://api.github.com/users/krux/gists{/gist_id}","starred_url":"https://api.github.com/users/krux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krux/subscriptions","organizations_url":"https://api.github.com/users/krux/orgs","repos_url":"https://api.github.com/users/krux/repos","events_url":"https://api.github.com/users/krux/events{/privacy}","received_events_url":"https://api.github.com/users/krux/received_events","type":"Organization","site_admin":false},"repo":{"id":30330711,"name":"kafka-manager","full_name":"krux/kafka-manager","owner":{"login":"krux","id":72871,"avatar_url":"https://avatars.githubusercontent.com/u/72871?v=3","gravatar_id":"","url":"https://api.github.com/users/krux","html_url":"https://github.com/krux","followers_url":"https://api.github.com/users/krux/followers","following_url":"https://api.github.com/users/krux/following{/other_user}","gists_url":"https://api.github.com/users/krux/gists{/gist_id}","starred_url":"https://api.github.com/users/krux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krux/subscriptions","organizations_url":"https://api.github.com/users/krux/orgs","repos_url":"https://api.github.com/users/krux/repos","events_url":"https://api.github.com/users/krux/events{/privacy}","received_events_url":"https://api.github.com/users/krux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krux/kafka-manager","description":"A tool for managing Apache Kafka.","fork":true,"url":"https://api.github.com/repos/krux/kafka-manager","forks_url":"https://api.github.com/repos/krux/kafka-manager/forks","keys_url":"https://api.github.com/repos/krux/kafka-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krux/kafka-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krux/kafka-manager/teams","hooks_url":"https://api.github.com/repos/krux/kafka-manager/hooks","issue_events_url":"https://api.github.com/repos/krux/kafka-manager/issues/events{/number}","events_url":"https://api.github.com/repos/krux/kafka-manager/events","assignees_url":"https://api.github.com/repos/krux/kafka-manager/assignees{/user}","branches_url":"https://api.github.com/repos/krux/kafka-manager/branches{/branch}","tags_url":"https://api.github.com/repos/krux/kafka-manager/tags","blobs_url":"https://api.github.com/repos/krux/kafka-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krux/kafka-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krux/kafka-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/krux/kafka-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krux/kafka-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/krux/kafka-manager/languages","stargazers_url":"https://api.github.com/repos/krux/kafka-manager/stargazers","contributors_url":"https://api.github.com/repos/krux/kafka-manager/contributors","subscribers_url":"https://api.github.com/repos/krux/kafka-manager/subscribers","subscription_url":"https://api.github.com/repos/krux/kafka-manager/subscription","commits_url":"https://api.github.com/repos/krux/kafka-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/krux/kafka-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/krux/kafka-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/krux/kafka-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/krux/kafka-manager/contents/{+path}","compare_url":"https://api.github.com/repos/krux/kafka-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krux/kafka-manager/merges","archive_url":"https://api.github.com/repos/krux/kafka-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krux/kafka-manager/downloads","issues_url":"https://api.github.com/repos/krux/kafka-manager/issues{/number}","pulls_url":"https://api.github.com/repos/krux/kafka-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/krux/kafka-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/krux/kafka-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krux/kafka-manager/labels{/name}","releases_url":"https://api.github.com/repos/krux/kafka-manager/releases{/id}","deployments_url":"https://api.github.com/repos/krux/kafka-manager/deployments","created_at":"2015-02-05T01:16:02Z","updated_at":"2016-07-22T21:20:57Z","pushed_at":"2016-08-04T17:50:00Z","git_url":"git://github.com/krux/kafka-manager.git","ssh_url":"git@github.com:krux/kafka-manager.git","clone_url":"https://github.com/krux/kafka-manager.git","svn_url":"https://github.com/krux/kafka-manager","homepage":"","size":2671,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/3"},"html":{"href":"https://github.com/krux/kafka-manager/pull/3"},"issue":{"href":"https://api.github.com/repos/krux/kafka-manager/issues/3"},"comments":{"href":"https://api.github.com/repos/krux/kafka-manager/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krux/kafka-manager/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/krux/kafka-manager/statuses/c81882fde16574f36459621a36d73c1686aa2ae1"}}}}
{"actor":{"display_login":"jnewman"}}