{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/9901","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/9901/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/9901/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/9901/events","html_url":"https://github.com/mrdoob/three.js/pull/9901","id":184159960,"number":9901,"title":"Removed outro from Rollup config","user":{"login":"cecilemuller","id":681420,"avatar_url":"https://avatars.githubusercontent.com/u/681420?v=3","gravatar_id":"","url":"https://api.github.com/users/cecilemuller","html_url":"https://github.com/cecilemuller","followers_url":"https://api.github.com/users/cecilemuller/followers","following_url":"https://api.github.com/users/cecilemuller/following{/other_user}","gists_url":"https://api.github.com/users/cecilemuller/gists{/gist_id}","starred_url":"https://api.github.com/users/cecilemuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cecilemuller/subscriptions","organizations_url":"https://api.github.com/users/cecilemuller/orgs","repos_url":"https://api.github.com/users/cecilemuller/repos","events_url":"https://api.github.com/users/cecilemuller/events{/privacy}","received_events_url":"https://api.github.com/users/cecilemuller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-20T08:01:36Z","updated_at":"2016-10-28T20:12:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/9901","html_url":"https://github.com/mrdoob/three.js/pull/9901","diff_url":"https://github.com/mrdoob/three.js/pull/9901.diff","patch_url":"https://github.com/mrdoob/three.js/pull/9901.patch"},"body":"Because it's appended as-is to the bundle, which makes an error at runtime given `exports` is undefined in the ES bundle. However this implies one should use `THREE.getAudioContext()` instead of `THREE.AudioContext`."},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/257016886","html_url":"https://github.com/mrdoob/three.js/pull/9901#issuecomment-257016886","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/9901","id":257016886,"user":{"login":"Rich-Harris","id":1162160,"avatar_url":"https://avatars.githubusercontent.com/u/1162160?v=3","gravatar_id":"","url":"https://api.github.com/users/Rich-Harris","html_url":"https://github.com/Rich-Harris","followers_url":"https://api.github.com/users/Rich-Harris/followers","following_url":"https://api.github.com/users/Rich-Harris/following{/other_user}","gists_url":"https://api.github.com/users/Rich-Harris/gists{/gist_id}","starred_url":"https://api.github.com/users/Rich-Harris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rich-Harris/subscriptions","organizations_url":"https://api.github.com/users/Rich-Harris/orgs","repos_url":"https://api.github.com/users/Rich-Harris/repos","events_url":"https://api.github.com/users/Rich-Harris/events{/privacy}","received_events_url":"https://api.github.com/users/Rich-Harris/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T20:12:05Z","updated_at":"2016-10-28T20:12:05Z","body":"Yep, in an ES6 world, having a named binding that is a getter is sort of incoherent – it'd be like having a variable that didn't initialise until you used it. The point of the workaround was to preserve the behaviour for existing (UMD) users while still allowing the codebase to be modularised. The ES bundle (which wasn't part of that original work) can't have an `AudioContext` export – I think it'll have to have a separate config altogether.\r\n\r\nMy advice from the sidelines would be to export `getAudioContext` and deprecate `THREE.AudioContext` for everyone – still have it in the UMD build to avoid breakage, but start steering people towards `getAudioContext`. That way, when browsers natively support modules (which I believe isn't that far away), Three will be ready."}}
{"actor":{"display_login":"Rich-Harris"}}