{"action":"created","comment":{"url":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments/79456995","id":79456995,"diff_hunk":"@@ -112,18 +114,39 @@ public class AKAUPresetBuilder {\n                 sampleIteration += 1\n             }\n \n-            let startNote = soundDict.objectForKey(startNoteKey)! as! Int\n-            let endNote = soundDict.objectForKey(endNoteKey)! as! Int\n+            \n+            var startNote = soundDict.objectForKey(startNoteKey) as? Int\n+            var endNote = soundDict.objectForKey(endNoteKey) as? Int\n             let rootNote = soundDict.objectForKey(rootNoteKey)! as! Int\n-            let tempSampleZoneXML: String = AKAUPresetBuilder.generateZone(i, rootNote: rootNote, startNote: startNote, endNote: endNote, wavRef: sampleNum)\n+            startNote = (startNote == nil ? rootNote : startNote)\n+            endNote = (endNote == nil ? rootNote : endNote)\n+            let trigModeStr = soundDict.objectForKey(triggerModeKey) as? String\n+            let trigMode : SampleTrigMode\n+            let loopBool = false //in progress\n+            let tempSampleZoneXML: String = AKAUPresetBuilder.generateZone(i, rootNote: rootNote, startNote: startNote!, endNote: endNote!, wavRef: sampleNum, loopEnabled: loopBool)","path":"AudioKit/Common/Nodes/Playback/Sampler/AKAUPresetBuilder.swift","position":27,"original_position":27,"commit_id":"57dfef865f187aea67afaacdf854042b9568f6d5","original_commit_id":"57dfef865f187aea67afaacdf854042b9568f6d5","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line Length Violation: Line should be 100 characters or less: currently 181 characters (line_length)","created_at":"2016-09-19T18:26:53Z","updated_at":"2016-09-19T18:26:53Z","html_url":"https://github.com/audiokit/AudioKit/pull/557#discussion_r79456995","pull_request_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments/79456995"},"html":{"href":"https://github.com/audiokit/AudioKit/pull/557#discussion_r79456995"},"pull_request":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/audiokit/AudioKit/pulls/557","id":85844479,"html_url":"https://github.com/audiokit/AudioKit/pull/557","diff_url":"https://github.com/audiokit/AudioKit/pull/557.diff","patch_url":"https://github.com/audiokit/AudioKit/pull/557.patch","issue_url":"https://api.github.com/repos/audiokit/AudioKit/issues/557","number":557,"state":"open","locked":false,"title":"AUPreset builder minor things","user":{"login":"eljeff","id":4977304,"avatar_url":"https://avatars.githubusercontent.com/u/4977304?v=3","gravatar_id":"","url":"https://api.github.com/users/eljeff","html_url":"https://github.com/eljeff","followers_url":"https://api.github.com/users/eljeff/followers","following_url":"https://api.github.com/users/eljeff/following{/other_user}","gists_url":"https://api.github.com/users/eljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljeff/subscriptions","organizations_url":"https://api.github.com/users/eljeff/orgs","repos_url":"https://api.github.com/users/eljeff/repos","events_url":"https://api.github.com/users/eljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eljeff/received_events","type":"User","site_admin":false},"body":"Added ability to load 'trig modes' into sampler - re-privatised public functions i had used in another project, before updating AUPresetbuilder.","created_at":"2016-09-19T18:26:41Z","updated_at":"2016-09-19T18:26:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/557/commits","review_comments_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/557/comments","review_comment_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/audiokit/AudioKit/issues/557/comments","statuses_url":"https://api.github.com/repos/audiokit/AudioKit/statuses/57dfef865f187aea67afaacdf854042b9568f6d5","head":{"label":"eljeff:develop","ref":"develop","sha":"57dfef865f187aea67afaacdf854042b9568f6d5","user":{"login":"eljeff","id":4977304,"avatar_url":"https://avatars.githubusercontent.com/u/4977304?v=3","gravatar_id":"","url":"https://api.github.com/users/eljeff","html_url":"https://github.com/eljeff","followers_url":"https://api.github.com/users/eljeff/followers","following_url":"https://api.github.com/users/eljeff/following{/other_user}","gists_url":"https://api.github.com/users/eljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljeff/subscriptions","organizations_url":"https://api.github.com/users/eljeff/orgs","repos_url":"https://api.github.com/users/eljeff/repos","events_url":"https://api.github.com/users/eljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eljeff/received_events","type":"User","site_admin":false},"repo":{"id":50607641,"name":"AudioKit","full_name":"eljeff/AudioKit","owner":{"login":"eljeff","id":4977304,"avatar_url":"https://avatars.githubusercontent.com/u/4977304?v=3","gravatar_id":"","url":"https://api.github.com/users/eljeff","html_url":"https://github.com/eljeff","followers_url":"https://api.github.com/users/eljeff/followers","following_url":"https://api.github.com/users/eljeff/following{/other_user}","gists_url":"https://api.github.com/users/eljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljeff/subscriptions","organizations_url":"https://api.github.com/users/eljeff/orgs","repos_url":"https://api.github.com/users/eljeff/repos","events_url":"https://api.github.com/users/eljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eljeff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eljeff/AudioKit","description":"Open-source audio synthesis, processing, & analysis platform.","fork":true,"url":"https://api.github.com/repos/eljeff/AudioKit","forks_url":"https://api.github.com/repos/eljeff/AudioKit/forks","keys_url":"https://api.github.com/repos/eljeff/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eljeff/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eljeff/AudioKit/teams","hooks_url":"https://api.github.com/repos/eljeff/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/eljeff/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/eljeff/AudioKit/events","assignees_url":"https://api.github.com/repos/eljeff/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/eljeff/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/eljeff/AudioKit/tags","blobs_url":"https://api.github.com/repos/eljeff/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eljeff/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eljeff/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/eljeff/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eljeff/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/eljeff/AudioKit/languages","stargazers_url":"https://api.github.com/repos/eljeff/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/eljeff/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/eljeff/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/eljeff/AudioKit/subscription","commits_url":"https://api.github.com/repos/eljeff/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/eljeff/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/eljeff/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/eljeff/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/eljeff/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/eljeff/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eljeff/AudioKit/merges","archive_url":"https://api.github.com/repos/eljeff/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eljeff/AudioKit/downloads","issues_url":"https://api.github.com/repos/eljeff/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/eljeff/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/eljeff/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/eljeff/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eljeff/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/eljeff/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/eljeff/AudioKit/deployments","created_at":"2016-01-28T19:28:22Z","updated_at":"2016-01-28T19:28:25Z","pushed_at":"2016-09-15T20:06:48Z","git_url":"git://github.com/eljeff/AudioKit.git","ssh_url":"git@github.com:eljeff/AudioKit.git","clone_url":"https://github.com/eljeff/AudioKit.git","svn_url":"https://github.com/eljeff/AudioKit","homepage":"http://audiokit.io/","size":178748,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"audiokit:develop","ref":"develop","sha":"6e774b1792ad5dbf6b962f6900d973b7941a7d50","user":{"login":"audiokit","id":6593633,"avatar_url":"https://avatars.githubusercontent.com/u/6593633?v=3","gravatar_id":"","url":"https://api.github.com/users/audiokit","html_url":"https://github.com/audiokit","followers_url":"https://api.github.com/users/audiokit/followers","following_url":"https://api.github.com/users/audiokit/following{/other_user}","gists_url":"https://api.github.com/users/audiokit/gists{/gist_id}","starred_url":"https://api.github.com/users/audiokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audiokit/subscriptions","organizations_url":"https://api.github.com/users/audiokit/orgs","repos_url":"https://api.github.com/users/audiokit/repos","events_url":"https://api.github.com/users/audiokit/events{/privacy}","received_events_url":"https://api.github.com/users/audiokit/received_events","type":"Organization","site_admin":false},"repo":{"id":16096528,"name":"AudioKit","full_name":"audiokit/AudioKit","owner":{"login":"audiokit","id":6593633,"avatar_url":"https://avatars.githubusercontent.com/u/6593633?v=3","gravatar_id":"","url":"https://api.github.com/users/audiokit","html_url":"https://github.com/audiokit","followers_url":"https://api.github.com/users/audiokit/followers","following_url":"https://api.github.com/users/audiokit/following{/other_user}","gists_url":"https://api.github.com/users/audiokit/gists{/gist_id}","starred_url":"https://api.github.com/users/audiokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audiokit/subscriptions","organizations_url":"https://api.github.com/users/audiokit/orgs","repos_url":"https://api.github.com/users/audiokit/repos","events_url":"https://api.github.com/users/audiokit/events{/privacy}","received_events_url":"https://api.github.com/users/audiokit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audiokit/AudioKit","description":"Open-source audio synthesis, processing, & analysis platform.","fork":false,"url":"https://api.github.com/repos/audiokit/AudioKit","forks_url":"https://api.github.com/repos/audiokit/AudioKit/forks","keys_url":"https://api.github.com/repos/audiokit/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audiokit/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audiokit/AudioKit/teams","hooks_url":"https://api.github.com/repos/audiokit/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/audiokit/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/audiokit/AudioKit/events","assignees_url":"https://api.github.com/repos/audiokit/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/audiokit/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/audiokit/AudioKit/tags","blobs_url":"https://api.github.com/repos/audiokit/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audiokit/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audiokit/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/audiokit/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audiokit/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/audiokit/AudioKit/languages","stargazers_url":"https://api.github.com/repos/audiokit/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/audiokit/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/audiokit/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/audiokit/AudioKit/subscription","commits_url":"https://api.github.com/repos/audiokit/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/audiokit/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/audiokit/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/audiokit/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/audiokit/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/audiokit/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audiokit/AudioKit/merges","archive_url":"https://api.github.com/repos/audiokit/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audiokit/AudioKit/downloads","issues_url":"https://api.github.com/repos/audiokit/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/audiokit/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/audiokit/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/audiokit/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audiokit/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/audiokit/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/audiokit/AudioKit/deployments","created_at":"2014-01-21T08:16:07Z","updated_at":"2016-09-19T10:07:26Z","pushed_at":"2016-09-19T18:26:41Z","git_url":"git://github.com/audiokit/AudioKit.git","ssh_url":"git@github.com:audiokit/AudioKit.git","clone_url":"https://github.com/audiokit/AudioKit.git","svn_url":"https://github.com/audiokit/AudioKit","homepage":"http://audiokit.io/","size":185607,"stargazers_count":2441,"watchers_count":2441,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":6,"forks":339,"open_issues":6,"watchers":2441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/557"},"html":{"href":"https://github.com/audiokit/AudioKit/pull/557"},"issue":{"href":"https://api.github.com/repos/audiokit/AudioKit/issues/557"},"comments":{"href":"https://api.github.com/repos/audiokit/AudioKit/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/audiokit/AudioKit/statuses/57dfef865f187aea67afaacdf854042b9568f6d5"}}}}
{"actor":{"display_login":"houndci-bot"}}