{"action":"created","comment":{"url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/comments/72243510","id":72243510,"diff_hunk":"@@ -56,4 +56,8 @@ abstract class Target {\n     def getProp(Map map, defaultValue) {\n         return map.get(\"${identifier}${name}\", map.get(identifier, defaultValue))\n     }\n+\n+    public void resolve() {","path":"buildSrc/src/main/groovy/com/github/okbuilds/core/model/Target.groovy","position":5,"original_position":5,"commit_id":"6c53866f71143b12579340427b9ea826bf53fb92","original_commit_id":"6c53866f71143b12579340427b9ea826bf53fb92","user":{"login":"kageiit","id":291148,"avatar_url":"https://avatars.githubusercontent.com/u/291148?v=3","gravatar_id":"","url":"https://api.github.com/users/kageiit","html_url":"https://github.com/kageiit","followers_url":"https://api.github.com/users/kageiit/followers","following_url":"https://api.github.com/users/kageiit/following{/other_user}","gists_url":"https://api.github.com/users/kageiit/gists{/gist_id}","starred_url":"https://api.github.com/users/kageiit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kageiit/subscriptions","organizations_url":"https://api.github.com/users/kageiit/orgs","repos_url":"https://api.github.com/users/kageiit/repos","events_url":"https://api.github.com/users/kageiit/events{/privacy}","received_events_url":"https://api.github.com/users/kageiit/received_events","type":"User","site_admin":false},"body":"Make this abstract?","created_at":"2016-07-26T13:00:04Z","updated_at":"2016-07-26T13:00:04Z","html_url":"https://github.com/OkBuilds/OkBuck/pull/136#discussion_r72243510","pull_request_url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/comments/72243510"},"html":{"href":"https://github.com/OkBuilds/OkBuck/pull/136#discussion_r72243510"},"pull_request":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136","id":78781727,"html_url":"https://github.com/OkBuilds/OkBuck/pull/136","diff_url":"https://github.com/OkBuilds/OkBuck/pull/136.diff","patch_url":"https://github.com/OkBuilds/OkBuck/pull/136.patch","issue_url":"https://api.github.com/repos/OkBuilds/OkBuck/issues/136","number":136,"state":"open","locked":false,"title":"Extract target dependencies and populate cache before creating rule to make sure all projects are on the same version of dependencies.","user":{"login":"raviagarwal7","id":1913956,"avatar_url":"https://avatars.githubusercontent.com/u/1913956?v=3","gravatar_id":"","url":"https://api.github.com/users/raviagarwal7","html_url":"https://github.com/raviagarwal7","followers_url":"https://api.github.com/users/raviagarwal7/followers","following_url":"https://api.github.com/users/raviagarwal7/following{/other_user}","gists_url":"https://api.github.com/users/raviagarwal7/gists{/gist_id}","starred_url":"https://api.github.com/users/raviagarwal7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raviagarwal7/subscriptions","organizations_url":"https://api.github.com/users/raviagarwal7/orgs","repos_url":"https://api.github.com/users/raviagarwal7/repos","events_url":"https://api.github.com/users/raviagarwal7/events{/privacy}","received_events_url":"https://api.github.com/users/raviagarwal7/received_events","type":"User","site_admin":false},"body":" - Buck file generator goes through each project one by one and to gets all its rules.\r\n - If a rule is created for a project which is very low in (near leaf) in the hierarchy then the resolved dependencies (in the rule) might differ from its parent ones (or from the project in a completely disjoint tree)\r\n - This diff is resolving configuration and extracting dependencies before creating rules.","created_at":"2016-07-26T02:14:11Z","updated_at":"2016-07-26T13:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1594272a09d3d40e7caa6ec6d2a6cf371dbd5c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136/commits","review_comments_url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136/comments","review_comment_url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OkBuilds/OkBuck/issues/136/comments","statuses_url":"https://api.github.com/repos/OkBuilds/OkBuck/statuses/6c53866f71143b12579340427b9ea826bf53fb92","head":{"label":"uber-common:ravi/memoize","ref":"ravi/memoize","sha":"6c53866f71143b12579340427b9ea826bf53fb92","user":{"login":"uber-common","id":14812045,"avatar_url":"https://avatars.githubusercontent.com/u/14812045?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"repo":{"id":60535132,"name":"OkBuck","full_name":"uber-common/OkBuck","owner":{"login":"uber-common","id":14812045,"avatar_url":"https://avatars.githubusercontent.com/u/14812045?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-common/OkBuck","description":"OkBuck is a gradle plugin, aiming to help developers utilize the fast build system: Buck, based on an existing project built using gradle. This plugin lets you have both build systems work side by side.","fork":true,"url":"https://api.github.com/repos/uber-common/OkBuck","forks_url":"https://api.github.com/repos/uber-common/OkBuck/forks","keys_url":"https://api.github.com/repos/uber-common/OkBuck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-common/OkBuck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-common/OkBuck/teams","hooks_url":"https://api.github.com/repos/uber-common/OkBuck/hooks","issue_events_url":"https://api.github.com/repos/uber-common/OkBuck/issues/events{/number}","events_url":"https://api.github.com/repos/uber-common/OkBuck/events","assignees_url":"https://api.github.com/repos/uber-common/OkBuck/assignees{/user}","branches_url":"https://api.github.com/repos/uber-common/OkBuck/branches{/branch}","tags_url":"https://api.github.com/repos/uber-common/OkBuck/tags","blobs_url":"https://api.github.com/repos/uber-common/OkBuck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-common/OkBuck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-common/OkBuck/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-common/OkBuck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-common/OkBuck/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-common/OkBuck/languages","stargazers_url":"https://api.github.com/repos/uber-common/OkBuck/stargazers","contributors_url":"https://api.github.com/repos/uber-common/OkBuck/contributors","subscribers_url":"https://api.github.com/repos/uber-common/OkBuck/subscribers","subscription_url":"https://api.github.com/repos/uber-common/OkBuck/subscription","commits_url":"https://api.github.com/repos/uber-common/OkBuck/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-common/OkBuck/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-common/OkBuck/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-common/OkBuck/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-common/OkBuck/contents/{+path}","compare_url":"https://api.github.com/repos/uber-common/OkBuck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-common/OkBuck/merges","archive_url":"https://api.github.com/repos/uber-common/OkBuck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-common/OkBuck/downloads","issues_url":"https://api.github.com/repos/uber-common/OkBuck/issues{/number}","pulls_url":"https://api.github.com/repos/uber-common/OkBuck/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-common/OkBuck/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-common/OkBuck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-common/OkBuck/labels{/name}","releases_url":"https://api.github.com/repos/uber-common/OkBuck/releases{/id}","deployments_url":"https://api.github.com/repos/uber-common/OkBuck/deployments","created_at":"2016-06-06T14:35:29Z","updated_at":"2016-06-06T14:35:30Z","pushed_at":"2016-07-26T02:50:52Z","git_url":"git://github.com/uber-common/OkBuck.git","ssh_url":"git@github.com:uber-common/OkBuck.git","clone_url":"https://github.com/uber-common/OkBuck.git","svn_url":"https://github.com/uber-common/OkBuck","homepage":"","size":3190,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OkBuilds:master","ref":"master","sha":"aa91a58e5d945dd4fd6401ca4aa76b224bb48117","user":{"login":"OkBuilds","id":19268334,"avatar_url":"https://avatars.githubusercontent.com/u/19268334?v=3","gravatar_id":"","url":"https://api.github.com/users/OkBuilds","html_url":"https://github.com/OkBuilds","followers_url":"https://api.github.com/users/OkBuilds/followers","following_url":"https://api.github.com/users/OkBuilds/following{/other_user}","gists_url":"https://api.github.com/users/OkBuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/OkBuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OkBuilds/subscriptions","organizations_url":"https://api.github.com/users/OkBuilds/orgs","repos_url":"https://api.github.com/users/OkBuilds/repos","events_url":"https://api.github.com/users/OkBuilds/events{/privacy}","received_events_url":"https://api.github.com/users/OkBuilds/received_events","type":"Organization","site_admin":false},"repo":{"id":43598554,"name":"OkBuck","full_name":"OkBuilds/OkBuck","owner":{"login":"OkBuilds","id":19268334,"avatar_url":"https://avatars.githubusercontent.com/u/19268334?v=3","gravatar_id":"","url":"https://api.github.com/users/OkBuilds","html_url":"https://github.com/OkBuilds","followers_url":"https://api.github.com/users/OkBuilds/followers","following_url":"https://api.github.com/users/OkBuilds/following{/other_user}","gists_url":"https://api.github.com/users/OkBuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/OkBuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OkBuilds/subscriptions","organizations_url":"https://api.github.com/users/OkBuilds/orgs","repos_url":"https://api.github.com/users/OkBuilds/repos","events_url":"https://api.github.com/users/OkBuilds/events{/privacy}","received_events_url":"https://api.github.com/users/OkBuilds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OkBuilds/OkBuck","description":"OkBuck is a gradle plugin, aiming to help developers utilize the fast build system: Buck, based on an existing project built using gradle. This plugin lets you have both build systems work side by side.","fork":false,"url":"https://api.github.com/repos/OkBuilds/OkBuck","forks_url":"https://api.github.com/repos/OkBuilds/OkBuck/forks","keys_url":"https://api.github.com/repos/OkBuilds/OkBuck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OkBuilds/OkBuck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OkBuilds/OkBuck/teams","hooks_url":"https://api.github.com/repos/OkBuilds/OkBuck/hooks","issue_events_url":"https://api.github.com/repos/OkBuilds/OkBuck/issues/events{/number}","events_url":"https://api.github.com/repos/OkBuilds/OkBuck/events","assignees_url":"https://api.github.com/repos/OkBuilds/OkBuck/assignees{/user}","branches_url":"https://api.github.com/repos/OkBuilds/OkBuck/branches{/branch}","tags_url":"https://api.github.com/repos/OkBuilds/OkBuck/tags","blobs_url":"https://api.github.com/repos/OkBuilds/OkBuck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OkBuilds/OkBuck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OkBuilds/OkBuck/git/refs{/sha}","trees_url":"https://api.github.com/repos/OkBuilds/OkBuck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OkBuilds/OkBuck/statuses/{sha}","languages_url":"https://api.github.com/repos/OkBuilds/OkBuck/languages","stargazers_url":"https://api.github.com/repos/OkBuilds/OkBuck/stargazers","contributors_url":"https://api.github.com/repos/OkBuilds/OkBuck/contributors","subscribers_url":"https://api.github.com/repos/OkBuilds/OkBuck/subscribers","subscription_url":"https://api.github.com/repos/OkBuilds/OkBuck/subscription","commits_url":"https://api.github.com/repos/OkBuilds/OkBuck/commits{/sha}","git_commits_url":"https://api.github.com/repos/OkBuilds/OkBuck/git/commits{/sha}","comments_url":"https://api.github.com/repos/OkBuilds/OkBuck/comments{/number}","issue_comment_url":"https://api.github.com/repos/OkBuilds/OkBuck/issues/comments{/number}","contents_url":"https://api.github.com/repos/OkBuilds/OkBuck/contents/{+path}","compare_url":"https://api.github.com/repos/OkBuilds/OkBuck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OkBuilds/OkBuck/merges","archive_url":"https://api.github.com/repos/OkBuilds/OkBuck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OkBuilds/OkBuck/downloads","issues_url":"https://api.github.com/repos/OkBuilds/OkBuck/issues{/number}","pulls_url":"https://api.github.com/repos/OkBuilds/OkBuck/pulls{/number}","milestones_url":"https://api.github.com/repos/OkBuilds/OkBuck/milestones{/number}","notifications_url":"https://api.github.com/repos/OkBuilds/OkBuck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OkBuilds/OkBuck/labels{/name}","releases_url":"https://api.github.com/repos/OkBuilds/OkBuck/releases{/id}","deployments_url":"https://api.github.com/repos/OkBuilds/OkBuck/deployments","created_at":"2015-10-03T12:36:22Z","updated_at":"2016-07-26T00:56:46Z","pushed_at":"2016-07-26T02:50:52Z","git_url":"git://github.com/OkBuilds/OkBuck.git","ssh_url":"git@github.com:OkBuilds/OkBuck.git","clone_url":"https://github.com/OkBuilds/OkBuck.git","svn_url":"https://github.com/OkBuilds/OkBuck","homepage":"","size":3181,"stargazers_count":470,"watchers_count":470,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":8,"forks":49,"open_issues":8,"watchers":470,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136"},"html":{"href":"https://github.com/OkBuilds/OkBuck/pull/136"},"issue":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/issues/136"},"comments":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/OkBuilds/OkBuck/statuses/6c53866f71143b12579340427b9ea826bf53fb92"}}}}
{"actor":{"display_login":"kageiit"}}