{"action":"created","comment":{"url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/comments/89148624","pull_request_review_id":9697183,"id":89148624,"diff_hunk":"@@ -0,0 +1,9 @@\n+# Model style\n+\n+```\n+title = models.CharField(\n+    max_length=100,\n+    blank=True,\n+    null=True,","path":"python/models.md","position":7,"original_position":7,"commit_id":"f03c5e0cf04ec2696ee6f9f6b82b1d591fe2c534","original_commit_id":"f03c5e0cf04ec2696ee6f9f6b82b1d591fe2c534","user":{"login":"dan-gamble","id":7152041,"avatar_url":"https://avatars.githubusercontent.com/u/7152041?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-gamble","html_url":"https://github.com/dan-gamble","followers_url":"https://api.github.com/users/dan-gamble/followers","following_url":"https://api.github.com/users/dan-gamble/following{/other_user}","gists_url":"https://api.github.com/users/dan-gamble/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-gamble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-gamble/subscriptions","organizations_url":"https://api.github.com/users/dan-gamble/orgs","repos_url":"https://api.github.com/users/dan-gamble/repos","events_url":"https://api.github.com/users/dan-gamble/events{/privacy}","received_events_url":"https://api.github.com/users/dan-gamble/received_events","type":"User","site_admin":false},"body":"Yea, i understand the reasoning and i do like it for that reason. I'm easy either way tbf i think we should just be consistent across languages.\r\n\r\nSo i'd advise adding a dangling comma to our ESLint","created_at":"2016-11-22T16:04:42Z","updated_at":"2016-11-22T16:04:43Z","html_url":"https://github.com/onespacemedia/osm-styleguide/pull/1#discussion_r89148624","pull_request_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/comments/89148624"},"html":{"href":"https://github.com/onespacemedia/osm-styleguide/pull/1#discussion_r89148624"},"pull_request":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1","id":94842810,"html_url":"https://github.com/onespacemedia/osm-styleguide/pull/1","diff_url":"https://github.com/onespacemedia/osm-styleguide/pull/1.diff","patch_url":"https://github.com/onespacemedia/osm-styleguide/pull/1.patch","issue_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/1","number":1,"state":"open","locked":false,"title":"[WIP][Python] models.py style","user":{"login":"danielsamuels","id":1781176,"avatar_url":"https://avatars.githubusercontent.com/u/1781176?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsamuels","html_url":"https://github.com/danielsamuels","followers_url":"https://api.github.com/users/danielsamuels/followers","following_url":"https://api.github.com/users/danielsamuels/following{/other_user}","gists_url":"https://api.github.com/users/danielsamuels/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsamuels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsamuels/subscriptions","organizations_url":"https://api.github.com/users/danielsamuels/orgs","repos_url":"https://api.github.com/users/danielsamuels/repos","events_url":"https://api.github.com/users/danielsamuels/events{/privacy}","received_events_url":"https://api.github.com/users/danielsamuels/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-22T16:00:56Z","updated_at":"2016-11-22T16:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4ed2de07f93b7a36e155cb4cf08f588b2449b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1/commits","review_comments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1/comments","review_comment_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/1/comments","statuses_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/statuses/f03c5e0cf04ec2696ee6f9f6b82b1d591fe2c534","head":{"label":"onespacemedia:python-models","ref":"python-models","sha":"f03c5e0cf04ec2696ee6f9f6b82b1d591fe2c534","user":{"login":"onespacemedia","id":4577273,"avatar_url":"https://avatars.githubusercontent.com/u/4577273?v=3","gravatar_id":"","url":"https://api.github.com/users/onespacemedia","html_url":"https://github.com/onespacemedia","followers_url":"https://api.github.com/users/onespacemedia/followers","following_url":"https://api.github.com/users/onespacemedia/following{/other_user}","gists_url":"https://api.github.com/users/onespacemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/onespacemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onespacemedia/subscriptions","organizations_url":"https://api.github.com/users/onespacemedia/orgs","repos_url":"https://api.github.com/users/onespacemedia/repos","events_url":"https://api.github.com/users/onespacemedia/events{/privacy}","received_events_url":"https://api.github.com/users/onespacemedia/received_events","type":"Organization","site_admin":false},"repo":{"id":74487217,"name":"osm-styleguide","full_name":"onespacemedia/osm-styleguide","owner":{"login":"onespacemedia","id":4577273,"avatar_url":"https://avatars.githubusercontent.com/u/4577273?v=3","gravatar_id":"","url":"https://api.github.com/users/onespacemedia","html_url":"https://github.com/onespacemedia","followers_url":"https://api.github.com/users/onespacemedia/followers","following_url":"https://api.github.com/users/onespacemedia/following{/other_user}","gists_url":"https://api.github.com/users/onespacemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/onespacemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onespacemedia/subscriptions","organizations_url":"https://api.github.com/users/onespacemedia/orgs","repos_url":"https://api.github.com/users/onespacemedia/repos","events_url":"https://api.github.com/users/onespacemedia/events{/privacy}","received_events_url":"https://api.github.com/users/onespacemedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onespacemedia/osm-styleguide","description":"A styleguide for our HTML / CSS / Javascript / Python code","fork":false,"url":"https://api.github.com/repos/onespacemedia/osm-styleguide","forks_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/forks","keys_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/teams","hooks_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/hooks","issue_events_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/events","assignees_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/tags","blobs_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/languages","stargazers_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/stargazers","contributors_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/contributors","subscribers_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/subscribers","subscription_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/subscription","commits_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/merges","archive_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/downloads","issues_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/deployments","created_at":"2016-11-22T15:39:57Z","updated_at":"2016-11-22T15:39:57Z","pushed_at":"2016-11-22T16:00:56Z","git_url":"git://github.com/onespacemedia/osm-styleguide.git","ssh_url":"git@github.com:onespacemedia/osm-styleguide.git","clone_url":"https://github.com/onespacemedia/osm-styleguide.git","svn_url":"https://github.com/onespacemedia/osm-styleguide","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"onespacemedia:master","ref":"master","sha":"6df5e5c0043490c08b10bc98d2e12c424b1d127b","user":{"login":"onespacemedia","id":4577273,"avatar_url":"https://avatars.githubusercontent.com/u/4577273?v=3","gravatar_id":"","url":"https://api.github.com/users/onespacemedia","html_url":"https://github.com/onespacemedia","followers_url":"https://api.github.com/users/onespacemedia/followers","following_url":"https://api.github.com/users/onespacemedia/following{/other_user}","gists_url":"https://api.github.com/users/onespacemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/onespacemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onespacemedia/subscriptions","organizations_url":"https://api.github.com/users/onespacemedia/orgs","repos_url":"https://api.github.com/users/onespacemedia/repos","events_url":"https://api.github.com/users/onespacemedia/events{/privacy}","received_events_url":"https://api.github.com/users/onespacemedia/received_events","type":"Organization","site_admin":false},"repo":{"id":74487217,"name":"osm-styleguide","full_name":"onespacemedia/osm-styleguide","owner":{"login":"onespacemedia","id":4577273,"avatar_url":"https://avatars.githubusercontent.com/u/4577273?v=3","gravatar_id":"","url":"https://api.github.com/users/onespacemedia","html_url":"https://github.com/onespacemedia","followers_url":"https://api.github.com/users/onespacemedia/followers","following_url":"https://api.github.com/users/onespacemedia/following{/other_user}","gists_url":"https://api.github.com/users/onespacemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/onespacemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onespacemedia/subscriptions","organizations_url":"https://api.github.com/users/onespacemedia/orgs","repos_url":"https://api.github.com/users/onespacemedia/repos","events_url":"https://api.github.com/users/onespacemedia/events{/privacy}","received_events_url":"https://api.github.com/users/onespacemedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onespacemedia/osm-styleguide","description":"A styleguide for our HTML / CSS / Javascript / Python code","fork":false,"url":"https://api.github.com/repos/onespacemedia/osm-styleguide","forks_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/forks","keys_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/teams","hooks_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/hooks","issue_events_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/events","assignees_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/tags","blobs_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/languages","stargazers_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/stargazers","contributors_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/contributors","subscribers_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/subscribers","subscription_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/subscription","commits_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/merges","archive_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/downloads","issues_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/onespacemedia/osm-styleguide/deployments","created_at":"2016-11-22T15:39:57Z","updated_at":"2016-11-22T15:39:57Z","pushed_at":"2016-11-22T16:00:56Z","git_url":"git://github.com/onespacemedia/osm-styleguide.git","ssh_url":"git@github.com:onespacemedia/osm-styleguide.git","clone_url":"https://github.com/onespacemedia/osm-styleguide.git","svn_url":"https://github.com/onespacemedia/osm-styleguide","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1"},"html":{"href":"https://github.com/onespacemedia/osm-styleguide/pull/1"},"issue":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/1"},"comments":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/onespacemedia/osm-styleguide/statuses/f03c5e0cf04ec2696ee6f9f6b82b1d591fe2c534"}}}}
{"actor":{"display_login":"dan-gamble"}}