{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/buck/issues/1018","repository_url":"https://api.github.com/repos/facebook/buck","labels_url":"https://api.github.com/repos/facebook/buck/issues/1018/labels{/name}","comments_url":"https://api.github.com/repos/facebook/buck/issues/1018/comments","events_url":"https://api.github.com/repos/facebook/buck/issues/1018/events","html_url":"https://github.com/facebook/buck/pull/1018","id":189555977,"number":1018,"title":"Update manifest merger","user":{"login":"marcinkwiatkowski","id":737294,"avatar_url":"https://avatars.githubusercontent.com/u/737294?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinkwiatkowski","html_url":"https://github.com/marcinkwiatkowski","followers_url":"https://api.github.com/users/marcinkwiatkowski/followers","following_url":"https://api.github.com/users/marcinkwiatkowski/following{/other_user}","gists_url":"https://api.github.com/users/marcinkwiatkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinkwiatkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinkwiatkowski/subscriptions","organizations_url":"https://api.github.com/users/marcinkwiatkowski/orgs","repos_url":"https://api.github.com/users/marcinkwiatkowski/repos","events_url":"https://api.github.com/users/marcinkwiatkowski/events{/privacy}","received_events_url":"https://api.github.com/users/marcinkwiatkowski/received_events","type":"User","site_admin":false},"labels":[{"id":196857089,"url":"https://api.github.com/repos/facebook/buck/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":213045191,"url":"https://api.github.com/repos/facebook/buck/labels/GH%20Review:%20needs-revision","name":"GH Review: needs-revision","color":"f7c6c7","default":false},{"id":361338223,"url":"https://api.github.com/repos/facebook/buck/labels/Import%20Started","name":"Import Started","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"dreiss","id":4121,"avatar_url":"https://avatars.githubusercontent.com/u/4121?v=3","gravatar_id":"","url":"https://api.github.com/users/dreiss","html_url":"https://github.com/dreiss","followers_url":"https://api.github.com/users/dreiss/followers","following_url":"https://api.github.com/users/dreiss/following{/other_user}","gists_url":"https://api.github.com/users/dreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/dreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreiss/subscriptions","organizations_url":"https://api.github.com/users/dreiss/orgs","repos_url":"https://api.github.com/users/dreiss/repos","events_url":"https://api.github.com/users/dreiss/events{/privacy}","received_events_url":"https://api.github.com/users/dreiss/received_events","type":"User","site_admin":false},"assignees":[{"login":"dreiss","id":4121,"avatar_url":"https://avatars.githubusercontent.com/u/4121?v=3","gravatar_id":"","url":"https://api.github.com/users/dreiss","html_url":"https://github.com/dreiss","followers_url":"https://api.github.com/users/dreiss/followers","following_url":"https://api.github.com/users/dreiss/following{/other_user}","gists_url":"https://api.github.com/users/dreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/dreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreiss/subscriptions","organizations_url":"https://api.github.com/users/dreiss/orgs","repos_url":"https://api.github.com/users/dreiss/repos","events_url":"https://api.github.com/users/dreiss/events{/privacy}","received_events_url":"https://api.github.com/users/dreiss/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2016-11-16T01:21:04Z","updated_at":"2016-12-05T23:24:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/1018","html_url":"https://github.com/facebook/buck/pull/1018","diff_url":"https://github.com/facebook/buck/pull/1018.diff","patch_url":"https://github.com/facebook/buck/pull/1018.patch"},"body":"This switches to `ManifestMerger2` implementation and fixes https://github.com/facebook/buck/issues/299\r\n\r\nMajority of this PR is updating aosp to `25.2.0` version of the tools.\r\n\r\nThe only interesting change is in `GenerateManifestStep.java`.\r\n\r\nFor the sake of not maintaining two versions of aosp, this PR replaces old `ManifestMerger` with `ManifestMerger2`. Having both is possible (we could take `ManifestMerger` from tools `24.x.x`, the last version that shipped with it) but if the new merger works for everyone, probably best to just go with that."},"comment":{"url":"https://api.github.com/repos/facebook/buck/issues/comments/265011216","html_url":"https://github.com/facebook/buck/pull/1018#issuecomment-265011216","issue_url":"https://api.github.com/repos/facebook/buck/issues/1018","id":265011216,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T23:24:06Z","updated_at":"2016-12-05T23:24:06Z","body":"@marcinkwiatkowski updated the pull request - [view changes](https://github.com/facebook/buck/pull/1018/files/e4d9021eb7bf72f015e628521a03b0e075bc227f..42d54f5471cfbf12cc83b77292bdaf7066cdbb19) - [changes since last import](https://github.com/facebook/buck/pull/1018/files/e4d9021eb7bf72f015e628521a03b0e075bc227f..42d54f5471cfbf12cc83b77292bdaf7066cdbb19)"}}
{"actor":{"display_login":"facebook-github-bot"}}