{"action":"created","issue":{"url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/23","labels_url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/23/comments","events_url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/23/events","html_url":"https://github.com/mharris717/ember-drag-drop/pull/23","id":125646090,"number":23,"title":"Rewritten drag coordinator","user":{"login":"njjkgeerts","id":504749,"avatar_url":"https://avatars.githubusercontent.com/u/504749?v=3","gravatar_id":"","url":"https://api.github.com/users/njjkgeerts","html_url":"https://github.com/njjkgeerts","followers_url":"https://api.github.com/users/njjkgeerts/followers","following_url":"https://api.github.com/users/njjkgeerts/following{/other_user}","gists_url":"https://api.github.com/users/njjkgeerts/gists{/gist_id}","starred_url":"https://api.github.com/users/njjkgeerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjkgeerts/subscriptions","organizations_url":"https://api.github.com/users/njjkgeerts/orgs","repos_url":"https://api.github.com/users/njjkgeerts/repos","events_url":"https://api.github.com/users/njjkgeerts/events{/privacy}","received_events_url":"https://api.github.com/users/njjkgeerts/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-08T16:40:43Z","updated_at":"2016-01-10T18:53:37Z","closed_at":"2016-01-10T18:53:37Z","pull_request":{"url":"https://api.github.com/repos/mharris717/ember-drag-drop/pulls/23","html_url":"https://github.com/mharris717/ember-drag-drop/pull/23","diff_url":"https://github.com/mharris717/ember-drag-drop/pull/23.diff","patch_url":"https://github.com/mharris717/ember-drag-drop/pull/23.patch"},"body":"I have rewritten the drag coordinator. There were two problems I encountered with the original one. \r\n\r\n1. The DOM manipulation (by swapNodes) confused the Ember DOM view. This resulted in unexpected behaviour in the sorting. In this new version, the DOM manipulation is entirely done through Ember, since it simply modifies the list.\r\n2. Grid based layouts were not supported because of the algorithm used: it swapped positions of the dragged over elements. This only works in linear sets such as lists. In this new version, it simply insert the element at the position of the dragged over element.\r\n\r\nPlease feel free to give me feedback if this commit is not according to your wishes. I now successfully use this version in a production app of a startup company. "},"comment":{"url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/comments/170381735","html_url":"https://github.com/mharris717/ember-drag-drop/pull/23#issuecomment-170381735","issue_url":"https://api.github.com/repos/mharris717/ember-drag-drop/issues/23","id":170381735,"user":{"login":"dgavey","id":755589,"avatar_url":"https://avatars.githubusercontent.com/u/755589?v=3","gravatar_id":"","url":"https://api.github.com/users/dgavey","html_url":"https://github.com/dgavey","followers_url":"https://api.github.com/users/dgavey/followers","following_url":"https://api.github.com/users/dgavey/following{/other_user}","gists_url":"https://api.github.com/users/dgavey/gists{/gist_id}","starred_url":"https://api.github.com/users/dgavey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgavey/subscriptions","organizations_url":"https://api.github.com/users/dgavey/orgs","repos_url":"https://api.github.com/users/dgavey/repos","events_url":"https://api.github.com/users/dgavey/events{/privacy}","received_events_url":"https://api.github.com/users/dgavey/received_events","type":"User","site_admin":false},"created_at":"2016-01-10T18:53:37Z","updated_at":"2016-01-10T18:53:37Z","body":"Thanks for the pull request, I was unable to use it, as I had this basically refactored the code similarly recently.  It has been published under 0.3.0, it would work fine for you. Let me know if it doesn't"}}