{"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/dblock/danger-changelog/pulls/17","id":94527322,"html_url":"https://github.com/dblock/danger-changelog/pull/17","diff_url":"https://github.com/dblock/danger-changelog/pull/17.diff","patch_url":"https://github.com/dblock/danger-changelog/pull/17.patch","issue_url":"https://api.github.com/repos/dblock/danger-changelog/issues/17","number":17,"state":"open","locked":false,"title":"Handle hash instead of star as invalid changelog line;","user":{"login":"Antondomashnev","id":2076088,"avatar_url":"https://avatars.githubusercontent.com/u/2076088?v=3","gravatar_id":"","url":"https://api.github.com/users/Antondomashnev","html_url":"https://github.com/Antondomashnev","followers_url":"https://api.github.com/users/Antondomashnev/followers","following_url":"https://api.github.com/users/Antondomashnev/following{/other_user}","gists_url":"https://api.github.com/users/Antondomashnev/gists{/gist_id}","starred_url":"https://api.github.com/users/Antondomashnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antondomashnev/subscriptions","organizations_url":"https://api.github.com/users/Antondomashnev/orgs","repos_url":"https://api.github.com/users/Antondomashnev/repos","events_url":"https://api.github.com/users/Antondomashnev/events{/privacy}","received_events_url":"https://api.github.com/users/Antondomashnev/received_events","type":"User","site_admin":false},"body":"This PR addresses the issue #16 \r\n\r\n@dblock I have doubts about the method name I've chosen to check if the changelog line almost looks like changelog line 😄 \r\n```ruby\r\nDanger::Changelog::ChangelogLine.changelog_line?(line)\r\n```\r\n\r\nI also have one idea how to refactor the code a bit:  \r\nIf the `Danger::Changelog::ChangelogLine` can be initialized with a `line` and that it can have a type: `[\"you_contribution\", \"header\", \"changelog\"]` and depending on the `type`, it can be validated properly. So eventually it moves all logic about validation inside one class `Danger::Changelog::ChangelogLine`, instead of two currently. @dblock what do you think?","created_at":"2016-11-20T18:34:39Z","updated_at":"2016-11-20T18:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dblock/danger-changelog/pulls/17/commits","review_comments_url":"https://api.github.com/repos/dblock/danger-changelog/pulls/17/comments","review_comment_url":"https://api.github.com/repos/dblock/danger-changelog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dblock/danger-changelog/issues/17/comments","statuses_url":"https://api.github.com/repos/dblock/danger-changelog/statuses/886994af4824759db6f495ac85e4e6f985d289b5","head":{"label":"Antondomashnev:antondomashnev/validation_improvement","ref":"antondomashnev/validation_improvement","sha":"886994af4824759db6f495ac85e4e6f985d289b5","user":{"login":"Antondomashnev","id":2076088,"avatar_url":"https://avatars.githubusercontent.com/u/2076088?v=3","gravatar_id":"","url":"https://api.github.com/users/Antondomashnev","html_url":"https://github.com/Antondomashnev","followers_url":"https://api.github.com/users/Antondomashnev/followers","following_url":"https://api.github.com/users/Antondomashnev/following{/other_user}","gists_url":"https://api.github.com/users/Antondomashnev/gists{/gist_id}","starred_url":"https://api.github.com/users/Antondomashnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antondomashnev/subscriptions","organizations_url":"https://api.github.com/users/Antondomashnev/orgs","repos_url":"https://api.github.com/users/Antondomashnev/repos","events_url":"https://api.github.com/users/Antondomashnev/events{/privacy}","received_events_url":"https://api.github.com/users/Antondomashnev/received_events","type":"User","site_admin":false},"repo":{"id":74230337,"name":"danger-changelog","full_name":"Antondomashnev/danger-changelog","owner":{"login":"Antondomashnev","id":2076088,"avatar_url":"https://avatars.githubusercontent.com/u/2076088?v=3","gravatar_id":"","url":"https://api.github.com/users/Antondomashnev","html_url":"https://github.com/Antondomashnev","followers_url":"https://api.github.com/users/Antondomashnev/followers","following_url":"https://api.github.com/users/Antondomashnev/following{/other_user}","gists_url":"https://api.github.com/users/Antondomashnev/gists{/gist_id}","starred_url":"https://api.github.com/users/Antondomashnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antondomashnev/subscriptions","organizations_url":"https://api.github.com/users/Antondomashnev/orgs","repos_url":"https://api.github.com/users/Antondomashnev/repos","events_url":"https://api.github.com/users/Antondomashnev/events{/privacy}","received_events_url":"https://api.github.com/users/Antondomashnev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Antondomashnev/danger-changelog","description":"A plugin that is OCD about your CHANGELOG format.","fork":true,"url":"https://api.github.com/repos/Antondomashnev/danger-changelog","forks_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/forks","keys_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/teams","hooks_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/hooks","issue_events_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/issues/events{/number}","events_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/events","assignees_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/assignees{/user}","branches_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/branches{/branch}","tags_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/tags","blobs_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/statuses/{sha}","languages_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/languages","stargazers_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/stargazers","contributors_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/contributors","subscribers_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/subscribers","subscription_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/subscription","commits_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/contents/{+path}","compare_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/merges","archive_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/downloads","issues_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/issues{/number}","pulls_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/pulls{/number}","milestones_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/milestones{/number}","notifications_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/labels{/name}","releases_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/releases{/id}","deployments_url":"https://api.github.com/repos/Antondomashnev/danger-changelog/deployments","created_at":"2016-11-19T19:26:06Z","updated_at":"2016-11-19T19:26:08Z","pushed_at":"2016-11-20T18:28:51Z","git_url":"git://github.com/Antondomashnev/danger-changelog.git","ssh_url":"git@github.com:Antondomashnev/danger-changelog.git","clone_url":"https://github.com/Antondomashnev/danger-changelog.git","svn_url":"https://github.com/Antondomashnev/danger-changelog","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dblock:master","ref":"master","sha":"574ed09e11198403c15e4b4c17dda9f5499eac3a","user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"repo":{"id":66667678,"name":"danger-changelog","full_name":"dblock/danger-changelog","owner":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dblock/danger-changelog","description":"A plugin that is OCD about your CHANGELOG format.","fork":false,"url":"https://api.github.com/repos/dblock/danger-changelog","forks_url":"https://api.github.com/repos/dblock/danger-changelog/forks","keys_url":"https://api.github.com/repos/dblock/danger-changelog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dblock/danger-changelog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dblock/danger-changelog/teams","hooks_url":"https://api.github.com/repos/dblock/danger-changelog/hooks","issue_events_url":"https://api.github.com/repos/dblock/danger-changelog/issues/events{/number}","events_url":"https://api.github.com/repos/dblock/danger-changelog/events","assignees_url":"https://api.github.com/repos/dblock/danger-changelog/assignees{/user}","branches_url":"https://api.github.com/repos/dblock/danger-changelog/branches{/branch}","tags_url":"https://api.github.com/repos/dblock/danger-changelog/tags","blobs_url":"https://api.github.com/repos/dblock/danger-changelog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dblock/danger-changelog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dblock/danger-changelog/git/refs{/sha}","trees_url":"https://api.github.com/repos/dblock/danger-changelog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dblock/danger-changelog/statuses/{sha}","languages_url":"https://api.github.com/repos/dblock/danger-changelog/languages","stargazers_url":"https://api.github.com/repos/dblock/danger-changelog/stargazers","contributors_url":"https://api.github.com/repos/dblock/danger-changelog/contributors","subscribers_url":"https://api.github.com/repos/dblock/danger-changelog/subscribers","subscription_url":"https://api.github.com/repos/dblock/danger-changelog/subscription","commits_url":"https://api.github.com/repos/dblock/danger-changelog/commits{/sha}","git_commits_url":"https://api.github.com/repos/dblock/danger-changelog/git/commits{/sha}","comments_url":"https://api.github.com/repos/dblock/danger-changelog/comments{/number}","issue_comment_url":"https://api.github.com/repos/dblock/danger-changelog/issues/comments{/number}","contents_url":"https://api.github.com/repos/dblock/danger-changelog/contents/{+path}","compare_url":"https://api.github.com/repos/dblock/danger-changelog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dblock/danger-changelog/merges","archive_url":"https://api.github.com/repos/dblock/danger-changelog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dblock/danger-changelog/downloads","issues_url":"https://api.github.com/repos/dblock/danger-changelog/issues{/number}","pulls_url":"https://api.github.com/repos/dblock/danger-changelog/pulls{/number}","milestones_url":"https://api.github.com/repos/dblock/danger-changelog/milestones{/number}","notifications_url":"https://api.github.com/repos/dblock/danger-changelog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dblock/danger-changelog/labels{/name}","releases_url":"https://api.github.com/repos/dblock/danger-changelog/releases{/id}","deployments_url":"https://api.github.com/repos/dblock/danger-changelog/deployments","created_at":"2016-08-26T17:46:08Z","updated_at":"2016-10-25T14:25:28Z","pushed_at":"2016-09-26T21:16:42Z","git_url":"git://github.com/dblock/danger-changelog.git","ssh_url":"git@github.com:dblock/danger-changelog.git","clone_url":"https://github.com/dblock/danger-changelog.git","svn_url":"https://github.com/dblock/danger-changelog","homepage":null,"size":120,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dblock/danger-changelog/pulls/17"},"html":{"href":"https://github.com/dblock/danger-changelog/pull/17"},"issue":{"href":"https://api.github.com/repos/dblock/danger-changelog/issues/17"},"comments":{"href":"https://api.github.com/repos/dblock/danger-changelog/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/dblock/danger-changelog/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/dblock/danger-changelog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dblock/danger-changelog/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/dblock/danger-changelog/statuses/886994af4824759db6f495ac85e4e6f985d289b5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":4,"changed_files":6}}
{"actor":{"display_login":"Antondomashnev"}}