{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/comments/90786295","pull_request_review_id":11302203,"id":90786295,"diff_hunk":"@@ -83,9 +83,16 @@ public function extractManipulationWriteState(&$writes)\n                 continue;\n             }\n \n+            if (isset($write['fields']['SiteTree:SubsiteID'])) {","path":"code/search/SearchVariantSubsites.php","position":4,"original_position":4,"commit_id":"d318ff793b2078f533680b791c51d6f258ee6ae4","original_commit_id":"d318ff793b2078f533680b791c51d6f258ee6ae4","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"Yes but files in subsiteid = 3 shouldn't be.\r\n\r\nIf they are global, they must be indexed in EVERY subsite, not only once.","created_at":"2016-12-04T21:13:49Z","updated_at":"2016-12-04T21:13:49Z","html_url":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131#discussion_r90786295","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/comments/90786295"},"html":{"href":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131#discussion_r90786295"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131","id":96285475,"html_url":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131","diff_url":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131.diff","patch_url":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/131","number":131,"state":"open","locked":false,"title":"FIX Regression where pages would be indexed under all subsites","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-02T14:09:08Z","updated_at":"2016-12-04T21:13:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23cc397762068af93af1c96996217fa296277298","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/131/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/statuses/d318ff793b2078f533680b791c51d6f258ee6ae4","head":{"label":"dhensby:pulls/2.2/fix-subsite-regression","ref":"pulls/2.2/fix-subsite-regression","sha":"d318ff793b2078f533680b791c51d6f258ee6ae4","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"repo":{"id":52321432,"name":"silverstripe-fulltextsearch","full_name":"dhensby/silverstripe-fulltextsearch","owner":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhensby/silverstripe-fulltextsearch","description":"Adds external full text search engine support to SilverStripe","fork":true,"url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch","forks_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/forks","keys_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/teams","hooks_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/hooks","issue_events_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/issues/events{/number}","events_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/events","assignees_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/assignees{/user}","branches_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/branches{/branch}","tags_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/tags","blobs_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/languages","stargazers_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/stargazers","contributors_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/contributors","subscribers_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/subscribers","subscription_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/subscription","commits_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/contents/{+path}","compare_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/merges","archive_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/downloads","issues_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/issues{/number}","pulls_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/labels{/name}","releases_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/releases{/id}","deployments_url":"https://api.github.com/repos/dhensby/silverstripe-fulltextsearch/deployments","created_at":"2016-02-23T01:58:51Z","updated_at":"2016-02-23T01:58:51Z","pushed_at":"2016-12-02T14:08:55Z","git_url":"git://github.com/dhensby/silverstripe-fulltextsearch.git","ssh_url":"git@github.com:dhensby/silverstripe-fulltextsearch.git","clone_url":"https://github.com/dhensby/silverstripe-fulltextsearch.git","svn_url":"https://github.com/dhensby/silverstripe-fulltextsearch","homepage":"","size":12459,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"190f4cb683f1893cb3a78af7d123139762b62af6","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1673985,"name":"silverstripe-fulltextsearch","full_name":"silverstripe/silverstripe-fulltextsearch","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-fulltextsearch","description":"Adds external full text search engine support to SilverStripe","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/deployments","created_at":"2011-04-28T03:21:06Z","updated_at":"2016-11-04T14:55:50Z","pushed_at":"2016-12-02T14:09:09Z","git_url":"git://github.com/silverstripe/silverstripe-fulltextsearch.git","ssh_url":"git@github.com:silverstripe/silverstripe-fulltextsearch.git","clone_url":"https://github.com/silverstripe/silverstripe-fulltextsearch.git","svn_url":"https://github.com/silverstripe/silverstripe-fulltextsearch","homepage":"","size":12617,"stargazers_count":29,"watchers_count":29,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":28,"forks":39,"open_issues":28,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131"},"html":{"href":"https://github.com/silverstripe/silverstripe-fulltextsearch/pull/131"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/131"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-fulltextsearch/statuses/d318ff793b2078f533680b791c51d6f258ee6ae4"}}}}
{"actor":{"display_login":"tractorcow"}}