{"action":"created","issue":{"url":"https://api.github.com/repos/flux-framework/flux-core/issues/835","repository_url":"https://api.github.com/repos/flux-framework/flux-core","labels_url":"https://api.github.com/repos/flux-framework/flux-core/issues/835/labels{/name}","comments_url":"https://api.github.com/repos/flux-framework/flux-core/issues/835/comments","events_url":"https://api.github.com/repos/flux-framework/flux-core/issues/835/events","html_url":"https://github.com/flux-framework/flux-core/pull/835","id":181550235,"number":835,"title":"pull in json-c","user":{"login":"garlick","id":169947,"avatar_url":"https://avatars.githubusercontent.com/u/169947?v=3","gravatar_id":"","url":"https://api.github.com/users/garlick","html_url":"https://github.com/garlick","followers_url":"https://api.github.com/users/garlick/followers","following_url":"https://api.github.com/users/garlick/following{/other_user}","gists_url":"https://api.github.com/users/garlick/gists{/gist_id}","starred_url":"https://api.github.com/users/garlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garlick/subscriptions","organizations_url":"https://api.github.com/users/garlick/orgs","repos_url":"https://api.github.com/users/garlick/repos","events_url":"https://api.github.com/users/garlick/events{/privacy}","received_events_url":"https://api.github.com/users/garlick/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flux-framework/flux-core/labels/review","name":"review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-06T23:28:27Z","updated_at":"2016-10-06T23:31:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flux-framework/flux-core/pulls/835","html_url":"https://github.com/flux-framework/flux-core/pull/835","diff_url":"https://github.com/flux-framework/flux-core/pull/835.diff","patch_url":"https://github.com/flux-framework/flux-core/pull/835.patch"},"body":"This PR is the missing piece that would have allowed #319, an attempt to convert part of the project to the [jansson](http://www.digip.org/jansson/), to have been completed.  It pulls in a copy of the json-c library and renames all of its public symbols to have have a `json_c_` prefix.  The library is built as part of `libflux-internal.la`.  Any part of flux-core can now dump json-c simply by dropping its include of `src/common/libjson-c/json.h` or `src/common/libutil/shortjson.h`.\r\n\r\nIf this approach is acceptable, next I'd like to revisit bringing back the really cool formatted rpc functions that were parked in #319.\r\n\r\nNote to flux-sched: this doesn't affect external interfaces, and you can still track `shortjson.h` as the only change to it here is to include json.h via a different path.\r\n\r\nNote on tests: I did add a small TAP test here but I did not pull in the tests that ship with json-c.  We could do that but it will take some work and I didn't feel it was justified here, given that json-c releases are pretty well tested."},"comment":{"url":"https://api.github.com/repos/flux-framework/flux-core/issues/comments/252116928","html_url":"https://github.com/flux-framework/flux-core/pull/835#issuecomment-252116928","issue_url":"https://api.github.com/repos/flux-framework/flux-core/issues/835","id":252116928,"user":{"login":"lipari","id":740218,"avatar_url":"https://avatars.githubusercontent.com/u/740218?v=3","gravatar_id":"","url":"https://api.github.com/users/lipari","html_url":"https://github.com/lipari","followers_url":"https://api.github.com/users/lipari/followers","following_url":"https://api.github.com/users/lipari/following{/other_user}","gists_url":"https://api.github.com/users/lipari/gists{/gist_id}","starred_url":"https://api.github.com/users/lipari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipari/subscriptions","organizations_url":"https://api.github.com/users/lipari/orgs","repos_url":"https://api.github.com/users/lipari/repos","events_url":"https://api.github.com/users/lipari/events{/privacy}","received_events_url":"https://api.github.com/users/lipari/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T23:31:53Z","updated_at":"2016-10-06T23:31:53Z","body":"> Note to flux-sched: this doesn't affect external interfaces, and you can still track shortjson.h as the only change to it here is to include json.h via a different path.\r\n\r\n@garlick, this sounds like something sched is going to want to adopt if we are to maintain as much consistency with the flux-core as possible.  Do you agree?"}}
{"actor":{"display_login":"lipari"}}