{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/core-docs/issues/871","repository_url":"https://api.github.com/repos/dotnet/core-docs","labels_url":"https://api.github.com/repos/dotnet/core-docs/issues/871/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/core-docs/issues/871/comments","events_url":"https://api.github.com/repos/dotnet/core-docs/issues/871/events","html_url":"https://github.com/dotnet/core-docs/issues/871","id":169456940,"number":871,"title":"Samples Directory needs to separate build environments","user":{"login":"BillWagner","id":493969,"avatar_url":"https://avatars.githubusercontent.com/u/493969?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-04T19:42:09Z","updated_at":"2016-08-04T22:17:30Z","closed_at":null,"body":"We discovered this while working on PR #870 \r\n\r\nA few of our samples require the full framework. That's fine, because they cover migrating from the full framework to Core, or supporting both (see here: https://docs.microsoft.com/en-us/dotnet/articles/core/porting/project-structure)\r\n\r\nWe need a project structure that enables the CI build server to build the right set of samples in the correct configuration. This is a matrix that comprises .NET products (.NET Core, .NET Standard, Full .NET Framework), and platforms (Windows, Linux, MacOS). Some Core projects may have a native dependency, because they explain how to create those kinds of projects.\r\n\r\nThis structure is further complicated by our current structure, which organizes samples based on content: C# samples, F# samples, .NET Core samples, and so on.\r\n\r\nI believe all language samples (C# and F#) should build on all platforms. @cartermp can verify for F#. (I will verify for C#).\r\n\r\nCore samples probably should all build on all supported Core platforms.  \r\n\r\nThe interesting ones now are those that discuss the full .NET framework, or how to migrate from the full framework to Core.  They are listed at the end of this issue.  \r\n\r\n# Proposal\r\n\r\nWe'll make a new directory for samples that are meant to build on the full framework only. This should be `/samples/full-framework`. This will include any code that discusses migration to core, or supporting the full framework as a development environment.\r\n\r\nIn the future, we can add sub-directories for other environments when this repository adds samples specific to those environments (for example, Xamarin projects, Windows client frameworks, and so on).\r\n\r\n**Samples Affected**\r\n\r\nSamples that do not build on Ubuntu (by design) are:\r\n\r\n/samples/core-projects/libraries/frameworks-library\r\n/samples/core-projects/libraries/migrate-library\r\n/samples/core-projects/libraries/migrate-library-pcl\r\n/samples/core-projects/libraries/migrate-library-xproj\r\n/samples/core-projects/libraries/migrate-library-xproj-keep-csproj\r\n\r\nThese should all move to the new /samples/full-framework directory.\r\n\r\nThe topics that reference those samples must have all links updated when the samples move.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/core-docs/issues/comments/237700368","html_url":"https://github.com/dotnet/core-docs/issues/871#issuecomment-237700368","issue_url":"https://api.github.com/repos/dotnet/core-docs/issues/871","id":237700368,"user":{"login":"richlander","id":2608468,"avatar_url":"https://avatars.githubusercontent.com/u/2608468?v=3","gravatar_id":"","url":"https://api.github.com/users/richlander","html_url":"https://github.com/richlander","followers_url":"https://api.github.com/users/richlander/followers","following_url":"https://api.github.com/users/richlander/following{/other_user}","gists_url":"https://api.github.com/users/richlander/gists{/gist_id}","starred_url":"https://api.github.com/users/richlander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richlander/subscriptions","organizations_url":"https://api.github.com/users/richlander/orgs","repos_url":"https://api.github.com/users/richlander/repos","events_url":"https://api.github.com/users/richlander/events{/privacy}","received_events_url":"https://api.github.com/users/richlander/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T22:17:30Z","updated_at":"2016-08-04T22:17:30Z","body":"I think there are two good models:\r\n\r\n- Match the guide name.\r\n- Match the NuGet short name (no version).\r\n\r\nIf we look at Xamarin, it won't just be Xamarin, but Xamarin Android and Xamarin iOS (and others). If we keep that in mind, then the NuGet name is the best, IMO."}}
{"actor":{"display_login":"richlander"}}