{"action":"closed","number":157,"pull_request":{"url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157","id":74815905,"html_url":"https://github.com/orocos-toolchain/rtt/pull/157","diff_url":"https://github.com/orocos-toolchain/rtt/pull/157.diff","patch_url":"https://github.com/orocos-toolchain/rtt/pull/157.patch","issue_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/157","number":157,"state":"closed","locked":false,"title":"useorocos: fix RPATH issues when linking to ocl or 3rd-party libraries","user":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"body":"This PR restores the INSTALL_RPATH behavior of RTT version 2.7 and before, where all directories in the linker's search path have been added to the INSTALL_RPATH of a target. #51 and #79 introduced DESTDIR support (installation in stage dir), where the locations of the libraries at link time is not necessarily the same as the installed location.\r\n\r\nIn all cases where OROCOS targets link to other libraries which are not installed in a directory within the default search path and without the `orocos_use_package()` macro, these patches broke dynamic linking without special care in the user's cmake code.\r\n\r\nExample:\r\n```cmake\r\nfind_package(OROCOS-OCL REQUIRED COMPONENTS ocl-logging ocl-timer)\r\n\r\norocos_component(foo foo.cpp)\r\ntarget_link_libraries(foo ${OROCOS-OCL_OCL-LOGGING_LIBRARIES} ${OROCOS-OCL_OCL-TIMER_LIBRARIES})\r\n```\r\nThe INSTALL_RPATH of `libfoo.so` would not contain the ocl library dir `<prefix>/lib/orocos/<target>/ocl`.\r\n\r\nBoth commits, b4ad7f9 and 15970d7 solve this issue in different ways. Commit c07b81b is already in master and only has been cherry-picked to this branch for testing and to avoid later merge conflicts.\r\n\r\nIt should be noted that\r\n```cmake\r\norocos_use_package(ocl-logging)\r\norocos_use_package(ocl-timer)\r\norocos_component(foo foo.cpp)\r\n```\r\nis the recommended way to link OROCOS targets to libraries in OCL (or other OROCOS packages) which is not affected by RPATH issues.","created_at":"2016-06-22T16:30:47Z","updated_at":"2016-08-10T15:19:51Z","closed_at":"2016-08-10T15:19:51Z","merged_at":"2016-08-10T15:19:50Z","merge_commit_sha":"7daf55526bef7851e42e5a0e6dd612828e3a3757","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157/commits","review_comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157/comments","review_comment_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/157/comments","statuses_url":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/15970d74d3c1b8472872ed122e4fcf8ff7f9389b","head":{"label":"meyerj:install-rpath-fixes","ref":"install-rpath-fixes","sha":"15970d74d3c1b8472872ed122e4fcf8ff7f9389b","user":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"repo":{"id":13614656,"name":"rtt","full_name":"meyerj/rtt","owner":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meyerj/rtt","description":"Real-Time Toolkit","fork":true,"url":"https://api.github.com/repos/meyerj/rtt","forks_url":"https://api.github.com/repos/meyerj/rtt/forks","keys_url":"https://api.github.com/repos/meyerj/rtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meyerj/rtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meyerj/rtt/teams","hooks_url":"https://api.github.com/repos/meyerj/rtt/hooks","issue_events_url":"https://api.github.com/repos/meyerj/rtt/issues/events{/number}","events_url":"https://api.github.com/repos/meyerj/rtt/events","assignees_url":"https://api.github.com/repos/meyerj/rtt/assignees{/user}","branches_url":"https://api.github.com/repos/meyerj/rtt/branches{/branch}","tags_url":"https://api.github.com/repos/meyerj/rtt/tags","blobs_url":"https://api.github.com/repos/meyerj/rtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meyerj/rtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meyerj/rtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/meyerj/rtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meyerj/rtt/statuses/{sha}","languages_url":"https://api.github.com/repos/meyerj/rtt/languages","stargazers_url":"https://api.github.com/repos/meyerj/rtt/stargazers","contributors_url":"https://api.github.com/repos/meyerj/rtt/contributors","subscribers_url":"https://api.github.com/repos/meyerj/rtt/subscribers","subscription_url":"https://api.github.com/repos/meyerj/rtt/subscription","commits_url":"https://api.github.com/repos/meyerj/rtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/meyerj/rtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/meyerj/rtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/meyerj/rtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/meyerj/rtt/contents/{+path}","compare_url":"https://api.github.com/repos/meyerj/rtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meyerj/rtt/merges","archive_url":"https://api.github.com/repos/meyerj/rtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meyerj/rtt/downloads","issues_url":"https://api.github.com/repos/meyerj/rtt/issues{/number}","pulls_url":"https://api.github.com/repos/meyerj/rtt/pulls{/number}","milestones_url":"https://api.github.com/repos/meyerj/rtt/milestones{/number}","notifications_url":"https://api.github.com/repos/meyerj/rtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meyerj/rtt/labels{/name}","releases_url":"https://api.github.com/repos/meyerj/rtt/releases{/id}","deployments_url":"https://api.github.com/repos/meyerj/rtt/deployments","created_at":"2013-10-16T09:16:39Z","updated_at":"2015-04-13T14:40:39Z","pushed_at":"2016-08-10T12:28:23Z","git_url":"git://github.com/meyerj/rtt.git","ssh_url":"git@github.com:meyerj/rtt.git","clone_url":"https://github.com/meyerj/rtt.git","svn_url":"https://github.com/meyerj/rtt","homepage":"www.orocos.org","size":21881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"toolchain-2.9"}},"base":{"label":"orocos-toolchain:master","ref":"master","sha":"7fde6cbe677dbc46e58e8cdc2b9953da19fb0c2e","user":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"repo":{"id":6884031,"name":"rtt","full_name":"orocos-toolchain/rtt","owner":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocos-toolchain/rtt","description":"Real-Time Toolkit","fork":false,"url":"https://api.github.com/repos/orocos-toolchain/rtt","forks_url":"https://api.github.com/repos/orocos-toolchain/rtt/forks","keys_url":"https://api.github.com/repos/orocos-toolchain/rtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocos-toolchain/rtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocos-toolchain/rtt/teams","hooks_url":"https://api.github.com/repos/orocos-toolchain/rtt/hooks","issue_events_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/events{/number}","events_url":"https://api.github.com/repos/orocos-toolchain/rtt/events","assignees_url":"https://api.github.com/repos/orocos-toolchain/rtt/assignees{/user}","branches_url":"https://api.github.com/repos/orocos-toolchain/rtt/branches{/branch}","tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/tags","blobs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/{sha}","languages_url":"https://api.github.com/repos/orocos-toolchain/rtt/languages","stargazers_url":"https://api.github.com/repos/orocos-toolchain/rtt/stargazers","contributors_url":"https://api.github.com/repos/orocos-toolchain/rtt/contributors","subscribers_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscribers","subscription_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscription","commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/orocos-toolchain/rtt/contents/{+path}","compare_url":"https://api.github.com/repos/orocos-toolchain/rtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocos-toolchain/rtt/merges","archive_url":"https://api.github.com/repos/orocos-toolchain/rtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocos-toolchain/rtt/downloads","issues_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues{/number}","pulls_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls{/number}","milestones_url":"https://api.github.com/repos/orocos-toolchain/rtt/milestones{/number}","notifications_url":"https://api.github.com/repos/orocos-toolchain/rtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocos-toolchain/rtt/labels{/name}","releases_url":"https://api.github.com/repos/orocos-toolchain/rtt/releases{/id}","deployments_url":"https://api.github.com/repos/orocos-toolchain/rtt/deployments","created_at":"2012-11-27T13:45:18Z","updated_at":"2016-08-01T12:25:05Z","pushed_at":"2016-08-10T15:19:51Z","git_url":"git://github.com/orocos-toolchain/rtt.git","ssh_url":"git@github.com:orocos-toolchain/rtt.git","clone_url":"https://github.com/orocos-toolchain/rtt.git","svn_url":"https://github.com/orocos-toolchain/rtt","homepage":"www.orocos.org","size":21811,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":42,"forks":26,"open_issues":42,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157"},"html":{"href":"https://github.com/orocos-toolchain/rtt/pull/157"},"issue":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/issues/157"},"comments":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/15970d74d3c1b8472872ed122e4fcf8ff7f9389b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":36,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"meyerj"}}