{"action":"created","issue":{"url":"https://api.github.com/repos/guyellis/http-status-check/issues/47","repository_url":"https://api.github.com/repos/guyellis/http-status-check","labels_url":"https://api.github.com/repos/guyellis/http-status-check/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/guyellis/http-status-check/issues/47/comments","events_url":"https://api.github.com/repos/guyellis/http-status-check/issues/47/events","html_url":"https://github.com/guyellis/http-status-check/issues/47","id":188911017,"number":47,"title":"fix 3 broken test for inAdapters/fileAdapter, fix http not existing, increase coverage on mail adapter","user":{"login":"thomasmodeneis","id":2600966,"avatar_url":"https://avatars.githubusercontent.com/u/2600966?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasmodeneis","html_url":"https://github.com/thomasmodeneis","followers_url":"https://api.github.com/users/thomasmodeneis/followers","following_url":"https://api.github.com/users/thomasmodeneis/following{/other_user}","gists_url":"https://api.github.com/users/thomasmodeneis/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmodeneis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmodeneis/subscriptions","organizations_url":"https://api.github.com/users/thomasmodeneis/orgs","repos_url":"https://api.github.com/users/thomasmodeneis/repos","events_url":"https://api.github.com/users/thomasmodeneis/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmodeneis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-12T13:12:06Z","updated_at":"2016-11-12T16:24:13Z","closed_at":"2016-11-12T16:24:13Z","body":"```\r\n 3 failing\r\n\r\n  1) inAdapters/fileAdapter/ getRunData() should return checksites.js data if exists:\r\n\r\n      AssertionError: expected 'samplesites' to equal 'checksites'\r\n      + expected - actual\r\n\r\n      -samplesites\r\n      +checksites\r\n      \r\n      at Context.<anonymous> (test/lib/inAdapters/test.fileAdapter.js:35:27)\r\n\r\n  2) inAdapters/fileAdapter/ getRunData() should return samplesites.js data if exists and if checksites.js is missing:\r\n     Error: Expecting HTTP_STATUS_CHECK_FILE environment or checksites.js or samplesites.js to exist.\r\n      at findFile (lib/inAdapters/fileAdapter.js:19:11)\r\n      at Object.getRunData (lib/inAdapters/fileAdapter.js:24:14)\r\n      at Context.<anonymous> (test/lib/inAdapters/test.fileAdapter.js:56:31)\r\n\r\n  3) inAdapters/fileAdapter/ getRunData() should throw an exception if neither samplesites.js or checksites.js exist:\r\n\r\n      AssertionError: expected 2 to equal 3\r\n      + expected - actual\r\n\r\n      -2\r\n      +3\r\n      \r\n      at Context.<anonymous> (test/lib/inAdapters/test.fileAdapter.js:79:34)\r\n\r\n\r\n```\r\n\r\nfix http not existing, now is https\r\n```\r\n$ npm run start\r\n\r\n> http-status-check@1.1.0 start /opt/pocs/http-status-check\r\n> node index.js\r\n\r\nX Comentarismo API (http://www.linksilk.com) failed. Here are the problems:\r\n  - Expected header 'location' to be http://linksilk.com/ but instead it was https://linksilk.com/\r\nA total of 6 URIs were tested.\r\nFailure count:  1\r\nSuccess count:  4\r\nDisable count:  1\r\n```\r\n\r\nIncrease coverage:\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 78.71% ( 196/249 )\r\nBranches     : 73.27% ( 74/101 )\r\nFunctions    : 82.35% ( 28/34 )\r\nLines        : 78.63% ( 195/248 )\r\n================================================================================\r\n```\r\n\r\nBy adding test.emailAdapter.js Now coverage is:\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 93.57% ( 233/249 )\r\nBranches     : 81.19% ( 82/101 )\r\nFunctions    : 91.18% ( 31/34 )\r\nLines        : 93.55% ( 232/248 )\r\n================================================================================\r\n```"},"comment":{"url":"https://api.github.com/repos/guyellis/http-status-check/issues/comments/260131666","html_url":"https://github.com/guyellis/http-status-check/issues/47#issuecomment-260131666","issue_url":"https://api.github.com/repos/guyellis/http-status-check/issues/47","id":260131666,"user":{"login":"guyellis","id":2047725,"avatar_url":"https://avatars.githubusercontent.com/u/2047725?v=3","gravatar_id":"","url":"https://api.github.com/users/guyellis","html_url":"https://github.com/guyellis","followers_url":"https://api.github.com/users/guyellis/followers","following_url":"https://api.github.com/users/guyellis/following{/other_user}","gists_url":"https://api.github.com/users/guyellis/gists{/gist_id}","starred_url":"https://api.github.com/users/guyellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyellis/subscriptions","organizations_url":"https://api.github.com/users/guyellis/orgs","repos_url":"https://api.github.com/users/guyellis/repos","events_url":"https://api.github.com/users/guyellis/events{/privacy}","received_events_url":"https://api.github.com/users/guyellis/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T16:24:13Z","updated_at":"2016-11-12T16:24:13Z","body":"Fixed by @thomasmodeneis PR"}}
{"actor":{"display_login":"guyellis"}}