{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/http4s/pulls/comments/48693888","id":48693888,"diff_hunk":"@@ -11,7 +11,7 @@ object ClientExample {\n \n     val client = org.http4s.client.blaze.defaultClient\n \n-    val page: Task[String] = client(uri(\"https://www.google.com/\")).as[String]\n+    val page: Task[String] = client.getAs[String](uri(\"https://www.google.com/\"))","path":"examples/blaze/src/main/scala/com/example/http4s/blaze/ClientExample.scala","position":5,"original_position":5,"commit_id":"d3b1f97c386bf69e7ea27fb95d573d77df46cfc0","original_commit_id":"d3b1f97c386bf69e7ea27fb95d573d77df46cfc0","user":{"login":"bryce-anderson","id":2948506,"avatar_url":"https://avatars.githubusercontent.com/u/2948506?v=3","gravatar_id":"","url":"https://api.github.com/users/bryce-anderson","html_url":"https://github.com/bryce-anderson","followers_url":"https://api.github.com/users/bryce-anderson/followers","following_url":"https://api.github.com/users/bryce-anderson/following{/other_user}","gists_url":"https://api.github.com/users/bryce-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/bryce-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryce-anderson/subscriptions","organizations_url":"https://api.github.com/users/bryce-anderson/orgs","repos_url":"https://api.github.com/users/bryce-anderson/repos","events_url":"https://api.github.com/users/bryce-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/bryce-anderson/received_events","type":"User","site_admin":false},"body":"This is the only part that makes me sad: I liked that we had a symmetry between the `Request` and `Response` as far as the `.as[T]` syntax. Technically we still do, but its not the 'right' way to do it.\r\nHowever, it seems a small price to pay for not taking all the socket addresses.","created_at":"2016-01-03T14:57:35Z","updated_at":"2016-01-03T14:57:35Z","html_url":"https://github.com/http4s/http4s/pull/495#discussion_r48693888","pull_request_url":"https://api.github.com/repos/http4s/http4s/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments/48693888"},"html":{"href":"https://github.com/http4s/http4s/pull/495#discussion_r48693888"},"pull_request":{"href":"https://api.github.com/repos/http4s/http4s/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/495","id":54896719,"html_url":"https://github.com/http4s/http4s/pull/495","diff_url":"https://github.com/http4s/http4s/pull/495.diff","patch_url":"https://github.com/http4s/http4s/pull/495.patch","issue_url":"https://api.github.com/repos/http4s/http4s/issues/495","number":495,"state":"open","locked":false,"title":"Improve resource safety of client.","user":{"login":"rossabaker","id":142698,"avatar_url":"https://avatars.githubusercontent.com/u/142698?v=3","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"body":"The abstract method now returns a `DisposableResponse`, which\r\npairs the response with a dispose Task that must be called to\r\nfree the HTTP connection.\r\n\r\nThe three \"userspace\" methods are various forms of:\r\n- `stream`: like the old `prepare`, the caller is responsible\r\n  for running the response body to trigger cleanup.\r\n- `fetch`: takes a callback from the response to a Task,\r\n  which provides automatic resource cleanup on termination\r\n  of the Task.\r\n- `fetchAs`: differs from old `prepAs` in that the decoding\r\n  is not strict.  This brings it in line with `Response.as`.","created_at":"2016-01-01T21:30:25Z","updated_at":"2016-01-03T14:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef2b28ed1222b4e70418803ce553249525afa21a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/http4s/http4s/pulls/495/commits","review_comments_url":"https://api.github.com/repos/http4s/http4s/pulls/495/comments","review_comment_url":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/495/comments","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/d3b1f97c386bf69e7ea27fb95d573d77df46cfc0","head":{"label":"http4s:topic/client-refactor","ref":"topic/client-refactor","sha":"d3b1f97c386bf69e7ea27fb95d573d77df46cfc0","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"name":"http4s","full_name":"http4s/http4s","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","created_at":"2012-03-12T04:41:20Z","updated_at":"2016-01-01T14:14:12Z","pushed_at":"2016-01-03T02:05:03Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"http://http4s.org/","size":14596,"stargazers_count":367,"watchers_count":367,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":50,"forks":76,"open_issues":50,"watchers":367,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"de18f36065c95f4c9ae036b6f81bbbf93e3c9e0b","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"name":"http4s","full_name":"http4s/http4s","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","created_at":"2012-03-12T04:41:20Z","updated_at":"2016-01-01T14:14:12Z","pushed_at":"2016-01-03T02:05:03Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"http://http4s.org/","size":14596,"stargazers_count":367,"watchers_count":367,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":50,"forks":76,"open_issues":50,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/495"},"html":{"href":"https://github.com/http4s/http4s/pull/495"},"issue":{"href":"https://api.github.com/repos/http4s/http4s/issues/495"},"comments":{"href":"https://api.github.com/repos/http4s/http4s/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/http4s/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/http4s/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/http4s/statuses/d3b1f97c386bf69e7ea27fb95d573d77df46cfc0"}}}}