{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/miracle2k/android2po/pulls/41","id":52017709,"html_url":"https://github.com/miracle2k/android2po/pull/41","diff_url":"https://github.com/miracle2k/android2po/pull/41.diff","patch_url":"https://github.com/miracle2k/android2po/pull/41.patch","issue_url":"https://api.github.com/repos/miracle2k/android2po/issues/41","number":41,"state":"closed","locked":false,"title":"Stabilize the order of plural forms in .po files","user":{"login":"imankulov","id":75075,"avatar_url":"https://avatars.githubusercontent.com/u/75075?v=3","gravatar_id":"","url":"https://api.github.com/users/imankulov","html_url":"https://github.com/imankulov","followers_url":"https://api.github.com/users/imankulov/followers","following_url":"https://api.github.com/users/imankulov/following{/other_user}","gists_url":"https://api.github.com/users/imankulov/gists{/gist_id}","starred_url":"https://api.github.com/users/imankulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imankulov/subscriptions","organizations_url":"https://api.github.com/users/imankulov/orgs","repos_url":"https://api.github.com/users/imankulov/repos","events_url":"https://api.github.com/users/imankulov/events{/privacy}","received_events_url":"https://api.github.com/users/imankulov/received_events","type":"User","site_admin":false},"body":"Translation tools dealing with gettext files cannot provide any information on which variant corresponds to which CLDR mnemonic form. Therefore, the order of variants in gettext file is crucially important for successful translation.\r\n\r\nLooks like locale.plural_form.abstract doesn't always follow the \"canonical order\" of [zero, one, two, few, many, other], and explicit sort of keys is preferable.\r\n\r\nHere we explicitly sort plural forms and validate the \"meaningfulness\" of resulting .po file in tests. Tests which were relying on a different order or msgstr items are fixed.\r\n\r\nThe patch should be considered as backward-incompatible, because it breaks po -> xml transformation made in assumption of a different translation order.","created_at":"2015-11-27T18:22:39Z","updated_at":"2016-01-12T20:54:18Z","closed_at":"2016-01-12T20:54:18Z","merged_at":"2016-01-12T20:54:18Z","merge_commit_sha":"b3bd01d43536fcc19d2fef8ca712cebb547be2f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/miracle2k/android2po/pulls/41/commits","review_comments_url":"https://api.github.com/repos/miracle2k/android2po/pulls/41/comments","review_comment_url":"https://api.github.com/repos/miracle2k/android2po/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miracle2k/android2po/issues/41/comments","statuses_url":"https://api.github.com/repos/miracle2k/android2po/statuses/7cda8b51d9003ed6382eec77882260f8e7ef5896","head":{"label":"imankulov:sort-plurals","ref":"sort-plurals","sha":"7cda8b51d9003ed6382eec77882260f8e7ef5896","user":{"login":"imankulov","id":75075,"avatar_url":"https://avatars.githubusercontent.com/u/75075?v=3","gravatar_id":"","url":"https://api.github.com/users/imankulov","html_url":"https://github.com/imankulov","followers_url":"https://api.github.com/users/imankulov/followers","following_url":"https://api.github.com/users/imankulov/following{/other_user}","gists_url":"https://api.github.com/users/imankulov/gists{/gist_id}","starred_url":"https://api.github.com/users/imankulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imankulov/subscriptions","organizations_url":"https://api.github.com/users/imankulov/orgs","repos_url":"https://api.github.com/users/imankulov/repos","events_url":"https://api.github.com/users/imankulov/events{/privacy}","received_events_url":"https://api.github.com/users/imankulov/received_events","type":"User","site_admin":false},"repo":{"id":6688531,"name":"android2po","full_name":"imankulov/android2po","owner":{"login":"imankulov","id":75075,"avatar_url":"https://avatars.githubusercontent.com/u/75075?v=3","gravatar_id":"","url":"https://api.github.com/users/imankulov","html_url":"https://github.com/imankulov","followers_url":"https://api.github.com/users/imankulov/followers","following_url":"https://api.github.com/users/imankulov/following{/other_user}","gists_url":"https://api.github.com/users/imankulov/gists{/gist_id}","starred_url":"https://api.github.com/users/imankulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imankulov/subscriptions","organizations_url":"https://api.github.com/users/imankulov/orgs","repos_url":"https://api.github.com/users/imankulov/repos","events_url":"https://api.github.com/users/imankulov/events{/privacy}","received_events_url":"https://api.github.com/users/imankulov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imankulov/android2po","description":"Convert Android string resources to gettext, and back.","fork":true,"url":"https://api.github.com/repos/imankulov/android2po","forks_url":"https://api.github.com/repos/imankulov/android2po/forks","keys_url":"https://api.github.com/repos/imankulov/android2po/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imankulov/android2po/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imankulov/android2po/teams","hooks_url":"https://api.github.com/repos/imankulov/android2po/hooks","issue_events_url":"https://api.github.com/repos/imankulov/android2po/issues/events{/number}","events_url":"https://api.github.com/repos/imankulov/android2po/events","assignees_url":"https://api.github.com/repos/imankulov/android2po/assignees{/user}","branches_url":"https://api.github.com/repos/imankulov/android2po/branches{/branch}","tags_url":"https://api.github.com/repos/imankulov/android2po/tags","blobs_url":"https://api.github.com/repos/imankulov/android2po/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imankulov/android2po/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imankulov/android2po/git/refs{/sha}","trees_url":"https://api.github.com/repos/imankulov/android2po/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imankulov/android2po/statuses/{sha}","languages_url":"https://api.github.com/repos/imankulov/android2po/languages","stargazers_url":"https://api.github.com/repos/imankulov/android2po/stargazers","contributors_url":"https://api.github.com/repos/imankulov/android2po/contributors","subscribers_url":"https://api.github.com/repos/imankulov/android2po/subscribers","subscription_url":"https://api.github.com/repos/imankulov/android2po/subscription","commits_url":"https://api.github.com/repos/imankulov/android2po/commits{/sha}","git_commits_url":"https://api.github.com/repos/imankulov/android2po/git/commits{/sha}","comments_url":"https://api.github.com/repos/imankulov/android2po/comments{/number}","issue_comment_url":"https://api.github.com/repos/imankulov/android2po/issues/comments{/number}","contents_url":"https://api.github.com/repos/imankulov/android2po/contents/{+path}","compare_url":"https://api.github.com/repos/imankulov/android2po/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imankulov/android2po/merges","archive_url":"https://api.github.com/repos/imankulov/android2po/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imankulov/android2po/downloads","issues_url":"https://api.github.com/repos/imankulov/android2po/issues{/number}","pulls_url":"https://api.github.com/repos/imankulov/android2po/pulls{/number}","milestones_url":"https://api.github.com/repos/imankulov/android2po/milestones{/number}","notifications_url":"https://api.github.com/repos/imankulov/android2po/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imankulov/android2po/labels{/name}","releases_url":"https://api.github.com/repos/imankulov/android2po/releases{/id}","created_at":"2012-11-14T13:58:53Z","updated_at":"2015-11-25T16:28:23Z","pushed_at":"2015-12-09T16:13:26Z","git_url":"git://github.com/imankulov/android2po.git","ssh_url":"git@github.com:imankulov/android2po.git","clone_url":"https://github.com/imankulov/android2po.git","svn_url":"https://github.com/imankulov/android2po","homepage":"","size":518,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miracle2k:master","ref":"master","sha":"4f206b9943bbb3b3eb939b6614029592481f31b7","user":{"login":"miracle2k","id":13807,"avatar_url":"https://avatars.githubusercontent.com/u/13807?v=3","gravatar_id":"","url":"https://api.github.com/users/miracle2k","html_url":"https://github.com/miracle2k","followers_url":"https://api.github.com/users/miracle2k/followers","following_url":"https://api.github.com/users/miracle2k/following{/other_user}","gists_url":"https://api.github.com/users/miracle2k/gists{/gist_id}","starred_url":"https://api.github.com/users/miracle2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miracle2k/subscriptions","organizations_url":"https://api.github.com/users/miracle2k/orgs","repos_url":"https://api.github.com/users/miracle2k/repos","events_url":"https://api.github.com/users/miracle2k/events{/privacy}","received_events_url":"https://api.github.com/users/miracle2k/received_events","type":"User","site_admin":false},"repo":{"id":382876,"name":"android2po","full_name":"miracle2k/android2po","owner":{"login":"miracle2k","id":13807,"avatar_url":"https://avatars.githubusercontent.com/u/13807?v=3","gravatar_id":"","url":"https://api.github.com/users/miracle2k","html_url":"https://github.com/miracle2k","followers_url":"https://api.github.com/users/miracle2k/followers","following_url":"https://api.github.com/users/miracle2k/following{/other_user}","gists_url":"https://api.github.com/users/miracle2k/gists{/gist_id}","starred_url":"https://api.github.com/users/miracle2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miracle2k/subscriptions","organizations_url":"https://api.github.com/users/miracle2k/orgs","repos_url":"https://api.github.com/users/miracle2k/repos","events_url":"https://api.github.com/users/miracle2k/events{/privacy}","received_events_url":"https://api.github.com/users/miracle2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miracle2k/android2po","description":"Convert Android string resources to gettext, and back.","fork":false,"url":"https://api.github.com/repos/miracle2k/android2po","forks_url":"https://api.github.com/repos/miracle2k/android2po/forks","keys_url":"https://api.github.com/repos/miracle2k/android2po/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miracle2k/android2po/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miracle2k/android2po/teams","hooks_url":"https://api.github.com/repos/miracle2k/android2po/hooks","issue_events_url":"https://api.github.com/repos/miracle2k/android2po/issues/events{/number}","events_url":"https://api.github.com/repos/miracle2k/android2po/events","assignees_url":"https://api.github.com/repos/miracle2k/android2po/assignees{/user}","branches_url":"https://api.github.com/repos/miracle2k/android2po/branches{/branch}","tags_url":"https://api.github.com/repos/miracle2k/android2po/tags","blobs_url":"https://api.github.com/repos/miracle2k/android2po/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miracle2k/android2po/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miracle2k/android2po/git/refs{/sha}","trees_url":"https://api.github.com/repos/miracle2k/android2po/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miracle2k/android2po/statuses/{sha}","languages_url":"https://api.github.com/repos/miracle2k/android2po/languages","stargazers_url":"https://api.github.com/repos/miracle2k/android2po/stargazers","contributors_url":"https://api.github.com/repos/miracle2k/android2po/contributors","subscribers_url":"https://api.github.com/repos/miracle2k/android2po/subscribers","subscription_url":"https://api.github.com/repos/miracle2k/android2po/subscription","commits_url":"https://api.github.com/repos/miracle2k/android2po/commits{/sha}","git_commits_url":"https://api.github.com/repos/miracle2k/android2po/git/commits{/sha}","comments_url":"https://api.github.com/repos/miracle2k/android2po/comments{/number}","issue_comment_url":"https://api.github.com/repos/miracle2k/android2po/issues/comments{/number}","contents_url":"https://api.github.com/repos/miracle2k/android2po/contents/{+path}","compare_url":"https://api.github.com/repos/miracle2k/android2po/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miracle2k/android2po/merges","archive_url":"https://api.github.com/repos/miracle2k/android2po/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miracle2k/android2po/downloads","issues_url":"https://api.github.com/repos/miracle2k/android2po/issues{/number}","pulls_url":"https://api.github.com/repos/miracle2k/android2po/pulls{/number}","milestones_url":"https://api.github.com/repos/miracle2k/android2po/milestones{/number}","notifications_url":"https://api.github.com/repos/miracle2k/android2po/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miracle2k/android2po/labels{/name}","releases_url":"https://api.github.com/repos/miracle2k/android2po/releases{/id}","created_at":"2009-11-23T18:47:59Z","updated_at":"2016-01-12T20:04:15Z","pushed_at":"2016-01-12T20:54:17Z","git_url":"git://github.com/miracle2k/android2po.git","ssh_url":"git@github.com:miracle2k/android2po.git","clone_url":"https://github.com/miracle2k/android2po.git","svn_url":"https://github.com/miracle2k/android2po","homepage":"","size":498,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":12,"forks":33,"open_issues":12,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miracle2k/android2po/pulls/41"},"html":{"href":"https://github.com/miracle2k/android2po/pull/41"},"issue":{"href":"https://api.github.com/repos/miracle2k/android2po/issues/41"},"comments":{"href":"https://api.github.com/repos/miracle2k/android2po/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/miracle2k/android2po/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/miracle2k/android2po/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miracle2k/android2po/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/miracle2k/android2po/statuses/7cda8b51d9003ed6382eec77882260f8e7ef5896"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"miracle2k","id":13807,"avatar_url":"https://avatars.githubusercontent.com/u/13807?v=3","gravatar_id":"","url":"https://api.github.com/users/miracle2k","html_url":"https://github.com/miracle2k","followers_url":"https://api.github.com/users/miracle2k/followers","following_url":"https://api.github.com/users/miracle2k/following{/other_user}","gists_url":"https://api.github.com/users/miracle2k/gists{/gist_id}","starred_url":"https://api.github.com/users/miracle2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miracle2k/subscriptions","organizations_url":"https://api.github.com/users/miracle2k/orgs","repos_url":"https://api.github.com/users/miracle2k/repos","events_url":"https://api.github.com/users/miracle2k/events{/privacy}","received_events_url":"https://api.github.com/users/miracle2k/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":70,"deletions":8,"changed_files":2}}