{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/9078","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/9078/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/9078/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/9078/events","html_url":"https://github.com/elastic/kibana/issues/9078","id":189457369,"number":9078,"title":"Style Guide suggestion on Promises","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"labels":[{"id":135902874,"url":"https://api.github.com/repos/elastic/kibana/labels/discuss","name":"discuss","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-15T17:36:06Z","updated_at":"2016-11-16T18:23:05Z","closed_at":null,"body":"I think we should be consistent in our use of native vs bluebird promises, as it can be confusing in the code to figure out which type is being used.\r\n\r\nI'd like to propose that we add a style guide entry around this:\r\n- Use native promises where ever possible and reasonable\r\n- If you must use bluebird, and you are returning a Promise from an exported function, wrap it in a native promise. That way everyone can assume that a Promise returned from a function is of the native type.\r\n\r\nOpen for debate! "},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/261028114","html_url":"https://github.com/elastic/kibana/issues/9078#issuecomment-261028114","issue_url":"https://api.github.com/repos/elastic/kibana/issues/9078","id":261028114,"user":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T18:23:05Z","updated_at":"2016-11-16T18:23:05Z","body":"Agreed. The styleguide should also recommend adding unit tests for this sort of API contract, otherwise it would be very easy to accidentally break."}}
{"actor":{"display_login":"Bargs"}}