{"action":"created","issue":{"url":"https://api.github.com/repos/gnunn1/terminix/issues/350","repository_url":"https://api.github.com/repos/gnunn1/terminix","labels_url":"https://api.github.com/repos/gnunn1/terminix/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/gnunn1/terminix/issues/350/comments","events_url":"https://api.github.com/repos/gnunn1/terminix/issues/350/events","html_url":"https://github.com/gnunn1/terminix/issues/350","id":156999190,"number":350,"title":"Better visual bell support","user":{"login":"noscript","id":717109,"avatar_url":"https://avatars.githubusercontent.com/u/717109?v=3","gravatar_id":"","url":"https://api.github.com/users/noscript","html_url":"https://github.com/noscript","followers_url":"https://api.github.com/users/noscript/followers","following_url":"https://api.github.com/users/noscript/following{/other_user}","gists_url":"https://api.github.com/users/noscript/gists{/gist_id}","starred_url":"https://api.github.com/users/noscript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noscript/subscriptions","organizations_url":"https://api.github.com/users/noscript/orgs","repos_url":"https://api.github.com/users/noscript/repos","events_url":"https://api.github.com/users/noscript/events{/privacy}","received_events_url":"https://api.github.com/users/noscript/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gnunn1/terminix/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-26T14:37:19Z","updated_at":"2016-06-01T23:49:46Z","closed_at":"2016-06-01T23:42:43Z","body":"This is how I test the bell in various terminals:\r\n\r\n```\r\n$ sleep 5 && echo -ne \\\\a\r\n```\r\n\r\n-  I would expect at least bell propagation to window manager / desktop environment. Bell in `xterm` causes both window border and windows list button flash in LXDE.\r\n\r\n- The session button, session sidebar and split title bar should also indicate where (and if) the bell happened."},"comment":{"url":"https://api.github.com/repos/gnunn1/terminix/issues/comments/223158443","html_url":"https://github.com/gnunn1/terminix/issues/350#issuecomment-223158443","issue_url":"https://api.github.com/repos/gnunn1/terminix/issues/350","id":223158443,"user":{"login":"gnunn1","id":9358238,"avatar_url":"https://avatars.githubusercontent.com/u/9358238?v=3","gravatar_id":"","url":"https://api.github.com/users/gnunn1","html_url":"https://github.com/gnunn1","followers_url":"https://api.github.com/users/gnunn1/followers","following_url":"https://api.github.com/users/gnunn1/following{/other_user}","gists_url":"https://api.github.com/users/gnunn1/gists{/gist_id}","starred_url":"https://api.github.com/users/gnunn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnunn1/subscriptions","organizations_url":"https://api.github.com/users/gnunn1/orgs","repos_url":"https://api.github.com/users/gnunn1/repos","events_url":"https://api.github.com/users/gnunn1/events{/privacy}","received_events_url":"https://api.github.com/users/gnunn1/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T23:49:46Z","updated_at":"2016-06-01T23:49:46Z","body":"I've checked in an initial version of this feature, I don't think it's perfect but I'm looking for feedback and usually I get the best feedback after closing an issue :) \r\n\r\nAt the moment the implementation is as follows for the icon:\r\n\r\n* The icon is shown in the titlebar with a shaking animation, I'm using the alarm-symbolic icon so hopefully the shaking will pair well with whatever icon is present in most icon themes.\r\n* The icon is shown for 5 seconds before being hidden again\r\n* If the terminal is in a session that is not visible, showing the bell icon will be deferred until the session is visible\r\n* I'm not deferring showing the icon if the window is not visible, way too many edge cases to deal with. i.e. window is visible but not obscured or visible in another monitor, etc\r\n\r\nThe one I struggle with still is whether a notification should be raised for it. If you have a VTE that supports notifications it will often result in double notifications when the bell is used to signal the end of a long running command. I'm not keen on flashing the window, as I previously mentioned that's way too disco for me."}}
{"actor":{"display_login":"gnunn1"}}