{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/1815","repository_url":"https://api.github.com/repos/hyperledger/fabric","labels_url":"https://api.github.com/repos/hyperledger/fabric/issues/1815/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1815/comments","events_url":"https://api.github.com/repos/hyperledger/fabric/issues/1815/events","html_url":"https://github.com/hyperledger/fabric/issues/1815","id":159985363,"number":1815,"title":"Consider removing logging wrapper functions from chaincode.go","user":{"login":"srderson","id":4872087,"avatar_url":"https://avatars.githubusercontent.com/u/4872087?v=3","gravatar_id":"","url":"https://api.github.com/users/srderson","html_url":"https://github.com/srderson","followers_url":"https://api.github.com/users/srderson/followers","following_url":"https://api.github.com/users/srderson/following{/other_user}","gists_url":"https://api.github.com/users/srderson/gists{/gist_id}","starred_url":"https://api.github.com/users/srderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srderson/subscriptions","organizations_url":"https://api.github.com/users/srderson/orgs","repos_url":"https://api.github.com/users/srderson/repos","events_url":"https://api.github.com/users/srderson/events{/privacy}","received_events_url":"https://api.github.com/users/srderson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-13T15:59:08Z","updated_at":"2016-06-14T17:35:16Z","closed_at":null,"body":"<!-- For general purpose questions, use Stack Overflow http://stackoverflow.com/questions/tagged/hyperledger -->\r\n\r\n## Description\r\n`chaincode.go` contains functions such as `Debugf`, `Infof`, etc. The comment associated with these was\r\n```\r\n// Note: We're only creating the 'f' forms of the logging functions here for\r\n// consistency with Go language conventions around formatted I/O routines, and\r\n// to avoid confusion with the conventions used in the core code. It is\r\n// possible that some day the core code will also change from using\r\n// logger.Debug() to logger.Debugf() etc., and we want to protect chaincode\r\n// writers from that hiccup if it occurs.\r\n```\r\nThe core code will not support `Debugf`, `Infof`, etc. because we are upgrading the logging package. We can remove this wrapper or leave it we think it will continue to protect chaincode writers from future logging changes.\r\n\r\nPersonally, I'm somewhat tempted to leave it because\r\na) Some people have already used it\r\nb) It will continue to protect chaincode writers from future logging changes.\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/comments/225956876","html_url":"https://github.com/hyperledger/fabric/issues/1815#issuecomment-225956876","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1815","id":225956876,"user":{"login":"bcbrock","id":11968347,"avatar_url":"https://avatars.githubusercontent.com/u/11968347?v=3","gravatar_id":"","url":"https://api.github.com/users/bcbrock","html_url":"https://github.com/bcbrock","followers_url":"https://api.github.com/users/bcbrock/followers","following_url":"https://api.github.com/users/bcbrock/following{/other_user}","gists_url":"https://api.github.com/users/bcbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/bcbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcbrock/subscriptions","organizations_url":"https://api.github.com/users/bcbrock/orgs","repos_url":"https://api.github.com/users/bcbrock/repos","events_url":"https://api.github.com/users/bcbrock/events{/privacy}","received_events_url":"https://api.github.com/users/bcbrock/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T17:35:16Z","updated_at":"2016-06-14T17:35:16Z","body":"@genggjh I will take the task of adding and documenting the non-f forms. Chris and I chatted in private and he agreed to the change and asked me to add some documentation to the source code. "}}
{"actor":{"display_login":"bcbrock"}}