{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/daikon/pulls/comments/86358442","pull_request_review_id":7020579,"id":86358442,"diff_hunk":"@@ -79,8 +80,8 @@\n \n     private List<String> methodCalled = new ArrayList<>();\n \n-    public FullExampleProperties(String name) {\n-        super(name);\n+    public FullExampleProperties() {","path":"daikon/src/test/java/org/talend/daikon/serialize/jsonschema/FullExampleProperties.java","position":14,"original_position":14,"commit_id":"bb151fd5189f94c76f46a09a1bd92839d8decd5b","original_commit_id":"bb151fd5189f94c76f46a09a1bd92839d8decd5b","user":{"login":"sgandon","id":783286,"avatar_url":"https://avatars.githubusercontent.com/u/783286?v=3","gravatar_id":"","url":"https://api.github.com/users/sgandon","html_url":"https://github.com/sgandon","followers_url":"https://api.github.com/users/sgandon/followers","following_url":"https://api.github.com/users/sgandon/following{/other_user}","gists_url":"https://api.github.com/users/sgandon/gists{/gist_id}","starred_url":"https://api.github.com/users/sgandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgandon/subscriptions","organizations_url":"https://api.github.com/users/sgandon/orgs","repos_url":"https://api.github.com/users/sgandon/repos","events_url":"https://api.github.com/users/sgandon/events{/privacy}","received_events_url":"https://api.github.com/users/sgandon/received_events","type":"User","site_admin":false},"body":"This is a very bad example to create an empty constructor because we are supposed to be using Properties as nested Properties to some other Properties and the contract is that those nested properties have a name.\r\nI know this is only used for test but it is important that it show the good example of developing a ComponentProperties","created_at":"2016-11-03T14:43:03Z","updated_at":"2016-11-03T14:44:46Z","html_url":"https://github.com/Talend/daikon/pull/80#discussion_r86358442","pull_request_url":"https://api.github.com/repos/Talend/daikon/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments/86358442"},"html":{"href":"https://github.com/Talend/daikon/pull/80#discussion_r86358442"},"pull_request":{"href":"https://api.github.com/repos/Talend/daikon/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/daikon/pulls/80","id":92145650,"html_url":"https://github.com/Talend/daikon/pull/80","diff_url":"https://github.com/Talend/daikon/pull/80.diff","patch_url":"https://github.com/Talend/daikon/pull/80.patch","issue_url":"https://api.github.com/repos/Talend/daikon/issues/80","number":80,"state":"open","locked":false,"title":"Feature/tdkn 81 jsonschema i18n","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [x] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format) ?\r\n- [x] Tests for the changes have been added (for bug fixes / features) ?\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [ ] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [ ] Bugfix\r\n- [x] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\n\r\n\r\n**What is the new behavior?**\r\nsupport i18n for json schema, use `title` & `enumNames` in json schema as the key for display name\r\nnew EnumListProperty, which used for column of table, and this column has a enum type, need to use Property to get the display name\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n","created_at":"2016-11-03T12:42:16Z","updated_at":"2016-11-03T14:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a8df156fb300a807daaa4a356767f87bb2d22d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/daikon/pulls/80/commits","review_comments_url":"https://api.github.com/repos/Talend/daikon/pulls/80/comments","review_comment_url":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/daikon/issues/80/comments","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/bb151fd5189f94c76f46a09a1bd92839d8decd5b","head":{"label":"Talend:feature/TDKN-81-jsonschema-i18n","ref":"feature/TDKN-81-jsonschema-i18n","sha":"bb151fd5189f94c76f46a09a1bd92839d8decd5b","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2016-10-24T09:25:37Z","pushed_at":"2016-11-03T13:48:54Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":2838,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"4639fa51a4238ce1db483e15f46e861fbebc0d0b","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2016-10-24T09:25:37Z","pushed_at":"2016-11-03T13:48:54Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":2838,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/80"},"html":{"href":"https://github.com/Talend/daikon/pull/80"},"issue":{"href":"https://api.github.com/repos/Talend/daikon/issues/80"},"comments":{"href":"https://api.github.com/repos/Talend/daikon/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/daikon/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/daikon/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/daikon/statuses/bb151fd5189f94c76f46a09a1bd92839d8decd5b"}}}}
{"actor":{"display_login":"sgandon"}}