{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/spack/issues/667","repository_url":"https://api.github.com/repos/LLNL/spack","labels_url":"https://api.github.com/repos/LLNL/spack/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/667/comments","events_url":"https://api.github.com/repos/LLNL/spack/issues/667/events","html_url":"https://github.com/LLNL/spack/pull/667","id":143841786,"number":667,"title":"[Needs Review] Updated PySide to work with Python 3.5","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-03-27T19:45:04Z","updated_at":"2016-08-12T00:48:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/667","html_url":"https://github.com/LLNL/spack/pull/667","diff_url":"https://github.com/LLNL/spack/pull/667.diff","patch_url":"https://github.com/LLNL/spack/pull/667.patch"},"body":"Looking for review by @tgamblin who wrote the original code.  Multiple issues are in play here:\r\n\r\n1. The old version (1.2.2) does not work with Python3.  It could be retained, but only with a \"when=\" qualifier requiring Python2.  Alternatively, we could drop it, since v1.2.4 DOES claim to work with Python 2.6 and 2.7.  This is GUI interface code, using a new version not going to change anyone's numerical output.\r\n\r\n2. PySide is a \"complex\" project in which the main project downloads other sub-projects with git magic.  Long an the short of it is... downloading a tarball from git is NOT the same in this case as downloading the tarballs provided at PyPI.  Version 1.2.3 was short-lived (~1 day), and there is no tarball download for it.  It's easiest NOT to try to build that with Spack, since that would require a complex GitHub download procedure.\r\n\r\n3. The main improvement of version 1.2.4 is a Python version check that complains and quits if you're using the \"wrong\" version.  It allows for Python3 up to v3.4, but NOT v3.5.  A GitHub posting indicates that it probably DOES work on v3.5, but the maintainers are not interested in certifying that across all platforms: https://github.com/PySide/pyside-setup/issues/58   Meanwhile, the maintainers seem to have moved on to PySide2, which is for use with Qt5.  I don't expect them to ever certify PySide1 with Python 3.5.\r\n\r\n4. The easiest way to get PySide working for Python 3.5 is to patch the `setup.py` file to allow Python 3.5.  Which is what I did.\r\n\r\n6. Starting with Version 1.2.3, the PySide post-install script has been eliminated.  I eliminated the patching for it accordingly.  BUT... I don't really understand all the other RPATH machinations going on here, or whether they are still valid with the latest PySide.  This needs review.\r\n\r\nThe good news is... this all worked for me running Matplotlib with Python 3.5.  So I'm cautiously optimistic that this recipe is basically correct.\r\n"},"comment":{"url":"https://api.github.com/repos/LLNL/spack/issues/comments/239335262","html_url":"https://github.com/LLNL/spack/pull/667#issuecomment-239335262","issue_url":"https://api.github.com/repos/LLNL/spack/issues/667","id":239335262,"user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T00:48:14Z","updated_at":"2016-08-12T00:48:14Z","body":"Yes, please do.  I rely on Python 3.5.\n\n> That's true, but 1.2.2 links and 1.2.4 doesn't\n\nI'll figure this out next time I pull, if it bites me then.\n\nOn Thu, Aug 11, 2016 at 8:36 PM, Adam J. Stewart <notifications@github.com>\nwrote:\n\n> The lack of RPATH problem is widespread, I don't think we'll get far with\n> it by avoiding certain versions.\n>\n> That's true, but 1.2.2 links and 1.2.4 doesn't. I'll add both versions and\n> keep 1.2.2 preferred for now until someone figures out how to get it to\n> link.\n>\n> Do you want me to include the hack to force it to work with Python 3.5?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/LLNL/spack/pull/667#issuecomment-239333780>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AB1cd076IULFdZeiEL8iz1sS4ZKHHI47ks5qe8AegaJpZM4H5hvq>\n> .\n>\n"}}
{"actor":{"display_login":"citibeth"}}