{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/49054931","id":49054931,"diff_hunk":"@@ -407,16 +363,12 @@ public function getPromotionCoupons()\n     /**\n      * {@inheritdoc}\n      */\n-    public function addPromotionCoupon($coupon)\n+    public function addPromotionCoupon(BaseCouponInterface $coupon = null)\n     {\n         if (null === $coupon) {\n             return $this;","path":"src/Sylius/Component/Core/Model/Order.php","position":239,"original_position":239,"commit_id":"aa0949e67c918b9eee2351d58fdd50600c5b9382","original_commit_id":"aa0949e67c918b9eee2351d58fdd50600c5b9382","user":{"login":"michalmarcinkowski","id":7572437,"avatar_url":"https://avatars.githubusercontent.com/u/7572437?v=3","gravatar_id":"","url":"https://api.github.com/users/michalmarcinkowski","html_url":"https://github.com/michalmarcinkowski","followers_url":"https://api.github.com/users/michalmarcinkowski/followers","following_url":"https://api.github.com/users/michalmarcinkowski/following{/other_user}","gists_url":"https://api.github.com/users/michalmarcinkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalmarcinkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalmarcinkowski/subscriptions","organizations_url":"https://api.github.com/users/michalmarcinkowski/orgs","repos_url":"https://api.github.com/users/michalmarcinkowski/repos","events_url":"https://api.github.com/users/michalmarcinkowski/events{/privacy}","received_events_url":"https://api.github.com/users/michalmarcinkowski/received_events","type":"User","site_admin":false},"body":"`return;`","created_at":"2016-01-07T09:29:03Z","updated_at":"2016-01-07T09:29:03Z","html_url":"https://github.com/Sylius/Sylius/pull/3795#discussion_r49054931","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3795","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/49054931"},"html":{"href":"https://github.com/Sylius/Sylius/pull/3795#discussion_r49054931"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3795"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/3795","id":54789752,"html_url":"https://github.com/Sylius/Sylius/pull/3795","diff_url":"https://github.com/Sylius/Sylius/pull/3795.diff","patch_url":"https://github.com/Sylius/Sylius/pull/3795.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/3795","number":3795,"state":"open","locked":false,"title":"[Order] Implementation of OrderItemQuantityModifier","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nThis PR is based on https://github.com/Sylius/Sylius/pull/3771 and correspond with @michalmarcinkowski work in https://github.com/Sylius/Sylius/pull/3786.\r\n\r\nIn this PR there is ``OrderItemQuantityModifier`` implemented, that handles item units management. The idea is, to change ``OrderItem`` quantity only by adding/removing units.\r\n\r\n**Possible improvements/modifications**\r\n- it will be better to remove *backordered* units first, then *sold* ones\r\n- we could remove ``setQuantity`` method from ``OrderItem`` as it's not longer needed, but to make it work fully, recalculation logic from https://github.com/Sylius/Sylius/pull/3786 must be changed","created_at":"2015-12-30T10:14:44Z","updated_at":"2016-01-07T09:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"824ccf424f942a77f19fb70b6fb585e45201a6b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3795/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3795/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/3795/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/aa0949e67c918b9eee2351d58fdd50600c5b9382","head":{"label":"Zales0123:order-item-quantity-modifier","ref":"order-item-quantity-modifier","sha":"aa0949e67c918b9eee2351d58fdd50600c5b9382","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"repo":{"id":28911466,"name":"Sylius","full_name":"Zales0123/Sylius","owner":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zales0123/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/Zales0123/Sylius","forks_url":"https://api.github.com/repos/Zales0123/Sylius/forks","keys_url":"https://api.github.com/repos/Zales0123/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zales0123/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zales0123/Sylius/teams","hooks_url":"https://api.github.com/repos/Zales0123/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Zales0123/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Zales0123/Sylius/events","assignees_url":"https://api.github.com/repos/Zales0123/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Zales0123/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Zales0123/Sylius/tags","blobs_url":"https://api.github.com/repos/Zales0123/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zales0123/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zales0123/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zales0123/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zales0123/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Zales0123/Sylius/languages","stargazers_url":"https://api.github.com/repos/Zales0123/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Zales0123/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Zales0123/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Zales0123/Sylius/subscription","commits_url":"https://api.github.com/repos/Zales0123/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zales0123/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zales0123/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zales0123/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zales0123/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Zales0123/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zales0123/Sylius/merges","archive_url":"https://api.github.com/repos/Zales0123/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zales0123/Sylius/downloads","issues_url":"https://api.github.com/repos/Zales0123/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Zales0123/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Zales0123/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Zales0123/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zales0123/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Zales0123/Sylius/releases{/id}","created_at":"2015-01-07T11:20:44Z","updated_at":"2015-05-06T12:22:35Z","pushed_at":"2016-01-05T14:00:44Z","git_url":"git://github.com/Zales0123/Sylius.git","ssh_url":"git@github.com:Zales0123/Sylius.git","clone_url":"https://github.com/Zales0123/Sylius.git","svn_url":"https://github.com/Zales0123/Sylius","homepage":"Sylius.org","size":21690,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"16b744310e2161f79c1e8cb6d525e774eb1d38b9","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"Component-based and format-agnostic (JSON/XML/HTML) eCommerce framework on top of Symfony.","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-01-07T07:41:30Z","pushed_at":"2016-01-07T09:27:59Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://sylius.org","size":51260,"stargazers_count":2104,"watchers_count":2104,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":766,"mirror_url":null,"open_issues_count":475,"forks":766,"open_issues":475,"watchers":2104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3795"},"html":{"href":"https://github.com/Sylius/Sylius/pull/3795"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3795"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3795/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3795/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3795/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/aa0949e67c918b9eee2351d58fdd50600c5b9382"}}}}