{"action":"created","comment":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/66854312","id":66854312,"diff_hunk":"@@ -65,8 +65,8 @@ def test_image_pipe(tmpdir):\n                          obs_table=data_store.obs_table, exclusion_mask=exclusion_mask)\n     mosaic.make_images(make_background_image=True, for_integral_flux=True, radius=10.)\n     # TODO: this fails on some machines, for unknown reasons.\n-    #assert_equal(mosaic.maps['counts'].data.sum(), 2334.0)\n-    #assert_almost_equal(mosaic.maps['bkg'].data.sum(), 1987.2088283446637)\n-    #assert_almost_equal(mosaic.maps['exposure'].data.sum(), 5.9292301086257267e17)\n-    #assert_almost_equal(mosaic.maps['significance'].lookup(center), 33.699068269123039)\n-    #assert_almost_equal(mosaic.maps['excess'].data.sum(), 346.79117165533626)\n+    assert_equal(mosaic.maps['counts'].data.sum(), 2334.0)","path":"gammapy/scripts/tests/test_image_pipe.py","position":9,"original_position":9,"commit_id":"0d8d7bcfc3d9a50c67e4cbffcce78a9d10b4b0ee","original_commit_id":"0d8d7bcfc3d9a50c67e4cbffcce78a9d10b4b0ee","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"body":"This assertion fails in some builds:\r\nhttps://travis-ci.org/gammapy/gammapy/jobs/137307389#L1697\r\n\r\nI guess this is float rounding errors of the position of a single event at the image edge.\r\nThis can happen, it's normal.\r\nYou just have to change to e.g.\r\n```\r\nassert_allclose(mosaic.maps['counts'].data.sum(), 2334, atol=3)\r\n```\r\nPlease also remove the `TODO` comment above the other asserts from `assert_almost_equal` to `assert_allclose`, to be in line with our [assert convention](http://docs.gammapy.org/en/latest/development/howto.html#assert-convention) in Gammapy.","created_at":"2016-06-13T19:44:03Z","updated_at":"2016-06-13T19:44:03Z","html_url":"https://github.com/gammapy/gammapy/pull/576#discussion_r66854312","pull_request_url":"https://api.github.com/repos/gammapy/gammapy/pulls/576","_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/66854312"},"html":{"href":"https://github.com/gammapy/gammapy/pull/576#discussion_r66854312"},"pull_request":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/576"}}},"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/576","id":73613113,"html_url":"https://github.com/gammapy/gammapy/pull/576","diff_url":"https://github.com/gammapy/gammapy/pull/576.diff","patch_url":"https://github.com/gammapy/gammapy/pull/576.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/576","number":576,"state":"open","locked":false,"title":"Image pipe solidangle","user":{"login":"JouvinLea","id":14295716,"avatar_url":"https://avatars.githubusercontent.com/u/14295716?v=3","gravatar_id":"","url":"https://api.github.com/users/JouvinLea","html_url":"https://github.com/JouvinLea","followers_url":"https://api.github.com/users/JouvinLea/followers","following_url":"https://api.github.com/users/JouvinLea/following{/other_user}","gists_url":"https://api.github.com/users/JouvinLea/gists{/gist_id}","starred_url":"https://api.github.com/users/JouvinLea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JouvinLea/subscriptions","organizations_url":"https://api.github.com/users/JouvinLea/orgs","repos_url":"https://api.github.com/users/JouvinLea/repos","events_url":"https://api.github.com/users/JouvinLea/events{/privacy}","received_events_url":"https://api.github.com/users/JouvinLea/received_events","type":"User","site_admin":false},"body":"Hi,\r\nthis is fix the solid_angle issue in image_pipe and add a test that assert some values for the different SkyMap.\r\n\r\nCheers,\r\nLea","created_at":"2016-06-13T17:29:41Z","updated_at":"2016-06-13T19:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ce34d539d58bae50b211fa66c66edbe3ef2ac24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/576/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/576/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/576/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/0d8d7bcfc3d9a50c67e4cbffcce78a9d10b4b0ee","head":{"label":"JouvinLea:ImagePipe_solidangle","ref":"ImagePipe_solidangle","sha":"0d8d7bcfc3d9a50c67e4cbffcce78a9d10b4b0ee","user":{"login":"JouvinLea","id":14295716,"avatar_url":"https://avatars.githubusercontent.com/u/14295716?v=3","gravatar_id":"","url":"https://api.github.com/users/JouvinLea","html_url":"https://github.com/JouvinLea","followers_url":"https://api.github.com/users/JouvinLea/followers","following_url":"https://api.github.com/users/JouvinLea/following{/other_user}","gists_url":"https://api.github.com/users/JouvinLea/gists{/gist_id}","starred_url":"https://api.github.com/users/JouvinLea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JouvinLea/subscriptions","organizations_url":"https://api.github.com/users/JouvinLea/orgs","repos_url":"https://api.github.com/users/JouvinLea/repos","events_url":"https://api.github.com/users/JouvinLea/events{/privacy}","received_events_url":"https://api.github.com/users/JouvinLea/received_events","type":"User","site_admin":false},"repo":{"id":46556710,"name":"gammapy","full_name":"JouvinLea/gammapy","owner":{"login":"JouvinLea","id":14295716,"avatar_url":"https://avatars.githubusercontent.com/u/14295716?v=3","gravatar_id":"","url":"https://api.github.com/users/JouvinLea","html_url":"https://github.com/JouvinLea","followers_url":"https://api.github.com/users/JouvinLea/followers","following_url":"https://api.github.com/users/JouvinLea/following{/other_user}","gists_url":"https://api.github.com/users/JouvinLea/gists{/gist_id}","starred_url":"https://api.github.com/users/JouvinLea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JouvinLea/subscriptions","organizations_url":"https://api.github.com/users/JouvinLea/orgs","repos_url":"https://api.github.com/users/JouvinLea/repos","events_url":"https://api.github.com/users/JouvinLea/events{/privacy}","received_events_url":"https://api.github.com/users/JouvinLea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JouvinLea/gammapy","description":"A Python package for gamma-ray astronomy","fork":true,"url":"https://api.github.com/repos/JouvinLea/gammapy","forks_url":"https://api.github.com/repos/JouvinLea/gammapy/forks","keys_url":"https://api.github.com/repos/JouvinLea/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JouvinLea/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JouvinLea/gammapy/teams","hooks_url":"https://api.github.com/repos/JouvinLea/gammapy/hooks","issue_events_url":"https://api.github.com/repos/JouvinLea/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/JouvinLea/gammapy/events","assignees_url":"https://api.github.com/repos/JouvinLea/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/JouvinLea/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/JouvinLea/gammapy/tags","blobs_url":"https://api.github.com/repos/JouvinLea/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JouvinLea/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JouvinLea/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/JouvinLea/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JouvinLea/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/JouvinLea/gammapy/languages","stargazers_url":"https://api.github.com/repos/JouvinLea/gammapy/stargazers","contributors_url":"https://api.github.com/repos/JouvinLea/gammapy/contributors","subscribers_url":"https://api.github.com/repos/JouvinLea/gammapy/subscribers","subscription_url":"https://api.github.com/repos/JouvinLea/gammapy/subscription","commits_url":"https://api.github.com/repos/JouvinLea/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/JouvinLea/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/JouvinLea/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/JouvinLea/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/JouvinLea/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/JouvinLea/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JouvinLea/gammapy/merges","archive_url":"https://api.github.com/repos/JouvinLea/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JouvinLea/gammapy/downloads","issues_url":"https://api.github.com/repos/JouvinLea/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/JouvinLea/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/JouvinLea/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/JouvinLea/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JouvinLea/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/JouvinLea/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/JouvinLea/gammapy/deployments","created_at":"2015-11-20T10:54:35Z","updated_at":"2015-11-20T10:54:37Z","pushed_at":"2016-06-13T17:27:25Z","git_url":"git://github.com/JouvinLea/gammapy.git","ssh_url":"git@github.com:JouvinLea/gammapy.git","clone_url":"https://github.com/JouvinLea/gammapy.git","svn_url":"https://github.com/JouvinLea/gammapy","homepage":"https://gammapy.readthedocs.org/","size":6008,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"b226142a4d50a655cef4612833d22bf6c2f89e65","user":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/gammapy/gammapy/deployments","created_at":"2013-05-15T07:50:40Z","updated_at":"2016-06-13T12:51:39Z","pushed_at":"2016-06-13T18:34:17Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"http://docs.gammapy.org","size":6612,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":151,"forks":42,"open_issues":151,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/576"},"html":{"href":"https://github.com/gammapy/gammapy/pull/576"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/576"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/576/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/576/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/576/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/0d8d7bcfc3d9a50c67e4cbffcce78a9d10b4b0ee"}}}}
{"actor":{"display_login":"cdeil"}}