{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/comments/78026488","id":78026488,"diff_hunk":"@@ -238,14 +235,6 @@ div.tablePopover:hover {\n .ace_content {\n     background-color: #f4f4f4;\n }\n-.ws-el > .ws-el-controls {","path":"caravel/assets/javascripts/SqlLab/main.css","position":22,"original_position":22,"commit_id":"166224822bc1397522e1fc851c7175034bf59082","original_commit_id":"166224822bc1397522e1fc851c7175034bf59082","user":{"login":"mistercrunch","id":487433,"avatar_url":"https://avatars.githubusercontent.com/u/487433?v=3","gravatar_id":"","url":"https://api.github.com/users/mistercrunch","html_url":"https://github.com/mistercrunch","followers_url":"https://api.github.com/users/mistercrunch/followers","following_url":"https://api.github.com/users/mistercrunch/following{/other_user}","gists_url":"https://api.github.com/users/mistercrunch/gists{/gist_id}","starred_url":"https://api.github.com/users/mistercrunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistercrunch/subscriptions","organizations_url":"https://api.github.com/users/mistercrunch/orgs","repos_url":"https://api.github.com/users/mistercrunch/repos","events_url":"https://api.github.com/users/mistercrunch/events{/privacy}","received_events_url":"https://api.github.com/users/mistercrunch/received_events","type":"User","site_admin":false},"body":"I took the time to do this because I thought it was better, let's talk and agree before ripping it out.","created_at":"2016-09-08T15:11:54Z","updated_at":"2016-09-08T15:11:54Z","html_url":"https://github.com/airbnb/caravel/pull/1079#discussion_r78026488","pull_request_url":"https://api.github.com/repos/airbnb/caravel/pulls/1079","_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments/78026488"},"html":{"href":"https://github.com/airbnb/caravel/pull/1079#discussion_r78026488"},"pull_request":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/1079","id":84430355,"html_url":"https://github.com/airbnb/caravel/pull/1079","diff_url":"https://github.com/airbnb/caravel/pull/1079.diff","patch_url":"https://github.com/airbnb/caravel/pull/1079.patch","issue_url":"https://api.github.com/repos/airbnb/caravel/issues/1079","number":1079,"state":"open","locked":false,"title":"[sql-lab] ui polish","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"body":"- we don't need tooltips on accordion menu, known ui pattern, also was blocking the table action icons\r\n- use consistent type sizes for sql-lab (same as other views), bump body type down to 14px in the theme\r\n- adjust sql editor height\r\n- table meta data accordion menu \r\n---prevent default on accordion clicks\r\n--- always show table actions, they are more discoverable like that\r\n--- polish spacing/layout\r\n- make welcome view type same as body copy (don't used `table-condensed`)\r\n\r\nbefore: \r\n<img width=\"1280\" alt=\"screenshot 2016-09-08 01 03 05\" src=\"https://cloud.githubusercontent.com/assets/130878/18341615/a1469d2c-755f-11e6-9e82-4f6a3c5fc4c7.png\">\r\n\r\n<img width=\"1280\" alt=\"screenshot 2016-09-08 01 01 35\" src=\"https://cloud.githubusercontent.com/assets/130878/18341585/7bacfc6e-755f-11e6-8c4f-7e24b9cb3bca.png\">\r\n\r\n\r\nafter:\r\n\r\n<img width=\"1280\" alt=\"screenshot 2016-09-08 00 54 41\" src=\"https://cloud.githubusercontent.com/assets/130878/18341430/d1dacebe-755e-11e6-85f7-cb5d52da559b.png\">\r\n\r\n\r\n![sql-lab-polish](https://cloud.githubusercontent.com/assets/130878/18341361/7e88a902-755e-11e6-9ac9-cdc28c336ff8.gif)\r\n\r\n\r\n\r\nplz review @mistercrunch @bkyryliuk @vera-liu ","created_at":"2016-09-08T07:53:19Z","updated_at":"2016-09-08T15:11:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27549b0f4f0770c882156a40cae3c36883cf1895","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/caravel/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/airbnb/caravel/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/caravel/issues/1079/comments","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/166224822bc1397522e1fc851c7175034bf59082","head":{"label":"ascott:alanna-sql-lab-polish","ref":"alanna-sql-lab-polish","sha":"166224822bc1397522e1fc851c7175034bf59082","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"repo":{"id":60567622,"name":"caravel","full_name":"ascott/caravel","owner":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ascott/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/ascott/caravel","forks_url":"https://api.github.com/repos/ascott/caravel/forks","keys_url":"https://api.github.com/repos/ascott/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ascott/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ascott/caravel/teams","hooks_url":"https://api.github.com/repos/ascott/caravel/hooks","issue_events_url":"https://api.github.com/repos/ascott/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/ascott/caravel/events","assignees_url":"https://api.github.com/repos/ascott/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/ascott/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/ascott/caravel/tags","blobs_url":"https://api.github.com/repos/ascott/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ascott/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ascott/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ascott/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ascott/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/ascott/caravel/languages","stargazers_url":"https://api.github.com/repos/ascott/caravel/stargazers","contributors_url":"https://api.github.com/repos/ascott/caravel/contributors","subscribers_url":"https://api.github.com/repos/ascott/caravel/subscribers","subscription_url":"https://api.github.com/repos/ascott/caravel/subscription","commits_url":"https://api.github.com/repos/ascott/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ascott/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ascott/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ascott/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ascott/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/ascott/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ascott/caravel/merges","archive_url":"https://api.github.com/repos/ascott/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ascott/caravel/downloads","issues_url":"https://api.github.com/repos/ascott/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/ascott/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/ascott/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/ascott/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ascott/caravel/labels{/name}","releases_url":"https://api.github.com/repos/ascott/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/ascott/caravel/deployments","created_at":"2016-06-06T23:34:56Z","updated_at":"2016-06-06T23:34:57Z","pushed_at":"2016-09-08T07:44:42Z","git_url":"git://github.com/ascott/caravel.git","ssh_url":"git@github.com:ascott/caravel.git","clone_url":"https://github.com/ascott/caravel.git","svn_url":"https://github.com/ascott/caravel","homepage":"","size":37144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"d454fb402b6abf2b9092d072b065345ad62e5867","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"caravel","full_name":"airbnb/caravel","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/caravel","forks_url":"https://api.github.com/repos/airbnb/caravel/forks","keys_url":"https://api.github.com/repos/airbnb/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/caravel/teams","hooks_url":"https://api.github.com/repos/airbnb/caravel/hooks","issue_events_url":"https://api.github.com/repos/airbnb/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/caravel/events","assignees_url":"https://api.github.com/repos/airbnb/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/caravel/tags","blobs_url":"https://api.github.com/repos/airbnb/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/caravel/languages","stargazers_url":"https://api.github.com/repos/airbnb/caravel/stargazers","contributors_url":"https://api.github.com/repos/airbnb/caravel/contributors","subscribers_url":"https://api.github.com/repos/airbnb/caravel/subscribers","subscription_url":"https://api.github.com/repos/airbnb/caravel/subscription","commits_url":"https://api.github.com/repos/airbnb/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/caravel/merges","archive_url":"https://api.github.com/repos/airbnb/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/caravel/downloads","issues_url":"https://api.github.com/repos/airbnb/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/caravel/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/caravel/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-09-08T14:29:41Z","pushed_at":"2016-09-08T07:53:19Z","git_url":"git://github.com/airbnb/caravel.git","ssh_url":"git@github.com:airbnb/caravel.git","clone_url":"https://github.com/airbnb/caravel.git","svn_url":"https://github.com/airbnb/caravel","homepage":"","size":40596,"stargazers_count":7221,"watchers_count":7221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":801,"mirror_url":null,"open_issues_count":230,"forks":801,"open_issues":230,"watchers":7221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1079"},"html":{"href":"https://github.com/airbnb/caravel/pull/1079"},"issue":{"href":"https://api.github.com/repos/airbnb/caravel/issues/1079"},"comments":{"href":"https://api.github.com/repos/airbnb/caravel/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/caravel/statuses/166224822bc1397522e1fc851c7175034bf59082"}}}}
{"actor":{"display_login":"mistercrunch"}}