{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/52000537","id":52000537,"diff_hunk":"@@ -68,9 +73,7 @@ public void handleRequest(HttpServerExchange httpServerExchange) throws Exceptio\n         HeaderMap requestHeaders = httpServerExchange.getRequestHeaders();\n \n         String databaseName = matcher.group(1);\n-        try {","path":"hawkular-component/src/main/java/org/hawkular/metrics/security/InfluxAuthHttpHandler.java","position":25,"original_position":25,"commit_id":"fe2cdf3780a22b8c92f00a37dc0e83af3e717fc6","original_commit_id":"fe2cdf3780a22b8c92f00a37dc0e83af3e717fc6","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"body":"OK, I'll simply revert the second commit then.\n\nLe 05/02/2016 11:21, Juraci Paixão Kröhling a écrit :\n> In\n> hawkular-component/src/main/java/org/hawkular/metrics/security/InfluxAuthHttpHandler.java\n> <https://github.com/hawkular/hawkular-metrics/pull/444#discussion_r51998297>:\n>\n>> @@ -68,9 +73,7 @@ public void handleRequest(HttpServerExchange httpServerExchange) throws Exceptio\n>>          HeaderMap requestHeaders = httpServerExchange.getRequestHeaders();\n>>\n>>          String databaseName = matcher.group(1);\n>> -        try {\n>\n> The regex above is not meant to replace this try/catch. It might be the\n> case that it matches the regex but still is not spec-compliant. In such\n> case, Accounts will throw a RuntimeException, so, it's a matter of taste\n> now :)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/hawkular/hawkular-metrics/pull/444/files#r51998297>.\n>\n\n","created_at":"2016-02-05T10:43:28Z","updated_at":"2016-02-05T10:43:28Z","html_url":"https://github.com/hawkular/hawkular-metrics/pull/444#discussion_r52000537","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/52000537"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/444#discussion_r52000537"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444","id":58407311,"html_url":"https://github.com/hawkular/hawkular-metrics/pull/444","diff_url":"https://github.com/hawkular/hawkular-metrics/pull/444.diff","patch_url":"https://github.com/hawkular/hawkular-metrics/pull/444.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/444","number":444,"state":"open","locked":false,"title":"HWKMETRICS-346 Fix bogus Hawkular Component security rules","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"body":"HWKMETRICS-346 Fix bogus Hawkular Component security rules\n\nDo not use declarative security in web.xml.\n\nNote that the REST endpoints are still all secured by default, only a couple are white-listed for free access.","created_at":"2016-02-05T09:49:24Z","updated_at":"2016-02-05T10:43:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"846528a61d8465c658b237be22e7513d7753c131","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/444/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/fe2cdf3780a22b8c92f00a37dc0e83af3e717fc6","head":{"label":"tsegismont:jira/HWKMETRICS-346","ref":"jira/HWKMETRICS-346","sha":"fe2cdf3780a22b8c92f00a37dc0e83af3e717fc6","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"repo":{"id":19787241,"name":"hawkular-metrics","full_name":"tsegismont/hawkular-metrics","owner":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsegismont/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":true,"url":"https://api.github.com/repos/tsegismont/hawkular-metrics","forks_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/tsegismont/hawkular-metrics/deployments","created_at":"2014-05-14T16:28:24Z","updated_at":"2016-01-15T11:19:55Z","pushed_at":"2016-02-05T09:59:13Z","git_url":"git://github.com/tsegismont/hawkular-metrics.git","ssh_url":"git@github.com:tsegismont/hawkular-metrics.git","clone_url":"https://github.com/tsegismont/hawkular-metrics.git","svn_url":"https://github.com/tsegismont/hawkular-metrics","homepage":"","size":13547,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"5c46759ef141aa1422897525e4ac6be4f7dcc8fb","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":17705626,"name":"hawkular-metrics","full_name":"hawkular/hawkular-metrics","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-metrics","forks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/deployments","created_at":"2014-03-13T10:07:30Z","updated_at":"2016-02-04T14:17:30Z","pushed_at":"2016-02-05T09:59:14Z","git_url":"git://github.com/hawkular/hawkular-metrics.git","ssh_url":"git@github.com:hawkular/hawkular-metrics.git","clone_url":"https://github.com/hawkular/hawkular-metrics.git","svn_url":"https://github.com/hawkular/hawkular-metrics","homepage":"","size":16284,"stargazers_count":69,"watchers_count":69,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":15,"forks":42,"open_issues":15,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/444"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/444"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/fe2cdf3780a22b8c92f00a37dc0e83af3e717fc6"}}}}