{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28","id":58220853,"html_url":"https://github.com/Roomify/bat_drupal/pull/28","diff_url":"https://github.com/Roomify/bat_drupal/pull/28.diff","patch_url":"https://github.com/Roomify/bat_drupal/pull/28.patch","issue_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/28","number":28,"state":"closed","locked":false,"title":"A bat unit is not necessarily a drupal bat unit","user":{"login":"acrollet","id":101649,"avatar_url":"https://avatars.githubusercontent.com/u/101649?v=3","gravatar_id":"","url":"https://api.github.com/users/acrollet","html_url":"https://github.com/acrollet","followers_url":"https://api.github.com/users/acrollet/followers","following_url":"https://api.github.com/users/acrollet/following{/other_user}","gists_url":"https://api.github.com/users/acrollet/gists{/gist_id}","starred_url":"https://api.github.com/users/acrollet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrollet/subscriptions","organizations_url":"https://api.github.com/users/acrollet/orgs","repos_url":"https://api.github.com/users/acrollet/repos","events_url":"https://api.github.com/users/acrollet/events{/privacy}","received_events_url":"https://api.github.com/users/acrollet/received_events","type":"User","site_admin":false},"body":"Ok @istos here it is - event creation/editing etc works on the standard forms for events referencing units or rates, works with scheduler when referencing units. (existing functionality)\r\n\r\n2 weaknesses:\r\n\r\n* the 'All events' view was modified to remove anything to do with a unit. Perhaps we should re-name the view to 'All unit events' and re-instate the functionality? Confusing for people using the base functionality.\r\n* bat_fullcalendar has been modified to work, but everything still assumes Units. Do we anticipate building other interfaces for any non-unit use cases, or should we try to make the basic interface agnostic about what kind of entity events relate to?","created_at":"2016-02-03T23:51:34Z","updated_at":"2016-02-04T08:35:53Z","closed_at":"2016-02-04T08:35:53Z","merged_at":"2016-02-04T08:35:53Z","merge_commit_sha":"05e4bcd7676306a1df108f73e7e146ab058627a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Roomify/bat_drupal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/28/comments","statuses_url":"https://api.github.com/repos/Roomify/bat_drupal/statuses/df8d49ed09a03eb56812544a30edcb23b08baf32","head":{"label":"Roomify:aBatUnitIsNotNecessarilyADrupalBatUnit","ref":"aBatUnitIsNotNecessarilyADrupalBatUnit","sha":"df8d49ed09a03eb56812544a30edcb23b08baf32","user":{"login":"Roomify","id":10819471,"avatar_url":"https://avatars.githubusercontent.com/u/10819471?v=3","gravatar_id":"","url":"https://api.github.com/users/Roomify","html_url":"https://github.com/Roomify","followers_url":"https://api.github.com/users/Roomify/followers","following_url":"https://api.github.com/users/Roomify/following{/other_user}","gists_url":"https://api.github.com/users/Roomify/gists{/gist_id}","starred_url":"https://api.github.com/users/Roomify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roomify/subscriptions","organizations_url":"https://api.github.com/users/Roomify/orgs","repos_url":"https://api.github.com/users/Roomify/repos","events_url":"https://api.github.com/users/Roomify/events{/privacy}","received_events_url":"https://api.github.com/users/Roomify/received_events","type":"Organization","site_admin":false},"repo":{"id":44861254,"name":"bat_drupal","full_name":"Roomify/bat_drupal","owner":{"login":"Roomify","id":10819471,"avatar_url":"https://avatars.githubusercontent.com/u/10819471?v=3","gravatar_id":"","url":"https://api.github.com/users/Roomify","html_url":"https://github.com/Roomify","followers_url":"https://api.github.com/users/Roomify/followers","following_url":"https://api.github.com/users/Roomify/following{/other_user}","gists_url":"https://api.github.com/users/Roomify/gists{/gist_id}","starred_url":"https://api.github.com/users/Roomify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roomify/subscriptions","organizations_url":"https://api.github.com/users/Roomify/orgs","repos_url":"https://api.github.com/users/Roomify/repos","events_url":"https://api.github.com/users/Roomify/events{/privacy}","received_events_url":"https://api.github.com/users/Roomify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Roomify/bat_drupal","description":"Booking and Availability Management Tools for Drupal 7 and Drupal 8","fork":false,"url":"https://api.github.com/repos/Roomify/bat_drupal","forks_url":"https://api.github.com/repos/Roomify/bat_drupal/forks","keys_url":"https://api.github.com/repos/Roomify/bat_drupal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Roomify/bat_drupal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Roomify/bat_drupal/teams","hooks_url":"https://api.github.com/repos/Roomify/bat_drupal/hooks","issue_events_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/events{/number}","events_url":"https://api.github.com/repos/Roomify/bat_drupal/events","assignees_url":"https://api.github.com/repos/Roomify/bat_drupal/assignees{/user}","branches_url":"https://api.github.com/repos/Roomify/bat_drupal/branches{/branch}","tags_url":"https://api.github.com/repos/Roomify/bat_drupal/tags","blobs_url":"https://api.github.com/repos/Roomify/bat_drupal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Roomify/bat_drupal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Roomify/bat_drupal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Roomify/bat_drupal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Roomify/bat_drupal/statuses/{sha}","languages_url":"https://api.github.com/repos/Roomify/bat_drupal/languages","stargazers_url":"https://api.github.com/repos/Roomify/bat_drupal/stargazers","contributors_url":"https://api.github.com/repos/Roomify/bat_drupal/contributors","subscribers_url":"https://api.github.com/repos/Roomify/bat_drupal/subscribers","subscription_url":"https://api.github.com/repos/Roomify/bat_drupal/subscription","commits_url":"https://api.github.com/repos/Roomify/bat_drupal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Roomify/bat_drupal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Roomify/bat_drupal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Roomify/bat_drupal/contents/{+path}","compare_url":"https://api.github.com/repos/Roomify/bat_drupal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Roomify/bat_drupal/merges","archive_url":"https://api.github.com/repos/Roomify/bat_drupal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Roomify/bat_drupal/downloads","issues_url":"https://api.github.com/repos/Roomify/bat_drupal/issues{/number}","pulls_url":"https://api.github.com/repos/Roomify/bat_drupal/pulls{/number}","milestones_url":"https://api.github.com/repos/Roomify/bat_drupal/milestones{/number}","notifications_url":"https://api.github.com/repos/Roomify/bat_drupal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Roomify/bat_drupal/labels{/name}","releases_url":"https://api.github.com/repos/Roomify/bat_drupal/releases{/id}","deployments_url":"https://api.github.com/repos/Roomify/bat_drupal/deployments","created_at":"2015-10-24T10:17:31Z","updated_at":"2016-01-27T15:36:03Z","pushed_at":"2016-02-04T08:35:53Z","git_url":"git://github.com/Roomify/bat_drupal.git","ssh_url":"git@github.com:Roomify/bat_drupal.git","clone_url":"https://github.com/Roomify/bat_drupal.git","svn_url":"https://github.com/Roomify/bat_drupal","homepage":null,"size":710,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":6,"default_branch":"7.x-1.x"}},"base":{"label":"Roomify:7.x-1.x","ref":"7.x-1.x","sha":"3f1216318d8b17ae09805eb0a59819ac9759eb7a","user":{"login":"Roomify","id":10819471,"avatar_url":"https://avatars.githubusercontent.com/u/10819471?v=3","gravatar_id":"","url":"https://api.github.com/users/Roomify","html_url":"https://github.com/Roomify","followers_url":"https://api.github.com/users/Roomify/followers","following_url":"https://api.github.com/users/Roomify/following{/other_user}","gists_url":"https://api.github.com/users/Roomify/gists{/gist_id}","starred_url":"https://api.github.com/users/Roomify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roomify/subscriptions","organizations_url":"https://api.github.com/users/Roomify/orgs","repos_url":"https://api.github.com/users/Roomify/repos","events_url":"https://api.github.com/users/Roomify/events{/privacy}","received_events_url":"https://api.github.com/users/Roomify/received_events","type":"Organization","site_admin":false},"repo":{"id":44861254,"name":"bat_drupal","full_name":"Roomify/bat_drupal","owner":{"login":"Roomify","id":10819471,"avatar_url":"https://avatars.githubusercontent.com/u/10819471?v=3","gravatar_id":"","url":"https://api.github.com/users/Roomify","html_url":"https://github.com/Roomify","followers_url":"https://api.github.com/users/Roomify/followers","following_url":"https://api.github.com/users/Roomify/following{/other_user}","gists_url":"https://api.github.com/users/Roomify/gists{/gist_id}","starred_url":"https://api.github.com/users/Roomify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roomify/subscriptions","organizations_url":"https://api.github.com/users/Roomify/orgs","repos_url":"https://api.github.com/users/Roomify/repos","events_url":"https://api.github.com/users/Roomify/events{/privacy}","received_events_url":"https://api.github.com/users/Roomify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Roomify/bat_drupal","description":"Booking and Availability Management Tools for Drupal 7 and Drupal 8","fork":false,"url":"https://api.github.com/repos/Roomify/bat_drupal","forks_url":"https://api.github.com/repos/Roomify/bat_drupal/forks","keys_url":"https://api.github.com/repos/Roomify/bat_drupal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Roomify/bat_drupal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Roomify/bat_drupal/teams","hooks_url":"https://api.github.com/repos/Roomify/bat_drupal/hooks","issue_events_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/events{/number}","events_url":"https://api.github.com/repos/Roomify/bat_drupal/events","assignees_url":"https://api.github.com/repos/Roomify/bat_drupal/assignees{/user}","branches_url":"https://api.github.com/repos/Roomify/bat_drupal/branches{/branch}","tags_url":"https://api.github.com/repos/Roomify/bat_drupal/tags","blobs_url":"https://api.github.com/repos/Roomify/bat_drupal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Roomify/bat_drupal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Roomify/bat_drupal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Roomify/bat_drupal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Roomify/bat_drupal/statuses/{sha}","languages_url":"https://api.github.com/repos/Roomify/bat_drupal/languages","stargazers_url":"https://api.github.com/repos/Roomify/bat_drupal/stargazers","contributors_url":"https://api.github.com/repos/Roomify/bat_drupal/contributors","subscribers_url":"https://api.github.com/repos/Roomify/bat_drupal/subscribers","subscription_url":"https://api.github.com/repos/Roomify/bat_drupal/subscription","commits_url":"https://api.github.com/repos/Roomify/bat_drupal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Roomify/bat_drupal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Roomify/bat_drupal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Roomify/bat_drupal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Roomify/bat_drupal/contents/{+path}","compare_url":"https://api.github.com/repos/Roomify/bat_drupal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Roomify/bat_drupal/merges","archive_url":"https://api.github.com/repos/Roomify/bat_drupal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Roomify/bat_drupal/downloads","issues_url":"https://api.github.com/repos/Roomify/bat_drupal/issues{/number}","pulls_url":"https://api.github.com/repos/Roomify/bat_drupal/pulls{/number}","milestones_url":"https://api.github.com/repos/Roomify/bat_drupal/milestones{/number}","notifications_url":"https://api.github.com/repos/Roomify/bat_drupal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Roomify/bat_drupal/labels{/name}","releases_url":"https://api.github.com/repos/Roomify/bat_drupal/releases{/id}","deployments_url":"https://api.github.com/repos/Roomify/bat_drupal/deployments","created_at":"2015-10-24T10:17:31Z","updated_at":"2016-01-27T15:36:03Z","pushed_at":"2016-02-04T08:35:53Z","git_url":"git://github.com/Roomify/bat_drupal.git","ssh_url":"git@github.com:Roomify/bat_drupal.git","clone_url":"https://github.com/Roomify/bat_drupal.git","svn_url":"https://github.com/Roomify/bat_drupal","homepage":null,"size":710,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":6,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28"},"html":{"href":"https://github.com/Roomify/bat_drupal/pull/28"},"issue":{"href":"https://api.github.com/repos/Roomify/bat_drupal/issues/28"},"comments":{"href":"https://api.github.com/repos/Roomify/bat_drupal/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Roomify/bat_drupal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Roomify/bat_drupal/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Roomify/bat_drupal/statuses/df8d49ed09a03eb56812544a30edcb23b08baf32"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"istos","id":80763,"avatar_url":"https://avatars.githubusercontent.com/u/80763?v=3","gravatar_id":"","url":"https://api.github.com/users/istos","html_url":"https://github.com/istos","followers_url":"https://api.github.com/users/istos/followers","following_url":"https://api.github.com/users/istos/following{/other_user}","gists_url":"https://api.github.com/users/istos/gists{/gist_id}","starred_url":"https://api.github.com/users/istos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istos/subscriptions","organizations_url":"https://api.github.com/users/istos/orgs","repos_url":"https://api.github.com/users/istos/repos","events_url":"https://api.github.com/users/istos/events{/privacy}","received_events_url":"https://api.github.com/users/istos/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":8,"additions":245,"deletions":109,"changed_files":11}}