{"action":"created","issue":{"url":"https://api.github.com/repos/caskdata/cdap/issues/5153","repository_url":"https://api.github.com/repos/caskdata/cdap","labels_url":"https://api.github.com/repos/caskdata/cdap/issues/5153/labels{/name}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/5153/comments","events_url":"https://api.github.com/repos/caskdata/cdap/issues/5153/events","html_url":"https://github.com/caskdata/cdap/pull/5153","id":133849596,"number":5153,"title":"CDAP-4388 fix resource balancer to set completion","user":{"login":"gsps1","id":1328150,"avatar_url":"https://avatars.githubusercontent.com/u/1328150?v=3","gravatar_id":"","url":"https://api.github.com/users/gsps1","html_url":"https://github.com/gsps1","followers_url":"https://api.github.com/users/gsps1/followers","following_url":"https://api.github.com/users/gsps1/following{/other_user}","gists_url":"https://api.github.com/users/gsps1/gists{/gist_id}","starred_url":"https://api.github.com/users/gsps1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsps1/subscriptions","organizations_url":"https://api.github.com/users/gsps1/orgs","repos_url":"https://api.github.com/users/gsps1/repos","events_url":"https://api.github.com/users/gsps1/events{/privacy}","received_events_url":"https://api.github.com/users/gsps1/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/caskdata/cdap/labels/3.4","name":"3.4","color":"0052cc"},{"url":"https://api.github.com/repos/caskdata/cdap/labels/Bug","name":"Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-16T00:29:59Z","updated_at":"2016-02-18T01:43:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/5153","html_url":"https://github.com/caskdata/cdap/pull/5153","diff_url":"https://github.com/caskdata/cdap/pull/5153.diff","patch_url":"https://github.com/caskdata/cdap/pull/5153.patch"},"body":"when finished is called on ResourceBalancerService#ResourceHandler, we stop the service (metrics.processor/log.saver) however we don't set completion on ResourceBalancer, causing it to continue running even after the service is stopped. By setting completion, this would stop resource balancer and other services in the metrics.processor/log.saver container when there is an exception or notifications are cancelled causing finished to be called.\r\n\r\nJIRA : https://issues.cask.co/browse/CDAP-4388\r\nBuild : http://builds.cask.co/browse/CDAP-DUT3568-1"},"comment":{"url":"https://api.github.com/repos/caskdata/cdap/issues/comments/185500510","html_url":"https://github.com/caskdata/cdap/pull/5153#issuecomment-185500510","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/5153","id":185500510,"user":{"login":"anwar6953","id":2440977,"avatar_url":"https://avatars.githubusercontent.com/u/2440977?v=3","gravatar_id":"","url":"https://api.github.com/users/anwar6953","html_url":"https://github.com/anwar6953","followers_url":"https://api.github.com/users/anwar6953/followers","following_url":"https://api.github.com/users/anwar6953/following{/other_user}","gists_url":"https://api.github.com/users/anwar6953/gists{/gist_id}","starred_url":"https://api.github.com/users/anwar6953/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anwar6953/subscriptions","organizations_url":"https://api.github.com/users/anwar6953/orgs","repos_url":"https://api.github.com/users/anwar6953/repos","events_url":"https://api.github.com/users/anwar6953/events{/privacy}","received_events_url":"https://api.github.com/users/anwar6953/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T01:43:14Z","updated_at":"2016-02-18T01:43:14Z","body":"This doesn't resolve the root cause of https://issues.cask.co/browse/CDAP-4388, right?\r\nWhat it does allow is for metrics processor to restart if the root cause is triggered, instead of just hanging in an idle state, right?"}}