{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/puppet-logstash/issues/312","repository_url":"https://api.github.com/repos/elastic/puppet-logstash","labels_url":"https://api.github.com/repos/elastic/puppet-logstash/issues/312/labels{/name}","comments_url":"https://api.github.com/repos/elastic/puppet-logstash/issues/312/comments","events_url":"https://api.github.com/repos/elastic/puppet-logstash/issues/312/events","html_url":"https://github.com/elastic/puppet-logstash/issues/312","id":186341364,"number":312,"title":"Logstash 5.x Support","user":{"login":"Cova","id":280622,"avatar_url":"https://avatars.githubusercontent.com/u/280622?v=3","gravatar_id":"","url":"https://api.github.com/users/Cova","html_url":"https://github.com/Cova","followers_url":"https://api.github.com/users/Cova/followers","following_url":"https://api.github.com/users/Cova/following{/other_user}","gists_url":"https://api.github.com/users/Cova/gists{/gist_id}","starred_url":"https://api.github.com/users/Cova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cova/subscriptions","organizations_url":"https://api.github.com/users/Cova/orgs","repos_url":"https://api.github.com/users/Cova/repos","events_url":"https://api.github.com/users/Cova/events{/privacy}","received_events_url":"https://api.github.com/users/Cova/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2016-10-31T17:10:56Z","updated_at":"2016-12-07T00:57:01Z","closed_at":null,"body":"There's an issue tracking the outstanding issues for ElasticSearch 5.x support from its puppet module, so I figured Logstash should have one too."},"comment":{"url":"https://api.github.com/repos/elastic/puppet-logstash/issues/comments/265322735","html_url":"https://github.com/elastic/puppet-logstash/issues/312#issuecomment-265322735","issue_url":"https://api.github.com/repos/elastic/puppet-logstash/issues/312","id":265322735,"user":{"login":"jarpy","id":119659,"avatar_url":"https://avatars.githubusercontent.com/u/119659?v=3","gravatar_id":"","url":"https://api.github.com/users/jarpy","html_url":"https://github.com/jarpy","followers_url":"https://api.github.com/users/jarpy/followers","following_url":"https://api.github.com/users/jarpy/following{/other_user}","gists_url":"https://api.github.com/users/jarpy/gists{/gist_id}","starred_url":"https://api.github.com/users/jarpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarpy/subscriptions","organizations_url":"https://api.github.com/users/jarpy/orgs","repos_url":"https://api.github.com/users/jarpy/repos","events_url":"https://api.github.com/users/jarpy/events{/privacy}","received_events_url":"https://api.github.com/users/jarpy/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T00:57:01Z","updated_at":"2016-12-07T00:57:01Z","body":"All the `file_concat` stuff is gone now. The module now creates one file per `logstash::configfile` declaration.\r\n\r\nhttps://github.com/elastic/puppet-logstash/commit/054248c7d4b38a74fb131ea72d37fe0c2637e1ad\r\n\r\nNote: This patch also removes the needless (IMO) abstraction of templating from `logstash::configfile`, so if you were doing:\r\n\r\n```\r\nlogstash::configfile { 'logs':\r\n  template => 'path/to/template'\r\n}\r\n```\r\nNow you should do:\r\n```\r\nlogstash::configfile { 'logs':\r\n  content => template('path/to/template')\r\n}\r\n```\r\nThat's consistent with normal templating for file resources, and doesn't add abstraction magic over something that Puppet coders already do every day."}}
{"actor":{"display_login":"jarpy"}}