{"action":"closed","number":790,"pull_request":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790","id":91473098,"html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/790","diff_url":"https://github.com/chocolate-doom/chocolate-doom/pull/790.diff","patch_url":"https://github.com/chocolate-doom/chocolate-doom/pull/790.patch","issue_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/790","number":790,"state":"closed","locked":false,"title":"Compatibility options in Heretic and Hexen","user":{"login":"CapnClever","id":8853201,"avatar_url":"https://avatars.githubusercontent.com/u/8853201?v=3","gravatar_id":"","url":"https://api.github.com/users/CapnClever","html_url":"https://github.com/CapnClever","followers_url":"https://api.github.com/users/CapnClever/followers","following_url":"https://api.github.com/users/CapnClever/following{/other_user}","gists_url":"https://api.github.com/users/CapnClever/gists{/gist_id}","starred_url":"https://api.github.com/users/CapnClever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CapnClever/subscriptions","organizations_url":"https://api.github.com/users/CapnClever/orgs","repos_url":"https://api.github.com/users/CapnClever/repos","events_url":"https://api.github.com/users/CapnClever/events{/privacy}","received_events_url":"https://api.github.com/users/CapnClever/received_events","type":"User","site_admin":false},"body":"Resolves #789. Forgot to include issue tags to the commits, though this was a self-made issue so hopefully not too concerning. Some notes:\n- I rewrote a little bit of Hexen's savegame code so read information from a file bytes at a time, as is done in Doom/Heretic: this \"solved\" the problem of loading or saving a game.\n- `CopyFile` was completely rewritten to read in chunks (0x10000) of saves at a time for the copy procedure: this virtually guarantees no allocation problems here. Hexen's compatibility WRT savegames is to attempt to read in the entire file, then immediately freeing the space if it succeeds.\n- Also did some renaming of Hexen's save-writing functions. Since I changed many lines for the save-reading anyway, I figure this isn't a big deal. (I could go back to using the `GET_LONG`, etc macros, but this is probably more straight-forward and this code's almost never been touched anyway so I don't think there's a git blame problem.)\n\nThe rest should be straight-forward.\n","created_at":"2016-10-29T00:59:20Z","updated_at":"2016-11-01T19:27:22Z","closed_at":"2016-11-01T19:27:22Z","merged_at":"2016-11-01T19:27:22Z","merge_commit_sha":"48e19c69bf470517353101a445b8d824d1b3f7bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790/commits","review_comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790/comments","review_comment_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/790/comments","statuses_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/1e15f8923197e50811336bc4d323a406e0d704f0","head":{"label":"CapnClever:raven-compat-setup","ref":"raven-compat-setup","sha":"1e15f8923197e50811336bc4d323a406e0d704f0","user":{"login":"CapnClever","id":8853201,"avatar_url":"https://avatars.githubusercontent.com/u/8853201?v=3","gravatar_id":"","url":"https://api.github.com/users/CapnClever","html_url":"https://github.com/CapnClever","followers_url":"https://api.github.com/users/CapnClever/followers","following_url":"https://api.github.com/users/CapnClever/following{/other_user}","gists_url":"https://api.github.com/users/CapnClever/gists{/gist_id}","starred_url":"https://api.github.com/users/CapnClever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CapnClever/subscriptions","organizations_url":"https://api.github.com/users/CapnClever/orgs","repos_url":"https://api.github.com/users/CapnClever/repos","events_url":"https://api.github.com/users/CapnClever/events{/privacy}","received_events_url":"https://api.github.com/users/CapnClever/received_events","type":"User","site_admin":false},"repo":{"id":67605904,"name":"chocolate-doom","full_name":"CapnClever/chocolate-doom","owner":{"login":"CapnClever","id":8853201,"avatar_url":"https://avatars.githubusercontent.com/u/8853201?v=3","gravatar_id":"","url":"https://api.github.com/users/CapnClever","html_url":"https://github.com/CapnClever","followers_url":"https://api.github.com/users/CapnClever/followers","following_url":"https://api.github.com/users/CapnClever/following{/other_user}","gists_url":"https://api.github.com/users/CapnClever/gists{/gist_id}","starred_url":"https://api.github.com/users/CapnClever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CapnClever/subscriptions","organizations_url":"https://api.github.com/users/CapnClever/orgs","repos_url":"https://api.github.com/users/CapnClever/repos","events_url":"https://api.github.com/users/CapnClever/events{/privacy}","received_events_url":"https://api.github.com/users/CapnClever/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CapnClever/chocolate-doom","description":"Chocolate Doom is a Doom source port that is conservative and historically accurate.","fork":true,"url":"https://api.github.com/repos/CapnClever/chocolate-doom","forks_url":"https://api.github.com/repos/CapnClever/chocolate-doom/forks","keys_url":"https://api.github.com/repos/CapnClever/chocolate-doom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CapnClever/chocolate-doom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CapnClever/chocolate-doom/teams","hooks_url":"https://api.github.com/repos/CapnClever/chocolate-doom/hooks","issue_events_url":"https://api.github.com/repos/CapnClever/chocolate-doom/issues/events{/number}","events_url":"https://api.github.com/repos/CapnClever/chocolate-doom/events","assignees_url":"https://api.github.com/repos/CapnClever/chocolate-doom/assignees{/user}","branches_url":"https://api.github.com/repos/CapnClever/chocolate-doom/branches{/branch}","tags_url":"https://api.github.com/repos/CapnClever/chocolate-doom/tags","blobs_url":"https://api.github.com/repos/CapnClever/chocolate-doom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CapnClever/chocolate-doom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CapnClever/chocolate-doom/git/refs{/sha}","trees_url":"https://api.github.com/repos/CapnClever/chocolate-doom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CapnClever/chocolate-doom/statuses/{sha}","languages_url":"https://api.github.com/repos/CapnClever/chocolate-doom/languages","stargazers_url":"https://api.github.com/repos/CapnClever/chocolate-doom/stargazers","contributors_url":"https://api.github.com/repos/CapnClever/chocolate-doom/contributors","subscribers_url":"https://api.github.com/repos/CapnClever/chocolate-doom/subscribers","subscription_url":"https://api.github.com/repos/CapnClever/chocolate-doom/subscription","commits_url":"https://api.github.com/repos/CapnClever/chocolate-doom/commits{/sha}","git_commits_url":"https://api.github.com/repos/CapnClever/chocolate-doom/git/commits{/sha}","comments_url":"https://api.github.com/repos/CapnClever/chocolate-doom/comments{/number}","issue_comment_url":"https://api.github.com/repos/CapnClever/chocolate-doom/issues/comments{/number}","contents_url":"https://api.github.com/repos/CapnClever/chocolate-doom/contents/{+path}","compare_url":"https://api.github.com/repos/CapnClever/chocolate-doom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CapnClever/chocolate-doom/merges","archive_url":"https://api.github.com/repos/CapnClever/chocolate-doom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CapnClever/chocolate-doom/downloads","issues_url":"https://api.github.com/repos/CapnClever/chocolate-doom/issues{/number}","pulls_url":"https://api.github.com/repos/CapnClever/chocolate-doom/pulls{/number}","milestones_url":"https://api.github.com/repos/CapnClever/chocolate-doom/milestones{/number}","notifications_url":"https://api.github.com/repos/CapnClever/chocolate-doom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CapnClever/chocolate-doom/labels{/name}","releases_url":"https://api.github.com/repos/CapnClever/chocolate-doom/releases{/id}","deployments_url":"https://api.github.com/repos/CapnClever/chocolate-doom/deployments","created_at":"2016-09-07T12:48:58Z","updated_at":"2016-09-07T12:49:02Z","pushed_at":"2016-10-31T17:29:42Z","git_url":"git://github.com/CapnClever/chocolate-doom.git","ssh_url":"git@github.com:CapnClever/chocolate-doom.git","clone_url":"https://github.com/CapnClever/chocolate-doom.git","svn_url":"https://github.com/CapnClever/chocolate-doom","homepage":"https://www.chocolate-doom.org/","size":13984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolate-doom:master","ref":"master","sha":"15b8e6e1e47e4f733f862c16a5c18a3485bd22d4","user":{"login":"chocolate-doom","id":6140118,"avatar_url":"https://avatars.githubusercontent.com/u/6140118?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolate-doom","html_url":"https://github.com/chocolate-doom","followers_url":"https://api.github.com/users/chocolate-doom/followers","following_url":"https://api.github.com/users/chocolate-doom/following{/other_user}","gists_url":"https://api.github.com/users/chocolate-doom/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolate-doom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolate-doom/subscriptions","organizations_url":"https://api.github.com/users/chocolate-doom/orgs","repos_url":"https://api.github.com/users/chocolate-doom/repos","events_url":"https://api.github.com/users/chocolate-doom/events{/privacy}","received_events_url":"https://api.github.com/users/chocolate-doom/received_events","type":"Organization","site_admin":false},"repo":{"id":230912,"name":"chocolate-doom","full_name":"chocolate-doom/chocolate-doom","owner":{"login":"chocolate-doom","id":6140118,"avatar_url":"https://avatars.githubusercontent.com/u/6140118?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolate-doom","html_url":"https://github.com/chocolate-doom","followers_url":"https://api.github.com/users/chocolate-doom/followers","following_url":"https://api.github.com/users/chocolate-doom/following{/other_user}","gists_url":"https://api.github.com/users/chocolate-doom/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolate-doom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolate-doom/subscriptions","organizations_url":"https://api.github.com/users/chocolate-doom/orgs","repos_url":"https://api.github.com/users/chocolate-doom/repos","events_url":"https://api.github.com/users/chocolate-doom/events{/privacy}","received_events_url":"https://api.github.com/users/chocolate-doom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolate-doom/chocolate-doom","description":"Chocolate Doom is a Doom source port that is conservative and historically accurate.","fork":false,"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom","forks_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/forks","keys_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/teams","hooks_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/hooks","issue_events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/events{/number}","events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/events","assignees_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/assignees{/user}","branches_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/branches{/branch}","tags_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/tags","blobs_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/languages","stargazers_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/stargazers","contributors_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/contributors","subscribers_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/subscribers","subscription_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/subscription","commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/contents/{+path}","compare_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/merges","archive_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/downloads","issues_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues{/number}","pulls_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/labels{/name}","releases_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/releases{/id}","deployments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/deployments","created_at":"2009-06-18T22:15:53Z","updated_at":"2016-11-01T17:00:13Z","pushed_at":"2016-11-01T19:27:22Z","git_url":"git://github.com/chocolate-doom/chocolate-doom.git","ssh_url":"git@github.com:chocolate-doom/chocolate-doom.git","clone_url":"https://github.com/chocolate-doom/chocolate-doom.git","svn_url":"https://github.com/chocolate-doom/chocolate-doom","homepage":"https://www.chocolate-doom.org/","size":20721,"stargazers_count":233,"watchers_count":233,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":170,"forks":93,"open_issues":170,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790"},"html":{"href":"https://github.com/chocolate-doom/chocolate-doom/pull/790"},"issue":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/790"},"comments":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/1e15f8923197e50811336bc4d323a406e0d704f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fragglet","id":96821,"avatar_url":"https://avatars.githubusercontent.com/u/96821?v=3","gravatar_id":"","url":"https://api.github.com/users/fragglet","html_url":"https://github.com/fragglet","followers_url":"https://api.github.com/users/fragglet/followers","following_url":"https://api.github.com/users/fragglet/following{/other_user}","gists_url":"https://api.github.com/users/fragglet/gists{/gist_id}","starred_url":"https://api.github.com/users/fragglet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragglet/subscriptions","organizations_url":"https://api.github.com/users/fragglet/orgs","repos_url":"https://api.github.com/users/fragglet/repos","events_url":"https://api.github.com/users/fragglet/events{/privacy}","received_events_url":"https://api.github.com/users/fragglet/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":4,"additions":779,"deletions":647,"changed_files":11}}
{"actor":{"display_login":"fragglet"}}