{"action":"created","issue":{"url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/9","repository_url":"https://api.github.com/repos/cosign-io/recovery-js-lib","labels_url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/9/comments","events_url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/9/events","html_url":"https://github.com/cosign-io/recovery-js-lib/issues/9","id":165581667,"number":9,"title":"verify signatures before confirmation","user":{"login":"johannbarbie","id":659301,"avatar_url":"https://avatars.githubusercontent.com/u/659301?v=3","gravatar_id":"","url":"https://api.github.com/users/johannbarbie","html_url":"https://github.com/johannbarbie","followers_url":"https://api.github.com/users/johannbarbie/followers","following_url":"https://api.github.com/users/johannbarbie/following{/other_user}","gists_url":"https://api.github.com/users/johannbarbie/gists{/gist_id}","starred_url":"https://api.github.com/users/johannbarbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannbarbie/subscriptions","organizations_url":"https://api.github.com/users/johannbarbie/orgs","repos_url":"https://api.github.com/users/johannbarbie/repos","events_url":"https://api.github.com/users/johannbarbie/events{/privacy}","received_events_url":"https://api.github.com/users/johannbarbie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cosign-io/recovery-js-lib/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-14T14:54:52Z","updated_at":"2016-07-18T11:33:11Z","closed_at":null,"body":"transaction https://testnet.etherscan.io/tx/0x6bc1926cb34a57a22ae6adb78f92c9cf40712b68dd0d4d77eb5c9dd7713e88e2#eventlog\nfailed.\n\nthere is no reason not to check validity of signatures in node before sending the tx to blockchain and hopping that it works out. would safe cost for failed tx and put more responsibility on developer."},"comment":{"url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/comments/233305153","html_url":"https://github.com/cosign-io/recovery-js-lib/issues/9#issuecomment-233305153","issue_url":"https://api.github.com/repos/cosign-io/recovery-js-lib/issues/9","id":233305153,"user":{"login":"johannbarbie","id":659301,"avatar_url":"https://avatars.githubusercontent.com/u/659301?v=3","gravatar_id":"","url":"https://api.github.com/users/johannbarbie","html_url":"https://github.com/johannbarbie","followers_url":"https://api.github.com/users/johannbarbie/followers","following_url":"https://api.github.com/users/johannbarbie/following{/other_user}","gists_url":"https://api.github.com/users/johannbarbie/gists{/gist_id}","starred_url":"https://api.github.com/users/johannbarbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannbarbie/subscriptions","organizations_url":"https://api.github.com/users/johannbarbie/orgs","repos_url":"https://api.github.com/users/johannbarbie/repos","events_url":"https://api.github.com/users/johannbarbie/events{/privacy}","received_events_url":"https://api.github.com/users/johannbarbie/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T11:33:11Z","updated_at":"2016-07-18T11:33:11Z","body":"error produced on invalid sig:\n\n\"rTenant\": \"0xb77ccd4aef26b0486286d980bde38bc8fa356e98f353a2ebd7d9e518ed4c9d01\",\n\"sTenant\": \"0xa9c3028b7469a1a3cb7d1e67ef2abc8a66da4d1c58bcfa8f430d818908295fb\",\n\n2016-07-18T11:28:27.917Z\tbf423ed8-4cda-11e6-bdd2-59fadd0e84a7\tTypeError: Invalid hex string at TypeError (native) at Buffer.write (buffer.js:571:21) at fromString (buffer.js:113:26) at new Buffer (buffer.js:58:12) at /var/task/lib/index.js:310:21 at Object.callback (/var/task/node_modules/web3/lib/web3/function.js:118:9) at /var/task/node_modules/web3/lib/web3/method.js:142:25 at /var/task/node_modules/web3/lib/web3/requestmanager.js:89:9 at Web3ProviderEngine._inspectResponseForNewBlock (/var/task/node_modules/web3-provider-engine/index.js:220:12) at /var/task/node_modules/web3-provider-engine/index.js:129:14"}}
{"actor":{"display_login":"johannbarbie"}}