{"action":"created","issue":{"url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/119","repository_url":"https://api.github.com/repos/shprink/ionic-native-transitions","labels_url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/119/comments","events_url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/119/events","html_url":"https://github.com/shprink/ionic-native-transitions/issues/119","id":164869558,"number":119,"title":"\"same state transition are not possible\" is not API-consistent with ionic's `$state.go`","user":{"login":"jakub-g","id":1437027,"avatar_url":"https://avatars.githubusercontent.com/u/1437027?v=3","gravatar_id":"","url":"https://api.github.com/users/jakub-g","html_url":"https://github.com/jakub-g","followers_url":"https://api.github.com/users/jakub-g/followers","following_url":"https://api.github.com/users/jakub-g/following{/other_user}","gists_url":"https://api.github.com/users/jakub-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jakub-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakub-g/subscriptions","organizations_url":"https://api.github.com/users/jakub-g/orgs","repos_url":"https://api.github.com/users/jakub-g/repos","events_url":"https://api.github.com/users/jakub-g/events{/privacy}","received_events_url":"https://api.github.com/users/jakub-g/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/shprink/ionic-native-transitions/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-11T15:45:18Z","updated_at":"2016-07-12T12:33:59Z","closed_at":"2016-07-12T07:08:11Z","body":"https://github.com/shprink/ionic-native-transitions/blob/9192ce31215dd20b583bce126d3fff0d39e67ba4/lib/provider.js#L204\r\n\r\nThe code of `stateGo` is as follows\r\n\r\n```\r\nfunction stateGo(state = null, stateParams = {}, transitionOptions = null, stateOptions = {}) {\r\n            if (!state) {\r\n                $log.debug('[native transition] cannot change state without a state...');\r\n                return;\r\n            }\r\n            if ($state.current.name === state){\r\n                $log.debug('[native transition] same state transition are not possible');\r\n                return;\r\n            }\r\n            unregisterToStateChangeStartEvent();\r\n            transition(transitionOptions);\r\n            return $timeout(() => $state.go(state, stateParams, stateOptions));\r\n}\r\n```\r\n\r\nnote the part where the transition is abandoned if we go to the same state\r\n\r\n```\r\n            if ($state.current.name === state){\r\n                $log.debug('[native transition] same state transition are not possible');\r\n                return;\r\n            }\r\n```\r\n\r\nDue to this, we found a regression in our app, because we were doing something like this in some place:\r\n\r\n```\r\n$state.go(state, {}, {reload:true});\r\n```\r\n\r\nRight now when we do\r\n\r\n```\r\n$ionicNativeTransitions.stateGo(..., ..., ..., {reload:true})\r\n```\r\nthe `$state.go` reload is not triggered.\r\n\r\nI think for consistency, ionic-native-transitions should call `$state.go` in such case.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/comments/232033619","html_url":"https://github.com/shprink/ionic-native-transitions/issues/119#issuecomment-232033619","issue_url":"https://api.github.com/repos/shprink/ionic-native-transitions/issues/119","id":232033619,"user":{"login":"shprink","id":1388706,"avatar_url":"https://avatars.githubusercontent.com/u/1388706?v=3","gravatar_id":"","url":"https://api.github.com/users/shprink","html_url":"https://github.com/shprink","followers_url":"https://api.github.com/users/shprink/followers","following_url":"https://api.github.com/users/shprink/following{/other_user}","gists_url":"https://api.github.com/users/shprink/gists{/gist_id}","starred_url":"https://api.github.com/users/shprink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shprink/subscriptions","organizations_url":"https://api.github.com/users/shprink/orgs","repos_url":"https://api.github.com/users/shprink/repos","events_url":"https://api.github.com/users/shprink/events{/privacy}","received_events_url":"https://api.github.com/users/shprink/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T12:33:59Z","updated_at":"2016-07-12T12:33:59Z","body":"The version is now 1.0.0 with a breaking change. it is explained in the changelog https://github.com/shprink/ionic-native-transitions/blob/develop/CHANGELOG.md#100"}}
{"actor":{"display_login":"shprink"}}