{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/comments/52925041","id":52925041,"diff_hunk":"@@ -1,6 +1,6 @@\n <%-\n-if @is_dynamic and @allow_update.empty?\n-  raise(Puppet::ParseError, \"allow_update is empty for dynamic zone '#{name}'\")\n+if @is_dynamic and (@allow_update.empty? and @allow_update_cidr.empty?)\n+  raise(Puppet::ParseError, \"Both allow_update and allow_update_cidr are empty for dynamic zone '#{name}'\")","path":"templates/zone-master.erb","position":5,"original_position":5,"commit_id":"64b2d53f9be92887b154e31acab8c2203b766e9f","original_commit_id":"64b2d53f9be92887b154e31acab8c2203b766e9f","user":{"login":"vide","id":270267,"avatar_url":"https://avatars.githubusercontent.com/u/270267?v=3","gravatar_id":"","url":"https://api.github.com/users/vide","html_url":"https://github.com/vide","followers_url":"https://api.github.com/users/vide/followers","following_url":"https://api.github.com/users/vide/following{/other_user}","gists_url":"https://api.github.com/users/vide/gists{/gist_id}","starred_url":"https://api.github.com/users/vide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vide/subscriptions","organizations_url":"https://api.github.com/users/vide/orgs","repos_url":"https://api.github.com/users/vide/repos","events_url":"https://api.github.com/users/vide/events{/privacy}","received_events_url":"https://api.github.com/users/vide/received_events","type":"User","site_admin":false},"body":"Well, IMO it's a perfectly normal scenario: I can both accept updates from a secure network via CIDR validation and from an unsecure one with the secret key.\r\nI don't understand what you mean to use `is_a?(Array)`, do you mean instead of `.empty?` ?","created_at":"2016-02-15T17:26:24Z","updated_at":"2016-02-15T17:26:24Z","html_url":"https://github.com/camptocamp/puppet-bind/pull/64#discussion_r52925041","pull_request_url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/comments/52925041"},"html":{"href":"https://github.com/camptocamp/puppet-bind/pull/64#discussion_r52925041"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64","id":55634215,"html_url":"https://github.com/camptocamp/puppet-bind/pull/64","diff_url":"https://github.com/camptocamp/puppet-bind/pull/64.diff","patch_url":"https://github.com/camptocamp/puppet-bind/pull/64.patch","issue_url":"https://api.github.com/repos/camptocamp/puppet-bind/issues/64","number":64,"state":"open","locked":false,"title":"Add a new array allow_update_cidr in zone management","user":{"login":"vide","id":270267,"avatar_url":"https://avatars.githubusercontent.com/u/270267?v=3","gravatar_id":"","url":"https://api.github.com/users/vide","html_url":"https://github.com/vide","followers_url":"https://api.github.com/users/vide/followers","following_url":"https://api.github.com/users/vide/following{/other_user}","gists_url":"https://api.github.com/users/vide/gists{/gist_id}","starred_url":"https://api.github.com/users/vide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vide/subscriptions","organizations_url":"https://api.github.com/users/vide/orgs","repos_url":"https://api.github.com/users/vide/repos","events_url":"https://api.github.com/users/vide/events{/privacy}","received_events_url":"https://api.github.com/users/vide/received_events","type":"User","site_admin":false},"body":"Add a new, dedicated array so we can specify more allow-update values like networks, a part from keys, as per http://www.zytrax.com/books/dns/ch7/xfer.html#allow-update\r\n\r\nI created a new array to maintain backwards compatibility with the keys-only array and because they have slightly different syntax + different requirements","created_at":"2016-01-11T15:18:01Z","updated_at":"2016-02-15T17:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88c809fda66ba957f005eb07df7d7fdafa3474cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64/commits","review_comments_url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64/comments","review_comment_url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/puppet-bind/issues/64/comments","statuses_url":"https://api.github.com/repos/camptocamp/puppet-bind/statuses/64b2d53f9be92887b154e31acab8c2203b766e9f","head":{"label":"trovitsys:extend_allow_update","ref":"extend_allow_update","sha":"64b2d53f9be92887b154e31acab8c2203b766e9f","user":{"login":"trovitsys","id":11089155,"avatar_url":"https://avatars.githubusercontent.com/u/11089155?v=3","gravatar_id":"","url":"https://api.github.com/users/trovitsys","html_url":"https://github.com/trovitsys","followers_url":"https://api.github.com/users/trovitsys/followers","following_url":"https://api.github.com/users/trovitsys/following{/other_user}","gists_url":"https://api.github.com/users/trovitsys/gists{/gist_id}","starred_url":"https://api.github.com/users/trovitsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trovitsys/subscriptions","organizations_url":"https://api.github.com/users/trovitsys/orgs","repos_url":"https://api.github.com/users/trovitsys/repos","events_url":"https://api.github.com/users/trovitsys/events{/privacy}","received_events_url":"https://api.github.com/users/trovitsys/received_events","type":"Organization","site_admin":false},"repo":{"id":32322001,"name":"puppet-bind","full_name":"trovitsys/puppet-bind","owner":{"login":"trovitsys","id":11089155,"avatar_url":"https://avatars.githubusercontent.com/u/11089155?v=3","gravatar_id":"","url":"https://api.github.com/users/trovitsys","html_url":"https://github.com/trovitsys","followers_url":"https://api.github.com/users/trovitsys/followers","following_url":"https://api.github.com/users/trovitsys/following{/other_user}","gists_url":"https://api.github.com/users/trovitsys/gists{/gist_id}","starred_url":"https://api.github.com/users/trovitsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trovitsys/subscriptions","organizations_url":"https://api.github.com/users/trovitsys/orgs","repos_url":"https://api.github.com/users/trovitsys/repos","events_url":"https://api.github.com/users/trovitsys/events{/privacy}","received_events_url":"https://api.github.com/users/trovitsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trovitsys/puppet-bind","description":"Installs and configures Bind9 domain name server","fork":true,"url":"https://api.github.com/repos/trovitsys/puppet-bind","forks_url":"https://api.github.com/repos/trovitsys/puppet-bind/forks","keys_url":"https://api.github.com/repos/trovitsys/puppet-bind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trovitsys/puppet-bind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trovitsys/puppet-bind/teams","hooks_url":"https://api.github.com/repos/trovitsys/puppet-bind/hooks","issue_events_url":"https://api.github.com/repos/trovitsys/puppet-bind/issues/events{/number}","events_url":"https://api.github.com/repos/trovitsys/puppet-bind/events","assignees_url":"https://api.github.com/repos/trovitsys/puppet-bind/assignees{/user}","branches_url":"https://api.github.com/repos/trovitsys/puppet-bind/branches{/branch}","tags_url":"https://api.github.com/repos/trovitsys/puppet-bind/tags","blobs_url":"https://api.github.com/repos/trovitsys/puppet-bind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trovitsys/puppet-bind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trovitsys/puppet-bind/git/refs{/sha}","trees_url":"https://api.github.com/repos/trovitsys/puppet-bind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trovitsys/puppet-bind/statuses/{sha}","languages_url":"https://api.github.com/repos/trovitsys/puppet-bind/languages","stargazers_url":"https://api.github.com/repos/trovitsys/puppet-bind/stargazers","contributors_url":"https://api.github.com/repos/trovitsys/puppet-bind/contributors","subscribers_url":"https://api.github.com/repos/trovitsys/puppet-bind/subscribers","subscription_url":"https://api.github.com/repos/trovitsys/puppet-bind/subscription","commits_url":"https://api.github.com/repos/trovitsys/puppet-bind/commits{/sha}","git_commits_url":"https://api.github.com/repos/trovitsys/puppet-bind/git/commits{/sha}","comments_url":"https://api.github.com/repos/trovitsys/puppet-bind/comments{/number}","issue_comment_url":"https://api.github.com/repos/trovitsys/puppet-bind/issues/comments{/number}","contents_url":"https://api.github.com/repos/trovitsys/puppet-bind/contents/{+path}","compare_url":"https://api.github.com/repos/trovitsys/puppet-bind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trovitsys/puppet-bind/merges","archive_url":"https://api.github.com/repos/trovitsys/puppet-bind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trovitsys/puppet-bind/downloads","issues_url":"https://api.github.com/repos/trovitsys/puppet-bind/issues{/number}","pulls_url":"https://api.github.com/repos/trovitsys/puppet-bind/pulls{/number}","milestones_url":"https://api.github.com/repos/trovitsys/puppet-bind/milestones{/number}","notifications_url":"https://api.github.com/repos/trovitsys/puppet-bind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trovitsys/puppet-bind/labels{/name}","releases_url":"https://api.github.com/repos/trovitsys/puppet-bind/releases{/id}","deployments_url":"https://api.github.com/repos/trovitsys/puppet-bind/deployments","created_at":"2015-03-16T12:01:18Z","updated_at":"2016-01-11T14:09:03Z","pushed_at":"2016-01-11T15:37:59Z","git_url":"git://github.com/trovitsys/puppet-bind.git","ssh_url":"git@github.com:trovitsys/puppet-bind.git","clone_url":"https://github.com/trovitsys/puppet-bind.git","svn_url":"https://github.com/trovitsys/puppet-bind","homepage":"","size":268,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"0d90df25d3e8b5be6e56af7797587d7c1bc32324","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":1081874,"name":"puppet-bind","full_name":"camptocamp/puppet-bind","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/puppet-bind","description":"Installs and configures Bind9 domain name server","fork":false,"url":"https://api.github.com/repos/camptocamp/puppet-bind","forks_url":"https://api.github.com/repos/camptocamp/puppet-bind/forks","keys_url":"https://api.github.com/repos/camptocamp/puppet-bind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/puppet-bind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/puppet-bind/teams","hooks_url":"https://api.github.com/repos/camptocamp/puppet-bind/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/puppet-bind/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/puppet-bind/events","assignees_url":"https://api.github.com/repos/camptocamp/puppet-bind/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/puppet-bind/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/puppet-bind/tags","blobs_url":"https://api.github.com/repos/camptocamp/puppet-bind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/puppet-bind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/puppet-bind/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/puppet-bind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/puppet-bind/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/puppet-bind/languages","stargazers_url":"https://api.github.com/repos/camptocamp/puppet-bind/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/puppet-bind/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/puppet-bind/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/puppet-bind/subscription","commits_url":"https://api.github.com/repos/camptocamp/puppet-bind/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/puppet-bind/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/puppet-bind/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/puppet-bind/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/puppet-bind/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/puppet-bind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/puppet-bind/merges","archive_url":"https://api.github.com/repos/camptocamp/puppet-bind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/puppet-bind/downloads","issues_url":"https://api.github.com/repos/camptocamp/puppet-bind/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/puppet-bind/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/puppet-bind/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/puppet-bind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/puppet-bind/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/puppet-bind/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/puppet-bind/deployments","created_at":"2010-11-15T13:17:27Z","updated_at":"2015-12-08T20:27:53Z","pushed_at":"2016-02-15T08:33:49Z","git_url":"git://github.com/camptocamp/puppet-bind.git","ssh_url":"git@github.com:camptocamp/puppet-bind.git","clone_url":"https://github.com/camptocamp/puppet-bind.git","svn_url":"https://github.com/camptocamp/puppet-bind","homepage":"","size":315,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":7,"forks":46,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64"},"html":{"href":"https://github.com/camptocamp/puppet-bind/pull/64"},"issue":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/issues/64"},"comments":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/puppet-bind/statuses/64b2d53f9be92887b154e31acab8c2203b766e9f"}}}}