{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/973","repository_url":"https://api.github.com/repos/apache/incubator-zeppelin","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/973/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/973/comments","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/973/events","html_url":"https://github.com/apache/incubator-zeppelin/pull/973","id":159047813,"number":973,"title":"[ZEPPELIN-973, ZEPPELIN-954] Table rendering improvements","user":{"login":"jasonxh","id":6090732,"avatar_url":"https://avatars.githubusercontent.com/u/6090732?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonxh","html_url":"https://github.com/jasonxh","followers_url":"https://api.github.com/users/jasonxh/followers","following_url":"https://api.github.com/users/jasonxh/following{/other_user}","gists_url":"https://api.github.com/users/jasonxh/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonxh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonxh/subscriptions","organizations_url":"https://api.github.com/users/jasonxh/orgs","repos_url":"https://api.github.com/users/jasonxh/repos","events_url":"https://api.github.com/users/jasonxh/events{/privacy}","received_events_url":"https://api.github.com/users/jasonxh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-07T23:31:20Z","updated_at":"2016-06-08T05:38:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/973","html_url":"https://github.com/apache/incubator-zeppelin/pull/973","diff_url":"https://github.com/apache/incubator-zeppelin/pull/973.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/973.patch"},"body":"### What is this PR for?\r\nThis PR fixes a few minor issues from the recent introduction of Handsontable for table rendering (https://github.com/apache/incubator-zeppelin/pull/858):\r\n* Render up to 5 digits after decimal point instead of always rounding to integers\r\n* Allow visual selection of table cells (for copy)\r\n* Default to text renderer instead of numeric renderer\r\n\r\n### What type of PR is it?\r\nBug Fix, Improvement\r\n\r\n### Todos\r\n\r\n### What is the Jira issue?\r\n* https://issues.apache.org/jira/browse/ZEPPELIN-973\r\n* https://issues.apache.org/jira/browse/ZEPPELIN-954\r\n\r\n### How should this be tested?\r\nOutput some rows with floating point numbers and render them in a table.\r\n\r\n### Screenshots (if appropriate)\r\n\r\n### Questions:\r\n* Does the licenses files need update? No\r\n* Is there breaking changes for older versions? No\r\n* Does this needs documentation? No"},"comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments/224493025","html_url":"https://github.com/apache/incubator-zeppelin/pull/973#issuecomment-224493025","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/973","id":224493025,"user":{"login":"corneadoug","id":710411,"avatar_url":"https://avatars.githubusercontent.com/u/710411?v=3","gravatar_id":"","url":"https://api.github.com/users/corneadoug","html_url":"https://github.com/corneadoug","followers_url":"https://api.github.com/users/corneadoug/followers","following_url":"https://api.github.com/users/corneadoug/following{/other_user}","gists_url":"https://api.github.com/users/corneadoug/gists{/gist_id}","starred_url":"https://api.github.com/users/corneadoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corneadoug/subscriptions","organizations_url":"https://api.github.com/users/corneadoug/orgs","repos_url":"https://api.github.com/users/corneadoug/repos","events_url":"https://api.github.com/users/corneadoug/events{/privacy}","received_events_url":"https://api.github.com/users/corneadoug/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T05:38:01Z","updated_at":"2016-06-08T05:38:01Z","body":"@jasonxh Thanks for the fix\r\nNext time if possible, please add a simple code example for testing, like:\r\n```\r\nprint(s\"\"\"%table\r\nname\\tsize\r\nsun\\t127.6\r\nmoon\\t0.6458\r\ngerard\\t45.234856803\"\"\")\r\n```\r\nIt can save a lot of time to the reviewer :)\r\n\r\nI tested and the decimal formating is working great, HTML and string rendering is still good too.\r\n\r\nRegarding the selection cell for copy, I would advise to use both:\r\n```\r\nfragmentSelection: true,\r\ndisableVisualSelection: true,\r\n```\r\n\r\nThis would remove the cell selection (with the border), and allow selection of the table text visually.\r\n![screen shot 2016-06-08 at 2 36 59 pm](https://cloud.githubusercontent.com/assets/710411/15883785/7c5af448-2d86-11e6-9565-bcc30c29877f.png)\r\n\r\nSo except for that small configuration change, LGTM\r\n"}}
{"actor":{"display_login":"corneadoug"}}