{"action":"created","comment":{"url":"https://api.github.com/repos/lyft/PynamoDB/pulls/comments/84188122","pull_request_review_id":4980958,"id":84188122,"diff_hunk":"@@ -523,7 +523,10 @@ def deserialize(self, values):\n \n         lst_of_type = []\n         for item in deserialized_lst:\n-            lst_of_type.append(self.element_type(**item))\n+            if issubclass(item.__class__, MapAttribute):\n+                lst_of_type.append(self.element_type(**item))\n+            else:\n+                lst_of_type.append(item)","path":"pynamodb/attributes.py","position":8,"original_position":8,"commit_id":"59fc807c0957d28fa046b029178fdbc5a5cf07f5","original_commit_id":"59fc807c0957d28fa046b029178fdbc5a5cf07f5","user":{"login":"jmphilli","id":204245,"avatar_url":"https://avatars.githubusercontent.com/u/204245?v=3","gravatar_id":"","url":"https://api.github.com/users/jmphilli","html_url":"https://github.com/jmphilli","followers_url":"https://api.github.com/users/jmphilli/followers","following_url":"https://api.github.com/users/jmphilli/following{/other_user}","gists_url":"https://api.github.com/users/jmphilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmphilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmphilli/subscriptions","organizations_url":"https://api.github.com/users/jmphilli/orgs","repos_url":"https://api.github.com/users/jmphilli/repos","events_url":"https://api.github.com/users/jmphilli/events{/privacy}","received_events_url":"https://api.github.com/users/jmphilli/received_events","type":"User","site_admin":false},"body":"cc @danielhochman -- if the `of` type in the attribute passed in the constructor of the `ListAttribute` is not a subclass of `MapAttribute` then we don't want to explode the item (`**item` == explode)","created_at":"2016-10-19T23:23:50Z","updated_at":"2016-10-19T23:23:50Z","html_url":"https://github.com/lyft/PynamoDB/pull/7#discussion_r84188122","pull_request_url":"https://api.github.com/repos/lyft/PynamoDB/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/comments/84188122"},"html":{"href":"https://github.com/lyft/PynamoDB/pull/7#discussion_r84188122"},"pull_request":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/lyft/PynamoDB/pulls/7","id":90108255,"html_url":"https://github.com/lyft/PynamoDB/pull/7","diff_url":"https://github.com/lyft/PynamoDB/pull/7.diff","patch_url":"https://github.com/lyft/PynamoDB/pull/7.patch","issue_url":"https://api.github.com/repos/lyft/PynamoDB/issues/7","number":7,"state":"open","locked":false,"title":"Fix bug when deserializing a list of a non-map attribute","user":{"login":"berdim99","id":1106201,"avatar_url":"https://avatars.githubusercontent.com/u/1106201?v=3","gravatar_id":"","url":"https://api.github.com/users/berdim99","html_url":"https://github.com/berdim99","followers_url":"https://api.github.com/users/berdim99/followers","following_url":"https://api.github.com/users/berdim99/following{/other_user}","gists_url":"https://api.github.com/users/berdim99/gists{/gist_id}","starred_url":"https://api.github.com/users/berdim99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdim99/subscriptions","organizations_url":"https://api.github.com/users/berdim99/orgs","repos_url":"https://api.github.com/users/berdim99/repos","events_url":"https://api.github.com/users/berdim99/events{/privacy}","received_events_url":"https://api.github.com/users/berdim99/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-19T23:17:42Z","updated_at":"2016-10-19T23:23:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4506008e3d88c798033f44855fe0053770b907a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lyft/PynamoDB/pulls/7/commits","review_comments_url":"https://api.github.com/repos/lyft/PynamoDB/pulls/7/comments","review_comment_url":"https://api.github.com/repos/lyft/PynamoDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/PynamoDB/issues/7/comments","statuses_url":"https://api.github.com/repos/lyft/PynamoDB/statuses/59fc807c0957d28fa046b029178fdbc5a5cf07f5","head":{"label":"lyft:list_update_bug","ref":"list_update_bug","sha":"59fc807c0957d28fa046b029178fdbc5a5cf07f5","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":36536656,"name":"PynamoDB","full_name":"lyft/PynamoDB","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/PynamoDB","description":"A pythonic interface to Amazon's DynamoDB","fork":true,"url":"https://api.github.com/repos/lyft/PynamoDB","forks_url":"https://api.github.com/repos/lyft/PynamoDB/forks","keys_url":"https://api.github.com/repos/lyft/PynamoDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/PynamoDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/PynamoDB/teams","hooks_url":"https://api.github.com/repos/lyft/PynamoDB/hooks","issue_events_url":"https://api.github.com/repos/lyft/PynamoDB/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/PynamoDB/events","assignees_url":"https://api.github.com/repos/lyft/PynamoDB/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/PynamoDB/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/PynamoDB/tags","blobs_url":"https://api.github.com/repos/lyft/PynamoDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/PynamoDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/PynamoDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/PynamoDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/PynamoDB/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/PynamoDB/languages","stargazers_url":"https://api.github.com/repos/lyft/PynamoDB/stargazers","contributors_url":"https://api.github.com/repos/lyft/PynamoDB/contributors","subscribers_url":"https://api.github.com/repos/lyft/PynamoDB/subscribers","subscription_url":"https://api.github.com/repos/lyft/PynamoDB/subscription","commits_url":"https://api.github.com/repos/lyft/PynamoDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/PynamoDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/PynamoDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/PynamoDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/PynamoDB/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/PynamoDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/PynamoDB/merges","archive_url":"https://api.github.com/repos/lyft/PynamoDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/PynamoDB/downloads","issues_url":"https://api.github.com/repos/lyft/PynamoDB/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/PynamoDB/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/PynamoDB/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/PynamoDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/PynamoDB/labels{/name}","releases_url":"https://api.github.com/repos/lyft/PynamoDB/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/PynamoDB/deployments","created_at":"2015-05-30T00:47:26Z","updated_at":"2016-03-26T00:44:38Z","pushed_at":"2016-10-19T23:17:42Z","git_url":"git://github.com/lyft/PynamoDB.git","ssh_url":"git@github.com:lyft/PynamoDB.git","clone_url":"https://github.com/lyft/PynamoDB.git","svn_url":"https://github.com/lyft/PynamoDB","homepage":"http://pynamodb.readthedocs.org","size":892,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"devel"}},"base":{"label":"lyft:devel","ref":"devel","sha":"73549174551d49f39d6d65666956aabe8397c5ec","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":36536656,"name":"PynamoDB","full_name":"lyft/PynamoDB","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/PynamoDB","description":"A pythonic interface to Amazon's DynamoDB","fork":true,"url":"https://api.github.com/repos/lyft/PynamoDB","forks_url":"https://api.github.com/repos/lyft/PynamoDB/forks","keys_url":"https://api.github.com/repos/lyft/PynamoDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/PynamoDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/PynamoDB/teams","hooks_url":"https://api.github.com/repos/lyft/PynamoDB/hooks","issue_events_url":"https://api.github.com/repos/lyft/PynamoDB/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/PynamoDB/events","assignees_url":"https://api.github.com/repos/lyft/PynamoDB/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/PynamoDB/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/PynamoDB/tags","blobs_url":"https://api.github.com/repos/lyft/PynamoDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/PynamoDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/PynamoDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/PynamoDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/PynamoDB/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/PynamoDB/languages","stargazers_url":"https://api.github.com/repos/lyft/PynamoDB/stargazers","contributors_url":"https://api.github.com/repos/lyft/PynamoDB/contributors","subscribers_url":"https://api.github.com/repos/lyft/PynamoDB/subscribers","subscription_url":"https://api.github.com/repos/lyft/PynamoDB/subscription","commits_url":"https://api.github.com/repos/lyft/PynamoDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/PynamoDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/PynamoDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/PynamoDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/PynamoDB/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/PynamoDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/PynamoDB/merges","archive_url":"https://api.github.com/repos/lyft/PynamoDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/PynamoDB/downloads","issues_url":"https://api.github.com/repos/lyft/PynamoDB/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/PynamoDB/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/PynamoDB/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/PynamoDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/PynamoDB/labels{/name}","releases_url":"https://api.github.com/repos/lyft/PynamoDB/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/PynamoDB/deployments","created_at":"2015-05-30T00:47:26Z","updated_at":"2016-03-26T00:44:38Z","pushed_at":"2016-10-19T23:17:42Z","git_url":"git://github.com/lyft/PynamoDB.git","ssh_url":"git@github.com:lyft/PynamoDB.git","clone_url":"https://github.com/lyft/PynamoDB.git","svn_url":"https://github.com/lyft/PynamoDB","homepage":"http://pynamodb.readthedocs.org","size":892,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/7"},"html":{"href":"https://github.com/lyft/PynamoDB/pull/7"},"issue":{"href":"https://api.github.com/repos/lyft/PynamoDB/issues/7"},"comments":{"href":"https://api.github.com/repos/lyft/PynamoDB/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/PynamoDB/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/PynamoDB/statuses/59fc807c0957d28fa046b029178fdbc5a5cf07f5"}}}}
{"actor":{"display_login":"jmphilli"}}