{"action":"created","issue":{"url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/8","repository_url":"https://api.github.com/repos/calipho-sib/feature-viewer","labels_url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/8/comments","events_url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/8/events","html_url":"https://github.com/calipho-sib/feature-viewer/issues/8","id":155708196,"number":8,"title":"Clean disposal of feature-viewer instance","user":{"login":"fredludlow","id":900535,"avatar_url":"https://avatars.githubusercontent.com/u/900535?v=3","gravatar_id":"","url":"https://api.github.com/users/fredludlow","html_url":"https://github.com/fredludlow","followers_url":"https://api.github.com/users/fredludlow/followers","following_url":"https://api.github.com/users/fredludlow/following{/other_user}","gists_url":"https://api.github.com/users/fredludlow/gists{/gist_id}","starred_url":"https://api.github.com/users/fredludlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredludlow/subscriptions","organizations_url":"https://api.github.com/users/fredludlow/orgs","repos_url":"https://api.github.com/users/fredludlow/repos","events_url":"https://api.github.com/users/fredludlow/events{/privacy}","received_events_url":"https://api.github.com/users/fredludlow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-19T10:52:03Z","updated_at":"2016-05-24T08:53:29Z","closed_at":null,"body":"This is somewhat related to the use-case mentioned in #5. At them moment I'm allowing users to toggle features, implemented by deleting and recreating the container element, then recreating a feature-viewer instance. This is (perhaps unsurprisingly) slowly leaking memory - I guess due to circular references between DOM and JS created by event handlers. Would it possible (or is there already) a convenient \"dispose\" function on the feature-viewer that would remove these?\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/comments/221206546","html_url":"https://github.com/calipho-sib/feature-viewer/issues/8#issuecomment-221206546","issue_url":"https://api.github.com/repos/calipho-sib/feature-viewer/issues/8","id":221206546,"user":{"login":"fredludlow","id":900535,"avatar_url":"https://avatars.githubusercontent.com/u/900535?v=3","gravatar_id":"","url":"https://api.github.com/users/fredludlow","html_url":"https://github.com/fredludlow","followers_url":"https://api.github.com/users/fredludlow/followers","following_url":"https://api.github.com/users/fredludlow/following{/other_user}","gists_url":"https://api.github.com/users/fredludlow/gists{/gist_id}","starred_url":"https://api.github.com/users/fredludlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredludlow/subscriptions","organizations_url":"https://api.github.com/users/fredludlow/orgs","repos_url":"https://api.github.com/users/fredludlow/repos","events_url":"https://api.github.com/users/fredludlow/events{/privacy}","received_events_url":"https://api.github.com/users/fredludlow/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T08:53:29Z","updated_at":"2016-05-24T08:53:29Z","body":"Ah, I hadn't actually thought of doing it like that...\r\n\r\nMy use-case is I have hundreds of features (rows) most of which contain very sparse data, so I have a single summary row and a (separate) widget to turn on and off the individual rows. Toggling a row currently causes a complete re-creation of the viewer, which resets the zoom - so I was hoping I could use `offset` to supply an initial zoom (and hide the re-creation from the user), but that actually stops you being able to zoom out beyond the range specified in `offset`. \r\n\r\nAn ability to toggle features/rows without recreating the instance would be good, but that does look like a bigger change!\r\n\r\nFred\r\n\r\n"}}
{"actor":{"display_login":"fredludlow"}}