{"action":"created","comment":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/comments/70527806","id":70527806,"diff_hunk":"@@ -26,14 +27,14 @@\n   &__foreground,\n   &__foreground-circle,\n   &__background {\n-    width: 100%;\n-    height: 100%;\n     position: absolute;\n+    height: 100%;\n+    width: 100%;\n   }\n }\n \n .md-ripple__foreground {\n-  &-active {\n+  &-bounded-active {\n   transition: transform 300ms cubic-bezier(0.157, 0.72, 0.386, 0.987);","path":"packages/mdl-ripple/mdl-ripple.scss","position":23,"original_position":23,"commit_id":"a6ecf5cbd462ec178d2b6a01ef35eb8d6e73bfe6","original_commit_id":"a6ecf5cbd462ec178d2b6a01ef35eb8d6e73bfe6","user":{"login":"traviskaufman","id":1185269,"avatar_url":"https://avatars.githubusercontent.com/u/1185269?v=3","gravatar_id":"","url":"https://api.github.com/users/traviskaufman","html_url":"https://github.com/traviskaufman","followers_url":"https://api.github.com/users/traviskaufman/followers","following_url":"https://api.github.com/users/traviskaufman/following{/other_user}","gists_url":"https://api.github.com/users/traviskaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/traviskaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviskaufman/subscriptions","organizations_url":"https://api.github.com/users/traviskaufman/orgs","repos_url":"https://api.github.com/users/traviskaufman/repos","events_url":"https://api.github.com/users/traviskaufman/events{/privacy}","received_events_url":"https://api.github.com/users/traviskaufman/received_events","type":"User","site_admin":false},"body":"If these are modifier classes, I believe the convention is to use two dashes between the base class name and the modifier, e.g. `&--bounded-active`.\r\n\r\nFurthermore is there a reason to have compound modifier classes such as `bounded-active` rather than just having two distinct modifier classes? e.g. `&--bounded#{&}--active` ? ","created_at":"2016-07-12T21:41:06Z","updated_at":"2016-07-12T21:41:06Z","html_url":"https://github.com/google/material-design-lite/pull/4551#discussion_r70527806","pull_request_url":"https://api.github.com/repos/google/material-design-lite/pulls/4551","_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments/70527806"},"html":{"href":"https://github.com/google/material-design-lite/pull/4551#discussion_r70527806"},"pull_request":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4551"}}},"pull_request":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/4551","id":77186243,"html_url":"https://github.com/google/material-design-lite/pull/4551","diff_url":"https://github.com/google/material-design-lite/pull/4551.diff","patch_url":"https://github.com/google/material-design-lite/pull/4551.patch","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/4551","number":4551,"state":"open","locked":false,"title":"[mdl-ripple] Update to mixin pattern and some cleanup.","user":{"login":"rfru","id":1762133,"avatar_url":"https://avatars.githubusercontent.com/u/1762133?v=3","gravatar_id":"","url":"https://api.github.com/users/rfru","html_url":"https://github.com/rfru","followers_url":"https://api.github.com/users/rfru/followers","following_url":"https://api.github.com/users/rfru/following{/other_user}","gists_url":"https://api.github.com/users/rfru/gists{/gist_id}","starred_url":"https://api.github.com/users/rfru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfru/subscriptions","organizations_url":"https://api.github.com/users/rfru/orgs","repos_url":"https://api.github.com/users/rfru/repos","events_url":"https://api.github.com/users/rfru/events{/privacy}","received_events_url":"https://api.github.com/users/rfru/received_events","type":"User","site_admin":false},"body":"#4467 ","created_at":"2016-07-12T20:31:37Z","updated_at":"2016-07-12T21:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e892333bb8d4be4e9bf6d384bf50987a6f38b27","assignee":{"login":"traviskaufman","id":1185269,"avatar_url":"https://avatars.githubusercontent.com/u/1185269?v=3","gravatar_id":"","url":"https://api.github.com/users/traviskaufman","html_url":"https://github.com/traviskaufman","followers_url":"https://api.github.com/users/traviskaufman/followers","following_url":"https://api.github.com/users/traviskaufman/following{/other_user}","gists_url":"https://api.github.com/users/traviskaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/traviskaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviskaufman/subscriptions","organizations_url":"https://api.github.com/users/traviskaufman/orgs","repos_url":"https://api.github.com/users/traviskaufman/repos","events_url":"https://api.github.com/users/traviskaufman/events{/privacy}","received_events_url":"https://api.github.com/users/traviskaufman/received_events","type":"User","site_admin":false},"assignees":[{"login":"traviskaufman","id":1185269,"avatar_url":"https://avatars.githubusercontent.com/u/1185269?v=3","gravatar_id":"","url":"https://api.github.com/users/traviskaufman","html_url":"https://github.com/traviskaufman","followers_url":"https://api.github.com/users/traviskaufman/followers","following_url":"https://api.github.com/users/traviskaufman/following{/other_user}","gists_url":"https://api.github.com/users/traviskaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/traviskaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviskaufman/subscriptions","organizations_url":"https://api.github.com/users/traviskaufman/orgs","repos_url":"https://api.github.com/users/traviskaufman/repos","events_url":"https://api.github.com/users/traviskaufman/events{/privacy}","received_events_url":"https://api.github.com/users/traviskaufman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/material-design-lite/milestones/13","html_url":"https://github.com/google/material-design-lite/milestones/V2%20Alpha","labels_url":"https://api.github.com/repos/google/material-design-lite/milestones/13/labels","id":1855481,"number":13,"title":"V2 Alpha","description":"","creator":{"login":"traviskaufman","id":1185269,"avatar_url":"https://avatars.githubusercontent.com/u/1185269?v=3","gravatar_id":"","url":"https://api.github.com/users/traviskaufman","html_url":"https://github.com/traviskaufman","followers_url":"https://api.github.com/users/traviskaufman/followers","following_url":"https://api.github.com/users/traviskaufman/following{/other_user}","gists_url":"https://api.github.com/users/traviskaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/traviskaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviskaufman/subscriptions","organizations_url":"https://api.github.com/users/traviskaufman/orgs","repos_url":"https://api.github.com/users/traviskaufman/repos","events_url":"https://api.github.com/users/traviskaufman/events{/privacy}","received_events_url":"https://api.github.com/users/traviskaufman/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":1,"state":"open","created_at":"2016-06-29T16:06:08Z","updated_at":"2016-07-12T20:31:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/material-design-lite/pulls/4551/commits","review_comments_url":"https://api.github.com/repos/google/material-design-lite/pulls/4551/comments","review_comment_url":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/4551/comments","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/a6ecf5cbd462ec178d2b6a01ef35eb8d6e73bfe6","head":{"label":"rfru:master","ref":"master","sha":"a6ecf5cbd462ec178d2b6a01ef35eb8d6e73bfe6","user":{"login":"rfru","id":1762133,"avatar_url":"https://avatars.githubusercontent.com/u/1762133?v=3","gravatar_id":"","url":"https://api.github.com/users/rfru","html_url":"https://github.com/rfru","followers_url":"https://api.github.com/users/rfru/followers","following_url":"https://api.github.com/users/rfru/following{/other_user}","gists_url":"https://api.github.com/users/rfru/gists{/gist_id}","starred_url":"https://api.github.com/users/rfru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfru/subscriptions","organizations_url":"https://api.github.com/users/rfru/orgs","repos_url":"https://api.github.com/users/rfru/repos","events_url":"https://api.github.com/users/rfru/events{/privacy}","received_events_url":"https://api.github.com/users/rfru/received_events","type":"User","site_admin":false},"repo":{"id":63078535,"name":"material-design-lite","full_name":"rfru/material-design-lite","owner":{"login":"rfru","id":1762133,"avatar_url":"https://avatars.githubusercontent.com/u/1762133?v=3","gravatar_id":"","url":"https://api.github.com/users/rfru","html_url":"https://github.com/rfru","followers_url":"https://api.github.com/users/rfru/followers","following_url":"https://api.github.com/users/rfru/following{/other_user}","gists_url":"https://api.github.com/users/rfru/gists{/gist_id}","starred_url":"https://api.github.com/users/rfru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfru/subscriptions","organizations_url":"https://api.github.com/users/rfru/orgs","repos_url":"https://api.github.com/users/rfru/repos","events_url":"https://api.github.com/users/rfru/events{/privacy}","received_events_url":"https://api.github.com/users/rfru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfru/material-design-lite","description":"Material Design Components in HTML/CSS/JS","fork":true,"url":"https://api.github.com/repos/rfru/material-design-lite","forks_url":"https://api.github.com/repos/rfru/material-design-lite/forks","keys_url":"https://api.github.com/repos/rfru/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfru/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfru/material-design-lite/teams","hooks_url":"https://api.github.com/repos/rfru/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/rfru/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/rfru/material-design-lite/events","assignees_url":"https://api.github.com/repos/rfru/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/rfru/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/rfru/material-design-lite/tags","blobs_url":"https://api.github.com/repos/rfru/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfru/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfru/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfru/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfru/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/rfru/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/rfru/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/rfru/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/rfru/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/rfru/material-design-lite/subscription","commits_url":"https://api.github.com/repos/rfru/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfru/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfru/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfru/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfru/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/rfru/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfru/material-design-lite/merges","archive_url":"https://api.github.com/repos/rfru/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfru/material-design-lite/downloads","issues_url":"https://api.github.com/repos/rfru/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/rfru/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/rfru/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/rfru/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfru/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/rfru/material-design-lite/releases{/id}","deployments_url":"https://api.github.com/repos/rfru/material-design-lite/deployments","created_at":"2016-07-11T15:14:27Z","updated_at":"2016-07-11T15:14:30Z","pushed_at":"2016-07-12T20:26:11Z","git_url":"git://github.com/rfru/material-design-lite.git","ssh_url":"git@github.com:rfru/material-design-lite.git","clone_url":"https://github.com/rfru/material-design-lite.git","svn_url":"https://github.com/rfru/material-design-lite","homepage":"http://getmdl.io","size":55714,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mdl-1.x"}},"base":{"label":"google:master","ref":"master","sha":"9a1d46eb985459631e7474c38f4135eda2957de8","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","deployments_url":"https://api.github.com/repos/google/material-design-lite/deployments","created_at":"2015-01-14T22:01:33Z","updated_at":"2016-07-12T21:21:34Z","pushed_at":"2016-07-12T20:31:38Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":62761,"stargazers_count":21944,"watchers_count":21944,"language":"HTML","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3612,"mirror_url":null,"open_issues_count":322,"forks":3612,"open_issues":322,"watchers":21944,"default_branch":"mdl-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4551"},"html":{"href":"https://github.com/google/material-design-lite/pull/4551"},"issue":{"href":"https://api.github.com/repos/google/material-design-lite/issues/4551"},"comments":{"href":"https://api.github.com/repos/google/material-design-lite/issues/4551/comments"},"review_comments":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4551/comments"},"review_comment":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4551/commits"},"statuses":{"href":"https://api.github.com/repos/google/material-design-lite/statuses/a6ecf5cbd462ec178d2b6a01ef35eb8d6e73bfe6"}}}}
{"actor":{"display_login":"traviskaufman"}}