{"action":"created","issue":{"url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/42","repository_url":"https://api.github.com/repos/ptmt/react-native-desktop","labels_url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/42/comments","events_url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/42/events","html_url":"https://github.com/ptmt/react-native-desktop/pull/42","id":138478721,"number":42,"title":"Correct screen backing scale factor.","user":{"login":"beretboat","id":4593681,"avatar_url":"https://avatars.githubusercontent.com/u/4593681?v=3","gravatar_id":"","url":"https://api.github.com/users/beretboat","html_url":"https://github.com/beretboat","followers_url":"https://api.github.com/users/beretboat/followers","following_url":"https://api.github.com/users/beretboat/following{/other_user}","gists_url":"https://api.github.com/users/beretboat/gists{/gist_id}","starred_url":"https://api.github.com/users/beretboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beretboat/subscriptions","organizations_url":"https://api.github.com/users/beretboat/orgs","repos_url":"https://api.github.com/users/beretboat/repos","events_url":"https://api.github.com/users/beretboat/events{/privacy}","received_events_url":"https://api.github.com/users/beretboat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-04T13:39:20Z","updated_at":"2016-03-04T14:17:09Z","closed_at":"2016-03-04T13:58:40Z","pull_request":{"url":"https://api.github.com/repos/ptmt/react-native-desktop/pulls/42","html_url":"https://github.com/ptmt/react-native-desktop/pull/42","diff_url":"https://github.com/ptmt/react-native-desktop/pull/42.diff","patch_url":"https://github.com/ptmt/react-native-desktop/pull/42.patch"},"body":"Previously, backing scale factor was hardcoded to 1, which caused `<Image />` displayed wrong on Retina monitors.\r\nAlso I remove `dispatch_once` so RND could adapt to dynamic backing scale factor changes. Unlike iOS devices, dynamic backing scale factor changes are possible. (For example, user with dual displays might drag a window from a Retina display to another non-Retina display.) With profiling, I found that removing `dispatch_once` won't cause noticeable performance issue, unless you have hundreds of  `<Image />` to display at the same time."},"comment":{"url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/comments/192298015","html_url":"https://github.com/ptmt/react-native-desktop/pull/42#issuecomment-192298015","issue_url":"https://api.github.com/repos/ptmt/react-native-desktop/issues/42","id":192298015,"user":{"login":"beretboat","id":4593681,"avatar_url":"https://avatars.githubusercontent.com/u/4593681?v=3","gravatar_id":"","url":"https://api.github.com/users/beretboat","html_url":"https://github.com/beretboat","followers_url":"https://api.github.com/users/beretboat/followers","following_url":"https://api.github.com/users/beretboat/following{/other_user}","gists_url":"https://api.github.com/users/beretboat/gists{/gist_id}","starred_url":"https://api.github.com/users/beretboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beretboat/subscriptions","organizations_url":"https://api.github.com/users/beretboat/orgs","repos_url":"https://api.github.com/users/beretboat/repos","events_url":"https://api.github.com/users/beretboat/events{/privacy}","received_events_url":"https://api.github.com/users/beretboat/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T14:17:09Z","updated_at":"2016-03-04T14:17:09Z","body":"I don't know why, but yes. You can see it in the diff, there's `scale = 1;` before `dispatch_once `."}}