{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/comments/77514551","id":77514551,"diff_hunk":"@@ -80,7 +72,7 @@\n \n       expected_offsets = {\n         \"x\" => {\n-          0 => 42,\n+          0 => kind_of(Numeric),","path":"spec/offset_manager_spec.rb","position":46,"original_position":46,"commit_id":"c5dc3ba4647f025fc2d022759b700db77f8d9744","original_commit_id":"c5dc3ba4647f025fc2d022759b700db77f8d9744","user":{"login":"dasch","id":6351,"avatar_url":"https://avatars.githubusercontent.com/u/6351?v=3","gravatar_id":"","url":"https://api.github.com/users/dasch","html_url":"https://github.com/dasch","followers_url":"https://api.github.com/users/dasch/followers","following_url":"https://api.github.com/users/dasch/following{/other_user}","gists_url":"https://api.github.com/users/dasch/gists{/gist_id}","starred_url":"https://api.github.com/users/dasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasch/subscriptions","organizations_url":"https://api.github.com/users/dasch/orgs","repos_url":"https://api.github.com/users/dasch/repos","events_url":"https://api.github.com/users/dasch/events{/privacy}","received_events_url":"https://api.github.com/users/dasch/received_events","type":"User","site_admin":false},"body":"Why not an explicit value here?","created_at":"2016-09-05T12:28:03Z","updated_at":"2016-09-05T12:28:03Z","html_url":"https://github.com/zendesk/ruby-kafka/pull/281#discussion_r77514551","pull_request_url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/comments/77514551"},"html":{"href":"https://github.com/zendesk/ruby-kafka/pull/281#discussion_r77514551"},"pull_request":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281","id":83993962,"html_url":"https://github.com/zendesk/ruby-kafka/pull/281","diff_url":"https://github.com/zendesk/ruby-kafka/pull/281.diff","patch_url":"https://github.com/zendesk/ruby-kafka/pull/281.patch","issue_url":"https://api.github.com/repos/zendesk/ruby-kafka/issues/281","number":281,"state":"open","locked":false,"title":"Ensures that kafka has the offset off the next message","user":{"login":"tulios","id":33231,"avatar_url":"https://avatars.githubusercontent.com/u/33231?v=3","gravatar_id":"","url":"https://api.github.com/users/tulios","html_url":"https://github.com/tulios","followers_url":"https://api.github.com/users/tulios/followers","following_url":"https://api.github.com/users/tulios/following{/other_user}","gists_url":"https://api.github.com/users/tulios/gists{/gist_id}","starred_url":"https://api.github.com/users/tulios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulios/subscriptions","organizations_url":"https://api.github.com/users/tulios/orgs","repos_url":"https://api.github.com/users/tulios/repos","events_url":"https://api.github.com/users/tulios/events{/privacy}","received_events_url":"https://api.github.com/users/tulios/received_events","type":"User","site_admin":false},"body":"This PR fixes issue #280 \r\n\r\n@dasch I tried to follow your recommendation to move +1 to `commit _offsets` but `offset_manager#next_offset_for` is involved in two scenarios:\r\n\r\n1) When `@processed_offsets` is not initialized and it reads from kafka\r\n2) While the batch is not committed, thus depending on `@processed_offsets` to get the next offset\r\n\r\n+1 is in `offset_manager#mark_as_processed` now to keep all the logic inside the offset manager.","created_at":"2016-09-05T12:19:26Z","updated_at":"2016-09-05T12:28:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8651c97c9963d8a3358a05f9a82cb25d0ae43e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281/commits","review_comments_url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281/comments","review_comment_url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/ruby-kafka/issues/281/comments","statuses_url":"https://api.github.com/repos/zendesk/ruby-kafka/statuses/c5dc3ba4647f025fc2d022759b700db77f8d9744","head":{"label":"tulios:master","ref":"master","sha":"c5dc3ba4647f025fc2d022759b700db77f8d9744","user":{"login":"tulios","id":33231,"avatar_url":"https://avatars.githubusercontent.com/u/33231?v=3","gravatar_id":"","url":"https://api.github.com/users/tulios","html_url":"https://github.com/tulios","followers_url":"https://api.github.com/users/tulios/followers","following_url":"https://api.github.com/users/tulios/following{/other_user}","gists_url":"https://api.github.com/users/tulios/gists{/gist_id}","starred_url":"https://api.github.com/users/tulios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulios/subscriptions","organizations_url":"https://api.github.com/users/tulios/orgs","repos_url":"https://api.github.com/users/tulios/repos","events_url":"https://api.github.com/users/tulios/events{/privacy}","received_events_url":"https://api.github.com/users/tulios/received_events","type":"User","site_admin":false},"repo":{"id":67402865,"name":"ruby-kafka","full_name":"tulios/ruby-kafka","owner":{"login":"tulios","id":33231,"avatar_url":"https://avatars.githubusercontent.com/u/33231?v=3","gravatar_id":"","url":"https://api.github.com/users/tulios","html_url":"https://github.com/tulios","followers_url":"https://api.github.com/users/tulios/followers","following_url":"https://api.github.com/users/tulios/following{/other_user}","gists_url":"https://api.github.com/users/tulios/gists{/gist_id}","starred_url":"https://api.github.com/users/tulios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulios/subscriptions","organizations_url":"https://api.github.com/users/tulios/orgs","repos_url":"https://api.github.com/users/tulios/repos","events_url":"https://api.github.com/users/tulios/events{/privacy}","received_events_url":"https://api.github.com/users/tulios/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tulios/ruby-kafka","description":"A Ruby client library for Apache Kafka 0.9","fork":true,"url":"https://api.github.com/repos/tulios/ruby-kafka","forks_url":"https://api.github.com/repos/tulios/ruby-kafka/forks","keys_url":"https://api.github.com/repos/tulios/ruby-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tulios/ruby-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tulios/ruby-kafka/teams","hooks_url":"https://api.github.com/repos/tulios/ruby-kafka/hooks","issue_events_url":"https://api.github.com/repos/tulios/ruby-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/tulios/ruby-kafka/events","assignees_url":"https://api.github.com/repos/tulios/ruby-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/tulios/ruby-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/tulios/ruby-kafka/tags","blobs_url":"https://api.github.com/repos/tulios/ruby-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tulios/ruby-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tulios/ruby-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/tulios/ruby-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tulios/ruby-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/tulios/ruby-kafka/languages","stargazers_url":"https://api.github.com/repos/tulios/ruby-kafka/stargazers","contributors_url":"https://api.github.com/repos/tulios/ruby-kafka/contributors","subscribers_url":"https://api.github.com/repos/tulios/ruby-kafka/subscribers","subscription_url":"https://api.github.com/repos/tulios/ruby-kafka/subscription","commits_url":"https://api.github.com/repos/tulios/ruby-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/tulios/ruby-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/tulios/ruby-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/tulios/ruby-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/tulios/ruby-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/tulios/ruby-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tulios/ruby-kafka/merges","archive_url":"https://api.github.com/repos/tulios/ruby-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tulios/ruby-kafka/downloads","issues_url":"https://api.github.com/repos/tulios/ruby-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/tulios/ruby-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/tulios/ruby-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/tulios/ruby-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tulios/ruby-kafka/labels{/name}","releases_url":"https://api.github.com/repos/tulios/ruby-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/tulios/ruby-kafka/deployments","created_at":"2016-09-05T08:33:12Z","updated_at":"2016-09-05T08:33:13Z","pushed_at":"2016-09-05T12:03:07Z","git_url":"git://github.com/tulios/ruby-kafka.git","ssh_url":"git@github.com:tulios/ruby-kafka.git","clone_url":"https://github.com/tulios/ruby-kafka.git","svn_url":"https://github.com/tulios/ruby-kafka","homepage":"http://www.rubydoc.info/gems/ruby-kafka","size":710,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"035a3790077c19e5379747f0ff1af6151f3c7b93","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":49878403,"name":"ruby-kafka","full_name":"zendesk/ruby-kafka","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/ruby-kafka","description":"A Ruby client library for Apache Kafka 0.9","fork":false,"url":"https://api.github.com/repos/zendesk/ruby-kafka","forks_url":"https://api.github.com/repos/zendesk/ruby-kafka/forks","keys_url":"https://api.github.com/repos/zendesk/ruby-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/ruby-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/ruby-kafka/teams","hooks_url":"https://api.github.com/repos/zendesk/ruby-kafka/hooks","issue_events_url":"https://api.github.com/repos/zendesk/ruby-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/ruby-kafka/events","assignees_url":"https://api.github.com/repos/zendesk/ruby-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/ruby-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/ruby-kafka/tags","blobs_url":"https://api.github.com/repos/zendesk/ruby-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/ruby-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/ruby-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/ruby-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/ruby-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/ruby-kafka/languages","stargazers_url":"https://api.github.com/repos/zendesk/ruby-kafka/stargazers","contributors_url":"https://api.github.com/repos/zendesk/ruby-kafka/contributors","subscribers_url":"https://api.github.com/repos/zendesk/ruby-kafka/subscribers","subscription_url":"https://api.github.com/repos/zendesk/ruby-kafka/subscription","commits_url":"https://api.github.com/repos/zendesk/ruby-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/ruby-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/ruby-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/ruby-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/ruby-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/ruby-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/ruby-kafka/merges","archive_url":"https://api.github.com/repos/zendesk/ruby-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/ruby-kafka/downloads","issues_url":"https://api.github.com/repos/zendesk/ruby-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/ruby-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/ruby-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/ruby-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/ruby-kafka/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/ruby-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/ruby-kafka/deployments","created_at":"2016-01-18T13:24:55Z","updated_at":"2016-09-01T14:20:24Z","pushed_at":"2016-09-05T12:19:26Z","git_url":"git://github.com/zendesk/ruby-kafka.git","ssh_url":"git@github.com:zendesk/ruby-kafka.git","clone_url":"https://github.com/zendesk/ruby-kafka.git","svn_url":"https://github.com/zendesk/ruby-kafka","homepage":"http://www.rubydoc.info/gems/ruby-kafka","size":699,"stargazers_count":280,"watchers_count":280,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":26,"forks":37,"open_issues":26,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281"},"html":{"href":"https://github.com/zendesk/ruby-kafka/pull/281"},"issue":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/issues/281"},"comments":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/ruby-kafka/statuses/c5dc3ba4647f025fc2d022759b700db77f8d9744"}}}}
{"actor":{"display_login":"dasch"}}