{"action":"created","issue":{"url":"https://api.github.com/repos/zikula/core/issues/3178","repository_url":"https://api.github.com/repos/zikula/core","labels_url":"https://api.github.com/repos/zikula/core/issues/3178/labels{/name}","comments_url":"https://api.github.com/repos/zikula/core/issues/3178/comments","events_url":"https://api.github.com/repos/zikula/core/issues/3178/events","html_url":"https://github.com/zikula/core/pull/3178","id":189047884,"number":3178,"title":"easier password reset process, fixed #1781, plus some minor fixes","user":{"login":"Guite","id":277531,"avatar_url":"https://avatars.githubusercontent.com/u/277531?v=3","gravatar_id":"","url":"https://api.github.com/users/Guite","html_url":"https://github.com/Guite","followers_url":"https://api.github.com/users/Guite/followers","following_url":"https://api.github.com/users/Guite/following{/other_user}","gists_url":"https://api.github.com/users/Guite/gists{/gist_id}","starred_url":"https://api.github.com/users/Guite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guite/subscriptions","organizations_url":"https://api.github.com/users/Guite/orgs","repos_url":"https://api.github.com/users/Guite/repos","events_url":"https://api.github.com/users/Guite/events{/privacy}","received_events_url":"https://api.github.com/users/Guite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zikula/core/milestones/21","html_url":"https://github.com/zikula/core/milestones/1.4.4","labels_url":"https://api.github.com/repos/zikula/core/milestones/21/labels","id":1876349,"number":21,"title":"1.4.4","description":"Fourth service release for 1.4.x series","creator":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=3","gravatar_id":"","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":117,"state":"open","created_at":"2016-07-11T16:39:55Z","updated_at":"2016-11-14T07:45:11Z","due_on":"2016-11-25T00:00:00Z","closed_at":null},"comments":2,"created_at":"2016-11-14T07:45:11Z","updated_at":"2016-11-14T12:03:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zikula/core/pulls/3178","html_url":"https://github.com/zikula/core/pull/3178","diff_url":"https://github.com/zikula/core/pull/3178.diff","patch_url":"https://github.com/zikula/core/pull/3178.patch"},"body":"| Q                 | A\r\n| ----------------- | ---\r\n| Bug fix?          | yes (email related)\r\n| New feature?      | yes\r\n| BC breaks?        | no\r\n| Deprecations?     | no\r\n| Fixed tickets     | #1781 \r\n| Refs tickets      | -\r\n| License           | MIT\r\n| Changelog updated | yes\r\n\r\n**Notes:**\r\n\r\nThis does still use the verification entity and confirmation codes. So for example the expiry is still handled by that.\r\n\r\nBut there are some essential behavioural differences:\r\n\r\n1. The code is wrapped into an encoded identifier together with the user id, the user name and the email address. This identifier is appended to the url contained in the email text.\r\n2. After extracting the identifier arguments the user is selected using all three fields (which makes it harder to guess correct identifiers).\r\n3. The code is checked before the form even displays.\r\n4. The form contains only two password fields now.\r\n5. A new helper class (`LostPasswordVerificationHelper`) encapsulates the details, making the controllers a bit more slim.\r\n\r\nThis PR also addresses some minor bugs I've found, like non-absolute urls in the email templates and wrong usage of the `MailerApi` in the `MailHelper` class."},"comment":{"url":"https://api.github.com/repos/zikula/core/issues/comments/260318508","html_url":"https://github.com/zikula/core/pull/3178#issuecomment-260318508","issue_url":"https://api.github.com/repos/zikula/core/issues/3178","id":260318508,"user":{"login":"craigh","id":350048,"avatar_url":"https://avatars.githubusercontent.com/u/350048?v=3","gravatar_id":"","url":"https://api.github.com/users/craigh","html_url":"https://github.com/craigh","followers_url":"https://api.github.com/users/craigh/followers","following_url":"https://api.github.com/users/craigh/following{/other_user}","gists_url":"https://api.github.com/users/craigh/gists{/gist_id}","starred_url":"https://api.github.com/users/craigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigh/subscriptions","organizations_url":"https://api.github.com/users/craigh/orgs","repos_url":"https://api.github.com/users/craigh/repos","events_url":"https://api.github.com/users/craigh/events{/privacy}","received_events_url":"https://api.github.com/users/craigh/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T12:03:44Z","updated_at":"2016-11-14T12:03:44Z","body":"to review in combination with the #3177: User data is migrated from the `users` table to the `zauth_authentication_mapping` table when each user logs in after that upgrade. This means that *some* user data will be in both places - the only thing this PR cares about - the password - is the main thing that is migrated.\r\n\r\nThis means you will need to have a 'new' method which uses `zauth_authentication_mapping` and a BC method using the `users` table - the easier it is to remove the BC layer, the better please. \r\n\r\nI didn't walk though each line of this PR yet, but it appears you haven't considered the `zauth_authentication_mapping` location for passwords. perhaps I missed it"}}
{"actor":{"display_login":"craigh"}}