{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/84135873","pull_request_review_id":4932517,"id":84135873,"diff_hunk":"@@ -34,19 +34,19 @@\n \n     private Map<String, ServiceRegistration> metacardTypeServiceRegistrations = new HashMap<>();\n \n-    private List<SaxEventHandlerFactory> saxEventHandlerFactories;\n-\n-    private List<String> saxEventHandlerConfiguration;\n+    private List<SaxEventHandlerFactory> saxEventHandlerFactories = new ArrayList<>();\n \n     private DynamicMetacardType metacardType;\n \n     private String id = \"DEFAULT_ID\";\n \n     public void bind(SaxEventHandlerFactory saxEventHandlerFactory) {","path":"catalog/transformer/catalog-transformer-streaming-lib/src/main/java/org/codice/ddf/transformer/xml/streaming/lib/MetacardTypeRegister.java","position":null,"original_position":29,"commit_id":"3309807e139655db148727c06aea91cafdec739c","original_commit_id":"3309807e139655db148727c06aea91cafdec739c","user":{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars.githubusercontent.com/u/1469860?v=3","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"body":"You'll now need to synchronize your reads/writes to the `saxEventHandlerFactories` list (and calls to `setMetacardType`. Simplest to just sync the `bind`, `unbind`, and `setMetacardType` methods. You could use a lock instead but that's probably overkill.","created_at":"2016-10-19T18:26:50Z","updated_at":"2016-10-19T18:28:30Z","html_url":"https://github.com/codice/ddf/pull/1327#discussion_r84135873","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1327","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/84135873"},"html":{"href":"https://github.com/codice/ddf/pull/1327#discussion_r84135873"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1327"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1327","id":87993024,"html_url":"https://github.com/codice/ddf/pull/1327","diff_url":"https://github.com/codice/ddf/pull/1327.diff","patch_url":"https://github.com/codice/ddf/pull/1327.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1327","number":1327,"state":"open","locked":false,"title":"DDF-2507 Added MetacardType attribute registration to XmlInputTransformer","user":{"login":"emanns95","id":12501737,"avatar_url":"https://avatars.githubusercontent.com/u/12501737?v=3","gravatar_id":"","url":"https://api.github.com/users/emanns95","html_url":"https://github.com/emanns95","followers_url":"https://api.github.com/users/emanns95/followers","following_url":"https://api.github.com/users/emanns95/following{/other_user}","gists_url":"https://api.github.com/users/emanns95/gists{/gist_id}","starred_url":"https://api.github.com/users/emanns95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanns95/subscriptions","organizations_url":"https://api.github.com/users/emanns95/orgs","repos_url":"https://api.github.com/users/emanns95/repos","events_url":"https://api.github.com/users/emanns95/events{/privacy}","received_events_url":"https://api.github.com/users/emanns95/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThe attributes for metacards created using the XmlInputTransformer do not register the MetacardType Attributes. These attributes are now registered.\r\n\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@brendan-hofmann \r\n@harrison-tarr \r\n@jrnorth \r\n\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@coyotesqrl\r\n@kcwire\r\n\r\n#### How should this be tested?\r\nFull build and ingest xml data with a numerical field. Check that the field can be searched on.\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2016-10-04T23:27:43Z","updated_at":"2016-10-19T18:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa9ce6f3dbdb94bebbdcd50262cc6ab054b3baa2","assignee":{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars.githubusercontent.com/u/1469860?v=3","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars.githubusercontent.com/u/1469860?v=3","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"kcwire","id":4631300,"avatar_url":"https://avatars.githubusercontent.com/u/4631300?v=3","gravatar_id":"","url":"https://api.github.com/users/kcwire","html_url":"https://github.com/kcwire","followers_url":"https://api.github.com/users/kcwire/followers","following_url":"https://api.github.com/users/kcwire/following{/other_user}","gists_url":"https://api.github.com/users/kcwire/gists{/gist_id}","starred_url":"https://api.github.com/users/kcwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcwire/subscriptions","organizations_url":"https://api.github.com/users/kcwire/orgs","repos_url":"https://api.github.com/users/kcwire/repos","events_url":"https://api.github.com/users/kcwire/events{/privacy}","received_events_url":"https://api.github.com/users/kcwire/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1327/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1327/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1327/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/3309807e139655db148727c06aea91cafdec739c","head":{"label":"emanns95:DDF-2507-attribute-registration","ref":"DDF-2507-attribute-registration","sha":"3309807e139655db148727c06aea91cafdec739c","user":{"login":"emanns95","id":12501737,"avatar_url":"https://avatars.githubusercontent.com/u/12501737?v=3","gravatar_id":"","url":"https://api.github.com/users/emanns95","html_url":"https://github.com/emanns95","followers_url":"https://api.github.com/users/emanns95/followers","following_url":"https://api.github.com/users/emanns95/following{/other_user}","gists_url":"https://api.github.com/users/emanns95/gists{/gist_id}","starred_url":"https://api.github.com/users/emanns95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanns95/subscriptions","organizations_url":"https://api.github.com/users/emanns95/orgs","repos_url":"https://api.github.com/users/emanns95/repos","events_url":"https://api.github.com/users/emanns95/events{/privacy}","received_events_url":"https://api.github.com/users/emanns95/received_events","type":"User","site_admin":false},"repo":{"id":40488022,"name":"ddf","full_name":"emanns95/ddf","owner":{"login":"emanns95","id":12501737,"avatar_url":"https://avatars.githubusercontent.com/u/12501737?v=3","gravatar_id":"","url":"https://api.github.com/users/emanns95","html_url":"https://github.com/emanns95","followers_url":"https://api.github.com/users/emanns95/followers","following_url":"https://api.github.com/users/emanns95/following{/other_user}","gists_url":"https://api.github.com/users/emanns95/gists{/gist_id}","starred_url":"https://api.github.com/users/emanns95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanns95/subscriptions","organizations_url":"https://api.github.com/users/emanns95/orgs","repos_url":"https://api.github.com/users/emanns95/repos","events_url":"https://api.github.com/users/emanns95/events{/privacy}","received_events_url":"https://api.github.com/users/emanns95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emanns95/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/emanns95/ddf","forks_url":"https://api.github.com/repos/emanns95/ddf/forks","keys_url":"https://api.github.com/repos/emanns95/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emanns95/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emanns95/ddf/teams","hooks_url":"https://api.github.com/repos/emanns95/ddf/hooks","issue_events_url":"https://api.github.com/repos/emanns95/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/emanns95/ddf/events","assignees_url":"https://api.github.com/repos/emanns95/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/emanns95/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/emanns95/ddf/tags","blobs_url":"https://api.github.com/repos/emanns95/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emanns95/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emanns95/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/emanns95/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emanns95/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/emanns95/ddf/languages","stargazers_url":"https://api.github.com/repos/emanns95/ddf/stargazers","contributors_url":"https://api.github.com/repos/emanns95/ddf/contributors","subscribers_url":"https://api.github.com/repos/emanns95/ddf/subscribers","subscription_url":"https://api.github.com/repos/emanns95/ddf/subscription","commits_url":"https://api.github.com/repos/emanns95/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/emanns95/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/emanns95/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/emanns95/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/emanns95/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/emanns95/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emanns95/ddf/merges","archive_url":"https://api.github.com/repos/emanns95/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emanns95/ddf/downloads","issues_url":"https://api.github.com/repos/emanns95/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/emanns95/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/emanns95/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/emanns95/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emanns95/ddf/labels{/name}","releases_url":"https://api.github.com/repos/emanns95/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/emanns95/ddf/deployments","created_at":"2015-08-10T14:48:17Z","updated_at":"2015-08-10T14:48:27Z","pushed_at":"2016-10-19T18:19:19Z","git_url":"git://github.com/emanns95/ddf.git","ssh_url":"git@github.com:emanns95/ddf.git","clone_url":"https://github.com/emanns95/ddf.git","svn_url":"https://github.com/emanns95/ddf","homepage":"","size":148958,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"6aceeaab1fa11d61f826c7f4950045f4f1d9e1ee","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-10-19T07:32:07Z","pushed_at":"2016-10-19T18:19:20Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":287801,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":22,"forks":95,"open_issues":22,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1327"},"html":{"href":"https://github.com/codice/ddf/pull/1327"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1327"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1327/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1327/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1327/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/3309807e139655db148727c06aea91cafdec739c"}}}}
{"actor":{"display_login":"coyotesqrl"}}