{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/66037988","id":66037988,"diff_hunk":"@@ -616,18 +667,17 @@ lazy val test = project\n     fork in IntegrationTest := true,\n     javaOptions in IntegrationTest += \"-Xmx1G\",\n     testFrameworks += new TestFramework(\"scala.tools.partest.sbt.Framework\"),\n-    testOptions in IntegrationTest += Tests.Setup( () => root.base.getAbsolutePath + \"/pull-binary-libs.sh\" ! ),\n     testOptions in IntegrationTest += Tests.Argument(\"-Dpartest.java_opts=-Xmx1024M -Xms64M -XX:MaxPermSize=128M\"),\n-    definedTests in IntegrationTest += (\n-      new sbt.TestDefinition(\n-        \"partest\",\n-        // marker fingerprint since there are no test classes\n-        // to be discovered by sbt:\n-        new sbt.testing.AnnotatedFingerprint {\n-          def isModule = true\n-          def annotationName = \"partest\"\n-        }, true, Array())\n-     )\n+    testOptions in IntegrationTest += Tests.Argument(\"-Dpartest.scalac_opts=\" + (scalacOptions in Compile).value.mkString(\" \")),","path":"build.sbt","position":222,"original_position":222,"commit_id":"aae241a4e63b99683dd9afcf054f44f40c996f17","original_commit_id":"aae241a4e63b99683dd9afcf054f44f40c996f17","user":{"login":"szeiger","id":54262,"avatar_url":"https://avatars.githubusercontent.com/u/54262?v=3","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"body":"No, there's no parsing of quoted arguments happening anywhere. This is a single `Argument` for partest which does a `.split(' ')` on the RHS of the `-D` def to get the scalac args. There is currently no way use spaces inside of scalac args but that's a limitation of partest (and is also present when launching it from ant or the command line).","created_at":"2016-06-07T09:30:34Z","updated_at":"2016-06-07T09:30:34Z","html_url":"https://github.com/scala/scala/pull/5190#discussion_r66037988","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/5190","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/66037988"},"html":{"href":"https://github.com/scala/scala/pull/5190#discussion_r66037988"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/5190"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/5190","id":71414050,"html_url":"https://github.com/scala/scala/pull/5190","diff_url":"https://github.com/scala/scala/pull/5190.diff","patch_url":"https://github.com/scala/scala/pull/5190.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/5190","number":5190,"state":"open","locked":false,"title":"Use sbt for PR validation [ci: last-only]","user":{"login":"szeiger","id":54262,"avatar_url":"https://avatars.githubusercontent.com/u/54262?v=3","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"body":"Picking up the work on #4933","created_at":"2016-05-25T15:40:58Z","updated_at":"2016-06-07T09:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61a09e28cc53e1cc2eec917f1c18459e43748199","assignee":{"login":"szeiger","id":54262,"avatar_url":"https://avatars.githubusercontent.com/u/54262?v=3","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/52","html_url":"https://github.com/scala/scala/milestones/2.12.0-M5","labels_url":"https://api.github.com/repos/scala/scala/milestones/52/labels","id":1355301,"number":52,"title":"2.12.0-M5","description":"Lead: @lrytz\r\n\r\nIn order to meet our deadline, we will only accept new PRs that fix an issue scheduled for M5 over at https://github.com/scala/scala-dev/milestones/2.12.0-M5 (no longer accepting new issues as of May 2). \r\n\r\nNOTE: We always accept more tests/docs -- this restriction aims to avoid PRs that change functionality or may otherwise cause regressions and release date slips.\r\n\r\nLukas informed scala-internals about this on April 22nd. For urgent/critical issues, exceptions will be considered after discussion on scala-internals.\r\n\r\nThe deadline currently stands at June 3rd (originally it was one week earlier). We're working hard to beat this date, and will cut the release as soon as we've made our way through the PR queue.","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":119,"state":"open","created_at":"2015-10-14T13:06:29Z","updated_at":"2016-06-06T18:51:56Z","due_on":"2016-06-02T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/5190/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/5190/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/5190/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/aae241a4e63b99683dd9afcf054f44f40c996f17","head":{"label":"szeiger:wip/validate-test-use-sbt","ref":"wip/validate-test-use-sbt","sha":"aae241a4e63b99683dd9afcf054f44f40c996f17","user":{"login":"szeiger","id":54262,"avatar_url":"https://avatars.githubusercontent.com/u/54262?v=3","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"repo":{"id":2889909,"name":"scala","full_name":"szeiger/scala","owner":{"login":"szeiger","id":54262,"avatar_url":"https://avatars.githubusercontent.com/u/54262?v=3","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szeiger/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/szeiger/scala","forks_url":"https://api.github.com/repos/szeiger/scala/forks","keys_url":"https://api.github.com/repos/szeiger/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szeiger/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szeiger/scala/teams","hooks_url":"https://api.github.com/repos/szeiger/scala/hooks","issue_events_url":"https://api.github.com/repos/szeiger/scala/issues/events{/number}","events_url":"https://api.github.com/repos/szeiger/scala/events","assignees_url":"https://api.github.com/repos/szeiger/scala/assignees{/user}","branches_url":"https://api.github.com/repos/szeiger/scala/branches{/branch}","tags_url":"https://api.github.com/repos/szeiger/scala/tags","blobs_url":"https://api.github.com/repos/szeiger/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szeiger/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szeiger/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/szeiger/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szeiger/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/szeiger/scala/languages","stargazers_url":"https://api.github.com/repos/szeiger/scala/stargazers","contributors_url":"https://api.github.com/repos/szeiger/scala/contributors","subscribers_url":"https://api.github.com/repos/szeiger/scala/subscribers","subscription_url":"https://api.github.com/repos/szeiger/scala/subscription","commits_url":"https://api.github.com/repos/szeiger/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/szeiger/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/szeiger/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/szeiger/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/szeiger/scala/contents/{+path}","compare_url":"https://api.github.com/repos/szeiger/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szeiger/scala/merges","archive_url":"https://api.github.com/repos/szeiger/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szeiger/scala/downloads","issues_url":"https://api.github.com/repos/szeiger/scala/issues{/number}","pulls_url":"https://api.github.com/repos/szeiger/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/szeiger/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/szeiger/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szeiger/scala/labels{/name}","releases_url":"https://api.github.com/repos/szeiger/scala/releases{/id}","deployments_url":"https://api.github.com/repos/szeiger/scala/deployments","created_at":"2011-12-01T09:14:47Z","updated_at":"2014-03-11T19:07:27Z","pushed_at":"2016-06-03T16:12:33Z","git_url":"git://github.com/szeiger/scala.git","ssh_url":"git@github.com:szeiger/scala.git","clone_url":"https://github.com/szeiger/scala.git","svn_url":"https://github.com/szeiger/scala","homepage":"http://www.scala-lang.org/","size":83936,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"139f6bf9d709fc18a23530f2f84afa8a1f97b464","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2016-06-07T05:21:03Z","pushed_at":"2016-06-07T07:44:59Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":144218,"stargazers_count":6273,"watchers_count":6273,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1581,"mirror_url":null,"open_issues_count":26,"forks":1581,"open_issues":26,"watchers":6273,"default_branch":"2.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/5190"},"html":{"href":"https://github.com/scala/scala/pull/5190"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/5190"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/5190/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/5190/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/5190/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/aae241a4e63b99683dd9afcf054f44f40c996f17"}}}}
{"actor":{"display_login":"szeiger"}}