{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/481","repository_url":"https://api.github.com/repos/vaadin/vaadin-grid","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/481/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/481/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/481/events","html_url":"https://github.com/vaadin/vaadin-grid/pull/481","id":181680950,"number":481,"title":"Make sure _ignoreScroll gets cleared","user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-grid/labels/2.0","name":"2.0","color":"fef2c0"},{"url":"https://api.github.com/repos/vaadin/vaadin-grid/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-07T14:19:11Z","updated_at":"2016-10-10T08:50:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/pulls/481","html_url":"https://github.com/vaadin/vaadin-grid/pull/481","diff_url":"https://github.com/vaadin/vaadin-grid/pull/481.diff","patch_url":"https://github.com/vaadin/vaadin-grid/pull/481.patch"},"body":"If scroller._ignoreScroll is true while resizing the grid, the headers/footers might get misplaced. This PR makes sure  _ignoreScroll flag gets cleared.\r\n<img width=\"457\" alt=\"screenshot 2016-10-07 12 00 00\" src=\"https://cloud.githubusercontent.com/assets/1222264/19193232/f7f3f408-8cb1-11e6-92fd-f20e42e54161.png\">\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid/481)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/comments/252563934","html_url":"https://github.com/vaadin/vaadin-grid/pull/481#issuecomment-252563934","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/481","id":252563934,"user":{"login":"Saulis","id":1039468,"avatar_url":"https://avatars.githubusercontent.com/u/1039468?v=3","gravatar_id":"","url":"https://api.github.com/users/Saulis","html_url":"https://github.com/Saulis","followers_url":"https://api.github.com/users/Saulis/followers","following_url":"https://api.github.com/users/Saulis/following{/other_user}","gists_url":"https://api.github.com/users/Saulis/gists{/gist_id}","starred_url":"https://api.github.com/users/Saulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saulis/subscriptions","organizations_url":"https://api.github.com/users/Saulis/orgs","repos_url":"https://api.github.com/users/Saulis/repos","events_url":"https://api.github.com/users/Saulis/events{/privacy}","received_events_url":"https://api.github.com/users/Saulis/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T08:50:26Z","updated_at":"2016-10-10T08:50:26Z","body":"The `_ignoreScroll` is only for optimizing, right? What if we would just remove the optimization to clean up the code a bit? Didn't test on IE or Edge, but on browsers I can't tell any difference performance wise.\n\n---\n\nReview status: 0 of 3 files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-grid/481#-:-KThloWG6vxrjvpWMfJy:b-ns2z2q)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Saulis"}}