{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/48919311","id":48919311,"diff_hunk":"@@ -86,7 +86,7 @@ object MLUtils {\n         val indicesLength = indices.length\n         while (i < indicesLength) {\n           val current = indices(i)\n-          require(current > previous, \"indices should be one-based and in ascending order\" )\n+          require(current > previous, \"indices should be one-based and in ascending order; found current=\" + current + \", previous=\" + previous + \"; line=\\\"\" + line + \"\\\"\")","path":"mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala","position":5,"original_position":5,"commit_id":"8ae7d3591848698de43412b658d003915f0ad1d2","original_commit_id":"8ae7d3591848698de43412b658d003915f0ad1d2","user":{"login":"thunterdb","id":7594753,"avatar_url":"https://avatars.githubusercontent.com/u/7594753?v=3","gravatar_id":"","url":"https://api.github.com/users/thunterdb","html_url":"https://github.com/thunterdb","followers_url":"https://api.github.com/users/thunterdb/followers","following_url":"https://api.github.com/users/thunterdb/following{/other_user}","gists_url":"https://api.github.com/users/thunterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunterdb/subscriptions","organizations_url":"https://api.github.com/users/thunterdb/orgs","repos_url":"https://api.github.com/users/thunterdb/repos","events_url":"https://api.github.com/users/thunterdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunterdb/received_events","type":"User","site_admin":false},"body":"This line is too long (see spark style guide). Also, I recommend you use scala's string interpolation rather than manually building the string: \r\n```scala\r\ns\"previous=$previous, line='$line' \"\r\n```","created_at":"2016-01-06T01:34:29Z","updated_at":"2016-01-06T01:34:29Z","html_url":"https://github.com/apache/spark/pull/10611#discussion_r48919311","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/10611","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/48919311"},"html":{"href":"https://github.com/apache/spark/pull/10611#discussion_r48919311"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/10611"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/10611","id":55165165,"html_url":"https://github.com/apache/spark/pull/10611","diff_url":"https://github.com/apache/spark/pull/10611.diff","patch_url":"https://github.com/apache/spark/pull/10611.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/10611","number":10611,"state":"open","locked":false,"title":"[SPARK-12663] [MLlib] More informative error message in MLUtils.loadLibSVMFile","user":{"login":"robert-dodier","id":1489136,"avatar_url":"https://avatars.githubusercontent.com/u/1489136?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-dodier","html_url":"https://github.com/robert-dodier","followers_url":"https://api.github.com/users/robert-dodier/followers","following_url":"https://api.github.com/users/robert-dodier/following{/other_user}","gists_url":"https://api.github.com/users/robert-dodier/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-dodier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-dodier/subscriptions","organizations_url":"https://api.github.com/users/robert-dodier/orgs","repos_url":"https://api.github.com/users/robert-dodier/repos","events_url":"https://api.github.com/users/robert-dodier/events{/privacy}","received_events_url":"https://api.github.com/users/robert-dodier/received_events","type":"User","site_admin":false},"body":"This PR contains 1 commit which resolves [SPARK-12663](https://issues.apache.org/jira/browse/SPARK-12663).\r\n\r\nFor the record, I got a positive response from 2 people when I floated this idea on dev@spark.apache.org on 2015-10-23. [Link to archived discussion.](http://apache-spark-developers-list.1001551.n3.nabble.com/slightly-more-informative-error-message-in-MLUtils-loadLibSVMFile-td14764.html)","created_at":"2016-01-06T01:03:12Z","updated_at":"2016-01-06T01:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c05a8c30e565ec9c56a05c43da319ec664bce42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/10611/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/10611/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/10611/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8ae7d3591848698de43412b658d003915f0ad1d2","head":{"label":"robert-dodier:loadlibsvmfile-error-msg-branch","ref":"loadlibsvmfile-error-msg-branch","sha":"8ae7d3591848698de43412b658d003915f0ad1d2","user":{"login":"robert-dodier","id":1489136,"avatar_url":"https://avatars.githubusercontent.com/u/1489136?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-dodier","html_url":"https://github.com/robert-dodier","followers_url":"https://api.github.com/users/robert-dodier/followers","following_url":"https://api.github.com/users/robert-dodier/following{/other_user}","gists_url":"https://api.github.com/users/robert-dodier/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-dodier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-dodier/subscriptions","organizations_url":"https://api.github.com/users/robert-dodier/orgs","repos_url":"https://api.github.com/users/robert-dodier/repos","events_url":"https://api.github.com/users/robert-dodier/events{/privacy}","received_events_url":"https://api.github.com/users/robert-dodier/received_events","type":"User","site_admin":false},"repo":{"id":31746026,"name":"spark","full_name":"robert-dodier/spark","owner":{"login":"robert-dodier","id":1489136,"avatar_url":"https://avatars.githubusercontent.com/u/1489136?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-dodier","html_url":"https://github.com/robert-dodier","followers_url":"https://api.github.com/users/robert-dodier/followers","following_url":"https://api.github.com/users/robert-dodier/following{/other_user}","gists_url":"https://api.github.com/users/robert-dodier/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-dodier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-dodier/subscriptions","organizations_url":"https://api.github.com/users/robert-dodier/orgs","repos_url":"https://api.github.com/users/robert-dodier/repos","events_url":"https://api.github.com/users/robert-dodier/events{/privacy}","received_events_url":"https://api.github.com/users/robert-dodier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robert-dodier/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/robert-dodier/spark","forks_url":"https://api.github.com/repos/robert-dodier/spark/forks","keys_url":"https://api.github.com/repos/robert-dodier/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robert-dodier/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robert-dodier/spark/teams","hooks_url":"https://api.github.com/repos/robert-dodier/spark/hooks","issue_events_url":"https://api.github.com/repos/robert-dodier/spark/issues/events{/number}","events_url":"https://api.github.com/repos/robert-dodier/spark/events","assignees_url":"https://api.github.com/repos/robert-dodier/spark/assignees{/user}","branches_url":"https://api.github.com/repos/robert-dodier/spark/branches{/branch}","tags_url":"https://api.github.com/repos/robert-dodier/spark/tags","blobs_url":"https://api.github.com/repos/robert-dodier/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robert-dodier/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robert-dodier/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/robert-dodier/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robert-dodier/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/robert-dodier/spark/languages","stargazers_url":"https://api.github.com/repos/robert-dodier/spark/stargazers","contributors_url":"https://api.github.com/repos/robert-dodier/spark/contributors","subscribers_url":"https://api.github.com/repos/robert-dodier/spark/subscribers","subscription_url":"https://api.github.com/repos/robert-dodier/spark/subscription","commits_url":"https://api.github.com/repos/robert-dodier/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/robert-dodier/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/robert-dodier/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/robert-dodier/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/robert-dodier/spark/contents/{+path}","compare_url":"https://api.github.com/repos/robert-dodier/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robert-dodier/spark/merges","archive_url":"https://api.github.com/repos/robert-dodier/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robert-dodier/spark/downloads","issues_url":"https://api.github.com/repos/robert-dodier/spark/issues{/number}","pulls_url":"https://api.github.com/repos/robert-dodier/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/robert-dodier/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/robert-dodier/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robert-dodier/spark/labels{/name}","releases_url":"https://api.github.com/repos/robert-dodier/spark/releases{/id}","created_at":"2015-03-06T01:19:52Z","updated_at":"2015-03-14T02:14:52Z","pushed_at":"2016-01-06T00:30:32Z","git_url":"git://github.com/robert-dodier/spark.git","ssh_url":"git@github.com:robert-dodier/spark.git","clone_url":"https://github.com/robert-dodier/spark.git","svn_url":"https://github.com/robert-dodier/spark","homepage":null,"size":133098,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1537e55604cafafa49a8b7f3ce915f9745392bc0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-01-06T01:18:18Z","pushed_at":"2016-01-06T01:05:22Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":398399,"stargazers_count":6838,"watchers_count":6838,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6299,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":348,"forks":6299,"open_issues":348,"watchers":6838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/10611"},"html":{"href":"https://github.com/apache/spark/pull/10611"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/10611"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/10611/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/10611/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/10611/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8ae7d3591848698de43412b658d003915f0ad1d2"}}}}