{"action":"created","issue":{"url":"https://api.github.com/repos/DaveDavenport/rofi/issues/486","repository_url":"https://api.github.com/repos/DaveDavenport/rofi","labels_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/486/labels{/name}","comments_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/486/comments","events_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/486/events","html_url":"https://github.com/DaveDavenport/rofi/pull/486","id":184684711,"number":486,"title":"changed subprocess call in file-browser example","user":{"login":"flhp","id":22923029,"avatar_url":"https://avatars.githubusercontent.com/u/22923029?v=3","gravatar_id":"","url":"https://api.github.com/users/flhp","html_url":"https://github.com/flhp","followers_url":"https://api.github.com/users/flhp/followers","following_url":"https://api.github.com/users/flhp/following{/other_user}","gists_url":"https://api.github.com/users/flhp/gists{/gist_id}","starred_url":"https://api.github.com/users/flhp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flhp/subscriptions","organizations_url":"https://api.github.com/users/flhp/orgs","repos_url":"https://api.github.com/users/flhp/repos","events_url":"https://api.github.com/users/flhp/events{/privacy}","received_events_url":"https://api.github.com/users/flhp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-23T11:24:59Z","updated_at":"2016-10-23T11:37:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DaveDavenport/rofi/pulls/486","html_url":"https://github.com/DaveDavenport/rofi/pull/486","diff_url":"https://github.com/DaveDavenport/rofi/pull/486.diff","patch_url":"https://github.com/DaveDavenport/rofi/pull/486.patch"},"body":"Hi, this is a really tiny thing but it's been bothering for a while:\r\nI'm using the file-browser script as a quick way to open files, but xdg-open always seemed to open the wrong programs (mostly firefox, but for everything).\r\nAfter spending way too much time on this, I traced it to the \"coproc\" call. When used in a bash shell, it works normally, but called from a script it seems to mess with the way xdg-open opens files.\r\nAnyways, removing the first ampersand from that line fixes it.\r\nFrom the bash manpage: \r\n```\r\nThere are two formats for redirecting standard output and standard error:\r\n\r\n              &>word\r\n       and\r\n              >&word\r\n\r\nOf the two forms, the first is preferred.  This is semantically equivalent to\r\n\r\n              >word 2>&1\r\n```\r\nSo to me, it seems either the first ampersand or 2nd redirect is superfluous.\r\n\r\nJust one character, but this has itched me for some time now and maybe it helps someone else."},"comment":{"url":"https://api.github.com/repos/DaveDavenport/rofi/issues/comments/255583739","html_url":"https://github.com/DaveDavenport/rofi/pull/486#issuecomment-255583739","issue_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/486","id":255583739,"user":{"login":"DaveDavenport","id":406245,"avatar_url":"https://avatars.githubusercontent.com/u/406245?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDavenport","html_url":"https://github.com/DaveDavenport","followers_url":"https://api.github.com/users/DaveDavenport/followers","following_url":"https://api.github.com/users/DaveDavenport/following{/other_user}","gists_url":"https://api.github.com/users/DaveDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDavenport/subscriptions","organizations_url":"https://api.github.com/users/DaveDavenport/orgs","repos_url":"https://api.github.com/users/DaveDavenport/repos","events_url":"https://api.github.com/users/DaveDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDavenport/received_events","type":"User","site_admin":false},"created_at":"2016-10-23T11:37:40Z","updated_at":"2016-10-23T11:37:40Z","body":"I agree the & can be removed, it looks like it is an old thing left over.\r\n\r\nI don't think it was original mend to be part of the redirect.. (see the extra spaces!)\r\nit just screwed up things.\r\n\r\nAlso, why just fix one occurrence? will merge when second also fixed."}}
{"actor":{"display_login":"DaveDavenport"}}