{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments/77474598","id":77474598,"diff_hunk":"@@ -73,12 +73,14 @@ function issubset{T<:SimpleGraph}(g::T, h::T)\n end\n \n \n-\"\"\"Add `n` new vertices to the graph `g`.\"\"\"\n+\"\"\"Add `n` new vertices to the graph `g`. Returns true if all vertices\n+were added successfully, false otherwise.\"\"\"\n function add_vertices!(g::SimpleGraph, n::Integer)\n+    added = true\n     for i = 1:n\n-        add_vertex!(g)\n+        added &= add_vertex!(g)","path":"src/core.jl","position":11,"original_position":11,"commit_id":"eddc47b6c80a86cbd8d2ad60d56f4de61bb3d1d7","original_commit_id":"ab5fe639f5b1e879b299a9f0c48cef335ebde70c","user":{"login":"sbromberger","id":941359,"avatar_url":"https://avatars.githubusercontent.com/u/941359?v=3","gravatar_id":"","url":"https://api.github.com/users/sbromberger","html_url":"https://github.com/sbromberger","followers_url":"https://api.github.com/users/sbromberger/followers","following_url":"https://api.github.com/users/sbromberger/following{/other_user}","gists_url":"https://api.github.com/users/sbromberger/gists{/gist_id}","starred_url":"https://api.github.com/users/sbromberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbromberger/subscriptions","organizations_url":"https://api.github.com/users/sbromberger/orgs","repos_url":"https://api.github.com/users/sbromberger/repos","events_url":"https://api.github.com/users/sbromberger/events{/privacy}","received_events_url":"https://api.github.com/users/sbromberger/received_events","type":"User","site_admin":false},"body":"Yes - that was my thinking. In the event we ever change the return logic for `add_vertex!`, we shouldn't need to change anything else.","created_at":"2016-09-05T06:18:07Z","updated_at":"2016-09-05T06:18:07Z","html_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432#discussion_r77474598","pull_request_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments/77474598"},"html":{"href":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432#discussion_r77474598"},"pull_request":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432","id":83933597,"html_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432","diff_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432.diff","patch_url":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432.patch","issue_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/432","number":432,"state":"open","locked":false,"title":"implements #246","user":{"login":"sbromberger","id":941359,"avatar_url":"https://avatars.githubusercontent.com/u/941359?v=3","gravatar_id":"","url":"https://api.github.com/users/sbromberger","html_url":"https://github.com/sbromberger","followers_url":"https://api.github.com/users/sbromberger/followers","following_url":"https://api.github.com/users/sbromberger/following{/other_user}","gists_url":"https://api.github.com/users/sbromberger/gists{/gist_id}","starred_url":"https://api.github.com/users/sbromberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbromberger/subscriptions","organizations_url":"https://api.github.com/users/sbromberger/orgs","repos_url":"https://api.github.com/users/sbromberger/repos","events_url":"https://api.github.com/users/sbromberger/events{/privacy}","received_events_url":"https://api.github.com/users/sbromberger/received_events","type":"User","site_admin":false},"body":"closes #246","created_at":"2016-09-04T20:47:55Z","updated_at":"2016-09-05T06:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c9216e7ffbd5017c31ab070cde3b3a47580cdf0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432/commits","review_comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432/comments","review_comment_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/432/comments","statuses_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/eddc47b6c80a86cbd8d2ad60d56f4de61bb3d1d7","head":{"label":"JuliaGraphs:add-rem-edge-returns","ref":"add-rem-edge-returns","sha":"eddc47b6c80a86cbd8d2ad60d56f4de61bb3d1d7","user":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"repo":{"id":29314835,"name":"LightGraphs.jl","full_name":"JuliaGraphs/LightGraphs.jl","owner":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGraphs/LightGraphs.jl","description":"An optimized graphs package for Julia","fork":false,"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl","forks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/forks","keys_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/events","assignees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/merges","archive_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/deployments","created_at":"2015-01-15T19:44:43Z","updated_at":"2016-08-30T05:33:47Z","pushed_at":"2016-09-05T06:08:08Z","git_url":"git://github.com/JuliaGraphs/LightGraphs.jl.git","ssh_url":"git@github.com:JuliaGraphs/LightGraphs.jl.git","clone_url":"https://github.com/JuliaGraphs/LightGraphs.jl.git","svn_url":"https://github.com/JuliaGraphs/LightGraphs.jl","homepage":"","size":4781,"stargazers_count":67,"watchers_count":67,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":23,"forks":27,"open_issues":23,"watchers":67,"default_branch":"master"}},"base":{"label":"JuliaGraphs:master","ref":"master","sha":"e8e2717db33a315a1114499624ec89d5098e4b84","user":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"repo":{"id":29314835,"name":"LightGraphs.jl","full_name":"JuliaGraphs/LightGraphs.jl","owner":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGraphs/LightGraphs.jl","description":"An optimized graphs package for Julia","fork":false,"url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl","forks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/forks","keys_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/events","assignees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/merges","archive_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/deployments","created_at":"2015-01-15T19:44:43Z","updated_at":"2016-08-30T05:33:47Z","pushed_at":"2016-09-05T06:08:08Z","git_url":"git://github.com/JuliaGraphs/LightGraphs.jl.git","ssh_url":"git@github.com:JuliaGraphs/LightGraphs.jl.git","clone_url":"https://github.com/JuliaGraphs/LightGraphs.jl.git","svn_url":"https://github.com/JuliaGraphs/LightGraphs.jl","homepage":"","size":4781,"stargazers_count":67,"watchers_count":67,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":23,"forks":27,"open_issues":23,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432"},"html":{"href":"https://github.com/JuliaGraphs/LightGraphs.jl/pull/432"},"issue":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/432"},"comments":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGraphs/LightGraphs.jl/statuses/eddc47b6c80a86cbd8d2ad60d56f4de61bb3d1d7"}}}}
{"actor":{"display_login":"sbromberger"}}