{"action":"created","issue":{"url":"https://api.github.com/repos/novoda/accessibilitools/issues/4","repository_url":"https://api.github.com/repos/novoda/accessibilitools","labels_url":"https://api.github.com/repos/novoda/accessibilitools/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/novoda/accessibilitools/issues/4/comments","events_url":"https://api.github.com/repos/novoda/accessibilitools/issues/4/events","html_url":"https://github.com/novoda/accessibilitools/pull/4","id":142941952,"number":4,"title":"Remove final so we can mock accessibility services (easily)","user":{"login":"takecare","id":212528,"avatar_url":"https://avatars.githubusercontent.com/u/212528?v=3","gravatar_id":"","url":"https://api.github.com/users/takecare","html_url":"https://github.com/takecare","followers_url":"https://api.github.com/users/takecare/followers","following_url":"https://api.github.com/users/takecare/following{/other_user}","gists_url":"https://api.github.com/users/takecare/gists{/gist_id}","starred_url":"https://api.github.com/users/takecare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takecare/subscriptions","organizations_url":"https://api.github.com/users/takecare/orgs","repos_url":"https://api.github.com/users/takecare/repos","events_url":"https://api.github.com/users/takecare/events{/privacy}","received_events_url":"https://api.github.com/users/takecare/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-23T11:59:47Z","updated_at":"2016-03-23T14:08:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/novoda/accessibilitools/pulls/4","html_url":"https://github.com/novoda/accessibilitools/pull/4","diff_url":"https://github.com/novoda/accessibilitools/pull/4.diff","patch_url":"https://github.com/novoda/accessibilitools/pull/4.patch"},"body":"In order to test some client classes we nee to mock AccessibilityServices, so we need to not have this class as `final`. An alternative would be to provide a test version of the library so it's swapped in as a test-only dependency.\r\n\r\nPaired with @jackSzm."},"comment":{"url":"https://api.github.com/repos/novoda/accessibilitools/issues/comments/200359225","html_url":"https://github.com/novoda/accessibilitools/pull/4#issuecomment-200359225","issue_url":"https://api.github.com/repos/novoda/accessibilitools/issues/4","id":200359225,"user":{"login":"rock3r","id":153802,"avatar_url":"https://avatars.githubusercontent.com/u/153802?v=3","gravatar_id":"","url":"https://api.github.com/users/rock3r","html_url":"https://github.com/rock3r","followers_url":"https://api.github.com/users/rock3r/followers","following_url":"https://api.github.com/users/rock3r/following{/other_user}","gists_url":"https://api.github.com/users/rock3r/gists{/gist_id}","starred_url":"https://api.github.com/users/rock3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock3r/subscriptions","organizations_url":"https://api.github.com/users/rock3r/orgs","repos_url":"https://api.github.com/users/rock3r/repos","events_url":"https://api.github.com/users/rock3r/events{/privacy}","received_events_url":"https://api.github.com/users/rock3r/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T14:08:49Z","updated_at":"2016-03-23T14:08:49Z","body":"LGTM :+1: too (even though I still prefer the closed by default principle, for many a reason I have explained already, this is more in line with what we usually do)"}}