{"action":"created","comment":{"url":"https://api.github.com/repos/openml/openml-python/pulls/comments/81402021","pull_request_review_id":2377020,"id":81402021,"diff_hunk":"@@ -0,0 +1,466 @@\n+from collections import OrderedDict, defaultdict\n+import importlib\n+import inspect\n+import json\n+import json.decoder\n+import six\n+import warnings\n+import sys\n+\n+import numpy as np\n+import scipy.stats.distributions\n+import sklearn.base\n+import sklearn.model_selection\n+# Necessary to have signature available in python 2.7\n+from sklearn.utils.fixes import signature\n+\n+from .flow import OpenMLFlow\n+from ..exceptions import OpenMLRestrictionViolated\n+\n+MAXIMAL_FLOW_LENGTH = 1024\n+\n+\n+if sys.version_info >= (3, 5):\n+    from json.decoder import JSONDecodeError\n+else:\n+    JSONDecodeError = ValueError\n+\n+\n+class SklearnToFlowConverter(object):\n+    \"\"\"Convert scikit-learn estimator into an OpenMLFlow.\"\"\"\n+\n+    def serialize_object(self, o):","path":"openml/flows/sklearn_converter.py","position":32,"original_position":32,"commit_id":"4c7673fc14c37fa1bed85e9296007272ab1039c5","original_commit_id":"4c7673fc14c37fa1bed85e9296007272ab1039c5","user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"body":"why not just ``serialize``?","created_at":"2016-09-30T19:21:29Z","updated_at":"2016-09-30T19:21:29Z","html_url":"https://github.com/openml/openml-python/pull/167#discussion_r81402021","pull_request_url":"https://api.github.com/repos/openml/openml-python/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/openml/openml-python/pulls/comments/81402021"},"html":{"href":"https://github.com/openml/openml-python/pull/167#discussion_r81402021"},"pull_request":{"href":"https://api.github.com/repos/openml/openml-python/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/openml/openml-python/pulls/167","id":83822523,"html_url":"https://github.com/openml/openml-python/pull/167","diff_url":"https://github.com/openml/openml-python/pull/167.diff","patch_url":"https://github.com/openml/openml-python/pull/167.patch","issue_url":"https://api.github.com/repos/openml/openml-python/issues/167","number":167,"state":"open","locked":false,"title":"Feature/upload flow","user":{"login":"mfeurer","id":5320498,"avatar_url":"https://avatars.githubusercontent.com/u/5320498?v=3","gravatar_id":"","url":"https://api.github.com/users/mfeurer","html_url":"https://github.com/mfeurer","followers_url":"https://api.github.com/users/mfeurer/followers","following_url":"https://api.github.com/users/mfeurer/following{/other_user}","gists_url":"https://api.github.com/users/mfeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/mfeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfeurer/subscriptions","organizations_url":"https://api.github.com/users/mfeurer/orgs","repos_url":"https://api.github.com/users/mfeurer/repos","events_url":"https://api.github.com/users/mfeurer/events{/privacy}","received_events_url":"https://api.github.com/users/mfeurer/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-02T15:40:11Z","updated_at":"2016-09-30T19:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7270a8b4bb476c697172aba67038a5cfe41abe18","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openml/openml-python/pulls/167/commits","review_comments_url":"https://api.github.com/repos/openml/openml-python/pulls/167/comments","review_comment_url":"https://api.github.com/repos/openml/openml-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openml/openml-python/issues/167/comments","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/4c7673fc14c37fa1bed85e9296007272ab1039c5","head":{"label":"openml:feature/upload-flow","ref":"feature/upload-flow","sha":"4c7673fc14c37fa1bed85e9296007272ab1039c5","user":{"login":"openml","id":4984562,"avatar_url":"https://avatars.githubusercontent.com/u/4984562?v=3","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"repo":{"id":17939040,"name":"openml-python","full_name":"openml/openml-python","owner":{"login":"openml","id":4984562,"avatar_url":"https://avatars.githubusercontent.com/u/4984562?v=3","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openml/openml-python","description":"Python module to interface with OpenML","fork":false,"url":"https://api.github.com/repos/openml/openml-python","forks_url":"https://api.github.com/repos/openml/openml-python/forks","keys_url":"https://api.github.com/repos/openml/openml-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openml/openml-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openml/openml-python/teams","hooks_url":"https://api.github.com/repos/openml/openml-python/hooks","issue_events_url":"https://api.github.com/repos/openml/openml-python/issues/events{/number}","events_url":"https://api.github.com/repos/openml/openml-python/events","assignees_url":"https://api.github.com/repos/openml/openml-python/assignees{/user}","branches_url":"https://api.github.com/repos/openml/openml-python/branches{/branch}","tags_url":"https://api.github.com/repos/openml/openml-python/tags","blobs_url":"https://api.github.com/repos/openml/openml-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openml/openml-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openml/openml-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/openml/openml-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/{sha}","languages_url":"https://api.github.com/repos/openml/openml-python/languages","stargazers_url":"https://api.github.com/repos/openml/openml-python/stargazers","contributors_url":"https://api.github.com/repos/openml/openml-python/contributors","subscribers_url":"https://api.github.com/repos/openml/openml-python/subscribers","subscription_url":"https://api.github.com/repos/openml/openml-python/subscription","commits_url":"https://api.github.com/repos/openml/openml-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/openml/openml-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/openml/openml-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/openml/openml-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/openml/openml-python/contents/{+path}","compare_url":"https://api.github.com/repos/openml/openml-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openml/openml-python/merges","archive_url":"https://api.github.com/repos/openml/openml-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openml/openml-python/downloads","issues_url":"https://api.github.com/repos/openml/openml-python/issues{/number}","pulls_url":"https://api.github.com/repos/openml/openml-python/pulls{/number}","milestones_url":"https://api.github.com/repos/openml/openml-python/milestones{/number}","notifications_url":"https://api.github.com/repos/openml/openml-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openml/openml-python/labels{/name}","releases_url":"https://api.github.com/repos/openml/openml-python/releases{/id}","deployments_url":"https://api.github.com/repos/openml/openml-python/deployments","created_at":"2014-03-20T10:46:41Z","updated_at":"2016-09-01T08:05:39Z","pushed_at":"2016-09-29T16:12:26Z","git_url":"git://github.com/openml/openml-python.git","ssh_url":"git@github.com:openml/openml-python.git","clone_url":"https://github.com/openml/openml-python.git","svn_url":"https://github.com/openml/openml-python","homepage":null,"size":2291,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":57,"forks":11,"open_issues":57,"watchers":29,"default_branch":"develop"}},"base":{"label":"openml:develop","ref":"develop","sha":"a407b752094a92c3f42f9938664e7b73da78f6ed","user":{"login":"openml","id":4984562,"avatar_url":"https://avatars.githubusercontent.com/u/4984562?v=3","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"repo":{"id":17939040,"name":"openml-python","full_name":"openml/openml-python","owner":{"login":"openml","id":4984562,"avatar_url":"https://avatars.githubusercontent.com/u/4984562?v=3","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openml/openml-python","description":"Python module to interface with OpenML","fork":false,"url":"https://api.github.com/repos/openml/openml-python","forks_url":"https://api.github.com/repos/openml/openml-python/forks","keys_url":"https://api.github.com/repos/openml/openml-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openml/openml-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openml/openml-python/teams","hooks_url":"https://api.github.com/repos/openml/openml-python/hooks","issue_events_url":"https://api.github.com/repos/openml/openml-python/issues/events{/number}","events_url":"https://api.github.com/repos/openml/openml-python/events","assignees_url":"https://api.github.com/repos/openml/openml-python/assignees{/user}","branches_url":"https://api.github.com/repos/openml/openml-python/branches{/branch}","tags_url":"https://api.github.com/repos/openml/openml-python/tags","blobs_url":"https://api.github.com/repos/openml/openml-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openml/openml-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openml/openml-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/openml/openml-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/{sha}","languages_url":"https://api.github.com/repos/openml/openml-python/languages","stargazers_url":"https://api.github.com/repos/openml/openml-python/stargazers","contributors_url":"https://api.github.com/repos/openml/openml-python/contributors","subscribers_url":"https://api.github.com/repos/openml/openml-python/subscribers","subscription_url":"https://api.github.com/repos/openml/openml-python/subscription","commits_url":"https://api.github.com/repos/openml/openml-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/openml/openml-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/openml/openml-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/openml/openml-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/openml/openml-python/contents/{+path}","compare_url":"https://api.github.com/repos/openml/openml-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openml/openml-python/merges","archive_url":"https://api.github.com/repos/openml/openml-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openml/openml-python/downloads","issues_url":"https://api.github.com/repos/openml/openml-python/issues{/number}","pulls_url":"https://api.github.com/repos/openml/openml-python/pulls{/number}","milestones_url":"https://api.github.com/repos/openml/openml-python/milestones{/number}","notifications_url":"https://api.github.com/repos/openml/openml-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openml/openml-python/labels{/name}","releases_url":"https://api.github.com/repos/openml/openml-python/releases{/id}","deployments_url":"https://api.github.com/repos/openml/openml-python/deployments","created_at":"2014-03-20T10:46:41Z","updated_at":"2016-09-01T08:05:39Z","pushed_at":"2016-09-29T16:12:26Z","git_url":"git://github.com/openml/openml-python.git","ssh_url":"git@github.com:openml/openml-python.git","clone_url":"https://github.com/openml/openml-python.git","svn_url":"https://github.com/openml/openml-python","homepage":null,"size":2291,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":57,"forks":11,"open_issues":57,"watchers":29,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openml/openml-python/pulls/167"},"html":{"href":"https://github.com/openml/openml-python/pull/167"},"issue":{"href":"https://api.github.com/repos/openml/openml-python/issues/167"},"comments":{"href":"https://api.github.com/repos/openml/openml-python/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/openml/openml-python/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/openml/openml-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openml/openml-python/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/openml/openml-python/statuses/4c7673fc14c37fa1bed85e9296007272ab1039c5"}}}}
{"actor":{"display_login":"amueller"}}