{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6187","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6187/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6187/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6187/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/6187","id":115253481,"number":6187,"title":"Clean up and enhance enum_dns","user":{"login":"all3g","id":7352479,"avatar_url":"https://avatars.githubusercontent.com/u/7352479?v=3","gravatar_id":"","url":"https://api.github.com/users/all3g","html_url":"https://github.com/all3g","followers_url":"https://api.github.com/users/all3g/followers","following_url":"https://api.github.com/users/all3g/following{/other_user}","gists_url":"https://api.github.com/users/all3g/gists{/gist_id}","starred_url":"https://api.github.com/users/all3g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3g/subscriptions","organizations_url":"https://api.github.com/users/all3g/orgs","repos_url":"https://api.github.com/users/all3g/repos","events_url":"https://api.github.com/users/all3g/events{/privacy}","received_events_url":"https://api.github.com/users/all3g/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/enhancement","name":"enhancement","color":"5319e7"},{"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/module","name":"module","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"jhart-r7","id":3869433,"avatar_url":"https://avatars.githubusercontent.com/u/3869433?v=3","gravatar_id":"","url":"https://api.github.com/users/jhart-r7","html_url":"https://github.com/jhart-r7","followers_url":"https://api.github.com/users/jhart-r7/followers","following_url":"https://api.github.com/users/jhart-r7/following{/other_user}","gists_url":"https://api.github.com/users/jhart-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jhart-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhart-r7/subscriptions","organizations_url":"https://api.github.com/users/jhart-r7/orgs","repos_url":"https://api.github.com/users/jhart-r7/repos","events_url":"https://api.github.com/users/jhart-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jhart-r7/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-11-05T10:25:36Z","updated_at":"2016-02-01T06:46:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6187","html_url":"https://github.com/rapid7/metasploit-framework/pull/6187","diff_url":"https://github.com/rapid7/metasploit-framework/pull/6187.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/6187.patch"},"body":"Related: [5824](https://github.com/rapid7/metasploit-framework/pull/5824) and [#5942](https://github.com/rapid7/metasploit-framework/pull/5942). In order to collect dns records in a stable way, we review **[enum_dns](https://github.com/rapid7/metasploit-framework/blob/master/modules/auxiliary/gather/enum_dns.rb)**. Please find issues, and report it here. Thanks !\r\n\r\n```\r\nmsf auxiliary(enum_dns) > show options \r\n\r\nModule options (auxiliary/gather/enum_dns):\r\n\r\n   Name         Current Setting    Required  Description\r\n   ----         ---------------    --------  -----------\r\n   DOMAIN                          yes       The target domain\r\n   ENUM_A       true               yes       Enumerate DNS A record\r\n   ENUM_AXFR    true               yes       Initiate a zone transfer against each NS record\r\n   ENUM_BRT     false              yes       Brute force subdomains and hostnames via the supplied wordlist\r\n   ENUM_CNAME   true               yes       Enumerate DNS CNAME record\r\n   ENUM_MX      true               yes       Enumerate DNS MX record\r\n   ENUM_NS      true               yes       Enumerate DNS NS record\r\n   ENUM_RVL     false              yes       Reverse lookup a range of IP addresses\r\n   ENUM_SOA     true               yes       Enumerate DNS SOA record\r\n   ENUM_SRV     true               yes       Enumerate the most common SRV records\r\n   ENUM_TLD     true               yes       Perform a TLD expansion by replacing the TLD with the IANA TLD list\r\n   ENUM_TXT     true               yes       Enumerate DNS TXT record\r\n   IPRANGE                         no        The target address range or CIDR identifier\r\n   NS                              no        Specify the nameserver to use for queries (default is system DNS)\r\n   STOP_WLDCRD  false              yes       Stops bruteforce enumeration if wildcard resolution is detected\r\n   STORE_LOOT   true               yes       Store acquired DNS records as loot\r\n   THREADS      1                  no        Threads for ENUM_BRT\r\n   WORDLIST     /tmp/namelist.txt  no        Wordlist of subdomains\r\n```"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/177808190","html_url":"https://github.com/rapid7/metasploit-framework/pull/6187#issuecomment-177808190","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6187","id":177808190,"user":{"login":"sempervictus","id":1331084,"avatar_url":"https://avatars.githubusercontent.com/u/1331084?v=3","gravatar_id":"","url":"https://api.github.com/users/sempervictus","html_url":"https://github.com/sempervictus","followers_url":"https://api.github.com/users/sempervictus/followers","following_url":"https://api.github.com/users/sempervictus/following{/other_user}","gists_url":"https://api.github.com/users/sempervictus/gists{/gist_id}","starred_url":"https://api.github.com/users/sempervictus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempervictus/subscriptions","organizations_url":"https://api.github.com/users/sempervictus/orgs","repos_url":"https://api.github.com/users/sempervictus/repos","events_url":"https://api.github.com/users/sempervictus/events{/privacy}","received_events_url":"https://api.github.com/users/sempervictus/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T06:46:46Z","updated_at":"2016-02-01T06:46:46Z","body":"Took a quick look, some good changes, totally mauls my module/implementation in merge though.\r\nOld unmerged PRs which i personally think @devs should reconsider and get into upstream allow DNS to work via Rex (https://github.com/rapid7/metasploit-framework/pull/709) giving the masses pivot and proxy scanning (i believe the DNS_TCP piece _was_ merged upstream), and then there's the threaded pull request which significantly speeds up DNS probes in a convenient in-framework module instead of importing others' outputs (https://github.com/rapid7/metasploit-framework/pull/852). When using RBX as the Ruby engine, this is a pretty major win in terms of scan performance.\r\n\r\nGiven the amount of code in all of these modules, i'd suggest getting Rex in line with what we have for DNS to aid functionality/evasion, creating a scanner library for DNS with all the methods in all of these methods. Implementing a threaded scanner with those methods similar to #852, and exposing all of that through the end-user module in framework. It should help people write quick and dirty scanners using the base methods without reproducing code left and right, and without the maintenance nightmare of this module (no offense intended Carlos)."}}