{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/73590712","id":73590712,"diff_hunk":"@@ -0,0 +1,93 @@\n+package org.apache.mesos.config;\n+\n+import com.fasterxml.jackson.annotation.JsonCreator;\n+import com.fasterxml.jackson.annotation.JsonProperty;\n+\n+/**\n+ * Represents the repair configuration in JSON.\n+ */\n+public class RepairConfiguration {\n+    @Override\n+    public boolean equals(Object o) {\n+        if (this == o) {\n+        return true;\n+        }\n+        if (o == null || getClass() != o.getClass()) {\n+            return false;\n+        }\n+\n+        RepairConfiguration that = (RepairConfiguration) o;\n+\n+        if (gracePeriodMins != that.gracePeriodMins) {\n+            return false;\n+        }\n+        if (repairDelaySecs != that.repairDelaySecs) {\n+            return false;\n+        }\n+        return enableReplacement == that.enableReplacement;\n+\n+    }\n+\n+    @Override\n+    public int hashCode() {\n+        int result = gracePeriodMins;\n+        result = 31 * result + repairDelaySecs;\n+        result = 31 * result + (enableReplacement ? 1 : 0);\n+        return result;\n+    }\n+\n+    @JsonProperty(\"repairInPlaceGracePeriodMins\")\n+    private int gracePeriodMins;\n+    @JsonProperty(\"minDelayBetweenRepairsSecs\")\n+    private int repairDelaySecs;\n+    @JsonProperty(\"enableReplacement\")\n+    private boolean enableReplacement;\n+\n+    public  RepairConfiguration() {}\n+\n+    @JsonCreator\n+    public RepairConfiguration(\n+            @JsonProperty(\"repairInPlaceGracePeriodMins\") int gracePeriodMins,\n+            @JsonProperty(\"minDelayBetweenRepairsSecs\") int repairDelaySecs,\n+            @JsonProperty(\"enableReplacement\") boolean enableReplacement) {\n+        this.gracePeriodMins = gracePeriodMins;\n+        this.repairDelaySecs = repairDelaySecs;\n+        this.enableReplacement = enableReplacement;\n+    }\n+\n+    public boolean isEnableReplacement() {\n+        return enableReplacement;\n+    }\n+\n+    @JsonProperty(\"enableReplacement\")\n+    public void setEnableReplacement(boolean enableReplacement) {\n+        this.enableReplacement = enableReplacement;\n+    }\n+\n+    public int getRepairDelaySecs() {","path":"src/main/java/org/apache/mesos/config/RepairConfiguration.java","position":null,"original_position":67,"commit_id":"4cc349ed9243d89861438c9c565a58a3333d118b","original_commit_id":"8c07626c6f9410f8e6a58d1f78168ba6b6410ec2","user":{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars.githubusercontent.com/u/567111?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false},"body":"Yet another reason I don't like YAML for config.  Oh well.  If it's too hard to have both config in YAML and have classes that reasonable signatures for internal consumption, we can stay with the current approach.  To be clear, my proposal was to essentially leave what you have here alone, and add something which provides a better interface for internal consumption, and translate between the two as necessary.","created_at":"2016-08-04T19:51:17Z","updated_at":"2016-08-04T19:51:17Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/77#discussion_r73590712","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/73590712"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/77#discussion_r73590712"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77","id":79650730,"html_url":"https://github.com/mesosphere/dcos-commons/pull/77","diff_url":"https://github.com/mesosphere/dcos-commons/pull/77.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/77.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/77","number":77,"state":"open","locked":false,"title":"Automatically repairing scheduler implementation","user":{"login":"dgrnbrg","id":618507,"avatar_url":"https://avatars.githubusercontent.com/u/618507?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrnbrg","html_url":"https://github.com/dgrnbrg","followers_url":"https://api.github.com/users/dgrnbrg/followers","following_url":"https://api.github.com/users/dgrnbrg/following{/other_user}","gists_url":"https://api.github.com/users/dgrnbrg/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrnbrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrnbrg/subscriptions","organizations_url":"https://api.github.com/users/dgrnbrg/orgs","repos_url":"https://api.github.com/users/dgrnbrg/repos","events_url":"https://api.github.com/users/dgrnbrg/events{/privacy}","received_events_url":"https://api.github.com/users/dgrnbrg/received_events","type":"User","site_admin":false},"body":"This PR implements a new scheduler called `RepairScheduler`. This helps frameworks handle failure & restarts for persistent-disk based applications.\r\n\r\nThis is implementation complete, but still needs tests that do not depend on the proprietary libraries they were originally developed against.","created_at":"2016-08-01T22:56:18Z","updated_at":"2016-08-04T19:51:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e388d449793d758d1715b1959f1373db8e53e72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/77/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/4cc349ed9243d89861438c9c565a58a3333d118b","head":{"label":"dgrnbrg:tardigrade","ref":"tardigrade","sha":"4cc349ed9243d89861438c9c565a58a3333d118b","user":{"login":"dgrnbrg","id":618507,"avatar_url":"https://avatars.githubusercontent.com/u/618507?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrnbrg","html_url":"https://github.com/dgrnbrg","followers_url":"https://api.github.com/users/dgrnbrg/followers","following_url":"https://api.github.com/users/dgrnbrg/following{/other_user}","gists_url":"https://api.github.com/users/dgrnbrg/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrnbrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrnbrg/subscriptions","organizations_url":"https://api.github.com/users/dgrnbrg/orgs","repos_url":"https://api.github.com/users/dgrnbrg/repos","events_url":"https://api.github.com/users/dgrnbrg/events{/privacy}","received_events_url":"https://api.github.com/users/dgrnbrg/received_events","type":"User","site_admin":false},"repo":{"id":61917016,"name":"dcos-commons","full_name":"dgrnbrg/dcos-commons","owner":{"login":"dgrnbrg","id":618507,"avatar_url":"https://avatars.githubusercontent.com/u/618507?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrnbrg","html_url":"https://github.com/dgrnbrg","followers_url":"https://api.github.com/users/dgrnbrg/followers","following_url":"https://api.github.com/users/dgrnbrg/following{/other_user}","gists_url":"https://api.github.com/users/dgrnbrg/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrnbrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrnbrg/subscriptions","organizations_url":"https://api.github.com/users/dgrnbrg/orgs","repos_url":"https://api.github.com/users/dgrnbrg/repos","events_url":"https://api.github.com/users/dgrnbrg/events{/privacy}","received_events_url":"https://api.github.com/users/dgrnbrg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgrnbrg/dcos-commons","description":null,"fork":true,"url":"https://api.github.com/repos/dgrnbrg/dcos-commons","forks_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/forks","keys_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/teams","hooks_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/events","assignees_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/tags","blobs_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/subscription","commits_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/merges","archive_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/downloads","issues_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/dgrnbrg/dcos-commons/deployments","created_at":"2016-06-24T23:02:24Z","updated_at":"2016-06-24T23:02:25Z","pushed_at":"2016-08-04T19:35:36Z","git_url":"git://github.com/dgrnbrg/dcos-commons.git","ssh_url":"git@github.com:dgrnbrg/dcos-commons.git","clone_url":"https://github.com/dgrnbrg/dcos-commons.git","svn_url":"https://github.com/dgrnbrg/dcos-commons","homepage":null,"size":571,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"c6924279966fb73108a9016b1c0c4a7b780d6976","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2016-08-03T15:28:52Z","pushed_at":"2016-08-04T19:35:36Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":null,"size":591,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/77"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/77"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/4cc349ed9243d89861438c9c565a58a3333d118b"}}}}
{"actor":{"display_login":"gabrielhartmann"}}