{"action":"opened","number":254,"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254","id":73723909,"html_url":"https://github.com/moneyadviceservice/mortgage_calculator/pull/254","diff_url":"https://github.com/moneyadviceservice/mortgage_calculator/pull/254.diff","patch_url":"https://github.com/moneyadviceservice/mortgage_calculator/pull/254.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/254","number":254,"state":"open","locked":false,"title":"7405 - New tooltip and accessibility fixes for colour changing","user":{"login":"slaywell","id":14920201,"avatar_url":"https://avatars.githubusercontent.com/u/14920201?v=3","gravatar_id":"","url":"https://api.github.com/users/slaywell","html_url":"https://github.com/slaywell","followers_url":"https://api.github.com/users/slaywell/followers","following_url":"https://api.github.com/users/slaywell/following{/other_user}","gists_url":"https://api.github.com/users/slaywell/gists{/gist_id}","starred_url":"https://api.github.com/users/slaywell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaywell/subscriptions","organizations_url":"https://api.github.com/users/slaywell/orgs","repos_url":"https://api.github.com/users/slaywell/repos","events_url":"https://api.github.com/users/slaywell/events{/privacy}","received_events_url":"https://api.github.com/users/slaywell/received_events","type":"User","site_admin":false},"body":"## Overview\r\nThis PR adds the coloured labels and tooltip with a border:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/14920201/16041184/f4d2f8ae-322b-11e6-8174-938eafdae3c3.png)\r\n\r\n## Details\r\n1. Changes the colours of the labels so that they are black text on a colour-changing background. This fixes a problem that we had before where the colour contrast was too low.\r\n2. Adds a tooltip that 'persists on screen' once revealed. All of the other tooltips disappear on the 'blur' event, which is not what we want for this one as it has important content and a link within it.\r\n3. Refactors some of the CSS for the colour-changing, and adds a class for in-page anchor links that is offset from the top (to avoid the sticky header appearing over the content).\r\n\r\n## Notes\r\nI thought about putting the HTML for the new tooltip into a partial in the same way as the existing tooltips work - see `app/views/mortgage_calculator/affordabilities/_field_tooltip.erb` - but didn't for two reasons, this is a specific one-off use case for this markup, and I had to pass a lot of parameters to the partial to get the data into it. Happy to refactor this if there's a better solution though.","created_at":"2016-06-14T11:35:44Z","updated_at":"2016-06-14T11:35:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7d46951f3064a8f0b9d112147e19f59fe30fadd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/254/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/statuses/f62baf8ca0e8184e4230fc87f189c3029bf2bbbb","head":{"label":"moneyadviceservice:7405-accessibility-of-colors","ref":"7405-accessibility-of-colors","sha":"f62baf8ca0e8184e4230fc87f189c3029bf2bbbb","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":16581429,"name":"mortgage_calculator","full_name":"moneyadviceservice/mortgage_calculator","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/mortgage_calculator","description":"Mortgage calculator tools","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator","forks_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/deployments","created_at":"2014-02-06T14:17:20Z","updated_at":"2016-02-02T09:34:50Z","pushed_at":"2016-06-14T11:35:44Z","git_url":"git://github.com/moneyadviceservice/mortgage_calculator.git","ssh_url":"git@github.com:moneyadviceservice/mortgage_calculator.git","clone_url":"https://github.com/moneyadviceservice/mortgage_calculator.git","svn_url":"https://github.com/moneyadviceservice/mortgage_calculator","homepage":"https://www.moneyadviceservice.org.uk/en/tools/mortgage-calculator","size":2894,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"moneyadviceservice:cultivate","ref":"cultivate","sha":"6bd7de24ba333ff2ef1723a03cc1208fefaea2da","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":16581429,"name":"mortgage_calculator","full_name":"moneyadviceservice/mortgage_calculator","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/mortgage_calculator","description":"Mortgage calculator tools","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator","forks_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/deployments","created_at":"2014-02-06T14:17:20Z","updated_at":"2016-02-02T09:34:50Z","pushed_at":"2016-06-14T11:35:44Z","git_url":"git://github.com/moneyadviceservice/mortgage_calculator.git","ssh_url":"git@github.com:moneyadviceservice/mortgage_calculator.git","clone_url":"https://github.com/moneyadviceservice/mortgage_calculator.git","svn_url":"https://github.com/moneyadviceservice/mortgage_calculator","homepage":"https://www.moneyadviceservice.org.uk/en/tools/mortgage-calculator","size":2894,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254"},"html":{"href":"https://github.com/moneyadviceservice/mortgage_calculator/pull/254"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/254"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/mortgage_calculator/statuses/f62baf8ca0e8184e4230fc87f189c3029bf2bbbb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":86,"deletions":101,"changed_files":13}}
{"actor":{"display_login":"slaywell"}}