{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1094","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1094/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1094/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1094/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1094","id":192762758,"number":1094,"title":"Add BigQuery Query Parameters","user":{"login":"blowmage","id":730,"avatar_url":"https://avatars.githubusercontent.com/u/730?v=3","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"labels":[{"id":172905378,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/labels/bigquery","name":"bigquery","color":"0052cc","default":false},{"id":166382179,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-01T06:14:20Z","updated_at":"2016-12-01T22:32:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/1094","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1094","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1094.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1094.patch"},"body":"Implement BigQuery Query Parameters.\r\n\r\nPositional Query Parameters:\r\n\r\n```ruby\r\nrequire \"google/cloud/bigquery\"\r\n\r\nbigquery = Google::Cloud::Bigquery.new\r\n\r\ndataset = bigquery.dataset \"my_dataset\"\r\ndata = dataset.query \"SELECT * FROM users WHERE id = ?\", \r\n                     params: [1234567890]\r\n```\r\n\r\nNamed Query Parameters:\r\n\r\n```ruby\r\nrequire \"google/cloud/bigquery\"\r\n\r\nbigquery = Google::Cloud::Bigquery.new\r\n\r\ndataset = bigquery.dataset \"my_dataset\"\r\ndata = dataset.query \"SELECT * FROM users WHERE id = @id\", \r\n                     params: { id: 1234567890 }\r\n```\r\n\r\n- [x] Implement Query Parameters\r\n- [x] Unit Tests\r\n- [x] Acceptance Tests\r\n- [x] Method-level Documentation\r\n- [x] LegacySQL Documentation\r\n- [ ] Overview Documentation\r\n\r\n[closes #1070]"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/comments/264316315","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1094#issuecomment-264316315","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1094","id":264316315,"user":{"login":"blowmage","id":730,"avatar_url":"https://avatars.githubusercontent.com/u/730?v=3","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T22:32:29Z","updated_at":"2016-12-01T22:32:29Z","body":"I think the changes in this PR look simple at first, but conceptually it is quite large. The differences between legacy SQL and standard SQL is going to be a thing users will have to understand in order to use BigQuery well.\r\n\r\nThat said, I'm really happy with the Ruby API for providing positional and named query parameters. And I'm super happy we can maintain backwards compatibility without making the Ruby API overly convoluted."}}
{"actor":{"display_login":"blowmage"}}