{"action":"closed","number":1723,"pull_request":{"url":"https://api.github.com/repos/octobercms/october/pulls/1723","id":57009549,"html_url":"https://github.com/octobercms/october/pull/1723","diff_url":"https://github.com/octobercms/october/pull/1723.diff","patch_url":"https://github.com/octobercms/october/pull/1723.patch","issue_url":"https://api.github.com/repos/octobercms/october/issues/1723","number":1723,"state":"closed","locked":false,"title":"Make default 404 page use 404 status code","user":{"login":"Herlevsen","id":3679012,"avatar_url":"https://avatars.githubusercontent.com/u/3679012?v=3","gravatar_id":"","url":"https://api.github.com/users/Herlevsen","html_url":"https://github.com/Herlevsen","followers_url":"https://api.github.com/users/Herlevsen/followers","following_url":"https://api.github.com/users/Herlevsen/following{/other_user}","gists_url":"https://api.github.com/users/Herlevsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Herlevsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herlevsen/subscriptions","organizations_url":"https://api.github.com/users/Herlevsen/orgs","repos_url":"https://api.github.com/users/Herlevsen/repos","events_url":"https://api.github.com/users/Herlevsen/events{/privacy}","received_events_url":"https://api.github.com/users/Herlevsen/received_events","type":"User","site_admin":false},"body":"On a fresh installation, when the default 404 page is visited at domain.com/404, the HTTP status code is 200. That would make search engines able to index the 404 page. IMO the url should act as if the 404 page itself did not exist.","created_at":"2016-01-24T18:15:37Z","updated_at":"2016-02-13T04:43:48Z","closed_at":"2016-02-13T04:43:48Z","merged_at":"2016-02-13T04:43:48Z","merge_commit_sha":"daa0c0d8f491cddc7e582bd6b602f9a74d945d96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/octobercms/october/pulls/1723/commits","review_comments_url":"https://api.github.com/repos/octobercms/october/pulls/1723/comments","review_comment_url":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octobercms/october/issues/1723/comments","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/2350e30853cc2c1337697bb38c113f7319eea0f1","head":{"label":"Herlevsen:develop","ref":"develop","sha":"2350e30853cc2c1337697bb38c113f7319eea0f1","user":{"login":"Herlevsen","id":3679012,"avatar_url":"https://avatars.githubusercontent.com/u/3679012?v=3","gravatar_id":"","url":"https://api.github.com/users/Herlevsen","html_url":"https://github.com/Herlevsen","followers_url":"https://api.github.com/users/Herlevsen/followers","following_url":"https://api.github.com/users/Herlevsen/following{/other_user}","gists_url":"https://api.github.com/users/Herlevsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Herlevsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herlevsen/subscriptions","organizations_url":"https://api.github.com/users/Herlevsen/orgs","repos_url":"https://api.github.com/users/Herlevsen/repos","events_url":"https://api.github.com/users/Herlevsen/events{/privacy}","received_events_url":"https://api.github.com/users/Herlevsen/received_events","type":"User","site_admin":false},"repo":{"id":50296973,"name":"october","full_name":"Herlevsen/october","owner":{"login":"Herlevsen","id":3679012,"avatar_url":"https://avatars.githubusercontent.com/u/3679012?v=3","gravatar_id":"","url":"https://api.github.com/users/Herlevsen","html_url":"https://github.com/Herlevsen","followers_url":"https://api.github.com/users/Herlevsen/followers","following_url":"https://api.github.com/users/Herlevsen/following{/other_user}","gists_url":"https://api.github.com/users/Herlevsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Herlevsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herlevsen/subscriptions","organizations_url":"https://api.github.com/users/Herlevsen/orgs","repos_url":"https://api.github.com/users/Herlevsen/repos","events_url":"https://api.github.com/users/Herlevsen/events{/privacy}","received_events_url":"https://api.github.com/users/Herlevsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Herlevsen/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":true,"url":"https://api.github.com/repos/Herlevsen/october","forks_url":"https://api.github.com/repos/Herlevsen/october/forks","keys_url":"https://api.github.com/repos/Herlevsen/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Herlevsen/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Herlevsen/october/teams","hooks_url":"https://api.github.com/repos/Herlevsen/october/hooks","issue_events_url":"https://api.github.com/repos/Herlevsen/october/issues/events{/number}","events_url":"https://api.github.com/repos/Herlevsen/october/events","assignees_url":"https://api.github.com/repos/Herlevsen/october/assignees{/user}","branches_url":"https://api.github.com/repos/Herlevsen/october/branches{/branch}","tags_url":"https://api.github.com/repos/Herlevsen/october/tags","blobs_url":"https://api.github.com/repos/Herlevsen/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Herlevsen/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Herlevsen/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/Herlevsen/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Herlevsen/october/statuses/{sha}","languages_url":"https://api.github.com/repos/Herlevsen/october/languages","stargazers_url":"https://api.github.com/repos/Herlevsen/october/stargazers","contributors_url":"https://api.github.com/repos/Herlevsen/october/contributors","subscribers_url":"https://api.github.com/repos/Herlevsen/october/subscribers","subscription_url":"https://api.github.com/repos/Herlevsen/october/subscription","commits_url":"https://api.github.com/repos/Herlevsen/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/Herlevsen/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/Herlevsen/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/Herlevsen/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/Herlevsen/october/contents/{+path}","compare_url":"https://api.github.com/repos/Herlevsen/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Herlevsen/october/merges","archive_url":"https://api.github.com/repos/Herlevsen/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Herlevsen/october/downloads","issues_url":"https://api.github.com/repos/Herlevsen/october/issues{/number}","pulls_url":"https://api.github.com/repos/Herlevsen/october/pulls{/number}","milestones_url":"https://api.github.com/repos/Herlevsen/october/milestones{/number}","notifications_url":"https://api.github.com/repos/Herlevsen/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Herlevsen/october/labels{/name}","releases_url":"https://api.github.com/repos/Herlevsen/october/releases{/id}","deployments_url":"https://api.github.com/repos/Herlevsen/october/deployments","created_at":"2016-01-24T16:43:13Z","updated_at":"2016-01-24T16:43:16Z","pushed_at":"2016-01-24T18:05:35Z","git_url":"git://github.com/Herlevsen/october.git","ssh_url":"git@github.com:Herlevsen/october.git","clone_url":"https://github.com/Herlevsen/october.git","svn_url":"https://github.com/Herlevsen/october","homepage":"http://octobercms.com/","size":21037,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octobercms:develop","ref":"develop","sha":"af4f42e2080f64dffe3d6dcf007615ce45665959","user":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars.githubusercontent.com/u/5554805?v=3","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"repo":{"id":14732311,"name":"october","full_name":"octobercms/october","owner":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars.githubusercontent.com/u/5554805?v=3","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octobercms/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":false,"url":"https://api.github.com/repos/octobercms/october","forks_url":"https://api.github.com/repos/octobercms/october/forks","keys_url":"https://api.github.com/repos/octobercms/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octobercms/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octobercms/october/teams","hooks_url":"https://api.github.com/repos/octobercms/october/hooks","issue_events_url":"https://api.github.com/repos/octobercms/october/issues/events{/number}","events_url":"https://api.github.com/repos/octobercms/october/events","assignees_url":"https://api.github.com/repos/octobercms/october/assignees{/user}","branches_url":"https://api.github.com/repos/octobercms/october/branches{/branch}","tags_url":"https://api.github.com/repos/octobercms/october/tags","blobs_url":"https://api.github.com/repos/octobercms/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octobercms/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octobercms/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/octobercms/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/{sha}","languages_url":"https://api.github.com/repos/octobercms/october/languages","stargazers_url":"https://api.github.com/repos/octobercms/october/stargazers","contributors_url":"https://api.github.com/repos/octobercms/october/contributors","subscribers_url":"https://api.github.com/repos/octobercms/october/subscribers","subscription_url":"https://api.github.com/repos/octobercms/october/subscription","commits_url":"https://api.github.com/repos/octobercms/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/octobercms/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/octobercms/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/octobercms/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/octobercms/october/contents/{+path}","compare_url":"https://api.github.com/repos/octobercms/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octobercms/october/merges","archive_url":"https://api.github.com/repos/octobercms/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octobercms/october/downloads","issues_url":"https://api.github.com/repos/octobercms/october/issues{/number}","pulls_url":"https://api.github.com/repos/octobercms/october/pulls{/number}","milestones_url":"https://api.github.com/repos/octobercms/october/milestones{/number}","notifications_url":"https://api.github.com/repos/octobercms/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octobercms/october/labels{/name}","releases_url":"https://api.github.com/repos/octobercms/october/releases{/id}","deployments_url":"https://api.github.com/repos/octobercms/october/deployments","created_at":"2013-11-26T23:30:43Z","updated_at":"2016-02-13T00:00:42Z","pushed_at":"2016-02-13T04:43:48Z","git_url":"git://github.com/octobercms/october.git","ssh_url":"git@github.com:octobercms/october.git","clone_url":"https://github.com/octobercms/october.git","svn_url":"https://github.com/octobercms/october","homepage":"http://octobercms.com/","size":22141,"stargazers_count":4120,"watchers_count":4120,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":957,"mirror_url":null,"open_issues_count":244,"forks":957,"open_issues":244,"watchers":4120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octobercms/october/pulls/1723"},"html":{"href":"https://github.com/octobercms/october/pull/1723"},"issue":{"href":"https://api.github.com/repos/octobercms/october/issues/1723"},"comments":{"href":"https://api.github.com/repos/octobercms/october/issues/1723/comments"},"review_comments":{"href":"https://api.github.com/repos/octobercms/october/pulls/1723/comments"},"review_comment":{"href":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octobercms/october/pulls/1723/commits"},"statuses":{"href":"https://api.github.com/repos/octobercms/october/statuses/2350e30853cc2c1337697bb38c113f7319eea0f1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"daftspunk","id":1392869,"avatar_url":"https://avatars.githubusercontent.com/u/1392869?v=3","gravatar_id":"","url":"https://api.github.com/users/daftspunk","html_url":"https://github.com/daftspunk","followers_url":"https://api.github.com/users/daftspunk/followers","following_url":"https://api.github.com/users/daftspunk/following{/other_user}","gists_url":"https://api.github.com/users/daftspunk/gists{/gist_id}","starred_url":"https://api.github.com/users/daftspunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daftspunk/subscriptions","organizations_url":"https://api.github.com/users/daftspunk/orgs","repos_url":"https://api.github.com/users/daftspunk/repos","events_url":"https://api.github.com/users/daftspunk/events{/privacy}","received_events_url":"https://api.github.com/users/daftspunk/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}