{"action":"created","issue":{"url":"https://api.github.com/repos/pydata/xarray/issues/1060","repository_url":"https://api.github.com/repos/pydata/xarray","labels_url":"https://api.github.com/repos/pydata/xarray/issues/1060/labels{/name}","comments_url":"https://api.github.com/repos/pydata/xarray/issues/1060/comments","events_url":"https://api.github.com/repos/pydata/xarray/issues/1060/events","html_url":"https://github.com/pydata/xarray/pull/1060","id":185181822,"number":1060,"title":"Remove obsolete NetCDF4 Error catch","user":{"login":"fmaussion","id":10050469,"avatar_url":"https://avatars.githubusercontent.com/u/10050469?v=3","gravatar_id":"","url":"https://api.github.com/users/fmaussion","html_url":"https://github.com/fmaussion","followers_url":"https://api.github.com/users/fmaussion/followers","following_url":"https://api.github.com/users/fmaussion/following{/other_user}","gists_url":"https://api.github.com/users/fmaussion/gists{/gist_id}","starred_url":"https://api.github.com/users/fmaussion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmaussion/subscriptions","organizations_url":"https://api.github.com/users/fmaussion/orgs","repos_url":"https://api.github.com/users/fmaussion/repos","events_url":"https://api.github.com/users/fmaussion/events{/privacy}","received_events_url":"https://api.github.com/users/fmaussion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-25T17:25:33Z","updated_at":"2016-12-16T19:52:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pydata/xarray/pulls/1060","html_url":"https://github.com/pydata/xarray/pull/1060","diff_url":"https://github.com/pydata/xarray/pull/1060.diff","patch_url":"https://github.com/pydata/xarray/pull/1060.patch"},"body":"[edit: this original PR was replaced with another change: \"remove obsolete NetCDF4 Error catch\"]\r\n\r\nThis allows to give a customized NetCDF4 object to the DataStore.\r\n\r\nI needed this for Salem's diagnostic variables: https://github.com/fmaussion/salem/blob/master/salem/sio.py#L737-L751\r\n\r\nMy workaround (a very [shallow](https://github.com/fmaussion/salem/blob/master/salem/sio.py#L653) subclass of NetCDF4DataStore) is fine for me, so I won't be offended if you decide not to merge.\r\n\r\nOn a related issue, the IndexError catch which happens [here](https://github.com/pydata/xarray/blob/master/xarray/backends/netCDF4_.py#L52) is also giving me trouble, since it hides bugs in my code. \r\n\r\nI know I'm kind of misusing the backend, but I find it very useful the way it is. I'm open to any suggestion to make it more elegant. Thanks!\r\n"},"comment":{"url":"https://api.github.com/repos/pydata/xarray/issues/comments/267681380","html_url":"https://github.com/pydata/xarray/pull/1060#issuecomment-267681380","issue_url":"https://api.github.com/repos/pydata/xarray/issues/1060","id":267681380,"user":{"login":"fmaussion","id":10050469,"avatar_url":"https://avatars.githubusercontent.com/u/10050469?v=3","gravatar_id":"","url":"https://api.github.com/users/fmaussion","html_url":"https://github.com/fmaussion","followers_url":"https://api.github.com/users/fmaussion/followers","following_url":"https://api.github.com/users/fmaussion/following{/other_user}","gists_url":"https://api.github.com/users/fmaussion/gists{/gist_id}","starred_url":"https://api.github.com/users/fmaussion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmaussion/subscriptions","organizations_url":"https://api.github.com/users/fmaussion/orgs","repos_url":"https://api.github.com/users/fmaussion/repos","events_url":"https://api.github.com/users/fmaussion/events{/privacy}","received_events_url":"https://api.github.com/users/fmaussion/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T19:52:17Z","updated_at":"2016-12-16T19:52:17Z","body":"I don't have a strong opinion on this. I guess that older systems are bound to a specific version of the C netCDF library, not with a specific python netCDF4 lib, right?"}}
{"actor":{"display_login":"fmaussion"}}