{"action":"created","issue":{"url":"https://api.github.com/repos/PCGen/pcgen/issues/1396","repository_url":"https://api.github.com/repos/PCGen/pcgen","labels_url":"https://api.github.com/repos/PCGen/pcgen/issues/1396/labels{/name}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/1396/comments","events_url":"https://api.github.com/repos/PCGen/pcgen/issues/1396/events","html_url":"https://github.com/PCGen/pcgen/pull/1396","id":168134475,"number":1396,"title":"Fix OS-292: Support UTF-8","user":{"login":"Zaister","id":4464545,"avatar_url":"https://avatars.githubusercontent.com/u/4464545?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaister","html_url":"https://github.com/Zaister","followers_url":"https://api.github.com/users/Zaister/followers","following_url":"https://api.github.com/users/Zaister/following{/other_user}","gists_url":"https://api.github.com/users/Zaister/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaister/subscriptions","organizations_url":"https://api.github.com/users/Zaister/orgs","repos_url":"https://api.github.com/users/Zaister/repos","events_url":"https://api.github.com/users/Zaister/events{/privacy}","received_events_url":"https://api.github.com/users/Zaister/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-28T16:07:23Z","updated_at":"2016-07-30T13:42:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/1396","html_url":"https://github.com/PCGen/pcgen/pull/1396","diff_url":"https://github.com/PCGen/pcgen/pull/1396.diff","patch_url":"https://github.com/PCGen/pcgen/pull/1396.patch"},"body":"This solves the UTF-8 problem by using features of the updated FOP library to imbed a custom font. I have chosen Noto Sans (https://fonts.google.com/specimen/Noto+Sans) which is free and available under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0). This font is designed to reduce the so-called \"tofu\" (i.e. the boxes produced by missing glyphs) and supports most international letters (but not Chinese or Japanese). @Nylanfs has commented that the license should be compatible with PCGen, so we should have no problems using and redistributing these fonts.\r\n\r\nI have added a new `fonts` directory under `outputsheets` where I have added the files for this font and  adapted the FOP configuration file to load them. Furthermore I have updated the fantasy output sheets (so far) to use these fonts.\r\n\r\nAdvanced users can even add their own fonts by copying them into the `fonts` directory and modifying the FOP configuration file and the output sheets accordingly.\r\n\r\nI have taken the opportunity to update the footer templates of the output sheets that contain the credits for the sheets to match the current state of the project.\r\n\r\nI'd like to have this change reviewed by @LegacyKing and @cpmeister as it touches various areas of PCGen and even includes a code modification and adds a new library to be able to read the font configuration from the FOP configuration file. Please comment."},"comment":{"url":"https://api.github.com/repos/PCGen/pcgen/issues/comments/236365907","html_url":"https://github.com/PCGen/pcgen/pull/1396#issuecomment-236365907","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/1396","id":236365907,"user":{"login":"Zaister","id":4464545,"avatar_url":"https://avatars.githubusercontent.com/u/4464545?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaister","html_url":"https://github.com/Zaister","followers_url":"https://api.github.com/users/Zaister/followers","following_url":"https://api.github.com/users/Zaister/following{/other_user}","gists_url":"https://api.github.com/users/Zaister/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaister/subscriptions","organizations_url":"https://api.github.com/users/Zaister/orgs","repos_url":"https://api.github.com/users/Zaister/repos","events_url":"https://api.github.com/users/Zaister/events{/privacy}","received_events_url":"https://api.github.com/users/Zaister/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T13:42:38Z","updated_at":"2016-07-30T13:42:38Z","body":"OK, here's the new status of this branch\r\n* The font alias in `fop.xconf` has been eliminated and replaced by an XSL variable defined in `outputsheets/d20/fantasy/pdf/fantasy_common`.\r\n* Hardcoded loading the Noto Sans fonts into the current GraphicsEnvironment in the `PrintPreviewDialog` class, so they can be used by the AWT renderer.\r\n* Updated fontbox library to most current version 2.0.2\r\n\r\nI think this is now ready to be merged. More character sheets (e.g. other game modes) can then be adapted gradually."}}
{"actor":{"display_login":"Zaister"}}