{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/7016","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7016/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7016/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7016/events","html_url":"https://github.com/mozilla/pdf.js/pull/7016","id":135577380,"number":7016,"title":"Show popups when a Popup entry is missing but title and/or contents are available","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-annotations","name":"4-annotations","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-02-22T23:25:10Z","updated_at":"2016-02-22T23:51:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7016","html_url":"https://github.com/mozilla/pdf.js/pull/7016","diff_url":"https://github.com/mozilla/pdf.js/pull/7016.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/7016.patch"},"body":"Fixes #7014.\r\n\r\nWe already did this for Text annotations, but it turns out that we need to do this for every annotation type that works with popups. Note that most PDF generators generate Popup annotations along with Highlight/Underline/Squiggly/StrikeOut annotations: it's relatively rare that PDF generators do not do this, but it does occur as this test case shows. With this patch, the file mentioned in the issue above (also attached to this PR as a test case) renders the same in PDF.js as it does in any other reader and we handle more of the available fields for those annotation types.\r\n\r\n@Snuffleupagus Do you have time to review this one? If not, feel free to unassign yourself. The logic is very similar to that of Text annotations (the only real difference is the trigger div instead of the image), so hopefully it should be relatively easy to review."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/187442279","html_url":"https://github.com/mozilla/pdf.js/pull/7016#issuecomment-187442279","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7016","id":187442279,"user":{"login":"pdfjsbot","id":1036361,"avatar_url":"https://avatars.githubusercontent.com/u/1036361?v=3","gravatar_id":"","url":"https://api.github.com/users/pdfjsbot","html_url":"https://github.com/pdfjsbot","followers_url":"https://api.github.com/users/pdfjsbot/followers","following_url":"https://api.github.com/users/pdfjsbot/following{/other_user}","gists_url":"https://api.github.com/users/pdfjsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pdfjsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdfjsbot/subscriptions","organizations_url":"https://api.github.com/users/pdfjsbot/orgs","repos_url":"https://api.github.com/users/pdfjsbot/repos","events_url":"https://api.github.com/users/pdfjsbot/events{/privacy}","received_events_url":"https://api.github.com/users/pdfjsbot/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T23:51:05Z","updated_at":"2016-02-22T23:51:05Z","body":"#### From: Bot.io (Linux)\n\n----\n\n# Success\n\nFull output at http://107.21.233.14:8877/4f82c4023f9e21b/output.txt\n\nTotal script time: 21.60 mins\n\n+ **Font tests:** Passed\n+ **Unit tests:** Passed\n+ **Regression tests:** Passed"}}