{"action":"created","comment":{"url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments/76265069","id":76265069,"diff_hunk":"@@ -151,11 +184,16 @@ extern NSString *const kSSKeychainWhereKey;\n  @param accessibilityType One of the \"Keychain Item Accessibility Constants\"\n  used for determining when a keychain item should be readable.\n \n- If the value is `NULL` (the default), the Keychain default will be used.\n+ If the value is `NULL` (the default), the Keychain default will be used which\n+ is highly insecure. You really should use at least `kSecAttrAccessibleAfterFirstUnlock`\n+ for background applications or `kSecAttrAccessibleWhenUnlocked` for all\n+ other applications.\n \n  @see accessibilityType\n  */\n + (void)setAccessibilityType:(CFTypeRef)accessibilityType;\n #endif\n \n @end\n+\n+#import \"SAMKeychainQuery.h\"","path":"src/ios/SAMKeychain/SAMKeychain.h","position":188,"original_position":188,"commit_id":"7d19f40c0de1a8315c25ae4554847a123c331808","original_commit_id":"7d19f40c0de1a8315c25ae4554847a123c331808","user":{"login":"briananderson1222","id":4603907,"avatar_url":"https://avatars.githubusercontent.com/u/4603907?v=3","gravatar_id":"","url":"https://api.github.com/users/briananderson1222","html_url":"https://github.com/briananderson1222","followers_url":"https://api.github.com/users/briananderson1222/followers","following_url":"https://api.github.com/users/briananderson1222/following{/other_user}","gists_url":"https://api.github.com/users/briananderson1222/gists{/gist_id}","starred_url":"https://api.github.com/users/briananderson1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briananderson1222/subscriptions","organizations_url":"https://api.github.com/users/briananderson1222/orgs","repos_url":"https://api.github.com/users/briananderson1222/repos","events_url":"https://api.github.com/users/briananderson1222/events{/privacy}","received_events_url":"https://api.github.com/users/briananderson1222/received_events","type":"User","site_admin":false},"body":"Unfortunately this is the only manual change required in the library. It previously read `#import <SAMKeychain/SAMKeychainQuery.h>` but I didn't know of a way to import these files as part of this framework.. Without having worked in iOS code for a few years now I would think this change could almost be submitted to SAMKeychain so that the reference is relative.. or we could figure out a way of making the cordova plugin recognize this framework","created_at":"2016-08-25T15:23:52Z","updated_at":"2016-08-25T15:23:52Z","html_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49#discussion_r76265069","pull_request_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments/76265069"},"html":{"href":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49#discussion_r76265069"},"pull_request":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49","id":82740170,"html_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49","diff_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49.diff","patch_url":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49.patch","issue_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/49","number":49,"state":"open","locked":false,"title":"Updates to SAMKeychain","user":{"login":"briananderson1222","id":4603907,"avatar_url":"https://avatars.githubusercontent.com/u/4603907?v=3","gravatar_id":"","url":"https://api.github.com/users/briananderson1222","html_url":"https://github.com/briananderson1222","followers_url":"https://api.github.com/users/briananderson1222/followers","following_url":"https://api.github.com/users/briananderson1222/following{/other_user}","gists_url":"https://api.github.com/users/briananderson1222/gists{/gist_id}","starred_url":"https://api.github.com/users/briananderson1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briananderson1222/subscriptions","organizations_url":"https://api.github.com/users/briananderson1222/orgs","repos_url":"https://api.github.com/users/briananderson1222/repos","events_url":"https://api.github.com/users/briananderson1222/events{/privacy}","received_events_url":"https://api.github.com/users/briananderson1222/received_events","type":"User","site_admin":false},"body":"@ggozad Updated to the latest version of SAMKeychain in their master branch.","created_at":"2016-08-25T15:21:41Z","updated_at":"2016-08-25T15:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4439997d22ba38e14430802310143fa8f196f29d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49/commits","review_comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49/comments","review_comment_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/49/comments","statuses_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/7d19f40c0de1a8315c25ae4554847a123c331808","head":{"label":"briananderson1222:master","ref":"master","sha":"7d19f40c0de1a8315c25ae4554847a123c331808","user":{"login":"briananderson1222","id":4603907,"avatar_url":"https://avatars.githubusercontent.com/u/4603907?v=3","gravatar_id":"","url":"https://api.github.com/users/briananderson1222","html_url":"https://github.com/briananderson1222","followers_url":"https://api.github.com/users/briananderson1222/followers","following_url":"https://api.github.com/users/briananderson1222/following{/other_user}","gists_url":"https://api.github.com/users/briananderson1222/gists{/gist_id}","starred_url":"https://api.github.com/users/briananderson1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briananderson1222/subscriptions","organizations_url":"https://api.github.com/users/briananderson1222/orgs","repos_url":"https://api.github.com/users/briananderson1222/repos","events_url":"https://api.github.com/users/briananderson1222/events{/privacy}","received_events_url":"https://api.github.com/users/briananderson1222/received_events","type":"User","site_admin":false},"repo":{"id":66560370,"name":"cordova-plugin-secure-storage","full_name":"briananderson1222/cordova-plugin-secure-storage","owner":{"login":"briananderson1222","id":4603907,"avatar_url":"https://avatars.githubusercontent.com/u/4603907?v=3","gravatar_id":"","url":"https://api.github.com/users/briananderson1222","html_url":"https://github.com/briananderson1222","followers_url":"https://api.github.com/users/briananderson1222/followers","following_url":"https://api.github.com/users/briananderson1222/following{/other_user}","gists_url":"https://api.github.com/users/briananderson1222/gists{/gist_id}","starred_url":"https://api.github.com/users/briananderson1222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briananderson1222/subscriptions","organizations_url":"https://api.github.com/users/briananderson1222/orgs","repos_url":"https://api.github.com/users/briananderson1222/repos","events_url":"https://api.github.com/users/briananderson1222/events{/privacy}","received_events_url":"https://api.github.com/users/briananderson1222/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briananderson1222/cordova-plugin-secure-storage","description":"Secure storage plugin for Apache Cordova","fork":true,"url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage","forks_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/forks","keys_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/teams","hooks_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/hooks","issue_events_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/issues/events{/number}","events_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/events","assignees_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/assignees{/user}","branches_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/branches{/branch}","tags_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/tags","blobs_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/languages","stargazers_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/stargazers","contributors_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/contributors","subscribers_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/subscribers","subscription_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/subscription","commits_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/contents/{+path}","compare_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/merges","archive_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/downloads","issues_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/issues{/number}","pulls_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/labels{/name}","releases_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/releases{/id}","deployments_url":"https://api.github.com/repos/briananderson1222/cordova-plugin-secure-storage/deployments","created_at":"2016-08-25T13:30:53Z","updated_at":"2016-08-25T13:30:54Z","pushed_at":"2016-08-25T15:20:22Z","git_url":"git://github.com/briananderson1222/cordova-plugin-secure-storage.git","ssh_url":"git@github.com:briananderson1222/cordova-plugin-secure-storage.git","clone_url":"https://github.com/briananderson1222/cordova-plugin-secure-storage.git","svn_url":"https://github.com/briananderson1222/cordova-plugin-secure-storage","homepage":"","size":123,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Crypho:master","ref":"master","sha":"602b5891ee8dd67bffa6104dd366b046879466b9","user":{"login":"Crypho","id":2860957,"avatar_url":"https://avatars.githubusercontent.com/u/2860957?v=3","gravatar_id":"","url":"https://api.github.com/users/Crypho","html_url":"https://github.com/Crypho","followers_url":"https://api.github.com/users/Crypho/followers","following_url":"https://api.github.com/users/Crypho/following{/other_user}","gists_url":"https://api.github.com/users/Crypho/gists{/gist_id}","starred_url":"https://api.github.com/users/Crypho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crypho/subscriptions","organizations_url":"https://api.github.com/users/Crypho/orgs","repos_url":"https://api.github.com/users/Crypho/repos","events_url":"https://api.github.com/users/Crypho/events{/privacy}","received_events_url":"https://api.github.com/users/Crypho/received_events","type":"Organization","site_admin":false},"repo":{"id":32869407,"name":"cordova-plugin-secure-storage","full_name":"Crypho/cordova-plugin-secure-storage","owner":{"login":"Crypho","id":2860957,"avatar_url":"https://avatars.githubusercontent.com/u/2860957?v=3","gravatar_id":"","url":"https://api.github.com/users/Crypho","html_url":"https://github.com/Crypho","followers_url":"https://api.github.com/users/Crypho/followers","following_url":"https://api.github.com/users/Crypho/following{/other_user}","gists_url":"https://api.github.com/users/Crypho/gists{/gist_id}","starred_url":"https://api.github.com/users/Crypho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crypho/subscriptions","organizations_url":"https://api.github.com/users/Crypho/orgs","repos_url":"https://api.github.com/users/Crypho/repos","events_url":"https://api.github.com/users/Crypho/events{/privacy}","received_events_url":"https://api.github.com/users/Crypho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Crypho/cordova-plugin-secure-storage","description":"Secure storage plugin for Apache Cordova","fork":false,"url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage","forks_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/forks","keys_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/teams","hooks_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/hooks","issue_events_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/events{/number}","events_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/events","assignees_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/assignees{/user}","branches_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/branches{/branch}","tags_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/tags","blobs_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/languages","stargazers_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/stargazers","contributors_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/contributors","subscribers_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/subscribers","subscription_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/subscription","commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/contents/{+path}","compare_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/merges","archive_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/downloads","issues_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues{/number}","pulls_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/labels{/name}","releases_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/releases{/id}","deployments_url":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/deployments","created_at":"2015-03-25T14:24:08Z","updated_at":"2016-08-24T01:26:16Z","pushed_at":"2016-08-25T15:21:42Z","git_url":"git://github.com/Crypho/cordova-plugin-secure-storage.git","ssh_url":"git@github.com:Crypho/cordova-plugin-secure-storage.git","clone_url":"https://github.com/Crypho/cordova-plugin-secure-storage.git","svn_url":"https://github.com/Crypho/cordova-plugin-secure-storage","homepage":"","size":148,"stargazers_count":93,"watchers_count":93,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":4,"forks":36,"open_issues":4,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49"},"html":{"href":"https://github.com/Crypho/cordova-plugin-secure-storage/pull/49"},"issue":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/49"},"comments":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/Crypho/cordova-plugin-secure-storage/statuses/7d19f40c0de1a8315c25ae4554847a123c331808"}}}}
{"actor":{"display_login":"briananderson1222"}}