{"action":"created","comment":{"url":"https://api.github.com/repos/mathiasverraes/money/pulls/comments/48712823","id":48712823,"diff_hunk":"@@ -0,0 +1,95 @@\n+<?php\n+namespace Money;","path":"src/Calculator.php","position":2,"original_position":2,"commit_id":"be83d17725a33197367b048c62c933b17c4a46e6","original_commit_id":"cc8d9fa51f7a698fa5a4eddbf800dee9873ac8d5","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"body":"Consistency.","created_at":"2016-01-04T09:01:00Z","updated_at":"2016-01-04T09:01:00Z","html_url":"https://github.com/mathiasverraes/money/pull/115#discussion_r48712823","pull_request_url":"https://api.github.com/repos/mathiasverraes/money/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/comments/48712823"},"html":{"href":"https://github.com/mathiasverraes/money/pull/115#discussion_r48712823"},"pull_request":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/mathiasverraes/money/pulls/115","id":54472142,"html_url":"https://github.com/mathiasverraes/money/pull/115","diff_url":"https://github.com/mathiasverraes/money/pull/115.diff","patch_url":"https://github.com/mathiasverraes/money/pull/115.patch","issue_url":"https://api.github.com/repos/mathiasverraes/money/issues/115","number":115,"state":"open","locked":false,"title":"deal with integer limits","user":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"body":"Solves #111.\r\n\r\nProbably has quite some impact on the library. Review carefully. Rather see some more comments on the design decisions than on some PSR-2 compliance. The latter will be solved - if there is any compliance oversights - when there is agreement on the design.\r\n\r\nHard aspect of this PR was rounding in GMP and BC Math libraries. Had a look at some other libraries for this to implement.","created_at":"2015-12-23T14:05:42Z","updated_at":"2016-01-04T09:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7fd35c666f720dba6bb9fa5422716bf8b81a1e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mathiasverraes/money/pulls/115/commits","review_comments_url":"https://api.github.com/repos/mathiasverraes/money/pulls/115/comments","review_comment_url":"https://api.github.com/repos/mathiasverraes/money/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mathiasverraes/money/issues/115/comments","statuses_url":"https://api.github.com/repos/mathiasverraes/money/statuses/be83d17725a33197367b048c62c933b17c4a46e6","head":{"label":"frederikbosch:nextrelease","ref":"nextrelease","sha":"be83d17725a33197367b048c62c933b17c4a46e6","user":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"repo":{"id":37968848,"name":"money","full_name":"frederikbosch/money","owner":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frederikbosch/money","description":"PHP implementation of Fowler's Money pattern. NOTE: all work is happening in the \"nextrelease\" branch, which will break BC.","fork":true,"url":"https://api.github.com/repos/frederikbosch/money","forks_url":"https://api.github.com/repos/frederikbosch/money/forks","keys_url":"https://api.github.com/repos/frederikbosch/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frederikbosch/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frederikbosch/money/teams","hooks_url":"https://api.github.com/repos/frederikbosch/money/hooks","issue_events_url":"https://api.github.com/repos/frederikbosch/money/issues/events{/number}","events_url":"https://api.github.com/repos/frederikbosch/money/events","assignees_url":"https://api.github.com/repos/frederikbosch/money/assignees{/user}","branches_url":"https://api.github.com/repos/frederikbosch/money/branches{/branch}","tags_url":"https://api.github.com/repos/frederikbosch/money/tags","blobs_url":"https://api.github.com/repos/frederikbosch/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frederikbosch/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frederikbosch/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/frederikbosch/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frederikbosch/money/statuses/{sha}","languages_url":"https://api.github.com/repos/frederikbosch/money/languages","stargazers_url":"https://api.github.com/repos/frederikbosch/money/stargazers","contributors_url":"https://api.github.com/repos/frederikbosch/money/contributors","subscribers_url":"https://api.github.com/repos/frederikbosch/money/subscribers","subscription_url":"https://api.github.com/repos/frederikbosch/money/subscription","commits_url":"https://api.github.com/repos/frederikbosch/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/frederikbosch/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/frederikbosch/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/frederikbosch/money/issues/comments{/number}","contents_url":"https://api.github.com/repos/frederikbosch/money/contents/{+path}","compare_url":"https://api.github.com/repos/frederikbosch/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frederikbosch/money/merges","archive_url":"https://api.github.com/repos/frederikbosch/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frederikbosch/money/downloads","issues_url":"https://api.github.com/repos/frederikbosch/money/issues{/number}","pulls_url":"https://api.github.com/repos/frederikbosch/money/pulls{/number}","milestones_url":"https://api.github.com/repos/frederikbosch/money/milestones{/number}","notifications_url":"https://api.github.com/repos/frederikbosch/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frederikbosch/money/labels{/name}","releases_url":"https://api.github.com/repos/frederikbosch/money/releases{/id}","created_at":"2015-06-24T07:18:20Z","updated_at":"2015-06-24T07:18:20Z","pushed_at":"2016-01-04T09:00:31Z","git_url":"git://github.com/frederikbosch/money.git","ssh_url":"git@github.com:frederikbosch/money.git","clone_url":"https://github.com/frederikbosch/money.git","svn_url":"https://github.com/frederikbosch/money","homepage":"http://blog.verraes.net/2011/04/fowler-money-pattern-in-php/","size":218,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mathiasverraes:nextrelease","ref":"nextrelease","sha":"e64ced28a62a430478df3c35639a5d1da50b9d7f","user":{"login":"mathiasverraes","id":489516,"avatar_url":"https://avatars.githubusercontent.com/u/489516?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasverraes","html_url":"https://github.com/mathiasverraes","followers_url":"https://api.github.com/users/mathiasverraes/followers","following_url":"https://api.github.com/users/mathiasverraes/following{/other_user}","gists_url":"https://api.github.com/users/mathiasverraes/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasverraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasverraes/subscriptions","organizations_url":"https://api.github.com/users/mathiasverraes/orgs","repos_url":"https://api.github.com/users/mathiasverraes/repos","events_url":"https://api.github.com/users/mathiasverraes/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasverraes/received_events","type":"User","site_admin":false},"repo":{"id":1543827,"name":"money","full_name":"mathiasverraes/money","owner":{"login":"mathiasverraes","id":489516,"avatar_url":"https://avatars.githubusercontent.com/u/489516?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasverraes","html_url":"https://github.com/mathiasverraes","followers_url":"https://api.github.com/users/mathiasverraes/followers","following_url":"https://api.github.com/users/mathiasverraes/following{/other_user}","gists_url":"https://api.github.com/users/mathiasverraes/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasverraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasverraes/subscriptions","organizations_url":"https://api.github.com/users/mathiasverraes/orgs","repos_url":"https://api.github.com/users/mathiasverraes/repos","events_url":"https://api.github.com/users/mathiasverraes/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasverraes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathiasverraes/money","description":"PHP implementation of Fowler's Money pattern. NOTE: all work is happening in the \"nextrelease\" branch, which will break BC.","fork":false,"url":"https://api.github.com/repos/mathiasverraes/money","forks_url":"https://api.github.com/repos/mathiasverraes/money/forks","keys_url":"https://api.github.com/repos/mathiasverraes/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathiasverraes/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathiasverraes/money/teams","hooks_url":"https://api.github.com/repos/mathiasverraes/money/hooks","issue_events_url":"https://api.github.com/repos/mathiasverraes/money/issues/events{/number}","events_url":"https://api.github.com/repos/mathiasverraes/money/events","assignees_url":"https://api.github.com/repos/mathiasverraes/money/assignees{/user}","branches_url":"https://api.github.com/repos/mathiasverraes/money/branches{/branch}","tags_url":"https://api.github.com/repos/mathiasverraes/money/tags","blobs_url":"https://api.github.com/repos/mathiasverraes/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathiasverraes/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathiasverraes/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathiasverraes/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathiasverraes/money/statuses/{sha}","languages_url":"https://api.github.com/repos/mathiasverraes/money/languages","stargazers_url":"https://api.github.com/repos/mathiasverraes/money/stargazers","contributors_url":"https://api.github.com/repos/mathiasverraes/money/contributors","subscribers_url":"https://api.github.com/repos/mathiasverraes/money/subscribers","subscription_url":"https://api.github.com/repos/mathiasverraes/money/subscription","commits_url":"https://api.github.com/repos/mathiasverraes/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathiasverraes/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathiasverraes/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathiasverraes/money/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathiasverraes/money/contents/{+path}","compare_url":"https://api.github.com/repos/mathiasverraes/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathiasverraes/money/merges","archive_url":"https://api.github.com/repos/mathiasverraes/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathiasverraes/money/downloads","issues_url":"https://api.github.com/repos/mathiasverraes/money/issues{/number}","pulls_url":"https://api.github.com/repos/mathiasverraes/money/pulls{/number}","milestones_url":"https://api.github.com/repos/mathiasverraes/money/milestones{/number}","notifications_url":"https://api.github.com/repos/mathiasverraes/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathiasverraes/money/labels{/name}","releases_url":"https://api.github.com/repos/mathiasverraes/money/releases{/id}","created_at":"2011-03-29T22:58:09Z","updated_at":"2015-12-30T10:15:04Z","pushed_at":"2016-01-04T09:00:31Z","git_url":"git://github.com/mathiasverraes/money.git","ssh_url":"git@github.com:mathiasverraes/money.git","clone_url":"https://github.com/mathiasverraes/money.git","svn_url":"https://github.com/mathiasverraes/money","homepage":"http://blog.verraes.net/2011/04/fowler-money-pattern-in-php/","size":294,"stargazers_count":628,"watchers_count":628,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":19,"forks":95,"open_issues":19,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/115"},"html":{"href":"https://github.com/mathiasverraes/money/pull/115"},"issue":{"href":"https://api.github.com/repos/mathiasverraes/money/issues/115"},"comments":{"href":"https://api.github.com/repos/mathiasverraes/money/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mathiasverraes/money/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/mathiasverraes/money/statuses/be83d17725a33197367b048c62c933b17c4a46e6"}}}}