{"action":"created","comment":{"url":"https://api.github.com/repos/ros-controls/ros_control/pulls/comments/85663160","pull_request_review_id":6366529,"id":85663160,"diff_hunk":"@@ -6,7 +6,6 @@ find_package(catkin REQUIRED COMPONENTS roscpp hardware_interface pluginlib)\n \n # Declare catkin package\n catkin_package(\n-  DEPENDS boost","path":"controller_interface/CMakeLists.txt","position":4,"original_position":4,"commit_id":"a62f17e353c1bb2d01376d450c8045d15884ecbd","original_commit_id":"a62f17e353c1bb2d01376d450c8045d15884ecbd","user":{"login":"efernandez","id":382167,"avatar_url":"https://avatars.githubusercontent.com/u/382167?v=3","gravatar_id":"","url":"https://api.github.com/users/efernandez","html_url":"https://github.com/efernandez","followers_url":"https://api.github.com/users/efernandez/followers","following_url":"https://api.github.com/users/efernandez/following{/other_user}","gists_url":"https://api.github.com/users/efernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/efernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efernandez/subscriptions","organizations_url":"https://api.github.com/users/efernandez/orgs","repos_url":"https://api.github.com/users/efernandez/repos","events_url":"https://api.github.com/users/efernandez/events{/privacy}","received_events_url":"https://api.github.com/users/efernandez/received_events","type":"User","site_admin":false},"body":"However, if `Boost_INCLUDE_DIRS` and `Boost_LIBRARIES` aren't used in the `CMakeLists.txt`, I guess it's because nothing really depends on `Boost` here, right? Indeed, `find_package(Boost REQUIRED)` is needed as well, if `Boost` is actually used.","created_at":"2016-10-30T16:21:10Z","updated_at":"2016-10-30T16:36:23Z","html_url":"https://github.com/ros-controls/ros_control/pull/253#discussion_r85663160","pull_request_url":"https://api.github.com/repos/ros-controls/ros_control/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/comments/85663160"},"html":{"href":"https://github.com/ros-controls/ros_control/pull/253#discussion_r85663160"},"pull_request":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/ros-controls/ros_control/pulls/253","id":91223684,"html_url":"https://github.com/ros-controls/ros_control/pull/253","diff_url":"https://github.com/ros-controls/ros_control/pull/253.diff","patch_url":"https://github.com/ros-controls/ros_control/pull/253.patch","issue_url":"https://api.github.com/repos/ros-controls/ros_control/issues/253","number":253,"state":"open","locked":false,"title":"Remove boost from depends declaration to fix cmake warning","user":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?v=3","gravatar_id":"","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"body":"This is to remove 2 cmake warnings for said packages.\r\n\r\n`catkin_package() DEPENDS on 'boost' but neither 'boost_INCLUDE_DIRS' nor 'boost_LIBRARIES' is defined.`","created_at":"2016-10-27T15:24:44Z","updated_at":"2016-10-30T16:36:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e247eaf6a89ef46fe38b372f20419d2941296d10","assignee":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?v=3","gravatar_id":"","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?v=3","gravatar_id":"","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros-controls/ros_control/pulls/253/commits","review_comments_url":"https://api.github.com/repos/ros-controls/ros_control/pulls/253/comments","review_comment_url":"https://api.github.com/repos/ros-controls/ros_control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-controls/ros_control/issues/253/comments","statuses_url":"https://api.github.com/repos/ros-controls/ros_control/statuses/a62f17e353c1bb2d01376d450c8045d15884ecbd","head":{"label":"bmagyar:cmake_warnings_boost","ref":"cmake_warnings_boost","sha":"a62f17e353c1bb2d01376d450c8045d15884ecbd","user":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?v=3","gravatar_id":"","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"repo":{"id":65998788,"name":"ros_control","full_name":"bmagyar/ros_control","owner":{"login":"bmagyar","id":3524577,"avatar_url":"https://avatars.githubusercontent.com/u/3524577?v=3","gravatar_id":"","url":"https://api.github.com/users/bmagyar","html_url":"https://github.com/bmagyar","followers_url":"https://api.github.com/users/bmagyar/followers","following_url":"https://api.github.com/users/bmagyar/following{/other_user}","gists_url":"https://api.github.com/users/bmagyar/gists{/gist_id}","starred_url":"https://api.github.com/users/bmagyar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmagyar/subscriptions","organizations_url":"https://api.github.com/users/bmagyar/orgs","repos_url":"https://api.github.com/users/bmagyar/repos","events_url":"https://api.github.com/users/bmagyar/events{/privacy}","received_events_url":"https://api.github.com/users/bmagyar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmagyar/ros_control","description":"Generic and simple controls framework for ROS","fork":true,"url":"https://api.github.com/repos/bmagyar/ros_control","forks_url":"https://api.github.com/repos/bmagyar/ros_control/forks","keys_url":"https://api.github.com/repos/bmagyar/ros_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmagyar/ros_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmagyar/ros_control/teams","hooks_url":"https://api.github.com/repos/bmagyar/ros_control/hooks","issue_events_url":"https://api.github.com/repos/bmagyar/ros_control/issues/events{/number}","events_url":"https://api.github.com/repos/bmagyar/ros_control/events","assignees_url":"https://api.github.com/repos/bmagyar/ros_control/assignees{/user}","branches_url":"https://api.github.com/repos/bmagyar/ros_control/branches{/branch}","tags_url":"https://api.github.com/repos/bmagyar/ros_control/tags","blobs_url":"https://api.github.com/repos/bmagyar/ros_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmagyar/ros_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmagyar/ros_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmagyar/ros_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmagyar/ros_control/statuses/{sha}","languages_url":"https://api.github.com/repos/bmagyar/ros_control/languages","stargazers_url":"https://api.github.com/repos/bmagyar/ros_control/stargazers","contributors_url":"https://api.github.com/repos/bmagyar/ros_control/contributors","subscribers_url":"https://api.github.com/repos/bmagyar/ros_control/subscribers","subscription_url":"https://api.github.com/repos/bmagyar/ros_control/subscription","commits_url":"https://api.github.com/repos/bmagyar/ros_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmagyar/ros_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmagyar/ros_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmagyar/ros_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmagyar/ros_control/contents/{+path}","compare_url":"https://api.github.com/repos/bmagyar/ros_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmagyar/ros_control/merges","archive_url":"https://api.github.com/repos/bmagyar/ros_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmagyar/ros_control/downloads","issues_url":"https://api.github.com/repos/bmagyar/ros_control/issues{/number}","pulls_url":"https://api.github.com/repos/bmagyar/ros_control/pulls{/number}","milestones_url":"https://api.github.com/repos/bmagyar/ros_control/milestones{/number}","notifications_url":"https://api.github.com/repos/bmagyar/ros_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmagyar/ros_control/labels{/name}","releases_url":"https://api.github.com/repos/bmagyar/ros_control/releases{/id}","deployments_url":"https://api.github.com/repos/bmagyar/ros_control/deployments","created_at":"2016-08-18T13:19:38Z","updated_at":"2016-08-18T13:19:39Z","pushed_at":"2016-10-28T13:32:08Z","git_url":"git://github.com/bmagyar/ros_control.git","ssh_url":"git@github.com:bmagyar/ros_control.git","clone_url":"https://github.com/bmagyar/ros_control.git","svn_url":"https://github.com/bmagyar/ros_control","homepage":"http://wiki.ros.org/ros_control","size":1907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-controls:kinetic-devel","ref":"kinetic-devel","sha":"999f53a494d00639cc7668921cdd59ca31bb0cf1","user":{"login":"ros-controls","id":4827547,"avatar_url":"https://avatars.githubusercontent.com/u/4827547?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-controls","html_url":"https://github.com/ros-controls","followers_url":"https://api.github.com/users/ros-controls/followers","following_url":"https://api.github.com/users/ros-controls/following{/other_user}","gists_url":"https://api.github.com/users/ros-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-controls/subscriptions","organizations_url":"https://api.github.com/users/ros-controls/orgs","repos_url":"https://api.github.com/users/ros-controls/repos","events_url":"https://api.github.com/users/ros-controls/events{/privacy}","received_events_url":"https://api.github.com/users/ros-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":6607925,"name":"ros_control","full_name":"ros-controls/ros_control","owner":{"login":"ros-controls","id":4827547,"avatar_url":"https://avatars.githubusercontent.com/u/4827547?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-controls","html_url":"https://github.com/ros-controls","followers_url":"https://api.github.com/users/ros-controls/followers","following_url":"https://api.github.com/users/ros-controls/following{/other_user}","gists_url":"https://api.github.com/users/ros-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-controls/subscriptions","organizations_url":"https://api.github.com/users/ros-controls/orgs","repos_url":"https://api.github.com/users/ros-controls/repos","events_url":"https://api.github.com/users/ros-controls/events{/privacy}","received_events_url":"https://api.github.com/users/ros-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-controls/ros_control","description":"Generic and simple controls framework for ROS","fork":false,"url":"https://api.github.com/repos/ros-controls/ros_control","forks_url":"https://api.github.com/repos/ros-controls/ros_control/forks","keys_url":"https://api.github.com/repos/ros-controls/ros_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-controls/ros_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-controls/ros_control/teams","hooks_url":"https://api.github.com/repos/ros-controls/ros_control/hooks","issue_events_url":"https://api.github.com/repos/ros-controls/ros_control/issues/events{/number}","events_url":"https://api.github.com/repos/ros-controls/ros_control/events","assignees_url":"https://api.github.com/repos/ros-controls/ros_control/assignees{/user}","branches_url":"https://api.github.com/repos/ros-controls/ros_control/branches{/branch}","tags_url":"https://api.github.com/repos/ros-controls/ros_control/tags","blobs_url":"https://api.github.com/repos/ros-controls/ros_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-controls/ros_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-controls/ros_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-controls/ros_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-controls/ros_control/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-controls/ros_control/languages","stargazers_url":"https://api.github.com/repos/ros-controls/ros_control/stargazers","contributors_url":"https://api.github.com/repos/ros-controls/ros_control/contributors","subscribers_url":"https://api.github.com/repos/ros-controls/ros_control/subscribers","subscription_url":"https://api.github.com/repos/ros-controls/ros_control/subscription","commits_url":"https://api.github.com/repos/ros-controls/ros_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-controls/ros_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-controls/ros_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-controls/ros_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-controls/ros_control/contents/{+path}","compare_url":"https://api.github.com/repos/ros-controls/ros_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-controls/ros_control/merges","archive_url":"https://api.github.com/repos/ros-controls/ros_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-controls/ros_control/downloads","issues_url":"https://api.github.com/repos/ros-controls/ros_control/issues{/number}","pulls_url":"https://api.github.com/repos/ros-controls/ros_control/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-controls/ros_control/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-controls/ros_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-controls/ros_control/labels{/name}","releases_url":"https://api.github.com/repos/ros-controls/ros_control/releases{/id}","deployments_url":"https://api.github.com/repos/ros-controls/ros_control/deployments","created_at":"2012-11-09T03:09:38Z","updated_at":"2016-10-29T14:10:22Z","pushed_at":"2016-10-28T13:32:08Z","git_url":"git://github.com/ros-controls/ros_control.git","ssh_url":"git@github.com:ros-controls/ros_control.git","clone_url":"https://github.com/ros-controls/ros_control.git","svn_url":"https://github.com/ros-controls/ros_control","homepage":"http://wiki.ros.org/ros_control","size":2629,"stargazers_count":66,"watchers_count":66,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":36,"forks":79,"open_issues":36,"watchers":66,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/253"},"html":{"href":"https://github.com/ros-controls/ros_control/pull/253"},"issue":{"href":"https://api.github.com/repos/ros-controls/ros_control/issues/253"},"comments":{"href":"https://api.github.com/repos/ros-controls/ros_control/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-controls/ros_control/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/ros-controls/ros_control/statuses/a62f17e353c1bb2d01376d450c8045d15884ecbd"}}}}
{"actor":{"display_login":"efernandez"}}