{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/72850455","id":72850455,"diff_hunk":"@@ -607,6 +607,10 @@ type SecretVolumeSource struct {\n \t// the volume setup will error. Paths must be relative and may not contain\n \t// the '..' path or start with '..'.\n \tItems []KeyToPath `json:\"items,omitempty\"`\n+\t// Mode bits to use on created files by default. The used mode bits will","path":"pkg/api/types.go","position":4,"original_position":4,"commit_id":"24f078df6cf894a84328872b4fdcad736ab97938","original_commit_id":"24f078df6cf894a84328872b4fdcad736ab97938","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"s/used/final (same in all cases)","created_at":"2016-07-29T19:48:55Z","updated_at":"2016-07-29T19:48:55Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28936#discussion_r72850455","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/72850455"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28936#discussion_r72850455"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936","id":77396152,"html_url":"https://github.com/kubernetes/kubernetes/pull/28936","diff_url":"https://github.com/kubernetes/kubernetes/pull/28936.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28936.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936","number":28936,"state":"open","locked":false,"title":"WIP: Allow to set permission mode bits on secrets, configmaps and downwardAPI files","user":{"login":"rata","id":70861,"avatar_url":"https://avatars.githubusercontent.com/u/70861?v=3","gravatar_id":"","url":"https://api.github.com/users/rata","html_url":"https://github.com/rata","followers_url":"https://api.github.com/users/rata/followers","following_url":"https://api.github.com/users/rata/following{/other_user}","gists_url":"https://api.github.com/users/rata/gists{/gist_id}","starred_url":"https://api.github.com/users/rata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rata/subscriptions","organizations_url":"https://api.github.com/users/rata/orgs","repos_url":"https://api.github.com/users/rata/repos","events_url":"https://api.github.com/users/rata/events{/privacy}","received_events_url":"https://api.github.com/users/rata/received_events","type":"User","site_admin":false},"body":"cc @thockin @pmorie \r\n\r\nHere is the first round to implement: https://github.com/kubernetes/kubernetes/pull/28733.\r\n\r\nI made two commits: one with the actual change and the other with the auto-generated code. I think it's easier to review this way, but let me know if you prefer in some other way.\r\n\r\nI haven't written any tests yet, I wanted to have a first glance and not write them till this (and the API) are more close to the \"LGTM\" :)\r\n\r\nThere are some things:\r\n * I'm not sure where to do the \"AND 0777\". I'll try to look better in the code base, but suggestions are always welcome :)\r\n * The write permission on group and others is not set when you do an `ls -l` on the running container. It does work with write permissions to the owner. Debugging seems to show that is something happening after this is correctly set on creation. Will look closer.\r\n * The default permission (when the new fields are not specified) are the same that on kubernetes v1.3\r\n * I do realize there are conflicts with master, but I think this is good enough to have a look. The conflicts is with the autog-enerated code, so the actual code is actually the same (and it takes like ~30 minutes to generate it here)\r\n * I didn't generate the docs (`generated-docs` and `generated-swagger-docs` from `hack/update-all.sh`) because my machine runs out of mem. So that's why it isn't in this first PR, will try to investigate and see why it happens.\r\n\r\nOther than that, this works fine here with some silly scripts I did to create a secret&configmap&downwardAPI, a pod and check the file permissions. Tested the \"defaultMode\" and \"mode\" for all. But of course, will write tests once this is looking fine :)\r\n\r\n\r\nThanks a lot again!\r\nRodrigo","created_at":"2016-07-14T03:49:52Z","updated_at":"2016-07-29T19:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/24f078df6cf894a84328872b4fdcad736ab97938","head":{"label":"rata:secret-configmap-file-mode","ref":"secret-configmap-file-mode","sha":"24f078df6cf894a84328872b4fdcad736ab97938","user":{"login":"rata","id":70861,"avatar_url":"https://avatars.githubusercontent.com/u/70861?v=3","gravatar_id":"","url":"https://api.github.com/users/rata","html_url":"https://github.com/rata","followers_url":"https://api.github.com/users/rata/followers","following_url":"https://api.github.com/users/rata/following{/other_user}","gists_url":"https://api.github.com/users/rata/gists{/gist_id}","starred_url":"https://api.github.com/users/rata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rata/subscriptions","organizations_url":"https://api.github.com/users/rata/orgs","repos_url":"https://api.github.com/users/rata/repos","events_url":"https://api.github.com/users/rata/events{/privacy}","received_events_url":"https://api.github.com/users/rata/received_events","type":"User","site_admin":false},"repo":{"id":54125593,"name":"kubernetes","full_name":"rata/kubernetes","owner":{"login":"rata","id":70861,"avatar_url":"https://avatars.githubusercontent.com/u/70861?v=3","gravatar_id":"","url":"https://api.github.com/users/rata","html_url":"https://github.com/rata","followers_url":"https://api.github.com/users/rata/followers","following_url":"https://api.github.com/users/rata/following{/other_user}","gists_url":"https://api.github.com/users/rata/gists{/gist_id}","starred_url":"https://api.github.com/users/rata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rata/subscriptions","organizations_url":"https://api.github.com/users/rata/orgs","repos_url":"https://api.github.com/users/rata/repos","events_url":"https://api.github.com/users/rata/events{/privacy}","received_events_url":"https://api.github.com/users/rata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rata/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/rata/kubernetes","forks_url":"https://api.github.com/repos/rata/kubernetes/forks","keys_url":"https://api.github.com/repos/rata/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rata/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rata/kubernetes/teams","hooks_url":"https://api.github.com/repos/rata/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rata/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rata/kubernetes/events","assignees_url":"https://api.github.com/repos/rata/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rata/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rata/kubernetes/tags","blobs_url":"https://api.github.com/repos/rata/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rata/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rata/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rata/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rata/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rata/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rata/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rata/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rata/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rata/kubernetes/subscription","commits_url":"https://api.github.com/repos/rata/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rata/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rata/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rata/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rata/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rata/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rata/kubernetes/merges","archive_url":"https://api.github.com/repos/rata/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rata/kubernetes/downloads","issues_url":"https://api.github.com/repos/rata/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rata/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rata/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rata/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rata/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rata/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rata/kubernetes/deployments","created_at":"2016-03-17T14:43:18Z","updated_at":"2016-03-17T14:43:30Z","pushed_at":"2016-07-23T18:19:21Z","git_url":"git://github.com/rata/kubernetes.git","ssh_url":"git@github.com:rata/kubernetes.git","clone_url":"https://github.com/rata/kubernetes.git","svn_url":"https://github.com/rata/kubernetes","homepage":"http://kubernetes.io","size":279520,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"64d185f5340542705162841fe0d6509c0086ee27","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-29T15:58:45Z","pushed_at":"2016-07-29T19:44:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":514364,"stargazers_count":15846,"watchers_count":15846,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5019,"mirror_url":null,"open_issues_count":4060,"forks":5019,"open_issues":4060,"watchers":15846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28936"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/24f078df6cf894a84328872b4fdcad736ab97938"}}}}
{"actor":{"display_login":"thockin"}}