{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/49655338","id":49655338,"diff_hunk":"@@ -46,27 +27,20 @@ class Config implements ConfigInterface\n     ];\n \n     /**\n-     * Constructor\n-     *\n      * @param array $config\n      */\n     public function __construct(array $config = [])\n     {\n         // Only merge keys we're interested in\n-        foreach (array_keys($config) as $key) {\n-            if (! isset($this->allowedKeys[$key])) {\n-                unset($config[$key]);\n+        foreach (array_keys($this->config) as $requiredKey) {\n+            if (isset($config[$requiredKey])) {","path":"src/Config.php","position":44,"original_position":44,"commit_id":"b229413333c77cb10baf558647ba24eaff261c84","original_commit_id":"b229413333c77cb10baf558647ba24eaff261c84","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"This should likely be a combination of `isset && is_array`, as every single item is expected to be an array. I'll make that change on merge.","created_at":"2016-01-13T21:44:01Z","updated_at":"2016-01-13T21:44:01Z","html_url":"https://github.com/zendframework/zend-servicemanager/pull/68#discussion_r49655338","pull_request_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/49655338"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/68#discussion_r49655338"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68","id":55930609,"html_url":"https://github.com/zendframework/zend-servicemanager/pull/68","diff_url":"https://github.com/zendframework/zend-servicemanager/pull/68.diff","patch_url":"https://github.com/zendframework/zend-servicemanager/pull/68.patch","issue_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/68","number":68,"state":"open","locked":false,"title":"Remove Zend\\Stdlib dependency","user":{"login":"snapshotpl","id":312655,"avatar_url":"https://avatars.githubusercontent.com/u/312655?v=3","gravatar_id":"","url":"https://api.github.com/users/snapshotpl","html_url":"https://github.com/snapshotpl","followers_url":"https://api.github.com/users/snapshotpl/followers","following_url":"https://api.github.com/users/snapshotpl/following{/other_user}","gists_url":"https://api.github.com/users/snapshotpl/gists{/gist_id}","starred_url":"https://api.github.com/users/snapshotpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapshotpl/subscriptions","organizations_url":"https://api.github.com/users/snapshotpl/orgs","repos_url":"https://api.github.com/users/snapshotpl/repos","events_url":"https://api.github.com/users/snapshotpl/events{/privacy}","received_events_url":"https://api.github.com/users/snapshotpl/received_events","type":"User","site_admin":false},"body":"...and simplify config implementation","created_at":"2016-01-13T17:42:42Z","updated_at":"2016-01-13T21:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a18c4b6d84d8ba2b1a10c797439a8c2c0a0a7a06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/68/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/b229413333c77cb10baf558647ba24eaff261c84","head":{"label":"snapshotpl:remove-stdlib-dependency","ref":"remove-stdlib-dependency","sha":"b229413333c77cb10baf558647ba24eaff261c84","user":{"login":"snapshotpl","id":312655,"avatar_url":"https://avatars.githubusercontent.com/u/312655?v=3","gravatar_id":"","url":"https://api.github.com/users/snapshotpl","html_url":"https://github.com/snapshotpl","followers_url":"https://api.github.com/users/snapshotpl/followers","following_url":"https://api.github.com/users/snapshotpl/following{/other_user}","gists_url":"https://api.github.com/users/snapshotpl/gists{/gist_id}","starred_url":"https://api.github.com/users/snapshotpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapshotpl/subscriptions","organizations_url":"https://api.github.com/users/snapshotpl/orgs","repos_url":"https://api.github.com/users/snapshotpl/repos","events_url":"https://api.github.com/users/snapshotpl/events{/privacy}","received_events_url":"https://api.github.com/users/snapshotpl/received_events","type":"User","site_admin":false},"repo":{"id":49460298,"name":"zend-servicemanager","full_name":"snapshotpl/zend-servicemanager","owner":{"login":"snapshotpl","id":312655,"avatar_url":"https://avatars.githubusercontent.com/u/312655?v=3","gravatar_id":"","url":"https://api.github.com/users/snapshotpl","html_url":"https://github.com/snapshotpl","followers_url":"https://api.github.com/users/snapshotpl/followers","following_url":"https://api.github.com/users/snapshotpl/following{/other_user}","gists_url":"https://api.github.com/users/snapshotpl/gists{/gist_id}","starred_url":"https://api.github.com/users/snapshotpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapshotpl/subscriptions","organizations_url":"https://api.github.com/users/snapshotpl/orgs","repos_url":"https://api.github.com/users/snapshotpl/repos","events_url":"https://api.github.com/users/snapshotpl/events{/privacy}","received_events_url":"https://api.github.com/users/snapshotpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snapshotpl/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":true,"url":"https://api.github.com/repos/snapshotpl/zend-servicemanager","forks_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/snapshotpl/zend-servicemanager/releases{/id}","created_at":"2016-01-11T23:08:16Z","updated_at":"2016-01-11T23:08:17Z","pushed_at":"2016-01-13T17:46:17Z","git_url":"git://github.com/snapshotpl/zend-servicemanager.git","ssh_url":"git@github.com:snapshotpl/zend-servicemanager.git","clone_url":"https://github.com/snapshotpl/zend-servicemanager.git","svn_url":"https://github.com/snapshotpl/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":2043,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"97dfca5c8b368b2d41dc47aa3cbf9383072e0ace","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280826,"name":"zend-servicemanager","full_name":"zendframework/zend-servicemanager","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-servicemanager","forks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/zendframework/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/zendframework/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-servicemanager/releases{/id}","created_at":"2015-05-08T13:28:10Z","updated_at":"2016-01-13T20:57:47Z","pushed_at":"2016-01-13T19:32:02Z","git_url":"git://github.com/zendframework/zend-servicemanager.git","ssh_url":"git@github.com:zendframework/zend-servicemanager.git","clone_url":"https://github.com/zendframework/zend-servicemanager.git","svn_url":"https://github.com/zendframework/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":2284,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":6,"forks":28,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/68"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/68"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/b229413333c77cb10baf558647ba24eaff261c84"}}}}