{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/widgets/issues/128","repository_url":"https://api.github.com/repos/dojo/widgets","labels_url":"https://api.github.com/repos/dojo/widgets/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/128/comments","events_url":"https://api.github.com/repos/dojo/widgets/issues/128/events","html_url":"https://github.com/dojo/widgets/pull/128","id":191365319,"number":128,"title":"include VNodeEvented in Widget base","user":{"login":"agubler","id":1982678,"avatar_url":"https://avatars.githubusercontent.com/u/1982678?v=3","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dojo/widgets/milestones/8","html_url":"https://github.com/dojo/widgets/milestones/2016.11","labels_url":"https://api.github.com/repos/dojo/widgets/milestones/8/labels","id":2090437,"number":8,"title":"2016.11","description":"","creator":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":47,"state":"open","created_at":"2016-10-24T19:42:52Z","updated_at":"2016-11-29T16:49:30Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"comments":8,"created_at":"2016-11-23T19:49:24Z","updated_at":"2016-11-29T17:37:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/128","html_url":"https://github.com/dojo/widgets/pull/128","diff_url":"https://github.com/dojo/widgets/pull/128.diff","patch_url":"https://github.com/dojo/widgets/pull/128.patch"},"body":"**Type:** feature\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [x] There is a related issue\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [x] Unit or Functional tests are included in the PR\r\n\r\n**Description:**\r\n\r\nAdd `VNodeEvented` to `createWidgetBase` by default.\r\n\r\nResolves #115\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dojo/widgets/issues/comments/263641029","html_url":"https://github.com/dojo/widgets/pull/128#issuecomment-263641029","issue_url":"https://api.github.com/repos/dojo/widgets/issues/128","id":263641029,"user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T17:37:09Z","updated_at":"2016-11-29T17:37:09Z","body":">  this mixin only aspects things that are in Evented and the mixin itself actually has createEvented mixed in so all the functionality should be covered by existing unit tests.\r\n\r\nIt adds a [nodeAttribute](https://github.com/dojo/widgets/blob/master/src/mixins/createVNodeEvented.ts#L139) renderer.  Nothing in Evented calls that.  The only thing that calls that is WidgetBase.  The unit tests for VNodeEvented don't utilise a render function, because VNodeEvented doesn't implement that.  The mixin _does_ change the behaviour of WidgetBase, but the current tests are not testing for it the expected behaviour (that the listeners end up in the render)."}}
{"actor":{"display_login":"kitsonk"}}