{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28470","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28470/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28470/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28470/events","html_url":"https://github.com/kubernetes/kubernetes/issues/28470","id":163714345,"number":28470,"title":"Adding provider bm (bare metal)","user":{"login":"pskrzyns","id":16152568,"avatar_url":"https://avatars.githubusercontent.com/u/16152568?v=3","gravatar_id":"","url":"https://api.github.com/users/pskrzyns","html_url":"https://github.com/pskrzyns","followers_url":"https://api.github.com/users/pskrzyns/followers","following_url":"https://api.github.com/users/pskrzyns/following{/other_user}","gists_url":"https://api.github.com/users/pskrzyns/gists{/gist_id}","starred_url":"https://api.github.com/users/pskrzyns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskrzyns/subscriptions","organizations_url":"https://api.github.com/users/pskrzyns/orgs","repos_url":"https://api.github.com/users/pskrzyns/repos","events_url":"https://api.github.com/users/pskrzyns/events{/privacy}","received_events_url":"https://api.github.com/users/pskrzyns/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-04T17:13:49Z","updated_at":"2016-07-12T18:05:35Z","closed_at":"2016-07-12T18:05:35Z","body":"I would like to add new provider `bm` for running tests on bare metal\r\n\r\nAt this moment i found something about 64 non conformance tests failing on bare metal so I would like to add to them\r\n```go\r\nBeforeEach(func() {\r\n...\r\n\t\tframework.SkipIfProviderIs(\"bm\")\r\n...\r\n\t})\r\n```\r\nwhich will allow us to monitor status of currently passing tests.\r\n\r\n`framework.SkipIfProviderIs(\"bm\")` will be removed from other tests as they will be fixed on bm or documentation describing how to run them will be added\r\n\r\nAdditionally some tests like density tests require provider specific implementation (in this case `GetSigner`)                                                                                                                               \r\n\r\nSo questions:\r\n - When adding new provider do I need to add some more configuration scripts beside:\r\ncluster/bm/config-default.sh\r\ncluster/bm/utils.sh\r\nor those are the only ones ?\r\n - Any tests beside those using `GetSigner` with provider specific implementation (except those with framework.SkipUnlessProviderIs) ?\r\n - Which documentation should be updated after adding new provider?\r\n - Any other requirements to add new provider ?\r\n\r\n\r\n\r\nTODO list:\r\n- [ ] add `cluster/bm/config-default.sh` and `cluster/bm/utils.sh`\r\n- [ ] add framework.SkipIfProviderIs(\"bm\") to failing tests\r\n- [ ] update documentation\r\n- [ ] support for bm provider in `GetSigner`\r\n- [ ] fixing tests to allow them running on bare metal\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/232129704","html_url":"https://github.com/kubernetes/kubernetes/issues/28470#issuecomment-232129704","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28470","id":232129704,"user":{"login":"pskrzyns","id":16152568,"avatar_url":"https://avatars.githubusercontent.com/u/16152568?v=3","gravatar_id":"","url":"https://api.github.com/users/pskrzyns","html_url":"https://github.com/pskrzyns","followers_url":"https://api.github.com/users/pskrzyns/followers","following_url":"https://api.github.com/users/pskrzyns/following{/other_user}","gists_url":"https://api.github.com/users/pskrzyns/gists{/gist_id}","starred_url":"https://api.github.com/users/pskrzyns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskrzyns/subscriptions","organizations_url":"https://api.github.com/users/pskrzyns/orgs","repos_url":"https://api.github.com/users/pskrzyns/repos","events_url":"https://api.github.com/users/pskrzyns/events{/privacy}","received_events_url":"https://api.github.com/users/pskrzyns/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T18:05:35Z","updated_at":"2016-07-12T18:05:35Z","body":"Closing after today sig-testing meeting. I will create other issue for tracking e2e tests failing on bm.\r\nThis will be reopened when i have real bm specific tests i.e. Density tests with 500 pods per node ;)"}}
{"actor":{"display_login":"pskrzyns"}}