{"action":"opened","number":1678,"pull_request":{"url":"https://api.github.com/repos/roots/sage/pulls/1678","id":77609590,"html_url":"https://github.com/roots/sage/pull/1678","diff_url":"https://github.com/roots/sage/pull/1678.diff","patch_url":"https://github.com/roots/sage/pull/1678.patch","issue_url":"https://api.github.com/repos/roots/sage/issues/1678","number":1678,"state":"open","locked":false,"title":"Rework template wrapper, bring back template_part()","user":{"login":"QWp6t","id":2104321,"avatar_url":"https://avatars.githubusercontent.com/u/2104321?v=3","gravatar_id":"","url":"https://api.github.com/users/QWp6t","html_url":"https://github.com/QWp6t","followers_url":"https://api.github.com/users/QWp6t/followers","following_url":"https://api.github.com/users/QWp6t/following{/other_user}","gists_url":"https://api.github.com/users/QWp6t/gists{/gist_id}","starred_url":"https://api.github.com/users/QWp6t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QWp6t/subscriptions","organizations_url":"https://api.github.com/users/QWp6t/orgs","repos_url":"https://api.github.com/users/QWp6t/repos","events_url":"https://api.github.com/users/QWp6t/events{/privacy}","received_events_url":"https://api.github.com/users/QWp6t/received_events","type":"User","site_admin":false},"body":"This brings back the previous `sidebar_path()` functionality, but I've re-implemented it as part of a  more generic `template_part()` helper function. The helper function is aware of the main template and it will first check for partials appended with the main template name.\r\n\r\nSo if you have...\r\n* partials/sidebar.php\r\n* partials/sidebar-front-page.php\r\n\r\nAnd you load your sidebar with `App\\template_part('partials/sidebar');`\r\n\r\nThen when the front-page.php template is loaded, the sidebar-front-page.php partial will also be loaded.\r\n\r\nAdditionally, this PR alters some of the language to be a little more consistent with Sage 8. Instead of \"wrap\" and \"unwrap,\" I'm using \"layout\" (e.g., base.php) and \"main\" (e.g., page.php) in the Template class.","created_at":"2016-07-15T12:42:44Z","updated_at":"2016-07-15T12:42:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/roots/sage/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/roots/sage/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/roots/sage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roots/sage/issues/1678/comments","statuses_url":"https://api.github.com/repos/roots/sage/statuses/eb3a7add858c4531244ab27004fc15c91cb2b98e","head":{"label":"roots:sage9-rework_wrapper","ref":"sage9-rework_wrapper","sha":"eb3a7add858c4531244ab27004fc15c91cb2b98e","user":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"repo":{"id":1305114,"name":"sage","full_name":"roots/sage","owner":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roots/sage","description":"The best WordPress starter theme with a modern front-end development workflow. Based on HTML5 Boilerplate, gulp, Bower, and Bootstrap.","fork":false,"url":"https://api.github.com/repos/roots/sage","forks_url":"https://api.github.com/repos/roots/sage/forks","keys_url":"https://api.github.com/repos/roots/sage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roots/sage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roots/sage/teams","hooks_url":"https://api.github.com/repos/roots/sage/hooks","issue_events_url":"https://api.github.com/repos/roots/sage/issues/events{/number}","events_url":"https://api.github.com/repos/roots/sage/events","assignees_url":"https://api.github.com/repos/roots/sage/assignees{/user}","branches_url":"https://api.github.com/repos/roots/sage/branches{/branch}","tags_url":"https://api.github.com/repos/roots/sage/tags","blobs_url":"https://api.github.com/repos/roots/sage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roots/sage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roots/sage/git/refs{/sha}","trees_url":"https://api.github.com/repos/roots/sage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roots/sage/statuses/{sha}","languages_url":"https://api.github.com/repos/roots/sage/languages","stargazers_url":"https://api.github.com/repos/roots/sage/stargazers","contributors_url":"https://api.github.com/repos/roots/sage/contributors","subscribers_url":"https://api.github.com/repos/roots/sage/subscribers","subscription_url":"https://api.github.com/repos/roots/sage/subscription","commits_url":"https://api.github.com/repos/roots/sage/commits{/sha}","git_commits_url":"https://api.github.com/repos/roots/sage/git/commits{/sha}","comments_url":"https://api.github.com/repos/roots/sage/comments{/number}","issue_comment_url":"https://api.github.com/repos/roots/sage/issues/comments{/number}","contents_url":"https://api.github.com/repos/roots/sage/contents/{+path}","compare_url":"https://api.github.com/repos/roots/sage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roots/sage/merges","archive_url":"https://api.github.com/repos/roots/sage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roots/sage/downloads","issues_url":"https://api.github.com/repos/roots/sage/issues{/number}","pulls_url":"https://api.github.com/repos/roots/sage/pulls{/number}","milestones_url":"https://api.github.com/repos/roots/sage/milestones{/number}","notifications_url":"https://api.github.com/repos/roots/sage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roots/sage/labels{/name}","releases_url":"https://api.github.com/repos/roots/sage/releases{/id}","deployments_url":"https://api.github.com/repos/roots/sage/deployments","created_at":"2011-01-29T03:12:09Z","updated_at":"2016-07-15T09:18:34Z","pushed_at":"2016-07-15T12:42:45Z","git_url":"git://github.com/roots/sage.git","ssh_url":"git@github.com:roots/sage.git","clone_url":"https://github.com/roots/sage.git","svn_url":"https://github.com/roots/sage","homepage":"https://roots.io/sage/","size":67595,"stargazers_count":7381,"watchers_count":7381,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2496,"mirror_url":null,"open_issues_count":15,"forks":2496,"open_issues":15,"watchers":7381,"default_branch":"master"}},"base":{"label":"roots:sage-9","ref":"sage-9","sha":"0a71544b83aace5200c0f1a099558d57f2a96155","user":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"repo":{"id":1305114,"name":"sage","full_name":"roots/sage","owner":{"login":"roots","id":4986074,"avatar_url":"https://avatars.githubusercontent.com/u/4986074?v=3","gravatar_id":"","url":"https://api.github.com/users/roots","html_url":"https://github.com/roots","followers_url":"https://api.github.com/users/roots/followers","following_url":"https://api.github.com/users/roots/following{/other_user}","gists_url":"https://api.github.com/users/roots/gists{/gist_id}","starred_url":"https://api.github.com/users/roots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roots/subscriptions","organizations_url":"https://api.github.com/users/roots/orgs","repos_url":"https://api.github.com/users/roots/repos","events_url":"https://api.github.com/users/roots/events{/privacy}","received_events_url":"https://api.github.com/users/roots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roots/sage","description":"The best WordPress starter theme with a modern front-end development workflow. Based on HTML5 Boilerplate, gulp, Bower, and Bootstrap.","fork":false,"url":"https://api.github.com/repos/roots/sage","forks_url":"https://api.github.com/repos/roots/sage/forks","keys_url":"https://api.github.com/repos/roots/sage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roots/sage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roots/sage/teams","hooks_url":"https://api.github.com/repos/roots/sage/hooks","issue_events_url":"https://api.github.com/repos/roots/sage/issues/events{/number}","events_url":"https://api.github.com/repos/roots/sage/events","assignees_url":"https://api.github.com/repos/roots/sage/assignees{/user}","branches_url":"https://api.github.com/repos/roots/sage/branches{/branch}","tags_url":"https://api.github.com/repos/roots/sage/tags","blobs_url":"https://api.github.com/repos/roots/sage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roots/sage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roots/sage/git/refs{/sha}","trees_url":"https://api.github.com/repos/roots/sage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roots/sage/statuses/{sha}","languages_url":"https://api.github.com/repos/roots/sage/languages","stargazers_url":"https://api.github.com/repos/roots/sage/stargazers","contributors_url":"https://api.github.com/repos/roots/sage/contributors","subscribers_url":"https://api.github.com/repos/roots/sage/subscribers","subscription_url":"https://api.github.com/repos/roots/sage/subscription","commits_url":"https://api.github.com/repos/roots/sage/commits{/sha}","git_commits_url":"https://api.github.com/repos/roots/sage/git/commits{/sha}","comments_url":"https://api.github.com/repos/roots/sage/comments{/number}","issue_comment_url":"https://api.github.com/repos/roots/sage/issues/comments{/number}","contents_url":"https://api.github.com/repos/roots/sage/contents/{+path}","compare_url":"https://api.github.com/repos/roots/sage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roots/sage/merges","archive_url":"https://api.github.com/repos/roots/sage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roots/sage/downloads","issues_url":"https://api.github.com/repos/roots/sage/issues{/number}","pulls_url":"https://api.github.com/repos/roots/sage/pulls{/number}","milestones_url":"https://api.github.com/repos/roots/sage/milestones{/number}","notifications_url":"https://api.github.com/repos/roots/sage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roots/sage/labels{/name}","releases_url":"https://api.github.com/repos/roots/sage/releases{/id}","deployments_url":"https://api.github.com/repos/roots/sage/deployments","created_at":"2011-01-29T03:12:09Z","updated_at":"2016-07-15T09:18:34Z","pushed_at":"2016-07-15T12:42:45Z","git_url":"git://github.com/roots/sage.git","ssh_url":"git@github.com:roots/sage.git","clone_url":"https://github.com/roots/sage.git","svn_url":"https://github.com/roots/sage","homepage":"https://roots.io/sage/","size":67595,"stargazers_count":7381,"watchers_count":7381,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2496,"mirror_url":null,"open_issues_count":15,"forks":2496,"open_issues":15,"watchers":7381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roots/sage/pulls/1678"},"html":{"href":"https://github.com/roots/sage/pull/1678"},"issue":{"href":"https://api.github.com/repos/roots/sage/issues/1678"},"comments":{"href":"https://api.github.com/repos/roots/sage/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/roots/sage/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/roots/sage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roots/sage/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/roots/sage/statuses/eb3a7add858c4531244ab27004fc15c91cb2b98e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":130,"deletions":109,"changed_files":8}}
{"actor":{"display_login":"QWp6t"}}