{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/83028085","pull_request_review_id":3894930,"id":83028085,"diff_hunk":"@@ -219,3 +222,41 @@ func SetMasterNodeAffinity(meta *api.ObjectMeta) {\n \t}\n \tmeta.Annotations[api.AffinityAnnotationKey] = string(affinityAnnotation)\n }\n+\n+func createDummyDeployment(client *clientset.Clientset) {\n+\tfmt.Println(\"<master/apiclient> attempting a test deployment\")\n+\tdummyDeployment := NewDeployment(\"dummy\", 1, api.PodSpec{\n+\t\tSecurityContext: &api.PodSecurityContext{HostNetwork: true},\n+\t\tContainers: []api.Container{{\n+\t\t\tName:  \"dummy\",\n+\t\t\tImage: images.GetAddonImage(\"pause\"),\n+\t\t}},\n+\t})\n+\n+\twait.PollInfinite(apiCallRetryInterval, func() (bool, error) {","path":"cmd/kubeadm/app/master/apiclient.go","position":32,"original_position":32,"commit_id":"53e393ad421394ad664da09bbab86bf6f1d458e1","original_commit_id":"53e393ad421394ad664da09bbab86bf6f1d458e1","user":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"body":"Oops, misread.","created_at":"2016-10-12T15:13:36Z","updated_at":"2016-10-12T15:13:36Z","html_url":"https://github.com/kubernetes/kubernetes/pull/34573#discussion_r83028085","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/83028085"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/34573#discussion_r83028085"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573","id":88916173,"html_url":"https://github.com/kubernetes/kubernetes/pull/34573","diff_url":"https://github.com/kubernetes/kubernetes/pull/34573.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/34573.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34573","number":34573,"state":"open","locked":false,"title":"Test API more extensivelly before declaring readiness ","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nIt's possible that first deployment kubeadm creates will hit `deployments.extensions \"kube-discovery\" is forbidden: not yet ready to handle request`, which comes from NamespaceLifecycle admission controller and has something to do with cache. According to @derekwaynecarr, we need to create a namespace-scoped resource to really check for this. I didn't want to make a check with deployment of whatever comes first right now, and decided to have explicit step for this in `apiclient.go`.\r\n\r\n**Which issue this PR fixes**: fixes #34411\r\n\r\n**Special notes for your reviewer**: @kubernetes/sig-cluster-lifecycle \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/34573)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-11T21:38:28Z","updated_at":"2016-10-12T15:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a0bc921cf0daa43fd4111938a9a881a8e8bd92","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34573/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/53e393ad421394ad664da09bbab86bf6f1d458e1","head":{"label":"errordeveloper:fix-early-deployment-issue","ref":"fix-early-deployment-issue","sha":"53e393ad421394ad664da09bbab86bf6f1d458e1","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":25202727,"name":"kubernetes","full_name":"errordeveloper/kubernetes","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/errordeveloper/kubernetes","forks_url":"https://api.github.com/repos/errordeveloper/kubernetes/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubernetes/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubernetes/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubernetes/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubernetes/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubernetes/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubernetes/deployments","created_at":"2014-10-14T11:13:25Z","updated_at":"2016-03-23T12:29:37Z","pushed_at":"2016-10-12T14:53:12Z","git_url":"git://github.com/errordeveloper/kubernetes.git","ssh_url":"git@github.com:errordeveloper/kubernetes.git","clone_url":"https://github.com/errordeveloper/kubernetes.git","svn_url":"https://github.com/errordeveloper/kubernetes","homepage":null,"size":333114,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ead65fc25fe309464b40d0ba212f83ae256725da","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-12T14:16:46Z","pushed_at":"2016-10-12T15:08:18Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":592288,"stargazers_count":17475,"watchers_count":17475,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5683,"mirror_url":null,"open_issues_count":4933,"forks":5683,"open_issues":4933,"watchers":17475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/34573"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/34573"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/34573/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34573/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/53e393ad421394ad664da09bbab86bf6f1d458e1"}}}}
{"actor":{"display_login":"mikedanese"}}