{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/90492553","pull_request_review_id":11011613,"id":90492553,"diff_hunk":"@@ -1,20 +1,20 @@\n 'use strict';\n-var common = require('../common');\n-var assert = require('assert');\n-var net = require('net');\n+let common = require('../common');\n+let assert = require('assert');\n+let net = require('net');\n \n var serverConnection;\n var clientConnection;\n var echoServer = net.createServer(function(connection) {\n   serverConnection = connection;\n-  setTimeout(function() {\n+  setTimeout(common.mustCall(function() {\n     // make sure both connections are still open\n-    assert.equal(serverConnection.readyState, 'open');\n-    assert.equal(clientConnection.readyState, 'open');\n+    assert.strictEqual(serverConnection.readyState, 'open');\n+    assert.strictEqual(clientConnection.readyState, 'open');\n     serverConnection.end();\n     clientConnection.end();\n     echoServer.close();\n-  }, common.platformTimeout(100));\n+  },1), common.platformTimeout(100));","path":"test/parallel/test-net-keepalive.js","position":24,"original_position":24,"commit_id":"0c55efdd3b0bd418bce11a1637629b502e6f6d0e","original_commit_id":"0c55efdd3b0bd418bce11a1637629b502e6f6d0e","user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars.githubusercontent.com/u/54666?v=3","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"body":"There should be a space before the 1 here.","created_at":"2016-12-01T17:11:39Z","updated_at":"2016-12-01T17:11:39Z","html_url":"https://github.com/nodejs/node/pull/9984#discussion_r90492553","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9984","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/90492553"},"html":{"href":"https://github.com/nodejs/node/pull/9984#discussion_r90492553"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9984"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9984","id":96130747,"html_url":"https://github.com/nodejs/node/pull/9984","diff_url":"https://github.com/nodejs/node/pull/9984.diff","patch_url":"https://github.com/nodejs/node/pull/9984.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9984","number":9984,"state":"open","locked":false,"title":"test: add mustCall to setTimeout","user":{"login":"kmccmk9","id":678335,"avatar_url":"https://avatars.githubusercontent.com/u/678335?v=3","gravatar_id":"","url":"https://api.github.com/users/kmccmk9","html_url":"https://github.com/kmccmk9","followers_url":"https://api.github.com/users/kmccmk9/followers","following_url":"https://api.github.com/users/kmccmk9/following{/other_user}","gists_url":"https://api.github.com/users/kmccmk9/gists{/gist_id}","starred_url":"https://api.github.com/users/kmccmk9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmccmk9/subscriptions","organizations_url":"https://api.github.com/users/kmccmk9/orgs","repos_url":"https://api.github.com/users/kmccmk9/repos","events_url":"https://api.github.com/users/kmccmk9/events{/privacy}","received_events_url":"https://api.github.com/users/kmccmk9/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nAdded mustCall to the setTimout inline function. Changed assert.equal\r\nto assert.strictEqual. Changed var for require modules to let.","created_at":"2016-12-01T17:10:41Z","updated_at":"2016-12-01T17:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fbd0f80e7a88de697854c3e2e6e55593635b2c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9984/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9984/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9984/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/0c55efdd3b0bd418bce11a1637629b502e6f6d0e","head":{"label":"kmccmk9:test-keepalive","ref":"test-keepalive","sha":"0c55efdd3b0bd418bce11a1637629b502e6f6d0e","user":{"login":"kmccmk9","id":678335,"avatar_url":"https://avatars.githubusercontent.com/u/678335?v=3","gravatar_id":"","url":"https://api.github.com/users/kmccmk9","html_url":"https://github.com/kmccmk9","followers_url":"https://api.github.com/users/kmccmk9/followers","following_url":"https://api.github.com/users/kmccmk9/following{/other_user}","gists_url":"https://api.github.com/users/kmccmk9/gists{/gist_id}","starred_url":"https://api.github.com/users/kmccmk9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmccmk9/subscriptions","organizations_url":"https://api.github.com/users/kmccmk9/orgs","repos_url":"https://api.github.com/users/kmccmk9/repos","events_url":"https://api.github.com/users/kmccmk9/events{/privacy}","received_events_url":"https://api.github.com/users/kmccmk9/received_events","type":"User","site_admin":false},"repo":{"id":75305177,"name":"node","full_name":"kmccmk9/node","owner":{"login":"kmccmk9","id":678335,"avatar_url":"https://avatars.githubusercontent.com/u/678335?v=3","gravatar_id":"","url":"https://api.github.com/users/kmccmk9","html_url":"https://github.com/kmccmk9","followers_url":"https://api.github.com/users/kmccmk9/followers","following_url":"https://api.github.com/users/kmccmk9/following{/other_user}","gists_url":"https://api.github.com/users/kmccmk9/gists{/gist_id}","starred_url":"https://api.github.com/users/kmccmk9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmccmk9/subscriptions","organizations_url":"https://api.github.com/users/kmccmk9/orgs","repos_url":"https://api.github.com/users/kmccmk9/repos","events_url":"https://api.github.com/users/kmccmk9/events{/privacy}","received_events_url":"https://api.github.com/users/kmccmk9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmccmk9/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/kmccmk9/node","forks_url":"https://api.github.com/repos/kmccmk9/node/forks","keys_url":"https://api.github.com/repos/kmccmk9/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmccmk9/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmccmk9/node/teams","hooks_url":"https://api.github.com/repos/kmccmk9/node/hooks","issue_events_url":"https://api.github.com/repos/kmccmk9/node/issues/events{/number}","events_url":"https://api.github.com/repos/kmccmk9/node/events","assignees_url":"https://api.github.com/repos/kmccmk9/node/assignees{/user}","branches_url":"https://api.github.com/repos/kmccmk9/node/branches{/branch}","tags_url":"https://api.github.com/repos/kmccmk9/node/tags","blobs_url":"https://api.github.com/repos/kmccmk9/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmccmk9/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmccmk9/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmccmk9/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmccmk9/node/statuses/{sha}","languages_url":"https://api.github.com/repos/kmccmk9/node/languages","stargazers_url":"https://api.github.com/repos/kmccmk9/node/stargazers","contributors_url":"https://api.github.com/repos/kmccmk9/node/contributors","subscribers_url":"https://api.github.com/repos/kmccmk9/node/subscribers","subscription_url":"https://api.github.com/repos/kmccmk9/node/subscription","commits_url":"https://api.github.com/repos/kmccmk9/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmccmk9/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmccmk9/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmccmk9/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmccmk9/node/contents/{+path}","compare_url":"https://api.github.com/repos/kmccmk9/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmccmk9/node/merges","archive_url":"https://api.github.com/repos/kmccmk9/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmccmk9/node/downloads","issues_url":"https://api.github.com/repos/kmccmk9/node/issues{/number}","pulls_url":"https://api.github.com/repos/kmccmk9/node/pulls{/number}","milestones_url":"https://api.github.com/repos/kmccmk9/node/milestones{/number}","notifications_url":"https://api.github.com/repos/kmccmk9/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmccmk9/node/labels{/name}","releases_url":"https://api.github.com/repos/kmccmk9/node/releases{/id}","deployments_url":"https://api.github.com/repos/kmccmk9/node/deployments","created_at":"2016-12-01T15:22:17Z","updated_at":"2016-12-01T15:22:43Z","pushed_at":"2016-12-01T17:07:04Z","git_url":"git://github.com/kmccmk9/node.git","ssh_url":"git@github.com:kmccmk9/node.git","clone_url":"https://github.com/kmccmk9/node.git","svn_url":"https://github.com/kmccmk9/node","homepage":"https://nodejs.org","size":366849,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8264a2225628cbc32116f83a079f6024786988ab","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-01T16:53:42Z","pushed_at":"2016-12-01T17:11:31Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":366849,"stargazers_count":29424,"watchers_count":29424,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5241,"mirror_url":null,"open_issues_count":1085,"forks":5241,"open_issues":1085,"watchers":29424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9984"},"html":{"href":"https://github.com/nodejs/node/pull/9984"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9984"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9984/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9984/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9984/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/0c55efdd3b0bd418bce11a1637629b502e6f6d0e"}}}}
{"actor":{"display_login":"mscdex"}}