{"push_id":1327969667,"size":196,"distinct_size":196,"ref":"refs/heads/master","head":"066e07fdf0612dc7a167f88dc0c5ee969338ce95","before":"c74d103db86f9e7cc69b8a5635a127815e4cb91f","commits":[{"sha":"090ecd66530504e9e7346dc040ffe1b65319c1a9","author":{"name":"Mick Killianey","email":"4c696aca7c9e1d3e11752ee303a7fac0d53a2661@fb.com"},"message":"Rename \"plugin\" to \"ideabuck\" to allow for the possibility of another buck plugin.\n\nSummary:\nRenamed com.facebook.buck.intellij.{plugin,ideabuck} to match the name of the plugin\nin the Jetbrains repo. (See https://plugins.jetbrains.com/plugin/7826?pr=idea .)\n\nAlso added build target \"ideabuck\"\n\nTest Plan: Confirm that 'buck build //...' and 'ant test' still work.\n\nReviewed By: dreiss\n\nfbshipit-source-id: 3fe4430","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/090ecd66530504e9e7346dc040ffe1b65319c1a9"},{"sha":"951d49f77d5fe144328848ed639009585aeac3b9","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"change behavior of getTransitiveClasspathDeps to match getTransitiveClasspathEntries\n\nSummary:\n`getTransitiveClasspathDeps` currently leave out the root library even if there\nare exported deps. This changes the export the library in this case, which makes\nthe behavior identical to `getTransitiveClasspathEntries` (though perhaps\nequally non-sensical).\n\nThis is important when merging these two codepaths back into one.\n\nTest Plan: CI\n\nReviewed By: asp2insp\n\nfbshipit-source-id: 5ab412c","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/951d49f77d5fe144328848ed639009585aeac3b9"},{"sha":"304889cb18f13ac2e25bc1523bd8956be1713114","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Derive transitive classpaths from transitiveClasspathDeps + immediate classpaths\n\nSummary:\nInstead of implementing identical traversal code for finding\ntransitive dependencies from which to collect classpaths, implement\nclasspath collection in terms transitive dependencies + classpaths for\neach dependency.\n\nThis is an intermediate step to removing the\ntransitiveClasspathEntries multimap entirely.\n\nThis diff should be scrutinized with some care, as some of this code\nis very old and I have not worked with the Java stuff before.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 511646f","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/304889cb18f13ac2e25bc1523bd8956be1713114"},{"sha":"847e5fb3bf4d1d4dcd46f7259af92e6040399270","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Replace getTransitiveClasspathEntries with getTransitiveClasspaths\n\nSummary:\nBased on the observation that we only ever use the keys or values of\ngetTransitiveClasspathEntries, and never the map-like nature of the\nentries themselves, this diff refactors all uses of the keySet to\n`getTransitiveClasspathDeps` and all uses of value to the new\n`getTransitiveClasspaths`.\n\nThis should dramatically reduce the memory footprint for storing all\nthe transitive classpaths.\n\nThe underlying computation to generate the classpaths still constructs\na multimap (because some codepaths actually use the underlying\n`getClasspathEntries` function). I will contemplate removing this in\nthe future for a computation speed win.\n\nTest Plan:\nCI\n\n`buck audit classpaths` shows no differences.\n\nReviewed By: alsutton\n\nfbshipit-source-id: 99aea6e","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/847e5fb3bf4d1d4dcd46f7259af92e6040399270"},{"sha":"bc8a3a95df1c7ea94690dc7c0e84bb409626e9c5","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Stop computing Multimap of transitive classpaths\n\nSummary:\nThis diff adds a function to collect classpaths from libraries without\npreserving the library it comes from (fetching the classpaths of a\nparticular library can be achieved by calling\ngetImmediateClasspaths()).\n\nChange remaining uses of the multimap to use this new function, or\ncall getImmediateClasspaths.\n\nThis results in a negligible performance win when computing transitive\nclasspaths (~4% in one test).\n\nTest Plan: CI, `buck audit classpaths` and see results are identical.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 059e7d4","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/bc8a3a95df1c7ea94690dc7c0e84bb409626e9c5"},{"sha":"7988718cfeeb89b6480875eb39c5480851f069b8","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Add the option to set pex shebang line and use it to force buck.pex to python2.7\n\nSummary:\nPreviously, the buck pex is built with whatever `python.interpreter` is set to.\n\nThe pex cli supports --python-shebang for explicitly setting the shebang line. I\nadd this functionality to our make_pex.py as well.\n\nI use this newly added flag, along with the undocumented `build_args` field, to\nforce buck pex to always emit python2.7.\n\nI did not want to just use python2 since that convention is not standard (my\nlaptop did not have a python2 on my path by default).\n\nTest Plan:\nant default\n     bin/buck build buck\n     head -n 1 buck-out/programs/buck.pex\n\nSee that the first line is as I set it.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 5d27af1","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/7988718cfeeb89b6480875eb39c5480851f069b8"},{"sha":"3df843ea004c1959e06aad320da561f1aa942dd5","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"cxx: support `exported_deps` on `prebuilt_cxx_library_group`\n\nTest Plan: added test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 1d5a9ce","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/3df843ea004c1959e06aad320da561f1aa942dd5"},{"sha":"abdef755b824ba722c732a606eedbfc558c6b69c","author":{"name":"Adam Simpkins","email":"edcf11ba16d0c184526f274cfa425b28caee076f@fb.com"},"message":"fix python unit tests to return non-zero on failure\n\nSummary:\nSecond attempt to fix the python unit tests to return non-zero on\nfailure.  This updates the python test runner to return a special exit\ncode on test failure, and updates PythonRunTestsStep to translate that\nspecific exit code back into a successful result.\n\nTest Plan: Updated testPythonTest() to check this behavior.\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: c8542cb","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/abdef755b824ba722c732a606eedbfc558c6b69c"},{"sha":"7994bd06060cd63a25ac373f09b885648c28b455","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"export_file: introduce a now `mode` parameter to avoid copying\n\nSummary:\nCurrently, the implementation of `export_file` creates a copy of\nthe references source path.  In many cases, this isn't necessary\nand can incur a large build time overhead.  This diff adds a new\n`mode` parameter which can be used to select a new `REFERENCE`\nmode.  In this mode, the underlying source path is forwarded rather\nthan copied/cached.\n\nTest Plan: added tests\n\nReviewed By: Coneko\n\nfbshipit-source-id: 063f591","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/7994bd06060cd63a25ac373f09b885648c28b455"},{"sha":"4b81d63ac18a6f626f2fd23c088eb29e0ebba4b6","author":{"name":"Al Sutton","email":"44353ece80b2d873af6191a7a438b1cfc9d61e3c@fb.com"},"message":"Add aapt vector drawable switch support\n\nSummary:\nAdd support for the --no-version-vectors switch for aapt which is needed for\nvector drawable support on pre-KitKat devices (see https://fburl.com/430488692)\n\nTest Plan: - Unit tests included\n\nReviewed By: asp2insp\n\nfbshipit-source-id: d03b014","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/4b81d63ac18a6f626f2fd23c088eb29e0ebba4b6"},{"sha":"2b73ccc719f7c03947ce28e366ebe5dbdbe230e1","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Remove RemoteLogger interface - replace with BatchingLogger\n\nSummary:\nSwitching from: RemoteLogger interface implemented by (abstract) BatchingLogger\nto: BatchingLogger interface implemented by (abstract) AbstractBatchingLogger\n\nTest Plan: buck test\n\nReviewed By: ruibm\n\nfbshipit-source-id: 45d7bd9","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/2b73ccc719f7c03947ce28e366ebe5dbdbe230e1"},{"sha":"fc27d49f6cf21d63be89e7c9f134d7891e6d3040","author":{"name":"Vladislav Alexeev","email":"caa47d39ae0ab3ce159d5ed47ba1172beb4c76b1@fb.com"},"message":"Move MaximumResourceAmounts functionality to BuckConfig\n\nSummary:\nMove MaximumResourceAmounts functionality to BuckConfig\nFor consistency.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 0435e2c","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/fc27d49f6cf21d63be89e7c9f134d7891e6d3040"},{"sha":"8e437bace2ea4ca76cc6ea42b1b300d3ac54adf2","author":{"name":"Gautam Korlam","email":"a70b17c4b77b9b5f936f1ba7f5e2b8be80f39ff8@uber.com"},"message":"Use package and resource name when computing referenced resource names in dex\n\nSummary:\nResolves #828\nCloses https://github.com/facebook/buck/pull/830\n\nReviewed By: aiked, Coneko\n\nfbshipit-source-id: 021a889","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/8e437bace2ea4ca76cc6ea42b1b300d3ac54adf2"},{"sha":"0a0d0bb1e02aefe593c06e48c161de352cfd7653","author":{"name":"Mick Killianey","email":"4c696aca7c9e1d3e11752ee303a7fac0d53a2661@fb.com"},"message":"Ignore com.facebook.buck.intellij files from compilation by the main buck module.\n\nSummary:\nDon't compile the intellij module as part of the buck module.  It was\nwrongly rooted, and even if we fix that, it has different dependencies\nand should be treated differently -- as one example, it uses the\nIntelliJ-compatible JDK, which is not necessarily the JDK used by\nBuck.  (Buck is currently Java 7+, while the ideabuck plugin can,\nindependently of Buck, decide to run on Java 8+).\n\nTest Plan: Verify the plugin files are no longer compiled as part of the buck module.\n\nReviewed By: asp2insp\n\nfbshipit-source-id: 91e2c44","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/0a0d0bb1e02aefe593c06e48c161de352cfd7653"},{"sha":"ba106d72a525962bf7f944a90006e245ca701d0d","author":{"name":"Mick Killianey","email":"4c696aca7c9e1d3e11752ee303a7fac0d53a2661@fb.com"},"message":"Fix DependenciesOptimizer and DependenciesOptimizerTest.\n\nSummary: DependenciesOptimizerTest wasn't compiling, now it does.\n\nTest Plan: Run tests.\n\nReviewed By: mzlee\n\nfbshipit-source-id: f4d09fc","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/ba106d72a525962bf7f944a90006e245ca701d0d"},{"sha":"b5f4e756a922c74b1e3d8fad7ba9d704dfd2f771","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Revert \"Remove buck test --dry-run.\"\n\nSummary: This reverts commit 3a6f6e6a49abe196d90a475196839a27818c8314.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: f56ed86","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/b5f4e756a922c74b1e3d8fad7ba9d704dfd2f771"},{"sha":"131728b765574d43d7ec90bd1a454bddfe21257e","author":{"name":"Mick Killianey","email":"4c696aca7c9e1d3e11752ee303a7fac0d53a2661@fb.com"},"message":"Add .buckversion to project generated by quickstart.\n\nSummary: The quickstart command used to generate a project without a .buckversion file.\n\nTest Plan:\nAmended existing integration test to check the .buckversion file.\nAlso added test to verify that Android apps build an apk.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 6c5dc29","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/131728b765574d43d7ec90bd1a454bddfe21257e"},{"sha":"6766d57df2e5e2274566bd8e56d50751eb84ce0d","author":{"name":"Ben Reed","email":"00f3e66b2f5e79dbd31db77ea23c54658e1a0453@fb.com"},"message":"add fork_mode option to java_test\n\nSummary:\ntragically some projects count on running junit tests in their own\nprocess. it's sloppy and should be fixed in general, but it shouldn't\nprevent them from using buck.\n\nthis patch adds the fork_mode option to java_test to run tests in their\nown process.\n\nTest Plan:\nadded two unit tests that only pass if the tests run in separate\nprocesses.\n\nReviewed By: bhamiltoncx\n\nfbshipit-source-id: 2d3645b","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/6766d57df2e5e2274566bd8e56d50751eb84ce0d"},{"sha":"011f40767d68b872395e9b4ac5a5e7d25a603702","author":{"name":"Vladislav Alexeev","email":"caa47d39ae0ab3ce159d5ed47ba1172beb4c76b1@fb.com"},"message":"Make CachingBuildEngine aware of resources\n\nSummary:\nSwitch CachingBuildEngine to use ResourceAmounts\nAlso, make sure it schedules caching work and other scheduling intermediate work with lower resource requirements.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 733358c","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/011f40767d68b872395e9b4ac5a5e7d25a603702"},{"sha":"71aa66a14fb2789160e9af65a368c65400eb99be","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"rage should not throw on empty buck-out/log\n\nSummary: Buck rage should not fail when no interesting builds are found.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: d21436d","distinct":true,"url":"https://api.github.com/repos/zbsz/buck/commits/71aa66a14fb2789160e9af65a368c65400eb99be"}]}
{"actor":{"display_login":"zbsz"}}