{"action":"created","issue":{"url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/451","repository_url":"https://api.github.com/repos/sialcasa/mvvmFX","labels_url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/451/labels{/name}","comments_url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/451/comments","events_url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/451/events","html_url":"https://github.com/sialcasa/mvvmFX/issues/451","id":189771260,"number":451,"title":"Load FXML in background thread with FluentViewLoader","user":{"login":"rguillens","id":7717683,"avatar_url":"https://avatars.githubusercontent.com/u/7717683?v=3","gravatar_id":"","url":"https://api.github.com/users/rguillens","html_url":"https://github.com/rguillens","followers_url":"https://api.github.com/users/rguillens/followers","following_url":"https://api.github.com/users/rguillens/following{/other_user}","gists_url":"https://api.github.com/users/rguillens/gists{/gist_id}","starred_url":"https://api.github.com/users/rguillens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rguillens/subscriptions","organizations_url":"https://api.github.com/users/rguillens/orgs","repos_url":"https://api.github.com/users/rguillens/repos","events_url":"https://api.github.com/users/rguillens/events{/privacy}","received_events_url":"https://api.github.com/users/rguillens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-16T16:59:58Z","updated_at":"2016-11-17T08:22:38Z","closed_at":null,"body":"Could be possible loading large FXML scenegraphs in background thread and then execute initialization code in UI thread?\r\n"},"comment":{"url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/comments/261183992","html_url":"https://github.com/sialcasa/mvvmFX/issues/451#issuecomment-261183992","issue_url":"https://api.github.com/repos/sialcasa/mvvmFX/issues/451","id":261183992,"user":{"login":"lestard","id":328387,"avatar_url":"https://avatars.githubusercontent.com/u/328387?v=3","gravatar_id":"","url":"https://api.github.com/users/lestard","html_url":"https://github.com/lestard","followers_url":"https://api.github.com/users/lestard/followers","following_url":"https://api.github.com/users/lestard/following{/other_user}","gists_url":"https://api.github.com/users/lestard/gists{/gist_id}","starred_url":"https://api.github.com/users/lestard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lestard/subscriptions","organizations_url":"https://api.github.com/users/lestard/orgs","repos_url":"https://api.github.com/users/lestard/repos","events_url":"https://api.github.com/users/lestard/events{/privacy}","received_events_url":"https://api.github.com/users/lestard/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T08:22:38Z","updated_at":"2016-11-17T08:22:38Z","body":"This sounds interesting and could improve performance of loading a lot. However, I don't think it's possible with the current implementation. \r\nWe are using the original FXMLLoader internally and this class doesn't allow much configuration. \r\n\r\nTo implement this we would need to first check if it is even possible to load FXML files from another thread with FXMLLoader. I don't think this is possible because typically you need to be on the FX-Thread to create instances of JavaFX controls.\r\n\r\nIf I'm wrong and loading FXML files from outside of FX thread is possible the second step would be to introduce a new initialization mechanism that is guaranteed to be executed on the FX thread. This would be the easy part. For example we could introduce a new interface that we check at loading time and invoke the new initialize method. alternatively you could use `Platform.runLater` in the normal `initialize` method.\r\n"}}
{"actor":{"display_login":"lestard"}}