{"action":"opened","number":641,"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641","id":67093132,"html_url":"https://github.com/aws/aws-sdk-go/pull/641","diff_url":"https://github.com/aws/aws-sdk-go/pull/641.diff","patch_url":"https://github.com/aws/aws-sdk-go/pull/641.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/641","number":641,"state":"open","locked":false,"title":"Fix retries when response is nil","user":{"login":"ryanbrainard","id":966764,"avatar_url":"https://avatars.githubusercontent.com/u/966764?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrainard","html_url":"https://github.com/ryanbrainard","followers_url":"https://api.github.com/users/ryanbrainard/followers","following_url":"https://api.github.com/users/ryanbrainard/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrainard/subscriptions","organizations_url":"https://api.github.com/users/ryanbrainard/orgs","repos_url":"https://api.github.com/users/ryanbrainard/repos","events_url":"https://api.github.com/users/ryanbrainard/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrainard/received_events","type":"User","site_admin":false},"body":"If a failure occurs before `Request.HTTPResponse` is set, the retry handler will panic when trying to read `Request.HTTPResponse.Body`. This adds guards to the retry handler.\r\n\r\nNote, this was partially fixed in https://github.com/aws/aws-sdk-go/pull/622, but this handles the case where the `Request.HTTPResponse` is completely `nil` (not just a `nil` `Body`).\r\n\r\ncc: @ricardochimal @fabiokung ","created_at":"2016-04-19T21:29:21Z","updated_at":"2016-04-19T21:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/641/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-go/statuses/3b55f8717fa6f0b7b7c62bc2f9e4560678b432d0","head":{"label":"ryanbrainard:fix-retry-nil-resp","ref":"fix-retry-nil-resp","sha":"3b55f8717fa6f0b7b7c62bc2f9e4560678b432d0","user":{"login":"ryanbrainard","id":966764,"avatar_url":"https://avatars.githubusercontent.com/u/966764?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrainard","html_url":"https://github.com/ryanbrainard","followers_url":"https://api.github.com/users/ryanbrainard/followers","following_url":"https://api.github.com/users/ryanbrainard/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrainard/subscriptions","organizations_url":"https://api.github.com/users/ryanbrainard/orgs","repos_url":"https://api.github.com/users/ryanbrainard/repos","events_url":"https://api.github.com/users/ryanbrainard/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrainard/received_events","type":"User","site_admin":false},"repo":{"id":56632111,"name":"aws-sdk-go","full_name":"ryanbrainard/aws-sdk-go","owner":{"login":"ryanbrainard","id":966764,"avatar_url":"https://avatars.githubusercontent.com/u/966764?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrainard","html_url":"https://github.com/ryanbrainard","followers_url":"https://api.github.com/users/ryanbrainard/followers","following_url":"https://api.github.com/users/ryanbrainard/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrainard/subscriptions","organizations_url":"https://api.github.com/users/ryanbrainard/orgs","repos_url":"https://api.github.com/users/ryanbrainard/repos","events_url":"https://api.github.com/users/ryanbrainard/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrainard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanbrainard/aws-sdk-go","description":"AWS SDK for the Go programming language.","fork":true,"url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go","forks_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/forks","keys_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/teams","hooks_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/events","assignees_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/tags","blobs_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/languages","stargazers_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/subscription","commits_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/merges","archive_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/downloads","issues_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/ryanbrainard/aws-sdk-go/deployments","created_at":"2016-04-19T21:07:59Z","updated_at":"2016-04-19T21:08:02Z","pushed_at":"2016-04-19T21:25:04Z","git_url":"git://github.com/ryanbrainard/aws-sdk-go.git","ssh_url":"git@github.com:ryanbrainard/aws-sdk-go.git","clone_url":"https://github.com/ryanbrainard/aws-sdk-go.git","svn_url":"https://github.com/ryanbrainard/aws-sdk-go","homepage":"http://aws.amazon.com/sdk-for-go/","size":21524,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"5a13d507649a7f53fd52aa560a592a4ca69d7324","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27576132,"name":"aws-sdk-go","full_name":"aws/aws-sdk-go","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-go","description":"AWS SDK for the Go programming language.","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-go","forks_url":"https://api.github.com/repos/aws/aws-sdk-go/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-go/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-go/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-go/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-go/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-go/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-go/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-go/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-go/deployments","created_at":"2014-12-05T05:29:41Z","updated_at":"2016-04-19T17:38:45Z","pushed_at":"2016-04-19T17:55:14Z","git_url":"git://github.com/aws/aws-sdk-go.git","ssh_url":"git@github.com:aws/aws-sdk-go.git","clone_url":"https://github.com/aws/aws-sdk-go.git","svn_url":"https://github.com/aws/aws-sdk-go","homepage":"http://aws.amazon.com/sdk-for-go/","size":23338,"stargazers_count":2453,"watchers_count":2453,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":37,"forks":367,"open_issues":37,"watchers":2453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641"},"html":{"href":"https://github.com/aws/aws-sdk-go/pull/641"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-go/issues/641"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-go/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-go/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-go/statuses/3b55f8717fa6f0b7b7c62bc2f9e4560678b432d0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":1,"changed_files":2}}