{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26373","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26373/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26373/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26373/events","html_url":"https://github.com/owncloud/core/pull/26373","id":182827335,"number":26373,"title":"Provide a theme through an app","user":{"login":"PhilippSchaffrath","id":1282767,"avatar_url":"https://avatars.githubusercontent.com/u/1282767?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippSchaffrath","html_url":"https://github.com/PhilippSchaffrath","followers_url":"https://api.github.com/users/PhilippSchaffrath/followers","following_url":"https://api.github.com/users/PhilippSchaffrath/following{/other_user}","gists_url":"https://api.github.com/users/PhilippSchaffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippSchaffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippSchaffrath/subscriptions","organizations_url":"https://api.github.com/users/PhilippSchaffrath/orgs","repos_url":"https://api.github.com/users/PhilippSchaffrath/repos","events_url":"https://api.github.com/users/PhilippSchaffrath/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippSchaffrath/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/76","html_url":"https://github.com/owncloud/core/milestones/9.2","labels_url":"https://api.github.com/repos/owncloud/core/milestones/76/labels","id":1632230,"number":76,"title":"9.2","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":567,"closed_issues":330,"state":"open","created_at":"2016-03-09T07:18:43Z","updated_at":"2016-10-13T15:49:26Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-10-13T15:47:02Z","updated_at":"2016-10-14T06:40:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26373","html_url":"https://github.com/owncloud/core/pull/26373","diff_url":"https://github.com/owncloud/core/pull/26373.diff","patch_url":"https://github.com/owncloud/core/pull/26373.patch"},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n\r\n## Description\r\nThis allows users to install apps that provide a theme. If an app enables itself as app-theme in its `app.php`:\r\n```\r\n/** @var Theme\\ThemeService $themeService */\r\n$themeService = \\OC::$server->query('ThemeService');\r\n$themeService->setAppTheme('theme-owncloud');\r\n```\r\nthe app will be used as theme. If no app claims to be a theme, the existing logic will continue to work. That means, OC will look for the `theme` key in `config/config.php` and will use it. OC will still look for `themes/default` if no theme is configured.\r\n\r\n## Related Issue\r\n#20200 \r\n\r\n# Breaking changes\r\nThe documentation (https://doc.owncloud.org/server/9.0/developer_manual/core/theming.html) describes, that modifying an apps translation files would require a file in `theme/apps/app-name/l10n/language.js`. Modifying an apps template on the other hand would require a file in `theme/app-name/templates/template.php`.\r\n\r\nThis inconsistency has been removed. Templates will be located just like translations under `theme/apps/app-name/template/...`.\r\n\r\nTheming an App now requires the corresponding files to be located in an \"app\" folder.\r\n\r\n@DeepDiver1975, @PVince81, @butonic: what do you think about getting rid of this unnecessary complexity?\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/253721739","html_url":"https://github.com/owncloud/core/pull/26373#issuecomment-253721739","issue_url":"https://api.github.com/repos/owncloud/core/issues/26373","id":253721739,"user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T06:40:49Z","updated_at":"2016-10-14T06:40:49Z","body":"I'm the makefile there are targets to execute the tests. I guess there is composer call missing to install development dependencies"}}
{"actor":{"display_login":"DeepDiver1975"}}