{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/96","repository_url":"https://api.github.com/repos/Microsoft/vscode-tslint","labels_url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/96/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/96/events","html_url":"https://github.com/Microsoft/vscode-tslint/pull/96","id":179098143,"number":96,"title":"support of fixes provided by TSLint engine","user":{"login":"rlasjunies","id":1439791,"avatar_url":"https://avatars.githubusercontent.com/u/1439791?v=3","gravatar_id":"","url":"https://api.github.com/users/rlasjunies","html_url":"https://github.com/rlasjunies","followers_url":"https://api.github.com/users/rlasjunies/followers","following_url":"https://api.github.com/users/rlasjunies/following{/other_user}","gists_url":"https://api.github.com/users/rlasjunies/gists{/gist_id}","starred_url":"https://api.github.com/users/rlasjunies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlasjunies/subscriptions","organizations_url":"https://api.github.com/users/rlasjunies/orgs","repos_url":"https://api.github.com/users/rlasjunies/repos","events_url":"https://api.github.com/users/rlasjunies/events{/privacy}","received_events_url":"https://api.github.com/users/rlasjunies/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-25T17:38:47Z","updated_at":"2016-10-04T06:56:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-tslint/pulls/96","html_url":"https://github.com/Microsoft/vscode-tslint/pull/96","diff_url":"https://github.com/Microsoft/vscode-tslint/pull/96.diff","patch_url":"https://github.com/Microsoft/vscode-tslint/pull/96.patch"},"body":"Here is the proposal to support the fixes provided by TSLint engine. #84\r\n\r\nAlgo overview:\r\n- vscode-tslint still support it's own fix  \r\n- if fix is provided by TSLint engine, it's used  \r\n- a part when the flag `overrideTSLintFix` of a specific rule is `true`\r\n\r\nThis proposal should support \"migration\" while users are not yet using latest version of tslint and exceptional case where tslint does not have all the information to apply fixes.\r\n\r\nBy the way we can apply this code now and move step by step the current vscode autoFix to TSLint engine.\r\n\r\n@egamma, @JKillian, @alexeagle,\r\nLet me know what do you think about it!\r\n\r\nremark: the algo do not support the case when there are several innerReplacements. I do not see the use case and the impact on the current code seems not trivial. Can you provide examples?\r\n\r\n@egamma,\r\n I've modified a little bit the wordings in the code. autoFix => vscFix or tslFix depend on the source\r\n I've renamed the file AutoFix.ts to vscFix.ts. And cleaned fields not used in the algo (tsLintCode, autoFixMessage, ... )\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/comments/251308693","html_url":"https://github.com/Microsoft/vscode-tslint/pull/96#issuecomment-251308693","issue_url":"https://api.github.com/repos/Microsoft/vscode-tslint/issues/96","id":251308693,"user":{"login":"rlasjunies","id":1439791,"avatar_url":"https://avatars.githubusercontent.com/u/1439791?v=3","gravatar_id":"","url":"https://api.github.com/users/rlasjunies","html_url":"https://github.com/rlasjunies","followers_url":"https://api.github.com/users/rlasjunies/followers","following_url":"https://api.github.com/users/rlasjunies/following{/other_user}","gists_url":"https://api.github.com/users/rlasjunies/gists{/gist_id}","starred_url":"https://api.github.com/users/rlasjunies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlasjunies/subscriptions","organizations_url":"https://api.github.com/users/rlasjunies/orgs","repos_url":"https://api.github.com/users/rlasjunies/repos","events_url":"https://api.github.com/users/rlasjunies/events{/privacy}","received_events_url":"https://api.github.com/users/rlasjunies/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T06:56:48Z","updated_at":"2016-10-04T06:56:48Z","body":":-)\n\nmore than happy to participate!\n\nschuzz\n\nLe 4 oct. 2016 08:48, \"Erich Gamma\" <notifications@github.com> a écrit :\n\n> @rlasjunies <https://github.com/rlasjunies> I'll add this to the our\n> October iteration plan.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Microsoft/vscode-tslint/pull/96#issuecomment-251307310>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABX4L-kQRe1nohakPbp31phJc_ocud_Kks5qwfa3gaJpZM4KF9L3>\n> .\n>\n"}}
{"actor":{"display_login":"rlasjunies"}}