{"action":"closed","number":164,"pull_request":{"url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164","id":92780628,"html_url":"https://github.com/fastbuild/fastbuild/pull/164","diff_url":"https://github.com/fastbuild/fastbuild/pull/164.diff","patch_url":"https://github.com/fastbuild/fastbuild/pull/164.patch","issue_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/164","number":164,"state":"closed","locked":false,"title":"Fix AString::Replace taking extremly long time when \"from\" is an empty string","user":{"login":"dummyunit","id":2660083,"avatar_url":"https://avatars.githubusercontent.com/u/2660083?v=3","gravatar_id":"","url":"https://api.github.com/users/dummyunit","html_url":"https://github.com/dummyunit","followers_url":"https://api.github.com/users/dummyunit/followers","following_url":"https://api.github.com/users/dummyunit/following{/other_user}","gists_url":"https://api.github.com/users/dummyunit/gists{/gist_id}","starred_url":"https://api.github.com/users/dummyunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummyunit/subscriptions","organizations_url":"https://api.github.com/users/dummyunit/orgs","repos_url":"https://api.github.com/users/dummyunit/repos","events_url":"https://api.github.com/users/dummyunit/events{/privacy}","received_events_url":"https://api.github.com/users/dummyunit/received_events","type":"User","site_admin":false},"body":"When `AString::Replace` is called with empty `from` string, it never\r\nadvances `pos` pointer in the main loop and exits only when `maxReplaces`\r\nreaches 0, which takes 2^32 iterations.\r\nThis problem can be observed with this input (parsing takes very long\r\ntime):\r\n\r\n    .X = 'a'\r\n    .X - ''\r\n\r\nThis patch adds early exit to catch this case.","created_at":"2016-11-08T13:48:36Z","updated_at":"2016-11-12T16:14:52Z","closed_at":"2016-11-12T16:14:52Z","merged_at":"2016-11-12T16:14:52Z","merge_commit_sha":"71229ffd11e621197c86833dd5ff66b36e4a382a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164/commits","review_comments_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164/comments","review_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/164/comments","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/fc4e2728904956acc2948103f4fb368c661f09d0","head":{"label":"dummyunit:fix_empty_replace","ref":"fix_empty_replace","sha":"fc4e2728904956acc2948103f4fb368c661f09d0","user":{"login":"dummyunit","id":2660083,"avatar_url":"https://avatars.githubusercontent.com/u/2660083?v=3","gravatar_id":"","url":"https://api.github.com/users/dummyunit","html_url":"https://github.com/dummyunit","followers_url":"https://api.github.com/users/dummyunit/followers","following_url":"https://api.github.com/users/dummyunit/following{/other_user}","gists_url":"https://api.github.com/users/dummyunit/gists{/gist_id}","starred_url":"https://api.github.com/users/dummyunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummyunit/subscriptions","organizations_url":"https://api.github.com/users/dummyunit/orgs","repos_url":"https://api.github.com/users/dummyunit/repos","events_url":"https://api.github.com/users/dummyunit/events{/privacy}","received_events_url":"https://api.github.com/users/dummyunit/received_events","type":"User","site_admin":false},"repo":{"id":53078226,"name":"fastbuild","full_name":"dummyunit/fastbuild","owner":{"login":"dummyunit","id":2660083,"avatar_url":"https://avatars.githubusercontent.com/u/2660083?v=3","gravatar_id":"","url":"https://api.github.com/users/dummyunit","html_url":"https://github.com/dummyunit","followers_url":"https://api.github.com/users/dummyunit/followers","following_url":"https://api.github.com/users/dummyunit/following{/other_user}","gists_url":"https://api.github.com/users/dummyunit/gists{/gist_id}","starred_url":"https://api.github.com/users/dummyunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummyunit/subscriptions","organizations_url":"https://api.github.com/users/dummyunit/orgs","repos_url":"https://api.github.com/users/dummyunit/repos","events_url":"https://api.github.com/users/dummyunit/events{/privacy}","received_events_url":"https://api.github.com/users/dummyunit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dummyunit/fastbuild","description":null,"fork":true,"url":"https://api.github.com/repos/dummyunit/fastbuild","forks_url":"https://api.github.com/repos/dummyunit/fastbuild/forks","keys_url":"https://api.github.com/repos/dummyunit/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dummyunit/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dummyunit/fastbuild/teams","hooks_url":"https://api.github.com/repos/dummyunit/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/dummyunit/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/dummyunit/fastbuild/events","assignees_url":"https://api.github.com/repos/dummyunit/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/dummyunit/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/dummyunit/fastbuild/tags","blobs_url":"https://api.github.com/repos/dummyunit/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dummyunit/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dummyunit/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/dummyunit/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dummyunit/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/dummyunit/fastbuild/languages","stargazers_url":"https://api.github.com/repos/dummyunit/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/dummyunit/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/dummyunit/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/dummyunit/fastbuild/subscription","commits_url":"https://api.github.com/repos/dummyunit/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/dummyunit/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/dummyunit/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/dummyunit/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/dummyunit/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/dummyunit/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dummyunit/fastbuild/merges","archive_url":"https://api.github.com/repos/dummyunit/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dummyunit/fastbuild/downloads","issues_url":"https://api.github.com/repos/dummyunit/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/dummyunit/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/dummyunit/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/dummyunit/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dummyunit/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/dummyunit/fastbuild/releases{/id}","deployments_url":"https://api.github.com/repos/dummyunit/fastbuild/deployments","created_at":"2016-03-03T19:45:55Z","updated_at":"2016-03-03T19:45:56Z","pushed_at":"2016-11-08T13:47:15Z","git_url":"git://github.com/dummyunit/fastbuild.git","ssh_url":"git@github.com:dummyunit/fastbuild.git","clone_url":"https://github.com/dummyunit/fastbuild.git","svn_url":"https://github.com/dummyunit/fastbuild","homepage":null,"size":5242,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastbuild:dev","ref":"dev","sha":"50f31ec09fa370d19ab828c4668ed15cb647c359","user":{"login":"fastbuild","id":11589493,"avatar_url":"https://avatars.githubusercontent.com/u/11589493?v=3","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":32647696,"name":"fastbuild","full_name":"fastbuild/fastbuild","owner":{"login":"fastbuild","id":11589493,"avatar_url":"https://avatars.githubusercontent.com/u/11589493?v=3","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastbuild/fastbuild","description":"High performance build system supporting caching and network distribution.","fork":false,"url":"https://api.github.com/repos/fastbuild/fastbuild","forks_url":"https://api.github.com/repos/fastbuild/fastbuild/forks","keys_url":"https://api.github.com/repos/fastbuild/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastbuild/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastbuild/fastbuild/teams","hooks_url":"https://api.github.com/repos/fastbuild/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/fastbuild/fastbuild/events","assignees_url":"https://api.github.com/repos/fastbuild/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/fastbuild/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/fastbuild/fastbuild/tags","blobs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastbuild/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastbuild/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/fastbuild/fastbuild/languages","stargazers_url":"https://api.github.com/repos/fastbuild/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/fastbuild/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/fastbuild/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/fastbuild/fastbuild/subscription","commits_url":"https://api.github.com/repos/fastbuild/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastbuild/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastbuild/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/fastbuild/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastbuild/fastbuild/merges","archive_url":"https://api.github.com/repos/fastbuild/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastbuild/fastbuild/downloads","issues_url":"https://api.github.com/repos/fastbuild/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/fastbuild/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/fastbuild/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastbuild/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/fastbuild/fastbuild/releases{/id}","deployments_url":"https://api.github.com/repos/fastbuild/fastbuild/deployments","created_at":"2015-03-21T19:53:07Z","updated_at":"2016-11-12T06:52:15Z","pushed_at":"2016-11-12T16:14:52Z","git_url":"git://github.com/fastbuild/fastbuild.git","ssh_url":"git@github.com:fastbuild/fastbuild.git","clone_url":"https://github.com/fastbuild/fastbuild.git","svn_url":"https://github.com/fastbuild/fastbuild","homepage":"http://fastbuild.org","size":5293,"stargazers_count":155,"watchers_count":155,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":44,"forks":66,"open_issues":44,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164"},"html":{"href":"https://github.com/fastbuild/fastbuild/pull/164"},"issue":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/164"},"comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/fastbuild/fastbuild/statuses/fc4e2728904956acc2948103f4fb368c661f09d0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ffulin","id":11589403,"avatar_url":"https://avatars.githubusercontent.com/u/11589403?v=3","gravatar_id":"","url":"https://api.github.com/users/ffulin","html_url":"https://github.com/ffulin","followers_url":"https://api.github.com/users/ffulin/followers","following_url":"https://api.github.com/users/ffulin/following{/other_user}","gists_url":"https://api.github.com/users/ffulin/gists{/gist_id}","starred_url":"https://api.github.com/users/ffulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffulin/subscriptions","organizations_url":"https://api.github.com/users/ffulin/orgs","repos_url":"https://api.github.com/users/ffulin/repos","events_url":"https://api.github.com/users/ffulin/events{/privacy}","received_events_url":"https://api.github.com/users/ffulin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ffulin"}}