{"action":"closed","number":334,"pull_request":{"url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334","id":64690967,"html_url":"https://github.com/drwetter/testssl.sh/pull/334","diff_url":"https://github.com/drwetter/testssl.sh/pull/334.diff","patch_url":"https://github.com/drwetter/testssl.sh/pull/334.patch","issue_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/334","number":334,"state":"closed","locked":false,"title":"run_cipher_per_proto speedup","user":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars.githubusercontent.com/u/16493199?v=3","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"body":"This PR makes basically the same changes to run_cipher_per_proto() as I previously made to run_allciphers(). The main difference is that in this function, round 0 consists of a single call to \"$OPENSSL s_client\" with \"-cipher\" including all of the locally supported ciphers. The reason for the difference is that in run_allciphers() its saves time to assume the server supports at least one cipher suite. In the case of run_cipher_per_proto(), however, it is likely that the server will not support some protocols at all, so its usually faster to start with a single call to \"$OPENSSL s_client\" that tests whether the server supports the protocol at all.","created_at":"2016-03-30T20:24:43Z","updated_at":"2016-03-31T13:34:36Z","closed_at":"2016-03-31T13:34:36Z","merged_at":null,"merge_commit_sha":"94c52cae38aec1d8e3b4118abe09b97ddbec5080","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334/commits","review_comments_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334/comments","review_comment_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/334/comments","statuses_url":"https://api.github.com/repos/drwetter/testssl.sh/statuses/528f5ee779c2504f0294b34a875d06fa107e2135","head":{"label":"dcooper16:run_cipher_per_proto_speedup","ref":"run_cipher_per_proto_speedup","sha":"528f5ee779c2504f0294b34a875d06fa107e2135","user":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars.githubusercontent.com/u/16493199?v=3","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"repo":{"id":50522989,"name":"testssl.sh","full_name":"dcooper16/testssl.sh","owner":{"login":"dcooper16","id":16493199,"avatar_url":"https://avatars.githubusercontent.com/u/16493199?v=3","gravatar_id":"","url":"https://api.github.com/users/dcooper16","html_url":"https://github.com/dcooper16","followers_url":"https://api.github.com/users/dcooper16/followers","following_url":"https://api.github.com/users/dcooper16/following{/other_user}","gists_url":"https://api.github.com/users/dcooper16/gists{/gist_id}","starred_url":"https://api.github.com/users/dcooper16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcooper16/subscriptions","organizations_url":"https://api.github.com/users/dcooper16/orgs","repos_url":"https://api.github.com/users/dcooper16/repos","events_url":"https://api.github.com/users/dcooper16/events{/privacy}","received_events_url":"https://api.github.com/users/dcooper16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcooper16/testssl.sh","description":"Testing TLS/SSL encryption","fork":true,"url":"https://api.github.com/repos/dcooper16/testssl.sh","forks_url":"https://api.github.com/repos/dcooper16/testssl.sh/forks","keys_url":"https://api.github.com/repos/dcooper16/testssl.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcooper16/testssl.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcooper16/testssl.sh/teams","hooks_url":"https://api.github.com/repos/dcooper16/testssl.sh/hooks","issue_events_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues/events{/number}","events_url":"https://api.github.com/repos/dcooper16/testssl.sh/events","assignees_url":"https://api.github.com/repos/dcooper16/testssl.sh/assignees{/user}","branches_url":"https://api.github.com/repos/dcooper16/testssl.sh/branches{/branch}","tags_url":"https://api.github.com/repos/dcooper16/testssl.sh/tags","blobs_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcooper16/testssl.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/dcooper16/testssl.sh/languages","stargazers_url":"https://api.github.com/repos/dcooper16/testssl.sh/stargazers","contributors_url":"https://api.github.com/repos/dcooper16/testssl.sh/contributors","subscribers_url":"https://api.github.com/repos/dcooper16/testssl.sh/subscribers","subscription_url":"https://api.github.com/repos/dcooper16/testssl.sh/subscription","commits_url":"https://api.github.com/repos/dcooper16/testssl.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcooper16/testssl.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcooper16/testssl.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcooper16/testssl.sh/contents/{+path}","compare_url":"https://api.github.com/repos/dcooper16/testssl.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcooper16/testssl.sh/merges","archive_url":"https://api.github.com/repos/dcooper16/testssl.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcooper16/testssl.sh/downloads","issues_url":"https://api.github.com/repos/dcooper16/testssl.sh/issues{/number}","pulls_url":"https://api.github.com/repos/dcooper16/testssl.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/dcooper16/testssl.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/dcooper16/testssl.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcooper16/testssl.sh/labels{/name}","releases_url":"https://api.github.com/repos/dcooper16/testssl.sh/releases{/id}","deployments_url":"https://api.github.com/repos/dcooper16/testssl.sh/deployments","created_at":"2016-01-27T17:02:00Z","updated_at":"2016-01-27T17:02:02Z","pushed_at":"2016-03-31T13:34:36Z","git_url":"git://github.com/dcooper16/testssl.sh.git","ssh_url":"git@github.com:dcooper16/testssl.sh.git","clone_url":"https://github.com/dcooper16/testssl.sh.git","svn_url":"https://github.com/dcooper16/testssl.sh","homepage":null,"size":52304,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drwetter:master","ref":"master","sha":"62f34cfda2fcd2fce9a075b5fbe8b31d847da246","user":{"login":"drwetter","id":8036727,"avatar_url":"https://avatars.githubusercontent.com/u/8036727?v=3","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"repo":{"id":21385916,"name":"testssl.sh","full_name":"drwetter/testssl.sh","owner":{"login":"drwetter","id":8036727,"avatar_url":"https://avatars.githubusercontent.com/u/8036727?v=3","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drwetter/testssl.sh","description":"Testing TLS/SSL encryption","fork":false,"url":"https://api.github.com/repos/drwetter/testssl.sh","forks_url":"https://api.github.com/repos/drwetter/testssl.sh/forks","keys_url":"https://api.github.com/repos/drwetter/testssl.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drwetter/testssl.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drwetter/testssl.sh/teams","hooks_url":"https://api.github.com/repos/drwetter/testssl.sh/hooks","issue_events_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/events{/number}","events_url":"https://api.github.com/repos/drwetter/testssl.sh/events","assignees_url":"https://api.github.com/repos/drwetter/testssl.sh/assignees{/user}","branches_url":"https://api.github.com/repos/drwetter/testssl.sh/branches{/branch}","tags_url":"https://api.github.com/repos/drwetter/testssl.sh/tags","blobs_url":"https://api.github.com/repos/drwetter/testssl.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drwetter/testssl.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drwetter/testssl.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/drwetter/testssl.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drwetter/testssl.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/drwetter/testssl.sh/languages","stargazers_url":"https://api.github.com/repos/drwetter/testssl.sh/stargazers","contributors_url":"https://api.github.com/repos/drwetter/testssl.sh/contributors","subscribers_url":"https://api.github.com/repos/drwetter/testssl.sh/subscribers","subscription_url":"https://api.github.com/repos/drwetter/testssl.sh/subscription","commits_url":"https://api.github.com/repos/drwetter/testssl.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/drwetter/testssl.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/drwetter/testssl.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/drwetter/testssl.sh/contents/{+path}","compare_url":"https://api.github.com/repos/drwetter/testssl.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drwetter/testssl.sh/merges","archive_url":"https://api.github.com/repos/drwetter/testssl.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drwetter/testssl.sh/downloads","issues_url":"https://api.github.com/repos/drwetter/testssl.sh/issues{/number}","pulls_url":"https://api.github.com/repos/drwetter/testssl.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/drwetter/testssl.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/drwetter/testssl.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drwetter/testssl.sh/labels{/name}","releases_url":"https://api.github.com/repos/drwetter/testssl.sh/releases{/id}","deployments_url":"https://api.github.com/repos/drwetter/testssl.sh/deployments","created_at":"2014-07-01T11:55:26Z","updated_at":"2016-03-31T11:45:32Z","pushed_at":"2016-03-30T21:28:49Z","git_url":"git://github.com/drwetter/testssl.sh.git","ssh_url":"git@github.com:drwetter/testssl.sh.git","clone_url":"https://github.com/drwetter/testssl.sh.git","svn_url":"https://github.com/drwetter/testssl.sh","homepage":null,"size":53202,"stargazers_count":649,"watchers_count":649,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":65,"forks":107,"open_issues":65,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334"},"html":{"href":"https://github.com/drwetter/testssl.sh/pull/334"},"issue":{"href":"https://api.github.com/repos/drwetter/testssl.sh/issues/334"},"comments":{"href":"https://api.github.com/repos/drwetter/testssl.sh/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drwetter/testssl.sh/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/drwetter/testssl.sh/statuses/528f5ee779c2504f0294b34a875d06fa107e2135"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":85,"deletions":34,"changed_files":1}}