{"action":"created","comment":{"url":"https://api.github.com/repos/cargomedia/cm/pulls/comments/71292280","id":71292280,"diff_hunk":"@@ -278,6 +278,17 @@ public function getQuery() {\n     }\n \n     /**\n+     * @return array\n+     */\n+    public function findQuery() {\n+        try {\n+            return $this->getQuery();\n+        } catch (CM_Exception_Invalid $e) {","path":"library/CM/Http/Request/Abstract.php","position":9,"original_position":9,"commit_id":"744e1018ee36e8049adf522b2a79fd040efe707c","original_commit_id":"744e1018ee36e8049adf522b2a79fd040efe707c","user":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"body":"Nono, I rather meant that `findQuery` should return `[]|null`, while `getQuery` should return `[]` or throw.\r\n\r\nI thought that we could use `Post::getQuery` code for new `Post::findQuery`, but instead of throwing we could return `null` - as it's invalid query.\r\nNew `getQuery` would be simple proxy for `findQuery` with option throw when query is null.","created_at":"2016-07-19T08:32:15Z","updated_at":"2016-07-19T08:32:15Z","html_url":"https://github.com/cargomedia/cm/pull/2253#discussion_r71292280","pull_request_url":"https://api.github.com/repos/cargomedia/cm/pulls/2253","_links":{"self":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/comments/71292280"},"html":{"href":"https://github.com/cargomedia/cm/pull/2253#discussion_r71292280"},"pull_request":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/2253"}}},"pull_request":{"url":"https://api.github.com/repos/cargomedia/cm/pulls/2253","id":76920063,"html_url":"https://github.com/cargomedia/cm/pull/2253","diff_url":"https://github.com/cargomedia/cm/pull/2253.diff","patch_url":"https://github.com/cargomedia/cm/pull/2253.patch","issue_url":"https://api.github.com/repos/cargomedia/cm/issues/2253","number":2253,"state":"open","locked":false,"title":"Logger: pass \"httpRequest.query\" to Loggly","user":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"body":"Currently in Loggly we have the following keys in `httpRequest`: ip, hostname, uri, referer, useragent, method.\r\n\r\nIt would be good to also have `query`, which allows to identify for example what ajax request was sent. This information is available in mongodb/admin.\r\n\r\n@fvovan @tomaszdurka  wdyt? If you agree, could you also open a PR on *guides*?","created_at":"2016-07-11T09:02:12Z","updated_at":"2016-07-19T08:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d8b8bf5b3f0a78a3c81ec376480f58337b262e3","assignee":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"assignees":[{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cargomedia/cm/pulls/2253/commits","review_comments_url":"https://api.github.com/repos/cargomedia/cm/pulls/2253/comments","review_comment_url":"https://api.github.com/repos/cargomedia/cm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cargomedia/cm/issues/2253/comments","statuses_url":"https://api.github.com/repos/cargomedia/cm/statuses/744e1018ee36e8049adf522b2a79fd040efe707c","head":{"label":"fvovan:issue-2253","ref":"issue-2253","sha":"744e1018ee36e8049adf522b2a79fd040efe707c","user":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"repo":{"id":33868650,"name":"CM","full_name":"fvovan/CM","owner":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fvovan/CM","description":"CM web application framework","fork":true,"url":"https://api.github.com/repos/fvovan/CM","forks_url":"https://api.github.com/repos/fvovan/CM/forks","keys_url":"https://api.github.com/repos/fvovan/CM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvovan/CM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvovan/CM/teams","hooks_url":"https://api.github.com/repos/fvovan/CM/hooks","issue_events_url":"https://api.github.com/repos/fvovan/CM/issues/events{/number}","events_url":"https://api.github.com/repos/fvovan/CM/events","assignees_url":"https://api.github.com/repos/fvovan/CM/assignees{/user}","branches_url":"https://api.github.com/repos/fvovan/CM/branches{/branch}","tags_url":"https://api.github.com/repos/fvovan/CM/tags","blobs_url":"https://api.github.com/repos/fvovan/CM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvovan/CM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvovan/CM/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvovan/CM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvovan/CM/statuses/{sha}","languages_url":"https://api.github.com/repos/fvovan/CM/languages","stargazers_url":"https://api.github.com/repos/fvovan/CM/stargazers","contributors_url":"https://api.github.com/repos/fvovan/CM/contributors","subscribers_url":"https://api.github.com/repos/fvovan/CM/subscribers","subscription_url":"https://api.github.com/repos/fvovan/CM/subscription","commits_url":"https://api.github.com/repos/fvovan/CM/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvovan/CM/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvovan/CM/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvovan/CM/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvovan/CM/contents/{+path}","compare_url":"https://api.github.com/repos/fvovan/CM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvovan/CM/merges","archive_url":"https://api.github.com/repos/fvovan/CM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvovan/CM/downloads","issues_url":"https://api.github.com/repos/fvovan/CM/issues{/number}","pulls_url":"https://api.github.com/repos/fvovan/CM/pulls{/number}","milestones_url":"https://api.github.com/repos/fvovan/CM/milestones{/number}","notifications_url":"https://api.github.com/repos/fvovan/CM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvovan/CM/labels{/name}","releases_url":"https://api.github.com/repos/fvovan/CM/releases{/id}","deployments_url":"https://api.github.com/repos/fvovan/CM/deployments","created_at":"2015-04-13T12:59:39Z","updated_at":"2015-04-13T12:59:42Z","pushed_at":"2016-07-18T15:30:00Z","git_url":"git://github.com/fvovan/CM.git","ssh_url":"git@github.com:fvovan/CM.git","clone_url":"https://github.com/fvovan/CM.git","svn_url":"https://github.com/fvovan/CM","homepage":"","size":31779,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cargomedia:master","ref":"master","sha":"04648e22592bf5ac192a7e462470a47f01120ff2","user":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":7134007,"name":"cm","full_name":"cargomedia/cm","owner":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cargomedia/cm","description":"CM web application framework","fork":false,"url":"https://api.github.com/repos/cargomedia/cm","forks_url":"https://api.github.com/repos/cargomedia/cm/forks","keys_url":"https://api.github.com/repos/cargomedia/cm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cargomedia/cm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cargomedia/cm/teams","hooks_url":"https://api.github.com/repos/cargomedia/cm/hooks","issue_events_url":"https://api.github.com/repos/cargomedia/cm/issues/events{/number}","events_url":"https://api.github.com/repos/cargomedia/cm/events","assignees_url":"https://api.github.com/repos/cargomedia/cm/assignees{/user}","branches_url":"https://api.github.com/repos/cargomedia/cm/branches{/branch}","tags_url":"https://api.github.com/repos/cargomedia/cm/tags","blobs_url":"https://api.github.com/repos/cargomedia/cm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cargomedia/cm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cargomedia/cm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cargomedia/cm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cargomedia/cm/statuses/{sha}","languages_url":"https://api.github.com/repos/cargomedia/cm/languages","stargazers_url":"https://api.github.com/repos/cargomedia/cm/stargazers","contributors_url":"https://api.github.com/repos/cargomedia/cm/contributors","subscribers_url":"https://api.github.com/repos/cargomedia/cm/subscribers","subscription_url":"https://api.github.com/repos/cargomedia/cm/subscription","commits_url":"https://api.github.com/repos/cargomedia/cm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cargomedia/cm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cargomedia/cm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cargomedia/cm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cargomedia/cm/contents/{+path}","compare_url":"https://api.github.com/repos/cargomedia/cm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cargomedia/cm/merges","archive_url":"https://api.github.com/repos/cargomedia/cm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cargomedia/cm/downloads","issues_url":"https://api.github.com/repos/cargomedia/cm/issues{/number}","pulls_url":"https://api.github.com/repos/cargomedia/cm/pulls{/number}","milestones_url":"https://api.github.com/repos/cargomedia/cm/milestones{/number}","notifications_url":"https://api.github.com/repos/cargomedia/cm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cargomedia/cm/labels{/name}","releases_url":"https://api.github.com/repos/cargomedia/cm/releases{/id}","deployments_url":"https://api.github.com/repos/cargomedia/cm/deployments","created_at":"2012-12-12T17:00:30Z","updated_at":"2016-01-12T14:23:36Z","pushed_at":"2016-07-19T08:31:45Z","git_url":"git://github.com/cargomedia/cm.git","ssh_url":"git@github.com:cargomedia/cm.git","clone_url":"https://github.com/cargomedia/cm.git","svn_url":"https://github.com/cargomedia/cm","homepage":"","size":32715,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":30,"forks":21,"open_issues":30,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/2253"},"html":{"href":"https://github.com/cargomedia/cm/pull/2253"},"issue":{"href":"https://api.github.com/repos/cargomedia/cm/issues/2253"},"comments":{"href":"https://api.github.com/repos/cargomedia/cm/issues/2253/comments"},"review_comments":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/2253/comments"},"review_comment":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cargomedia/cm/pulls/2253/commits"},"statuses":{"href":"https://api.github.com/repos/cargomedia/cm/statuses/744e1018ee36e8049adf522b2a79fd040efe707c"}}}}
{"actor":{"display_login":"tomaszdurka"}}