{"action":"created","comment":{"url":"https://api.github.com/repos/raintank/metrictank/pulls/comments/87890107","pull_request_review_id":8482958,"id":87890107,"diff_hunk":"@@ -11,6 +11,7 @@ test:\n     - cd $IMPORTPATH && go test -v -race $(go list ./... | grep -v /vendor/)\n     - cd $IMPORTPATH && go vet $(go list ./... | grep -v /vendor/)\n     - cd $IMPORTPATH && scripts/end2end_test.sh\n+    - cd $IMPORTPATH && go test -run='^$' -bench=. $(go list ./... | grep -v /vendor/)","path":"circle.yml","position":4,"original_position":4,"commit_id":"c7eeaa78b5e83f9bb92649657eb6cef71c8d1c30","original_commit_id":"c7eeaa78b5e83f9bb92649657eb6cef71c8d1c30","user":{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false},"body":"end2end_test tears down the docker containers when it finishes so all of the benchmark tests that have an external dependency will fail","created_at":"2016-11-14T20:53:39Z","updated_at":"2016-11-14T20:53:48Z","html_url":"https://github.com/raintank/metrictank/pull/386#discussion_r87890107","pull_request_url":"https://api.github.com/repos/raintank/metrictank/pulls/386","_links":{"self":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/comments/87890107"},"html":{"href":"https://github.com/raintank/metrictank/pull/386#discussion_r87890107"},"pull_request":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/386"}}},"pull_request":{"url":"https://api.github.com/repos/raintank/metrictank/pulls/386","id":93610254,"html_url":"https://github.com/raintank/metrictank/pull/386","diff_url":"https://github.com/raintank/metrictank/pull/386.diff","patch_url":"https://github.com/raintank/metrictank/pull/386.patch","issue_url":"https://api.github.com/repos/raintank/metrictank/issues/386","number":386,"state":"open","locked":false,"title":"Fix bench","user":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"body":"@woodsaj can we merge this before the http refactor? (and then rebase httpRefactor). currently in master and httpRefactor the benchmarks are broken. i'ld like them to work before and after httpRefactor, so we can compare easily","created_at":"2016-11-14T17:28:02Z","updated_at":"2016-11-14T20:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bef3a55321ea449a77dfe371c1a688d08df2fcf1","assignee":{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/raintank/metrictank/pulls/386/commits","review_comments_url":"https://api.github.com/repos/raintank/metrictank/pulls/386/comments","review_comment_url":"https://api.github.com/repos/raintank/metrictank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raintank/metrictank/issues/386/comments","statuses_url":"https://api.github.com/repos/raintank/metrictank/statuses/c7eeaa78b5e83f9bb92649657eb6cef71c8d1c30","head":{"label":"raintank:fix-bench","ref":"fix-bench","sha":"c7eeaa78b5e83f9bb92649657eb6cef71c8d1c30","user":{"login":"raintank","id":8512431,"avatar_url":"https://avatars.githubusercontent.com/u/8512431?v=3","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"repo":{"id":30401116,"name":"metrictank","full_name":"raintank/metrictank","owner":{"login":"raintank","id":8512431,"avatar_url":"https://avatars.githubusercontent.com/u/8512431?v=3","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raintank/metrictank","description":"Cassandra-backed, metrics2.0 based, multi-tenant timeseries database for Graphite and friends","fork":false,"url":"https://api.github.com/repos/raintank/metrictank","forks_url":"https://api.github.com/repos/raintank/metrictank/forks","keys_url":"https://api.github.com/repos/raintank/metrictank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raintank/metrictank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raintank/metrictank/teams","hooks_url":"https://api.github.com/repos/raintank/metrictank/hooks","issue_events_url":"https://api.github.com/repos/raintank/metrictank/issues/events{/number}","events_url":"https://api.github.com/repos/raintank/metrictank/events","assignees_url":"https://api.github.com/repos/raintank/metrictank/assignees{/user}","branches_url":"https://api.github.com/repos/raintank/metrictank/branches{/branch}","tags_url":"https://api.github.com/repos/raintank/metrictank/tags","blobs_url":"https://api.github.com/repos/raintank/metrictank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raintank/metrictank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raintank/metrictank/git/refs{/sha}","trees_url":"https://api.github.com/repos/raintank/metrictank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raintank/metrictank/statuses/{sha}","languages_url":"https://api.github.com/repos/raintank/metrictank/languages","stargazers_url":"https://api.github.com/repos/raintank/metrictank/stargazers","contributors_url":"https://api.github.com/repos/raintank/metrictank/contributors","subscribers_url":"https://api.github.com/repos/raintank/metrictank/subscribers","subscription_url":"https://api.github.com/repos/raintank/metrictank/subscription","commits_url":"https://api.github.com/repos/raintank/metrictank/commits{/sha}","git_commits_url":"https://api.github.com/repos/raintank/metrictank/git/commits{/sha}","comments_url":"https://api.github.com/repos/raintank/metrictank/comments{/number}","issue_comment_url":"https://api.github.com/repos/raintank/metrictank/issues/comments{/number}","contents_url":"https://api.github.com/repos/raintank/metrictank/contents/{+path}","compare_url":"https://api.github.com/repos/raintank/metrictank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raintank/metrictank/merges","archive_url":"https://api.github.com/repos/raintank/metrictank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raintank/metrictank/downloads","issues_url":"https://api.github.com/repos/raintank/metrictank/issues{/number}","pulls_url":"https://api.github.com/repos/raintank/metrictank/pulls{/number}","milestones_url":"https://api.github.com/repos/raintank/metrictank/milestones{/number}","notifications_url":"https://api.github.com/repos/raintank/metrictank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raintank/metrictank/labels{/name}","releases_url":"https://api.github.com/repos/raintank/metrictank/releases{/id}","deployments_url":"https://api.github.com/repos/raintank/metrictank/deployments","created_at":"2015-02-06T07:44:12Z","updated_at":"2016-11-13T09:32:28Z","pushed_at":"2016-11-14T19:56:04Z","git_url":"git://github.com/raintank/metrictank.git","ssh_url":"git@github.com:raintank/metrictank.git","clone_url":"https://github.com/raintank/metrictank.git","svn_url":"https://github.com/raintank/metrictank","homepage":"","size":9142,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":76,"forks":10,"open_issues":76,"watchers":73,"default_branch":"master"}},"base":{"label":"raintank:master","ref":"master","sha":"000a494c968d0290d33acbb3234a7973560123cf","user":{"login":"raintank","id":8512431,"avatar_url":"https://avatars.githubusercontent.com/u/8512431?v=3","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"repo":{"id":30401116,"name":"metrictank","full_name":"raintank/metrictank","owner":{"login":"raintank","id":8512431,"avatar_url":"https://avatars.githubusercontent.com/u/8512431?v=3","gravatar_id":"","url":"https://api.github.com/users/raintank","html_url":"https://github.com/raintank","followers_url":"https://api.github.com/users/raintank/followers","following_url":"https://api.github.com/users/raintank/following{/other_user}","gists_url":"https://api.github.com/users/raintank/gists{/gist_id}","starred_url":"https://api.github.com/users/raintank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raintank/subscriptions","organizations_url":"https://api.github.com/users/raintank/orgs","repos_url":"https://api.github.com/users/raintank/repos","events_url":"https://api.github.com/users/raintank/events{/privacy}","received_events_url":"https://api.github.com/users/raintank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raintank/metrictank","description":"Cassandra-backed, metrics2.0 based, multi-tenant timeseries database for Graphite and friends","fork":false,"url":"https://api.github.com/repos/raintank/metrictank","forks_url":"https://api.github.com/repos/raintank/metrictank/forks","keys_url":"https://api.github.com/repos/raintank/metrictank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raintank/metrictank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raintank/metrictank/teams","hooks_url":"https://api.github.com/repos/raintank/metrictank/hooks","issue_events_url":"https://api.github.com/repos/raintank/metrictank/issues/events{/number}","events_url":"https://api.github.com/repos/raintank/metrictank/events","assignees_url":"https://api.github.com/repos/raintank/metrictank/assignees{/user}","branches_url":"https://api.github.com/repos/raintank/metrictank/branches{/branch}","tags_url":"https://api.github.com/repos/raintank/metrictank/tags","blobs_url":"https://api.github.com/repos/raintank/metrictank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raintank/metrictank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raintank/metrictank/git/refs{/sha}","trees_url":"https://api.github.com/repos/raintank/metrictank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raintank/metrictank/statuses/{sha}","languages_url":"https://api.github.com/repos/raintank/metrictank/languages","stargazers_url":"https://api.github.com/repos/raintank/metrictank/stargazers","contributors_url":"https://api.github.com/repos/raintank/metrictank/contributors","subscribers_url":"https://api.github.com/repos/raintank/metrictank/subscribers","subscription_url":"https://api.github.com/repos/raintank/metrictank/subscription","commits_url":"https://api.github.com/repos/raintank/metrictank/commits{/sha}","git_commits_url":"https://api.github.com/repos/raintank/metrictank/git/commits{/sha}","comments_url":"https://api.github.com/repos/raintank/metrictank/comments{/number}","issue_comment_url":"https://api.github.com/repos/raintank/metrictank/issues/comments{/number}","contents_url":"https://api.github.com/repos/raintank/metrictank/contents/{+path}","compare_url":"https://api.github.com/repos/raintank/metrictank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raintank/metrictank/merges","archive_url":"https://api.github.com/repos/raintank/metrictank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raintank/metrictank/downloads","issues_url":"https://api.github.com/repos/raintank/metrictank/issues{/number}","pulls_url":"https://api.github.com/repos/raintank/metrictank/pulls{/number}","milestones_url":"https://api.github.com/repos/raintank/metrictank/milestones{/number}","notifications_url":"https://api.github.com/repos/raintank/metrictank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raintank/metrictank/labels{/name}","releases_url":"https://api.github.com/repos/raintank/metrictank/releases{/id}","deployments_url":"https://api.github.com/repos/raintank/metrictank/deployments","created_at":"2015-02-06T07:44:12Z","updated_at":"2016-11-13T09:32:28Z","pushed_at":"2016-11-14T19:56:04Z","git_url":"git://github.com/raintank/metrictank.git","ssh_url":"git@github.com:raintank/metrictank.git","clone_url":"https://github.com/raintank/metrictank.git","svn_url":"https://github.com/raintank/metrictank","homepage":"","size":9142,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":76,"forks":10,"open_issues":76,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/386"},"html":{"href":"https://github.com/raintank/metrictank/pull/386"},"issue":{"href":"https://api.github.com/repos/raintank/metrictank/issues/386"},"comments":{"href":"https://api.github.com/repos/raintank/metrictank/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raintank/metrictank/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/raintank/metrictank/statuses/c7eeaa78b5e83f9bb92649657eb6cef71c8d1c30"}}}}
{"actor":{"display_login":"woodsaj"}}