{"action":"created","issue":{"url":"https://api.github.com/repos/juju/juju/issues/5282","repository_url":"https://api.github.com/repos/juju/juju","labels_url":"https://api.github.com/repos/juju/juju/issues/5282/labels{/name}","comments_url":"https://api.github.com/repos/juju/juju/issues/5282/comments","events_url":"https://api.github.com/repos/juju/juju/issues/5282/events","html_url":"https://github.com/juju/juju/pull/5282","id":151157262,"number":5282,"title":"Don't parse stderr when checking output from jujud version","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-26T14:56:06Z","updated_at":"2016-04-26T19:24:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/5282","html_url":"https://github.com/juju/juju/pull/5282","diff_url":"https://github.com/juju/juju/pull/5282.diff","patch_url":"https://github.com/juju/juju/pull/5282.patch"},"body":"This PR changes how we read the output from 'jujud version' such that we ignore what it outputs for stderr.\nWithout this change, any logging or debug printing that gets added early in the stack will cause upload-tools\nto fail, because it tries to parse the logging output to stderr as well as the valid version number output\nto stdout.  Given the vast quantity of code we run on startup, even just to get to outputting the version,\nthis leaves a lot of code that simply can't have logging added to it, which is bad. This fixes that problem.\n\n(Review request: http://reviews.vapour.ws/r/4709/)"},"comment":{"url":"https://api.github.com/repos/juju/juju/issues/comments/214858378","html_url":"https://github.com/juju/juju/pull/5282#issuecomment-214858378","issue_url":"https://api.github.com/repos/juju/juju/issues/5282","id":214858378,"user":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T19:24:45Z","updated_at":"2016-04-26T19:24:45Z","body":"Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju"}}