{"push_id":1212938101,"size":1,"distinct_size":1,"ref":"refs/heads/GtkApplicationfromNaut_WIP2","head":"df6613d10be8721fa197cccfbe362a31e494d3d6","before":"859d855e7abbe8ab14eaa923a756a6169bcbb82d","commits":[{"sha":"df6613d10be8721fa197cccfbe362a31e494d3d6","author":{"name":"lukefromdc","email":"28744ca2c5fb5c59c5b140d44dca490756af2852@hushmail.com"},"message":"Fix command line help broken by prev commits\n\nStop caja --help from crashing caja, make it actually display the help. Had to make all of it one screen and treat it as a series of strings. The normal help invocation from the command line (before this) works fine if Caja is not running, but if it is it takes over the thread and causes caja to exit. Disable that help option, redirect the command line invocation to display this help screen by other means. \r\n\r\nNote that the session management help is excluded until we know what the session manager is going to do when this is all finished, then it can be added back with the appropriate edits. A kludge but the only way i could save the command line help given GNOME's fix came nearly six months after the commit sequence used to port to GtkApplication.\r\n\r\nhttps://github.com/GNOME/nautilus/commit/5c949fffcb0de62fd5375f546fa94dd50ec7f86f\r\napplication: rewrite GApplication command line handling\r\n\r\nUnfortunately Nautius 3.0 got all the way out the door with both this issue and another bug (that now also affects caja), both listed below, GNOME's fix thus ended up being to a radically different version of nautilus-application.c and I was unable to apply it even by hand to our version based not on May 2011 but December 2010 Nautilus code.\r\n\r\nhttps://bugzilla.gnome.org/show_bug.cgi?id=637157 (in Nautilus 3.0). \r\nInvoking \"nautilus --help\" in terminal crashes existing Nautilus instance\r\n\r\nhttps://bugzilla.gnome.org/show_bug.cgi?id=649336\r\nInvoking  \"nautilus .\" from any directory opens /home directory \r\n\r\nGNOME's basic description of the first bug and their fix is this:\r\nThe  handling of the command line was done in the remote process.\r\nThus an unknown command like --help would kill the main thread as it was processed remotely.\r\nThus use the local_command_line handler to process locally the command line and  ignore unknown commands and help request remotely.\r\nIn the process fix a bug with the application quit, that is it was using release twice but the refcount could increment more than twice thus an invocation of quit would fail. Use application quit_mainloop instead for the non exit with last window use case.","distinct":true,"url":"https://api.github.com/repos/lukefromdc/caja/commits/df6613d10be8721fa197cccfbe362a31e494d3d6"}]}
{"actor":{"display_login":"lukefromdc"}}