{"action":"created","issue":{"url":"https://api.github.com/repos/tangrams/tangram-es/issues/522","repository_url":"https://api.github.com/repos/tangrams/tangram-es","labels_url":"https://api.github.com/repos/tangrams/tangram-es/issues/522/labels{/name}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/issues/522/comments","events_url":"https://api.github.com/repos/tangrams/tangram-es/issues/522/events","html_url":"https://github.com/tangrams/tangram-es/pull/522","id":131416953,"number":522,"title":"TileDataSink","user":{"login":"hjanetzek","id":1747,"avatar_url":"https://avatars.githubusercontent.com/u/1747?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanetzek","html_url":"https://github.com/hjanetzek","followers_url":"https://api.github.com/users/hjanetzek/followers","following_url":"https://api.github.com/users/hjanetzek/following{/other_user}","gists_url":"https://api.github.com/users/hjanetzek/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanetzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanetzek/subscriptions","organizations_url":"https://api.github.com/users/hjanetzek/orgs","repos_url":"https://api.github.com/users/hjanetzek/repos","events_url":"https://api.github.com/users/hjanetzek/events{/privacy}","received_events_url":"https://api.github.com/users/hjanetzek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tangrams/tangram-es/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/tangrams/tangram-es/labels/ready%20for%20review","name":"ready for review","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"blair1618","id":3371850,"avatar_url":"https://avatars.githubusercontent.com/u/3371850?v=3","gravatar_id":"","url":"https://api.github.com/users/blair1618","html_url":"https://github.com/blair1618","followers_url":"https://api.github.com/users/blair1618/followers","following_url":"https://api.github.com/users/blair1618/following{/other_user}","gists_url":"https://api.github.com/users/blair1618/gists{/gist_id}","starred_url":"https://api.github.com/users/blair1618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blair1618/subscriptions","organizations_url":"https://api.github.com/users/blair1618/orgs","repos_url":"https://api.github.com/users/blair1618/repos","events_url":"https://api.github.com/users/blair1618/events{/privacy}","received_events_url":"https://api.github.com/users/blair1618/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-04T17:23:25Z","updated_at":"2016-02-25T19:12:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tangrams/tangram-es/pulls/522","html_url":"https://github.com/tangrams/tangram-es/pull/522","diff_url":"https://github.com/tangrams/tangram-es/pull/522.diff","patch_url":"https://github.com/tangrams/tangram-es/pull/522.patch"},"body":"Replacing TileData container with TileDataSink callbacks. With this a single Feature object can be reused for tile creation. Unmatched layers can be skipped directly, unmatched features (by props and geometry type) can be skipped without extracting the geometry. "},"comment":{"url":"https://api.github.com/repos/tangrams/tangram-es/issues/comments/188935678","html_url":"https://github.com/tangrams/tangram-es/pull/522#issuecomment-188935678","issue_url":"https://api.github.com/repos/tangrams/tangram-es/issues/522","id":188935678,"user":{"login":"blair1618","id":3371850,"avatar_url":"https://avatars.githubusercontent.com/u/3371850?v=3","gravatar_id":"","url":"https://api.github.com/users/blair1618","html_url":"https://github.com/blair1618","followers_url":"https://api.github.com/users/blair1618/followers","following_url":"https://api.github.com/users/blair1618/following{/other_user}","gists_url":"https://api.github.com/users/blair1618/gists{/gist_id}","starred_url":"https://api.github.com/users/blair1618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blair1618/subscriptions","organizations_url":"https://api.github.com/users/blair1618/orgs","repos_url":"https://api.github.com/users/blair1618/repos","events_url":"https://api.github.com/users/blair1618/events{/privacy}","received_events_url":"https://api.github.com/users/blair1618/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T19:12:14Z","updated_at":"2016-02-25T19:12:14Z","body":"I've been profiling this change on an iPhone and I only see rather modest improvements in load times:\r\n```\r\nTime spent in TileWorker::run loading Manhattan at zoom 16 with the eraser-map scene,\r\naverage of 3 runs\r\n\r\nMVT\r\nmaster:         1050ms\r\ntile-data-sink: 990ms\r\n\r\nGeoJSON\r\nmaster:         1140ms\r\ntile-data-sink: 1170ms\r\n\r\nTopoJSON\r\nmaster:         1130ms\r\ntile-data-sink: 1150ms\r\n\r\nTime spent in TileWorker::run loading Manhattan at zoom 16 with the default testing scene,\r\naverage of 3 runs\r\n\r\nMVT\r\nmaster:         1000ms\r\ntile-data-sink: 895ms\r\n\r\nGeoJSON\r\nmaster:         1055ms\r\ntile-data-sink: 1060ms\r\n\r\nTopoJSON\r\nmaster:         1005ms\r\ntile-data-sink: 1045ms\r\n```\r\n@hjanetzek have you measured significant performance improvements in another context?"}}