{"action":"closed","number":538,"pull_request":{"url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538","id":73514949,"html_url":"https://github.com/mxstbr/react-boilerplate/pull/538","diff_url":"https://github.com/mxstbr/react-boilerplate/pull/538.diff","patch_url":"https://github.com/mxstbr/react-boilerplate/pull/538.patch","issue_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/538","number":538,"state":"closed","locked":false,"title":"Removed ShallowCompare","user":{"login":"eddiewang","id":2057997,"avatar_url":"https://avatars.githubusercontent.com/u/2057997?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiewang","html_url":"https://github.com/eddiewang","followers_url":"https://api.github.com/users/eddiewang/followers","following_url":"https://api.github.com/users/eddiewang/following{/other_user}","gists_url":"https://api.github.com/users/eddiewang/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiewang/subscriptions","organizations_url":"https://api.github.com/users/eddiewang/orgs","repos_url":"https://api.github.com/users/eddiewang/repos","events_url":"https://api.github.com/users/eddiewang/events{/privacy}","received_events_url":"https://api.github.com/users/eddiewang/received_events","type":"User","site_admin":false},"body":"---referencing from gitter\r\napp/container/homepge/index.js\r\nline 46-49\r\nshouldComponentUpdate(nextProps, nextState) { return shallowCompare(this, nextProps, nextState); }\r\nReact-redux connect internally takes care of this . @gearon read the source youTube video talks about this ... Shallowcompare is useful if it's not connected to redux store ...\r\n\r\nlooks like we don't need this if connected to redux store.... removed the code.","created_at":"2016-06-13T01:58:23Z","updated_at":"2016-06-13T07:19:51Z","closed_at":"2016-06-13T07:19:51Z","merged_at":"2016-06-13T07:19:51Z","merge_commit_sha":"ca4c8b23e8eb6c09ad08f91a5d04a5823cd9b0fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538/commits","review_comments_url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538/comments","review_comment_url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/538/comments","statuses_url":"https://api.github.com/repos/mxstbr/react-boilerplate/statuses/43792dc89bfd9124997a9b648c07adae82cb41dc","head":{"label":"eddiewang:master","ref":"master","sha":"43792dc89bfd9124997a9b648c07adae82cb41dc","user":{"login":"eddiewang","id":2057997,"avatar_url":"https://avatars.githubusercontent.com/u/2057997?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiewang","html_url":"https://github.com/eddiewang","followers_url":"https://api.github.com/users/eddiewang/followers","following_url":"https://api.github.com/users/eddiewang/following{/other_user}","gists_url":"https://api.github.com/users/eddiewang/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiewang/subscriptions","organizations_url":"https://api.github.com/users/eddiewang/orgs","repos_url":"https://api.github.com/users/eddiewang/repos","events_url":"https://api.github.com/users/eddiewang/events{/privacy}","received_events_url":"https://api.github.com/users/eddiewang/received_events","type":"User","site_admin":false},"repo":{"id":60785407,"name":"react-boilerplate","full_name":"eddiewang/react-boilerplate","owner":{"login":"eddiewang","id":2057997,"avatar_url":"https://avatars.githubusercontent.com/u/2057997?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiewang","html_url":"https://github.com/eddiewang","followers_url":"https://api.github.com/users/eddiewang/followers","following_url":"https://api.github.com/users/eddiewang/following{/other_user}","gists_url":"https://api.github.com/users/eddiewang/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiewang/subscriptions","organizations_url":"https://api.github.com/users/eddiewang/orgs","repos_url":"https://api.github.com/users/eddiewang/repos","events_url":"https://api.github.com/users/eddiewang/events{/privacy}","received_events_url":"https://api.github.com/users/eddiewang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddiewang/react-boilerplate","description":":fire: A highly scalable, offline-first foundation with the best developer experience and a focus on performance and best practices.","fork":true,"url":"https://api.github.com/repos/eddiewang/react-boilerplate","forks_url":"https://api.github.com/repos/eddiewang/react-boilerplate/forks","keys_url":"https://api.github.com/repos/eddiewang/react-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddiewang/react-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddiewang/react-boilerplate/teams","hooks_url":"https://api.github.com/repos/eddiewang/react-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/eddiewang/react-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/eddiewang/react-boilerplate/events","assignees_url":"https://api.github.com/repos/eddiewang/react-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/eddiewang/react-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/eddiewang/react-boilerplate/tags","blobs_url":"https://api.github.com/repos/eddiewang/react-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddiewang/react-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddiewang/react-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddiewang/react-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddiewang/react-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/eddiewang/react-boilerplate/languages","stargazers_url":"https://api.github.com/repos/eddiewang/react-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/eddiewang/react-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/eddiewang/react-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/eddiewang/react-boilerplate/subscription","commits_url":"https://api.github.com/repos/eddiewang/react-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddiewang/react-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddiewang/react-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddiewang/react-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddiewang/react-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/eddiewang/react-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddiewang/react-boilerplate/merges","archive_url":"https://api.github.com/repos/eddiewang/react-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddiewang/react-boilerplate/downloads","issues_url":"https://api.github.com/repos/eddiewang/react-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/eddiewang/react-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/eddiewang/react-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/eddiewang/react-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddiewang/react-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/eddiewang/react-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/eddiewang/react-boilerplate/deployments","created_at":"2016-06-09T15:26:55Z","updated_at":"2016-06-09T15:26:56Z","pushed_at":"2016-06-13T01:57:23Z","git_url":"git://github.com/eddiewang/react-boilerplate.git","ssh_url":"git@github.com:eddiewang/react-boilerplate.git","clone_url":"https://github.com/eddiewang/react-boilerplate.git","svn_url":"https://github.com/eddiewang/react-boilerplate","homepage":"http://reactboilerplate.com","size":2172,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxstbr:master","ref":"master","sha":"6709d17de8a53aa87e668794cb547942dcbe170a","user":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"repo":{"id":30969188,"name":"react-boilerplate","full_name":"mxstbr/react-boilerplate","owner":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxstbr/react-boilerplate","description":":fire: A highly scalable, offline-first foundation with the best developer experience and a focus on performance and best practices.","fork":false,"url":"https://api.github.com/repos/mxstbr/react-boilerplate","forks_url":"https://api.github.com/repos/mxstbr/react-boilerplate/forks","keys_url":"https://api.github.com/repos/mxstbr/react-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxstbr/react-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxstbr/react-boilerplate/teams","hooks_url":"https://api.github.com/repos/mxstbr/react-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/mxstbr/react-boilerplate/events","assignees_url":"https://api.github.com/repos/mxstbr/react-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/mxstbr/react-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/mxstbr/react-boilerplate/tags","blobs_url":"https://api.github.com/repos/mxstbr/react-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxstbr/react-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxstbr/react-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxstbr/react-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxstbr/react-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/mxstbr/react-boilerplate/languages","stargazers_url":"https://api.github.com/repos/mxstbr/react-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/mxstbr/react-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/mxstbr/react-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/mxstbr/react-boilerplate/subscription","commits_url":"https://api.github.com/repos/mxstbr/react-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxstbr/react-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxstbr/react-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxstbr/react-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/mxstbr/react-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxstbr/react-boilerplate/merges","archive_url":"https://api.github.com/repos/mxstbr/react-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxstbr/react-boilerplate/downloads","issues_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/mxstbr/react-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/mxstbr/react-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxstbr/react-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/mxstbr/react-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/mxstbr/react-boilerplate/deployments","created_at":"2015-02-18T14:36:32Z","updated_at":"2016-06-13T05:11:37Z","pushed_at":"2016-06-13T07:19:51Z","git_url":"git://github.com/mxstbr/react-boilerplate.git","ssh_url":"git@github.com:mxstbr/react-boilerplate.git","clone_url":"https://github.com/mxstbr/react-boilerplate.git","svn_url":"https://github.com/mxstbr/react-boilerplate","homepage":"http://reactboilerplate.com","size":2914,"stargazers_count":7612,"watchers_count":7612,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":537,"mirror_url":null,"open_issues_count":49,"forks":537,"open_issues":49,"watchers":7612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538"},"html":{"href":"https://github.com/mxstbr/react-boilerplate/pull/538"},"issue":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/538"},"comments":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/mxstbr/react-boilerplate/statuses/43792dc89bfd9124997a9b648c07adae82cb41dc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":0,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"mxstbr"}}