{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/11339","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/11339/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/11339/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/11339/events","html_url":"https://github.com/Microsoft/vscode/issues/11339","id":174368360,"number":11339,"title":"onDidChangeTextDocument Api timing issue","user":{"login":"aminroosta","id":2920178,"avatar_url":"https://avatars.githubusercontent.com/u/2920178?v=3","gravatar_id":"","url":"https://api.github.com/users/aminroosta","html_url":"https://github.com/aminroosta","followers_url":"https://api.github.com/users/aminroosta/followers","following_url":"https://api.github.com/users/aminroosta/following{/other_user}","gists_url":"https://api.github.com/users/aminroosta/gists{/gist_id}","starred_url":"https://api.github.com/users/aminroosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aminroosta/subscriptions","organizations_url":"https://api.github.com/users/aminroosta/orgs","repos_url":"https://api.github.com/users/aminroosta/repos","events_url":"https://api.github.com/users/aminroosta/events{/privacy}","received_events_url":"https://api.github.com/users/aminroosta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/vscode/labels/api","name":"api","color":"1d76db"},{"url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"E57E7E"}],"state":"open","locked":false,"assignee":{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"assignees":[{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},{"login":"jrieken","id":1794099,"avatar_url":"https://avatars.githubusercontent.com/u/1794099?v=3","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/29","html_url":"https://github.com/Microsoft/vscode/milestones/October%202016","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/29/labels","id":2019000,"number":29,"title":"October 2016","description":null,"creator":{"login":"weinand","id":1898161,"avatar_url":"https://avatars.githubusercontent.com/u/1898161?v=3","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2016-09-21T11:16:13Z","updated_at":"2016-09-23T14:55:19Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-08-31T20:18:51Z","updated_at":"2016-09-23T15:49:22Z","closed_at":null,"body":"- VSCode Version: 1.4.0-insider\r\n- OS Version: El Capitan\r\n\r\nSteps to Reproduce:\r\n\r\n1. Enter some text in an editor window\r\n\r\n<img width=\"551\" alt=\"screen shot 2016-09-01 at 12 46 01 am\" src=\"https://cloud.githubusercontent.com/assets/2920178/18144809/c8e231ca-6fdd-11e6-90d9-af9a6274a2b5.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/249229298","html_url":"https://github.com/Microsoft/vscode/issues/11339#issuecomment-249229298","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/11339","id":249229298,"user":{"login":"jrieken","id":1794099,"avatar_url":"https://avatars.githubusercontent.com/u/1794099?v=3","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T15:49:22Z","updated_at":"2016-09-23T15:49:22Z","body":"@bpasero Unsure if you want to know so short before the weekend 🙉 The problem is that we have one event source for [doc](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/mainThreadDocuments.ts#L109)[ument](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/mainThreadDocuments.ts#L150) changes and another for [dirty](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/mainThreadDocuments.ts#L76). So, one event is from the editor world and the other from the workbench world and we don't synchronise on them - so we first tell extensions a document has changes (and at that time it's not dirty) and on next tick we tell extensions a document is dirty. I have no clue how we bring all those things together yet..."}}
{"actor":{"display_login":"jrieken"}}