{"push_id":1448140974,"size":151,"distinct_size":1,"ref":"refs/heads/stable","head":"d0db81f3c42fed24c114afb27b0b50519c87fef7","before":"d8a48943c3146a98d6e4de594e37ce77022eaecf","commits":[{"sha":"7a48b429cdce7294921dd8e7086fc3f9e8a747f3","author":{"name":"Martin Arista","email":"a958d17767d6d5d674fae8c86d9dc73469ccf87a@mrtnrst.local"},"message":"Add carthage instal steps\n\nSummary:\nAdded Carthage Install Steps #13\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/48\n\nDifferential Revision: D4005535\n\nPulled By: jessesquires\n\nfbshipit-source-id: 5414c1e967abfbbe7a5d199b1e3b09b844e52c63","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/7a48b429cdce7294921dd8e7086fc3f9e8a747f3"},{"sha":"a2e00053578dda9784dcbc46bf79b13da0bdf5dc","author":{"name":"Kyle Hickinson","email":"801e1d334f35b0f327e4f34e5e42d695dc4abde0@gmail.com"},"message":"Replace reusable identifier methods with a C function (#40)\n\nSummary:\nReplaced the two methods for generating a reusable identifier with an inline C function (as per #40) which has 3 parameters: `viewClass` (unchanged), `nibName` (for when #1 is added), and `kind`. The string is generated following the same pattern as before.\n\nA few things:\n- The current test only tests one of the options. May want to add more tests for each.\n- Not sure if you guys prefer `NS_INLINE` vs `static inline`.\n- Not sure if we want to add assertions for empty strings for nibName/kind parameters.\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/49\n\nDifferential Revision: D4005549\n\nPulled By: jessesquires\n\nfbshipit-source-id: e1683ebe8882d1a8de934c8166f67d3508cffba9","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/a2e00053578dda9784dcbc46bf79b13da0bdf5dc"},{"sha":"6e3656449f239178898352e69c481a0e824ef996","author":{"name":"Ryan Nystrom","email":"04f6cd5d4b740980bb86b1bc9f116dd5afd20d65@instagram.com"},"message":"Update User copy in readme to a real-world example\n\nSummary:\nCopy changes. Can proof them here: https://github.com/Instagram/IGListKit/tree/readme\n\nI got some feedback that the `User` example didn't make sense (*why would you have two users with the same pk?*).\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/50\n\nReviewed By: jessesquires\n\nDifferential Revision: D4006618\n\nPulled By: rnystrom\n\nfbshipit-source-id: 9673788b643785d223b67ab1b23315edfc5874cb","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/6e3656449f239178898352e69c481a0e824ef996"},{"sha":"a7124a0fe5ce17efa231b7c2dcaf5aa435bb09f3","author":{"name":"James Kuang","email":"8861bc1c20fdff9c772d752d35e3c1605dc42827@gmail.com"},"message":"Update README 'pk' to 'primaryKey' for consistency\n\nSummary:\nUpdated README example for naming consistency\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/58\n\nReviewed By: ryanolsonk, ocrickard\n\nDifferential Revision: D4008590\n\nPulled By: rnystrom\n\nfbshipit-source-id: 74412ca77054cd6a15c0783b95f5d7a87eaf4c96","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/a7124a0fe5ce17efa231b7c2dcaf5aa435bb09f3"},{"sha":"bd72c71cd693bd9621ad0bf2022b5d169c44d0e6","author":{"name":"Patrick Balestra","email":"b4a5ea001e047040e8c9075b67a268293138da2c@patrickbalestra.com"},"message":"Fix Twitter handles in Example project\n\nSummary:\nI was exploring the example project when I noticed that two Twitter handles were wrong.\nThis will probably be the most useless PR ever in `IGListKit`, but it's good that you guys get the correct acknowledgment for your hard work! 🤓\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/54\n\nReviewed By: ryanolsonk\n\nDifferential Revision: D4008615\n\nPulled By: rnystrom\n\nfbshipit-source-id: 904892d40fed73045e724cc87dddf641af02e27d","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/bd72c71cd693bd9621ad0bf2022b5d169c44d0e6"},{"sha":"992c3b7caa30251bd5c35cc36caa49832168e7e8","author":{"name":"Ben Asher","email":"0754cc973e445c68c72d63255adf46e10e4c3ab2@gmail.com"},"message":"IGListAdapter: Fix not returning early when collectionView/dataSource is nil and completion is nil\n\nSummary:\n- I ran the static analyzer, and it found a case in `performUpdatesAnimated:completion:` where it looks like we meant to bail out early if the `collectionView` or `dataSource` is nil, but it only does so if `completion` is provided.\n- Fixed a spelling error in nearby documentation\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\n\n- There is one other analyzer warning, but it seems to be making an incorrect assumption. In any case, it's not something I can fix quickly (requires more time spent staring at IGListDiff.mm).\n- A ticket should be opened to add static analysis to .travis.yml. I'lll do this soonish, unless someone beats me to it!\n\n- I could add a test for this, but this project is annotated well enough with null\nCloses https://github.com/Instagram/IGListKit/pull/51\n\nReviewed By: ocrickard\n\nDifferential Revision: D4008605\n\nPulled By: rnystrom\n\nfbshipit-source-id: c2b7516cb8c1fc619aa63d1e9b0c26f2918cd8a1","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/992c3b7caa30251bd5c35cc36caa49832168e7e8"},{"sha":"58e5888deacbe0f6aca0155bd16652a98a1bf52a","author":{"name":"Bas Broek","email":"d3d9b47d743b93dc8d31a1964d50ffbed35f2d70@users.noreply.github.com"},"message":"Jessie > Jesse\n\nSummary:\nCorrected Jesse's name.\n\n- [x] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/60\n\nReviewed By: ocrickard\n\nDifferential Revision: D4009130\n\nPulled By: jessesquires\n\nfbshipit-source-id: 5786282f0690829374096bed1528138dccf0a703","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/58e5888deacbe0f6aca0155bd16652a98a1bf52a"},{"sha":"8b32b80aac449de8a5b260bf8685e2fc8bdce66f","author":{"name":"ReadmeCritic","email":"ff482cc572fe982c4fd6b0ee8654d7781aafba7a@gmail.com"},"message":"Correct the spelling of CocoaPods in README\n\nSummary:\nThis pull request corrects the spelling of **CocoaPods** 🤓\nhttps://github.com/CocoaPods/shared_resources/tree/master/media\n\n<blockquote class=\"twitter-tweet\" data-lang=\"en\"><p lang=\"en\" dir=\"ltr\">One day I’ll make a bot that looks through the READMEs of all Pods, looks to see if it uses “Cocoapods” and PRs “CocoaPods” :D</p>&mdash; Ørta (orta) <a href=\"https://twitter.com/orta/status/697374357975388160\">February 10, 2016</a></blockquote>\n<script async src=\"//platform.twitter.com/widgets.js\" charset=\"utf-8\"></script>\n\nCreated with [`cocoapods-readme`](https://github.com/dkhamsing/cocoapods-readme).\nCloses https://github.com/Instagram/IGListKit/pull/59\n\nReviewed By: ocrickard\n\nDifferential Revision: D4009138\n\nPulled By: jessesquires\n\nfbshipit-source-id: fedaa51e883a78e52de4f7d934e0945b946cc751","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/8b32b80aac449de8a5b260bf8685e2fc8bdce66f"},{"sha":"4863974f9daa635eef16e77ece43616bfb4008c5","author":{"name":"Ben Asher","email":"0754cc973e445c68c72d63255adf46e10e4c3ab2@gmail.com"},"message":"Added CHANGELOG entry for #51\n\nSummary:\nFixed #63. I used the style we use in CocoaPods, but I'm happy to adjust!\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/67\n\nReviewed By: jessesquires\n\nDifferential Revision: D4015999\n\nPulled By: rnystrom\n\nfbshipit-source-id: bbe8055f22e84c5bdc628b4c1d95dab111774e12","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/4863974f9daa635eef16e77ece43616bfb4008c5"},{"sha":"394760081c7c2daa5ae6c18e00cdeaf2b67e22c1","author":{"name":"Ryan Nystrom","email":"04f6cd5d4b740980bb86b1bc9f116dd5afd20d65@instagram.com"},"message":"Add isLast/FirstSection API to IGListSectionController\n\nSummary: Product needs show that section controllers need some sort of awarenes when they are the first/last section in a list (e.g. for cell borders). Adding this simple API, non-breaking.\n\nReviewed By: jessesquires\n\nDifferential Revision: D4016023\n\nfbshipit-source-id: c75f9298fc73875a1cabad191fe2db6cb9ee4376","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/394760081c7c2daa5ae6c18e00cdeaf2b67e22c1"},{"sha":"fd22609e7e014552084ba691ca3b911dd41c2cd3","author":{"name":"Ben Asher","email":"0754cc973e445c68c72d63255adf46e10e4c3ab2@gmail.com"},"message":"Use bundler to manage CocoaPods and xcpretty\n\nSummary:\n- Travis appears to be using CocoaPods 1.1.0.beta.2, which is missing some fixes for Xcode 8 (see [sample failing build](https://travis-ci.org/Instagram/IGListKit/jobs/166935850) from #51).\n- This change will ensure that a consistent CocoaPods version is used by Travis\n- In the added Gemfile, I picked the latest CocoaPods 1.1.0 RC (matches version in Podfile.lock) and the latest xcpretty.\n- Changed `pod spec lint` to `pod lib lint` to verify local files instead of files from the version specified in the spec.\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/57\n\nDifferential Revision: D4019655\n\nPulled By: rnystrom\n\nfbshipit-source-id: 422e55c44dfdf276b587ea6e12ae30218a237ff5","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/fd22609e7e014552084ba691ca3b911dd41c2cd3"},{"sha":"ab21a7f6691b90383b6c4cd400923589e0fe3d8a","author":{"name":"Chris Amanse","email":"4181b934c2715a2bba60cdb3cc1b35b2777d1c23@chrisamanse.xyz"},"message":"Fix typo in connecting data source code in README\n\nSummary:\nOnly README.md was changed. Fixed the typo in example code for connecting data source (replace opening parenthesis with whitespace).\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/64\n\nReviewed By: jessesquires\n\nDifferential Revision: D4012595\n\nPulled By: rnystrom\n\nfbshipit-source-id: f27774e20c7a2ec3154cacbf919fd295625bace4","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/ab21a7f6691b90383b6c4cd400923589e0fe3d8a"},{"sha":"d3442ec497324f94aa7072915292fba69348b709","author":{"name":"Valeriy Van","email":"aaa7173a7aedc8d402eb5f05c3dea648a6894272@cgm.com"},"message":"Simplifies block ridding of one if-else branch met only once.\n\nSummary:\nSimplifies block ridding of one if-else branch met only once.\nSolves issue #68.\n\n- [*] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [*] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/69\n\nReviewed By: jessesquires\n\nDifferential Revision: D4021608\n\nPulled By: rnystrom\n\nfbshipit-source-id: 21cfca8578398c819a68aa3a118d27d58bb580b3","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/d3442ec497324f94aa7072915292fba69348b709"},{"sha":"221c2fbd209b90072ce576d85df1e70ce0a6b341","author":{"name":"Valeriy Van","email":"f27a17fc90c00d8c248d8510a1084221738b492b@w7software.com"},"message":"Makes objects function more swifty.\n\nSummary:\n- [x ] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/70\n\nReviewed By: nlutsenko\n\nDifferential Revision: D4025610\n\nPulled By: rnystrom\n\nfbshipit-source-id: 927e93cec5719466dc152f82a235d5a70e53109d","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/221c2fbd209b90072ce576d85df1e70ce0a6b341"},{"sha":"ce4b851da343940513a074342fab6f5a7e67125d","author":{"name":"Sven Bacia","email":"35e81d3ebf07e799bbc75dfb991dfae0d604cfa2@gmail.com"},"message":"Support cells created from nibs\n\nSummary:\nI started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind.\n\n- [x]  I'm currently thinking about the best way to test these changes.\n- [x] I was not able to update the documentation (issue #55).\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/56\n\nReviewed By: dshahidehpour\n\nDifferential Revision: D4023746\n\nPulled By: rnystrom\n\nfbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/ce4b851da343940513a074342fab6f5a7e67125d"},{"sha":"1e73bc69b0dde256f1d761a8076d8b4de81212b2","author":{"name":"Valeriy Van","email":"f27a17fc90c00d8c248d8510a1084221738b492b@w7software.com"},"message":"Fixes compilation errors in example app.\n\nSummary:\nFixes compilation errors in example app.\n\n- [x] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/71\n\nDifferential Revision: D4027054\n\nPulled By: rnystrom\n\nfbshipit-source-id: 50020d309e8cf69dabaa1958d9f1eed37dc6ee63","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/1e73bc69b0dde256f1d761a8076d8b4de81212b2"},{"sha":"d4f64c3e90984fb3f25575e51fc3a65243493670","author":{"name":"Ryan Nystrom","email":"04f6cd5d4b740980bb86b1bc9f116dd5afd20d65@instagram.com"},"message":"Swap test nib to test bundle\n\nSummary:\nIGTestNibCell.xib was in the wrong bundle after imported internally (moved it to `Assets` dir)\n\n- [x] All tests pass. Demo project builds and runs.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/78\n\nReviewed By: ryanolsonk\n\nDifferential Revision: D4028444\n\nPulled By: rnystrom\n\nfbshipit-source-id: cb7ed0f8024ca9fd116827f3935f075c1d9193be","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/d4f64c3e90984fb3f25575e51fc3a65243493670"},{"sha":"8a96fc9c64ae84626fd41c493aece9ad7309ce3d","author":{"name":"Ryan Nystrom","email":"04f6cd5d4b740980bb86b1bc9f116dd5afd20d65@instagram.com"},"message":"Extension only API flag\n\nSummary:\nAdds `APPLICATION_EXTENSION_API_ONLY = YES` to Xcode project.\nCloses https://github.com/Instagram/IGListKit/pull/79\n\nDifferential Revision: D4028543\n\nPulled By: rnystrom\n\nfbshipit-source-id: 203afacb5485dd4dc5897991d7981cf80f6da993","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/8a96fc9c64ae84626fd41c493aece9ad7309ce3d"},{"sha":"799517d6aecbaaf6d4ec7e4402b2e9b3112ddd79","author":{"name":"Valeriy Van","email":"f27a17fc90c00d8c248d8510a1084221738b492b@w7software.com"},"message":"Using switch with is cases instead of if with multiple as?.\n\nSummary:\nUsing switch with is cases instead of if with multiple as?.\n\n- [x] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/82\n\nReviewed By: dshahidehpour\n\nDifferential Revision: D4030890\n\nPulled By: jessesquires\n\nfbshipit-source-id: fc17795620509572ed1d9fa6ef405357acab9a9b","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/799517d6aecbaaf6d4ec7e4402b2e9b3112ddd79"},{"sha":"96a9555ecb8678cffb82cb3c76c695bc57b5ff8b","author":{"name":"Valeriy Van","email":"f27a17fc90c00d8c248d8510a1084221738b492b@w7software.com"},"message":"Makes objects function more swifty.\n\nSummary:\nMakes objects function more swifty.\n\n- [x ] All tests pass. Demo project builds and runs.\n- [ ] I added tests, an experiment, or detailed why my change isn't tested.\n- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)\nCloses https://github.com/Instagram/IGListKit/pull/74\n\nReviewed By: dshahidehpour\n\nDifferential Revision: D4030906\n\nPulled By: jessesquires\n\nfbshipit-source-id: 9a986fd4b470da0a33fadfd71f41f86b324df5be","distinct":false,"url":"https://api.github.com/repos/Instagram/IGListKit/commits/96a9555ecb8678cffb82cb3c76c695bc57b5ff8b"}]}
{"actor":{"display_login":"jessesquires"}}