{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/94081103","pull_request_review_id":14611765,"id":94081103,"diff_hunk":"@@ -231,7 +275,7 @@ func createApproverSet(comments []*githubapi.IssueComment) sets.String {\n \tapproverMatcher := c.CommandName(approveCommand)\n \tfor _, comment := range c.FilterComments(comments, approverMatcher) {\n \t\tcmd := c.ParseCommand(comment)\n-\t\tif cmd.Arguments == \"cancel\" {\n+\t\tif cmd.Arguments == cancel {","path":"mungegithub/mungers/approval-handler.go","position":164,"original_position":164,"commit_id":"28ed592301d4ec9b80ead26be64cc2461a8d9423","original_commit_id":"28ed592301d4ec9b80ead26be64cc2461a8d9423","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"body":"One question: what does `Delete` do if there is no such user in the set? i.e. what happens when someone cancels without approving in the first place?","created_at":"2016-12-28T21:48:08Z","updated_at":"2016-12-28T21:48:08Z","html_url":"https://github.com/kubernetes/contrib/pull/2194#discussion_r94081103","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2194","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/94081103"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2194#discussion_r94081103"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2194"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/2194","id":98860127,"html_url":"https://github.com/kubernetes/contrib/pull/2194","diff_url":"https://github.com/kubernetes/contrib/pull/2194.diff","patch_url":"https://github.com/kubernetes/contrib/pull/2194.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/2194","number":2194,"state":"open","locked":false,"title":"[mungegithub]: Improve Approval Process","user":{"login":"grodrigues3","id":4854198,"avatar_url":"https://avatars.githubusercontent.com/u/4854198?v=3","gravatar_id":"","url":"https://api.github.com/users/grodrigues3","html_url":"https://github.com/grodrigues3","followers_url":"https://api.github.com/users/grodrigues3/followers","following_url":"https://api.github.com/users/grodrigues3/following{/other_user}","gists_url":"https://api.github.com/users/grodrigues3/gists{/gist_id}","starred_url":"https://api.github.com/users/grodrigues3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grodrigues3/subscriptions","organizations_url":"https://api.github.com/users/grodrigues3/orgs","repos_url":"https://api.github.com/users/grodrigues3/repos","events_url":"https://api.github.com/users/grodrigues3/events{/privacy}","received_events_url":"https://api.github.com/users/grodrigues3/received_events","type":"User","site_admin":false},"body":"- Add link to OWNERS file in notification\r\n- Show minimum set of OWNERS files needed\r\n  for approval\r\n- Make notification clearer\r\n- Call LeafApprovers on full file, not just\r\n  path, so correct owners file used\r\n- Added tests for repo updates and removed \"/\"\r\n  convention for root so files have same prefix\r\n- Added canonical way to get filepath and\r\n  tests for it","created_at":"2016-12-21T02:08:36Z","updated_at":"2016-12-28T21:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e84e04083e983c90ca3c45ff290f82540de1315a","assignee":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"assignees":[{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2194/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2194/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/2194/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/28ed592301d4ec9b80ead26be64cc2461a8d9423","head":{"label":"grodrigues3:reorder-mungers-reword-notification","ref":"reorder-mungers-reword-notification","sha":"28ed592301d4ec9b80ead26be64cc2461a8d9423","user":{"login":"grodrigues3","id":4854198,"avatar_url":"https://avatars.githubusercontent.com/u/4854198?v=3","gravatar_id":"","url":"https://api.github.com/users/grodrigues3","html_url":"https://github.com/grodrigues3","followers_url":"https://api.github.com/users/grodrigues3/followers","following_url":"https://api.github.com/users/grodrigues3/following{/other_user}","gists_url":"https://api.github.com/users/grodrigues3/gists{/gist_id}","starred_url":"https://api.github.com/users/grodrigues3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grodrigues3/subscriptions","organizations_url":"https://api.github.com/users/grodrigues3/orgs","repos_url":"https://api.github.com/users/grodrigues3/repos","events_url":"https://api.github.com/users/grodrigues3/events{/privacy}","received_events_url":"https://api.github.com/users/grodrigues3/received_events","type":"User","site_admin":false},"repo":{"id":64148560,"name":"contrib","full_name":"grodrigues3/contrib","owner":{"login":"grodrigues3","id":4854198,"avatar_url":"https://avatars.githubusercontent.com/u/4854198?v=3","gravatar_id":"","url":"https://api.github.com/users/grodrigues3","html_url":"https://github.com/grodrigues3","followers_url":"https://api.github.com/users/grodrigues3/followers","following_url":"https://api.github.com/users/grodrigues3/following{/other_user}","gists_url":"https://api.github.com/users/grodrigues3/gists{/gist_id}","starred_url":"https://api.github.com/users/grodrigues3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grodrigues3/subscriptions","organizations_url":"https://api.github.com/users/grodrigues3/orgs","repos_url":"https://api.github.com/users/grodrigues3/repos","events_url":"https://api.github.com/users/grodrigues3/events{/privacy}","received_events_url":"https://api.github.com/users/grodrigues3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grodrigues3/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":true,"url":"https://api.github.com/repos/grodrigues3/contrib","forks_url":"https://api.github.com/repos/grodrigues3/contrib/forks","keys_url":"https://api.github.com/repos/grodrigues3/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grodrigues3/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grodrigues3/contrib/teams","hooks_url":"https://api.github.com/repos/grodrigues3/contrib/hooks","issue_events_url":"https://api.github.com/repos/grodrigues3/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/grodrigues3/contrib/events","assignees_url":"https://api.github.com/repos/grodrigues3/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/grodrigues3/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/grodrigues3/contrib/tags","blobs_url":"https://api.github.com/repos/grodrigues3/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grodrigues3/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grodrigues3/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/grodrigues3/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grodrigues3/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/grodrigues3/contrib/languages","stargazers_url":"https://api.github.com/repos/grodrigues3/contrib/stargazers","contributors_url":"https://api.github.com/repos/grodrigues3/contrib/contributors","subscribers_url":"https://api.github.com/repos/grodrigues3/contrib/subscribers","subscription_url":"https://api.github.com/repos/grodrigues3/contrib/subscription","commits_url":"https://api.github.com/repos/grodrigues3/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/grodrigues3/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/grodrigues3/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/grodrigues3/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/grodrigues3/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/grodrigues3/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grodrigues3/contrib/merges","archive_url":"https://api.github.com/repos/grodrigues3/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grodrigues3/contrib/downloads","issues_url":"https://api.github.com/repos/grodrigues3/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/grodrigues3/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/grodrigues3/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/grodrigues3/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grodrigues3/contrib/labels{/name}","releases_url":"https://api.github.com/repos/grodrigues3/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/grodrigues3/contrib/deployments","created_at":"2016-07-25T15:59:50Z","updated_at":"2016-07-25T15:59:55Z","pushed_at":"2016-12-27T22:31:07Z","git_url":"git://github.com/grodrigues3/contrib.git","ssh_url":"git@github.com:grodrigues3/contrib.git","clone_url":"https://github.com/grodrigues3/contrib.git","svn_url":"https://github.com/grodrigues3/contrib","homepage":"","size":41458,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fd023f71c47edaffd40476a45b131e64310699b8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-12-28T15:07:58Z","pushed_at":"2016-12-28T21:02:07Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":62251,"stargazers_count":715,"watchers_count":715,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":730,"mirror_url":null,"open_issues_count":412,"forks":730,"open_issues":412,"watchers":715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2194"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2194"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2194"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2194/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2194/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2194/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/28ed592301d4ec9b80ead26be64cc2461a8d9423"}}}}
{"actor":{"display_login":"foxish"}}