{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/mzabriskie/axios/pulls/185","id":54922984,"html_url":"https://github.com/mzabriskie/axios/pull/185","diff_url":"https://github.com/mzabriskie/axios/pull/185.diff","patch_url":"https://github.com/mzabriskie/axios/pull/185.patch","issue_url":"https://api.github.com/repos/mzabriskie/axios/issues/185","number":185,"state":"closed","locked":false,"title":"Improve XDomainRequest implementation","user":{"login":"jtangelder","id":1243901,"avatar_url":"https://avatars.githubusercontent.com/u/1243901?v=3","gravatar_id":"","url":"https://api.github.com/users/jtangelder","html_url":"https://github.com/jtangelder","followers_url":"https://api.github.com/users/jtangelder/followers","following_url":"https://api.github.com/users/jtangelder/following{/other_user}","gists_url":"https://api.github.com/users/jtangelder/gists{/gist_id}","starred_url":"https://api.github.com/users/jtangelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtangelder/subscriptions","organizations_url":"https://api.github.com/users/jtangelder/orgs","repos_url":"https://api.github.com/users/jtangelder/repos","events_url":"https://api.github.com/users/jtangelder/events{/privacy}","received_events_url":"https://api.github.com/users/jtangelder/received_events","type":"User","site_admin":false},"body":"I saw the XDomainRequest detection and forsaw an issue with its implementation. The `ieVersion()` method would break the webworker support, since it adds a dependency to the `document`. My solution checks for the property `withCredentials`, since it was [introduced at IE10](https://msdn.microsoft.com/en-us/library/hh872883(v=vs.85).aspx). \r\nAlso removed `ActiveXObject` support since that is only for IE7 and older, and Axios doesn't support these, right?\r\n\r\nAnd added some manual tests to verify the working in browsers. Tested with these on Saucelabs and my local machine in Win7-IE9, Win7-IE10, Win7-IE11 and Chrome 47.","created_at":"2016-01-03T11:14:31Z","updated_at":"2016-01-17T21:35:46Z","closed_at":"2016-01-17T21:35:46Z","merged_at":"2016-01-17T21:35:46Z","merge_commit_sha":"81448e2bd7aca3103121b72641665fe359d7a876","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mzabriskie/axios/pulls/185/commits","review_comments_url":"https://api.github.com/repos/mzabriskie/axios/pulls/185/comments","review_comment_url":"https://api.github.com/repos/mzabriskie/axios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mzabriskie/axios/issues/185/comments","statuses_url":"https://api.github.com/repos/mzabriskie/axios/statuses/ef6bfe8cb2d22e691a7f1d3dcd9dc0e1039b9b23","head":{"label":"jtangelder:improve-ie","ref":"improve-ie","sha":"ef6bfe8cb2d22e691a7f1d3dcd9dc0e1039b9b23","user":{"login":"jtangelder","id":1243901,"avatar_url":"https://avatars.githubusercontent.com/u/1243901?v=3","gravatar_id":"","url":"https://api.github.com/users/jtangelder","html_url":"https://github.com/jtangelder","followers_url":"https://api.github.com/users/jtangelder/followers","following_url":"https://api.github.com/users/jtangelder/following{/other_user}","gists_url":"https://api.github.com/users/jtangelder/gists{/gist_id}","starred_url":"https://api.github.com/users/jtangelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtangelder/subscriptions","organizations_url":"https://api.github.com/users/jtangelder/orgs","repos_url":"https://api.github.com/users/jtangelder/repos","events_url":"https://api.github.com/users/jtangelder/events{/privacy}","received_events_url":"https://api.github.com/users/jtangelder/received_events","type":"User","site_admin":false},"repo":{"id":44958942,"name":"axios","full_name":"jtangelder/axios","owner":{"login":"jtangelder","id":1243901,"avatar_url":"https://avatars.githubusercontent.com/u/1243901?v=3","gravatar_id":"","url":"https://api.github.com/users/jtangelder","html_url":"https://github.com/jtangelder","followers_url":"https://api.github.com/users/jtangelder/followers","following_url":"https://api.github.com/users/jtangelder/following{/other_user}","gists_url":"https://api.github.com/users/jtangelder/gists{/gist_id}","starred_url":"https://api.github.com/users/jtangelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtangelder/subscriptions","organizations_url":"https://api.github.com/users/jtangelder/orgs","repos_url":"https://api.github.com/users/jtangelder/repos","events_url":"https://api.github.com/users/jtangelder/events{/privacy}","received_events_url":"https://api.github.com/users/jtangelder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtangelder/axios","description":"Promise based HTTP client for the browser and node.js","fork":true,"url":"https://api.github.com/repos/jtangelder/axios","forks_url":"https://api.github.com/repos/jtangelder/axios/forks","keys_url":"https://api.github.com/repos/jtangelder/axios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtangelder/axios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtangelder/axios/teams","hooks_url":"https://api.github.com/repos/jtangelder/axios/hooks","issue_events_url":"https://api.github.com/repos/jtangelder/axios/issues/events{/number}","events_url":"https://api.github.com/repos/jtangelder/axios/events","assignees_url":"https://api.github.com/repos/jtangelder/axios/assignees{/user}","branches_url":"https://api.github.com/repos/jtangelder/axios/branches{/branch}","tags_url":"https://api.github.com/repos/jtangelder/axios/tags","blobs_url":"https://api.github.com/repos/jtangelder/axios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtangelder/axios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtangelder/axios/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtangelder/axios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtangelder/axios/statuses/{sha}","languages_url":"https://api.github.com/repos/jtangelder/axios/languages","stargazers_url":"https://api.github.com/repos/jtangelder/axios/stargazers","contributors_url":"https://api.github.com/repos/jtangelder/axios/contributors","subscribers_url":"https://api.github.com/repos/jtangelder/axios/subscribers","subscription_url":"https://api.github.com/repos/jtangelder/axios/subscription","commits_url":"https://api.github.com/repos/jtangelder/axios/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtangelder/axios/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtangelder/axios/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtangelder/axios/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtangelder/axios/contents/{+path}","compare_url":"https://api.github.com/repos/jtangelder/axios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtangelder/axios/merges","archive_url":"https://api.github.com/repos/jtangelder/axios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtangelder/axios/downloads","issues_url":"https://api.github.com/repos/jtangelder/axios/issues{/number}","pulls_url":"https://api.github.com/repos/jtangelder/axios/pulls{/number}","milestones_url":"https://api.github.com/repos/jtangelder/axios/milestones{/number}","notifications_url":"https://api.github.com/repos/jtangelder/axios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtangelder/axios/labels{/name}","releases_url":"https://api.github.com/repos/jtangelder/axios/releases{/id}","created_at":"2015-10-26T09:38:29Z","updated_at":"2015-10-26T09:38:30Z","pushed_at":"2016-01-03T11:17:52Z","git_url":"git://github.com/jtangelder/axios.git","ssh_url":"git@github.com:jtangelder/axios.git","clone_url":"https://github.com/jtangelder/axios.git","svn_url":"https://github.com/jtangelder/axios","homepage":"","size":1276,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mzabriskie:master","ref":"master","sha":"6265b5440953930c8788a090f2e49b84272b0569","user":{"login":"mzabriskie","id":199035,"avatar_url":"https://avatars.githubusercontent.com/u/199035?v=3","gravatar_id":"","url":"https://api.github.com/users/mzabriskie","html_url":"https://github.com/mzabriskie","followers_url":"https://api.github.com/users/mzabriskie/followers","following_url":"https://api.github.com/users/mzabriskie/following{/other_user}","gists_url":"https://api.github.com/users/mzabriskie/gists{/gist_id}","starred_url":"https://api.github.com/users/mzabriskie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzabriskie/subscriptions","organizations_url":"https://api.github.com/users/mzabriskie/orgs","repos_url":"https://api.github.com/users/mzabriskie/repos","events_url":"https://api.github.com/users/mzabriskie/events{/privacy}","received_events_url":"https://api.github.com/users/mzabriskie/received_events","type":"User","site_admin":false},"repo":{"id":23088740,"name":"axios","full_name":"mzabriskie/axios","owner":{"login":"mzabriskie","id":199035,"avatar_url":"https://avatars.githubusercontent.com/u/199035?v=3","gravatar_id":"","url":"https://api.github.com/users/mzabriskie","html_url":"https://github.com/mzabriskie","followers_url":"https://api.github.com/users/mzabriskie/followers","following_url":"https://api.github.com/users/mzabriskie/following{/other_user}","gists_url":"https://api.github.com/users/mzabriskie/gists{/gist_id}","starred_url":"https://api.github.com/users/mzabriskie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzabriskie/subscriptions","organizations_url":"https://api.github.com/users/mzabriskie/orgs","repos_url":"https://api.github.com/users/mzabriskie/repos","events_url":"https://api.github.com/users/mzabriskie/events{/privacy}","received_events_url":"https://api.github.com/users/mzabriskie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mzabriskie/axios","description":"Promise based HTTP client for the browser and node.js","fork":false,"url":"https://api.github.com/repos/mzabriskie/axios","forks_url":"https://api.github.com/repos/mzabriskie/axios/forks","keys_url":"https://api.github.com/repos/mzabriskie/axios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mzabriskie/axios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mzabriskie/axios/teams","hooks_url":"https://api.github.com/repos/mzabriskie/axios/hooks","issue_events_url":"https://api.github.com/repos/mzabriskie/axios/issues/events{/number}","events_url":"https://api.github.com/repos/mzabriskie/axios/events","assignees_url":"https://api.github.com/repos/mzabriskie/axios/assignees{/user}","branches_url":"https://api.github.com/repos/mzabriskie/axios/branches{/branch}","tags_url":"https://api.github.com/repos/mzabriskie/axios/tags","blobs_url":"https://api.github.com/repos/mzabriskie/axios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mzabriskie/axios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mzabriskie/axios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mzabriskie/axios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mzabriskie/axios/statuses/{sha}","languages_url":"https://api.github.com/repos/mzabriskie/axios/languages","stargazers_url":"https://api.github.com/repos/mzabriskie/axios/stargazers","contributors_url":"https://api.github.com/repos/mzabriskie/axios/contributors","subscribers_url":"https://api.github.com/repos/mzabriskie/axios/subscribers","subscription_url":"https://api.github.com/repos/mzabriskie/axios/subscription","commits_url":"https://api.github.com/repos/mzabriskie/axios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mzabriskie/axios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mzabriskie/axios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mzabriskie/axios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mzabriskie/axios/contents/{+path}","compare_url":"https://api.github.com/repos/mzabriskie/axios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mzabriskie/axios/merges","archive_url":"https://api.github.com/repos/mzabriskie/axios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mzabriskie/axios/downloads","issues_url":"https://api.github.com/repos/mzabriskie/axios/issues{/number}","pulls_url":"https://api.github.com/repos/mzabriskie/axios/pulls{/number}","milestones_url":"https://api.github.com/repos/mzabriskie/axios/milestones{/number}","notifications_url":"https://api.github.com/repos/mzabriskie/axios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mzabriskie/axios/labels{/name}","releases_url":"https://api.github.com/repos/mzabriskie/axios/releases{/id}","created_at":"2014-08-18T22:30:27Z","updated_at":"2016-01-17T20:51:31Z","pushed_at":"2016-01-17T21:35:46Z","git_url":"git://github.com/mzabriskie/axios.git","ssh_url":"git@github.com:mzabriskie/axios.git","clone_url":"https://github.com/mzabriskie/axios.git","svn_url":"https://github.com/mzabriskie/axios","homepage":"","size":1374,"stargazers_count":1991,"watchers_count":1991,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":45,"forks":123,"open_issues":45,"watchers":1991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mzabriskie/axios/pulls/185"},"html":{"href":"https://github.com/mzabriskie/axios/pull/185"},"issue":{"href":"https://api.github.com/repos/mzabriskie/axios/issues/185"},"comments":{"href":"https://api.github.com/repos/mzabriskie/axios/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/mzabriskie/axios/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/mzabriskie/axios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mzabriskie/axios/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/mzabriskie/axios/statuses/ef6bfe8cb2d22e691a7f1d3dcd9dc0e1039b9b23"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mzabriskie","id":199035,"avatar_url":"https://avatars.githubusercontent.com/u/199035?v=3","gravatar_id":"","url":"https://api.github.com/users/mzabriskie","html_url":"https://github.com/mzabriskie","followers_url":"https://api.github.com/users/mzabriskie/followers","following_url":"https://api.github.com/users/mzabriskie/following{/other_user}","gists_url":"https://api.github.com/users/mzabriskie/gists{/gist_id}","starred_url":"https://api.github.com/users/mzabriskie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzabriskie/subscriptions","organizations_url":"https://api.github.com/users/mzabriskie/orgs","repos_url":"https://api.github.com/users/mzabriskie/repos","events_url":"https://api.github.com/users/mzabriskie/events{/privacy}","received_events_url":"https://api.github.com/users/mzabriskie/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":4,"additions":82,"deletions":59,"changed_files":6}}