{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/9774","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/9774/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/9774/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/9774/events","html_url":"https://github.com/dotnet/corefx/pull/9774","id":163150381,"number":9774,"title":"Fix Console.In.Peek and friends","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-30T12:12:23Z","updated_at":"2016-06-30T16:27:14Z","closed_at":"2016-06-30T16:18:33Z","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/9774","html_url":"https://github.com/dotnet/corefx/pull/9774","diff_url":"https://github.com/dotnet/corefx/pull/9774.diff","patch_url":"https://github.com/dotnet/corefx/pull/9774.patch"},"body":"The StdInStreamReader used on Unix as the TextReader used in Console.In derives from StreamReader and is passed the ConsoleStream for stdin.  This is both unnecessary and problematic.  It's unnecessary because all of the reading is done via special functions exposed from System.Native.so.  It's problematic because the base StreamReader does its own buffering based on the ConsoleStream and not all of the functions have been overridden by the StdInStreamReader.  As a result, for example, calling Read(char[], int, int) ends up bypassing previously cached data.\r\n\r\nThis commit does two main things:\r\n- Renames StdInStreamReader to StdInReader and changes it from deriving from StreamReader to deriving from the base TextReader.  The only functions that must be overridden on TextReader to enable the behavior for the rest are Read and Peek.\r\n- Adds an override of Peek.  Read is already overridden.\r\n\r\nFixes https://github.com/dotnet/corefx/issues/9767\r\ncc: @ianhays, @ellismg, @swgillespie "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/229712514","html_url":"https://github.com/dotnet/corefx/pull/9774#issuecomment-229712514","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/9774","id":229712514,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:27:14Z","updated_at":"2016-06-30T16:27:14Z","body":"> Thanks for the quick turnaround!\r\n\r\n:smile: Thanks for raising the issue."}}
{"actor":{"display_login":"stephentoub"}}