{"action":"closed","issue":{"url":"https://api.github.com/repos/Microsoft/node-uwp/issues/12","labels_url":"https://api.github.com/repos/Microsoft/node-uwp/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/node-uwp/issues/12/comments","events_url":"https://api.github.com/repos/Microsoft/node-uwp/issues/12/events","html_url":"https://github.com/Microsoft/node-uwp/issues/12","id":125845616,"number":12,"title":"Incompatibility with nan 2.2.0","user":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kunalspathak","id":12488060,"avatar_url":"https://avatars.githubusercontent.com/u/12488060?v=3","gravatar_id":"","url":"https://api.github.com/users/kunalspathak","html_url":"https://github.com/kunalspathak","followers_url":"https://api.github.com/users/kunalspathak/followers","following_url":"https://api.github.com/users/kunalspathak/following{/other_user}","gists_url":"https://api.github.com/users/kunalspathak/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalspathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalspathak/subscriptions","organizations_url":"https://api.github.com/users/kunalspathak/orgs","repos_url":"https://api.github.com/users/kunalspathak/repos","events_url":"https://api.github.com/users/kunalspathak/events{/privacy}","received_events_url":"https://api.github.com/users/kunalspathak/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2016-01-10T20:59:34Z","updated_at":"2016-01-28T22:07:04Z","closed_at":"2016-01-28T22:07:04Z","body":"`npm install uwp` gave me some compile errors  (please forgive my localized msbuild printing some messages in French):\r\n\r\n```\r\n\"C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\binding.sln\" (cible par défaut) (1) ->\r\n\"C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj\" (cible par défaut) (2) ->\r\n(ClCompile cible) ->\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(135): warning C4005: 'TYPE_CHECK': macro redefinition [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n\r\n\r\n\"C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\binding.sln\" (cible par défaut) (1) ->\r\n\"C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj\" (cible par défaut) (2) ->\r\n(ClCompile cible) ->\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(605): error C2039: 'GCCallback': is not a member of 'v8::Isolate' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(605): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(605): error C2146: syntax error: missing ';' before identifier 'GCEpilogueCallback' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(606): error C2039: 'GCCallback': is not a member of 'v8::Isolate' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(611): error C2146: syntax error: missing ')' before identifier 'callback' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(611): error C2143: syntax error: missing ';' before '{' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(611): error C2447: '{': missing function header (old-style formal list?) [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(616): error C2146: syntax error: missing ')' before identifier 'callback' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(616): error C2143: syntax error: missing ';' before '{' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(616): error C2447: '{': missing function header (old-style formal list?) [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(623): error C2664: 'void v8::Isolate::AddGCPrologueCallback(v8::Isolate::GCPrologueCallback,v8::GCType)': cannot convert argument 1 from 'Nan::GCPrologueCallback' to 'v8::Isolate ::GCPrologueCallback' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n  C:\\Dropbox\\Coding\\bb8-2\\node_modules\\nan\\nan.h(628): error C2664: 'void v8::Isolate::RemoveGCPrologueCallback(v8::Isolate::GCPrologueCallback)': cannot convert argument 1 from 'Nan::GCPrologueCallback' to 'v8::Isolate::GCProl ogueCallback' [C:\\Dropbox\\Coding\\bb8-2\\node_modules\\uwp\\build\\uwp.vcxproj]\r\n```\r\n\r\nSince the errors were clearly complaining about nan, I thought I would check the version of nan that was used. Your `package.json` mentions `^2.1.0`, which resolved to `2.2.0`. I guessed that maybe you didn't test `uwp` with nan `2.2.0`, so I cloned this repo on my disk, changed the nan version in `package.json` to `~2.1.0`, ran `npm i /path/to/my/cloned/uwp` and it worked.\r\n\r\nSo maybe nan messed up and there is a breaking change between 2.1 and 2.2, or maybe uwp is using some internal nan APIs that were changed between 2.1 and 2.2. Anyway, a quick fix is to change the `package.json` nan dependency to `~2.1.0` or even `2.1.0`."}}