{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/finagle/issues/513","repository_url":"https://api.github.com/repos/twitter/finagle","labels_url":"https://api.github.com/repos/twitter/finagle/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/513/comments","events_url":"https://api.github.com/repos/twitter/finagle/issues/513/events","html_url":"https://github.com/twitter/finagle/pull/513","id":157715425,"number":513,"title":"Extract transport agnostic zipkin code into finagle-zipkin-core","user":{"login":"sveinnfannar","id":751254,"avatar_url":"https://avatars.githubusercontent.com/u/751254?v=3","gravatar_id":"","url":"https://api.github.com/users/sveinnfannar","html_url":"https://github.com/sveinnfannar","followers_url":"https://api.github.com/users/sveinnfannar/followers","following_url":"https://api.github.com/users/sveinnfannar/following{/other_user}","gists_url":"https://api.github.com/users/sveinnfannar/gists{/gist_id}","starred_url":"https://api.github.com/users/sveinnfannar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveinnfannar/subscriptions","organizations_url":"https://api.github.com/users/sveinnfannar/orgs","repos_url":"https://api.github.com/users/sveinnfannar/repos","events_url":"https://api.github.com/users/sveinnfannar/events{/privacy}","received_events_url":"https://api.github.com/users/sveinnfannar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-05-31T16:32:39Z","updated_at":"2016-06-03T22:49:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/513","html_url":"https://github.com/twitter/finagle/pull/513","diff_url":"https://github.com/twitter/finagle/pull/513.diff","patch_url":"https://github.com/twitter/finagle/pull/513.patch"},"body":"Problem\r\n\r\nAddress issue https://github.com/twitter/finagle/issues/465 (Add http and kafka transports to zipkin-tracer).\r\nZipkin can receive traces via Kafka, HTTP and Scribe. Some Finagle users (including Quizup) already using Kafka are reluctant to introduce Scribe into their stack as it is no longer maintained.\r\nSo the purpose of this PR is to support Kafka as a transport for Zipkin traces, as well as structuring the code such that it allows other transports to be added (like HTTP).\r\n\r\n\r\nSolution\r\n\r\nExtract most of finagle-zipkin into finagle-zipkin-core, leaving finagle-zipkin with only scribe specific stuff (with no api breaking changes to finagle-zipkin of course). ~~Then implement finagle-zipkin-kafka, which depends on finagle-zipkin-core~~. Kafka transport will be introduced in a separate PR.\r\n\r\nThis structure was initially suggested by @kevinoliver in https://github.com/twitter/finagle/issues/465#issuecomment-183012155. \r\n\r\n\r\nTodo\r\n\r\n - [x] Extract common code into finagle-zipkin-core (largest part)\r\n - [ ] ~~Implement finagle-zipkin-kafka (in progress)~~ (separate PR)\r\n - [x] Clean up Pants and SBT dependencies\r\n\r\n\r\nQuestions\r\n\r\n@mosesn can you check this out and provide some feedback?\r\n@adriancole is this in line with what you had envisioned?"},"comment":{"url":"https://api.github.com/repos/twitter/finagle/issues/comments/223713013","html_url":"https://github.com/twitter/finagle/pull/513#issuecomment-223713013","issue_url":"https://api.github.com/repos/twitter/finagle/issues/513","id":223713013,"user":{"login":"kevinoliver","id":347229,"avatar_url":"https://avatars.githubusercontent.com/u/347229?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinoliver","html_url":"https://github.com/kevinoliver","followers_url":"https://api.github.com/users/kevinoliver/followers","following_url":"https://api.github.com/users/kevinoliver/following{/other_user}","gists_url":"https://api.github.com/users/kevinoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinoliver/subscriptions","organizations_url":"https://api.github.com/users/kevinoliver/orgs","repos_url":"https://api.github.com/users/kevinoliver/repos","events_url":"https://api.github.com/users/kevinoliver/events{/privacy}","received_events_url":"https://api.github.com/users/kevinoliver/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T22:49:58Z","updated_at":"2016-06-03T22:49:58Z","body":"@sveinnfannar ok looking good to me. mind fixing this round and pinging when its good?"}}
{"actor":{"display_login":"kevinoliver"}}