{"action":"created","issue":{"url":"https://api.github.com/repos/jgarzik/picocoin/issues/84","repository_url":"https://api.github.com/repos/jgarzik/picocoin","labels_url":"https://api.github.com/repos/jgarzik/picocoin/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/jgarzik/picocoin/issues/84/comments","events_url":"https://api.github.com/repos/jgarzik/picocoin/issues/84/events","html_url":"https://github.com/jgarzik/picocoin/pull/84","id":166225549,"number":84,"title":"ccoin: Add a simple logging framework","user":{"login":"aido","id":2703875,"avatar_url":"https://avatars.githubusercontent.com/u/2703875?v=3","gravatar_id":"","url":"https://api.github.com/users/aido","html_url":"https://github.com/aido","followers_url":"https://api.github.com/users/aido/followers","following_url":"https://api.github.com/users/aido/following{/other_user}","gists_url":"https://api.github.com/users/aido/gists{/gist_id}","starred_url":"https://api.github.com/users/aido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aido/subscriptions","organizations_url":"https://api.github.com/users/aido/orgs","repos_url":"https://api.github.com/users/aido/repos","events_url":"https://api.github.com/users/aido/events{/privacy}","received_events_url":"https://api.github.com/users/aido/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-07-19T00:53:46Z","updated_at":"2016-07-26T20:27:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jgarzik/picocoin/pulls/84","html_url":"https://github.com/jgarzik/picocoin/pull/84","diff_url":"https://github.com/jgarzik/picocoin/pull/84.diff","patch_url":"https://github.com/jgarzik/picocoin/pull/84.patch"},"body":"Hi,\r\n\r\nWhen modularizing the net code a negative side effect was that for logging and debugging to still work as before the `bool debugging` and `FILE *plog``variables had to passed through a few net functions and structures,\r\n```\r\nstruct net_child_info {\r\n.\r\n.\r\n\tbool\t\t\tdebugging;\r\n\tFILE\t\t\t*plog;\r\n.\r\n.\r\n};\r\n\r\nstruct net_engine {\r\n.\r\n.\r\n\tbool\tdebugging;\r\n\tFILE\t*plog;\r\n.\r\n.\r\n};\r\n\r\nstruct net_engine *neteng_new_start(void (*network_child)(int read_fd, int write_fd), bool debugging, FILE *plog);\r\n```\r\n\r\nThis pull request creates a simple log framework so the  `bool debugging` and `FILE *plog` variables don't need to be passed from function to function. It also adds a timestamp to brd log files,"},"comment":{"url":"https://api.github.com/repos/jgarzik/picocoin/issues/comments/235394315","html_url":"https://github.com/jgarzik/picocoin/pull/84#issuecomment-235394315","issue_url":"https://api.github.com/repos/jgarzik/picocoin/issues/84","id":235394315,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T20:27:27Z","updated_at":"2016-07-26T20:27:27Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7173899/badge)](https://coveralls.io/builds/7173899)\n\nCoverage decreased (-0.07%) to 74.208% when pulling **8052ea5c85076cfe903675e362bd3085710e09d8 on aido:log** into **b36c27f07a987b7aa6525353d6bbfe124058c447 on jgarzik:master**.\n"}}
{"actor":{"display_login":"coveralls"}}