{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments/63396579","id":63396579,"diff_hunk":"@@ -47,9 +47,12 @@ type ImageDestination interface {\n // Image is a Docker image in a repository.\n type Image interface {\n \t// ref to repository?\n+\t// GetManifest is like ImageSource.GetManifest, but the result is cached; it is OK to call this however often you need.\n+\tGetManifest() ([]byte, error)\n+\t// GetSignatures is like ImageSource.GetSignatures, but the result is cached; it is OK to call this however often you need.\n+\tGetSignatures() ([][]byte, error)","path":"types/types.go","position":null,"original_position":7,"commit_id":"e4913bd0b04767ea1efca1f9f0b3501347129b05","original_commit_id":"feb9de4845ce72e6b53b5ca38c6733be246ecbe0","user":{"login":"mtrmac","id":7052838,"avatar_url":"https://avatars.githubusercontent.com/u/7052838?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"body":"I do think that the source/destination distinction is useful; but for sources, this PR already goes a long way towards most users using a `types.Image` and not caring about `ImageSource` at all (basically unless you need layer contents, in which case tarball streams and ordering etc. are really important, `Image` gives you the same information and the caching and parsing makes it the preferred interface.).","created_at":"2016-05-16T18:03:18Z","updated_at":"2016-05-16T18:03:18Z","html_url":"https://github.com/projectatomic/skopeo/pull/57#discussion_r63396579","pull_request_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments/63396579"},"html":{"href":"https://github.com/projectatomic/skopeo/pull/57#discussion_r63396579"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/skopeo/pulls/57","id":70231087,"html_url":"https://github.com/projectatomic/skopeo/pull/57","diff_url":"https://github.com/projectatomic/skopeo/pull/57.diff","patch_url":"https://github.com/projectatomic/skopeo/pull/57.patch","issue_url":"https://api.github.com/repos/projectatomic/skopeo/issues/57","number":57,"state":"open","locked":false,"title":"API for signatures","user":{"login":"mtrmac","id":7052838,"avatar_url":"https://avatars.githubusercontent.com/u/7052838?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"body":"This adds methods useful for validating signatures to `types.Image`, namely the ability to retrieve signatures, and the supposedly signed identity, and renames `RawManifest` for consistency.\r\n\r\nThe implementation remains Docker-specific (in particular, not usable for OpenShift), but having the type and API will allow the policy evaluation code to compile, which is on my critical path now.\r\n\r\nSee comments in the individual commits for details.","created_at":"2016-05-16T17:34:01Z","updated_at":"2016-05-16T18:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce075a75829e387e3306d9d495d637812c98441c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/57/commits","review_comments_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/57/comments","review_comment_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/skopeo/issues/57/comments","statuses_url":"https://api.github.com/repos/projectatomic/skopeo/statuses/e4913bd0b04767ea1efca1f9f0b3501347129b05","head":{"label":"mtrmac:api-for-signatures","ref":"api-for-signatures","sha":"e4913bd0b04767ea1efca1f9f0b3501347129b05","user":{"login":"mtrmac","id":7052838,"avatar_url":"https://avatars.githubusercontent.com/u/7052838?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"repo":{"id":53720952,"name":"skopeo","full_name":"mtrmac/skopeo","owner":{"login":"mtrmac","id":7052838,"avatar_url":"https://avatars.githubusercontent.com/u/7052838?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtrmac/skopeo","description":" Work with remote images registries - retrieving information, images, signing content ","fork":true,"url":"https://api.github.com/repos/mtrmac/skopeo","forks_url":"https://api.github.com/repos/mtrmac/skopeo/forks","keys_url":"https://api.github.com/repos/mtrmac/skopeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtrmac/skopeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtrmac/skopeo/teams","hooks_url":"https://api.github.com/repos/mtrmac/skopeo/hooks","issue_events_url":"https://api.github.com/repos/mtrmac/skopeo/issues/events{/number}","events_url":"https://api.github.com/repos/mtrmac/skopeo/events","assignees_url":"https://api.github.com/repos/mtrmac/skopeo/assignees{/user}","branches_url":"https://api.github.com/repos/mtrmac/skopeo/branches{/branch}","tags_url":"https://api.github.com/repos/mtrmac/skopeo/tags","blobs_url":"https://api.github.com/repos/mtrmac/skopeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtrmac/skopeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtrmac/skopeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtrmac/skopeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtrmac/skopeo/statuses/{sha}","languages_url":"https://api.github.com/repos/mtrmac/skopeo/languages","stargazers_url":"https://api.github.com/repos/mtrmac/skopeo/stargazers","contributors_url":"https://api.github.com/repos/mtrmac/skopeo/contributors","subscribers_url":"https://api.github.com/repos/mtrmac/skopeo/subscribers","subscription_url":"https://api.github.com/repos/mtrmac/skopeo/subscription","commits_url":"https://api.github.com/repos/mtrmac/skopeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtrmac/skopeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtrmac/skopeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtrmac/skopeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtrmac/skopeo/contents/{+path}","compare_url":"https://api.github.com/repos/mtrmac/skopeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtrmac/skopeo/merges","archive_url":"https://api.github.com/repos/mtrmac/skopeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtrmac/skopeo/downloads","issues_url":"https://api.github.com/repos/mtrmac/skopeo/issues{/number}","pulls_url":"https://api.github.com/repos/mtrmac/skopeo/pulls{/number}","milestones_url":"https://api.github.com/repos/mtrmac/skopeo/milestones{/number}","notifications_url":"https://api.github.com/repos/mtrmac/skopeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtrmac/skopeo/labels{/name}","releases_url":"https://api.github.com/repos/mtrmac/skopeo/releases{/id}","deployments_url":"https://api.github.com/repos/mtrmac/skopeo/deployments","created_at":"2016-03-12T08:17:36Z","updated_at":"2016-05-16T16:30:07Z","pushed_at":"2016-05-16T17:41:29Z","git_url":"git://github.com/mtrmac/skopeo.git","ssh_url":"git@github.com:mtrmac/skopeo.git","clone_url":"https://github.com/mtrmac/skopeo.git","svn_url":"https://github.com/mtrmac/skopeo","homepage":"","size":1630,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"a39474c8171b13687a8c145749aeba17f8e5e784","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":53356367,"name":"skopeo","full_name":"projectatomic/skopeo","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/skopeo","description":"Work with remote images registries - retrieving information, images, signing content","fork":false,"url":"https://api.github.com/repos/projectatomic/skopeo","forks_url":"https://api.github.com/repos/projectatomic/skopeo/forks","keys_url":"https://api.github.com/repos/projectatomic/skopeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/skopeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/skopeo/teams","hooks_url":"https://api.github.com/repos/projectatomic/skopeo/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/skopeo/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/skopeo/events","assignees_url":"https://api.github.com/repos/projectatomic/skopeo/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/skopeo/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/skopeo/tags","blobs_url":"https://api.github.com/repos/projectatomic/skopeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/skopeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/skopeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/skopeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/skopeo/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/skopeo/languages","stargazers_url":"https://api.github.com/repos/projectatomic/skopeo/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/skopeo/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/skopeo/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/skopeo/subscription","commits_url":"https://api.github.com/repos/projectatomic/skopeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/skopeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/skopeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/skopeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/skopeo/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/skopeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/skopeo/merges","archive_url":"https://api.github.com/repos/projectatomic/skopeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/skopeo/downloads","issues_url":"https://api.github.com/repos/projectatomic/skopeo/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/skopeo/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/skopeo/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/skopeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/skopeo/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/skopeo/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/skopeo/deployments","created_at":"2016-03-07T20:23:29Z","updated_at":"2016-05-09T18:25:28Z","pushed_at":"2016-05-16T17:41:29Z","git_url":"git://github.com/projectatomic/skopeo.git","ssh_url":"git@github.com:projectatomic/skopeo.git","clone_url":"https://github.com/projectatomic/skopeo.git","svn_url":"https://github.com/projectatomic/skopeo","homepage":"","size":1646,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/57"},"html":{"href":"https://github.com/projectatomic/skopeo/pull/57"},"issue":{"href":"https://api.github.com/repos/projectatomic/skopeo/issues/57"},"comments":{"href":"https://api.github.com/repos/projectatomic/skopeo/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/skopeo/statuses/e4913bd0b04767ea1efca1f9f0b3501347129b05"}}}}