{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/77033989","id":77033989,"diff_hunk":"@@ -89,6 +89,10 @@ public static void main (String args[]) {\n                     printUsageAndExit(options, OPTION_ZK_SERVERS_LONG + \" and \" + OPTION_ZK_COMMITTED_NODE_LONG + \" are required  with \" +\n                             OPTION_OLD_CONSUMER_LONG);\n                 }\n+                String zkNode = commandLine.getOptionValue(OPTION_ZK_COMMITTED_NODE_LONG);","path":"external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java","position":4,"original_position":4,"commit_id":"e61e7738328913ec429742cd2b3cb22a39eb263f","original_commit_id":"e61e7738328913ec429742cd2b3cb22a39eb263f","user":{"login":"priyank5485","id":5192436,"avatar_url":"https://avatars.githubusercontent.com/u/5192436?v=3","gravatar_id":"","url":"https://api.github.com/users/priyank5485","html_url":"https://github.com/priyank5485","followers_url":"https://api.github.com/users/priyank5485/followers","following_url":"https://api.github.com/users/priyank5485/following{/other_user}","gists_url":"https://api.github.com/users/priyank5485/gists{/gist_id}","starred_url":"https://api.github.com/users/priyank5485/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyank5485/subscriptions","organizations_url":"https://api.github.com/users/priyank5485/orgs","repos_url":"https://api.github.com/users/priyank5485/repos","events_url":"https://api.github.com/users/priyank5485/events{/privacy}","received_events_url":"https://api.github.com/users/priyank5485/received_events","type":"User","site_admin":false},"body":"While adding OPTION_ZK_NODE_COMMITTED_NODE_LONG to options it is added using the method options.addOption(String opt, String longOpt, boolean hasArg, String description) The third argument is set to true in the call which specifies that the argument must have a value. Does not that take care of null or empty value? Do we need to have this explicit check here?","created_at":"2016-08-31T17:32:49Z","updated_at":"2016-08-31T17:32:50Z","html_url":"https://github.com/apache/storm/pull/1665#discussion_r77033989","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1665","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/77033989"},"html":{"href":"https://github.com/apache/storm/pull/1665#discussion_r77033989"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1665"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1665","id":83472005,"html_url":"https://github.com/apache/storm/pull/1665","diff_url":"https://github.com/apache/storm/pull/1665.diff","patch_url":"https://github.com/apache/storm/pull/1665.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1665","number":1665,"state":"open","locked":false,"title":"STORM-2074: fix storm-kafka-monitor NPE bug","user":{"login":"vesense","id":6711230,"avatar_url":"https://avatars.githubusercontent.com/u/6711230?v=3","gravatar_id":"","url":"https://api.github.com/users/vesense","html_url":"https://github.com/vesense","followers_url":"https://api.github.com/users/vesense/followers","following_url":"https://api.github.com/users/vesense/following{/other_user}","gists_url":"https://api.github.com/users/vesense/gists{/gist_id}","starred_url":"https://api.github.com/users/vesense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesense/subscriptions","organizations_url":"https://api.github.com/users/vesense/orgs","repos_url":"https://api.github.com/users/vesense/repos","events_url":"https://api.github.com/users/vesense/events{/privacy}","received_events_url":"https://api.github.com/users/vesense/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/STORM-2074","created_at":"2016-08-31T15:12:29Z","updated_at":"2016-08-31T17:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b45214898218f01c7550e837a05343df095c464","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1665/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1665/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1665/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/e61e7738328913ec429742cd2b3cb22a39eb263f","head":{"label":"vesense:STORM-2074","ref":"STORM-2074","sha":"e61e7738328913ec429742cd2b3cb22a39eb263f","user":{"login":"vesense","id":6711230,"avatar_url":"https://avatars.githubusercontent.com/u/6711230?v=3","gravatar_id":"","url":"https://api.github.com/users/vesense","html_url":"https://github.com/vesense","followers_url":"https://api.github.com/users/vesense/followers","following_url":"https://api.github.com/users/vesense/following{/other_user}","gists_url":"https://api.github.com/users/vesense/gists{/gist_id}","starred_url":"https://api.github.com/users/vesense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesense/subscriptions","organizations_url":"https://api.github.com/users/vesense/orgs","repos_url":"https://api.github.com/users/vesense/repos","events_url":"https://api.github.com/users/vesense/events{/privacy}","received_events_url":"https://api.github.com/users/vesense/received_events","type":"User","site_admin":false},"repo":{"id":30167243,"name":"storm","full_name":"vesense/storm","owner":{"login":"vesense","id":6711230,"avatar_url":"https://avatars.githubusercontent.com/u/6711230?v=3","gravatar_id":"","url":"https://api.github.com/users/vesense","html_url":"https://github.com/vesense","followers_url":"https://api.github.com/users/vesense/followers","following_url":"https://api.github.com/users/vesense/following{/other_user}","gists_url":"https://api.github.com/users/vesense/gists{/gist_id}","starred_url":"https://api.github.com/users/vesense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesense/subscriptions","organizations_url":"https://api.github.com/users/vesense/orgs","repos_url":"https://api.github.com/users/vesense/repos","events_url":"https://api.github.com/users/vesense/events{/privacy}","received_events_url":"https://api.github.com/users/vesense/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vesense/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/vesense/storm","forks_url":"https://api.github.com/repos/vesense/storm/forks","keys_url":"https://api.github.com/repos/vesense/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vesense/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vesense/storm/teams","hooks_url":"https://api.github.com/repos/vesense/storm/hooks","issue_events_url":"https://api.github.com/repos/vesense/storm/issues/events{/number}","events_url":"https://api.github.com/repos/vesense/storm/events","assignees_url":"https://api.github.com/repos/vesense/storm/assignees{/user}","branches_url":"https://api.github.com/repos/vesense/storm/branches{/branch}","tags_url":"https://api.github.com/repos/vesense/storm/tags","blobs_url":"https://api.github.com/repos/vesense/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vesense/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vesense/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/vesense/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vesense/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/vesense/storm/languages","stargazers_url":"https://api.github.com/repos/vesense/storm/stargazers","contributors_url":"https://api.github.com/repos/vesense/storm/contributors","subscribers_url":"https://api.github.com/repos/vesense/storm/subscribers","subscription_url":"https://api.github.com/repos/vesense/storm/subscription","commits_url":"https://api.github.com/repos/vesense/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/vesense/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/vesense/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/vesense/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/vesense/storm/contents/{+path}","compare_url":"https://api.github.com/repos/vesense/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vesense/storm/merges","archive_url":"https://api.github.com/repos/vesense/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vesense/storm/downloads","issues_url":"https://api.github.com/repos/vesense/storm/issues{/number}","pulls_url":"https://api.github.com/repos/vesense/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/vesense/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/vesense/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vesense/storm/labels{/name}","releases_url":"https://api.github.com/repos/vesense/storm/releases{/id}","deployments_url":"https://api.github.com/repos/vesense/storm/deployments","created_at":"2015-02-02T02:07:13Z","updated_at":"2016-01-13T01:35:05Z","pushed_at":"2016-08-31T15:11:28Z","git_url":"git://github.com/vesense/storm.git","ssh_url":"git@github.com:vesense/storm.git","clone_url":"https://github.com/vesense/storm.git","svn_url":"https://github.com/vesense/storm","homepage":null,"size":107843,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a4bf2af9626a789d397a23059240ea8b06f9880e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-08-31T13:57:19Z","pushed_at":"2016-08-31T17:31:13Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":173840,"stargazers_count":3491,"watchers_count":3491,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2587,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":137,"forks":2587,"open_issues":137,"watchers":3491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1665"},"html":{"href":"https://github.com/apache/storm/pull/1665"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1665"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1665/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1665/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1665/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/e61e7738328913ec429742cd2b3cb22a39eb263f"}}}}
{"actor":{"display_login":"priyank5485"}}