{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/77179756","id":77179756,"diff_hunk":"@@ -68,6 +68,24 @@ MET::MET( double sumet_, const std::vector<CorrMETData>& corr_,\n     }\n }\n \n+// Copy constructor\n+//____________________________________________________________________________||\n+MET::MET( const MET& met ): ","path":"DataFormats/METReco/src/MET.cc","position":6,"original_position":6,"commit_id":"4aa761b6de91fa35c59cd9da7595ba43099d2e68","original_commit_id":"4aa761b6de91fa35c59cd9da7595ba43099d2e68","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"is this overload really doing anything other than the default copy constructor?\r\n~OK to stay","created_at":"2016-09-01T14:05:07Z","updated_at":"2016-09-01T14:05:07Z","html_url":"https://github.com/cms-sw/cmssw/pull/15565#discussion_r77179756","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/77179756"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15565#discussion_r77179756"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565","id":82360038,"html_url":"https://github.com/cms-sw/cmssw/pull/15565","diff_url":"https://github.com/cms-sw/cmssw/pull/15565.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15565.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15565","number":15565,"state":"open","locked":false,"title":"Puppi MET and MET significance fixes in the MET tool","user":{"login":"mmarionncern","id":5114248,"avatar_url":"https://avatars.githubusercontent.com/u/5114248?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarionncern","html_url":"https://github.com/mmarionncern","followers_url":"https://api.github.com/users/mmarionncern/followers","following_url":"https://api.github.com/users/mmarionncern/following{/other_user}","gists_url":"https://api.github.com/users/mmarionncern/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarionncern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarionncern/subscriptions","organizations_url":"https://api.github.com/users/mmarionncern/orgs","repos_url":"https://api.github.com/users/mmarionncern/repos","events_url":"https://api.github.com/users/mmarionncern/events{/privacy}","received_events_url":"https://api.github.com/users/mmarionncern/received_events","type":"User","site_admin":false},"body":"This PR fixes several bugs and inconsistencies in the PAT MET tool :\r\n- use of proper JECs for the Puppi MET\r\n- fix the MET significance storage when miniAOD are produced\r\n- update the MET significance tune\r\n- modify some MET constructors (RECO and PAT) to keep the met significance matrix when met objects is copied.\r\n\r\nChanges expected : \r\n- Puppi MET and its uncertainties\r\n- MET significance\r\n\r\nThe puppi MET results will have sense when #15562 will be integrated.\r\n\r\nPackages impacted:\r\n- DataFormats/METReco\r\n- DataFormats/PatCandidates\r\n- PhysicsTools/PatAlgos\r\n- PhysicsTools/PatUtils\r\n- RecoMET/METProducers\r\n\r\nLocal tests and matrix tests seems successfull.\r\n\r\nI will be out of office from August 27th to September 17th. If comments comes during that period, please contact @mariadalfonso and @zdemirag .\r\n\r\n","created_at":"2016-08-23T13:01:20Z","updated_at":"2016-09-01T14:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148535c41457d7e6f3477630050dd7cfd90be61d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":64,"closed_issues":1332,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-01T13:40:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15565/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/4aa761b6de91fa35c59cd9da7595ba43099d2e68","head":{"label":"cms-met:MM_PuppiFix810_100816","ref":"MM_PuppiFix810_100816","sha":"4aa761b6de91fa35c59cd9da7595ba43099d2e68","user":{"login":"cms-met","id":5247643,"avatar_url":"https://avatars.githubusercontent.com/u/5247643?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-met","html_url":"https://github.com/cms-met","followers_url":"https://api.github.com/users/cms-met/followers","following_url":"https://api.github.com/users/cms-met/following{/other_user}","gists_url":"https://api.github.com/users/cms-met/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-met/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-met/subscriptions","organizations_url":"https://api.github.com/users/cms-met/orgs","repos_url":"https://api.github.com/users/cms-met/repos","events_url":"https://api.github.com/users/cms-met/events{/privacy}","received_events_url":"https://api.github.com/users/cms-met/received_events","type":"Organization","site_admin":false},"repo":{"id":12169492,"name":"cmssw","full_name":"cms-met/cmssw","owner":{"login":"cms-met","id":5247643,"avatar_url":"https://avatars.githubusercontent.com/u/5247643?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-met","html_url":"https://github.com/cms-met","followers_url":"https://api.github.com/users/cms-met/followers","following_url":"https://api.github.com/users/cms-met/following{/other_user}","gists_url":"https://api.github.com/users/cms-met/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-met/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-met/subscriptions","organizations_url":"https://api.github.com/users/cms-met/orgs","repos_url":"https://api.github.com/users/cms-met/repos","events_url":"https://api.github.com/users/cms-met/events{/privacy}","received_events_url":"https://api.github.com/users/cms-met/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-met/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/cms-met/cmssw","forks_url":"https://api.github.com/repos/cms-met/cmssw/forks","keys_url":"https://api.github.com/repos/cms-met/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-met/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-met/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-met/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-met/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-met/cmssw/events","assignees_url":"https://api.github.com/repos/cms-met/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-met/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-met/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-met/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-met/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-met/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-met/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-met/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-met/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-met/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-met/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-met/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-met/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-met/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-met/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-met/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-met/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-met/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-met/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-met/cmssw/merges","archive_url":"https://api.github.com/repos/cms-met/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-met/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-met/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-met/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-met/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-met/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-met/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-met/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-met/cmssw/deployments","created_at":"2013-08-16T22:16:52Z","updated_at":"2015-04-24T10:21:36Z","pushed_at":"2016-08-31T15:36:18Z","git_url":"git://github.com/cms-met/cmssw.git","ssh_url":"git@github.com:cms-met/cmssw.git","clone_url":"https://github.com/cms-met/cmssw.git","svn_url":"https://github.com/cms-met/cmssw","homepage":"cms-sw.github.io/cmssw","size":902238,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"CMSSW_7_5_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"5486c49c9c84b86a2d522f9afc4055f626219e1a","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-08-30T23:51:00Z","pushed_at":"2016-09-01T14:03:48Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1104044,"stargazers_count":338,"watchers_count":338,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1961,"mirror_url":null,"open_issues_count":365,"forks":1961,"open_issues":365,"watchers":338,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15565"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15565"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15565/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15565/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/4aa761b6de91fa35c59cd9da7595ba43099d2e68"}}}}
{"actor":{"display_login":"slava77"}}