{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/60959645","id":60959645,"diff_hunk":"@@ -300,7 +300,7 @@ the following values:\n    treated like a TTY, and have ANSI/VT100 escape codes written to it.\n    Defaults to checking `isTTY` on the `output` stream upon instantiation.\n \n- - `historySize` - maximum number of history lines retained. Defaults to `30`.\n+ - `historySize` - maximum number of history lines retained. To disable the history set this value to `0`. Defaults to `30`.","path":"doc/api/readline.md","position":null,"original_position":5,"commit_id":"b673829bb9de8e773642eacb674a5eba2a20a498","original_commit_id":"2cc3d3971709d51aa95a685c7ea17082256ac958","user":{"login":"suryagh","id":5177920,"avatar_url":"https://avatars.githubusercontent.com/u/5177920?v=3","gravatar_id":"","url":"https://api.github.com/users/suryagh","html_url":"https://github.com/suryagh","followers_url":"https://api.github.com/users/suryagh/followers","following_url":"https://api.github.com/users/suryagh/following{/other_user}","gists_url":"https://api.github.com/users/suryagh/gists{/gist_id}","starred_url":"https://api.github.com/users/suryagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryagh/subscriptions","organizations_url":"https://api.github.com/users/suryagh/orgs","repos_url":"https://api.github.com/users/suryagh/repos","events_url":"https://api.github.com/users/suryagh/events{/privacy}","received_events_url":"https://api.github.com/users/suryagh/received_events","type":"User","site_admin":false},"body":"👍 Done.","created_at":"2016-04-25T18:07:49Z","updated_at":"2016-04-25T18:07:49Z","html_url":"https://github.com/nodejs/node/pull/6352#discussion_r60959645","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6352","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/60959645"},"html":{"href":"https://github.com/nodejs/node/pull/6352#discussion_r60959645"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6352"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6352","id":67584222,"html_url":"https://github.com/nodejs/node/pull/6352","diff_url":"https://github.com/nodejs/node/pull/6352.diff","patch_url":"https://github.com/nodejs/node/pull/6352.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6352","number":6352,"state":"open","locked":false,"title":"readline: Allow history to be disabled","user":{"login":"suryagh","id":5177920,"avatar_url":"https://avatars.githubusercontent.com/u/5177920?v=3","gravatar_id":"","url":"https://api.github.com/users/suryagh","html_url":"https://github.com/suryagh","followers_url":"https://api.github.com/users/suryagh/followers","following_url":"https://api.github.com/users/suryagh/following{/other_user}","gists_url":"https://api.github.com/users/suryagh/gists{/gist_id}","starred_url":"https://api.github.com/users/suryagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryagh/subscriptions","organizations_url":"https://api.github.com/users/suryagh/orgs","repos_url":"https://api.github.com/users/suryagh/repos","events_url":"https://api.github.com/users/suryagh/events{/privacy}","received_events_url":"https://api.github.com/users/suryagh/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request to Node.js. Before you submit, please\r\nreview below requirements and walk through the checklist. You can 'tick'\r\na box by using the letter \"x\": [x].\r\n\r\nRun the test suite by invoking: `make -j4 lint test` on linux or\r\n`vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. Finally – if possible – a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test is included\r\n- [x] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\nreadline\r\n\r\n##### Description of change\r\n\r\n<!-- provide a description of the change below this comment -->\r\n\r\nFixes #6336\r\n1.  The `historySize` to default to `30` only if `undefined`.\r\n2.  If `historySize` is set to 0, then disable caching the line.\r\n3.  Added unit tests.\r\n4.  Updated documentation.","created_at":"2016-04-22T23:01:07Z","updated_at":"2016-04-25T18:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0175b2b69697619016da9b41456dc86256121b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6352/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6352/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6352/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b673829bb9de8e773642eacb674a5eba2a20a498","head":{"label":"suryagh:fix","ref":"fix","sha":"b673829bb9de8e773642eacb674a5eba2a20a498","user":{"login":"suryagh","id":5177920,"avatar_url":"https://avatars.githubusercontent.com/u/5177920?v=3","gravatar_id":"","url":"https://api.github.com/users/suryagh","html_url":"https://github.com/suryagh","followers_url":"https://api.github.com/users/suryagh/followers","following_url":"https://api.github.com/users/suryagh/following{/other_user}","gists_url":"https://api.github.com/users/suryagh/gists{/gist_id}","starred_url":"https://api.github.com/users/suryagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryagh/subscriptions","organizations_url":"https://api.github.com/users/suryagh/orgs","repos_url":"https://api.github.com/users/suryagh/repos","events_url":"https://api.github.com/users/suryagh/events{/privacy}","received_events_url":"https://api.github.com/users/suryagh/received_events","type":"User","site_admin":false},"repo":{"id":55274816,"name":"node","full_name":"suryagh/node","owner":{"login":"suryagh","id":5177920,"avatar_url":"https://avatars.githubusercontent.com/u/5177920?v=3","gravatar_id":"","url":"https://api.github.com/users/suryagh","html_url":"https://github.com/suryagh","followers_url":"https://api.github.com/users/suryagh/followers","following_url":"https://api.github.com/users/suryagh/following{/other_user}","gists_url":"https://api.github.com/users/suryagh/gists{/gist_id}","starred_url":"https://api.github.com/users/suryagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryagh/subscriptions","organizations_url":"https://api.github.com/users/suryagh/orgs","repos_url":"https://api.github.com/users/suryagh/repos","events_url":"https://api.github.com/users/suryagh/events{/privacy}","received_events_url":"https://api.github.com/users/suryagh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suryagh/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/suryagh/node","forks_url":"https://api.github.com/repos/suryagh/node/forks","keys_url":"https://api.github.com/repos/suryagh/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suryagh/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suryagh/node/teams","hooks_url":"https://api.github.com/repos/suryagh/node/hooks","issue_events_url":"https://api.github.com/repos/suryagh/node/issues/events{/number}","events_url":"https://api.github.com/repos/suryagh/node/events","assignees_url":"https://api.github.com/repos/suryagh/node/assignees{/user}","branches_url":"https://api.github.com/repos/suryagh/node/branches{/branch}","tags_url":"https://api.github.com/repos/suryagh/node/tags","blobs_url":"https://api.github.com/repos/suryagh/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suryagh/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suryagh/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/suryagh/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suryagh/node/statuses/{sha}","languages_url":"https://api.github.com/repos/suryagh/node/languages","stargazers_url":"https://api.github.com/repos/suryagh/node/stargazers","contributors_url":"https://api.github.com/repos/suryagh/node/contributors","subscribers_url":"https://api.github.com/repos/suryagh/node/subscribers","subscription_url":"https://api.github.com/repos/suryagh/node/subscription","commits_url":"https://api.github.com/repos/suryagh/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/suryagh/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/suryagh/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/suryagh/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/suryagh/node/contents/{+path}","compare_url":"https://api.github.com/repos/suryagh/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suryagh/node/merges","archive_url":"https://api.github.com/repos/suryagh/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suryagh/node/downloads","issues_url":"https://api.github.com/repos/suryagh/node/issues{/number}","pulls_url":"https://api.github.com/repos/suryagh/node/pulls{/number}","milestones_url":"https://api.github.com/repos/suryagh/node/milestones{/number}","notifications_url":"https://api.github.com/repos/suryagh/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suryagh/node/labels{/name}","releases_url":"https://api.github.com/repos/suryagh/node/releases{/id}","deployments_url":"https://api.github.com/repos/suryagh/node/deployments","created_at":"2016-04-02T03:00:56Z","updated_at":"2016-04-02T03:01:07Z","pushed_at":"2016-04-25T18:07:09Z","git_url":"git://github.com/suryagh/node.git","ssh_url":"git@github.com:suryagh/node.git","clone_url":"https://github.com/suryagh/node.git","svn_url":"https://github.com/suryagh/node","homepage":"https://nodejs.org","size":187782,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"eb4201f07a1b1f430ddf4efad4f276f3088def97","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-04-25T18:01:42Z","pushed_at":"2016-04-25T18:07:10Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":246738,"stargazers_count":22381,"watchers_count":22381,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3072,"mirror_url":null,"open_issues_count":660,"forks":3072,"open_issues":660,"watchers":22381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6352"},"html":{"href":"https://github.com/nodejs/node/pull/6352"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6352"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6352/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6352/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6352/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b673829bb9de8e773642eacb674a5eba2a20a498"}}}}