{"comment":{"url":"https://api.github.com/repos/smeighan/xLights/comments/18364114","html_url":"https://github.com/smeighan/xLights/commit/e84e60a1d04aeb656f3f86db790979f4a80fd5df#commitcomment-18364114","id":18364114,"user":{"login":"keithsw1111","id":10283944,"avatar_url":"https://avatars.githubusercontent.com/u/10283944?v=3","gravatar_id":"","url":"https://api.github.com/users/keithsw1111","html_url":"https://github.com/keithsw1111","followers_url":"https://api.github.com/users/keithsw1111/followers","following_url":"https://api.github.com/users/keithsw1111/following{/other_user}","gists_url":"https://api.github.com/users/keithsw1111/gists{/gist_id}","starred_url":"https://api.github.com/users/keithsw1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithsw1111/subscriptions","organizations_url":"https://api.github.com/users/keithsw1111/orgs","repos_url":"https://api.github.com/users/keithsw1111/repos","events_url":"https://api.github.com/users/keithsw1111/events{/privacy}","received_events_url":"https://api.github.com/users/keithsw1111/received_events","type":"User","site_admin":false},"position":23,"line":733,"path":"xLights/TabConvert.cpp","commit_id":"e84e60a1d04aeb656f3f86db790979f4a80fd5df","created_at":"2016-07-22T20:02:48Z","updated_at":"2016-07-22T20:02:48Z","body":"Ok. That shouldn't be that hard to fix.\n\nSent from my iPhone\n\nOn 22 Jul 2016, at 10:32 PM, Daniel Kulp <notifications@github.com<mailto:notifications@github.com>> wrote:\n\n\nThis whole section is very very wrong..... the framedata may NOT be in RGB order. It might not even be RGB. It could be single channel data. It might not be in node order either. If you are using start channels to set a different order, the nodes won't be in order like that.\n\nYou need to use the frame data to set the data into the model and then read the color from the Node itself. The node can decode it properly .\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub<https://github.com/smeighan/xLights/commit/e84e60a1d04aeb656f3f86db790979f4a80fd5df#commitcomment-18356208>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJzrqGTDKrp3vG2vlGiLMcEoUb4XoGHSks5qYLhDgaJpZM4JSt1P>.\n\n************** IMPORTANT MESSAGE *****************************       \nThis e-mail message is intended only for the addressee(s) and contains information which may be\nconfidential. \nIf you are not the intended recipient please advise the sender by return email, do not use or\ndisclose the contents, and delete the message and any attachments from your system. Unless\nspecifically indicated, this email does not constitute formal advice or commitment by the sender\nor the Commonwealth Bank of Australia (ABN 48 123 123 124) or its subsidiaries. \nWe can be contacted through our web site: commbank.com.au. \nIf you no longer wish to receive commercial electronic messages from us, please reply to this\ne-mail by typing Unsubscribe in the subject line. \n**************************************************************\n\n\n"}}
{"actor":{"display_login":"keithsw1111"}}