{"action":"created","issue":{"url":"https://api.github.com/repos/piskvorky/gensim/issues/649","repository_url":"https://api.github.com/repos/piskvorky/gensim","labels_url":"https://api.github.com/repos/piskvorky/gensim/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/piskvorky/gensim/issues/649/comments","events_url":"https://api.github.com/repos/piskvorky/gensim/issues/649/events","html_url":"https://github.com/piskvorky/gensim/pull/649","id":144551901,"number":649,"title":"[MRG] ENH: Make normalization an explicit transformation.","user":{"login":"dsquareindia","id":9411999,"avatar_url":"https://avatars.githubusercontent.com/u/9411999?v=3","gravatar_id":"","url":"https://api.github.com/users/dsquareindia","html_url":"https://github.com/dsquareindia","followers_url":"https://api.github.com/users/dsquareindia/followers","following_url":"https://api.github.com/users/dsquareindia/following{/other_user}","gists_url":"https://api.github.com/users/dsquareindia/gists{/gist_id}","starred_url":"https://api.github.com/users/dsquareindia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsquareindia/subscriptions","organizations_url":"https://api.github.com/users/dsquareindia/orgs","repos_url":"https://api.github.com/users/dsquareindia/repos","events_url":"https://api.github.com/users/dsquareindia/events{/privacy}","received_events_url":"https://api.github.com/users/dsquareindia/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/piskvorky/gensim/labels/feature","name":"feature","color":"0b02e1"}],"state":"open","locked":false,"assignee":{"login":"tmylk","id":1261528,"avatar_url":"https://avatars.githubusercontent.com/u/1261528?v=3","gravatar_id":"","url":"https://api.github.com/users/tmylk","html_url":"https://github.com/tmylk","followers_url":"https://api.github.com/users/tmylk/followers","following_url":"https://api.github.com/users/tmylk/following{/other_user}","gists_url":"https://api.github.com/users/tmylk/gists{/gist_id}","starred_url":"https://api.github.com/users/tmylk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmylk/subscriptions","organizations_url":"https://api.github.com/users/tmylk/orgs","repos_url":"https://api.github.com/users/tmylk/repos","events_url":"https://api.github.com/users/tmylk/events{/privacy}","received_events_url":"https://api.github.com/users/tmylk/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-03-30T11:13:04Z","updated_at":"2016-04-21T06:24:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/piskvorky/gensim/pulls/649","html_url":"https://github.com/piskvorky/gensim/pull/649","diff_url":"https://github.com/piskvorky/gensim/pull/649.diff","patch_url":"https://github.com/piskvorky/gensim/pull/649.patch"},"body":"Addresses issue #69. What this PR includes:\r\n* Added support for ''l1' norm.\r\n* Added norm parameter to Similarity constructor.\r\n* Added norm parameter to matutils.unitvec.\r\n* Created file models/normmodel.py to make normalization an explicit transformation.\r\n\r\nTODO:\r\n- [X] Check for input validation\r\n- [X] Make test file test/test_norms.py\r\n- [X] Add tests for input validation using assertRaises\r\n- [X] Add documentation\r\n- [X] Add more tests to testTransform to cover all input type validations\r\n\r\n@piskvorky @tmylk Could you please tell me if I'm going on the right track?"},"comment":{"url":"https://api.github.com/repos/piskvorky/gensim/issues/comments/212765195","html_url":"https://github.com/piskvorky/gensim/pull/649#issuecomment-212765195","issue_url":"https://api.github.com/repos/piskvorky/gensim/issues/649","id":212765195,"user":{"login":"dsquareindia","id":9411999,"avatar_url":"https://avatars.githubusercontent.com/u/9411999?v=3","gravatar_id":"","url":"https://api.github.com/users/dsquareindia","html_url":"https://github.com/dsquareindia","followers_url":"https://api.github.com/users/dsquareindia/followers","following_url":"https://api.github.com/users/dsquareindia/following{/other_user}","gists_url":"https://api.github.com/users/dsquareindia/gists{/gist_id}","starred_url":"https://api.github.com/users/dsquareindia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsquareindia/subscriptions","organizations_url":"https://api.github.com/users/dsquareindia/orgs","repos_url":"https://api.github.com/users/dsquareindia/repos","events_url":"https://api.github.com/users/dsquareindia/events{/privacy}","received_events_url":"https://api.github.com/users/dsquareindia/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T06:24:27Z","updated_at":"2016-04-21T06:24:27Z","body":"Removed merge conflicts."}}