{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/36032","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/36032/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36032/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/36032/events","html_url":"https://github.com/rust-lang/rust/pull/36032","id":173581234,"number":36032,"title":"Use workspaces and switch to a single Cargo.lock.","user":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-27T06:29:47Z","updated_at":"2016-08-29T20:57:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36032","html_url":"https://github.com/rust-lang/rust/pull/36032","diff_url":"https://github.com/rust-lang/rust/pull/36032.diff","patch_url":"https://github.com/rust-lang/rust/pull/36032.patch"},"body":"This involves hacking the code used to run cargo test on various\r\npackages, because it reads Cargo.lock to determine which packages should\r\nbe tested. This change implements a blacklist, since that will catch new\r\ncrates when they are added in the future."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/243253817","html_url":"https://github.com/rust-lang/rust/pull/36032#issuecomment-243253817","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36032","id":243253817,"user":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T20:57:56Z","updated_at":"2016-08-29T20:57:56Z","body":"Isn't the issue here that bootstrap is forced to read `Cargo.lock` to determine dependencies rather than have it issue a cargo command which returns a list of dependencies? My preferred solution would be to have a cargo command that returns a list of dependencies and perhaps has modifiers for only listing path ones, or perhaps listing which type they are in the output, so it can be filtered. (I'd be willing to try making this change in cargo, if you agree and have pointers.)\r\n\r\nI'm not actually sure how that RFC is related to this at all.\r\n\r\nIf there's a change in cargo in the foreseeable future, then I don't really think it matters much what gets hardcoded today, since it will only last until the next cycle before it can be improved."}}
{"actor":{"display_login":"ahmedcharles"}}