{"action":"created","comment":{"url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/comments/70373956","id":70373956,"diff_hunk":"@@ -0,0 +1,108 @@\n+import os\n+import sys\n+import argparse\n+\n+import lsst.pex.config                  as pexConfig\n+import lsst.afw.table as afwTable\n+import lsst.afw.geom as afwGeom\n+from lsst.pipe.base import Task\n+\n+class CreateDetGeomConfig(pexConfig.Config):\n+    \"\"\"Configuration for creating the PFS detector geometry files\"\"\"\n+\n+class CreateDetGeomTask(Task):\n+    \"\"\"Task to create the detector geometry files for PFS\"\"\"\n+    ConfigClass = CreateDetGeomConfig\n+    _DefaultName = \"createDetGeomTask\"\n+\n+    def __init__(self, *args, **kwargs):\n+        super(CreateDetGeomTask, self).__init__(*args, **kwargs)\n+\n+    def run(self):\n+        gain = (1.24, 1.24, 1.27, 1.18, 1.26, 1.20, 1.24, 1.26)\n+        rdnoise = (3.61, 3.78, 3.18, 2.95, 3.19, 3.80, 4.51, 3.18)\n+        \n+        outDir = os.getenv('OBS_PFS_DIR', '~/stella_git/obs_pfs')\n+        print 'outDir = <',outDir,'>'\n+        outDir = outDir+'/pfs/camera'","path":"python/pfs/drp/stella/createDetGeom.py","position":27,"original_position":27,"commit_id":"8cb1e8e591ad665e6f1146aede21e23f2dcda94d","original_commit_id":"8cb1e8e591ad665e6f1146aede21e23f2dcda94d","user":{"login":"ziggyman","id":10981596,"avatar_url":"https://avatars.githubusercontent.com/u/10981596?v=3","gravatar_id":"","url":"https://api.github.com/users/ziggyman","html_url":"https://github.com/ziggyman","followers_url":"https://api.github.com/users/ziggyman/followers","following_url":"https://api.github.com/users/ziggyman/following{/other_user}","gists_url":"https://api.github.com/users/ziggyman/gists{/gist_id}","starred_url":"https://api.github.com/users/ziggyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziggyman/subscriptions","organizations_url":"https://api.github.com/users/ziggyman/orgs","repos_url":"https://api.github.com/users/ziggyman/repos","events_url":"https://api.github.com/users/ziggyman/events{/privacy}","received_events_url":"https://api.github.com/users/ziggyman/received_events","type":"User","site_admin":false},"body":"The output directory will not change so I removed it from the parameter list.\r\nYou are right, this should be an obs_pfs task. Originally it was an ipython notebook in drp_stella, before obs_pfs was created. Now it should really go into obs_pfs, so I moved both createDetGeom.py (bin.src and python/pfs/drp/stella) to obs_pfs (bin.src and python/lsst/obs/pfs)","created_at":"2016-07-12T03:54:06Z","updated_at":"2016-07-12T03:54:06Z","html_url":"https://github.com/Subaru-PFS/drp_stella/pull/1#discussion_r70373956","pull_request_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/comments/70373956"},"html":{"href":"https://github.com/Subaru-PFS/drp_stella/pull/1#discussion_r70373956"},"pull_request":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1","id":76000603,"html_url":"https://github.com/Subaru-PFS/drp_stella/pull/1","diff_url":"https://github.com/Subaru-PFS/drp_stella/pull/1.diff","patch_url":"https://github.com/Subaru-PFS/drp_stella/pull/1.patch","issue_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/1","number":1,"state":"open","locked":false,"title":"Review for INFRA-32","user":{"login":"jdswinbank","id":460854,"avatar_url":"https://avatars.githubusercontent.com/u/460854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdswinbank","html_url":"https://github.com/jdswinbank","followers_url":"https://api.github.com/users/jdswinbank/followers","following_url":"https://api.github.com/users/jdswinbank/following{/other_user}","gists_url":"https://api.github.com/users/jdswinbank/gists{/gist_id}","starred_url":"https://api.github.com/users/jdswinbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdswinbank/subscriptions","organizations_url":"https://api.github.com/users/jdswinbank/orgs","repos_url":"https://api.github.com/users/jdswinbank/repos","events_url":"https://api.github.com/users/jdswinbank/events{/privacy}","received_events_url":"https://api.github.com/users/jdswinbank/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-01T15:52:56Z","updated_at":"2016-07-12T03:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6edb0320c4f4a77e600596fbee34fc66cbaa476d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/1/comments","statuses_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/statuses/8cb1e8e591ad665e6f1146aede21e23f2dcda94d","head":{"label":"Subaru-PFS:tickets/INFRA-32","ref":"tickets/INFRA-32","sha":"8cb1e8e591ad665e6f1146aede21e23f2dcda94d","user":{"login":"Subaru-PFS","id":8980283,"avatar_url":"https://avatars.githubusercontent.com/u/8980283?v=3","gravatar_id":"","url":"https://api.github.com/users/Subaru-PFS","html_url":"https://github.com/Subaru-PFS","followers_url":"https://api.github.com/users/Subaru-PFS/followers","following_url":"https://api.github.com/users/Subaru-PFS/following{/other_user}","gists_url":"https://api.github.com/users/Subaru-PFS/gists{/gist_id}","starred_url":"https://api.github.com/users/Subaru-PFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subaru-PFS/subscriptions","organizations_url":"https://api.github.com/users/Subaru-PFS/orgs","repos_url":"https://api.github.com/users/Subaru-PFS/repos","events_url":"https://api.github.com/users/Subaru-PFS/events{/privacy}","received_events_url":"https://api.github.com/users/Subaru-PFS/received_events","type":"Organization","site_admin":false},"repo":{"id":53125359,"name":"drp_stella","full_name":"Subaru-PFS/drp_stella","owner":{"login":"Subaru-PFS","id":8980283,"avatar_url":"https://avatars.githubusercontent.com/u/8980283?v=3","gravatar_id":"","url":"https://api.github.com/users/Subaru-PFS","html_url":"https://github.com/Subaru-PFS","followers_url":"https://api.github.com/users/Subaru-PFS/followers","following_url":"https://api.github.com/users/Subaru-PFS/following{/other_user}","gists_url":"https://api.github.com/users/Subaru-PFS/gists{/gist_id}","starred_url":"https://api.github.com/users/Subaru-PFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subaru-PFS/subscriptions","organizations_url":"https://api.github.com/users/Subaru-PFS/orgs","repos_url":"https://api.github.com/users/Subaru-PFS/repos","events_url":"https://api.github.com/users/Subaru-PFS/events{/privacy}","received_events_url":"https://api.github.com/users/Subaru-PFS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Subaru-PFS/drp_stella","description":"2D DRP","fork":false,"url":"https://api.github.com/repos/Subaru-PFS/drp_stella","forks_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/forks","keys_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/teams","hooks_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/hooks","issue_events_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/events{/number}","events_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/events","assignees_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/assignees{/user}","branches_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/branches{/branch}","tags_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/tags","blobs_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/statuses/{sha}","languages_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/languages","stargazers_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/stargazers","contributors_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/contributors","subscribers_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/subscribers","subscription_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/subscription","commits_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/contents/{+path}","compare_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/merges","archive_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/downloads","issues_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues{/number}","pulls_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls{/number}","milestones_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/milestones{/number}","notifications_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/labels{/name}","releases_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/releases{/id}","deployments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/deployments","created_at":"2016-03-04T09:51:39Z","updated_at":"2016-06-27T17:14:50Z","pushed_at":"2016-07-11T23:15:48Z","git_url":"git://github.com/Subaru-PFS/drp_stella.git","ssh_url":"git@github.com:Subaru-PFS/drp_stella.git","clone_url":"https://github.com/Subaru-PFS/drp_stella.git","svn_url":"https://github.com/Subaru-PFS/drp_stella","homepage":null,"size":2154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Subaru-PFS:master","ref":"master","sha":"1d6e19ab0512228bbd688748cf58aa1cb8ecb467","user":{"login":"Subaru-PFS","id":8980283,"avatar_url":"https://avatars.githubusercontent.com/u/8980283?v=3","gravatar_id":"","url":"https://api.github.com/users/Subaru-PFS","html_url":"https://github.com/Subaru-PFS","followers_url":"https://api.github.com/users/Subaru-PFS/followers","following_url":"https://api.github.com/users/Subaru-PFS/following{/other_user}","gists_url":"https://api.github.com/users/Subaru-PFS/gists{/gist_id}","starred_url":"https://api.github.com/users/Subaru-PFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subaru-PFS/subscriptions","organizations_url":"https://api.github.com/users/Subaru-PFS/orgs","repos_url":"https://api.github.com/users/Subaru-PFS/repos","events_url":"https://api.github.com/users/Subaru-PFS/events{/privacy}","received_events_url":"https://api.github.com/users/Subaru-PFS/received_events","type":"Organization","site_admin":false},"repo":{"id":53125359,"name":"drp_stella","full_name":"Subaru-PFS/drp_stella","owner":{"login":"Subaru-PFS","id":8980283,"avatar_url":"https://avatars.githubusercontent.com/u/8980283?v=3","gravatar_id":"","url":"https://api.github.com/users/Subaru-PFS","html_url":"https://github.com/Subaru-PFS","followers_url":"https://api.github.com/users/Subaru-PFS/followers","following_url":"https://api.github.com/users/Subaru-PFS/following{/other_user}","gists_url":"https://api.github.com/users/Subaru-PFS/gists{/gist_id}","starred_url":"https://api.github.com/users/Subaru-PFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subaru-PFS/subscriptions","organizations_url":"https://api.github.com/users/Subaru-PFS/orgs","repos_url":"https://api.github.com/users/Subaru-PFS/repos","events_url":"https://api.github.com/users/Subaru-PFS/events{/privacy}","received_events_url":"https://api.github.com/users/Subaru-PFS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Subaru-PFS/drp_stella","description":"2D DRP","fork":false,"url":"https://api.github.com/repos/Subaru-PFS/drp_stella","forks_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/forks","keys_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/teams","hooks_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/hooks","issue_events_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/events{/number}","events_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/events","assignees_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/assignees{/user}","branches_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/branches{/branch}","tags_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/tags","blobs_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/statuses/{sha}","languages_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/languages","stargazers_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/stargazers","contributors_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/contributors","subscribers_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/subscribers","subscription_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/subscription","commits_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/contents/{+path}","compare_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/merges","archive_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/downloads","issues_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues{/number}","pulls_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls{/number}","milestones_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/milestones{/number}","notifications_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/labels{/name}","releases_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/releases{/id}","deployments_url":"https://api.github.com/repos/Subaru-PFS/drp_stella/deployments","created_at":"2016-03-04T09:51:39Z","updated_at":"2016-06-27T17:14:50Z","pushed_at":"2016-07-11T23:15:48Z","git_url":"git://github.com/Subaru-PFS/drp_stella.git","ssh_url":"git@github.com:Subaru-PFS/drp_stella.git","clone_url":"https://github.com/Subaru-PFS/drp_stella.git","svn_url":"https://github.com/Subaru-PFS/drp_stella","homepage":null,"size":2154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1"},"html":{"href":"https://github.com/Subaru-PFS/drp_stella/pull/1"},"issue":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/1"},"comments":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Subaru-PFS/drp_stella/statuses/8cb1e8e591ad665e6f1146aede21e23f2dcda94d"}}}}
{"actor":{"display_login":"ziggyman"}}