{"action":"created","comment":{"url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/comments/72825677","id":72825677,"diff_hunk":"@@ -476,11 +476,12 @@ protected function exchange_bind_ok($reader)\n      * @param string $destination\n      * @param string $source\n      * @param string $routing_key\n+     * @param bool $nowait\n      * @param array $arguments\n      * @param int $ticket\n      * @return mixed\n      */\n-    public function exchange_unbind($destination, $source, $routing_key = '', $arguments = null, $ticket = null)\n+    public function exchange_unbind($destination, $source, $routing_key = '', $nowait = false, $arguments = null, $ticket = null)","path":"PhpAmqpLib/Channel/AMQPChannel.php","position":10,"original_position":10,"commit_id":"e6dab50364ce5755f6554bf43fe8c956c2e88047","original_commit_id":"e6dab50364ce5755f6554bf43fe8c956c2e88047","user":{"login":"MrHash","id":390925,"avatar_url":"https://avatars.githubusercontent.com/u/390925?v=3","gravatar_id":"","url":"https://api.github.com/users/MrHash","html_url":"https://github.com/MrHash","followers_url":"https://api.github.com/users/MrHash/followers","following_url":"https://api.github.com/users/MrHash/following{/other_user}","gists_url":"https://api.github.com/users/MrHash/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHash/subscriptions","organizations_url":"https://api.github.com/users/MrHash/orgs","repos_url":"https://api.github.com/users/MrHash/repos","events_url":"https://api.github.com/users/MrHash/events{/privacy}","received_events_url":"https://api.github.com/users/MrHash/received_events","type":"User","site_admin":false},"body":"I made it this way because i don't think it's likely anyone could have been using the optional parameters as the implementation won't work as far as i can tell. Also it follows the order as described in the docs, and follows the established convention.","created_at":"2016-07-29T16:59:45Z","updated_at":"2016-07-29T16:59:45Z","html_url":"https://github.com/php-amqplib/php-amqplib/pull/427#discussion_r72825677","pull_request_url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427","_links":{"self":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/comments/72825677"},"html":{"href":"https://github.com/php-amqplib/php-amqplib/pull/427#discussion_r72825677"},"pull_request":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427","id":79040247,"html_url":"https://github.com/php-amqplib/php-amqplib/pull/427","diff_url":"https://github.com/php-amqplib/php-amqplib/pull/427.diff","patch_url":"https://github.com/php-amqplib/php-amqplib/pull/427.patch","issue_url":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/427","number":427,"state":"open","locked":false,"title":"Fix exchange_unbind arguments","user":{"login":"MrHash","id":390925,"avatar_url":"https://avatars.githubusercontent.com/u/390925?v=3","gravatar_id":"","url":"https://api.github.com/users/MrHash","html_url":"https://github.com/MrHash","followers_url":"https://api.github.com/users/MrHash/followers","following_url":"https://api.github.com/users/MrHash/following{/other_user}","gists_url":"https://api.github.com/users/MrHash/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHash/subscriptions","organizations_url":"https://api.github.com/users/MrHash/orgs","repos_url":"https://api.github.com/users/MrHash/repos","events_url":"https://api.github.com/users/MrHash/events{/privacy}","received_events_url":"https://api.github.com/users/MrHash/received_events","type":"User","site_admin":false},"body":"Support unbinding of exchanges with arguments as raised in issue #409 ","created_at":"2016-07-27T15:00:38Z","updated_at":"2016-07-29T16:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f21972c029d3973be09ee2ed564a53a579059502","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427/commits","review_comments_url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427/comments","review_comment_url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/427/comments","statuses_url":"https://api.github.com/repos/php-amqplib/php-amqplib/statuses/e6dab50364ce5755f6554bf43fe8c956c2e88047","head":{"label":"FriendsOfHoneybee:master","ref":"master","sha":"e6dab50364ce5755f6554bf43fe8c956c2e88047","user":{"login":"FriendsOfHoneybee","id":20356727,"avatar_url":"https://avatars.githubusercontent.com/u/20356727?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfHoneybee","html_url":"https://github.com/FriendsOfHoneybee","followers_url":"https://api.github.com/users/FriendsOfHoneybee/followers","following_url":"https://api.github.com/users/FriendsOfHoneybee/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfHoneybee/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfHoneybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfHoneybee/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfHoneybee/orgs","repos_url":"https://api.github.com/users/FriendsOfHoneybee/repos","events_url":"https://api.github.com/users/FriendsOfHoneybee/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfHoneybee/received_events","type":"Organization","site_admin":false},"repo":{"id":64316207,"name":"php-amqplib","full_name":"FriendsOfHoneybee/php-amqplib","owner":{"login":"FriendsOfHoneybee","id":20356727,"avatar_url":"https://avatars.githubusercontent.com/u/20356727?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfHoneybee","html_url":"https://github.com/FriendsOfHoneybee","followers_url":"https://api.github.com/users/FriendsOfHoneybee/followers","following_url":"https://api.github.com/users/FriendsOfHoneybee/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfHoneybee/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfHoneybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfHoneybee/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfHoneybee/orgs","repos_url":"https://api.github.com/users/FriendsOfHoneybee/repos","events_url":"https://api.github.com/users/FriendsOfHoneybee/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfHoneybee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfHoneybee/php-amqplib","description":"AMQP library for PHP","fork":true,"url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib","forks_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/forks","keys_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/teams","hooks_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/events","assignees_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/tags","blobs_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/languages","stargazers_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/subscription","commits_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/merges","archive_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/downloads","issues_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsOfHoneybee/php-amqplib/deployments","created_at":"2016-07-27T14:38:36Z","updated_at":"2016-07-27T14:38:37Z","pushed_at":"2016-07-27T14:56:38Z","git_url":"git://github.com/FriendsOfHoneybee/php-amqplib.git","ssh_url":"git@github.com:FriendsOfHoneybee/php-amqplib.git","clone_url":"https://github.com/FriendsOfHoneybee/php-amqplib.git","svn_url":"https://github.com/FriendsOfHoneybee/php-amqplib","homepage":"","size":6011,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-amqplib:master","ref":"master","sha":"b7b677d046a9735e0ad940d649feaf38d58c866c","user":{"login":"php-amqplib","id":17164433,"avatar_url":"https://avatars.githubusercontent.com/u/17164433?v=3","gravatar_id":"","url":"https://api.github.com/users/php-amqplib","html_url":"https://github.com/php-amqplib","followers_url":"https://api.github.com/users/php-amqplib/followers","following_url":"https://api.github.com/users/php-amqplib/following{/other_user}","gists_url":"https://api.github.com/users/php-amqplib/gists{/gist_id}","starred_url":"https://api.github.com/users/php-amqplib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-amqplib/subscriptions","organizations_url":"https://api.github.com/users/php-amqplib/orgs","repos_url":"https://api.github.com/users/php-amqplib/repos","events_url":"https://api.github.com/users/php-amqplib/events{/privacy}","received_events_url":"https://api.github.com/users/php-amqplib/received_events","type":"Organization","site_admin":false},"repo":{"id":2784293,"name":"php-amqplib","full_name":"php-amqplib/php-amqplib","owner":{"login":"php-amqplib","id":17164433,"avatar_url":"https://avatars.githubusercontent.com/u/17164433?v=3","gravatar_id":"","url":"https://api.github.com/users/php-amqplib","html_url":"https://github.com/php-amqplib","followers_url":"https://api.github.com/users/php-amqplib/followers","following_url":"https://api.github.com/users/php-amqplib/following{/other_user}","gists_url":"https://api.github.com/users/php-amqplib/gists{/gist_id}","starred_url":"https://api.github.com/users/php-amqplib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-amqplib/subscriptions","organizations_url":"https://api.github.com/users/php-amqplib/orgs","repos_url":"https://api.github.com/users/php-amqplib/repos","events_url":"https://api.github.com/users/php-amqplib/events{/privacy}","received_events_url":"https://api.github.com/users/php-amqplib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-amqplib/php-amqplib","description":"AMQP library for PHP","fork":false,"url":"https://api.github.com/repos/php-amqplib/php-amqplib","forks_url":"https://api.github.com/repos/php-amqplib/php-amqplib/forks","keys_url":"https://api.github.com/repos/php-amqplib/php-amqplib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-amqplib/php-amqplib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-amqplib/php-amqplib/teams","hooks_url":"https://api.github.com/repos/php-amqplib/php-amqplib/hooks","issue_events_url":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/events{/number}","events_url":"https://api.github.com/repos/php-amqplib/php-amqplib/events","assignees_url":"https://api.github.com/repos/php-amqplib/php-amqplib/assignees{/user}","branches_url":"https://api.github.com/repos/php-amqplib/php-amqplib/branches{/branch}","tags_url":"https://api.github.com/repos/php-amqplib/php-amqplib/tags","blobs_url":"https://api.github.com/repos/php-amqplib/php-amqplib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-amqplib/php-amqplib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-amqplib/php-amqplib/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-amqplib/php-amqplib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-amqplib/php-amqplib/statuses/{sha}","languages_url":"https://api.github.com/repos/php-amqplib/php-amqplib/languages","stargazers_url":"https://api.github.com/repos/php-amqplib/php-amqplib/stargazers","contributors_url":"https://api.github.com/repos/php-amqplib/php-amqplib/contributors","subscribers_url":"https://api.github.com/repos/php-amqplib/php-amqplib/subscribers","subscription_url":"https://api.github.com/repos/php-amqplib/php-amqplib/subscription","commits_url":"https://api.github.com/repos/php-amqplib/php-amqplib/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-amqplib/php-amqplib/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-amqplib/php-amqplib/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-amqplib/php-amqplib/contents/{+path}","compare_url":"https://api.github.com/repos/php-amqplib/php-amqplib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-amqplib/php-amqplib/merges","archive_url":"https://api.github.com/repos/php-amqplib/php-amqplib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-amqplib/php-amqplib/downloads","issues_url":"https://api.github.com/repos/php-amqplib/php-amqplib/issues{/number}","pulls_url":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls{/number}","milestones_url":"https://api.github.com/repos/php-amqplib/php-amqplib/milestones{/number}","notifications_url":"https://api.github.com/repos/php-amqplib/php-amqplib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-amqplib/php-amqplib/labels{/name}","releases_url":"https://api.github.com/repos/php-amqplib/php-amqplib/releases{/id}","deployments_url":"https://api.github.com/repos/php-amqplib/php-amqplib/deployments","created_at":"2011-11-15T23:49:33Z","updated_at":"2016-07-28T10:36:48Z","pushed_at":"2016-07-27T15:00:38Z","git_url":"git://github.com/php-amqplib/php-amqplib.git","ssh_url":"git@github.com:php-amqplib/php-amqplib.git","clone_url":"https://github.com/php-amqplib/php-amqplib.git","svn_url":"https://github.com/php-amqplib/php-amqplib","homepage":"","size":6464,"stargazers_count":1254,"watchers_count":1254,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":94,"forks":408,"open_issues":94,"watchers":1254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427"},"html":{"href":"https://github.com/php-amqplib/php-amqplib/pull/427"},"issue":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/427"},"comments":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/php-amqplib/php-amqplib/statuses/e6dab50364ce5755f6554bf43fe8c956c2e88047"}}}}
{"actor":{"display_login":"MrHash"}}