{"action":"created","issue":{"url":"https://api.github.com/repos/wanji/caffe-sl/issues/7","repository_url":"https://api.github.com/repos/wanji/caffe-sl","labels_url":"https://api.github.com/repos/wanji/caffe-sl/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/wanji/caffe-sl/issues/7/comments","events_url":"https://api.github.com/repos/wanji/caffe-sl/issues/7/events","html_url":"https://github.com/wanji/caffe-sl/issues/7","id":166742720,"number":7,"title":"batch_triplet_loss_layer.cpp","user":{"login":"ChloeEHKim","id":17716507,"avatar_url":"https://avatars.githubusercontent.com/u/17716507?v=3","gravatar_id":"","url":"https://api.github.com/users/ChloeEHKim","html_url":"https://github.com/ChloeEHKim","followers_url":"https://api.github.com/users/ChloeEHKim/followers","following_url":"https://api.github.com/users/ChloeEHKim/following{/other_user}","gists_url":"https://api.github.com/users/ChloeEHKim/gists{/gist_id}","starred_url":"https://api.github.com/users/ChloeEHKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChloeEHKim/subscriptions","organizations_url":"https://api.github.com/users/ChloeEHKim/orgs","repos_url":"https://api.github.com/users/ChloeEHKim/repos","events_url":"https://api.github.com/users/ChloeEHKim/events{/privacy}","received_events_url":"https://api.github.com/users/ChloeEHKim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-21T05:52:13Z","updated_at":"2016-07-22T11:16:16Z","closed_at":null,"body":"Hi, I'm looking through the batch_triplet_loss_layer source for triplet embedding vgg-face model.\r\nI'd like to filter only hard negative samples so I set the sample parameter \"true\". \r\nBut, I found that in the file, line 164 looks like below\r\n   if (!sample || neg_dist > pos_dist) {\r\n                smp_rank_loss += cur_rank_loss;\r\n                triplets_.push_back(Triplet(i, j, k));\r\n              }\r\nIs this should be \"  if (!sample ||  pos_dist > neg_dist) \"? since the distance is euclidean.\r\nThanks for your help in advance. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wanji/caffe-sl/issues/comments/234518858","html_url":"https://github.com/wanji/caffe-sl/issues/7#issuecomment-234518858","issue_url":"https://api.github.com/repos/wanji/caffe-sl/issues/7","id":234518858,"user":{"login":"wanji","id":620654,"avatar_url":"https://avatars.githubusercontent.com/u/620654?v=3","gravatar_id":"","url":"https://api.github.com/users/wanji","html_url":"https://github.com/wanji","followers_url":"https://api.github.com/users/wanji/followers","following_url":"https://api.github.com/users/wanji/following{/other_user}","gists_url":"https://api.github.com/users/wanji/gists{/gist_id}","starred_url":"https://api.github.com/users/wanji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanji/subscriptions","organizations_url":"https://api.github.com/users/wanji/orgs","repos_url":"https://api.github.com/users/wanji/repos","events_url":"https://api.github.com/users/wanji/events{/privacy}","received_events_url":"https://api.github.com/users/wanji/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T11:16:15Z","updated_at":"2016-07-22T11:16:15Z","body":"It is `neg_dist > pos_dist`. The purpose is to avoid triplets that are too hard.\r\nRefer the [FaceNet](http://arxiv.org/abs/1503.03832) paper for more details:\r\n\r\n```\r\nFaceNet: A Unified Embedding for Face Recognition and Clustering\r\nFlorian Schroff, Dmitry Kalenichenko, James Philbin\r\n```"}}
{"actor":{"display_login":"wanji"}}