{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/3189","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/3189/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/3189/comments","events_url":"https://api.github.com/repos/keybase/client/issues/3189/events","html_url":"https://github.com/keybase/client/pull/3189","id":162048074,"number":3189,"title":"visdiff on windows","user":{"login":"chromakode","id":16893,"avatar_url":"https://avatars.githubusercontent.com/u/16893?v=3","gravatar_id":"","url":"https://api.github.com/users/chromakode","html_url":"https://github.com/chromakode","followers_url":"https://api.github.com/users/chromakode/followers","following_url":"https://api.github.com/users/chromakode/following{/other_user}","gists_url":"https://api.github.com/users/chromakode/gists{/gist_id}","starred_url":"https://api.github.com/users/chromakode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromakode/subscriptions","organizations_url":"https://api.github.com/users/chromakode/orgs","repos_url":"https://api.github.com/users/chromakode/repos","events_url":"https://api.github.com/users/chromakode/events{/privacy}","received_events_url":"https://api.github.com/users/chromakode/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-23T23:49:15Z","updated_at":"2016-06-24T22:35:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3189","html_url":"https://github.com/keybase/client/pull/3189","diff_url":"https://github.com/keybase/client/pull/3189.diff","patch_url":"https://github.com/keybase/client/pull/3189.patch"},"body":":eyeglasses: @keybase/react-hackers \r\n\r\nAlright! This is finally running on Jenkins, and ready to take a look at.\r\n\r\nI've moved the visdiff runner into its own directory and separated out the dependencies. I anticipate it's going to grow a bit in the future when we add HTML output for diffing, so it seems like the right time to break it out. Importantly, this also makes it convenient to install as a binary outside of the `desktop` source tree, so that it doesn't get blown away when commits are checked out (which caused cryptic errors from the `s3` module).\r\n\r\nThe visdiff package is transpiled via a npm prepublish hook. Setting it up takes a few steps:\r\n\r\n```sh\r\n# from root repo dir\r\ncd visdiff\r\nnpm install  # we need to install babel build deps in the visdiff package first\r\ncd ..\r\nnpm install ./visdiff  # transpile and install a binary in root node_modules\r\ncd desktop\r\nnpm install\r\n../node_modules/.bin/keybase-visdiff\r\n```\r\n\r\nI tried some other variations, but didn't come up with a simpler approach. I didn't want to put `keybase-visdiff` in `devDependencies` of desktop because it's primarily used in CI and pulls in its own unrelated deps. Long-term, the package should get built and vendored into our JS deps like every other package, at which point we'll stop having to do this dance.\r\n\r\nIt was necessary to hack in the commit ids for demonstrating this branch, because `render-screenshots` is run from the state of the commit that is being checked, and it doesn't work on windows until this this changeset is applied.\r\n\r\n### Outstanding tasks:\r\n- [x] Finalize Windows Jenkins setup where this will live\r\n- [x] Update Linux-JS Jenkins setup to build and use new setup, remove s3cmd cruft\r\n- [x] [idea] Resolve HEAD^...HEAD style definitions from `argv` with `git rev-parse` so the runner can take arguments again"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/228479389","html_url":"https://github.com/keybase/client/pull/3189#issuecomment-228479389","issue_url":"https://api.github.com/repos/keybase/client/issues/3189","id":228479389,"user":{"login":"keybase-ci-visdiff","id":19354522,"avatar_url":"https://avatars.githubusercontent.com/u/19354522?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase-ci-visdiff","html_url":"https://github.com/keybase-ci-visdiff","followers_url":"https://api.github.com/users/keybase-ci-visdiff/followers","following_url":"https://api.github.com/users/keybase-ci-visdiff/following{/other_user}","gists_url":"https://api.github.com/users/keybase-ci-visdiff/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase-ci-visdiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase-ci-visdiff/subscriptions","organizations_url":"https://api.github.com/users/keybase-ci-visdiff/orgs","repos_url":"https://api.github.com/users/keybase-ci-visdiff/repos","events_url":"https://api.github.com/users/keybase-ci-visdiff/events{/privacy}","received_events_url":"https://api.github.com/users/keybase-ci-visdiff/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T22:35:21Z","updated_at":"2016-06-24T22:35:21Z","body":":mag_right: The commits 583b8975ba39...976a7f93010f introduced some visual changes on win32:\n * Changed: **Folders_Clear_History_Confirmation-Normal_Public** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Public-583b8975ba39.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Public-976a7f93010f.png)  \n   ![Folders_Clear_History_Confirmation-Normal_Public comparison](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Public.png)\n * Changed: **Folders_Clear_History_Confirmation-Normal_Private** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Private-583b8975ba39.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Private-976a7f93010f.png)  \n   ![Folders_Clear_History_Confirmation-Normal_Private comparison](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Normal_Private.png)\n * Changed: **Folders_Clear_History_Confirmation-Long_Name_Public** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Long_Name_Public-583b8975ba39.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Long_Name_Public-976a7f93010f.png)  \n   ![Folders_Clear_History_Confirmation-Long_Name_Public comparison](https://keybase-app-visdiff.s3.amazonaws.com/1466807541931-583b8975ba39-976a7f93010f-win32/Folders_Clear_History_Confirmation-Long_Name_Public.png)"}}
{"actor":{"display_login":"keybase-ci-visdiff"}}