{"action":"created","comment":{"url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/comments/72341844","id":72341844,"diff_hunk":"@@ -0,0 +1,26 @@\n+{\"82mm_a3\": [\n+    {\"charge\": 0, \"table\": [","path":"BallisticTables.json","position":2,"original_position":2,"commit_id":"5966273921a348f57c26c5fff108e3ab5a164b09","original_commit_id":"5966273921a348f57c26c5fff108e3ab5a164b09","user":{"login":"YannikH","id":4272044,"avatar_url":"https://avatars.githubusercontent.com/u/4272044?v=3","gravatar_id":"","url":"https://api.github.com/users/YannikH","html_url":"https://github.com/YannikH","followers_url":"https://api.github.com/users/YannikH/followers","following_url":"https://api.github.com/users/YannikH/following{/other_user}","gists_url":"https://api.github.com/users/YannikH/gists{/gist_id}","starred_url":"https://api.github.com/users/YannikH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannikH/subscriptions","organizations_url":"https://api.github.com/users/YannikH/orgs","repos_url":"https://api.github.com/users/YannikH/repos","events_url":"https://api.github.com/users/YannikH/events{/privacy}","received_events_url":"https://api.github.com/users/YannikH/received_events","type":"User","site_admin":false},"body":"lookup could be quicker by making the charge and range the key I think(not 100% sure how javascript deals with key iteration but I think that should be fine).\r\nexample:\r\n```\r\n{\"82mm_a3\": [\r\n    {0: [\r\n        100 : {qd blablabla},\r\n        150: {more blablablabla}\r\n        ]\r\n   }\r\n}\r\n```\r\nIt makes the lookup code easier to write as you can directly lookup a key instead of iterate through items to find values.\r\nlookup code being for example `rangeTables[\"82mm_a3\"][0][150]`, no loops or anything. This also means that to find a range you can round your distance to target up and down to the nearest 50s/100s and perform a direct lookup with that number. No more loops!\r\n\r\nThe only downside to this is that we are making the rangetables a little less intuitive, though I don't think this is something we need to worry about.","created_at":"2016-07-26T21:33:18Z","updated_at":"2016-07-26T21:33:18Z","html_url":"https://github.com/VKing6/ITCMBC/pull/3#discussion_r72341844","pull_request_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/comments/72341844"},"html":{"href":"https://github.com/VKing6/ITCMBC/pull/3#discussion_r72341844"},"pull_request":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3","id":78894971,"html_url":"https://github.com/VKing6/ITCMBC/pull/3","diff_url":"https://github.com/VKing6/ITCMBC/pull/3.diff","patch_url":"https://github.com/VKing6/ITCMBC/pull/3.patch","issue_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/3","number":3,"state":"open","locked":false,"title":"Convert ballistic tables to JSON","user":{"login":"VKing6","id":6129446,"avatar_url":"https://avatars.githubusercontent.com/u/6129446?v=3","gravatar_id":"","url":"https://api.github.com/users/VKing6","html_url":"https://github.com/VKing6","followers_url":"https://api.github.com/users/VKing6/followers","following_url":"https://api.github.com/users/VKing6/following{/other_user}","gists_url":"https://api.github.com/users/VKing6/gists{/gist_id}","starred_url":"https://api.github.com/users/VKing6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VKing6/subscriptions","organizations_url":"https://api.github.com/users/VKing6/orgs","repos_url":"https://api.github.com/users/VKing6/repos","events_url":"https://api.github.com/users/VKing6/events{/privacy}","received_events_url":"https://api.github.com/users/VKing6/received_events","type":"User","site_admin":false},"body":"First draft for a JSON syntax for ballistic tables.\r\n\r\n- [ ] Automate table conversion","created_at":"2016-07-26T17:47:09Z","updated_at":"2016-07-26T21:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6412c95ae67bb38d44a56381df1e7543930ba01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3/commits","review_comments_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3/comments","review_comment_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/3/comments","statuses_url":"https://api.github.com/repos/VKing6/ITCMBC/statuses/5966273921a348f57c26c5fff108e3ab5a164b09","head":{"label":"VKing6:json-ballistic-tables","ref":"json-ballistic-tables","sha":"5966273921a348f57c26c5fff108e3ab5a164b09","user":{"login":"VKing6","id":6129446,"avatar_url":"https://avatars.githubusercontent.com/u/6129446?v=3","gravatar_id":"","url":"https://api.github.com/users/VKing6","html_url":"https://github.com/VKing6","followers_url":"https://api.github.com/users/VKing6/followers","following_url":"https://api.github.com/users/VKing6/following{/other_user}","gists_url":"https://api.github.com/users/VKing6/gists{/gist_id}","starred_url":"https://api.github.com/users/VKing6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VKing6/subscriptions","organizations_url":"https://api.github.com/users/VKing6/orgs","repos_url":"https://api.github.com/users/VKing6/repos","events_url":"https://api.github.com/users/VKing6/events{/privacy}","received_events_url":"https://api.github.com/users/VKing6/received_events","type":"User","site_admin":false},"repo":{"id":63904551,"name":"ITCMBC","full_name":"VKing6/ITCMBC","owner":{"login":"VKing6","id":6129446,"avatar_url":"https://avatars.githubusercontent.com/u/6129446?v=3","gravatar_id":"","url":"https://api.github.com/users/VKing6","html_url":"https://github.com/VKing6","followers_url":"https://api.github.com/users/VKing6/followers","following_url":"https://api.github.com/users/VKing6/following{/other_user}","gists_url":"https://api.github.com/users/VKing6/gists{/gist_id}","starred_url":"https://api.github.com/users/VKing6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VKing6/subscriptions","organizations_url":"https://api.github.com/users/VKing6/orgs","repos_url":"https://api.github.com/users/VKing6/repos","events_url":"https://api.github.com/users/VKing6/events{/privacy}","received_events_url":"https://api.github.com/users/VKing6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VKing6/ITCMBC","description":"ITC Mortar Ballistics Computer","fork":false,"url":"https://api.github.com/repos/VKing6/ITCMBC","forks_url":"https://api.github.com/repos/VKing6/ITCMBC/forks","keys_url":"https://api.github.com/repos/VKing6/ITCMBC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VKing6/ITCMBC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VKing6/ITCMBC/teams","hooks_url":"https://api.github.com/repos/VKing6/ITCMBC/hooks","issue_events_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/events{/number}","events_url":"https://api.github.com/repos/VKing6/ITCMBC/events","assignees_url":"https://api.github.com/repos/VKing6/ITCMBC/assignees{/user}","branches_url":"https://api.github.com/repos/VKing6/ITCMBC/branches{/branch}","tags_url":"https://api.github.com/repos/VKing6/ITCMBC/tags","blobs_url":"https://api.github.com/repos/VKing6/ITCMBC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VKing6/ITCMBC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VKing6/ITCMBC/git/refs{/sha}","trees_url":"https://api.github.com/repos/VKing6/ITCMBC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VKing6/ITCMBC/statuses/{sha}","languages_url":"https://api.github.com/repos/VKing6/ITCMBC/languages","stargazers_url":"https://api.github.com/repos/VKing6/ITCMBC/stargazers","contributors_url":"https://api.github.com/repos/VKing6/ITCMBC/contributors","subscribers_url":"https://api.github.com/repos/VKing6/ITCMBC/subscribers","subscription_url":"https://api.github.com/repos/VKing6/ITCMBC/subscription","commits_url":"https://api.github.com/repos/VKing6/ITCMBC/commits{/sha}","git_commits_url":"https://api.github.com/repos/VKing6/ITCMBC/git/commits{/sha}","comments_url":"https://api.github.com/repos/VKing6/ITCMBC/comments{/number}","issue_comment_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/comments{/number}","contents_url":"https://api.github.com/repos/VKing6/ITCMBC/contents/{+path}","compare_url":"https://api.github.com/repos/VKing6/ITCMBC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VKing6/ITCMBC/merges","archive_url":"https://api.github.com/repos/VKing6/ITCMBC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VKing6/ITCMBC/downloads","issues_url":"https://api.github.com/repos/VKing6/ITCMBC/issues{/number}","pulls_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls{/number}","milestones_url":"https://api.github.com/repos/VKing6/ITCMBC/milestones{/number}","notifications_url":"https://api.github.com/repos/VKing6/ITCMBC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VKing6/ITCMBC/labels{/name}","releases_url":"https://api.github.com/repos/VKing6/ITCMBC/releases{/id}","deployments_url":"https://api.github.com/repos/VKing6/ITCMBC/deployments","created_at":"2016-07-21T21:49:27Z","updated_at":"2016-07-21T21:54:40Z","pushed_at":"2016-07-26T17:47:09Z","git_url":"git://github.com/VKing6/ITCMBC.git","ssh_url":"git@github.com:VKing6/ITCMBC.git","clone_url":"https://github.com/VKing6/ITCMBC.git","svn_url":"https://github.com/VKing6/ITCMBC","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"VKing6:master","ref":"master","sha":"a04ee4632ada5858f820be407962dc1573b16e88","user":{"login":"VKing6","id":6129446,"avatar_url":"https://avatars.githubusercontent.com/u/6129446?v=3","gravatar_id":"","url":"https://api.github.com/users/VKing6","html_url":"https://github.com/VKing6","followers_url":"https://api.github.com/users/VKing6/followers","following_url":"https://api.github.com/users/VKing6/following{/other_user}","gists_url":"https://api.github.com/users/VKing6/gists{/gist_id}","starred_url":"https://api.github.com/users/VKing6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VKing6/subscriptions","organizations_url":"https://api.github.com/users/VKing6/orgs","repos_url":"https://api.github.com/users/VKing6/repos","events_url":"https://api.github.com/users/VKing6/events{/privacy}","received_events_url":"https://api.github.com/users/VKing6/received_events","type":"User","site_admin":false},"repo":{"id":63904551,"name":"ITCMBC","full_name":"VKing6/ITCMBC","owner":{"login":"VKing6","id":6129446,"avatar_url":"https://avatars.githubusercontent.com/u/6129446?v=3","gravatar_id":"","url":"https://api.github.com/users/VKing6","html_url":"https://github.com/VKing6","followers_url":"https://api.github.com/users/VKing6/followers","following_url":"https://api.github.com/users/VKing6/following{/other_user}","gists_url":"https://api.github.com/users/VKing6/gists{/gist_id}","starred_url":"https://api.github.com/users/VKing6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VKing6/subscriptions","organizations_url":"https://api.github.com/users/VKing6/orgs","repos_url":"https://api.github.com/users/VKing6/repos","events_url":"https://api.github.com/users/VKing6/events{/privacy}","received_events_url":"https://api.github.com/users/VKing6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VKing6/ITCMBC","description":"ITC Mortar Ballistics Computer","fork":false,"url":"https://api.github.com/repos/VKing6/ITCMBC","forks_url":"https://api.github.com/repos/VKing6/ITCMBC/forks","keys_url":"https://api.github.com/repos/VKing6/ITCMBC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VKing6/ITCMBC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VKing6/ITCMBC/teams","hooks_url":"https://api.github.com/repos/VKing6/ITCMBC/hooks","issue_events_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/events{/number}","events_url":"https://api.github.com/repos/VKing6/ITCMBC/events","assignees_url":"https://api.github.com/repos/VKing6/ITCMBC/assignees{/user}","branches_url":"https://api.github.com/repos/VKing6/ITCMBC/branches{/branch}","tags_url":"https://api.github.com/repos/VKing6/ITCMBC/tags","blobs_url":"https://api.github.com/repos/VKing6/ITCMBC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VKing6/ITCMBC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VKing6/ITCMBC/git/refs{/sha}","trees_url":"https://api.github.com/repos/VKing6/ITCMBC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VKing6/ITCMBC/statuses/{sha}","languages_url":"https://api.github.com/repos/VKing6/ITCMBC/languages","stargazers_url":"https://api.github.com/repos/VKing6/ITCMBC/stargazers","contributors_url":"https://api.github.com/repos/VKing6/ITCMBC/contributors","subscribers_url":"https://api.github.com/repos/VKing6/ITCMBC/subscribers","subscription_url":"https://api.github.com/repos/VKing6/ITCMBC/subscription","commits_url":"https://api.github.com/repos/VKing6/ITCMBC/commits{/sha}","git_commits_url":"https://api.github.com/repos/VKing6/ITCMBC/git/commits{/sha}","comments_url":"https://api.github.com/repos/VKing6/ITCMBC/comments{/number}","issue_comment_url":"https://api.github.com/repos/VKing6/ITCMBC/issues/comments{/number}","contents_url":"https://api.github.com/repos/VKing6/ITCMBC/contents/{+path}","compare_url":"https://api.github.com/repos/VKing6/ITCMBC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VKing6/ITCMBC/merges","archive_url":"https://api.github.com/repos/VKing6/ITCMBC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VKing6/ITCMBC/downloads","issues_url":"https://api.github.com/repos/VKing6/ITCMBC/issues{/number}","pulls_url":"https://api.github.com/repos/VKing6/ITCMBC/pulls{/number}","milestones_url":"https://api.github.com/repos/VKing6/ITCMBC/milestones{/number}","notifications_url":"https://api.github.com/repos/VKing6/ITCMBC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VKing6/ITCMBC/labels{/name}","releases_url":"https://api.github.com/repos/VKing6/ITCMBC/releases{/id}","deployments_url":"https://api.github.com/repos/VKing6/ITCMBC/deployments","created_at":"2016-07-21T21:49:27Z","updated_at":"2016-07-21T21:54:40Z","pushed_at":"2016-07-26T17:47:09Z","git_url":"git://github.com/VKing6/ITCMBC.git","ssh_url":"git@github.com:VKing6/ITCMBC.git","clone_url":"https://github.com/VKing6/ITCMBC.git","svn_url":"https://github.com/VKing6/ITCMBC","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3"},"html":{"href":"https://github.com/VKing6/ITCMBC/pull/3"},"issue":{"href":"https://api.github.com/repos/VKing6/ITCMBC/issues/3"},"comments":{"href":"https://api.github.com/repos/VKing6/ITCMBC/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VKing6/ITCMBC/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/VKing6/ITCMBC/statuses/5966273921a348f57c26c5fff108e3ab5a164b09"}}}}
{"actor":{"display_login":"YannikH"}}