{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/widgets/pulls/comments/80045301","id":80045301,"diff_hunk":"@@ -1,37 +1,48 @@\n import { EventObject, Handle } from 'dojo-core/interfaces';\n import { on } from 'dojo-core/aspect';\n+import { assign } from 'dojo-core/lang';\n import { ComposeFactory } from 'dojo-compose/compose';\n-import createEvented, { Evented, EventedOptions, EventedListenerOrArray, EventedListenersMap, resolveListener, TargettedEventObject } from 'dojo-compose/mixins/createEvented';\n+import createEvented, {\n+\tEvented,\n+\tEventedOptions,\n+\tEventedListenerOrArray,\n+\tEventedListenersMap,\n+\tresolveListener,\n+\tTargettedEventObject\n+} from 'dojo-compose/mixins/createEvented';\n+import Set from 'dojo-shim/Set';\n+import { VNodeProperties } from 'maquette';\n+import { NodeAttributeFunction } from './createRenderMixin';\n \n export interface VNodeListeners {\n-\t[on: string]: (ev?: TargettedEventObject) => boolean | void;\n-\tontouchcancel?(ev?: TouchEvent): boolean | void;\n-\tontouchend?(ev?: TouchEvent): boolean | void;\n-\tontouchmove?(ev?: TouchEvent): boolean | void;\n-\tontouchstart?(ev?: TouchEvent): boolean | void;\n-\tonblur?(ev?: FocusEvent): boolean | void;\n-\tonchange?(ev?: Event): boolean | void;\n-\tonclick?(ev?: MouseEvent): boolean | void;\n-\tondblclick?(ev?: MouseEvent): boolean | void;\n-\tonfocus?(ev?: FocusEvent): boolean | void;\n-\toninput?(ev?: Event): boolean | void;\n-\tonkeydown?(ev?: KeyboardEvent): boolean | void;\n-\tonkeypress?(ev?: KeyboardEvent): boolean | void;\n-\tonkeyup?(ev?: KeyboardEvent): boolean | void;\n-\tonload?(ev?: Event): boolean | void;\n-\tonmousedown?(ev?: MouseEvent): boolean | void;\n-\tonmouseenter?(ev?: MouseEvent): boolean | void;\n-\tonmouseleave?(ev?: MouseEvent): boolean | void;\n-\tonmousemove?(ev?: MouseEvent): boolean | void;\n-\tonmouseout?(ev?: MouseEvent): boolean | void;\n-\tonmouseover?(ev?: MouseEvent): boolean | void;\n-\tonmouseup?(ev?: MouseEvent): boolean | void;\n-\tonmousewheel?(ev?: MouseWheelEvent): boolean | void;\n-\tonscroll?(ev?: UIEvent): boolean | void;\n-\tonsubmit?(ev?: Event): boolean | void;\n+\t[on: string]: (ev?: TargettedEventObject) => boolean | undefined | null;","path":"src/mixins/createVNodeEvented.ts","position":44,"original_position":44,"commit_id":"c2827b21912bf350bd6fa11f263a62f8d0209d63","original_commit_id":"c2827b21912bf350bd6fa11f263a62f8d0209d63","user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"body":"Good idea, will address.","created_at":"2016-09-22T13:56:04Z","updated_at":"2016-09-22T13:56:04Z","html_url":"https://github.com/dojo/widgets/pull/40#discussion_r80045301","pull_request_url":"https://api.github.com/repos/dojo/widgets/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments/80045301"},"html":{"href":"https://github.com/dojo/widgets/pull/40#discussion_r80045301"},"pull_request":{"href":"https://api.github.com/repos/dojo/widgets/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/40","id":84393803,"html_url":"https://github.com/dojo/widgets/pull/40","diff_url":"https://github.com/dojo/widgets/pull/40.diff","patch_url":"https://github.com/dojo/widgets/pull/40.patch","issue_url":"https://api.github.com/repos/dojo/widgets/issues/40","number":40,"state":"open","locked":false,"title":"Add nodeAttributes to RenderMixin","user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"body":"This PR resolves #22, where expressing attributes in a mixin was challenging.  This uses the new feature of `dojo/compose` that will merge arrays that exist on a prototype (see: dojo/compose#51).  With this PR, a mixin which has the following interface and mixed in with `CachedRenderMixin`:\r\n\r\n```typescript\r\ninterface NodeAttributeFunction {\r\n    (attributes: VNodeProperties): VNodeProperties;\r\n}\r\n\r\ninterface NodeAttributeMixin {\r\n    nodeAttributes: NodeAttributeFunction[];\r\n}\r\n```\r\n\r\nWill have its node attributes \"collected\".  The values must be returned from the function in order to be mixed in to the final VNode that is being generated during a render call.\r\n\r\nTodo:\r\n\r\n- [x] Update unit tests\r\n","created_at":"2016-09-07T23:56:13Z","updated_at":"2016-09-22T13:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"205cb2307e03d73732e9597095abebc75129f4e7","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dojo/widgets/milestones/6","html_url":"https://github.com/dojo/widgets/milestones/2016.09","labels_url":"https://api.github.com/repos/dojo/widgets/milestones/6/labels","id":1862836,"number":6,"title":"2016.09","description":"","creator":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2016-07-04T09:07:49Z","updated_at":"2016-09-21T18:14:51Z","due_on":"2016-09-29T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dojo/widgets/pulls/40/commits","review_comments_url":"https://api.github.com/repos/dojo/widgets/pulls/40/comments","review_comment_url":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/40/comments","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/c2827b21912bf350bd6fa11f263a62f8d0209d63","head":{"label":"dojo:feature-get-attributes","ref":"feature-get-attributes","sha":"c2827b21912bf350bd6fa11f263a62f8d0209d63","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":55768463,"name":"widgets","full_name":"dojo/widgets","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/widgets","description":":rocket: UI components for dojo2.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2016-04-08T09:47:48Z","updated_at":"2016-09-02T12:08:15Z","pushed_at":"2016-09-22T11:26:58Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"","size":953,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":9,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"52e55e7d776ca1b309d4b7b8274c4f9ee879c337","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":55768463,"name":"widgets","full_name":"dojo/widgets","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/widgets","description":":rocket: UI components for dojo2.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2016-04-08T09:47:48Z","updated_at":"2016-09-02T12:08:15Z","pushed_at":"2016-09-22T11:26:58Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"","size":953,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/40"},"html":{"href":"https://github.com/dojo/widgets/pull/40"},"issue":{"href":"https://api.github.com/repos/dojo/widgets/issues/40"},"comments":{"href":"https://api.github.com/repos/dojo/widgets/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/widgets/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/widgets/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/widgets/statuses/c2827b21912bf350bd6fa11f263a62f8d0209d63"}}}}
{"actor":{"display_login":"kitsonk"}}