{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/93831872","pull_request_review_id":14366537,"id":93831872,"diff_hunk":"@@ -1323,11 +1325,13 @@ def cornacchia(a, b, m):\n         return None\n \n     for t in v:\n-        if t < m // 2:\n+        if t >= m // 2:\n+            u, r = t, m\n+        elif t < m // 2:\n+            u,r = m-t,m","path":"sympy/solvers/diophantine.py","position":26,"original_position":26,"commit_id":"e0b8f32aea4abf5617e66cee03e9c426549311ac","original_commit_id":"e0b8f32aea4abf5617e66cee03e9c426549311ac","user":{"login":"jksuom","id":6929119,"avatar_url":"https://avatars.githubusercontent.com/u/6929119?v=3","gravatar_id":"","url":"https://api.github.com/users/jksuom","html_url":"https://github.com/jksuom","followers_url":"https://api.github.com/users/jksuom/followers","following_url":"https://api.github.com/users/jksuom/following{/other_user}","gists_url":"https://api.github.com/users/jksuom/gists{/gist_id}","starred_url":"https://api.github.com/users/jksuom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jksuom/subscriptions","organizations_url":"https://api.github.com/users/jksuom/orgs","repos_url":"https://api.github.com/users/jksuom/repos","events_url":"https://api.github.com/users/jksuom/events{/privacy}","received_events_url":"https://api.github.com/users/jksuom/received_events","type":"User","site_admin":false},"body":"Please add a space after commas.","created_at":"2016-12-25T17:13:07Z","updated_at":"2016-12-25T17:13:07Z","html_url":"https://github.com/sympy/sympy/pull/11961#discussion_r93831872","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/11961","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/93831872"},"html":{"href":"https://github.com/sympy/sympy/pull/11961#discussion_r93831872"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11961"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11961","id":98652612,"html_url":"https://github.com/sympy/sympy/pull/11961","diff_url":"https://github.com/sympy/sympy/pull/11961.diff","patch_url":"https://github.com/sympy/sympy/pull/11961.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11961","number":11961,"state":"open","locked":false,"title":"11956 diophantine cornacchia","user":{"login":"pranjaltale16","id":15308785,"avatar_url":"https://avatars.githubusercontent.com/u/15308785?v=3","gravatar_id":"","url":"https://api.github.com/users/pranjaltale16","html_url":"https://github.com/pranjaltale16","followers_url":"https://api.github.com/users/pranjaltale16/followers","following_url":"https://api.github.com/users/pranjaltale16/following{/other_user}","gists_url":"https://api.github.com/users/pranjaltale16/gists{/gist_id}","starred_url":"https://api.github.com/users/pranjaltale16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranjaltale16/subscriptions","organizations_url":"https://api.github.com/users/pranjaltale16/orgs","repos_url":"https://api.github.com/users/pranjaltale16/repos","events_url":"https://api.github.com/users/pranjaltale16/events{/privacy}","received_events_url":"https://api.github.com/users/pranjaltale16/received_events","type":"User","site_admin":false},"body":"Fixes #11956 #11959 \r\n\r\nCorrected `diophantene()` function mainly modified 'cornacchia()' function\r\nBefore diophantine solution for the eqn `x**2+2*y**2 -32` is null set but now it is giving correct solutions\r\nAlso initially in cornacchia function when 'a = b = 1' it was returning `set([(3, 4)])` instead of `set([(4, 3)])`\r\nAnd modified  `diop_DN()` function to show all solutions rather than half of them.","created_at":"2016-12-19T22:32:49Z","updated_at":"2016-12-25T17:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46d8e48da470500f3d9011208e7af76f4f547c31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/11961/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/11961/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11961/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/e0b8f32aea4abf5617e66cee03e9c426549311ac","head":{"label":"pranjaltale16:11956_diophantine_cornacchia","ref":"11956_diophantine_cornacchia","sha":"e0b8f32aea4abf5617e66cee03e9c426549311ac","user":{"login":"pranjaltale16","id":15308785,"avatar_url":"https://avatars.githubusercontent.com/u/15308785?v=3","gravatar_id":"","url":"https://api.github.com/users/pranjaltale16","html_url":"https://github.com/pranjaltale16","followers_url":"https://api.github.com/users/pranjaltale16/followers","following_url":"https://api.github.com/users/pranjaltale16/following{/other_user}","gists_url":"https://api.github.com/users/pranjaltale16/gists{/gist_id}","starred_url":"https://api.github.com/users/pranjaltale16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranjaltale16/subscriptions","organizations_url":"https://api.github.com/users/pranjaltale16/orgs","repos_url":"https://api.github.com/users/pranjaltale16/repos","events_url":"https://api.github.com/users/pranjaltale16/events{/privacy}","received_events_url":"https://api.github.com/users/pranjaltale16/received_events","type":"User","site_admin":false},"repo":{"id":69698534,"name":"sympy","full_name":"pranjaltale16/sympy","owner":{"login":"pranjaltale16","id":15308785,"avatar_url":"https://avatars.githubusercontent.com/u/15308785?v=3","gravatar_id":"","url":"https://api.github.com/users/pranjaltale16","html_url":"https://github.com/pranjaltale16","followers_url":"https://api.github.com/users/pranjaltale16/followers","following_url":"https://api.github.com/users/pranjaltale16/following{/other_user}","gists_url":"https://api.github.com/users/pranjaltale16/gists{/gist_id}","starred_url":"https://api.github.com/users/pranjaltale16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranjaltale16/subscriptions","organizations_url":"https://api.github.com/users/pranjaltale16/orgs","repos_url":"https://api.github.com/users/pranjaltale16/repos","events_url":"https://api.github.com/users/pranjaltale16/events{/privacy}","received_events_url":"https://api.github.com/users/pranjaltale16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pranjaltale16/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/pranjaltale16/sympy","forks_url":"https://api.github.com/repos/pranjaltale16/sympy/forks","keys_url":"https://api.github.com/repos/pranjaltale16/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pranjaltale16/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pranjaltale16/sympy/teams","hooks_url":"https://api.github.com/repos/pranjaltale16/sympy/hooks","issue_events_url":"https://api.github.com/repos/pranjaltale16/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/pranjaltale16/sympy/events","assignees_url":"https://api.github.com/repos/pranjaltale16/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/pranjaltale16/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/pranjaltale16/sympy/tags","blobs_url":"https://api.github.com/repos/pranjaltale16/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pranjaltale16/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pranjaltale16/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pranjaltale16/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pranjaltale16/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/pranjaltale16/sympy/languages","stargazers_url":"https://api.github.com/repos/pranjaltale16/sympy/stargazers","contributors_url":"https://api.github.com/repos/pranjaltale16/sympy/contributors","subscribers_url":"https://api.github.com/repos/pranjaltale16/sympy/subscribers","subscription_url":"https://api.github.com/repos/pranjaltale16/sympy/subscription","commits_url":"https://api.github.com/repos/pranjaltale16/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pranjaltale16/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pranjaltale16/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pranjaltale16/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pranjaltale16/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/pranjaltale16/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pranjaltale16/sympy/merges","archive_url":"https://api.github.com/repos/pranjaltale16/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pranjaltale16/sympy/downloads","issues_url":"https://api.github.com/repos/pranjaltale16/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/pranjaltale16/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/pranjaltale16/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/pranjaltale16/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pranjaltale16/sympy/labels{/name}","releases_url":"https://api.github.com/repos/pranjaltale16/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/pranjaltale16/sympy/deployments","created_at":"2016-09-30T20:08:08Z","updated_at":"2016-09-30T20:08:14Z","pushed_at":"2016-12-25T16:12:17Z","git_url":"git://github.com/pranjaltale16/sympy.git","ssh_url":"git@github.com:pranjaltale16/sympy.git","clone_url":"https://github.com/pranjaltale16/sympy.git","svn_url":"https://github.com/pranjaltale16/sympy","homepage":"http://sympy.org/","size":76352,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"f22f110cb5f7ac55c041b343f0f28220ac0ee6a4","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-12-25T04:07:04Z","pushed_at":"2016-12-25T17:06:21Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":76859,"stargazers_count":3451,"watchers_count":3451,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1723,"mirror_url":null,"open_issues_count":2675,"forks":1723,"open_issues":2675,"watchers":3451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11961"},"html":{"href":"https://github.com/sympy/sympy/pull/11961"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/11961"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/11961/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11961/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11961/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/e0b8f32aea4abf5617e66cee03e9c426549311ac"}}}}
{"actor":{"display_login":"jksuom"}}