{"action":"opened","issue":{"url":"https://api.github.com/repos/brave/browser-ios/issues/629","repository_url":"https://api.github.com/repos/brave/browser-ios","labels_url":"https://api.github.com/repos/brave/browser-ios/issues/629/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-ios/issues/629/comments","events_url":"https://api.github.com/repos/brave/browser-ios/issues/629/events","html_url":"https://github.com/brave/browser-ios/issues/629","id":197208563,"number":629,"title":"[beta] Reader mode toolbar button UI refactor","user":{"login":"garvankeeley","id":5495083,"avatar_url":"https://avatars.githubusercontent.com/u/5495083?v=3","gravatar_id":"","url":"https://api.github.com/users/garvankeeley","html_url":"https://github.com/garvankeeley","followers_url":"https://api.github.com/users/garvankeeley/followers","following_url":"https://api.github.com/users/garvankeeley/following{/other_user}","gists_url":"https://api.github.com/users/garvankeeley/gists{/gist_id}","starred_url":"https://api.github.com/users/garvankeeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garvankeeley/subscriptions","organizations_url":"https://api.github.com/users/garvankeeley/orgs","repos_url":"https://api.github.com/users/garvankeeley/repos","events_url":"https://api.github.com/users/garvankeeley/events{/privacy}","received_events_url":"https://api.github.com/users/garvankeeley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-22T16:11:02Z","updated_at":"2016-12-22T16:11:02Z","closed_at":null,"body":"There are a few issues with the current implementation.\r\nThe first is whether this toolbar is the best way to show access to the settings, we haven't decided if we want to keep using this or move to a button, or overlay some other type of element on the webview to access settings.\r\n\r\nThe second issue is  that the current implementation is a UIView glued on to the bottom of the top toolbar, without any modification to the layout system of the top toolbar to avoid refactoring the layout code to accommodate this. This results in the reader settings bar view sitting outside of the frame of the top toolbar and thus taps not being sent to it. This requires a custom tap detection, see BrowserViewController.ViewToCaptureReaderModeTap. "}}
{"actor":{"display_login":"garvankeeley"}}