{"action":"closed","number":1179,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/1179","id":53962233,"html_url":"https://github.com/ampproject/amphtml/pull/1179","diff_url":"https://github.com/ampproject/amphtml/pull/1179.diff","patch_url":"https://github.com/ampproject/amphtml/pull/1179.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1179","number":1179,"state":"closed","locked":false,"title":"point out that localhost urls are also fine","user":{"login":"johnduffell","id":7304387,"avatar_url":"https://avatars.githubusercontent.com/u/7304387?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"body":"In the error message we can't use relative urls, but if it were localhost it would be fine.  Since when developing locally we often use www.thegulocal.com as a convention for localhost, it would be better to point out the problem in the message.\r\n\r\nIt would actually be better to allow relative urls, but it would require the google cache to make a note of the original hostname when rewriting the URLs.  If you could do that, it would be ideal.","created_at":"2015-12-17T11:02:21Z","updated_at":"2016-01-04T16:46:45Z","closed_at":"2016-01-04T16:46:45Z","merged_at":"2016-01-04T16:46:45Z","merge_commit_sha":"e50d1808562b9b27074e2f409970c9d9da81eee9","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1179/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/4b628afb0989b6bc3efbd5456375ce98eb7d52eb","head":{"label":"johnduffell:patch-1","ref":"patch-1","sha":"4b628afb0989b6bc3efbd5456375ce98eb7d52eb","user":{"login":"johnduffell","id":7304387,"avatar_url":"https://avatars.githubusercontent.com/u/7304387?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"repo":{"id":45391602,"name":"amphtml","full_name":"johnduffell/amphtml","owner":{"login":"johnduffell","id":7304387,"avatar_url":"https://avatars.githubusercontent.com/u/7304387?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnduffell/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/johnduffell/amphtml","forks_url":"https://api.github.com/repos/johnduffell/amphtml/forks","keys_url":"https://api.github.com/repos/johnduffell/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnduffell/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnduffell/amphtml/teams","hooks_url":"https://api.github.com/repos/johnduffell/amphtml/hooks","issue_events_url":"https://api.github.com/repos/johnduffell/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/johnduffell/amphtml/events","assignees_url":"https://api.github.com/repos/johnduffell/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/johnduffell/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/johnduffell/amphtml/tags","blobs_url":"https://api.github.com/repos/johnduffell/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnduffell/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnduffell/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnduffell/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnduffell/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/johnduffell/amphtml/languages","stargazers_url":"https://api.github.com/repos/johnduffell/amphtml/stargazers","contributors_url":"https://api.github.com/repos/johnduffell/amphtml/contributors","subscribers_url":"https://api.github.com/repos/johnduffell/amphtml/subscribers","subscription_url":"https://api.github.com/repos/johnduffell/amphtml/subscription","commits_url":"https://api.github.com/repos/johnduffell/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnduffell/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnduffell/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnduffell/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnduffell/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/johnduffell/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnduffell/amphtml/merges","archive_url":"https://api.github.com/repos/johnduffell/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnduffell/amphtml/downloads","issues_url":"https://api.github.com/repos/johnduffell/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/johnduffell/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/johnduffell/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/johnduffell/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnduffell/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/johnduffell/amphtml/releases{/id}","created_at":"2015-11-02T11:53:58Z","updated_at":"2015-11-02T11:53:59Z","pushed_at":"2015-12-17T10:59:57Z","git_url":"git://github.com/johnduffell/amphtml.git","ssh_url":"git@github.com:johnduffell/amphtml.git","clone_url":"https://github.com/johnduffell/amphtml.git","svn_url":"https://github.com/johnduffell/amphtml","homepage":"https://ampproject.org","size":13914,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"33dbab374c99d12544b820984ec99e3f445b2aab","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-01-04T15:13:23Z","pushed_at":"2016-01-04T16:46:45Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":21780,"stargazers_count":5215,"watchers_count":5215,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":null,"open_issues_count":203,"forks":504,"open_issues":203,"watchers":5215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1179"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1179"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1179"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/4b628afb0989b6bc3efbd5456375ce98eb7d52eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}