{"action":"closed","issue":{"url":"https://api.github.com/repos/luruke/barba.js/issues/36","repository_url":"https://api.github.com/repos/luruke/barba.js","labels_url":"https://api.github.com/repos/luruke/barba.js/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/luruke/barba.js/issues/36/comments","events_url":"https://api.github.com/repos/luruke/barba.js/issues/36/events","html_url":"https://github.com/luruke/barba.js/issues/36","id":161532089,"number":36,"title":"Non-strict equality warning from UglifyJs.","user":{"login":"dblodorn","id":7268786,"avatar_url":"https://avatars.githubusercontent.com/u/7268786?v=3","gravatar_id":"","url":"https://api.github.com/users/dblodorn","html_url":"https://github.com/dblodorn","followers_url":"https://api.github.com/users/dblodorn/followers","following_url":"https://api.github.com/users/dblodorn/following{/other_user}","gists_url":"https://api.github.com/users/dblodorn/gists{/gist_id}","starred_url":"https://api.github.com/users/dblodorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblodorn/subscriptions","organizations_url":"https://api.github.com/users/dblodorn/orgs","repos_url":"https://api.github.com/users/dblodorn/repos","events_url":"https://api.github.com/users/dblodorn/events{/privacy}","received_events_url":"https://api.github.com/users/dblodorn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/luruke/barba.js/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-21T20:30:31Z","updated_at":"2016-06-25T13:42:19Z","closed_at":"2016-06-25T13:42:19Z","body":"First off you've made an amazing library! it's been awesome to work with, and I just launched a project that takes great advantage of it! - http://thekitchennation.com/\r\nRemoving the page refresh is a biggie for me.\r\n\r\nOne small issue is that when I run the production build with my webpack setup i always get this error from the uglify plugin:\r\n\r\n    WARNING in ./public/js/app.js from UglifyJs\r\n    Non-strict equality against boolean: != false [./~/barba.js/dist/barba.js:535,0]\r\n    Non-strict equality against boolean: != false [./~/barba.js/dist/barba.js:549,0]\r\n\r\nif I go into your build and change (for example - on line 535)\r\n    \r\n    if(e in this.events === false)\r\nto: \r\n    \r\n    if(e in this.events == false)\r\nno issues - but then I'm going to assume that may cause issues down the road.\r\n\r\n**note that there are no problems in dev mode (no minification).**\r\n\r\nany thoughts would be appreciated, and more than anything I wanted to bring this to your attention.\r\n\r\n**many thanks for you work!**\r\n"}}
{"actor":{"display_login":"luruke"}}