{"action":"created","issue":{"url":"https://api.github.com/repos/typesafehub/ssl-config/issues/42","repository_url":"https://api.github.com/repos/typesafehub/ssl-config","labels_url":"https://api.github.com/repos/typesafehub/ssl-config/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/typesafehub/ssl-config/issues/42/comments","events_url":"https://api.github.com/repos/typesafehub/ssl-config/issues/42/events","html_url":"https://github.com/typesafehub/ssl-config/pull/42","id":163107858,"number":42,"title":"add password for TrustStoreConfig","user":{"login":"note","id":345056,"avatar_url":"https://avatars.githubusercontent.com/u/345056?v=3","gravatar_id":"","url":"https://api.github.com/users/note","html_url":"https://github.com/note","followers_url":"https://api.github.com/users/note/followers","following_url":"https://api.github.com/users/note/following{/other_user}","gists_url":"https://api.github.com/users/note/gists{/gist_id}","starred_url":"https://api.github.com/users/note/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/note/subscriptions","organizations_url":"https://api.github.com/users/note/orgs","repos_url":"https://api.github.com/users/note/repos","events_url":"https://api.github.com/users/note/events{/privacy}","received_events_url":"https://api.github.com/users/note/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-30T08:19:52Z","updated_at":"2016-08-09T05:19:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/typesafehub/ssl-config/pulls/42","html_url":"https://github.com/typesafehub/ssl-config/pull/42","diff_url":"https://github.com/typesafehub/ssl-config/pull/42.diff","patch_url":"https://github.com/typesafehub/ssl-config/pull/42.patch"},"body":"Related to https://github.com/akka/akka/issues/20381\r\n\r\nIt's the minimal set of changes to make https://github.com/akka/akka/issues/20381 work. There are at least two more things that may be done:\r\n\r\n1. Adding support for `DKS` keystores (https://docs.oracle.com/javase/8/docs/api/java/security/DomainLoadStoreParameter.html). I have mixed feelings about it because it seems to me that DKS config do more or less the same thing as ssl-config itself.\r\n2. Adding support for server side SNI - changes in `CompositeX509KeyManager` would be needed (probably we should create a separate ticket for this)\r\n\r\nIt also eliminates critical bug in `CompositeX509KeyManager` which method `chooseEngineClientAlias` was throwing NPE for `issuers == null`\r\n\r\nAlso I have some codewise questions - will add them as PR comments in a moment."},"comment":{"url":"https://api.github.com/repos/typesafehub/ssl-config/issues/comments/238456240","html_url":"https://github.com/typesafehub/ssl-config/pull/42#issuecomment-238456240","issue_url":"https://api.github.com/repos/typesafehub/ssl-config/issues/42","id":238456240,"user":{"login":"Steiny69","id":4659562,"avatar_url":"https://avatars.githubusercontent.com/u/4659562?v=3","gravatar_id":"","url":"https://api.github.com/users/Steiny69","html_url":"https://github.com/Steiny69","followers_url":"https://api.github.com/users/Steiny69/followers","following_url":"https://api.github.com/users/Steiny69/following{/other_user}","gists_url":"https://api.github.com/users/Steiny69/gists{/gist_id}","starred_url":"https://api.github.com/users/Steiny69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steiny69/subscriptions","organizations_url":"https://api.github.com/users/Steiny69/orgs","repos_url":"https://api.github.com/users/Steiny69/repos","events_url":"https://api.github.com/users/Steiny69/events{/privacy}","received_events_url":"https://api.github.com/users/Steiny69/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T05:19:42Z","updated_at":"2016-08-09T05:19:42Z","body":"Is this still being worked on? It would be nice to at least get the NPE fix in as that is a major show stopper for using the key manager with any reasonable cipher suite."}}
{"actor":{"display_login":"Steiny69"}}