{"action":"created","comment":{"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/comments/76325892","id":76325892,"diff_hunk":"@@ -94,8 +94,13 @@ int  readPacket(MQTTClient* c, Timer* timer)\n         goto exit;\n     len = 1;\n     /* 2. read the remaining length.  This is variable in itself */\n-    decodePacket(c, &rem_len, left_ms(timer));\n-    len += MQTTPacket_encode(c->readbuf + 1, rem_len); /* put the original remaining length back into the buffer */\n+    len += decodePacket(c, &rem_len, left_ms(timer));","path":"extras/paho_mqtt_c/MQTTClient.c","position":6,"original_position":6,"commit_id":"3a2cf74ebd731007eaa1988ef32311b3392e59d7","original_commit_id":"16b53e11e2b6e8db07972fc72195eef1c940d3ec","user":{"login":"kanflo","id":931076,"avatar_url":"https://avatars.githubusercontent.com/u/931076?v=3","gravatar_id":"","url":"https://api.github.com/users/kanflo","html_url":"https://github.com/kanflo","followers_url":"https://api.github.com/users/kanflo/followers","following_url":"https://api.github.com/users/kanflo/following{/other_user}","gists_url":"https://api.github.com/users/kanflo/gists{/gist_id}","starred_url":"https://api.github.com/users/kanflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanflo/subscriptions","organizations_url":"https://api.github.com/users/kanflo/orgs","repos_url":"https://api.github.com/users/kanflo/repos","events_url":"https://api.github.com/users/kanflo/events{/privacy}","received_events_url":"https://api.github.com/users/kanflo/received_events","type":"User","site_admin":false},"body":"Does this fix come from upstream or should it be sent upstream?","created_at":"2016-08-25T21:14:02Z","updated_at":"2016-08-25T21:14:02Z","html_url":"https://github.com/SuperHouse/esp-open-rtos/pull/173#discussion_r76325892","pull_request_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/comments/76325892"},"html":{"href":"https://github.com/SuperHouse/esp-open-rtos/pull/173#discussion_r76325892"},"pull_request":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173","id":78944209,"html_url":"https://github.com/SuperHouse/esp-open-rtos/pull/173","diff_url":"https://github.com/SuperHouse/esp-open-rtos/pull/173.diff","patch_url":"https://github.com/SuperHouse/esp-open-rtos/pull/173.patch","issue_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/173","number":173,"state":"open","locked":false,"title":"Added a MQTT pub/sub example of using AWS IoT","user":{"login":"rongsaws","id":19155175,"avatar_url":"https://avatars.githubusercontent.com/u/19155175?v=3","gravatar_id":"","url":"https://api.github.com/users/rongsaws","html_url":"https://github.com/rongsaws","followers_url":"https://api.github.com/users/rongsaws/followers","following_url":"https://api.github.com/users/rongsaws/following{/other_user}","gists_url":"https://api.github.com/users/rongsaws/gists{/gist_id}","starred_url":"https://api.github.com/users/rongsaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongsaws/subscriptions","organizations_url":"https://api.github.com/users/rongsaws/orgs","repos_url":"https://api.github.com/users/rongsaws/repos","events_url":"https://api.github.com/users/rongsaws/events{/privacy}","received_events_url":"https://api.github.com/users/rongsaws/received_events","type":"User","site_admin":false},"body":"This example demonstrates ESP8266 is capable of working with the AWS IoT service through TLS1.2 based MQTT connection. \r\n\r\nReadme file included. \r\n\r\nSome memory usage stats of the example:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/19155175/17159106/aac5b176-534f-11e6-83c3-775fcb2c3cc6.png)\r\n","created_at":"2016-07-26T23:41:45Z","updated_at":"2016-08-25T21:14:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5daf6cbd9b31e99de094ec1aeb34395b2775555e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173/commits","review_comments_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173/comments","review_comment_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/173/comments","statuses_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/statuses/3a2cf74ebd731007eaa1988ef32311b3392e59d7","head":{"label":"rongsaws:master","ref":"master","sha":"3a2cf74ebd731007eaa1988ef32311b3392e59d7","user":{"login":"rongsaws","id":19155175,"avatar_url":"https://avatars.githubusercontent.com/u/19155175?v=3","gravatar_id":"","url":"https://api.github.com/users/rongsaws","html_url":"https://github.com/rongsaws","followers_url":"https://api.github.com/users/rongsaws/followers","following_url":"https://api.github.com/users/rongsaws/following{/other_user}","gists_url":"https://api.github.com/users/rongsaws/gists{/gist_id}","starred_url":"https://api.github.com/users/rongsaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongsaws/subscriptions","organizations_url":"https://api.github.com/users/rongsaws/orgs","repos_url":"https://api.github.com/users/rongsaws/repos","events_url":"https://api.github.com/users/rongsaws/events{/privacy}","received_events_url":"https://api.github.com/users/rongsaws/received_events","type":"User","site_admin":false},"repo":{"id":64260062,"name":"esp-open-rtos","full_name":"rongsaws/esp-open-rtos","owner":{"login":"rongsaws","id":19155175,"avatar_url":"https://avatars.githubusercontent.com/u/19155175?v=3","gravatar_id":"","url":"https://api.github.com/users/rongsaws","html_url":"https://github.com/rongsaws","followers_url":"https://api.github.com/users/rongsaws/followers","following_url":"https://api.github.com/users/rongsaws/following{/other_user}","gists_url":"https://api.github.com/users/rongsaws/gists{/gist_id}","starred_url":"https://api.github.com/users/rongsaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongsaws/subscriptions","organizations_url":"https://api.github.com/users/rongsaws/orgs","repos_url":"https://api.github.com/users/rongsaws/repos","events_url":"https://api.github.com/users/rongsaws/events{/privacy}","received_events_url":"https://api.github.com/users/rongsaws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rongsaws/esp-open-rtos","description":"Open source FreeRTOS-based ESP8266 software framework","fork":true,"url":"https://api.github.com/repos/rongsaws/esp-open-rtos","forks_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/forks","keys_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/teams","hooks_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/hooks","issue_events_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/issues/events{/number}","events_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/events","assignees_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/assignees{/user}","branches_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/branches{/branch}","tags_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/tags","blobs_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/git/refs{/sha}","trees_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/statuses/{sha}","languages_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/languages","stargazers_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/stargazers","contributors_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/contributors","subscribers_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/subscribers","subscription_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/subscription","commits_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/commits{/sha}","git_commits_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/git/commits{/sha}","comments_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/comments{/number}","issue_comment_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/issues/comments{/number}","contents_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/contents/{+path}","compare_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/merges","archive_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/downloads","issues_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/issues{/number}","pulls_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/pulls{/number}","milestones_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/milestones{/number}","notifications_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/labels{/name}","releases_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/releases{/id}","deployments_url":"https://api.github.com/repos/rongsaws/esp-open-rtos/deployments","created_at":"2016-07-26T22:53:36Z","updated_at":"2016-08-12T13:24:21Z","pushed_at":"2016-07-28T23:55:59Z","git_url":"git://github.com/rongsaws/esp-open-rtos.git","ssh_url":"git@github.com:rongsaws/esp-open-rtos.git","clone_url":"https://github.com/rongsaws/esp-open-rtos.git","svn_url":"https://github.com/rongsaws/esp-open-rtos","homepage":null,"size":9663,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SuperHouse:master","ref":"master","sha":"22c480b583b77dcc6284a6cc474bbbe05c8720cb","user":{"login":"SuperHouse","id":11762865,"avatar_url":"https://avatars.githubusercontent.com/u/11762865?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperHouse","html_url":"https://github.com/SuperHouse","followers_url":"https://api.github.com/users/SuperHouse/followers","following_url":"https://api.github.com/users/SuperHouse/following{/other_user}","gists_url":"https://api.github.com/users/SuperHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperHouse/subscriptions","organizations_url":"https://api.github.com/users/SuperHouse/orgs","repos_url":"https://api.github.com/users/SuperHouse/repos","events_url":"https://api.github.com/users/SuperHouse/events{/privacy}","received_events_url":"https://api.github.com/users/SuperHouse/received_events","type":"Organization","site_admin":false},"repo":{"id":36720532,"name":"esp-open-rtos","full_name":"SuperHouse/esp-open-rtos","owner":{"login":"SuperHouse","id":11762865,"avatar_url":"https://avatars.githubusercontent.com/u/11762865?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperHouse","html_url":"https://github.com/SuperHouse","followers_url":"https://api.github.com/users/SuperHouse/followers","following_url":"https://api.github.com/users/SuperHouse/following{/other_user}","gists_url":"https://api.github.com/users/SuperHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperHouse/subscriptions","organizations_url":"https://api.github.com/users/SuperHouse/orgs","repos_url":"https://api.github.com/users/SuperHouse/repos","events_url":"https://api.github.com/users/SuperHouse/events{/privacy}","received_events_url":"https://api.github.com/users/SuperHouse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SuperHouse/esp-open-rtos","description":"Open source FreeRTOS-based ESP8266 software framework","fork":false,"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos","forks_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/forks","keys_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/teams","hooks_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/hooks","issue_events_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/events{/number}","events_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/events","assignees_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/assignees{/user}","branches_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/branches{/branch}","tags_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/tags","blobs_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/languages","stargazers_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/stargazers","contributors_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/contributors","subscribers_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/subscribers","subscription_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/subscription","commits_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/contents/{+path}","compare_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/merges","archive_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/downloads","issues_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues{/number}","pulls_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/labels{/name}","releases_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/releases{/id}","deployments_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/deployments","created_at":"2015-06-02T08:52:21Z","updated_at":"2016-08-25T14:15:38Z","pushed_at":"2016-08-25T21:11:59Z","git_url":"git://github.com/SuperHouse/esp-open-rtos.git","ssh_url":"git@github.com:SuperHouse/esp-open-rtos.git","clone_url":"https://github.com/SuperHouse/esp-open-rtos.git","svn_url":"https://github.com/SuperHouse/esp-open-rtos","homepage":null,"size":10202,"stargazers_count":292,"watchers_count":292,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":56,"forks":87,"open_issues":56,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173"},"html":{"href":"https://github.com/SuperHouse/esp-open-rtos/pull/173"},"issue":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/173"},"comments":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/SuperHouse/esp-open-rtos/statuses/3a2cf74ebd731007eaa1988ef32311b3392e59d7"}}}}
{"actor":{"display_login":"kanflo"}}