{"action":"created","comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/78491446","id":78491446,"diff_hunk":"@@ -6,8 +6,10 @@\n # If we see that there is an external command by that name we just return. That will cause fish to\n # run the external command. On the other hand, if an external command isn't found we define a\n # function that will provide fallback behavior.\n-if not type -q -P realpath\n-    function realpath --description 'fallback realpath implementation'\n-        builtin fish_realpath $argv[-1]\n-    end\n+if not command -v realpath > /dev/null\n+\tif command -v grealpath > /dev/null\n+\t\talias realpath=grealpath\n+\telse\n+\t\talias realpath=fish_realpath","path":"share/functions/realpath.fish","position":12,"original_position":12,"commit_id":"3593b7ec0525933528f8f789d9a63dcaefbb6632","original_commit_id":"3593b7ec0525933528f8f789d9a63dcaefbb6632","user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"body":"Then let's nuke realpath.fish. It was a mistake. Scripts should have been using fish_realpath directly. ","created_at":"2016-09-13T03:25:50Z","updated_at":"2016-09-13T03:25:50Z","html_url":"https://github.com/fish-shell/fish-shell/pull/3374#discussion_r78491446","pull_request_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374","_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/78491446"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/3374#discussion_r78491446"},"pull_request":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374"}}},"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374","id":84868400,"html_url":"https://github.com/fish-shell/fish-shell/pull/3374","diff_url":"https://github.com/fish-shell/fish-shell/pull/3374.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/3374.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3374","number":3374,"state":"open","locked":false,"title":"Use 'grealpath' if installed for realpath fallback","user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nPer #3370, our realpath builtin/wrapper function will  not use GNU realpath if installed on BSD with a 'g' prefix.\r\n","created_at":"2016-09-12T13:11:35Z","updated_at":"2016-09-13T03:25:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52d46fcc372be0825dc7c46e5d8a20afb94b2cc0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3374/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/3593b7ec0525933528f8f789d9a63dcaefbb6632","head":{"label":"floam:realpath","ref":"realpath","sha":"3593b7ec0525933528f8f789d9a63dcaefbb6632","user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"repo":{"id":51836351,"name":"fish-shell","full_name":"floam/fish-shell","owner":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floam/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/floam/fish-shell","forks_url":"https://api.github.com/repos/floam/fish-shell/forks","keys_url":"https://api.github.com/repos/floam/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floam/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floam/fish-shell/teams","hooks_url":"https://api.github.com/repos/floam/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/floam/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/floam/fish-shell/events","assignees_url":"https://api.github.com/repos/floam/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/floam/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/floam/fish-shell/tags","blobs_url":"https://api.github.com/repos/floam/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floam/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floam/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/floam/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floam/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/floam/fish-shell/languages","stargazers_url":"https://api.github.com/repos/floam/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/floam/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/floam/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/floam/fish-shell/subscription","commits_url":"https://api.github.com/repos/floam/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/floam/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/floam/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/floam/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/floam/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/floam/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floam/fish-shell/merges","archive_url":"https://api.github.com/repos/floam/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floam/fish-shell/downloads","issues_url":"https://api.github.com/repos/floam/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/floam/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/floam/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/floam/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floam/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/floam/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/floam/fish-shell/deployments","created_at":"2016-02-16T13:07:03Z","updated_at":"2016-08-17T00:25:52Z","pushed_at":"2016-09-12T13:22:28Z","git_url":"git://github.com/floam/fish-shell.git","ssh_url":"git@github.com:floam/fish-shell.git","clone_url":"https://github.com/floam/fish-shell.git","svn_url":"https://github.com/floam/fish-shell","homepage":"http://fishshell.com","size":33280,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"f7c6426b21c6b2305c772a3e859bac27782af6cd","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"name":"fish-shell","full_name":"fish-shell/fish-shell","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/fish-shell/fish-shell/deployments","created_at":"2012-05-10T03:00:55Z","updated_at":"2016-09-12T15:10:25Z","pushed_at":"2016-09-13T01:48:46Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":41663,"stargazers_count":6519,"watchers_count":6519,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":624,"mirror_url":null,"open_issues_count":561,"forks":624,"open_issues":561,"watchers":6519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/3374"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/3374"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/3374/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3374/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/3593b7ec0525933528f8f789d9a63dcaefbb6632"}}}}
{"actor":{"display_login":"floam"}}