{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/52","repository_url":"https://api.github.com/repos/rackerlabs/cookbook-repose","labels_url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/52/comments","events_url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/52/events","html_url":"https://github.com/rackerlabs/cookbook-repose/pull/52","id":145813716,"number":52,"title":"Add more unit tests for filter and service recipes, update naming to match styles","user":{"login":"drenalin23","id":12398902,"avatar_url":"https://avatars.githubusercontent.com/u/12398902?v=3","gravatar_id":"","url":"https://api.github.com/users/drenalin23","html_url":"https://github.com/drenalin23","followers_url":"https://api.github.com/users/drenalin23/followers","following_url":"https://api.github.com/users/drenalin23/following{/other_user}","gists_url":"https://api.github.com/users/drenalin23/gists{/gist_id}","starred_url":"https://api.github.com/users/drenalin23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drenalin23/subscriptions","organizations_url":"https://api.github.com/users/drenalin23/orgs","repos_url":"https://api.github.com/users/drenalin23/repos","events_url":"https://api.github.com/users/drenalin23/events{/privacy}","received_events_url":"https://api.github.com/users/drenalin23/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-04T21:45:06Z","updated_at":"2016-04-07T01:14:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/cookbook-repose/pulls/52","html_url":"https://github.com/rackerlabs/cookbook-repose/pull/52","diff_url":"https://github.com/rackerlabs/cookbook-repose/pull/52.diff","patch_url":"https://github.com/rackerlabs/cookbook-repose/pull/52.patch"},"body":"# What\r\nAdded the rest of the a set of basic unit tests for the filter and service recipes.  There should now be 100% coverage for all of the basic resources in the current cookbook/recipes.\r\nUpdated naming conventions for tests and recipes where they did not match prevailing convention for the rest of the files.\r\n\r\n# How\r\nAdded chefspec tests in the test/unit/spec folder.  Updated the name of all tests to match prevalent naming style.  \r\nWith ChefDK installed run $ chef exec rspec test/unit \r\nto run all of the unit tests.\r\n\r\n# Why \r\nTo finish setting up basic unit testing for the repository.  To continue to cleanup any deviations in naming or style so that the recipes remain cleanly named.\r\n\r\n# TODO\r\nI should either remove the renaming of the connection-pool recipe OR should finish renaming the attribute names in the default files.  It could also be pulled into a separate PR.  Please comment on this part of the PR in particular and I'll adjust it.  "},"comment":{"url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/comments/206641826","html_url":"https://github.com/rackerlabs/cookbook-repose/pull/52#issuecomment-206641826","issue_url":"https://api.github.com/repos/rackerlabs/cookbook-repose/issues/52","id":206641826,"user":{"login":"filler","id":289288,"avatar_url":"https://avatars.githubusercontent.com/u/289288?v=3","gravatar_id":"","url":"https://api.github.com/users/filler","html_url":"https://github.com/filler","followers_url":"https://api.github.com/users/filler/followers","following_url":"https://api.github.com/users/filler/following{/other_user}","gists_url":"https://api.github.com/users/filler/gists{/gist_id}","starred_url":"https://api.github.com/users/filler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filler/subscriptions","organizations_url":"https://api.github.com/users/filler/orgs","repos_url":"https://api.github.com/users/filler/repos","events_url":"https://api.github.com/users/filler/events{/privacy}","received_events_url":"https://api.github.com/users/filler/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T01:14:50Z","updated_at":"2016-04-07T01:14:50Z","body":":+1: lgtm! :rocket:\r\n\r\nWould you like to be added as a curator of this book so you can manage PRs? It looks like MMI is doubling down which is awesome. "}}