{"action":"created","issue":{"url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/23","repository_url":"https://api.github.com/repos/FormidableLabs/victory-examples","labels_url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/23/comments","events_url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/23/events","html_url":"https://github.com/FormidableLabs/victory-examples/issues/23","id":160779257,"number":23,"title":"Kill demo folder?","user":{"login":"paulathevalley","id":768965,"avatar_url":"https://avatars.githubusercontent.com/u/768965?v=3","gravatar_id":"","url":"https://api.github.com/users/paulathevalley","html_url":"https://github.com/paulathevalley","followers_url":"https://api.github.com/users/paulathevalley/followers","following_url":"https://api.github.com/users/paulathevalley/following{/other_user}","gists_url":"https://api.github.com/users/paulathevalley/gists{/gist_id}","starred_url":"https://api.github.com/users/paulathevalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulathevalley/subscriptions","organizations_url":"https://api.github.com/users/paulathevalley/orgs","repos_url":"https://api.github.com/users/paulathevalley/repos","events_url":"https://api.github.com/users/paulathevalley/events{/privacy}","received_events_url":"https://api.github.com/users/paulathevalley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/FormidableLabs/victory-examples/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-16T22:56:30Z","updated_at":"2016-08-18T00:01:04Z","closed_at":null,"body":"`<CustomTheme />` example lives in `/src`. Both `/docs` and `/demo` refer to it—this follows the directory structure of other victory components but it’s starting to feel a little weird. \r\n\r\nWe may not need `/demo` anymore as one could run `builder run docs-dev` and see essentially the same thing. Would it be okay to kill `/demo` folder in favor of `/src` and `/docs`?"},"comment":{"url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/comments/240585983","html_url":"https://github.com/FormidableLabs/victory-examples/issues/23#issuecomment-240585983","issue_url":"https://api.github.com/repos/FormidableLabs/victory-examples/issues/23","id":240585983,"user":{"login":"paulathevalley","id":768965,"avatar_url":"https://avatars.githubusercontent.com/u/768965?v=3","gravatar_id":"","url":"https://api.github.com/users/paulathevalley","html_url":"https://github.com/paulathevalley","followers_url":"https://api.github.com/users/paulathevalley/followers","following_url":"https://api.github.com/users/paulathevalley/following{/other_user}","gists_url":"https://api.github.com/users/paulathevalley/gists{/gist_id}","starred_url":"https://api.github.com/users/paulathevalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulathevalley/subscriptions","organizations_url":"https://api.github.com/users/paulathevalley/orgs","repos_url":"https://api.github.com/users/paulathevalley/repos","events_url":"https://api.github.com/users/paulathevalley/events{/privacy}","received_events_url":"https://api.github.com/users/paulathevalley/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T00:01:04Z","updated_at":"2016-08-18T00:01:04Z","body":"On further discussion with @chrisbolin, the `src/` files are almost identical to the `ecology.md` files, which feels overcomplicated. We’d like to make this better. \r\n\r\nSo, this boils down to this question: what really is the example, the _source_ (`src/candlestick-dashboard.js`) or the _tutorial_ (`ecology.md`)? \r\n\r\n1. If the _tutorial_ is held sacred, we propose to nuke this repo, and move the `ecology.md` files over to `victory-docs`. \r\n\r\n2. If the _source_ is held sacred, we propose to nuke the `/docs` and write a script \"injecting\" the source file (e.g. `src/candlestick-dashboard.js`) into `ecology.md`. This option would require some standardization of the examples, for instance: a title (required), explanation (optional), and component (required, only one allowed). This also means the examples are less flexible. \r\n\r\n@boygirl what do you think?"}}
{"actor":{"display_login":"paulathevalley"}}