{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/68961814","id":68961814,"diff_hunk":"@@ -3965,6 +4006,45 @@ class CSocketSelectThread: public CSocketBaseThread\n         basesize = n;\n     }\n \n+    bool checkSocks()\n+    {\n+        bool ret = false;\n+        ForEachItemIn(i,items) {","path":"system/jlib/jsocket.cpp","position":313,"original_position":312,"commit_id":"5d180f0af9b0930ea3427c8138c67b1104694b7e","original_commit_id":"09ec43ed277a8cb2ed05a203fe6a276ec4f358fb","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"Ok, my policy is that if I touch a method I correct the formatting at that point. That sometimes extends to if I touch a class.","created_at":"2016-06-29T14:58:31Z","updated_at":"2016-06-29T14:58:31Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837#discussion_r68961814","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/68961814"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837#discussion_r68961814"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837","id":75369081,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8837","number":8837,"state":"open","locked":false,"title":"HPCC-12883 Remove socket fd max from select and epoll","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"This PR uses poll() in place of select() (except on Windows where there is a known won't fix issue with WSAPoll()) AND this PR also uses an array of pointers into heap storage for the SelectItem list of descriptors - so there is no longer indexing by fd into an array (epfdtbl) and thus no longer any limit on the number or value of socket descriptors.  The change for using an array of pointers is referenced in JIRA issue HPCC-10235.  Both issues are fixed here because both relate to a max fd value.\r\n\r\n@ghalliday and/or @jakesmith please review.\r\n\r\nSigned-off-by: Mark Kelly <mark.kelly@lexisnexis.com>","created_at":"2016-06-27T19:50:33Z","updated_at":"2016-06-29T14:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10d2ee7aa7a0f583b346d3ec345aa03d99ac3d4c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8837/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5d180f0af9b0930ea3427c8138c67b1104694b7e","head":{"label":"mckellyln:hpcc-12883b","ref":"hpcc-12883b","sha":"5d180f0af9b0930ea3427c8138c67b1104694b7e","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"repo":{"id":12089496,"name":"HPCC-Platform","full_name":"mckellyln/HPCC-Platform","owner":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mckellyln/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/mckellyln/HPCC-Platform","forks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/deployments","created_at":"2013-08-13T18:39:30Z","updated_at":"2015-05-06T15:40:27Z","pushed_at":"2016-06-29T13:47:46Z","git_url":"git://github.com/mckellyln/HPCC-Platform.git","ssh_url":"git@github.com:mckellyln/HPCC-Platform.git","clone_url":"https://github.com/mckellyln/HPCC-Platform.git","svn_url":"https://github.com/mckellyln/HPCC-Platform","homepage":"track.hpccsystems.com","size":169670,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.0.4","ref":"candidate-6.0.4","sha":"0814a69bc8b0c7e82c9e64a2436a70a44b7161f9","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-06-28T10:31:27Z","pushed_at":"2016-06-29T14:48:18Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":198620,"stargazers_count":282,"watchers_count":282,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":428,"forks":151,"open_issues":428,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8837"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8837"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8837/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8837/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5d180f0af9b0930ea3427c8138c67b1104694b7e"}}}}
{"actor":{"display_login":"jakesmith"}}