{"action":"created","issue":{"url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/8","repository_url":"https://api.github.com/repos/tbs1980/NumericalIntegration","labels_url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/8/comments","events_url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/8/events","html_url":"https://github.com/tbs1980/NumericalIntegration/issues/8","id":174422674,"number":8,"title":"Index out of bounds in Integrator.h","user":{"login":"gfinak","id":1385593,"avatar_url":"https://avatars.githubusercontent.com/u/1385593?v=3","gravatar_id":"","url":"https://api.github.com/users/gfinak","html_url":"https://github.com/gfinak","followers_url":"https://api.github.com/users/gfinak/followers","following_url":"https://api.github.com/users/gfinak/following{/other_user}","gists_url":"https://api.github.com/users/gfinak/gists{/gist_id}","starred_url":"https://api.github.com/users/gfinak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfinak/subscriptions","organizations_url":"https://api.github.com/users/gfinak/orgs","repos_url":"https://api.github.com/users/gfinak/repos","events_url":"https://api.github.com/users/gfinak/events{/privacy}","received_events_url":"https://api.github.com/users/gfinak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-01T02:31:36Z","updated_at":"2016-09-01T03:59:08Z","closed_at":null,"body":"I opened this issue at yixuan/RcppNumerical#1\r\nBriefly here: line 268\r\nThe for loop index, `k` can reach the size of the `m_integralList` and fail an assertion in Eigen, since `m_numSubintervals` can exceed `m_maxSubintervals` in the main integration loop where it is bound by `<=`. \r\nAs I mention in the other issue, I don't have a minimal reproducible example as this seems to be an extreme edge case but I do encounter it in my own code and tracked it down with lldb. My quick fix was to test whether `m_numSubintervals > m_maxSubintervals` and set the former equal to the latter if true."},"comment":{"url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/comments/243969811","html_url":"https://github.com/tbs1980/NumericalIntegration/issues/8#issuecomment-243969811","issue_url":"https://api.github.com/repos/tbs1980/NumericalIntegration/issues/8","id":243969811,"user":{"login":"mcsauder","id":2497951,"avatar_url":"https://avatars.githubusercontent.com/u/2497951?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsauder","html_url":"https://github.com/mcsauder","followers_url":"https://api.github.com/users/mcsauder/followers","following_url":"https://api.github.com/users/mcsauder/following{/other_user}","gists_url":"https://api.github.com/users/mcsauder/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsauder/subscriptions","organizations_url":"https://api.github.com/users/mcsauder/orgs","repos_url":"https://api.github.com/users/mcsauder/repos","events_url":"https://api.github.com/users/mcsauder/events{/privacy}","received_events_url":"https://api.github.com/users/mcsauder/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T03:59:08Z","updated_at":"2016-09-01T03:59:08Z","body":"Also, if at all possible, could you utilize the Eigen fork we created so that any other differences can be eliminated?\r\n\r\nIt should be very easy for you to clone, then make, then make install from our Eigen fork.  This will give you the Numerical Integration module capabilities you are exercising from directly within Eigen.  You will want to ensure your installation directory is set correctly, default is to /usr/local/include/ however, a typical package installation from your package manager would place Eigen3 in /usr/include/, so you'll need to update the installation directory, just read the notes when you run \"make\" and it will make sense:\r\n\r\n```\r\nhg clone ssh://hg@bitbucket.org/tbs1980/eigen-numerical-integration-module\r\ncd eigen-numerical-integration-module\r\nmkdir build && cd build && cmake ..\r\ncmake . -DCMAKE_INSTALL_PREFIX=/usr/\r\nsudo make install\r\n```\r\n"}}
{"actor":{"display_login":"mcsauder"}}