{"action":"closed","number":25061,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/25061","id":70451149,"html_url":"https://github.com/rails/rails/pull/25061","diff_url":"https://github.com/rails/rails/pull/25061.diff","patch_url":"https://github.com/rails/rails/pull/25061.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/25061","number":25061,"state":"closed","locked":false,"title":"Use RAILS_MAX_THREADS as pool size on all adapters","user":{"login":"eugeneius","id":432189,"avatar_url":"https://avatars.githubusercontent.com/u/432189?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneius","html_url":"https://github.com/eugeneius","followers_url":"https://api.github.com/users/eugeneius/followers","following_url":"https://api.github.com/users/eugeneius/following{/other_user}","gists_url":"https://api.github.com/users/eugeneius/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneius/subscriptions","organizations_url":"https://api.github.com/users/eugeneius/orgs","repos_url":"https://api.github.com/users/eugeneius/repos","events_url":"https://api.github.com/users/eugeneius/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneius/received_events","type":"User","site_admin":false},"body":"When `RAILS_MAX_THREADS` is set, the postgresql adapter uses it as the connection pool size, so that there are always enough connections available to serve Action Cable requests: https://github.com/rails/rails/pull/23528\r\n\r\nThe same logic applies when using the mysql2 or sqlite3 adapters.\r\n\r\n/cc @schneems ","created_at":"2016-05-18T00:08:55Z","updated_at":"2016-05-24T14:33:35Z","closed_at":"2016-05-24T14:33:34Z","merged_at":"2016-05-24T14:33:34Z","merge_commit_sha":"61f6dc5b45cd734967b026dee5ccf786d590cbf3","assignee":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/25061/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/25061/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/25061/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/1bb7615c3b3a12199623f845ce08145f331d3d68","head":{"label":"eugeneius:rails_max_threads_mysql_sqlite","ref":"rails_max_threads_mysql_sqlite","sha":"1bb7615c3b3a12199623f845ce08145f331d3d68","user":{"login":"eugeneius","id":432189,"avatar_url":"https://avatars.githubusercontent.com/u/432189?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneius","html_url":"https://github.com/eugeneius","followers_url":"https://api.github.com/users/eugeneius/followers","following_url":"https://api.github.com/users/eugeneius/following{/other_user}","gists_url":"https://api.github.com/users/eugeneius/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneius/subscriptions","organizations_url":"https://api.github.com/users/eugeneius/orgs","repos_url":"https://api.github.com/users/eugeneius/repos","events_url":"https://api.github.com/users/eugeneius/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneius/received_events","type":"User","site_admin":false},"repo":{"id":16918547,"name":"rails","full_name":"eugeneius/rails","owner":{"login":"eugeneius","id":432189,"avatar_url":"https://avatars.githubusercontent.com/u/432189?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneius","html_url":"https://github.com/eugeneius","followers_url":"https://api.github.com/users/eugeneius/followers","following_url":"https://api.github.com/users/eugeneius/following{/other_user}","gists_url":"https://api.github.com/users/eugeneius/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneius/subscriptions","organizations_url":"https://api.github.com/users/eugeneius/orgs","repos_url":"https://api.github.com/users/eugeneius/repos","events_url":"https://api.github.com/users/eugeneius/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eugeneius/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/eugeneius/rails","forks_url":"https://api.github.com/repos/eugeneius/rails/forks","keys_url":"https://api.github.com/repos/eugeneius/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eugeneius/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eugeneius/rails/teams","hooks_url":"https://api.github.com/repos/eugeneius/rails/hooks","issue_events_url":"https://api.github.com/repos/eugeneius/rails/issues/events{/number}","events_url":"https://api.github.com/repos/eugeneius/rails/events","assignees_url":"https://api.github.com/repos/eugeneius/rails/assignees{/user}","branches_url":"https://api.github.com/repos/eugeneius/rails/branches{/branch}","tags_url":"https://api.github.com/repos/eugeneius/rails/tags","blobs_url":"https://api.github.com/repos/eugeneius/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eugeneius/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eugeneius/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/eugeneius/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eugeneius/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/eugeneius/rails/languages","stargazers_url":"https://api.github.com/repos/eugeneius/rails/stargazers","contributors_url":"https://api.github.com/repos/eugeneius/rails/contributors","subscribers_url":"https://api.github.com/repos/eugeneius/rails/subscribers","subscription_url":"https://api.github.com/repos/eugeneius/rails/subscription","commits_url":"https://api.github.com/repos/eugeneius/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/eugeneius/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/eugeneius/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/eugeneius/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/eugeneius/rails/contents/{+path}","compare_url":"https://api.github.com/repos/eugeneius/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eugeneius/rails/merges","archive_url":"https://api.github.com/repos/eugeneius/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eugeneius/rails/downloads","issues_url":"https://api.github.com/repos/eugeneius/rails/issues{/number}","pulls_url":"https://api.github.com/repos/eugeneius/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/eugeneius/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/eugeneius/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eugeneius/rails/labels{/name}","releases_url":"https://api.github.com/repos/eugeneius/rails/releases{/id}","deployments_url":"https://api.github.com/repos/eugeneius/rails/deployments","created_at":"2014-02-17T16:15:02Z","updated_at":"2015-03-10T00:47:44Z","pushed_at":"2016-05-24T06:37:54Z","git_url":"git://github.com/eugeneius/rails.git","ssh_url":"git@github.com:eugeneius/rails.git","clone_url":"https://github.com/eugeneius/rails.git","svn_url":"https://github.com/eugeneius/rails","homepage":"http://rubyonrails.org","size":128172,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"661ed303f49128b92a5a88d25deebcebbc891b55","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-05-24T14:31:21Z","pushed_at":"2016-05-24T14:33:34Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":342736,"stargazers_count":31276,"watchers_count":31276,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12686,"mirror_url":null,"open_issues_count":988,"forks":12686,"open_issues":988,"watchers":31276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/25061"},"html":{"href":"https://github.com/rails/rails/pull/25061"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/25061"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/25061/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/25061/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/25061/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/1bb7615c3b3a12199623f845ce08145f331d3d68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":10,"deletions":2,"changed_files":10}}
{"actor":{"display_login":"schneems"}}