{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/71052373","id":71052373,"diff_hunk":"@@ -147,6 +147,7 @@ protected void startUp() throws Exception {\n     // Run http service on random port\n     httpService = new CommonNettyHttpServiceBuilder(configuration)\n       .setHost(hostname.getCanonicalHostName())\n+      .setPort(configuration.getInt(Constants.AppFabric.SERVER_PORT))","path":"cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/services/AppFabricServer.java","position":17,"original_position":17,"commit_id":"0878bd9ad7f7811701d99e7881d99e6db2705313","original_commit_id":"0878bd9ad7f7811701d99e7881d99e6db2705313","user":{"login":"anew","id":483004,"avatar_url":"https://avatars.githubusercontent.com/u/483004?v=3","gravatar_id":"","url":"https://api.github.com/users/anew","html_url":"https://github.com/anew","followers_url":"https://api.github.com/users/anew/followers","following_url":"https://api.github.com/users/anew/following{/other_user}","gists_url":"https://api.github.com/users/anew/gists{/gist_id}","starred_url":"https://api.github.com/users/anew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anew/subscriptions","organizations_url":"https://api.github.com/users/anew/orgs","repos_url":"https://api.github.com/users/anew/repos","events_url":"https://api.github.com/users/anew/events{/privacy}","received_events_url":"https://api.github.com/users/anew/received_events","type":"User","site_admin":false},"body":"this will throw a NullPointerException if the configuration does not contain Constants.AppFabric.SERVER_PORT. A default value of 0 needs to be added to cdap-common/src/main/resources/cdap-default.xml.\r\n\r\nAnd the same for all the other newly introduced port configs. ","created_at":"2016-07-15T23:10:43Z","updated_at":"2016-07-15T23:10:43Z","html_url":"https://github.com/caskdata/cdap/pull/6051#discussion_r71052373","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6051","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/71052373"},"html":{"href":"https://github.com/caskdata/cdap/pull/6051#discussion_r71052373"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6051"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6051","id":77660215,"html_url":"https://github.com/caskdata/cdap/pull/6051","diff_url":"https://github.com/caskdata/cdap/pull/6051.diff","patch_url":"https://github.com/caskdata/cdap/pull/6051.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6051","number":6051,"state":"open","locked":false,"title":"CDAP-6321 Master Service Bind Port Not Configurable","user":{"login":"bennythomps","id":6827467,"avatar_url":"https://avatars.githubusercontent.com/u/6827467?v=3","gravatar_id":"","url":"https://api.github.com/users/bennythomps","html_url":"https://github.com/bennythomps","followers_url":"https://api.github.com/users/bennythomps/followers","following_url":"https://api.github.com/users/bennythomps/following{/other_user}","gists_url":"https://api.github.com/users/bennythomps/gists{/gist_id}","starred_url":"https://api.github.com/users/bennythomps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennythomps/subscriptions","organizations_url":"https://api.github.com/users/bennythomps/orgs","repos_url":"https://api.github.com/users/bennythomps/repos","events_url":"https://api.github.com/users/bennythomps/events{/privacy}","received_events_url":"https://api.github.com/users/bennythomps/received_events","type":"User","site_admin":false},"body":"Added ability to configure port and bind addresses for master services (via CDAP conf).","created_at":"2016-07-15T18:44:25Z","updated_at":"2016-07-15T23:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe3c86c66a0f528720fe9d97ae87dc4c7a1c4255","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6051/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6051/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6051/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/0878bd9ad7f7811701d99e7881d99e6db2705313","head":{"label":"thomsonreuters:develop","ref":"develop","sha":"0878bd9ad7f7811701d99e7881d99e6db2705313","user":{"login":"thomsonreuters","id":686958,"avatar_url":"https://avatars.githubusercontent.com/u/686958?v=3","gravatar_id":"","url":"https://api.github.com/users/thomsonreuters","html_url":"https://github.com/thomsonreuters","followers_url":"https://api.github.com/users/thomsonreuters/followers","following_url":"https://api.github.com/users/thomsonreuters/following{/other_user}","gists_url":"https://api.github.com/users/thomsonreuters/gists{/gist_id}","starred_url":"https://api.github.com/users/thomsonreuters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomsonreuters/subscriptions","organizations_url":"https://api.github.com/users/thomsonreuters/orgs","repos_url":"https://api.github.com/users/thomsonreuters/repos","events_url":"https://api.github.com/users/thomsonreuters/events{/privacy}","received_events_url":"https://api.github.com/users/thomsonreuters/received_events","type":"Organization","site_admin":false},"repo":{"id":63363452,"name":"cdap","full_name":"thomsonreuters/cdap","owner":{"login":"thomsonreuters","id":686958,"avatar_url":"https://avatars.githubusercontent.com/u/686958?v=3","gravatar_id":"","url":"https://api.github.com/users/thomsonreuters","html_url":"https://github.com/thomsonreuters","followers_url":"https://api.github.com/users/thomsonreuters/followers","following_url":"https://api.github.com/users/thomsonreuters/following{/other_user}","gists_url":"https://api.github.com/users/thomsonreuters/gists{/gist_id}","starred_url":"https://api.github.com/users/thomsonreuters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomsonreuters/subscriptions","organizations_url":"https://api.github.com/users/thomsonreuters/orgs","repos_url":"https://api.github.com/users/thomsonreuters/repos","events_url":"https://api.github.com/users/thomsonreuters/events{/privacy}","received_events_url":"https://api.github.com/users/thomsonreuters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thomsonreuters/cdap","description":"Cask Data Application Platform (CDAP)","fork":true,"url":"https://api.github.com/repos/thomsonreuters/cdap","forks_url":"https://api.github.com/repos/thomsonreuters/cdap/forks","keys_url":"https://api.github.com/repos/thomsonreuters/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomsonreuters/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomsonreuters/cdap/teams","hooks_url":"https://api.github.com/repos/thomsonreuters/cdap/hooks","issue_events_url":"https://api.github.com/repos/thomsonreuters/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/thomsonreuters/cdap/events","assignees_url":"https://api.github.com/repos/thomsonreuters/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/thomsonreuters/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/thomsonreuters/cdap/tags","blobs_url":"https://api.github.com/repos/thomsonreuters/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomsonreuters/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomsonreuters/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomsonreuters/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomsonreuters/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/thomsonreuters/cdap/languages","stargazers_url":"https://api.github.com/repos/thomsonreuters/cdap/stargazers","contributors_url":"https://api.github.com/repos/thomsonreuters/cdap/contributors","subscribers_url":"https://api.github.com/repos/thomsonreuters/cdap/subscribers","subscription_url":"https://api.github.com/repos/thomsonreuters/cdap/subscription","commits_url":"https://api.github.com/repos/thomsonreuters/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomsonreuters/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomsonreuters/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomsonreuters/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomsonreuters/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/thomsonreuters/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomsonreuters/cdap/merges","archive_url":"https://api.github.com/repos/thomsonreuters/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomsonreuters/cdap/downloads","issues_url":"https://api.github.com/repos/thomsonreuters/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/thomsonreuters/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/thomsonreuters/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/thomsonreuters/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomsonreuters/cdap/labels{/name}","releases_url":"https://api.github.com/repos/thomsonreuters/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/thomsonreuters/cdap/deployments","created_at":"2016-07-14T19:22:35Z","updated_at":"2016-07-14T19:22:52Z","pushed_at":"2016-07-15T18:41:53Z","git_url":"git://github.com/thomsonreuters/cdap.git","ssh_url":"git@github.com:thomsonreuters/cdap.git","clone_url":"https://github.com/thomsonreuters/cdap.git","svn_url":"https://github.com/thomsonreuters/cdap","homepage":"http://cdap.io","size":420371,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"79932caaa2cd525ac8ab3c377e087c35bf8b1306","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-12T22:52:35Z","pushed_at":"2016-07-15T23:01:14Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":623602,"stargazers_count":134,"watchers_count":134,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":25,"forks":48,"open_issues":25,"watchers":134,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6051"},"html":{"href":"https://github.com/caskdata/cdap/pull/6051"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6051"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6051/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6051/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6051/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/0878bd9ad7f7811701d99e7881d99e6db2705313"}}}}
{"actor":{"display_login":"anew"}}