{"action":"created","comment":{"url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/comments/89651790","pull_request_review_id":10197175,"id":89651790,"diff_hunk":"@@ -0,0 +1,69 @@\n+require 'rails_helper'\n+\n+RSpec.describe UsersController, type: :controller do\n+  describe '#index' do\n+    it 'redirects to home page' do\n+      get :index\n+      expect(response).to redirect_to(root_path)\n+    end\n+  end\n+\n+  let(:user){ create(:user) }\n+  describe '#create' do\n+    context 'with valid params' do\n+      def valid_user\n+        post :create, params: { user: attributes_for(:user)}\n+      end\n+\n+      it 'saves a record to the database' do\n+        count_before = User.count\n+        valid_user\n+\n+        count_after = User.count\n+        expect(count_after).to eq(count_before + 1)\n+      end\n+\n+      it 'saves session id of current user' do\n+        # u = create(:user)\n+        # expect(session[:user_id]).to eq(u.id)\n+","path":"spec/controllers/users_controller_spec.rb","position":29,"original_position":29,"commit_id":"ab30018c034b2ab11f4aa4785ed15207f20c5e1a","original_commit_id":"ab30018c034b2ab11f4aa4785ed15207f20c5e1a","user":{"login":"jamesonji","id":6577026,"avatar_url":"https://avatars.githubusercontent.com/u/6577026?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesonji","html_url":"https://github.com/jamesonji","followers_url":"https://api.github.com/users/jamesonji/followers","following_url":"https://api.github.com/users/jamesonji/following{/other_user}","gists_url":"https://api.github.com/users/jamesonji/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesonji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesonji/subscriptions","organizations_url":"https://api.github.com/users/jamesonji/orgs","repos_url":"https://api.github.com/users/jamesonji/repos","events_url":"https://api.github.com/users/jamesonji/events{/privacy}","received_events_url":"https://api.github.com/users/jamesonji/received_events","type":"User","site_admin":false},"body":"Remove comment and space below it.\r\n\r\nProbably better to set session[:user_id] to nil first and then do the comparison.  I like the way you did in the comment though. ","created_at":"2016-11-25T19:22:50Z","updated_at":"2016-11-25T19:34:23Z","html_url":"https://github.com/CodeCoreYVR/indie_arcade/pull/114#discussion_r89651790","pull_request_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/comments/89651790"},"html":{"href":"https://github.com/CodeCoreYVR/indie_arcade/pull/114#discussion_r89651790"},"pull_request":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114","id":95220172,"html_url":"https://github.com/CodeCoreYVR/indie_arcade/pull/114","diff_url":"https://github.com/CodeCoreYVR/indie_arcade/pull/114.diff","patch_url":"https://github.com/CodeCoreYVR/indie_arcade/pull/114.patch","issue_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/114","number":114,"state":"open","locked":false,"title":"User controller rspec","user":{"login":"david82213","id":5046524,"avatar_url":"https://avatars.githubusercontent.com/u/5046524?v=3","gravatar_id":"","url":"https://api.github.com/users/david82213","html_url":"https://github.com/david82213","followers_url":"https://api.github.com/users/david82213/followers","following_url":"https://api.github.com/users/david82213/following{/other_user}","gists_url":"https://api.github.com/users/david82213/gists{/gist_id}","starred_url":"https://api.github.com/users/david82213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david82213/subscriptions","organizations_url":"https://api.github.com/users/david82213/orgs","repos_url":"https://api.github.com/users/david82213/repos","events_url":"https://api.github.com/users/david82213/events{/privacy}","received_events_url":"https://api.github.com/users/david82213/received_events","type":"User","site_admin":false},"body":"testing for the user controller actions are implemented.\r\n@jamesonji please, review this. ","created_at":"2016-11-24T19:02:24Z","updated_at":"2016-11-25T19:34:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a1bff48f020b32af54c0447e0edb330798e0a9f","assignee":{"login":"jamesonji","id":6577026,"avatar_url":"https://avatars.githubusercontent.com/u/6577026?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesonji","html_url":"https://github.com/jamesonji","followers_url":"https://api.github.com/users/jamesonji/followers","following_url":"https://api.github.com/users/jamesonji/following{/other_user}","gists_url":"https://api.github.com/users/jamesonji/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesonji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesonji/subscriptions","organizations_url":"https://api.github.com/users/jamesonji/orgs","repos_url":"https://api.github.com/users/jamesonji/repos","events_url":"https://api.github.com/users/jamesonji/events{/privacy}","received_events_url":"https://api.github.com/users/jamesonji/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamesonji","id":6577026,"avatar_url":"https://avatars.githubusercontent.com/u/6577026?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesonji","html_url":"https://github.com/jamesonji","followers_url":"https://api.github.com/users/jamesonji/followers","following_url":"https://api.github.com/users/jamesonji/following{/other_user}","gists_url":"https://api.github.com/users/jamesonji/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesonji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesonji/subscriptions","organizations_url":"https://api.github.com/users/jamesonji/orgs","repos_url":"https://api.github.com/users/jamesonji/repos","events_url":"https://api.github.com/users/jamesonji/events{/privacy}","received_events_url":"https://api.github.com/users/jamesonji/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114/commits","review_comments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114/comments","review_comment_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/114/comments","statuses_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/statuses/ab30018c034b2ab11f4aa4785ed15207f20c5e1a","head":{"label":"CodeCoreYVR:user_controller_rspec","ref":"user_controller_rspec","sha":"ab30018c034b2ab11f4aa4785ed15207f20c5e1a","user":{"login":"CodeCoreYVR","id":6611839,"avatar_url":"https://avatars.githubusercontent.com/u/6611839?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeCoreYVR","html_url":"https://github.com/CodeCoreYVR","followers_url":"https://api.github.com/users/CodeCoreYVR/followers","following_url":"https://api.github.com/users/CodeCoreYVR/following{/other_user}","gists_url":"https://api.github.com/users/CodeCoreYVR/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeCoreYVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeCoreYVR/subscriptions","organizations_url":"https://api.github.com/users/CodeCoreYVR/orgs","repos_url":"https://api.github.com/users/CodeCoreYVR/repos","events_url":"https://api.github.com/users/CodeCoreYVR/events{/privacy}","received_events_url":"https://api.github.com/users/CodeCoreYVR/received_events","type":"Organization","site_admin":false},"repo":{"id":67845309,"name":"indie_arcade","full_name":"CodeCoreYVR/indie_arcade","owner":{"login":"CodeCoreYVR","id":6611839,"avatar_url":"https://avatars.githubusercontent.com/u/6611839?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeCoreYVR","html_url":"https://github.com/CodeCoreYVR","followers_url":"https://api.github.com/users/CodeCoreYVR/followers","following_url":"https://api.github.com/users/CodeCoreYVR/following{/other_user}","gists_url":"https://api.github.com/users/CodeCoreYVR/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeCoreYVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeCoreYVR/subscriptions","organizations_url":"https://api.github.com/users/CodeCoreYVR/orgs","repos_url":"https://api.github.com/users/CodeCoreYVR/repos","events_url":"https://api.github.com/users/CodeCoreYVR/events{/privacy}","received_events_url":"https://api.github.com/users/CodeCoreYVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeCoreYVR/indie_arcade","description":null,"fork":false,"url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade","forks_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/forks","keys_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/teams","hooks_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/hooks","issue_events_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/events{/number}","events_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/events","assignees_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/assignees{/user}","branches_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/branches{/branch}","tags_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/tags","blobs_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/languages","stargazers_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/stargazers","contributors_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/contributors","subscribers_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/subscribers","subscription_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/subscription","commits_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/contents/{+path}","compare_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/merges","archive_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/downloads","issues_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues{/number}","pulls_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/labels{/name}","releases_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/releases{/id}","deployments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/deployments","created_at":"2016-09-10T02:14:33Z","updated_at":"2016-11-24T19:44:51Z","pushed_at":"2016-11-25T19:06:44Z","git_url":"git://github.com/CodeCoreYVR/indie_arcade.git","ssh_url":"git@github.com:CodeCoreYVR/indie_arcade.git","clone_url":"https://github.com/CodeCoreYVR/indie_arcade.git","svn_url":"https://github.com/CodeCoreYVR/indie_arcade","homepage":null,"size":11009,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":2,"default_branch":"integration"}},"base":{"label":"CodeCoreYVR:integration","ref":"integration","sha":"df9cef43c7db08a8786adc8df4cb9d0cc2e3bdfe","user":{"login":"CodeCoreYVR","id":6611839,"avatar_url":"https://avatars.githubusercontent.com/u/6611839?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeCoreYVR","html_url":"https://github.com/CodeCoreYVR","followers_url":"https://api.github.com/users/CodeCoreYVR/followers","following_url":"https://api.github.com/users/CodeCoreYVR/following{/other_user}","gists_url":"https://api.github.com/users/CodeCoreYVR/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeCoreYVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeCoreYVR/subscriptions","organizations_url":"https://api.github.com/users/CodeCoreYVR/orgs","repos_url":"https://api.github.com/users/CodeCoreYVR/repos","events_url":"https://api.github.com/users/CodeCoreYVR/events{/privacy}","received_events_url":"https://api.github.com/users/CodeCoreYVR/received_events","type":"Organization","site_admin":false},"repo":{"id":67845309,"name":"indie_arcade","full_name":"CodeCoreYVR/indie_arcade","owner":{"login":"CodeCoreYVR","id":6611839,"avatar_url":"https://avatars.githubusercontent.com/u/6611839?v=3","gravatar_id":"","url":"https://api.github.com/users/CodeCoreYVR","html_url":"https://github.com/CodeCoreYVR","followers_url":"https://api.github.com/users/CodeCoreYVR/followers","following_url":"https://api.github.com/users/CodeCoreYVR/following{/other_user}","gists_url":"https://api.github.com/users/CodeCoreYVR/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeCoreYVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeCoreYVR/subscriptions","organizations_url":"https://api.github.com/users/CodeCoreYVR/orgs","repos_url":"https://api.github.com/users/CodeCoreYVR/repos","events_url":"https://api.github.com/users/CodeCoreYVR/events{/privacy}","received_events_url":"https://api.github.com/users/CodeCoreYVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeCoreYVR/indie_arcade","description":null,"fork":false,"url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade","forks_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/forks","keys_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/teams","hooks_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/hooks","issue_events_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/events{/number}","events_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/events","assignees_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/assignees{/user}","branches_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/branches{/branch}","tags_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/tags","blobs_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/languages","stargazers_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/stargazers","contributors_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/contributors","subscribers_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/subscribers","subscription_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/subscription","commits_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/contents/{+path}","compare_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/merges","archive_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/downloads","issues_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues{/number}","pulls_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/labels{/name}","releases_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/releases{/id}","deployments_url":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/deployments","created_at":"2016-09-10T02:14:33Z","updated_at":"2016-11-24T19:44:51Z","pushed_at":"2016-11-25T19:06:44Z","git_url":"git://github.com/CodeCoreYVR/indie_arcade.git","ssh_url":"git@github.com:CodeCoreYVR/indie_arcade.git","clone_url":"https://github.com/CodeCoreYVR/indie_arcade.git","svn_url":"https://github.com/CodeCoreYVR/indie_arcade","homepage":null,"size":11009,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":2,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114"},"html":{"href":"https://github.com/CodeCoreYVR/indie_arcade/pull/114"},"issue":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/114"},"comments":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/CodeCoreYVR/indie_arcade/statuses/ab30018c034b2ab11f4aa4785ed15207f20c5e1a"}}}}
{"actor":{"display_login":"jamesonji"}}