{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/88527763","pull_request_review_id":9099550,"id":88527763,"diff_hunk":"@@ -40,13 +41,12 @@\n @SuppressWarnings(\"unused\")\n @Configuration\n @EnableCaching\n-@AutoConfigureAfter(value = { MetricsConfiguration.class<% if (databaseType == 'sql' || databaseType == 'mongodb') { %>, DatabaseConfiguration.class<% } %> })\n+@AutoConfigureAfter(value = { MetricsConfiguration.class })\n+@AutoConfigureBefore(value = { WebConfigurer.class<% if (databaseType == 'sql' || databaseType == 'mongodb') { %>, DatabaseConfiguration.class<% } %> })\n public class CacheConfiguration {\n ","path":"generators/server/templates/src/main/java/package/config/_CacheConfiguration.java","position":16,"original_position":16,"commit_id":"b2d26c9abc4be16875fa795ab72c2d90ab452aba","original_commit_id":"b2d26c9abc4be16875fa795ab72c2d90ab452aba","user":{"login":"henri-tremblay","id":1216819,"avatar_url":"https://avatars.githubusercontent.com/u/1216819?v=3","gravatar_id":"","url":"https://api.github.com/users/henri-tremblay","html_url":"https://github.com/henri-tremblay","followers_url":"https://api.github.com/users/henri-tremblay/followers","following_url":"https://api.github.com/users/henri-tremblay/following{/other_user}","gists_url":"https://api.github.com/users/henri-tremblay/gists{/gist_id}","starred_url":"https://api.github.com/users/henri-tremblay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henri-tremblay/subscriptions","organizations_url":"https://api.github.com/users/henri-tremblay/orgs","repos_url":"https://api.github.com/users/henri-tremblay/repos","events_url":"https://api.github.com/users/henri-tremblay/events{/privacy}","received_events_url":"https://api.github.com/users/henri-tremblay/received_events","type":"User","site_admin":false},"body":"I mean that instead of having a `private CacheManager cacheManager` you can have a local variable in the `cacheManager()` method.\r\n\r\nSince I'm commenting code that isn't in the diff, it makes it a bit easier to be clear... Sorry about that.","created_at":"2016-11-17T19:29:15Z","updated_at":"2016-11-17T19:29:15Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/4482#discussion_r88527763","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/88527763"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/4482#discussion_r88527763"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482","id":93865525,"html_url":"https://github.com/jhipster/generator-jhipster/pull/4482","diff_url":"https://github.com/jhipster/generator-jhipster/pull/4482.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/4482.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4482","number":4482,"state":"open","locked":false,"title":"[DON'T MERGE] fixed Hazelcast initialization","user":{"login":"gAmUssA","id":433085,"avatar_url":"https://avatars.githubusercontent.com/u/433085?v=3","gravatar_id":"","url":"https://api.github.com/users/gAmUssA","html_url":"https://github.com/gAmUssA","followers_url":"https://api.github.com/users/gAmUssA/followers","following_url":"https://api.github.com/users/gAmUssA/following{/other_user}","gists_url":"https://api.github.com/users/gAmUssA/gists{/gist_id}","starred_url":"https://api.github.com/users/gAmUssA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gAmUssA/subscriptions","organizations_url":"https://api.github.com/users/gAmUssA/orgs","repos_url":"https://api.github.com/users/gAmUssA/repos","events_url":"https://api.github.com/users/gAmUssA/events{/privacy}","received_events_url":"https://api.github.com/users/gAmUssA/received_events","type":"User","site_admin":false},"body":"Attempt to fix #4189 \r\n\r\nChanges:\r\n- custom `HazelcastCacheRegionFactory` is not required. Removed ❌\r\n- `HazelcastInstance` created by Spring\r\n- `HazelcastInstance` is retrieved by name in Hibernate config and Web filter config\r\n-  `HazelcastInstance` bean created before Hibernate L2 cache and Web filter - see `CacheConfiguration`\r\n- removed static `HazelcastInstance` property","created_at":"2016-11-15T22:52:22Z","updated_at":"2016-11-17T19:29:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acc7112ea8a9d7cce253e11b04da80a15153028e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4482/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/b2d26c9abc4be16875fa795ab72c2d90ab452aba","head":{"label":"gAmUssA:hazelcast-jhipster-4189","ref":"hazelcast-jhipster-4189","sha":"b2d26c9abc4be16875fa795ab72c2d90ab452aba","user":{"login":"gAmUssA","id":433085,"avatar_url":"https://avatars.githubusercontent.com/u/433085?v=3","gravatar_id":"","url":"https://api.github.com/users/gAmUssA","html_url":"https://github.com/gAmUssA","followers_url":"https://api.github.com/users/gAmUssA/followers","following_url":"https://api.github.com/users/gAmUssA/following{/other_user}","gists_url":"https://api.github.com/users/gAmUssA/gists{/gist_id}","starred_url":"https://api.github.com/users/gAmUssA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gAmUssA/subscriptions","organizations_url":"https://api.github.com/users/gAmUssA/orgs","repos_url":"https://api.github.com/users/gAmUssA/repos","events_url":"https://api.github.com/users/gAmUssA/events{/privacy}","received_events_url":"https://api.github.com/users/gAmUssA/received_events","type":"User","site_admin":false},"repo":{"id":73330726,"name":"generator-jhipster","full_name":"gAmUssA/generator-jhipster","owner":{"login":"gAmUssA","id":433085,"avatar_url":"https://avatars.githubusercontent.com/u/433085?v=3","gravatar_id":"","url":"https://api.github.com/users/gAmUssA","html_url":"https://github.com/gAmUssA","followers_url":"https://api.github.com/users/gAmUssA/followers","following_url":"https://api.github.com/users/gAmUssA/following{/other_user}","gists_url":"https://api.github.com/users/gAmUssA/gists{/gist_id}","starred_url":"https://api.github.com/users/gAmUssA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gAmUssA/subscriptions","organizations_url":"https://api.github.com/users/gAmUssA/orgs","repos_url":"https://api.github.com/users/gAmUssA/repos","events_url":"https://api.github.com/users/gAmUssA/events{/privacy}","received_events_url":"https://api.github.com/users/gAmUssA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gAmUssA/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":true,"url":"https://api.github.com/repos/gAmUssA/generator-jhipster","forks_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/forks","keys_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/events","assignees_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/merges","archive_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/gAmUssA/generator-jhipster/deployments","created_at":"2016-11-09T23:46:58Z","updated_at":"2016-11-09T23:47:02Z","pushed_at":"2016-11-16T02:47:33Z","git_url":"git://github.com/gAmUssA/generator-jhipster.git","ssh_url":"git@github.com:gAmUssA/generator-jhipster.git","clone_url":"https://github.com/gAmUssA/generator-jhipster.git","svn_url":"https://github.com/gAmUssA/generator-jhipster","homepage":"http://jhipster.github.io","size":14810,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"93e361aebffc1018d9b74c1a450b4ed45040cf7c","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2016-11-17T17:54:27Z","pushed_at":"2016-11-17T12:21:05Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":19935,"stargazers_count":5391,"watchers_count":5391,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1186,"mirror_url":null,"open_issues_count":38,"forks":1186,"open_issues":38,"watchers":5391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/4482"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4482"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4482/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4482/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/b2d26c9abc4be16875fa795ab72c2d90ab452aba"}}}}
{"actor":{"display_login":"henri-tremblay"}}