{"action":"created","issue":{"url":"https://api.github.com/repos/skylines-project/skylines/issues/442","repository_url":"https://api.github.com/repos/skylines-project/skylines","labels_url":"https://api.github.com/repos/skylines-project/skylines/issues/442/labels{/name}","comments_url":"https://api.github.com/repos/skylines-project/skylines/issues/442/comments","events_url":"https://api.github.com/repos/skylines-project/skylines/issues/442/events","html_url":"https://github.com/skylines-project/skylines/issues/442","id":178414788,"number":442,"title":"Airfield names garbled","user":{"login":"jharting","id":167352,"avatar_url":"https://avatars.githubusercontent.com/u/167352?v=3","gravatar_id":"","url":"https://api.github.com/users/jharting","html_url":"https://github.com/jharting","followers_url":"https://api.github.com/users/jharting/followers","following_url":"https://api.github.com/users/jharting/following{/other_user}","gists_url":"https://api.github.com/users/jharting/gists{/gist_id}","starred_url":"https://api.github.com/users/jharting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jharting/subscriptions","organizations_url":"https://api.github.com/users/jharting/orgs","repos_url":"https://api.github.com/users/jharting/repos","events_url":"https://api.github.com/users/jharting/events{/privacy}","received_events_url":"https://api.github.com/users/jharting/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-09-21T17:40:15Z","updated_at":"2016-10-11T18:17:44Z","closed_at":"2016-09-29T16:13:33Z","body":"Surprisingly quite a few airfields in the Czech Republic have their names garbled on skylines (e.g. Medlamky instead of Medlanky, Krizantov instead of Krizanov etc.) I found more than 10 typos just within CZ names. I know you import the airfield database from welt2000. I tried contacting them at http://www.segelflug.de/vereine/welt2000/ but they never responded.\r\n\r\nIt kind of hurts to see the name of your homebase misspelled all the time :-(\r\n\r\nMy question is if any of these would be possible:\r\n\r\n1) Does anyone here know the welt2000 authors and can possibly push my changes through? Even better does anyone here have access and can review and apply my changes? I have a patch ready it just needs to get in.\r\n\r\n2) Would it be possible to fork welt2000 database under skylines-project org on github? If think that having the database on github would be beneficial anyway (more contributions, better transparency of changes, etc.) I need to double check but I think it is OK with their T&C."},"comment":{"url":"https://api.github.com/repos/skylines-project/skylines/issues/comments/253000005","html_url":"https://github.com/skylines-project/skylines/issues/442#issuecomment-253000005","issue_url":"https://api.github.com/repos/skylines-project/skylines/issues/442","id":253000005,"user":{"login":"jharting","id":167352,"avatar_url":"https://avatars.githubusercontent.com/u/167352?v=3","gravatar_id":"","url":"https://api.github.com/users/jharting","html_url":"https://github.com/jharting","followers_url":"https://api.github.com/users/jharting/followers","following_url":"https://api.github.com/users/jharting/following{/other_user}","gists_url":"https://api.github.com/users/jharting/gists{/gist_id}","starred_url":"https://api.github.com/users/jharting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jharting/subscriptions","organizations_url":"https://api.github.com/users/jharting/orgs","repos_url":"https://api.github.com/users/jharting/repos","events_url":"https://api.github.com/users/jharting/events{/privacy}","received_events_url":"https://api.github.com/users/jharting/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T18:17:44Z","updated_at":"2016-10-11T18:17:44Z","body":"@Turbo87  So what I did was:\r\n\r\n1) Spinned up Vagrant with current master (btw that change you suggested did not work for me - more on that later)\r\n2) Modified `skylines/lib/waypoints/welt2000.py` to fetch the airport database from the old location\r\n3) Run the import\r\n4) Verified that I see the old names in the db\r\n5) Created a user, uploaded a flight\r\n6) Verified that I see the old airport name associated with the flight\r\n7) Reverted the change in `skylines/lib/waypoints/welt2000.py`\r\n8) Run the import again\r\n\r\nAnd it worked. After the last step when I run the server again I can see the flight having the new airport name and so does a db query return:\r\n\r\n```\r\nskylines=# select id, name from airports where icao = 'LKKA';\r\n  id  |   name   \r\n------+----------\r\n 3520 | Krizanov\r\n(1 row)\r\n```\r\nAs the script run I noticed it explicitly logging the changes, e.g.:\r\n```\r\nCZ  Krizantov  LKKA\r\n  name from Krizantov to Krizanov\r\nCZ  Medlamky  LKCM\r\n  name from Medlamky to Medlanky\r\nCZ  Moravsca Trebova  LKMK\r\n...\r\n```\r\n\r\nDid you see that as well? Could you by chance omit **--commit** option in the import command?"}}
{"actor":{"display_login":"jharting"}}