{"action":"created","issue":{"url":"https://api.github.com/repos/babel/babylon/issues/263","repository_url":"https://api.github.com/repos/babel/babylon","labels_url":"https://api.github.com/repos/babel/babylon/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/babel/babylon/issues/263/comments","events_url":"https://api.github.com/repos/babel/babylon/issues/263/events","html_url":"https://github.com/babel/babylon/pull/263","id":196788872,"number":263,"title":"Refactor tokenizer types file","user":{"login":"xtuc","id":1493671,"avatar_url":"https://avatars.githubusercontent.com/u/1493671?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuc","html_url":"https://github.com/xtuc","followers_url":"https://api.github.com/users/xtuc/followers","following_url":"https://api.github.com/users/xtuc/following{/other_user}","gists_url":"https://api.github.com/users/xtuc/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuc/subscriptions","organizations_url":"https://api.github.com/users/xtuc/orgs","repos_url":"https://api.github.com/users/xtuc/repos","events_url":"https://api.github.com/users/xtuc/events{/privacy}","received_events_url":"https://api.github.com/users/xtuc/received_events","type":"User","site_admin":false},"labels":[{"id":370920733,"url":"https://api.github.com/repos/babel/babylon/labels/internal","name":"internal","color":"1d76db","default":false},{"id":460383733,"url":"https://api.github.com/repos/babel/babylon/labels/polish","name":"polish","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-20T21:44:00Z","updated_at":"2016-12-25T11:39:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/babel/babylon/pulls/263","html_url":"https://github.com/babel/babylon/pull/263","diff_url":"https://github.com/babel/babylon/pull/263.diff","patch_url":"https://github.com/babel/babylon/pull/263.patch"},"body":"<!--- \r\nBefore making a PR please make sure to read our contributing guidelines \r\nhttps://github.com/babel/babylon/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n| Q                 | A\r\n| ----------------- | ---\r\n| Bug fix?          | no\r\n| Breaking change?  | no\r\n| New feature?      | no\r\n| Deprecations?     | no\r\n| Spec compliancy?  | no\r\n| Tests added/pass? | no\r\n| Fixed tickets     | no\r\n| License           | MIT\r\n\r\n<!-- Describe your changes below in as much detail as possible -->\r\n\r\nThis is not particularly wanted but it seems clearer to me. It's also to be consistent in usage / definition.\r\n"},"comment":{"url":"https://api.github.com/repos/babel/babylon/issues/comments/269119001","html_url":"https://github.com/babel/babylon/pull/263#issuecomment-269119001","issue_url":"https://api.github.com/repos/babel/babylon/issues/263","id":269119001,"user":{"login":"xtuc","id":1493671,"avatar_url":"https://avatars.githubusercontent.com/u/1493671?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuc","html_url":"https://github.com/xtuc","followers_url":"https://api.github.com/users/xtuc/followers","following_url":"https://api.github.com/users/xtuc/following{/other_user}","gists_url":"https://api.github.com/users/xtuc/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuc/subscriptions","organizations_url":"https://api.github.com/users/xtuc/orgs","repos_url":"https://api.github.com/users/xtuc/repos","events_url":"https://api.github.com/users/xtuc/events{/privacy}","received_events_url":"https://api.github.com/users/xtuc/received_events","type":"User","site_admin":false},"created_at":"2016-12-25T11:39:05Z","updated_at":"2016-12-25T11:39:05Z","body":"Yes absolutely.\r\n\r\nBranch `refactor-tokenizer-types`:\r\n\r\n| name                            | run    |\r\n|-|-|\r\n| ./fixtures/angular.js           | 494ms  |\r\n| ./fixtures/backbone.js          | 46ms   |\r\n| ./fixtures/ember.debug.js       | 1223ms |\r\n| ./fixtures/jquery.js            | 243ms  |\r\n| ./fixtures/react-with-addons.js | 525ms  |\r\n\r\nBranch `master`:\r\n\r\n| name                            | run    |\r\n|-|-|\r\n| ./fixtures/angular.js           | 514ms  |\r\n| ./fixtures/backbone.js          | 55ms   |\r\n| ./fixtures/ember.debug.js       | 1262ms |\r\n| ./fixtures/jquery.js            | 242ms  |\r\n| ./fixtures/react-with-addons.js | 510ms  |\r\n\r\n\r\nDiff:\r\n\r\n| name                            | run    |\r\n|-|-|\r\n| ./fixtures/angular.js           | -18ms |\r\n| ./fixtures/backbone.js          | -9ms   |\r\n| ./fixtures/ember.debug.js       | -39ms |\r\n| ./fixtures/jquery.js            | +1ms  |\r\n| ./fixtures/react-with-addons.js | -15ms  |\r\n\r\nWould be great to include your performance tests in Babylon tests (only on CI). What do you think about it?"}}
{"actor":{"display_login":"xtuc"}}