{"action":"created","comment":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/48813767","id":48813767,"diff_hunk":"@@ -457,23 +464,48 @@ void replica::on_learn_reply(\n     // local state is newer than learnee\n     if (resp->last_committed_decree < _app->last_committed_decree())\n     {\n-        dwarn(\"%s: on_learn_reply[%016llx]: learnee = %s, learner state is newer than learnee (primary): %\" PRId64 \" vs %\" PRId64,\n+        dwarn(\n+            \"%s: on_learn_reply[%016llx]: learnee = %s, learner state is newer than learnee (primary): %\" PRId64 \" vs %\" PRId64 \", create new app\",\n             name(), req->signature, resp->config.primary.to_string(),\n             _app->last_committed_decree(),\n             resp->last_committed_decree            \n             );\n \n+        // TODO(qinzuoyan):\n+        // - we'd better backup the old data, which may be recovered in some way.","path":"src/apps/replication/lib/replica_learn.cpp","position":155,"original_position":110,"commit_id":"6e2c99c8c699c1d8059c1e352610863d57b545cc","original_commit_id":"fa9b91343054ab6f1e8f7b733094c50306a7fd6f","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"body":"close + open(new) = reset?","created_at":"2016-01-05T05:34:14Z","updated_at":"2016-01-05T05:34:14Z","html_url":"https://github.com/imzhenyu/rDSN/pull/163#discussion_r48813767","pull_request_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/48813767"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/163#discussion_r48813767"},"pull_request":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163","id":54966501,"html_url":"https://github.com/imzhenyu/rDSN/pull/163","diff_url":"https://github.com/imzhenyu/rDSN/pull/163.diff","patch_url":"https://github.com/imzhenyu/rDSN/pull/163.patch","issue_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/163","number":163,"state":"open","locked":false,"title":"add rep_tests case 204/205/206/207/210/211 for testing learning","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"and some bugfixs and refactors.\r\nimplements #52 ","created_at":"2016-01-04T11:38:08Z","updated_at":"2016-01-05T05:34:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84a64222f9f99a05ff2505d09b5ee619f3d5017e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163/commits","review_comments_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163/comments","review_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/163/comments","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/6e2c99c8c699c1d8059c1e352610863d57b545cc","head":{"label":"qinzuoyan:master","ref":"master","sha":"6e2c99c8c699c1d8059c1e352610863d57b545cc","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"repo":{"id":38676944,"name":"rDSN","full_name":"qinzuoyan/rDSN","owner":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qinzuoyan/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/qinzuoyan/rDSN","forks_url":"https://api.github.com/repos/qinzuoyan/rDSN/forks","keys_url":"https://api.github.com/repos/qinzuoyan/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinzuoyan/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinzuoyan/rDSN/teams","hooks_url":"https://api.github.com/repos/qinzuoyan/rDSN/hooks","issue_events_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/qinzuoyan/rDSN/events","assignees_url":"https://api.github.com/repos/qinzuoyan/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/qinzuoyan/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/qinzuoyan/rDSN/tags","blobs_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinzuoyan/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/qinzuoyan/rDSN/languages","stargazers_url":"https://api.github.com/repos/qinzuoyan/rDSN/stargazers","contributors_url":"https://api.github.com/repos/qinzuoyan/rDSN/contributors","subscribers_url":"https://api.github.com/repos/qinzuoyan/rDSN/subscribers","subscription_url":"https://api.github.com/repos/qinzuoyan/rDSN/subscription","commits_url":"https://api.github.com/repos/qinzuoyan/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinzuoyan/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/qinzuoyan/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/qinzuoyan/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinzuoyan/rDSN/merges","archive_url":"https://api.github.com/repos/qinzuoyan/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinzuoyan/rDSN/downloads","issues_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/qinzuoyan/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/qinzuoyan/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/qinzuoyan/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinzuoyan/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/qinzuoyan/rDSN/releases{/id}","created_at":"2015-07-07T09:15:38Z","updated_at":"2015-07-07T09:15:39Z","pushed_at":"2016-01-05T04:24:23Z","git_url":"git://github.com/qinzuoyan/rDSN.git","ssh_url":"git@github.com:qinzuoyan/rDSN.git","clone_url":"https://github.com/qinzuoyan/rDSN.git","svn_url":"https://github.com/qinzuoyan/rDSN","homepage":null,"size":52096,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"imzhenyu:master","ref":"master","sha":"d32170f2ce187b698775f41700eb434aa60eedaf","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","created_at":"2015-06-08T00:54:11Z","updated_at":"2016-01-02T21:19:29Z","pushed_at":"2016-01-05T05:22:01Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":52286,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":24,"forks":4,"open_issues":24,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/163"},"issue":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/163"},"comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/imzhenyu/rDSN/statuses/6e2c99c8c699c1d8059c1e352610863d57b545cc"}}}}