{"action":"created","comment":{"url":"https://api.github.com/repos/libdfp/libdfp/pulls/comments/70272265","id":70272265,"diff_hunk":"@@ -324,7 +325,15 @@ main (int argc, char *argv[])\n   numinputs = ftell (inputfile) / sizeof (inputtype);\n   rewind (inputfile);\n   inputs = malloc (numinputs * sizeof (inputtype));\n-  fread (inputs, sizeof (inputtype), numinputs, inputfile);\n+\n+  r = fread (inputs, sizeof (inputtype), numinputs, inputfile);\n+  if (ferror (inputfile))","path":"tests/test-amort.c","position":15,"original_position":15,"commit_id":"cc029ae373a8a7f7f22efaef086ca75930f0f3b2","original_commit_id":"cc029ae373a8a7f7f22efaef086ca75930f0f3b2","user":{"login":"pmur","id":12972156,"avatar_url":"https://avatars.githubusercontent.com/u/12972156?v=3","gravatar_id":"","url":"https://api.github.com/users/pmur","html_url":"https://github.com/pmur","followers_url":"https://api.github.com/users/pmur/followers","following_url":"https://api.github.com/users/pmur/following{/other_user}","gists_url":"https://api.github.com/users/pmur/gists{/gist_id}","starred_url":"https://api.github.com/users/pmur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmur/subscriptions","organizations_url":"https://api.github.com/users/pmur/orgs","repos_url":"https://api.github.com/users/pmur/repos","events_url":"https://api.github.com/users/pmur/events{/privacy}","received_events_url":"https://api.github.com/users/pmur/received_events","type":"User","site_admin":false},"body":"I suspect you will also want to check that r == numinputs too.  It also removes the need for the unused attribute above.","created_at":"2016-07-11T14:49:52Z","updated_at":"2016-07-11T14:49:52Z","html_url":"https://github.com/libdfp/libdfp/pull/51#discussion_r70272265","pull_request_url":"https://api.github.com/repos/libdfp/libdfp/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/comments/70272265"},"html":{"href":"https://github.com/libdfp/libdfp/pull/51#discussion_r70272265"},"pull_request":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/libdfp/libdfp/pulls/51","id":76953497,"html_url":"https://github.com/libdfp/libdfp/pull/51","diff_url":"https://github.com/libdfp/libdfp/pull/51.diff","patch_url":"https://github.com/libdfp/libdfp/pull/51.patch","issue_url":"https://api.github.com/repos/libdfp/libdfp/issues/51","number":51,"state":"open","locked":false,"title":"Fix -Wunused-result warning message in test-amort.c","user":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"body":"This patch gets rid of the following message during \"make check\":\r\n\r\n./tests/test-amort.c: In function ‘main’:\r\n./tests/test-amort.c:327:9: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]\r\n   fread (inputs, sizeof (inputtype), numinputs, inputfile);\r\n         ^\r\n\r\nFixes issue https://github.com/libdfp/libdfp/issues/42\r\n\r\nSigned-off-by: Murilo Opsfelder Araujo <muriloo@linux.vnet.ibm.com>","created_at":"2016-07-11T13:28:51Z","updated_at":"2016-07-11T14:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1e1e211d17406ef9a0829405c83ceedf50d24ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libdfp/libdfp/pulls/51/commits","review_comments_url":"https://api.github.com/repos/libdfp/libdfp/pulls/51/comments","review_comment_url":"https://api.github.com/repos/libdfp/libdfp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libdfp/libdfp/issues/51/comments","statuses_url":"https://api.github.com/repos/libdfp/libdfp/statuses/cc029ae373a8a7f7f22efaef086ca75930f0f3b2","head":{"label":"mopsfelder:issues/42","ref":"issues/42","sha":"cc029ae373a8a7f7f22efaef086ca75930f0f3b2","user":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"repo":{"id":63069425,"name":"libdfp","full_name":"mopsfelder/libdfp","owner":{"login":"mopsfelder","id":2346907,"avatar_url":"https://avatars.githubusercontent.com/u/2346907?v=3","gravatar_id":"","url":"https://api.github.com/users/mopsfelder","html_url":"https://github.com/mopsfelder","followers_url":"https://api.github.com/users/mopsfelder/followers","following_url":"https://api.github.com/users/mopsfelder/following{/other_user}","gists_url":"https://api.github.com/users/mopsfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/mopsfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mopsfelder/subscriptions","organizations_url":"https://api.github.com/users/mopsfelder/orgs","repos_url":"https://api.github.com/users/mopsfelder/repos","events_url":"https://api.github.com/users/mopsfelder/events{/privacy}","received_events_url":"https://api.github.com/users/mopsfelder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mopsfelder/libdfp","description":"Decimal Floating Point C Library","fork":true,"url":"https://api.github.com/repos/mopsfelder/libdfp","forks_url":"https://api.github.com/repos/mopsfelder/libdfp/forks","keys_url":"https://api.github.com/repos/mopsfelder/libdfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mopsfelder/libdfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mopsfelder/libdfp/teams","hooks_url":"https://api.github.com/repos/mopsfelder/libdfp/hooks","issue_events_url":"https://api.github.com/repos/mopsfelder/libdfp/issues/events{/number}","events_url":"https://api.github.com/repos/mopsfelder/libdfp/events","assignees_url":"https://api.github.com/repos/mopsfelder/libdfp/assignees{/user}","branches_url":"https://api.github.com/repos/mopsfelder/libdfp/branches{/branch}","tags_url":"https://api.github.com/repos/mopsfelder/libdfp/tags","blobs_url":"https://api.github.com/repos/mopsfelder/libdfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mopsfelder/libdfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mopsfelder/libdfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mopsfelder/libdfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mopsfelder/libdfp/statuses/{sha}","languages_url":"https://api.github.com/repos/mopsfelder/libdfp/languages","stargazers_url":"https://api.github.com/repos/mopsfelder/libdfp/stargazers","contributors_url":"https://api.github.com/repos/mopsfelder/libdfp/contributors","subscribers_url":"https://api.github.com/repos/mopsfelder/libdfp/subscribers","subscription_url":"https://api.github.com/repos/mopsfelder/libdfp/subscription","commits_url":"https://api.github.com/repos/mopsfelder/libdfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mopsfelder/libdfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mopsfelder/libdfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mopsfelder/libdfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mopsfelder/libdfp/contents/{+path}","compare_url":"https://api.github.com/repos/mopsfelder/libdfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mopsfelder/libdfp/merges","archive_url":"https://api.github.com/repos/mopsfelder/libdfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mopsfelder/libdfp/downloads","issues_url":"https://api.github.com/repos/mopsfelder/libdfp/issues{/number}","pulls_url":"https://api.github.com/repos/mopsfelder/libdfp/pulls{/number}","milestones_url":"https://api.github.com/repos/mopsfelder/libdfp/milestones{/number}","notifications_url":"https://api.github.com/repos/mopsfelder/libdfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mopsfelder/libdfp/labels{/name}","releases_url":"https://api.github.com/repos/mopsfelder/libdfp/releases{/id}","deployments_url":"https://api.github.com/repos/mopsfelder/libdfp/deployments","created_at":"2016-07-11T13:15:47Z","updated_at":"2016-07-11T13:15:49Z","pushed_at":"2016-07-11T13:20:23Z","git_url":"git://github.com/mopsfelder/libdfp.git","ssh_url":"git@github.com:mopsfelder/libdfp.git","clone_url":"https://github.com/mopsfelder/libdfp.git","svn_url":"https://github.com/mopsfelder/libdfp","homepage":null,"size":2204,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libdfp:master","ref":"master","sha":"62cdd3a15b6c81e9767db229c8fe9cf90a11d494","user":{"login":"libdfp","id":6402467,"avatar_url":"https://avatars.githubusercontent.com/u/6402467?v=3","gravatar_id":"","url":"https://api.github.com/users/libdfp","html_url":"https://github.com/libdfp","followers_url":"https://api.github.com/users/libdfp/followers","following_url":"https://api.github.com/users/libdfp/following{/other_user}","gists_url":"https://api.github.com/users/libdfp/gists{/gist_id}","starred_url":"https://api.github.com/users/libdfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libdfp/subscriptions","organizations_url":"https://api.github.com/users/libdfp/orgs","repos_url":"https://api.github.com/users/libdfp/repos","events_url":"https://api.github.com/users/libdfp/events{/privacy}","received_events_url":"https://api.github.com/users/libdfp/received_events","type":"Organization","site_admin":false},"repo":{"id":15912252,"name":"libdfp","full_name":"libdfp/libdfp","owner":{"login":"libdfp","id":6402467,"avatar_url":"https://avatars.githubusercontent.com/u/6402467?v=3","gravatar_id":"","url":"https://api.github.com/users/libdfp","html_url":"https://github.com/libdfp","followers_url":"https://api.github.com/users/libdfp/followers","following_url":"https://api.github.com/users/libdfp/following{/other_user}","gists_url":"https://api.github.com/users/libdfp/gists{/gist_id}","starred_url":"https://api.github.com/users/libdfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libdfp/subscriptions","organizations_url":"https://api.github.com/users/libdfp/orgs","repos_url":"https://api.github.com/users/libdfp/repos","events_url":"https://api.github.com/users/libdfp/events{/privacy}","received_events_url":"https://api.github.com/users/libdfp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libdfp/libdfp","description":"Decimal Floating Point C Library","fork":false,"url":"https://api.github.com/repos/libdfp/libdfp","forks_url":"https://api.github.com/repos/libdfp/libdfp/forks","keys_url":"https://api.github.com/repos/libdfp/libdfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libdfp/libdfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libdfp/libdfp/teams","hooks_url":"https://api.github.com/repos/libdfp/libdfp/hooks","issue_events_url":"https://api.github.com/repos/libdfp/libdfp/issues/events{/number}","events_url":"https://api.github.com/repos/libdfp/libdfp/events","assignees_url":"https://api.github.com/repos/libdfp/libdfp/assignees{/user}","branches_url":"https://api.github.com/repos/libdfp/libdfp/branches{/branch}","tags_url":"https://api.github.com/repos/libdfp/libdfp/tags","blobs_url":"https://api.github.com/repos/libdfp/libdfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libdfp/libdfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libdfp/libdfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/libdfp/libdfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libdfp/libdfp/statuses/{sha}","languages_url":"https://api.github.com/repos/libdfp/libdfp/languages","stargazers_url":"https://api.github.com/repos/libdfp/libdfp/stargazers","contributors_url":"https://api.github.com/repos/libdfp/libdfp/contributors","subscribers_url":"https://api.github.com/repos/libdfp/libdfp/subscribers","subscription_url":"https://api.github.com/repos/libdfp/libdfp/subscription","commits_url":"https://api.github.com/repos/libdfp/libdfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/libdfp/libdfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/libdfp/libdfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/libdfp/libdfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/libdfp/libdfp/contents/{+path}","compare_url":"https://api.github.com/repos/libdfp/libdfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libdfp/libdfp/merges","archive_url":"https://api.github.com/repos/libdfp/libdfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libdfp/libdfp/downloads","issues_url":"https://api.github.com/repos/libdfp/libdfp/issues{/number}","pulls_url":"https://api.github.com/repos/libdfp/libdfp/pulls{/number}","milestones_url":"https://api.github.com/repos/libdfp/libdfp/milestones{/number}","notifications_url":"https://api.github.com/repos/libdfp/libdfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libdfp/libdfp/labels{/name}","releases_url":"https://api.github.com/repos/libdfp/libdfp/releases{/id}","deployments_url":"https://api.github.com/repos/libdfp/libdfp/deployments","created_at":"2014-01-14T19:08:58Z","updated_at":"2016-06-25T04:02:35Z","pushed_at":"2016-07-11T13:28:51Z","git_url":"git://github.com/libdfp/libdfp.git","ssh_url":"git@github.com:libdfp/libdfp.git","clone_url":"https://github.com/libdfp/libdfp.git","svn_url":"https://github.com/libdfp/libdfp","homepage":null,"size":2294,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":14,"forks":11,"open_issues":14,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/51"},"html":{"href":"https://github.com/libdfp/libdfp/pull/51"},"issue":{"href":"https://api.github.com/repos/libdfp/libdfp/issues/51"},"comments":{"href":"https://api.github.com/repos/libdfp/libdfp/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libdfp/libdfp/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/libdfp/libdfp/statuses/cc029ae373a8a7f7f22efaef086ca75930f0f3b2"}}}}
{"actor":{"display_login":"pmur"}}