{"action":"created","comment":{"url":"https://api.github.com/repos/mautic/mautic/pulls/comments/81531755","pull_request_review_id":2504412,"id":81531755,"diff_hunk":"@@ -1516,6 +1515,31 @@ public function importLead($fields, $data, $owner = null, $list = null, $tags =\n             );\n         }\n \n+        $booleanTrue  = ['1', 'true', 'yes'];","path":"app/bundles/LeadBundle/Model/LeadModel.php","position":null,"original_position":12,"commit_id":"4ec33acd4cec011cefd46b1750e73f030731f39e","original_commit_id":"d6520fa735157387ff638cd4e708842ef1c73673","user":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"body":"Great suggestion. Implemented.","created_at":"2016-10-03T11:21:42Z","updated_at":"2016-10-03T11:21:42Z","html_url":"https://github.com/mautic/mautic/pull/2616#discussion_r81531755","pull_request_url":"https://api.github.com/repos/mautic/mautic/pulls/2616","_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments/81531755"},"html":{"href":"https://github.com/mautic/mautic/pull/2616#discussion_r81531755"},"pull_request":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2616"}}},"pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/2616","id":87518437,"html_url":"https://github.com/mautic/mautic/pull/2616","diff_url":"https://github.com/mautic/mautic/pull/2616.diff","patch_url":"https://github.com/mautic/mautic/pull/2616.patch","issue_url":"https://api.github.com/repos/mautic/mautic/issues/2616","number":2616,"state":"open","locked":false,"title":"Default values imported, boolean values can be true/false/yes/no","user":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"body":"[//]: # ( Please answer the following questions: )\r\n\r\n| Q  | A\r\n| --- | ---\r\n| Bug fix? | Y\r\n| New feature? | Y\r\n| Related user documentation PR URL | TODO\r\n| Related developer documentation PR URL | /\r\n| Issues addressed (#s or URLs) | https://github.com/mautic/mautic/issues/1863, https://github.com/mautic/mautic/issues/2502\r\n| BC breaks? | N\r\n| Deprecations? | N\r\n\r\n[//]: # ( Note that all new features should have a related user and/or developer documentation PR in their respective repositories. )\r\n\r\n[//]: # ( Required: )\r\n#### Description:\r\nThis PR does 2 things:\r\n1) It imports also default values if the contact fields have any\r\n2) It allows to import yes/no/true/false as Boolean values.\r\n\r\n#### Steps to test this PR:\r\n1. Apply this PR.\r\n2. Test again.\r\n\r\nNotice:\r\n1. All 8 contacts were imported with correct Boolean values.\r\n2. All contact have the default value in the Phone field.\r\n\r\n[//]: # ( As applicable: )\r\n#### Steps to reproduce the bug:\r\n1. Make sure you have at least one contact field with default value. For example Phone field.\r\n2. Create a new contact field called \"Boolean Test\" and is type of Boolean.\r\n3. Try to import the following CSV:\r\n\r\n```\r\n\"email\", \"stage\", \"company\", \"boolean_test\"\r\n\"john2@doe.com\", \"test\", \"Google\", \"No\"\r\n\"john1@doe.com\", \"test\", \"Google\", 0\r\n\"john3@doe.com\", \"test\", \"Google\", \"false\"\r\n\"john4@doe.com\", \"test\", \"Google\", \"FALSE\"\r\n\"johana1@doana.com\", \"stage A\", \"Apple\", 1\r\n\"johana2@doana.com\", \"stage A\", \"Apple\", \"Yes\"\r\n\"johana3@doana.com\", \"stage A\", \"Apple\", \"true\"\r\n\"johana4@doana.com\", \"stage A\", \"Apple\", \"TRUE\"\r\n```\r\n\r\nNotice:\r\n1. It will import only 2 out of 8 contacts. The reason is that text Boolean values are not valid.\r\n2. The default Phone value wasn't imported to the contacts who got saved.\r\n","created_at":"2016-09-30T15:48:07Z","updated_at":"2016-10-03T11:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a383029460c7d46ecf88de8d6777e7e4b42d60d1","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mautic/mautic/milestones/20","html_url":"https://github.com/mautic/mautic/milestones/2.2.1","labels_url":"https://api.github.com/repos/mautic/mautic/milestones/20/labels","id":2029396,"number":20,"title":"2.2.1","description":"","creator":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":1,"state":"open","created_at":"2016-09-26T16:46:48Z","updated_at":"2016-10-03T10:58:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mautic/mautic/pulls/2616/commits","review_comments_url":"https://api.github.com/repos/mautic/mautic/pulls/2616/comments","review_comment_url":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/2616/comments","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/4ec33acd4cec011cefd46b1750e73f030731f39e","head":{"label":"escopecz:import-fixes","ref":"import-fixes","sha":"4ec33acd4cec011cefd46b1750e73f030731f39e","user":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"repo":{"id":31202004,"name":"mautic","full_name":"escopecz/mautic","owner":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/escopecz/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":true,"url":"https://api.github.com/repos/escopecz/mautic","forks_url":"https://api.github.com/repos/escopecz/mautic/forks","keys_url":"https://api.github.com/repos/escopecz/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/escopecz/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/escopecz/mautic/teams","hooks_url":"https://api.github.com/repos/escopecz/mautic/hooks","issue_events_url":"https://api.github.com/repos/escopecz/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/escopecz/mautic/events","assignees_url":"https://api.github.com/repos/escopecz/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/escopecz/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/escopecz/mautic/tags","blobs_url":"https://api.github.com/repos/escopecz/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/escopecz/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/escopecz/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/escopecz/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/escopecz/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/escopecz/mautic/languages","stargazers_url":"https://api.github.com/repos/escopecz/mautic/stargazers","contributors_url":"https://api.github.com/repos/escopecz/mautic/contributors","subscribers_url":"https://api.github.com/repos/escopecz/mautic/subscribers","subscription_url":"https://api.github.com/repos/escopecz/mautic/subscription","commits_url":"https://api.github.com/repos/escopecz/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/escopecz/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/escopecz/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/escopecz/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/escopecz/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/escopecz/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/escopecz/mautic/merges","archive_url":"https://api.github.com/repos/escopecz/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/escopecz/mautic/downloads","issues_url":"https://api.github.com/repos/escopecz/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/escopecz/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/escopecz/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/escopecz/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/escopecz/mautic/labels{/name}","releases_url":"https://api.github.com/repos/escopecz/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/escopecz/mautic/deployments","created_at":"2015-02-23T09:52:24Z","updated_at":"2015-03-09T14:56:38Z","pushed_at":"2016-10-03T11:20:54Z","git_url":"git://github.com/escopecz/mautic.git","ssh_url":"git@github.com:escopecz/mautic.git","clone_url":"https://github.com/escopecz/mautic.git","svn_url":"https://github.com/escopecz/mautic","homepage":"http://mautic.org","size":58044,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mautic:staging","ref":"staging","sha":"dc2ba012c34921facf6d8f12d334e1f15db4c622","user":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":12204147,"name":"mautic","full_name":"mautic/mautic","owner":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mautic/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":false,"url":"https://api.github.com/repos/mautic/mautic","forks_url":"https://api.github.com/repos/mautic/mautic/forks","keys_url":"https://api.github.com/repos/mautic/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/mautic/teams","hooks_url":"https://api.github.com/repos/mautic/mautic/hooks","issue_events_url":"https://api.github.com/repos/mautic/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/mautic/events","assignees_url":"https://api.github.com/repos/mautic/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/mautic/tags","blobs_url":"https://api.github.com/repos/mautic/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/mautic/languages","stargazers_url":"https://api.github.com/repos/mautic/mautic/stargazers","contributors_url":"https://api.github.com/repos/mautic/mautic/contributors","subscribers_url":"https://api.github.com/repos/mautic/mautic/subscribers","subscription_url":"https://api.github.com/repos/mautic/mautic/subscription","commits_url":"https://api.github.com/repos/mautic/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/mautic/merges","archive_url":"https://api.github.com/repos/mautic/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/mautic/downloads","issues_url":"https://api.github.com/repos/mautic/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/mautic/labels{/name}","releases_url":"https://api.github.com/repos/mautic/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/mautic/mautic/deployments","created_at":"2013-08-19T00:36:28Z","updated_at":"2016-10-03T08:40:32Z","pushed_at":"2016-10-03T11:20:55Z","git_url":"git://github.com/mautic/mautic.git","ssh_url":"git@github.com:mautic/mautic.git","clone_url":"https://github.com/mautic/mautic.git","svn_url":"https://github.com/mautic/mautic","homepage":"https://www.mautic.org","size":64814,"stargazers_count":1048,"watchers_count":1048,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":366,"mirror_url":null,"open_issues_count":432,"forks":366,"open_issues":432,"watchers":1048,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2616"},"html":{"href":"https://github.com/mautic/mautic/pull/2616"},"issue":{"href":"https://api.github.com/repos/mautic/mautic/issues/2616"},"comments":{"href":"https://api.github.com/repos/mautic/mautic/issues/2616/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2616/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/mautic/pulls/2616/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/mautic/statuses/4ec33acd4cec011cefd46b1750e73f030731f39e"}}}}
{"actor":{"display_login":"escopecz"}}