{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/88573061","pull_request_review_id":9144063,"id":88573061,"diff_hunk":"@@ -0,0 +1,55 @@\n+/*\n+ * Copyright 2016 Netflix, Inc.\n+ * <p>\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with\n+ *  the License. You may obtain a copy of the License at\n+ *  <p>\n+ *  http://www.apache.org/licenses/LICENSE-2.0\n+ *  <p>\n+ *  Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on\n+ *  an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the\n+ *  specific language governing permissions and limitations under the License.\n+ */\n+\n+package io.reactivesocket.perf;\n+\n+import io.reactivesocket.ReactiveSocket;\n+import io.reactivesocket.util.PayloadImpl;\n+import org.openjdk.jmh.annotations.Benchmark;\n+import org.openjdk.jmh.annotations.BenchmarkMode;\n+import org.openjdk.jmh.annotations.Level;\n+import org.openjdk.jmh.annotations.Mode;\n+import org.openjdk.jmh.annotations.OutputTimeUnit;\n+import org.openjdk.jmh.annotations.Param;\n+import org.openjdk.jmh.annotations.Scope;\n+import org.openjdk.jmh.annotations.Setup;\n+import org.openjdk.jmh.annotations.State;\n+import org.openjdk.jmh.infra.Blackhole;\n+\n+import java.util.concurrent.ThreadLocalRandom;\n+import java.util.concurrent.TimeUnit;\n+import java.util.function.Supplier;\n+\n+@BenchmarkMode(Mode.Throughput)\n+@OutputTimeUnit(TimeUnit.SECONDS)\n+@State(Scope.Benchmark)\n+public class RequestResponseLargePayloadPerf extends AbstractReactiveSocketPerf {\n+\n+    @Param({\"16\", \"1024\"})","path":"reactivesocket-examples/src/jmh/java/io/reactivesocket/perf/RequestResponseLargePayloadPerf.java","position":38,"original_position":38,"commit_id":"d79412e0dd4b92ce7bf2d2e3414126b9e4e2d4e6","original_commit_id":"d79412e0dd4b92ce7bf2d2e3414126b9e4e2d4e6","user":{"login":"stevegury","id":376195,"avatar_url":"https://avatars.githubusercontent.com/u/376195?v=3","gravatar_id":"","url":"https://api.github.com/users/stevegury","html_url":"https://github.com/stevegury","followers_url":"https://api.github.com/users/stevegury/followers","following_url":"https://api.github.com/users/stevegury/following{/other_user}","gists_url":"https://api.github.com/users/stevegury/gists{/gist_id}","starred_url":"https://api.github.com/users/stevegury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevegury/subscriptions","organizations_url":"https://api.github.com/users/stevegury/orgs","repos_url":"https://api.github.com/users/stevegury/repos","events_url":"https://api.github.com/users/stevegury/events{/privacy}","received_events_url":"https://api.github.com/users/stevegury/received_events","type":"User","site_admin":false},"body":"You could also add the case of very small messages, i.e. a few bytes.","created_at":"2016-11-17T23:45:21Z","updated_at":"2016-11-17T23:45:21Z","html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195#discussion_r88573061","pull_request_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/88573061"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195#discussion_r88573061"},"pull_request":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195","id":93879738,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195","diff_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/195","number":195,"state":"open","locked":false,"title":"JMH test for larger payloads","user":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"body":"#### Problem\r\n\r\nCurrent JMH tests only benchmark smaller payloads \"hello\". It will be good to know the numbers with larger payloads.\r\n\r\n#### Modifications\r\n\r\n- Refactored `RequestResponsePerf` and extracted a base class that can be used in all benchmarks.\r\n- Added another benchmark class to test different payload sizes.\r\n\r\n#### Result\r\n\r\nMore insight into perf.","created_at":"2016-11-16T00:39:26Z","updated_at":"2016-11-17T23:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d635b58c223cafd8a402716cd67605c93337fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/195/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/d79412e0dd4b92ce7bf2d2e3414126b9e4e2d4e6","head":{"label":"NiteshKant:0.5.x-perf","ref":"0.5.x-perf","sha":"d79412e0dd4b92ce7bf2d2e3414126b9e4e2d4e6","user":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"repo":{"id":39788725,"name":"reactivesocket-java","full_name":"NiteshKant/reactivesocket-java","owner":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NiteshKant/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":true,"url":"https://api.github.com/repos/NiteshKant/reactivesocket-java","forks_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/deployments","created_at":"2015-07-27T17:41:09Z","updated_at":"2016-05-04T18:50:32Z","pushed_at":"2016-11-16T00:35:42Z","git_url":"git://github.com/NiteshKant/reactivesocket-java.git","ssh_url":"git@github.com:NiteshKant/reactivesocket-java.git","clone_url":"https://github.com/NiteshKant/reactivesocket-java.git","svn_url":"https://github.com/NiteshKant/reactivesocket-java","homepage":"reactivesocket.io","size":1620,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"0.2.x"}},"base":{"label":"ReactiveSocket:0.5.x","ref":"0.5.x","sha":"f87d5088fcab89264b217a46082da2055d96c13d","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":38732107,"name":"reactivesocket-java","full_name":"ReactiveSocket/reactivesocket-java","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/deployments","created_at":"2015-07-08T04:36:42Z","updated_at":"2016-11-01T14:56:07Z","pushed_at":"2016-11-16T00:39:26Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-java.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-java.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-java.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-java","homepage":"reactivesocket.io","size":2120,"stargazers_count":108,"watchers_count":108,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":20,"forks":24,"open_issues":20,"watchers":108,"default_branch":"0.2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/195"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/195"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/d79412e0dd4b92ce7bf2d2e3414126b9e4e2d4e6"}}}}
{"actor":{"display_login":"stevegury"}}