{"action":"opened","number":9778,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/9778","id":86787003,"html_url":"https://github.com/mrdoob/three.js/pull/9778","diff_url":"https://github.com/mrdoob/three.js/pull/9778.diff","patch_url":"https://github.com/mrdoob/three.js/pull/9778.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/9778","number":9778,"state":"open","locked":false,"title":"VREffect: Check VRLayer configuration on every render","user":{"login":"brianchirls","id":492291,"avatar_url":"https://avatars.githubusercontent.com/u/492291?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchirls","html_url":"https://github.com/brianchirls","followers_url":"https://api.github.com/users/brianchirls/followers","following_url":"https://api.github.com/users/brianchirls/following{/other_user}","gists_url":"https://api.github.com/users/brianchirls/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchirls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchirls/subscriptions","organizations_url":"https://api.github.com/users/brianchirls/orgs","repos_url":"https://api.github.com/users/brianchirls/repos","events_url":"https://api.github.com/users/brianchirls/events{/privacy}","received_events_url":"https://api.github.com/users/brianchirls/received_events","type":"User","site_admin":false},"body":"According to the [webvr spec](https://w3c.github.io/webvr/#interface-window) and now the Chromium implementation, there is no event fired when `requestPresent` is called to change `VRLayer` parameters. So these values need to be checked on every frame.\r\n\r\n> **onvrdisplaypresentchange** A user agent MUST dispatch this event type to indicate that a VRDisplay has begun or ended VR presentation. This event should not fire on subsequent calls to requestPresent() after the VRDisplay has already begun VR presentation.\r\n\r\nAccording to my discussion with @toji, `getLayers` is a cheap call and should not incur a significant performance cost running on every frame, and there is no other way to know when these values have changed.\r\n\r\nNote: I also changed the name of the event handler function, because we're not listening to \"fullscreenchange\" anymore.","created_at":"2016-09-26T17:45:13Z","updated_at":"2016-09-26T17:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9778/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9778/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/9778/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/867fa35ff880e9877e45e4a750109379ae613673","head":{"label":"brianchirls:vrdisplaypresentchange","ref":"vrdisplaypresentchange","sha":"867fa35ff880e9877e45e4a750109379ae613673","user":{"login":"brianchirls","id":492291,"avatar_url":"https://avatars.githubusercontent.com/u/492291?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchirls","html_url":"https://github.com/brianchirls","followers_url":"https://api.github.com/users/brianchirls/followers","following_url":"https://api.github.com/users/brianchirls/following{/other_user}","gists_url":"https://api.github.com/users/brianchirls/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchirls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchirls/subscriptions","organizations_url":"https://api.github.com/users/brianchirls/orgs","repos_url":"https://api.github.com/users/brianchirls/repos","events_url":"https://api.github.com/users/brianchirls/events{/privacy}","received_events_url":"https://api.github.com/users/brianchirls/received_events","type":"User","site_admin":false},"repo":{"id":56066633,"name":"three.js","full_name":"brianchirls/three.js","owner":{"login":"brianchirls","id":492291,"avatar_url":"https://avatars.githubusercontent.com/u/492291?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchirls","html_url":"https://github.com/brianchirls","followers_url":"https://api.github.com/users/brianchirls/followers","following_url":"https://api.github.com/users/brianchirls/following{/other_user}","gists_url":"https://api.github.com/users/brianchirls/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchirls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchirls/subscriptions","organizations_url":"https://api.github.com/users/brianchirls/orgs","repos_url":"https://api.github.com/users/brianchirls/repos","events_url":"https://api.github.com/users/brianchirls/events{/privacy}","received_events_url":"https://api.github.com/users/brianchirls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianchirls/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/brianchirls/three.js","forks_url":"https://api.github.com/repos/brianchirls/three.js/forks","keys_url":"https://api.github.com/repos/brianchirls/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchirls/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchirls/three.js/teams","hooks_url":"https://api.github.com/repos/brianchirls/three.js/hooks","issue_events_url":"https://api.github.com/repos/brianchirls/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/brianchirls/three.js/events","assignees_url":"https://api.github.com/repos/brianchirls/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/brianchirls/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/brianchirls/three.js/tags","blobs_url":"https://api.github.com/repos/brianchirls/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchirls/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchirls/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchirls/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchirls/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchirls/three.js/languages","stargazers_url":"https://api.github.com/repos/brianchirls/three.js/stargazers","contributors_url":"https://api.github.com/repos/brianchirls/three.js/contributors","subscribers_url":"https://api.github.com/repos/brianchirls/three.js/subscribers","subscription_url":"https://api.github.com/repos/brianchirls/three.js/subscription","commits_url":"https://api.github.com/repos/brianchirls/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchirls/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchirls/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchirls/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianchirls/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/brianchirls/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchirls/three.js/merges","archive_url":"https://api.github.com/repos/brianchirls/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchirls/three.js/downloads","issues_url":"https://api.github.com/repos/brianchirls/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/brianchirls/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchirls/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchirls/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchirls/three.js/labels{/name}","releases_url":"https://api.github.com/repos/brianchirls/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/brianchirls/three.js/deployments","created_at":"2016-04-12T13:44:07Z","updated_at":"2016-04-12T13:44:13Z","pushed_at":"2016-09-26T17:40:51Z","git_url":"git://github.com/brianchirls/three.js.git","ssh_url":"git@github.com:brianchirls/three.js.git","clone_url":"https://github.com/brianchirls/three.js.git","svn_url":"https://github.com/brianchirls/three.js","homepage":"http://threejs.org/","size":404707,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"a70b90b4be7a9ec1fe110ac8c4eb837fd6abc5b9","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-09-26T16:32:13Z","pushed_at":"2016-09-26T17:45:13Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":623770,"stargazers_count":27681,"watchers_count":27681,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9433,"mirror_url":null,"open_issues_count":810,"forks":9433,"open_issues":810,"watchers":27681,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9778"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9778"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9778"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9778/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9778/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9778/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/867fa35ff880e9877e45e4a750109379ae613673"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":15,"changed_files":1}}
{"actor":{"display_login":"brianchirls"}}