{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/50968333","id":50968333,"diff_hunk":"@@ -4,7 +4,8 @@\n \n agents.each do |agent|\n   step 'cd into pxp-agent bin folder and check the version' do\n-    on(agent, \"cd #{pxp_agent_dir(agent)} && ./pxp-agent --version\") do |result|\n+    # Vendored Ruby needs to be on path. The \"privatebindir\" property of beaker host can be used for this\n+    on(agent, \"export PATH=\\\"#{agent['privatebindir']}:$PATH\\\" && #{pxp_agent_dir(agent)}/pxp-agent --version\") do |result|","path":"acceptance/tests/pxp_agent_version.rb","position":6,"original_position":6,"commit_id":"af7d2f93f0ca10c10a17c8703ca1a6bfaec193e4","original_commit_id":"af7d2f93f0ca10c10a17c8703ca1a6bfaec193e4","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"body":"The export is required so that our vendored components are on the path. Without it, pxp-agent will exit with errors about libs not being loadable","created_at":"2016-01-27T10:53:50Z","updated_at":"2016-01-27T10:53:50Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/306#discussion_r50968333","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/50968333"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/306#discussion_r50968333"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306","id":57101813,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/306","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/306.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/306.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/306","number":306,"state":"open","locked":false,"title":"(PCP-235) Bring in the remainder of Ethan's acceptance improvements","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"body":"PR 261 had numerous improvements to the acceptance code; but most of the changes were implemented incidentally or became n/a.\r\nThis PR brings in the last couple of improvements that were proposed in PR 261","created_at":"2016-01-25T17:21:46Z","updated_at":"2016-01-27T10:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c680952bb38f77f34cc6b850a5a08e79a8e303d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/306/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/af7d2f93f0ca10c10a17c8703ca1a6bfaec193e4","head":{"label":"james-stocks:PCP-235","ref":"PCP-235","sha":"af7d2f93f0ca10c10a17c8703ca1a6bfaec193e4","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"repo":{"id":43741364,"name":"pxp-agent","full_name":"james-stocks/pxp-agent","owner":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-stocks/pxp-agent","description":"Puppet eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/james-stocks/pxp-agent","forks_url":"https://api.github.com/repos/james-stocks/pxp-agent/forks","keys_url":"https://api.github.com/repos/james-stocks/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-stocks/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-stocks/pxp-agent/teams","hooks_url":"https://api.github.com/repos/james-stocks/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/james-stocks/pxp-agent/events","assignees_url":"https://api.github.com/repos/james-stocks/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/james-stocks/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/tags","blobs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-stocks/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/james-stocks/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/james-stocks/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/james-stocks/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscription","commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-stocks/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-stocks/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/james-stocks/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-stocks/pxp-agent/merges","archive_url":"https://api.github.com/repos/james-stocks/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-stocks/pxp-agent/downloads","issues_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/james-stocks/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/james-stocks/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/james-stocks/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-stocks/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/james-stocks/pxp-agent/releases{/id}","deployments_url":"https://api.github.com/repos/james-stocks/pxp-agent/deployments","created_at":"2015-10-06T09:30:06Z","updated_at":"2015-10-06T09:30:07Z","pushed_at":"2016-01-26T16:39:13Z","git_url":"git://github.com/james-stocks/pxp-agent.git","ssh_url":"git@github.com:james-stocks/pxp-agent.git","clone_url":"https://github.com/james-stocks/pxp-agent.git","svn_url":"https://github.com/james-stocks/pxp-agent","homepage":"","size":8988,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"1b12224ca659301b8de479d56f83a8c8b16f413d","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/deployments","created_at":"2014-08-22T16:25:01Z","updated_at":"2016-01-20T12:23:44Z","pushed_at":"2016-01-27T00:47:04Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":9172,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":4,"forks":17,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/306"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/306"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/af7d2f93f0ca10c10a17c8703ca1a6bfaec193e4"}}}}