{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/client/issues/182","repository_url":"https://api.github.com/repos/hypothesis/client","labels_url":"https://api.github.com/repos/hypothesis/client/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/client/issues/182/comments","events_url":"https://api.github.com/repos/hypothesis/client/issues/182/events","html_url":"https://github.com/hypothesis/client/pull/182","id":196976588,"number":182,"title":"Show annotations in Annotations tab but with quote struck through after anchoring timeout","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"labels":[{"id":400865234,"url":"https://api.github.com/repos/hypothesis/client/labels/WIP","name":"WIP","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-21T16:33:41Z","updated_at":"2016-12-21T16:36:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/client/pulls/182","html_url":"https://github.com/hypothesis/client/pull/182","diff_url":"https://github.com/hypothesis/client/pull/182.diff","patch_url":"https://github.com/hypothesis/client/pull/182.patch"},"body":"**Depends on https://github.com/hypothesis/client/pull/181**\r\n\r\nThis is a fix for https://github.com/hypothesis/client/issues/176 which resolves the problem where annotations taking a long time to anchor initially appear in the 'Orphans' tab and then migrate across to the Annotations tab.\r\n\r\nInstead of marking annotations as orphans if they fail to anchor within the timeout, we instead set a separate flag on the annotation (`$anchorTimeout`) and then use that in addition to the `$orphan` flag to decide a) which tab the annotation should appear in and b) how to display it.\r\n\r\nIn this PR, annotations that fail to anchor within the initial timeout are displayed in the Annotations tab but with the quote struck through (the same as orphans) to indicate that you can't click them to scroll to them yet. Once annotations do anchor or fail to anchor, they will either remain in the Annotations tab with the quote unstruck or migrate to the Orphans tab.\r\n\r\nFixes https://github.com/hypothesis/client/issues/176"},"comment":{"url":"https://api.github.com/repos/hypothesis/client/issues/comments/268569243","html_url":"https://github.com/hypothesis/client/pull/182#issuecomment-268569243","issue_url":"https://api.github.com/repos/hypothesis/client/issues/182","id":268569243,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T16:36:34Z","updated_at":"2016-12-21T16:36:34Z","body":"## [Current coverage](https://codecov.io/gh/hypothesis/client/pull/182?src=pr) is 74.42% (diff: 95.55%)\n> Merging [#182](https://codecov.io/gh/hypothesis/client/pull/182?src=pr) into [master](https://codecov.io/gh/hypothesis/client/branch/master?src=pr) will increase coverage by **0.21%**\n\n```diff\n@@             master       #182   diff @@\n==========================================\n  Files           107        107          \n  Lines          5523       5526     +3   \n  Methods        1288       1294     +6   \n  Messages          0          0          \n  Branches        906        900     -6   \n==========================================\n+ Hits           4099       4113    +14   \n+ Misses         1424       1413    -11   \n  Partials          0          0          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [445b106...de24744](https://codecov.io/gh/hypothesis/client/compare/445b1061cac11aee1f0847664f6ecbfb91327792...de24744aa8a06fd1952f000303d497e55c57433e?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}