{"action":"created","issue":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1172","repository_url":"https://api.github.com/repos/ligo-cbc/pycbc","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1172/labels{/name}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1172/comments","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1172/events","html_url":"https://github.com/ligo-cbc/pycbc/pull/1172","id":185336159,"number":1172,"title":"Changes to make test cases work","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"assignees":[{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},{"login":"josh-willis","id":9597853,"avatar_url":"https://avatars.githubusercontent.com/u/9597853?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-willis","html_url":"https://github.com/josh-willis","followers_url":"https://api.github.com/users/josh-willis/followers","following_url":"https://api.github.com/users/josh-willis/following{/other_user}","gists_url":"https://api.github.com/users/josh-willis/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-willis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-willis/subscriptions","organizations_url":"https://api.github.com/users/josh-willis/orgs","repos_url":"https://api.github.com/users/josh-willis/repos","events_url":"https://api.github.com/users/josh-willis/events{/privacy}","received_events_url":"https://api.github.com/users/josh-willis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-26T09:07:02Z","updated_at":"2016-10-28T15:09:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1172","html_url":"https://github.com/ligo-cbc/pycbc/pull/1172","diff_url":"https://github.com/ligo-cbc/pycbc/pull/1172.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/1172.patch"},"body":"If I run `python setup.py test` I get a number of failures due to many of the test scripts being out-of-date. This patch allows all of the test scripts to run succesfully in all but two cases:\r\n\r\n * The first is an FFT that *does* run but shouldn't run (apparently). I'll comment on that at the line in question shortly.\r\n * The second is test_lalsim.py. A whole bunch of waveforms fail in a variety of different cases here.  There are a number of different failure modes, and I don't want to track this down for waveforms that I think are not used in production analysis. However, some common issues that I have noticed: \r\n    * The various EOB models are as stable as the test requires when making changes to input parameters at the tolerance level. This is known: The various numerical solvers are sensitive to machine-level precision changes. \r\n     * Various waveforms fail the \"shift masses around slightly\" test because the internal calculation of eta returns 0.25 + machine tolerance. (In many cases this causes segfaults as the error is not handled correctly, either in lalsimulation or within PyCBC). I actually changed the default masses to not be equal mass, and added a new test to check specifically for this.\r\n\r\nMy proposal for lalsim would be to wait until the new waveform interface is pushed and then identify *all* failures, and send them on to developers. For some cases we probably don't want to check waveforms in the automated test scripts, unless specifically told to (by specifying `--approximant`). But for production/reviewed waveforms that cause failures, we should either allow exceptions, or reduce tolerances, for specific cases if a reason is known and understood, or get the waveform fixed.\r\n\r\nNote that we now test both frequency and time-domain waveforms by default. `_INTERP` waveforms are excluded as they fail some of the tests as things like orbital phase and distance are ignored for those waveforms, as these are intended only as filters.\r\n\r\n@ahnitz I assume some of these tests are *not* run currently from Travis. Can these now be enabled, with the exception of test_lalsim? Or how is that handled?"},"comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments/256946625","html_url":"https://github.com/ligo-cbc/pycbc/pull/1172#issuecomment-256946625","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1172","id":256946625,"user":{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars.githubusercontent.com/u/11317236?v=3","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T15:09:37Z","updated_at":"2016-10-28T15:09:37Z","body":"Ian, some of the test cases you fixed are already in the Travis script tools/run_travis.sh, you can just uncomment them. If you want to add missing one, just copy and paste one of the existing cases."}}
{"actor":{"display_login":"titodalcanton"}}