{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/comments/90338466","pull_request_review_id":10859122,"id":90338466,"diff_hunk":"@@ -63,6 +63,7 @@\n         \"socorro.processor.signature_utilities.SignatureRunWatchDog, \"\n         \"socorro.processor.signature_utilities.SignatureIPCChannelError, \"\n         \"socorro.processor.signature_utilities.SignatureIPCMessageName, \"\n+        \"socorro.processor.signature_utilities.SigTrim, \"","path":"socorro/processor/mozilla_processor_2015.py","position":4,"original_position":4,"commit_id":"7bd94468e57b22e7bc3028aaab8b0a0ec34d1845","original_commit_id":"7bd94468e57b22e7bc3028aaab8b0a0ec34d1845","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"I think it makes sense to strip it before truncating so the extra spaces don't affect truncation. Having said that, maybe `SigTrunc` should take the signature, strip it and then truncate it and make sure it's stripped?","created_at":"2016-11-30T22:00:08Z","updated_at":"2016-11-30T22:00:08Z","html_url":"https://github.com/mozilla/socorro/pull/3602#discussion_r90338466","pull_request_url":"https://api.github.com/repos/mozilla/socorro/pulls/3602","_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/comments/90338466"},"html":{"href":"https://github.com/mozilla/socorro/pull/3602#discussion_r90338466"},"pull_request":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/3602"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/3602","id":94944563,"html_url":"https://github.com/mozilla/socorro/pull/3602","diff_url":"https://github.com/mozilla/socorro/pull/3602.diff","patch_url":"https://github.com/mozilla/socorro/pull/3602.patch","issue_url":"https://api.github.com/repos/mozilla/socorro/issues/3602","number":3602,"state":"open","locked":false,"title":"Fixes bug 1313283 - Strip signatures from leading or trailing white s…","user":{"login":"adngdb","id":328790,"avatar_url":"https://avatars.githubusercontent.com/u/328790?v=3","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"body":"…paces.\r\n\r\n@willkg What do you think about this?\r\n\r\nFun fact: we can easily use SuperSearch to find all signatures starting or ending with a white space, e.g. https://crash-stats.mozilla.com/api/SuperSearch/?signature=%24%20&_results_number=0","created_at":"2016-11-23T04:43:32Z","updated_at":"2016-11-30T22:00:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53db3f522345b52bd4e39b7fbfe61bdaa01275fe","assignee":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"assignees":[{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/socorro/pulls/3602/commits","review_comments_url":"https://api.github.com/repos/mozilla/socorro/pulls/3602/comments","review_comment_url":"https://api.github.com/repos/mozilla/socorro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/socorro/issues/3602/comments","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/7bd94468e57b22e7bc3028aaab8b0a0ec34d1845","head":{"label":"adngdb:1313283-white-space-bug","ref":"1313283-white-space-bug","sha":"7bd94468e57b22e7bc3028aaab8b0a0ec34d1845","user":{"login":"adngdb","id":328790,"avatar_url":"https://avatars.githubusercontent.com/u/328790?v=3","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"repo":{"id":2353068,"name":"socorro","full_name":"adngdb/socorro","owner":{"login":"adngdb","id":328790,"avatar_url":"https://avatars.githubusercontent.com/u/328790?v=3","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adngdb/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":true,"url":"https://api.github.com/repos/adngdb/socorro","forks_url":"https://api.github.com/repos/adngdb/socorro/forks","keys_url":"https://api.github.com/repos/adngdb/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adngdb/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adngdb/socorro/teams","hooks_url":"https://api.github.com/repos/adngdb/socorro/hooks","issue_events_url":"https://api.github.com/repos/adngdb/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/adngdb/socorro/events","assignees_url":"https://api.github.com/repos/adngdb/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/adngdb/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/adngdb/socorro/tags","blobs_url":"https://api.github.com/repos/adngdb/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adngdb/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adngdb/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/adngdb/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adngdb/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/adngdb/socorro/languages","stargazers_url":"https://api.github.com/repos/adngdb/socorro/stargazers","contributors_url":"https://api.github.com/repos/adngdb/socorro/contributors","subscribers_url":"https://api.github.com/repos/adngdb/socorro/subscribers","subscription_url":"https://api.github.com/repos/adngdb/socorro/subscription","commits_url":"https://api.github.com/repos/adngdb/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/adngdb/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/adngdb/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/adngdb/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/adngdb/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/adngdb/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adngdb/socorro/merges","archive_url":"https://api.github.com/repos/adngdb/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adngdb/socorro/downloads","issues_url":"https://api.github.com/repos/adngdb/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/adngdb/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/adngdb/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/adngdb/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adngdb/socorro/labels{/name}","releases_url":"https://api.github.com/repos/adngdb/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/adngdb/socorro/deployments","created_at":"2011-09-09T02:59:03Z","updated_at":"2015-08-07T14:15:18Z","pushed_at":"2016-11-24T00:39:04Z","git_url":"git://github.com/adngdb/socorro.git","ssh_url":"git@github.com:adngdb/socorro.git","clone_url":"https://github.com/adngdb/socorro.git","svn_url":"https://github.com/adngdb/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":169507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ad09dbfc5f6ea3f7df0aa322ad0d142f4b883392","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2263742,"name":"socorro","full_name":"mozilla/socorro","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":false,"url":"https://api.github.com/repos/mozilla/socorro","forks_url":"https://api.github.com/repos/mozilla/socorro/forks","keys_url":"https://api.github.com/repos/mozilla/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/socorro/teams","hooks_url":"https://api.github.com/repos/mozilla/socorro/hooks","issue_events_url":"https://api.github.com/repos/mozilla/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/socorro/events","assignees_url":"https://api.github.com/repos/mozilla/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/socorro/tags","blobs_url":"https://api.github.com/repos/mozilla/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/socorro/languages","stargazers_url":"https://api.github.com/repos/mozilla/socorro/stargazers","contributors_url":"https://api.github.com/repos/mozilla/socorro/contributors","subscribers_url":"https://api.github.com/repos/mozilla/socorro/subscribers","subscription_url":"https://api.github.com/repos/mozilla/socorro/subscription","commits_url":"https://api.github.com/repos/mozilla/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/socorro/merges","archive_url":"https://api.github.com/repos/mozilla/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/socorro/downloads","issues_url":"https://api.github.com/repos/mozilla/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/socorro/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/socorro/deployments","created_at":"2011-08-24T19:21:49Z","updated_at":"2016-11-29T07:58:54Z","pushed_at":"2016-11-30T19:26:39Z","git_url":"git://github.com/mozilla/socorro.git","ssh_url":"git@github.com:mozilla/socorro.git","clone_url":"https://github.com/mozilla/socorro.git","svn_url":"https://github.com/mozilla/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":179060,"stargazers_count":332,"watchers_count":332,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":17,"forks":164,"open_issues":17,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/3602"},"html":{"href":"https://github.com/mozilla/socorro/pull/3602"},"issue":{"href":"https://api.github.com/repos/mozilla/socorro/issues/3602"},"comments":{"href":"https://api.github.com/repos/mozilla/socorro/issues/3602/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/3602/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/3602/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/socorro/statuses/7bd94468e57b22e7bc3028aaab8b0a0ec34d1845"}}}}
{"actor":{"display_login":"willkg"}}