{"action":"created","issue":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/1159","repository_url":"https://api.github.com/repos/pkp/pkp-lib","labels_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1159/labels{/name}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1159/comments","events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1159/events","html_url":"https://github.com/pkp/pkp-lib/issues/1159","id":134302313,"number":1159,"title":"[OMP] Cover thumbnail size generates PHP Warning","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pkp/pkp-lib/labels/Open%20Monograph%20Press","name":"Open Monograph Press","color":"a2c6dc"}],"state":"open","locked":false,"assignee":{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4","html_url":"https://github.com/pkp/pkp-lib/milestones/OMP%201.2","labels_url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4/labels","id":892323,"number":4,"title":"OMP 1.2","description":"OMP 1.2 is a major revision of OMP building on the stable OMP 1.1.1 branch but adding numerous new features and changes, including Javascript library upgrades, a move to Composer for dependency management, and more.","creator":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":107,"state":"open","created_at":"2014-12-04T23:55:42Z","updated_at":"2016-02-23T18:33:46Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2016-02-17T14:58:07Z","updated_at":"2016-02-25T16:56:59Z","closed_at":null,"body":"It looks like [the call to CatalogEntryCatalogMetadataForm::_buildSurrogateImage()](https://github.com/pkp/omp/blob/master/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php#L269) is missing [a couple of arguments](https://github.com/pkp/omp/blob/master/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php#L379).\r\n\r\nI took a quick look and probably the arguments can be made optional. But best if someone familiar with the code takes a look.\r\n\r\nHere are the PHP Warnings:\r\n\r\n```\r\n[Wed Feb 17 14:54:06.402254 2016] [:error] [pid 23589] [client 192.168.0.8:56649] PHP Warning:  Missing argument 4 for CatalogEntryCatalogMetadataForm::_buildSurrogateImage(), called in /var/www/html/omp/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php on line 269 and defined in /var/www/html/omp/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php on line 379, referer: http://192.168.0.8/omp/index.php/publicknowledge/workflow/index/5/5\r\n[Wed Feb 17 14:54:06.402303 2016] [:error] [pid 23589] [client 192.168.0.8:56649] PHP Warning:  Missing argument 5 for CatalogEntryCatalogMetadataForm::_buildSurrogateImage(), called in /var/www/html/omp/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php on line 269 and defined in /var/www/html/omp/controllers/tab/catalogEntry/form/CatalogEntryCatalogMetadataForm.inc.php on line 379, referer: http://192.168.0.8/omp/index.php/publicknowledge/workflow/index/5/5\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/188877300","html_url":"https://github.com/pkp/pkp-lib/issues/1159#issuecomment-188877300","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1159","id":188877300,"user":{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T16:56:58Z","updated_at":"2016-02-25T16:56:58Z","body":"Maybe then one more question :-) If one uploads a new cover page, the thumbnail will be replaced, but the old catalog.png stays. Should I then check in the code if there is catalog.png when uploading a cover, then remove it? Or just leave it, although it will in this case be different than the new thumbnail image?"}}