{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/54758278","id":54758278,"diff_hunk":"@@ -0,0 +1,96 @@\n+##\n+# Copyright 2016-2016 Ghent University, Forschungszentrum Juelich\n+#\n+# This file is part of EasyBuild,\n+# originally created by the HPC team of Ghent University (http://ugent.be/hpc/en),\n+# with support of Ghent University (http://ugent.be/hpc),\n+# the Flemish Supercomputer Centre (VSC) (https://vscentrum.be/nl/en),\n+# Flemish Research Foundation (FWO) (http://www.fwo.be/en)\n+# and the Department of Economy, Science and Innovation (EWI) (http://www.ewi-vlaanderen.be/en).\n+#\n+# http://github.com/hpcugent/easybuild\n+#\n+# EasyBuild is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation v2.\n+#\n+# EasyBuild is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with EasyBuild.  If not, see <http://www.gnu.org/licenses/>.\n+##\n+\"\"\"\n+EasyBuild support for building and installing the ParaStationMPI library, implemented as an easyblock\n+\n+@author: Damian Alvarez (Forschungszentrum Juelich)\n+\"\"\"\n+import os\n+from distutils.version import LooseVersion\n+\n+from easybuild.easyblocks.mpich import EB_MPICH\n+from easybuild.tools.systemtools import get_shared_lib_ext\n+\n+\n+class EB_psmpi(EB_MPICH):\n+    \"\"\"\n+    Support for building the ParaStationMPI library.\n+    - some compiler dependent configure options\n+    \"\"\"\n+\n+    def configure_step(self):\n+        \"\"\"\n+        Custom configuration procedure for ParaStationMPI\n+        * unset environment variables that leak into mpi* wrappers, and define $MPICHLIB_* equivalents instead\n+        \"\"\"\n+\n+        # things might go wrong if a previous install dir is present, so let's get rid of it\n+        if not self.cfg['keeppreviousinstall']:\n+            self.log.info(\"Making sure any old installation is removed before we start the build...\")\n+            super(EB_psmpi, self).make_dir(self.installdir, True, dontcreateinstalldir=True)\n+\n+        # MPICH configure script complains when F90 or F90FLAGS are set,\n+        # they should be replaced with FC/FCFLAGS instead.\n+        # Additionally, there are a set of variables (FCFLAGS among them) that should not be set at configure time,\n+        # or they will leak in the mpix wrappers.\n+        # Specific variables to be included in the wrapper exists, but they changed between MPICH 3.1.4 and MPICH 3.2\n+        # and in a typical scenario we probably don't want them.\n+        self.setup_env_vars()\n+\n+        # Bypass the configure_step of EB_MPICH\n+        super(EB_MPICH, self).configure_step()\n+\n+    # make and make install are default\n+\n+    def sanity_check_step(self, custom_paths=None, use_new_libnames=None):\n+        \"\"\"\n+        Custom sanity check for ParaStationMPI\n+        \"\"\"\n+        shlib_ext = get_shared_lib_ext()\n+        if custom_paths is None:\n+            custom_paths = {}\n+\n+        if use_new_libnames is None:\n+            # cfr. http://git.mpich.org/mpich.git/blob_plain/v3.1.1:/CHANGES\n+            # MPICH changed its library names sinceversion 3.1.1\n+            use_new_libnames = LooseVersion(self.version) >= LooseVersion('5.1.0-1')\n+\n+        # Starting MPICH 3.1.1, libraries have been renamed\n+        # cf http://git.mpich.org/mpich.git/blob_plain/v3.1.1:/CHANGES\n+        if use_new_libnames:\n+            libnames = ['mpi', 'mpicxx', 'mpifort']\n+        else:\n+            libnames = ['fmpich', 'mpichcxx', 'mpichf90', 'mpich', 'mpl', 'opa']\n+\n+        binaries = ['mpicc', 'mpicxx', 'mpif77', 'mpif90']\n+        bins = [os.path.join('bin', x) for x in binaries]\n+        headers = [os.path.join('include', x) for x in ['mpi.h', 'mpicxx.h', 'mpif.h']]\n+        libs = [os.path.join('lib', 'lib%s.%s' % (l, e)) for l in libnames for e in ['a', shlib_ext]]\n+\n+        custom_paths.setdefault('dirs', []).extend(['bin', 'include', 'lib'])\n+        custom_paths.setdefault('files', []).extend(bins + headers + libs)\n+\n+        # Bypass the sanity_check_step of EB_MPICH","path":"easybuild/easyblocks/p/psmpi.py","position":95,"original_position":95,"commit_id":"d07f3e3083f99976488c392e83cf07577babf86b","original_commit_id":"d07f3e3083f99976488c392e83cf07577babf86b","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"mention *why* you're bypassing\r\n\r\nbut, I think we should allow tweaking the MPICH sanity check rather than reinventing it for 80-90%...","created_at":"2016-03-02T17:27:29Z","updated_at":"2016-03-02T17:27:29Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/852#discussion_r54758278","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/54758278"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/852#discussion_r54758278"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852","id":61435017,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/852","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/852.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/852.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/852","number":852,"state":"open","locked":false,"title":"new psmpi easyblock, and environment variable setup in mpich.py flush…","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"body":"New psmpi easyblock, and environment variable setup in mpich.py flushed out to its own method","created_at":"2016-03-02T17:21:13Z","updated_at":"2016-03-02T17:27:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03f67a4cc9c92e66811c8132ea200e2e0acf7604","assignee":null,"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/24","html_url":"https://github.com/hpcugent/easybuild-easyblocks/milestones/v2.7.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/24/labels","id":1538511,"number":24,"title":"v2.7.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":18,"state":"open","created_at":"2016-01-23T08:57:21Z","updated_at":"2016-03-02T17:22:24Z","due_on":"2016-03-16T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/852/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/d07f3e3083f99976488c392e83cf07577babf86b","head":{"label":"damianam:psmpi_easyblock","ref":"psmpi_easyblock","sha":"d07f3e3083f99976488c392e83cf07577babf86b","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"repo":{"id":46984921,"name":"easybuild-easyblocks","full_name":"damianam/easybuild-easyblocks","owner":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damianam/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/damianam/easybuild-easyblocks","forks_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/deployments","created_at":"2015-11-27T14:40:00Z","updated_at":"2015-11-27T14:40:02Z","pushed_at":"2016-03-02T17:19:44Z","git_url":"git://github.com/damianam/easybuild-easyblocks.git","ssh_url":"git@github.com:damianam/easybuild-easyblocks.git","clone_url":"https://github.com/damianam/easybuild-easyblocks.git","svn_url":"https://github.com/damianam/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":8477,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"7408519ce06e8bec57b117ff39f5f19e4aafff7b","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/deployments","created_at":"2012-10-15T14:31:19Z","updated_at":"2016-02-04T20:37:10Z","pushed_at":"2016-03-02T17:21:13Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":9811,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":125,"forks":91,"open_issues":125,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/852"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/852"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/852/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/852/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/d07f3e3083f99976488c392e83cf07577babf86b"}}}}