{"action":"opened","number":4744,"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744","id":96569780,"html_url":"https://github.com/PowerDNS/pdns/pull/4744","diff_url":"https://github.com/PowerDNS/pdns/pull/4744.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/4744.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4744","number":4744,"state":"open","locked":false,"title":"Handle exceptions raised by `closesocket()`","user":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"body":"### Short description\r\nThis was not very well handled, and could cause the PowerDNS process\r\nto terminate. This is especially nasty when `closesocket()` is called\r\nfrom a destructor, as we could already be dealing with an exception.\r\n\r\n### Checklist\r\n<!-- please indicate if any of these things are done/included with this Pull Request. Not all boxes need to be checked for the Pull Request to be accepted -->\r\nI have:\r\n- [x] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [x] compiled and tested this code\r\n\r\n\r\n","created_at":"2016-12-05T17:09:20Z","updated_at":"2016-12-05T17:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4744/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/a7b68ae7e414ec9f3184df70ac8008f8a310ae60","head":{"label":"rgacogne:handle-closesocket-excp","ref":"handle-closesocket-excp","sha":"a7b68ae7e414ec9f3184df70ac8008f8a310ae60","user":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"repo":{"id":45459221,"name":"pdns","full_name":"rgacogne/pdns","owner":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgacogne/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/rgacogne/pdns","forks_url":"https://api.github.com/repos/rgacogne/pdns/forks","keys_url":"https://api.github.com/repos/rgacogne/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgacogne/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgacogne/pdns/teams","hooks_url":"https://api.github.com/repos/rgacogne/pdns/hooks","issue_events_url":"https://api.github.com/repos/rgacogne/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/rgacogne/pdns/events","assignees_url":"https://api.github.com/repos/rgacogne/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/rgacogne/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/rgacogne/pdns/tags","blobs_url":"https://api.github.com/repos/rgacogne/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgacogne/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgacogne/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgacogne/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgacogne/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/rgacogne/pdns/languages","stargazers_url":"https://api.github.com/repos/rgacogne/pdns/stargazers","contributors_url":"https://api.github.com/repos/rgacogne/pdns/contributors","subscribers_url":"https://api.github.com/repos/rgacogne/pdns/subscribers","subscription_url":"https://api.github.com/repos/rgacogne/pdns/subscription","commits_url":"https://api.github.com/repos/rgacogne/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgacogne/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgacogne/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgacogne/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgacogne/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/rgacogne/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgacogne/pdns/merges","archive_url":"https://api.github.com/repos/rgacogne/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgacogne/pdns/downloads","issues_url":"https://api.github.com/repos/rgacogne/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/rgacogne/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/rgacogne/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/rgacogne/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgacogne/pdns/labels{/name}","releases_url":"https://api.github.com/repos/rgacogne/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/rgacogne/pdns/deployments","created_at":"2015-11-03T10:29:53Z","updated_at":"2016-01-11T08:35:42Z","pushed_at":"2016-12-05T17:03:47Z","git_url":"git://github.com/rgacogne/pdns.git","ssh_url":"git@github.com:rgacogne/pdns.git","clone_url":"https://github.com/rgacogne/pdns.git","svn_url":"https://github.com/rgacogne/pdns","homepage":null,"size":32960,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"85ceefacf2754d34956b5ea09c83b2e1ccf22b3d","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2016-12-01T11:24:26Z","pushed_at":"2016-12-05T17:09:20Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":43034,"stargazers_count":729,"watchers_count":729,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":533,"forks":292,"open_issues":533,"watchers":729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4744"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4744"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4744/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4744/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/a7b68ae7e414ec9f3184df70ac8008f8a310ae60"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":124,"deletions":24,"changed_files":7}}
{"actor":{"display_login":"rgacogne"}}