{"action":"created","issue":{"url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/1660","repository_url":"https://api.github.com/repos/ryancramerdesign/ProcessWire","labels_url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/1660/labels{/name}","comments_url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/1660/comments","events_url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/1660/events","html_url":"https://github.com/ryancramerdesign/ProcessWire/issues/1660","id":131048839,"number":1660,"title":"The new linkAbstractor - issues","user":{"login":"tbba","id":652879,"avatar_url":"https://avatars.githubusercontent.com/u/652879?v=3","gravatar_id":"","url":"https://api.github.com/users/tbba","html_url":"https://github.com/tbba","followers_url":"https://api.github.com/users/tbba/followers","following_url":"https://api.github.com/users/tbba/following{/other_user}","gists_url":"https://api.github.com/users/tbba/gists{/gist_id}","starred_url":"https://api.github.com/users/tbba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbba/subscriptions","organizations_url":"https://api.github.com/users/tbba/orgs","repos_url":"https://api.github.com/users/tbba/repos","events_url":"https://api.github.com/users/tbba/events{/privacy}","received_events_url":"https://api.github.com/users/tbba/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/labels/Need%20More%20Information","name":"Need More Information","color":"fef2c0"},{"url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/labels/Potential%20Bug","name":"Potential Bug","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-03T14:55:10Z","updated_at":"2016-02-04T15:18:24Z","closed_at":null,"body":"This code is now falsifying correct links.\r\n\r\nMy structure:\r\n/de/page1/\r\n/de/page2/\r\n/de/page2/subpage/\r\n\r\n/en/page1/\r\n/en/page2/\r\n(/en/page2/subpage/ not existing: no subpage for En, EN was not checked)\r\n\r\n1. I set a link in /en/page1/  \r\nto /de/page2/subpage/\r\nAfter saving I see this /en/page2/subpage/  (/de/ -> /en/)\r\n\r\n2. I set a link in /de/page1/  \r\nto /de/page2/subpage/\r\nAfter saving I see this /page2/subpage/ (/de/ removed)\r\n\r\nIs this repeatable? (Safari)\r\n[UPDATE - tested with Firefox]\r\n"},"comment":{"url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/comments/179895314","html_url":"https://github.com/ryancramerdesign/ProcessWire/issues/1660#issuecomment-179895314","issue_url":"https://api.github.com/repos/ryancramerdesign/ProcessWire/issues/1660","id":179895314,"user":{"login":"tbba","id":652879,"avatar_url":"https://avatars.githubusercontent.com/u/652879?v=3","gravatar_id":"","url":"https://api.github.com/users/tbba","html_url":"https://github.com/tbba","followers_url":"https://api.github.com/users/tbba/followers","following_url":"https://api.github.com/users/tbba/following{/other_user}","gists_url":"https://api.github.com/users/tbba/gists{/gist_id}","starred_url":"https://api.github.com/users/tbba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbba/subscriptions","organizations_url":"https://api.github.com/users/tbba/orgs","repos_url":"https://api.github.com/users/tbba/repos","events_url":"https://api.github.com/users/tbba/events{/privacy}","received_events_url":"https://api.github.com/users/tbba/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T15:18:24Z","updated_at":"2016-02-04T15:18:24Z","body":"regarding TEST 2\r\nSetting an internal cross-language link is strongly recommended by GOOGLE to avoid, so I think it is correct what PW does. I wanted to test this anyway to see what happens. :-)\r\nIn such rare cases, having to set a link manually would be perfectly ok. And it is great that QA now can handle that.\r\n\r\nI also think that PW is doing right by allowing to set links that would lead to 404 errors. (I would be very annoyed if I just temporarily unpublish a page and all internal links to it would be erased automatically.)\r\n\r\nWhat I was wondering is that pages that have a language not checked are offered by the link tool in that language. It's so easy to make mistakes that way. Especially if you are the editor and not the developer.\r\nAlso, since content for language 2 can be a copy (fallback) of the default language1 (or a copy paste oversight) wrong links can easily sneak in language2. Correct? \r\nSince QA is so intelligent right now, how about some warning about a language cross-linking or a linking to a non existing language of that target page?\r\n(The usual 404 checker software is great in detecting broken links. But, at least my tools cannot detect cross-language linking to valid targets as errors.)"}}