{"action":"created","issue":{"url":"https://api.github.com/repos/nsh87/receptormarker/issues/63","repository_url":"https://api.github.com/repos/nsh87/receptormarker","labels_url":"https://api.github.com/repos/nsh87/receptormarker/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/nsh87/receptormarker/issues/63/comments","events_url":"https://api.github.com/repos/nsh87/receptormarker/issues/63/events","html_url":"https://github.com/nsh87/receptormarker/pull/63","id":140785773,"number":63,"title":"Create multiClust class and implement related fixes","user":{"login":"nsh87","id":4327717,"avatar_url":"https://avatars.githubusercontent.com/u/4327717?v=3","gravatar_id":"","url":"https://api.github.com/users/nsh87","html_url":"https://github.com/nsh87","followers_url":"https://api.github.com/users/nsh87/followers","following_url":"https://api.github.com/users/nsh87/following{/other_user}","gists_url":"https://api.github.com/users/nsh87/gists{/gist_id}","starred_url":"https://api.github.com/users/nsh87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsh87/subscriptions","organizations_url":"https://api.github.com/users/nsh87/orgs","repos_url":"https://api.github.com/users/nsh87/repos","events_url":"https://api.github.com/users/nsh87/events{/privacy}","received_events_url":"https://api.github.com/users/nsh87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-14T20:17:27Z","updated_at":"2016-03-14T22:54:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nsh87/receptormarker/pulls/63","html_url":"https://github.com/nsh87/receptormarker/pull/63","diff_url":"https://github.com/nsh87/receptormarker/pull/63.diff","patch_url":"https://github.com/nsh87/receptormarker/pull/63.patch"},"body":"The major commit here is https://github.com/nsh87/receptormarker/commit/3d58920d11f0dfac3250ab148e5e80986492cda1. It creates an actual `multiClust` class and moves the documentation around. The rest of the commits are around:\r\n\r\n* Fixing function calls to use the new `multiClust` class\r\n* Updating/fixing unit tests for the same\r\n* Modifying unit tests either for more coverage or to reduce redundancy\r\n\r\n@catterbu: If you can take a look at all of these that would be great. This PR is going to fail. I've split up most of the unit tests to be more atomic so it's more obvious what is failing. I think you'll have to address those failing ones yourself - I've done most of what I feel comfortable doing."},"comment":{"url":"https://api.github.com/repos/nsh87/receptormarker/issues/comments/196555293","html_url":"https://github.com/nsh87/receptormarker/pull/63#issuecomment-196555293","issue_url":"https://api.github.com/repos/nsh87/receptormarker/issues/63","id":196555293,"user":{"login":"catterbu","id":8098803,"avatar_url":"https://avatars.githubusercontent.com/u/8098803?v=3","gravatar_id":"","url":"https://api.github.com/users/catterbu","html_url":"https://github.com/catterbu","followers_url":"https://api.github.com/users/catterbu/followers","following_url":"https://api.github.com/users/catterbu/following{/other_user}","gists_url":"https://api.github.com/users/catterbu/gists{/gist_id}","starred_url":"https://api.github.com/users/catterbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catterbu/subscriptions","organizations_url":"https://api.github.com/users/catterbu/orgs","repos_url":"https://api.github.com/users/catterbu/repos","events_url":"https://api.github.com/users/catterbu/events{/privacy}","received_events_url":"https://api.github.com/users/catterbu/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T22:54:23Z","updated_at":"2016-03-14T22:54:23Z","body":"@nsh87 will do this evening. Just got back from a meeting with Bill. My guess was absolutely correct. You set up everything perfectly, now he is jut waiting on the money and data I say \"go.\"\n\n> On Mar 14, 2016, at 3:44 PM, Nikhil Haas <notifications@github.com> wrote:\n> \n> @catterbu: never mind, it's not a stupid typo or anything. You're going to have to check out these failed tests to see what's going on:\n> \n> 1. Error: the 'clust_model' slot in the pre-generated multiClust validates -----\n> argument \"FUN\" is missing, with no default\n> 1: withCallingHandlers(eval(code, new_test_environment), error = capture_calls, message = function(c) invokeRestart(\"muffleMessage\"))\n> 2: eval(code, new_test_environment)\n> 3: eval(expr, envir, enclos)\n> 4: lapply(expect_is(f_clust@clust_model[[1]], \"kmeans\")) at test_multi_clustering.R:47\n> 5: match.fun(FUN)\n> \n> 2. Error: multi_clust() correctly handles contrived boolean data ---------------\n> more cluster centers than distinct data points.\n> 1: withCallingHandlers(eval(code, new_test_environment), error = capture_calls, message = function(c) invokeRestart(\"muffleMessage\"))\n> 2: eval(code, new_test_environment)\n> 3: eval(expr, envir, enclos)\n> 4: multi_clust(contrived_bool, krange = 2:7) at test_multi_clustering.R:81\n> 5: stats::kmeans(d, k, iter.max = iter.max, nstart = runs, ...) at /home/travis/build/nsh87/receptormarker/R/multi_clustering.R:88\n> 6: stop(\"more cluster centers than distinct data points.\")\n> \n> 3. Failure (at test_multi_clustering.R#92): multi_clust() correctly handles non-boolean iris data \n> k_best is not identical to 3. Differences: \n> Mean relative difference: 0.3333333\n> \n> *** grep results from unit tests ********************\n> \n> 27:3. Failure (at test_multi_clustering.R#92): multi_clust() correctly handles non-boolean iris data \n> 10:1. Error: the 'clust_model' slot in the pre-generated multiClust validates -----\n> 18:2. Error: multi_clust() correctly handles contrived boolean data ---------------\n> \n> ERROR, WARNING, or Failure found in unit tests. See grep results above.\n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}