{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/54201153","id":54201153,"diff_hunk":"@@ -0,0 +1,7 @@\n+kind: \"Secret\"\n+apiVersion: \"v1\"\n+metadata:\n+  name: \"buildkite-agent-ssh-key-secret\"\n+data:\n+  id-rsa: \"???\"","path":"buildkite-agent/manifests/buildkite-agent-secrets.yaml","position":6,"original_position":6,"commit_id":"dc7750f2bdd29fc7077aa87245510ebc9a137138","original_commit_id":"dc7750f2bdd29fc7077aa87245510ebc9a137138","user":{"login":"toolmantim","id":153,"avatar_url":"https://avatars.githubusercontent.com/u/153?v=3","gravatar_id":"","url":"https://api.github.com/users/toolmantim","html_url":"https://github.com/toolmantim","followers_url":"https://api.github.com/users/toolmantim/followers","following_url":"https://api.github.com/users/toolmantim/following{/other_user}","gists_url":"https://api.github.com/users/toolmantim/gists{/gist_id}","starred_url":"https://api.github.com/users/toolmantim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolmantim/subscriptions","organizations_url":"https://api.github.com/users/toolmantim/orgs","repos_url":"https://api.github.com/users/toolmantim/repos","events_url":"https://api.github.com/users/toolmantim/events{/privacy}","received_events_url":"https://api.github.com/users/toolmantim/received_events","type":"User","site_admin":false},"body":"Thanks for the pointer. I found the auto-generated ones, but nothing that reads from a file (such as a key) and inserts into the template.\r\n\r\nI'm thinking the best way is to have a values file (ala https://github.com/helm/helm/blob/master/docs/generate-and-template.md) that have both the agent token, and the agent keys. It probably makes sense to require people base64 their private key before putting it in the values file… because of yaml/toml formatting. Unless there's a way to substitute a file's contents as a \"value\"?","created_at":"2016-02-26T03:23:34Z","updated_at":"2016-02-26T03:23:34Z","html_url":"https://github.com/helm/charts/pull/78#discussion_r54201153","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/54201153"},"html":{"href":"https://github.com/helm/charts/pull/78#discussion_r54201153"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/78","id":60768679,"html_url":"https://github.com/helm/charts/pull/78","diff_url":"https://github.com/helm/charts/pull/78.diff","patch_url":"https://github.com/helm/charts/pull/78.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/78","number":78,"state":"open","locked":false,"title":"Add buildkite-agent","user":{"login":"toolmantim","id":153,"avatar_url":"https://avatars.githubusercontent.com/u/153?v=3","gravatar_id":"","url":"https://api.github.com/users/toolmantim","html_url":"https://github.com/toolmantim","followers_url":"https://api.github.com/users/toolmantim/followers","following_url":"https://api.github.com/users/toolmantim/following{/other_user}","gists_url":"https://api.github.com/users/toolmantim/gists{/gist_id}","starred_url":"https://api.github.com/users/toolmantim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolmantim/subscriptions","organizations_url":"https://api.github.com/users/toolmantim/orgs","repos_url":"https://api.github.com/users/toolmantim/repos","events_url":"https://api.github.com/users/toolmantim/events{/privacy}","received_events_url":"https://api.github.com/users/toolmantim/received_events","type":"User","site_admin":false},"body":"This adds a package for buildkite-agent, with the ability to add a rsa private key for allowing the agent to run builds from private repository sources","created_at":"2016-02-25T23:48:00Z","updated_at":"2016-02-26T03:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ae873b7dbe56e3dd6db43929177a558212a07b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/78/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/78/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/78/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/dc7750f2bdd29fc7077aa87245510ebc9a137138","head":{"label":"buildkite:add-buildkite-agent","ref":"add-buildkite-agent","sha":"dc7750f2bdd29fc7077aa87245510ebc9a137138","user":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"repo":{"id":52565116,"name":"charts","full_name":"buildkite/charts","owner":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars.githubusercontent.com/u/5055988?v=3","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildkite/charts","description":"Chart Repository for Helm - The Kubernetes Package Manager","fork":true,"url":"https://api.github.com/repos/buildkite/charts","forks_url":"https://api.github.com/repos/buildkite/charts/forks","keys_url":"https://api.github.com/repos/buildkite/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildkite/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildkite/charts/teams","hooks_url":"https://api.github.com/repos/buildkite/charts/hooks","issue_events_url":"https://api.github.com/repos/buildkite/charts/issues/events{/number}","events_url":"https://api.github.com/repos/buildkite/charts/events","assignees_url":"https://api.github.com/repos/buildkite/charts/assignees{/user}","branches_url":"https://api.github.com/repos/buildkite/charts/branches{/branch}","tags_url":"https://api.github.com/repos/buildkite/charts/tags","blobs_url":"https://api.github.com/repos/buildkite/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildkite/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildkite/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildkite/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildkite/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/buildkite/charts/languages","stargazers_url":"https://api.github.com/repos/buildkite/charts/stargazers","contributors_url":"https://api.github.com/repos/buildkite/charts/contributors","subscribers_url":"https://api.github.com/repos/buildkite/charts/subscribers","subscription_url":"https://api.github.com/repos/buildkite/charts/subscription","commits_url":"https://api.github.com/repos/buildkite/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildkite/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildkite/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildkite/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildkite/charts/contents/{+path}","compare_url":"https://api.github.com/repos/buildkite/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildkite/charts/merges","archive_url":"https://api.github.com/repos/buildkite/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildkite/charts/downloads","issues_url":"https://api.github.com/repos/buildkite/charts/issues{/number}","pulls_url":"https://api.github.com/repos/buildkite/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/buildkite/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/buildkite/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildkite/charts/labels{/name}","releases_url":"https://api.github.com/repos/buildkite/charts/releases{/id}","deployments_url":"https://api.github.com/repos/buildkite/charts/deployments","created_at":"2016-02-25T23:45:59Z","updated_at":"2016-02-25T23:45:59Z","pushed_at":"2016-02-25T23:46:23Z","git_url":"git://github.com/buildkite/charts.git","ssh_url":"git@github.com:buildkite/charts.git","clone_url":"https://github.com/buildkite/charts.git","svn_url":"https://github.com/buildkite/charts","homepage":"","size":79,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"8edc8bc1fb97d950f701aaefc84c10bbd6edeef4","user":{"login":"helm","id":15859888,"avatar_url":"https://avatars.githubusercontent.com/u/15859888?v=3","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":44991456,"name":"charts","full_name":"helm/charts","owner":{"login":"helm","id":15859888,"avatar_url":"https://avatars.githubusercontent.com/u/15859888?v=3","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helm/charts","description":"Chart Repository for Helm - The Kubernetes Package Manager","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-10-26T19:14:54Z","updated_at":"2016-02-25T23:03:09Z","pushed_at":"2016-02-25T23:48:01Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":96,"stargazers_count":67,"watchers_count":67,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":9,"forks":32,"open_issues":9,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/78"},"html":{"href":"https://github.com/helm/charts/pull/78"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/78"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/dc7750f2bdd29fc7077aa87245510ebc9a137138"}}}}