{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/comments/82547784","pull_request_review_id":3447906,"id":82547784,"diff_hunk":"@@ -10,7 +10,8 @@\n     \"test-wd\": \"mochify --wd test/client/**/*.spec.js\",\n     \"test-cover\": \"mochify --cover test/client/**/*.spec.js\",\n     \"test\": \"npm run phantom && npm run wd && npm run cover\",\n-    \"test-server\": \"nodemon --watch test/server/**/*.js --watch sync-server.js --watch lib/sync-server.js test/server/test-server.js | bunyan\"\n+    \"test-server\": \"nodemon --watch test/server/**/*.js --watch sync-server.js --watch lib/sync-server.js test/server/test-server.js | bunyan\",\n+    \"eslint\": \"grunt\"","path":"package.json","position":null,"original_position":6,"commit_id":"babfd4e6ab43c090447513f33bf4962502cae831","original_commit_id":"6e5f63d5e5424f5fc7f345a910d74cef991079b8","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"> I think if we are adding a eslint npm command, it should be grunt eslint instead of the default.\r\n\r\nI was not really sure if we should be adding a separate npm command for eslint or not. With the other RainCatcher modules I've just added grunt to the test npm target/command which I could do in this case as well. I've updated this PR with two commits and perhaps we can have a quick chat later today to clear this up? ","created_at":"2016-10-10T06:19:58Z","updated_at":"2016-10-10T06:19:58Z","html_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6#discussion_r82547784","pull_request_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/comments/82547784"},"html":{"href":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6#discussion_r82547784"},"pull_request":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6","id":88422152,"html_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6","diff_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6.diff","patch_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6.patch","issue_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/6","number":6,"state":"open","locked":false,"title":"add Grunt and ESLint support","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"Motivation:\r\nIntroduce ESLint to this project and in the process make the build\r\nprocess of our modules consistent we want to introduce\r\nGrunt.\r\n\r\nModifications:\r\nAdded Grunt.js and the required dev dependencies.\r\nAdded grunt to be run by Travis (CI).\r\n\r\nResult:\r\nRunning grunt will run eslint\r\n\r\nJIRA:\r\nhttps://issues.jboss.org/browse/RAINCATCH-167","created_at":"2016-10-07T11:28:31Z","updated_at":"2016-10-10T06:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7268bd13dc14fd620c0881f2c2b5d15ae71a903b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6/commits","review_comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6/comments","review_comment_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/6/comments","statuses_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/statuses/babfd4e6ab43c090447513f33bf4962502cae831","head":{"label":"danbev:RAINCATCH-167-add-grunt-and-eslint","ref":"RAINCATCH-167-add-grunt-and-eslint","sha":"babfd4e6ab43c090447513f33bf4962502cae831","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":70238960,"name":"raincatcher-sync","full_name":"danbev/raincatcher-sync","owner":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbev/raincatcher-sync","description":null,"fork":true,"url":"https://api.github.com/repos/danbev/raincatcher-sync","forks_url":"https://api.github.com/repos/danbev/raincatcher-sync/forks","keys_url":"https://api.github.com/repos/danbev/raincatcher-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/raincatcher-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/raincatcher-sync/teams","hooks_url":"https://api.github.com/repos/danbev/raincatcher-sync/hooks","issue_events_url":"https://api.github.com/repos/danbev/raincatcher-sync/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/raincatcher-sync/events","assignees_url":"https://api.github.com/repos/danbev/raincatcher-sync/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/raincatcher-sync/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/raincatcher-sync/tags","blobs_url":"https://api.github.com/repos/danbev/raincatcher-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/raincatcher-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/raincatcher-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/raincatcher-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/raincatcher-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/raincatcher-sync/languages","stargazers_url":"https://api.github.com/repos/danbev/raincatcher-sync/stargazers","contributors_url":"https://api.github.com/repos/danbev/raincatcher-sync/contributors","subscribers_url":"https://api.github.com/repos/danbev/raincatcher-sync/subscribers","subscription_url":"https://api.github.com/repos/danbev/raincatcher-sync/subscription","commits_url":"https://api.github.com/repos/danbev/raincatcher-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/raincatcher-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/raincatcher-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/raincatcher-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbev/raincatcher-sync/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/raincatcher-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/raincatcher-sync/merges","archive_url":"https://api.github.com/repos/danbev/raincatcher-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/raincatcher-sync/downloads","issues_url":"https://api.github.com/repos/danbev/raincatcher-sync/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/raincatcher-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/raincatcher-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/raincatcher-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/raincatcher-sync/labels{/name}","releases_url":"https://api.github.com/repos/danbev/raincatcher-sync/releases{/id}","deployments_url":"https://api.github.com/repos/danbev/raincatcher-sync/deployments","created_at":"2016-10-07T11:03:28Z","updated_at":"2016-10-07T11:03:29Z","pushed_at":"2016-10-10T06:19:20Z","git_url":"git://github.com/danbev/raincatcher-sync.git","ssh_url":"git@github.com:danbev/raincatcher-sync.git","clone_url":"https://github.com/danbev/raincatcher-sync.git","svn_url":"https://github.com/danbev/raincatcher-sync","homepage":null,"size":302,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry-raincatcher:master","ref":"master","sha":"be82d8b58600cb709be47accbca9187c4dccee43","user":{"login":"feedhenry-raincatcher","id":19932793,"avatar_url":"https://avatars.githubusercontent.com/u/19932793?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry-raincatcher","html_url":"https://github.com/feedhenry-raincatcher","followers_url":"https://api.github.com/users/feedhenry-raincatcher/followers","following_url":"https://api.github.com/users/feedhenry-raincatcher/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry-raincatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry-raincatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry-raincatcher/subscriptions","organizations_url":"https://api.github.com/users/feedhenry-raincatcher/orgs","repos_url":"https://api.github.com/users/feedhenry-raincatcher/repos","events_url":"https://api.github.com/users/feedhenry-raincatcher/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry-raincatcher/received_events","type":"Organization","site_admin":false},"repo":{"id":44386144,"name":"raincatcher-sync","full_name":"feedhenry-raincatcher/raincatcher-sync","owner":{"login":"feedhenry-raincatcher","id":19932793,"avatar_url":"https://avatars.githubusercontent.com/u/19932793?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry-raincatcher","html_url":"https://github.com/feedhenry-raincatcher","followers_url":"https://api.github.com/users/feedhenry-raincatcher/followers","following_url":"https://api.github.com/users/feedhenry-raincatcher/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry-raincatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry-raincatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry-raincatcher/subscriptions","organizations_url":"https://api.github.com/users/feedhenry-raincatcher/orgs","repos_url":"https://api.github.com/users/feedhenry-raincatcher/repos","events_url":"https://api.github.com/users/feedhenry-raincatcher/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry-raincatcher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync","description":"","fork":false,"url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync","forks_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/forks","keys_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/teams","hooks_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/hooks","issue_events_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/events","assignees_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/tags","blobs_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/languages","stargazers_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/stargazers","contributors_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/contributors","subscribers_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/subscribers","subscription_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/subscription","commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/merges","archive_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/downloads","issues_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/deployments","created_at":"2015-10-16T13:15:15Z","updated_at":"2016-06-23T15:29:20Z","pushed_at":"2016-10-10T06:19:20Z","git_url":"git://github.com/feedhenry-raincatcher/raincatcher-sync.git","ssh_url":"git@github.com:feedhenry-raincatcher/raincatcher-sync.git","clone_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync.git","svn_url":"https://github.com/feedhenry-raincatcher/raincatcher-sync","homepage":null,"size":297,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6"},"html":{"href":"https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/6"},"issue":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/6"},"comments":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-sync/statuses/babfd4e6ab43c090447513f33bf4962502cae831"}}}}
{"actor":{"display_login":"danbev"}}