{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16405","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16405/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16405/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16405/events","html_url":"https://github.com/apache/spark/pull/16405","id":197586572,"number":16405,"title":"[SPARK-19002][BUILD][PYTHON] Check pep8 against all Python scripts","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2016-12-26T13:10:34Z","updated_at":"2016-12-30T10:52:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16405","html_url":"https://github.com/apache/spark/pull/16405","diff_url":"https://github.com/apache/spark/pull/16405.diff","patch_url":"https://github.com/apache/spark/pull/16405.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\n\r\nThis PR proposes to check pep8 against all other Python scripts and fix the errors as below:\r\n\r\n\r\n```bash\r\n./dev/create-release/generate-contributors.py\r\n./dev/create-release/releaseutils.py\r\n./dev/create-release/translate-contributors.py\r\n./dev/lint-python\r\n./python/docs/epytext.py\r\n./examples/src/main/python/mllib/decision_tree_classification_example.py\r\n./examples/src/main/python/mllib/decision_tree_regression_example.py\r\n./examples/src/main/python/mllib/gradient_boosting_classification_example.py\r\n./examples/src/main/python/mllib/gradient_boosting_regression_example.py\r\n./examples/src/main/python/mllib/linear_regression_with_sgd_example.py\r\n./examples/src/main/python/mllib/logistic_regression_with_lbfgs_example.py\r\n./examples/src/main/python/mllib/naive_bayes_example.py\r\n./examples/src/main/python/mllib/random_forest_classification_example.py\r\n./examples/src/main/python/mllib/random_forest_regression_example.py\r\n./examples/src/main/python/mllib/svm_with_sgd_example.py\r\n./examples/src/main/python/streaming/network_wordjoinsentiments.py\r\n./sql/hive/src/test/resources/data/scripts/cat.py\r\n./sql/hive/src/test/resources/data/scripts/cat_error.py\r\n./sql/hive/src/test/resources/data/scripts/doubleescapedtab.py\r\n./sql/hive/src/test/resources/data/scripts/dumpdata_script.py\r\n./sql/hive/src/test/resources/data/scripts/escapedcarriagereturn.py\r\n./sql/hive/src/test/resources/data/scripts/escapednewline.py\r\n./sql/hive/src/test/resources/data/scripts/escapedtab.py\r\n./sql/hive/src/test/resources/data/scripts/input20_script.py\r\n./sql/hive/src/test/resources/data/scripts/newline.py\r\n```\r\n\r\n## How was this patch tested?\r\n\r\n\r\n- `./python/docs/epytext.py` \r\n\r\n  ```bash\r\n  cd ./python/docs $$ make html\r\n  ```\r\n\r\n- pep8 check (Python 2.7 / Python 3.3.6)\r\n\r\n  ```\r\n  ./dev/lint-python\r\n  ```\r\n\r\n- `./dev/merge_spark_pr.py` (Python 2.7 only / Python 3.3.6 not working)\r\n\r\n  ```bash\r\n  python -m doctest -v ./dev/merge_spark_pr.py\r\n  ```\r\n\r\n\r\n- `./dev/create-release/releaseutils.py` `./dev/create-release/generate-contributors.py` `./dev/create-release/translate-contributors.py` (Python 2.7 only / Python 3.3.6 not working)\r\n\r\n  ```bash\r\n  python generate-contributors.py\r\n  python translate-contributors.py\r\n  ```\r\n\r\n\r\n- Examples (Python 2.7 / Python 3.3.6)\r\n\r\n  ```bash\r\n  ./bin/spark-submit examples/src/main/python/mllib/decision_tree_classification_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/decision_tree_regression_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/gradient_boosting_classification_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/gradient_boosting_regression_example.p\r\n  ./bin/spark-submit examples/src/main/python/mllib/random_forest_classification_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/random_forest_regression_example.py\r\n  ```\r\n\r\n- Examples (Python 2.7 only / Python 3.3.6 not working)\r\n  ```\r\n  ./bin/spark-submit examples/src/main/python/mllib/linear_regression_with_sgd_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/logistic_regression_with_lbfgs_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/naive_bayes_example.py\r\n  ./bin/spark-submit examples/src/main/python/mllib/svm_with_sgd_example.py\r\n  ```\r\n\r\n- `sql/hive/src/test/resources/data/scripts/*.py` (Python 2.7 / Python 3.3.6 within suggested changes)\r\n\r\n  Manually tested only changed ones.\r\n\r\n\r\n- `./dev/github_jira_sync.py` (Python 2.7 only / Python 3.3.6 not working)\r\n\r\n  Manually tested this after disabling actually adding comments and links.\r\n\r\nAnd also via Jenkins tests."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/269758038","html_url":"https://github.com/apache/spark/pull/16405#issuecomment-269758038","issue_url":"https://api.github.com/repos/apache/spark/issues/16405","id":269758038,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T10:52:50Z","updated_at":"2016-12-30T10:52:50Z","body":"Merged build finished. Test PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}