{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/407","repository_url":"https://api.github.com/repos/openshift/vagrant-openshift","labels_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/407/labels{/name}","comments_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/407/comments","events_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/407/events","html_url":"https://github.com/openshift/vagrant-openshift/issues/407","id":137875642,"number":407,"title":"test-origin-image: merge PR with master?","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-02T13:38:03Z","updated_at":"2016-03-02T14:00:34Z","closed_at":null,"body":"I noticed that in [`lib/vagrant-openshift/command/test_origin_image.rb`](https://github.com/openshift/vagrant-openshift/blob/abbcc3ba653b11690ed200262c7e000dd7bc6351/lib/vagrant-openshift/command/test_origin_image.rb#L120-L140) we just checkout a PR and run tests without attempting to merge it with master:\r\n\r\n```bash\r\n# Fetch refs from Github pull requests\r\ngit fetch --quiet --tags --progress #{source} +refs/pull/*:refs/remotes/origin/pr/*\r\n\r\n# switch to the desired ref\r\ngit checkout #{ref}\r\n\r\n# ...\r\n\r\nmake test TARGET=rhel7\r\n# ...\r\n```\r\n\r\nI think we should be running tests against the result of merging the PR with master, so that we don't rely solely on the state of the tree in the proposed branch.\r\n\r\n@bparees @mfojtik @danmcp thoughts?"},"comment":{"url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/comments/191248208","html_url":"https://github.com/openshift/vagrant-openshift/issues/407#issuecomment-191248208","issue_url":"https://api.github.com/repos/openshift/vagrant-openshift/issues/407","id":191248208,"user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T14:00:34Z","updated_at":"2016-03-02T14:00:34Z","body":"@rhcarvalho @mfojtik https://github.com/openshift/test-pull-requests\r\n"}}