{"action":"created","issue":{"url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/14459","repository_url":"https://api.github.com/repos/jsdelivr/jsdelivr","labels_url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/14459/labels{/name}","comments_url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/14459/comments","events_url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/14459/events","html_url":"https://github.com/jsdelivr/jsdelivr/issues/14459","id":184751854,"number":14459,"title":"non-gzipped/non-deflated responses is trimming trailing newlines.","user":{"login":"jdalton","id":4303,"avatar_url":"https://avatars.githubusercontent.com/u/4303?v=3","gravatar_id":"","url":"https://api.github.com/users/jdalton","html_url":"https://github.com/jdalton","followers_url":"https://api.github.com/users/jdalton/followers","following_url":"https://api.github.com/users/jdalton/following{/other_user}","gists_url":"https://api.github.com/users/jdalton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdalton/subscriptions","organizations_url":"https://api.github.com/users/jdalton/orgs","repos_url":"https://api.github.com/users/jdalton/repos","events_url":"https://api.github.com/users/jdalton/events{/privacy}","received_events_url":"https://api.github.com/users/jdalton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T05:29:27Z","updated_at":"2016-10-24T21:29:02Z","closed_at":null,"body":"While adding [SRI integrity attributes](https://www.srihash.org/) I noticed that the response for \r\n> https://cdn.jsdelivr.net/g/fuse@2.5.0,immutable.js@3.8.1,react@15.3.2(react.min.js+react-dom.min.js)\r\n\r\n was incorrect.\r\n\r\nIt looks like jsdelivr is truncating the last `\\n` for non-gzipped/non-deflated responses.\r\nThe trimming, different responses for non-gzipped and gzipped, will cause SRI checks to fail for non-gzipped client responses.\r\n\r\nRelated to https://github.com/request/request/issues/2434 and https://github.com/mozilla/srihash.org/issues/152."},"comment":{"url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/comments/255871662","html_url":"https://github.com/jsdelivr/jsdelivr/issues/14459#issuecomment-255871662","issue_url":"https://api.github.com/repos/jsdelivr/jsdelivr/issues/14459","id":255871662,"user":{"login":"jimaek","id":1834071,"avatar_url":"https://avatars.githubusercontent.com/u/1834071?v=3","gravatar_id":"","url":"https://api.github.com/users/jimaek","html_url":"https://github.com/jimaek","followers_url":"https://api.github.com/users/jimaek/followers","following_url":"https://api.github.com/users/jimaek/following{/other_user}","gists_url":"https://api.github.com/users/jimaek/gists{/gist_id}","starred_url":"https://api.github.com/users/jimaek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimaek/subscriptions","organizations_url":"https://api.github.com/users/jimaek/orgs","repos_url":"https://api.github.com/users/jimaek/repos","events_url":"https://api.github.com/users/jimaek/events{/privacy}","received_events_url":"https://api.github.com/users/jimaek/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T21:29:02Z","updated_at":"2016-10-24T21:29:02Z","body":"I will take a look but using SRI with combined URLs is really not recommended as these links are highly dynamic"}}
{"actor":{"display_login":"jimaek"}}