{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/12085","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/12085/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/12085/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/12085/events","html_url":"https://github.com/Wikia/app/pull/12085","id":193727344,"number":12085,"title":"SUS | Cleanup code in Search/{Language,Match,Query,Result,Test,Traits}","user":{"login":"hakubo","id":1018759,"avatar_url":"https://avatars.githubusercontent.com/u/1018759?v=3","gravatar_id":"","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},"labels":[{"id":185794802,"url":"https://api.github.com/repos/Wikia/app/labels/Code%20cleanup","name":"Code cleanup","color":"f7c6c7","default":false},{"id":406580186,"url":"https://api.github.com/repos/Wikia/app/labels/sus","name":"sus","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-06T09:51:59Z","updated_at":"2016-12-06T12:43:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/12085","html_url":"https://github.com/Wikia/app/pull/12085","diff_url":"https://github.com/Wikia/app/pull/12085.diff","patch_url":"https://github.com/Wikia/app/pull/12085.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/265140805","html_url":"https://github.com/Wikia/app/pull/12085#issuecomment-265140805","issue_url":"https://api.github.com/repos/Wikia/app/issues/12085","id":265140805,"user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T12:43:07Z","updated_at":"2016-12-06T12:43:07Z","body":"SonarQube analysis reported 24 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 2 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 16 minor\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 6 info\n\nWatch the comments in this conversation to review them.\n\n#### 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [Article.php#L74](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Match/Article.php#L74): Immediately return this expression instead of assigning it to the temporary variable \"$text\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1488)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L34](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L34): Define a constant instead of duplicating this literal \"Wikia\\Search\\MediaWikiService\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L35](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L35): Define a constant instead of duplicating this literal \"service\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L64](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L64): Define a constant instead of duplicating this literal \"fixSnippeting\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L64](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L64): Define a constant instead of duplicating this literal \"Wikia\\Search\\Result\" 8 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L295](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L295): Define a constant instead of duplicating this literal \"Wikia\\Search\\Result::fixSnippeting should remove string-final ellipses.\" 4 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L548](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L548): Define a constant instead of duplicating this literal \"word1 word2 word3 word4\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [ResultTest.php#L550](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Test/ResultTest.php#L550): Define a constant instead of duplicating this literal \"word1 word2\" 4 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n1. ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) [ResultHelper.php#L43](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Result/ResultHelper.php#L43): Complete the task associated to this \"TODO\" comment. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1135)\n1. ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) [ResultHelper.php#L43](https://github.com/Wikia/app/blob/9242f57bd0a47b4ccf1956cc656003430a2f6452/extensions/wikia/Search/classes/Result/ResultHelper.php#L43): Move this trailing comment on the previous empty line. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS139)\n"}}
{"actor":{"display_login":"WikiaTech"}}