{"action":"created","issue":{"url":"https://api.github.com/repos/01org/ciao/issues/772","repository_url":"https://api.github.com/repos/01org/ciao","labels_url":"https://api.github.com/repos/01org/ciao/issues/772/labels{/name}","comments_url":"https://api.github.com/repos/01org/ciao/issues/772/comments","events_url":"https://api.github.com/repos/01org/ciao/issues/772/events","html_url":"https://github.com/01org/ciao/pull/772","id":187419510,"number":772,"title":"ciao-networking: simplify cnci image preparation mount","user":{"login":"tpepper","id":2745300,"avatar_url":"https://avatars.githubusercontent.com/u/2745300?v=3","gravatar_id":"","url":"https://api.github.com/users/tpepper","html_url":"https://github.com/tpepper","followers_url":"https://api.github.com/users/tpepper/followers","following_url":"https://api.github.com/users/tpepper/following{/other_user}","gists_url":"https://api.github.com/users/tpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/tpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpepper/subscriptions","organizations_url":"https://api.github.com/users/tpepper/orgs","repos_url":"https://api.github.com/users/tpepper/repos","events_url":"https://api.github.com/users/tpepper/events{/privacy}","received_events_url":"https://api.github.com/users/tpepper/received_events","type":"User","site_admin":false},"labels":[{"id":387369784,"url":"https://api.github.com/repos/01org/ciao/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-04T19:31:00Z","updated_at":"2016-11-04T19:38:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/772","html_url":"https://github.com/01org/ciao/pull/772","diff_url":"https://github.com/01org/ciao/pull/772.diff","patch_url":"https://github.com/01org/ciao/pull/772.patch"},"body":"We have a race potentially between losetup and partition existance.  This\r\nprobably is what the retry loop managed to kind of work around in the past.\r\nThe udevadm settle was in the wrong location previously.  It needs to come\r\nafter creation and before use.  It would have coincidentally in the past,\r\nIF you were retrying.\r\n\r\nWe can simplify by not looping and rather create, wait, use as a simple\r\nseries of commands.\r\n\r\nIf we find subsequent issues that need more logic in this flow, I suggest\r\nwe remove the losetup and udevadm settle, and instead do \"kpartx -sav\r\n$img\" followed by the mount.  Then also on exit do \"kpartx -sdv $img\".\r\n\r\nSigned-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>"},"comment":{"url":"https://api.github.com/repos/01org/ciao/issues/comments/258528258","html_url":"https://github.com/01org/ciao/pull/772#issuecomment-258528258","issue_url":"https://api.github.com/repos/01org/ciao/issues/772","id":258528258,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T19:38:47Z","updated_at":"2016-11-04T19:38:47Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8673593/badge)](https://coveralls.io/builds/8673593)\n\nCoverage increased (+0.0008%) to 65.847% when pulling **b1c65d246827180df34f273ee90044965e49dd5e on tpepper:cnci_img_prep_race_fix** into **7b087d20eae80de66b12af19376e4d79a2060845 on 01org:master**.\n"}}
{"actor":{"display_login":"coveralls"}}