{"action":"created","issue":{"url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/12","repository_url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush","labels_url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/12/comments","events_url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/12/events","html_url":"https://github.com/ahelal/kitchen-ansiblepush/issues/12","id":133879063,"number":12,"title":"Incompatible with Ansible 2.x","user":{"login":"arielsalvo","id":6566048,"avatar_url":"https://avatars.githubusercontent.com/u/6566048?v=3","gravatar_id":"","url":"https://api.github.com/users/arielsalvo","html_url":"https://github.com/arielsalvo","followers_url":"https://api.github.com/users/arielsalvo/followers","following_url":"https://api.github.com/users/arielsalvo/following{/other_user}","gists_url":"https://api.github.com/users/arielsalvo/gists{/gist_id}","starred_url":"https://api.github.com/users/arielsalvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielsalvo/subscriptions","organizations_url":"https://api.github.com/users/arielsalvo/orgs","repos_url":"https://api.github.com/users/arielsalvo/repos","events_url":"https://api.github.com/users/arielsalvo/events{/privacy}","received_events_url":"https://api.github.com/users/arielsalvo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-16T03:54:54Z","updated_at":"2016-02-19T15:13:35Z","closed_at":null,"body":"Hi,\r\n\r\nI noticed that kitchen-ansiblepush will always state that idempotency tests are passed even when changes take place.\r\nThis is because the API for callback plugins has changed and the current plugin no is longer loaded.\r\n\r\nI managed to get it working in my fork (git@github.com:arielsalvo/kitchen-ansiblepush.git) branch Concurrency which also includes the changes in the pull request I opened earlier.\r\nAlso needs to add \"callback_whitelist = changes\" to the \"[default]\" section of ansible.cfg.\r\n\r\nI didn't open another PR for this because the solution breaks compatibility with Ansible 1.x.\r\n\r\nPlease, let me know if you need any help with this one.\r\n\r\nRegards!\r\n   --Ariel"},"comment":{"url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/comments/186254781","html_url":"https://github.com/ahelal/kitchen-ansiblepush/issues/12#issuecomment-186254781","issue_url":"https://api.github.com/repos/ahelal/kitchen-ansiblepush/issues/12","id":186254781,"user":{"login":"arielsalvo","id":6566048,"avatar_url":"https://avatars.githubusercontent.com/u/6566048?v=3","gravatar_id":"","url":"https://api.github.com/users/arielsalvo","html_url":"https://github.com/arielsalvo","followers_url":"https://api.github.com/users/arielsalvo/followers","following_url":"https://api.github.com/users/arielsalvo/following{/other_user}","gists_url":"https://api.github.com/users/arielsalvo/gists{/gist_id}","starred_url":"https://api.github.com/users/arielsalvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielsalvo/subscriptions","organizations_url":"https://api.github.com/users/arielsalvo/orgs","repos_url":"https://api.github.com/users/arielsalvo/repos","events_url":"https://api.github.com/users/arielsalvo/events{/privacy}","received_events_url":"https://api.github.com/users/arielsalvo/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T15:13:35Z","updated_at":"2016-02-19T15:13:35Z","body":"Well.... I hadn't thought of making it optional but.... how about moving the setting to .kitchen.yml?\r\nI can't say no other callback will be needed in a test run and moving it to .kitchen.yml would provide the same flexibility.\r\n\r\nSay, like this:\r\n```\r\nif ANSIBLE_CALLBACK_WHITELIST in env:\r\n    check if \"changes\" is present and add if necessary\r\nelse if callback_whitelist in kitchen:\r\n    set ANSIBLE_CALLBACK_WHITELIST = callback_whitelist\r\n    check if \"changes\" is present and add if necessary\r\nelse\r\n    set ANSIBLE_CALLBACK_WHITELIST = \"changes\"\r\nend\r\n```\r\nThis would ignore ansible.cfg completely because we could never know from kitchen if a value is set but would still allow setting the whitelist with the same flexibility. If you want to let the user handle it on his own via ansible.cfg, I would remove the catch-all \"else\" clause.\r\n\r\nWhat do you think?"}}