{"action":"closed","number":7789,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789","id":91510754,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7789","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7789.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7789.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7789","number":7789,"state":"closed","locked":false,"title":"[MRG+1] Fix return_norm bug in preprocessing.normalize. Tests added.","user":{"login":"luang008","id":8357079,"avatar_url":"https://avatars.githubusercontent.com/u/8357079?v=3","gravatar_id":"","url":"https://api.github.com/users/luang008","html_url":"https://github.com/luang008","followers_url":"https://api.github.com/users/luang008/followers","following_url":"https://api.github.com/users/luang008/following{/other_user}","gists_url":"https://api.github.com/users/luang008/gists{/gist_id}","starred_url":"https://api.github.com/users/luang008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luang008/subscriptions","organizations_url":"https://api.github.com/users/luang008/orgs","repos_url":"https://api.github.com/users/luang008/repos","events_url":"https://api.github.com/users/luang008/events{/privacy}","received_events_url":"https://api.github.com/users/luang008/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n\r\n<!-- Example: Fixes #1234 -->\r\nFix #7771 \r\n#### What does this implement/fix? Explain your changes.\r\n\r\nInitialize variable **norm** as **NotImplemented** in order to avoid **UnboundLocalError**.\r\n#### Any other comments?\r\n\r\nMaybe we should implement **return_norm** for sparse matrix with norm l1/l2 later.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2016-10-30T04:19:05Z","updated_at":"2016-11-22T22:45:32Z","closed_at":"2016-11-22T22:45:32Z","merged_at":"2016-11-22T22:45:32Z","merge_commit_sha":"c17156106c191c1ca6ea40122539580b1c38e13b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.18.1","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22/labels","id":2046567,"number":22,"title":"0.18.1","description":"Urgent fixes to bugs and web site issues.","creator":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":76,"state":"open","created_at":"2016-10-04T11:55:58Z","updated_at":"2016-11-22T22:45:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7789/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/7e08f53e55d0f56ce204b6a3e670e1e95007fa21","head":{"label":"luang008:normalize-return_norm","ref":"normalize-return_norm","sha":"7e08f53e55d0f56ce204b6a3e670e1e95007fa21","user":{"login":"luang008","id":8357079,"avatar_url":"https://avatars.githubusercontent.com/u/8357079?v=3","gravatar_id":"","url":"https://api.github.com/users/luang008","html_url":"https://github.com/luang008","followers_url":"https://api.github.com/users/luang008/followers","following_url":"https://api.github.com/users/luang008/following{/other_user}","gists_url":"https://api.github.com/users/luang008/gists{/gist_id}","starred_url":"https://api.github.com/users/luang008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luang008/subscriptions","organizations_url":"https://api.github.com/users/luang008/orgs","repos_url":"https://api.github.com/users/luang008/repos","events_url":"https://api.github.com/users/luang008/events{/privacy}","received_events_url":"https://api.github.com/users/luang008/received_events","type":"User","site_admin":false},"repo":{"id":72320729,"name":"scikit-learn","full_name":"luang008/scikit-learn","owner":{"login":"luang008","id":8357079,"avatar_url":"https://avatars.githubusercontent.com/u/8357079?v=3","gravatar_id":"","url":"https://api.github.com/users/luang008","html_url":"https://github.com/luang008","followers_url":"https://api.github.com/users/luang008/followers","following_url":"https://api.github.com/users/luang008/following{/other_user}","gists_url":"https://api.github.com/users/luang008/gists{/gist_id}","starred_url":"https://api.github.com/users/luang008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luang008/subscriptions","organizations_url":"https://api.github.com/users/luang008/orgs","repos_url":"https://api.github.com/users/luang008/repos","events_url":"https://api.github.com/users/luang008/events{/privacy}","received_events_url":"https://api.github.com/users/luang008/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luang008/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/luang008/scikit-learn","forks_url":"https://api.github.com/repos/luang008/scikit-learn/forks","keys_url":"https://api.github.com/repos/luang008/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luang008/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luang008/scikit-learn/teams","hooks_url":"https://api.github.com/repos/luang008/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/luang008/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/luang008/scikit-learn/events","assignees_url":"https://api.github.com/repos/luang008/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/luang008/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/luang008/scikit-learn/tags","blobs_url":"https://api.github.com/repos/luang008/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luang008/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luang008/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/luang008/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luang008/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/luang008/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/luang008/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/luang008/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/luang008/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/luang008/scikit-learn/subscription","commits_url":"https://api.github.com/repos/luang008/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/luang008/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/luang008/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/luang008/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/luang008/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/luang008/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luang008/scikit-learn/merges","archive_url":"https://api.github.com/repos/luang008/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luang008/scikit-learn/downloads","issues_url":"https://api.github.com/repos/luang008/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/luang008/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/luang008/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/luang008/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luang008/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/luang008/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/luang008/scikit-learn/deployments","created_at":"2016-10-30T02:35:05Z","updated_at":"2016-10-30T02:35:15Z","pushed_at":"2016-11-22T21:35:51Z","git_url":"git://github.com/luang008/scikit-learn.git","ssh_url":"git@github.com:luang008/scikit-learn.git","clone_url":"https://github.com/luang008/scikit-learn.git","svn_url":"https://github.com/luang008/scikit-learn","homepage":"http://scikit-learn.org","size":76756,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"10323f5a377f378f3b4d79ec9cd36d27d79bbb31","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-11-22T20:56:45Z","pushed_at":"2016-11-22T22:45:32Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":129352,"stargazers_count":14860,"watchers_count":14860,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8401,"mirror_url":null,"open_issues_count":1128,"forks":8401,"open_issues":1128,"watchers":14860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7789"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7789"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7789/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7789/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/7e08f53e55d0f56ce204b6a3e670e1e95007fa21"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"comments":24,"review_comments":26,"commits":22,"additions":40,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"jnothman"}}