{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/24603","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/24603/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/24603/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/24603/events","html_url":"https://github.com/owncloud/core/pull/24603","id":154498338,"number":24603,"title":"flat federated re-share","user":{"login":"schiesbn","id":1589737,"avatar_url":"https://avatars.githubusercontent.com/u/1589737?v=3","gravatar_id":"","url":"https://api.github.com/users/schiesbn","html_url":"https://github.com/schiesbn","followers_url":"https://api.github.com/users/schiesbn/followers","following_url":"https://api.github.com/users/schiesbn/following{/other_user}","gists_url":"https://api.github.com/users/schiesbn/gists{/gist_id}","starred_url":"https://api.github.com/users/schiesbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schiesbn/subscriptions","organizations_url":"https://api.github.com/users/schiesbn/orgs","repos_url":"https://api.github.com/users/schiesbn/repos","events_url":"https://api.github.com/users/schiesbn/events{/privacy}","received_events_url":"https://api.github.com/users/schiesbn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/feature:federated-cloud-sharing","name":"feature:federated-cloud-sharing","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/62","html_url":"https://github.com/owncloud/core/milestones/9.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/62/labels","id":1322460,"number":62,"title":"9.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":742,"closed_issues":798,"state":"open","created_at":"2015-09-24T16:30:14Z","updated_at":"2016-05-19T10:26:47Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-05-12T14:35:16Z","updated_at":"2016-05-19T12:13:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/24603","html_url":"https://github.com/owncloud/core/pull/24603","diff_url":"https://github.com/owncloud/core/pull/24603.diff","patch_url":"https://github.com/owncloud/core/pull/24603.patch"},"body":"This PR introduces flat federated re-shares. This means that if userA@serverA share a file with userB@serverB and userB decided to reshare the file with userC@serverC the share will be created directly between userA and userC. Still both userA and userB will see the share and will be able to manipulate it, unshare it etc.\r\n\r\nThis should be a nice performance boost for federated re-shares. Because now everyone is directly connected to the source of the file instead of going through multiple ownClouds.\r\n\r\nFurther this brings the same behavior we already have for internal shares to federated shares.\r\n\r\n- [x] reshare gets created directly by the owner\r\n- [x] unshare from self gets propagated to both the owner and the initiator of the share\r\n- [x] unshare form the owner/initiator gets propagated to the recipient and the initiator/owner\r\n- [x] notification says \"you received fileX from userA@serverA on behalf of userB@serverB\" so that you know who shared the file with you\r\n- [x] propagate permission changes\r\n- [x] fall-back for federated re-shares with older ownClouds\r\n- [x] adjust unit tests"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/220306392","html_url":"https://github.com/owncloud/core/pull/24603#issuecomment-220306392","issue_url":"https://api.github.com/repos/owncloud/core/issues/24603","id":220306392,"user":{"login":"SergioBertolinSG","id":9048796,"avatar_url":"https://avatars.githubusercontent.com/u/9048796?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioBertolinSG","html_url":"https://github.com/SergioBertolinSG","followers_url":"https://api.github.com/users/SergioBertolinSG/followers","following_url":"https://api.github.com/users/SergioBertolinSG/following{/other_user}","gists_url":"https://api.github.com/users/SergioBertolinSG/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioBertolinSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioBertolinSG/subscriptions","organizations_url":"https://api.github.com/users/SergioBertolinSG/orgs","repos_url":"https://api.github.com/users/SergioBertolinSG/repos","events_url":"https://api.github.com/users/SergioBertolinSG/events{/privacy}","received_events_url":"https://api.github.com/users/SergioBertolinSG/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T12:13:28Z","updated_at":"2016-05-19T12:13:28Z","body":"A question if this is expected or it is not:\r\nsteps (in all the steps the fed shares are accepted): \r\n1. Having three servers, A, B and C with three users, userA, userB and userC each. \r\n2. userA shares a file to userB and userB to userC.\r\n3. userB deletes the file. (userC is still seeing the share).\r\n4. userA shares again the same file with userB.\r\n5. userB shares again that file with userC.\r\n\r\nObserved: userC has now the file twice, second one with (2). Shouldn't him have only one file?"}}