{"action":"created","comment":{"url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments/65861754","id":65861754,"diff_hunk":"@@ -37,13 +44,30 @@ def create_methods(self):\n \n \n class TestSystemCore(unittest.TestCase):\n-    def setUp(self):\n-        self.block = Block(\"Hello\")\n-        self.controller = HelloController(self.block)\n \n     def test_hello_controller_good_input(self):\n-        result = self.block.say_hello(name = \"me\")\n+        block = Block(\"hello\")\n+        HelloController(block)\n+        result = block.say_hello(name=\"me\")\n         self.assertEquals(result[\"greeting\"], \"Hello me\")\n \n+    def test_hello_controller_with_process(self):\n+        sync_factory = SyncFactory(\"sched\")\n+        process = Process(\"proc\", sync_factory)\n+        block = Block(\"hello\")\n+        HelloController(block)\n+        process.add_block(block)\n+        process.start()\n+        q = sync_factory.create_queue()\n+        req = Request.Post(response_queue=q, context=\"ClientConnection\", id_=44,\n+                           endpoint=[\"hello\", \"say_hello\"],\n+                           parameters=dict(name=\"thing\"))\n+        process.q.put(req)\n+        resp = q.get(timeout=1)","path":"tests/test_core/test_system_core.py","position":47,"original_position":47,"commit_id":"4490c133aba4b9fb3b973142298cb47cdbf8c068","original_commit_id":"4490c133aba4b9fb3b973142298cb47cdbf8c068","user":{"login":"thomascobb","id":7705060,"avatar_url":"https://avatars.githubusercontent.com/u/7705060?v=3","gravatar_id":"","url":"https://api.github.com/users/thomascobb","html_url":"https://github.com/thomascobb","followers_url":"https://api.github.com/users/thomascobb/followers","following_url":"https://api.github.com/users/thomascobb/following{/other_user}","gists_url":"https://api.github.com/users/thomascobb/gists{/gist_id}","starred_url":"https://api.github.com/users/thomascobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomascobb/subscriptions","organizations_url":"https://api.github.com/users/thomascobb/orgs","repos_url":"https://api.github.com/users/thomascobb/repos","events_url":"https://api.github.com/users/thomascobb/events{/privacy}","received_events_url":"https://api.github.com/users/thomascobb/received_events","type":"User","site_admin":false},"body":"So that the test fails rather than hangs if something went wrong","created_at":"2016-06-06T09:34:08Z","updated_at":"2016-06-06T09:34:08Z","html_url":"https://github.com/dls-controls/pymalcolm/pull/18#discussion_r65861754","pull_request_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments/65861754"},"html":{"href":"https://github.com/dls-controls/pymalcolm/pull/18#discussion_r65861754"},"pull_request":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18","id":72479450,"html_url":"https://github.com/dls-controls/pymalcolm/pull/18","diff_url":"https://github.com/dls-controls/pymalcolm/pull/18.diff","patch_url":"https://github.com/dls-controls/pymalcolm/pull/18.patch","issue_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/18","number":18,"state":"open","locked":false,"title":"Added system test for hello controller with process","user":{"login":"thomascobb","id":7705060,"avatar_url":"https://avatars.githubusercontent.com/u/7705060?v=3","gravatar_id":"","url":"https://api.github.com/users/thomascobb","html_url":"https://github.com/thomascobb","followers_url":"https://api.github.com/users/thomascobb/followers","following_url":"https://api.github.com/users/thomascobb/following{/other_user}","gists_url":"https://api.github.com/users/thomascobb/gists{/gist_id}","starred_url":"https://api.github.com/users/thomascobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomascobb/subscriptions","organizations_url":"https://api.github.com/users/thomascobb/orgs","repos_url":"https://api.github.com/users/thomascobb/repos","events_url":"https://api.github.com/users/thomascobb/events{/privacy}","received_events_url":"https://api.github.com/users/thomascobb/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-03T09:36:18Z","updated_at":"2016-06-06T09:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eb65a920ef056a78e22246b0bef7edcb0fe9aa8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18/commits","review_comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18/comments","review_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/18/comments","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/4490c133aba4b9fb3b973142298cb47cdbf8c068","head":{"label":"dls-controls:system_tests","ref":"system_tests","sha":"4490c133aba4b9fb3b973142298cb47cdbf8c068","user":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":51362478,"name":"pymalcolm","full_name":"dls-controls/pymalcolm","owner":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dls-controls/pymalcolm","description":"Scanning in the middlelayer, v2","fork":false,"url":"https://api.github.com/repos/dls-controls/pymalcolm","forks_url":"https://api.github.com/repos/dls-controls/pymalcolm/forks","keys_url":"https://api.github.com/repos/dls-controls/pymalcolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dls-controls/pymalcolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dls-controls/pymalcolm/teams","hooks_url":"https://api.github.com/repos/dls-controls/pymalcolm/hooks","issue_events_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/events{/number}","events_url":"https://api.github.com/repos/dls-controls/pymalcolm/events","assignees_url":"https://api.github.com/repos/dls-controls/pymalcolm/assignees{/user}","branches_url":"https://api.github.com/repos/dls-controls/pymalcolm/branches{/branch}","tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/tags","blobs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/{sha}","languages_url":"https://api.github.com/repos/dls-controls/pymalcolm/languages","stargazers_url":"https://api.github.com/repos/dls-controls/pymalcolm/stargazers","contributors_url":"https://api.github.com/repos/dls-controls/pymalcolm/contributors","subscribers_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscribers","subscription_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscription","commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dls-controls/pymalcolm/contents/{+path}","compare_url":"https://api.github.com/repos/dls-controls/pymalcolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dls-controls/pymalcolm/merges","archive_url":"https://api.github.com/repos/dls-controls/pymalcolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dls-controls/pymalcolm/downloads","issues_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues{/number}","pulls_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls{/number}","milestones_url":"https://api.github.com/repos/dls-controls/pymalcolm/milestones{/number}","notifications_url":"https://api.github.com/repos/dls-controls/pymalcolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dls-controls/pymalcolm/labels{/name}","releases_url":"https://api.github.com/repos/dls-controls/pymalcolm/releases{/id}","deployments_url":"https://api.github.com/repos/dls-controls/pymalcolm/deployments","created_at":"2016-02-09T11:21:37Z","updated_at":"2016-03-14T14:22:17Z","pushed_at":"2016-06-06T08:58:35Z","git_url":"git://github.com/dls-controls/pymalcolm.git","ssh_url":"git@github.com:dls-controls/pymalcolm.git","clone_url":"https://github.com/dls-controls/pymalcolm.git","svn_url":"https://github.com/dls-controls/pymalcolm","homepage":null,"size":1045,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"dls-controls:master","ref":"master","sha":"91d591fde9cedb72bc660559b5db35d3f8c2a2c4","user":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":51362478,"name":"pymalcolm","full_name":"dls-controls/pymalcolm","owner":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dls-controls/pymalcolm","description":"Scanning in the middlelayer, v2","fork":false,"url":"https://api.github.com/repos/dls-controls/pymalcolm","forks_url":"https://api.github.com/repos/dls-controls/pymalcolm/forks","keys_url":"https://api.github.com/repos/dls-controls/pymalcolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dls-controls/pymalcolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dls-controls/pymalcolm/teams","hooks_url":"https://api.github.com/repos/dls-controls/pymalcolm/hooks","issue_events_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/events{/number}","events_url":"https://api.github.com/repos/dls-controls/pymalcolm/events","assignees_url":"https://api.github.com/repos/dls-controls/pymalcolm/assignees{/user}","branches_url":"https://api.github.com/repos/dls-controls/pymalcolm/branches{/branch}","tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/tags","blobs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/{sha}","languages_url":"https://api.github.com/repos/dls-controls/pymalcolm/languages","stargazers_url":"https://api.github.com/repos/dls-controls/pymalcolm/stargazers","contributors_url":"https://api.github.com/repos/dls-controls/pymalcolm/contributors","subscribers_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscribers","subscription_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscription","commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dls-controls/pymalcolm/contents/{+path}","compare_url":"https://api.github.com/repos/dls-controls/pymalcolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dls-controls/pymalcolm/merges","archive_url":"https://api.github.com/repos/dls-controls/pymalcolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dls-controls/pymalcolm/downloads","issues_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues{/number}","pulls_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls{/number}","milestones_url":"https://api.github.com/repos/dls-controls/pymalcolm/milestones{/number}","notifications_url":"https://api.github.com/repos/dls-controls/pymalcolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dls-controls/pymalcolm/labels{/name}","releases_url":"https://api.github.com/repos/dls-controls/pymalcolm/releases{/id}","deployments_url":"https://api.github.com/repos/dls-controls/pymalcolm/deployments","created_at":"2016-02-09T11:21:37Z","updated_at":"2016-03-14T14:22:17Z","pushed_at":"2016-06-06T08:58:35Z","git_url":"git://github.com/dls-controls/pymalcolm.git","ssh_url":"git@github.com:dls-controls/pymalcolm.git","clone_url":"https://github.com/dls-controls/pymalcolm.git","svn_url":"https://github.com/dls-controls/pymalcolm","homepage":null,"size":1045,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18"},"html":{"href":"https://github.com/dls-controls/pymalcolm/pull/18"},"issue":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/issues/18"},"comments":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/4490c133aba4b9fb3b973142298cb47cdbf8c068"}}}}
{"actor":{"display_login":"thomascobb"}}