{"action":"created","issue":{"url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/293","repository_url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge","labels_url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/293/labels{/name}","comments_url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/293/comments","events_url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/293/events","html_url":"https://github.com/linuxfoundation/cii-best-practices-badge/issues/293","id":150561297,"number":293,"title":"Have pronto review the whole code base, not just latest commit","user":{"login":"dankohn","id":3083270,"avatar_url":"https://avatars.githubusercontent.com/u/3083270?v=3","gravatar_id":"","url":"https://api.github.com/users/dankohn","html_url":"https://github.com/dankohn","followers_url":"https://api.github.com/users/dankohn/followers","following_url":"https://api.github.com/users/dankohn/following{/other_user}","gists_url":"https://api.github.com/users/dankohn/gists{/gist_id}","starred_url":"https://api.github.com/users/dankohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankohn/subscriptions","organizations_url":"https://api.github.com/users/dankohn/orgs","repos_url":"https://api.github.com/users/dankohn/repos","events_url":"https://api.github.com/users/dankohn/events{/privacy}","received_events_url":"https://api.github.com/users/dankohn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"david-a-wheeler","id":813150,"avatar_url":"https://avatars.githubusercontent.com/u/813150?v=3","gravatar_id":"","url":"https://api.github.com/users/david-a-wheeler","html_url":"https://github.com/david-a-wheeler","followers_url":"https://api.github.com/users/david-a-wheeler/followers","following_url":"https://api.github.com/users/david-a-wheeler/following{/other_user}","gists_url":"https://api.github.com/users/david-a-wheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/david-a-wheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-a-wheeler/subscriptions","organizations_url":"https://api.github.com/users/david-a-wheeler/orgs","repos_url":"https://api.github.com/users/david-a-wheeler/repos","events_url":"https://api.github.com/users/david-a-wheeler/events{/privacy}","received_events_url":"https://api.github.com/users/david-a-wheeler/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-04-23T14:42:18Z","updated_at":"2016-04-23T15:20:46Z","closed_at":null,"body":"Commit https://github.com/linuxfoundation/cii-best-practices-badge/commit/3996ab2faa7a9628e2d25ef7335d2c7c150c6faf changed what pronto is reviewing on each  CircleCI run.\r\n\r\nIt had been set to create a diff between HEAD and the first commit, so that the diff showed the entire codebase. However, you changed it to create a diff between HEAD and HEAD, which will always be empty, and so a no-op.\r\n\r\nWe could instead do `bundle exec pronto run -f github text -c=HEAD^1 --exit-code` which would only run pronto on the lastest commit. However, this create a problem when you push 3 commits at the same time, and pronto will no longer review the earlier 2. It also causes spurious `unused method` errors from `rails_best_practices` since the place where a method is being used might not be in the commit where it's defined."},"comment":{"url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/comments/213757346","html_url":"https://github.com/linuxfoundation/cii-best-practices-badge/issues/293#issuecomment-213757346","issue_url":"https://api.github.com/repos/linuxfoundation/cii-best-practices-badge/issues/293","id":213757346,"user":{"login":"david-a-wheeler","id":813150,"avatar_url":"https://avatars.githubusercontent.com/u/813150?v=3","gravatar_id":"","url":"https://api.github.com/users/david-a-wheeler","html_url":"https://github.com/david-a-wheeler","followers_url":"https://api.github.com/users/david-a-wheeler/followers","following_url":"https://api.github.com/users/david-a-wheeler/following{/other_user}","gists_url":"https://api.github.com/users/david-a-wheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/david-a-wheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-a-wheeler/subscriptions","organizations_url":"https://api.github.com/users/david-a-wheeler/orgs","repos_url":"https://api.github.com/users/david-a-wheeler/repos","events_url":"https://api.github.com/users/david-a-wheeler/events{/privacy}","received_events_url":"https://api.github.com/users/david-a-wheeler/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T15:20:46Z","updated_at":"2016-04-23T15:20:46Z","body":"We could do a quick-and-dirty \"HEAD^3\" to arbitrarily go back a few commits for *now* - and see if we can do a better job later."}}