{"action":"created","comment":{"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments/73177676","id":73177676,"diff_hunk":"@@ -289,7 +293,7 @@ public void isAppInstalledTest() throws Exception {\n         try {\n             actual = driver.isAppInstalled(bundleId);\n         } catch (WebDriverException wdException) {\n-            if (!driver.appPlatform.equals(driver.IOS)) {\n+            if (isAndroid) {","path":"src/test/java/io/appium/java_client/youiengine/SanityTest.java","position":122,"original_position":122,"commit_id":"d979c080229567da1f12bd5f9432a1e69633e091","original_commit_id":"d979c080229567da1f12bd5f9432a1e69633e091","user":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"body":"Unfortunately, one of the things Appium wanted out of the PR was our SanityTest. \r\n\r\nI'm not sure how this is any less readable? Also we can't predict the future - once we have other platforms, we'll deal with handling them then :) (I have to be conscience of this line of thinking too)","created_at":"2016-08-02T15:26:17Z","updated_at":"2016-08-02T15:26:17Z","html_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/26#discussion_r73177676","pull_request_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments/73177676"},"html":{"href":"https://github.com/YOU-i-Labs/appium-java-client/pull/26#discussion_r73177676"},"pull_request":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26","id":79407950,"html_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/26","diff_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/26.diff","patch_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/26.patch","issue_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/26","number":26,"state":"open","locked":false,"title":"Command executor helper changes","user":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"body":"## Change list\r\n\r\n- Updated YouiEngineDriver.java\r\n- Rebased our repo off Appium/java-client - master\r\n\r\n## Types of changes\r\n\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n## Details\r\n\r\nUses newer CommandExecutorHelper to send device specific (proxied) calls to the server.","created_at":"2016-07-29T19:04:43Z","updated_at":"2016-08-02T15:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3c31bf56eb916e006547cdc7c503a1f9fd66ca7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26/commits","review_comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26/comments","review_comment_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/26/comments","statuses_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/d979c080229567da1f12bd5f9432a1e69633e091","head":{"label":"pfoster-youitv:commandExecutorChanges","ref":"commandExecutorChanges","sha":"d979c080229567da1f12bd5f9432a1e69633e091","user":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"repo":{"id":63964022,"name":"appium-java-client","full_name":"pfoster-youitv/appium-java-client","owner":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfoster-youitv/appium-java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/pfoster-youitv/appium-java-client","forks_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/forks","keys_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/teams","hooks_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/hooks","issue_events_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/events","assignees_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/tags","blobs_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/languages","stargazers_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/stargazers","contributors_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/contributors","subscribers_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/subscribers","subscription_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/subscription","commits_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/merges","archive_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/downloads","issues_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/labels{/name}","releases_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/deployments","created_at":"2016-07-22T15:31:09Z","updated_at":"2016-07-22T15:31:13Z","pushed_at":"2016-08-02T14:19:16Z","git_url":"git://github.com/pfoster-youitv/appium-java-client.git","ssh_url":"git@github.com:pfoster-youitv/appium-java-client.git","clone_url":"https://github.com/pfoster-youitv/appium-java-client.git","svn_url":"https://github.com/pfoster-youitv/appium-java-client","homepage":null,"size":213314,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"YOU-i-Labs:develop","ref":"develop","sha":"7a8523d195e87237a9402b668326abec1d77fd55","user":{"login":"YOU-i-Labs","id":2078519,"avatar_url":"https://avatars.githubusercontent.com/u/2078519?v=3","gravatar_id":"","url":"https://api.github.com/users/YOU-i-Labs","html_url":"https://github.com/YOU-i-Labs","followers_url":"https://api.github.com/users/YOU-i-Labs/followers","following_url":"https://api.github.com/users/YOU-i-Labs/following{/other_user}","gists_url":"https://api.github.com/users/YOU-i-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/YOU-i-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOU-i-Labs/subscriptions","organizations_url":"https://api.github.com/users/YOU-i-Labs/orgs","repos_url":"https://api.github.com/users/YOU-i-Labs/repos","events_url":"https://api.github.com/users/YOU-i-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/YOU-i-Labs/received_events","type":"Organization","site_admin":false},"repo":{"id":60346845,"name":"appium-java-client","full_name":"YOU-i-Labs/appium-java-client","owner":{"login":"YOU-i-Labs","id":2078519,"avatar_url":"https://avatars.githubusercontent.com/u/2078519?v=3","gravatar_id":"","url":"https://api.github.com/users/YOU-i-Labs","html_url":"https://github.com/YOU-i-Labs","followers_url":"https://api.github.com/users/YOU-i-Labs/followers","following_url":"https://api.github.com/users/YOU-i-Labs/following{/other_user}","gists_url":"https://api.github.com/users/YOU-i-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/YOU-i-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOU-i-Labs/subscriptions","organizations_url":"https://api.github.com/users/YOU-i-Labs/orgs","repos_url":"https://api.github.com/users/YOU-i-Labs/repos","events_url":"https://api.github.com/users/YOU-i-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/YOU-i-Labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YOU-i-Labs/appium-java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client","forks_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/forks","keys_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/teams","hooks_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/hooks","issue_events_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/events","assignees_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/tags","blobs_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/languages","stargazers_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/stargazers","contributors_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/contributors","subscribers_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/subscribers","subscription_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/subscription","commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/merges","archive_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/downloads","issues_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/labels{/name}","releases_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/deployments","created_at":"2016-06-03T12:43:09Z","updated_at":"2016-06-03T12:43:40Z","pushed_at":"2016-08-02T14:19:16Z","git_url":"git://github.com/YOU-i-Labs/appium-java-client.git","ssh_url":"git@github.com:YOU-i-Labs/appium-java-client.git","clone_url":"https://github.com/YOU-i-Labs/appium-java-client.git","svn_url":"https://github.com/YOU-i-Labs/appium-java-client","homepage":null,"size":312295,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26"},"html":{"href":"https://github.com/YOU-i-Labs/appium-java-client/pull/26"},"issue":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/26"},"comments":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/d979c080229567da1f12bd5f9432a1e69633e091"}}}}
{"actor":{"display_login":"pfoster-youitv"}}