{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/92283931","pull_request_review_id":12796956,"id":92283931,"diff_hunk":"@@ -82,7 +82,11 @@ export function resolveWildcardPath(pattern: string, allowEmptyWildcardMatch?: b\n         // First find the most complete path without any matching patterns\n         let idx = firstWildcardIndex(pattern);\n         tl.debug(\"Index of first wildcard: \" + idx);\n-        let findPathRoot = path.dirname(pattern.slice(0, idx));\n+\n+        // include the wildcard character because:\n+        //  dirname(c:\\foo\\bar\\) => c:\\foo (which will make find() return a bunch of stuff we know we'll discard)\n+        //  dirname(c:\\foo\\bar\\*) => c:\\foo\\bar\n+        let findPathRoot = path.dirname(pattern.slice(0, idx + 1));","path":"Tasks/Common/nuget-task-common/Utility.ts","position":9,"original_position":9,"commit_id":"b5ac481d42842d96ce1cc51a1951652b9b85413d","original_commit_id":"b5ac481d42842d96ce1cc51a1951652b9b85413d","user":{"login":"ericsciple","id":12102068,"avatar_url":"https://avatars.githubusercontent.com/u/12102068?v=3","gravatar_id":"","url":"https://api.github.com/users/ericsciple","html_url":"https://github.com/ericsciple","followers_url":"https://api.github.com/users/ericsciple/followers","following_url":"https://api.github.com/users/ericsciple/following{/other_user}","gists_url":"https://api.github.com/users/ericsciple/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsciple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsciple/subscriptions","organizations_url":"https://api.github.com/users/ericsciple/orgs","repos_url":"https://api.github.com/users/ericsciple/repos","events_url":"https://api.github.com/users/ericsciple/events{/privacy}","received_events_url":"https://api.github.com/users/ericsciple/received_events","type":"User","site_admin":false},"body":"yes i agree it is something outside the scope of this pr\r\n\r\nthe change here seems appropriate\r\n\r\nnote, even with most of the glob options turned off, it's character sets that are not accounted for by firstWildcardIndex and cannot be turned off","created_at":"2016-12-13T22:42:19Z","updated_at":"2016-12-13T22:42:19Z","html_url":"https://github.com/Microsoft/vsts-tasks/pull/3249#discussion_r92283931","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/92283931"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/3249#discussion_r92283931"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249","id":97846612,"html_url":"https://github.com/Microsoft/vsts-tasks/pull/3249","diff_url":"https://github.com/Microsoft/vsts-tasks/pull/3249.diff","patch_url":"https://github.com/Microsoft/vsts-tasks/pull/3249.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3249","number":3249,"state":"open","locked":false,"title":"Avoid overly-broad tasklib.find call","user":{"login":"jmyersmsft","id":11822817,"avatar_url":"https://avatars.githubusercontent.com/u/11822817?v=3","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-13T22:12:47Z","updated_at":"2016-12-13T22:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c66dd96521cf165d0ccb2e02e2a91d9e90facb53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3249/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/b5ac481d42842d96ce1cc51a1951652b9b85413d","head":{"label":"jmyersmsft:narrowFindScope","ref":"narrowFindScope","sha":"b5ac481d42842d96ce1cc51a1951652b9b85413d","user":{"login":"jmyersmsft","id":11822817,"avatar_url":"https://avatars.githubusercontent.com/u/11822817?v=3","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"repo":{"id":50451379,"name":"vso-agent-tasks","full_name":"jmyersmsft/vso-agent-tasks","owner":{"login":"jmyersmsft","id":11822817,"avatar_url":"https://avatars.githubusercontent.com/u/11822817?v=3","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmyersmsft/vso-agent-tasks","description":"Build and Release Tasks for Visual Studio Online and Team Foundation Server","fork":true,"url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks","forks_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/forks","keys_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/teams","hooks_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/hooks","issue_events_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/events","assignees_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/tags","blobs_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/languages","stargazers_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/stargazers","contributors_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/contributors","subscribers_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/subscribers","subscription_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/subscription","commits_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/merges","archive_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/downloads","issues_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/labels{/name}","releases_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/jmyersmsft/vso-agent-tasks/deployments","created_at":"2016-01-26T18:57:02Z","updated_at":"2016-01-26T18:57:05Z","pushed_at":"2016-12-13T22:11:46Z","git_url":"git://github.com/jmyersmsft/vso-agent-tasks.git","ssh_url":"git@github.com:jmyersmsft/vso-agent-tasks.git","clone_url":"https://github.com/jmyersmsft/vso-agent-tasks.git","svn_url":"https://github.com/jmyersmsft/vso-agent-tasks","homepage":" https://www.visualstudio.com/features/devops-vs","size":18262,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d44b2f1cee6e6ce00ac183d1bbc48584c5a53559","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2016-12-13T18:58:38Z","pushed_at":"2016-12-13T22:18:49Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"git@github.com:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":23272,"stargazers_count":471,"watchers_count":471,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":431,"mirror_url":null,"open_issues_count":117,"forks":431,"open_issues":117,"watchers":471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/3249"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3249"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3249/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3249/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/b5ac481d42842d96ce1cc51a1951652b9b85413d"}}}}
{"actor":{"display_login":"ericsciple"}}