{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/652","repository_url":"https://api.github.com/repos/sul-dlss/sul-embed","labels_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/652/comments","events_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/652/events","html_url":"https://github.com/sul-dlss/sul-embed/pull/652","id":171543186,"number":652,"title":"is_it_working: differentiate non_crucial checks ","user":{"login":"ndushay","id":96775,"avatar_url":"https://avatars.githubusercontent.com/u/96775?v=3","gravatar_id":"","url":"https://api.github.com/users/ndushay","html_url":"https://github.com/ndushay","followers_url":"https://api.github.com/users/ndushay/followers","following_url":"https://api.github.com/users/ndushay/following{/other_user}","gists_url":"https://api.github.com/users/ndushay/gists{/gist_id}","starred_url":"https://api.github.com/users/ndushay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndushay/subscriptions","organizations_url":"https://api.github.com/users/ndushay/orgs","repos_url":"https://api.github.com/users/ndushay/repos","events_url":"https://api.github.com/users/ndushay/events{/privacy}","received_events_url":"https://api.github.com/users/ndushay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sul-dlss/sul-embed/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-16T23:41:09Z","updated_at":"2016-08-16T23:46:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/pulls/652","html_url":"https://github.com/sul-dlss/sul-embed/pull/652","diff_url":"https://github.com/sul-dlss/sul-embed/pull/652.diff","patch_url":"https://github.com/sul-dlss/sul-embed/pull/652.patch"},"body":"... and ignore their status for is_it_working overall status\r\n\r\nA failing \"non-crucial\" check not only returns 200 to the overall is_it_working status, but has an additional message that can be used to hopefully make it easier for PSMs to communicate with users/stakeholders.\r\n\r\n### Before\r\n\r\n![sul-embed before](https://cloud.githubusercontent.com/assets/96775/17719510/eca0bb96-63cf-11e6-8875-c469673ac481.png)\r\n\r\n### After\r\n\r\n![sul-embed after](https://cloud.githubusercontent.com/assets/96775/17719512/f26a3570-63cf-11e6-952b-708e3aa768f6.png)\r\n\r\nThis will allow the load balancer to check for status 200 while also allowing nagios to look for status 200 (for crucial alerts) and string matching on \"FAIL\" for non-crucial alerts.\r\n\r\nCloses #649"},"comment":{"url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/comments/240273563","html_url":"https://github.com/sul-dlss/sul-embed/pull/652#issuecomment-240273563","issue_url":"https://api.github.com/repos/sul-dlss/sul-embed/issues/652","id":240273563,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T23:46:41Z","updated_at":"2016-08-16T23:46:41Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7478895/badge)](https://coveralls.io/builds/7478895)\n\nCoverage remained the same at 98.644% when pulling **0838139b782517062be1d96750e1ad2e8600e871 on is-it-working-tweaks** into **fa87d8b317a508e2ba48d8a7f5020922aaf80e0e on master**.\n"}}
{"actor":{"display_login":"coveralls"}}