{"action":"closed","number":1194,"pull_request":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/1194","id":66704902,"html_url":"https://github.com/candlepin/candlepin/pull/1194","diff_url":"https://github.com/candlepin/candlepin/pull/1194.diff","patch_url":"https://github.com/candlepin/candlepin/pull/1194.patch","issue_url":"https://api.github.com/repos/candlepin/candlepin/issues/1194","number":1194,"state":"closed","locked":false,"title":"unit test thrice to catch non deterministic tests","user":{"login":"vritant","id":2501280,"avatar_url":"https://avatars.githubusercontent.com/u/2501280?v=3","gravatar_id":"","url":"https://api.github.com/users/vritant","html_url":"https://github.com/vritant","followers_url":"https://api.github.com/users/vritant/followers","following_url":"https://api.github.com/users/vritant/following{/other_user}","gists_url":"https://api.github.com/users/vritant/gists{/gist_id}","starred_url":"https://api.github.com/users/vritant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vritant/subscriptions","organizations_url":"https://api.github.com/users/vritant/orgs","repos_url":"https://api.github.com/users/vritant/repos","events_url":"https://api.github.com/users/vritant/events{/privacy}","received_events_url":"https://api.github.com/users/vritant/received_events","type":"User","site_admin":false},"body":"- Unit test as many times as needed using `cp-test -uuuu`\r\n- This helps to catch non-deterministic unit tests\r\n- create buildr lint task to checkstyle, rubocop, and rpmlint\r\n- add jenkins buildr task to do misc. validation\r\n- add -b option to cp-test to execute arbitrary buildr task\r\n- now you can run arbitrary buildr commands like:\r\n  - `cp-test -b test:PoolManagerTest`\r\n  - `cp-test -b jenkins`\r\n\r\nif accepted, we will need to :\r\n- [ ] re-build docker images\r\n- [ ] rename checkstyle job and update it to execute `cp-test -b jenkins -l` instead of just `cp-test -l`","created_at":"2016-04-15T21:05:51Z","updated_at":"2016-04-18T21:30:16Z","closed_at":"2016-04-18T21:30:16Z","merged_at":"2016-04-18T21:30:16Z","merge_commit_sha":"078f69aa760c5ac2143154372edb9dfceb8ee4c5","assignee":{"login":"Ceiu","id":6061522,"avatar_url":"https://avatars.githubusercontent.com/u/6061522?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/candlepin/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/candlepin/candlepin/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/candlepin/issues/1194/comments","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/4b134633f2b3ed7423f8c864f043bc26a235bc23","head":{"label":"candlepin:vritant/non-deterministic-unit-tests","ref":"vritant/non-deterministic-unit-tests","sha":"4b134633f2b3ed7423f8c864f043bc26a235bc23","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2016-03-25T11:56:48Z","pushed_at":"2016-04-18T21:30:16Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":58277,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":15,"forks":26,"open_issues":15,"watchers":35,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"34024d6a03428499e5c5d7308e8f414e077ef7b5","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2016-03-25T11:56:48Z","pushed_at":"2016-04-18T21:30:16Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":58277,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":15,"forks":26,"open_issues":15,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1194"},"html":{"href":"https://github.com/candlepin/candlepin/pull/1194"},"issue":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/1194"},"comments":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/candlepin/statuses/4b134633f2b3ed7423f8c864f043bc26a235bc23"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Ceiu","id":6061522,"avatar_url":"https://avatars.githubusercontent.com/u/6061522?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"comments":6,"review_comments":5,"commits":2,"additions":37,"deletions":13,"changed_files":2}}