{"action":"closed","number":3968,"pull_request":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/3968","id":70055705,"html_url":"https://github.com/vanilla/vanilla/pull/3968","diff_url":"https://github.com/vanilla/vanilla/pull/3968.diff","patch_url":"https://github.com/vanilla/vanilla/pull/3968.patch","issue_url":"https://api.github.com/repos/vanilla/vanilla/issues/3968","number":3968,"state":"closed","locked":false,"title":"Update Gdn_Format::text to deal with the love bug","user":{"login":"initvector","id":1390241,"avatar_url":"https://avatars.githubusercontent.com/u/1390241?v=3","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},"body":"`strip_tags` hates what it perceives to be invalid markup.  When you use a \"less-than\" sign, followed by a non-whitespace character, it's taken to mean an opening tag.  If you have an opening tag that is never fully completed/closed, you have invalid markup.  When users use \"<3\" in their messages, `strip_tags` immediately truncates the message just before the \"heart\".\r\n\r\nThis is an issue for plain-text e-mails. The message text is cutoff, because it is passed through `EmailTemplate::plainTextEmail`, which then passes the content through to `Gdn_Format::text` where it has a run in with `strip_tags`.  This is also an issue for anywhere in Vanilla which uses `Gdn_Format::text` to display user input.\r\n\r\nThis update implements a simple routine to convert the opening character of what it detects to be an invalid tag (any < not immediately followed by a letter).  The following call to `htmlspecialchars` has been updated to avoid double encoding of entities.\r\n\r\nCloses #3787\r\nCloses #2320","created_at":"2016-05-13T20:45:49Z","updated_at":"2016-05-13T22:28:50Z","closed_at":"2016-05-13T22:28:50Z","merged_at":"2016-05-13T22:28:50Z","merge_commit_sha":"137d4b904e097932e7146c11ddb59bd83c1a1cc9","assignee":{"login":"beckyvb","id":3805381,"avatar_url":"https://avatars.githubusercontent.com/u/3805381?v=3","gravatar_id":"","url":"https://api.github.com/users/beckyvb","html_url":"https://github.com/beckyvb","followers_url":"https://api.github.com/users/beckyvb/followers","following_url":"https://api.github.com/users/beckyvb/following{/other_user}","gists_url":"https://api.github.com/users/beckyvb/gists{/gist_id}","starred_url":"https://api.github.com/users/beckyvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckyvb/subscriptions","organizations_url":"https://api.github.com/users/beckyvb/orgs","repos_url":"https://api.github.com/users/beckyvb/repos","events_url":"https://api.github.com/users/beckyvb/events{/privacy}","received_events_url":"https://api.github.com/users/beckyvb/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/vanilla/vanilla/milestones/29","html_url":"https://github.com/vanilla/vanilla/milestones/Sprint%2012","labels_url":"https://api.github.com/repos/vanilla/vanilla/milestones/29/labels","id":1729661,"number":29,"title":"Sprint 12","description":"","creator":{"login":"linc","id":117672,"avatar_url":"https://avatars.githubusercontent.com/u/117672?v=3","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":31,"state":"open","created_at":"2016-04-25T17:09:40Z","updated_at":"2016-05-13T22:28:50Z","due_on":"2016-05-21T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vanilla/vanilla/pulls/3968/commits","review_comments_url":"https://api.github.com/repos/vanilla/vanilla/pulls/3968/comments","review_comment_url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanilla/vanilla/issues/3968/comments","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/9e0510c0f0113c8be3aabc84e389c36ed68383a3","head":{"label":"vanilla:fix/love-bug","ref":"fix/love-bug","sha":"9e0510c0f0113c8be3aabc84e389c36ed68383a3","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2016-05-08T09:56:45Z","pushed_at":"2016-05-13T22:28:50Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"http://vanillaforums.org","size":71724,"stargazers_count":1502,"watchers_count":1502,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":583,"mirror_url":null,"open_issues_count":382,"forks":583,"open_issues":382,"watchers":1502,"default_branch":"master"}},"base":{"label":"vanilla:master","ref":"master","sha":"b040eea88be3d39467f13aab0e895ac98e4c2b88","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2016-05-08T09:56:45Z","pushed_at":"2016-05-13T22:28:50Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"http://vanillaforums.org","size":71724,"stargazers_count":1502,"watchers_count":1502,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":583,"mirror_url":null,"open_issues_count":382,"forks":583,"open_issues":382,"watchers":1502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3968"},"html":{"href":"https://github.com/vanilla/vanilla/pull/3968"},"issue":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/3968"},"comments":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/3968/comments"},"review_comments":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3968/comments"},"review_comment":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3968/commits"},"statuses":{"href":"https://api.github.com/repos/vanilla/vanilla/statuses/9e0510c0f0113c8be3aabc84e389c36ed68383a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"beckyvb","id":3805381,"avatar_url":"https://avatars.githubusercontent.com/u/3805381?v=3","gravatar_id":"","url":"https://api.github.com/users/beckyvb","html_url":"https://github.com/beckyvb","followers_url":"https://api.github.com/users/beckyvb/followers","following_url":"https://api.github.com/users/beckyvb/following{/other_user}","gists_url":"https://api.github.com/users/beckyvb/gists{/gist_id}","starred_url":"https://api.github.com/users/beckyvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckyvb/subscriptions","organizations_url":"https://api.github.com/users/beckyvb/orgs","repos_url":"https://api.github.com/users/beckyvb/repos","events_url":"https://api.github.com/users/beckyvb/events{/privacy}","received_events_url":"https://api.github.com/users/beckyvb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":3,"additions":22,"deletions":12,"changed_files":1}}