{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/57833348","id":57833348,"diff_hunk":"@@ -67,6 +67,8 @@ lighthouse({\n   } else {\n     prettyPrint(results);\n   }\n+}).catch(function () {\n+  process.exit();","path":"cli.js","position":5,"original_position":5,"commit_id":"85480e1aa0cde1434a892a093250f67de06eeaac","original_commit_id":"85480e1aa0cde1434a892a093250f67de06eeaac","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"body":"yep!\r\n\r\nmake sure to to \r\n```\r\n.catch(err => {\r\n   .......\r\n});\r\n```","created_at":"2016-03-30T03:33:57Z","updated_at":"2016-03-30T03:33:57Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/103#discussion_r57833348","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/57833348"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/103#discussion_r57833348"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103","id":64561129,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/103","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/103.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/103.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/103","number":103,"state":"open","locked":false,"title":"Add exception handling to exit","user":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"body":"There is no handler for exception throwing from lighthouse. so the cli app can't exit properly","created_at":"2016-03-30T01:55:28Z","updated_at":"2016-03-30T03:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0b2c6bdf40945fe6fee187fae2518e6d6ae9d58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/103/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/85480e1aa0cde1434a892a093250f67de06eeaac","head":{"label":"ragingwind:exit","ref":"exit","sha":"85480e1aa0cde1434a892a093250f67de06eeaac","user":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"repo":{"id":54429888,"name":"lighthouse","full_name":"ragingwind/lighthouse","owner":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ragingwind/lighthouse","description":null,"fork":true,"url":"https://api.github.com/repos/ragingwind/lighthouse","forks_url":"https://api.github.com/repos/ragingwind/lighthouse/forks","keys_url":"https://api.github.com/repos/ragingwind/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ragingwind/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ragingwind/lighthouse/teams","hooks_url":"https://api.github.com/repos/ragingwind/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/ragingwind/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/ragingwind/lighthouse/events","assignees_url":"https://api.github.com/repos/ragingwind/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/ragingwind/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/ragingwind/lighthouse/tags","blobs_url":"https://api.github.com/repos/ragingwind/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ragingwind/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ragingwind/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/ragingwind/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ragingwind/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/ragingwind/lighthouse/languages","stargazers_url":"https://api.github.com/repos/ragingwind/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/ragingwind/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/ragingwind/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/ragingwind/lighthouse/subscription","commits_url":"https://api.github.com/repos/ragingwind/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/ragingwind/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/ragingwind/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/ragingwind/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/ragingwind/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/ragingwind/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ragingwind/lighthouse/merges","archive_url":"https://api.github.com/repos/ragingwind/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ragingwind/lighthouse/downloads","issues_url":"https://api.github.com/repos/ragingwind/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/ragingwind/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/ragingwind/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/ragingwind/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ragingwind/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/ragingwind/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/ragingwind/lighthouse/deployments","created_at":"2016-03-21T23:19:34Z","updated_at":"2016-03-21T23:19:35Z","pushed_at":"2016-03-30T01:38:57Z","git_url":"git://github.com/ragingwind/lighthouse.git","ssh_url":"git@github.com:ragingwind/lighthouse.git","clone_url":"https://github.com/ragingwind/lighthouse.git","svn_url":"https://github.com/ragingwind/lighthouse","homepage":null,"size":2378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"da556199435b6347c8447a3833edd3c479517058","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-03-29T19:09:16Z","pushed_at":"2016-03-30T01:55:28Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":null,"size":2390,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":31,"forks":9,"open_issues":31,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/103"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/103"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/85480e1aa0cde1434a892a093250f67de06eeaac"}}}}