{"action":"created","issue":{"url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/476","labels_url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/476/labels{/name}","comments_url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/476/comments","events_url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/476/events","html_url":"https://github.com/ganymedes01/TheErebus/issues/476","id":130608144,"number":476,"title":"Mobs are applying poison on collision rather than on attack","user":{"login":"Funwayguy","id":6048596,"avatar_url":"https://avatars.githubusercontent.com/u/6048596?v=3","gravatar_id":"","url":"https://api.github.com/users/Funwayguy","html_url":"https://github.com/Funwayguy","followers_url":"https://api.github.com/users/Funwayguy/followers","following_url":"https://api.github.com/users/Funwayguy/following{/other_user}","gists_url":"https://api.github.com/users/Funwayguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Funwayguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Funwayguy/subscriptions","organizations_url":"https://api.github.com/users/Funwayguy/orgs","repos_url":"https://api.github.com/users/Funwayguy/repos","events_url":"https://api.github.com/users/Funwayguy/events{/privacy}","received_events_url":"https://api.github.com/users/Funwayguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-02T08:11:04Z","updated_at":"2016-02-02T12:00:18Z","closed_at":null,"body":"This may not seem like a big deal but this bypasses invincibility frames on the player as well as applying effects to entities even if the mob isn't hostile to them. Please use vanilla Cave Spiders as a reference on how to properly set this up, i.e. checking first if the attack was successful then applying the potion side effect.\r\n\r\nKnown affected mobs:\r\n- EntityWasp\r\n- EntityScorpion\r\n- EntityCentipede\r\n\r\nIn addition to potion effects, other mob abilities such as the Scorpion's grab attack, apply on collision also bypassing attack cool downs and hostility checks. These should be preferably moved to 'attackEntityAsMob()' as well"},"comment":{"url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/comments/178530164","html_url":"https://github.com/ganymedes01/TheErebus/issues/476#issuecomment-178530164","issue_url":"https://api.github.com/repos/ganymedes01/TheErebus/issues/476","id":178530164,"user":{"login":"vadis365","id":6518708,"avatar_url":"https://avatars.githubusercontent.com/u/6518708?v=3","gravatar_id":"","url":"https://api.github.com/users/vadis365","html_url":"https://github.com/vadis365","followers_url":"https://api.github.com/users/vadis365/followers","following_url":"https://api.github.com/users/vadis365/following{/other_user}","gists_url":"https://api.github.com/users/vadis365/gists{/gist_id}","starred_url":"https://api.github.com/users/vadis365/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadis365/subscriptions","organizations_url":"https://api.github.com/users/vadis365/orgs","repos_url":"https://api.github.com/users/vadis365/repos","events_url":"https://api.github.com/users/vadis365/events{/privacy}","received_events_url":"https://api.github.com/users/vadis365/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T12:00:18Z","updated_at":"2016-02-02T12:00:18Z","body":"I'll ignore the comment about the Spiders thanks.\r\nInstead of applying the poison to the mobs collision, I will move it to an AI class and re-write the 3 year old code that is used on these mobs ;)"}}