{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5948","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5948/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5948/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5948/events","html_url":"https://github.com/scikit-learn/scikit-learn/issues/5948","id":119763880,"number":5948,"title":"[DOC+RFC] Enhance `test_size` and `train_size` docs","user":{"login":"raghavrv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavrv","html_url":"https://github.com/raghavrv","followers_url":"https://api.github.com/users/raghavrv/followers","following_url":"https://api.github.com/users/raghavrv/following{/other_user}","gists_url":"https://api.github.com/users/raghavrv/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavrv/subscriptions","organizations_url":"https://api.github.com/users/raghavrv/orgs","repos_url":"https://api.github.com/users/raghavrv/repos","events_url":"https://api.github.com/users/raghavrv/events{/privacy}","received_events_url":"https://api.github.com/users/raghavrv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2015-12-01T17:09:55Z","updated_at":"2016-09-03T14:21:20Z","closed_at":null,"body":"Clarify that setting `train_size` will not change the default value of `test_size` (`0.1`), unless you explicitly set it to `None`. \r\n\r\nOnly if `test_size` is explicitly set to `None`, the value is set to the complement of `train_size`, not otherwise. This should be made more explicit in the documentation.\r\n\r\n@GaelVaroquaux suggested that we could deprecate one of them (preferably `train_size`?). I feel thats a good idea. Any comments?\r\n\r\nSee issue #5940"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/244549159","html_url":"https://github.com/scikit-learn/scikit-learn/issues/5948#issuecomment-244549159","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5948","id":244549159,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T14:21:20Z","updated_at":"2016-09-03T14:21:20Z","body":"@GaelVaroquaux I suspect most people either assume the defaults are good enough, just set `test_size` or `train_size`, or else actually look at the docs.\r\n\r\n@nelson-liu I think a PR implementing @ogrisel's suggestion should be made, and we'll see if we can get the documentation clear enough."}}
{"actor":{"display_login":"jnothman"}}