{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/19","repository_url":"https://api.github.com/repos/dgraph-io/dgraph","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/19/comments","events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/19/events","html_url":"https://github.com/dgraph-io/dgraph/pull/19","id":131841925,"number":19,"title":"Add rocksDB merging code","user":{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-02-06T10:19:21Z","updated_at":"2016-02-07T05:47:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/19","html_url":"https://github.com/dgraph-io/dgraph/pull/19","diff_url":"https://github.com/dgraph-io/dgraph/pull/19.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/19.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/dgraph/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments/180957120","html_url":"https://github.com/dgraph-io/dgraph/pull/19#issuecomment-180957120","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/19","id":180957120,"user":{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false},"created_at":"2016-02-07T05:47:19Z","updated_at":"2016-02-07T05:47:19Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[tools/merge/merge.cc, line 29 \\[r2\\]](https://reviewable.io:443/reviews/dgraph-io/dgraph/19#-K9sg0fslIEt89KJNQJJ:-K9uG04Z5w2Glzd8Vioi:172514585) ([raw file](https://github.com/dgraph-io/dgraph/blob/b37e6c1bd6baf3ee7df09182d1d27d5bb3e8be8f/tools/merge/merge.cc#L29)):*\nShould we first try reading from the store and if its too slow change to the heap approach?\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/dgraph-io/dgraph/19)*\n<!-- Sent from Reviewable.io -->\n"}}