{"action":"created","issue":{"url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/1","repository_url":"https://api.github.com/repos/anvilresearch/oidc-rp","labels_url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/1/comments","events_url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/1/events","html_url":"https://github.com/anvilresearch/oidc-rp/pull/1","id":170900394,"number":1,"title":"Minor code tweaks / get rid of Standard warnings","user":{"login":"dmitrizagidulin","id":947005,"avatar_url":"https://avatars.githubusercontent.com/u/947005?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitrizagidulin","html_url":"https://github.com/dmitrizagidulin","followers_url":"https://api.github.com/users/dmitrizagidulin/followers","following_url":"https://api.github.com/users/dmitrizagidulin/following{/other_user}","gists_url":"https://api.github.com/users/dmitrizagidulin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrizagidulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrizagidulin/subscriptions","organizations_url":"https://api.github.com/users/dmitrizagidulin/orgs","repos_url":"https://api.github.com/users/dmitrizagidulin/repos","events_url":"https://api.github.com/users/dmitrizagidulin/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrizagidulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-12T15:43:01Z","updated_at":"2016-08-15T18:51:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/anvilresearch/oidc-rp/pulls/1","html_url":"https://github.com/anvilresearch/oidc-rp/pull/1","diff_url":"https://github.com/anvilresearch/oidc-rp/pull/1.diff","patch_url":"https://github.com/anvilresearch/oidc-rp/pull/1.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/comments/239892568","html_url":"https://github.com/anvilresearch/oidc-rp/pull/1#issuecomment-239892568","issue_url":"https://api.github.com/repos/anvilresearch/oidc-rp/issues/1","id":239892568,"user":{"login":"christiansmith","id":332377,"avatar_url":"https://avatars.githubusercontent.com/u/332377?v=3","gravatar_id":"","url":"https://api.github.com/users/christiansmith","html_url":"https://github.com/christiansmith","followers_url":"https://api.github.com/users/christiansmith/followers","following_url":"https://api.github.com/users/christiansmith/following{/other_user}","gists_url":"https://api.github.com/users/christiansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/christiansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiansmith/subscriptions","organizations_url":"https://api.github.com/users/christiansmith/orgs","repos_url":"https://api.github.com/users/christiansmith/repos","events_url":"https://api.github.com/users/christiansmith/events{/privacy}","received_events_url":"https://api.github.com/users/christiansmith/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T18:51:28Z","updated_at":"2016-08-15T18:51:28Z","body":"@dmitrizagidulin good thoughts. Assuming Standard JavaScript formatters/linters agree, let's go with the space after comma rule. That would have been my first thought, but I keep seeing people doing destructuring without commas and have tried to go with the flow there. In retrospect, this reminds me of...\r\n\r\n```javascript\r\nvar a = 0\r\n  , b = 1\r\n  , c = 2\r\n  ;\r\n```\r\n\r\n... which has a sort of eccentric \"which I were a lisper\" quality while only being marginally (and arguably) less error-prone to edit than...\r\n\r\n```javascript\r\nvar a = 0,\r\n    b = 1,\r\n    c = 2;\r\n```\r\n\r\n... where everything is simplified by...\r\n\r\n```javascript\r\nvar a = 1\r\nvar b = 2\r\nvar c = 3\r\n```\r\n\r\nI'm good with ordering by static vs proto (static on top) and otherwise alphabetically. Have gone more with the \"reads like a story\" very often in the past, but from experience that is quite arbitrary as everyone approaches reading new code differently. Alphabetical is better for finding what one is looking for. It's strikes me that comments are better able to tell the story because much code is impossibly non-linear in definition. Perhaps the comment above a class or at the top of the module is the right place to explain composition and context. \r\n\r\nAlso, I wonder if a strong urge to group related functions together would be better satisfied by other kinds of organization, such as breaking out related behaviors into a different class or module.\r\n\r\nThe only other question about conventions is what to do with the constructor. Should it be inline with alphabetical methods or, in contrast \"pinned\" to the top of the class? I'd go with top of the class if that's agreeable."}}
{"actor":{"display_login":"christiansmith"}}