{"action":"created","issue":{"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/477","repository_url":"https://api.github.com/repos/robertoDiaz/liferay-portal","labels_url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/477/labels{/name}","comments_url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/477/comments","events_url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/477/events","html_url":"https://github.com/robertoDiaz/liferay-portal/pull/477","id":171932771,"number":477,"title":"LPS-67115","user":{"login":"stian-sigvartsen","id":12467295,"avatar_url":"https://avatars.githubusercontent.com/u/12467295?v=3","gravatar_id":"","url":"https://api.github.com/users/stian-sigvartsen","html_url":"https://github.com/stian-sigvartsen","followers_url":"https://api.github.com/users/stian-sigvartsen/followers","following_url":"https://api.github.com/users/stian-sigvartsen/following{/other_user}","gists_url":"https://api.github.com/users/stian-sigvartsen/gists{/gist_id}","starred_url":"https://api.github.com/users/stian-sigvartsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stian-sigvartsen/subscriptions","organizations_url":"https://api.github.com/users/stian-sigvartsen/orgs","repos_url":"https://api.github.com/users/stian-sigvartsen/repos","events_url":"https://api.github.com/users/stian-sigvartsen/events{/privacy}","received_events_url":"https://api.github.com/users/stian-sigvartsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-18T15:40:01Z","updated_at":"2016-08-18T15:43:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/pulls/477","html_url":"https://github.com/robertoDiaz/liferay-portal/pull/477","diff_url":"https://github.com/robertoDiaz/liferay-portal/pull/477.diff","patch_url":"https://github.com/robertoDiaz/liferay-portal/pull/477.patch"},"body":"Please can you test that the changes made by myself & @topolik has not adversely affected the application logic. When ready, please squash/tidy the commits & send to Brian (or pass it back to me and I am happy to do it).\r\n\r\np.s. We can revisit @topolik 's concern over staging behaviour ( https://github.com/topolik/liferay-portal/pull/368#discussion_r74585660 ) when the new AnnouncementsAdmin portlet is ready if this code in question will be extracted anyway.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/comments/240765101","html_url":"https://github.com/robertoDiaz/liferay-portal/pull/477#issuecomment-240765101","issue_url":"https://api.github.com/repos/robertoDiaz/liferay-portal/issues/477","id":240765101,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T15:43:22Z","updated_at":"2016-08-18T15:43:22Z","body":"<h1>Some tests FAILED!</h1><p>Build Time: 3 minutes 1 second</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a><br />Branch GIT ID: <a href=\"https://github.com/liferay/liferay-portal/commit/f83ee83a19fb8df24f48974a87b5a857c9385af4\">f83ee83a19fb8df24f48974a87b5a857c9385af4</a></p><h4>Job Summary:</h4><ul><li><strike><strong><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master)/475/\">test-portal-acceptance-pullrequest(master)</a></strong></strike></li><li><strike><strong><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/193/\">test-portal-acceptance-pullrequest-source(master)</a></strong></strike></li></ul><h5>For more details click <a href=\"https://test-1-20.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/475/jenkins-report.html\">here</a>.</h5><hr /><h4>Failed Jobs:</h4><ol><li><h5><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master)/475/\">test-portal-acceptance-pullrequest(master)</a></h5><h6>Job Results:</h6><p>0 Jobs Passed.<br />2 Jobs Failed.</p><pre><code>Completed with the status of FAILURE.</code></pre></li><li><h5 job-result=\"FAILURE\"><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/193/\">test-portal-acceptance-pullrequest-source(master)</a></h5><p>Please fix <strong>rebase errors</strong> on <strong><a href=\"https://github.com/stian-sigvartsen/liferay-portal/tree/topolik-pull-request-368-LPS-67115\">stian-sigvartsen/topolik-pull-request-368-LPS-67115</a></strong>.</p><pre><code>     \\[exec\\] First, rewinding head to replay your work on top of it\\.\\.\\.\n     \\[exec\\] Applying: LPS\\-67115 ADD\\_ENTRY action is actually really used in JSP view layer to hide administration for performance reasons\\. Don't check it in service layer\\.\n     \\[exec\\] Applying: LPS\\-67115 Remove the ADD\\_ENTRY permission at Portlet level\n     \\[exec\\] Applying: LPS\\-67115 Create new resource permission using the service as resource\n     \\[exec\\] Applying: LPS\\-67115 Simplify the service API\\. With this new method invokers will need to provide a displayDate\\. If we want to offer a method to add announcements with the current display date we should have a new method that doesn't accept the display date parameter instead of having a boolean to decide the behaviour\\.\n     \\[exec\\] Applying: LPS\\-67115 SF\n     \\[exec\\] Applying: LPS\\-67115 ant build\\-service\\-portlet\\-announcements\n     \\[exec\\] Applying: LPS\\-67115 SEMVER\n     \\[exec\\] Using index info to reconstruct a base tree\\.\\.\\.\n     \\[exec\\] M\tmodules/core/portal\\-bootstrap/system\\.packages\\.extra\\.mf\n     \\[exec\\] M\tportal\\-kernel/src/com/liferay/portal/kernel/security/permission/packageinfo\n     \\[exec\\] <stdin>:9: trailing whitespace\\.\n     \\[exec\\] Bnd\\-LastModified: 1470680534271\n     \\[exec\\] <stdin>:16: trailing whitespace\\.\n     \\[exec\\] Created\\-By: 1\\.8\\.0\\_77 \\(Oracle Corporation\\)\n     \\[exec\\] <stdin>:25: trailing whitespace\\.\n     \\[exec\\]  il;version=\\\\\"1\\.0\\.0\\\\\";uses:=\\\\\"com\\.liferay\\.portal\\.kernel\\.model\\\\\",com\\.lifera\n     \\[exec\\] <stdin>:34: trailing whitespace\\.\n     \\[exec\\]  \\\\\",com\\.liferay\\.announcements\\.kernel\\.service;version=\\\\\"1\\.2\\.0\\\\\";uses:=\\\\\"com\n     \\[exec\\] <stdin>:43: trailing whitespace\\.\n     \\[exec\\]  il;version=\\\\\"1\\.0\\.0\\\\\";uses:=\\\\\"com\\.liferay\\.asset\\.kernel\\.service\\.persistenc\n     \\[exec\\] warning: squelched 1913 whitespace errors\n     \\[exec\\] warning: 1918 lines add whitespace errors\\.\n     \\[exec\\] Falling back to patching base and 3\\-way merge\\.\\.\\.\n     \\[exec\\] Auto\\-merging modules/core/portal\\-bootstrap/system\\.packages\\.extra\\.mf\n     \\[exec\\] CONFLICT \\(content\\): Merge conflict in modules/core/portal\\-bootstrap/system\\.packages\\.extra\\.mf\n     \\[exec\\] Failed to merge in the changes\\.\n     \\[exec\\] Patch failed at 0007 LPS\\-67115 SEMVER</code></pre></li></ol><h5>For upstream results, click <a href=\"http://test-1-1/job/test-portal-acceptance-upstream(master)/\">here</a>.</h5>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}