{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/76683856","id":76683856,"diff_hunk":"@@ -30,7 +30,10 @@ module.exports = function(name, props) { // eslint-disable-line\n   if (!svg[name]) {\n     throw new Error(\"Unknown SVG: \" + name);\n   }\n-  let className = props ? `${name} ${props.className}` : name;\n+  let className = name;","path":"public/images/Svg.js","position":5,"original_position":5,"commit_id":"14643e87001ba3a0a6abf9ef0b66789cc4159db1","original_commit_id":"14643e87001ba3a0a6abf9ef0b66789cc4159db1","user":{"login":"wldcordeiro","id":580982,"avatar_url":"https://avatars.githubusercontent.com/u/580982?v=3","gravatar_id":"","url":"https://api.github.com/users/wldcordeiro","html_url":"https://github.com/wldcordeiro","followers_url":"https://api.github.com/users/wldcordeiro/followers","following_url":"https://api.github.com/users/wldcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/wldcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/wldcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wldcordeiro/subscriptions","organizations_url":"https://api.github.com/users/wldcordeiro/orgs","repos_url":"https://api.github.com/users/wldcordeiro/repos","events_url":"https://api.github.com/users/wldcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/wldcordeiro/received_events","type":"User","site_admin":false},"body":"Maybe the better solution here would be for me to use the `classnames` lib like the rest of the app uses?","created_at":"2016-08-29T20:47:10Z","updated_at":"2016-08-29T20:47:10Z","html_url":"https://github.com/devtools-html/debugger.html/pull/619#discussion_r76683856","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/76683856"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/619#discussion_r76683856"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619","id":83156857,"html_url":"https://github.com/devtools-html/debugger.html/pull/619","diff_url":"https://github.com/devtools-html/debugger.html/pull/619.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/619.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/619","number":619,"state":"open","locked":false,"title":"File search close","user":{"login":"wldcordeiro","id":580982,"avatar_url":"https://avatars.githubusercontent.com/u/580982?v=3","gravatar_id":"","url":"https://api.github.com/users/wldcordeiro","html_url":"https://github.com/wldcordeiro","followers_url":"https://api.github.com/users/wldcordeiro/followers","following_url":"https://api.github.com/users/wldcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/wldcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/wldcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wldcordeiro/subscriptions","organizations_url":"https://api.github.com/users/wldcordeiro/orgs","repos_url":"https://api.github.com/users/wldcordeiro/repos","events_url":"https://api.github.com/users/wldcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/wldcordeiro/received_events","type":"User","site_admin":false},"body":"Associated with #584 adds the file search close button. I noticed a bug with `Svg` when I passed the `onClick` without the `className` prop also existing. Fixed this in a single commit that I can roll back and put in another PR.\r\n\r\nAlso still working on styling. Need some guidance there on what CSS is appropriate (in terms of units to use, flexbox, etc)\r\n\r\nScreenshot\r\n![screenshot_20160829_140522](https://cloud.githubusercontent.com/assets/580982/18065587/ab5ca204-6df1-11e6-9312-cd26efb508da.png)\r\n","created_at":"2016-08-29T19:52:56Z","updated_at":"2016-08-29T20:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26cd71fc8166d97e192b94b48ea8db969b3e7553","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/619/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/14643e87001ba3a0a6abf9ef0b66789cc4159db1","head":{"label":"wldcordeiro:file-search-close","ref":"file-search-close","sha":"14643e87001ba3a0a6abf9ef0b66789cc4159db1","user":{"login":"wldcordeiro","id":580982,"avatar_url":"https://avatars.githubusercontent.com/u/580982?v=3","gravatar_id":"","url":"https://api.github.com/users/wldcordeiro","html_url":"https://github.com/wldcordeiro","followers_url":"https://api.github.com/users/wldcordeiro/followers","following_url":"https://api.github.com/users/wldcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/wldcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/wldcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wldcordeiro/subscriptions","organizations_url":"https://api.github.com/users/wldcordeiro/orgs","repos_url":"https://api.github.com/users/wldcordeiro/repos","events_url":"https://api.github.com/users/wldcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/wldcordeiro/received_events","type":"User","site_admin":false},"repo":{"id":62337931,"name":"debugger.html","full_name":"wldcordeiro/debugger.html","owner":{"login":"wldcordeiro","id":580982,"avatar_url":"https://avatars.githubusercontent.com/u/580982?v=3","gravatar_id":"","url":"https://api.github.com/users/wldcordeiro","html_url":"https://github.com/wldcordeiro","followers_url":"https://api.github.com/users/wldcordeiro/followers","following_url":"https://api.github.com/users/wldcordeiro/following{/other_user}","gists_url":"https://api.github.com/users/wldcordeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/wldcordeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wldcordeiro/subscriptions","organizations_url":"https://api.github.com/users/wldcordeiro/orgs","repos_url":"https://api.github.com/users/wldcordeiro/repos","events_url":"https://api.github.com/users/wldcordeiro/events{/privacy}","received_events_url":"https://api.github.com/users/wldcordeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wldcordeiro/debugger.html","description":"An experimental debugger interface.","fork":true,"url":"https://api.github.com/repos/wldcordeiro/debugger.html","forks_url":"https://api.github.com/repos/wldcordeiro/debugger.html/forks","keys_url":"https://api.github.com/repos/wldcordeiro/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wldcordeiro/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wldcordeiro/debugger.html/teams","hooks_url":"https://api.github.com/repos/wldcordeiro/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/wldcordeiro/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/wldcordeiro/debugger.html/events","assignees_url":"https://api.github.com/repos/wldcordeiro/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/wldcordeiro/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/wldcordeiro/debugger.html/tags","blobs_url":"https://api.github.com/repos/wldcordeiro/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wldcordeiro/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wldcordeiro/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/wldcordeiro/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wldcordeiro/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/wldcordeiro/debugger.html/languages","stargazers_url":"https://api.github.com/repos/wldcordeiro/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/wldcordeiro/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/wldcordeiro/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/wldcordeiro/debugger.html/subscription","commits_url":"https://api.github.com/repos/wldcordeiro/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/wldcordeiro/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/wldcordeiro/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/wldcordeiro/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/wldcordeiro/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/wldcordeiro/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wldcordeiro/debugger.html/merges","archive_url":"https://api.github.com/repos/wldcordeiro/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wldcordeiro/debugger.html/downloads","issues_url":"https://api.github.com/repos/wldcordeiro/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/wldcordeiro/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/wldcordeiro/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/wldcordeiro/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wldcordeiro/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/wldcordeiro/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/wldcordeiro/debugger.html/deployments","created_at":"2016-06-30T19:44:44Z","updated_at":"2016-06-30T19:44:45Z","pushed_at":"2016-08-29T20:46:13Z","git_url":"git://github.com/wldcordeiro/debugger.html.git","ssh_url":"git@github.com:wldcordeiro/debugger.html.git","clone_url":"https://github.com/wldcordeiro/debugger.html.git","svn_url":"https://github.com/wldcordeiro/debugger.html","homepage":"","size":2330,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"afd32dd87d542ca3d472a8c4b8224aaa05706cfd","user":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars.githubusercontent.com/u/19979421?v=3","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"devtools-html/debugger.html","owner":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars.githubusercontent.com/u/19979421?v=3","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2016-08-29T17:56:00Z","pushed_at":"2016-08-29T20:46:14Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"git@github.com:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"","size":16714,"stargazers_count":150,"watchers_count":150,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":57,"forks":31,"open_issues":57,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/619"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/619"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/14643e87001ba3a0a6abf9ef0b66789cc4159db1"}}}}
{"actor":{"display_login":"wldcordeiro"}}