{"action":"opened","issue":{"url":"https://api.github.com/repos/BastilleResearch/nrf-research-firmware/issues/2","repository_url":"https://api.github.com/repos/BastilleResearch/nrf-research-firmware","labels_url":"https://api.github.com/repos/BastilleResearch/nrf-research-firmware/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/BastilleResearch/nrf-research-firmware/issues/2/comments","events_url":"https://api.github.com/repos/BastilleResearch/nrf-research-firmware/issues/2/events","html_url":"https://github.com/BastilleResearch/nrf-research-firmware/issues/2","id":194307258,"number":2,"title":"logitech-usb-restore does not match Logitech flashing tool","user":{"login":"hughsie","id":151380,"avatar_url":"https://avatars.githubusercontent.com/u/151380?v=3","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-08T11:04:28Z","updated_at":"2016-12-08T11:04:28Z","closed_at":null,"body":"In logitech-usb-restore you seem to have:\r\n\r\n    for payload in payloads:\r\n      response = dongle.send_command(0x21, 0x09, 0x0200, 0x0000, payload)\r\n    response = dongle.send_command(0x21, 0x09, 0x0200, 0x0000, payloads[0])\r\n\r\nBut the logitech tools only write the first packet once, at the end of the flashing process. I assume this is on the logic that if flashing fails the interrupt vector will be set at 0xffff and thus the bootloader does not start the runtime firmware. I think you probably should skip the first payload packet in the same way to avoid broken hardware if the flashing is interrupted.\r\n"}}
{"actor":{"display_login":"hughsie"}}