{"action":"created","comment":{"url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/comments/84005310","pull_request_review_id":4807649,"id":84005310,"diff_hunk":"@@ -30,13 +30,13 @@ start_link() ->\n             Error\n     end.\n \n--spec start_session(fun(() -> map())) -> {error, term()} | {ok, pid()}.\n-start_session(ConnInfoFun) when is_function(ConnInfoFun, 0) ->\n-\tsupervisor:start_child(?MODULE, [ConnInfoFun]).\n+-spec start_session(binary(), binary(), fun(() -> map())) -> {error, term()} | {ok, pid()}.\n+start_session(Token, XSRFToken, ConnInfoFun) when is_function(ConnInfoFun, 0) ->\n+\tsupervisor:start_child(?MODULE, [Token, XSRFToken, ConnInfoFun]).\n \n--spec close_session(pid()) -> ok | {error, not_found | simple_one_for_one}.\n-close_session(SessionPid) ->\n-    supervisor:terminate_child(?MODULE, SessionPid).\n+-spec close_session(binary()) -> ok | {error, not_found | simple_one_for_one}.\n+close_session(Token) ->","path":"src/dderl_session_sup.erl","position":24,"original_position":24,"commit_id":"0bc326cc8277ac65a4dfb4295ea0ea40f420961d","original_commit_id":"0bc326cc8277ac65a4dfb4295ea0ea40f420961d","user":{"login":"c-bik","id":913008,"avatar_url":"https://avatars.githubusercontent.com/u/913008?v=3","gravatar_id":"","url":"https://api.github.com/users/c-bik","html_url":"https://github.com/c-bik","followers_url":"https://api.github.com/users/c-bik/followers","following_url":"https://api.github.com/users/c-bik/following{/other_user}","gists_url":"https://api.github.com/users/c-bik/gists{/gist_id}","starred_url":"https://api.github.com/users/c-bik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-bik/subscriptions","organizations_url":"https://api.github.com/users/c-bik/orgs","repos_url":"https://api.github.com/users/c-bik/repos","events_url":"https://api.github.com/users/c-bik/events{/privacy}","received_events_url":"https://api.github.com/users/c-bik/received_events","type":"User","site_admin":false},"body":"Rename `Token` -> `SessionToken`","created_at":"2016-10-19T06:42:53Z","updated_at":"2016-10-19T06:42:53Z","html_url":"https://github.com/K2InformaticsGmbH/dderl/pull/293#discussion_r84005310","pull_request_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/comments/84005310"},"html":{"href":"https://github.com/K2InformaticsGmbH/dderl/pull/293#discussion_r84005310"},"pull_request":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293","id":83786196,"html_url":"https://github.com/K2InformaticsGmbH/dderl/pull/293","diff_url":"https://github.com/K2InformaticsGmbH/dderl/pull/293.diff","patch_url":"https://github.com/K2InformaticsGmbH/dderl/pull/293.patch","issue_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/293","number":293,"state":"open","locked":false,"title":"Saml Implementation","user":{"login":"shamis","id":3499591,"avatar_url":"https://avatars.githubusercontent.com/u/3499591?v=3","gravatar_id":"","url":"https://api.github.com/users/shamis","html_url":"https://github.com/shamis","followers_url":"https://api.github.com/users/shamis/followers","following_url":"https://api.github.com/users/shamis/following{/other_user}","gists_url":"https://api.github.com/users/shamis/gists{/gist_id}","starred_url":"https://api.github.com/users/shamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamis/subscriptions","organizations_url":"https://api.github.com/users/shamis/orgs","repos_url":"https://api.github.com/users/shamis/repos","events_url":"https://api.github.com/users/shamis/events{/privacy}","received_events_url":"https://api.github.com/users/shamis/received_events","type":"User","site_admin":false},"body":"Fixes #291 \r\nFixes #280 \r\nFixes #305 \r\nAdded Xsrf token","created_at":"2016-09-02T11:27:13Z","updated_at":"2016-10-19T06:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1951920b28832c814309791be5f33c61b524713","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293/commits","review_comments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293/comments","review_comment_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/293/comments","statuses_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/statuses/0bc326cc8277ac65a4dfb4295ea0ea40f420961d","head":{"label":"K2InformaticsGmbH:saml","ref":"saml","sha":"0bc326cc8277ac65a4dfb4295ea0ea40f420961d","user":{"login":"K2InformaticsGmbH","id":7457120,"avatar_url":"https://avatars.githubusercontent.com/u/7457120?v=3","gravatar_id":"","url":"https://api.github.com/users/K2InformaticsGmbH","html_url":"https://github.com/K2InformaticsGmbH","followers_url":"https://api.github.com/users/K2InformaticsGmbH/followers","following_url":"https://api.github.com/users/K2InformaticsGmbH/following{/other_user}","gists_url":"https://api.github.com/users/K2InformaticsGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/K2InformaticsGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K2InformaticsGmbH/subscriptions","organizations_url":"https://api.github.com/users/K2InformaticsGmbH/orgs","repos_url":"https://api.github.com/users/K2InformaticsGmbH/repos","events_url":"https://api.github.com/users/K2InformaticsGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/K2InformaticsGmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":3985584,"name":"dderl","full_name":"K2InformaticsGmbH/dderl","owner":{"login":"K2InformaticsGmbH","id":7457120,"avatar_url":"https://avatars.githubusercontent.com/u/7457120?v=3","gravatar_id":"","url":"https://api.github.com/users/K2InformaticsGmbH","html_url":"https://github.com/K2InformaticsGmbH","followers_url":"https://api.github.com/users/K2InformaticsGmbH/followers","following_url":"https://api.github.com/users/K2InformaticsGmbH/following{/other_user}","gists_url":"https://api.github.com/users/K2InformaticsGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/K2InformaticsGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K2InformaticsGmbH/subscriptions","organizations_url":"https://api.github.com/users/K2InformaticsGmbH/orgs","repos_url":"https://api.github.com/users/K2InformaticsGmbH/repos","events_url":"https://api.github.com/users/K2InformaticsGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/K2InformaticsGmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/K2InformaticsGmbH/dderl","description":"Web based Data Explorer / Data Jump Station with Erlang In-Memory Support","fork":false,"url":"https://api.github.com/repos/K2InformaticsGmbH/dderl","forks_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/forks","keys_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/teams","hooks_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/hooks","issue_events_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/events{/number}","events_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/events","assignees_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/assignees{/user}","branches_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/branches{/branch}","tags_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/tags","blobs_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/refs{/sha}","trees_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/statuses/{sha}","languages_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/languages","stargazers_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/stargazers","contributors_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/contributors","subscribers_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/subscribers","subscription_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/subscription","commits_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/commits{/sha}","git_commits_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/commits{/sha}","comments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/comments{/number}","issue_comment_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/comments{/number}","contents_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/contents/{+path}","compare_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/merges","archive_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/downloads","issues_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues{/number}","pulls_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls{/number}","milestones_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/milestones{/number}","notifications_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/labels{/name}","releases_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/releases{/id}","deployments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/deployments","created_at":"2012-04-10T18:27:09Z","updated_at":"2016-09-03T12:12:01Z","pushed_at":"2016-10-18T13:21:54Z","git_url":"git://github.com/K2InformaticsGmbH/dderl.git","ssh_url":"git@github.com:K2InformaticsGmbH/dderl.git","clone_url":"https://github.com/K2InformaticsGmbH/dderl.git","svn_url":"https://github.com/K2InformaticsGmbH/dderl","homepage":"","size":14384,"stargazers_count":3,"watchers_count":3,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":36,"forks":4,"open_issues":36,"watchers":3,"default_branch":"master"}},"base":{"label":"K2InformaticsGmbH:master","ref":"master","sha":"9beb0fe84db77fd27f6178bc832a23c06bac7dfc","user":{"login":"K2InformaticsGmbH","id":7457120,"avatar_url":"https://avatars.githubusercontent.com/u/7457120?v=3","gravatar_id":"","url":"https://api.github.com/users/K2InformaticsGmbH","html_url":"https://github.com/K2InformaticsGmbH","followers_url":"https://api.github.com/users/K2InformaticsGmbH/followers","following_url":"https://api.github.com/users/K2InformaticsGmbH/following{/other_user}","gists_url":"https://api.github.com/users/K2InformaticsGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/K2InformaticsGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K2InformaticsGmbH/subscriptions","organizations_url":"https://api.github.com/users/K2InformaticsGmbH/orgs","repos_url":"https://api.github.com/users/K2InformaticsGmbH/repos","events_url":"https://api.github.com/users/K2InformaticsGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/K2InformaticsGmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":3985584,"name":"dderl","full_name":"K2InformaticsGmbH/dderl","owner":{"login":"K2InformaticsGmbH","id":7457120,"avatar_url":"https://avatars.githubusercontent.com/u/7457120?v=3","gravatar_id":"","url":"https://api.github.com/users/K2InformaticsGmbH","html_url":"https://github.com/K2InformaticsGmbH","followers_url":"https://api.github.com/users/K2InformaticsGmbH/followers","following_url":"https://api.github.com/users/K2InformaticsGmbH/following{/other_user}","gists_url":"https://api.github.com/users/K2InformaticsGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/K2InformaticsGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K2InformaticsGmbH/subscriptions","organizations_url":"https://api.github.com/users/K2InformaticsGmbH/orgs","repos_url":"https://api.github.com/users/K2InformaticsGmbH/repos","events_url":"https://api.github.com/users/K2InformaticsGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/K2InformaticsGmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/K2InformaticsGmbH/dderl","description":"Web based Data Explorer / Data Jump Station with Erlang In-Memory Support","fork":false,"url":"https://api.github.com/repos/K2InformaticsGmbH/dderl","forks_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/forks","keys_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/teams","hooks_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/hooks","issue_events_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/events{/number}","events_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/events","assignees_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/assignees{/user}","branches_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/branches{/branch}","tags_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/tags","blobs_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/refs{/sha}","trees_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/statuses/{sha}","languages_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/languages","stargazers_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/stargazers","contributors_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/contributors","subscribers_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/subscribers","subscription_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/subscription","commits_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/commits{/sha}","git_commits_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/git/commits{/sha}","comments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/comments{/number}","issue_comment_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/comments{/number}","contents_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/contents/{+path}","compare_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/merges","archive_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/downloads","issues_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues{/number}","pulls_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls{/number}","milestones_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/milestones{/number}","notifications_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/labels{/name}","releases_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/releases{/id}","deployments_url":"https://api.github.com/repos/K2InformaticsGmbH/dderl/deployments","created_at":"2012-04-10T18:27:09Z","updated_at":"2016-09-03T12:12:01Z","pushed_at":"2016-10-18T13:21:54Z","git_url":"git://github.com/K2InformaticsGmbH/dderl.git","ssh_url":"git@github.com:K2InformaticsGmbH/dderl.git","clone_url":"https://github.com/K2InformaticsGmbH/dderl.git","svn_url":"https://github.com/K2InformaticsGmbH/dderl","homepage":"","size":14384,"stargazers_count":3,"watchers_count":3,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":36,"forks":4,"open_issues":36,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293"},"html":{"href":"https://github.com/K2InformaticsGmbH/dderl/pull/293"},"issue":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/293"},"comments":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/K2InformaticsGmbH/dderl/statuses/0bc326cc8277ac65a4dfb4295ea0ea40f420961d"}}}}
{"actor":{"display_login":"c-bik"}}