{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/83814076","pull_request_review_id":4631266,"id":83814076,"diff_hunk":"@@ -286,21 +286,24 @@ def build_cells(self, bc=['reflective'] * 6):\n                    openmc.XPlane(x0=self.upper_right[0],\n                                  boundary_type=bc[1])]\n         if len(self.dimension) == 1:\n-            yplanes = [openmc.YPlane(y0=np.finfo(np.float).min,\n-                                     boundary_type='reflective'),\n-                       openmc.YPlane(y0=np.finfo(np.float).max,\n-                                     boundary_type='reflective')]\n+            yplanes = [openmc.YPlane(y0=1000., boundary_type='reflective'),\n+                       openmc.YPlane(y0=1000., boundary_type='reflective')]","path":"openmc/mesh.py","position":null,"original_position":9,"commit_id":"22df8cfe417d7cfe88361bd4cac75c315798f09e","original_commit_id":"aaf9b401691e647c29c9c58a34046254a3e30e7c","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"body":"- [x] ","created_at":"2016-10-18T09:24:45Z","updated_at":"2016-10-18T09:24:45Z","html_url":"https://github.com/mit-crpg/openmc/pull/719#discussion_r83814076","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/719","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/83814076"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/719#discussion_r83814076"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/719","id":84782954,"html_url":"https://github.com/mit-crpg/openmc/pull/719","diff_url":"https://github.com/mit-crpg/openmc/pull/719.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/719.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/719","number":719,"state":"open","locked":false,"title":"Implement HDF5-Based Multi-Group XS Library Format","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"body":"This PR resolves #594 while also updating to reflect the temperature-dependent data format in use through the rest of the code as a result of #712.  I have also replaced direct hdf5 calls from nuclide_header, sab_header, reaction_header with wrapper functions in hdf5_interface.  \r\n\r\nThe python API has been updatd, and a script provided (openmc-update-mgxs.py) to convert old XML libs to the h5 format.  \r\n\r\n@friedmud, @wbinventor, and @samuelshaner could you please review with an eye on the suitability of this format to your needs?  As we discussed in #594 it would be best if we all used the same format.  I believe I've captured all your concerns in the discussions within #594, but double check for me.  The only differences in this library from the one I was sharing there are that the temperature-dependent data was slightly re-organized to match what we do with the continuous-energy HDF5 files, and, I've got in the sparse scattering matrices @friedmud requested.  Thanks guys!","created_at":"2016-09-11T10:39:14Z","updated_at":"2016-10-18T09:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19b7d722a0c34a432d96f985da1f53a437bdcb6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/719/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/719/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/719/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/22df8cfe417d7cfe88361bd4cac75c315798f09e","head":{"label":"nelsonag:mg_th5","ref":"mg_th5","sha":"22df8cfe417d7cfe88361bd4cac75c315798f09e","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"repo":{"id":18528596,"name":"openmc","full_name":"nelsonag/openmc","owner":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelsonag/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/nelsonag/openmc","forks_url":"https://api.github.com/repos/nelsonag/openmc/forks","keys_url":"https://api.github.com/repos/nelsonag/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelsonag/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelsonag/openmc/teams","hooks_url":"https://api.github.com/repos/nelsonag/openmc/hooks","issue_events_url":"https://api.github.com/repos/nelsonag/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/nelsonag/openmc/events","assignees_url":"https://api.github.com/repos/nelsonag/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/nelsonag/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/nelsonag/openmc/tags","blobs_url":"https://api.github.com/repos/nelsonag/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelsonag/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelsonag/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelsonag/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelsonag/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/nelsonag/openmc/languages","stargazers_url":"https://api.github.com/repos/nelsonag/openmc/stargazers","contributors_url":"https://api.github.com/repos/nelsonag/openmc/contributors","subscribers_url":"https://api.github.com/repos/nelsonag/openmc/subscribers","subscription_url":"https://api.github.com/repos/nelsonag/openmc/subscription","commits_url":"https://api.github.com/repos/nelsonag/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelsonag/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelsonag/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelsonag/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelsonag/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/nelsonag/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelsonag/openmc/merges","archive_url":"https://api.github.com/repos/nelsonag/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelsonag/openmc/downloads","issues_url":"https://api.github.com/repos/nelsonag/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/nelsonag/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/nelsonag/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/nelsonag/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelsonag/openmc/labels{/name}","releases_url":"https://api.github.com/repos/nelsonag/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/nelsonag/openmc/deployments","created_at":"2014-04-07T18:40:04Z","updated_at":"2016-10-04T23:18:12Z","pushed_at":"2016-10-18T09:23:43Z","git_url":"git://github.com/nelsonag/openmc.git","ssh_url":"git@github.com:nelsonag/openmc.git","clone_url":"https://github.com/nelsonag/openmc.git","svn_url":"https://github.com/nelsonag/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":32357,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"d39d634a4009f8cfce127d7bab9588b8982b3bdb","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/openmc/deployments","created_at":"2011-07-21T00:33:27Z","updated_at":"2016-10-11T18:38:26Z","pushed_at":"2016-10-18T09:23:44Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":49934,"stargazers_count":88,"watchers_count":88,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":103,"mirror_url":null,"open_issues_count":53,"forks":103,"open_issues":53,"watchers":88,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/719"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/719"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/719"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/22df8cfe417d7cfe88361bd4cac75c315798f09e"}}}}
{"actor":{"display_login":"nelsonag"}}