{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/89522671","pull_request_review_id":10068378,"id":89522671,"diff_hunk":"@@ -909,8 +911,13 @@ private void waitForHawkularServer() throws Exception {\n                 if (response.code() != 200) {\n                     log.debugf(\"Hawkular Metrics is not ready yet: %d/%s\", response.code(), response.message());\n                 } else {\n-                    log.debugf(\"Hawkular Metrics is ready: %s\", response.body().string());\n-                    break;\n+                    String bodyString = response.body().string();\n+                    if (checkReallyUp(bodyString)) {\n+                        log.debugf(\"Hawkular Metrics is ready %s\", bodyString);\n+                        break;\n+                    } else {\n+                        log.debugf(\"Hawkular Metrics is still starting\", bodyString);","path":"hawkular-wildfly-agent/src/main/java/org/hawkular/agent/monitor/service/MonitorService.java","position":27,"original_position":27,"commit_id":"77dd56ca3c92013577d3b4c2be43676098102650","original_commit_id":"77dd56ca3c92013577d3b4c2be43676098102650","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"body":"Sorry @pilhuhn  - I just noticed this when I was about to press the merge button. Notice this debugf call passes in \"bodyString\" but you don't have a %s in the log message, so its not used. Need to fix that. Other than that, this is ready to be merged once that is fixed. So change this line to:\r\n\r\n````\r\nlog.debugf(\"Hawkular Metrics is still starting: %s\", bodyString);\r\n````\r\n\r\nWhile you are here, probably also good to add a colon to the previous debug log message to separate the static message with the value of bodyString - line 916:\r\n\r\n````\r\nlog.debugf(\"Hawkular Metrics is ready: %s\", bodyString);\r\n````","created_at":"2016-11-24T16:08:04Z","updated_at":"2016-11-24T16:08:04Z","html_url":"https://github.com/hawkular/hawkular-agent/pull/270#discussion_r89522671","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/89522671"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/270#discussion_r89522671"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270","id":95153222,"html_url":"https://github.com/hawkular/hawkular-agent/pull/270","diff_url":"https://github.com/hawkular/hawkular-agent/pull/270.diff","patch_url":"https://github.com/hawkular/hawkular-agent/pull/270.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/270","number":270,"state":"open","locked":false,"title":"Check if metrics is really up or still starting.","user":{"login":"pilhuhn","id":208246,"avatar_url":"https://avatars.githubusercontent.com/u/208246?v=3","gravatar_id":"","url":"https://api.github.com/users/pilhuhn","html_url":"https://github.com/pilhuhn","followers_url":"https://api.github.com/users/pilhuhn/followers","following_url":"https://api.github.com/users/pilhuhn/following{/other_user}","gists_url":"https://api.github.com/users/pilhuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/pilhuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilhuhn/subscriptions","organizations_url":"https://api.github.com/users/pilhuhn/orgs","repos_url":"https://api.github.com/users/pilhuhn/repos","events_url":"https://api.github.com/users/pilhuhn/events{/privacy}","received_events_url":"https://api.github.com/users/pilhuhn/received_events","type":"User","site_admin":false},"body":"If metrics returns 200 OK, we still need to check if it is still starting.\r\n\r\nHWKAGENT-150","created_at":"2016-11-24T10:34:57Z","updated_at":"2016-11-24T16:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf57cc2776dc9d4a5a4da923a2edec6fdc6ecdd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/270/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/77dd56ca3c92013577d3b4c2be43676098102650","head":{"label":"pilhuhn:wait-more","ref":"wait-more","sha":"77dd56ca3c92013577d3b4c2be43676098102650","user":{"login":"pilhuhn","id":208246,"avatar_url":"https://avatars.githubusercontent.com/u/208246?v=3","gravatar_id":"","url":"https://api.github.com/users/pilhuhn","html_url":"https://github.com/pilhuhn","followers_url":"https://api.github.com/users/pilhuhn/followers","following_url":"https://api.github.com/users/pilhuhn/following{/other_user}","gists_url":"https://api.github.com/users/pilhuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/pilhuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilhuhn/subscriptions","organizations_url":"https://api.github.com/users/pilhuhn/orgs","repos_url":"https://api.github.com/users/pilhuhn/repos","events_url":"https://api.github.com/users/pilhuhn/events{/privacy}","received_events_url":"https://api.github.com/users/pilhuhn/received_events","type":"User","site_admin":false},"repo":{"id":38070917,"name":"hawkular-agent","full_name":"pilhuhn/hawkular-agent","owner":{"login":"pilhuhn","id":208246,"avatar_url":"https://avatars.githubusercontent.com/u/208246?v=3","gravatar_id":"","url":"https://api.github.com/users/pilhuhn","html_url":"https://github.com/pilhuhn","followers_url":"https://api.github.com/users/pilhuhn/followers","following_url":"https://api.github.com/users/pilhuhn/following{/other_user}","gists_url":"https://api.github.com/users/pilhuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/pilhuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilhuhn/subscriptions","organizations_url":"https://api.github.com/users/pilhuhn/orgs","repos_url":"https://api.github.com/users/pilhuhn/repos","events_url":"https://api.github.com/users/pilhuhn/events{/privacy}","received_events_url":"https://api.github.com/users/pilhuhn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pilhuhn/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":true,"url":"https://api.github.com/repos/pilhuhn/hawkular-agent","forks_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/forks","keys_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/events","assignees_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/merges","archive_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/releases{/id}","deployments_url":"https://api.github.com/repos/pilhuhn/hawkular-agent/deployments","created_at":"2015-06-25T19:58:04Z","updated_at":"2016-06-27T19:55:51Z","pushed_at":"2016-11-24T15:37:12Z","git_url":"git://github.com/pilhuhn/hawkular-agent.git","ssh_url":"git@github.com:pilhuhn/hawkular-agent.git","clone_url":"https://github.com/pilhuhn/hawkular-agent.git","svn_url":"https://github.com/pilhuhn/hawkular-agent","homepage":null,"size":3772,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"83514a58f030928d9019495a1a73b06255aca3f4","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":33185377,"name":"hawkular-agent","full_name":"hawkular/hawkular-agent","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-agent","forks_url":"https://api.github.com/repos/hawkular/hawkular-agent/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-agent/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-agent/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-agent/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-agent/deployments","created_at":"2015-03-31T12:56:14Z","updated_at":"2016-11-02T00:20:59Z","pushed_at":"2016-11-24T15:37:12Z","git_url":"git://github.com/hawkular/hawkular-agent.git","ssh_url":"git@github.com:hawkular/hawkular-agent.git","clone_url":"https://github.com/hawkular/hawkular-agent.git","svn_url":"https://github.com/hawkular/hawkular-agent","homepage":null,"size":3974,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":4,"forks":29,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/270"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/270"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/77dd56ca3c92013577d3b4c2be43676098102650"}}}}
{"actor":{"display_login":"jmazzitelli"}}