{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/76368743","id":76368743,"diff_hunk":"@@ -155,7 +155,58 @@ func (h *Runtime) PodSandboxStatus(podSandboxID string) (*kubeapi.PodSandboxStat\n \n // ListPodSandbox returns a list of Sandbox.\n func (h *Runtime) ListPodSandbox(filter *kubeapi.PodSandboxFilter) ([]*kubeapi.PodSandbox, error) {\n-\treturn nil, fmt.Errorf(\"Not implemented\")\n+\tpods, err := h.client.GetPodList()\n+\tif err != nil {\n+\t\tglog.Errorf(\"GetPodList failed: %v\", err)\n+\t\treturn nil, err\n+\t}\n+\n+\titems := make([]*kubeapi.PodSandbox, 0, len(pods))\n+\tfor _, pod := range pods {\n+\t\tstate := toPodSandboxState(pod.Status)\n+\n+\t\tif filter != nil {\n+\t\t\tif filter.Name != nil && pod.PodName != filter.GetName() {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\n+\t\t\tif filter.Id != nil && pod.PodID != filter.GetId() {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\n+\t\t\tif filter.State != nil && state != filter.GetState() {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t}\n+\n+\t\tif filter != nil && filter.LabelSelector != nil &&\n+\t\t\t!inMap(filter.LabelSelector, pod.Labels) {","path":"pkg/hyper/hyper.go","position":30,"original_position":30,"commit_id":"ba205f92631157ab0ef5eac146fbaee4f67bc945","original_commit_id":"ba205f92631157ab0ef5eac146fbaee4f67bc945","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"Labels filtering should be moved up into `if filter != nil {  }`","created_at":"2016-08-26T06:15:23Z","updated_at":"2016-08-26T06:15:23Z","html_url":"https://github.com/kubernetes/frakti/pull/20#discussion_r76368743","pull_request_url":"https://api.github.com/repos/kubernetes/frakti/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/76368743"},"html":{"href":"https://github.com/kubernetes/frakti/pull/20#discussion_r76368743"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/20","id":82834058,"html_url":"https://github.com/kubernetes/frakti/pull/20","diff_url":"https://github.com/kubernetes/frakti/pull/20.diff","patch_url":"https://github.com/kubernetes/frakti/pull/20.patch","issue_url":"https://api.github.com/repos/kubernetes/frakti/issues/20","number":20,"state":"open","locked":false,"title":"add list pod","user":{"login":"xlgao-zju","id":1636894,"avatar_url":"https://avatars.githubusercontent.com/u/1636894?v=3","gravatar_id":"","url":"https://api.github.com/users/xlgao-zju","html_url":"https://github.com/xlgao-zju","followers_url":"https://api.github.com/users/xlgao-zju/followers","following_url":"https://api.github.com/users/xlgao-zju/following{/other_user}","gists_url":"https://api.github.com/users/xlgao-zju/gists{/gist_id}","starred_url":"https://api.github.com/users/xlgao-zju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlgao-zju/subscriptions","organizations_url":"https://api.github.com/users/xlgao-zju/orgs","repos_url":"https://api.github.com/users/xlgao-zju/repos","events_url":"https://api.github.com/users/xlgao-zju/events{/privacy}","received_events_url":"https://api.github.com/users/xlgao-zju/received_events","type":"User","site_admin":false},"body":"A part of #8 \r\n\r\nSigned-off-by: Xianglin Gao <xlgao@zju.edu.cn>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/frakti/20)\n<!-- Reviewable:end -->\n","created_at":"2016-08-26T05:33:21Z","updated_at":"2016-08-26T06:15:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e172b60163c6c3f8f3ad238c2f3858b7aeb5735","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/frakti/pulls/20/commits","review_comments_url":"https://api.github.com/repos/kubernetes/frakti/pulls/20/comments","review_comment_url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/frakti/issues/20/comments","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/ba205f92631157ab0ef5eac146fbaee4f67bc945","head":{"label":"xlgao-zju:add-list-pod","ref":"add-list-pod","sha":"ba205f92631157ab0ef5eac146fbaee4f67bc945","user":{"login":"xlgao-zju","id":1636894,"avatar_url":"https://avatars.githubusercontent.com/u/1636894?v=3","gravatar_id":"","url":"https://api.github.com/users/xlgao-zju","html_url":"https://github.com/xlgao-zju","followers_url":"https://api.github.com/users/xlgao-zju/followers","following_url":"https://api.github.com/users/xlgao-zju/following{/other_user}","gists_url":"https://api.github.com/users/xlgao-zju/gists{/gist_id}","starred_url":"https://api.github.com/users/xlgao-zju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlgao-zju/subscriptions","organizations_url":"https://api.github.com/users/xlgao-zju/orgs","repos_url":"https://api.github.com/users/xlgao-zju/repos","events_url":"https://api.github.com/users/xlgao-zju/events{/privacy}","received_events_url":"https://api.github.com/users/xlgao-zju/received_events","type":"User","site_admin":false},"repo":{"id":65527197,"name":"frakti","full_name":"xlgao-zju/frakti","owner":{"login":"xlgao-zju","id":1636894,"avatar_url":"https://avatars.githubusercontent.com/u/1636894?v=3","gravatar_id":"","url":"https://api.github.com/users/xlgao-zju","html_url":"https://github.com/xlgao-zju","followers_url":"https://api.github.com/users/xlgao-zju/followers","following_url":"https://api.github.com/users/xlgao-zju/following{/other_user}","gists_url":"https://api.github.com/users/xlgao-zju/gists{/gist_id}","starred_url":"https://api.github.com/users/xlgao-zju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlgao-zju/subscriptions","organizations_url":"https://api.github.com/users/xlgao-zju/orgs","repos_url":"https://api.github.com/users/xlgao-zju/repos","events_url":"https://api.github.com/users/xlgao-zju/events{/privacy}","received_events_url":"https://api.github.com/users/xlgao-zju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xlgao-zju/frakti","description":null,"fork":true,"url":"https://api.github.com/repos/xlgao-zju/frakti","forks_url":"https://api.github.com/repos/xlgao-zju/frakti/forks","keys_url":"https://api.github.com/repos/xlgao-zju/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xlgao-zju/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xlgao-zju/frakti/teams","hooks_url":"https://api.github.com/repos/xlgao-zju/frakti/hooks","issue_events_url":"https://api.github.com/repos/xlgao-zju/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/xlgao-zju/frakti/events","assignees_url":"https://api.github.com/repos/xlgao-zju/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/xlgao-zju/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/xlgao-zju/frakti/tags","blobs_url":"https://api.github.com/repos/xlgao-zju/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xlgao-zju/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xlgao-zju/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/xlgao-zju/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xlgao-zju/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/xlgao-zju/frakti/languages","stargazers_url":"https://api.github.com/repos/xlgao-zju/frakti/stargazers","contributors_url":"https://api.github.com/repos/xlgao-zju/frakti/contributors","subscribers_url":"https://api.github.com/repos/xlgao-zju/frakti/subscribers","subscription_url":"https://api.github.com/repos/xlgao-zju/frakti/subscription","commits_url":"https://api.github.com/repos/xlgao-zju/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/xlgao-zju/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/xlgao-zju/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/xlgao-zju/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/xlgao-zju/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/xlgao-zju/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xlgao-zju/frakti/merges","archive_url":"https://api.github.com/repos/xlgao-zju/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xlgao-zju/frakti/downloads","issues_url":"https://api.github.com/repos/xlgao-zju/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/xlgao-zju/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/xlgao-zju/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/xlgao-zju/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xlgao-zju/frakti/labels{/name}","releases_url":"https://api.github.com/repos/xlgao-zju/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/xlgao-zju/frakti/deployments","created_at":"2016-08-12T05:56:07Z","updated_at":"2016-08-12T05:56:08Z","pushed_at":"2016-08-26T05:30:01Z","git_url":"git://github.com/xlgao-zju/frakti.git","ssh_url":"git@github.com:xlgao-zju/frakti.git","clone_url":"https://github.com/xlgao-zju/frakti.git","svn_url":"https://github.com/xlgao-zju/frakti","homepage":null,"size":645,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b6f9424074f361a9ec2276568cd607eff2a5f767","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62069434,"name":"frakti","full_name":"kubernetes/frakti","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubernetes/frakti","forks_url":"https://api.github.com/repos/kubernetes/frakti/forks","keys_url":"https://api.github.com/repos/kubernetes/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/frakti/teams","hooks_url":"https://api.github.com/repos/kubernetes/frakti/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/frakti/events","assignees_url":"https://api.github.com/repos/kubernetes/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/frakti/tags","blobs_url":"https://api.github.com/repos/kubernetes/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/frakti/languages","stargazers_url":"https://api.github.com/repos/kubernetes/frakti/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/frakti/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/frakti/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/frakti/subscription","commits_url":"https://api.github.com/repos/kubernetes/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/frakti/merges","archive_url":"https://api.github.com/repos/kubernetes/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/frakti/downloads","issues_url":"https://api.github.com/repos/kubernetes/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/frakti/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/frakti/deployments","created_at":"2016-06-27T16:04:23Z","updated_at":"2016-08-25T08:01:46Z","pushed_at":"2016-08-26T05:33:26Z","git_url":"git://github.com/kubernetes/frakti.git","ssh_url":"git@github.com:kubernetes/frakti.git","clone_url":"https://github.com/kubernetes/frakti.git","svn_url":"https://github.com/kubernetes/frakti","homepage":"","size":654,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/20"},"html":{"href":"https://github.com/kubernetes/frakti/pull/20"},"issue":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/20"},"comments":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/frakti/statuses/ba205f92631157ab0ef5eac146fbaee4f67bc945"}}}}
{"actor":{"display_login":"feiskyer"}}