{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/91704647","pull_request_review_id":12210160,"id":91704647,"diff_hunk":"@@ -69,8 +71,22 @@ public String toString()\n         }\n     };\n \n+    public enum Mode\n+    {\n+        SINGLE,\n+        HA,\n+        ARBITER,\n+        CORE,\n+        READ_REPLICA\n+    }\n+\n+    @Description( \"Configure the operating mode of the database -- 'SINGLE' for stand-alone operation, 'HA' for \" +\n+            \"operating as a member in a cluster, 'ARBITER' for an HA-only cluster member with no database, \" +\n+            \"CORE for a core member of a Causal Clustering cluster, or READ_REPLICA for read replica.\" )\n+    public static final Setting<Mode> mode = setting( \"dbms.mode\", options( Mode.class ), Mode.SINGLE.name() );","path":"enterprise/cluster/src/main/java/org/neo4j/cluster/ClusterSettings.java","position":51,"original_position":51,"commit_id":"8bb23b554fab188be69603dbb90eef31a6af15d5","original_commit_id":"8bb23b554fab188be69603dbb90eef31a6af15d5","user":{"login":"benbc","id":128750,"avatar_url":"https://avatars.githubusercontent.com/u/128750?v=3","gravatar_id":"","url":"https://api.github.com/users/benbc","html_url":"https://github.com/benbc","followers_url":"https://api.github.com/users/benbc/followers","following_url":"https://api.github.com/users/benbc/following{/other_user}","gists_url":"https://api.github.com/users/benbc/gists{/gist_id}","starred_url":"https://api.github.com/users/benbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbc/subscriptions","organizations_url":"https://api.github.com/users/benbc/orgs","repos_url":"https://api.github.com/users/benbc/repos","events_url":"https://api.github.com/users/benbc/events{/privacy}","received_events_url":"https://api.github.com/users/benbc/received_events","type":"User","site_admin":false},"body":"This seems like a strange place to define this (since it crosses HA and core-edge. Where was it before?","created_at":"2016-12-09T11:59:22Z","updated_at":"2016-12-09T12:04:18Z","html_url":"https://github.com/neo4j/neo4j/pull/8457#discussion_r91704647","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8457","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/91704647"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8457#discussion_r91704647"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8457"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/8457","id":95741380,"html_url":"https://github.com/neo4j/neo4j/pull/8457","diff_url":"https://github.com/neo4j/neo4j/pull/8457.diff","patch_url":"https://github.com/neo4j/neo4j/pull/8457.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/8457","number":8457,"state":"open","locked":false,"title":"Refactor configuration","user":{"login":"spacecowboy","id":223655,"avatar_url":"https://avatars.githubusercontent.com/u/223655?v=3","gravatar_id":"","url":"https://api.github.com/users/spacecowboy","html_url":"https://github.com/spacecowboy","followers_url":"https://api.github.com/users/spacecowboy/followers","following_url":"https://api.github.com/users/spacecowboy/following{/other_user}","gists_url":"https://api.github.com/users/spacecowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/spacecowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacecowboy/subscriptions","organizations_url":"https://api.github.com/users/spacecowboy/orgs","repos_url":"https://api.github.com/users/spacecowboy/repos","events_url":"https://api.github.com/users/spacecowboy/events{/privacy}","received_events_url":"https://api.github.com/users/spacecowboy/received_events","type":"User","site_admin":false},"body":"The primary goal of this change is to make it possible to validate a\r\nconfiguration file when it is parsed from disk. This has previously\r\nbeen impossible because the individual settings have been spread\r\nacross modules and files.\r\n\r\nSettings continue to live in separate files but the classes in which\r\nthey live are loaded via ServiceLoading. This allows the Config object\r\nto have access to all settings at runtime.\r\n\r\nTo make sure that the Config object is used a sensible way its\r\nconstructors have been made private. The only way it build a Config is\r\nvia its static factory methods. This was already the primary way of\r\nconstructing it previously.\r\n\r\nThe new structure allows for two clear entry points:\r\n\r\n* `embeddedDefaults()`\r\n* `serverDefaults()`\r\n\r\nThe names should be self-explanatory.\r\n\r\nA secondary effect was it was necessary to be able to pass a Config\r\nobject directly to the PlatformModule/GraphDatabase factories instead\r\nof doing a Config to Map conversion.\r\n\r\nConverting a Config object to a Map is still possible but no longer\r\nstraight-forward and should only be done when absolutely required. To\r\ncompensate, convenience functions have been added to allow safe and\r\nreasonable access to the raw settings. Primary intended usage remains\r\npassing a Settings object which does its own parsing.\r\n\r\nA new maven module `community/configuration` was added to allow\r\nmodules to have loadable settings without adding a dependency on\r\nKernel.\r\n","created_at":"2016-11-29T17:45:59Z","updated_at":"2016-12-09T12:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"390d33e2852e167ddc04ad102ca87f9b6b873080","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8457/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8457/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/8457/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/8bb23b554fab188be69603dbb90eef31a6af15d5","head":{"label":"spacecowboy:3.2-configstuff","ref":"3.2-configstuff","sha":"8bb23b554fab188be69603dbb90eef31a6af15d5","user":{"login":"spacecowboy","id":223655,"avatar_url":"https://avatars.githubusercontent.com/u/223655?v=3","gravatar_id":"","url":"https://api.github.com/users/spacecowboy","html_url":"https://github.com/spacecowboy","followers_url":"https://api.github.com/users/spacecowboy/followers","following_url":"https://api.github.com/users/spacecowboy/following{/other_user}","gists_url":"https://api.github.com/users/spacecowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/spacecowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacecowboy/subscriptions","organizations_url":"https://api.github.com/users/spacecowboy/orgs","repos_url":"https://api.github.com/users/spacecowboy/repos","events_url":"https://api.github.com/users/spacecowboy/events{/privacy}","received_events_url":"https://api.github.com/users/spacecowboy/received_events","type":"User","site_admin":false},"repo":{"id":42576031,"name":"neo4j","full_name":"spacecowboy/neo4j","owner":{"login":"spacecowboy","id":223655,"avatar_url":"https://avatars.githubusercontent.com/u/223655?v=3","gravatar_id":"","url":"https://api.github.com/users/spacecowboy","html_url":"https://github.com/spacecowboy","followers_url":"https://api.github.com/users/spacecowboy/followers","following_url":"https://api.github.com/users/spacecowboy/following{/other_user}","gists_url":"https://api.github.com/users/spacecowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/spacecowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacecowboy/subscriptions","organizations_url":"https://api.github.com/users/spacecowboy/orgs","repos_url":"https://api.github.com/users/spacecowboy/repos","events_url":"https://api.github.com/users/spacecowboy/events{/privacy}","received_events_url":"https://api.github.com/users/spacecowboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spacecowboy/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/spacecowboy/neo4j","forks_url":"https://api.github.com/repos/spacecowboy/neo4j/forks","keys_url":"https://api.github.com/repos/spacecowboy/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacecowboy/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacecowboy/neo4j/teams","hooks_url":"https://api.github.com/repos/spacecowboy/neo4j/hooks","issue_events_url":"https://api.github.com/repos/spacecowboy/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/spacecowboy/neo4j/events","assignees_url":"https://api.github.com/repos/spacecowboy/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/spacecowboy/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/spacecowboy/neo4j/tags","blobs_url":"https://api.github.com/repos/spacecowboy/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacecowboy/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacecowboy/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacecowboy/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacecowboy/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/spacecowboy/neo4j/languages","stargazers_url":"https://api.github.com/repos/spacecowboy/neo4j/stargazers","contributors_url":"https://api.github.com/repos/spacecowboy/neo4j/contributors","subscribers_url":"https://api.github.com/repos/spacecowboy/neo4j/subscribers","subscription_url":"https://api.github.com/repos/spacecowboy/neo4j/subscription","commits_url":"https://api.github.com/repos/spacecowboy/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacecowboy/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacecowboy/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacecowboy/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacecowboy/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/spacecowboy/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacecowboy/neo4j/merges","archive_url":"https://api.github.com/repos/spacecowboy/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacecowboy/neo4j/downloads","issues_url":"https://api.github.com/repos/spacecowboy/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/spacecowboy/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/spacecowboy/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/spacecowboy/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacecowboy/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/spacecowboy/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/spacecowboy/neo4j/deployments","created_at":"2015-09-16T08:54:13Z","updated_at":"2015-09-16T08:54:38Z","pushed_at":"2016-12-08T11:16:54Z","git_url":"git://github.com/spacecowboy/neo4j.git","ssh_url":"git@github.com:spacecowboy/neo4j.git","clone_url":"https://github.com/spacecowboy/neo4j.git","svn_url":"https://github.com/spacecowboy/neo4j","homepage":"http://neo4j.com","size":316307,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.2","ref":"3.2","sha":"78564a05562a34de9ce8e8ac109850f55584e120","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-12-08T19:33:42Z","pushed_at":"2016-12-09T11:28:01Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":388520,"stargazers_count":3271,"watchers_count":3271,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1033,"mirror_url":null,"open_issues_count":412,"forks":1033,"open_issues":412,"watchers":3271,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8457"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8457"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8457"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8457/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8457/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8457/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/8bb23b554fab188be69603dbb90eef31a6af15d5"}}}}
{"actor":{"display_login":"benbc"}}