{"action":"created","comment":{"url":"https://api.github.com/repos/quantcast/qfs/pulls/comments/59104627","id":59104627,"diff_hunk":"@@ -0,0 +1,28 @@\n+#include <gtest/gtest.h>\n+\n+#include \"common/StrUtils.h\"\n+\n+namespace KFS {\n+namespace Test {\n+\n+TEST(StrUtils_T, printf) {","path":"src/cc/tests/common/StrUtils_T.cc","position":8,"original_position":8,"commit_id":"67755db096fc2ed1456b79a923c51a1bfe836315","original_commit_id":"c0e39549b1a62b183af761cc4c830b56604feabe","user":{"login":"fsareshwala","id":212864,"avatar_url":"https://avatars.githubusercontent.com/u/212864?v=3","gravatar_id":"","url":"https://api.github.com/users/fsareshwala","html_url":"https://github.com/fsareshwala","followers_url":"https://api.github.com/users/fsareshwala/followers","following_url":"https://api.github.com/users/fsareshwala/following{/other_user}","gists_url":"https://api.github.com/users/fsareshwala/gists{/gist_id}","starred_url":"https://api.github.com/users/fsareshwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsareshwala/subscriptions","organizations_url":"https://api.github.com/users/fsareshwala/orgs","repos_url":"https://api.github.com/users/fsareshwala/repos","events_url":"https://api.github.com/users/fsareshwala/events{/privacy}","received_events_url":"https://api.github.com/users/fsareshwala/received_events","type":"User","site_admin":false},"body":"These aren't fixture tests unfortunately. I don't want to replace the suggestion in the Developer Documentation with this just yet. However, I have added a mention of checking out some of the existing tests for some examples.","created_at":"2016-04-09T00:05:24Z","updated_at":"2016-04-09T00:05:24Z","html_url":"https://github.com/quantcast/qfs/pull/118#discussion_r59104627","pull_request_url":"https://api.github.com/repos/quantcast/qfs/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/comments/59104627"},"html":{"href":"https://github.com/quantcast/qfs/pull/118#discussion_r59104627"},"pull_request":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/quantcast/qfs/pulls/118","id":65382955,"html_url":"https://github.com/quantcast/qfs/pull/118","diff_url":"https://github.com/quantcast/qfs/pull/118.diff","patch_url":"https://github.com/quantcast/qfs/pull/118.patch","issue_url":"https://api.github.com/repos/quantcast/qfs/issues/118","number":118,"state":"open","locked":false,"title":"Tests: add a proper unit testing framework to the qfs repository","user":{"login":"fsareshwala","id":212864,"avatar_url":"https://avatars.githubusercontent.com/u/212864?v=3","gravatar_id":"","url":"https://api.github.com/users/fsareshwala","html_url":"https://github.com/fsareshwala","followers_url":"https://api.github.com/users/fsareshwala/followers","following_url":"https://api.github.com/users/fsareshwala/following{/other_user}","gists_url":"https://api.github.com/users/fsareshwala/gists{/gist_id}","starred_url":"https://api.github.com/users/fsareshwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsareshwala/subscriptions","organizations_url":"https://api.github.com/users/fsareshwala/orgs","repos_url":"https://api.github.com/users/fsareshwala/repos","events_url":"https://api.github.com/users/fsareshwala/events{/privacy}","received_events_url":"https://api.github.com/users/fsareshwala/received_events","type":"User","site_admin":false},"body":"This change adds google test to the qfs source code. It updates the cmake files so that all tests are built and run under the make gtest command. This testing framework comes with proper assertions, fixtures, environments, etc. It is a much more resourceful framework than what we currently have with qftest.sh, e.g. tests are run in isolation using a syntax and API which isn't scary to developers unfamiliar with larger parts of the codebase. This change starts with adding the framework to the build system. Over the next couple of commits, we will work on migrating the qfstest.sh tests to run under the google test framework.","created_at":"2016-04-05T22:35:08Z","updated_at":"2016-04-09T00:05:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"477ab98a1daa537f71a8d0fb2ae51ac31ddd28ed","assignee":{"login":"mckurt","id":15147662,"avatar_url":"https://avatars.githubusercontent.com/u/15147662?v=3","gravatar_id":"","url":"https://api.github.com/users/mckurt","html_url":"https://github.com/mckurt","followers_url":"https://api.github.com/users/mckurt/followers","following_url":"https://api.github.com/users/mckurt/following{/other_user}","gists_url":"https://api.github.com/users/mckurt/gists{/gist_id}","starred_url":"https://api.github.com/users/mckurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckurt/subscriptions","organizations_url":"https://api.github.com/users/mckurt/orgs","repos_url":"https://api.github.com/users/mckurt/repos","events_url":"https://api.github.com/users/mckurt/events{/privacy}","received_events_url":"https://api.github.com/users/mckurt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/quantcast/qfs/pulls/118/commits","review_comments_url":"https://api.github.com/repos/quantcast/qfs/pulls/118/comments","review_comment_url":"https://api.github.com/repos/quantcast/qfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantcast/qfs/issues/118/comments","statuses_url":"https://api.github.com/repos/quantcast/qfs/statuses/67755db096fc2ed1456b79a923c51a1bfe836315","head":{"label":"fsareshwala:master","ref":"master","sha":"67755db096fc2ed1456b79a923c51a1bfe836315","user":{"login":"fsareshwala","id":212864,"avatar_url":"https://avatars.githubusercontent.com/u/212864?v=3","gravatar_id":"","url":"https://api.github.com/users/fsareshwala","html_url":"https://github.com/fsareshwala","followers_url":"https://api.github.com/users/fsareshwala/followers","following_url":"https://api.github.com/users/fsareshwala/following{/other_user}","gists_url":"https://api.github.com/users/fsareshwala/gists{/gist_id}","starred_url":"https://api.github.com/users/fsareshwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsareshwala/subscriptions","organizations_url":"https://api.github.com/users/fsareshwala/orgs","repos_url":"https://api.github.com/users/fsareshwala/repos","events_url":"https://api.github.com/users/fsareshwala/events{/privacy}","received_events_url":"https://api.github.com/users/fsareshwala/received_events","type":"User","site_admin":false},"repo":{"id":54413125,"name":"qfs","full_name":"fsareshwala/qfs","owner":{"login":"fsareshwala","id":212864,"avatar_url":"https://avatars.githubusercontent.com/u/212864?v=3","gravatar_id":"","url":"https://api.github.com/users/fsareshwala","html_url":"https://github.com/fsareshwala","followers_url":"https://api.github.com/users/fsareshwala/followers","following_url":"https://api.github.com/users/fsareshwala/following{/other_user}","gists_url":"https://api.github.com/users/fsareshwala/gists{/gist_id}","starred_url":"https://api.github.com/users/fsareshwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsareshwala/subscriptions","organizations_url":"https://api.github.com/users/fsareshwala/orgs","repos_url":"https://api.github.com/users/fsareshwala/repos","events_url":"https://api.github.com/users/fsareshwala/events{/privacy}","received_events_url":"https://api.github.com/users/fsareshwala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fsareshwala/qfs","description":"Quantcast File System","fork":true,"url":"https://api.github.com/repos/fsareshwala/qfs","forks_url":"https://api.github.com/repos/fsareshwala/qfs/forks","keys_url":"https://api.github.com/repos/fsareshwala/qfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsareshwala/qfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsareshwala/qfs/teams","hooks_url":"https://api.github.com/repos/fsareshwala/qfs/hooks","issue_events_url":"https://api.github.com/repos/fsareshwala/qfs/issues/events{/number}","events_url":"https://api.github.com/repos/fsareshwala/qfs/events","assignees_url":"https://api.github.com/repos/fsareshwala/qfs/assignees{/user}","branches_url":"https://api.github.com/repos/fsareshwala/qfs/branches{/branch}","tags_url":"https://api.github.com/repos/fsareshwala/qfs/tags","blobs_url":"https://api.github.com/repos/fsareshwala/qfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsareshwala/qfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsareshwala/qfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsareshwala/qfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsareshwala/qfs/statuses/{sha}","languages_url":"https://api.github.com/repos/fsareshwala/qfs/languages","stargazers_url":"https://api.github.com/repos/fsareshwala/qfs/stargazers","contributors_url":"https://api.github.com/repos/fsareshwala/qfs/contributors","subscribers_url":"https://api.github.com/repos/fsareshwala/qfs/subscribers","subscription_url":"https://api.github.com/repos/fsareshwala/qfs/subscription","commits_url":"https://api.github.com/repos/fsareshwala/qfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsareshwala/qfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsareshwala/qfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsareshwala/qfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsareshwala/qfs/contents/{+path}","compare_url":"https://api.github.com/repos/fsareshwala/qfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsareshwala/qfs/merges","archive_url":"https://api.github.com/repos/fsareshwala/qfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsareshwala/qfs/downloads","issues_url":"https://api.github.com/repos/fsareshwala/qfs/issues{/number}","pulls_url":"https://api.github.com/repos/fsareshwala/qfs/pulls{/number}","milestones_url":"https://api.github.com/repos/fsareshwala/qfs/milestones{/number}","notifications_url":"https://api.github.com/repos/fsareshwala/qfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsareshwala/qfs/labels{/name}","releases_url":"https://api.github.com/repos/fsareshwala/qfs/releases{/id}","deployments_url":"https://api.github.com/repos/fsareshwala/qfs/deployments","created_at":"2016-03-21T18:30:47Z","updated_at":"2016-03-21T18:30:50Z","pushed_at":"2016-04-08T23:27:39Z","git_url":"git://github.com/fsareshwala/qfs.git","ssh_url":"git@github.com:fsareshwala/qfs.git","clone_url":"https://github.com/fsareshwala/qfs.git","svn_url":"https://github.com/fsareshwala/qfs","homepage":"","size":18259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quantcast:master","ref":"master","sha":"d7ff1ba0fa608611045c3aae1607258e920ec83b","user":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"repo":{"id":5447814,"name":"qfs","full_name":"quantcast/qfs","owner":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantcast/qfs","description":"Quantcast File System","fork":false,"url":"https://api.github.com/repos/quantcast/qfs","forks_url":"https://api.github.com/repos/quantcast/qfs/forks","keys_url":"https://api.github.com/repos/quantcast/qfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantcast/qfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantcast/qfs/teams","hooks_url":"https://api.github.com/repos/quantcast/qfs/hooks","issue_events_url":"https://api.github.com/repos/quantcast/qfs/issues/events{/number}","events_url":"https://api.github.com/repos/quantcast/qfs/events","assignees_url":"https://api.github.com/repos/quantcast/qfs/assignees{/user}","branches_url":"https://api.github.com/repos/quantcast/qfs/branches{/branch}","tags_url":"https://api.github.com/repos/quantcast/qfs/tags","blobs_url":"https://api.github.com/repos/quantcast/qfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantcast/qfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantcast/qfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantcast/qfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantcast/qfs/statuses/{sha}","languages_url":"https://api.github.com/repos/quantcast/qfs/languages","stargazers_url":"https://api.github.com/repos/quantcast/qfs/stargazers","contributors_url":"https://api.github.com/repos/quantcast/qfs/contributors","subscribers_url":"https://api.github.com/repos/quantcast/qfs/subscribers","subscription_url":"https://api.github.com/repos/quantcast/qfs/subscription","commits_url":"https://api.github.com/repos/quantcast/qfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantcast/qfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantcast/qfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantcast/qfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantcast/qfs/contents/{+path}","compare_url":"https://api.github.com/repos/quantcast/qfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantcast/qfs/merges","archive_url":"https://api.github.com/repos/quantcast/qfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantcast/qfs/downloads","issues_url":"https://api.github.com/repos/quantcast/qfs/issues{/number}","pulls_url":"https://api.github.com/repos/quantcast/qfs/pulls{/number}","milestones_url":"https://api.github.com/repos/quantcast/qfs/milestones{/number}","notifications_url":"https://api.github.com/repos/quantcast/qfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantcast/qfs/labels{/name}","releases_url":"https://api.github.com/repos/quantcast/qfs/releases{/id}","deployments_url":"https://api.github.com/repos/quantcast/qfs/deployments","created_at":"2012-08-17T03:59:37Z","updated_at":"2016-04-07T04:40:55Z","pushed_at":"2016-04-08T23:27:39Z","git_url":"git://github.com/quantcast/qfs.git","ssh_url":"git@github.com:quantcast/qfs.git","clone_url":"https://github.com/quantcast/qfs.git","svn_url":"https://github.com/quantcast/qfs","homepage":"https://quantcast.atlassian.net","size":18833,"stargazers_count":433,"watchers_count":433,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":118,"mirror_url":null,"open_issues_count":5,"forks":118,"open_issues":5,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/118"},"html":{"href":"https://github.com/quantcast/qfs/pull/118"},"issue":{"href":"https://api.github.com/repos/quantcast/qfs/issues/118"},"comments":{"href":"https://api.github.com/repos/quantcast/qfs/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/quantcast/qfs/statuses/67755db096fc2ed1456b79a923c51a1bfe836315"}}}}