{"action":"created","issue":{"url":"https://api.github.com/repos/scala/scala/issues/5246","repository_url":"https://api.github.com/repos/scala/scala","labels_url":"https://api.github.com/repos/scala/scala/issues/5246/labels{/name}","comments_url":"https://api.github.com/repos/scala/scala/issues/5246/comments","events_url":"https://api.github.com/repos/scala/scala/issues/5246/events","html_url":"https://github.com/scala/scala/pull/5246","id":162242781,"number":5246,"title":"SI-4826 Retain javadoc comments in scaladoc [ci: last-only]","user":{"login":"jodersky","id":1007012,"avatar_url":"https://avatars.githubusercontent.com/u/1007012?v=3","gravatar_id":"","url":"https://api.github.com/users/jodersky","html_url":"https://github.com/jodersky","followers_url":"https://api.github.com/users/jodersky/followers","following_url":"https://api.github.com/users/jodersky/following{/other_user}","gists_url":"https://api.github.com/users/jodersky/gists{/gist_id}","starred_url":"https://api.github.com/users/jodersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodersky/subscriptions","organizations_url":"https://api.github.com/users/jodersky/orgs","repos_url":"https://api.github.com/users/jodersky/repos","events_url":"https://api.github.com/users/jodersky/events{/privacy}","received_events_url":"https://api.github.com/users/jodersky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scala/scala/labels/reviewed","name":"reviewed","color":"02e10c"},{"url":"https://api.github.com/repos/scala/scala/labels/welcome","name":"welcome","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/47","html_url":"https://github.com/scala/scala/milestones/2.12.0-RC1","labels_url":"https://api.github.com/repos/scala/scala/milestones/47/labels","id":977200,"number":47,"title":"2.12.0-RC1","description":"The RC cycle is strictly reserved for bug fixes that we *cannot do after 2.12.0*. The 2.12.0 branch is for changes to bytecode generation, erasure, type inference or binary compatibility. The RC1 queue will close on July 19, and we'll release as soon as the all PRs have been reviewed and merged. [Discussion](https://groups.google.com/d/msg/scala-internals/hxDjZfm1h3c/Y5OkHdatAAAJ)\r\n\r\nWe will merge 2.12.0 into the 2.12.x branch, so that 2.12.1 development can continue during the RC cycle.\r\n\r\nLead: @adriaanm\r\n\r\nMerge to 2.12.0.","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":30,"state":"open","created_at":"2015-02-12T17:53:06Z","updated_at":"2016-07-22T00:16:19Z","due_on":"2016-07-19T07:00:00Z","closed_at":null},"comments":21,"created_at":"2016-06-24T22:32:38Z","updated_at":"2016-07-22T01:32:43Z","closed_at":"2016-07-18T21:41:55Z","pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/5246","html_url":"https://github.com/scala/scala/pull/5246","diff_url":"https://github.com/scala/scala/pull/5246.diff","patch_url":"https://github.com/scala/scala/pull/5246.patch"},"body":"Double-star comments in java sources currently do not show up in scaladoc output, although their related classes and members do. This is an inconvenience for multi-language projects (talking about Spark specifically).\r\n\r\nThe changes in this PR retain documentation comments in java sources and include them in scaladoc.\r\nTo achieve this, the following parts of the compiler are modified:\r\n\r\n- java lexer and parser: overridable methods are added to allow scaladoc to consume java doc comments. These changes were greatly inspired by the existing way scaladoc hooks into the scala parser.\r\n- namer and typer: ignore certain checks to validate ASTs generated by the java parser. The main reason for these changes is that scaladoc requires symbols to be assigned to java members, and the easiest way to achieve that is by using the existing namer and typer. If this solution is too hacky, an alternative would be to add an extra traversal (or even phase?) to java ASTs that does symbol assignment solely for java.\r\n\r\nI know that I'm quite late to the 2.12 party, however since these changes are quite marginal and mostly affect scaladoc, I based this PR on the 2.12.x branch.\r\n\r\ncc @VladUreche "},"comment":{"url":"https://api.github.com/repos/scala/scala/issues/comments/234431863","html_url":"https://github.com/scala/scala/pull/5246#issuecomment-234431863","issue_url":"https://api.github.com/repos/scala/scala/issues/5246","id":234431863,"user":{"login":"jodersky","id":1007012,"avatar_url":"https://avatars.githubusercontent.com/u/1007012?v=3","gravatar_id":"","url":"https://api.github.com/users/jodersky","html_url":"https://github.com/jodersky","followers_url":"https://api.github.com/users/jodersky/followers","following_url":"https://api.github.com/users/jodersky/following{/other_user}","gists_url":"https://api.github.com/users/jodersky/gists{/gist_id}","starred_url":"https://api.github.com/users/jodersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodersky/subscriptions","organizations_url":"https://api.github.com/users/jodersky/orgs","repos_url":"https://api.github.com/users/jodersky/repos","events_url":"https://api.github.com/users/jodersky/events{/privacy}","received_events_url":"https://api.github.com/users/jodersky/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T01:32:43Z","updated_at":"2016-07-22T01:32:43Z","body":"@adriaanm , have you tested this? I'm getting typer assertion errors now when compiling Akka. It could be however that I have a messed up build (I'm spoofing my locally published scala SNAPSHOT as M5 to workaround dependencies in Akka)"}}
{"actor":{"display_login":"jodersky"}}