{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/59","repository_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/59/comments","events_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/59/events","html_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/59","id":169368204,"number":59,"title":".NET core support!","user":{"login":"Mpdreamz","id":245275,"avatar_url":"https://avatars.githubusercontent.com/u/245275?v=3","gravatar_id":"","url":"https://api.github.com/users/Mpdreamz","html_url":"https://github.com/Mpdreamz","followers_url":"https://api.github.com/users/Mpdreamz/followers","following_url":"https://api.github.com/users/Mpdreamz/following{/other_user}","gists_url":"https://api.github.com/users/Mpdreamz/gists{/gist_id}","starred_url":"https://api.github.com/users/Mpdreamz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mpdreamz/subscriptions","organizations_url":"https://api.github.com/users/Mpdreamz/orgs","repos_url":"https://api.github.com/users/Mpdreamz/repos","events_url":"https://api.github.com/users/Mpdreamz/events{/privacy}","received_events_url":"https://api.github.com/users/Mpdreamz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-04T12:59:38Z","updated_at":"2016-08-05T10:06:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/59","html_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/59","diff_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/59.diff","patch_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/59.patch"},"body":"Lotsa changes, #21  was still super useful as a reference here (thank you @alexvaluyskiy!)\r\n\r\nAlso moved the test project over to dotnetcore and xunit, nunit has a dotnet runner but it was throwing hard exceptions and only testing one framework. The xunit dotnet runner tests both full desktop clr as well as netstandard1.3 (core clr). \r\n\r\nFixed tests due to 2.0 changes, the first emit() now always sends directly irregardless of `BatchPostingLimit` or period. The different timer implementations also do not guarantee that this first emit() will only send one document over. \r\n\r\nSuper helpful to have @nblumhardt and @merbla in person at NDC to help out :D cheers guys!\r\n\r\n@mivano I ported over the powershell build script as far as I could as I'm not sure how you do releasing and appveyor so this needs another pass over to suit your deployment model. \r\n\r\nIt builds and tests.  It also packs nuget packages in the same location but please double check the dlls have the correct version applied, the nuget metadata is valid. same nuget id with casing, are the dlls signed as we expect them too?\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/comments/237813328","html_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/59#issuecomment-237813328","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/59","id":237813328,"user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T10:06:04Z","updated_at":"2016-08-05T10:06:04Z","body":"LGTM! :+1: Added some very minor notes.\r\n\r\nNot related directly to the PR, but what do you think about making `dev` the default branch in this repository? We've switched from `master` to `dev` in most/all of the other repos so that new work is always visible (makes liveness obvious) and so that new PRs will target it by default. Just a thought."}}
{"actor":{"display_login":"nblumhardt"}}