{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/1725","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/1725/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/1725/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/1725/events","html_url":"https://github.com/oppia/oppia/pull/1725","id":147789090,"number":1725,"title":"Fix #1285: create new About / Teach pages","user":{"login":"charisseysabel","id":11045720,"avatar_url":"https://avatars.githubusercontent.com/u/11045720?v=3","gravatar_id":"","url":"https://api.github.com/users/charisseysabel","html_url":"https://github.com/charisseysabel","followers_url":"https://api.github.com/users/charisseysabel/followers","following_url":"https://api.github.com/users/charisseysabel/following{/other_user}","gists_url":"https://api.github.com/users/charisseysabel/gists{/gist_id}","starred_url":"https://api.github.com/users/charisseysabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charisseysabel/subscriptions","organizations_url":"https://api.github.com/users/charisseysabel/orgs","repos_url":"https://api.github.com/users/charisseysabel/repos","events_url":"https://api.github.com/users/charisseysabel/events{/privacy}","received_events_url":"https://api.github.com/users/charisseysabel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oppia/oppia/labels/IN%20REVIEW%20-%20don't%20merge","name":"IN REVIEW - don't merge","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"milestone":null,"comments":24,"created_at":"2016-04-12T15:34:36Z","updated_at":"2016-05-26T19:45:25Z","closed_at":"2016-05-26T19:45:25Z","pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/1725","html_url":"https://github.com/oppia/oppia/pull/1725","diff_url":"https://github.com/oppia/oppia/pull/1725.diff","patch_url":"https://github.com/oppia/oppia/pull/1725.patch"},"body":"Following the feedback I got from #1673. (Sorry I missed the last release; but the server issue has been fixed so I should be good)\r\n\r\n- The pages now match the current theme. I tried to reuse as much existing css code as I could. (Will we ever make a style guide?)\r\n- I copy/pasted the links that were used in the current About pages. I'm not sure if it the links would work. For example, if I click on the forum link, I am redirected to the address `https://site/forum/url` but it says it cannot be reached.\r\n- I modified `main.py` and `pages.py` to insert the teach page but I get a 404 error when I go to `localhost:8181/teach`. I couldn't view it properly to address if there are other issues to fix.\r\n- The otter is still not in the right position :(\r\n- I noticed that there is a top margin at the footer (screenshot below) and its even bigger on mobile. Since this is necessary on other pages that require a footer, is there a way to solve this?\r\n![footer-gap](https://cloud.githubusercontent.com/assets/11045720/14465409/2f28559c-00d3-11e6-88fb-172bb7a467c6.png)\r\n"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/221974164","html_url":"https://github.com/oppia/oppia/pull/1725#issuecomment-221974164","issue_url":"https://api.github.com/repos/oppia/oppia/issues/1725","id":221974164,"user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T19:45:25Z","updated_at":"2016-05-26T19:45:25Z","body":"Yep, something went wrong. I think it may have been related to a line endings issue; I just did a PR at #1892 that hopefully fixes it. So, closing this one, since it's superseded by #1892.\r\n\r\nAlso, I'll try and review this tonight. Thanks!"}}
{"actor":{"display_login":"seanlip"}}