{"action":"created","issue":{"url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/5","repository_url":"https://api.github.com/repos/RedisLabsModules/countminsketch","labels_url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/5/comments","events_url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/5/events","html_url":"https://github.com/RedisLabsModules/countminsketch/pull/5","id":159770734,"number":5,"title":"Use a fixed seed","user":{"login":"yusaku","id":995783,"avatar_url":"https://avatars.githubusercontent.com/u/995783?v=3","gravatar_id":"","url":"https://api.github.com/users/yusaku","html_url":"https://github.com/yusaku","followers_url":"https://api.github.com/users/yusaku/followers","following_url":"https://api.github.com/users/yusaku/following{/other_user}","gists_url":"https://api.github.com/users/yusaku/gists{/gist_id}","starred_url":"https://api.github.com/users/yusaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yusaku/subscriptions","organizations_url":"https://api.github.com/users/yusaku/orgs","repos_url":"https://api.github.com/users/yusaku/repos","events_url":"https://api.github.com/users/yusaku/events{/privacy}","received_events_url":"https://api.github.com/users/yusaku/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-11T12:10:53Z","updated_at":"2016-06-11T14:17:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RedisLabsModules/countminsketch/pulls/5","html_url":"https://github.com/RedisLabsModules/countminsketch/pull/5","diff_url":"https://github.com/RedisLabsModules/countminsketch/pull/5.diff","patch_url":"https://github.com/RedisLabsModules/countminsketch/pull/5.patch"},"body":"This PR proposes to fix a seed to make coefficients consistent for every sketch.\r\n\r\nFor now, there is no way to create sketches that share the same coefficients. That is needed to implement binary operations like addition/subtraction on sketches.\r\n\r\nIt might be acceptable to fix a seed since Redis itself constantly uses a fixed seed for its HLL data type, and unlike hash tables, the choice of the seed does not affect the time complexity of any operations."},"comment":{"url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/comments/225364929","html_url":"https://github.com/RedisLabsModules/countminsketch/pull/5#issuecomment-225364929","issue_url":"https://api.github.com/repos/RedisLabsModules/countminsketch/issues/5","id":225364929,"user":{"login":"itamarhaber","id":6059516,"avatar_url":"https://avatars.githubusercontent.com/u/6059516?v=3","gravatar_id":"","url":"https://api.github.com/users/itamarhaber","html_url":"https://github.com/itamarhaber","followers_url":"https://api.github.com/users/itamarhaber/followers","following_url":"https://api.github.com/users/itamarhaber/following{/other_user}","gists_url":"https://api.github.com/users/itamarhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/itamarhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itamarhaber/subscriptions","organizations_url":"https://api.github.com/users/itamarhaber/orgs","repos_url":"https://api.github.com/users/itamarhaber/repos","events_url":"https://api.github.com/users/itamarhaber/events{/privacy}","received_events_url":"https://api.github.com/users/itamarhaber/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T14:17:29Z","updated_at":"2016-06-11T14:17:29Z","body":"Thanks - I've been meaning to do as when I get to completing this module and adding the merge operation. Please also remove the definition of `ustime` and its copyright and I'll merge this."}}
{"actor":{"display_login":"itamarhaber"}}