{"action":"created","comment":{"url":"https://api.github.com/repos/GitTools/GitLink/pulls/comments/89159538","pull_request_review_id":9707300,"id":89159538,"diff_hunk":"@@ -33,74 +33,80 @@ public static void Link(string pdbPath, LinkOptions options = default(LinkOption\n         {\n             Argument.IsNotNullOrEmpty(() => pdbPath);\n \n-            var pdb = new PdbFile(pdbPath);\n-            var filesAndChecksums = pdb.GetFiles();\n-            var sourceFiles = filesAndChecksums.Select(f => f.Item1);\n-\n-            string repositoryDirectory = GitDirFinder.TreeWalkForGitDir(Path.GetDirectoryName(sourceFiles.First()));\n-            using (var repository = new Repository(repositoryDirectory))\n+            var projectSrcSrvFile = pdbPath + \".srcsrv\";\n+            string repositoryDirectory;\n+            using (var pdb = new PdbFile(pdbPath))\n             {\n-                var providerManager = new Providers.ProviderManager();\n-                Providers.IProvider provider;\n-                if (options.GitRemoteUrl == null)\n-                {\n-                    var candidateProviders = from remote in repository.Network.Remotes\n-                                             let p = providerManager.GetProvider(remote.Url)\n-                                             where p != null\n-                                             select p;\n-                    provider = candidateProviders.First();\n-                }\n-                else\n-                {\n-                    provider = providerManager.GetProvider(options.GitRemoteUrl.AbsoluteUri);\n-                }\n-\n-                var projectSrcSrvFile = pdbPath + \".srcsrv\";\n+                var sourceFiles = pdb.GetFiles().Select(f => f.Item1).ToList();\n \n-                if (!options.SkipVerify)\n+                repositoryDirectory = GitDirFinder.TreeWalkForGitDir(Path.GetDirectoryName(sourceFiles.First()));\n+                using (var repository = new Repository(repositoryDirectory))\n                 {\n-                    Log.Info(\"Verifying pdb file\");\n+                    var repoSourceFiles = sourceFiles.ToDictionary(e => e, repository.GetRepoNormalizedPath);\n \n-                    var missingFiles = pdb.FindMissingOrChangedSourceFiles();\n-                    foreach (var missingFile in missingFiles)\n+                    var providerManager = new Providers.ProviderManager();\n+                    Providers.IProvider provider;\n+                    if (options.GitRemoteUrl == null)\n                     {\n-                        Log.Warning($\"File \\\"{missingFile}\\\" missing or changed since the PDB was compiled.\");\n+                        var candidateProviders = from remote in repository.Network.Remotes\n+                                                 let p = providerManager.GetProvider(remote.Url)\n+                                                 where p != null\n+                                                 select p;\n+                        provider = candidateProviders.First();","path":"src/GitLink/Linker.cs","position":50,"original_position":50,"commit_id":"72d6154a8df51dd6997d4f02c09ee683f8f7ed90","original_commit_id":"72d6154a8df51dd6997d4f02c09ee683f8f7ed90","user":{"login":"GeertvanHorrik","id":1246444,"avatar_url":"https://avatars.githubusercontent.com/u/1246444?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertvanHorrik","html_url":"https://github.com/GeertvanHorrik","followers_url":"https://api.github.com/users/GeertvanHorrik/followers","following_url":"https://api.github.com/users/GeertvanHorrik/following{/other_user}","gists_url":"https://api.github.com/users/GeertvanHorrik/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertvanHorrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertvanHorrik/subscriptions","organizations_url":"https://api.github.com/users/GeertvanHorrik/orgs","repos_url":"https://api.github.com/users/GeertvanHorrik/repos","events_url":"https://api.github.com/users/GeertvanHorrik/events{/privacy}","received_events_url":"https://api.github.com/users/GeertvanHorrik/received_events","type":"User","site_admin":false},"body":"Do we want to crash here or log an error so the user actually knows what is crashing this? I prefer the latter.","created_at":"2016-11-22T16:49:31Z","updated_at":"2016-11-22T16:51:31Z","html_url":"https://github.com/GitTools/GitLink/pull/120#discussion_r89159538","pull_request_url":"https://api.github.com/repos/GitTools/GitLink/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/comments/89159538"},"html":{"href":"https://github.com/GitTools/GitLink/pull/120#discussion_r89159538"},"pull_request":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/GitTools/GitLink/pulls/120","id":94844889,"html_url":"https://github.com/GitTools/GitLink/pull/120","diff_url":"https://github.com/GitTools/GitLink/pull/120.diff","patch_url":"https://github.com/GitTools/GitLink/pull/120.patch","issue_url":"https://api.github.com/repos/GitTools/GitLink/issues/120","number":120,"state":"open","locked":false,"title":"Starting to stabilize and fix issues","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"body":"Important changes:\r\n* Normalize path capitalization per git index (fixes issues I've seen filed against gitlink)\r\n* Forward errors from pdbstr.exe to logger (a bug I found pre-existed in GitLink, but never filed)\r\n* Fix pdb locking issue\r\n\r\nextras:\r\n* Fix build integration\r\n* Rename GitLink task from LinkProject\r\n* Skip exceptions for missing files\r\n* Removed tests for removed code","created_at":"2016-11-22T16:11:02Z","updated_at":"2016-11-22T16:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42d6d912f038dc07a3d8b4a7229485d631eb607e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GitTools/GitLink/pulls/120/commits","review_comments_url":"https://api.github.com/repos/GitTools/GitLink/pulls/120/comments","review_comment_url":"https://api.github.com/repos/GitTools/GitLink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GitTools/GitLink/issues/120/comments","statuses_url":"https://api.github.com/repos/GitTools/GitLink/statuses/72d6154a8df51dd6997d4f02c09ee683f8f7ed90","head":{"label":"AArnott:develop4","ref":"develop4","sha":"72d6154a8df51dd6997d4f02c09ee683f8f7ed90","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"repo":{"id":70203743,"name":"PdbGit","full_name":"AArnott/PdbGit","owner":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AArnott/PdbGit","description":"Making .NET open source accessible!","fork":true,"url":"https://api.github.com/repos/AArnott/PdbGit","forks_url":"https://api.github.com/repos/AArnott/PdbGit/forks","keys_url":"https://api.github.com/repos/AArnott/PdbGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AArnott/PdbGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AArnott/PdbGit/teams","hooks_url":"https://api.github.com/repos/AArnott/PdbGit/hooks","issue_events_url":"https://api.github.com/repos/AArnott/PdbGit/issues/events{/number}","events_url":"https://api.github.com/repos/AArnott/PdbGit/events","assignees_url":"https://api.github.com/repos/AArnott/PdbGit/assignees{/user}","branches_url":"https://api.github.com/repos/AArnott/PdbGit/branches{/branch}","tags_url":"https://api.github.com/repos/AArnott/PdbGit/tags","blobs_url":"https://api.github.com/repos/AArnott/PdbGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AArnott/PdbGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AArnott/PdbGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/AArnott/PdbGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AArnott/PdbGit/statuses/{sha}","languages_url":"https://api.github.com/repos/AArnott/PdbGit/languages","stargazers_url":"https://api.github.com/repos/AArnott/PdbGit/stargazers","contributors_url":"https://api.github.com/repos/AArnott/PdbGit/contributors","subscribers_url":"https://api.github.com/repos/AArnott/PdbGit/subscribers","subscription_url":"https://api.github.com/repos/AArnott/PdbGit/subscription","commits_url":"https://api.github.com/repos/AArnott/PdbGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/AArnott/PdbGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/AArnott/PdbGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/AArnott/PdbGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/AArnott/PdbGit/contents/{+path}","compare_url":"https://api.github.com/repos/AArnott/PdbGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AArnott/PdbGit/merges","archive_url":"https://api.github.com/repos/AArnott/PdbGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AArnott/PdbGit/downloads","issues_url":"https://api.github.com/repos/AArnott/PdbGit/issues{/number}","pulls_url":"https://api.github.com/repos/AArnott/PdbGit/pulls{/number}","milestones_url":"https://api.github.com/repos/AArnott/PdbGit/milestones{/number}","notifications_url":"https://api.github.com/repos/AArnott/PdbGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AArnott/PdbGit/labels{/name}","releases_url":"https://api.github.com/repos/AArnott/PdbGit/releases{/id}","deployments_url":"https://api.github.com/repos/AArnott/PdbGit/deployments","created_at":"2016-10-07T00:31:08Z","updated_at":"2016-11-22T08:57:53Z","pushed_at":"2016-11-22T16:03:01Z","git_url":"git://github.com/AArnott/PdbGit.git","ssh_url":"git@github.com:AArnott/PdbGit.git","clone_url":"https://github.com/AArnott/PdbGit.git","svn_url":"https://github.com/AArnott/PdbGit","homepage":"","size":8584,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"GitTools:pr/110-in-batches","ref":"pr/110-in-batches","sha":"7f5b12c2d00b27898f03109fd64329bf79c8f52e","user":{"login":"GitTools","id":11839771,"avatar_url":"https://avatars.githubusercontent.com/u/11839771?v=3","gravatar_id":"","url":"https://api.github.com/users/GitTools","html_url":"https://github.com/GitTools","followers_url":"https://api.github.com/users/GitTools/followers","following_url":"https://api.github.com/users/GitTools/following{/other_user}","gists_url":"https://api.github.com/users/GitTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GitTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitTools/subscriptions","organizations_url":"https://api.github.com/users/GitTools/orgs","repos_url":"https://api.github.com/users/GitTools/repos","events_url":"https://api.github.com/users/GitTools/events{/privacy}","received_events_url":"https://api.github.com/users/GitTools/received_events","type":"Organization","site_admin":false},"repo":{"id":18791236,"name":"GitLink","full_name":"GitTools/GitLink","owner":{"login":"GitTools","id":11839771,"avatar_url":"https://avatars.githubusercontent.com/u/11839771?v=3","gravatar_id":"","url":"https://api.github.com/users/GitTools","html_url":"https://github.com/GitTools","followers_url":"https://api.github.com/users/GitTools/followers","following_url":"https://api.github.com/users/GitTools/following{/other_user}","gists_url":"https://api.github.com/users/GitTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GitTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitTools/subscriptions","organizations_url":"https://api.github.com/users/GitTools/orgs","repos_url":"https://api.github.com/users/GitTools/repos","events_url":"https://api.github.com/users/GitTools/events{/privacy}","received_events_url":"https://api.github.com/users/GitTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GitTools/GitLink","description":"Making .NET open source accessible!","fork":false,"url":"https://api.github.com/repos/GitTools/GitLink","forks_url":"https://api.github.com/repos/GitTools/GitLink/forks","keys_url":"https://api.github.com/repos/GitTools/GitLink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GitTools/GitLink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GitTools/GitLink/teams","hooks_url":"https://api.github.com/repos/GitTools/GitLink/hooks","issue_events_url":"https://api.github.com/repos/GitTools/GitLink/issues/events{/number}","events_url":"https://api.github.com/repos/GitTools/GitLink/events","assignees_url":"https://api.github.com/repos/GitTools/GitLink/assignees{/user}","branches_url":"https://api.github.com/repos/GitTools/GitLink/branches{/branch}","tags_url":"https://api.github.com/repos/GitTools/GitLink/tags","blobs_url":"https://api.github.com/repos/GitTools/GitLink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GitTools/GitLink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GitTools/GitLink/git/refs{/sha}","trees_url":"https://api.github.com/repos/GitTools/GitLink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GitTools/GitLink/statuses/{sha}","languages_url":"https://api.github.com/repos/GitTools/GitLink/languages","stargazers_url":"https://api.github.com/repos/GitTools/GitLink/stargazers","contributors_url":"https://api.github.com/repos/GitTools/GitLink/contributors","subscribers_url":"https://api.github.com/repos/GitTools/GitLink/subscribers","subscription_url":"https://api.github.com/repos/GitTools/GitLink/subscription","commits_url":"https://api.github.com/repos/GitTools/GitLink/commits{/sha}","git_commits_url":"https://api.github.com/repos/GitTools/GitLink/git/commits{/sha}","comments_url":"https://api.github.com/repos/GitTools/GitLink/comments{/number}","issue_comment_url":"https://api.github.com/repos/GitTools/GitLink/issues/comments{/number}","contents_url":"https://api.github.com/repos/GitTools/GitLink/contents/{+path}","compare_url":"https://api.github.com/repos/GitTools/GitLink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GitTools/GitLink/merges","archive_url":"https://api.github.com/repos/GitTools/GitLink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GitTools/GitLink/downloads","issues_url":"https://api.github.com/repos/GitTools/GitLink/issues{/number}","pulls_url":"https://api.github.com/repos/GitTools/GitLink/pulls{/number}","milestones_url":"https://api.github.com/repos/GitTools/GitLink/milestones{/number}","notifications_url":"https://api.github.com/repos/GitTools/GitLink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GitTools/GitLink/labels{/name}","releases_url":"https://api.github.com/repos/GitTools/GitLink/releases{/id}","deployments_url":"https://api.github.com/repos/GitTools/GitLink/deployments","created_at":"2014-04-15T07:29:39Z","updated_at":"2016-11-21T20:27:13Z","pushed_at":"2016-11-22T16:11:03Z","git_url":"git://github.com/GitTools/GitLink.git","ssh_url":"git@github.com:GitTools/GitLink.git","clone_url":"https://github.com/GitTools/GitLink.git","svn_url":"https://github.com/GitTools/GitLink","homepage":"","size":8547,"stargazers_count":293,"watchers_count":293,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":32,"forks":42,"open_issues":32,"watchers":293,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/120"},"html":{"href":"https://github.com/GitTools/GitLink/pull/120"},"issue":{"href":"https://api.github.com/repos/GitTools/GitLink/issues/120"},"comments":{"href":"https://api.github.com/repos/GitTools/GitLink/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GitTools/GitLink/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/GitTools/GitLink/statuses/72d6154a8df51dd6997d4f02c09ee683f8f7ed90"}}}}
{"actor":{"display_login":"GeertvanHorrik"}}