{"action":"created","comment":{"url":"https://api.github.com/repos/NLog/NLog/pulls/comments/49283181","id":49283181,"diff_hunk":"@@ -263,14 +263,15 @@ protected override string GetFormattedMessage(LogEventInfo logEvent)\n                 }\n                 catch (Exception exception)\n                 {\n-                    if (exception.MustBeRethrown())\n+                    //also check IsErrorEnabled, otherwise 'MustBeRethrown' writes it to Error\n+                    if (InternalLogger.IsWarnEnabled || InternalLogger.IsErrorEnabled)\n                     {\n-                        throw;\n+                        InternalLogger.Warn(exception, \"Exception in Append(): {0}.\", renderer.GetType().FullName);","path":"src/NLog/Layouts/SimpleLayout.cs","position":9,"original_position":9,"commit_id":"8bb1d9a7b6593a79228b522aa5f9effec4474b8e","original_commit_id":"8bb1d9a7b6593a79228b522aa5f9effec4474b8e","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"Indeed, did not checked the message. The current message is not helpful","created_at":"2016-01-10T23:03:27Z","updated_at":"2016-01-10T23:03:27Z","html_url":"https://github.com/NLog/NLog/pull/1143#discussion_r49283181","pull_request_url":"https://api.github.com/repos/NLog/NLog/pulls/1143","_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments/49283181"},"html":{"href":"https://github.com/NLog/NLog/pull/1143#discussion_r49283181"},"pull_request":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1143"}}},"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1143","id":55519532,"html_url":"https://github.com/NLog/NLog/pull/1143","diff_url":"https://github.com/NLog/NLog/pull/1143.diff","patch_url":"https://github.com/NLog/NLog/pull/1143.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1143","number":1143,"state":"open","locked":false,"title":"Consistent Exception handling v3","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"\r\nhttps://github.com/NLog/NLog/pull/1141 should be merged first. \r\n\r\n- added overloads with exception parameter, analogues to the normal logger. \r\n- MustBeRethrown logs to InternalLogger if the exception is not logged before to the InternalLogger\r\n- Warn for NLog config errors, Exception otherwise. \r\n\r\nFixes https://github.com/NLog/NLog/issues/637. Fixes https://github.com/NLog/NLog/issues/277\r\n\r\nsupersedes #915 and https://github.com/NLog/NLog/pull/1117","created_at":"2016-01-08T22:33:56Z","updated_at":"2016-01-10T23:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d229edb6db55e245cf436381949d798cc91ec224","assignee":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/14","html_url":"https://github.com/NLog/NLog/milestones/4.3","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/14/labels","id":1369256,"number":14,"title":"4.3","description":"","creator":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":38,"state":"open","created_at":"2015-10-21T22:23:20Z","updated_at":"2016-01-10T22:45:33Z","due_on":"2016-01-23T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/1143/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/1143/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1143/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/8bb1d9a7b6593a79228b522aa5f9effec4474b8e","head":{"label":"NLog:excception-handling-v3","ref":"excception-handling-v3","sha":"8bb1d9a7b6593a79228b522aa5f9effec4474b8e","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-01-10T16:51:40Z","pushed_at":"2016-01-10T22:45:36Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":120567,"stargazers_count":1399,"watchers_count":1399,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"open_issues_count":124,"forks":514,"open_issues":124,"watchers":1399,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"ad3bb0414fcfa0610a2cbd0fcc208d66bc49f1eb","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-01-10T16:51:40Z","pushed_at":"2016-01-10T22:45:36Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":120567,"stargazers_count":1399,"watchers_count":1399,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"open_issues_count":124,"forks":514,"open_issues":124,"watchers":1399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1143"},"html":{"href":"https://github.com/NLog/NLog/pull/1143"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/1143"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/1143/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1143/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1143/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/8bb1d9a7b6593a79228b522aa5f9effec4474b8e"}}}}