{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35531","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35531/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35531/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35531/events","html_url":"https://github.com/kubernetes/kubernetes/issues/35531","id":185179693,"number":35531,"title":"Docker shim should persist runtime config options like podCIDR","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"labels":[{"id":116712108,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/networking","name":"area/networking","color":"006b75","default":false},{"id":173493827,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/cluster","name":"team/cluster","color":"d2b48c","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-25T17:16:38Z","updated_at":"2016-10-31T18:28:23Z","closed_at":null,"body":"Does the shim need to persist runtime config options so the network plugin can notice changes?    \r\n1. Some runtime options are only needed at startup and not changed thereafter. We handle this today.\r\n2. Some may change at any point. Fails existence proof (?).\r\n3. Some are only available after startup, but won't change\r\n\r\nPodCIDR is an example of 3, and I think it might need to get persisted beause network plugins today assume a complete cni.conf. There are 2 ways to get that:     \r\n1. Admin provisions complete CNI.conf in --cni-conf-dir, ignores podCIDR\r\n2. runtime shim constructs valid CNI.conf at runtime\r\n\r\nKubenet for example keeps the cni.conf template in memory and replaces the CIDR using normal string substituation (\"subnet: %s:\"). When the kubelet retrieves a podCIDR from the node, it sends an event into kubenet. This works because kubenet is compiled in. If the shim is responsible for invoking the plugin, and the shim isn't compiled in, it needs a way to get the cidr. \r\n\r\n@kubernetes/sig-network \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/257378685","html_url":"https://github.com/kubernetes/kubernetes/issues/35531#issuecomment-257378685","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35531","id":257378685,"user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T18:28:23Z","updated_at":"2016-10-31T18:28:23Z","body":"Yeah it should be possible to feed config options like podcidr through a file down into a network plugin without needing a kube aware wrapper. Got confused. "}}
{"actor":{"display_login":"bprashanth"}}