{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/57696188","id":57696188,"diff_hunk":"@@ -0,0 +1,65 @@\n+bundle common test_meta\n+{\n+  vars:\n+      \"description\"\n+\tstring => \"The agent should behave consistently with regard to erroring\n+                   when attempting to read a file that does not exist.\";\n+}\n+\n+\n+body common control\n+{\n+      inputs => { \"../../../default.cf.sub\" };\n+      bundlesequence  => { default(\"$(this.promise_filename)\") };\n+      version => \"1.0\";\n+}\n+\n+#######################################################\n+\n+bundle agent check\n+{\n+  meta:\n+      \"test_soft_fail\"\n+        string => \"any\",\n+        meta => { \"redmine7724\" };\n+\n+  vars:\n+      \"sub_tests\"\n+         slist => {\n+                    \"commands\",\n+                    \"countlinesmatching\",\n+                    \"data_readstringarray\",\n+                    \"data_readstringarrayidx\",\n+                    \"edit_line\",\n+                    \"file_hash\",\n+                    \"getfields\",\n+                    \"peerleader\",\n+                    \"peerleaders\",\n+                    \"peers\",\n+                    \"readcsv\",\n+                    \"readdata\",\n+                    \"readintarray\",\n+                    \"readintlist\",\n+                    \"readjson\",\n+                    \"readrealarray\",\n+                    \"readreallist\",\n+                    \"readstringarray\",\n+                    \"readstringarrayidx\",\n+                    \"readstringlist\",\n+                    \"readyaml\",\n+                    \"usemodule\",\n+                  };\n+\n+  methods:\n+      # We simply look for output of 'error:' in the subtest. It's not very\n+      # specific, but should be unlikely to fail in other conditions.\n+      \"check\"\n+        # Stub in case we decide that suppressing all of these errors is the correct thing\n+        # Pass with any output, except in case of error:\n+        #usebundle => dcs_passif_output(\".*\", \".*error:.*\", \n+        # Pass when there is error: in the output\n+        usebundle => dcs_passif_output(\".*error:.*\", \".*NOTLOOKINGFORANYTHINGTOFAIL.*\", \n+                                       \"$(sys.cf_agent) -Kf $(this.promise_filename).sub_$(sub_tests) -DAUTO,DEBUG\", $(this.promise_filename));","path":"tests/acceptance/00_basics/06_output/error_file_absent/error_file_absent.cf","position":62,"original_position":62,"commit_id":"c1bd77abfea3522b052ad3c6e30851d004819a8d","original_commit_id":"c1bd77abfea3522b052ad3c6e30851d004819a8d","user":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"body":"Therefore multiple invocation will pass as a whole if at least one of them outputs `Pass`.","created_at":"2016-03-29T09:39:36Z","updated_at":"2016-03-29T09:39:36Z","html_url":"https://github.com/cfengine/core/pull/2431#discussion_r57696188","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/2431","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/57696188"},"html":{"href":"https://github.com/cfengine/core/pull/2431#discussion_r57696188"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/2431"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2431","id":52881799,"html_url":"https://github.com/cfengine/core/pull/2431","diff_url":"https://github.com/cfengine/core/pull/2431.diff","patch_url":"https://github.com/cfengine/core/pull/2431.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/2431","number":2431,"state":"open","locked":false,"title":"Add: Test consistency of error for absent files","user":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"body":"Ref: Redmine #7724 https://dev.cfengine.com/issues/7724","created_at":"2015-12-07T18:28:01Z","updated_at":"2016-03-29T09:39:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d8ad90fbc3ea980fcb51524b6fd3c4fd5790c93","assignee":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/2431/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/2431/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2431/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/c1bd77abfea3522b052ad3c6e30851d004819a8d","head":{"label":"nickanderson:redmine/7724_error_when_file_absent","ref":"redmine/7724_error_when_file_absent","sha":"c1bd77abfea3522b052ad3c6e30851d004819a8d","user":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"repo":{"id":5087189,"name":"core","full_name":"nickanderson/core","owner":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickanderson/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/nickanderson/core","forks_url":"https://api.github.com/repos/nickanderson/core/forks","keys_url":"https://api.github.com/repos/nickanderson/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickanderson/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickanderson/core/teams","hooks_url":"https://api.github.com/repos/nickanderson/core/hooks","issue_events_url":"https://api.github.com/repos/nickanderson/core/issues/events{/number}","events_url":"https://api.github.com/repos/nickanderson/core/events","assignees_url":"https://api.github.com/repos/nickanderson/core/assignees{/user}","branches_url":"https://api.github.com/repos/nickanderson/core/branches{/branch}","tags_url":"https://api.github.com/repos/nickanderson/core/tags","blobs_url":"https://api.github.com/repos/nickanderson/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickanderson/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickanderson/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickanderson/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickanderson/core/statuses/{sha}","languages_url":"https://api.github.com/repos/nickanderson/core/languages","stargazers_url":"https://api.github.com/repos/nickanderson/core/stargazers","contributors_url":"https://api.github.com/repos/nickanderson/core/contributors","subscribers_url":"https://api.github.com/repos/nickanderson/core/subscribers","subscription_url":"https://api.github.com/repos/nickanderson/core/subscription","commits_url":"https://api.github.com/repos/nickanderson/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickanderson/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickanderson/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickanderson/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickanderson/core/contents/{+path}","compare_url":"https://api.github.com/repos/nickanderson/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickanderson/core/merges","archive_url":"https://api.github.com/repos/nickanderson/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickanderson/core/downloads","issues_url":"https://api.github.com/repos/nickanderson/core/issues{/number}","pulls_url":"https://api.github.com/repos/nickanderson/core/pulls{/number}","milestones_url":"https://api.github.com/repos/nickanderson/core/milestones{/number}","notifications_url":"https://api.github.com/repos/nickanderson/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickanderson/core/labels{/name}","releases_url":"https://api.github.com/repos/nickanderson/core/releases{/id}","deployments_url":"https://api.github.com/repos/nickanderson/core/deployments","created_at":"2012-07-17T19:52:12Z","updated_at":"2015-07-02T20:34:12Z","pushed_at":"2016-03-27T17:58:49Z","git_url":"git://github.com/nickanderson/core.git","ssh_url":"git@github.com:nickanderson/core.git","clone_url":"https://github.com/nickanderson/core.git","svn_url":"https://github.com/nickanderson/core","homepage":"https://cfengine.com/community/","size":54758,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"e8bf98a3ef1e842c8cd20503494cb0db331aadb2","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","deployments_url":"https://api.github.com/repos/cfengine/core/deployments","created_at":"2012-02-25T09:19:05Z","updated_at":"2016-03-12T18:35:11Z","pushed_at":"2016-03-29T09:35:51Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":70383,"stargazers_count":235,"watchers_count":235,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":21,"forks":144,"open_issues":21,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/2431"},"html":{"href":"https://github.com/cfengine/core/pull/2431"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/2431"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/2431/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/2431/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/2431/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/c1bd77abfea3522b052ad3c6e30851d004819a8d"}}}}