{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5656","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5656/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5656/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5656/events","html_url":"https://github.com/nodejs/node/pull/5656","id":140110236,"number":5656,"title":" Refactor mac installer (built on #2571)","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/install","name":"install","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/os%20x","name":"os x","color":"9944dd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-11T07:32:35Z","updated_at":"2016-03-16T07:11:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5656","html_url":"https://github.com/nodejs/node/pull/5656","diff_url":"https://github.com/nodejs/node/pull/5656.diff","patch_url":"https://github.com/nodejs/node/pull/5656.patch"},"body":"I've spent some more quality time with Packages today, trying to wrangle this into something closer to ready. Building on the work of @remixz work in #776 and @fhemberger's work in #2571.\r\n\r\n* Remove the uninstall option - while I got it to work nicely and cleaned up the script to _fully_ remove everything, the installer that Packages makes is not really suitable for an uninstall option, it still says it's \"installing\", the button is \"install\", the summary at the end still says it's installed Node & npm, it's basically a hack to make an uninstaller possible. We should consider putting this option on the wiki or even installing it somewhere in /usr/local/ that's not in PATH but we can point users to so they can run it themselves.\r\n* Switched to the new logo using the commit on master already\r\n* Made the \"Install Node.js\" option mandatory, Packages has some depend-on functionality for selecting options but there is _no way_ to make it so you have to have Node.js if you select npm, you can make the select box turn on but you can turn it off.\r\n* Changed install.py to add new NODE_INSTALL_NODE_ONLY, NODE_INSTALL_NPM_ONLY and NODE_INSTALL_HEADERS_ONLY (was HEADERS_ONLY) env vars so it can install npm to a different location to node so that the options work properly and you can actually opt to _not_ install npm (yes, it works now!).\r\n* Made it so you have to click \"Customize\" to get to the checkboxes to optionally install npm.\r\n* Made the LICENSE an RTF, it looks so so much nicer now that it's formatted.\r\n* Moved the .pkg to the top-level instead of out/, which is what the current installer does and what Jenkins expects.\r\n\r\nCommits are all over the place and need to be compacted obviously.\r\n\r\nWill post a test build soon, got to sort out the slaves again.\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/197189036","html_url":"https://github.com/nodejs/node/pull/5656#issuecomment-197189036","issue_url":"https://api.github.com/repos/nodejs/node/issues/5656","id":197189036,"user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T07:11:01Z","updated_at":"2016-03-16T07:11:01Z","body":"OK, some more adjustments and I've put *Packages* on both OSX build machines now (was only on one before). Now I have a test package to share! Grab it at https://nodejs.org/download/test/v6.0.0-test20160316798c9dc5b3/node-v6.0.0-test20160316798c9dc5b3.pkg to experience the new goodness."}}