{"action":"created","issue":{"url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/38","repository_url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller","labels_url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/38/comments","events_url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/38/events","html_url":"https://github.com/CassetteRocks/react-infinite-scroller/pull/38","id":195632691,"number":38,"title":"Feature/scroll ele","user":{"login":"eacaps","id":8252280,"avatar_url":"https://avatars.githubusercontent.com/u/8252280?v=3","gravatar_id":"","url":"https://api.github.com/users/eacaps","html_url":"https://github.com/eacaps","followers_url":"https://api.github.com/users/eacaps/followers","following_url":"https://api.github.com/users/eacaps/following{/other_user}","gists_url":"https://api.github.com/users/eacaps/gists{/gist_id}","starred_url":"https://api.github.com/users/eacaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eacaps/subscriptions","organizations_url":"https://api.github.com/users/eacaps/orgs","repos_url":"https://api.github.com/users/eacaps/repos","events_url":"https://api.github.com/users/eacaps/events{/privacy}","received_events_url":"https://api.github.com/users/eacaps/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-14T20:07:40Z","updated_at":"2016-12-16T01:46:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/pulls/38","html_url":"https://github.com/CassetteRocks/react-infinite-scroller/pull/38","diff_url":"https://github.com/CassetteRocks/react-infinite-scroller/pull/38.diff","patch_url":"https://github.com/CassetteRocks/react-infinite-scroller/pull/38.patch"},"body":"Hello, I was looking into using a infinite-scroller library and yours seemed like the simplest and most up to date. Unfortunately the view is complicated and the scroll container is several levels up from the actual scrolling list.  Our page also has a header and the useWindow property will not produce the correct scrolling behavior. I implemented an additional property `scrollElement` that you can specify as the element to attach the scroll handlers to. Let me know if you think this is a reasonable idea."},"comment":{"url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/comments/267496394","html_url":"https://github.com/CassetteRocks/react-infinite-scroller/pull/38#issuecomment-267496394","issue_url":"https://api.github.com/repos/CassetteRocks/react-infinite-scroller/issues/38","id":267496394,"user":{"login":"danbovey","id":1503076,"avatar_url":"https://avatars.githubusercontent.com/u/1503076?v=3","gravatar_id":"","url":"https://api.github.com/users/danbovey","html_url":"https://github.com/danbovey","followers_url":"https://api.github.com/users/danbovey/followers","following_url":"https://api.github.com/users/danbovey/following{/other_user}","gists_url":"https://api.github.com/users/danbovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danbovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbovey/subscriptions","organizations_url":"https://api.github.com/users/danbovey/orgs","repos_url":"https://api.github.com/users/danbovey/repos","events_url":"https://api.github.com/users/danbovey/events{/privacy}","received_events_url":"https://api.github.com/users/danbovey/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T01:46:26Z","updated_at":"2016-12-16T01:46:26Z","body":"Hi\r\n\r\nIf I've got this right, you don't want the `parentNode` to be the scrolling element. Passing around DOM elements in props is definitely not idiomatic to React. @calebcassel I get that choosing between window or parent might be inflexible but I just don't see the use case for this.\r\n\r\nLook into [react-dimensions](https://github.com/digidem/react-dimensions) if the `parentNode` of your InfiniteScroll component isn't taking up the required space.\r\n\r\nhttps://github.com/CassetteRocks/react-infinite-scroller#dom-scroll-events\r\n\r\nAlso, creating a new prop called `scrollElement` whilst leaving `useWindow` a boolean is weird logic allowing you to ask for window and provide a scroll element - would need to be rethought into something like define a scroll element, else use window."}}
{"actor":{"display_login":"danbovey"}}