{"action":"closed","issue":{"url":"https://api.github.com/repos/mdn/webextensions-examples/issues/77","repository_url":"https://api.github.com/repos/mdn/webextensions-examples","labels_url":"https://api.github.com/repos/mdn/webextensions-examples/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/mdn/webextensions-examples/issues/77/comments","events_url":"https://api.github.com/repos/mdn/webextensions-examples/issues/77/events","html_url":"https://github.com/mdn/webextensions-examples/issues/77","id":164461951,"number":77,"title":"beastify.js","user":{"login":"oxidian24","id":18716184,"avatar_url":"https://avatars.githubusercontent.com/u/18716184?v=3","gravatar_id":"","url":"https://api.github.com/users/oxidian24","html_url":"https://github.com/oxidian24","followers_url":"https://api.github.com/users/oxidian24/followers","following_url":"https://api.github.com/users/oxidian24/following{/other_user}","gists_url":"https://api.github.com/users/oxidian24/gists{/gist_id}","starred_url":"https://api.github.com/users/oxidian24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxidian24/subscriptions","organizations_url":"https://api.github.com/users/oxidian24/orgs","repos_url":"https://api.github.com/users/oxidian24/repos","events_url":"https://api.github.com/users/oxidian24/events{/privacy}","received_events_url":"https://api.github.com/users/oxidian24/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-08T05:33:05Z","updated_at":"2016-07-09T16:21:37Z","closed_at":"2016-07-09T16:21:37Z","body":"I see a gap in some examples like Beastify. I see it should be simple as possible, but the problem is that you did not make it clear enough that HTML page or HTML document must be loaded (or I did not realized it). It took few days to me to realize that when I open new Tab in Firefox, it is not html page (**it looks like html doc but is not**). As far as I understand the problem - the Window exists but the document was not created. So when I tried your addon nothing displayed in the Window.\r\n\r\nThe function\r\n\r\n`function insertBeast(beastURL) {\r\n  var beastImage = document.createElement(\"img\");\r\n  beastImage.setAttribute(\"src\", beastURL);\r\n  beastImage.setAttribute(\"style\", \"width: 100vw\");\r\n  beastImage.setAttribute(\"style\", \"height: 100vh\");\r\n  document.body.appendChild(beastImage);\r\n}\r\n`\r\nCan not create any document, because you did not check if the document exists and did not create the document in the case that the document does not exists (but window does). Please add the fix.\r\n\r\nAlso a back-reference to the second tutorial would be helpful. Also add a link to first tutorial to borderify.js . Because I did come here from different link and I did not see the explanation which is there. Now, I do not know the links which are to the rest of the examples, if there are some tutorials which I should see related to them."}}
{"actor":{"display_login":"wbamberg"}}