{"action":"created","comment":{"url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/comments/83285046","pull_request_review_id":4139067,"id":83285046,"diff_hunk":"@@ -27,6 +29,12 @@ def _str_to_bool(s):\n                              'boolean, got {}'.format(s))\n         return {'true': True, 'false': False}[s.lower()]\n \n+    def _ensure_positive_float(f):","path":"generate.py","position":19,"original_position":19,"commit_id":"e5d55b256cd43aa1ca696ffd45e9401be9c568a0","original_commit_id":"e5d55b256cd43aa1ca696ffd45e9401be9c568a0","user":{"login":"lemonzi","id":3180006,"avatar_url":"https://avatars.githubusercontent.com/u/3180006?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonzi","html_url":"https://github.com/lemonzi","followers_url":"https://api.github.com/users/lemonzi/followers","following_url":"https://api.github.com/users/lemonzi/following{/other_user}","gists_url":"https://api.github.com/users/lemonzi/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonzi/subscriptions","organizations_url":"https://api.github.com/users/lemonzi/orgs","repos_url":"https://api.github.com/users/lemonzi/repos","events_url":"https://api.github.com/users/lemonzi/events{/privacy}","received_events_url":"https://api.github.com/users/lemonzi/received_events","type":"User","site_admin":false},"body":"Shouldn't this be generic and not specific to the sampling temperature?","created_at":"2016-10-13T18:45:39Z","updated_at":"2016-10-13T18:45:46Z","html_url":"https://github.com/ibab/tensorflow-wavenet/pull/131#discussion_r83285046","pull_request_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/comments/83285046"},"html":{"href":"https://github.com/ibab/tensorflow-wavenet/pull/131#discussion_r83285046"},"pull_request":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131","id":88561046,"html_url":"https://github.com/ibab/tensorflow-wavenet/pull/131","diff_url":"https://github.com/ibab/tensorflow-wavenet/pull/131.diff","patch_url":"https://github.com/ibab/tensorflow-wavenet/pull/131.patch","issue_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/131","number":131,"state":"open","locked":false,"title":"Added temperature flag to generation script","user":{"login":"robinsloan","id":40284,"avatar_url":"https://avatars.githubusercontent.com/u/40284?v=3","gravatar_id":"","url":"https://api.github.com/users/robinsloan","html_url":"https://github.com/robinsloan","followers_url":"https://api.github.com/users/robinsloan/followers","following_url":"https://api.github.com/users/robinsloan/following{/other_user}","gists_url":"https://api.github.com/users/robinsloan/gists{/gist_id}","starred_url":"https://api.github.com/users/robinsloan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinsloan/subscriptions","organizations_url":"https://api.github.com/users/robinsloan/orgs","repos_url":"https://api.github.com/users/robinsloan/repos","events_url":"https://api.github.com/users/robinsloan/events{/privacy}","received_events_url":"https://api.github.com/users/robinsloan/received_events","type":"User","site_admin":false},"body":"It's nice to be able to specify sampling \"temperature\" when generating output, usually for aesthetic reasons, so I added some code to scale the sampling probabilities if a temperature other than 1.0 is provided.\r\n\r\nDemo: https://soundcloud.com/robinsloan/sets/tensorflow-wavenet-temperature-demo","created_at":"2016-10-08T22:25:03Z","updated_at":"2016-10-13T18:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70cd5e323f1275f932570ec3296f0e0e03a4a46c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131/commits","review_comments_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131/comments","review_comment_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/131/comments","statuses_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/statuses/e5d55b256cd43aa1ca696ffd45e9401be9c568a0","head":{"label":"robinsloan:master","ref":"master","sha":"e5d55b256cd43aa1ca696ffd45e9401be9c568a0","user":{"login":"robinsloan","id":40284,"avatar_url":"https://avatars.githubusercontent.com/u/40284?v=3","gravatar_id":"","url":"https://api.github.com/users/robinsloan","html_url":"https://github.com/robinsloan","followers_url":"https://api.github.com/users/robinsloan/followers","following_url":"https://api.github.com/users/robinsloan/following{/other_user}","gists_url":"https://api.github.com/users/robinsloan/gists{/gist_id}","starred_url":"https://api.github.com/users/robinsloan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinsloan/subscriptions","organizations_url":"https://api.github.com/users/robinsloan/orgs","repos_url":"https://api.github.com/users/robinsloan/repos","events_url":"https://api.github.com/users/robinsloan/events{/privacy}","received_events_url":"https://api.github.com/users/robinsloan/received_events","type":"User","site_admin":false},"repo":{"id":69299039,"name":"tensorflow-wavenet","full_name":"robinsloan/tensorflow-wavenet","owner":{"login":"robinsloan","id":40284,"avatar_url":"https://avatars.githubusercontent.com/u/40284?v=3","gravatar_id":"","url":"https://api.github.com/users/robinsloan","html_url":"https://github.com/robinsloan","followers_url":"https://api.github.com/users/robinsloan/followers","following_url":"https://api.github.com/users/robinsloan/following{/other_user}","gists_url":"https://api.github.com/users/robinsloan/gists{/gist_id}","starred_url":"https://api.github.com/users/robinsloan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinsloan/subscriptions","organizations_url":"https://api.github.com/users/robinsloan/orgs","repos_url":"https://api.github.com/users/robinsloan/repos","events_url":"https://api.github.com/users/robinsloan/events{/privacy}","received_events_url":"https://api.github.com/users/robinsloan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robinsloan/tensorflow-wavenet","description":"A TensorFlow implementation of DeepMind's WaveNet paper","fork":true,"url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet","forks_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/forks","keys_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/teams","hooks_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/hooks","issue_events_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/issues/events{/number}","events_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/events","assignees_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/assignees{/user}","branches_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/branches{/branch}","tags_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/tags","blobs_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/git/refs{/sha}","trees_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/statuses/{sha}","languages_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/languages","stargazers_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/stargazers","contributors_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/contributors","subscribers_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/subscribers","subscription_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/subscription","commits_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/commits{/sha}","git_commits_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/git/commits{/sha}","comments_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/comments{/number}","issue_comment_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/issues/comments{/number}","contents_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/contents/{+path}","compare_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/merges","archive_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/downloads","issues_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/issues{/number}","pulls_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/pulls{/number}","milestones_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/milestones{/number}","notifications_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/labels{/name}","releases_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/releases{/id}","deployments_url":"https://api.github.com/repos/robinsloan/tensorflow-wavenet/deployments","created_at":"2016-09-26T22:46:39Z","updated_at":"2016-09-26T22:46:41Z","pushed_at":"2016-10-13T02:10:08Z","git_url":"git://github.com/robinsloan/tensorflow-wavenet.git","ssh_url":"git@github.com:robinsloan/tensorflow-wavenet.git","clone_url":"https://github.com/robinsloan/tensorflow-wavenet.git","svn_url":"https://github.com/robinsloan/tensorflow-wavenet","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ibab:master","ref":"master","sha":"111117f57a3d380907d6090569c205729cdebbfd","user":{"login":"ibab","id":890531,"avatar_url":"https://avatars.githubusercontent.com/u/890531?v=3","gravatar_id":"","url":"https://api.github.com/users/ibab","html_url":"https://github.com/ibab","followers_url":"https://api.github.com/users/ibab/followers","following_url":"https://api.github.com/users/ibab/following{/other_user}","gists_url":"https://api.github.com/users/ibab/gists{/gist_id}","starred_url":"https://api.github.com/users/ibab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibab/subscriptions","organizations_url":"https://api.github.com/users/ibab/orgs","repos_url":"https://api.github.com/users/ibab/repos","events_url":"https://api.github.com/users/ibab/events{/privacy}","received_events_url":"https://api.github.com/users/ibab/received_events","type":"User","site_admin":false},"repo":{"id":68013171,"name":"tensorflow-wavenet","full_name":"ibab/tensorflow-wavenet","owner":{"login":"ibab","id":890531,"avatar_url":"https://avatars.githubusercontent.com/u/890531?v=3","gravatar_id":"","url":"https://api.github.com/users/ibab","html_url":"https://github.com/ibab","followers_url":"https://api.github.com/users/ibab/followers","following_url":"https://api.github.com/users/ibab/following{/other_user}","gists_url":"https://api.github.com/users/ibab/gists{/gist_id}","starred_url":"https://api.github.com/users/ibab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibab/subscriptions","organizations_url":"https://api.github.com/users/ibab/orgs","repos_url":"https://api.github.com/users/ibab/repos","events_url":"https://api.github.com/users/ibab/events{/privacy}","received_events_url":"https://api.github.com/users/ibab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibab/tensorflow-wavenet","description":"A TensorFlow implementation of DeepMind's WaveNet paper","fork":false,"url":"https://api.github.com/repos/ibab/tensorflow-wavenet","forks_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/forks","keys_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/teams","hooks_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/hooks","issue_events_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/events{/number}","events_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/events","assignees_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/assignees{/user}","branches_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/branches{/branch}","tags_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/tags","blobs_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/statuses/{sha}","languages_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/languages","stargazers_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/stargazers","contributors_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/contributors","subscribers_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/subscribers","subscription_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/subscription","commits_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/contents/{+path}","compare_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/merges","archive_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/downloads","issues_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues{/number}","pulls_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls{/number}","milestones_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/milestones{/number}","notifications_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/labels{/name}","releases_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/releases{/id}","deployments_url":"https://api.github.com/repos/ibab/tensorflow-wavenet/deployments","created_at":"2016-09-12T13:50:45Z","updated_at":"2016-10-13T16:18:18Z","pushed_at":"2016-10-13T18:30:07Z","git_url":"git://github.com/ibab/tensorflow-wavenet.git","ssh_url":"git@github.com:ibab/tensorflow-wavenet.git","clone_url":"https://github.com/ibab/tensorflow-wavenet.git","svn_url":"https://github.com/ibab/tensorflow-wavenet","homepage":null,"size":611,"stargazers_count":1431,"watchers_count":1431,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":30,"forks":175,"open_issues":30,"watchers":1431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131"},"html":{"href":"https://github.com/ibab/tensorflow-wavenet/pull/131"},"issue":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/131"},"comments":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/ibab/tensorflow-wavenet/statuses/e5d55b256cd43aa1ca696ffd45e9401be9c568a0"}}}}
{"actor":{"display_login":"lemonzi"}}