{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/1010","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/1010/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/1010/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/1010/events","html_url":"https://github.com/eclipse/jetty.project/pull/1010","id":183294368,"number":1010,"title":"Enhancement for detection of insufficient threads","user":{"login":"vladimir-bukhtoyarov","id":6761830,"avatar_url":"https://avatars.githubusercontent.com/u/6761830?v=3","gravatar_id":"","url":"https://api.github.com/users/vladimir-bukhtoyarov","html_url":"https://github.com/vladimir-bukhtoyarov","followers_url":"https://api.github.com/users/vladimir-bukhtoyarov/followers","following_url":"https://api.github.com/users/vladimir-bukhtoyarov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-bukhtoyarov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-bukhtoyarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-bukhtoyarov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-bukhtoyarov/orgs","repos_url":"https://api.github.com/users/vladimir-bukhtoyarov/repos","events_url":"https://api.github.com/users/vladimir-bukhtoyarov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-bukhtoyarov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-16T21:54:19Z","updated_at":"2016-10-19T23:13:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/1010","html_url":"https://github.com/eclipse/jetty.project/pull/1010","diff_url":"https://github.com/eclipse/jetty.project/pull/1010.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/1010.patch"},"body":"**Problem:**\r\nThe server cares about selectors and acceptors even in the case of connector uses dedicated executor. This is wrong behaviour because of selectors and acceptors will never executed in server executor, so server should not try check limit in this case.\r\n\r\n**Impact:**\r\nIn case of dedicated executor for connector, It is impossible to set the small max-size to server pool, because server requires threads which will never used.\r\n\r\n**Workaround:**\r\nSet required max thread count for server executor.\r\n\r\n**Implemented fix:**\r\nConfiguration of connector has no impact to the insufficient thread detection at server level if connector uses own executor."},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/254967584","html_url":"https://github.com/eclipse/jetty.project/pull/1010#issuecomment-254967584","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/1010","id":254967584,"user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T23:13:26Z","updated_at":"2016-10-19T23:13:26Z","body":"The relevant line:\r\n\r\n```\r\n[INFO] Missing header in: /opt/jenkins/workspace/jetty.project_PR-1010-ED5GFIIPCZZGF53HJJKV6VOEM2R3LGL5RIKBD6HAV2DVPCCCVIHA/jetty-server/src/test/java/org/eclipse/jetty/server/InsufficientThreadsDetectionTest.java\r\n```\r\n\r\nThe file in your commit: https://github.com/vladimir-bukhtoyarov/jetty.project/blob/e34da4e7590eca23dccceaaa2acaa745c2f48539/jetty-server/src/test/java/org/eclipse/jetty/server/InsufficientThreadsDetectionTest.java\r\n\r\nThe license validation is very picky (intentionally so), just add the blank line and you should pass that license verification step.\r\n\r\n"}}
{"actor":{"display_login":"joakime"}}