{"action":"created","issue":{"url":"https://api.github.com/repos/collectd/collectd/issues/2037","repository_url":"https://api.github.com/repos/collectd/collectd","labels_url":"https://api.github.com/repos/collectd/collectd/issues/2037/labels{/name}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/2037/comments","events_url":"https://api.github.com/repos/collectd/collectd/issues/2037/events","html_url":"https://github.com/collectd/collectd/pull/2037","id":189362812,"number":2037,"title":"virt plugin: Rewrite from scratch","user":{"login":"mojaves","id":194089,"avatar_url":"https://avatars.githubusercontent.com/u/194089?v=3","gravatar_id":"","url":"https://api.github.com/users/mojaves","html_url":"https://github.com/mojaves","followers_url":"https://api.github.com/users/mojaves/followers","following_url":"https://api.github.com/users/mojaves/following{/other_user}","gists_url":"https://api.github.com/users/mojaves/gists{/gist_id}","starred_url":"https://api.github.com/users/mojaves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojaves/subscriptions","organizations_url":"https://api.github.com/users/mojaves/orgs","repos_url":"https://api.github.com/users/mojaves/repos","events_url":"https://api.github.com/users/mojaves/events{/privacy}","received_events_url":"https://api.github.com/users/mojaves/received_events","type":"User","site_admin":false},"labels":[{"id":441006047,"url":"https://api.github.com/repos/collectd/collectd/labels/Pending%20contributor%20action","name":"Pending contributor action","color":"d0d0d0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-15T11:07:33Z","updated_at":"2016-11-16T16:03:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/2037","html_url":"https://github.com/collectd/collectd/pull/2037","diff_url":"https://github.com/collectd/collectd/pull/2037.diff","patch_url":"https://github.com/collectd/collectd/pull/2037.patch"},"body":"This patch rewrites the existing virt plugin\r\nalmost entirely, borrowing only few bits from\r\nthe existing one.\r\n\r\nThe plugin exports as superset of the metrics the\r\nold plugin exported, and accepts a superset of the\r\nconfiguration settings the old plugin expected, so\r\nit is intended to act as drop-in replacement.\r\n\r\nThe new plugin now depends on glib2, libvirt and libxml2.\r\nThe new plugin has tests, taking inspiration from the tests\r\nof the ceph plugin (src/ceph_test.c).\r\n\r\nThe gathering of the libvirt values has been completely overhauled,\r\nand now we use the libvirt bulk stats API:\r\nhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainListGetStats\r\nwhich is a more modern and convenient way to fetch the\r\ndata from running libvirt domains.\r\n\r\nWe add resiliency in presence of unresponsive domains.\r\nThis can happen if a domain used shared storage (NFS, ISCSI)\r\nand it experiences a network failure during one I/O operation.\r\ncheck docs/README.virt.md to learn more about the issue\r\nand the implemented solution."},"comment":{"url":"https://api.github.com/repos/collectd/collectd/issues/comments/260985830","html_url":"https://github.com/collectd/collectd/pull/2037#issuecomment-260985830","issue_url":"https://api.github.com/repos/collectd/collectd/issues/2037","id":260985830,"user":{"login":"pszczerx","id":22165295,"avatar_url":"https://avatars.githubusercontent.com/u/22165295?v=3","gravatar_id":"","url":"https://api.github.com/users/pszczerx","html_url":"https://github.com/pszczerx","followers_url":"https://api.github.com/users/pszczerx/followers","following_url":"https://api.github.com/users/pszczerx/following{/other_user}","gists_url":"https://api.github.com/users/pszczerx/gists{/gist_id}","starred_url":"https://api.github.com/users/pszczerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pszczerx/subscriptions","organizations_url":"https://api.github.com/users/pszczerx/orgs","repos_url":"https://api.github.com/users/pszczerx/repos","events_url":"https://api.github.com/users/pszczerx/events{/privacy}","received_events_url":"https://api.github.com/users/pszczerx/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T16:03:20Z","updated_at":"2016-11-16T16:03:20Z","body":"@mojaves thanks for opening this PR. I left a few comments, but of course a maintainer needs to take a look at this.\r\n\r\n@octo: Could you answer @mojaves question regarding distros? We are planning on extending virt plugin with a couple more metrics and some of them require libvirt >= 2.0.0."}}
{"actor":{"display_login":"pszczerx"}}