{"action":"opened","number":150,"pull_request":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/150","id":66779782,"html_url":"https://github.com/mozilla/tofino/pull/150","diff_url":"https://github.com/mozilla/tofino/pull/150.diff","patch_url":"https://github.com/mozilla/tofino/pull/150.patch","issue_url":"https://api.github.com/repos/mozilla/tofino/issues/150","number":150,"state":"open","locked":false,"title":"Navigation commands for WebView should be handled by Redux actions vi…","user":{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false},"body":"…a state changes observed by Page. r=vp,linclark\r\n\r\nFixes #119.\r\n\r\nThis removes most of the usage of different components querying the DOM for the webview, and so only the Page object manages its WebView*. There are still other things grabbing the webview with `getCurrentWebView` but these are for non-navigation components like copy/paste, may need a different solution to clean that up\r\n\r\nThis feels more Reduxy, and commands are executed as the most recent 'command' (refresh, back, forward, etc) is stored in the Page state, so the Page knows if it needs to fire off a command or not. Is this the right way to do this? Feels nice, having these pretty big deal actions actually reflected in the redux state, though.\r\n\r\nCan't assign to @linclark for some reason (?), but would like both of ya @victorporof to take a look at this, because I think this problem will come up again so good to have a pattern for dealing with it","created_at":"2016-04-17T20:16:18Z","updated_at":"2016-04-17T20:16:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/tofino/pulls/150/commits","review_comments_url":"https://api.github.com/repos/mozilla/tofino/pulls/150/comments","review_comment_url":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/tofino/issues/150/comments","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/1a7e4f640c5b3a20f2d7980a0d243af4261e8fa8","head":{"label":"jsantell:loc-nav","ref":"loc-nav","sha":"1a7e4f640c5b3a20f2d7980a0d243af4261e8fa8","user":{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false},"repo":{"id":55798745,"name":"tofino","full_name":"jsantell/tofino","owner":{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsantell/tofino","description":"Project Tofino is a browser interaction experiment.","fork":true,"url":"https://api.github.com/repos/jsantell/tofino","forks_url":"https://api.github.com/repos/jsantell/tofino/forks","keys_url":"https://api.github.com/repos/jsantell/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsantell/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsantell/tofino/teams","hooks_url":"https://api.github.com/repos/jsantell/tofino/hooks","issue_events_url":"https://api.github.com/repos/jsantell/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/jsantell/tofino/events","assignees_url":"https://api.github.com/repos/jsantell/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/jsantell/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/jsantell/tofino/tags","blobs_url":"https://api.github.com/repos/jsantell/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsantell/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsantell/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsantell/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsantell/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/jsantell/tofino/languages","stargazers_url":"https://api.github.com/repos/jsantell/tofino/stargazers","contributors_url":"https://api.github.com/repos/jsantell/tofino/contributors","subscribers_url":"https://api.github.com/repos/jsantell/tofino/subscribers","subscription_url":"https://api.github.com/repos/jsantell/tofino/subscription","commits_url":"https://api.github.com/repos/jsantell/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsantell/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsantell/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsantell/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsantell/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/jsantell/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsantell/tofino/merges","archive_url":"https://api.github.com/repos/jsantell/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsantell/tofino/downloads","issues_url":"https://api.github.com/repos/jsantell/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/jsantell/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/jsantell/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/jsantell/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsantell/tofino/labels{/name}","releases_url":"https://api.github.com/repos/jsantell/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/jsantell/tofino/deployments","created_at":"2016-04-08T17:52:20Z","updated_at":"2016-04-08T17:52:21Z","pushed_at":"2016-04-17T20:12:14Z","git_url":"git://github.com/jsantell/tofino.git","ssh_url":"git@github.com:jsantell/tofino.git","clone_url":"https://github.com/jsantell/tofino.git","svn_url":"https://github.com/jsantell/tofino","homepage":"https://medium.com/project-tofino","size":1404,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"72bac8076803f2bc88fd78ce21d0a897dd2b25ff","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":55401807,"name":"tofino","full_name":"mozilla/tofino","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/tofino","description":"Project Tofino is a browser interaction experiment.","fork":false,"url":"https://api.github.com/repos/mozilla/tofino","forks_url":"https://api.github.com/repos/mozilla/tofino/forks","keys_url":"https://api.github.com/repos/mozilla/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/tofino/teams","hooks_url":"https://api.github.com/repos/mozilla/tofino/hooks","issue_events_url":"https://api.github.com/repos/mozilla/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/tofino/events","assignees_url":"https://api.github.com/repos/mozilla/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/tofino/tags","blobs_url":"https://api.github.com/repos/mozilla/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/tofino/languages","stargazers_url":"https://api.github.com/repos/mozilla/tofino/stargazers","contributors_url":"https://api.github.com/repos/mozilla/tofino/contributors","subscribers_url":"https://api.github.com/repos/mozilla/tofino/subscribers","subscription_url":"https://api.github.com/repos/mozilla/tofino/subscription","commits_url":"https://api.github.com/repos/mozilla/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/tofino/merges","archive_url":"https://api.github.com/repos/mozilla/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/tofino/downloads","issues_url":"https://api.github.com/repos/mozilla/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/tofino/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/tofino/deployments","created_at":"2016-04-04T10:13:26Z","updated_at":"2016-04-17T13:39:34Z","pushed_at":"2016-04-17T20:16:19Z","git_url":"git://github.com/mozilla/tofino.git","ssh_url":"git@github.com:mozilla/tofino.git","clone_url":"https://github.com/mozilla/tofino.git","svn_url":"https://github.com/mozilla/tofino","homepage":"https://medium.com/project-tofino","size":1533,"stargazers_count":270,"watchers_count":270,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":41,"forks":27,"open_issues":41,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/150"},"html":{"href":"https://github.com/mozilla/tofino/pull/150"},"issue":{"href":"https://api.github.com/repos/mozilla/tofino/issues/150"},"comments":{"href":"https://api.github.com/repos/mozilla/tofino/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/tofino/statuses/1a7e4f640c5b3a20f2d7980a0d243af4261e8fa8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":162,"deletions":22,"changed_files":11}}