{"action":"closed","issue":{"url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/985","repository_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth","labels_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/985/labels{/name}","comments_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/985/comments","events_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/985/events","html_url":"https://github.com/benedmunds/CodeIgniter-Ion-Auth/issues/985","id":182602148,"number":985,"title":"$identity checking for empty failed","user":{"login":"zhuzhaodan","id":13619254,"avatar_url":"https://avatars.githubusercontent.com/u/13619254?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuzhaodan","html_url":"https://github.com/zhuzhaodan","followers_url":"https://api.github.com/users/zhuzhaodan/followers","following_url":"https://api.github.com/users/zhuzhaodan/following{/other_user}","gists_url":"https://api.github.com/users/zhuzhaodan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuzhaodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuzhaodan/subscriptions","organizations_url":"https://api.github.com/users/zhuzhaodan/orgs","repos_url":"https://api.github.com/users/zhuzhaodan/repos","events_url":"https://api.github.com/users/zhuzhaodan/events{/privacy}","received_events_url":"https://api.github.com/users/zhuzhaodan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-12T18:42:55Z","updated_at":"2016-10-12T19:27:15Z","closed_at":"2016-10-12T19:27:15Z","body":"`\r\n\tpublic function identity_check($identity = '')\r\n\t{\r\n\t\t$this->trigger_events('identity_check');\r\n\r\n\t\tif (empty($identity))\r\n\t\t{\r\n\t\t\treturn FALSE;\r\n\t\t}\r\n\r\n\t\treturn $this->db->where($this->identity_column, $identity)\r\n\t\t                ->count_all_results($this->tables['users']) > 0;\r\n\t}`\r\n\r\nif $identity is empty, then return false then goes here\r\n\r\n`\t\tif ($this->identity_check($identity))\r\n\t\t{\r\n\t\t\t$this->set_error('account_creation_duplicate_identity');\r\n\t\t\treturn FALSE;\r\n\t\t}`\r\n\r\nThen skiped the check for empty $identity, which results in $identity is empty in the database"}}
{"actor":{"display_login":"benedmunds"}}