{"action":"created","issue":{"url":"https://api.github.com/repos/mrb113/PerfectHash/issues/1","repository_url":"https://api.github.com/repos/mrb113/PerfectHash","labels_url":"https://api.github.com/repos/mrb113/PerfectHash/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mrb113/PerfectHash/issues/1/comments","events_url":"https://api.github.com/repos/mrb113/PerfectHash/issues/1/events","html_url":"https://github.com/mrb113/PerfectHash/issues/1","id":181311123,"number":1,"title":"about UCHAR_MAX","user":{"login":"clark0081","id":14243896,"avatar_url":"https://avatars.githubusercontent.com/u/14243896?v=3","gravatar_id":"","url":"https://api.github.com/users/clark0081","html_url":"https://github.com/clark0081","followers_url":"https://api.github.com/users/clark0081/followers","following_url":"https://api.github.com/users/clark0081/following{/other_user}","gists_url":"https://api.github.com/users/clark0081/gists{/gist_id}","starred_url":"https://api.github.com/users/clark0081/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark0081/subscriptions","organizations_url":"https://api.github.com/users/clark0081/orgs","repos_url":"https://api.github.com/users/clark0081/repos","events_url":"https://api.github.com/users/clark0081/events{/privacy}","received_events_url":"https://api.github.com/users/clark0081/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-06T02:33:18Z","updated_at":"2016-10-06T02:52:56Z","closed_at":null,"body":"thanks a lot, it is a great example of perfect hash function,\r\nbut i have two questions: in the document perfect.c , there is no definition of UCHAR_MAX, \r\nand in test.c I can't figure out why using 63580000 to calculate  the kernelbasekeys array\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mrb113/PerfectHash/issues/comments/251854912","html_url":"https://github.com/mrb113/PerfectHash/issues/1#issuecomment-251854912","issue_url":"https://api.github.com/repos/mrb113/PerfectHash/issues/1","id":251854912,"user":{"login":"mrb113","id":1258037,"avatar_url":"https://avatars.githubusercontent.com/u/1258037?v=3","gravatar_id":"","url":"https://api.github.com/users/mrb113","html_url":"https://github.com/mrb113","followers_url":"https://api.github.com/users/mrb113/followers","following_url":"https://api.github.com/users/mrb113/following{/other_user}","gists_url":"https://api.github.com/users/mrb113/gists{/gist_id}","starred_url":"https://api.github.com/users/mrb113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrb113/subscriptions","organizations_url":"https://api.github.com/users/mrb113/orgs","repos_url":"https://api.github.com/users/mrb113/repos","events_url":"https://api.github.com/users/mrb113/events{/privacy}","received_events_url":"https://api.github.com/users/mrb113/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T02:52:56Z","updated_at":"2016-10-06T02:52:56Z","body":"Hi Clark,\r\n\r\nI built this for Windows so UCHAR_MAX probably isn't defined for you. I'll fix it, but in the meantime, you can say\r\n#ifndef UCHAR_MAX\r\n#define UCHAR_MAX 0xff\r\n#endif\r\n\r\nThe test leaves a lot to be desired - I built the library for public consumption but not really the test.\r\nAs for the data set, this is how I got the kernel base keys:\r\n\r\nrun \"link /dump /headers /loadconfig\" on kernelbase.dll from a machine running an x86 Windows build. Take the long list of numbers this will print out and subtract the “image base address” from each number to get the set of numbers you will hash. The image base address is the number you've listed.\r\n\r\nThat is not documented anywhere... I'll have to add it somewhere."}}
{"actor":{"display_login":"mrb113"}}