{"action":"closed","number":14346,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14346","id":95028532,"html_url":"https://github.com/servo/servo/pull/14346","diff_url":"https://github.com/servo/servo/pull/14346.diff","patch_url":"https://github.com/servo/servo/pull/14346.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/14346","number":14346,"state":"closed","locked":false,"title":"Use MSVC toolchain if PLATFORM is defined","user":{"login":"mati865","id":1174646,"avatar_url":"https://avatars.githubusercontent.com/u/1174646?v=3","gravatar_id":"","url":"https://api.github.com/users/mati865","html_url":"https://github.com/mati865","followers_url":"https://api.github.com/users/mati865/followers","following_url":"https://api.github.com/users/mati865/following{/other_user}","gists_url":"https://api.github.com/users/mati865/gists{/gist_id}","starred_url":"https://api.github.com/users/mati865/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mati865/subscriptions","organizations_url":"https://api.github.com/users/mati865/orgs","repos_url":"https://api.github.com/users/mati865/repos","events_url":"https://api.github.com/users/mati865/events{/privacy}","received_events_url":"https://api.github.com/users/mati865/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n`VSInstallDir` exists only when Visual Studio is installed.\r\n`VS140COMNTOOLS` is defined by installing either Visual Studio or [Visual C++ Build Tools](http://landinghub.visualstudio.com/visual-cpp-build-tools)\r\n\r\nIt will allow to build MSVC based Servo without having to install whole Visual Studio (few GiB).\r\n\r\nEDIT: Another (maybe cleaner) solution would be reverting https://github.com/servo/servo/commit/63ec96a57d4772a961bea63111c927ccd7c85a91\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [ ] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [x] These changes do not require tests because `VS140COMNTOOLS` variable is already used in [mach.bat](https://github.com/servo/servo/blob/master/mach.bat)\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14346)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-11-23T15:48:11Z","updated_at":"2016-12-28T16:24:48Z","closed_at":"2016-12-28T16:24:48Z","merged_at":"2016-12-28T16:24:48Z","merge_commit_sha":"687a1844b9cf9eca62f7588a3be8cf2587862dfa","assignee":{"login":"larsbergstrom","id":475847,"avatar_url":"https://avatars.githubusercontent.com/u/475847?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbergstrom","html_url":"https://github.com/larsbergstrom","followers_url":"https://api.github.com/users/larsbergstrom/followers","following_url":"https://api.github.com/users/larsbergstrom/following{/other_user}","gists_url":"https://api.github.com/users/larsbergstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbergstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbergstrom/subscriptions","organizations_url":"https://api.github.com/users/larsbergstrom/orgs","repos_url":"https://api.github.com/users/larsbergstrom/repos","events_url":"https://api.github.com/users/larsbergstrom/events{/privacy}","received_events_url":"https://api.github.com/users/larsbergstrom/received_events","type":"User","site_admin":false},"assignees":[{"login":"larsbergstrom","id":475847,"avatar_url":"https://avatars.githubusercontent.com/u/475847?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbergstrom","html_url":"https://github.com/larsbergstrom","followers_url":"https://api.github.com/users/larsbergstrom/followers","following_url":"https://api.github.com/users/larsbergstrom/following{/other_user}","gists_url":"https://api.github.com/users/larsbergstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbergstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbergstrom/subscriptions","organizations_url":"https://api.github.com/users/larsbergstrom/orgs","repos_url":"https://api.github.com/users/larsbergstrom/repos","events_url":"https://api.github.com/users/larsbergstrom/events{/privacy}","received_events_url":"https://api.github.com/users/larsbergstrom/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/14346/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/14346/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/14346/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/687a1844b9cf9eca62f7588a3be8cf2587862dfa","head":{"label":"mati865:master","ref":"master","sha":"687a1844b9cf9eca62f7588a3be8cf2587862dfa","user":{"login":"mati865","id":1174646,"avatar_url":"https://avatars.githubusercontent.com/u/1174646?v=3","gravatar_id":"","url":"https://api.github.com/users/mati865","html_url":"https://github.com/mati865","followers_url":"https://api.github.com/users/mati865/followers","following_url":"https://api.github.com/users/mati865/following{/other_user}","gists_url":"https://api.github.com/users/mati865/gists{/gist_id}","starred_url":"https://api.github.com/users/mati865/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mati865/subscriptions","organizations_url":"https://api.github.com/users/mati865/orgs","repos_url":"https://api.github.com/users/mati865/repos","events_url":"https://api.github.com/users/mati865/events{/privacy}","received_events_url":"https://api.github.com/users/mati865/received_events","type":"User","site_admin":false},"repo":{"id":74584823,"name":"servo","full_name":"mati865/servo","owner":{"login":"mati865","id":1174646,"avatar_url":"https://avatars.githubusercontent.com/u/1174646?v=3","gravatar_id":"","url":"https://api.github.com/users/mati865","html_url":"https://github.com/mati865","followers_url":"https://api.github.com/users/mati865/followers","following_url":"https://api.github.com/users/mati865/following{/other_user}","gists_url":"https://api.github.com/users/mati865/gists{/gist_id}","starred_url":"https://api.github.com/users/mati865/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mati865/subscriptions","organizations_url":"https://api.github.com/users/mati865/orgs","repos_url":"https://api.github.com/users/mati865/repos","events_url":"https://api.github.com/users/mati865/events{/privacy}","received_events_url":"https://api.github.com/users/mati865/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mati865/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/mati865/servo","forks_url":"https://api.github.com/repos/mati865/servo/forks","keys_url":"https://api.github.com/repos/mati865/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mati865/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mati865/servo/teams","hooks_url":"https://api.github.com/repos/mati865/servo/hooks","issue_events_url":"https://api.github.com/repos/mati865/servo/issues/events{/number}","events_url":"https://api.github.com/repos/mati865/servo/events","assignees_url":"https://api.github.com/repos/mati865/servo/assignees{/user}","branches_url":"https://api.github.com/repos/mati865/servo/branches{/branch}","tags_url":"https://api.github.com/repos/mati865/servo/tags","blobs_url":"https://api.github.com/repos/mati865/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mati865/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mati865/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mati865/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mati865/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/mati865/servo/languages","stargazers_url":"https://api.github.com/repos/mati865/servo/stargazers","contributors_url":"https://api.github.com/repos/mati865/servo/contributors","subscribers_url":"https://api.github.com/repos/mati865/servo/subscribers","subscription_url":"https://api.github.com/repos/mati865/servo/subscription","commits_url":"https://api.github.com/repos/mati865/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mati865/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mati865/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mati865/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mati865/servo/contents/{+path}","compare_url":"https://api.github.com/repos/mati865/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mati865/servo/merges","archive_url":"https://api.github.com/repos/mati865/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mati865/servo/downloads","issues_url":"https://api.github.com/repos/mati865/servo/issues{/number}","pulls_url":"https://api.github.com/repos/mati865/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/mati865/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/mati865/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mati865/servo/labels{/name}","releases_url":"https://api.github.com/repos/mati865/servo/releases{/id}","deployments_url":"https://api.github.com/repos/mati865/servo/deployments","created_at":"2016-11-23T14:35:25Z","updated_at":"2016-11-23T03:45:46Z","pushed_at":"2016-12-07T18:26:01Z","git_url":"git://github.com/mati865/servo.git","ssh_url":"git@github.com:mati865/servo.git","clone_url":"https://github.com/mati865/servo.git","svn_url":"https://github.com/mati865/servo","homepage":"https://servo.org/","size":220706,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"3818d3f23ffada9df346a1ddcac11442a889c40b","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-12-28T13:21:46Z","pushed_at":"2016-12-28T16:24:45Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":277973,"stargazers_count":8467,"watchers_count":8467,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1400,"mirror_url":null,"open_issues_count":1956,"forks":1400,"open_issues":1956,"watchers":8467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/14346"},"html":{"href":"https://github.com/servo/servo/pull/14346"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/14346"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/14346/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/14346/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/14346/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/687a1844b9cf9eca62f7588a3be8cf2587862dfa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":16,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":4,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"bors-servo"}}