{"action":"created","issue":{"url":"https://api.github.com/repos/npruehs/tome-editor/issues/61","repository_url":"https://api.github.com/repos/npruehs/tome-editor","labels_url":"https://api.github.com/repos/npruehs/tome-editor/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/npruehs/tome-editor/issues/61/comments","events_url":"https://api.github.com/repos/npruehs/tome-editor/issues/61/events","html_url":"https://github.com/npruehs/tome-editor/pull/61","id":173415052,"number":61,"title":"Applied custom changes","user":{"login":"pgrimsehl","id":21222416,"avatar_url":"https://avatars.githubusercontent.com/u/21222416?v=3","gravatar_id":"","url":"https://api.github.com/users/pgrimsehl","html_url":"https://github.com/pgrimsehl","followers_url":"https://api.github.com/users/pgrimsehl/followers","following_url":"https://api.github.com/users/pgrimsehl/following{/other_user}","gists_url":"https://api.github.com/users/pgrimsehl/gists{/gist_id}","starred_url":"https://api.github.com/users/pgrimsehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgrimsehl/subscriptions","organizations_url":"https://api.github.com/users/pgrimsehl/orgs","repos_url":"https://api.github.com/users/pgrimsehl/repos","events_url":"https://api.github.com/users/pgrimsehl/events{/privacy}","received_events_url":"https://api.github.com/users/pgrimsehl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/npruehs/tome-editor/labels/feature","name":"feature","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/npruehs/tome-editor/milestones/5","html_url":"https://github.com/npruehs/tome-editor/milestones/0.5%20(Dragon)","labels_url":"https://api.github.com/repos/npruehs/tome-editor/milestones/5/labels","id":1542754,"number":5,"title":"0.5 (Dragon)","description":"","creator":{"login":"npruehs","id":757321,"avatar_url":"https://avatars.githubusercontent.com/u/757321?v=3","gravatar_id":"","url":"https://api.github.com/users/npruehs","html_url":"https://github.com/npruehs","followers_url":"https://api.github.com/users/npruehs/followers","following_url":"https://api.github.com/users/npruehs/following{/other_user}","gists_url":"https://api.github.com/users/npruehs/gists{/gist_id}","starred_url":"https://api.github.com/users/npruehs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npruehs/subscriptions","organizations_url":"https://api.github.com/users/npruehs/orgs","repos_url":"https://api.github.com/users/npruehs/repos","events_url":"https://api.github.com/users/npruehs/events{/privacy}","received_events_url":"https://api.github.com/users/npruehs/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-01-25T21:52:40Z","updated_at":"2016-08-26T22:30:44Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-08-26T09:56:06Z","updated_at":"2016-08-30T11:42:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/npruehs/tome-editor/pulls/61","html_url":"https://github.com/npruehs/tome-editor/pull/61","diff_url":"https://github.com/npruehs/tome-editor/pull/61.diff","patch_url":"https://github.com/npruehs/tome-editor/pull/61.patch"},"body":"[pg-0000] locale can be defined in project file and is used for\r\ntextformatting of value strings (e.g. decimal point)\r\n[pg-0001] do not export empty records (use empty records to build folder\r\nstructures to organize records)\r\n[pg-0002] decimals in doubleSpinBox increased from 3 to 4\r\n[pg-0003] components can be selected in addition to fields when editing\r\nrecords\r\n[pg-0004] added description column to record field table and removed\r\ntooltip\r\n[pg-0005] added default icons for records, differentiating between empty\r\nrecords and records with fields (simulate \"folder hierarchy\")"},"comment":{"url":"https://api.github.com/repos/npruehs/tome-editor/issues/comments/243412996","html_url":"https://github.com/npruehs/tome-editor/pull/61#issuecomment-243412996","issue_url":"https://api.github.com/repos/npruehs/tome-editor/issues/61","id":243412996,"user":{"login":"npruehs","id":757321,"avatar_url":"https://avatars.githubusercontent.com/u/757321?v=3","gravatar_id":"","url":"https://api.github.com/users/npruehs","html_url":"https://github.com/npruehs","followers_url":"https://api.github.com/users/npruehs/followers","following_url":"https://api.github.com/users/npruehs/following{/other_user}","gists_url":"https://api.github.com/users/npruehs/gists{/gist_id}","starred_url":"https://api.github.com/users/npruehs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npruehs/subscriptions","organizations_url":"https://api.github.com/users/npruehs/orgs","repos_url":"https://api.github.com/users/npruehs/repos","events_url":"https://api.github.com/users/npruehs/events{/privacy}","received_events_url":"https://api.github.com/users/npruehs/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T11:42:23Z","updated_at":"2016-08-30T11:42:23Z","body":"Thanks, will take a look at it this evening! Are you familiar with Pull/Rebase in Git? Otherwise I will handle the merge conflicts on my side.\r\n\r\n[pg-0001]/[pg-0003]\r\n\r\nRecords do inherit all fields, along with their components and field values. Thus, concerning [pg-0001], by definition, children of empty records cannot be empty. Concerning [pg-0003], you can just create an NPC record and all eight components. All NPCs should derive from that record, and will automatically inherit all eight components along with their default values. Or am I missing something else here you're trying to achieve?\r\n\r\n`RecordsController::getInheritedFieldValues` will return a combined `RecordFieldValueMap` along the inheritance tree, for convenience.\r\n\r\nhttps://github.com/npruehs/tome-editor/blob/develop/Source/Tome/Features/Records/Controller/recordscontroller.cpp\r\n\r\n[pg-0000]/[pg-0002]/[pg-0004]\r\n\r\nThere is #16 for adding project settings. Whenever you come up with something you feel should be added, just add a comment there! Will add it in a upcoming release.\r\n"}}
{"actor":{"display_login":"npruehs"}}