{"action":"closed","number":453,"pull_request":{"url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453","id":63606449,"html_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/453","diff_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/453.diff","patch_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/453.patch","issue_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/453","number":453,"state":"closed","locked":false,"title":"Make Webpack Upgradable and DRY","user":{"login":"Spittal","id":1229177,"avatar_url":"https://avatars.githubusercontent.com/u/1229177?v=3","gravatar_id":"","url":"https://api.github.com/users/Spittal","html_url":"https://github.com/Spittal","followers_url":"https://api.github.com/users/Spittal/followers","following_url":"https://api.github.com/users/Spittal/following{/other_user}","gists_url":"https://api.github.com/users/Spittal/gists{/gist_id}","starred_url":"https://api.github.com/users/Spittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spittal/subscriptions","organizations_url":"https://api.github.com/users/Spittal/orgs","repos_url":"https://api.github.com/users/Spittal/repos","events_url":"https://api.github.com/users/Spittal/events{/privacy}","received_events_url":"https://api.github.com/users/Spittal/received_events","type":"User","site_admin":false},"body":"* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nThe webpack configuration has been changed so that components of the configuration that is shared between production and development are now in one file. It makes the files more cohesive and easier to update. \r\n\r\nI've tried introducing this before, but was rejected on grounds of complexity. I would like to argue that this configuration is yes slightly more complex (not anymore complex than other parts of this starter pack) but makes it much easier to to merge in changes from this repo into existing projects. Not only does it allow you put your custom loaders in a single file, but also the \"config\" object having the ability to be passed around means that you can merge changes from this repo much easier without breaking some \"application specific\" changes.\r\n\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\nThere is a lots of duplicate code in the webpack configurations.\r\n\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\nMade the webpack conmfiguration more dry, and more scalable.\r\n\r\n\r\n* **Other information**:\r\nI've been trying to stay up to date with the latest polyfills, and beta versions of Angular while developing an application, It's important to me that I am able to quickly apply changes made in this repo to my own applications. This PR would make that process much faster for me.","created_at":"2016-03-21T18:02:00Z","updated_at":"2016-03-28T17:50:32Z","closed_at":"2016-03-28T17:50:32Z","merged_at":"2016-03-28T17:50:32Z","merge_commit_sha":"19f7b293df87b2b9669e93d0488582cc971f9e2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453/commits","review_comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453/comments","review_comment_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/453/comments","statuses_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/b4fbe1a11373dd9e96236c9c0aae3c4f51dd83aa","head":{"label":"Spittal:master","ref":"master","sha":"b4fbe1a11373dd9e96236c9c0aae3c4f51dd83aa","user":{"login":"Spittal","id":1229177,"avatar_url":"https://avatars.githubusercontent.com/u/1229177?v=3","gravatar_id":"","url":"https://api.github.com/users/Spittal","html_url":"https://github.com/Spittal","followers_url":"https://api.github.com/users/Spittal/followers","following_url":"https://api.github.com/users/Spittal/following{/other_user}","gists_url":"https://api.github.com/users/Spittal/gists{/gist_id}","starred_url":"https://api.github.com/users/Spittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spittal/subscriptions","organizations_url":"https://api.github.com/users/Spittal/orgs","repos_url":"https://api.github.com/users/Spittal/repos","events_url":"https://api.github.com/users/Spittal/events{/privacy}","received_events_url":"https://api.github.com/users/Spittal/received_events","type":"User","site_admin":false},"repo":{"id":51602629,"name":"angular2-webpack-starter","full_name":"Spittal/angular2-webpack-starter","owner":{"login":"Spittal","id":1229177,"avatar_url":"https://avatars.githubusercontent.com/u/1229177?v=3","gravatar_id":"","url":"https://api.github.com/users/Spittal","html_url":"https://github.com/Spittal","followers_url":"https://api.github.com/users/Spittal/followers","following_url":"https://api.github.com/users/Spittal/following{/other_user}","gists_url":"https://api.github.com/users/Spittal/gists{/gist_id}","starred_url":"https://api.github.com/users/Spittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spittal/subscriptions","organizations_url":"https://api.github.com/users/Spittal/orgs","repos_url":"https://api.github.com/users/Spittal/repos","events_url":"https://api.github.com/users/Spittal/events{/privacy}","received_events_url":"https://api.github.com/users/Spittal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spittal/angular2-webpack-starter","description":"An Angular 2 Webpack Starter kit featuring Angular 2 (Router, Http, Forms, Services, Tests, E2E, Dev/Prod), Karma, Protractor, Jasmine, Istanbul, TypeScript, TsLint, Typings, and Webpack by @AngularClass","fork":true,"url":"https://api.github.com/repos/Spittal/angular2-webpack-starter","forks_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/forks","keys_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/teams","hooks_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/hooks","issue_events_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/issues/events{/number}","events_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/events","assignees_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/assignees{/user}","branches_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/branches{/branch}","tags_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/tags","blobs_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/languages","stargazers_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/stargazers","contributors_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/contributors","subscribers_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/subscribers","subscription_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/subscription","commits_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/contents/{+path}","compare_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/merges","archive_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/downloads","issues_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/issues{/number}","pulls_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/labels{/name}","releases_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/releases{/id}","deployments_url":"https://api.github.com/repos/Spittal/angular2-webpack-starter/deployments","created_at":"2016-02-12T16:57:48Z","updated_at":"2016-03-18T20:47:06Z","pushed_at":"2016-03-28T16:30:36Z","git_url":"git://github.com/Spittal/angular2-webpack-starter.git","ssh_url":"git@github.com:Spittal/angular2-webpack-starter.git","clone_url":"https://github.com/Spittal/angular2-webpack-starter.git","svn_url":"https://github.com/Spittal/angular2-webpack-starter","homepage":"https://angularclass.github.io/angular2-webpack-starter/","size":1917,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AngularClass:master","ref":"master","sha":"f1d49a9bf534bc1d91c25535bd8c1fe97906f0b6","user":{"login":"AngularClass","id":11602678,"avatar_url":"https://avatars.githubusercontent.com/u/11602678?v=3","gravatar_id":"","url":"https://api.github.com/users/AngularClass","html_url":"https://github.com/AngularClass","followers_url":"https://api.github.com/users/AngularClass/followers","following_url":"https://api.github.com/users/AngularClass/following{/other_user}","gists_url":"https://api.github.com/users/AngularClass/gists{/gist_id}","starred_url":"https://api.github.com/users/AngularClass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngularClass/subscriptions","organizations_url":"https://api.github.com/users/AngularClass/orgs","repos_url":"https://api.github.com/users/AngularClass/repos","events_url":"https://api.github.com/users/AngularClass/events{/privacy}","received_events_url":"https://api.github.com/users/AngularClass/received_events","type":"Organization","site_admin":false},"repo":{"id":31829770,"name":"angular2-webpack-starter","full_name":"AngularClass/angular2-webpack-starter","owner":{"login":"AngularClass","id":11602678,"avatar_url":"https://avatars.githubusercontent.com/u/11602678?v=3","gravatar_id":"","url":"https://api.github.com/users/AngularClass","html_url":"https://github.com/AngularClass","followers_url":"https://api.github.com/users/AngularClass/followers","following_url":"https://api.github.com/users/AngularClass/following{/other_user}","gists_url":"https://api.github.com/users/AngularClass/gists{/gist_id}","starred_url":"https://api.github.com/users/AngularClass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngularClass/subscriptions","organizations_url":"https://api.github.com/users/AngularClass/orgs","repos_url":"https://api.github.com/users/AngularClass/repos","events_url":"https://api.github.com/users/AngularClass/events{/privacy}","received_events_url":"https://api.github.com/users/AngularClass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AngularClass/angular2-webpack-starter","description":"An Angular 2 Starter kit featuring Angular 2 (Router, Http, Forms, Services, Tests, E2E, Dev/Prod), Karma, Protractor, Jasmine, Istanbul, TypeScript, TsLint, Codelyzer, Hot Module Replacement, Typings, and Webpack by @AngularClass","fork":false,"url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter","forks_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/forks","keys_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/teams","hooks_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/hooks","issue_events_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/events{/number}","events_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/events","assignees_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/assignees{/user}","branches_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/branches{/branch}","tags_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/tags","blobs_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/languages","stargazers_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/stargazers","contributors_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/contributors","subscribers_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/subscribers","subscription_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/subscription","commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/contents/{+path}","compare_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/merges","archive_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/downloads","issues_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues{/number}","pulls_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/labels{/name}","releases_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/releases{/id}","deployments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/deployments","created_at":"2015-03-07T22:25:10Z","updated_at":"2016-03-28T17:20:39Z","pushed_at":"2016-03-28T17:50:32Z","git_url":"git://github.com/AngularClass/angular2-webpack-starter.git","ssh_url":"git@github.com:AngularClass/angular2-webpack-starter.git","clone_url":"https://github.com/AngularClass/angular2-webpack-starter.git","svn_url":"https://github.com/AngularClass/angular2-webpack-starter","homepage":"https://angularclass.github.io/angular2-webpack-starter/","size":3309,"stargazers_count":2253,"watchers_count":2253,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1015,"mirror_url":null,"open_issues_count":60,"forks":1015,"open_issues":60,"watchers":2253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453"},"html":{"href":"https://github.com/AngularClass/angular2-webpack-starter/pull/453"},"issue":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/453"},"comments":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/b4fbe1a11373dd9e96236c9c0aae3c4f51dd83aa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gdi2290","id":1016365,"avatar_url":"https://avatars.githubusercontent.com/u/1016365?v=3","gravatar_id":"","url":"https://api.github.com/users/gdi2290","html_url":"https://github.com/gdi2290","followers_url":"https://api.github.com/users/gdi2290/followers","following_url":"https://api.github.com/users/gdi2290/following{/other_user}","gists_url":"https://api.github.com/users/gdi2290/gists{/gist_id}","starred_url":"https://api.github.com/users/gdi2290/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdi2290/subscriptions","organizations_url":"https://api.github.com/users/gdi2290/orgs","repos_url":"https://api.github.com/users/gdi2290/repos","events_url":"https://api.github.com/users/gdi2290/events{/privacy}","received_events_url":"https://api.github.com/users/gdi2290/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":10,"additions":306,"deletions":451,"changed_files":4}}