{"action":"created","comment":{"url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/comments/85709183","pull_request_review_id":6408294,"id":85709183,"diff_hunk":"@@ -19,39 +18,87 @@ let latestSeq = 'unknown'\n // const GLOBAL_INDEX = '-/index.json'\n // const NOT_FOUND = '-/404.json'\n \n-module.exports = RegistryClone\n-\n-function RegistryClone (ipfs, opts) {\n-  if (!(this instanceof RegistryClone)) {\n-    return new RegistryClone(ipfs, opts)\n+module.exports = function registryClone (opts) {\n+  opts = opts || {\n+    store: require('ipfs-blob-store')\n   }\n \n-  let bsConfig = config.blobStore\n-  opts = opts || {}\n+  let storeConfig = config.blobStore\n \n   if (opts.url) {\n     const parsed = multiaddr(opts.url).nodeAddress()\n-    bsConfig = Object.assign(bsConfig, {\n+    storeConfig = Object.assign(storeConfig, {\n       host: parsed.address,\n-      port: parsed.port\n+      port: parseInt(parsed.port, 10)\n     })\n   }\n \n   if (typeof opts.flush === 'boolean') {\n-    bsConfig.flush = opts.flush\n+    storeConfig.flush = opts.flush\n+  }\n+\n+  const followConf = {\n+    seqFile: config.seqFile,\n+    handler: changeHandler,\n+    registry: config.registry,\n+    skim: config.skim\n   }\n \n   if (opts.seqNumber) {\n-    // TODO: what to do?\n+    followConf.since = opts.seqNumber\n   }","path":"src/ipfs-npm/registry/clone/index.js","position":null,"original_position":54,"commit_id":"fa02825c11c74d9af72a93eb010193e15fa78d1b","original_commit_id":"e0e26d5c94e7bb740f1cd69d391273d56237627e","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"body":"@diasdavid `since` is the name `follow-registry` understands, passing `seqNumber` wouldn't work","created_at":"2016-10-31T09:54:56Z","updated_at":"2016-10-31T09:54:56Z","html_url":"https://github.com/diasdavid/npm-on-ipfs/pull/45#discussion_r85709183","pull_request_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/comments/85709183"},"html":{"href":"https://github.com/diasdavid/npm-on-ipfs/pull/45#discussion_r85709183"},"pull_request":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45","id":90818289,"html_url":"https://github.com/diasdavid/npm-on-ipfs/pull/45","diff_url":"https://github.com/diasdavid/npm-on-ipfs/pull/45.diff","patch_url":"https://github.com/diasdavid/npm-on-ipfs/pull/45.patch","issue_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/45","number":45,"state":"closed","locked":false,"title":"[WIP] Improve, fix and finish","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"body":"I started working on this last night and will continue on this over the next weeks, as I really want to use this\n","created_at":"2016-10-25T14:23:51Z","updated_at":"2016-10-31T09:54:56Z","closed_at":"2016-10-31T08:11:40Z","merged_at":"2016-10-31T08:11:40Z","merge_commit_sha":"fc2fa873bfc3fad053b1d59879b77070d9e3aefe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45/commits","review_comments_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45/comments","review_comment_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/45/comments","statuses_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/statuses/fa02825c11c74d9af72a93eb010193e15fa78d1b","head":{"label":"dignifiedquire:ipfs-npm","ref":"ipfs-npm","sha":"fa02825c11c74d9af72a93eb010193e15fa78d1b","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"repo":{"id":46568237,"name":"npm-on-ipfs","full_name":"dignifiedquire/npm-on-ipfs","owner":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dignifiedquire/npm-on-ipfs","description":"Set up a NPM registry mirror, using your favourite storage, including IPFS! :D","fork":true,"url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs","forks_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/forks","keys_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/teams","hooks_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/hooks","issue_events_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/events","assignees_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/tags","blobs_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/languages","stargazers_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/stargazers","contributors_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/contributors","subscribers_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/subscribers","subscription_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/subscription","commits_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/merges","archive_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/downloads","issues_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/dignifiedquire/npm-on-ipfs/deployments","created_at":"2015-11-20T14:58:08Z","updated_at":"2016-10-21T19:32:59Z","pushed_at":"2016-10-31T00:23:41Z","git_url":"git://github.com/dignifiedquire/npm-on-ipfs.git","ssh_url":"git@github.com:dignifiedquire/npm-on-ipfs.git","clone_url":"https://github.com/dignifiedquire/npm-on-ipfs.git","svn_url":"https://github.com/dignifiedquire/npm-on-ipfs","homepage":null,"size":77226,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diasdavid:ipfs-npm","ref":"ipfs-npm","sha":"dd60eb3ec1ecb2c61e92cb1d43b28017ae4c4e7e","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"repo":{"id":46182325,"name":"npm-on-ipfs","full_name":"diasdavid/npm-on-ipfs","owner":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diasdavid/npm-on-ipfs","description":":package: Install npm modules through IPFS! ","fork":false,"url":"https://api.github.com/repos/diasdavid/npm-on-ipfs","forks_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/forks","keys_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/teams","hooks_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/hooks","issue_events_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/events","assignees_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/tags","blobs_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/languages","stargazers_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/stargazers","contributors_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/contributors","subscribers_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/subscribers","subscription_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/subscription","commits_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/merges","archive_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/downloads","issues_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/diasdavid/npm-on-ipfs/deployments","created_at":"2015-11-14T16:34:30Z","updated_at":"2016-10-24T15:00:50Z","pushed_at":"2016-10-31T08:11:40Z","git_url":"git://github.com/diasdavid/npm-on-ipfs.git","ssh_url":"git@github.com:diasdavid/npm-on-ipfs.git","clone_url":"https://github.com/diasdavid/npm-on-ipfs.git","svn_url":"https://github.com/diasdavid/npm-on-ipfs","homepage":"","size":77231,"stargazers_count":86,"watchers_count":86,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45"},"html":{"href":"https://github.com/diasdavid/npm-on-ipfs/pull/45"},"issue":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/45"},"comments":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/diasdavid/npm-on-ipfs/statuses/fa02825c11c74d9af72a93eb010193e15fa78d1b"}}}}
{"actor":{"display_login":"dignifiedquire"}}