{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34","id":68164771,"html_url":"https://github.com/isleofcode/ember-cordova/pull/34","diff_url":"https://github.com/isleofcode/ember-cordova/pull/34.diff","patch_url":"https://github.com/isleofcode/ember-cordova/pull/34.patch","issue_url":"https://api.github.com/repos/isleofcode/ember-cordova/issues/34","number":34,"state":"closed","locked":false,"title":"Use resolveRegistration rather than container.lookupFactory to get env","user":{"login":"gilest","id":36919,"avatar_url":"https://avatars.githubusercontent.com/u/36919?v=3","gravatar_id":"","url":"https://api.github.com/users/gilest","html_url":"https://github.com/gilest","followers_url":"https://api.github.com/users/gilest/followers","following_url":"https://api.github.com/users/gilest/following{/other_user}","gists_url":"https://api.github.com/users/gilest/gists{/gist_id}","starred_url":"https://api.github.com/users/gilest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilest/subscriptions","organizations_url":"https://api.github.com/users/gilest/orgs","repos_url":"https://api.github.com/users/gilest/repos","events_url":"https://api.github.com/users/gilest/events{/privacy}","received_events_url":"https://api.github.com/users/gilest/received_events","type":"User","site_admin":false},"body":"`1.0.3` errors for me within the `in-app-livereload` instance initializer.\r\n\r\n> TypeError: app.container.lookupFactory is not a function. (In 'app.container.lookupFactory('config:environment')', 'app.container.lookupFactory' is undefined)\r\n\r\nI'm running ember  `2.5.1` in an iOS 9.3 iPad 2 simulator.\r\n\r\nI think the `container.lookupFactory` public API may have been removed in newer versions of ember.\r\n\r\nUsing `resolveRegistration` works well for my setup, but it may not work so well in older versions of ember. Note that the old `__container__.lookupFactory` that was altered in #26 also still works for me.","created_at":"2016-04-28T05:10:22Z","updated_at":"2016-05-03T02:19:58Z","closed_at":"2016-05-03T02:19:58Z","merged_at":"2016-05-03T02:19:58Z","merge_commit_sha":"9702cf0a66e26860102b2a091bc1d1600d200e57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34/commits","review_comments_url":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34/comments","review_comment_url":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/comments{/number}","comments_url":"https://api.github.com/repos/isleofcode/ember-cordova/issues/34/comments","statuses_url":"https://api.github.com/repos/isleofcode/ember-cordova/statuses/9702cf0a66e26860102b2a091bc1d1600d200e57","head":{"label":"gilest:master","ref":"master","sha":"9702cf0a66e26860102b2a091bc1d1600d200e57","user":{"login":"gilest","id":36919,"avatar_url":"https://avatars.githubusercontent.com/u/36919?v=3","gravatar_id":"","url":"https://api.github.com/users/gilest","html_url":"https://github.com/gilest","followers_url":"https://api.github.com/users/gilest/followers","following_url":"https://api.github.com/users/gilest/following{/other_user}","gists_url":"https://api.github.com/users/gilest/gists{/gist_id}","starred_url":"https://api.github.com/users/gilest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilest/subscriptions","organizations_url":"https://api.github.com/users/gilest/orgs","repos_url":"https://api.github.com/users/gilest/repos","events_url":"https://api.github.com/users/gilest/events{/privacy}","received_events_url":"https://api.github.com/users/gilest/received_events","type":"User","site_admin":false},"repo":{"id":57272062,"name":"ember-cordova","full_name":"gilest/ember-cordova","owner":{"login":"gilest","id":36919,"avatar_url":"https://avatars.githubusercontent.com/u/36919?v=3","gravatar_id":"","url":"https://api.github.com/users/gilest","html_url":"https://github.com/gilest","followers_url":"https://api.github.com/users/gilest/followers","following_url":"https://api.github.com/users/gilest/following{/other_user}","gists_url":"https://api.github.com/users/gilest/gists{/gist_id}","starred_url":"https://api.github.com/users/gilest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilest/subscriptions","organizations_url":"https://api.github.com/users/gilest/orgs","repos_url":"https://api.github.com/users/gilest/repos","events_url":"https://api.github.com/users/gilest/events{/privacy}","received_events_url":"https://api.github.com/users/gilest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gilest/ember-cordova","description":"","fork":true,"url":"https://api.github.com/repos/gilest/ember-cordova","forks_url":"https://api.github.com/repos/gilest/ember-cordova/forks","keys_url":"https://api.github.com/repos/gilest/ember-cordova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilest/ember-cordova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilest/ember-cordova/teams","hooks_url":"https://api.github.com/repos/gilest/ember-cordova/hooks","issue_events_url":"https://api.github.com/repos/gilest/ember-cordova/issues/events{/number}","events_url":"https://api.github.com/repos/gilest/ember-cordova/events","assignees_url":"https://api.github.com/repos/gilest/ember-cordova/assignees{/user}","branches_url":"https://api.github.com/repos/gilest/ember-cordova/branches{/branch}","tags_url":"https://api.github.com/repos/gilest/ember-cordova/tags","blobs_url":"https://api.github.com/repos/gilest/ember-cordova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilest/ember-cordova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilest/ember-cordova/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilest/ember-cordova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilest/ember-cordova/statuses/{sha}","languages_url":"https://api.github.com/repos/gilest/ember-cordova/languages","stargazers_url":"https://api.github.com/repos/gilest/ember-cordova/stargazers","contributors_url":"https://api.github.com/repos/gilest/ember-cordova/contributors","subscribers_url":"https://api.github.com/repos/gilest/ember-cordova/subscribers","subscription_url":"https://api.github.com/repos/gilest/ember-cordova/subscription","commits_url":"https://api.github.com/repos/gilest/ember-cordova/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilest/ember-cordova/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilest/ember-cordova/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilest/ember-cordova/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilest/ember-cordova/contents/{+path}","compare_url":"https://api.github.com/repos/gilest/ember-cordova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilest/ember-cordova/merges","archive_url":"https://api.github.com/repos/gilest/ember-cordova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilest/ember-cordova/downloads","issues_url":"https://api.github.com/repos/gilest/ember-cordova/issues{/number}","pulls_url":"https://api.github.com/repos/gilest/ember-cordova/pulls{/number}","milestones_url":"https://api.github.com/repos/gilest/ember-cordova/milestones{/number}","notifications_url":"https://api.github.com/repos/gilest/ember-cordova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilest/ember-cordova/labels{/name}","releases_url":"https://api.github.com/repos/gilest/ember-cordova/releases{/id}","deployments_url":"https://api.github.com/repos/gilest/ember-cordova/deployments","created_at":"2016-04-28T04:53:56Z","updated_at":"2016-04-28T04:53:57Z","pushed_at":"2016-04-28T04:58:27Z","git_url":"git://github.com/gilest/ember-cordova.git","ssh_url":"git@github.com:gilest/ember-cordova.git","clone_url":"https://github.com/gilest/ember-cordova.git","svn_url":"https://github.com/gilest/ember-cordova","homepage":null,"size":1396,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"isleofcode:master","ref":"master","sha":"7373b215162fcac38bc1fed75d52a92e193e6e8f","user":{"login":"isleofcode","id":8960029,"avatar_url":"https://avatars.githubusercontent.com/u/8960029?v=3","gravatar_id":"","url":"https://api.github.com/users/isleofcode","html_url":"https://github.com/isleofcode","followers_url":"https://api.github.com/users/isleofcode/followers","following_url":"https://api.github.com/users/isleofcode/following{/other_user}","gists_url":"https://api.github.com/users/isleofcode/gists{/gist_id}","starred_url":"https://api.github.com/users/isleofcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isleofcode/subscriptions","organizations_url":"https://api.github.com/users/isleofcode/orgs","repos_url":"https://api.github.com/users/isleofcode/repos","events_url":"https://api.github.com/users/isleofcode/events{/privacy}","received_events_url":"https://api.github.com/users/isleofcode/received_events","type":"Organization","site_admin":false},"repo":{"id":53808826,"name":"ember-cordova","full_name":"isleofcode/ember-cordova","owner":{"login":"isleofcode","id":8960029,"avatar_url":"https://avatars.githubusercontent.com/u/8960029?v=3","gravatar_id":"","url":"https://api.github.com/users/isleofcode","html_url":"https://github.com/isleofcode","followers_url":"https://api.github.com/users/isleofcode/followers","following_url":"https://api.github.com/users/isleofcode/following{/other_user}","gists_url":"https://api.github.com/users/isleofcode/gists{/gist_id}","starred_url":"https://api.github.com/users/isleofcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isleofcode/subscriptions","organizations_url":"https://api.github.com/users/isleofcode/orgs","repos_url":"https://api.github.com/users/isleofcode/repos","events_url":"https://api.github.com/users/isleofcode/events{/privacy}","received_events_url":"https://api.github.com/users/isleofcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/isleofcode/ember-cordova","description":"","fork":false,"url":"https://api.github.com/repos/isleofcode/ember-cordova","forks_url":"https://api.github.com/repos/isleofcode/ember-cordova/forks","keys_url":"https://api.github.com/repos/isleofcode/ember-cordova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isleofcode/ember-cordova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isleofcode/ember-cordova/teams","hooks_url":"https://api.github.com/repos/isleofcode/ember-cordova/hooks","issue_events_url":"https://api.github.com/repos/isleofcode/ember-cordova/issues/events{/number}","events_url":"https://api.github.com/repos/isleofcode/ember-cordova/events","assignees_url":"https://api.github.com/repos/isleofcode/ember-cordova/assignees{/user}","branches_url":"https://api.github.com/repos/isleofcode/ember-cordova/branches{/branch}","tags_url":"https://api.github.com/repos/isleofcode/ember-cordova/tags","blobs_url":"https://api.github.com/repos/isleofcode/ember-cordova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isleofcode/ember-cordova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isleofcode/ember-cordova/git/refs{/sha}","trees_url":"https://api.github.com/repos/isleofcode/ember-cordova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isleofcode/ember-cordova/statuses/{sha}","languages_url":"https://api.github.com/repos/isleofcode/ember-cordova/languages","stargazers_url":"https://api.github.com/repos/isleofcode/ember-cordova/stargazers","contributors_url":"https://api.github.com/repos/isleofcode/ember-cordova/contributors","subscribers_url":"https://api.github.com/repos/isleofcode/ember-cordova/subscribers","subscription_url":"https://api.github.com/repos/isleofcode/ember-cordova/subscription","commits_url":"https://api.github.com/repos/isleofcode/ember-cordova/commits{/sha}","git_commits_url":"https://api.github.com/repos/isleofcode/ember-cordova/git/commits{/sha}","comments_url":"https://api.github.com/repos/isleofcode/ember-cordova/comments{/number}","issue_comment_url":"https://api.github.com/repos/isleofcode/ember-cordova/issues/comments{/number}","contents_url":"https://api.github.com/repos/isleofcode/ember-cordova/contents/{+path}","compare_url":"https://api.github.com/repos/isleofcode/ember-cordova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isleofcode/ember-cordova/merges","archive_url":"https://api.github.com/repos/isleofcode/ember-cordova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isleofcode/ember-cordova/downloads","issues_url":"https://api.github.com/repos/isleofcode/ember-cordova/issues{/number}","pulls_url":"https://api.github.com/repos/isleofcode/ember-cordova/pulls{/number}","milestones_url":"https://api.github.com/repos/isleofcode/ember-cordova/milestones{/number}","notifications_url":"https://api.github.com/repos/isleofcode/ember-cordova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isleofcode/ember-cordova/labels{/name}","releases_url":"https://api.github.com/repos/isleofcode/ember-cordova/releases{/id}","deployments_url":"https://api.github.com/repos/isleofcode/ember-cordova/deployments","created_at":"2016-03-13T21:30:58Z","updated_at":"2016-05-01T09:08:15Z","pushed_at":"2016-05-03T02:19:58Z","git_url":"git://github.com/isleofcode/ember-cordova.git","ssh_url":"git@github.com:isleofcode/ember-cordova.git","clone_url":"https://github.com/isleofcode/ember-cordova.git","svn_url":"https://github.com/isleofcode/ember-cordova","homepage":null,"size":1397,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34"},"html":{"href":"https://github.com/isleofcode/ember-cordova/pull/34"},"issue":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/issues/34"},"comments":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/isleofcode/ember-cordova/statuses/9702cf0a66e26860102b2a091bc1d1600d200e57"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AlexBlom","id":246898,"avatar_url":"https://avatars.githubusercontent.com/u/246898?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexBlom","html_url":"https://github.com/AlexBlom","followers_url":"https://api.github.com/users/AlexBlom/followers","following_url":"https://api.github.com/users/AlexBlom/following{/other_user}","gists_url":"https://api.github.com/users/AlexBlom/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBlom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBlom/subscriptions","organizations_url":"https://api.github.com/users/AlexBlom/orgs","repos_url":"https://api.github.com/users/AlexBlom/repos","events_url":"https://api.github.com/users/AlexBlom/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBlom/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}