{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/69328294","id":69328294,"diff_hunk":"@@ -30,44 +30,72 @@\n     @timeupdate=\"timeUpdate\"\n     @loadedmetadata=\"setTotalTime\"\n     v-el:audio \n-    src=\"http://www.stephaniequinn.com/Music/Commercial%20DEMO%20-%2004.mp3\">\n-  </audio>\n+    src=\"http://www.stephaniequinn.com/Music/Commercial%20DEMO%20-%2004.mp3\"\n+    ></audio>\n \n </template>\n \n \n <script>\n \n+  const logging = require('loglevel');\n   require('html5media/dist/api/1.1.8/html5media');\n   module.exports = {\n \n     data: () => ({\n-      isPlay: true,\n-      isPause: false,\n-      timebarChanged: false,\n-      currentMinutes: 0,\n-      currentSeconds: 0,\n-      totalMinutes: 0,\n-      totalSeconds: 0,\n+      isPlay: {\n+        type: Boolean,\n+        status: true,\n+      },\n+      isPause: {\n+        type: Boolean,\n+        status: false,\n+      },\n+      timebarChanged: {\n+        type: Boolean,\n+        status: false,\n+      },\n+      currentMinutes: {\n+        type: Number,\n+        min: 0,\n+      },\n+      currentSeconds: {\n+        type: Number,\n+        sec: 0,\n+      },\n+      totalMinutes: {\n+        type: Number,\n+        totalmin: 0,\n+      },\n+      totalSeconds: {\n+        type: Number,\n+        totalsec: 0,\n+      },","path":"kolibri/plugins/audio_mp3_render/assets/src/vue/index.vue","position":76,"original_position":77,"commit_id":"23d06f7b3d2df94b534326305dd1d32033e81fcc","original_commit_id":"23d06f7b3d2df94b534326305dd1d32033e81fcc","user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars.githubusercontent.com/u/2367265?v=3","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"body":"My bad! didn't mean to imply that","created_at":"2016-07-01T16:59:34Z","updated_at":"2016-07-01T16:59:34Z","html_url":"https://github.com/learningequality/kolibri/pull/169#discussion_r69328294","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/69328294"},"html":{"href":"https://github.com/learningequality/kolibri/pull/169#discussion_r69328294"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/169","id":74984697,"html_url":"https://github.com/learningequality/kolibri/pull/169","diff_url":"https://github.com/learningequality/kolibri/pull/169.diff","patch_url":"https://github.com/learningequality/kolibri/pull/169.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/169","number":169,"state":"open","locked":false,"title":"WIP - Audio Renderer","user":{"login":"jtamiace","id":6668144,"avatar_url":"https://avatars.githubusercontent.com/u/6668144?v=3","gravatar_id":"","url":"https://api.github.com/users/jtamiace","html_url":"https://github.com/jtamiace","followers_url":"https://api.github.com/users/jtamiace/followers","following_url":"https://api.github.com/users/jtamiace/following{/other_user}","gists_url":"https://api.github.com/users/jtamiace/gists{/gist_id}","starred_url":"https://api.github.com/users/jtamiace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtamiace/subscriptions","organizations_url":"https://api.github.com/users/jtamiace/orgs","repos_url":"https://api.github.com/users/jtamiace/repos","events_url":"https://api.github.com/users/jtamiace/events{/privacy}","received_events_url":"https://api.github.com/users/jtamiace/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nAudio renderer for Kolibri. Will continue to update this PR with commits that add functionality to the elements.\r\n\r\n## TODO\r\n\r\nHigher priority\r\n- [x] HTML/CSS layout\r\n- [x] Install html5media.js library, which allows HTML5 audio tag to run on all browsers (thanks to @rtibbles )\r\n- [x] Play/pause button works\r\n- [x] Current time / total time shows\r\n- [x] Current time / total time is in XX:XX format\r\n- [x] Round tracker moves across screen as audio plays\r\n- [x] Round tracker can be dragged and updates time\r\n- [ ] Time tracker styles are compatible across (reasonably most) browsers\r\n\r\nLess priority\r\n- [x] Restart button works\r\n- [x] + 10s button works\r\n- [x] - 10s button works\r\n- [ ] Show buffering progress in time tracker\r\n\r\n- [ ] Have tests been written for the new code?\r\n- [ ] Has documentation been written/updated?\r\n- [ ] New dependencies (if any) added to requirements file\r\n- [ ] Add an entry to CHANGELOG.rst\r\n- [ ] Add yourself it AUTHORS.rst if you don't appear there\r\n\r\n## Reviewer guidance\r\n\r\n\r\n## Issues addressed\r\n\r\nList the issues solved or partly solved by the PR\r\n\r\n## Documentation\r\n\r\nIf the PR has documentation, link the file here (either .rst in your repo or if built on Read The Docs)\r\n\r\n## Screenshots (if appropriate)\r\n\r\n![audio 2](https://cloud.githubusercontent.com/assets/6668144/16425229/6db6c010-3d18-11e6-82ff-27b303642d95.PNG)\r\n\r\n","created_at":"2016-06-23T16:21:55Z","updated_at":"2016-07-01T16:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70fb71e0bf879ce188ad6b809e785269fc6137a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/169/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/169/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/169/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/23d06f7b3d2df94b534326305dd1d32033e81fcc","head":{"label":"jtamiace:audio-page","ref":"audio-page","sha":"23d06f7b3d2df94b534326305dd1d32033e81fcc","user":{"login":"jtamiace","id":6668144,"avatar_url":"https://avatars.githubusercontent.com/u/6668144?v=3","gravatar_id":"","url":"https://api.github.com/users/jtamiace","html_url":"https://github.com/jtamiace","followers_url":"https://api.github.com/users/jtamiace/followers","following_url":"https://api.github.com/users/jtamiace/following{/other_user}","gists_url":"https://api.github.com/users/jtamiace/gists{/gist_id}","starred_url":"https://api.github.com/users/jtamiace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtamiace/subscriptions","organizations_url":"https://api.github.com/users/jtamiace/orgs","repos_url":"https://api.github.com/users/jtamiace/repos","events_url":"https://api.github.com/users/jtamiace/events{/privacy}","received_events_url":"https://api.github.com/users/jtamiace/received_events","type":"User","site_admin":false},"repo":{"id":61400481,"name":"kolibri","full_name":"jtamiace/kolibri","owner":{"login":"jtamiace","id":6668144,"avatar_url":"https://avatars.githubusercontent.com/u/6668144?v=3","gravatar_id":"","url":"https://api.github.com/users/jtamiace","html_url":"https://github.com/jtamiace","followers_url":"https://api.github.com/users/jtamiace/followers","following_url":"https://api.github.com/users/jtamiace/following{/other_user}","gists_url":"https://api.github.com/users/jtamiace/gists{/gist_id}","starred_url":"https://api.github.com/users/jtamiace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtamiace/subscriptions","organizations_url":"https://api.github.com/users/jtamiace/orgs","repos_url":"https://api.github.com/users/jtamiace/repos","events_url":"https://api.github.com/users/jtamiace/events{/privacy}","received_events_url":"https://api.github.com/users/jtamiace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtamiace/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/jtamiace/kolibri","forks_url":"https://api.github.com/repos/jtamiace/kolibri/forks","keys_url":"https://api.github.com/repos/jtamiace/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtamiace/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtamiace/kolibri/teams","hooks_url":"https://api.github.com/repos/jtamiace/kolibri/hooks","issue_events_url":"https://api.github.com/repos/jtamiace/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/jtamiace/kolibri/events","assignees_url":"https://api.github.com/repos/jtamiace/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/jtamiace/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/jtamiace/kolibri/tags","blobs_url":"https://api.github.com/repos/jtamiace/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtamiace/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtamiace/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtamiace/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtamiace/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/jtamiace/kolibri/languages","stargazers_url":"https://api.github.com/repos/jtamiace/kolibri/stargazers","contributors_url":"https://api.github.com/repos/jtamiace/kolibri/contributors","subscribers_url":"https://api.github.com/repos/jtamiace/kolibri/subscribers","subscription_url":"https://api.github.com/repos/jtamiace/kolibri/subscription","commits_url":"https://api.github.com/repos/jtamiace/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtamiace/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtamiace/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtamiace/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtamiace/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/jtamiace/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtamiace/kolibri/merges","archive_url":"https://api.github.com/repos/jtamiace/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtamiace/kolibri/downloads","issues_url":"https://api.github.com/repos/jtamiace/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/jtamiace/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/jtamiace/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/jtamiace/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtamiace/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/jtamiace/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/jtamiace/kolibri/deployments","created_at":"2016-06-17T20:28:44Z","updated_at":"2016-06-17T20:28:45Z","pushed_at":"2016-06-30T23:35:35Z","git_url":"git://github.com/jtamiace/kolibri.git","ssh_url":"git@github.com:jtamiace/kolibri.git","clone_url":"https://github.com/jtamiace/kolibri.git","svn_url":"https://github.com/jtamiace/kolibri","homepage":"http://learningequality.org/kolibri/","size":5762,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:master","ref":"master","sha":"4bed0d077ade6182d0d18a3bc488d2a03986f6b3","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2016-06-21T16:02:31Z","pushed_at":"2016-07-01T16:57:07Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":6328,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":39,"forks":28,"open_issues":39,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/169"},"html":{"href":"https://github.com/learningequality/kolibri/pull/169"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/169"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/23d06f7b3d2df94b534326305dd1d32033e81fcc"}}}}
{"actor":{"display_login":"indirectlylit"}}