{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/84242333","pull_request_review_id":5030838,"id":84242333,"diff_hunk":"@@ -57,3 +57,43 @@ function teardown() {\n   [[ ${lines[1]} == *\".\"* ]]\n   [[ ${lines[2]} == *\"..\"* ]]\n }\n+\n+@test \"runc exec ls -la with --cwd\" {\n+  # run busybox detached\n+  runc run -d --console /dev/pts/ptmx test_busybox\n+  [ \"$status\" -eq 0 ]\n+\n+  wait_for_container 15 1 test_busybox\n+\n+  runc exec --cwd /bin test_busybox ls -la\n+  [ \"$status\" -eq 0 ]\n+  [[ ${lines[0]} == *\"total\"* ]]\n+  [[ ${lines[1]} == *\".\"* ]]\n+  [[ ${lines[2]} == *\"..\"* ]]\n+}\n+\n+@test \"runc exec --env\" {\n+  # run busybox detached\n+  runc run -d --console /dev/pts/ptmx test_busybox\n+  [ \"$status\" -eq 0 ]\n+\n+  wait_for_container 15 1 test_busybox\n+\n+  runc exec --env RUNC_EXEC_TEST=true test_busybox env\n+  [ \"$status\" -eq 0 ]\n+\n+  [[ \"${output}\" == *\"RUNC_EXEC_TEST=true\"* ]]\n+}\n+\n+@test \"runc exec --user\" {\n+  # run busybox detached\n+  runc run -d --console /dev/pts/ptmx test_busybox\n+  [ \"$status\" -eq 0 ]\n+\n+  wait_for_container 15 1 test_busybox\n+\n+  runc exec --user 1000:1000 test_busybox id","path":"tests/integration/exec.bats","position":38,"original_position":39,"commit_id":"72b1f8a247c0a6fc8e5af2577f80d9a7616199b4","original_commit_id":"5be97af344687a8a5ed4d42961984485d29ecff7","user":{"login":"datawolf","id":1785993,"avatar_url":"https://avatars.githubusercontent.com/u/1785993?v=3","gravatar_id":"","url":"https://api.github.com/users/datawolf","html_url":"https://github.com/datawolf","followers_url":"https://api.github.com/users/datawolf/followers","following_url":"https://api.github.com/users/datawolf/following{/other_user}","gists_url":"https://api.github.com/users/datawolf/gists{/gist_id}","starred_url":"https://api.github.com/users/datawolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawolf/subscriptions","organizations_url":"https://api.github.com/users/datawolf/orgs","repos_url":"https://api.github.com/users/datawolf/repos","events_url":"https://api.github.com/users/datawolf/events{/privacy}","received_events_url":"https://api.github.com/users/datawolf/received_events","type":"User","site_admin":false},"body":"but the current implementation of `runc exec` command only support `--user value, -u value UID(format:<uid>[:gid])`","created_at":"2016-10-20T09:18:33Z","updated_at":"2016-10-20T09:18:33Z","html_url":"https://github.com/opencontainers/runc/pull/1133#discussion_r84242333","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/1133","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/84242333"},"html":{"href":"https://github.com/opencontainers/runc/pull/1133#discussion_r84242333"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1133"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1133","id":90144696,"html_url":"https://github.com/opencontainers/runc/pull/1133","diff_url":"https://github.com/opencontainers/runc/pull/1133.diff","patch_url":"https://github.com/opencontainers/runc/pull/1133.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1133","number":1133,"state":"open","locked":false,"title":"add test cases for exec command","user":{"login":"datawolf","id":1785993,"avatar_url":"https://avatars.githubusercontent.com/u/1785993?v=3","gravatar_id":"","url":"https://api.github.com/users/datawolf","html_url":"https://github.com/datawolf","followers_url":"https://api.github.com/users/datawolf/followers","following_url":"https://api.github.com/users/datawolf/following{/other_user}","gists_url":"https://api.github.com/users/datawolf/gists{/gist_id}","starred_url":"https://api.github.com/users/datawolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawolf/subscriptions","organizations_url":"https://api.github.com/users/datawolf/orgs","repos_url":"https://api.github.com/users/datawolf/repos","events_url":"https://api.github.com/users/datawolf/events{/privacy}","received_events_url":"https://api.github.com/users/datawolf/received_events","type":"User","site_admin":false},"body":"This patch add test `--cwd`, `--env`, `--user` option for exec command.\r\n\r\nSigned-off-by: Wang Long <long.wanglong@huawei.com>","created_at":"2016-10-20T07:12:47Z","updated_at":"2016-10-20T09:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5d55cc3437111fbccc79ddae5c25cb57f00e87d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/1133/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/1133/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1133/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/72b1f8a247c0a6fc8e5af2577f80d9a7616199b4","head":{"label":"datawolf:add-integration-test-for-exec","ref":"add-integration-test-for-exec","sha":"72b1f8a247c0a6fc8e5af2577f80d9a7616199b4","user":{"login":"datawolf","id":1785993,"avatar_url":"https://avatars.githubusercontent.com/u/1785993?v=3","gravatar_id":"","url":"https://api.github.com/users/datawolf","html_url":"https://github.com/datawolf","followers_url":"https://api.github.com/users/datawolf/followers","following_url":"https://api.github.com/users/datawolf/following{/other_user}","gists_url":"https://api.github.com/users/datawolf/gists{/gist_id}","starred_url":"https://api.github.com/users/datawolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawolf/subscriptions","organizations_url":"https://api.github.com/users/datawolf/orgs","repos_url":"https://api.github.com/users/datawolf/repos","events_url":"https://api.github.com/users/datawolf/events{/privacy}","received_events_url":"https://api.github.com/users/datawolf/received_events","type":"User","site_admin":false},"repo":{"id":66808968,"name":"runc","full_name":"datawolf/runc","owner":{"login":"datawolf","id":1785993,"avatar_url":"https://avatars.githubusercontent.com/u/1785993?v=3","gravatar_id":"","url":"https://api.github.com/users/datawolf","html_url":"https://github.com/datawolf","followers_url":"https://api.github.com/users/datawolf/followers","following_url":"https://api.github.com/users/datawolf/following{/other_user}","gists_url":"https://api.github.com/users/datawolf/gists{/gist_id}","starred_url":"https://api.github.com/users/datawolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawolf/subscriptions","organizations_url":"https://api.github.com/users/datawolf/orgs","repos_url":"https://api.github.com/users/datawolf/repos","events_url":"https://api.github.com/users/datawolf/events{/privacy}","received_events_url":"https://api.github.com/users/datawolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/datawolf/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/datawolf/runc","forks_url":"https://api.github.com/repos/datawolf/runc/forks","keys_url":"https://api.github.com/repos/datawolf/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datawolf/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datawolf/runc/teams","hooks_url":"https://api.github.com/repos/datawolf/runc/hooks","issue_events_url":"https://api.github.com/repos/datawolf/runc/issues/events{/number}","events_url":"https://api.github.com/repos/datawolf/runc/events","assignees_url":"https://api.github.com/repos/datawolf/runc/assignees{/user}","branches_url":"https://api.github.com/repos/datawolf/runc/branches{/branch}","tags_url":"https://api.github.com/repos/datawolf/runc/tags","blobs_url":"https://api.github.com/repos/datawolf/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datawolf/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datawolf/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/datawolf/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datawolf/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/datawolf/runc/languages","stargazers_url":"https://api.github.com/repos/datawolf/runc/stargazers","contributors_url":"https://api.github.com/repos/datawolf/runc/contributors","subscribers_url":"https://api.github.com/repos/datawolf/runc/subscribers","subscription_url":"https://api.github.com/repos/datawolf/runc/subscription","commits_url":"https://api.github.com/repos/datawolf/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/datawolf/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/datawolf/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/datawolf/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/datawolf/runc/contents/{+path}","compare_url":"https://api.github.com/repos/datawolf/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datawolf/runc/merges","archive_url":"https://api.github.com/repos/datawolf/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datawolf/runc/downloads","issues_url":"https://api.github.com/repos/datawolf/runc/issues{/number}","pulls_url":"https://api.github.com/repos/datawolf/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/datawolf/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/datawolf/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datawolf/runc/labels{/name}","releases_url":"https://api.github.com/repos/datawolf/runc/releases{/id}","deployments_url":"https://api.github.com/repos/datawolf/runc/deployments","created_at":"2016-08-29T03:41:23Z","updated_at":"2016-08-29T03:41:25Z","pushed_at":"2016-10-20T09:15:49Z","git_url":"git://github.com/datawolf/runc.git","ssh_url":"git@github.com:datawolf/runc.git","clone_url":"https://github.com/datawolf/runc.git","svn_url":"https://github.com/datawolf/runc","homepage":"https://www.opencontainers.org/","size":3792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"2a5001c1bce45d9228a173cd331861322e163dd3","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-10-20T04:38:52Z","pushed_at":"2016-10-20T09:15:49Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":6410,"stargazers_count":3188,"watchers_count":3188,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":94,"forks":463,"open_issues":94,"watchers":3188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1133"},"html":{"href":"https://github.com/opencontainers/runc/pull/1133"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1133"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1133/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1133/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1133/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/72b1f8a247c0a6fc8e5af2577f80d9a7616199b4"}}}}
{"actor":{"display_login":"datawolf"}}