{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/8952","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/8952/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8952/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/8952/events","html_url":"https://github.com/mrdoob/three.js/pull/8952","id":155997013,"number":8952,"title":"Consistent getPoints and getSpacedPoints on ellipse","user":{"login":"rfm1201","id":3810815,"avatar_url":"https://avatars.githubusercontent.com/u/3810815?v=3","gravatar_id":"","url":"https://api.github.com/users/rfm1201","html_url":"https://github.com/rfm1201","followers_url":"https://api.github.com/users/rfm1201/followers","following_url":"https://api.github.com/users/rfm1201/following{/other_user}","gists_url":"https://api.github.com/users/rfm1201/gists{/gist_id}","starred_url":"https://api.github.com/users/rfm1201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfm1201/subscriptions","organizations_url":"https://api.github.com/users/rfm1201/orgs","repos_url":"https://api.github.com/users/rfm1201/repos","events_url":"https://api.github.com/users/rfm1201/events{/privacy}","received_events_url":"https://api.github.com/users/rfm1201/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-05-20T16:04:32Z","updated_at":"2016-06-01T14:08:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/8952","html_url":"https://github.com/mrdoob/three.js/pull/8952","diff_url":"https://github.com/mrdoob/three.js/pull/8952.diff","patch_url":"https://github.com/mrdoob/three.js/pull/8952.patch"},"body":"This is a correction for issue https://github.com/mrdoob/three.js/issues/8897\r\n\r\ngetPoints and getSpacedPoints work as getSpacedPoints used to (but with the final point). The arc between aStartAngle and aEndAngle is always forced in the 0, 2*PI area, as getSpacedPoints did (but not getPoints)\r\n\r\nThis pull request doesn't adress the 2 problems found yesturday (removal of the last point by getPoints when to close of the first and point defined by moveTo not used by getSpacedPoints when defined before an ellipse)\r\n\r\nI modified my fiddle to facilitate the vision on the two paths. The new one is https://jsfiddle.net/wdsmy9k3/3/ You may choose angle in a larger ares and you can choose which path you want to see."},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/223003722","html_url":"https://github.com/mrdoob/three.js/pull/8952#issuecomment-223003722","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8952","id":223003722,"user":{"login":"rfm1201","id":3810815,"avatar_url":"https://avatars.githubusercontent.com/u/3810815?v=3","gravatar_id":"","url":"https://api.github.com/users/rfm1201","html_url":"https://github.com/rfm1201","followers_url":"https://api.github.com/users/rfm1201/followers","following_url":"https://api.github.com/users/rfm1201/following{/other_user}","gists_url":"https://api.github.com/users/rfm1201/gists{/gist_id}","starred_url":"https://api.github.com/users/rfm1201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfm1201/subscriptions","organizations_url":"https://api.github.com/users/rfm1201/orgs","repos_url":"https://api.github.com/users/rfm1201/repos","events_url":"https://api.github.com/users/rfm1201/events{/privacy}","received_events_url":"https://api.github.com/users/rfm1201/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T14:08:57Z","updated_at":"2016-06-01T14:08:57Z","body":"the 2PI problem is a philosophical issue.\r\nBoth ways could be good. My personal preference is to spin around the ellipse as many times as required, but same thing for clockwise and reverse clockwise. A colleague next to me think that, if it would be right mathematically, for a path, the current way is the right one.\r\nSpinning as many times as mathematically required may cause issue to getSpacedPoints as the real length of the ellipse may be much more than the visual length of the ellipse. When an ellipse is just a part of the path, it may be hard to understand why the points are distributed the way they are."}}
{"actor":{"display_login":"rfm1201"}}