{"push_id":1174307250,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"602246306a1b33f73e22556f3744d7f72cac377a","before":"3e566de51fe6f2e966158f97682f9a5aaecab974","commits":[{"sha":"573f1ac474d6c3d4eaba0422f30981aca02a3e8b","author":{"name":"Aleisha","email":"934fbebf63797f261a218fe8902264ad1e62817b@hotmail.com"},"message":"Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar\n\nThis patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar.\n\nEDIT: Ensuring modal opens on all pages\nEDIT2: Once the form has been submitted the page will redirect to where you submitted the form from.\nEDIT3: Fixing indentation of member-add-message.inc\n       Ensuring messages save on every page\n       Fill branch\n       Ensure predefined notes appear\n       Form redirects to where it was submitted from, or just the circulation page.\nEDIT4: Removing the new include file and moving it all into the modal in the toolbar\nEDIT5: Removing swp file and unnecessary code duplication by utilising plugins\nEDIT6: Batch checkout fixes\nEDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on)\n\nTo test:\n1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)\n2) Click 'Add a new message' under Messages\n3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC.\n4) Click Cancel. Confirm this closes the modal.\n5) Click 'Add message' button in toolbar. Complete steps 3 and 4.\n6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows.\n\tcirc/circulation.pl\n\tmembers/moremember.pl\n\tmembers/routing-lists.pl\n\tmembers/statistics.pl\n\tmembers/boraccount.pl\n\tmembers/pay.pl\n\tmembers/maninvoice.pl\n\tmembers/mancredit.pl\n\tmembers/readingrec.pl\n\tmembers/notices.pl\n\tmembers/member-flags.pl\n\tmembers/member-password.pl\n\tmembers/paycollect.pl\n\tmembers/files.pl\n        turn on BatchCheckouts syspref and put in appropriate patron category\n        circ/circulation.pl?borrowernumber=X&batch=1\n7) Confirm that the page redirects to where you submitted the form from once you have submitted it.\n8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it)\n\nSponsored-by: Catalyst IT\n\nFollowed test plan, works as expected. (Re-tested for comment #24)\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/573f1ac474d6c3d4eaba0422f30981aca02a3e8b"},{"sha":"71ea7e2ba5b8a44f1a8fb292b66f9ed3a6a0eb45","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 3669: Remove parameters passed to action of form\n\nSounds weird to pass parameters to the action of a POST form.\nThis patch adds a workaround.\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/71ea7e2ba5b8a44f1a8fb292b66f9ed3a6a0eb45"},{"sha":"602246306a1b33f73e22556f3744d7f72cac377a","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 3669 [QA Followup] - Give the text area some breathing room\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/602246306a1b33f73e22556f3744d7f72cac377a"}]}
{"actor":{"display_login":"gmcharlt"}}