{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/80652866","pull_request_review_id":1695100,"id":80652866,"diff_hunk":"@@ -884,7 +889,9 @@ void CodeGenPGO::applyFunctionAttributes(llvm::Function *Fn) {\n void CodeGenPGO::emitCounterIncrement(const RootObject *S) const {\n   if (!global.params.genInstrProf || !RegionCounterMap || !emitInstrumentation)\n     return;\n-\n+  //Never generate PGO code for dcompute\n+  if (gDComputeTarget)","path":"gen/pgo.cpp","position":27,"original_position":27,"commit_id":"13a5423d408e384a0087a353b04da00155b32ba4","original_commit_id":"13a5423d408e384a0087a353b04da00155b32ba4","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"body":"You could want to do a PGO build that also runs Kernels.","created_at":"2016-09-27T09:28:55Z","updated_at":"2016-09-27T09:28:55Z","html_url":"https://github.com/ldc-developers/ldc/pull/1786#discussion_r80652866","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/80652866"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1786#discussion_r80652866"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786","id":86677133,"html_url":"https://github.com/ldc-developers/ldc/pull/1786","diff_url":"https://github.com/ldc-developers/ldc/pull/1786.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1786.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1786","number":1786,"state":"open","locked":false,"title":"Dcompute","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"body":"DCompute adds capability to target CUDA and SPRIV backends of llvm.\r\n\r\nSeveral misc comments.\r\n- ldc will segfault if -sinlgeobj is passed and the first module on the cmd line is marked `@compute`, I am yet to think of a solution for that.\r\n- I feel most of the `if(!dct)` that stop PGO and DI generation could be done more elegantly, but I don't know how they are implemented, so suggestions are welcome.\r\n- It is possible I have added unused functions\r\n- Help and suggestions for TODOs much appreciated\r\n- ldc is less ignorant of addrspaces now, but I might have missed some places where they are not taken into account.\r\n- clang format may need to be run at some point.","created_at":"2016-09-26T03:34:10Z","updated_at":"2016-09-27T09:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e07fb4c858a1fd7eaf153634e300c25106ee1836","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1786/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/13a5423d408e384a0087a353b04da00155b32ba4","head":{"label":"thewilsonator:dcompute","ref":"dcompute","sha":"13a5423d408e384a0087a353b04da00155b32ba4","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"repo":{"id":62774759,"name":"ldc","full_name":"thewilsonator/ldc","owner":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thewilsonator/ldc","description":"The LLVM-based D compiler.","fork":true,"url":"https://api.github.com/repos/thewilsonator/ldc","forks_url":"https://api.github.com/repos/thewilsonator/ldc/forks","keys_url":"https://api.github.com/repos/thewilsonator/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewilsonator/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewilsonator/ldc/teams","hooks_url":"https://api.github.com/repos/thewilsonator/ldc/hooks","issue_events_url":"https://api.github.com/repos/thewilsonator/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/thewilsonator/ldc/events","assignees_url":"https://api.github.com/repos/thewilsonator/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/thewilsonator/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/thewilsonator/ldc/tags","blobs_url":"https://api.github.com/repos/thewilsonator/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewilsonator/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewilsonator/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewilsonator/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewilsonator/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/thewilsonator/ldc/languages","stargazers_url":"https://api.github.com/repos/thewilsonator/ldc/stargazers","contributors_url":"https://api.github.com/repos/thewilsonator/ldc/contributors","subscribers_url":"https://api.github.com/repos/thewilsonator/ldc/subscribers","subscription_url":"https://api.github.com/repos/thewilsonator/ldc/subscription","commits_url":"https://api.github.com/repos/thewilsonator/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewilsonator/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewilsonator/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewilsonator/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewilsonator/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/thewilsonator/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewilsonator/ldc/merges","archive_url":"https://api.github.com/repos/thewilsonator/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewilsonator/ldc/downloads","issues_url":"https://api.github.com/repos/thewilsonator/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/thewilsonator/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/thewilsonator/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/thewilsonator/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewilsonator/ldc/labels{/name}","releases_url":"https://api.github.com/repos/thewilsonator/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/thewilsonator/ldc/deployments","created_at":"2016-07-07T04:19:58Z","updated_at":"2016-09-20T05:33:40Z","pushed_at":"2016-09-27T06:02:57Z","git_url":"git://github.com/thewilsonator/ldc.git","ssh_url":"git@github.com:thewilsonator/ldc.git","clone_url":"https://github.com/thewilsonator/ldc.git","svn_url":"https://github.com/thewilsonator/ldc","homepage":"http://wiki.dlang.org/LDC","size":26230,"stargazers_count":3,"watchers_count":3,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"fd80d5eada729c1eab6f15fa257b58543bbd064a","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-09-26T21:49:25Z","pushed_at":"2016-09-27T06:54:28Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":30325,"stargazers_count":495,"watchers_count":495,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":182,"forks":104,"open_issues":182,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1786"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1786"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1786/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1786/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/13a5423d408e384a0087a353b04da00155b32ba4"}}}}
{"actor":{"display_login":"thewilsonator"}}