{"action":"created","comment":{"url":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments/89180879","pull_request_review_id":9729263,"id":89180879,"diff_hunk":"@@ -273,8 +297,8 @@ def get_credentials(short_term_name, lt_key_id, lt_access_key, args, config):\n     with open(AWS_CREDS_PATH, 'w') as configfile:\n         config.write(configfile)\n     logger.info(\n-        \"Success! Your credentials will expire in %s seconds at: %s\"\n-        % (args.duration, response['Credentials']['Expiration']))\n+        \"Success! Your credentials will expire at: %s\" %\n+        response['Credentials']['Expiration'])","path":"aws-mfa","position":231,"original_position":188,"commit_id":"cb8af6860213ca283ac642721593040bfaee3805","original_commit_id":"d8e7802adc1f18d64dd1462ccb69d32cd3e0c3c5","user":{"login":"broamski","id":5578240,"avatar_url":"https://avatars.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"body":"Again, I'd like to keep seconds info logged.","created_at":"2016-11-22T18:34:53Z","updated_at":"2016-11-22T18:34:53Z","html_url":"https://github.com/broamski/aws-mfa/pull/12#discussion_r89180879","pull_request_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments/89180879"},"html":{"href":"https://github.com/broamski/aws-mfa/pull/12#discussion_r89180879"},"pull_request":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/broamski/aws-mfa/pulls/12","id":94373641,"html_url":"https://github.com/broamski/aws-mfa/pull/12","diff_url":"https://github.com/broamski/aws-mfa/pull/12.diff","patch_url":"https://github.com/broamski/aws-mfa/pull/12.patch","issue_url":"https://api.github.com/repos/broamski/aws-mfa/issues/12","number":12,"state":"open","locked":false,"title":"Set STS_DEFAULT to 43200 (AWS default)","user":{"login":"kenden","id":480586,"avatar_url":"https://avatars.githubusercontent.com/u/480586?v=3","gravatar_id":"","url":"https://api.github.com/users/kenden","html_url":"https://github.com/kenden","followers_url":"https://api.github.com/users/kenden/followers","following_url":"https://api.github.com/users/kenden/following{/other_user}","gists_url":"https://api.github.com/users/kenden/gists{/gist_id}","starred_url":"https://api.github.com/users/kenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenden/subscriptions","organizations_url":"https://api.github.com/users/kenden/orgs","repos_url":"https://api.github.com/users/kenden/repos","events_url":"https://api.github.com/users/kenden/events{/privacy}","received_events_url":"https://api.github.com/users/kenden/received_events","type":"User","site_admin":false},"body":"The STS_DEFAULT should be the same as AWS's value:\r\nhttp://docs.aws.amazon.com/cli/latest/reference/sts/get-session-token.html\r\n\r\nReplace the help string for --duration by the AWS help  of\r\naws sts get-session-token for '--duration-seconds'","created_at":"2016-11-18T14:44:51Z","updated_at":"2016-11-22T18:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff579d3c3d3875550223f449e718f9a40f2ed924","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/12/commits","review_comments_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/12/comments","review_comment_url":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broamski/aws-mfa/issues/12/comments","statuses_url":"https://api.github.com/repos/broamski/aws-mfa/statuses/cb8af6860213ca283ac642721593040bfaee3805","head":{"label":"kenden:fix_max_seconds","ref":"fix_max_seconds","sha":"cb8af6860213ca283ac642721593040bfaee3805","user":{"login":"kenden","id":480586,"avatar_url":"https://avatars.githubusercontent.com/u/480586?v=3","gravatar_id":"","url":"https://api.github.com/users/kenden","html_url":"https://github.com/kenden","followers_url":"https://api.github.com/users/kenden/followers","following_url":"https://api.github.com/users/kenden/following{/other_user}","gists_url":"https://api.github.com/users/kenden/gists{/gist_id}","starred_url":"https://api.github.com/users/kenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenden/subscriptions","organizations_url":"https://api.github.com/users/kenden/orgs","repos_url":"https://api.github.com/users/kenden/repos","events_url":"https://api.github.com/users/kenden/events{/privacy}","received_events_url":"https://api.github.com/users/kenden/received_events","type":"User","site_admin":false},"repo":{"id":74123344,"name":"aws-mfa","full_name":"kenden/aws-mfa","owner":{"login":"kenden","id":480586,"avatar_url":"https://avatars.githubusercontent.com/u/480586?v=3","gravatar_id":"","url":"https://api.github.com/users/kenden","html_url":"https://github.com/kenden","followers_url":"https://api.github.com/users/kenden/followers","following_url":"https://api.github.com/users/kenden/following{/other_user}","gists_url":"https://api.github.com/users/kenden/gists{/gist_id}","starred_url":"https://api.github.com/users/kenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenden/subscriptions","organizations_url":"https://api.github.com/users/kenden/orgs","repos_url":"https://api.github.com/users/kenden/repos","events_url":"https://api.github.com/users/kenden/events{/privacy}","received_events_url":"https://api.github.com/users/kenden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenden/aws-mfa","description":"Manage AWS MFA Security Credentials","fork":true,"url":"https://api.github.com/repos/kenden/aws-mfa","forks_url":"https://api.github.com/repos/kenden/aws-mfa/forks","keys_url":"https://api.github.com/repos/kenden/aws-mfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenden/aws-mfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenden/aws-mfa/teams","hooks_url":"https://api.github.com/repos/kenden/aws-mfa/hooks","issue_events_url":"https://api.github.com/repos/kenden/aws-mfa/issues/events{/number}","events_url":"https://api.github.com/repos/kenden/aws-mfa/events","assignees_url":"https://api.github.com/repos/kenden/aws-mfa/assignees{/user}","branches_url":"https://api.github.com/repos/kenden/aws-mfa/branches{/branch}","tags_url":"https://api.github.com/repos/kenden/aws-mfa/tags","blobs_url":"https://api.github.com/repos/kenden/aws-mfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenden/aws-mfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenden/aws-mfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenden/aws-mfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenden/aws-mfa/statuses/{sha}","languages_url":"https://api.github.com/repos/kenden/aws-mfa/languages","stargazers_url":"https://api.github.com/repos/kenden/aws-mfa/stargazers","contributors_url":"https://api.github.com/repos/kenden/aws-mfa/contributors","subscribers_url":"https://api.github.com/repos/kenden/aws-mfa/subscribers","subscription_url":"https://api.github.com/repos/kenden/aws-mfa/subscription","commits_url":"https://api.github.com/repos/kenden/aws-mfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenden/aws-mfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenden/aws-mfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenden/aws-mfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenden/aws-mfa/contents/{+path}","compare_url":"https://api.github.com/repos/kenden/aws-mfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenden/aws-mfa/merges","archive_url":"https://api.github.com/repos/kenden/aws-mfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenden/aws-mfa/downloads","issues_url":"https://api.github.com/repos/kenden/aws-mfa/issues{/number}","pulls_url":"https://api.github.com/repos/kenden/aws-mfa/pulls{/number}","milestones_url":"https://api.github.com/repos/kenden/aws-mfa/milestones{/number}","notifications_url":"https://api.github.com/repos/kenden/aws-mfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenden/aws-mfa/labels{/name}","releases_url":"https://api.github.com/repos/kenden/aws-mfa/releases{/id}","deployments_url":"https://api.github.com/repos/kenden/aws-mfa/deployments","created_at":"2016-11-18T11:18:27Z","updated_at":"2016-11-18T11:18:28Z","pushed_at":"2016-11-22T18:32:56Z","git_url":"git://github.com/kenden/aws-mfa.git","ssh_url":"git@github.com:kenden/aws-mfa.git","clone_url":"https://github.com/kenden/aws-mfa.git","svn_url":"https://github.com/kenden/aws-mfa","homepage":"","size":29,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"broamski:master","ref":"master","sha":"4e942d166e0050c39893202f5693e060cdad1201","user":{"login":"broamski","id":5578240,"avatar_url":"https://avatars.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"repo":{"id":48399035,"name":"aws-mfa","full_name":"broamski/aws-mfa","owner":{"login":"broamski","id":5578240,"avatar_url":"https://avatars.githubusercontent.com/u/5578240?v=3","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/broamski/aws-mfa","description":"Manage AWS MFA Security Credentials","fork":false,"url":"https://api.github.com/repos/broamski/aws-mfa","forks_url":"https://api.github.com/repos/broamski/aws-mfa/forks","keys_url":"https://api.github.com/repos/broamski/aws-mfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broamski/aws-mfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broamski/aws-mfa/teams","hooks_url":"https://api.github.com/repos/broamski/aws-mfa/hooks","issue_events_url":"https://api.github.com/repos/broamski/aws-mfa/issues/events{/number}","events_url":"https://api.github.com/repos/broamski/aws-mfa/events","assignees_url":"https://api.github.com/repos/broamski/aws-mfa/assignees{/user}","branches_url":"https://api.github.com/repos/broamski/aws-mfa/branches{/branch}","tags_url":"https://api.github.com/repos/broamski/aws-mfa/tags","blobs_url":"https://api.github.com/repos/broamski/aws-mfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broamski/aws-mfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broamski/aws-mfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/broamski/aws-mfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broamski/aws-mfa/statuses/{sha}","languages_url":"https://api.github.com/repos/broamski/aws-mfa/languages","stargazers_url":"https://api.github.com/repos/broamski/aws-mfa/stargazers","contributors_url":"https://api.github.com/repos/broamski/aws-mfa/contributors","subscribers_url":"https://api.github.com/repos/broamski/aws-mfa/subscribers","subscription_url":"https://api.github.com/repos/broamski/aws-mfa/subscription","commits_url":"https://api.github.com/repos/broamski/aws-mfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/broamski/aws-mfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/broamski/aws-mfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/broamski/aws-mfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/broamski/aws-mfa/contents/{+path}","compare_url":"https://api.github.com/repos/broamski/aws-mfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broamski/aws-mfa/merges","archive_url":"https://api.github.com/repos/broamski/aws-mfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broamski/aws-mfa/downloads","issues_url":"https://api.github.com/repos/broamski/aws-mfa/issues{/number}","pulls_url":"https://api.github.com/repos/broamski/aws-mfa/pulls{/number}","milestones_url":"https://api.github.com/repos/broamski/aws-mfa/milestones{/number}","notifications_url":"https://api.github.com/repos/broamski/aws-mfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broamski/aws-mfa/labels{/name}","releases_url":"https://api.github.com/repos/broamski/aws-mfa/releases{/id}","deployments_url":"https://api.github.com/repos/broamski/aws-mfa/deployments","created_at":"2015-12-21T23:11:38Z","updated_at":"2016-11-08T13:18:52Z","pushed_at":"2016-11-22T18:32:56Z","git_url":"git://github.com/broamski/aws-mfa.git","ssh_url":"git@github.com:broamski/aws-mfa.git","clone_url":"https://github.com/broamski/aws-mfa.git","svn_url":"https://github.com/broamski/aws-mfa","homepage":"","size":39,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/12"},"html":{"href":"https://github.com/broamski/aws-mfa/pull/12"},"issue":{"href":"https://api.github.com/repos/broamski/aws-mfa/issues/12"},"comments":{"href":"https://api.github.com/repos/broamski/aws-mfa/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broamski/aws-mfa/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/broamski/aws-mfa/statuses/cb8af6860213ca283ac642721593040bfaee3805"}}}}
{"actor":{"display_login":"broamski"}}