{"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15","id":72153118,"html_url":"https://github.com/Sarcasm/flycheck-irony/pull/15","diff_url":"https://github.com/Sarcasm/flycheck-irony/pull/15.diff","patch_url":"https://github.com/Sarcasm/flycheck-irony/pull/15.patch","issue_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/15","number":15,"state":"open","locked":false,"title":"Adds error region function to pick up Irony's end column reporting","user":{"login":"itollefsen","id":19262403,"avatar_url":"https://avatars.githubusercontent.com/u/19262403?v=3","gravatar_id":"","url":"https://api.github.com/users/itollefsen","html_url":"https://github.com/itollefsen","followers_url":"https://api.github.com/users/itollefsen/followers","following_url":"https://api.github.com/users/itollefsen/following{/other_user}","gists_url":"https://api.github.com/users/itollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/itollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itollefsen/subscriptions","organizations_url":"https://api.github.com/users/itollefsen/orgs","repos_url":"https://api.github.com/users/itollefsen/repos","events_url":"https://api.github.com/users/itollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/itollefsen/received_events","type":"User","site_admin":false},"body":"If Irony can report the end column for a diagnostic message, then it's much simpler, and faster, to use that to calculate the error region than what Flycheck itself can do - especially if mode is `sexps'. It will also be more accurate.\r\n\r\nThis adds a custom `flycheck-irony-error' struct that inherits from `flycheck-error' and adds a `column-end' member.\r\n\r\n`flycheck-irony--build-error' has been changed to build a `flycheck-irony-error' instead of a\r\n`flycheck-error' and set `column-end' based on Irony's diagnostic output.\r\n\r\nA new error region function has been added; `flycheck-irony--error-region'. That function is added as an advice around the standard `flycheck-error-region-for-mode'. If the checker is \"irony\" and `column-end' as as value, `flycheck-irony--error-region' will calculate the error region, disregarding mode. If not, it will call the standard `flycheck-error-region-for-mode'.\r\n\r\nThis change depends on the changes to Sarcasm/irony-mode in pull request #312, which among other things replaces the offset in Irony's diagnostic output with the end column instead.","created_at":"2016-06-01T10:01:11Z","updated_at":"2016-06-01T10:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/15/comments","statuses_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/statuses/dfee3e595e189a79fe26a1ee39baa53e48c55ec7","head":{"label":"itollefsen:faster-error-region","ref":"faster-error-region","sha":"dfee3e595e189a79fe26a1ee39baa53e48c55ec7","user":{"login":"itollefsen","id":19262403,"avatar_url":"https://avatars.githubusercontent.com/u/19262403?v=3","gravatar_id":"","url":"https://api.github.com/users/itollefsen","html_url":"https://github.com/itollefsen","followers_url":"https://api.github.com/users/itollefsen/followers","following_url":"https://api.github.com/users/itollefsen/following{/other_user}","gists_url":"https://api.github.com/users/itollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/itollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itollefsen/subscriptions","organizations_url":"https://api.github.com/users/itollefsen/orgs","repos_url":"https://api.github.com/users/itollefsen/repos","events_url":"https://api.github.com/users/itollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/itollefsen/received_events","type":"User","site_admin":false},"repo":{"id":60165618,"name":"flycheck-irony","full_name":"itollefsen/flycheck-irony","owner":{"login":"itollefsen","id":19262403,"avatar_url":"https://avatars.githubusercontent.com/u/19262403?v=3","gravatar_id":"","url":"https://api.github.com/users/itollefsen","html_url":"https://github.com/itollefsen","followers_url":"https://api.github.com/users/itollefsen/followers","following_url":"https://api.github.com/users/itollefsen/following{/other_user}","gists_url":"https://api.github.com/users/itollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/itollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itollefsen/subscriptions","organizations_url":"https://api.github.com/users/itollefsen/orgs","repos_url":"https://api.github.com/users/itollefsen/repos","events_url":"https://api.github.com/users/itollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/itollefsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itollefsen/flycheck-irony","description":"C, C++ and Objective-C support for Flycheck, using Irony Mode","fork":true,"url":"https://api.github.com/repos/itollefsen/flycheck-irony","forks_url":"https://api.github.com/repos/itollefsen/flycheck-irony/forks","keys_url":"https://api.github.com/repos/itollefsen/flycheck-irony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itollefsen/flycheck-irony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itollefsen/flycheck-irony/teams","hooks_url":"https://api.github.com/repos/itollefsen/flycheck-irony/hooks","issue_events_url":"https://api.github.com/repos/itollefsen/flycheck-irony/issues/events{/number}","events_url":"https://api.github.com/repos/itollefsen/flycheck-irony/events","assignees_url":"https://api.github.com/repos/itollefsen/flycheck-irony/assignees{/user}","branches_url":"https://api.github.com/repos/itollefsen/flycheck-irony/branches{/branch}","tags_url":"https://api.github.com/repos/itollefsen/flycheck-irony/tags","blobs_url":"https://api.github.com/repos/itollefsen/flycheck-irony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itollefsen/flycheck-irony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itollefsen/flycheck-irony/git/refs{/sha}","trees_url":"https://api.github.com/repos/itollefsen/flycheck-irony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itollefsen/flycheck-irony/statuses/{sha}","languages_url":"https://api.github.com/repos/itollefsen/flycheck-irony/languages","stargazers_url":"https://api.github.com/repos/itollefsen/flycheck-irony/stargazers","contributors_url":"https://api.github.com/repos/itollefsen/flycheck-irony/contributors","subscribers_url":"https://api.github.com/repos/itollefsen/flycheck-irony/subscribers","subscription_url":"https://api.github.com/repos/itollefsen/flycheck-irony/subscription","commits_url":"https://api.github.com/repos/itollefsen/flycheck-irony/commits{/sha}","git_commits_url":"https://api.github.com/repos/itollefsen/flycheck-irony/git/commits{/sha}","comments_url":"https://api.github.com/repos/itollefsen/flycheck-irony/comments{/number}","issue_comment_url":"https://api.github.com/repos/itollefsen/flycheck-irony/issues/comments{/number}","contents_url":"https://api.github.com/repos/itollefsen/flycheck-irony/contents/{+path}","compare_url":"https://api.github.com/repos/itollefsen/flycheck-irony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itollefsen/flycheck-irony/merges","archive_url":"https://api.github.com/repos/itollefsen/flycheck-irony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itollefsen/flycheck-irony/downloads","issues_url":"https://api.github.com/repos/itollefsen/flycheck-irony/issues{/number}","pulls_url":"https://api.github.com/repos/itollefsen/flycheck-irony/pulls{/number}","milestones_url":"https://api.github.com/repos/itollefsen/flycheck-irony/milestones{/number}","notifications_url":"https://api.github.com/repos/itollefsen/flycheck-irony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itollefsen/flycheck-irony/labels{/name}","releases_url":"https://api.github.com/repos/itollefsen/flycheck-irony/releases{/id}","deployments_url":"https://api.github.com/repos/itollefsen/flycheck-irony/deployments","created_at":"2016-06-01T09:55:05Z","updated_at":"2016-06-01T09:55:06Z","pushed_at":"2016-06-01T09:56:22Z","git_url":"git://github.com/itollefsen/flycheck-irony.git","ssh_url":"git@github.com:itollefsen/flycheck-irony.git","clone_url":"https://github.com/itollefsen/flycheck-irony.git","svn_url":"https://github.com/itollefsen/flycheck-irony","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sarcasm:master","ref":"master","sha":"34940ae5ab8f4c721d9c1118ebfc3496d7e67a84","user":{"login":"Sarcasm","id":424046,"avatar_url":"https://avatars.githubusercontent.com/u/424046?v=3","gravatar_id":"","url":"https://api.github.com/users/Sarcasm","html_url":"https://github.com/Sarcasm","followers_url":"https://api.github.com/users/Sarcasm/followers","following_url":"https://api.github.com/users/Sarcasm/following{/other_user}","gists_url":"https://api.github.com/users/Sarcasm/gists{/gist_id}","starred_url":"https://api.github.com/users/Sarcasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sarcasm/subscriptions","organizations_url":"https://api.github.com/users/Sarcasm/orgs","repos_url":"https://api.github.com/users/Sarcasm/repos","events_url":"https://api.github.com/users/Sarcasm/events{/privacy}","received_events_url":"https://api.github.com/users/Sarcasm/received_events","type":"User","site_admin":false},"repo":{"id":28159451,"name":"flycheck-irony","full_name":"Sarcasm/flycheck-irony","owner":{"login":"Sarcasm","id":424046,"avatar_url":"https://avatars.githubusercontent.com/u/424046?v=3","gravatar_id":"","url":"https://api.github.com/users/Sarcasm","html_url":"https://github.com/Sarcasm","followers_url":"https://api.github.com/users/Sarcasm/followers","following_url":"https://api.github.com/users/Sarcasm/following{/other_user}","gists_url":"https://api.github.com/users/Sarcasm/gists{/gist_id}","starred_url":"https://api.github.com/users/Sarcasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sarcasm/subscriptions","organizations_url":"https://api.github.com/users/Sarcasm/orgs","repos_url":"https://api.github.com/users/Sarcasm/repos","events_url":"https://api.github.com/users/Sarcasm/events{/privacy}","received_events_url":"https://api.github.com/users/Sarcasm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sarcasm/flycheck-irony","description":"C, C++ and Objective-C support for Flycheck, using Irony Mode","fork":false,"url":"https://api.github.com/repos/Sarcasm/flycheck-irony","forks_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/forks","keys_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/teams","hooks_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/hooks","issue_events_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/events{/number}","events_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/events","assignees_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/assignees{/user}","branches_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/branches{/branch}","tags_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/tags","blobs_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/statuses/{sha}","languages_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/languages","stargazers_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/stargazers","contributors_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/contributors","subscribers_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/subscribers","subscription_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/subscription","commits_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/contents/{+path}","compare_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/merges","archive_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/downloads","issues_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues{/number}","pulls_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls{/number}","milestones_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/milestones{/number}","notifications_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/labels{/name}","releases_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/releases{/id}","deployments_url":"https://api.github.com/repos/Sarcasm/flycheck-irony/deployments","created_at":"2014-12-17T23:04:16Z","updated_at":"2016-05-16T00:20:42Z","pushed_at":"2016-03-17T22:36:59Z","git_url":"git://github.com/Sarcasm/flycheck-irony.git","ssh_url":"git@github.com:Sarcasm/flycheck-irony.git","clone_url":"https://github.com/Sarcasm/flycheck-irony.git","svn_url":"https://github.com/Sarcasm/flycheck-irony","homepage":null,"size":60,"stargazers_count":26,"watchers_count":26,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15"},"html":{"href":"https://github.com/Sarcasm/flycheck-irony/pull/15"},"issue":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/15"},"comments":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Sarcasm/flycheck-irony/statuses/dfee3e595e189a79fe26a1ee39baa53e48c55ec7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":53,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"itollefsen"}}