{"action":"created","issue":{"url":"https://api.github.com/repos/CruGlobal/give-web/issues/183","repository_url":"https://api.github.com/repos/CruGlobal/give-web","labels_url":"https://api.github.com/repos/CruGlobal/give-web/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/CruGlobal/give-web/issues/183/comments","events_url":"https://api.github.com/repos/CruGlobal/give-web/issues/183/events","html_url":"https://github.com/CruGlobal/give-web/pull/183","id":183594766,"number":183,"title":"Edit recurring gifts step 1","user":{"login":"OzzieOrca","id":756501,"avatar_url":"https://avatars.githubusercontent.com/u/756501?v=3","gravatar_id":"","url":"https://api.github.com/users/OzzieOrca","html_url":"https://github.com/OzzieOrca","followers_url":"https://api.github.com/users/OzzieOrca/followers","following_url":"https://api.github.com/users/OzzieOrca/following{/other_user}","gists_url":"https://api.github.com/users/OzzieOrca/gists{/gist_id}","starred_url":"https://api.github.com/users/OzzieOrca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OzzieOrca/subscriptions","organizations_url":"https://api.github.com/users/OzzieOrca/orgs","repos_url":"https://api.github.com/users/OzzieOrca/repos","events_url":"https://api.github.com/users/OzzieOrca/events{/privacy}","received_events_url":"https://api.github.com/users/OzzieOrca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-18T05:37:12Z","updated_at":"2016-10-18T14:34:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CruGlobal/give-web/pulls/183","html_url":"https://github.com/CruGlobal/give-web/pull/183","diff_url":"https://github.com/CruGlobal/give-web/pull/183.diff","patch_url":"https://github.com/CruGlobal/give-web/pull/183.patch"},"body":"@Omicron7 This isn't done but I wanted you to at least see it before you get too far on your modals as so many of the modal views are similar.\r\n\r\nMainly I wanted to get your thoughts on the `giftListItem` component and it's usage. I think it or some variant could be used for most, if not all of the modal views that display gifts. I think at the very least they all share the profile picture and name and then have some sort of body or select action. I might be trying to cram too much functionality in there but they all should take in a gift object and either just display it in full or abbreviated form, return a modified version, or a selected status. Maybe we should split it into a display, edit, and select component... Idk.\r\n\r\nLet me know what you think and how I could clean it up or make it better. Feel free to suggest even small things like names. Maybe you've already got something started or some ideas... I'd love to hear them.\r\n\r\nIt would probably be easier to just look at the second commit as this is based off of https://github.com/CruGlobal/give-web/pull/182."},"comment":{"url":"https://api.github.com/repos/CruGlobal/give-web/issues/comments/254527097","html_url":"https://github.com/CruGlobal/give-web/pull/183#issuecomment-254527097","issue_url":"https://api.github.com/repos/CruGlobal/give-web/issues/183","id":254527097,"user":{"login":"Omicron7","id":302915,"avatar_url":"https://avatars.githubusercontent.com/u/302915?v=3","gravatar_id":"","url":"https://api.github.com/users/Omicron7","html_url":"https://github.com/Omicron7","followers_url":"https://api.github.com/users/Omicron7/followers","following_url":"https://api.github.com/users/Omicron7/following{/other_user}","gists_url":"https://api.github.com/users/Omicron7/gists{/gist_id}","starred_url":"https://api.github.com/users/Omicron7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Omicron7/subscriptions","organizations_url":"https://api.github.com/users/Omicron7/orgs","repos_url":"https://api.github.com/users/Omicron7/repos","events_url":"https://api.github.com/users/Omicron7/events{/privacy}","received_events_url":"https://api.github.com/users/Omicron7/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T14:34:39Z","updated_at":"2016-10-18T14:34:39Z","body":"@OzzieOrca I agree that we should have a common giftListItem component. Looking through the UX site, it looks like it can be configured in 4 different ways.\r\n\r\n1. VIEW / CONFIRM - view only version, used to confirm changes\r\n<img width=\"558\" alt=\"screen shot 2016-10-18 at 10 04 28 am\" src=\"https://cloud.githubusercontent.com/assets/302915/19481209/30d37f34-951b-11e6-9469-7dc85feb3c38.png\">\r\n2. EDIT / CONFIGURE - Allows full editing of the gift\r\n<img width=\"569\" alt=\"screen shot 2016-10-18 at 10 04 57 am\" src=\"https://cloud.githubusercontent.com/assets/302915/19481259/50bf5fb6-951b-11e6-9e6a-bc97d5ac21cb.png\">\r\n3. ONE-TIME - edit / configure one-time gift \r\n<img width=\"567\" alt=\"screen shot 2016-10-18 at 10 05 36 am\" src=\"https://cloud.githubusercontent.com/assets/302915/19481334/8fd09ada-951b-11e6-9842-c57d2da853bf.png\">\r\n4. PAYMENT - Only allows changing the payment method (dropdown has option to add new payment method). \r\n<img width=\"561\" alt=\"screen shot 2016-10-18 at 10 06 00 am\" src=\"https://cloud.githubusercontent.com/assets/302915/19481372/b81c5a06-951b-11e6-92d6-45f17688cf14.png\">\r\n\r\nIt might be overkill to build all of this in a single component. My suggestion would be a component for the picture / name, and transcluded components for the different editing modes:\r\n\r\n```javascript\r\nangular.module('name').component({\r\n    controller: Function,\r\n    templateUrl: template.name,\r\n    transclude: true\r\n});\r\n```\r\n```html\r\n<div>Template</div>\r\n<div>\r\n    <div ng-transclude />\r\n</div>\r\n```\r\nThis allows insertion of another component/directive into a specific place in the component. Allows for easy customization of sections of a larger component, determined by the parent, and not the child component.\r\n\r\n```html\r\n<gift-list-item gift=\"$ctrl.item\">\r\n    <gift-list-view gift=\"$ctrl.item\" />\r\n</gift-list-item>\r\n````\r\n```html\r\n<gift-list-item gift=\"$ctrl.item\">\r\n    <gift-list-edit gift=\"$ctrl.item\" />\r\n</gift-list-item>\r\n````\r\nWe could have a single component for the different edit modes if they share enough common code, or a component for each.\r\n```html\r\n<gift-list-item gift=\"$ctrl.item\">\r\n    <gift-list-one-time gift=\"$ctrl.item\" />\r\n    <!-- <gift-list-edit gift=\"$ctrl.item\" mode=\"'one-time'\" /> -->\r\n</gift-list-item>\r\n````\r\n\r\nThoughts? Did I miss any giftListItem configurations? Not sure if this is also used in the profile pages anywhere."}}
{"actor":{"display_login":"Omicron7"}}