{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/56498540","id":56498540,"diff_hunk":"@@ -833,9 +833,55 @@ public void handleWanReplication(Node node) {\n                         }\n                     }\n                     targetClusters.add(childBeanDefinition);\n+                } else if (\"wan-publisher\".equals(nName)) {\n+                    final BeanDefinitionBuilder publisherConfigBuilder = createBeanBuilder(WanPublisherConfig.class);\n+                    final AbstractBeanDefinition childBeanDefinition = publisherConfigBuilder.getBeanDefinition();\n+                    fillAttributeValues(n, publisherConfigBuilder, Collections.<String>emptyList());\n+\n+                    final NamedNodeMap attrs = n.getAttributes();\n+                    Node classNameNode = attrs.getNamedItem(\"class-name\");\n+                    String className = classNameNode != null ? getTextContent(classNameNode) : null;\n+                    Node implNode = attrs.getNamedItem(\"implementation\");\n+                    String implementation = implNode != null ? getTextContent(implNode) : null;\n+                    publisherConfigBuilder.addPropertyValue(\"className\", className);\n+                    if (implementation != null) {\n+                        publisherConfigBuilder.addPropertyReference(\"implementation\", implementation);\n+                    }\n+                    Assert.isTrue(className != null || implementation != null, \"One of 'class-name' or 'implementation' \"\n+                            + \"attributes is required to create WanPublisherConfig!\");\n+                    for (Node child : childElements(n)) {\n+                        final String nodeName = cleanNodeName(child);\n+                        if (\"properties\".equals(nodeName)) {\n+                            handleProperties(child, publisherConfigBuilder);\n+                            break;\n+                        }\n+                    }\n+                    wanPublishers.add(childBeanDefinition);\n+                } else if (\"wan-consumer\".equals(nName)) {\n+                    final BeanDefinitionBuilder consumerConfigBuilder = createBeanBuilder(WanConsumerConfig.class);\n+                    final NamedNodeMap attrs = n.getAttributes();\n+                    Node classNameNode = attrs.getNamedItem(\"class-name\");\n+                    String className = classNameNode != null ? getTextContent(classNameNode) : null;\n+                    Node implNode = attrs.getNamedItem(\"implementation\");\n+                    String implementation = implNode != null ? getTextContent(implNode) : null;\n+                    consumerConfigBuilder.addPropertyValue(\"className\", className);\n+                    if (implementation != null) {\n+                        consumerConfigBuilder.addPropertyReference(\"implementation\", implementation);","path":"hazelcast-spring/src/main/java/com/hazelcast/spring/HazelcastConfigBeanDefinitionParser.java","position":59,"original_position":59,"commit_id":"75bf775c497bced90ba5427408337ac620669309","original_commit_id":"75bf775c497bced90ba5427408337ac620669309","user":{"login":"serkan-ozal","id":3143425,"avatar_url":"https://avatars.githubusercontent.com/u/3143425?v=3","gravatar_id":"","url":"https://api.github.com/users/serkan-ozal","html_url":"https://github.com/serkan-ozal","followers_url":"https://api.github.com/users/serkan-ozal/followers","following_url":"https://api.github.com/users/serkan-ozal/following{/other_user}","gists_url":"https://api.github.com/users/serkan-ozal/gists{/gist_id}","starred_url":"https://api.github.com/users/serkan-ozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkan-ozal/subscriptions","organizations_url":"https://api.github.com/users/serkan-ozal/orgs","repos_url":"https://api.github.com/users/serkan-ozal/repos","events_url":"https://api.github.com/users/serkan-ozal/events{/privacy}","received_events_url":"https://api.github.com/users/serkan-ozal/received_events","type":"User","site_admin":false},"body":"just for curiosity, what is the difference between `addPropertyValue` and `addPropertyReference` in here?","created_at":"2016-03-17T12:55:50Z","updated_at":"2016-03-17T12:55:50Z","html_url":"https://github.com/hazelcast/hazelcast/pull/7723#discussion_r56498540","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/56498540"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7723#discussion_r56498540"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723","id":62513198,"html_url":"https://github.com/hazelcast/hazelcast/pull/7723","diff_url":"https://github.com/hazelcast/hazelcast/pull/7723.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/7723.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7723","number":7723,"state":"open","locked":false,"title":"Abstract WAN endpoints","user":{"login":"emrahkocaman","id":2887123,"avatar_url":"https://avatars.githubusercontent.com/u/2887123?v=3","gravatar_id":"","url":"https://api.github.com/users/emrahkocaman","html_url":"https://github.com/emrahkocaman","followers_url":"https://api.github.com/users/emrahkocaman/followers","following_url":"https://api.github.com/users/emrahkocaman/following{/other_user}","gists_url":"https://api.github.com/users/emrahkocaman/gists{/gist_id}","starred_url":"https://api.github.com/users/emrahkocaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrahkocaman/subscriptions","organizations_url":"https://api.github.com/users/emrahkocaman/orgs","repos_url":"https://api.github.com/users/emrahkocaman/repos","events_url":"https://api.github.com/users/emrahkocaman/events{/privacy}","received_events_url":"https://api.github.com/users/emrahkocaman/received_events","type":"User","site_admin":false},"body":"- Configuration changes for Abstract WAN endpoints.\r\n- Schema updates to 3.7","created_at":"2016-03-11T08:49:49Z","updated_at":"2016-03-17T12:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2786b5b7618e0feb0f29b466cf32146053aeea7d","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.7","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70/labels","id":1346433,"number":70,"title":"3.7","description":"","creator":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"open_issues":185,"closed_issues":224,"state":"open","created_at":"2015-10-09T12:16:13Z","updated_at":"2016-03-17T11:29:25Z","due_on":"2016-05-02T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7723/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/75bf775c497bced90ba5427408337ac620669309","head":{"label":"emrahkocaman:abstract-wan-endpoints","ref":"abstract-wan-endpoints","sha":"75bf775c497bced90ba5427408337ac620669309","user":{"login":"emrahkocaman","id":2887123,"avatar_url":"https://avatars.githubusercontent.com/u/2887123?v=3","gravatar_id":"","url":"https://api.github.com/users/emrahkocaman","html_url":"https://github.com/emrahkocaman","followers_url":"https://api.github.com/users/emrahkocaman/followers","following_url":"https://api.github.com/users/emrahkocaman/following{/other_user}","gists_url":"https://api.github.com/users/emrahkocaman/gists{/gist_id}","starred_url":"https://api.github.com/users/emrahkocaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrahkocaman/subscriptions","organizations_url":"https://api.github.com/users/emrahkocaman/orgs","repos_url":"https://api.github.com/users/emrahkocaman/repos","events_url":"https://api.github.com/users/emrahkocaman/events{/privacy}","received_events_url":"https://api.github.com/users/emrahkocaman/received_events","type":"User","site_admin":false},"repo":{"id":21817787,"name":"hazelcast","full_name":"emrahkocaman/hazelcast","owner":{"login":"emrahkocaman","id":2887123,"avatar_url":"https://avatars.githubusercontent.com/u/2887123?v=3","gravatar_id":"","url":"https://api.github.com/users/emrahkocaman","html_url":"https://github.com/emrahkocaman","followers_url":"https://api.github.com/users/emrahkocaman/followers","following_url":"https://api.github.com/users/emrahkocaman/following{/other_user}","gists_url":"https://api.github.com/users/emrahkocaman/gists{/gist_id}","starred_url":"https://api.github.com/users/emrahkocaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrahkocaman/subscriptions","organizations_url":"https://api.github.com/users/emrahkocaman/orgs","repos_url":"https://api.github.com/users/emrahkocaman/repos","events_url":"https://api.github.com/users/emrahkocaman/events{/privacy}","received_events_url":"https://api.github.com/users/emrahkocaman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emrahkocaman/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/emrahkocaman/hazelcast","forks_url":"https://api.github.com/repos/emrahkocaman/hazelcast/forks","keys_url":"https://api.github.com/repos/emrahkocaman/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emrahkocaman/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emrahkocaman/hazelcast/teams","hooks_url":"https://api.github.com/repos/emrahkocaman/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/emrahkocaman/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/emrahkocaman/hazelcast/events","assignees_url":"https://api.github.com/repos/emrahkocaman/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/emrahkocaman/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/emrahkocaman/hazelcast/tags","blobs_url":"https://api.github.com/repos/emrahkocaman/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emrahkocaman/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emrahkocaman/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/emrahkocaman/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emrahkocaman/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/emrahkocaman/hazelcast/languages","stargazers_url":"https://api.github.com/repos/emrahkocaman/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/emrahkocaman/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/emrahkocaman/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/emrahkocaman/hazelcast/subscription","commits_url":"https://api.github.com/repos/emrahkocaman/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/emrahkocaman/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/emrahkocaman/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/emrahkocaman/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/emrahkocaman/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/emrahkocaman/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emrahkocaman/hazelcast/merges","archive_url":"https://api.github.com/repos/emrahkocaman/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emrahkocaman/hazelcast/downloads","issues_url":"https://api.github.com/repos/emrahkocaman/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/emrahkocaman/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/emrahkocaman/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/emrahkocaman/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emrahkocaman/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/emrahkocaman/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/emrahkocaman/hazelcast/deployments","created_at":"2014-07-14T11:49:26Z","updated_at":"2016-01-15T08:50:01Z","pushed_at":"2016-03-11T08:46:35Z","git_url":"git://github.com/emrahkocaman/hazelcast.git","ssh_url":"git@github.com:emrahkocaman/hazelcast.git","clone_url":"https://github.com/emrahkocaman/hazelcast.git","svn_url":"https://github.com/emrahkocaman/hazelcast","homepage":"www.hazelcast.com","size":87463,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"f6c2c4dcb7d91e0b5fd818de0bc3a5f6bb20c484","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-03-16T20:50:17Z","pushed_at":"2016-03-17T11:46:02Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":102608,"stargazers_count":1476,"watchers_count":1476,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":703,"mirror_url":null,"open_issues_count":586,"forks":703,"open_issues":586,"watchers":1476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7723"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7723"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7723/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7723/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/75bf775c497bced90ba5427408337ac620669309"}}}}