{"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/dankogai/p5-encode/pulls/70","id":91104892,"html_url":"https://github.com/dankogai/p5-encode/pull/70","diff_url":"https://github.com/dankogai/p5-encode/pull/70.diff","patch_url":"https://github.com/dankogai/p5-encode/pull/70.patch","issue_url":"https://api.github.com/repos/dankogai/p5-encode/issues/70","number":70,"state":"closed","locked":false,"title":"Fix handling of undef, ref, typeglob, UTF8, COW and magic scalar argument in all XS functions","user":{"login":"pali","id":7141871,"avatar_url":"https://avatars.githubusercontent.com/u/7141871?v=3","gravatar_id":"","url":"https://api.github.com/users/pali","html_url":"https://github.com/pali","followers_url":"https://api.github.com/users/pali/followers","following_url":"https://api.github.com/users/pali/following{/other_user}","gists_url":"https://api.github.com/users/pali/gists{/gist_id}","starred_url":"https://api.github.com/users/pali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pali/subscriptions","organizations_url":"https://api.github.com/users/pali/orgs","repos_url":"https://api.github.com/users/pali/repos","events_url":"https://api.github.com/users/pali/events{/privacy}","received_events_url":"https://api.github.com/users/pali/received_events","type":"User","site_admin":false},"body":"Before this patch every function XS function did it differently and not\r\nevery one correctly. Now SvPV_force_nomg() is used when source argument\r\nis going to be modified. SvGETMAGIC() is called when entering into\r\nfunctions and then only \"nomg\" variants of perl functions are used to\r\nprevent processing get magic more times. SvSETMAGIC() is called after\r\nmodification of source argument.\r\n\r\nThis fixes bugs:\r\nhttps://rt.cpan.org/Public/Bug/Display.html?id=117158\r\nhttps://rt.cpan.org/Public/Bug/Display.html?id=85489\r\nhttps://github.com/dankogai/p5-encode/pull/66\r\n\r\nSee discussion about this patch, Father Chrysostomos reviewed it:\r\nhttp://code.activestate.com/lists/perl5-porters/233137/\r\nhttp://www.nntp.perl.org/group/perl.perl5.porters/2016/10/msg240511.html\r\n\r\n---\r\n\r\nNow magic scalars should be handled correctly by Encode.xs functions.","created_at":"2016-10-26T22:58:32Z","updated_at":"2016-10-26T23:07:07Z","closed_at":"2016-10-26T23:07:07Z","merged_at":"2016-10-26T23:07:07Z","merge_commit_sha":"20eaeb85cb25b4472c4e994e84a6302bd954655f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dankogai/p5-encode/pulls/70/commits","review_comments_url":"https://api.github.com/repos/dankogai/p5-encode/pulls/70/comments","review_comment_url":"https://api.github.com/repos/dankogai/p5-encode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dankogai/p5-encode/issues/70/comments","statuses_url":"https://api.github.com/repos/dankogai/p5-encode/statuses/8d7150f0da05941392b7e56b2e2c7acd461979f0","head":{"label":"pali:master","ref":"master","sha":"8d7150f0da05941392b7e56b2e2c7acd461979f0","user":{"login":"pali","id":7141871,"avatar_url":"https://avatars.githubusercontent.com/u/7141871?v=3","gravatar_id":"","url":"https://api.github.com/users/pali","html_url":"https://github.com/pali","followers_url":"https://api.github.com/users/pali/followers","following_url":"https://api.github.com/users/pali/following{/other_user}","gists_url":"https://api.github.com/users/pali/gists{/gist_id}","starred_url":"https://api.github.com/users/pali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pali/subscriptions","organizations_url":"https://api.github.com/users/pali/orgs","repos_url":"https://api.github.com/users/pali/repos","events_url":"https://api.github.com/users/pali/events{/privacy}","received_events_url":"https://api.github.com/users/pali/received_events","type":"User","site_admin":false},"repo":{"id":62971869,"name":"p5-encode","full_name":"pali/p5-encode","owner":{"login":"pali","id":7141871,"avatar_url":"https://avatars.githubusercontent.com/u/7141871?v=3","gravatar_id":"","url":"https://api.github.com/users/pali","html_url":"https://github.com/pali","followers_url":"https://api.github.com/users/pali/followers","following_url":"https://api.github.com/users/pali/following{/other_user}","gists_url":"https://api.github.com/users/pali/gists{/gist_id}","starred_url":"https://api.github.com/users/pali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pali/subscriptions","organizations_url":"https://api.github.com/users/pali/orgs","repos_url":"https://api.github.com/users/pali/repos","events_url":"https://api.github.com/users/pali/events{/privacy}","received_events_url":"https://api.github.com/users/pali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pali/p5-encode","description":"Encode - character encodings (for Perl 5.8 or better)","fork":true,"url":"https://api.github.com/repos/pali/p5-encode","forks_url":"https://api.github.com/repos/pali/p5-encode/forks","keys_url":"https://api.github.com/repos/pali/p5-encode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pali/p5-encode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pali/p5-encode/teams","hooks_url":"https://api.github.com/repos/pali/p5-encode/hooks","issue_events_url":"https://api.github.com/repos/pali/p5-encode/issues/events{/number}","events_url":"https://api.github.com/repos/pali/p5-encode/events","assignees_url":"https://api.github.com/repos/pali/p5-encode/assignees{/user}","branches_url":"https://api.github.com/repos/pali/p5-encode/branches{/branch}","tags_url":"https://api.github.com/repos/pali/p5-encode/tags","blobs_url":"https://api.github.com/repos/pali/p5-encode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pali/p5-encode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pali/p5-encode/git/refs{/sha}","trees_url":"https://api.github.com/repos/pali/p5-encode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pali/p5-encode/statuses/{sha}","languages_url":"https://api.github.com/repos/pali/p5-encode/languages","stargazers_url":"https://api.github.com/repos/pali/p5-encode/stargazers","contributors_url":"https://api.github.com/repos/pali/p5-encode/contributors","subscribers_url":"https://api.github.com/repos/pali/p5-encode/subscribers","subscription_url":"https://api.github.com/repos/pali/p5-encode/subscription","commits_url":"https://api.github.com/repos/pali/p5-encode/commits{/sha}","git_commits_url":"https://api.github.com/repos/pali/p5-encode/git/commits{/sha}","comments_url":"https://api.github.com/repos/pali/p5-encode/comments{/number}","issue_comment_url":"https://api.github.com/repos/pali/p5-encode/issues/comments{/number}","contents_url":"https://api.github.com/repos/pali/p5-encode/contents/{+path}","compare_url":"https://api.github.com/repos/pali/p5-encode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pali/p5-encode/merges","archive_url":"https://api.github.com/repos/pali/p5-encode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pali/p5-encode/downloads","issues_url":"https://api.github.com/repos/pali/p5-encode/issues{/number}","pulls_url":"https://api.github.com/repos/pali/p5-encode/pulls{/number}","milestones_url":"https://api.github.com/repos/pali/p5-encode/milestones{/number}","notifications_url":"https://api.github.com/repos/pali/p5-encode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pali/p5-encode/labels{/name}","releases_url":"https://api.github.com/repos/pali/p5-encode/releases{/id}","deployments_url":"https://api.github.com/repos/pali/p5-encode/deployments","created_at":"2016-07-09T22:38:36Z","updated_at":"2016-07-09T22:38:40Z","pushed_at":"2016-10-26T22:49:50Z","git_url":"git://github.com/pali/p5-encode.git","ssh_url":"git@github.com:pali/p5-encode.git","clone_url":"https://github.com/pali/p5-encode.git","svn_url":"https://github.com/pali/p5-encode","homepage":"https://metacpan.org/release/Encode","size":2542,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dankogai:master","ref":"master","sha":"9f304268000961e96d68d8094db07a3c0ef9d52e","user":{"login":"dankogai","id":68812,"avatar_url":"https://avatars.githubusercontent.com/u/68812?v=3","gravatar_id":"","url":"https://api.github.com/users/dankogai","html_url":"https://github.com/dankogai","followers_url":"https://api.github.com/users/dankogai/followers","following_url":"https://api.github.com/users/dankogai/following{/other_user}","gists_url":"https://api.github.com/users/dankogai/gists{/gist_id}","starred_url":"https://api.github.com/users/dankogai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankogai/subscriptions","organizations_url":"https://api.github.com/users/dankogai/orgs","repos_url":"https://api.github.com/users/dankogai/repos","events_url":"https://api.github.com/users/dankogai/events{/privacy}","received_events_url":"https://api.github.com/users/dankogai/received_events","type":"User","site_admin":false},"repo":{"id":163904,"name":"p5-encode","full_name":"dankogai/p5-encode","owner":{"login":"dankogai","id":68812,"avatar_url":"https://avatars.githubusercontent.com/u/68812?v=3","gravatar_id":"","url":"https://api.github.com/users/dankogai","html_url":"https://github.com/dankogai","followers_url":"https://api.github.com/users/dankogai/followers","following_url":"https://api.github.com/users/dankogai/following{/other_user}","gists_url":"https://api.github.com/users/dankogai/gists{/gist_id}","starred_url":"https://api.github.com/users/dankogai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankogai/subscriptions","organizations_url":"https://api.github.com/users/dankogai/orgs","repos_url":"https://api.github.com/users/dankogai/repos","events_url":"https://api.github.com/users/dankogai/events{/privacy}","received_events_url":"https://api.github.com/users/dankogai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dankogai/p5-encode","description":"Encode - character encodings (for Perl 5.8 or better)","fork":false,"url":"https://api.github.com/repos/dankogai/p5-encode","forks_url":"https://api.github.com/repos/dankogai/p5-encode/forks","keys_url":"https://api.github.com/repos/dankogai/p5-encode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dankogai/p5-encode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dankogai/p5-encode/teams","hooks_url":"https://api.github.com/repos/dankogai/p5-encode/hooks","issue_events_url":"https://api.github.com/repos/dankogai/p5-encode/issues/events{/number}","events_url":"https://api.github.com/repos/dankogai/p5-encode/events","assignees_url":"https://api.github.com/repos/dankogai/p5-encode/assignees{/user}","branches_url":"https://api.github.com/repos/dankogai/p5-encode/branches{/branch}","tags_url":"https://api.github.com/repos/dankogai/p5-encode/tags","blobs_url":"https://api.github.com/repos/dankogai/p5-encode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dankogai/p5-encode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dankogai/p5-encode/git/refs{/sha}","trees_url":"https://api.github.com/repos/dankogai/p5-encode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dankogai/p5-encode/statuses/{sha}","languages_url":"https://api.github.com/repos/dankogai/p5-encode/languages","stargazers_url":"https://api.github.com/repos/dankogai/p5-encode/stargazers","contributors_url":"https://api.github.com/repos/dankogai/p5-encode/contributors","subscribers_url":"https://api.github.com/repos/dankogai/p5-encode/subscribers","subscription_url":"https://api.github.com/repos/dankogai/p5-encode/subscription","commits_url":"https://api.github.com/repos/dankogai/p5-encode/commits{/sha}","git_commits_url":"https://api.github.com/repos/dankogai/p5-encode/git/commits{/sha}","comments_url":"https://api.github.com/repos/dankogai/p5-encode/comments{/number}","issue_comment_url":"https://api.github.com/repos/dankogai/p5-encode/issues/comments{/number}","contents_url":"https://api.github.com/repos/dankogai/p5-encode/contents/{+path}","compare_url":"https://api.github.com/repos/dankogai/p5-encode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dankogai/p5-encode/merges","archive_url":"https://api.github.com/repos/dankogai/p5-encode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dankogai/p5-encode/downloads","issues_url":"https://api.github.com/repos/dankogai/p5-encode/issues{/number}","pulls_url":"https://api.github.com/repos/dankogai/p5-encode/pulls{/number}","milestones_url":"https://api.github.com/repos/dankogai/p5-encode/milestones{/number}","notifications_url":"https://api.github.com/repos/dankogai/p5-encode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dankogai/p5-encode/labels{/name}","releases_url":"https://api.github.com/repos/dankogai/p5-encode/releases{/id}","deployments_url":"https://api.github.com/repos/dankogai/p5-encode/deployments","created_at":"2009-03-31T08:45:55Z","updated_at":"2016-10-26T22:29:26Z","pushed_at":"2016-10-26T23:07:08Z","git_url":"git://github.com/dankogai/p5-encode.git","ssh_url":"git@github.com:dankogai/p5-encode.git","clone_url":"https://github.com/dankogai/p5-encode.git","svn_url":"https://github.com/dankogai/p5-encode","homepage":"https://metacpan.org/release/Encode","size":2583,"stargazers_count":27,"watchers_count":27,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":3,"forks":33,"open_issues":3,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dankogai/p5-encode/pulls/70"},"html":{"href":"https://github.com/dankogai/p5-encode/pull/70"},"issue":{"href":"https://api.github.com/repos/dankogai/p5-encode/issues/70"},"comments":{"href":"https://api.github.com/repos/dankogai/p5-encode/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/dankogai/p5-encode/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/dankogai/p5-encode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dankogai/p5-encode/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/dankogai/p5-encode/statuses/8d7150f0da05941392b7e56b2e2c7acd461979f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dankogai","id":68812,"avatar_url":"https://avatars.githubusercontent.com/u/68812?v=3","gravatar_id":"","url":"https://api.github.com/users/dankogai","html_url":"https://github.com/dankogai","followers_url":"https://api.github.com/users/dankogai/followers","following_url":"https://api.github.com/users/dankogai/following{/other_user}","gists_url":"https://api.github.com/users/dankogai/gists{/gist_id}","starred_url":"https://api.github.com/users/dankogai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankogai/subscriptions","organizations_url":"https://api.github.com/users/dankogai/orgs","repos_url":"https://api.github.com/users/dankogai/repos","events_url":"https://api.github.com/users/dankogai/events{/privacy}","received_events_url":"https://api.github.com/users/dankogai/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":383,"deletions":129,"changed_files":8}}
{"actor":{"display_login":"dankogai"}}