{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/78232659","id":78232659,"diff_hunk":"@@ -39,8 +41,8 @@ def PyInit(self):\n \n         self.declareProperty(StringArrayProperty(name=\"SampleLogs\", direction=Direction.Input, validator=validator),\n                              doc=\"Comma separated list of sample logs to compare.\")\n-        self.declareProperty(\"Tolerance\", 1e-3, validator=FloatBoundedValidator(lower=1e-7, upper=1.0),\n-                             doc=\"Tolerance for comparison of double values.\")\n+        self.declareProperty(\"Tolerance\", 1e-3, validator=FloatBoundedValidator(lower=1e-7, upper=100.0),","path":"Framework/PythonInterface/plugins/algorithms/CompareSampleLogs.py","position":15,"original_position":15,"commit_id":"2de80a46ce9fe81a3f7e2638f7b3261ebf560ffd","original_commit_id":"2de80a46ce9fe81a3f7e2638f7b3261ebf560ffd","user":{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false},"body":"Load the CNCS_7860 from doc tests. Run `FilterBadPulses` to eliminate al the  values when the accelerator was down. The `proton_charge` log is in picoCoulombs, with an average of 1.81E7, and a standard deviation of about 82000. It all depends on the units. I would just leave a lower bound  ","created_at":"2016-09-09T19:06:11Z","updated_at":"2016-09-09T19:06:11Z","html_url":"https://github.com/mantidproject/mantid/pull/17406#discussion_r78232659","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17406","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/78232659"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17406#discussion_r78232659"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17406"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17406","id":83983279,"html_url":"https://github.com/mantidproject/mantid/pull/17406","diff_url":"https://github.com/mantidproject/mantid/pull/17406.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17406.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17406","number":17406,"state":"open","locked":false,"title":"Refs #17405. Refactoring of CompareSampleLogs.","user":{"login":"mganeva","id":7290767,"avatar_url":"https://avatars.githubusercontent.com/u/7290767?v=3","gravatar_id":"","url":"https://api.github.com/users/mganeva","html_url":"https://github.com/mganeva","followers_url":"https://api.github.com/users/mganeva/followers","following_url":"https://api.github.com/users/mganeva/following{/other_user}","gists_url":"https://api.github.com/users/mganeva/gists{/gist_id}","starred_url":"https://api.github.com/users/mganeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mganeva/subscriptions","organizations_url":"https://api.github.com/users/mganeva/orgs","repos_url":"https://api.github.com/users/mganeva/repos","events_url":"https://api.github.com/users/mganeva/events{/privacy}","received_events_url":"https://api.github.com/users/mganeva/received_events","type":"User","site_admin":false},"body":"Refactoring of ComateSampleLogs algorithm to fix the mentioned issue and some minor code improvements. \r\n\r\n2 new unit tests.\r\n\r\n**To test:**\r\nCheck that nothing has got broken. The simple test for new behavoiur:\r\n```python\r\nws1 = CreateSampleWorkspace()\r\nws2 = CreateSampleWorkspace()\r\nAddSampleLog(ws1, 'chopper_speed', '13995', 'String')\r\nAddSampleLog(ws2, 'chopper_speed', '14004', 'Number')\r\nresult = CompareSampleLogs([ws1, ws2], 'chopper_speed', 10.0)\r\nprint result\r\n```\r\nthe result must be an empty string.\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #17405. \r\n\r\nDoes not need to be in the release notes.\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n\r\n","created_at":"2016-09-05T10:42:40Z","updated_at":"2016-09-09T19:06:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e276d950a6fb7b269c3ddcc2c9803c13e7db1f9","assignee":{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"assignees":[{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"Code Freeze: 16-Sep-2016\r\nDeveloper & Unscripted Testing: 16-Sep-2016 to 20-Sep-2016\r\nBeta test: 20-Sep-2016 to 04-Oct-2016\r\nRelease Date: 10-Oct-2016","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":701,"closed_issues":777,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-09-09T16:46:17Z","due_on":"2016-10-10T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17406/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17406/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17406/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/2de80a46ce9fe81a3f7e2638f7b3261ebf560ffd","head":{"label":"mganeva:compare_sample_logs","ref":"compare_sample_logs","sha":"2de80a46ce9fe81a3f7e2638f7b3261ebf560ffd","user":{"login":"mganeva","id":7290767,"avatar_url":"https://avatars.githubusercontent.com/u/7290767?v=3","gravatar_id":"","url":"https://api.github.com/users/mganeva","html_url":"https://github.com/mganeva","followers_url":"https://api.github.com/users/mganeva/followers","following_url":"https://api.github.com/users/mganeva/following{/other_user}","gists_url":"https://api.github.com/users/mganeva/gists{/gist_id}","starred_url":"https://api.github.com/users/mganeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mganeva/subscriptions","organizations_url":"https://api.github.com/users/mganeva/orgs","repos_url":"https://api.github.com/users/mganeva/repos","events_url":"https://api.github.com/users/mganeva/events{/privacy}","received_events_url":"https://api.github.com/users/mganeva/received_events","type":"User","site_admin":false},"repo":{"id":18762481,"name":"mantid","full_name":"mganeva/mantid","owner":{"login":"mganeva","id":7290767,"avatar_url":"https://avatars.githubusercontent.com/u/7290767?v=3","gravatar_id":"","url":"https://api.github.com/users/mganeva","html_url":"https://github.com/mganeva","followers_url":"https://api.github.com/users/mganeva/followers","following_url":"https://api.github.com/users/mganeva/following{/other_user}","gists_url":"https://api.github.com/users/mganeva/gists{/gist_id}","starred_url":"https://api.github.com/users/mganeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mganeva/subscriptions","organizations_url":"https://api.github.com/users/mganeva/orgs","repos_url":"https://api.github.com/users/mganeva/repos","events_url":"https://api.github.com/users/mganeva/events{/privacy}","received_events_url":"https://api.github.com/users/mganeva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mganeva/mantid","description":"Main repository for Mantid code","fork":true,"url":"https://api.github.com/repos/mganeva/mantid","forks_url":"https://api.github.com/repos/mganeva/mantid/forks","keys_url":"https://api.github.com/repos/mganeva/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mganeva/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mganeva/mantid/teams","hooks_url":"https://api.github.com/repos/mganeva/mantid/hooks","issue_events_url":"https://api.github.com/repos/mganeva/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mganeva/mantid/events","assignees_url":"https://api.github.com/repos/mganeva/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mganeva/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mganeva/mantid/tags","blobs_url":"https://api.github.com/repos/mganeva/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mganeva/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mganeva/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mganeva/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mganeva/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mganeva/mantid/languages","stargazers_url":"https://api.github.com/repos/mganeva/mantid/stargazers","contributors_url":"https://api.github.com/repos/mganeva/mantid/contributors","subscribers_url":"https://api.github.com/repos/mganeva/mantid/subscribers","subscription_url":"https://api.github.com/repos/mganeva/mantid/subscription","commits_url":"https://api.github.com/repos/mganeva/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mganeva/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mganeva/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mganeva/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mganeva/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mganeva/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mganeva/mantid/merges","archive_url":"https://api.github.com/repos/mganeva/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mganeva/mantid/downloads","issues_url":"https://api.github.com/repos/mganeva/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mganeva/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mganeva/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mganeva/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mganeva/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mganeva/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mganeva/mantid/deployments","created_at":"2014-04-14T13:56:33Z","updated_at":"2016-01-19T10:08:50Z","pushed_at":"2016-09-06T08:10:16Z","git_url":"git://github.com/mganeva/mantid.git","ssh_url":"git@github.com:mganeva/mantid.git","clone_url":"https://github.com/mganeva/mantid.git","svn_url":"https://github.com/mganeva/mantid","homepage":"www.mantidproject.org","size":382729,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"f858492b892fe2866c5e57a6a77c0c50630de951","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-08-22T07:35:41Z","pushed_at":"2016-09-09T16:38:29Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":437595,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1666,"forks":36,"open_issues":1666,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17406"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17406"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17406"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17406/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17406/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17406/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/2de80a46ce9fe81a3f7e2638f7b3261ebf560ffd"}}}}
{"actor":{"display_login":"AndreiSavici"}}