{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/692","repository_url":"https://api.github.com/repos/alphagov/specialist-publisher","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/692/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/692/comments","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/692/events","html_url":"https://github.com/alphagov/specialist-publisher/pull/692","id":145195054,"number":692,"title":"Add attachments to manual sections","user":{"login":"mathildathompson","id":3854347,"avatar_url":"https://avatars.githubusercontent.com/u/3854347?v=3","gravatar_id":"","url":"https://api.github.com/users/mathildathompson","html_url":"https://github.com/mathildathompson","followers_url":"https://api.github.com/users/mathildathompson/followers","following_url":"https://api.github.com/users/mathildathompson/following{/other_user}","gists_url":"https://api.github.com/users/mathildathompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mathildathompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathildathompson/subscriptions","organizations_url":"https://api.github.com/users/mathildathompson/orgs","repos_url":"https://api.github.com/users/mathildathompson/repos","events_url":"https://api.github.com/users/mathildathompson/events{/privacy}","received_events_url":"https://api.github.com/users/mathildathompson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-01T14:26:33Z","updated_at":"2016-04-04T09:45:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/692","html_url":"https://github.com/alphagov/specialist-publisher/pull/692","diff_url":"https://github.com/alphagov/specialist-publisher/pull/692.diff","patch_url":"https://github.com/alphagov/specialist-publisher/pull/692.patch"},"body":"- We discovered inconsistencies between the manuals, section and documents #find and #form_publishing_api methods during development. Redesigned to use hash everywhere as opposed to ostruct; \r\n- Refactor manuals controller update action to use #update_attributes method;\r\n- Create a manual_sections_attachment_controller. We initially wanted to use the same attachment controller, but because params and redirect URLs are different, we decided it would become too unreadable;\r\n- manual_sections_attachment_controller logic identical to attachments controller;\r\n- When you are reviewing, please let us know if there is anything else we can share between attachments and manual_section_attachments views. We are currently only sharing _attachments_form.html.erb. \r\n- [Trello Card](https://trello.com/c/ZK2nTIo6/43-handle-attachments)"},"comment":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments/205216236","html_url":"https://github.com/alphagov/specialist-publisher/pull/692#issuecomment-205216236","issue_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/692","id":205216236,"user":{"login":"benilovj","id":23801,"avatar_url":"https://avatars.githubusercontent.com/u/23801?v=3","gravatar_id":"","url":"https://api.github.com/users/benilovj","html_url":"https://github.com/benilovj","followers_url":"https://api.github.com/users/benilovj/followers","following_url":"https://api.github.com/users/benilovj/following{/other_user}","gists_url":"https://api.github.com/users/benilovj/gists{/gist_id}","starred_url":"https://api.github.com/users/benilovj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benilovj/subscriptions","organizations_url":"https://api.github.com/users/benilovj/orgs","repos_url":"https://api.github.com/users/benilovj/repos","events_url":"https://api.github.com/users/benilovj/events{/privacy}","received_events_url":"https://api.github.com/users/benilovj/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T09:45:09Z","updated_at":"2016-04-04T09:45:09Z","body":"@h-lame I'm about to look at #689, please leave it open and I'll rebase this PR once it's merged."}}