{"action":"opened","number":743,"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-client/pulls/743","id":87843035,"html_url":"https://github.com/apollostack/apollo-client/pull/743","diff_url":"https://github.com/apollostack/apollo-client/pull/743.diff","patch_url":"https://github.com/apollostack/apollo-client/pull/743.patch","issue_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743","number":743,"state":"open","locked":false,"title":"First implementation of observable to promise","user":{"login":"tmeasday","id":132554,"avatar_url":"https://avatars.githubusercontent.com/u/132554?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeasday","html_url":"https://github.com/tmeasday","followers_url":"https://api.github.com/users/tmeasday/followers","following_url":"https://api.github.com/users/tmeasday/following{/other_user}","gists_url":"https://api.github.com/users/tmeasday/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeasday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeasday/subscriptions","organizations_url":"https://api.github.com/users/tmeasday/orgs","repos_url":"https://api.github.com/users/tmeasday/repos","events_url":"https://api.github.com/users/tmeasday/events{/privacy}","received_events_url":"https://api.github.com/users/tmeasday/received_events","type":"User","site_admin":false},"body":"@helfer I was thinking about how it's awkward to pass `done` around and how mocha is much more suited to dealing with promises, and I figured out a way to turn something that fires multiple times (like an observable) into a promise that resolves or rejects.\r\n\r\nWhat do you think? Does it make it hard to understand what the tests are doing?\r\n\r\nThese two sample tests are pretty much unmodified by the change (in terms of what they do).","created_at":"2016-10-04T07:14:57Z","updated_at":"2016-10-04T07:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b59c4e1eeebe3e436c52c24bbb14033ff8fba86c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/743/commits","review_comments_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/743/comments","review_comment_url":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743/comments","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/58e13e0381bc9af0f2fde3027f14d4533baaeefe","head":{"label":"apollostack:observableToPromise","ref":"observableToPromise","sha":"58e13e0381bc9af0f2fde3027f14d4533baaeefe","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollostack/apollo-client","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-client","description":":rocket: A simple caching client for any GraphQL server and UI framework","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-client","forks_url":"https://api.github.com/repos/apollostack/apollo-client/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-client/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-client/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2016-10-04T03:36:59Z","pushed_at":"2016-10-04T07:14:57Z","git_url":"git://github.com/apollostack/apollo-client.git","ssh_url":"git@github.com:apollostack/apollo-client.git","clone_url":"https://github.com/apollostack/apollo-client.git","svn_url":"https://github.com/apollostack/apollo-client","homepage":"http://dev.apollodata.com/core/","size":2424,"stargazers_count":979,"watchers_count":979,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":108,"forks":77,"open_issues":108,"watchers":979,"default_branch":"master"}},"base":{"label":"apollostack:refactor-tests","ref":"refactor-tests","sha":"3d0ec271c70ed567917cfe3355465bdee43f225c","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollostack/apollo-client","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-client","description":":rocket: A simple caching client for any GraphQL server and UI framework","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-client","forks_url":"https://api.github.com/repos/apollostack/apollo-client/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-client/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-client/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2016-10-04T03:36:59Z","pushed_at":"2016-10-04T07:14:57Z","git_url":"git://github.com/apollostack/apollo-client.git","ssh_url":"git@github.com:apollostack/apollo-client.git","clone_url":"https://github.com/apollostack/apollo-client.git","svn_url":"https://github.com/apollostack/apollo-client","homepage":"http://dev.apollodata.com/core/","size":2424,"stargazers_count":979,"watchers_count":979,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":108,"forks":77,"open_issues":108,"watchers":979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/743"},"html":{"href":"https://github.com/apollostack/apollo-client/pull/743"},"issue":{"href":"https://api.github.com/repos/apollostack/apollo-client/issues/743"},"comments":{"href":"https://api.github.com/repos/apollostack/apollo-client/issues/743/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/743/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/apollo-client/pulls/743/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/apollo-client/statuses/58e13e0381bc9af0f2fde3027f14d4533baaeefe"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":59,"deletions":25,"changed_files":2}}
{"actor":{"display_login":"tmeasday"}}