{"action":"created","comment":{"url":"https://api.github.com/repos/salsita/redux-elm/pulls/comments/75451754","id":75451754,"diff_hunk":"@@ -9,9 +9,8 @@ const pingPongSaga = actions$ => actions$\n ","path":"test/sagas/rxjsSaga.test.js","position":1,"original_position":1,"commit_id":"cfbd151b3a3edf4cee1558eb234f195f91d4e3d3","original_commit_id":"cfbd151b3a3edf4cee1558eb234f195f91d4e3d3","user":{"login":"tomkis1","id":5079224,"avatar_url":"https://avatars.githubusercontent.com/u/5079224?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkis1","html_url":"https://github.com/tomkis1","followers_url":"https://api.github.com/users/tomkis1/followers","following_url":"https://api.github.com/users/tomkis1/following{/other_user}","gists_url":"https://api.github.com/users/tomkis1/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkis1/subscriptions","organizations_url":"https://api.github.com/users/tomkis1/orgs","repos_url":"https://api.github.com/users/tomkis1/repos","events_url":"https://api.github.com/users/tomkis1/events{/privacy}","received_events_url":"https://api.github.com/users/tomkis1/received_events","type":"User","site_admin":false},"body":"Just adjusting to new interface","created_at":"2016-08-19T09:25:02Z","updated_at":"2016-08-19T09:25:02Z","html_url":"https://github.com/salsita/redux-elm/pull/45#discussion_r75451754","pull_request_url":"https://api.github.com/repos/salsita/redux-elm/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/comments/75451754"},"html":{"href":"https://github.com/salsita/redux-elm/pull/45#discussion_r75451754"},"pull_request":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/salsita/redux-elm/pulls/45","id":81950852,"html_url":"https://github.com/salsita/redux-elm/pull/45","diff_url":"https://github.com/salsita/redux-elm/pull/45.diff","patch_url":"https://github.com/salsita/redux-elm/pull/45.patch","issue_url":"https://api.github.com/repos/salsita/redux-elm/issues/45","number":45,"state":"open","locked":false,"title":"Can no longer use put in ceratin sagas","user":{"login":"tomkis1","id":5079224,"avatar_url":"https://avatars.githubusercontent.com/u/5079224?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkis1","html_url":"https://github.com/tomkis1","followers_url":"https://api.github.com/users/tomkis1/followers","following_url":"https://api.github.com/users/tomkis1/following{/other_user}","gists_url":"https://api.github.com/users/tomkis1/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkis1/subscriptions","organizations_url":"https://api.github.com/users/tomkis1/orgs","repos_url":"https://api.github.com/users/tomkis1/repos","events_url":"https://api.github.com/users/tomkis1/events{/privacy}","received_events_url":"https://api.github.com/users/tomkis1/received_events","type":"User","site_admin":false},"body":"This is a fix for #44\r\n\r\nThe problem was that subscription to output Saga stream was made after Saga instantiation, however in `redux-saga` version - Saga may potentially dispatch (`yield put...`) action in the initialisation phase:\r\n\r\neg:\r\n\r\n```javascript\r\nfunction* saga() {\r\n  yield put({ type: 'SomeAction' });\r\n}\r\n```\r\n\r\nThis action is dispatched right upon Saga instantiation and therefore Saga repository has not been yet subscribed to Saga output stream and therefore the action is ignored.\r\n\r\nThe fix is easy: we just need to subscribe to output action stream inside the constructor of the Saga.","created_at":"2016-08-19T09:23:02Z","updated_at":"2016-08-19T09:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35f72f82405c78610db4daaea03c0fb9a6840a8e","assignee":{"login":"matthewgertner","id":870558,"avatar_url":"https://avatars.githubusercontent.com/u/870558?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewgertner","html_url":"https://github.com/matthewgertner","followers_url":"https://api.github.com/users/matthewgertner/followers","following_url":"https://api.github.com/users/matthewgertner/following{/other_user}","gists_url":"https://api.github.com/users/matthewgertner/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewgertner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewgertner/subscriptions","organizations_url":"https://api.github.com/users/matthewgertner/orgs","repos_url":"https://api.github.com/users/matthewgertner/repos","events_url":"https://api.github.com/users/matthewgertner/events{/privacy}","received_events_url":"https://api.github.com/users/matthewgertner/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewgertner","id":870558,"avatar_url":"https://avatars.githubusercontent.com/u/870558?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewgertner","html_url":"https://github.com/matthewgertner","followers_url":"https://api.github.com/users/matthewgertner/followers","following_url":"https://api.github.com/users/matthewgertner/following{/other_user}","gists_url":"https://api.github.com/users/matthewgertner/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewgertner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewgertner/subscriptions","organizations_url":"https://api.github.com/users/matthewgertner/orgs","repos_url":"https://api.github.com/users/matthewgertner/repos","events_url":"https://api.github.com/users/matthewgertner/events{/privacy}","received_events_url":"https://api.github.com/users/matthewgertner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/salsita/redux-elm/pulls/45/commits","review_comments_url":"https://api.github.com/repos/salsita/redux-elm/pulls/45/comments","review_comment_url":"https://api.github.com/repos/salsita/redux-elm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salsita/redux-elm/issues/45/comments","statuses_url":"https://api.github.com/repos/salsita/redux-elm/statuses/cfbd151b3a3edf4cee1558eb234f195f91d4e3d3","head":{"label":"salsita:can-no-longer-use-put-in-ceratin-sagas","ref":"can-no-longer-use-put-in-ceratin-sagas","sha":"cfbd151b3a3edf4cee1558eb234f195f91d4e3d3","user":{"login":"salsita","id":1357845,"avatar_url":"https://avatars.githubusercontent.com/u/1357845?v=3","gravatar_id":"","url":"https://api.github.com/users/salsita","html_url":"https://github.com/salsita","followers_url":"https://api.github.com/users/salsita/followers","following_url":"https://api.github.com/users/salsita/following{/other_user}","gists_url":"https://api.github.com/users/salsita/gists{/gist_id}","starred_url":"https://api.github.com/users/salsita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsita/subscriptions","organizations_url":"https://api.github.com/users/salsita/orgs","repos_url":"https://api.github.com/users/salsita/repos","events_url":"https://api.github.com/users/salsita/events{/privacy}","received_events_url":"https://api.github.com/users/salsita/received_events","type":"Organization","site_admin":false},"repo":{"id":50673771,"name":"redux-elm","full_name":"salsita/redux-elm","owner":{"login":"salsita","id":1357845,"avatar_url":"https://avatars.githubusercontent.com/u/1357845?v=3","gravatar_id":"","url":"https://api.github.com/users/salsita","html_url":"https://github.com/salsita","followers_url":"https://api.github.com/users/salsita/followers","following_url":"https://api.github.com/users/salsita/following{/other_user}","gists_url":"https://api.github.com/users/salsita/gists{/gist_id}","starred_url":"https://api.github.com/users/salsita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsita/subscriptions","organizations_url":"https://api.github.com/users/salsita/orgs","repos_url":"https://api.github.com/users/salsita/repos","events_url":"https://api.github.com/users/salsita/events{/privacy}","received_events_url":"https://api.github.com/users/salsita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsita/redux-elm","description":"The Elm Architecture in JavaScript http://salsita.github.io/redux-elm/","fork":false,"url":"https://api.github.com/repos/salsita/redux-elm","forks_url":"https://api.github.com/repos/salsita/redux-elm/forks","keys_url":"https://api.github.com/repos/salsita/redux-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsita/redux-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsita/redux-elm/teams","hooks_url":"https://api.github.com/repos/salsita/redux-elm/hooks","issue_events_url":"https://api.github.com/repos/salsita/redux-elm/issues/events{/number}","events_url":"https://api.github.com/repos/salsita/redux-elm/events","assignees_url":"https://api.github.com/repos/salsita/redux-elm/assignees{/user}","branches_url":"https://api.github.com/repos/salsita/redux-elm/branches{/branch}","tags_url":"https://api.github.com/repos/salsita/redux-elm/tags","blobs_url":"https://api.github.com/repos/salsita/redux-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsita/redux-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsita/redux-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsita/redux-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsita/redux-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/salsita/redux-elm/languages","stargazers_url":"https://api.github.com/repos/salsita/redux-elm/stargazers","contributors_url":"https://api.github.com/repos/salsita/redux-elm/contributors","subscribers_url":"https://api.github.com/repos/salsita/redux-elm/subscribers","subscription_url":"https://api.github.com/repos/salsita/redux-elm/subscription","commits_url":"https://api.github.com/repos/salsita/redux-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsita/redux-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsita/redux-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsita/redux-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsita/redux-elm/contents/{+path}","compare_url":"https://api.github.com/repos/salsita/redux-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsita/redux-elm/merges","archive_url":"https://api.github.com/repos/salsita/redux-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsita/redux-elm/downloads","issues_url":"https://api.github.com/repos/salsita/redux-elm/issues{/number}","pulls_url":"https://api.github.com/repos/salsita/redux-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/salsita/redux-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/salsita/redux-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsita/redux-elm/labels{/name}","releases_url":"https://api.github.com/repos/salsita/redux-elm/releases{/id}","deployments_url":"https://api.github.com/repos/salsita/redux-elm/deployments","created_at":"2016-01-29T16:10:28Z","updated_at":"2016-08-19T06:07:26Z","pushed_at":"2016-08-19T09:23:02Z","git_url":"git://github.com/salsita/redux-elm.git","ssh_url":"git@github.com:salsita/redux-elm.git","clone_url":"https://github.com/salsita/redux-elm.git","svn_url":"https://github.com/salsita/redux-elm","homepage":"","size":2287,"stargazers_count":298,"watchers_count":298,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":15,"forks":18,"open_issues":15,"watchers":298,"default_branch":"master"}},"base":{"label":"salsita:master","ref":"master","sha":"78aec13b451cf60dba5dd2ccddd2984d015a95fb","user":{"login":"salsita","id":1357845,"avatar_url":"https://avatars.githubusercontent.com/u/1357845?v=3","gravatar_id":"","url":"https://api.github.com/users/salsita","html_url":"https://github.com/salsita","followers_url":"https://api.github.com/users/salsita/followers","following_url":"https://api.github.com/users/salsita/following{/other_user}","gists_url":"https://api.github.com/users/salsita/gists{/gist_id}","starred_url":"https://api.github.com/users/salsita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsita/subscriptions","organizations_url":"https://api.github.com/users/salsita/orgs","repos_url":"https://api.github.com/users/salsita/repos","events_url":"https://api.github.com/users/salsita/events{/privacy}","received_events_url":"https://api.github.com/users/salsita/received_events","type":"Organization","site_admin":false},"repo":{"id":50673771,"name":"redux-elm","full_name":"salsita/redux-elm","owner":{"login":"salsita","id":1357845,"avatar_url":"https://avatars.githubusercontent.com/u/1357845?v=3","gravatar_id":"","url":"https://api.github.com/users/salsita","html_url":"https://github.com/salsita","followers_url":"https://api.github.com/users/salsita/followers","following_url":"https://api.github.com/users/salsita/following{/other_user}","gists_url":"https://api.github.com/users/salsita/gists{/gist_id}","starred_url":"https://api.github.com/users/salsita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsita/subscriptions","organizations_url":"https://api.github.com/users/salsita/orgs","repos_url":"https://api.github.com/users/salsita/repos","events_url":"https://api.github.com/users/salsita/events{/privacy}","received_events_url":"https://api.github.com/users/salsita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsita/redux-elm","description":"The Elm Architecture in JavaScript http://salsita.github.io/redux-elm/","fork":false,"url":"https://api.github.com/repos/salsita/redux-elm","forks_url":"https://api.github.com/repos/salsita/redux-elm/forks","keys_url":"https://api.github.com/repos/salsita/redux-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsita/redux-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsita/redux-elm/teams","hooks_url":"https://api.github.com/repos/salsita/redux-elm/hooks","issue_events_url":"https://api.github.com/repos/salsita/redux-elm/issues/events{/number}","events_url":"https://api.github.com/repos/salsita/redux-elm/events","assignees_url":"https://api.github.com/repos/salsita/redux-elm/assignees{/user}","branches_url":"https://api.github.com/repos/salsita/redux-elm/branches{/branch}","tags_url":"https://api.github.com/repos/salsita/redux-elm/tags","blobs_url":"https://api.github.com/repos/salsita/redux-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsita/redux-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsita/redux-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsita/redux-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsita/redux-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/salsita/redux-elm/languages","stargazers_url":"https://api.github.com/repos/salsita/redux-elm/stargazers","contributors_url":"https://api.github.com/repos/salsita/redux-elm/contributors","subscribers_url":"https://api.github.com/repos/salsita/redux-elm/subscribers","subscription_url":"https://api.github.com/repos/salsita/redux-elm/subscription","commits_url":"https://api.github.com/repos/salsita/redux-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsita/redux-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsita/redux-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsita/redux-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsita/redux-elm/contents/{+path}","compare_url":"https://api.github.com/repos/salsita/redux-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsita/redux-elm/merges","archive_url":"https://api.github.com/repos/salsita/redux-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsita/redux-elm/downloads","issues_url":"https://api.github.com/repos/salsita/redux-elm/issues{/number}","pulls_url":"https://api.github.com/repos/salsita/redux-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/salsita/redux-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/salsita/redux-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsita/redux-elm/labels{/name}","releases_url":"https://api.github.com/repos/salsita/redux-elm/releases{/id}","deployments_url":"https://api.github.com/repos/salsita/redux-elm/deployments","created_at":"2016-01-29T16:10:28Z","updated_at":"2016-08-19T06:07:26Z","pushed_at":"2016-08-19T09:23:02Z","git_url":"git://github.com/salsita/redux-elm.git","ssh_url":"git@github.com:salsita/redux-elm.git","clone_url":"https://github.com/salsita/redux-elm.git","svn_url":"https://github.com/salsita/redux-elm","homepage":"","size":2287,"stargazers_count":298,"watchers_count":298,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":15,"forks":18,"open_issues":15,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/45"},"html":{"href":"https://github.com/salsita/redux-elm/pull/45"},"issue":{"href":"https://api.github.com/repos/salsita/redux-elm/issues/45"},"comments":{"href":"https://api.github.com/repos/salsita/redux-elm/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salsita/redux-elm/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/salsita/redux-elm/statuses/cfbd151b3a3edf4cee1558eb234f195f91d4e3d3"}}}}
{"actor":{"display_login":"tomkis1"}}