{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/93820415","pull_request_review_id":14356523,"id":93820415,"diff_hunk":"@@ -687,17 +687,19 @@ QUnit.test( \"jQuery('html')\", function( assert ) {\n \tassert.equal( jQuery( \"\\\\<div\\\\>\" ).length, 0, \"Ignore escaped html characters\" );\n } );\n \n-QUnit.test( \"jQuery(tag-hyphenated elements) gh-1987\", function( assert ) {\n-\tassert.expect( 17 );\n-\n-\tjQuery.each( \"thead tbody tfoot colgroup caption tr th td\".split( \" \" ), function( i, name ) {\n-\t\tvar j = jQuery( \"<\" + name + \"-d></\" + name + \"-d>\" );\n-\t\tassert.ok( j[ 0 ], \"Create a tag-hyphenated elements\" );\n-\t\tassert.ok( jQuery.nodeName( j[ 0 ], name.toUpperCase() + \"-D\" ), \"Tag-hyphenated element has expected node name\" );\n+QUnit.test( \"jQuery(symbol separated elements)\", function( assert ) {\n+\tassert.expect( 34 );\n+\n+\tjQuery.each( \"- :\".split( \" \" ), function( i, symbol ) {\n+\t\tjQuery.each( \"thead tbody tfoot colgroup caption tr th td\".split( \" \" ), function( k, element ) {\n+\t\t\tvar j = jQuery( \"<\" + element + symbol + \"test></\" + element + symbol + \"test>\" );","path":"test/unit/core.js","position":16,"original_position":16,"commit_id":"c49613ae358e6d744fe105a2a2cda349bd4fc3ca","original_commit_id":"c49613ae358e6d744fe105a2a2cda349bd4fc3ca","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"And _this_ is getting even harder to read. Let's just introduce a `tagName` variable.","created_at":"2016-12-24T19:14:55Z","updated_at":"2016-12-24T19:17:09Z","html_url":"https://github.com/jquery/jquery/pull/3473#discussion_r93820415","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/3473","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/93820415"},"html":{"href":"https://github.com/jquery/jquery/pull/3473#discussion_r93820415"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3473"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/3473","id":99307158,"html_url":"https://github.com/jquery/jquery/pull/3473","diff_url":"https://github.com/jquery/jquery/pull/3473.diff","patch_url":"https://github.com/jquery/jquery/pull/3473.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/3473","number":3473,"state":"open","locked":false,"title":"Tests: Added tests for colon separated tag names","user":{"login":"broder","id":14093913,"avatar_url":"https://avatars.githubusercontent.com/u/14093913?v=3","gravatar_id":"","url":"https://api.github.com/users/broder","html_url":"https://github.com/broder","followers_url":"https://api.github.com/users/broder/followers","following_url":"https://api.github.com/users/broder/following{/other_user}","gists_url":"https://api.github.com/users/broder/gists{/gist_id}","starred_url":"https://api.github.com/users/broder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broder/subscriptions","organizations_url":"https://api.github.com/users/broder/orgs","repos_url":"https://api.github.com/users/broder/repos","events_url":"https://api.github.com/users/broder/events{/privacy}","received_events_url":"https://api.github.com/users/broder/received_events","type":"User","site_admin":false},"body":"### Summary ###\r\nThis should cover #2006. Are there any other symbols we would specifically like to test?\r\n\r\n### Checklist ###\r\n* [ ] All authors have signed the CLA at https://contribute.jquery.com/CLA/\r\n* [x] New tests have been added to show the fix or feature works\r\n* [x] Grunt build and unit tests pass locally with these changes\r\n* [ ] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com","created_at":"2016-12-24T16:41:51Z","updated_at":"2016-12-24T19:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c40fbc791079c37b8810637ff51904bc27d68e8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/3473/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/3473/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/3473/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/c49613ae358e6d744fe105a2a2cda349bd4fc3ca","head":{"label":"broder:symbol_tests","ref":"symbol_tests","sha":"c49613ae358e6d744fe105a2a2cda349bd4fc3ca","user":{"login":"broder","id":14093913,"avatar_url":"https://avatars.githubusercontent.com/u/14093913?v=3","gravatar_id":"","url":"https://api.github.com/users/broder","html_url":"https://github.com/broder","followers_url":"https://api.github.com/users/broder/followers","following_url":"https://api.github.com/users/broder/following{/other_user}","gists_url":"https://api.github.com/users/broder/gists{/gist_id}","starred_url":"https://api.github.com/users/broder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broder/subscriptions","organizations_url":"https://api.github.com/users/broder/orgs","repos_url":"https://api.github.com/users/broder/repos","events_url":"https://api.github.com/users/broder/events{/privacy}","received_events_url":"https://api.github.com/users/broder/received_events","type":"User","site_admin":false},"repo":{"id":77235471,"name":"jquery","full_name":"broder/jquery","owner":{"login":"broder","id":14093913,"avatar_url":"https://avatars.githubusercontent.com/u/14093913?v=3","gravatar_id":"","url":"https://api.github.com/users/broder","html_url":"https://github.com/broder","followers_url":"https://api.github.com/users/broder/followers","following_url":"https://api.github.com/users/broder/following{/other_user}","gists_url":"https://api.github.com/users/broder/gists{/gist_id}","starred_url":"https://api.github.com/users/broder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broder/subscriptions","organizations_url":"https://api.github.com/users/broder/orgs","repos_url":"https://api.github.com/users/broder/repos","events_url":"https://api.github.com/users/broder/events{/privacy}","received_events_url":"https://api.github.com/users/broder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/broder/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/broder/jquery","forks_url":"https://api.github.com/repos/broder/jquery/forks","keys_url":"https://api.github.com/repos/broder/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broder/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broder/jquery/teams","hooks_url":"https://api.github.com/repos/broder/jquery/hooks","issue_events_url":"https://api.github.com/repos/broder/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/broder/jquery/events","assignees_url":"https://api.github.com/repos/broder/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/broder/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/broder/jquery/tags","blobs_url":"https://api.github.com/repos/broder/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broder/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broder/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/broder/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broder/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/broder/jquery/languages","stargazers_url":"https://api.github.com/repos/broder/jquery/stargazers","contributors_url":"https://api.github.com/repos/broder/jquery/contributors","subscribers_url":"https://api.github.com/repos/broder/jquery/subscribers","subscription_url":"https://api.github.com/repos/broder/jquery/subscription","commits_url":"https://api.github.com/repos/broder/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/broder/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/broder/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/broder/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/broder/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/broder/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broder/jquery/merges","archive_url":"https://api.github.com/repos/broder/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broder/jquery/downloads","issues_url":"https://api.github.com/repos/broder/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/broder/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/broder/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/broder/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broder/jquery/labels{/name}","releases_url":"https://api.github.com/repos/broder/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/broder/jquery/deployments","created_at":"2016-12-23T15:51:45Z","updated_at":"2016-12-23T15:51:57Z","pushed_at":"2016-12-24T16:31:01Z","git_url":"git://github.com/broder/jquery.git","ssh_url":"git@github.com:broder/jquery.git","clone_url":"https://github.com/broder/jquery.git","svn_url":"https://github.com/broder/jquery","homepage":"https://jquery.com/","size":27007,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"bf3a43eff8682b59cec785be6003753fa4b93706","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/jquery/deployments","created_at":"2009-04-03T15:20:14Z","updated_at":"2016-12-24T17:41:22Z","pushed_at":"2016-12-24T16:41:52Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"https://jquery.com/","size":27021,"stargazers_count":42761,"watchers_count":42761,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":11851,"mirror_url":null,"open_issues_count":78,"forks":11851,"open_issues":78,"watchers":42761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3473"},"html":{"href":"https://github.com/jquery/jquery/pull/3473"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/3473"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/3473/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3473/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3473/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/c49613ae358e6d744fe105a2a2cda349bd4fc3ca"}}}}
{"actor":{"display_login":"gibson042"}}