{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3242","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3242/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3242/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3242/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3242","id":190164106,"number":3242,"title":"Refactor home buttons","user":{"login":"srallen","id":5016731,"avatar_url":"https://avatars.githubusercontent.com/u/5016731?v=3","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"amyrebecca","id":8491638,"avatar_url":"https://avatars.githubusercontent.com/u/8491638?v=3","gravatar_id":"","url":"https://api.github.com/users/amyrebecca","html_url":"https://github.com/amyrebecca","followers_url":"https://api.github.com/users/amyrebecca/followers","following_url":"https://api.github.com/users/amyrebecca/following{/other_user}","gists_url":"https://api.github.com/users/amyrebecca/gists{/gist_id}","starred_url":"https://api.github.com/users/amyrebecca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyrebecca/subscriptions","organizations_url":"https://api.github.com/users/amyrebecca/orgs","repos_url":"https://api.github.com/users/amyrebecca/repos","events_url":"https://api.github.com/users/amyrebecca/events{/privacy}","received_events_url":"https://api.github.com/users/amyrebecca/received_events","type":"User","site_admin":false},"assignees":[{"login":"amyrebecca","id":8491638,"avatar_url":"https://avatars.githubusercontent.com/u/8491638?v=3","gravatar_id":"","url":"https://api.github.com/users/amyrebecca","html_url":"https://github.com/amyrebecca","followers_url":"https://api.github.com/users/amyrebecca/followers","following_url":"https://api.github.com/users/amyrebecca/following{/other_user}","gists_url":"https://api.github.com/users/amyrebecca/gists{/gist_id}","starred_url":"https://api.github.com/users/amyrebecca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyrebecca/subscriptions","organizations_url":"https://api.github.com/users/amyrebecca/orgs","repos_url":"https://api.github.com/users/amyrebecca/repos","events_url":"https://api.github.com/users/amyrebecca/events{/privacy}","received_events_url":"https://api.github.com/users/amyrebecca/received_events","type":"User","site_admin":false},{"login":"wgranger","id":14099077,"avatar_url":"https://avatars.githubusercontent.com/u/14099077?v=3","gravatar_id":"","url":"https://api.github.com/users/wgranger","html_url":"https://github.com/wgranger","followers_url":"https://api.github.com/users/wgranger/followers","following_url":"https://api.github.com/users/wgranger/following{/other_user}","gists_url":"https://api.github.com/users/wgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/wgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgranger/subscriptions","organizations_url":"https://api.github.com/users/wgranger/orgs","repos_url":"https://api.github.com/users/wgranger/repos","events_url":"https://api.github.com/users/wgranger/events{/privacy}","received_events_url":"https://api.github.com/users/wgranger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-17T21:06:27Z","updated_at":"2016-11-18T21:50:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/3242","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3242","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3242.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3242.patch"},"body":"This is a refactor of the project home page and the 'Get started!' or workflow buttons depending on project state and/or experimental features. This is in anticipation of setting up a experiment split for workflow assignment for Gravity Spy. Additionally fixes #3148.\r\n\r\nStaging link: https://refactor-home-buttons.pfe-preview.zooniverse.org/projects/zooniverse/gravity-spy?env=production\r\n\r\n@amyrebecca and @wgranger could you review and prioritize for merge on Monday?\r\n\r\n@eatyourgreens I added an `ariaDisabled` attribute to the `<Link />` components that are disabled, but VoiceOver wasn't communicating that they were disabled. Am I using it wrong or should I use something else?\r\n\r\n# Review Checklist\r\n\r\n- [x] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [x] Does it work on mobile?\r\n- [x] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [x] Did you deploy a staging branch?\r\n- [ ] Did you get any type checking errors from [Babel Typecheck](https://github.com/codemix/babel-plugin-typecheck)\r\n\r\n\r\n## Optional\r\n\r\n- [x] If it's a new component, is it in ES6? Is it clear of warnings from ESLint?\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/261651064","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3242#issuecomment-261651064","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3242","id":261651064,"user":{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars.githubusercontent.com/u/59547?v=3","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T21:50:13Z","updated_at":"2016-11-18T21:50:13Z","body":"@srallen `disabled` usually applies to form controls, or things that are emulating form controls. If you want to disable a link, why not render it as a `<span>` with the same CSS classes instead?"}}
{"actor":{"display_login":"eatyourgreens"}}