{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/reselect/issues/162","repository_url":"https://api.github.com/repos/reactjs/reselect","labels_url":"https://api.github.com/repos/reactjs/reselect/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/reselect/issues/162/comments","events_url":"https://api.github.com/repos/reactjs/reselect/issues/162/events","html_url":"https://github.com/reactjs/reselect/issues/162","id":174530881,"number":162,"title":"reconsider allowing selectors to take arguments","user":{"login":"jwoudenberg","id":1525551,"avatar_url":"https://avatars.githubusercontent.com/u/1525551?v=3","gravatar_id":"","url":"https://api.github.com/users/jwoudenberg","html_url":"https://github.com/jwoudenberg","followers_url":"https://api.github.com/users/jwoudenberg/followers","following_url":"https://api.github.com/users/jwoudenberg/following{/other_user}","gists_url":"https://api.github.com/users/jwoudenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jwoudenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwoudenberg/subscriptions","organizations_url":"https://api.github.com/users/jwoudenberg/orgs","repos_url":"https://api.github.com/users/jwoudenberg/repos","events_url":"https://api.github.com/users/jwoudenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jwoudenberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-01T13:58:53Z","updated_at":"2016-09-01T20:06:52Z","closed_at":null,"body":"So I read the issues related to selectors taking no arguments (#18, #38, #59) and I understand the reasoning behind it: that if you feel the need to create a selector with a dynamic argument, probably that argument should be in your store state somewhere.\r\n\r\nOnly I don't believe that's necessarily true. In a project I'm working on we keep the router state in the router itself and don't jump through extra hoops to sync this with the store state. I think this too is [a pretty well established pattern](http://stackoverflow.com/questions/36722584/how-to-sync-redux-state-and-url-hash-tag-params/36749963#36749963). It would be great to be able to pass the router state into a selector as an argument.\r\n\r\nI'm curious to hear your thoughts :smile:."},"comment":{"url":"https://api.github.com/repos/reactjs/reselect/issues/comments/244196125","html_url":"https://github.com/reactjs/reselect/issues/162#issuecomment-244196125","issue_url":"https://api.github.com/repos/reactjs/reselect/issues/162","id":244196125,"user":{"login":"ellbee","id":6018379,"avatar_url":"https://avatars.githubusercontent.com/u/6018379?v=3","gravatar_id":"","url":"https://api.github.com/users/ellbee","html_url":"https://github.com/ellbee","followers_url":"https://api.github.com/users/ellbee/followers","following_url":"https://api.github.com/users/ellbee/following{/other_user}","gists_url":"https://api.github.com/users/ellbee/gists{/gist_id}","starred_url":"https://api.github.com/users/ellbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellbee/subscriptions","organizations_url":"https://api.github.com/users/ellbee/orgs","repos_url":"https://api.github.com/users/ellbee/repos","events_url":"https://api.github.com/users/ellbee/events{/privacy}","received_events_url":"https://api.github.com/users/ellbee/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T20:06:52Z","updated_at":"2016-09-01T20:06:52Z","body":"When using `connect`, component props are passed as the second argument to the selector. This allows you to use the pattern referenced in your link.\r\n\r\nMore details here: https://github.com/reactjs/reselect#createselectorinputselectors--inputselectors-resultfunc"}}
{"actor":{"display_login":"ellbee"}}