{"push_id":953178252,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"345193dac1f10d50bab181e6d3a32890ff656c7c","before":"edadada8e4c79b21bdfdc682ea94061014c1db48","commits":[{"sha":"345193dac1f10d50bab181e6d3a32890ff656c7c","author":{"email":"2a472dda53d77df829274da40ffd1c737a7bd430@kollective.com","name":"paultar"},"message":"Refactor to comply with Microsoft requirements:\n1.       The template does not have a baseURL parameter and uses [uri(deployment().properties.templateLink.uri, concat('storageAccount-', parameters('storageAccountNewOrExisting'), '.json'))] to determine the location of linked templates, it would be better if the first part of this was used as the default for baseURL and then the baseURL was used to construct the valriable.\n\n2.       The template can be simplified a lot by using loops, the NICs, VMs, load balancers, IP addresses etc. are all repeated 3 times.\n\n3.       Is it necessary to have RDP on port 3389 for each VM? Two  suggestions here:\nHave the first VM only exposed and then use it as a jumpbox to get to the others.\nHave one LB and use different ports to expose RDP on the other VMs.\n\nIf either of these can be done then the DNS selection can be done using the PublicIP combo control (rather than concatenating unique string on to the end of a user supplied string) and there will be validation in the portal\n\n4.       Storage wise in createUIDefinition and the two storage account templates it needs to exclude the use of Premium Storage,  the allowed VM sizes do not support it","distinct":true,"url":"https://api.github.com/repos/dnascimb/azure-the_creator/commits/345193dac1f10d50bab181e6d3a32890ff656c7c"}]}