{"comment":{"url":"https://api.github.com/repos/NetLogo/models/comments/18653320","html_url":"https://github.com/NetLogo/models/commit/9e9d2f02e9136e7d37870ff3c65e720e72204bba#commitcomment-18653320","id":18653320,"user":{"login":"nicolaspayette","id":908754,"avatar_url":"https://avatars.githubusercontent.com/u/908754?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaspayette","html_url":"https://github.com/nicolaspayette","followers_url":"https://api.github.com/users/nicolaspayette/followers","following_url":"https://api.github.com/users/nicolaspayette/following{/other_user}","gists_url":"https://api.github.com/users/nicolaspayette/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaspayette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaspayette/subscriptions","organizations_url":"https://api.github.com/users/nicolaspayette/orgs","repos_url":"https://api.github.com/users/nicolaspayette/repos","events_url":"https://api.github.com/users/nicolaspayette/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaspayette/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"9e9d2f02e9136e7d37870ff3c65e720e72204bba","created_at":"2016-08-16T09:48:43Z","updated_at":"2016-08-16T09:48:43Z","body":"> I didn't realize you had to actually go into each model and specify the\r\ncommand (I think that's odd / maybe stupid).\r\n\r\nIt used to be that you had to directly edit the model file in a text editor. Now, at least, there's the Preview Commands Editor.\r\n\r\n> So in order to add a manual preview image, you have to: 1. Create a\r\npreview image; 2. Add that preview image within NetLogo; 3. Add that\r\nmodel to the Exceptions list. That seems like a lot...\r\n\r\nThere isn't any way out of 1 and 2, is there?\r\n\r\nAs for 3, maybe I could be convinced to remove the test. I wrote it at a time when I was trying to purge the Library of most manual previews, adding exceptions one by one as I went along.\r\n\r\nManual previews are generally undesirable because:\r\n\r\n- they easily get out of sync with the model;\r\n- they're not always easy to reproduce when you do need to update them;\r\n- they're less convenient (and more error prone) if you need to move files around (e.g. in https://github.com/NetLogo/NetLogo/blob/hexy/project/ModelCrossReference.scala);\r\n- they can't be used to generate checksums which are used in the main NetLogo tests to guard against regressions in NetLogo itself;\r\n- they take up space in the repo.\r\n\r\nSo I don't mind if there is a bit of overhead (as a dissuasive measure) when adding a manual preview.\r\n\r\nThat being said, LevelSpace is likely to require mostly manual previews, so we should probably just add a general `\"/ls/\"` exception like we did for [`\"HubNet\", \"/sound/\", \"GoGo\", \"Arduino\"`](https://github.com/NetLogo/models/blob/master/src/test/scala/org/nlogo/models/PreviewImagesTests.scala#L26)."}}
{"actor":{"display_login":"nicolaspayette"}}