{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/68539536","id":68539536,"diff_hunk":"@@ -18,37 +18,39 @@ import HttpMethods._\n trait RequestBuilding extends TransformerPipelineSupport {\n   type RequestTransformer = HttpRequest ⇒ HttpRequest\n \n+  implicit val timeout = Timeout(1.second)\n+\n   class RequestBuilder(val method: HttpMethod) {\n     def apply(): HttpRequest =\n       apply(\"/\")\n \n-    def apply(uri: String): HttpRequest =\n+    def apply(uri: String)(implicit timeout: Timeout): HttpRequest =\n       apply(uri, HttpEntity.Empty)\n \n-    def apply[T](uri: String, content: T)(implicit m: ToEntityMarshaller[T], ec: ExecutionContext): HttpRequest =\n+    def apply[T](uri: String, content: T)(implicit m: ToEntityMarshaller[T], ec: ExecutionContext, timeout: Timeout): HttpRequest =","path":"akka-http/src/main/scala/akka/http/scaladsl/client/RequestBuilding.scala","position":15,"original_position":15,"commit_id":"8788c1ef211ca97bd01a4d99aa3f018b44ba03e4","original_commit_id":"8788c1ef211ca97bd01a4d99aa3f018b44ba03e4","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"Changing the signature of a method is definitely a binary incompatible evolution, and I'm surprised MiMa doesn't report it. Maybe check if you have a misconfigured MiMa problems' filter? If not, then it would be great if you could pinpoint the problem and create an issue with a streamlined test to reproduce. Thanks!","created_at":"2016-06-27T08:32:14Z","updated_at":"2016-06-27T08:32:14Z","html_url":"https://github.com/akka/akka/pull/20825#discussion_r68539536","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/20825","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/68539536"},"html":{"href":"https://github.com/akka/akka/pull/20825#discussion_r68539536"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/20825"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/20825","id":75079375,"html_url":"https://github.com/akka/akka/pull/20825","diff_url":"https://github.com/akka/akka/pull/20825.diff","patch_url":"https://github.com/akka/akka/pull/20825.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/20825","number":20825,"state":"open","locked":false,"title":"Better configurable timeouts for Akka-HTTP, #20798","user":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"body":"- Add implicit timeout to all `RequestBuilding` overloads\r\n- Uniformize the usage of `RouteTestTimeout` \r\n\r\nReference #20798.\r\n","created_at":"2016-06-24T08:18:36Z","updated_at":"2016-06-27T08:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e25aa297dd1d8673c17df9131c89365f5c0a98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/20825/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/20825/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/20825/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/8788c1ef211ca97bd01a4d99aa3f018b44ba03e4","head":{"label":"zifeo:20798-requestBuilding-timeouts","ref":"20798-requestBuilding-timeouts","sha":"8788c1ef211ca97bd01a4d99aa3f018b44ba03e4","user":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"repo":{"id":61424550,"name":"akka","full_name":"zifeo/akka","owner":{"login":"zifeo","id":9053709,"avatar_url":"https://avatars.githubusercontent.com/u/9053709?v=3","gravatar_id":"","url":"https://api.github.com/users/zifeo","html_url":"https://github.com/zifeo","followers_url":"https://api.github.com/users/zifeo/followers","following_url":"https://api.github.com/users/zifeo/following{/other_user}","gists_url":"https://api.github.com/users/zifeo/gists{/gist_id}","starred_url":"https://api.github.com/users/zifeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zifeo/subscriptions","organizations_url":"https://api.github.com/users/zifeo/orgs","repos_url":"https://api.github.com/users/zifeo/repos","events_url":"https://api.github.com/users/zifeo/events{/privacy}","received_events_url":"https://api.github.com/users/zifeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zifeo/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/zifeo/akka","forks_url":"https://api.github.com/repos/zifeo/akka/forks","keys_url":"https://api.github.com/repos/zifeo/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zifeo/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zifeo/akka/teams","hooks_url":"https://api.github.com/repos/zifeo/akka/hooks","issue_events_url":"https://api.github.com/repos/zifeo/akka/issues/events{/number}","events_url":"https://api.github.com/repos/zifeo/akka/events","assignees_url":"https://api.github.com/repos/zifeo/akka/assignees{/user}","branches_url":"https://api.github.com/repos/zifeo/akka/branches{/branch}","tags_url":"https://api.github.com/repos/zifeo/akka/tags","blobs_url":"https://api.github.com/repos/zifeo/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zifeo/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zifeo/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/zifeo/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zifeo/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/zifeo/akka/languages","stargazers_url":"https://api.github.com/repos/zifeo/akka/stargazers","contributors_url":"https://api.github.com/repos/zifeo/akka/contributors","subscribers_url":"https://api.github.com/repos/zifeo/akka/subscribers","subscription_url":"https://api.github.com/repos/zifeo/akka/subscription","commits_url":"https://api.github.com/repos/zifeo/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/zifeo/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/zifeo/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/zifeo/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/zifeo/akka/contents/{+path}","compare_url":"https://api.github.com/repos/zifeo/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zifeo/akka/merges","archive_url":"https://api.github.com/repos/zifeo/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zifeo/akka/downloads","issues_url":"https://api.github.com/repos/zifeo/akka/issues{/number}","pulls_url":"https://api.github.com/repos/zifeo/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/zifeo/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/zifeo/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zifeo/akka/labels{/name}","releases_url":"https://api.github.com/repos/zifeo/akka/releases{/id}","deployments_url":"https://api.github.com/repos/zifeo/akka/deployments","created_at":"2016-06-18T08:32:28Z","updated_at":"2016-06-18T08:32:43Z","pushed_at":"2016-06-25T15:35:50Z","git_url":"git://github.com/zifeo/akka.git","ssh_url":"git@github.com:zifeo/akka.git","clone_url":"https://github.com/zifeo/akka.git","svn_url":"https://github.com/zifeo/akka","homepage":"http://akka.io","size":194905,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"6777e7f7d97b005bcbfc905b1a3b4d578979b72d","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-06-27T07:22:54Z","pushed_at":"2016-06-26T15:13:38Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":234777,"stargazers_count":5680,"watchers_count":5680,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1782,"mirror_url":null,"open_issues_count":685,"forks":1782,"open_issues":685,"watchers":5680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/20825"},"html":{"href":"https://github.com/akka/akka/pull/20825"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/20825"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/20825/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/20825/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/20825/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/8788c1ef211ca97bd01a4d99aa3f018b44ba03e4"}}}}
{"actor":{"display_login":"dotta"}}