{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/4021","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/4021/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/4021/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/4021/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/4021","id":134615326,"number":4021,"title":"Library resource prefix breaks current attrs.xml","user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"5319e7"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/26","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/android-v4.0.0","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/26/labels","id":1520788,"number":26,"title":"android-v4.0.0","description":"","creator":{"login":"bleege","id":989928,"avatar_url":"https://avatars.githubusercontent.com/u/989928?v=3","gravatar_id":"","url":"https://api.github.com/users/bleege","html_url":"https://github.com/bleege","followers_url":"https://api.github.com/users/bleege/followers","following_url":"https://api.github.com/users/bleege/following{/other_user}","gists_url":"https://api.github.com/users/bleege/gists{/gist_id}","starred_url":"https://api.github.com/users/bleege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleege/subscriptions","organizations_url":"https://api.github.com/users/bleege/orgs","repos_url":"https://api.github.com/users/bleege/repos","events_url":"https://api.github.com/users/bleege/events{/privacy}","received_events_url":"https://api.github.com/users/bleege/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":154,"state":"open","created_at":"2016-01-19T23:39:55Z","updated_at":"2016-02-24T23:42:14Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-18T15:43:04Z","updated_at":"2016-02-25T09:18:12Z","closed_at":null,"body":"For #3119 it seemed a great improvement to add `resourcePrefix` to build.gradle.\r\nThis enforces that resources should start with a certain prefix.\r\nFor this project I have chosen for the `mapbox_` prefix.\r\n\r\nThis resulted in following `strings.xml`:\r\n\r\n```xml\r\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<resources>\r\n    <string name=\"mapbox_compassContentDescription\">Map compass. Click to reset the map rotation to North.</string>\r\n    <string name=\"mapbox_attributionsIconContentDescription\">Attribution icon. Click to show attribution dialog.</string>\r\n    <string name=\"mapbox_attributionsDialogTitle\">Mapbox Android SDK</string>\r\n    <string name=\"mapbox_attributionTelemetryTitle\">Make Mapbox Maps Better</string>\r\n    <string name=\"mapbox_attributionTelemetryMessage\">You are helping to make OpenStreetMap and Mapbox maps better by contributing anonymous usage data.</string>\r\n    <string name=\"mapbox_mapboxIconContentDescription\">The Mapbox logo.</string>\r\n    <string name=\"mapbox_infoWindowTitle\">Title</string>\r\n    <string name=\"mapbox_infoWindowDescription\">Description</string>\r\n    <string name=\"mapbox_infoWindowAddress\">Address</string>\r\n\r\n    <!-- these are public -->\r\n    <string name=\"mapbox_style_mapbox_streets\">mapbox://styles/mapbox/streets-v8</string>\r\n    <string name=\"mapbox_style_emerald\">mapbox://styles/mapbox/emerald-v8</string>\r\n    <string name=\"mapbox_style_light\">mapbox://styles/mapbox/light-v8</string>\r\n    <string name=\"mapbox_style_dark\">mapbox://styles/mapbox/dark-v8</string>\r\n    <string name=\"mapbox_style_satellite\">mapbox://styles/mapbox/satellite-v8</string>\r\n    <string name=\"mapbox_style_satellite_streets\">mapbox://styles/mapbox/satellite-hybrid-v8</string>\r\n</resources>\r\n```\r\n\r\nThis is a great improvement in comparison with before, the resource prefix requires us to follow certain guidelines. Now with implementing #4018, I'm noticing this is required also for other types of resources: \r\neg `attrs.xml`:\r\n\r\n![screen shot 2016-02-18 at 16 36 34](https://cloud.githubusercontent.com/assets/2151639/13148475/d7782aba-d65d-11e5-8b8e-d76e585b784b.png)\r\n\r\nAt first this doesn't seem a problem, but when you look at the end result in java code:\r\n\r\n```java\r\ntypedArray.getBoolean(R.styleable.mapbox_MapView_mapbox_zoom_enabled, true));\r\n```\r\n\r\ninstead of\r\n\r\n```java\r\ntypedArray.getBoolean(R.styleable.MapView_scroll_enabled, true)\r\n```\r\n\r\nI'm personally not a big fan of this, but this API is only for internal use. \r\nEnd users will only see the following API:\r\n\r\n![screen shot 2016-02-18 at 16 40 50](https://cloud.githubusercontent.com/assets/2151639/13148633/72d56176-d65e-11e5-9b22-d8018c935171.png)\r\n\r\nWhat are your opinion on this? @bleege  @zugaldia\r\n\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/188684775","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/4021#issuecomment-188684775","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/4021","id":188684775,"user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T09:18:12Z","updated_at":"2016-02-25T09:18:12Z","body":"@zugaldia \r\nboth the styles and the attributes you mentioned [above](https://github.com/mapbox/mapbox-gl-native/issues/4021#issuecomment-187277018) are public.\r\nYou can see all our public resources in [public.xml](https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/res-public/values/public.xml)\r\n\r\nFor now I'm going to drop the `mapbox_` prefix for all resources except for `mapbox_access_token`.\r\n"}}