{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/4261","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/4261/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/4261/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/4261/events","html_url":"https://github.com/callemall/material-ui/pull/4261","id":154799826,"number":4261,"title":"[Avatar] Use inner shadow for border","user":{"login":"mbrookes","id":357702,"avatar_url":"https://avatars.githubusercontent.com/u/357702?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrookes","html_url":"https://github.com/mbrookes","followers_url":"https://api.github.com/users/mbrookes/followers","following_url":"https://api.github.com/users/mbrookes/following{/other_user}","gists_url":"https://api.github.com/users/mbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrookes/subscriptions","organizations_url":"https://api.github.com/users/mbrookes/orgs","repos_url":"https://api.github.com/users/mbrookes/repos","events_url":"https://api.github.com/users/mbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/mbrookes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/callemall/material-ui/labels/PR:%20Breaking%20Change","name":"PR: Breaking Change","color":"A33CD6"},{"url":"https://api.github.com/repos/callemall/material-ui/labels/PR:%20Needs%20Review","name":"PR: Needs Review","color":"fbca04"},{"url":"https://api.github.com/repos/callemall/material-ui/labels/PR:%20Needs%20Revision","name":"PR: Needs Revision","color":"e11d21"},{"url":"https://api.github.com/repos/callemall/material-ui/labels/PR:%20On%20Hold","name":"PR: On Hold","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/callemall/material-ui/milestones/14","html_url":"https://github.com/callemall/material-ui/milestones/0.16.0%20Release","labels_url":"https://api.github.com/repos/callemall/material-ui/milestones/14/labels","id":1582007,"number":14,"title":"0.16.0 Release","description":"","creator":{"login":"alitaheri","id":8528759,"avatar_url":"https://avatars.githubusercontent.com/u/8528759?v=3","gravatar_id":"","url":"https://api.github.com/users/alitaheri","html_url":"https://github.com/alitaheri","followers_url":"https://api.github.com/users/alitaheri/followers","following_url":"https://api.github.com/users/alitaheri/following{/other_user}","gists_url":"https://api.github.com/users/alitaheri/gists{/gist_id}","starred_url":"https://api.github.com/users/alitaheri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alitaheri/subscriptions","organizations_url":"https://api.github.com/users/alitaheri/orgs","repos_url":"https://api.github.com/users/alitaheri/repos","events_url":"https://api.github.com/users/alitaheri/events{/privacy}","received_events_url":"https://api.github.com/users/alitaheri/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":4,"state":"open","created_at":"2016-02-14T16:34:47Z","updated_at":"2016-05-13T22:36:02Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2016-05-13T21:03:41Z","updated_at":"2016-05-18T20:42:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/4261","html_url":"https://github.com/callemall/material-ui/pull/4261","diff_url":"https://github.com/callemall/material-ui/pull/4261.diff","patch_url":"https://github.com/callemall/material-ui/pull/4261.patch"},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! -->\r\n\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\nUse an inner shadow for the border to allow the image to be an `<img>` not `backgroundImage`.\r\n\r\nCloses #4254.\r\n"},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/220151842","html_url":"https://github.com/callemall/material-ui/pull/4261#issuecomment-220151842","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/4261","id":220151842,"user":{"login":"mbrookes","id":357702,"avatar_url":"https://avatars.githubusercontent.com/u/357702?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrookes","html_url":"https://github.com/mbrookes","followers_url":"https://api.github.com/users/mbrookes/followers","following_url":"https://api.github.com/users/mbrookes/following{/other_user}","gists_url":"https://api.github.com/users/mbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrookes/subscriptions","organizations_url":"https://api.github.com/users/mbrookes/orgs","repos_url":"https://api.github.com/users/mbrookes/repos","events_url":"https://api.github.com/users/mbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/mbrookes/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T20:42:45Z","updated_at":"2016-05-18T20:42:45Z","body":"Avatar images with a white background against a white background look pretty awful (@nathanmarks posted a good example in chat), but perhaps they're  not common enough to worry about.\r\n\r\nI think the border overlay is the right _design_ choice, but the code (and possible performance) overhead might not be worth it from an engineering standpoint."}}