{"action":"opened","issue":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2009","repository_url":"https://api.github.com/repos/DynamoRIO/dynamorio","labels_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2009/labels{/name}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2009/comments","events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2009/events","html_url":"https://github.com/DynamoRIO/dynamorio/issues/2009","id":179489840,"number":2009,"title":"Symbol iterators (dr_symbol_import_iterator_*) broken on ARM and AArch64","user":{"login":"egrimley","id":12933337,"avatar_url":"https://avatars.githubusercontent.com/u/12933337?v=3","gravatar_id":"","url":"https://api.github.com/users/egrimley","html_url":"https://github.com/egrimley","followers_url":"https://api.github.com/users/egrimley/followers","following_url":"https://api.github.com/users/egrimley/following{/other_user}","gists_url":"https://api.github.com/users/egrimley/gists{/gist_id}","starred_url":"https://api.github.com/users/egrimley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egrimley/subscriptions","organizations_url":"https://api.github.com/users/egrimley/orgs","repos_url":"https://api.github.com/users/egrimley/repos","events_url":"https://api.github.com/users/egrimley/events{/privacy}","received_events_url":"https://api.github.com/users/egrimley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-27T13:16:04Z","updated_at":"2016-09-27T13:16:04Z","closed_at":null,"body":"The symbol iterators (dr_symbol_import_iterator_*) do not work correctly on ARM or AArch64 because this statement, found in a comment in dr_symbol_import_iterator_start, turns out not to be true for ARM and AArch64 binaries built with -rdynamic, at least with the tool chain versions I've tested: \"gnu_symbias is the index of the first symbol in the hash table, so all of the imports are before it.\"\r\n\r\nIt would be better not to make unnecessary assumptions about how the symbols are sorted or divided: make both iterators (import and export) iterate through all the symbols and then filter on st_value. That should make the code both simpler and more reliable. Unfortunately, an attempt to implement this (b92660f476eeed0bb7591cdde8c06bf9163757c5) broke the Android build (https://github.com/DynamoRIO/dynamorio/issues/2008) and was reverted. Probably that patch should be revived one day."}}
{"actor":{"display_login":"egrimley"}}