{"action":"created","comment":{"url":"https://api.github.com/repos/penzance/askup/pulls/comments/57508152","id":57508152,"diff_hunk":"@@ -14,6 +14,12 @@\n             <input type=\"text\" class=\"form-control\" name=\"name\" />\n           </div>\n           <div class=\"form-group\">\n+            <label for=\"text\">Qset Type: </label>\n+            Questions<input type=\"radio\" name=\"qset_type\" value=\"questions\" checked>","path":"app/views/qsets/_modal_new_qset.html.erb","position":5,"original_position":5,"commit_id":"e2e1a3791a89832aae4c227224bcd812c20d60fd","original_commit_id":"e2e1a3791a89832aae4c227224bcd812c20d60fd","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"I noticed this is a bit squished at 100% in my Mac Chrome. Any way we can space these out a bit (maybe using CSS? some bootstrap styling for radio buttons on forms?)\r\n\r\nAlso, typically browsers want the label to match a specific input. That way, if you click on a label, it selects the input (in this case, the radio button). Otherwise, you have to click on the radio button itself, which is less user-friendly.\r\n\r\nSee https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label#Using_the_for_attribute and http://www.w3schools.com/tags/tag_label.asp.","created_at":"2016-03-26T03:13:02Z","updated_at":"2016-03-26T03:13:02Z","html_url":"https://github.com/penzance/askup/pull/78#discussion_r57508152","pull_request_url":"https://api.github.com/repos/penzance/askup/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/penzance/askup/pulls/comments/57508152"},"html":{"href":"https://github.com/penzance/askup/pull/78#discussion_r57508152"},"pull_request":{"href":"https://api.github.com/repos/penzance/askup/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/penzance/askup/pulls/78","id":63620267,"html_url":"https://github.com/penzance/askup/pull/78","diff_url":"https://github.com/penzance/askup/pull/78.diff","patch_url":"https://github.com/penzance/askup/pull/78.patch","issue_url":"https://api.github.com/repos/penzance/askup/issues/78","number":78,"state":"open","locked":false,"title":"Default questions","user":{"login":"rckim77","id":2919157,"avatar_url":"https://avatars.githubusercontent.com/u/2919157?v=3","gravatar_id":"","url":"https://api.github.com/users/rckim77","html_url":"https://github.com/rckim77","followers_url":"https://api.github.com/users/rckim77/followers","following_url":"https://api.github.com/users/rckim77/following{/other_user}","gists_url":"https://api.github.com/users/rckim77/gists{/gist_id}","starred_url":"https://api.github.com/users/rckim77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckim77/subscriptions","organizations_url":"https://api.github.com/users/rckim77/orgs","repos_url":"https://api.github.com/users/rckim77/repos","events_url":"https://api.github.com/users/rckim77/events{/privacy}","received_events_url":"https://api.github.com/users/rckim77/received_events","type":"User","site_admin":false},"body":"-user can now choose qset type on new qset modal\r\n-updated comments\r\n-changed redirect_to_qset_path(@qset) to (@qset.id) to mirror def update, though this may not be necessary/correct\r\n-no longer inherit qset_type from parent (now qset_types default to questions)\r\n","created_at":"2016-03-21T19:39:14Z","updated_at":"2016-03-26T03:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23e40fa211c19b379ac26f8da2df2d1ea1579c18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/penzance/askup/pulls/78/commits","review_comments_url":"https://api.github.com/repos/penzance/askup/pulls/78/comments","review_comment_url":"https://api.github.com/repos/penzance/askup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/penzance/askup/issues/78/comments","statuses_url":"https://api.github.com/repos/penzance/askup/statuses/e2e1a3791a89832aae4c227224bcd812c20d60fd","head":{"label":"rckim77:default_questions","ref":"default_questions","sha":"e2e1a3791a89832aae4c227224bcd812c20d60fd","user":{"login":"rckim77","id":2919157,"avatar_url":"https://avatars.githubusercontent.com/u/2919157?v=3","gravatar_id":"","url":"https://api.github.com/users/rckim77","html_url":"https://github.com/rckim77","followers_url":"https://api.github.com/users/rckim77/followers","following_url":"https://api.github.com/users/rckim77/following{/other_user}","gists_url":"https://api.github.com/users/rckim77/gists{/gist_id}","starred_url":"https://api.github.com/users/rckim77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckim77/subscriptions","organizations_url":"https://api.github.com/users/rckim77/orgs","repos_url":"https://api.github.com/users/rckim77/repos","events_url":"https://api.github.com/users/rckim77/events{/privacy}","received_events_url":"https://api.github.com/users/rckim77/received_events","type":"User","site_admin":false},"repo":{"id":43318085,"name":"askup","full_name":"rckim77/askup","owner":{"login":"rckim77","id":2919157,"avatar_url":"https://avatars.githubusercontent.com/u/2919157?v=3","gravatar_id":"","url":"https://api.github.com/users/rckim77","html_url":"https://github.com/rckim77","followers_url":"https://api.github.com/users/rckim77/followers","following_url":"https://api.github.com/users/rckim77/following{/other_user}","gists_url":"https://api.github.com/users/rckim77/gists{/gist_id}","starred_url":"https://api.github.com/users/rckim77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckim77/subscriptions","organizations_url":"https://api.github.com/users/rckim77/orgs","repos_url":"https://api.github.com/users/rckim77/repos","events_url":"https://api.github.com/users/rckim77/events{/privacy}","received_events_url":"https://api.github.com/users/rckim77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rckim77/askup","description":"","fork":true,"url":"https://api.github.com/repos/rckim77/askup","forks_url":"https://api.github.com/repos/rckim77/askup/forks","keys_url":"https://api.github.com/repos/rckim77/askup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rckim77/askup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rckim77/askup/teams","hooks_url":"https://api.github.com/repos/rckim77/askup/hooks","issue_events_url":"https://api.github.com/repos/rckim77/askup/issues/events{/number}","events_url":"https://api.github.com/repos/rckim77/askup/events","assignees_url":"https://api.github.com/repos/rckim77/askup/assignees{/user}","branches_url":"https://api.github.com/repos/rckim77/askup/branches{/branch}","tags_url":"https://api.github.com/repos/rckim77/askup/tags","blobs_url":"https://api.github.com/repos/rckim77/askup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rckim77/askup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rckim77/askup/git/refs{/sha}","trees_url":"https://api.github.com/repos/rckim77/askup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rckim77/askup/statuses/{sha}","languages_url":"https://api.github.com/repos/rckim77/askup/languages","stargazers_url":"https://api.github.com/repos/rckim77/askup/stargazers","contributors_url":"https://api.github.com/repos/rckim77/askup/contributors","subscribers_url":"https://api.github.com/repos/rckim77/askup/subscribers","subscription_url":"https://api.github.com/repos/rckim77/askup/subscription","commits_url":"https://api.github.com/repos/rckim77/askup/commits{/sha}","git_commits_url":"https://api.github.com/repos/rckim77/askup/git/commits{/sha}","comments_url":"https://api.github.com/repos/rckim77/askup/comments{/number}","issue_comment_url":"https://api.github.com/repos/rckim77/askup/issues/comments{/number}","contents_url":"https://api.github.com/repos/rckim77/askup/contents/{+path}","compare_url":"https://api.github.com/repos/rckim77/askup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rckim77/askup/merges","archive_url":"https://api.github.com/repos/rckim77/askup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rckim77/askup/downloads","issues_url":"https://api.github.com/repos/rckim77/askup/issues{/number}","pulls_url":"https://api.github.com/repos/rckim77/askup/pulls{/number}","milestones_url":"https://api.github.com/repos/rckim77/askup/milestones{/number}","notifications_url":"https://api.github.com/repos/rckim77/askup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rckim77/askup/labels{/name}","releases_url":"https://api.github.com/repos/rckim77/askup/releases{/id}","deployments_url":"https://api.github.com/repos/rckim77/askup/deployments","created_at":"2015-09-28T18:11:21Z","updated_at":"2016-02-08T22:42:24Z","pushed_at":"2016-03-21T19:48:22Z","git_url":"git://github.com/rckim77/askup.git","ssh_url":"git@github.com:rckim77/askup.git","clone_url":"https://github.com/rckim77/askup.git","svn_url":"https://github.com/rckim77/askup","homepage":null,"size":3485,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"penzance:master","ref":"master","sha":"a2bd3f6479e8f1f1edbd20d7f170d12afef5477f","user":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"repo":{"id":29279361,"name":"askup","full_name":"penzance/askup","owner":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/penzance/askup","description":"","fork":false,"url":"https://api.github.com/repos/penzance/askup","forks_url":"https://api.github.com/repos/penzance/askup/forks","keys_url":"https://api.github.com/repos/penzance/askup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penzance/askup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penzance/askup/teams","hooks_url":"https://api.github.com/repos/penzance/askup/hooks","issue_events_url":"https://api.github.com/repos/penzance/askup/issues/events{/number}","events_url":"https://api.github.com/repos/penzance/askup/events","assignees_url":"https://api.github.com/repos/penzance/askup/assignees{/user}","branches_url":"https://api.github.com/repos/penzance/askup/branches{/branch}","tags_url":"https://api.github.com/repos/penzance/askup/tags","blobs_url":"https://api.github.com/repos/penzance/askup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penzance/askup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penzance/askup/git/refs{/sha}","trees_url":"https://api.github.com/repos/penzance/askup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penzance/askup/statuses/{sha}","languages_url":"https://api.github.com/repos/penzance/askup/languages","stargazers_url":"https://api.github.com/repos/penzance/askup/stargazers","contributors_url":"https://api.github.com/repos/penzance/askup/contributors","subscribers_url":"https://api.github.com/repos/penzance/askup/subscribers","subscription_url":"https://api.github.com/repos/penzance/askup/subscription","commits_url":"https://api.github.com/repos/penzance/askup/commits{/sha}","git_commits_url":"https://api.github.com/repos/penzance/askup/git/commits{/sha}","comments_url":"https://api.github.com/repos/penzance/askup/comments{/number}","issue_comment_url":"https://api.github.com/repos/penzance/askup/issues/comments{/number}","contents_url":"https://api.github.com/repos/penzance/askup/contents/{+path}","compare_url":"https://api.github.com/repos/penzance/askup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penzance/askup/merges","archive_url":"https://api.github.com/repos/penzance/askup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penzance/askup/downloads","issues_url":"https://api.github.com/repos/penzance/askup/issues{/number}","pulls_url":"https://api.github.com/repos/penzance/askup/pulls{/number}","milestones_url":"https://api.github.com/repos/penzance/askup/milestones{/number}","notifications_url":"https://api.github.com/repos/penzance/askup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penzance/askup/labels{/name}","releases_url":"https://api.github.com/repos/penzance/askup/releases{/id}","deployments_url":"https://api.github.com/repos/penzance/askup/deployments","created_at":"2015-01-15T03:42:43Z","updated_at":"2016-01-26T16:51:30Z","pushed_at":"2016-03-25T20:03:16Z","git_url":"git://github.com/penzance/askup.git","ssh_url":"git@github.com:penzance/askup.git","clone_url":"https://github.com/penzance/askup.git","svn_url":"https://github.com/penzance/askup","homepage":null,"size":3513,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/penzance/askup/pulls/78"},"html":{"href":"https://github.com/penzance/askup/pull/78"},"issue":{"href":"https://api.github.com/repos/penzance/askup/issues/78"},"comments":{"href":"https://api.github.com/repos/penzance/askup/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/penzance/askup/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/penzance/askup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/penzance/askup/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/penzance/askup/statuses/e2e1a3791a89832aae4c227224bcd812c20d60fd"}}}}