{"action":"created","comment":{"url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/comments/59325708","id":59325708,"diff_hunk":"@@ -61,14 +63,21 @@ class UserController extends AbstractActionController\n     protected $redirectCallback;\n \n     /**\n-     * @param callable $redirectCallback\n+     * @var ServiceLocator\n      */\n-    public function __construct($redirectCallback)\n+    protected $serviceLocator;\n+\n+    /**\n+     * @param callable                      $redirectCallback\n+     * @param ServiceManager $serviceManager\n+     */\n+    public function __construct($redirectCallback, ServiceManager $serviceManager)","path":"src/ZfcUser/Controller/UserController.php","position":25,"original_position":25,"commit_id":"26fb8522caf6de6ffbac233e800a5c8e48e9a1a1","original_commit_id":"26fb8522caf6de6ffbac233e800a5c8e48e9a1a1","user":{"login":"svycka","id":1270782,"avatar_url":"https://avatars.githubusercontent.com/u/1270782?v=3","gravatar_id":"","url":"https://api.github.com/users/svycka","html_url":"https://github.com/svycka","followers_url":"https://api.github.com/users/svycka/followers","following_url":"https://api.github.com/users/svycka/following{/other_user}","gists_url":"https://api.github.com/users/svycka/gists{/gist_id}","starred_url":"https://api.github.com/users/svycka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svycka/subscriptions","organizations_url":"https://api.github.com/users/svycka/orgs","repos_url":"https://api.github.com/users/svycka/repos","events_url":"https://api.github.com/users/svycka/events{/privacy}","received_events_url":"https://api.github.com/users/svycka/received_events","type":"User","site_admin":false},"body":"This is BC break for sure even for me as I extended this controller and have a `parent::__construct($redirectCallback)` call in my new constructor.  You should make $serviceManager optional or remove as all others constructors","created_at":"2016-04-12T06:21:48Z","updated_at":"2016-04-12T06:21:48Z","html_url":"https://github.com/ZF-Commons/ZfcUser/pull/634#discussion_r59325708","pull_request_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/comments/59325708"},"html":{"href":"https://github.com/ZF-Commons/ZfcUser/pull/634#discussion_r59325708"},"pull_request":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634"}}},"pull_request":{"url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634","id":64971764,"html_url":"https://github.com/ZF-Commons/ZfcUser/pull/634","diff_url":"https://github.com/ZF-Commons/ZfcUser/pull/634.diff","patch_url":"https://github.com/ZF-Commons/ZfcUser/pull/634.patch","issue_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/634","number":634,"state":"open","locked":false,"title":"Fix Service Manager DI. Change tests","user":{"login":"marinovdf","id":2156373,"avatar_url":"https://avatars.githubusercontent.com/u/2156373?v=3","gravatar_id":"","url":"https://api.github.com/users/marinovdf","html_url":"https://github.com/marinovdf","followers_url":"https://api.github.com/users/marinovdf/followers","following_url":"https://api.github.com/users/marinovdf/following{/other_user}","gists_url":"https://api.github.com/users/marinovdf/gists{/gist_id}","starred_url":"https://api.github.com/users/marinovdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marinovdf/subscriptions","organizations_url":"https://api.github.com/users/marinovdf/orgs","repos_url":"https://api.github.com/users/marinovdf/repos","events_url":"https://api.github.com/users/marinovdf/events{/privacy}","received_events_url":"https://api.github.com/users/marinovdf/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-01T16:38:52Z","updated_at":"2016-04-12T06:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33648144f940b68677994081858392483e993687","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634/commits","review_comments_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634/comments","review_comment_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/634/comments","statuses_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/statuses/26fb8522caf6de6ffbac233e800a5c8e48e9a1a1","head":{"label":"marinovdf:sm_fix","ref":"sm_fix","sha":"26fb8522caf6de6ffbac233e800a5c8e48e9a1a1","user":{"login":"marinovdf","id":2156373,"avatar_url":"https://avatars.githubusercontent.com/u/2156373?v=3","gravatar_id":"","url":"https://api.github.com/users/marinovdf","html_url":"https://github.com/marinovdf","followers_url":"https://api.github.com/users/marinovdf/followers","following_url":"https://api.github.com/users/marinovdf/following{/other_user}","gists_url":"https://api.github.com/users/marinovdf/gists{/gist_id}","starred_url":"https://api.github.com/users/marinovdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marinovdf/subscriptions","organizations_url":"https://api.github.com/users/marinovdf/orgs","repos_url":"https://api.github.com/users/marinovdf/repos","events_url":"https://api.github.com/users/marinovdf/events{/privacy}","received_events_url":"https://api.github.com/users/marinovdf/received_events","type":"User","site_admin":false},"repo":{"id":55209301,"name":"ZfcUser","full_name":"marinovdf/ZfcUser","owner":{"login":"marinovdf","id":2156373,"avatar_url":"https://avatars.githubusercontent.com/u/2156373?v=3","gravatar_id":"","url":"https://api.github.com/users/marinovdf","html_url":"https://github.com/marinovdf","followers_url":"https://api.github.com/users/marinovdf/followers","following_url":"https://api.github.com/users/marinovdf/following{/other_user}","gists_url":"https://api.github.com/users/marinovdf/gists{/gist_id}","starred_url":"https://api.github.com/users/marinovdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marinovdf/subscriptions","organizations_url":"https://api.github.com/users/marinovdf/orgs","repos_url":"https://api.github.com/users/marinovdf/repos","events_url":"https://api.github.com/users/marinovdf/events{/privacy}","received_events_url":"https://api.github.com/users/marinovdf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marinovdf/ZfcUser","description":"A generic user registration and authentication module for ZF2. Supports Zend\\Db and Doctrine2. (Formerly EdpUser)","fork":true,"url":"https://api.github.com/repos/marinovdf/ZfcUser","forks_url":"https://api.github.com/repos/marinovdf/ZfcUser/forks","keys_url":"https://api.github.com/repos/marinovdf/ZfcUser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marinovdf/ZfcUser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marinovdf/ZfcUser/teams","hooks_url":"https://api.github.com/repos/marinovdf/ZfcUser/hooks","issue_events_url":"https://api.github.com/repos/marinovdf/ZfcUser/issues/events{/number}","events_url":"https://api.github.com/repos/marinovdf/ZfcUser/events","assignees_url":"https://api.github.com/repos/marinovdf/ZfcUser/assignees{/user}","branches_url":"https://api.github.com/repos/marinovdf/ZfcUser/branches{/branch}","tags_url":"https://api.github.com/repos/marinovdf/ZfcUser/tags","blobs_url":"https://api.github.com/repos/marinovdf/ZfcUser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marinovdf/ZfcUser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marinovdf/ZfcUser/git/refs{/sha}","trees_url":"https://api.github.com/repos/marinovdf/ZfcUser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marinovdf/ZfcUser/statuses/{sha}","languages_url":"https://api.github.com/repos/marinovdf/ZfcUser/languages","stargazers_url":"https://api.github.com/repos/marinovdf/ZfcUser/stargazers","contributors_url":"https://api.github.com/repos/marinovdf/ZfcUser/contributors","subscribers_url":"https://api.github.com/repos/marinovdf/ZfcUser/subscribers","subscription_url":"https://api.github.com/repos/marinovdf/ZfcUser/subscription","commits_url":"https://api.github.com/repos/marinovdf/ZfcUser/commits{/sha}","git_commits_url":"https://api.github.com/repos/marinovdf/ZfcUser/git/commits{/sha}","comments_url":"https://api.github.com/repos/marinovdf/ZfcUser/comments{/number}","issue_comment_url":"https://api.github.com/repos/marinovdf/ZfcUser/issues/comments{/number}","contents_url":"https://api.github.com/repos/marinovdf/ZfcUser/contents/{+path}","compare_url":"https://api.github.com/repos/marinovdf/ZfcUser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marinovdf/ZfcUser/merges","archive_url":"https://api.github.com/repos/marinovdf/ZfcUser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marinovdf/ZfcUser/downloads","issues_url":"https://api.github.com/repos/marinovdf/ZfcUser/issues{/number}","pulls_url":"https://api.github.com/repos/marinovdf/ZfcUser/pulls{/number}","milestones_url":"https://api.github.com/repos/marinovdf/ZfcUser/milestones{/number}","notifications_url":"https://api.github.com/repos/marinovdf/ZfcUser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marinovdf/ZfcUser/labels{/name}","releases_url":"https://api.github.com/repos/marinovdf/ZfcUser/releases{/id}","deployments_url":"https://api.github.com/repos/marinovdf/ZfcUser/deployments","created_at":"2016-04-01T06:34:58Z","updated_at":"2016-04-01T06:34:59Z","pushed_at":"2016-04-01T16:36:59Z","git_url":"git://github.com/marinovdf/ZfcUser.git","ssh_url":"git@github.com:marinovdf/ZfcUser.git","clone_url":"https://github.com/marinovdf/ZfcUser.git","svn_url":"https://github.com/marinovdf/ZfcUser","homepage":"","size":1054,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"ZF-Commons:1.x","ref":"1.x","sha":"fd103f7ee75e1d1c853474510f43bb5e64c757dc","user":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"repo":{"id":3131021,"name":"ZfcUser","full_name":"ZF-Commons/ZfcUser","owner":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZF-Commons/ZfcUser","description":"A generic user registration and authentication module for ZF2. Supports Zend\\Db and Doctrine2. (Formerly EdpUser)","fork":false,"url":"https://api.github.com/repos/ZF-Commons/ZfcUser","forks_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/forks","keys_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/teams","hooks_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/hooks","issue_events_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/events{/number}","events_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/events","assignees_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/assignees{/user}","branches_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/branches{/branch}","tags_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/tags","blobs_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/statuses/{sha}","languages_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/languages","stargazers_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/stargazers","contributors_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/contributors","subscribers_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/subscribers","subscription_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/subscription","commits_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/contents/{+path}","compare_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/merges","archive_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/downloads","issues_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues{/number}","pulls_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls{/number}","milestones_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/milestones{/number}","notifications_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/labels{/name}","releases_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/releases{/id}","deployments_url":"https://api.github.com/repos/ZF-Commons/ZfcUser/deployments","created_at":"2012-01-08T17:40:09Z","updated_at":"2016-04-11T16:02:38Z","pushed_at":"2016-04-01T16:38:52Z","git_url":"git://github.com/ZF-Commons/ZfcUser.git","ssh_url":"git@github.com:ZF-Commons/ZfcUser.git","clone_url":"https://github.com/ZF-Commons/ZfcUser.git","svn_url":"https://github.com/ZF-Commons/ZfcUser","homepage":"","size":1998,"stargazers_count":528,"watchers_count":528,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":399,"mirror_url":null,"open_issues_count":44,"forks":399,"open_issues":44,"watchers":528,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634"},"html":{"href":"https://github.com/ZF-Commons/ZfcUser/pull/634"},"issue":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/634"},"comments":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/ZF-Commons/ZfcUser/statuses/26fb8522caf6de6ffbac233e800a5c8e48e9a1a1"}}}}