{"action":"created","comment":{"url":"https://api.github.com/repos/willfitch/twemproxy/pulls/comments/66459388","id":66459388,"diff_hunk":"@@ -329,7 +329,7 @@ msg_get_error(bool redis, err_t err)\n     struct mbuf *mbuf;\n     int n;\n     char *errstr = err ? strerror(err) : \"unknown\";\n-    char *protstr = redis ? \"-ERR\" : \"SERVER_ERROR\";\n+    char *protstr = redis ? \"-ERR\" : \"ERROR\";","path":"src/nc_message.c","position":5,"original_position":5,"commit_id":"726dab0c0faa18941aa123b40b4d0c7acd628bfb","original_commit_id":"295085e1d0fc05ce28f2636ae811c88e4c1b69f0","user":{"login":"jonahharris","id":194874,"avatar_url":"https://avatars.githubusercontent.com/u/194874?v=3","gravatar_id":"","url":"https://api.github.com/users/jonahharris","html_url":"https://github.com/jonahharris","followers_url":"https://api.github.com/users/jonahharris/followers","following_url":"https://api.github.com/users/jonahharris/following{/other_user}","gists_url":"https://api.github.com/users/jonahharris/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahharris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahharris/subscriptions","organizations_url":"https://api.github.com/users/jonahharris/orgs","repos_url":"https://api.github.com/users/jonahharris/repos","events_url":"https://api.github.com/users/jonahharris/events{/privacy}","received_events_url":"https://api.github.com/users/jonahharris/received_events","type":"User","site_admin":false},"body":"Changing this string doesn't account for the source or type of the error, does it? In the memcached protocol, there are three types of errors, ERROR, CLIENT_ERROR, and SERVER_ERROR. This makes the assumption that all errors are server errors and doesn't actually handle the case, per the memcached protocol, that severe errors result in connection termination (which is what twemproxy does by default)","created_at":"2016-06-09T15:08:40Z","updated_at":"2016-06-09T15:08:40Z","html_url":"https://github.com/willfitch/twemproxy/pull/1#discussion_r66459388","pull_request_url":"https://api.github.com/repos/willfitch/twemproxy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/comments/66459388"},"html":{"href":"https://github.com/willfitch/twemproxy/pull/1#discussion_r66459388"},"pull_request":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/willfitch/twemproxy/pulls/1","id":73218835,"html_url":"https://github.com/willfitch/twemproxy/pull/1","diff_url":"https://github.com/willfitch/twemproxy/pull/1.diff","patch_url":"https://github.com/willfitch/twemproxy/pull/1.patch","issue_url":"https://api.github.com/repos/willfitch/twemproxy/issues/1","number":1,"state":"open","locked":false,"title":"Resolve invalid Memcached error protocol implementation","user":{"login":"willfitch","id":759414,"avatar_url":"https://avatars.githubusercontent.com/u/759414?v=3","gravatar_id":"","url":"https://api.github.com/users/willfitch","html_url":"https://github.com/willfitch","followers_url":"https://api.github.com/users/willfitch/followers","following_url":"https://api.github.com/users/willfitch/following{/other_user}","gists_url":"https://api.github.com/users/willfitch/gists{/gist_id}","starred_url":"https://api.github.com/users/willfitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willfitch/subscriptions","organizations_url":"https://api.github.com/users/willfitch/orgs","repos_url":"https://api.github.com/users/willfitch/repos","events_url":"https://api.github.com/users/willfitch/events{/privacy}","received_events_url":"https://api.github.com/users/willfitch/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-09T13:59:59Z","updated_at":"2016-06-09T15:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b3be1c1100db7f9e20df2fc43b6fb970c1b4b5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/willfitch/twemproxy/pulls/1/commits","review_comments_url":"https://api.github.com/repos/willfitch/twemproxy/pulls/1/comments","review_comment_url":"https://api.github.com/repos/willfitch/twemproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willfitch/twemproxy/issues/1/comments","statuses_url":"https://api.github.com/repos/willfitch/twemproxy/statuses/726dab0c0faa18941aa123b40b4d0c7acd628bfb","head":{"label":"willfitch:error_res","ref":"error_res","sha":"726dab0c0faa18941aa123b40b4d0c7acd628bfb","user":{"login":"willfitch","id":759414,"avatar_url":"https://avatars.githubusercontent.com/u/759414?v=3","gravatar_id":"","url":"https://api.github.com/users/willfitch","html_url":"https://github.com/willfitch","followers_url":"https://api.github.com/users/willfitch/followers","following_url":"https://api.github.com/users/willfitch/following{/other_user}","gists_url":"https://api.github.com/users/willfitch/gists{/gist_id}","starred_url":"https://api.github.com/users/willfitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willfitch/subscriptions","organizations_url":"https://api.github.com/users/willfitch/orgs","repos_url":"https://api.github.com/users/willfitch/repos","events_url":"https://api.github.com/users/willfitch/events{/privacy}","received_events_url":"https://api.github.com/users/willfitch/received_events","type":"User","site_admin":false},"repo":{"id":59767289,"name":"twemproxy","full_name":"willfitch/twemproxy","owner":{"login":"willfitch","id":759414,"avatar_url":"https://avatars.githubusercontent.com/u/759414?v=3","gravatar_id":"","url":"https://api.github.com/users/willfitch","html_url":"https://github.com/willfitch","followers_url":"https://api.github.com/users/willfitch/followers","following_url":"https://api.github.com/users/willfitch/following{/other_user}","gists_url":"https://api.github.com/users/willfitch/gists{/gist_id}","starred_url":"https://api.github.com/users/willfitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willfitch/subscriptions","organizations_url":"https://api.github.com/users/willfitch/orgs","repos_url":"https://api.github.com/users/willfitch/repos","events_url":"https://api.github.com/users/willfitch/events{/privacy}","received_events_url":"https://api.github.com/users/willfitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willfitch/twemproxy","description":"A fast, light-weight proxy for memcached and redis","fork":true,"url":"https://api.github.com/repos/willfitch/twemproxy","forks_url":"https://api.github.com/repos/willfitch/twemproxy/forks","keys_url":"https://api.github.com/repos/willfitch/twemproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willfitch/twemproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willfitch/twemproxy/teams","hooks_url":"https://api.github.com/repos/willfitch/twemproxy/hooks","issue_events_url":"https://api.github.com/repos/willfitch/twemproxy/issues/events{/number}","events_url":"https://api.github.com/repos/willfitch/twemproxy/events","assignees_url":"https://api.github.com/repos/willfitch/twemproxy/assignees{/user}","branches_url":"https://api.github.com/repos/willfitch/twemproxy/branches{/branch}","tags_url":"https://api.github.com/repos/willfitch/twemproxy/tags","blobs_url":"https://api.github.com/repos/willfitch/twemproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willfitch/twemproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willfitch/twemproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/willfitch/twemproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willfitch/twemproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/willfitch/twemproxy/languages","stargazers_url":"https://api.github.com/repos/willfitch/twemproxy/stargazers","contributors_url":"https://api.github.com/repos/willfitch/twemproxy/contributors","subscribers_url":"https://api.github.com/repos/willfitch/twemproxy/subscribers","subscription_url":"https://api.github.com/repos/willfitch/twemproxy/subscription","commits_url":"https://api.github.com/repos/willfitch/twemproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/willfitch/twemproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/willfitch/twemproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/willfitch/twemproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/willfitch/twemproxy/contents/{+path}","compare_url":"https://api.github.com/repos/willfitch/twemproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willfitch/twemproxy/merges","archive_url":"https://api.github.com/repos/willfitch/twemproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willfitch/twemproxy/downloads","issues_url":"https://api.github.com/repos/willfitch/twemproxy/issues{/number}","pulls_url":"https://api.github.com/repos/willfitch/twemproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/willfitch/twemproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/willfitch/twemproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willfitch/twemproxy/labels{/name}","releases_url":"https://api.github.com/repos/willfitch/twemproxy/releases{/id}","deployments_url":"https://api.github.com/repos/willfitch/twemproxy/deployments","created_at":"2016-05-26T16:45:53Z","updated_at":"2016-05-26T16:45:55Z","pushed_at":"2016-06-09T14:02:46Z","git_url":"git://github.com/willfitch/twemproxy.git","ssh_url":"git@github.com:willfitch/twemproxy.git","clone_url":"https://github.com/willfitch/twemproxy.git","svn_url":"https://github.com/willfitch/twemproxy","homepage":"","size":2138,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"willfitch:master","ref":"master","sha":"74af2fb2d5d3e214d8c0741a4b0ebb7d93572fc8","user":{"login":"willfitch","id":759414,"avatar_url":"https://avatars.githubusercontent.com/u/759414?v=3","gravatar_id":"","url":"https://api.github.com/users/willfitch","html_url":"https://github.com/willfitch","followers_url":"https://api.github.com/users/willfitch/followers","following_url":"https://api.github.com/users/willfitch/following{/other_user}","gists_url":"https://api.github.com/users/willfitch/gists{/gist_id}","starred_url":"https://api.github.com/users/willfitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willfitch/subscriptions","organizations_url":"https://api.github.com/users/willfitch/orgs","repos_url":"https://api.github.com/users/willfitch/repos","events_url":"https://api.github.com/users/willfitch/events{/privacy}","received_events_url":"https://api.github.com/users/willfitch/received_events","type":"User","site_admin":false},"repo":{"id":59767289,"name":"twemproxy","full_name":"willfitch/twemproxy","owner":{"login":"willfitch","id":759414,"avatar_url":"https://avatars.githubusercontent.com/u/759414?v=3","gravatar_id":"","url":"https://api.github.com/users/willfitch","html_url":"https://github.com/willfitch","followers_url":"https://api.github.com/users/willfitch/followers","following_url":"https://api.github.com/users/willfitch/following{/other_user}","gists_url":"https://api.github.com/users/willfitch/gists{/gist_id}","starred_url":"https://api.github.com/users/willfitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willfitch/subscriptions","organizations_url":"https://api.github.com/users/willfitch/orgs","repos_url":"https://api.github.com/users/willfitch/repos","events_url":"https://api.github.com/users/willfitch/events{/privacy}","received_events_url":"https://api.github.com/users/willfitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willfitch/twemproxy","description":"A fast, light-weight proxy for memcached and redis","fork":true,"url":"https://api.github.com/repos/willfitch/twemproxy","forks_url":"https://api.github.com/repos/willfitch/twemproxy/forks","keys_url":"https://api.github.com/repos/willfitch/twemproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willfitch/twemproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willfitch/twemproxy/teams","hooks_url":"https://api.github.com/repos/willfitch/twemproxy/hooks","issue_events_url":"https://api.github.com/repos/willfitch/twemproxy/issues/events{/number}","events_url":"https://api.github.com/repos/willfitch/twemproxy/events","assignees_url":"https://api.github.com/repos/willfitch/twemproxy/assignees{/user}","branches_url":"https://api.github.com/repos/willfitch/twemproxy/branches{/branch}","tags_url":"https://api.github.com/repos/willfitch/twemproxy/tags","blobs_url":"https://api.github.com/repos/willfitch/twemproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willfitch/twemproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willfitch/twemproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/willfitch/twemproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willfitch/twemproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/willfitch/twemproxy/languages","stargazers_url":"https://api.github.com/repos/willfitch/twemproxy/stargazers","contributors_url":"https://api.github.com/repos/willfitch/twemproxy/contributors","subscribers_url":"https://api.github.com/repos/willfitch/twemproxy/subscribers","subscription_url":"https://api.github.com/repos/willfitch/twemproxy/subscription","commits_url":"https://api.github.com/repos/willfitch/twemproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/willfitch/twemproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/willfitch/twemproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/willfitch/twemproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/willfitch/twemproxy/contents/{+path}","compare_url":"https://api.github.com/repos/willfitch/twemproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willfitch/twemproxy/merges","archive_url":"https://api.github.com/repos/willfitch/twemproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willfitch/twemproxy/downloads","issues_url":"https://api.github.com/repos/willfitch/twemproxy/issues{/number}","pulls_url":"https://api.github.com/repos/willfitch/twemproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/willfitch/twemproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/willfitch/twemproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willfitch/twemproxy/labels{/name}","releases_url":"https://api.github.com/repos/willfitch/twemproxy/releases{/id}","deployments_url":"https://api.github.com/repos/willfitch/twemproxy/deployments","created_at":"2016-05-26T16:45:53Z","updated_at":"2016-05-26T16:45:55Z","pushed_at":"2016-06-09T14:02:46Z","git_url":"git://github.com/willfitch/twemproxy.git","ssh_url":"git@github.com:willfitch/twemproxy.git","clone_url":"https://github.com/willfitch/twemproxy.git","svn_url":"https://github.com/willfitch/twemproxy","homepage":"","size":2138,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/1"},"html":{"href":"https://github.com/willfitch/twemproxy/pull/1"},"issue":{"href":"https://api.github.com/repos/willfitch/twemproxy/issues/1"},"comments":{"href":"https://api.github.com/repos/willfitch/twemproxy/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willfitch/twemproxy/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/willfitch/twemproxy/statuses/726dab0c0faa18941aa123b40b4d0c7acd628bfb"}}}}
{"actor":{"display_login":"jonahharris"}}