{"action":"closed","number":324,"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324","id":82869769,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/324","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/324.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/324.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/324","number":324,"state":"closed","locked":false,"title":"[Windows] Fix Device Style inheritance","user":{"login":"pingzing","id":5133649,"avatar_url":"https://avatars.githubusercontent.com/u/5133649?v=3","gravatar_id":"","url":"https://api.github.com/users/pingzing","html_url":"https://github.com/pingzing","followers_url":"https://api.github.com/users/pingzing/followers","following_url":"https://api.github.com/users/pingzing/following{/other_user}","gists_url":"https://api.github.com/users/pingzing/gists{/gist_id}","starred_url":"https://api.github.com/users/pingzing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingzing/subscriptions","organizations_url":"https://api.github.com/users/pingzing/orgs","repos_url":"https://api.github.com/users/pingzing/repos","events_url":"https://api.github.com/users/pingzing/events{/privacy}","received_events_url":"https://api.github.com/users/pingzing/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nChanges the Windows Phone RT platform resource lookup to get Setters from ancestor Styles in addition to the defined style.\r\n\r\nTests omitted because, as far as I can tell, testing the PlatformResourceProviders isn't possible.\r\n\r\n### Bugs Fixed ###\r\n\r\n- Part 1 of fixing [47873 - Most Device Styles do not render correctly in Windows Phone 8.1 (RT) applications](https://bugzilla.xamarin.com/show_bug.cgi?id=43783). Doesn't address the failure to lookup ThemeResources, however. Once that's addressed, will fix certain styles, such as the `BodyStyle`, which maps to the native `BodyTextBlockStyle`, which only directly defines a new `TextBlock.LineHeight` value. As Xamarin's style translation ignores that particular property, any Label using the Xamarin `BodyStyle` would get an unstyled Label, when they should, at the very least, receive the styling from the native `BaseTextBlockStyle`.\r\n\r\n### API Changes ###\r\n\r\nNone.\r\n\r\n### Behavioral Changes ###\r\n\r\nThere should be no visible changes _yet_. The only two Device Styles that render correctly on Windows Phone 8.1 RT, TitleStyle and SubtitleStyle do not have any elements inherited from their BasedOn Styles that a Xamarin Style uses. However, if [43783](https://bugzilla.xamarin.com/show_bug.cgi?id=43783) were to be fixed without also fixing this, the styles would be incomplete.\r\n\r\nRecommend do **not** merge until [43783](https://bugzilla.xamarin.com/show_bug.cgi?id=43783) is fixed.\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n","created_at":"2016-08-26T11:00:47Z","updated_at":"2016-09-30T18:47:41Z","closed_at":"2016-09-30T18:47:41Z","merged_at":"2016-09-30T18:47:41Z","merge_commit_sha":"c07c2314f5737d480088319e87ab299b22cb4ddc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/324/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/f32c37ddf52041e70a98ca661bb80f70d04df183","head":{"label":"pingzing:windows-fix-device-style-inheritance","ref":"windows-fix-device-style-inheritance","sha":"f32c37ddf52041e70a98ca661bb80f70d04df183","user":{"login":"pingzing","id":5133649,"avatar_url":"https://avatars.githubusercontent.com/u/5133649?v=3","gravatar_id":"","url":"https://api.github.com/users/pingzing","html_url":"https://github.com/pingzing","followers_url":"https://api.github.com/users/pingzing/followers","following_url":"https://api.github.com/users/pingzing/following{/other_user}","gists_url":"https://api.github.com/users/pingzing/gists{/gist_id}","starred_url":"https://api.github.com/users/pingzing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingzing/subscriptions","organizations_url":"https://api.github.com/users/pingzing/orgs","repos_url":"https://api.github.com/users/pingzing/repos","events_url":"https://api.github.com/users/pingzing/events{/privacy}","received_events_url":"https://api.github.com/users/pingzing/received_events","type":"User","site_admin":false},"repo":{"id":66633103,"name":"Xamarin.Forms","full_name":"pingzing/Xamarin.Forms","owner":{"login":"pingzing","id":5133649,"avatar_url":"https://avatars.githubusercontent.com/u/5133649?v=3","gravatar_id":"","url":"https://api.github.com/users/pingzing","html_url":"https://github.com/pingzing","followers_url":"https://api.github.com/users/pingzing/followers","following_url":"https://api.github.com/users/pingzing/following{/other_user}","gists_url":"https://api.github.com/users/pingzing/gists{/gist_id}","starred_url":"https://api.github.com/users/pingzing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingzing/subscriptions","organizations_url":"https://api.github.com/users/pingzing/orgs","repos_url":"https://api.github.com/users/pingzing/repos","events_url":"https://api.github.com/users/pingzing/events{/privacy}","received_events_url":"https://api.github.com/users/pingzing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pingzing/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/pingzing/Xamarin.Forms","forks_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/pingzing/Xamarin.Forms/deployments","created_at":"2016-08-26T08:59:08Z","updated_at":"2016-08-26T08:59:13Z","pushed_at":"2016-08-26T10:35:12Z","git_url":"git://github.com/pingzing/Xamarin.Forms.git","ssh_url":"git@github.com:pingzing/Xamarin.Forms.git","clone_url":"https://github.com/pingzing/Xamarin.Forms.git","svn_url":"https://github.com/pingzing/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":14160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"5b85aafcd671f5e8745cf52339c20378f91cb748","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-09-30T09:09:41Z","pushed_at":"2016-09-30T18:47:41Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":26848,"stargazers_count":903,"watchers_count":903,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":301,"mirror_url":null,"open_issues_count":39,"forks":301,"open_issues":39,"watchers":903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/324"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/324"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/f32c37ddf52041e70a98ca661bb80f70d04df183"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jassmith","id":30443,"avatar_url":"https://avatars.githubusercontent.com/u/30443?v=3","gravatar_id":"","url":"https://api.github.com/users/jassmith","html_url":"https://github.com/jassmith","followers_url":"https://api.github.com/users/jassmith/followers","following_url":"https://api.github.com/users/jassmith/following{/other_user}","gists_url":"https://api.github.com/users/jassmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jassmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jassmith/subscriptions","organizations_url":"https://api.github.com/users/jassmith/orgs","repos_url":"https://api.github.com/users/jassmith/repos","events_url":"https://api.github.com/users/jassmith/events{/privacy}","received_events_url":"https://api.github.com/users/jassmith/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":45,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jassmith"}}