{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/karyon/issues/310","repository_url":"https://api.github.com/repos/Netflix/karyon","labels_url":"https://api.github.com/repos/Netflix/karyon/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/karyon/issues/310/comments","events_url":"https://api.github.com/repos/Netflix/karyon/issues/310/events","html_url":"https://github.com/Netflix/karyon/issues/310","id":113969869,"number":310,"title":"3.x admin server now requires ui module to be installed","user":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Netflix/karyon/milestones/14","html_url":"https://github.com/Netflix/karyon/milestones/v3.0.1","labels_url":"https://api.github.com/repos/Netflix/karyon/milestones/14/labels","id":1438957,"number":14,"title":"v3.0.1","description":null,"creator":{"login":"elandau","id":913564,"avatar_url":"https://avatars.githubusercontent.com/u/913564?v=3","gravatar_id":"","url":"https://api.github.com/users/elandau","html_url":"https://github.com/elandau","followers_url":"https://api.github.com/users/elandau/followers","following_url":"https://api.github.com/users/elandau/following{/other_user}","gists_url":"https://api.github.com/users/elandau/gists{/gist_id}","starred_url":"https://api.github.com/users/elandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elandau/subscriptions","organizations_url":"https://api.github.com/users/elandau/orgs","repos_url":"https://api.github.com/users/elandau/repos","events_url":"https://api.github.com/users/elandau/events{/privacy}","received_events_url":"https://api.github.com/users/elandau/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2015-12-02T06:02:41Z","updated_at":"2016-06-02T15:19:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-10-29T03:09:38Z","updated_at":"2016-06-02T15:19:11Z","closed_at":"2016-06-02T15:19:10Z","body":"PR #306 breaks the ability to use AdminServerModule without using AdminUIServerModule. Specifically AdminHttpHandler will fail to be created if just using AdminServerModule:\r\n\r\n```\r\ncom.google.inject.CreationException: Unable to create injector, see the following errors:\r\n\r\n1) No implementation for com.netflix.karyon.admin.ui.AdminUIServerConfig was bound.\r\n  while locating com.netflix.karyon.admin.ui.AdminUIServerConfig\r\n    for parameter 3 at com.netflix.karyon.admin.rest.AdminHttpHandler.<init>(AdminHttpHandler.java:59)\r\n  while locating com.netflix.karyon.admin.rest.AdminHttpHandler\r\n    for parameter 1 at com.netflix.iep.karyon3.DefaultHandler.<init>(DefaultHandler.java:34)\r\n  at com.netflix.iep.karyon3.CompatModule.getAdminServer(CompatModule.java:50) (via modules: com.netflix.iep.karyon3.KaryonModule -> com.google.inject.util.Modules$OverrideModule -> com.netflix.iep.karyon3.CompatModule)\r\n\r\n1 error\r\n```\r\n\r\nIt seems like the rest/* classes should not depend on the ui/* classes."},"comment":{"url":"https://api.github.com/repos/Netflix/karyon/issues/comments/223324847","html_url":"https://github.com/Netflix/karyon/issues/310#issuecomment-223324847","issue_url":"https://api.github.com/repos/Netflix/karyon/issues/310","id":223324847,"user":{"login":"elandau","id":913564,"avatar_url":"https://avatars.githubusercontent.com/u/913564?v=3","gravatar_id":"","url":"https://api.github.com/users/elandau","html_url":"https://github.com/elandau","followers_url":"https://api.github.com/users/elandau/followers","following_url":"https://api.github.com/users/elandau/following{/other_user}","gists_url":"https://api.github.com/users/elandau/gists{/gist_id}","starred_url":"https://api.github.com/users/elandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elandau/subscriptions","organizations_url":"https://api.github.com/users/elandau/orgs","repos_url":"https://api.github.com/users/elandau/repos","events_url":"https://api.github.com/users/elandau/events{/privacy}","received_events_url":"https://api.github.com/users/elandau/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T15:19:10Z","updated_at":"2016-06-02T15:19:10Z","body":"3.x branch no longer under development"}}
{"actor":{"display_login":"elandau"}}