{"push_id":1088241906,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"35578aadfd71dacbd6818dbc5c0e7a6653227238","before":"4ca4f44e6ee89fdf8a59ffcc7b5909c56a390347","commits":[{"sha":"35578aadfd71dacbd6818dbc5c0e7a6653227238","author":{"email":"90d3e04d3957d615f1e24c1c14dff3064a3205b4@pefoley.com","name":"Peter Foley"},"message":"Cleanup warnings\n\nFix a bunch of misc warnings.\n\n[  8%] Building CXX object common/CMakeFiles/common.dir/src/arch-aarch64.C.o\n/home/peter/dyninst/common/src/arch-aarch64.C:111:45: warning: unused parameter ‘ptr’ [-Wunused-parameter]\n void instruction::setInstruction(codeBuf_t *ptr, Address) {\n                                             ^\n/home/peter/dyninst/common/src/arch-aarch64.C:143:40: warning: unused parameter ‘from’ [-Wunused-parameter]\n unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {\n                                        ^\n/home/peter/dyninst/common/src/arch-aarch64.C:143:54: warning: unused parameter ‘to’ [-Wunused-parameter]\n unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {\n                                                      ^\n/home/peter/dyninst/common/src/arch-aarch64.C:143:67: warning: unused parameter ‘addr_width’ [-Wunused-parameter]\n unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {\n                                                                   ^\n/home/peter/dyninst/common/src/arch-aarch64.C:149:40: warning: unused parameter ‘disp’ [-Wunused-parameter]\n unsigned instruction::jumpSize(Address disp, unsigned addr_width) {\n                                        ^\n/home/peter/dyninst/common/src/arch-aarch64.C:149:55: warning: unused parameter ‘addr_width’ [-Wunused-parameter]\n unsigned instruction::jumpSize(Address disp, unsigned addr_width) {\n                                                       ^\nIn file included from /home/peter/dyninst/common/h/dyn_regs.h:38:0,\n                 from /home/peter/dyninst/common/h/dyntypes.h:170,\n                 from /home/peter/dyninst/common/src/Types.h:168,\n                 from /home/peter/dyninst/common/src/arch-aarch64.C:31:\n/home/peter/dyninst/common/src/arch-aarch64.C: In member function ‘unsigned int NS_aarch64::instruction::getBranchTargetReg() const’:\n/home/peter/dyninst/common/src/arch-aarch64.C:204:24: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]\n         assert( regNum >= 0 || regNum <= 30);\n                        ^\n[ 14%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/Function.C.o\n/home/peter/dyninst/symtabAPI/src/Function.C:54:36: warning: unused parameter ‘sym’ [-Wunused-parameter]\n FunctionBase::FunctionBase(Symbol *sym) :\n                                    ^\n/home/peter/dyninst/symtabAPI/src/Function.C:76:36: warning: unused parameter ‘m’ [-Wunused-parameter]\n FunctionBase::FunctionBase(Module *m) :\n                                    ^\n/home/peter/dyninst/symtabAPI/src/Function.C:475:61: warning: unused parameter ‘isPrimary’ [-Wunused-parameter]\n bool InlinedFunction::addMangledName(std::string name, bool isPrimary)\n                                                             ^\n/home/peter/dyninst/symtabAPI/src/Function.C:481:60: warning: unused parameter ‘isPrimary’ [-Wunused-parameter]\n bool InlinedFunction::addPrettyName(std::string name, bool isPrimary)\n                                                            ^\n[ 22%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/dwarfWalker.C.o\nIn file included from /home/peter/dyninst/symtabAPI/src/dwarfWalker.C:31:0:\n/home/peter/dyninst/symtabAPI/src/dwarfWalker.h: In constructor ‘Dyninst::SymtabAPI::DwarfWalker::DwarfWalker(Dyninst::SymtabAPI::Symtab*, Dwarf_Debug_s*&)’:\n/home/peter/dyninst/symtabAPI/src/dwarfWalker.h:314:14: warning: ‘Dyninst::SymtabAPI::DwarfWalker::compile_offset’ will be initialized after [-Wreorder]\n    Dwarf_Off compile_offset;\n              ^\n/home/peter/dyninst/symtabAPI/src/dwarfWalker.h:292:12: warning:   ‘char** Dyninst::SymtabAPI::DwarfWalker::srcFileList_’ [-Wreorder]\n     char** srcFileList_;\n            ^\n/home/peter/dyninst/symtabAPI/src/dwarfWalker.C:76:1: warning:   when initialized here [-Wreorder]\n DwarfWalker::DwarfWalker(Symtab *symtab, Dwarf_Debug &dbg)\n ^\n[ 22%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/emitElf-64.C.o\n/home/peter/dyninst/symtabAPI/src/emitElf-64.C: In member function ‘bool Dyninst::SymtabAPI::emitElf64<ElfTypes>::driver(std::string) [with ElfTypes = Dyninst::SymtabAPI::ElfTypes32; std::string = std::basic_string<char>]’:\n/home/peter/dyninst/symtabAPI/src/emitElf-64.C:868:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]\n         write(newfd, &offset, sizeof(Elf_Off));\n         ^\n/home/peter/dyninst/symtabAPI/src/emitElf-64.C: In member function ‘bool Dyninst::SymtabAPI::emitElf64<ElfTypes>::driver(std::string) [with ElfTypes = Dyninst::SymtabAPI::ElfTypes64; std::string = std::basic_string<char>]’:\n/home/peter/dyninst/symtabAPI/src/emitElf-64.C:868:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]\n[ 26%] Building CXX object instructionAPI/CMakeFiles/instructionAPI.dir/src/InstructionDecoder-x86.C.o\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-x86.C: In member function ‘bool Dyninst::InstructionAPI::InstructionDecoder_x86::decodeOneOperand(const Dyninst::InstructionAPI::InstructionDecoder::buffer&, const NS_x86::ia32_operand&, int&, const Dyninst::InstructionAPI::Instruction*, bool, bool)’:\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-x86.C:795:12: warning: variable ‘has_vex’ set but not used [-Wunused-but-set-variable]\n       bool has_vex = 0;\n            ^\n[ 27%] Building CXX object instructionAPI/CMakeFiles/instructionAPI.dir/src/InstructionDecoder-aarch64.C.o\nIn file included from /home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:31:0:\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h: In constructor ‘Dyninst::InstructionAPI::InstructionDecoder_aarch64::InstructionDecoder_aarch64(Dyninst::Architecture)’:\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h:387:30: warning: ‘Dyninst::InstructionAPI::InstructionDecoder_aarch64::_Q’ will be initialized after [-Wreorder]\n                 unsigned int _Q;\n                              ^\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h:239:31: warning:   ‘int Dyninst::InstructionAPI::InstructionDecoder_aarch64::size’ [-Wreorder]\n                 int _szField, size;\n                               ^\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:141:5: warning:   when initialized here [-Wreorder]\n     InstructionDecoder_aarch64::InstructionDecoder_aarch64(Architecture a)\n     ^\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C: In member function ‘Dyninst::InstructionAPI::Expression::Ptr Dyninst::InstructionAPI::InstructionDecoder_aarch64::makeMemRefIndexLiteral()’:\n/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:1086:85: warning: ‘rt’ may be used uninitialized in this function [-Wmaybe-uninitialized]\n     return makeDereferenceExpression(makeAddExpression(makePCExpr(), label, u64), rt);\n                                                                                     ^\n[ 27%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/Parser.C.o\n/home/peter/dyninst/parseAPI/src/Parser.C: In member function ‘void Dyninst::ParseAPI::Parser::parse_frame(Dyninst::ParseAPI::ParseFrame&, bool)’:\n/home/peter/dyninst/parseAPI/src/Parser.C:888:20: warning: variable ‘ce’ set but not used [-Wunused-but-set-variable]\n             Edge * ce = NULL;\n                    ^\n[ 32%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/IA_aarch64Details.C.o\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:111:59: warning: unused parameter ‘blockToCheck’ [-Wunused-parameter]\n bool IA_aarch64Details::findTableAddrNoTOC(const IA_IAPI* blockToCheck)\n                                                           ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:33: warning: unused parameter ‘e’ [-Wunused-parameter]\n   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)\n                                 ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:54: warning: unused parameter ‘visited’ [-Wunused-parameter]\n   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)\n                                                      ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:83: warning: unused parameter ‘worklist’ [-Wunused-parameter]\n   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)\n                                                                                   ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:142:81: warning: unused parameter ‘start’ [-Wunused-parameter]\n bool IA_aarch64Details::scanForAdjustOrBase(IA_IAPI::allInsns_t::const_iterator start,\n                                                                                 ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:143:44: warning: unused parameter ‘end’ [-Wunused-parameter]\n        IA_IAPI::allInsns_t::const_iterator end,\n                                            ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:144:26: warning: unused parameter ‘jumpAddrReg’ [-Wunused-parameter]\n        RegisterAST::Ptr &jumpAddrReg) {\n                          ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:150:75: warning: unused parameter ‘start’ [-Wunused-parameter]\n bool IA_aarch64Details::findTableBase(IA_IAPI::allInsns_t::const_iterator start,\n                                                                           ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:151:45: warning: unused parameter ‘end’ [-Wunused-parameter]\n         IA_IAPI::allInsns_t::const_iterator end) {\n                                             ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:159:47: warning: unused parameter ‘currBlk’ [-Wunused-parameter]\n bool IA_aarch64Details::parseJumpTable(Block* currBlk,\n                                               ^\n/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:160:59: warning: unused parameter ‘outEdges’ [-Wunused-parameter]\n          std::vector<std::pair< Address, EdgeTypeEnum> >& outEdges)\n                                                           ^\n[ 33%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/BoundFactData.C.o\n/home/peter/dyninst/parseAPI/src/BoundFactData.C:604:39: warning: unused parameter ‘b’ [-Wunused-parameter]\n static bool IsInReadOnlyRegion(Block *b, Address low, Address high) {\n                                       ^\n[ 54%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/loadLibrary/codegen-aarch64.C.o\n/home/peter/dyninst/proccontrol/src/loadLibrary/codegen-aarch64.C: In member function ‘bool Dyninst::ProcControlAPI::Codegen::generateCallAARCH64(Dyninst::Address, const std::vector<long unsigned int>&)’:\n/home/peter/dyninst/proccontrol/src/loadLibrary/codegen-aarch64.C:53:10: warning: unused variable ‘blr_buf’ [-Wunused-variable]\n     char blr_buf[] = {\n          ^\n[ 56%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/mmapalloc.C.o\n/home/peter/dyninst/proccontrol/src/mmapalloc.C: In member function ‘virtual bool mmap_alloc_process::plat_createAllocationSnippet(Dyninst::Address, bool, long unsigned int, void*&, long unsigned int&, long unsigned int&)’:\n/home/peter/dyninst/proccontrol/src/mmapalloc.C:597:22: warning: variable ‘addr_size’ set but not used [-Wunused-but-set-variable]\n         unsigned int addr_size;\n                      ^\n[ 56%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/linux.C.o\nIn file included from /home/peter/dyninst/proccontrol/src/linux.C:48:0:\n/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘virtual bool DecoderLinux::decode(Dyninst::ProcControlAPI::ArchEvent*, std::vector<boost::shared_ptr<Dyninst::ProcControlAPI::Event> >&)’:\n/home/peter/dyninst/proccontrol/h/PCErrors.h:100:108: warning: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘Dyninst::MachRegisterVal {aka long unsigned int}’ [-Wformat=]\n          fprintf(pctrl_err_out, \"[%s:%u-%s] - Error: \" format, FILE__, __LINE__, thrdName(), ## __VA_ARGS__); \\\n                                                                                                            ^\n/home/peter/dyninst/proccontrol/src/linux.C:341:25: note: in expansion of macro ‘perr_printf’\n                         perr_printf(\"ARM-error: Failed to remove inserted BP, addr %p.\\n\",\n                         ^\n/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘virtual bool linux_process::plat_attachWillTriggerStop()’:\n/home/peter/dyninst/proccontrol/src/linux.C:1144:42: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’, declared with attribute warn_unused_result [-Wunused-result]\n             &tmpPid, &tmpPid, &ttyNumber);\n                                          ^\n/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘bool linux_process::readStatM(long unsigned int&, long unsigned int&, long unsigned int&)’:\n/home/peter/dyninst/proccontrol/src/linux.C:1927:35: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’, declared with attribute warn_unused_result [-Wunused-result]\n           &text, &lib, &data, &dt);\n                                   ^\n[ 77%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/function.C.o\n/home/peter/dyninst/dyninstAPI/src/function.C: In member function ‘bool func_instance::createOffsetVector_Symbols()’:\n/home/peter/dyninst/dyninstAPI/src/function.C:1205:18: warning: variable ‘bp’ set but not used [-Wunused-but-set-variable]\n     MachRegister bp = MachRegister::getFramePointer(arch);\n                  ^\n/home/peter/dyninst/dyninstAPI/src/function.C: In member function ‘void func_instance::createTMap_internal(StackMod*, StackLocation*, TMap*)’:\n/home/peter/dyninst/dyninstAPI/src/function.C:1530:27: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]\n     StackAnalysis::Height size = loc->size();\n                           ^\n[ 95%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/codegen-x86.C.o\n/home/peter/dyninst/dyninstAPI/src/codegen-x86.C: In static member function ‘static bool insnCodeGen::modifyDisp(long int, NS_x86::instruction&, codeGen&, Dyninst::Architecture, Dyninst::Address)’:\n/home/peter/dyninst/dyninstAPI/src/codegen-x86.C:1394:13: warning: variable ‘sib_scale_factor’ set but not used [-Wunused-but-set-variable]\n         int sib_scale_factor;\n             ^\n[ 96%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/linux.C.o\n/home/peter/dyninst/dyninstAPI/src/linux.C: In static member function ‘static bool BinaryEdit::getResolvedLibraryPath(const string&, std::vector<std::basic_string<char> >&)’:\n/home/peter/dyninst/dyninstAPI/src/linux.C:223:37: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]\n         fgets(buffer, 512, ldconfig); // ignore first line\n                                     ^","distinct":true,"url":"https://api.github.com/repos/pefoley2/dyninst/commits/35578aadfd71dacbd6818dbc5c0e7a6653227238"}]}