{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1475","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1475/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1475/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1475/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1475","id":180486732,"number":1475,"title":"Add RTL localization support","user":{"login":"bjubes","id":7608114,"avatar_url":"https://avatars.githubusercontent.com/u/7608114?v=3","gravatar_id":"","url":"https://api.github.com/users/bjubes","html_url":"https://github.com/bjubes","followers_url":"https://api.github.com/users/bjubes/followers","following_url":"https://api.github.com/users/bjubes/following{/other_user}","gists_url":"https://api.github.com/users/bjubes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjubes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjubes/subscriptions","organizations_url":"https://api.github.com/users/bjubes/orgs","repos_url":"https://api.github.com/users/bjubes/repos","events_url":"https://api.github.com/users/bjubes/events{/privacy}","received_events_url":"https://api.github.com/users/bjubes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-01T23:54:01Z","updated_at":"2016-10-07T01:30:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1475","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1475","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1475.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1475.patch"},"body":"closes #1456. This implementation is far from perfect, so please leave suggestions.\r\n\r\nRTL languages such as hebrew now display correctly from right to left. This is done by inverting the string, which is bad practice since the string should be correct internally, but the UI should invert it when displaying.\r\n\r\nto make a language RTL, the first line of the localization file must contain:\r\n`rtl=true` or `rtl=1`\r\n\r\nThe following files will be changed RTL on the localization repo after this is merged (please add more if applicable):\r\n* he_IL\r\n* ar"},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/252132415","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1475#issuecomment-252132415","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1475","id":252132415,"user":{"login":"bjubes","id":7608114,"avatar_url":"https://avatars.githubusercontent.com/u/7608114?v=3","gravatar_id":"","url":"https://api.github.com/users/bjubes","html_url":"https://github.com/bjubes","followers_url":"https://api.github.com/users/bjubes/followers","following_url":"https://api.github.com/users/bjubes/following{/other_user}","gists_url":"https://api.github.com/users/bjubes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjubes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjubes/subscriptions","organizations_url":"https://api.github.com/users/bjubes/orgs","repos_url":"https://api.github.com/users/bjubes/repos","events_url":"https://api.github.com/users/bjubes/events{/privacy}","received_events_url":"https://api.github.com/users/bjubes/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T01:30:36Z","updated_at":"2016-10-07T01:30:36Z","body":"your right. the best solution for letting lang=xxx be anywhere is to build a separate dictionary in the localizationTable class which maps codes (en_US) to language names (english) which can then be displayed. The problem is that the localization table holds a dictionary of each language as a dictionary of strings ` Dictionary<string, Dictionary<string, string>> localizationTable` so iterating through all of it to find every instance of lang as a key is waaay inefficient.\r\n\r\nOnce this is merged Ill work on allowing both tags (lang and rtl) to exist anywhere in the lang files. that way putting them on top can be convention not an awkward exception to the \"order doesn't matter\" rule"}}
{"actor":{"display_login":"bjubes"}}