{"action":"created","comment":{"url":"https://api.github.com/repos/xsf/xeps/pulls/comments/87617286","pull_request_review_id":8225682,"id":87617286,"diff_hunk":"@@ -169,6 +177,17 @@\n \t<section2 topic='Querying Entities' anchor='entities'>\n \t\t<p>While this document talks about 'clients' and 'servers', as these are the common cases, the querying entity (referred to as a 'client') need not be an XMPP client as defined by RFC6120, but could potentially be any type of entity, and the queried entity (referred to as a 'server') need not be an XMPP server as defined by RFC6120, although access controls might prohibit any given entity from being able to access an archive.</p>\n \t</section2>\n+\t<section2 topic='Communicating the archive ID' anchor='archives_id'>\n+\t\t<p>When an incoming message is archived, the server MAY add an &lt;stanza-id/&gt; element as defined in &xep0359; to the message, which informs the client of where and under what ID the message is stored. When doing this the server MUST follow the business rules defined in XEP-0359. The 'by'-attribute MUST be set to the address of the archive. For regular users that’s the bare JID of the account and for MUC that’s the bare JID of the room.</p>\n+\t\t<p>Servers MUST NOT include the &lt;stanza-id/&gt; element in messages addressed to JIDs that do not have permissions to access the archive, such as a users’s outgoing messages to their contacts. However servers SHOULD include the element as a child of the forwarded message when using &xep0280;</p>","path":"xep-0313.xml","position":21,"original_position":21,"commit_id":"d1ed977166b95a8ac3b002de28dc1cb659e5ac48","original_commit_id":"d1ed977166b95a8ac3b002de28dc1cb659e5ac48","user":{"login":"Kev","id":11914,"avatar_url":"https://avatars.githubusercontent.com/u/11914?v=3","gravatar_id":"","url":"https://api.github.com/users/Kev","html_url":"https://github.com/Kev","followers_url":"https://api.github.com/users/Kev/followers","following_url":"https://api.github.com/users/Kev/following{/other_user}","gists_url":"https://api.github.com/users/Kev/gists{/gist_id}","starred_url":"https://api.github.com/users/Kev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kev/subscriptions","organizations_url":"https://api.github.com/users/Kev/orgs","repos_url":"https://api.github.com/users/Kev/repos","events_url":"https://api.github.com/users/Kev/events{/privacy}","received_events_url":"https://api.github.com/users/Kev/received_events","type":"User","site_admin":false},"body":"I think having SHOULD here is in conflict with the MAY in the previous paragraph, isn't it?\r\n\r\nI'd have thought that if we bring the MAM IDs back, we'd want to make them compulsory and bump namespace, wouldn't we?","created_at":"2016-11-11T16:35:14Z","updated_at":"2016-11-11T16:35:14Z","html_url":"https://github.com/xsf/xeps/pull/275#discussion_r87617286","pull_request_url":"https://api.github.com/repos/xsf/xeps/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/xsf/xeps/pulls/comments/87617286"},"html":{"href":"https://github.com/xsf/xeps/pull/275#discussion_r87617286"},"pull_request":{"href":"https://api.github.com/repos/xsf/xeps/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/xsf/xeps/pulls/275","id":91513538,"html_url":"https://github.com/xsf/xeps/pull/275","diff_url":"https://github.com/xsf/xeps/pull/275.diff","patch_url":"https://github.com/xsf/xeps/pull/275.patch","issue_url":"https://api.github.com/repos/xsf/xeps/issues/275","number":275,"state":"open","locked":false,"title":"XEP-0313: server MAY add the id to incoming messages","user":{"login":"iNPUTmice","id":192229,"avatar_url":"https://avatars.githubusercontent.com/u/192229?v=3","gravatar_id":"","url":"https://api.github.com/users/iNPUTmice","html_url":"https://github.com/iNPUTmice","followers_url":"https://api.github.com/users/iNPUTmice/followers","following_url":"https://api.github.com/users/iNPUTmice/following{/other_user}","gists_url":"https://api.github.com/users/iNPUTmice/gists{/gist_id}","starred_url":"https://api.github.com/users/iNPUTmice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNPUTmice/subscriptions","organizations_url":"https://api.github.com/users/iNPUTmice/orgs","repos_url":"https://api.github.com/users/iNPUTmice/repos","events_url":"https://api.github.com/users/iNPUTmice/events{/privacy}","received_events_url":"https://api.github.com/users/iNPUTmice/received_events","type":"User","site_admin":false},"body":"Note that this PR depends on PR #270 being merged before.\n\nThis PR brings the old `<archive-id/>` back but as a `<stanza-id/>` defined in XEP-0359. This PR only influence the live incoming messages and doesn't change the syntax of regular interaction with MAM. It also doesn't include a namespace bump and is purely optional (MAY keyword). All security aspects are handled by the stanza-id XEP.\n\nI know that the original archive-id was dropped because it doesn't have a way to communicate the id for outgoing messages but I figure it is better to have the ID half the time than never.\nEjabberd already adds the id (but with a wrong by attribute IIRC) and a patch in prosody would be extremely simple and will help clients a lot. This feature doesn't stand in the way of future refactors of the entire MAM spec which @mwild1 has been planning and is also entirely optional. I hope we can merge this to kinda bridge the gap until we have something better. \n","created_at":"2016-10-30T07:14:26Z","updated_at":"2016-11-11T16:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dd604ffe2947f2d00553d79299a3bf8b4251acf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xsf/xeps/pulls/275/commits","review_comments_url":"https://api.github.com/repos/xsf/xeps/pulls/275/comments","review_comment_url":"https://api.github.com/repos/xsf/xeps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xsf/xeps/issues/275/comments","statuses_url":"https://api.github.com/repos/xsf/xeps/statuses/d1ed977166b95a8ac3b002de28dc1cb659e5ac48","head":{"label":"siacs:xep_0313_communicating_id","ref":"xep_0313_communicating_id","sha":"d1ed977166b95a8ac3b002de28dc1cb659e5ac48","user":{"login":"siacs","id":6818654,"avatar_url":"https://avatars.githubusercontent.com/u/6818654?v=3","gravatar_id":"","url":"https://api.github.com/users/siacs","html_url":"https://github.com/siacs","followers_url":"https://api.github.com/users/siacs/followers","following_url":"https://api.github.com/users/siacs/following{/other_user}","gists_url":"https://api.github.com/users/siacs/gists{/gist_id}","starred_url":"https://api.github.com/users/siacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siacs/subscriptions","organizations_url":"https://api.github.com/users/siacs/orgs","repos_url":"https://api.github.com/users/siacs/repos","events_url":"https://api.github.com/users/siacs/events{/privacy}","received_events_url":"https://api.github.com/users/siacs/received_events","type":"Organization","site_admin":false},"repo":{"id":41697957,"name":"xeps","full_name":"siacs/xeps","owner":{"login":"siacs","id":6818654,"avatar_url":"https://avatars.githubusercontent.com/u/6818654?v=3","gravatar_id":"","url":"https://api.github.com/users/siacs","html_url":"https://github.com/siacs","followers_url":"https://api.github.com/users/siacs/followers","following_url":"https://api.github.com/users/siacs/following{/other_user}","gists_url":"https://api.github.com/users/siacs/gists{/gist_id}","starred_url":"https://api.github.com/users/siacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siacs/subscriptions","organizations_url":"https://api.github.com/users/siacs/orgs","repos_url":"https://api.github.com/users/siacs/repos","events_url":"https://api.github.com/users/siacs/events{/privacy}","received_events_url":"https://api.github.com/users/siacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/siacs/xeps","description":null,"fork":true,"url":"https://api.github.com/repos/siacs/xeps","forks_url":"https://api.github.com/repos/siacs/xeps/forks","keys_url":"https://api.github.com/repos/siacs/xeps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siacs/xeps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siacs/xeps/teams","hooks_url":"https://api.github.com/repos/siacs/xeps/hooks","issue_events_url":"https://api.github.com/repos/siacs/xeps/issues/events{/number}","events_url":"https://api.github.com/repos/siacs/xeps/events","assignees_url":"https://api.github.com/repos/siacs/xeps/assignees{/user}","branches_url":"https://api.github.com/repos/siacs/xeps/branches{/branch}","tags_url":"https://api.github.com/repos/siacs/xeps/tags","blobs_url":"https://api.github.com/repos/siacs/xeps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siacs/xeps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siacs/xeps/git/refs{/sha}","trees_url":"https://api.github.com/repos/siacs/xeps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siacs/xeps/statuses/{sha}","languages_url":"https://api.github.com/repos/siacs/xeps/languages","stargazers_url":"https://api.github.com/repos/siacs/xeps/stargazers","contributors_url":"https://api.github.com/repos/siacs/xeps/contributors","subscribers_url":"https://api.github.com/repos/siacs/xeps/subscribers","subscription_url":"https://api.github.com/repos/siacs/xeps/subscription","commits_url":"https://api.github.com/repos/siacs/xeps/commits{/sha}","git_commits_url":"https://api.github.com/repos/siacs/xeps/git/commits{/sha}","comments_url":"https://api.github.com/repos/siacs/xeps/comments{/number}","issue_comment_url":"https://api.github.com/repos/siacs/xeps/issues/comments{/number}","contents_url":"https://api.github.com/repos/siacs/xeps/contents/{+path}","compare_url":"https://api.github.com/repos/siacs/xeps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siacs/xeps/merges","archive_url":"https://api.github.com/repos/siacs/xeps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siacs/xeps/downloads","issues_url":"https://api.github.com/repos/siacs/xeps/issues{/number}","pulls_url":"https://api.github.com/repos/siacs/xeps/pulls{/number}","milestones_url":"https://api.github.com/repos/siacs/xeps/milestones{/number}","notifications_url":"https://api.github.com/repos/siacs/xeps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siacs/xeps/labels{/name}","releases_url":"https://api.github.com/repos/siacs/xeps/releases{/id}","deployments_url":"https://api.github.com/repos/siacs/xeps/deployments","created_at":"2015-08-31T20:09:45Z","updated_at":"2015-09-07T13:25:05Z","pushed_at":"2016-11-01T15:41:13Z","git_url":"git://github.com/siacs/xeps.git","ssh_url":"git@github.com:siacs/xeps.git","clone_url":"https://github.com/siacs/xeps.git","svn_url":"https://github.com/siacs/xeps","homepage":null,"size":7215,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"xsf:master","ref":"master","sha":"ac8cf918ee7427133b50cebd692c62dfb3ad175c","user":{"login":"xsf","id":15827,"avatar_url":"https://avatars.githubusercontent.com/u/15827?v=3","gravatar_id":"","url":"https://api.github.com/users/xsf","html_url":"https://github.com/xsf","followers_url":"https://api.github.com/users/xsf/followers","following_url":"https://api.github.com/users/xsf/following{/other_user}","gists_url":"https://api.github.com/users/xsf/gists{/gist_id}","starred_url":"https://api.github.com/users/xsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsf/subscriptions","organizations_url":"https://api.github.com/users/xsf/orgs","repos_url":"https://api.github.com/users/xsf/repos","events_url":"https://api.github.com/users/xsf/events{/privacy}","received_events_url":"https://api.github.com/users/xsf/received_events","type":"Organization","site_admin":false},"repo":{"id":37649804,"name":"xeps","full_name":"xsf/xeps","owner":{"login":"xsf","id":15827,"avatar_url":"https://avatars.githubusercontent.com/u/15827?v=3","gravatar_id":"","url":"https://api.github.com/users/xsf","html_url":"https://github.com/xsf","followers_url":"https://api.github.com/users/xsf/followers","following_url":"https://api.github.com/users/xsf/following{/other_user}","gists_url":"https://api.github.com/users/xsf/gists{/gist_id}","starred_url":"https://api.github.com/users/xsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsf/subscriptions","organizations_url":"https://api.github.com/users/xsf/orgs","repos_url":"https://api.github.com/users/xsf/repos","events_url":"https://api.github.com/users/xsf/events{/privacy}","received_events_url":"https://api.github.com/users/xsf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xsf/xeps","description":null,"fork":false,"url":"https://api.github.com/repos/xsf/xeps","forks_url":"https://api.github.com/repos/xsf/xeps/forks","keys_url":"https://api.github.com/repos/xsf/xeps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xsf/xeps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xsf/xeps/teams","hooks_url":"https://api.github.com/repos/xsf/xeps/hooks","issue_events_url":"https://api.github.com/repos/xsf/xeps/issues/events{/number}","events_url":"https://api.github.com/repos/xsf/xeps/events","assignees_url":"https://api.github.com/repos/xsf/xeps/assignees{/user}","branches_url":"https://api.github.com/repos/xsf/xeps/branches{/branch}","tags_url":"https://api.github.com/repos/xsf/xeps/tags","blobs_url":"https://api.github.com/repos/xsf/xeps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xsf/xeps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xsf/xeps/git/refs{/sha}","trees_url":"https://api.github.com/repos/xsf/xeps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xsf/xeps/statuses/{sha}","languages_url":"https://api.github.com/repos/xsf/xeps/languages","stargazers_url":"https://api.github.com/repos/xsf/xeps/stargazers","contributors_url":"https://api.github.com/repos/xsf/xeps/contributors","subscribers_url":"https://api.github.com/repos/xsf/xeps/subscribers","subscription_url":"https://api.github.com/repos/xsf/xeps/subscription","commits_url":"https://api.github.com/repos/xsf/xeps/commits{/sha}","git_commits_url":"https://api.github.com/repos/xsf/xeps/git/commits{/sha}","comments_url":"https://api.github.com/repos/xsf/xeps/comments{/number}","issue_comment_url":"https://api.github.com/repos/xsf/xeps/issues/comments{/number}","contents_url":"https://api.github.com/repos/xsf/xeps/contents/{+path}","compare_url":"https://api.github.com/repos/xsf/xeps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xsf/xeps/merges","archive_url":"https://api.github.com/repos/xsf/xeps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xsf/xeps/downloads","issues_url":"https://api.github.com/repos/xsf/xeps/issues{/number}","pulls_url":"https://api.github.com/repos/xsf/xeps/pulls{/number}","milestones_url":"https://api.github.com/repos/xsf/xeps/milestones{/number}","notifications_url":"https://api.github.com/repos/xsf/xeps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xsf/xeps/labels{/name}","releases_url":"https://api.github.com/repos/xsf/xeps/releases{/id}","deployments_url":"https://api.github.com/repos/xsf/xeps/deployments","created_at":"2015-06-18T09:17:50Z","updated_at":"2016-10-26T20:17:55Z","pushed_at":"2016-11-09T17:46:42Z","git_url":"git://github.com/xsf/xeps.git","ssh_url":"git@github.com:xsf/xeps.git","clone_url":"https://github.com/xsf/xeps.git","svn_url":"https://github.com/xsf/xeps","homepage":null,"size":7445,"stargazers_count":56,"watchers_count":56,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":20,"forks":50,"open_issues":20,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xsf/xeps/pulls/275"},"html":{"href":"https://github.com/xsf/xeps/pull/275"},"issue":{"href":"https://api.github.com/repos/xsf/xeps/issues/275"},"comments":{"href":"https://api.github.com/repos/xsf/xeps/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/xsf/xeps/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/xsf/xeps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xsf/xeps/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/xsf/xeps/statuses/d1ed977166b95a8ac3b002de28dc1cb659e5ac48"}}}}
{"actor":{"display_login":"Kev"}}