{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/3202","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3202/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3202/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3202/events","html_url":"https://github.com/mne-tools/mne-python/pull/3202","id":152611112,"number":3202,"title":"adding a function to forcibly update measurement infos","user":{"login":"choldgraf","id":1839645,"avatar_url":"https://avatars.githubusercontent.com/u/1839645?v=3","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2016-05-02T18:18:38Z","updated_at":"2016-05-04T01:24:34Z","closed_at":"2016-05-04T00:12:15Z","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3202","html_url":"https://github.com/mne-tools/mne-python/pull/3202","diff_url":"https://github.com/mne-tools/mne-python/pull/3202.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3202.patch"},"body":"In reference to #2948, this adds a function to forcible update parameters of target info objects using the values from a base info object. Generally meant to facilitate adding new channels that you created from RawArray. A couple thoughts worth mentioning:\r\n\r\n* It hard-codes a few fields that it won't update `['chs', 'ch_names', and 'nchan']`. Is that OK and do you think I missed some?\r\n* It will update the fields in target_info without copying first. I could do a deepcopy first and then return info objects, though that'll make it a little clunkier. I did make it so that using the force parameter in `add_channels` *will* deepcopy before updating the infos.\r\n* In general, this is kind of a \"dumb\" implementation, so I tried to warn about potential ramifications in the doc for the \"force\" parameter in `add_channels`. I could also add more documentation to the _force_update... function itself.\r\n\r\nWDYT? @Eric89GXL @kingjr @agramfort ?\r\n\r\nEDIT by Eric89GXL:\r\nCloses #2948."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/216716031","html_url":"https://github.com/mne-tools/mne-python/pull/3202#issuecomment-216716031","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3202","id":216716031,"user":{"login":"choldgraf","id":1839645,"avatar_url":"https://avatars.githubusercontent.com/u/1839645?v=3","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T01:24:34Z","updated_at":"2016-05-04T01:24:34Z","body":"np!\n\nOn Tue, May 3, 2016 at 5:12 PM, Eric Larson <notifications@github.com>\nwrote:\n\n> Thanks @choldgraf <https://github.com/choldgraf>\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mne-tools/mne-python/pull/3202#issuecomment-216704797>\n>\n"}}