{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/84373173","pull_request_review_id":5156278,"id":84373173,"diff_hunk":"@@ -10,6 +10,7 @@ namespace CoreNodeModels.Input\n     [NodeName(\"Date Time\")]\n     [NodeDescription(\"DateTimeDescription\", typeof(Properties.Resources))]\n     [NodeCategory(BuiltinNodeCategories.CORE_INPUT)]\n+    [OutPortTypes(\"var\")]","path":"src/Libraries/CoreNodeModels/Input/DateTime.cs","position":4,"original_position":4,"commit_id":"116054795ac2e57547ca71bdd67d9a9c7f511248","original_commit_id":"116054795ac2e57547ca71bdd67d9a9c7f511248","user":{"login":"Racel","id":2551261,"avatar_url":"https://avatars.githubusercontent.com/u/2551261?v=3","gravatar_id":"","url":"https://api.github.com/users/Racel","html_url":"https://github.com/Racel","followers_url":"https://api.github.com/users/Racel/followers","following_url":"https://api.github.com/users/Racel/following{/other_user}","gists_url":"https://api.github.com/users/Racel/gists{/gist_id}","starred_url":"https://api.github.com/users/Racel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Racel/subscriptions","organizations_url":"https://api.github.com/users/Racel/orgs","repos_url":"https://api.github.com/users/Racel/repos","events_url":"https://api.github.com/users/Racel/events{/privacy}","received_events_url":"https://api.github.com/users/Racel/received_events","type":"User","site_admin":false},"body":"Can we change this to 'dateTime'. I know that all the other 'dateTime' nodes have 'var' as output, but that doesn't really mean anything.","created_at":"2016-10-20T20:50:57Z","updated_at":"2016-10-20T20:50:57Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/7277#discussion_r84373173","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/84373173"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/7277#discussion_r84373173"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277","id":89572112,"html_url":"https://github.com/DynamoDS/Dynamo/pull/7277","diff_url":"https://github.com/DynamoDS/Dynamo/pull/7277.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/7277.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/7277","number":7277,"state":"open","locked":false,"title":" NodeModel inputs/output labels, descriptions partially fixed in search","user":{"login":"samuelcwl","id":16283396,"avatar_url":"https://avatars.githubusercontent.com/u/16283396?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelcwl","html_url":"https://github.com/samuelcwl","followers_url":"https://api.github.com/users/samuelcwl/followers","following_url":"https://api.github.com/users/samuelcwl/following{/other_user}","gists_url":"https://api.github.com/users/samuelcwl/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelcwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelcwl/subscriptions","organizations_url":"https://api.github.com/users/samuelcwl/orgs","repos_url":"https://api.github.com/users/samuelcwl/repos","events_url":"https://api.github.com/users/samuelcwl/events{/privacy}","received_events_url":"https://api.github.com/users/samuelcwl/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThis PR is meant to address _MAGN-8833_.\r\n\r\nPreviously, there were some nodes which were missing Input/Output port labels as well as node descriptions. These are captured in this [Google Sheets](https://docs.google.com/spreadsheets/d/1TKX3Wr4kKsFPzeAR7nIIeqE0VSzbfx5fA_IM_qkJp-s/edit#gid=479228827). \r\n\r\nAs such, I came up with the node labels and descriptions (Ritesh reviewed these labels / descriptions) and tried to insert them where possible.\r\n\r\nFor many nodes in the list, however, I could not update their I/O labels as there was legacy code which still used the deprecated `InPort/OutPort data` framework and would take significant effort to retool many of these nodes to fit into the `NodeNameAttributes` framework. I've filed another Youtrack task for these nodes. Nevertheless, I managed to add in the `Outport Type` for these incompatible nodes. \r\n\r\nIn addition, there were some nodes (missing descriptions) which were written in DesignScript and loaded as .ds files. I have created another Youtrack task for these nodes as well.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [ ] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [ ] Follows [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions) standards (*No change of public methods or types etc..*)\r\n\r\n### Reviewers\r\n\r\n@riteshchandawar , @Racel \r\n\r\n### FYIs\r\n","created_at":"2016-10-17T07:21:18Z","updated_at":"2016-10-20T20:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12beef644329e1a5195c14b304d4ab65d52b588a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/7277/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/116054795ac2e57547ca71bdd67d9a9c7f511248","head":{"label":"samuelcwl:magn8833","ref":"magn8833","sha":"116054795ac2e57547ca71bdd67d9a9c7f511248","user":{"login":"samuelcwl","id":16283396,"avatar_url":"https://avatars.githubusercontent.com/u/16283396?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelcwl","html_url":"https://github.com/samuelcwl","followers_url":"https://api.github.com/users/samuelcwl/followers","following_url":"https://api.github.com/users/samuelcwl/following{/other_user}","gists_url":"https://api.github.com/users/samuelcwl/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelcwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelcwl/subscriptions","organizations_url":"https://api.github.com/users/samuelcwl/orgs","repos_url":"https://api.github.com/users/samuelcwl/repos","events_url":"https://api.github.com/users/samuelcwl/events{/privacy}","received_events_url":"https://api.github.com/users/samuelcwl/received_events","type":"User","site_admin":false},"repo":{"id":61698578,"name":"Dynamo","full_name":"samuelcwl/Dynamo","owner":{"login":"samuelcwl","id":16283396,"avatar_url":"https://avatars.githubusercontent.com/u/16283396?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelcwl","html_url":"https://github.com/samuelcwl","followers_url":"https://api.github.com/users/samuelcwl/followers","following_url":"https://api.github.com/users/samuelcwl/following{/other_user}","gists_url":"https://api.github.com/users/samuelcwl/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelcwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelcwl/subscriptions","organizations_url":"https://api.github.com/users/samuelcwl/orgs","repos_url":"https://api.github.com/users/samuelcwl/repos","events_url":"https://api.github.com/users/samuelcwl/events{/privacy}","received_events_url":"https://api.github.com/users/samuelcwl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelcwl/Dynamo","description":"Visual Programming","fork":true,"url":"https://api.github.com/repos/samuelcwl/Dynamo","forks_url":"https://api.github.com/repos/samuelcwl/Dynamo/forks","keys_url":"https://api.github.com/repos/samuelcwl/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelcwl/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelcwl/Dynamo/teams","hooks_url":"https://api.github.com/repos/samuelcwl/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/samuelcwl/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/samuelcwl/Dynamo/events","assignees_url":"https://api.github.com/repos/samuelcwl/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/samuelcwl/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/samuelcwl/Dynamo/tags","blobs_url":"https://api.github.com/repos/samuelcwl/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelcwl/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelcwl/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelcwl/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelcwl/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelcwl/Dynamo/languages","stargazers_url":"https://api.github.com/repos/samuelcwl/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/samuelcwl/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/samuelcwl/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/samuelcwl/Dynamo/subscription","commits_url":"https://api.github.com/repos/samuelcwl/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelcwl/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelcwl/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelcwl/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelcwl/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/samuelcwl/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelcwl/Dynamo/merges","archive_url":"https://api.github.com/repos/samuelcwl/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelcwl/Dynamo/downloads","issues_url":"https://api.github.com/repos/samuelcwl/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/samuelcwl/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelcwl/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelcwl/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelcwl/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/samuelcwl/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/samuelcwl/Dynamo/deployments","created_at":"2016-06-22T07:32:28Z","updated_at":"2016-06-22T07:32:45Z","pushed_at":"2016-10-20T03:44:43Z","git_url":"git://github.com/samuelcwl/Dynamo.git","ssh_url":"git@github.com:samuelcwl/Dynamo.git","clone_url":"https://github.com/samuelcwl/Dynamo.git","svn_url":"https://github.com/samuelcwl/Dynamo","homepage":"http://dynamobim.org","size":944543,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"7aa34460cdbdcc55dd9c44431620a497b7e1d04f","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2016-10-17T12:50:27Z","pushed_at":"2016-10-20T11:50:54Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1187798,"stargazers_count":383,"watchers_count":383,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":264,"mirror_url":null,"open_issues_count":666,"forks":264,"open_issues":666,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/7277"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/7277"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/7277/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/7277/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/116054795ac2e57547ca71bdd67d9a9c7f511248"}}}}
{"actor":{"display_login":"Racel"}}