{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/25308","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/25308/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/25308/comments","events_url":"https://api.github.com/repos/docker/docker/issues/25308/events","html_url":"https://github.com/docker/docker/pull/25308","id":168733497,"number":25308,"title":"Improve swarm join-token instructions","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/57","html_url":"https://github.com/docker/docker/milestones/1.12.1","labels_url":"https://api.github.com/repos/docker/docker/milestones/57/labels","id":1907496,"number":57,"title":"1.12.1","description":"milestone to track issues that can possibly warrant a patch release.\r\n\r\nsee our Patch release policy for more information about the procedure;\r\nhttps://github.com/docker/docker/blob/master/project/PATCH-RELEASES.md\r\n","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":15,"state":"open","created_at":"2016-07-27T15:59:34Z","updated_at":"2016-08-02T15:35:25Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-08-01T20:22:46Z","updated_at":"2016-08-02T16:28:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25308","html_url":"https://github.com/docker/docker/pull/25308","diff_url":"https://github.com/docker/docker/pull/25308.diff","patch_url":"https://github.com/docker/docker/pull/25308.patch"},"body":"this change improves the instructions for\r\nswarm join-token and swarm init;\r\n\r\n- only print the join-token command for workers\r\n  instead of for both managers and workers, to\r\n  prevent users from copying the wrong command.\r\n  An extra line is added to explain how to obtain\r\n  the manager token.\r\n- print a message that a token was rotated\r\n  sucesfully if '--rotate' is used.\r\n- add some extra white-space before / after\r\n  the join commands, to make copy/pasting\r\n  easier.\r\n\r\nthis change also does some refactoring of join-token;\r\n\r\n- move flagname-constants together with other constants\r\n- use variables for selected role (\"worker\" / \"manager\")\r\n  to prevent checking for them multiple times, and to\r\n  keep the \"worker\" / \"manager\" sting centralized\r\n- add an extra blank line after \"join-token\" instructions\r\n  this makes it easier to copy, and cleans up the\r\n  code a tiny bit\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/236960640","html_url":"https://github.com/docker/docker/pull/25308#issuecomment-236960640","issue_url":"https://api.github.com/repos/docker/docker/issues/25308","id":236960640,"user":{"login":"diogomonica","id":55332,"avatar_url":"https://avatars.githubusercontent.com/u/55332?v=3","gravatar_id":"","url":"https://api.github.com/users/diogomonica","html_url":"https://github.com/diogomonica","followers_url":"https://api.github.com/users/diogomonica/followers","following_url":"https://api.github.com/users/diogomonica/following{/other_user}","gists_url":"https://api.github.com/users/diogomonica/gists{/gist_id}","starred_url":"https://api.github.com/users/diogomonica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogomonica/subscriptions","organizations_url":"https://api.github.com/users/diogomonica/orgs","repos_url":"https://api.github.com/users/diogomonica/repos","events_url":"https://api.github.com/users/diogomonica/events{/privacy}","received_events_url":"https://api.github.com/users/diogomonica/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T16:28:38Z","updated_at":"2016-08-02T16:28:38Z","body":"LGTM"}}
{"actor":{"display_login":"diogomonica"}}