{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/88014967","pull_request_review_id":8601086,"id":88014967,"diff_hunk":"@@ -1202,7 +1201,7 @@ public function author_search($type, $firstpost_only, $sort_by_sql, $sort_key, $\n \t\t\t\t\t\t\t\t$post_visibility\n \t\t\t\t\t\t\t\t$sql_fora\n \t\t\t\t\t\t\t\tAND t.topic_id = p.topic_id\n-\t\t\t\t\t\t\t\t$sql_time\" . (($this->db->get_sql_layer() == 'sqlite' || $this->db->get_sql_layer() == 'sqlite3') ? ')' : '');\n+\t\t\t\t\t\t\t\t$sql_time\" . (($this->db->get_sql_layer() == 'sqlite3') ? ')' : '');","path":"phpBB/phpbb/search/fulltext_native.php","position":22,"original_position":22,"commit_id":"b5e238d41b781d7ba228eaa6d16ab534da31134a","original_commit_id":"b5e238d41b781d7ba228eaa6d16ab534da31134a","user":{"login":"senky","id":182498,"avatar_url":"https://avatars.githubusercontent.com/u/182498?v=3","gravatar_id":"","url":"https://api.github.com/users/senky","html_url":"https://github.com/senky","followers_url":"https://api.github.com/users/senky/followers","following_url":"https://api.github.com/users/senky/following{/other_user}","gists_url":"https://api.github.com/users/senky/gists{/gist_id}","starred_url":"https://api.github.com/users/senky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senky/subscriptions","organizations_url":"https://api.github.com/users/senky/orgs","repos_url":"https://api.github.com/users/senky/repos","events_url":"https://api.github.com/users/senky/events{/privacy}","received_events_url":"https://api.github.com/users/senky/received_events","type":"User","site_admin":false},"body":"Not true, you need to enclose expression in brackets to return it's value. Try it yourself here:\r\nhttp://sandbox.onlinephpfunctions.com/\r\ntry to execute this:\r\n```php\r\n<?php\r\n$string = \"text\" . 'a' == 'a' ? '-append' : '';\r\necho $string;\r\n```\r\nvs this:\r\n```php\r\n<?php\r\n$string = \"text\" . ('a' == 'a' ? '-append' : '');\r\necho $string;\r\n```","created_at":"2016-11-15T13:26:55Z","updated_at":"2016-11-15T13:26:55Z","html_url":"https://github.com/phpbb/phpbb/pull/4515#discussion_r88014967","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4515","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/88014967"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4515#discussion_r88014967"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4515"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4515","id":93479271,"html_url":"https://github.com/phpbb/phpbb/pull/4515","diff_url":"https://github.com/phpbb/phpbb/pull/4515.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4515.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4515","number":4515,"state":"open","locked":false,"title":"[ticket/14739] Remove SQLite 2.8.x database driver","user":{"login":"senky","id":182498,"avatar_url":"https://avatars.githubusercontent.com/u/182498?v=3","gravatar_id":"","url":"https://api.github.com/users/senky","html_url":"https://github.com/senky","followers_url":"https://api.github.com/users/senky/followers","following_url":"https://api.github.com/users/senky/following{/other_user}","gists_url":"https://api.github.com/users/senky/gists{/gist_id}","starred_url":"https://api.github.com/users/senky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senky/subscriptions","organizations_url":"https://api.github.com/users/senky/orgs","repos_url":"https://api.github.com/users/senky/repos","events_url":"https://api.github.com/users/senky/events{/privacy}","received_events_url":"https://api.github.com/users/senky/received_events","type":"User","site_admin":false},"body":"Checklist:\r\n\r\n- [ ] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [ ] Tests pass\r\n- [ ] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [ ] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nTracker ticket (set the ticket ID to **your ticket ID**):\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-14739\r\n\r\nPHPBB3-14739","created_at":"2016-11-13T17:13:56Z","updated_at":"2016-11-15T13:26:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd5235ce5f33d34a36220f44538bd1ac303bd3a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4515/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4515/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4515/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/b5e238d41b781d7ba228eaa6d16ab534da31134a","head":{"label":"senky:ticket/14739","ref":"ticket/14739","sha":"b5e238d41b781d7ba228eaa6d16ab534da31134a","user":{"login":"senky","id":182498,"avatar_url":"https://avatars.githubusercontent.com/u/182498?v=3","gravatar_id":"","url":"https://api.github.com/users/senky","html_url":"https://github.com/senky","followers_url":"https://api.github.com/users/senky/followers","following_url":"https://api.github.com/users/senky/following{/other_user}","gists_url":"https://api.github.com/users/senky/gists{/gist_id}","starred_url":"https://api.github.com/users/senky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senky/subscriptions","organizations_url":"https://api.github.com/users/senky/orgs","repos_url":"https://api.github.com/users/senky/repos","events_url":"https://api.github.com/users/senky/events{/privacy}","received_events_url":"https://api.github.com/users/senky/received_events","type":"User","site_admin":false},"repo":{"id":30877747,"name":"phpbb","full_name":"senky/phpbb","owner":{"login":"senky","id":182498,"avatar_url":"https://avatars.githubusercontent.com/u/182498?v=3","gravatar_id":"","url":"https://api.github.com/users/senky","html_url":"https://github.com/senky","followers_url":"https://api.github.com/users/senky/followers","following_url":"https://api.github.com/users/senky/following{/other_user}","gists_url":"https://api.github.com/users/senky/gists{/gist_id}","starred_url":"https://api.github.com/users/senky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senky/subscriptions","organizations_url":"https://api.github.com/users/senky/orgs","repos_url":"https://api.github.com/users/senky/repos","events_url":"https://api.github.com/users/senky/events{/privacy}","received_events_url":"https://api.github.com/users/senky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/senky/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/senky/phpbb","forks_url":"https://api.github.com/repos/senky/phpbb/forks","keys_url":"https://api.github.com/repos/senky/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senky/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senky/phpbb/teams","hooks_url":"https://api.github.com/repos/senky/phpbb/hooks","issue_events_url":"https://api.github.com/repos/senky/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/senky/phpbb/events","assignees_url":"https://api.github.com/repos/senky/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/senky/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/senky/phpbb/tags","blobs_url":"https://api.github.com/repos/senky/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senky/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senky/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/senky/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senky/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/senky/phpbb/languages","stargazers_url":"https://api.github.com/repos/senky/phpbb/stargazers","contributors_url":"https://api.github.com/repos/senky/phpbb/contributors","subscribers_url":"https://api.github.com/repos/senky/phpbb/subscribers","subscription_url":"https://api.github.com/repos/senky/phpbb/subscription","commits_url":"https://api.github.com/repos/senky/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/senky/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/senky/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/senky/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/senky/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/senky/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senky/phpbb/merges","archive_url":"https://api.github.com/repos/senky/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senky/phpbb/downloads","issues_url":"https://api.github.com/repos/senky/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/senky/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/senky/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/senky/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senky/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/senky/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/senky/phpbb/deployments","created_at":"2015-02-16T16:49:28Z","updated_at":"2015-02-16T16:49:33Z","pushed_at":"2016-11-15T13:23:01Z","git_url":"git://github.com/senky/phpbb.git","ssh_url":"git@github.com:senky/phpbb.git","clone_url":"https://github.com/senky/phpbb.git","svn_url":"https://github.com/senky/phpbb","homepage":"http://www.phpbb.com","size":56082,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:3.2.x","ref":"3.2.x","sha":"9c7e8c2dc5607a594f1e8d3a633dc686e8c002a7","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/phpbb/phpbb/deployments","created_at":"2010-03-01T22:33:17Z","updated_at":"2016-11-14T14:27:38Z","pushed_at":"2016-11-15T13:23:02Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":172461,"stargazers_count":934,"watchers_count":934,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":45,"forks":562,"open_issues":45,"watchers":934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4515"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4515"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4515"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4515/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4515/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4515/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/b5e238d41b781d7ba228eaa6d16ab534da31134a"}}}}
{"actor":{"display_login":"senky"}}