{"action":"created","comment":{"url":"https://api.github.com/repos/nitlang/nit/pulls/comments/68602259","id":68602259,"diff_hunk":"@@ -70,15 +85,25 @@ doc/nitc/index.html: bin/nitdoc bin/nitls\n \t\t--piwik-tracker \"pratchett.info.uqam.ca/piwik/\" \\\n \t\t--piwik-site-id \"3\"\n \n-man:\n-\t$(MAKE) -C share/man\n+.PHONY: man $(PROJECT_MANDIR)\n+man $(PROJECT_MANDIR):\n+\t$(MAKE) -C $(PROJECT_MANDIR)\n \n-clean:\n-\trm -rf -- doc/stdlib doc/nitc || true\n-\tcd c_src; make clean\n-\tcd src; make clean\n-\tcd tests; make clean\n-\tcd share/man; make clean\n+# `clean` `distclean` and `mostlyclean` avoid deleting files usually provided by\n+# the maintainers. `mostlyclean` also avoids deleting Nit tools in `./bin`.\n+# `maintainer-clean` deletes all files that can be regenerated by this Makefile.\n+#\n+# WARNING: The `maintainer-clean` target is intended for maintainers to use; it\n+# deletes files that may need special tools to rebuild.\n+#\n+# See also: https://www.gnu.org/prep/standards/html_node/Standard-Targets.html\n+.PHONY: clean distclean mostlyclean maintainer-clean\n+clean distclean mostlyclean maintainer-clean:\n+\trm -rf -- $(PROJECT_DOCDIR)/stdlib $(PROJECT_DOCDIR)/nitc || true\n+\t$(MAKE) -C ./c_src clean || true\n+\t$(MAKE) -C ./src $@\n+\t$(MAKE) -C ./tests $@\n+\t$(MAKE) -C ./share/man $@\n \tfor m in $(PROGS); do \\\n-\t\t$(MAKE) clean -C \"$$m\"; \\\n-\t\tdone || true","path":"Makefile","position":108,"original_position":108,"commit_id":"8a697bdc65c343be526378ef5cb88ce3f8bf398b","original_commit_id":"8a697bdc65c343be526378ef5cb88ce3f8bf398b","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars.githubusercontent.com/u/208057?v=3","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"body":"You can drop the commit \"fixing\" the indentation since remove the line altogether afterward.","created_at":"2016-06-27T15:54:15Z","updated_at":"2016-06-27T15:54:15Z","html_url":"https://github.com/nitlang/nit/pull/2201#discussion_r68602259","pull_request_url":"https://api.github.com/repos/nitlang/nit/pulls/2201","_links":{"self":{"href":"https://api.github.com/repos/nitlang/nit/pulls/comments/68602259"},"html":{"href":"https://github.com/nitlang/nit/pull/2201#discussion_r68602259"},"pull_request":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2201"}}},"pull_request":{"url":"https://api.github.com/repos/nitlang/nit/pulls/2201","id":75059895,"html_url":"https://github.com/nitlang/nit/pull/2201","diff_url":"https://github.com/nitlang/nit/pull/2201.diff","patch_url":"https://github.com/nitlang/nit/pull/2201.patch","issue_url":"https://api.github.com/repos/nitlang/nit/issues/2201","number":2201,"state":"open","locked":false,"title":"Refactor and fix makefiles","user":{"login":"jcbrinfo","id":6044484,"avatar_url":"https://avatars.githubusercontent.com/u/6044484?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbrinfo","html_url":"https://github.com/jcbrinfo","followers_url":"https://api.github.com/users/jcbrinfo/followers","following_url":"https://api.github.com/users/jcbrinfo/following{/other_user}","gists_url":"https://api.github.com/users/jcbrinfo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbrinfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbrinfo/subscriptions","organizations_url":"https://api.github.com/users/jcbrinfo/orgs","repos_url":"https://api.github.com/users/jcbrinfo/repos","events_url":"https://api.github.com/users/jcbrinfo/events{/privacy}","received_events_url":"https://api.github.com/users/jcbrinfo/received_events","type":"User","site_admin":false},"body":"Do some steps toward standardization of makefiles. Also make easier to build Nit tools individually and to remove generated files (and only them).\r\n\r\nSee also the documentation mentioned by the commits.","created_at":"2016-06-24T03:31:12Z","updated_at":"2016-06-27T15:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8423f438eb76d23c80c55e6c8a57f0052889f1dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nitlang/nit/pulls/2201/commits","review_comments_url":"https://api.github.com/repos/nitlang/nit/pulls/2201/comments","review_comment_url":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nitlang/nit/issues/2201/comments","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/8a697bdc65c343be526378ef5cb88ce3f8bf398b","head":{"label":"jcbrinfo:fix-makefiles","ref":"fix-makefiles","sha":"8a697bdc65c343be526378ef5cb88ce3f8bf398b","user":{"login":"jcbrinfo","id":6044484,"avatar_url":"https://avatars.githubusercontent.com/u/6044484?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbrinfo","html_url":"https://github.com/jcbrinfo","followers_url":"https://api.github.com/users/jcbrinfo/followers","following_url":"https://api.github.com/users/jcbrinfo/following{/other_user}","gists_url":"https://api.github.com/users/jcbrinfo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbrinfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbrinfo/subscriptions","organizations_url":"https://api.github.com/users/jcbrinfo/orgs","repos_url":"https://api.github.com/users/jcbrinfo/repos","events_url":"https://api.github.com/users/jcbrinfo/events{/privacy}","received_events_url":"https://api.github.com/users/jcbrinfo/received_events","type":"User","site_admin":false},"repo":{"id":23591816,"name":"nit","full_name":"jcbrinfo/nit","owner":{"login":"jcbrinfo","id":6044484,"avatar_url":"https://avatars.githubusercontent.com/u/6044484?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbrinfo","html_url":"https://github.com/jcbrinfo","followers_url":"https://api.github.com/users/jcbrinfo/followers","following_url":"https://api.github.com/users/jcbrinfo/following{/other_user}","gists_url":"https://api.github.com/users/jcbrinfo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbrinfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbrinfo/subscriptions","organizations_url":"https://api.github.com/users/jcbrinfo/orgs","repos_url":"https://api.github.com/users/jcbrinfo/repos","events_url":"https://api.github.com/users/jcbrinfo/events{/privacy}","received_events_url":"https://api.github.com/users/jcbrinfo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcbrinfo/nit","description":"Nit language","fork":true,"url":"https://api.github.com/repos/jcbrinfo/nit","forks_url":"https://api.github.com/repos/jcbrinfo/nit/forks","keys_url":"https://api.github.com/repos/jcbrinfo/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcbrinfo/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcbrinfo/nit/teams","hooks_url":"https://api.github.com/repos/jcbrinfo/nit/hooks","issue_events_url":"https://api.github.com/repos/jcbrinfo/nit/issues/events{/number}","events_url":"https://api.github.com/repos/jcbrinfo/nit/events","assignees_url":"https://api.github.com/repos/jcbrinfo/nit/assignees{/user}","branches_url":"https://api.github.com/repos/jcbrinfo/nit/branches{/branch}","tags_url":"https://api.github.com/repos/jcbrinfo/nit/tags","blobs_url":"https://api.github.com/repos/jcbrinfo/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcbrinfo/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcbrinfo/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcbrinfo/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcbrinfo/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/jcbrinfo/nit/languages","stargazers_url":"https://api.github.com/repos/jcbrinfo/nit/stargazers","contributors_url":"https://api.github.com/repos/jcbrinfo/nit/contributors","subscribers_url":"https://api.github.com/repos/jcbrinfo/nit/subscribers","subscription_url":"https://api.github.com/repos/jcbrinfo/nit/subscription","commits_url":"https://api.github.com/repos/jcbrinfo/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcbrinfo/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcbrinfo/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcbrinfo/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcbrinfo/nit/contents/{+path}","compare_url":"https://api.github.com/repos/jcbrinfo/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcbrinfo/nit/merges","archive_url":"https://api.github.com/repos/jcbrinfo/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcbrinfo/nit/downloads","issues_url":"https://api.github.com/repos/jcbrinfo/nit/issues{/number}","pulls_url":"https://api.github.com/repos/jcbrinfo/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/jcbrinfo/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/jcbrinfo/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcbrinfo/nit/labels{/name}","releases_url":"https://api.github.com/repos/jcbrinfo/nit/releases{/id}","deployments_url":"https://api.github.com/repos/jcbrinfo/nit/deployments","created_at":"2014-09-02T19:09:13Z","updated_at":"2016-05-23T21:19:24Z","pushed_at":"2016-06-27T15:11:01Z","git_url":"git://github.com/jcbrinfo/nit.git","ssh_url":"git@github.com:jcbrinfo/nit.git","clone_url":"https://github.com/jcbrinfo/nit.git","svn_url":"https://github.com/jcbrinfo/nit","homepage":"http://nitlanguage.org","size":113127,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nitlang:master","ref":"master","sha":"0bd93de684a38b2fb3c2269e885726d9618f5d65","user":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars.githubusercontent.com/u/5420298?v=3","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"repo":{"id":328597,"name":"nit","full_name":"nitlang/nit","owner":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars.githubusercontent.com/u/5420298?v=3","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nitlang/nit","description":"Nit language","fork":false,"url":"https://api.github.com/repos/nitlang/nit","forks_url":"https://api.github.com/repos/nitlang/nit/forks","keys_url":"https://api.github.com/repos/nitlang/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitlang/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitlang/nit/teams","hooks_url":"https://api.github.com/repos/nitlang/nit/hooks","issue_events_url":"https://api.github.com/repos/nitlang/nit/issues/events{/number}","events_url":"https://api.github.com/repos/nitlang/nit/events","assignees_url":"https://api.github.com/repos/nitlang/nit/assignees{/user}","branches_url":"https://api.github.com/repos/nitlang/nit/branches{/branch}","tags_url":"https://api.github.com/repos/nitlang/nit/tags","blobs_url":"https://api.github.com/repos/nitlang/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitlang/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitlang/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitlang/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/nitlang/nit/languages","stargazers_url":"https://api.github.com/repos/nitlang/nit/stargazers","contributors_url":"https://api.github.com/repos/nitlang/nit/contributors","subscribers_url":"https://api.github.com/repos/nitlang/nit/subscribers","subscription_url":"https://api.github.com/repos/nitlang/nit/subscription","commits_url":"https://api.github.com/repos/nitlang/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitlang/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitlang/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitlang/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitlang/nit/contents/{+path}","compare_url":"https://api.github.com/repos/nitlang/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitlang/nit/merges","archive_url":"https://api.github.com/repos/nitlang/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitlang/nit/downloads","issues_url":"https://api.github.com/repos/nitlang/nit/issues{/number}","pulls_url":"https://api.github.com/repos/nitlang/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/nitlang/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/nitlang/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitlang/nit/labels{/name}","releases_url":"https://api.github.com/repos/nitlang/nit/releases{/id}","deployments_url":"https://api.github.com/repos/nitlang/nit/deployments","created_at":"2009-10-06T15:03:00Z","updated_at":"2016-06-27T13:22:50Z","pushed_at":"2016-06-27T15:48:59Z","git_url":"git://github.com/nitlang/nit.git","ssh_url":"git@github.com:nitlang/nit.git","clone_url":"https://github.com/nitlang/nit.git","svn_url":"https://github.com/nitlang/nit","homepage":"http://nitlanguage.org","size":133064,"stargazers_count":145,"watchers_count":145,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":152,"forks":52,"open_issues":152,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2201"},"html":{"href":"https://github.com/nitlang/nit/pull/2201"},"issue":{"href":"https://api.github.com/repos/nitlang/nit/issues/2201"},"comments":{"href":"https://api.github.com/repos/nitlang/nit/issues/2201/comments"},"review_comments":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2201/comments"},"review_comment":{"href":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2201/commits"},"statuses":{"href":"https://api.github.com/repos/nitlang/nit/statuses/8a697bdc65c343be526378ef5cb88ce3f8bf398b"}}}}
{"actor":{"display_login":"xymus"}}