{"action":"closed","number":24808,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808","id":67923768,"html_url":"https://github.com/kubernetes/kubernetes/pull/24808","diff_url":"https://github.com/kubernetes/kubernetes/pull/24808.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/24808.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24808","number":24808,"state":"closed","locked":false,"title":"read gluster log to surface glusterfs plugin errors properly in describe events","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"body":"glusterfs.go does not properly expose errors as all mount errors go to a log file, I propose we read the log file to expose the errors without asking the users to 'go look at this log'\r\n\r\nThis PR does the following:\r\n1.  adds a gluster option for log-level=ERROR to remove all noise from log file\r\n2.  change log file name and path based on PV + Pod name - so specific per PV and Pod\r\n3.  create a utility to read the last two lines of the log file when failure occurs\r\n\r\nold behavior:\r\n```\r\n  13s\t13s\t1\t{kubelet 127.0.0.1}\t\tWarning\tFailedMount\tUnable to mount volumes for pod \"bb-gluster-pod2_default(34b18c6b-070d-11e6-8e95-52540092b5fb)\": glusterfs: mount failed: Mount failed: exit status 1\r\nMounting arguments: 192.168.234.147:myVol2 /var/lib/kubelet/pods/34b18c6b-070d-11e6-8e95-52540092b5fb/volumes/kubernetes.io~glusterfs/pv-gluster glusterfs [log-file=/var/lib/kubelet/plugins/kubernetes.io/glusterfs/pv-gluster/glusterfs.log]\r\nOutput: Mount failed. Please check the log file for more details.\r\n```\r\n\r\nimproved behavior: (updated after suggestions from community)\r\n```\r\n  34m\t\t34m\t\t1\t{kubelet 127.0.0.1}\t\t\tWarning\t\tFailedMount\tUnable to mount volumes for pod \"bb-multi-pod1_default(e7d7f790-0d4b-11e6-a275-52540092b5fb)\": glusterfs: mount failed: Mount failed: exit status 1\r\nMounting arguments: 192.168.123.222:myVol2 /var/lib/kubelet/pods/e7d7f790-0d4b-11e6-a275-52540092b5fb/volumes/kubernetes.io~glusterfs/pv-gluster2 glusterfs [log-level=ERROR log-file=/var/lib/kubelet/plugins/kubernetes.io/glusterfs/pv-gluster2/bb-multi-pod1-glusterfs.log]\r\nOutput: Mount failed. Please check the log file for more details.\r\n\r\n the following error information was pulled from the log to help resolve this issue: \r\n[2016-04-28 14:21:29.109697] E [socket.c:2332:socket_connect_finish] 0-glusterfs: connection to 192.168.123.222:24007 failed (Connection timed out)\r\n[2016-04-28 14:21:29.109767] E [glusterfsd-mgmt.c:1819:mgmt_rpc_notify] 0-glusterfsd-mgmt: failed to connect with remote-host: 192.168.123.222 (Transport endpoint is not connected)\r\n\r\n```\r\n\r\nalso this PR is alternate approach to :  #24624 \r\n\r\n\r\n","created_at":"2016-04-26T17:14:41Z","updated_at":"2016-06-02T20:42:54Z","closed_at":"2016-06-02T20:42:54Z","merged_at":"2016-06-02T20:42:54Z","merge_commit_sha":"0b7f8e5b743430116d0ce8581e3a283fbb8c19d6","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":163,"closed_issues":414,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-02T20:42:54Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24808/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a36cd3d55b8a6ccb2c5ec5224fd3985f30fda259","head":{"label":"screeley44:gluster_errors","ref":"gluster_errors","sha":"a36cd3d55b8a6ccb2c5ec5224fd3985f30fda259","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"repo":{"id":31073694,"name":"kubernetes","full_name":"screeley44/kubernetes","owner":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/screeley44/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/screeley44/kubernetes","forks_url":"https://api.github.com/repos/screeley44/kubernetes/forks","keys_url":"https://api.github.com/repos/screeley44/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screeley44/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screeley44/kubernetes/teams","hooks_url":"https://api.github.com/repos/screeley44/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/screeley44/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/screeley44/kubernetes/events","assignees_url":"https://api.github.com/repos/screeley44/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/screeley44/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/screeley44/kubernetes/tags","blobs_url":"https://api.github.com/repos/screeley44/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screeley44/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screeley44/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/screeley44/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screeley44/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/screeley44/kubernetes/languages","stargazers_url":"https://api.github.com/repos/screeley44/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/screeley44/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/screeley44/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/screeley44/kubernetes/subscription","commits_url":"https://api.github.com/repos/screeley44/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/screeley44/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/screeley44/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/screeley44/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/screeley44/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/screeley44/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screeley44/kubernetes/merges","archive_url":"https://api.github.com/repos/screeley44/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screeley44/kubernetes/downloads","issues_url":"https://api.github.com/repos/screeley44/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/screeley44/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/screeley44/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/screeley44/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screeley44/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/screeley44/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/screeley44/kubernetes/deployments","created_at":"2015-02-20T16:34:03Z","updated_at":"2016-03-14T18:36:58Z","pushed_at":"2016-06-02T13:09:39Z","git_url":"git://github.com/screeley44/kubernetes.git","ssh_url":"git@github.com:screeley44/kubernetes.git","clone_url":"https://github.com/screeley44/kubernetes.git","svn_url":"https://github.com/screeley44/kubernetes","homepage":"http://kubernetes.io","size":239888,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1288106608e06bc55573c6a8fabbe33eb501bd01","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-02T19:37:10Z","pushed_at":"2016-06-02T20:42:54Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":451312,"stargazers_count":14724,"watchers_count":14724,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4515,"mirror_url":null,"open_issues_count":3686,"forks":4515,"open_issues":3686,"watchers":14724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24808"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24808"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24808/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24808/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a36cd3d55b8a6ccb2c5ec5224fd3985f30fda259"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":28,"review_comments":30,"commits":1,"additions":87,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"k8s-merge-robot"}}