{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2952","repository_url":"https://api.github.com/repos/DataDog/dd-agent","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2952/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2952/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2952/events","html_url":"https://github.com/DataDog/dd-agent/pull/2952","id":185005880,"number":2952,"title":"[mongo] Add metrics for fsyncLocked-ness, replset votes and vote fraction","user":{"login":"ebroder","id":28167,"avatar_url":"https://avatars.githubusercontent.com/u/28167?v=3","gravatar_id":"","url":"https://api.github.com/users/ebroder","html_url":"https://github.com/ebroder","followers_url":"https://api.github.com/users/ebroder/followers","following_url":"https://api.github.com/users/ebroder/following{/other_user}","gists_url":"https://api.github.com/users/ebroder/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroder/subscriptions","organizations_url":"https://api.github.com/users/ebroder/orgs","repos_url":"https://api.github.com/users/ebroder/repos","events_url":"https://api.github.com/users/ebroder/events{/privacy}","received_events_url":"https://api.github.com/users/ebroder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/74","html_url":"https://github.com/DataDog/dd-agent/milestones/5.10.0","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/74/labels","id":1912359,"number":74,"title":"5.10.0","description":"","creator":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":55,"state":"open","created_at":"2016-07-29T18:06:01Z","updated_at":"2016-10-30T18:11:42Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-10-25T02:52:38Z","updated_at":"2016-10-30T18:11:42Z","closed_at":"2016-10-30T18:11:42Z","pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2952","html_url":"https://github.com/DataDog/dd-agent/pull/2952","diff_url":"https://github.com/DataDog/dd-agent/pull/2952.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2952.patch"},"body":"### What does this PR do?\r\n\r\nThis introduces 3 new metrics:\r\n - fsyncLocked: which is 1 if the mongod is fsynclocked and 0 if not\r\n - replSet.votes: which is the number of votes assigned to a node (on 2.6 or newer this will always be 0 or 1)\r\n - replSet.voteFraction: the fraction of votes in the replset assigned to this node\r\n\r\n### Motivation\r\n\r\nThese metrics are part of our monitoring for mongo node health. We alert on nodes being fsyncLocked for an extended period of time (since it usually indicates forgotten maintenance), and on voteFraction-grouped-by-AZ being > 0.5, since that indicates that loss of an AZ would break quorum."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/257167822","html_url":"https://github.com/DataDog/dd-agent/pull/2952#issuecomment-257167822","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2952","id":257167822,"user":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T18:11:42Z","updated_at":"2016-10-30T18:11:42Z","body":"Thanks @ebroder ! \r\n\r\nI moved the MongoDB `fsyncLock` metric test to the `AgentCheckTest` class suite, and opened a new PR with your change: #2975. Let's move to this thread."}}
{"actor":{"display_login":"yannmh"}}