{"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments/76850973","id":76850973,"diff_hunk":"@@ -0,0 +1,48 @@\n+package org.sagebionetworks.bridge.models.surveys;\n+\n+import static org.junit.Assert.assertEquals;\n+import static org.junit.Assert.assertNotNull;\n+import static org.junit.Assert.assertTrue;\n+\n+import nl.jqno.equalsverifier.EqualsVerifier;\n+import org.junit.Test;\n+\n+public class SurveyQuestionOptionTest {\n+    private static final Image DUMMY_IMAGE = new Image(\"dummy-source\", 42, 42);\n+\n+    @Test\n+    public void allValues() {\n+        SurveyQuestionOption option = new SurveyQuestionOption(\"test-label\", \"test-detail\", \"test-value\", DUMMY_IMAGE);\n+        assertEquals(\"test-label\", option.getLabel());\n+        assertEquals(\"test-detail\", option.getDetail());\n+        assertEquals(\"test-value\", option.getValue());\n+        assertEquals(DUMMY_IMAGE, option.getImage());\n+\n+        String optionString = option.toString();\n+        assertTrue(optionString.contains(option.getLabel()));\n+        assertTrue(optionString.contains(option.getDetail()));\n+        assertTrue(optionString.contains(option.getValue()));\n+        assertTrue(optionString.contains(option.getImage().toString()));\n+    }","path":"test/org/sagebionetworks/bridge/models/surveys/SurveyQuestionOptionTest.java","position":26,"original_position":26,"commit_id":"c5302305c9353275dc6fa42a14e2601118f20a78","original_commit_id":"c5302305c9353275dc6fa42a14e2601118f20a78","user":{"login":"alxdarksage","id":5589085,"avatar_url":"https://avatars.githubusercontent.com/u/5589085?v=3","gravatar_id":"","url":"https://api.github.com/users/alxdarksage","html_url":"https://github.com/alxdarksage","followers_url":"https://api.github.com/users/alxdarksage/followers","following_url":"https://api.github.com/users/alxdarksage/following{/other_user}","gists_url":"https://api.github.com/users/alxdarksage/gists{/gist_id}","starred_url":"https://api.github.com/users/alxdarksage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxdarksage/subscriptions","organizations_url":"https://api.github.com/users/alxdarksage/orgs","repos_url":"https://api.github.com/users/alxdarksage/repos","events_url":"https://api.github.com/users/alxdarksage/events{/privacy}","received_events_url":"https://api.github.com/users/alxdarksage/received_events","type":"User","site_admin":false},"body":"test of SurveyQuestionOption(String label) constructor?","created_at":"2016-08-30T18:21:54Z","updated_at":"2016-08-30T18:21:54Z","html_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236#discussion_r76850973","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments/76850973"},"html":{"href":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236#discussion_r76850973"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236"}}},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236","id":83187698,"html_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236","diff_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236.diff","patch_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1236","number":1236,"state":"open","locked":false,"title":"Integrate Surveys with Mutable Schemas; relax rules for Mutable Schemas","user":{"login":"DwayneJengSage","id":9541190,"avatar_url":"https://avatars.githubusercontent.com/u/9541190?v=3","gravatar_id":"","url":"https://api.github.com/users/DwayneJengSage","html_url":"https://github.com/DwayneJengSage","followers_url":"https://api.github.com/users/DwayneJengSage/followers","following_url":"https://api.github.com/users/DwayneJengSage/following{/other_user}","gists_url":"https://api.github.com/users/DwayneJengSage/gists{/gist_id}","starred_url":"https://api.github.com/users/DwayneJengSage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DwayneJengSage/subscriptions","organizations_url":"https://api.github.com/users/DwayneJengSage/orgs","repos_url":"https://api.github.com/users/DwayneJengSage/repos","events_url":"https://api.github.com/users/DwayneJengSage/events{/privacy}","received_events_url":"https://api.github.com/users/DwayneJengSage/received_events","type":"User","site_admin":false},"body":"Last code change needed to finish off https://sagebionetworks.jira.com/browse/BRIDGE-1289\r\n\r\nThis change integrate surveys with mutable schemas. We also relax some of the rules for mutable schemas to make them easier to work with.\r\n\r\nTesting done:\r\n* unit tests updated\r\n* integ tests (survey, upload schema, upload)\r\n* manual tests\r\n\r\nManual test cases:\r\n* create a new survey schema\r\n* compatible update to survey schema\r\n* incompatible update to survey schema\r\n* explicitly ask for a new schema rev for a survey schema\r\n* attempt to modify a schema field with an incompatible change\r\n* successfully modify a schema field with a compatible change\r\n* attempt to add a required field without minAppVersion to a schema\r\n* successfully add a required field with minAppVersion to a schema\r\n\r\nNote: https://github.com/Sage-Bionetworks/BridgeIntegrationTests/pull/76 needs to be pushed out before we can check this in.\r\n\r\nTODO: Additional integ tests to test the updated functionality.","created_at":"2016-08-29T23:55:37Z","updated_at":"2016-08-30T18:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1376d103106b7a6597e3394dea30ec2d7bf40bbf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1236/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/c5302305c9353275dc6fa42a14e2601118f20a78","head":{"label":"DwayneJengSage:dev-djeng2","ref":"dev-djeng2","sha":"c5302305c9353275dc6fa42a14e2601118f20a78","user":{"login":"DwayneJengSage","id":9541190,"avatar_url":"https://avatars.githubusercontent.com/u/9541190?v=3","gravatar_id":"","url":"https://api.github.com/users/DwayneJengSage","html_url":"https://github.com/DwayneJengSage","followers_url":"https://api.github.com/users/DwayneJengSage/followers","following_url":"https://api.github.com/users/DwayneJengSage/following{/other_user}","gists_url":"https://api.github.com/users/DwayneJengSage/gists{/gist_id}","starred_url":"https://api.github.com/users/DwayneJengSage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DwayneJengSage/subscriptions","organizations_url":"https://api.github.com/users/DwayneJengSage/orgs","repos_url":"https://api.github.com/users/DwayneJengSage/repos","events_url":"https://api.github.com/users/DwayneJengSage/events{/privacy}","received_events_url":"https://api.github.com/users/DwayneJengSage/received_events","type":"User","site_admin":false},"repo":{"id":26144291,"name":"BridgePF","full_name":"DwayneJengSage/BridgePF","owner":{"login":"DwayneJengSage","id":9541190,"avatar_url":"https://avatars.githubusercontent.com/u/9541190?v=3","gravatar_id":"","url":"https://api.github.com/users/DwayneJengSage","html_url":"https://github.com/DwayneJengSage","followers_url":"https://api.github.com/users/DwayneJengSage/followers","following_url":"https://api.github.com/users/DwayneJengSage/following{/other_user}","gists_url":"https://api.github.com/users/DwayneJengSage/gists{/gist_id}","starred_url":"https://api.github.com/users/DwayneJengSage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DwayneJengSage/subscriptions","organizations_url":"https://api.github.com/users/DwayneJengSage/orgs","repos_url":"https://api.github.com/users/DwayneJengSage/repos","events_url":"https://api.github.com/users/DwayneJengSage/events{/privacy}","received_events_url":"https://api.github.com/users/DwayneJengSage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DwayneJengSage/BridgePF","description":"","fork":true,"url":"https://api.github.com/repos/DwayneJengSage/BridgePF","forks_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/forks","keys_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/teams","hooks_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/hooks","issue_events_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/issues/events{/number}","events_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/events","assignees_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/assignees{/user}","branches_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/branches{/branch}","tags_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/tags","blobs_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/git/refs{/sha}","trees_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/statuses/{sha}","languages_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/languages","stargazers_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/stargazers","contributors_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/contributors","subscribers_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/subscribers","subscription_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/subscription","commits_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/commits{/sha}","git_commits_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/git/commits{/sha}","comments_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/comments{/number}","issue_comment_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/issues/comments{/number}","contents_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/contents/{+path}","compare_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/merges","archive_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/downloads","issues_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/issues{/number}","pulls_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/pulls{/number}","milestones_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/milestones{/number}","notifications_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/labels{/name}","releases_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/releases{/id}","deployments_url":"https://api.github.com/repos/DwayneJengSage/BridgePF/deployments","created_at":"2014-11-03T23:44:49Z","updated_at":"2016-01-14T07:05:20Z","pushed_at":"2016-08-27T01:17:00Z","git_url":"git://github.com/DwayneJengSage/BridgePF.git","ssh_url":"git@github.com:DwayneJengSage/BridgePF.git","clone_url":"https://github.com/DwayneJengSage/BridgePF.git","svn_url":"https://github.com/DwayneJengSage/BridgePF","homepage":null,"size":75150,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev-djeng2"}},"base":{"label":"Sage-Bionetworks:develop","ref":"develop","sha":"416d59b116d14f4c7d65cb642bb9658a63ebece3","user":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":18604783,"name":"BridgePF","full_name":"Sage-Bionetworks/BridgePF","owner":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/BridgePF","description":"Server software for Bridge-based mobile applications","fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF","forks_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/deployments","created_at":"2014-04-09T16:38:46Z","updated_at":"2016-05-02T21:48:35Z","pushed_at":"2016-08-29T23:55:37Z","git_url":"git://github.com/Sage-Bionetworks/BridgePF.git","ssh_url":"git@github.com:Sage-Bionetworks/BridgePF.git","clone_url":"https://github.com/Sage-Bionetworks/BridgePF.git","svn_url":"https://github.com/Sage-Bionetworks/BridgePF","homepage":"","size":75868,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236"},"html":{"href":"https://github.com/Sage-Bionetworks/BridgePF/pull/1236"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1236"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1236/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1236/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/c5302305c9353275dc6fa42a14e2601118f20a78"}}}}
{"actor":{"display_login":"alxdarksage"}}