{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/63324519","id":63324519,"diff_hunk":"@@ -445,7 +447,9 @@ def copy(self, extra=None):\n         \"\"\"\n         if extra is None:\n             extra = dict()\n-        return TrainValidationSplitModel(self.bestModel.copy(extra))\n+        bestModel = self.bestModel.copy(extra)\n+        validationMetrics = list(self.validationMetrics)","path":"python/pyspark/ml/tuning.py","position":38,"original_position":38,"commit_id":"8c28f3ccc3dd315a0b01b5be8ff40fb8f8ac1782","original_commit_id":"2948eb0ab45ea03324075d6a351c18deca7e411c","user":{"login":"holdenk","id":59893,"avatar_url":"https://avatars.githubusercontent.com/u/59893?v=3","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"body":"So this is a shallow copy rather than a deep copy - its probably OK since we aren't explicit in the docstring but maybe we should be explicit in the docstring that we make a shallow copy of the validation metrics since we are explicit about the other parts of the copy in the docstring?","created_at":"2016-05-16T08:44:15Z","updated_at":"2016-05-16T08:44:15Z","html_url":"https://github.com/apache/spark/pull/12767#discussion_r63324519","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12767","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/63324519"},"html":{"href":"https://github.com/apache/spark/pull/12767#discussion_r63324519"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12767"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12767","id":68294574,"html_url":"https://github.com/apache/spark/pull/12767","diff_url":"https://github.com/apache/spark/pull/12767.diff","patch_url":"https://github.com/apache/spark/pull/12767.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12767","number":12767,"state":"open","locked":false,"title":"[SPARK-14978][PySpark] PySpark TrainValidationSplitModel should support validationMetrics","user":{"login":"taku-k","id":7335200,"avatar_url":"https://avatars.githubusercontent.com/u/7335200?v=3","gravatar_id":"","url":"https://api.github.com/users/taku-k","html_url":"https://github.com/taku-k","followers_url":"https://api.github.com/users/taku-k/followers","following_url":"https://api.github.com/users/taku-k/following{/other_user}","gists_url":"https://api.github.com/users/taku-k/gists{/gist_id}","starred_url":"https://api.github.com/users/taku-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taku-k/subscriptions","organizations_url":"https://api.github.com/users/taku-k/orgs","repos_url":"https://api.github.com/users/taku-k/repos","events_url":"https://api.github.com/users/taku-k/events{/privacy}","received_events_url":"https://api.github.com/users/taku-k/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis pull request includes supporting validationMetrics for TrainValidationSplitModel with Python and test for it.\r\n\r\n## How was this patch tested?\r\n\r\ntest in `python/pyspark/ml/tests.py`\r\n\r\n\r\n","created_at":"2016-04-28T21:35:14Z","updated_at":"2016-05-16T08:44:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbdd46b25c2fa8bdc30825edf5804e6f41ac5a5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12767/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12767/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12767/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8c28f3ccc3dd315a0b01b5be8ff40fb8f8ac1782","head":{"label":"taku-k:spark-14978","ref":"spark-14978","sha":"8c28f3ccc3dd315a0b01b5be8ff40fb8f8ac1782","user":{"login":"taku-k","id":7335200,"avatar_url":"https://avatars.githubusercontent.com/u/7335200?v=3","gravatar_id":"","url":"https://api.github.com/users/taku-k","html_url":"https://github.com/taku-k","followers_url":"https://api.github.com/users/taku-k/followers","following_url":"https://api.github.com/users/taku-k/following{/other_user}","gists_url":"https://api.github.com/users/taku-k/gists{/gist_id}","starred_url":"https://api.github.com/users/taku-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taku-k/subscriptions","organizations_url":"https://api.github.com/users/taku-k/orgs","repos_url":"https://api.github.com/users/taku-k/repos","events_url":"https://api.github.com/users/taku-k/events{/privacy}","received_events_url":"https://api.github.com/users/taku-k/received_events","type":"User","site_admin":false},"repo":{"id":57326267,"name":"spark","full_name":"taku-k/spark","owner":{"login":"taku-k","id":7335200,"avatar_url":"https://avatars.githubusercontent.com/u/7335200?v=3","gravatar_id":"","url":"https://api.github.com/users/taku-k","html_url":"https://github.com/taku-k","followers_url":"https://api.github.com/users/taku-k/followers","following_url":"https://api.github.com/users/taku-k/following{/other_user}","gists_url":"https://api.github.com/users/taku-k/gists{/gist_id}","starred_url":"https://api.github.com/users/taku-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taku-k/subscriptions","organizations_url":"https://api.github.com/users/taku-k/orgs","repos_url":"https://api.github.com/users/taku-k/repos","events_url":"https://api.github.com/users/taku-k/events{/privacy}","received_events_url":"https://api.github.com/users/taku-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taku-k/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/taku-k/spark","forks_url":"https://api.github.com/repos/taku-k/spark/forks","keys_url":"https://api.github.com/repos/taku-k/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taku-k/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taku-k/spark/teams","hooks_url":"https://api.github.com/repos/taku-k/spark/hooks","issue_events_url":"https://api.github.com/repos/taku-k/spark/issues/events{/number}","events_url":"https://api.github.com/repos/taku-k/spark/events","assignees_url":"https://api.github.com/repos/taku-k/spark/assignees{/user}","branches_url":"https://api.github.com/repos/taku-k/spark/branches{/branch}","tags_url":"https://api.github.com/repos/taku-k/spark/tags","blobs_url":"https://api.github.com/repos/taku-k/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taku-k/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taku-k/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/taku-k/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taku-k/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/taku-k/spark/languages","stargazers_url":"https://api.github.com/repos/taku-k/spark/stargazers","contributors_url":"https://api.github.com/repos/taku-k/spark/contributors","subscribers_url":"https://api.github.com/repos/taku-k/spark/subscribers","subscription_url":"https://api.github.com/repos/taku-k/spark/subscription","commits_url":"https://api.github.com/repos/taku-k/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/taku-k/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/taku-k/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/taku-k/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/taku-k/spark/contents/{+path}","compare_url":"https://api.github.com/repos/taku-k/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taku-k/spark/merges","archive_url":"https://api.github.com/repos/taku-k/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taku-k/spark/downloads","issues_url":"https://api.github.com/repos/taku-k/spark/issues{/number}","pulls_url":"https://api.github.com/repos/taku-k/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/taku-k/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/taku-k/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taku-k/spark/labels{/name}","releases_url":"https://api.github.com/repos/taku-k/spark/releases{/id}","deployments_url":"https://api.github.com/repos/taku-k/spark/deployments","created_at":"2016-04-28T18:52:32Z","updated_at":"2016-04-28T18:52:53Z","pushed_at":"2016-05-16T08:41:24Z","git_url":"git://github.com/taku-k/spark.git","ssh_url":"git@github.com:taku-k/spark.git","clone_url":"https://github.com/taku-k/spark.git","svn_url":"https://github.com/taku-k/spark","homepage":null,"size":179315,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f116a84ef8bf8a201c1a67154fda6990e4222074","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-05-16T04:50:38Z","pushed_at":"2016-05-16T08:39:46Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":492202,"stargazers_count":8523,"watchers_count":8523,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7919,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":416,"forks":7919,"open_issues":416,"watchers":8523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12767"},"html":{"href":"https://github.com/apache/spark/pull/12767"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12767"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12767/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12767/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12767/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8c28f3ccc3dd315a0b01b5be8ff40fb8f8ac1782"}}}}