{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/54017357","id":54017357,"diff_hunk":"@@ -152,7 +164,17 @@ private[yarn] class YarnAllocator(\n \n   def getNumExecutorsRunning: Int = numExecutorsRunning\n \n-  def getNumExecutorsFailed: Int = numExecutorsFailed\n+  def getNumExecutorsFailed: Int = synchronized {","path":"yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala","position":44,"original_position":44,"commit_id":"3ecae071f23651bab71fb5e292b7e3653cba66e1","original_commit_id":"3ecae071f23651bab71fb5e292b7e3653cba66e1","user":{"login":"tgravescs","id":4563792,"avatar_url":"https://avatars.githubusercontent.com/u/4563792?v=3","gravatar_id":"","url":"https://api.github.com/users/tgravescs","html_url":"https://github.com/tgravescs","followers_url":"https://api.github.com/users/tgravescs/followers","following_url":"https://api.github.com/users/tgravescs/following{/other_user}","gists_url":"https://api.github.com/users/tgravescs/gists{/gist_id}","starred_url":"https://api.github.com/users/tgravescs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgravescs/subscriptions","organizations_url":"https://api.github.com/users/tgravescs/orgs","repos_url":"https://api.github.com/users/tgravescs/repos","events_url":"https://api.github.com/users/tgravescs/events{/privacy}","received_events_url":"https://api.github.com/users/tgravescs/received_events","type":"User","site_admin":false},"body":"oh nevermind, I see the only place the enqueue is called is eventually called synchronized in allocateResources. ","created_at":"2016-02-24T22:22:58Z","updated_at":"2016-02-24T22:22:58Z","html_url":"https://github.com/apache/spark/pull/10241#discussion_r54017357","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/10241","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/54017357"},"html":{"href":"https://github.com/apache/spark/pull/10241#discussion_r54017357"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/10241"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/10241","id":53209885,"html_url":"https://github.com/apache/spark/pull/10241","diff_url":"https://github.com/apache/spark/pull/10241.diff","patch_url":"https://github.com/apache/spark/pull/10241.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/10241","number":10241,"state":"open","locked":false,"title":"[SPARK-6735][YARN] Add window based executor failure tracking mechanism for long running service","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"body":"This work is based on @twinkle-sachdeva 's proposal. In parallel to such mechanism for AM failures, here add similar mechanism for executor failure tracking, this is useful for long running Spark service to mitigate the executor failure problems.\r\n\r\nPlease help to review, @tgravescs @sryza and @vanzin ","created_at":"2015-12-10T03:00:10Z","updated_at":"2016-02-24T22:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"803e3b2d11971027f34a3b43a16f8cbe9b42a002","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/10241/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/10241/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/10241/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/3ecae071f23651bab71fb5e292b7e3653cba66e1","head":{"label":"jerryshao:SPARK-6735","ref":"SPARK-6735","sha":"3ecae071f23651bab71fb5e292b7e3653cba66e1","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"repo":{"id":18259371,"name":"apache-spark","full_name":"jerryshao/apache-spark","owner":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryshao/apache-spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/jerryshao/apache-spark","forks_url":"https://api.github.com/repos/jerryshao/apache-spark/forks","keys_url":"https://api.github.com/repos/jerryshao/apache-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryshao/apache-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryshao/apache-spark/teams","hooks_url":"https://api.github.com/repos/jerryshao/apache-spark/hooks","issue_events_url":"https://api.github.com/repos/jerryshao/apache-spark/issues/events{/number}","events_url":"https://api.github.com/repos/jerryshao/apache-spark/events","assignees_url":"https://api.github.com/repos/jerryshao/apache-spark/assignees{/user}","branches_url":"https://api.github.com/repos/jerryshao/apache-spark/branches{/branch}","tags_url":"https://api.github.com/repos/jerryshao/apache-spark/tags","blobs_url":"https://api.github.com/repos/jerryshao/apache-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryshao/apache-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryshao/apache-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryshao/apache-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryshao/apache-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryshao/apache-spark/languages","stargazers_url":"https://api.github.com/repos/jerryshao/apache-spark/stargazers","contributors_url":"https://api.github.com/repos/jerryshao/apache-spark/contributors","subscribers_url":"https://api.github.com/repos/jerryshao/apache-spark/subscribers","subscription_url":"https://api.github.com/repos/jerryshao/apache-spark/subscription","commits_url":"https://api.github.com/repos/jerryshao/apache-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryshao/apache-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryshao/apache-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryshao/apache-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryshao/apache-spark/contents/{+path}","compare_url":"https://api.github.com/repos/jerryshao/apache-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryshao/apache-spark/merges","archive_url":"https://api.github.com/repos/jerryshao/apache-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryshao/apache-spark/downloads","issues_url":"https://api.github.com/repos/jerryshao/apache-spark/issues{/number}","pulls_url":"https://api.github.com/repos/jerryshao/apache-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryshao/apache-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryshao/apache-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryshao/apache-spark/labels{/name}","releases_url":"https://api.github.com/repos/jerryshao/apache-spark/releases{/id}","deployments_url":"https://api.github.com/repos/jerryshao/apache-spark/deployments","created_at":"2014-03-30T07:04:45Z","updated_at":"2014-07-09T01:42:23Z","pushed_at":"2016-02-23T05:29:59Z","git_url":"git://github.com/jerryshao/apache-spark.git","ssh_url":"git@github.com:jerryshao/apache-spark.git","clone_url":"https://github.com/jerryshao/apache-spark.git","svn_url":"https://github.com/jerryshao/apache-spark","homepage":null,"size":149196,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2166c2a75083c2262e071a652dd52b1a33348b6e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-02-24T22:05:31Z","pushed_at":"2016-02-24T22:21:03Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":437848,"stargazers_count":7551,"watchers_count":7551,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6869,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":385,"forks":6869,"open_issues":385,"watchers":7551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/10241"},"html":{"href":"https://github.com/apache/spark/pull/10241"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/10241"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/10241/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/10241/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/10241/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/3ecae071f23651bab71fb5e292b7e3653cba66e1"}}}}