{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/comments/76642890","id":76642890,"diff_hunk":"@@ -348,4 +349,19 @@ void setParent(hudson.tasks.junit.TestResult parent) {\n     private static final long serialVersionUID = 1L;\n \n     private static final Pattern SUREFIRE_FILENAME = Pattern.compile(\"TEST-(.+)\\\\.xml\");\n+\n+    /**\n+     * Merges another SuiteResult into this one.\n+     * \n+     * @param sr\n+     */\n+    public void merge(SuiteResult sr) {\n+        if (hasTimeAttr) {","path":"src/main/java/hudson/tasks/junit/SuiteResult.java","position":46,"original_position":46,"commit_id":"7f5b06d4c159061cdc1dac471646c913cb8dd77a","original_commit_id":"7f5b06d4c159061cdc1dac471646c913cb8dd77a","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Would be resolved by test cases checking\r\n\r\n```xml\r\n<testsuites name=\"Automation Tests\" tests=\"2\" errors=\"0\" failures=\"0\" ignored=\"0\">\r\n    <testsuite name=\"test.fs.FileSystemTests\">\r\n     <testcase name=\"testPrefix1\" classname=\"test.fs.FileSystemTest1\" time=\"10\"/>\r\n    </testsuite>\r\n    <testsuite name=\"test.fs.FileSystemTests\" time=\"50\">\r\n      <testcase name=\"testPrefix2\" classname=\"test.fs.FileSystemTest1\" time=\"10\"/>\r\n    </testsuite>\r\n</testsuites>\r\n```\r\n\r\nand\r\n\r\n```xml\r\n<testsuites name=\"Automation Tests\" tests=\"2\" errors=\"0\" failures=\"0\" ignored=\"0\">\r\n    <testsuite name=\"test.fs.FileSystemTests\" time=\"50\">\r\n     <testcase name=\"testPrefix1\" classname=\"test.fs.FileSystemTest1\" time=\"10\"/>\r\n    </testsuite>\r\n    <testsuite name=\"test.fs.FileSystemTests\">\r\n      <testcase name=\"testPrefix2\" classname=\"test.fs.FileSystemTest1\" time=\"10\"/>\r\n    </testsuite>\r\n</testsuites>\r\n```\r\n\r\nboth of which I would expect to report a total time of 60. (Right?)","created_at":"2016-08-29T16:52:38Z","updated_at":"2016-08-29T16:52:38Z","html_url":"https://github.com/jenkinsci/junit-plugin/pull/54#discussion_r76642890","pull_request_url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/comments/76642890"},"html":{"href":"https://github.com/jenkinsci/junit-plugin/pull/54#discussion_r76642890"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54","id":82266773,"html_url":"https://github.com/jenkinsci/junit-plugin/pull/54","diff_url":"https://github.com/jenkinsci/junit-plugin/pull/54.diff","patch_url":"https://github.com/jenkinsci/junit-plugin/pull/54.patch","issue_url":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/54","number":54,"state":"open","locked":false,"title":"[JENKINS-37598] Inaccurate aggregation of multiple xmls containing case information about the same testsuite","user":{"login":"kgyrtkirk","id":1902540,"avatar_url":"https://avatars.githubusercontent.com/u/1902540?v=3","gravatar_id":"","url":"https://api.github.com/users/kgyrtkirk","html_url":"https://github.com/kgyrtkirk","followers_url":"https://api.github.com/users/kgyrtkirk/followers","following_url":"https://api.github.com/users/kgyrtkirk/following{/other_user}","gists_url":"https://api.github.com/users/kgyrtkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/kgyrtkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgyrtkirk/subscriptions","organizations_url":"https://api.github.com/users/kgyrtkirk/orgs","repos_url":"https://api.github.com/users/kgyrtkirk/repos","events_url":"https://api.github.com/users/kgyrtkirk/events{/privacy}","received_events_url":"https://api.github.com/users/kgyrtkirk/received_events","type":"User","site_admin":false},"body":"[JENKINS-37598](https://issues.jenkins-ci.org/browse/JENKINS-37598)\r\n\r\n- [X] change logic to account for all suites involved during time aggregation in `ClassResult`\r\n- [X] moved `TestSuite` merging code from `TestResult` to `TestSuite.merge()`\r\n- [X] replaced `TestSuite.time` field with a boolean\r\n- [X] added 2 testcases - 1 with time attributes; and 1 without them...added to `TestResultTest` (because of `TestSuite.merge()` call location)","created_at":"2016-08-22T21:29:22Z","updated_at":"2016-08-29T16:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"477451c0aaeb1daf56fbe99912be0d9efb18aebf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/54/comments","statuses_url":"https://api.github.com/repos/jenkinsci/junit-plugin/statuses/7f5b06d4c159061cdc1dac471646c913cb8dd77a","head":{"label":"kgyrtkirk:JENKINS-37598","ref":"JENKINS-37598","sha":"7f5b06d4c159061cdc1dac471646c913cb8dd77a","user":{"login":"kgyrtkirk","id":1902540,"avatar_url":"https://avatars.githubusercontent.com/u/1902540?v=3","gravatar_id":"","url":"https://api.github.com/users/kgyrtkirk","html_url":"https://github.com/kgyrtkirk","followers_url":"https://api.github.com/users/kgyrtkirk/followers","following_url":"https://api.github.com/users/kgyrtkirk/following{/other_user}","gists_url":"https://api.github.com/users/kgyrtkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/kgyrtkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgyrtkirk/subscriptions","organizations_url":"https://api.github.com/users/kgyrtkirk/orgs","repos_url":"https://api.github.com/users/kgyrtkirk/repos","events_url":"https://api.github.com/users/kgyrtkirk/events{/privacy}","received_events_url":"https://api.github.com/users/kgyrtkirk/received_events","type":"User","site_admin":false},"repo":{"id":66308600,"name":"junit-plugin","full_name":"kgyrtkirk/junit-plugin","owner":{"login":"kgyrtkirk","id":1902540,"avatar_url":"https://avatars.githubusercontent.com/u/1902540?v=3","gravatar_id":"","url":"https://api.github.com/users/kgyrtkirk","html_url":"https://github.com/kgyrtkirk","followers_url":"https://api.github.com/users/kgyrtkirk/followers","following_url":"https://api.github.com/users/kgyrtkirk/following{/other_user}","gists_url":"https://api.github.com/users/kgyrtkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/kgyrtkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgyrtkirk/subscriptions","organizations_url":"https://api.github.com/users/kgyrtkirk/orgs","repos_url":"https://api.github.com/users/kgyrtkirk/repos","events_url":"https://api.github.com/users/kgyrtkirk/events{/privacy}","received_events_url":"https://api.github.com/users/kgyrtkirk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgyrtkirk/junit-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/kgyrtkirk/junit-plugin","forks_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/forks","keys_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/teams","hooks_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/hooks","issue_events_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/events","assignees_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/tags","blobs_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/languages","stargazers_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/stargazers","contributors_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/contributors","subscribers_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/subscribers","subscription_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/subscription","commits_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/merges","archive_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/downloads","issues_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/labels{/name}","releases_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/kgyrtkirk/junit-plugin/deployments","created_at":"2016-08-22T21:11:46Z","updated_at":"2016-08-22T21:11:50Z","pushed_at":"2016-08-22T21:24:33Z","git_url":"git://github.com/kgyrtkirk/junit-plugin.git","ssh_url":"git@github.com:kgyrtkirk/junit-plugin.git","clone_url":"https://github.com/kgyrtkirk/junit-plugin.git","svn_url":"https://github.com/kgyrtkirk/junit-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/JUnit+Plugin","size":1392,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8319d7e408ddb20626bdedc5e02830fda313455d","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":22840826,"name":"junit-plugin","full_name":"jenkinsci/junit-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/junit-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/junit-plugin","forks_url":"https://api.github.com/repos/jenkinsci/junit-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/junit-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/junit-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/junit-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/junit-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/junit-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/junit-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/junit-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/junit-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/junit-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/junit-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/junit-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/junit-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/junit-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/junit-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/junit-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/junit-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/junit-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/junit-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/junit-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/junit-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/junit-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/junit-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/junit-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/junit-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/junit-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/junit-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/junit-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/junit-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/junit-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/junit-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/junit-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/junit-plugin/deployments","created_at":"2014-08-11T13:55:17Z","updated_at":"2016-08-25T18:27:25Z","pushed_at":"2016-08-29T15:38:45Z","git_url":"git://github.com/jenkinsci/junit-plugin.git","ssh_url":"git@github.com:jenkinsci/junit-plugin.git","clone_url":"https://github.com/jenkinsci/junit-plugin.git","svn_url":"https://github.com/jenkinsci/junit-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/JUnit+Plugin","size":1823,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":14,"forks":79,"open_issues":14,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54"},"html":{"href":"https://github.com/jenkinsci/junit-plugin/pull/54"},"issue":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/54"},"comments":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/junit-plugin/statuses/7f5b06d4c159061cdc1dac471646c913cb8dd77a"}}}}
{"actor":{"display_login":"jglick"}}