{"action":"created","issue":{"url":"https://api.github.com/repos/socrata/cetera/issues/173","repository_url":"https://api.github.com/repos/socrata/cetera","labels_url":"https://api.github.com/repos/socrata/cetera/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/socrata/cetera/issues/173/comments","events_url":"https://api.github.com/repos/socrata/cetera/issues/173/events","html_url":"https://github.com/socrata/cetera/pull/173","id":161325618,"number":173,"title":"Add Queries object and consolidate queries there.","user":{"login":"aynleslie","id":6155686,"avatar_url":"https://avatars.githubusercontent.com/u/6155686?v=3","gravatar_id":"","url":"https://api.github.com/users/aynleslie","html_url":"https://github.com/aynleslie","followers_url":"https://api.github.com/users/aynleslie/followers","following_url":"https://api.github.com/users/aynleslie/following{/other_user}","gists_url":"https://api.github.com/users/aynleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/aynleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aynleslie/subscriptions","organizations_url":"https://api.github.com/users/aynleslie/orgs","repos_url":"https://api.github.com/users/aynleslie/repos","events_url":"https://api.github.com/users/aynleslie/events{/privacy}","received_events_url":"https://api.github.com/users/aynleslie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jasonij","id":272820,"avatar_url":"https://avatars.githubusercontent.com/u/272820?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonij","html_url":"https://github.com/jasonij","followers_url":"https://api.github.com/users/jasonij/followers","following_url":"https://api.github.com/users/jasonij/following{/other_user}","gists_url":"https://api.github.com/users/jasonij/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonij/subscriptions","organizations_url":"https://api.github.com/users/jasonij/orgs","repos_url":"https://api.github.com/users/jasonij/repos","events_url":"https://api.github.com/users/jasonij/events{/privacy}","received_events_url":"https://api.github.com/users/jasonij/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-21T00:32:23Z","updated_at":"2016-06-23T21:17:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/socrata/cetera/pulls/173","html_url":"https://github.com/socrata/cetera/pull/173","diff_url":"https://github.com/socrata/cetera/pull/173.diff","patch_url":"https://github.com/socrata/cetera/pull/173.patch"},"body":"#### What it do?\r\n\r\nMuch like we already have a `DocumentFilters` object to store our filters, I've added a `DocumentQueries` object to store our queries.  The queries where previously stored in 2 places:\r\n\r\n- The DocumentClient\r\n- The DocumentQueries inside the `Filters.scala` file\r\n\r\nThey are still in 2 places, with the following changes:\r\n\r\n- The DocumentClient has only the ones required by the `BaseDocumentClient` and the now private `buildBaseRequest` method\r\n- The DocumentQueries class has everything else\r\n\r\nSo:\r\n\r\n- I moved a lot of queries\r\n- I added the awful param `idsModRAStatuses`, a quadruple of Ints from the domainClient’s `calculateIdsAndModRAStatuses` method, to some of the query builders. this is an unfortunate consequence of me trying to break apart a huge PR and this piece is cleaner in the end, because that method will get moved.  It just doesn’t fit in at this phase (of breaking up the commit).   Please just tolerate this for a small while; I promise this is temporary.\r\n- I did away with several of the wide sweeping `import com.socrata.cetera._` imports, and as such there are few small name changes.\r\n- Two `scalastyle:ignore` commits were naturally done away with with these changes.   :)\r\n- I added a bunch of new tests, so that all but 1 of the methods in the `Queries` file are tested. The one untested method is the `compositeFilteredQuery` and that is going to be refactored and simplified in the end, so it would be silly to write tests now. They'll be coming in a couple commits though. \r\n\r\n#### How was it tested?\r\nsbt (all the usual things)\r\nran against prod, testing the /catalog endpoint with several param variations.\r\n\r\n#### Warnings !!!\r\n\r\nThis is the stage-3 refactor PR. It is rebased on top of pull 171\r\n"},"comment":{"url":"https://api.github.com/repos/socrata/cetera/issues/comments/228186683","html_url":"https://github.com/socrata/cetera/pull/173#issuecomment-228186683","issue_url":"https://api.github.com/repos/socrata/cetera/issues/173","id":228186683,"user":{"login":"jasonij","id":272820,"avatar_url":"https://avatars.githubusercontent.com/u/272820?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonij","html_url":"https://github.com/jasonij","followers_url":"https://api.github.com/users/jasonij/followers","following_url":"https://api.github.com/users/jasonij/following{/other_user}","gists_url":"https://api.github.com/users/jasonij/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonij/subscriptions","organizations_url":"https://api.github.com/users/jasonij/orgs","repos_url":"https://api.github.com/users/jasonij/repos","events_url":"https://api.github.com/users/jasonij/events{/privacy}","received_events_url":"https://api.github.com/users/jasonij/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T21:17:30Z","updated_at":"2016-06-23T21:17:30Z","body":"Lots of little things, most of which are discretionary. Imports should definitely be cleaned up (as this will also clean up the code base, as you'll see). The json interpolation indentation is quite messy and should be cleaned up.\r\n\r\nLots of indentation issues with fn signatures, I'm sure you can fix those quickly.\r\n\r\nVariables names, well, worth having a thought about and deciding if you want to change them now or call them good. I do think in a couple places moving involved things out into their own vals would improve readability. Partly I see this as a chance, since we're moving the files around anyway, just to fix little things while we can and are looking at them. Up to you how much you want to do this."}}
{"actor":{"display_login":"jasonij"}}