{"action":"created","comment":{"url":"https://api.github.com/repos/PayBreak/basket/pulls/comments/81526925","pull_request_review_id":2500044,"id":81526925,"diff_hunk":"@@ -403,9 +403,9 @@ public function emailApplication($installation, $id, Request $request)\n             ]\n         );\n \n-        $application = $this->fetchApplicationById($id, $installation);\n-\n         try {\n+            $application = $this->fetchApplicationById($id, $installation);","path":"app/Http/Controllers/ApplicationsController.php","position":7,"original_position":7,"commit_id":"c16ece3158b8cbf0fdbf37d280147feb7564d901","original_commit_id":"c16ece3158b8cbf0fdbf37d280147feb7564d901","user":{"login":"srleach","id":13541397,"avatar_url":"https://avatars.githubusercontent.com/u/13541397?v=3","gravatar_id":"","url":"https://api.github.com/users/srleach","html_url":"https://github.com/srleach","followers_url":"https://api.github.com/users/srleach/followers","following_url":"https://api.github.com/users/srleach/following{/other_user}","gists_url":"https://api.github.com/users/srleach/gists{/gist_id}","starred_url":"https://api.github.com/users/srleach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srleach/subscriptions","organizations_url":"https://api.github.com/users/srleach/orgs","repos_url":"https://api.github.com/users/srleach/repos","events_url":"https://api.github.com/users/srleach/events{/privacy}","received_events_url":"https://api.github.com/users/srleach/received_events","type":"User","site_admin":false},"body":"In this instance, I'm concerned that we're taking the wrong approach. If the application doesn't exist after we've just created it - then I think we should be moving forwards with ensuring that goes ahead properly rather than handling an exception. Perhaps we're trying to fetch the app too soon after creating it? What are your thoughts @wnowicki ","created_at":"2016-10-03T10:42:51Z","updated_at":"2016-10-03T10:42:51Z","html_url":"https://github.com/PayBreak/basket/pull/185#discussion_r81526925","pull_request_url":"https://api.github.com/repos/PayBreak/basket/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/comments/81526925"},"html":{"href":"https://github.com/PayBreak/basket/pull/185#discussion_r81526925"},"pull_request":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/PayBreak/basket/pulls/185","id":87693741,"html_url":"https://github.com/PayBreak/basket/pull/185","diff_url":"https://github.com/PayBreak/basket/pull/185.diff","patch_url":"https://github.com/PayBreak/basket/pull/185.patch","issue_url":"https://api.github.com/repos/PayBreak/basket/issues/185","number":185,"state":"open","locked":false,"title":"Uncaught Exception Fix","user":{"login":"00eadeyemi","id":16000696,"avatar_url":"https://avatars.githubusercontent.com/u/16000696?v=3","gravatar_id":"","url":"https://api.github.com/users/00eadeyemi","html_url":"https://github.com/00eadeyemi","followers_url":"https://api.github.com/users/00eadeyemi/followers","following_url":"https://api.github.com/users/00eadeyemi/following{/other_user}","gists_url":"https://api.github.com/users/00eadeyemi/gists{/gist_id}","starred_url":"https://api.github.com/users/00eadeyemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/00eadeyemi/subscriptions","organizations_url":"https://api.github.com/users/00eadeyemi/orgs","repos_url":"https://api.github.com/users/00eadeyemi/repos","events_url":"https://api.github.com/users/00eadeyemi/events{/privacy}","received_events_url":"https://api.github.com/users/00eadeyemi/received_events","type":"User","site_admin":false},"body":"### Bug Fix\r\n\r\n- Fixed potential fatal error \r\n\r\n[Delivers #131530149](https://www.pivotaltracker.com/story/show/131530149)","created_at":"2016-10-03T10:28:37Z","updated_at":"2016-10-03T10:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a746c8d4487c8f1d49ebe4c48e7f908147f78cf2","assignee":{"login":"srleach","id":13541397,"avatar_url":"https://avatars.githubusercontent.com/u/13541397?v=3","gravatar_id":"","url":"https://api.github.com/users/srleach","html_url":"https://github.com/srleach","followers_url":"https://api.github.com/users/srleach/followers","following_url":"https://api.github.com/users/srleach/following{/other_user}","gists_url":"https://api.github.com/users/srleach/gists{/gist_id}","starred_url":"https://api.github.com/users/srleach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srleach/subscriptions","organizations_url":"https://api.github.com/users/srleach/orgs","repos_url":"https://api.github.com/users/srleach/repos","events_url":"https://api.github.com/users/srleach/events{/privacy}","received_events_url":"https://api.github.com/users/srleach/received_events","type":"User","site_admin":false},"assignees":[{"login":"srleach","id":13541397,"avatar_url":"https://avatars.githubusercontent.com/u/13541397?v=3","gravatar_id":"","url":"https://api.github.com/users/srleach","html_url":"https://github.com/srleach","followers_url":"https://api.github.com/users/srleach/followers","following_url":"https://api.github.com/users/srleach/following{/other_user}","gists_url":"https://api.github.com/users/srleach/gists{/gist_id}","starred_url":"https://api.github.com/users/srleach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srleach/subscriptions","organizations_url":"https://api.github.com/users/srleach/orgs","repos_url":"https://api.github.com/users/srleach/repos","events_url":"https://api.github.com/users/srleach/events{/privacy}","received_events_url":"https://api.github.com/users/srleach/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PayBreak/basket/pulls/185/commits","review_comments_url":"https://api.github.com/repos/PayBreak/basket/pulls/185/comments","review_comment_url":"https://api.github.com/repos/PayBreak/basket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PayBreak/basket/issues/185/comments","statuses_url":"https://api.github.com/repos/PayBreak/basket/statuses/c16ece3158b8cbf0fdbf37d280147feb7564d901","head":{"label":"PayBreak:uncaught-exception-fix","ref":"uncaught-exception-fix","sha":"c16ece3158b8cbf0fdbf37d280147feb7564d901","user":{"login":"PayBreak","id":6369084,"avatar_url":"https://avatars.githubusercontent.com/u/6369084?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBreak","html_url":"https://github.com/PayBreak","followers_url":"https://api.github.com/users/PayBreak/followers","following_url":"https://api.github.com/users/PayBreak/following{/other_user}","gists_url":"https://api.github.com/users/PayBreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBreak/subscriptions","organizations_url":"https://api.github.com/users/PayBreak/orgs","repos_url":"https://api.github.com/users/PayBreak/repos","events_url":"https://api.github.com/users/PayBreak/events{/privacy}","received_events_url":"https://api.github.com/users/PayBreak/received_events","type":"Organization","site_admin":false},"repo":{"id":38302322,"name":"basket","full_name":"PayBreak/basket","owner":{"login":"PayBreak","id":6369084,"avatar_url":"https://avatars.githubusercontent.com/u/6369084?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBreak","html_url":"https://github.com/PayBreak","followers_url":"https://api.github.com/users/PayBreak/followers","following_url":"https://api.github.com/users/PayBreak/following{/other_user}","gists_url":"https://api.github.com/users/PayBreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBreak/subscriptions","organizations_url":"https://api.github.com/users/PayBreak/orgs","repos_url":"https://api.github.com/users/PayBreak/repos","events_url":"https://api.github.com/users/PayBreak/events{/privacy}","received_events_url":"https://api.github.com/users/PayBreak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PayBreak/basket","description":"Basket System","fork":false,"url":"https://api.github.com/repos/PayBreak/basket","forks_url":"https://api.github.com/repos/PayBreak/basket/forks","keys_url":"https://api.github.com/repos/PayBreak/basket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PayBreak/basket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PayBreak/basket/teams","hooks_url":"https://api.github.com/repos/PayBreak/basket/hooks","issue_events_url":"https://api.github.com/repos/PayBreak/basket/issues/events{/number}","events_url":"https://api.github.com/repos/PayBreak/basket/events","assignees_url":"https://api.github.com/repos/PayBreak/basket/assignees{/user}","branches_url":"https://api.github.com/repos/PayBreak/basket/branches{/branch}","tags_url":"https://api.github.com/repos/PayBreak/basket/tags","blobs_url":"https://api.github.com/repos/PayBreak/basket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PayBreak/basket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PayBreak/basket/git/refs{/sha}","trees_url":"https://api.github.com/repos/PayBreak/basket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PayBreak/basket/statuses/{sha}","languages_url":"https://api.github.com/repos/PayBreak/basket/languages","stargazers_url":"https://api.github.com/repos/PayBreak/basket/stargazers","contributors_url":"https://api.github.com/repos/PayBreak/basket/contributors","subscribers_url":"https://api.github.com/repos/PayBreak/basket/subscribers","subscription_url":"https://api.github.com/repos/PayBreak/basket/subscription","commits_url":"https://api.github.com/repos/PayBreak/basket/commits{/sha}","git_commits_url":"https://api.github.com/repos/PayBreak/basket/git/commits{/sha}","comments_url":"https://api.github.com/repos/PayBreak/basket/comments{/number}","issue_comment_url":"https://api.github.com/repos/PayBreak/basket/issues/comments{/number}","contents_url":"https://api.github.com/repos/PayBreak/basket/contents/{+path}","compare_url":"https://api.github.com/repos/PayBreak/basket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PayBreak/basket/merges","archive_url":"https://api.github.com/repos/PayBreak/basket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PayBreak/basket/downloads","issues_url":"https://api.github.com/repos/PayBreak/basket/issues{/number}","pulls_url":"https://api.github.com/repos/PayBreak/basket/pulls{/number}","milestones_url":"https://api.github.com/repos/PayBreak/basket/milestones{/number}","notifications_url":"https://api.github.com/repos/PayBreak/basket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PayBreak/basket/labels{/name}","releases_url":"https://api.github.com/repos/PayBreak/basket/releases{/id}","deployments_url":"https://api.github.com/repos/PayBreak/basket/deployments","created_at":"2015-06-30T10:12:55Z","updated_at":"2016-01-21T08:36:48Z","pushed_at":"2016-10-03T10:28:37Z","git_url":"git://github.com/PayBreak/basket.git","ssh_url":"git@github.com:PayBreak/basket.git","clone_url":"https://github.com/PayBreak/basket.git","svn_url":"https://github.com/PayBreak/basket","homepage":null,"size":6492,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"PayBreak:develop","ref":"develop","sha":"ec397149bea79c49dfcc278658b7125c352056aa","user":{"login":"PayBreak","id":6369084,"avatar_url":"https://avatars.githubusercontent.com/u/6369084?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBreak","html_url":"https://github.com/PayBreak","followers_url":"https://api.github.com/users/PayBreak/followers","following_url":"https://api.github.com/users/PayBreak/following{/other_user}","gists_url":"https://api.github.com/users/PayBreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBreak/subscriptions","organizations_url":"https://api.github.com/users/PayBreak/orgs","repos_url":"https://api.github.com/users/PayBreak/repos","events_url":"https://api.github.com/users/PayBreak/events{/privacy}","received_events_url":"https://api.github.com/users/PayBreak/received_events","type":"Organization","site_admin":false},"repo":{"id":38302322,"name":"basket","full_name":"PayBreak/basket","owner":{"login":"PayBreak","id":6369084,"avatar_url":"https://avatars.githubusercontent.com/u/6369084?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBreak","html_url":"https://github.com/PayBreak","followers_url":"https://api.github.com/users/PayBreak/followers","following_url":"https://api.github.com/users/PayBreak/following{/other_user}","gists_url":"https://api.github.com/users/PayBreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBreak/subscriptions","organizations_url":"https://api.github.com/users/PayBreak/orgs","repos_url":"https://api.github.com/users/PayBreak/repos","events_url":"https://api.github.com/users/PayBreak/events{/privacy}","received_events_url":"https://api.github.com/users/PayBreak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PayBreak/basket","description":"Basket System","fork":false,"url":"https://api.github.com/repos/PayBreak/basket","forks_url":"https://api.github.com/repos/PayBreak/basket/forks","keys_url":"https://api.github.com/repos/PayBreak/basket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PayBreak/basket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PayBreak/basket/teams","hooks_url":"https://api.github.com/repos/PayBreak/basket/hooks","issue_events_url":"https://api.github.com/repos/PayBreak/basket/issues/events{/number}","events_url":"https://api.github.com/repos/PayBreak/basket/events","assignees_url":"https://api.github.com/repos/PayBreak/basket/assignees{/user}","branches_url":"https://api.github.com/repos/PayBreak/basket/branches{/branch}","tags_url":"https://api.github.com/repos/PayBreak/basket/tags","blobs_url":"https://api.github.com/repos/PayBreak/basket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PayBreak/basket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PayBreak/basket/git/refs{/sha}","trees_url":"https://api.github.com/repos/PayBreak/basket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PayBreak/basket/statuses/{sha}","languages_url":"https://api.github.com/repos/PayBreak/basket/languages","stargazers_url":"https://api.github.com/repos/PayBreak/basket/stargazers","contributors_url":"https://api.github.com/repos/PayBreak/basket/contributors","subscribers_url":"https://api.github.com/repos/PayBreak/basket/subscribers","subscription_url":"https://api.github.com/repos/PayBreak/basket/subscription","commits_url":"https://api.github.com/repos/PayBreak/basket/commits{/sha}","git_commits_url":"https://api.github.com/repos/PayBreak/basket/git/commits{/sha}","comments_url":"https://api.github.com/repos/PayBreak/basket/comments{/number}","issue_comment_url":"https://api.github.com/repos/PayBreak/basket/issues/comments{/number}","contents_url":"https://api.github.com/repos/PayBreak/basket/contents/{+path}","compare_url":"https://api.github.com/repos/PayBreak/basket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PayBreak/basket/merges","archive_url":"https://api.github.com/repos/PayBreak/basket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PayBreak/basket/downloads","issues_url":"https://api.github.com/repos/PayBreak/basket/issues{/number}","pulls_url":"https://api.github.com/repos/PayBreak/basket/pulls{/number}","milestones_url":"https://api.github.com/repos/PayBreak/basket/milestones{/number}","notifications_url":"https://api.github.com/repos/PayBreak/basket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PayBreak/basket/labels{/name}","releases_url":"https://api.github.com/repos/PayBreak/basket/releases{/id}","deployments_url":"https://api.github.com/repos/PayBreak/basket/deployments","created_at":"2015-06-30T10:12:55Z","updated_at":"2016-01-21T08:36:48Z","pushed_at":"2016-10-03T10:28:37Z","git_url":"git://github.com/PayBreak/basket.git","ssh_url":"git@github.com:PayBreak/basket.git","clone_url":"https://github.com/PayBreak/basket.git","svn_url":"https://github.com/PayBreak/basket","homepage":null,"size":6492,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/185"},"html":{"href":"https://github.com/PayBreak/basket/pull/185"},"issue":{"href":"https://api.github.com/repos/PayBreak/basket/issues/185"},"comments":{"href":"https://api.github.com/repos/PayBreak/basket/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PayBreak/basket/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/PayBreak/basket/statuses/c16ece3158b8cbf0fdbf37d280147feb7564d901"}}}}
{"actor":{"display_login":"srleach"}}