{"action":"created","comment":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/comments/73072705","id":73072705,"diff_hunk":"@@ -11,51 +11,37 @@\n \n @implementation QSObjectSource\n \n-// KVO\n-+ (NSSet *)keyPathsForValuesAffectingValueForKey:(NSString *)key {\n-    NSSet *keyPaths = [super keyPathsForValuesAffectingValueForKey:key];\n-\n-    if ([key isEqualToString:@\"currentEntry\"]) {\n-        keyPaths = [keyPaths setByAddingObject:@\"selection\"];\n-    }\n-    return keyPaths;\n-}\n+- (NSImage *)iconForEntry:(QSCatalogEntry *)theEntry {return nil;}\n+\n+- (NSString *)nameForEntry:(QSCatalogEntry *)theEntry {return nil;}\n+\n+- (NSArray *)objectsForEntry:(QSCatalogEntry *)theEntry {return nil;}\n \n-- (NSImage *)iconForEntry:(NSDictionary *)theEntry {return nil;}\n-- (NSString *)nameForEntry:(NSDictionary *)theEntry {return nil;}\n-- (NSArray *)objectsForEntry:(NSDictionary *)theEntry {return nil;}\n - (void)invalidateSelf {\n \t//  NSLog(@\"invalidated %@\", self);\n \t[[NSNotificationCenter defaultCenter] postNotificationName:QSCatalogSourceInvalidated object:NSStringFromClass([self class])];\n }\n \n - (BOOL)indexIsValidFromDate:(NSDate *)indexDate forEntry:(NSDictionary *)theEntry {\n-//\t NSDate *specDate = [NSDate dateWithTimeIntervalSinceReferenceDate:[[theEntry objectForKey:kItemModificationDate] floatValue]];\n-//\t  return ([specDate compare:indexDate] == NSOrderedDescending);\n-//\t  //return NO; //Catalog Specification is more recent than index\n+\t//\t NSDate *specDate = [NSDate dateWithTimeIntervalSinceReferenceDate:[[theEntry objectForKey:kItemModificationDate] floatValue]];\n+\t//\t  return ([specDate compare:indexDate] == NSOrderedDescending);\n+\t//\t  //return NO; //Catalog Specification is more recent than index\n \t// ***warning  * should switch to using this!\n \treturn NO;\n }\n - (void)populateFields {return;}\n \n-- (void)updateCurrentEntryModificationDate {\n-\t[currentEntry setObject:[NSNumber numberWithDouble:[NSDate timeIntervalSinceReferenceDate]] forKey:kItemModificationDate];\n-}\n-\n - (NSMutableDictionary *)currentEntry {\n-\treturn [[self selection] info];\n+\treturn self.selection.info;\n }\n \n-- (QSCatalogEntry *)selection { return selection;  }\n-- (void)setSelection:(QSCatalogEntry *)newSelection {\n-\tif(newSelection != selection){\n-\t\tselection = newSelection;\n-\t}\n-}\n+- (void)setCurrentEntry:(NSMutableDictionary *)currentEntry {}\n \n-- (NSView *)settingsView { return settingsView;  }\n-- (void)setSettingsView:(NSView *)newSettingsView {\n-\tsettingsView = newSettingsView;\n+- (void)updateCurrentEntryModificationDate {\n+\tself.selectedEntry.sourceSettings[kItemModificationDate] = @([NSDate timeIntervalSinceReferenceDate]);\n }\n \n+- (QSCatalogEntry *)selection { return self.selectedEntry; }\n+- (void)setSelection:(QSCatalogEntry *)selection { self.selectedEntry = selection; }","path":"Quicksilver/Code-QuickStepCore/QSObjectSource.m","position":64,"original_position":64,"commit_id":"17f5671cee234f028da977e7d964ba2cd01f5070","original_commit_id":"17f5671cee234f028da977e7d964ba2cd01f5070","user":{"login":"pjrobertson","id":150431,"avatar_url":"https://avatars.githubusercontent.com/u/150431?v=3","gravatar_id":"","url":"https://api.github.com/users/pjrobertson","html_url":"https://github.com/pjrobertson","followers_url":"https://api.github.com/users/pjrobertson/followers","following_url":"https://api.github.com/users/pjrobertson/following{/other_user}","gists_url":"https://api.github.com/users/pjrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/pjrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjrobertson/subscriptions","organizations_url":"https://api.github.com/users/pjrobertson/orgs","repos_url":"https://api.github.com/users/pjrobertson/repos","events_url":"https://api.github.com/users/pjrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/pjrobertson/received_events","type":"User","site_admin":false},"body":"do we need any `@synchronized` round these? Just wondering if there could be a race condition with getting and setting, if you were in the middle of changing the selection?","created_at":"2016-08-01T23:39:02Z","updated_at":"2016-08-01T23:39:02Z","html_url":"https://github.com/quicksilver/Quicksilver/pull/2255#discussion_r73072705","pull_request_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255","_links":{"self":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/comments/73072705"},"html":{"href":"https://github.com/quicksilver/Quicksilver/pull/2255#discussion_r73072705"},"pull_request":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255"}}},"pull_request":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255","id":79648675,"html_url":"https://github.com/quicksilver/Quicksilver/pull/2255","diff_url":"https://github.com/quicksilver/Quicksilver/pull/2255.diff","patch_url":"https://github.com/quicksilver/Quicksilver/pull/2255.patch","issue_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2255","number":2255,"state":"open","locked":false,"title":"Cleanup object sources","user":{"login":"tiennou","id":81099,"avatar_url":"https://avatars.githubusercontent.com/u/81099?v=3","gravatar_id":"","url":"https://api.github.com/users/tiennou","html_url":"https://github.com/tiennou","followers_url":"https://api.github.com/users/tiennou/followers","following_url":"https://api.github.com/users/tiennou/following{/other_user}","gists_url":"https://api.github.com/users/tiennou/gists{/gist_id}","starred_url":"https://api.github.com/users/tiennou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiennou/subscriptions","organizations_url":"https://api.github.com/users/tiennou/orgs","repos_url":"https://api.github.com/users/tiennou/repos","events_url":"https://api.github.com/users/tiennou/events{/privacy}","received_events_url":"https://api.github.com/users/tiennou/received_events","type":"User","site_admin":false},"body":"This streamlines the `QSObjectSource`/`QSCatalogEntry` API, the ultimate goal being asynchronous loading of objects where that makes sense. I feel like this is pretty far away still, because I'd like to tackle the librarian first.\r\n\r\nI expect this not to break anything, the things that need plugin changes will be submitted separately in PR #2256, but I need the infrastructure in there to progress (eg. `-selectedEntry`).","created_at":"2016-08-01T22:36:41Z","updated_at":"2016-08-01T23:39:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10fddfcc12021bef081a86bc7404de09db8a4e27","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255/commits","review_comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255/comments","review_comment_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2255/comments","statuses_url":"https://api.github.com/repos/quicksilver/Quicksilver/statuses/17f5671cee234f028da977e7d964ba2cd01f5070","head":{"label":"quicksilver:catalog/clean-obj-source","ref":"catalog/clean-obj-source","sha":"17f5671cee234f028da977e7d964ba2cd01f5070","user":{"login":"quicksilver","id":499603,"avatar_url":"https://avatars.githubusercontent.com/u/499603?v=3","gravatar_id":"","url":"https://api.github.com/users/quicksilver","html_url":"https://github.com/quicksilver","followers_url":"https://api.github.com/users/quicksilver/followers","following_url":"https://api.github.com/users/quicksilver/following{/other_user}","gists_url":"https://api.github.com/users/quicksilver/gists{/gist_id}","starred_url":"https://api.github.com/users/quicksilver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicksilver/subscriptions","organizations_url":"https://api.github.com/users/quicksilver/orgs","repos_url":"https://api.github.com/users/quicksilver/repos","events_url":"https://api.github.com/users/quicksilver/events{/privacy}","received_events_url":"https://api.github.com/users/quicksilver/received_events","type":"Organization","site_admin":false},"repo":{"id":358078,"name":"Quicksilver","full_name":"quicksilver/Quicksilver","owner":{"login":"quicksilver","id":499603,"avatar_url":"https://avatars.githubusercontent.com/u/499603?v=3","gravatar_id":"","url":"https://api.github.com/users/quicksilver","html_url":"https://github.com/quicksilver","followers_url":"https://api.github.com/users/quicksilver/followers","following_url":"https://api.github.com/users/quicksilver/following{/other_user}","gists_url":"https://api.github.com/users/quicksilver/gists{/gist_id}","starred_url":"https://api.github.com/users/quicksilver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicksilver/subscriptions","organizations_url":"https://api.github.com/users/quicksilver/orgs","repos_url":"https://api.github.com/users/quicksilver/repos","events_url":"https://api.github.com/users/quicksilver/events{/privacy}","received_events_url":"https://api.github.com/users/quicksilver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicksilver/Quicksilver","description":"Quicksilver Mac OS X Project Source","fork":false,"url":"https://api.github.com/repos/quicksilver/Quicksilver","forks_url":"https://api.github.com/repos/quicksilver/Quicksilver/forks","keys_url":"https://api.github.com/repos/quicksilver/Quicksilver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicksilver/Quicksilver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicksilver/Quicksilver/teams","hooks_url":"https://api.github.com/repos/quicksilver/Quicksilver/hooks","issue_events_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/events{/number}","events_url":"https://api.github.com/repos/quicksilver/Quicksilver/events","assignees_url":"https://api.github.com/repos/quicksilver/Quicksilver/assignees{/user}","branches_url":"https://api.github.com/repos/quicksilver/Quicksilver/branches{/branch}","tags_url":"https://api.github.com/repos/quicksilver/Quicksilver/tags","blobs_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicksilver/Quicksilver/statuses/{sha}","languages_url":"https://api.github.com/repos/quicksilver/Quicksilver/languages","stargazers_url":"https://api.github.com/repos/quicksilver/Quicksilver/stargazers","contributors_url":"https://api.github.com/repos/quicksilver/Quicksilver/contributors","subscribers_url":"https://api.github.com/repos/quicksilver/Quicksilver/subscribers","subscription_url":"https://api.github.com/repos/quicksilver/Quicksilver/subscription","commits_url":"https://api.github.com/repos/quicksilver/Quicksilver/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicksilver/Quicksilver/contents/{+path}","compare_url":"https://api.github.com/repos/quicksilver/Quicksilver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicksilver/Quicksilver/merges","archive_url":"https://api.github.com/repos/quicksilver/Quicksilver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicksilver/Quicksilver/downloads","issues_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues{/number}","pulls_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls{/number}","milestones_url":"https://api.github.com/repos/quicksilver/Quicksilver/milestones{/number}","notifications_url":"https://api.github.com/repos/quicksilver/Quicksilver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicksilver/Quicksilver/labels{/name}","releases_url":"https://api.github.com/repos/quicksilver/Quicksilver/releases{/id}","deployments_url":"https://api.github.com/repos/quicksilver/Quicksilver/deployments","created_at":"2009-11-02T14:55:23Z","updated_at":"2016-07-29T03:12:53Z","pushed_at":"2016-08-01T23:38:19Z","git_url":"git://github.com/quicksilver/Quicksilver.git","ssh_url":"git@github.com:quicksilver/Quicksilver.git","clone_url":"https://github.com/quicksilver/Quicksilver.git","svn_url":"https://github.com/quicksilver/Quicksilver","homepage":"http://qsapp.com","size":125536,"stargazers_count":2039,"watchers_count":2039,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":252,"mirror_url":null,"open_issues_count":329,"forks":252,"open_issues":329,"watchers":2039,"default_branch":"master"}},"base":{"label":"quicksilver:master","ref":"master","sha":"e638baf8871b0d749c29e32979953449646526cf","user":{"login":"quicksilver","id":499603,"avatar_url":"https://avatars.githubusercontent.com/u/499603?v=3","gravatar_id":"","url":"https://api.github.com/users/quicksilver","html_url":"https://github.com/quicksilver","followers_url":"https://api.github.com/users/quicksilver/followers","following_url":"https://api.github.com/users/quicksilver/following{/other_user}","gists_url":"https://api.github.com/users/quicksilver/gists{/gist_id}","starred_url":"https://api.github.com/users/quicksilver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicksilver/subscriptions","organizations_url":"https://api.github.com/users/quicksilver/orgs","repos_url":"https://api.github.com/users/quicksilver/repos","events_url":"https://api.github.com/users/quicksilver/events{/privacy}","received_events_url":"https://api.github.com/users/quicksilver/received_events","type":"Organization","site_admin":false},"repo":{"id":358078,"name":"Quicksilver","full_name":"quicksilver/Quicksilver","owner":{"login":"quicksilver","id":499603,"avatar_url":"https://avatars.githubusercontent.com/u/499603?v=3","gravatar_id":"","url":"https://api.github.com/users/quicksilver","html_url":"https://github.com/quicksilver","followers_url":"https://api.github.com/users/quicksilver/followers","following_url":"https://api.github.com/users/quicksilver/following{/other_user}","gists_url":"https://api.github.com/users/quicksilver/gists{/gist_id}","starred_url":"https://api.github.com/users/quicksilver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicksilver/subscriptions","organizations_url":"https://api.github.com/users/quicksilver/orgs","repos_url":"https://api.github.com/users/quicksilver/repos","events_url":"https://api.github.com/users/quicksilver/events{/privacy}","received_events_url":"https://api.github.com/users/quicksilver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicksilver/Quicksilver","description":"Quicksilver Mac OS X Project Source","fork":false,"url":"https://api.github.com/repos/quicksilver/Quicksilver","forks_url":"https://api.github.com/repos/quicksilver/Quicksilver/forks","keys_url":"https://api.github.com/repos/quicksilver/Quicksilver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicksilver/Quicksilver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicksilver/Quicksilver/teams","hooks_url":"https://api.github.com/repos/quicksilver/Quicksilver/hooks","issue_events_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/events{/number}","events_url":"https://api.github.com/repos/quicksilver/Quicksilver/events","assignees_url":"https://api.github.com/repos/quicksilver/Quicksilver/assignees{/user}","branches_url":"https://api.github.com/repos/quicksilver/Quicksilver/branches{/branch}","tags_url":"https://api.github.com/repos/quicksilver/Quicksilver/tags","blobs_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicksilver/Quicksilver/statuses/{sha}","languages_url":"https://api.github.com/repos/quicksilver/Quicksilver/languages","stargazers_url":"https://api.github.com/repos/quicksilver/Quicksilver/stargazers","contributors_url":"https://api.github.com/repos/quicksilver/Quicksilver/contributors","subscribers_url":"https://api.github.com/repos/quicksilver/Quicksilver/subscribers","subscription_url":"https://api.github.com/repos/quicksilver/Quicksilver/subscription","commits_url":"https://api.github.com/repos/quicksilver/Quicksilver/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicksilver/Quicksilver/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicksilver/Quicksilver/contents/{+path}","compare_url":"https://api.github.com/repos/quicksilver/Quicksilver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicksilver/Quicksilver/merges","archive_url":"https://api.github.com/repos/quicksilver/Quicksilver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicksilver/Quicksilver/downloads","issues_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues{/number}","pulls_url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls{/number}","milestones_url":"https://api.github.com/repos/quicksilver/Quicksilver/milestones{/number}","notifications_url":"https://api.github.com/repos/quicksilver/Quicksilver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicksilver/Quicksilver/labels{/name}","releases_url":"https://api.github.com/repos/quicksilver/Quicksilver/releases{/id}","deployments_url":"https://api.github.com/repos/quicksilver/Quicksilver/deployments","created_at":"2009-11-02T14:55:23Z","updated_at":"2016-07-29T03:12:53Z","pushed_at":"2016-08-01T23:38:19Z","git_url":"git://github.com/quicksilver/Quicksilver.git","ssh_url":"git@github.com:quicksilver/Quicksilver.git","clone_url":"https://github.com/quicksilver/Quicksilver.git","svn_url":"https://github.com/quicksilver/Quicksilver","homepage":"http://qsapp.com","size":125536,"stargazers_count":2039,"watchers_count":2039,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":252,"mirror_url":null,"open_issues_count":329,"forks":252,"open_issues":329,"watchers":2039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255"},"html":{"href":"https://github.com/quicksilver/Quicksilver/pull/2255"},"issue":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2255"},"comments":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2255/comments"},"review_comments":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255/comments"},"review_comment":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2255/commits"},"statuses":{"href":"https://api.github.com/repos/quicksilver/Quicksilver/statuses/17f5671cee234f028da977e7d964ba2cd01f5070"}}}}
{"actor":{"display_login":"pjrobertson"}}