{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/comments/93924735","pull_request_review_id":14456138,"id":93924735,"diff_hunk":"@@ -5,15 +5,18 @@ import (\n \t\"flag\"\n \t\"fmt\"\n \t\"math/rand\"\n-\t_ \"net/http/pprof\" // register debugger\n \t\"os\"\n \t\"os/signal\"\n+\t\"runtime\"\n+\t\"runtime/pprof\"\n \t\"syscall\"\n \t\"time\"\n \n \t\"github.com/DataDog/datadog-trace-agent/config\"\n \t\"github.com/DataDog/datadog-trace-agent/statsd\"\n \tlog \"github.com/cihub/seelog\"\n+\n+\t_ \"net/http/pprof\"","path":"agent/main.go","position":16,"original_position":16,"commit_id":"63ad130b09864ded0c8c7f4bd31379f67075cf43","original_commit_id":"63ad130b09864ded0c8c7f4bd31379f67075cf43","user":{"login":"palazzem","id":1560405,"avatar_url":"https://avatars.githubusercontent.com/u/1560405?v=3","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"body":"Wait.... we don't have a ``_ \"net/http/pprof\"`` in the receiver. If I remove that line:\r\n```\r\n$ curl localhost:7777/debug/pprof/\r\n404 page not found\r\n```","created_at":"2016-12-27T12:05:11Z","updated_at":"2016-12-27T12:05:11Z","html_url":"https://github.com/DataDog/datadog-trace-agent/pull/159#discussion_r93924735","pull_request_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/comments/93924735"},"html":{"href":"https://github.com/DataDog/datadog-trace-agent/pull/159#discussion_r93924735"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159","id":99420556,"html_url":"https://github.com/DataDog/datadog-trace-agent/pull/159","diff_url":"https://github.com/DataDog/datadog-trace-agent/pull/159.diff","patch_url":"https://github.com/DataDog/datadog-trace-agent/pull/159.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/159","number":159,"state":"open","locked":false,"title":"[benchmark] add cpuprofiler flag to save a profiling session","user":{"login":"palazzem","id":1560405,"avatar_url":"https://avatars.githubusercontent.com/u/1560405?v=3","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"body":"### What it does\r\n\r\n* add `-cpuprofile=cpu.pprof` flag\r\n* add `-memprofile=mem.pprof` flag\r\n\r\nIt's useful to profile the full flow overhead when the agent is constantly hit by a huge number of traces per second.","created_at":"2016-12-27T08:52:19Z","updated_at":"2016-12-27T12:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca5f83c459494937a543119e514bcfb467a6ff1a","assignee":{"login":"LeoCavaille","id":1788830,"avatar_url":"https://avatars.githubusercontent.com/u/1788830?v=3","gravatar_id":"","url":"https://api.github.com/users/LeoCavaille","html_url":"https://github.com/LeoCavaille","followers_url":"https://api.github.com/users/LeoCavaille/followers","following_url":"https://api.github.com/users/LeoCavaille/following{/other_user}","gists_url":"https://api.github.com/users/LeoCavaille/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoCavaille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoCavaille/subscriptions","organizations_url":"https://api.github.com/users/LeoCavaille/orgs","repos_url":"https://api.github.com/users/LeoCavaille/repos","events_url":"https://api.github.com/users/LeoCavaille/events{/privacy}","received_events_url":"https://api.github.com/users/LeoCavaille/received_events","type":"User","site_admin":false},"assignees":[{"login":"LeoCavaille","id":1788830,"avatar_url":"https://avatars.githubusercontent.com/u/1788830?v=3","gravatar_id":"","url":"https://api.github.com/users/LeoCavaille","html_url":"https://github.com/LeoCavaille","followers_url":"https://api.github.com/users/LeoCavaille/followers","following_url":"https://api.github.com/users/LeoCavaille/following{/other_user}","gists_url":"https://api.github.com/users/LeoCavaille/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoCavaille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoCavaille/subscriptions","organizations_url":"https://api.github.com/users/LeoCavaille/orgs","repos_url":"https://api.github.com/users/LeoCavaille/repos","events_url":"https://api.github.com/users/LeoCavaille/events{/privacy}","received_events_url":"https://api.github.com/users/LeoCavaille/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/159/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/statuses/63ad130b09864ded0c8c7f4bd31379f67075cf43","head":{"label":"DataDog:palazzem/profile-flag","ref":"palazzem/profile-flag","sha":"63ad130b09864ded0c8c7f4bd31379f67075cf43","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":38379832,"name":"datadog-trace-agent","full_name":"DataDog/datadog-trace-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-trace-agent","description":"Datadog APM agent.","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-trace-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/deployments","created_at":"2015-07-01T15:45:17Z","updated_at":"2016-12-22T03:42:19Z","pushed_at":"2016-12-27T11:25:40Z","git_url":"git://github.com/DataDog/datadog-trace-agent.git","ssh_url":"git@github.com:DataDog/datadog-trace-agent.git","clone_url":"https://github.com/DataDog/datadog-trace-agent.git","svn_url":"https://github.com/DataDog/datadog-trace-agent","homepage":"http://www.datadog.com","size":685,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":10,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"5424a423a95c7ff7f8945889fa66833b9cd44cc4","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":38379832,"name":"datadog-trace-agent","full_name":"DataDog/datadog-trace-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-trace-agent","description":"Datadog APM agent.","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-trace-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-trace-agent/deployments","created_at":"2015-07-01T15:45:17Z","updated_at":"2016-12-22T03:42:19Z","pushed_at":"2016-12-27T11:25:40Z","git_url":"git://github.com/DataDog/datadog-trace-agent.git","ssh_url":"git@github.com:DataDog/datadog-trace-agent.git","clone_url":"https://github.com/DataDog/datadog-trace-agent.git","svn_url":"https://github.com/DataDog/datadog-trace-agent","homepage":"http://www.datadog.com","size":685,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159"},"html":{"href":"https://github.com/DataDog/datadog-trace-agent/pull/159"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/159"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-trace-agent/statuses/63ad130b09864ded0c8c7f4bd31379f67075cf43"}}}}
{"actor":{"display_login":"palazzem"}}