{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/93644386","pull_request_review_id":14174522,"id":93644386,"diff_hunk":"@@ -124,496 +140,509 @@ sub password {\n     $val .= $password;\n \n     $grub_fh->add_or_replace_lines(qr/^password\\s+/,\n-                              qr/^password $val$/,\n-                              \"password $val\\n\",\n-                              $self->main_section_offset($grub_fh),\n-                              );\n-}\n+                                   qr/^password $val$/,\n+                                   \"password $val\\n\",\n+                                   $self->main_section_offset($grub_fh),\n+                                   );\n \n-# get the position for the main section\n-# ie. after the header comments\n-sub main_section_offset {\n-    my ($self, $fh) = @_;\n-    my ($start, $end) = $fh->get_header_positions();\n-    return $start == -1 ? BEGINNING_OF_FILE : (SEEK_SET, $end);\n+    return SUCCESS;\n }\n \n-##########################################################################\n-sub Configure {\n-##########################################################################\n-    my ( $self, $config ) = @_;\n \n-    my $grubby = '/sbin/grubby';\n-    my $prefix = '/boot';\n-    if ( $config->elementExists(\"/software/components/grub/prefix\") ) {\n-        $prefix = $config->getValue(\"/software/components/grub/prefix\");\n-    }\n-    my $kernelname    = 'vmlinuz';\n-    my $kernelversion = '';\n-    if ( $config->elementExists($PATH_KERNEL_VERSION) ) {\n-        $kernelversion = $config->getValue($PATH_KERNEL_VERSION);\n-    }\n-    my $fulldefaultkernelpath;\n+=item serial_console\n \n-    # An undefined kernel version or an empty string are treated equally\n-    if ( !$kernelversion ) {\n-        $self->debug( 1, \"No kernel version defined: default kernel will not be set\" );\n-    } else {\n-        $fulldefaultkernelpath = $prefix . '/' . $kernelname . '-' . $kernelversion;\n-    }\n+Configure the grub serial console settings (C<ttyS> devices only)\n+by editing the grub conf via filehandle C<grub_fh>\n+(a C<CAF::FileEditor> instance, which is not closed in this method).\n \n-    my $grub_fh = CAF::FileEditor->new( $GRUB_CONF,\n-        owner => \"root\",\n-        group => \"root\",\n-        mode  => 0400,\n-        log   => $self );\n+Returns undef on failure, the console kernel commandline option\n+(or empty string if none is to be configured) on success.","path":"ncm-grub/src/main/perl/grub.pm","position":249,"original_position":249,"commit_id":"f0ed4c42a7c8abb91349277c4e24de95d2ac9cc9","original_commit_id":"f0ed4c42a7c8abb91349277c4e24de95d2ac9cc9","user":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"body":"Any particular reason why the return type is different to the password function? Why not return SUCCESS like it does?","created_at":"2016-12-22T15:39:49Z","updated_at":"2016-12-22T15:48:25Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/999#discussion_r93644386","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/93644386"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/999#discussion_r93644386"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999","id":98480646,"html_url":"https://github.com/quattor/configuration-modules-core/pull/999","diff_url":"https://github.com/quattor/configuration-modules-core/pull/999.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/999.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/999","number":999,"state":"open","locked":false,"title":"ncm-grub: full overhaul","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"No change in funcitonality, but should get rid of all backticks","created_at":"2016-12-18T17:09:39Z","updated_at":"2016-12-22T15:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3349a91ef920f87133a8c74ae6c191ae0564cb60","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/16","html_url":"https://github.com/quattor/configuration-modules-core/milestone/16","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/16/labels","id":2052453,"number":16,"title":"17.2","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":0,"state":"open","created_at":"2016-10-06T14:21:59Z","updated_at":"2016-12-21T07:19:31Z","due_on":"2017-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/999/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/f0ed4c42a7c8abb91349277c4e24de95d2ac9cc9","head":{"label":"stdweird:cleanup_grub","ref":"cleanup_grub","sha":"f0ed4c42a7c8abb91349277c4e24de95d2ac9cc9","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":9290244,"name":"configuration-modules-core","full_name":"stdweird/configuration-modules-core","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/configuration-modules-core","description":"Core NCM components for Quattor","fork":true,"url":"https://api.github.com/repos/stdweird/configuration-modules-core","forks_url":"https://api.github.com/repos/stdweird/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/stdweird/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/stdweird/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/stdweird/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/stdweird/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/stdweird/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/stdweird/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/stdweird/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/stdweird/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdweird/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/stdweird/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/stdweird/configuration-modules-core/deployments","created_at":"2013-04-08T06:47:35Z","updated_at":"2014-12-17T12:40:36Z","pushed_at":"2016-12-21T13:38:39Z","git_url":"git://github.com/stdweird/configuration-modules-core.git","ssh_url":"git@github.com:stdweird/configuration-modules-core.git","clone_url":"https://github.com/stdweird/configuration-modules-core.git","svn_url":"https://github.com/stdweird/configuration-modules-core","homepage":null,"size":11468,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"f4ca55ec38b92261373dc7eec9016439ff0d6106","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/configuration-modules-core/deployments","created_at":"2012-10-31T09:08:07Z","updated_at":"2016-10-24T10:45:01Z","pushed_at":"2016-12-22T15:30:51Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":11590,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":106,"forks":34,"open_issues":106,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/999"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/999"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/999/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/999/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/f0ed4c42a7c8abb91349277c4e24de95d2ac9cc9"}}}}
{"actor":{"display_login":"ned21"}}