{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/91727660","pull_request_review_id":12238859,"id":91727660,"diff_hunk":"@@ -44,18 +44,21 @@ trait ElasticSearchDAOSupport extends LazyLogging {\n \n   def makeMapping(attributeJson: String): String = {\n     val definition = attributeJson.parseJson.convertTo[AttributeDefinition]\n-    val maps = definition.properties map { case (label: String, detail: AttributeDetail) =>\n-      detailFromAttribute(label, detail)\n+    val attributeDetailMap = definition.properties map {\n+      case (label: String, detail: AttributeDetail) if detail.indexable.getOrElse(true) =>\n+        detailFromAttribute(label, detail)\n     }\n-    ESDatasetProperty(maps).toJson.prettyPrint\n+    ESDatasetProperty(attributeDetailMap).toJson.prettyPrint\n   }\n \n-  def detailFromAttribute(label: String, detail: AttributeDetail) = {\n+  def detailFromAttribute(label: String, detail: AttributeDetail): (String, ESPropertyFields) = {\n+    val itemType = detail match {\n+      case x if x.`type` == \"array\" && x.items.isDefined => x.items.get.`type`\n+      case x => x.`type`","path":"src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/ElasticSearchDAOSupport.scala","position":18,"original_position":18,"commit_id":"a55058032bb6f263194a2a28da011be997c4e068","original_commit_id":"a55058032bb6f263194a2a28da011be997c4e068","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"this needs to be safer, something like `case _ => detail.type`","created_at":"2016-12-09T14:45:34Z","updated_at":"2016-12-09T14:45:34Z","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/330#discussion_r91727660","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/91727660"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/330#discussion_r91727660"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330","id":97190032,"html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/330","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/330.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/330.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/330","number":330,"state":"open","locked":false,"title":"LMSVN stuff for orchestration","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"See  https://broadinstitute.atlassian.net/browse/GAWB-1352\r\nCompanion UI PR: https://github.com/broadinstitute/firecloud-ui/pull/600\r\n\r\nAdd a new property that is not meant to be sent to ES nor is meant to be user-editable. \r\n\r\n---\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: If updating admin endpoints, also update [firecloud-admin-cli](https://github.com/broadinstitute/firecloud-admin-cli)\r\n- [x] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [x] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * Add notes on what you've tested\r\n- [x] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [x] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [x] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [x] Tell the tech lead (TL) that the PR exists if they wants to look at it\r\n- [ ] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n","created_at":"2016-12-08T19:59:31Z","updated_at":"2016-12-09T14:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1464a458b0394809e8bfcb61e7002d24c4af25e","assignee":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/330/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/a55058032bb6f263194a2a28da011be997c4e068","head":{"label":"broadinstitute:gr-GAWB-1352-lmsvn","ref":"gr-GAWB-1352-lmsvn","sha":"a55058032bb6f263194a2a28da011be997c4e068","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-11-04T19:53:38Z","pushed_at":"2016-12-09T14:07:22Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":1542,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":8,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"30de26f0d9b41631556a324ca96d7c299260635b","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-11-04T19:53:38Z","pushed_at":"2016-12-09T14:07:22Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":1542,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/330"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/330"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/a55058032bb6f263194a2a28da011be997c4e068"}}}}
{"actor":{"display_login":"rushtong"}}