{"action":"created","issue":{"url":"https://api.github.com/repos/neovim/neovim/issues/4389","repository_url":"https://api.github.com/repos/neovim/neovim","labels_url":"https://api.github.com/repos/neovim/neovim/issues/4389/labels{/name}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/4389/comments","events_url":"https://api.github.com/repos/neovim/neovim/issues/4389/events","html_url":"https://github.com/neovim/neovim/pull/4389","id":137794761,"number":4389,"title":"[RFC] build: use cmake property COMPILE_DEFINITIONS","user":{"login":"Jun-T","id":7692465,"avatar_url":"https://avatars.githubusercontent.com/u/7692465?v=3","gravatar_id":"","url":"https://api.github.com/users/Jun-T","html_url":"https://github.com/Jun-T","followers_url":"https://api.github.com/users/Jun-T/followers","following_url":"https://api.github.com/users/Jun-T/following{/other_user}","gists_url":"https://api.github.com/users/Jun-T/gists{/gist_id}","starred_url":"https://api.github.com/users/Jun-T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jun-T/subscriptions","organizations_url":"https://api.github.com/users/Jun-T/orgs","repos_url":"https://api.github.com/users/Jun-T/repos","events_url":"https://api.github.com/users/Jun-T/events{/privacy}","received_events_url":"https://api.github.com/users/Jun-T/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neovim/neovim/labels/RFC","name":"RFC","color":"dfdfdf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-03-02T07:16:49Z","updated_at":"2016-03-04T18:36:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/4389","html_url":"https://github.com/neovim/neovim/pull/4389","diff_url":"https://github.com/neovim/neovim/pull/4389.diff","patch_url":"https://github.com/neovim/neovim/pull/4389.patch"},"body":"When I build nvim, I get an warning from cmake (Policy CMP0059), which says the property DEFINITIONS is deprecated and COMPILE_DEFINITIONS should be used instead.\r\n\r\nCOMPILE_DEFINITIONS already exist at least in cmake 2.8.7."},"comment":{"url":"https://api.github.com/repos/neovim/neovim/issues/comments/192400519","html_url":"https://github.com/neovim/neovim/pull/4389#issuecomment-192400519","issue_url":"https://api.github.com/repos/neovim/neovim/issues/4389","id":192400519,"user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T18:36:35Z","updated_at":"2016-03-04T18:36:35Z","body":"http://stackoverflow.com/a/31075623/152142 mentions `target_compile_options()` and `add_compile_options()` are available since cmake 2.8.12. Maybe those would help?"}}