{"action":"created","comment":{"url":"https://api.github.com/repos/dedis/crypto/pulls/comments/66759707","id":66759707,"diff_hunk":"@@ -39,6 +40,10 @@ type Suite interface {\n \t// Generic constructor to instantiate any abstract interface type\n \t// supported by this suite: at least Cipher, Hash, Point, Secret.\n \tConstructor\n+\n+\t// NewKey returns a freshly generated private key from the cipher stream.\n+\t// If cipher == nil, it uses random.Stream.\n+\tNewKey(cipher.Stream) Secret\n }","path":"abstract/suite.go","position":16,"original_position":16,"commit_id":"c16cffa1c621ffc1c3253f518a36a70a6fe849a4","original_commit_id":"84c71935df45fdf6df1235fdd6aacbff41e58abf","user":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"body":"I went for the simplest. We could also have done `NewKeyPair(cipher.Stream) config.KeyPair` but config package already uses abstract, so that would mean to move the `config.KeyPair` into abstract which do not seem something that has to be done in this PR... :)","created_at":"2016-06-13T09:04:26Z","updated_at":"2016-06-13T09:04:26Z","html_url":"https://github.com/dedis/crypto/pull/72#discussion_r66759707","pull_request_url":"https://api.github.com/repos/dedis/crypto/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/dedis/crypto/pulls/comments/66759707"},"html":{"href":"https://github.com/dedis/crypto/pull/72#discussion_r66759707"},"pull_request":{"href":"https://api.github.com/repos/dedis/crypto/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/dedis/crypto/pulls/72","id":73206323,"html_url":"https://github.com/dedis/crypto/pull/72","diff_url":"https://github.com/dedis/crypto/pull/72.diff","patch_url":"https://github.com/dedis/crypto/pull/72.patch","issue_url":"https://api.github.com/repos/dedis/crypto/issues/72","number":72,"state":"open","locked":false,"title":"Final version: Ed25519 with EdDSA compatibility","user":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"body":"Finally after some talks, this is the right PR where we do the compatibility with EdDSA. I will delete #68 #69 #71 .","created_at":"2016-06-09T12:40:32Z","updated_at":"2016-06-13T09:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"333766c7e23a2103c5f0323d2394b9951cb9cb95","assignee":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dedis/crypto/pulls/72/commits","review_comments_url":"https://api.github.com/repos/dedis/crypto/pulls/72/comments","review_comment_url":"https://api.github.com/repos/dedis/crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dedis/crypto/issues/72/comments","statuses_url":"https://api.github.com/repos/dedis/crypto/statuses/c16cffa1c621ffc1c3253f518a36a70a6fe849a4","head":{"label":"dedis:format_25519","ref":"format_25519","sha":"c16cffa1c621ffc1c3253f518a36a70a6fe849a4","user":{"login":"dedis","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":25253455,"name":"crypto","full_name":"dedis/crypto","owner":{"login":"dedis","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/crypto","description":"Advanced crypto library for the Go language","fork":false,"url":"https://api.github.com/repos/dedis/crypto","forks_url":"https://api.github.com/repos/dedis/crypto/forks","keys_url":"https://api.github.com/repos/dedis/crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/crypto/teams","hooks_url":"https://api.github.com/repos/dedis/crypto/hooks","issue_events_url":"https://api.github.com/repos/dedis/crypto/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/crypto/events","assignees_url":"https://api.github.com/repos/dedis/crypto/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/crypto/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/crypto/tags","blobs_url":"https://api.github.com/repos/dedis/crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/crypto/languages","stargazers_url":"https://api.github.com/repos/dedis/crypto/stargazers","contributors_url":"https://api.github.com/repos/dedis/crypto/contributors","subscribers_url":"https://api.github.com/repos/dedis/crypto/subscribers","subscription_url":"https://api.github.com/repos/dedis/crypto/subscription","commits_url":"https://api.github.com/repos/dedis/crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/crypto/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/crypto/merges","archive_url":"https://api.github.com/repos/dedis/crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/crypto/downloads","issues_url":"https://api.github.com/repos/dedis/crypto/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/crypto/labels{/name}","releases_url":"https://api.github.com/repos/dedis/crypto/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/crypto/deployments","created_at":"2014-10-15T12:25:03Z","updated_at":"2016-06-06T16:54:11Z","pushed_at":"2016-06-13T09:02:56Z","git_url":"git://github.com/dedis/crypto.git","ssh_url":"git@github.com:dedis/crypto.git","clone_url":"https://github.com/dedis/crypto.git","svn_url":"https://github.com/dedis/crypto","homepage":null,"size":7598,"stargazers_count":56,"watchers_count":56,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":13,"forks":15,"open_issues":13,"watchers":56,"default_branch":"master"}},"base":{"label":"dedis:master","ref":"master","sha":"ce549eb62f312d2d1755c13d5191f4e540036ff1","user":{"login":"dedis","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":25253455,"name":"crypto","full_name":"dedis/crypto","owner":{"login":"dedis","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/crypto","description":"Advanced crypto library for the Go language","fork":false,"url":"https://api.github.com/repos/dedis/crypto","forks_url":"https://api.github.com/repos/dedis/crypto/forks","keys_url":"https://api.github.com/repos/dedis/crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/crypto/teams","hooks_url":"https://api.github.com/repos/dedis/crypto/hooks","issue_events_url":"https://api.github.com/repos/dedis/crypto/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/crypto/events","assignees_url":"https://api.github.com/repos/dedis/crypto/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/crypto/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/crypto/tags","blobs_url":"https://api.github.com/repos/dedis/crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/crypto/languages","stargazers_url":"https://api.github.com/repos/dedis/crypto/stargazers","contributors_url":"https://api.github.com/repos/dedis/crypto/contributors","subscribers_url":"https://api.github.com/repos/dedis/crypto/subscribers","subscription_url":"https://api.github.com/repos/dedis/crypto/subscription","commits_url":"https://api.github.com/repos/dedis/crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/crypto/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/crypto/merges","archive_url":"https://api.github.com/repos/dedis/crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/crypto/downloads","issues_url":"https://api.github.com/repos/dedis/crypto/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/crypto/labels{/name}","releases_url":"https://api.github.com/repos/dedis/crypto/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/crypto/deployments","created_at":"2014-10-15T12:25:03Z","updated_at":"2016-06-06T16:54:11Z","pushed_at":"2016-06-13T09:02:56Z","git_url":"git://github.com/dedis/crypto.git","ssh_url":"git@github.com:dedis/crypto.git","clone_url":"https://github.com/dedis/crypto.git","svn_url":"https://github.com/dedis/crypto","homepage":null,"size":7598,"stargazers_count":56,"watchers_count":56,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":13,"forks":15,"open_issues":13,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dedis/crypto/pulls/72"},"html":{"href":"https://github.com/dedis/crypto/pull/72"},"issue":{"href":"https://api.github.com/repos/dedis/crypto/issues/72"},"comments":{"href":"https://api.github.com/repos/dedis/crypto/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/dedis/crypto/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/dedis/crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dedis/crypto/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/dedis/crypto/statuses/c16cffa1c621ffc1c3253f518a36a70a6fe849a4"}}}}
{"actor":{"display_login":"nikkolasg"}}