{"action":"created","issue":{"url":"https://api.github.com/repos/ghcjs/shims/issues/25","repository_url":"https://api.github.com/repos/ghcjs/shims","labels_url":"https://api.github.com/repos/ghcjs/shims/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/ghcjs/shims/issues/25/comments","events_url":"https://api.github.com/repos/ghcjs/shims/issues/25/events","html_url":"https://github.com/ghcjs/shims/pull/25","id":111950083,"number":25,"title":"make it work with reactive-banana again","user":{"login":"alios","id":234928,"avatar_url":"https://avatars.githubusercontent.com/u/234928?v=3","gravatar_id":"","url":"https://api.github.com/users/alios","html_url":"https://github.com/alios","followers_url":"https://api.github.com/users/alios/followers","following_url":"https://api.github.com/users/alios/following{/other_user}","gists_url":"https://api.github.com/users/alios/gists{/gist_id}","starred_url":"https://api.github.com/users/alios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alios/subscriptions","organizations_url":"https://api.github.com/users/alios/orgs","repos_url":"https://api.github.com/users/alios/repos","events_url":"https://api.github.com/users/alios/events{/privacy}","received_events_url":"https://api.github.com/users/alios/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2015-10-17T08:06:01Z","updated_at":"2016-07-20T12:32:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ghcjs/shims/pulls/25","html_url":"https://github.com/ghcjs/shims/pull/25","diff_url":"https://github.com/ghcjs/shims/pull/25.diff","patch_url":"https://github.com/ghcjs/shims/pull/25.patch"},"body":"Hi @luite!\r\n\r\nWith this patch I made reactive-banana work again. It didn't actually include your very recent thread related patch, as they produce \"a uncaught excpetion: Thread aborted\" on startup of my application.\r\n\r\nBut with this small patch my reactive banana code works again without any problems."},"comment":{"url":"https://api.github.com/repos/ghcjs/shims/issues/comments/233935573","html_url":"https://github.com/ghcjs/shims/pull/25#issuecomment-233935573","issue_url":"https://api.github.com/repos/ghcjs/shims/issues/25","id":233935573,"user":{"login":"luite","id":354096,"avatar_url":"https://avatars.githubusercontent.com/u/354096?v=3","gravatar_id":"","url":"https://api.github.com/users/luite","html_url":"https://github.com/luite","followers_url":"https://api.github.com/users/luite/followers","following_url":"https://api.github.com/users/luite/following{/other_user}","gists_url":"https://api.github.com/users/luite/gists{/gist_id}","starred_url":"https://api.github.com/users/luite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luite/subscriptions","organizations_url":"https://api.github.com/users/luite/orgs","repos_url":"https://api.github.com/users/luite/repos","events_url":"https://api.github.com/users/luite/events{/privacy}","received_events_url":"https://api.github.com/users/luite/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T12:32:59Z","updated_at":"2016-07-20T12:32:59Z","body":"I closed the PR because at least the first version got rid of all finalization, so it didn't really fix the problem but replace it with a different one that is somewhat harder to spot (memory leak).\r\n\r\nThere have been a few small fixes wrt traversal of some heap objects (small arrays and some specific closure variables). Are you running the latest version of the master branch?\r\n\r\nIf you still have a problem, can you make a small program that demonstrates it. Ideally without any dependencies outside what `ghcjs-boot` installs. A node.js runnable (terminal) program that  just depends on `reactive-banana` may be usable too.\r\n"}}
{"actor":{"display_login":"luite"}}