{"action":"closed","number":14952,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/14952","id":78820848,"html_url":"https://github.com/angular/angular.js/pull/14952","diff_url":"https://github.com/angular/angular.js/pull/14952.diff","patch_url":"https://github.com/angular/angular.js/pull/14952.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/14952","number":14952,"state":"closed","locked":false,"title":"chore(*): switch from JSHint/JSCS to ESLint (+ other build-related changes)","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nA build-related refactor.\r\n\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nCode is linted via JSHint+JSCS.\r\n\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nCode is linted via ESLint.\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] ~~Tests for the changes have been added (for bug fixes / features)~~\r\n- [x] ~~Docs have been added / updated (for bug fixes / features)~~\r\n\r\n**Other information**:\r\nThis is not ready (there are still many ESLint violations) but since the changes are rather large, I'd like to get some feedback now.\r\n\r\nThere are a couple of build-related commits; submitting them as separate PRs would be difficult as they modify `package.json` and shrinkwrap file. It makes sense to land them separately and all but the last commit are small so it shouldn't case lots of problems in reviewing.\r\n","created_at":"2016-07-26T09:42:43Z","updated_at":"2016-08-05T20:19:25Z","closed_at":"2016-08-05T20:19:25Z","merged_at":null,"merge_commit_sha":"3e5c37163f81dfe1ef5dc16420a0a263af3587b4","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/90","html_url":"https://github.com/angular/angular.js/milestones/1.5.x","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/90/labels","id":1025270,"number":90,"title":"1.5.x","description":"","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":101,"closed_issues":183,"state":"open","created_at":"2015-03-17T12:15:49Z","updated_at":"2016-08-05T20:19:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/14952/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/14952/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14952/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/30c027e5fcdfda5a37c6cacd8985e88eadc7299e","head":{"label":"mgol:eslint-etc","ref":"eslint-etc","sha":"30c027e5fcdfda5a37c6cacd8985e88eadc7299e","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"repo":{"id":9753166,"name":"angular.js","full_name":"mgol/angular.js","owner":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgol/angular.js","description":"","fork":true,"url":"https://api.github.com/repos/mgol/angular.js","forks_url":"https://api.github.com/repos/mgol/angular.js/forks","keys_url":"https://api.github.com/repos/mgol/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgol/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgol/angular.js/teams","hooks_url":"https://api.github.com/repos/mgol/angular.js/hooks","issue_events_url":"https://api.github.com/repos/mgol/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/mgol/angular.js/events","assignees_url":"https://api.github.com/repos/mgol/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/mgol/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/mgol/angular.js/tags","blobs_url":"https://api.github.com/repos/mgol/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgol/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgol/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgol/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgol/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mgol/angular.js/languages","stargazers_url":"https://api.github.com/repos/mgol/angular.js/stargazers","contributors_url":"https://api.github.com/repos/mgol/angular.js/contributors","subscribers_url":"https://api.github.com/repos/mgol/angular.js/subscribers","subscription_url":"https://api.github.com/repos/mgol/angular.js/subscription","commits_url":"https://api.github.com/repos/mgol/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgol/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgol/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgol/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgol/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/mgol/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgol/angular.js/merges","archive_url":"https://api.github.com/repos/mgol/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgol/angular.js/downloads","issues_url":"https://api.github.com/repos/mgol/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/mgol/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mgol/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mgol/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgol/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/mgol/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/mgol/angular.js/deployments","created_at":"2013-04-29T16:57:39Z","updated_at":"2015-04-27T20:42:39Z","pushed_at":"2016-08-05T19:44:28Z","git_url":"git://github.com/mgol/angular.js.git","ssh_url":"git@github.com:mgol/angular.js.git","clone_url":"https://github.com/mgol/angular.js.git","svn_url":"https://github.com/mgol/angular.js","homepage":"http://angularjs.org","size":71738,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1660ddd89e55351c74f28a35587e20735612bb26","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2016-08-05T19:25:13Z","pushed_at":"2016-08-05T20:18:52Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":178146,"stargazers_count":51145,"watchers_count":51145,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24978,"mirror_url":null,"open_issues_count":883,"forks":24978,"open_issues":883,"watchers":51145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14952"},"html":{"href":"https://github.com/angular/angular.js/pull/14952"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/14952"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/14952/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14952/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14952/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/30c027e5fcdfda5a37c6cacd8985e88eadc7299e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":16,"review_comments":138,"commits":8,"additions":12904,"deletions":11414,"changed_files":311}}
{"actor":{"display_login":"mgol"}}