{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/53140032","id":53140032,"diff_hunk":"@@ -64,7 +63,7 @@ public function testDefaultValueRendering()\n \n     protected function getParentClass()\n     {\n-        if (version_compare(Kernel::VERSION, '2.8.0', '>=')) {\n+        if (class_exists('Symfony\\Component\\Form\\Extension\\Core\\Type\\RangeType')) {","path":"Tests/Form/Widget/FormSonataFilterChoiceWidgetTest.php","position":13,"original_position":13,"commit_id":"e7d6c59f8018a1ad15011486e7961479898af41b","original_commit_id":"e7d6c59f8018a1ad15011486e7961479898af41b","user":{"login":"dnoise","id":929535,"avatar_url":"https://avatars.githubusercontent.com/u/929535?v=3","gravatar_id":"","url":"https://api.github.com/users/dnoise","html_url":"https://github.com/dnoise","followers_url":"https://api.github.com/users/dnoise/followers","following_url":"https://api.github.com/users/dnoise/following{/other_user}","gists_url":"https://api.github.com/users/dnoise/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoise/subscriptions","organizations_url":"https://api.github.com/users/dnoise/orgs","repos_url":"https://api.github.com/users/dnoise/repos","events_url":"https://api.github.com/users/dnoise/events{/privacy}","received_events_url":"https://api.github.com/users/dnoise/received_events","type":"User","site_admin":false},"body":"you mean this check?\r\n```\r\n if (!method_exists('Symfony\\Component\\Form\\FormTypeInterface', 'setDefaultOptions')) {\r\n            $choices = array_flip($choices);\r\n        }\r\n```\r\n\r\n[source code](https://github.com/sonata-project/SonataAdminBundle/blob/ecd83ff1f77b42758ad50b6cc3b9ec933b2da56e/Form/Type/Filter/ChoiceType.php#L75)","created_at":"2016-02-17T09:40:00Z","updated_at":"2016-02-17T09:40:00Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3597#discussion_r53140032","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/53140032"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3597#discussion_r53140032"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597","id":59614028,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3597","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3597.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3597.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3597","number":3597,"state":"open","locked":false,"title":"Remove method version_compare used on Form component integration tests","user":{"login":"rafaelcalleja","id":3765194,"avatar_url":"https://avatars.githubusercontent.com/u/3765194?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelcalleja","html_url":"https://github.com/rafaelcalleja","followers_url":"https://api.github.com/users/rafaelcalleja/followers","following_url":"https://api.github.com/users/rafaelcalleja/following{/other_user}","gists_url":"https://api.github.com/users/rafaelcalleja/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelcalleja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelcalleja/subscriptions","organizations_url":"https://api.github.com/users/rafaelcalleja/orgs","repos_url":"https://api.github.com/users/rafaelcalleja/repos","events_url":"https://api.github.com/users/rafaelcalleja/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelcalleja/received_events","type":"User","site_admin":false},"body":"Related to a [comment](https://github.com/sonata-project/SonataAdminBundle/pull/3585#issuecomment-184741402) on #3585 \r\n\r\n> This PR is not valid, version_compare should not be used even if on tests.\r\n\r\n@Soullivaneuh  it's ok?","created_at":"2016-02-17T09:05:58Z","updated_at":"2016-02-17T09:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19834653b8957a11b0f08964eeae2a70f7475721","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3597/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/e7d6c59f8018a1ad15011486e7961479898af41b","head":{"label":"rafaelcalleja:PR_refactor_integration_test","ref":"PR_refactor_integration_test","sha":"e7d6c59f8018a1ad15011486e7961479898af41b","user":{"login":"rafaelcalleja","id":3765194,"avatar_url":"https://avatars.githubusercontent.com/u/3765194?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelcalleja","html_url":"https://github.com/rafaelcalleja","followers_url":"https://api.github.com/users/rafaelcalleja/followers","following_url":"https://api.github.com/users/rafaelcalleja/following{/other_user}","gists_url":"https://api.github.com/users/rafaelcalleja/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelcalleja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelcalleja/subscriptions","organizations_url":"https://api.github.com/users/rafaelcalleja/orgs","repos_url":"https://api.github.com/users/rafaelcalleja/repos","events_url":"https://api.github.com/users/rafaelcalleja/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelcalleja/received_events","type":"User","site_admin":false},"repo":{"id":51510479,"name":"SonataAdminBundle","full_name":"rafaelcalleja/SonataAdminBundle","owner":{"login":"rafaelcalleja","id":3765194,"avatar_url":"https://avatars.githubusercontent.com/u/3765194?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelcalleja","html_url":"https://github.com/rafaelcalleja","followers_url":"https://api.github.com/users/rafaelcalleja/followers","following_url":"https://api.github.com/users/rafaelcalleja/following{/other_user}","gists_url":"https://api.github.com/users/rafaelcalleja/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelcalleja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelcalleja/subscriptions","organizations_url":"https://api.github.com/users/rafaelcalleja/orgs","repos_url":"https://api.github.com/users/rafaelcalleja/repos","events_url":"https://api.github.com/users/rafaelcalleja/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelcalleja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafaelcalleja/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle","forks_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/rafaelcalleja/SonataAdminBundle/deployments","created_at":"2016-02-11T11:28:45Z","updated_at":"2016-02-11T11:28:48Z","pushed_at":"2016-02-17T09:00:35Z","git_url":"git://github.com/rafaelcalleja/SonataAdminBundle.git","ssh_url":"git@github.com:rafaelcalleja/SonataAdminBundle.git","clone_url":"https://github.com/rafaelcalleja/SonataAdminBundle.git","svn_url":"https://github.com/rafaelcalleja/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":16827,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"0e12021c04c15385a93104c7a6cf67034ae6537b","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-02-16T20:52:26Z","pushed_at":"2016-02-17T09:05:59Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":19527,"stargazers_count":1312,"watchers_count":1312,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":946,"mirror_url":null,"open_issues_count":472,"forks":946,"open_issues":472,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3597"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3597"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3597/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3597/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/e7d6c59f8018a1ad15011486e7961479898af41b"}}}}