{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments/81124177","pull_request_review_id":2126490,"id":81124177,"diff_hunk":"@@ -26,7 +26,8 @@\n     default   => $package,\n   }\n \n-  if $::operatingsystem == 'Ubuntu' {\n+  # Default PHP come with xml module and no seperate package for it\n+  if $::operatingsystem == 'Ubuntu' and $::operatingsystemrelease >= '16.04'  {","path":"manifests/dev.pp","position":6,"original_position":6,"commit_id":"55059b98e76b91c8dbc2360bd7fdce27afb98696","original_commit_id":"55059b98e76b91c8dbc2360bd7fdce27afb98696","user":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"can you use versioncompare here instead of >=?","created_at":"2016-09-29T12:27:16Z","updated_at":"2016-09-29T12:32:04Z","html_url":"https://github.com/voxpupuli/puppet-php/pull/251#discussion_r81124177","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments/81124177"},"html":{"href":"https://github.com/voxpupuli/puppet-php/pull/251#discussion_r81124177"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251","id":87302548,"html_url":"https://github.com/voxpupuli/puppet-php/pull/251","diff_url":"https://github.com/voxpupuli/puppet-php/pull/251.diff","patch_url":"https://github.com/voxpupuli/puppet-php/pull/251.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/251","number":251,"state":"open","locked":false,"title":"Update module Ubuntu 14.04 default to official repository setup","user":{"login":"jk2l","id":228408,"avatar_url":"https://avatars.githubusercontent.com/u/228408?v=3","gravatar_id":"","url":"https://api.github.com/users/jk2l","html_url":"https://github.com/jk2l","followers_url":"https://api.github.com/users/jk2l/followers","following_url":"https://api.github.com/users/jk2l/following{/other_user}","gists_url":"https://api.github.com/users/jk2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jk2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jk2l/subscriptions","organizations_url":"https://api.github.com/users/jk2l/orgs","repos_url":"https://api.github.com/users/jk2l/repos","events_url":"https://api.github.com/users/jk2l/events{/privacy}","received_events_url":"https://api.github.com/users/jk2l/received_events","type":"User","site_admin":false},"body":"Fix for Ubuntu 14.04 Php installation:\r\n\r\nSummary:\r\n* The currents rule only work for PPA. Using 14.04 Official Ubuntu repository does not match any of the rules. \r\n* Removed 14.10 from metadata. It is in EOL and thing can randomly break. \r\n* Removed 12.04 from metadata. Default installation is 5.3, this module won't support any of it","created_at":"2016-09-29T12:24:04Z","updated_at":"2016-09-29T12:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"363f4568acc5ab4736d352e71364877c82910ad9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/251/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/55059b98e76b91c8dbc2360bd7fdce27afb98696","head":{"label":"jk2l:ubuntu","ref":"ubuntu","sha":"55059b98e76b91c8dbc2360bd7fdce27afb98696","user":{"login":"jk2l","id":228408,"avatar_url":"https://avatars.githubusercontent.com/u/228408?v=3","gravatar_id":"","url":"https://api.github.com/users/jk2l","html_url":"https://github.com/jk2l","followers_url":"https://api.github.com/users/jk2l/followers","following_url":"https://api.github.com/users/jk2l/following{/other_user}","gists_url":"https://api.github.com/users/jk2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jk2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jk2l/subscriptions","organizations_url":"https://api.github.com/users/jk2l/orgs","repos_url":"https://api.github.com/users/jk2l/repos","events_url":"https://api.github.com/users/jk2l/events{/privacy}","received_events_url":"https://api.github.com/users/jk2l/received_events","type":"User","site_admin":false},"repo":{"id":68575097,"name":"puppet-php","full_name":"jk2l/puppet-php","owner":{"login":"jk2l","id":228408,"avatar_url":"https://avatars.githubusercontent.com/u/228408?v=3","gravatar_id":"","url":"https://api.github.com/users/jk2l","html_url":"https://github.com/jk2l","followers_url":"https://api.github.com/users/jk2l/followers","following_url":"https://api.github.com/users/jk2l/following{/other_user}","gists_url":"https://api.github.com/users/jk2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jk2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jk2l/subscriptions","organizations_url":"https://api.github.com/users/jk2l/orgs","repos_url":"https://api.github.com/users/jk2l/repos","events_url":"https://api.github.com/users/jk2l/events{/privacy}","received_events_url":"https://api.github.com/users/jk2l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jk2l/puppet-php","description":"Generic Puppet module to manage PHP on many platforms","fork":true,"url":"https://api.github.com/repos/jk2l/puppet-php","forks_url":"https://api.github.com/repos/jk2l/puppet-php/forks","keys_url":"https://api.github.com/repos/jk2l/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jk2l/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jk2l/puppet-php/teams","hooks_url":"https://api.github.com/repos/jk2l/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/jk2l/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/jk2l/puppet-php/events","assignees_url":"https://api.github.com/repos/jk2l/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/jk2l/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/jk2l/puppet-php/tags","blobs_url":"https://api.github.com/repos/jk2l/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jk2l/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jk2l/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/jk2l/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jk2l/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/jk2l/puppet-php/languages","stargazers_url":"https://api.github.com/repos/jk2l/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/jk2l/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/jk2l/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/jk2l/puppet-php/subscription","commits_url":"https://api.github.com/repos/jk2l/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/jk2l/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/jk2l/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/jk2l/puppet-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/jk2l/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/jk2l/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jk2l/puppet-php/merges","archive_url":"https://api.github.com/repos/jk2l/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jk2l/puppet-php/downloads","issues_url":"https://api.github.com/repos/jk2l/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/jk2l/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/jk2l/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/jk2l/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jk2l/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/jk2l/puppet-php/releases{/id}","deployments_url":"https://api.github.com/repos/jk2l/puppet-php/deployments","created_at":"2016-09-19T06:19:04Z","updated_at":"2016-09-19T06:19:05Z","pushed_at":"2016-09-29T12:18:58Z","git_url":"git://github.com/jk2l/puppet-php.git","ssh_url":"git@github.com:jk2l/puppet-php.git","clone_url":"https://github.com/jk2l/puppet-php.git","svn_url":"https://github.com/jk2l/puppet-php","homepage":"http://php.puppet.mayflower.de/","size":855,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"59e7525e23feca8a467a5abe20a6add28b8e383f","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":16954722,"name":"puppet-php","full_name":"voxpupuli/puppet-php","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-php","description":"Generic Puppet module to manage PHP on many platforms","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-php","forks_url":"https://api.github.com/repos/voxpupuli/puppet-php/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-php/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-php/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-php/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-php/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-php/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-php/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-php/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-php/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-php/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-php/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-php/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-php/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-php/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-php/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-php/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-php/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-php/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-php/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-php/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-php/deployments","created_at":"2014-02-18T16:06:24Z","updated_at":"2016-09-11T22:17:02Z","pushed_at":"2016-09-29T12:24:04Z","git_url":"git://github.com/voxpupuli/puppet-php.git","ssh_url":"git@github.com:voxpupuli/puppet-php.git","clone_url":"https://github.com/voxpupuli/puppet-php.git","svn_url":"https://github.com/voxpupuli/puppet-php","homepage":"http://php.puppet.mayflower.de/","size":935,"stargazers_count":53,"watchers_count":53,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":36,"forks":104,"open_issues":36,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251"},"html":{"href":"https://github.com/voxpupuli/puppet-php/pull/251"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/issues/251"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-php/statuses/55059b98e76b91c8dbc2360bd7fdce27afb98696"}}}}
{"actor":{"display_login":"bastelfreak"}}