{"action":"created","comment":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/69912329","id":69912329,"diff_hunk":"@@ -18,32 +18,19 @@ define('Core/Commander/Providers/IoDriver_Image', ['Core/Commander/Providers/IoD\n     IoDriver_Image.prototype.constructor = IoDriver_Image;\n \n     IoDriver_Image.prototype.read = function(url) {\n-\n         return new Promise(function(resolve/*, reject*/) {\n-\n             var image = new Image();\n \n             image.addEventListener('load', function(/*event*/) {\n-\n                 resolve(this);\n-\n-            }, false);\n-\n-            image.addEventListener('progress', function(/*event*/) {\n-\n             }, false);\n \n-\n             image.addEventListener('error', function(/*event*/) {\n-\n-                this.src = '';\n                 resolve(undefined);\n-\n-            }.bind(this), false);\n+            }, false);","path":"src/Core/Commander/Providers/IoDriver_Image.js","position":26,"original_position":26,"commit_id":"c840c8797edcdcc419e1b27ff2eac461d95ecb42","original_commit_id":"c840c8797edcdcc419e1b27ff2eac461d95ecb42","user":{"login":"tbroyer","id":173813,"avatar_url":"https://avatars.githubusercontent.com/u/173813?v=3","gravatar_id":"","url":"https://api.github.com/users/tbroyer","html_url":"https://github.com/tbroyer","followers_url":"https://api.github.com/users/tbroyer/followers","following_url":"https://api.github.com/users/tbroyer/following{/other_user}","gists_url":"https://api.github.com/users/tbroyer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbroyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbroyer/subscriptions","organizations_url":"https://api.github.com/users/tbroyer/orgs","repos_url":"https://api.github.com/users/tbroyer/repos","events_url":"https://api.github.com/users/tbroyer/events{/privacy}","received_events_url":"https://api.github.com/users/tbroyer/received_events","type":"User","site_admin":false},"body":"Unless the small changes (remove `progress` event handling, remove setting `src` to the empty-string) are needed (they might very-well be), maybe revert changes to this file?\r\n\r\n(either that or put them in a specific commit: this is no longer about standardizing on XHR or promise, this is already using promise; it's possibly –probably?– broken, but that's a different issue, so it deserves a distinct commit IMO)","created_at":"2016-07-07T14:06:28Z","updated_at":"2016-07-07T14:06:28Z","html_url":"https://github.com/iTowns/itowns2/pull/93#discussion_r69912329","pull_request_url":"https://api.github.com/repos/iTowns/itowns2/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/69912329"},"html":{"href":"https://github.com/iTowns/itowns2/pull/93#discussion_r69912329"},"pull_request":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/93","id":75841594,"html_url":"https://github.com/iTowns/itowns2/pull/93","diff_url":"https://github.com/iTowns/itowns2/pull/93.diff","patch_url":"https://github.com/iTowns/itowns2/pull/93.patch","issue_url":"https://api.github.com/repos/iTowns/itowns2/issues/93","number":93,"state":"open","locked":false,"title":"Unify usage of XMLHttpRequest and Promise","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"body":"XMLHttpRequestHelper module provides a simple method to fire a\r\nXMLHttpRequest so each driver doesn't need to implement this.\r\n\r\nAlso use Promise's reject method instead of resolve(undefined) in\r\ncase of error.\r\n\r\n@gchoqueux r?","created_at":"2016-06-30T15:34:43Z","updated_at":"2016-07-07T14:06:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70fb797376ad5b05e4cdde50ed4991ae5a61d588","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/iTowns/itowns2/pulls/93/commits","review_comments_url":"https://api.github.com/repos/iTowns/itowns2/pulls/93/comments","review_comment_url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iTowns/itowns2/issues/93/comments","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/c840c8797edcdcc419e1b27ff2eac461d95ecb42","head":{"label":"peppsac:xml_http_requester","ref":"xml_http_requester","sha":"c840c8797edcdcc419e1b27ff2eac461d95ecb42","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"repo":{"id":62058333,"name":"itowns2","full_name":"peppsac/itowns2","owner":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peppsac/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":true,"url":"https://api.github.com/repos/peppsac/itowns2","forks_url":"https://api.github.com/repos/peppsac/itowns2/forks","keys_url":"https://api.github.com/repos/peppsac/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peppsac/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peppsac/itowns2/teams","hooks_url":"https://api.github.com/repos/peppsac/itowns2/hooks","issue_events_url":"https://api.github.com/repos/peppsac/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/peppsac/itowns2/events","assignees_url":"https://api.github.com/repos/peppsac/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/peppsac/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/peppsac/itowns2/tags","blobs_url":"https://api.github.com/repos/peppsac/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peppsac/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peppsac/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/peppsac/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peppsac/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/peppsac/itowns2/languages","stargazers_url":"https://api.github.com/repos/peppsac/itowns2/stargazers","contributors_url":"https://api.github.com/repos/peppsac/itowns2/contributors","subscribers_url":"https://api.github.com/repos/peppsac/itowns2/subscribers","subscription_url":"https://api.github.com/repos/peppsac/itowns2/subscription","commits_url":"https://api.github.com/repos/peppsac/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/peppsac/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/peppsac/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/peppsac/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/peppsac/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/peppsac/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peppsac/itowns2/merges","archive_url":"https://api.github.com/repos/peppsac/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peppsac/itowns2/downloads","issues_url":"https://api.github.com/repos/peppsac/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/peppsac/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/peppsac/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/peppsac/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peppsac/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/peppsac/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/peppsac/itowns2/deployments","created_at":"2016-06-27T13:30:40Z","updated_at":"2016-07-01T09:55:15Z","pushed_at":"2016-07-07T13:41:56Z","git_url":"git://github.com/peppsac/itowns2.git","ssh_url":"git@github.com:peppsac/itowns2.git","clone_url":"https://github.com/peppsac/itowns2.git","svn_url":"https://github.com/peppsac/itowns2","homepage":"","size":60131,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"iTowns:master","ref":"master","sha":"8fb2ed8bd59ee3060db03c70cd095f7e687c4aeb","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-06-29T14:55:42Z","pushed_at":"2016-07-07T13:55:37Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":60251,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":77,"forks":10,"open_issues":77,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/93"},"html":{"href":"https://github.com/iTowns/itowns2/pull/93"},"issue":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/93"},"comments":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/iTowns/itowns2/statuses/c840c8797edcdcc419e1b27ff2eac461d95ecb42"}}}}
{"actor":{"display_login":"tbroyer"}}