{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/86605116","pull_request_review_id":7258245,"id":86605116,"diff_hunk":"@@ -0,0 +1,201 @@\n+{\n+  \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\n+  \"contentVersion\": \"1.0.0.0\",\n+  \"parameters\": {\n+    \"namePrefix\": {\n+      \"type\": \"string\",\n+      \"minLength\": 3,\n+      \"maxLength\": 8,\n+      \"metadata\": {\n+        \"description\": \"Naming prefix for each new resource created. 3-char min, 8-char max, lowercase alphanumeric\"\n+      }\n+    },\n+    \"storageAccountType\": {\n+      \"type\": \"string\",\n+      \"allowedValues\": [\n+        \"Standard_LRS\",\n+        \"Standard_GRS\",\n+        \"Standard_RAGRS\",\n+        \"Premium_LRS\"\n+      ],\n+      \"metadata\": {\n+        \"description\": \"Type of new Storage Accounts (Standard_LRS, Standard_GRS, Standard_RAGRS or Premium_LRS) to be created to store VM disks\"\n+      },\n+      \"defaultValue\": \"Premium_LRS\"\n+    },\n+    \"vmSize\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"Size of the S2D VMs to be created\"\n+      },\n+      \"defaultValue\": \"Standard_DS1_v2\"\n+    },\n+    \"vmCount\": {\n+\t\t\t\"type\": \"int\",\n+      \"minValue\": 2,\n+      \"maxValue\": 3,\n+      \"metadata\": {\n+        \"description\": \"Number of S2D VMs to be created in cluster (Min=2, Max=3)\"\n+      },\n+\t\t\t\"defaultValue\": 2\n+\t\t},\n+\t\t\"vmDiskSize\": {\n+\t\t\t\"type\": \"int\",\n+      \"minValue\": 128,\n+      \"maxValue\": 1023,\n+      \"metadata\": {\n+        \"description\": \"Size of each data disk in GB on each S2D VM (Min=128, Max=1023)\"\n+      },      \n+\t\t\t\"defaultValue\": 1023\n+\t\t},\n+    \"vmDiskCount\": {\n+\t\t\t\"type\": \"int\",\n+      \"minValue\": 2,\n+      \"maxValue\": 32,\n+      \"metadata\": {\n+        \"description\": \"Number of data disks on each S2D VM (Min=2, Max=32). Ensure that the VM size you've selected will support this number of data disks.\"\n+      },      \n+\t\t\t\"defaultValue\": 2\n+\t\t},\n+    \"existingDomainName\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"DNS domain name for existing Active Directory domain\"\n+      },\n+      \"defaultValue\": \"contoso.com\"\n+    },\n+    \"adminUsername\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"Name of the Administrator of the existing Active Directory Domain\"\n+      }\n+    },\n+    \"adminPassword\": {\n+      \"type\": \"securestring\",\n+      \"minLength\": 12,\n+      \"metadata\": {\n+        \"description\": \"Password for the Administrator account of the existing Active Directory Domain\"\n+      }\n+    },\n+    \"existingVirtualNetworkRGName\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"Resource Group Name for the existing VNET.\"\n+      },\n+      \"defaultValue\": \"rg01\"\n+    },\n+    \"existingVirtualNetworkName\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"Name of the existing VNET.\"\n+      },\n+      \"defaultValue\": \"vnet01\"\n+    },\n+    \"existingSubnetName\": {\n+      \"type\": \"string\",\n+      \"metadata\": {\n+        \"description\": \"Name of the existing subnet in the existing VNET to which the S2D VMs should be deployed\"\n+      },\n+      \"defaultValue\": \"default\"\n+    },\n+    \"sofsName\": {","path":"301-storage-spaces-direct/azuredeploy.json","position":101,"original_position":101,"commit_id":"cad28fbef436e3f185c4124dcbd8db75a89040a3","original_commit_id":"cad28fbef436e3f185c4124dcbd8db75a89040a3","user":{"login":"robotechredmond","id":15369150,"avatar_url":"https://avatars.githubusercontent.com/u/15369150?v=3","gravatar_id":"","url":"https://api.github.com/users/robotechredmond","html_url":"https://github.com/robotechredmond","followers_url":"https://api.github.com/users/robotechredmond/followers","following_url":"https://api.github.com/users/robotechredmond/following{/other_user}","gists_url":"https://api.github.com/users/robotechredmond/gists{/gist_id}","starred_url":"https://api.github.com/users/robotechredmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotechredmond/subscriptions","organizations_url":"https://api.github.com/users/robotechredmond/orgs","repos_url":"https://api.github.com/users/robotechredmond/repos","events_url":"https://api.github.com/users/robotechredmond/events{/privacy}","received_events_url":"https://api.github.com/users/robotechredmond/received_events","type":"User","site_admin":false},"body":"sofsName is not globally unique.","created_at":"2016-11-04T18:21:33Z","updated_at":"2016-11-04T18:21:33Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2715#discussion_r86605116","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/86605116"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2715#discussion_r86605116"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715","id":92040484,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/2715","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/2715.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/2715.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2715","number":2715,"state":"open","locked":false,"title":"New template for Windows Server 2016 S2D with SOFS cluster","user":{"login":"robotechredmond","id":15369150,"avatar_url":"https://avatars.githubusercontent.com/u/15369150?v=3","gravatar_id":"","url":"https://api.github.com/users/robotechredmond","html_url":"https://github.com/robotechredmond","followers_url":"https://api.github.com/users/robotechredmond/followers","following_url":"https://api.github.com/users/robotechredmond/following{/other_user}","gists_url":"https://api.github.com/users/robotechredmond/gists{/gist_id}","starred_url":"https://api.github.com/users/robotechredmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotechredmond/subscriptions","organizations_url":"https://api.github.com/users/robotechredmond/orgs","repos_url":"https://api.github.com/users/robotechredmond/repos","events_url":"https://api.github.com/users/robotechredmond/events{/privacy}","received_events_url":"https://api.github.com/users/robotechredmond/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-11-02T19:37:17Z","updated_at":"2016-11-04T18:21:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7c79739b2937526787029d1b9a3e1edf7aeebb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2715/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/cad28fbef436e3f185c4124dcbd8db75a89040a3","head":{"label":"robotechredmond:master","ref":"master","sha":"cad28fbef436e3f185c4124dcbd8db75a89040a3","user":{"login":"robotechredmond","id":15369150,"avatar_url":"https://avatars.githubusercontent.com/u/15369150?v=3","gravatar_id":"","url":"https://api.github.com/users/robotechredmond","html_url":"https://github.com/robotechredmond","followers_url":"https://api.github.com/users/robotechredmond/followers","following_url":"https://api.github.com/users/robotechredmond/following{/other_user}","gists_url":"https://api.github.com/users/robotechredmond/gists{/gist_id}","starred_url":"https://api.github.com/users/robotechredmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotechredmond/subscriptions","organizations_url":"https://api.github.com/users/robotechredmond/orgs","repos_url":"https://api.github.com/users/robotechredmond/repos","events_url":"https://api.github.com/users/robotechredmond/events{/privacy}","received_events_url":"https://api.github.com/users/robotechredmond/received_events","type":"User","site_admin":false},"repo":{"id":45144304,"name":"azure-quickstart-templates","full_name":"robotechredmond/azure-quickstart-templates","owner":{"login":"robotechredmond","id":15369150,"avatar_url":"https://avatars.githubusercontent.com/u/15369150?v=3","gravatar_id":"","url":"https://api.github.com/users/robotechredmond","html_url":"https://github.com/robotechredmond","followers_url":"https://api.github.com/users/robotechredmond/followers","following_url":"https://api.github.com/users/robotechredmond/following{/other_user}","gists_url":"https://api.github.com/users/robotechredmond/gists{/gist_id}","starred_url":"https://api.github.com/users/robotechredmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotechredmond/subscriptions","organizations_url":"https://api.github.com/users/robotechredmond/orgs","repos_url":"https://api.github.com/users/robotechredmond/repos","events_url":"https://api.github.com/users/robotechredmond/events{/privacy}","received_events_url":"https://api.github.com/users/robotechredmond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robotechredmond/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates","forks_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/robotechredmond/azure-quickstart-templates/deployments","created_at":"2015-10-28T21:57:37Z","updated_at":"2016-10-28T17:09:19Z","pushed_at":"2016-11-02T19:37:17Z","git_url":"git://github.com/robotechredmond/azure-quickstart-templates.git","ssh_url":"git@github.com:robotechredmond/azure-quickstart-templates.git","clone_url":"https://github.com/robotechredmond/azure-quickstart-templates.git","svn_url":"https://github.com/robotechredmond/azure-quickstart-templates","homepage":null,"size":142855,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"bf86743a1af046e8e64f3b1cf686bc7228ed0997","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2016-11-04T15:33:25Z","pushed_at":"2016-11-04T18:21:17Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":177906,"stargazers_count":1547,"watchers_count":1547,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2187,"mirror_url":null,"open_issues_count":230,"forks":2187,"open_issues":230,"watchers":1547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/2715"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2715"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/2715/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/2715/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/cad28fbef436e3f185c4124dcbd8db75a89040a3"}}}}
{"actor":{"display_login":"robotechredmond"}}