{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/immutable-js/pulls/comments/91883748","pull_request_review_id":12392102,"id":91883748,"diff_hunk":"@@ -526,8 +526,14 @@ declare module 'immutable' {\n     updateIn(keyPath: ESIterable<any>, notSetValue: any, value: any): Map<K,V>;\n     updateIn(keyPath: ESIterable<any>, value: any): Map<K,V>;\n \n-    mergeIn(keyPath: ESIterable<any>, ...iterables: ESIterable<any>[]): Map<K,V>;\n-    mergeDeepIn(keyPath: ESIterable<any>, ...iterables: ESIterable<any>[]): Map<K,V>;\n+    mergeIn(\n+      keyPath: ESIterable<any>,\n+      ...iterables: (ESIterable<any> | { [key: string]: any })[]\n+    ): Map<K,V>;","path":"type-definitions/immutable.js.flow","position":9,"original_position":9,"commit_id":"2d26e0ca5b44fc2fa0c63e102b91faf07b2f291e","original_commit_id":"2d26e0ca5b44fc2fa0c63e102b91faf07b2f291e","user":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"body":"I used `any` b/c of this: http://facebook.github.io/immutable-js/docs/#/Map/merge\r\n\r\n```\r\nIf any of the values provided to merge are not Iterable (would return false for Immutable.Iterable.isIterable) then they are deeply converted via Immutable.fromJS before being merged. However, if the value is an Iterable but includes non-iterable JS objects or arrays, those nested values will be preserved.\r\n```\r\n\r\nSo if `V` is also `Map` or `List`, I can pass `Object` or `Array` as `V` and it still should be valid as it will be converted to `Map` or `List` by `fromJS`.","created_at":"2016-12-12T05:06:04Z","updated_at":"2016-12-12T05:06:04Z","html_url":"https://github.com/facebook/immutable-js/pull/987#discussion_r91883748","pull_request_url":"https://api.github.com/repos/facebook/immutable-js/pulls/987","_links":{"self":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/comments/91883748"},"html":{"href":"https://github.com/facebook/immutable-js/pull/987#discussion_r91883748"},"pull_request":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/987"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/immutable-js/pulls/987","id":88244120,"html_url":"https://github.com/facebook/immutable-js/pull/987","diff_url":"https://github.com/facebook/immutable-js/pull/987.diff","patch_url":"https://github.com/facebook/immutable-js/pull/987.patch","issue_url":"https://api.github.com/repos/facebook/immutable-js/issues/987","number":987,"state":"open","locked":false,"title":"[Flow]: Add JS objects to Map.mergeIn & Map.mergeDeepIn","user":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"body":"Adds vanilla JS objects to flow typings of `Immutable.Map`'s `mergeIn` & `mergeDeepIn`.\n","created_at":"2016-10-06T11:29:13Z","updated_at":"2016-12-12T05:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7f8bf82793fe75b0335c18e1a39e05ca3b69da1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/immutable-js/pulls/987/commits","review_comments_url":"https://api.github.com/repos/facebook/immutable-js/pulls/987/comments","review_comment_url":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/immutable-js/issues/987/comments","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/2d26e0ca5b44fc2fa0c63e102b91faf07b2f291e","head":{"label":"alexfedoseev:add-js-objects-to-map-mergein-flowtypes","ref":"add-js-objects-to-map-mergein-flowtypes","sha":"2d26e0ca5b44fc2fa0c63e102b91faf07b2f291e","user":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"repo":{"id":70144714,"name":"immutable-js","full_name":"alexfedoseev/immutable-js","owner":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexfedoseev/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":true,"url":"https://api.github.com/repos/alexfedoseev/immutable-js","forks_url":"https://api.github.com/repos/alexfedoseev/immutable-js/forks","keys_url":"https://api.github.com/repos/alexfedoseev/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexfedoseev/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexfedoseev/immutable-js/teams","hooks_url":"https://api.github.com/repos/alexfedoseev/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/alexfedoseev/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/alexfedoseev/immutable-js/events","assignees_url":"https://api.github.com/repos/alexfedoseev/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/alexfedoseev/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/alexfedoseev/immutable-js/tags","blobs_url":"https://api.github.com/repos/alexfedoseev/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexfedoseev/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexfedoseev/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexfedoseev/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexfedoseev/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/alexfedoseev/immutable-js/languages","stargazers_url":"https://api.github.com/repos/alexfedoseev/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/alexfedoseev/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/alexfedoseev/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/alexfedoseev/immutable-js/subscription","commits_url":"https://api.github.com/repos/alexfedoseev/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexfedoseev/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexfedoseev/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexfedoseev/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexfedoseev/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/alexfedoseev/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexfedoseev/immutable-js/merges","archive_url":"https://api.github.com/repos/alexfedoseev/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexfedoseev/immutable-js/downloads","issues_url":"https://api.github.com/repos/alexfedoseev/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/alexfedoseev/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/alexfedoseev/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/alexfedoseev/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexfedoseev/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/alexfedoseev/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/alexfedoseev/immutable-js/deployments","created_at":"2016-10-06T10:40:16Z","updated_at":"2016-10-06T10:40:18Z","pushed_at":"2016-12-12T02:45:22Z","git_url":"git://github.com/alexfedoseev/immutable-js.git","ssh_url":"git@github.com:alexfedoseev/immutable-js.git","clone_url":"https://github.com/alexfedoseev/immutable-js.git","svn_url":"https://github.com/alexfedoseev/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":17759,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0155f1c7b2e9c575b2090ff0e5e9093ae1039c87","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21413198,"name":"immutable-js","full_name":"facebook/immutable-js","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":false,"url":"https://api.github.com/repos/facebook/immutable-js","forks_url":"https://api.github.com/repos/facebook/immutable-js/forks","keys_url":"https://api.github.com/repos/facebook/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/immutable-js/teams","hooks_url":"https://api.github.com/repos/facebook/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/facebook/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/immutable-js/events","assignees_url":"https://api.github.com/repos/facebook/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/immutable-js/tags","blobs_url":"https://api.github.com/repos/facebook/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/immutable-js/languages","stargazers_url":"https://api.github.com/repos/facebook/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/facebook/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/facebook/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/facebook/immutable-js/subscription","commits_url":"https://api.github.com/repos/facebook/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/immutable-js/merges","archive_url":"https://api.github.com/repos/facebook/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/immutable-js/downloads","issues_url":"https://api.github.com/repos/facebook/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/facebook/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/immutable-js/deployments","created_at":"2014-07-02T06:02:29Z","updated_at":"2016-12-12T04:45:41Z","pushed_at":"2016-12-12T02:45:22Z","git_url":"git://github.com/facebook/immutable-js.git","ssh_url":"git@github.com:facebook/immutable-js.git","clone_url":"https://github.com/facebook/immutable-js.git","svn_url":"https://github.com/facebook/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":24178,"stargazers_count":16099,"watchers_count":16099,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":856,"mirror_url":null,"open_issues_count":270,"forks":856,"open_issues":270,"watchers":16099,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/987"},"html":{"href":"https://github.com/facebook/immutable-js/pull/987"},"issue":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/987"},"comments":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/987/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/987/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/987/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/immutable-js/statuses/2d26e0ca5b44fc2fa0c63e102b91faf07b2f291e"}}}}
{"actor":{"display_login":"alexfedoseev"}}