{"action":"created","issue":{"url":"https://api.github.com/repos/basho/riak_kv/issues/1420","repository_url":"https://api.github.com/repos/basho/riak_kv","labels_url":"https://api.github.com/repos/basho/riak_kv/issues/1420/labels{/name}","comments_url":"https://api.github.com/repos/basho/riak_kv/issues/1420/comments","events_url":"https://api.github.com/repos/basho/riak_kv/issues/1420/events","html_url":"https://github.com/basho/riak_kv/pull/1420","id":155786819,"number":1420,"title":"Clean up get/put FSM start code and remove non-sidejob code paths","user":{"login":"nickelization","id":4108538,"avatar_url":"https://avatars.githubusercontent.com/u/4108538?v=3","gravatar_id":"","url":"https://api.github.com/users/nickelization","html_url":"https://github.com/nickelization","followers_url":"https://api.github.com/users/nickelization/followers","following_url":"https://api.github.com/users/nickelization/following{/other_user}","gists_url":"https://api.github.com/users/nickelization/gists{/gist_id}","starred_url":"https://api.github.com/users/nickelization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickelization/subscriptions","organizations_url":"https://api.github.com/users/nickelization/orgs","repos_url":"https://api.github.com/users/nickelization/repos","events_url":"https://api.github.com/users/nickelization/events{/privacy}","received_events_url":"https://api.github.com/users/nickelization/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-05-19T17:02:21Z","updated_at":"2016-07-15T15:44:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/basho/riak_kv/pulls/1420","html_url":"https://github.com/basho/riak_kv/pull/1420","diff_url":"https://github.com/basho/riak_kv/pull/1420.diff","patch_url":"https://github.com/basho/riak_kv/pull/1420.patch"},"body":"This PR removes a bunch of code that allowed us to run riak_kv with sidejob disabled. None of our customers run with overload protection disabled, and now that sidejob has been pretty thoroughly vetted in production, we no longer need an escape hatch. Removing the non-sidejob code (as well as associated test code) will cut down on risk and maintenance costs. Performance should also be improved a little bit since we avoid having to do the extra check for sidejob vs non-sidejob when starting a get/put FSM.\r\n\r\nThese changes also remove the obsolete riak_kv_get_fsm and riak_kv_put_fsm supervisors, and renames the get/put FSM start_link functions to \"start\", since they don't actually link to the calling process. (Although the start_link function name is kept as an alias to avoid any potential problems during rolling upgrades.)"},"comment":{"url":"https://api.github.com/repos/basho/riak_kv/issues/comments/232988922","html_url":"https://github.com/basho/riak_kv/pull/1420#issuecomment-232988922","issue_url":"https://api.github.com/repos/basho/riak_kv/issues/1420","id":232988922,"user":{"login":"ian-mi","id":6137994,"avatar_url":"https://avatars.githubusercontent.com/u/6137994?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-mi","html_url":"https://github.com/ian-mi","followers_url":"https://api.github.com/users/ian-mi/followers","following_url":"https://api.github.com/users/ian-mi/following{/other_user}","gists_url":"https://api.github.com/users/ian-mi/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-mi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-mi/subscriptions","organizations_url":"https://api.github.com/users/ian-mi/orgs","repos_url":"https://api.github.com/users/ian-mi/repos","events_url":"https://api.github.com/users/ian-mi/events{/privacy}","received_events_url":"https://api.github.com/users/ian-mi/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T15:44:42Z","updated_at":"2016-07-15T15:44:42Z","body":"Sounds good.\r\n\r\n+1 3cea5ae"}}
{"actor":{"display_login":"ian-mi"}}