{"action":"created","comment":{"url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments/78429621","id":78429621,"diff_hunk":"@@ -614,6 +691,127 @@ def test_campaign_events(self):\n         response = self.fetchJSON(url, 'campaign=invalid')\n         self.assertResultsByUUID(response, [])\n \n+        # try to create empty campaign event\n+        response = self.postJSON(url, {})\n+        self.assertResponseError(response, 'campaign', \"This field is required.\")\n+        self.assertResponseError(response, 'relative_to', \"This field is required.\")\n+        self.assertResponseError(response, 'offset', \"This field is required.\")\n+        self.assertResponseError(response, 'unit', \"This field is required.\")\n+        self.assertResponseError(response, 'delivery_hour', \"This field is required.\")\n+\n+        # try again with some invalid values\n+        response = self.postJSON(url, {\n+            'campaign': campaign1.uuid,\n+            'relative_to': 'registration',\n+            'offset': 15,\n+            'unit': 'epocs',\n+            'delivery_hour': 25\n+        })\n+        self.assertResponseError(response, 'unit', \"\\\"epocs\\\" is not a valid choice.\")\n+        self.assertResponseError(response, 'delivery_hour', \"Ensure this value is less than or equal to 23.\")\n+\n+        # provide valid values for those fields.. but not a message or flow\n+        response = self.postJSON(url, {\n+            'campaign': campaign1.uuid,\n+            'relative_to': 'registration',\n+            'offset': 15,\n+            'unit': 'weeks',\n+            'delivery_hour': -1\n+        })\n+        self.assertResponseError(response, 'non_field_errors', \"Flow UUID or a message text required.\")\n+\n+        # create a message event\n+        response = self.postJSON(url, {\n+            'campaign': campaign1.uuid,\n+            'relative_to': 'registration',\n+            'offset': 15,\n+            'unit': 'weeks',\n+            'delivery_hour': -1,\n+            'message': \"Nice job\"\n+        })\n+        self.assertEqual(response.status_code, 201)\n+\n+        event1 = CampaignEvent.objects.get(campaign=campaign1, message=\"Nice job\")\n+        self.assertEqual(event1.event_type, CampaignEvent.TYPE_MESSAGE)\n+        self.assertEqual(event1.relative_to, registration)\n+        self.assertEqual(event1.offset, 15)\n+        self.assertEqual(event1.unit, 'W')\n+        self.assertEqual(event1.delivery_hour, -1)\n+\n+        # create a flow event\n+        response = self.postJSON(url, {\n+            'campaign': campaign1.uuid,\n+            'relative_to': 'registration',\n+            'offset': 15,\n+            'unit': 'weeks',\n+            'delivery_hour': -1,\n+            'flow': flow.uuid\n+        })\n+        self.assertEqual(response.status_code, 201)","path":"temba/api/tests/test_v2.py","position":195,"original_position":196,"commit_id":"71ef6ee82e60e0ddd076c16040ad371ad63af435","original_commit_id":"3e6bf252166d5f3d0bc715af697585e5e5e04c90","user":{"login":"ericnewcomer","id":211652,"avatar_url":"https://avatars.githubusercontent.com/u/211652?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnewcomer","html_url":"https://github.com/ericnewcomer","followers_url":"https://api.github.com/users/ericnewcomer/followers","following_url":"https://api.github.com/users/ericnewcomer/following{/other_user}","gists_url":"https://api.github.com/users/ericnewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnewcomer/subscriptions","organizations_url":"https://api.github.com/users/ericnewcomer/orgs","repos_url":"https://api.github.com/users/ericnewcomer/repos","events_url":"https://api.github.com/users/ericnewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/ericnewcomer/received_events","type":"User","site_admin":false},"body":"Interesting. I thought the UI filtered for this. It might have just been an opinion of mine :/\r\n\r\nFair enough.","created_at":"2016-09-12T18:39:01Z","updated_at":"2016-09-12T18:39:01Z","html_url":"https://github.com/nyaruka/rapidpro/pull/841#discussion_r78429621","pull_request_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841","_links":{"self":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments/78429621"},"html":{"href":"https://github.com/nyaruka/rapidpro/pull/841#discussion_r78429621"},"pull_request":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841"}}},"pull_request":{"url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841","id":84282118,"html_url":"https://github.com/nyaruka/rapidpro/pull/841","diff_url":"https://github.com/nyaruka/rapidpro/pull/841.diff","patch_url":"https://github.com/nyaruka/rapidpro/pull/841.patch","issue_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/841","number":841,"state":"open","locked":false,"title":"Campaigns and campaign events in API v2","user":{"login":"rowanseymour","id":675558,"avatar_url":"https://avatars.githubusercontent.com/u/675558?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanseymour","html_url":"https://github.com/rowanseymour","followers_url":"https://api.github.com/users/rowanseymour/followers","following_url":"https://api.github.com/users/rowanseymour/following{/other_user}","gists_url":"https://api.github.com/users/rowanseymour/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanseymour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanseymour/subscriptions","organizations_url":"https://api.github.com/users/rowanseymour/orgs","repos_url":"https://api.github.com/users/rowanseymour/repos","events_url":"https://api.github.com/users/rowanseymour/events{/privacy}","received_events_url":"https://api.github.com/users/rowanseymour/received_events","type":"User","site_admin":false},"body":"Adding/updating campaigns and adding/updating/deleting campaign events","created_at":"2016-09-07T11:22:20Z","updated_at":"2016-09-12T18:39:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d89ea111312d0ee3c986a37fd115054f29ae201e","assignee":{"login":"rowanseymour","id":675558,"avatar_url":"https://avatars.githubusercontent.com/u/675558?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanseymour","html_url":"https://github.com/rowanseymour","followers_url":"https://api.github.com/users/rowanseymour/followers","following_url":"https://api.github.com/users/rowanseymour/following{/other_user}","gists_url":"https://api.github.com/users/rowanseymour/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanseymour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanseymour/subscriptions","organizations_url":"https://api.github.com/users/rowanseymour/orgs","repos_url":"https://api.github.com/users/rowanseymour/repos","events_url":"https://api.github.com/users/rowanseymour/events{/privacy}","received_events_url":"https://api.github.com/users/rowanseymour/received_events","type":"User","site_admin":false},"assignees":[{"login":"rowanseymour","id":675558,"avatar_url":"https://avatars.githubusercontent.com/u/675558?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanseymour","html_url":"https://github.com/rowanseymour","followers_url":"https://api.github.com/users/rowanseymour/followers","following_url":"https://api.github.com/users/rowanseymour/following{/other_user}","gists_url":"https://api.github.com/users/rowanseymour/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanseymour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanseymour/subscriptions","organizations_url":"https://api.github.com/users/rowanseymour/orgs","repos_url":"https://api.github.com/users/rowanseymour/repos","events_url":"https://api.github.com/users/rowanseymour/events{/privacy}","received_events_url":"https://api.github.com/users/rowanseymour/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841/commits","review_comments_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841/comments","review_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/841/comments","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/71ef6ee82e60e0ddd076c16040ad371ad63af435","head":{"label":"nyaruka:even_more_api_v2","ref":"even_more_api_v2","sha":"71ef6ee82e60e0ddd076c16040ad371ad63af435","user":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"repo":{"id":27415685,"name":"rapidpro","full_name":"nyaruka/rapidpro","owner":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nyaruka/rapidpro","description":"RapidPro is a hosted service allowing organizations to visually build scalable interactive messaging applications.","fork":true,"url":"https://api.github.com/repos/nyaruka/rapidpro","forks_url":"https://api.github.com/repos/nyaruka/rapidpro/forks","keys_url":"https://api.github.com/repos/nyaruka/rapidpro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyaruka/rapidpro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyaruka/rapidpro/teams","hooks_url":"https://api.github.com/repos/nyaruka/rapidpro/hooks","issue_events_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/events{/number}","events_url":"https://api.github.com/repos/nyaruka/rapidpro/events","assignees_url":"https://api.github.com/repos/nyaruka/rapidpro/assignees{/user}","branches_url":"https://api.github.com/repos/nyaruka/rapidpro/branches{/branch}","tags_url":"https://api.github.com/repos/nyaruka/rapidpro/tags","blobs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyaruka/rapidpro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyaruka/rapidpro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/{sha}","languages_url":"https://api.github.com/repos/nyaruka/rapidpro/languages","stargazers_url":"https://api.github.com/repos/nyaruka/rapidpro/stargazers","contributors_url":"https://api.github.com/repos/nyaruka/rapidpro/contributors","subscribers_url":"https://api.github.com/repos/nyaruka/rapidpro/subscribers","subscription_url":"https://api.github.com/repos/nyaruka/rapidpro/subscription","commits_url":"https://api.github.com/repos/nyaruka/rapidpro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyaruka/rapidpro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyaruka/rapidpro/contents/{+path}","compare_url":"https://api.github.com/repos/nyaruka/rapidpro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyaruka/rapidpro/merges","archive_url":"https://api.github.com/repos/nyaruka/rapidpro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyaruka/rapidpro/downloads","issues_url":"https://api.github.com/repos/nyaruka/rapidpro/issues{/number}","pulls_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls{/number}","milestones_url":"https://api.github.com/repos/nyaruka/rapidpro/milestones{/number}","notifications_url":"https://api.github.com/repos/nyaruka/rapidpro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyaruka/rapidpro/labels{/name}","releases_url":"https://api.github.com/repos/nyaruka/rapidpro/releases{/id}","deployments_url":"https://api.github.com/repos/nyaruka/rapidpro/deployments","created_at":"2014-12-02T04:53:16Z","updated_at":"2016-07-21T21:37:20Z","pushed_at":"2016-09-12T18:36:39Z","git_url":"git://github.com/nyaruka/rapidpro.git","ssh_url":"git@github.com:nyaruka/rapidpro.git","clone_url":"https://github.com/nyaruka/rapidpro.git","svn_url":"https://github.com/nyaruka/rapidpro","homepage":null,"size":50912,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":7,"default_branch":"master"}},"base":{"label":"nyaruka:master","ref":"master","sha":"4be962dfc8cc40d94ec51cd25077a2e66923dc5f","user":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"repo":{"id":27415685,"name":"rapidpro","full_name":"nyaruka/rapidpro","owner":{"login":"nyaruka","id":299256,"avatar_url":"https://avatars.githubusercontent.com/u/299256?v=3","gravatar_id":"","url":"https://api.github.com/users/nyaruka","html_url":"https://github.com/nyaruka","followers_url":"https://api.github.com/users/nyaruka/followers","following_url":"https://api.github.com/users/nyaruka/following{/other_user}","gists_url":"https://api.github.com/users/nyaruka/gists{/gist_id}","starred_url":"https://api.github.com/users/nyaruka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyaruka/subscriptions","organizations_url":"https://api.github.com/users/nyaruka/orgs","repos_url":"https://api.github.com/users/nyaruka/repos","events_url":"https://api.github.com/users/nyaruka/events{/privacy}","received_events_url":"https://api.github.com/users/nyaruka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nyaruka/rapidpro","description":"RapidPro is a hosted service allowing organizations to visually build scalable interactive messaging applications.","fork":true,"url":"https://api.github.com/repos/nyaruka/rapidpro","forks_url":"https://api.github.com/repos/nyaruka/rapidpro/forks","keys_url":"https://api.github.com/repos/nyaruka/rapidpro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyaruka/rapidpro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyaruka/rapidpro/teams","hooks_url":"https://api.github.com/repos/nyaruka/rapidpro/hooks","issue_events_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/events{/number}","events_url":"https://api.github.com/repos/nyaruka/rapidpro/events","assignees_url":"https://api.github.com/repos/nyaruka/rapidpro/assignees{/user}","branches_url":"https://api.github.com/repos/nyaruka/rapidpro/branches{/branch}","tags_url":"https://api.github.com/repos/nyaruka/rapidpro/tags","blobs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyaruka/rapidpro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyaruka/rapidpro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyaruka/rapidpro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyaruka/rapidpro/statuses/{sha}","languages_url":"https://api.github.com/repos/nyaruka/rapidpro/languages","stargazers_url":"https://api.github.com/repos/nyaruka/rapidpro/stargazers","contributors_url":"https://api.github.com/repos/nyaruka/rapidpro/contributors","subscribers_url":"https://api.github.com/repos/nyaruka/rapidpro/subscribers","subscription_url":"https://api.github.com/repos/nyaruka/rapidpro/subscription","commits_url":"https://api.github.com/repos/nyaruka/rapidpro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyaruka/rapidpro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyaruka/rapidpro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyaruka/rapidpro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyaruka/rapidpro/contents/{+path}","compare_url":"https://api.github.com/repos/nyaruka/rapidpro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyaruka/rapidpro/merges","archive_url":"https://api.github.com/repos/nyaruka/rapidpro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyaruka/rapidpro/downloads","issues_url":"https://api.github.com/repos/nyaruka/rapidpro/issues{/number}","pulls_url":"https://api.github.com/repos/nyaruka/rapidpro/pulls{/number}","milestones_url":"https://api.github.com/repos/nyaruka/rapidpro/milestones{/number}","notifications_url":"https://api.github.com/repos/nyaruka/rapidpro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyaruka/rapidpro/labels{/name}","releases_url":"https://api.github.com/repos/nyaruka/rapidpro/releases{/id}","deployments_url":"https://api.github.com/repos/nyaruka/rapidpro/deployments","created_at":"2014-12-02T04:53:16Z","updated_at":"2016-07-21T21:37:20Z","pushed_at":"2016-09-12T18:36:39Z","git_url":"git://github.com/nyaruka/rapidpro.git","ssh_url":"git@github.com:nyaruka/rapidpro.git","clone_url":"https://github.com/nyaruka/rapidpro.git","svn_url":"https://github.com/nyaruka/rapidpro","homepage":null,"size":50912,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841"},"html":{"href":"https://github.com/nyaruka/rapidpro/pull/841"},"issue":{"href":"https://api.github.com/repos/nyaruka/rapidpro/issues/841"},"comments":{"href":"https://api.github.com/repos/nyaruka/rapidpro/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nyaruka/rapidpro/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/nyaruka/rapidpro/statuses/71ef6ee82e60e0ddd076c16040ad371ad63af435"}}}}
{"actor":{"display_login":"ericnewcomer"}}