{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10450","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10450/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10450/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10450/events","html_url":"https://github.com/joomla/joomla-cms/pull/10450","id":154719152,"number":10450,"title":"Rewrite installation plugins and add them to Hathor","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-13T14:03:46Z","updated_at":"2016-05-13T20:47:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10450","html_url":"https://github.com/joomla/joomla-cms/pull/10450","diff_url":"https://github.com/joomla/joomla-cms/pull/10450.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10450.patch"},"body":"With 3.6.0, the installer tabs are generated by plugins similar how the install from web tab is done.\r\nHowever this wasn't done for Hathor.\r\n\r\nThe way the plugins generated the output, it wasn't also possible to do proper overwrites for Hathor. The tabs and fieldsets were generated by the plugins, however Hathor doesn't use tabs.\r\n\r\n#### Summary of Changes\r\nThis PR rewrites the plugins so they return the data instead of directly outputting the tab. The tab is then generated by the Isis layout file.\r\nThis PR also adds the functionality (plugin trigger) to Hathor.\r\n\r\n#### Testing Instructions\r\n* Test in Isis and Hathor that the various extension install ways still work.\r\n* Try enabling/disabling the plugins and check that they properly show/hide in the installer view\r\n* Try rearranging the plugins and see that they follow the ordering set in the plugin manager (except the install from web one).\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/219155211","html_url":"https://github.com/joomla/joomla-cms/pull/10450#issuecomment-219155211","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10450","id":219155211,"user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T20:47:56Z","updated_at":"2016-05-13T20:47:56Z","body":"I have tested this item :white_check_mark: successfully on 49e416ad0100137d40d359f2d1c69c05f54e5c00<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/10450\">issues.joomla.org/joomla-cms/10450</a>.</sub>"}}