{"push_id":1386675557,"size":53,"distinct_size":1,"ref":"refs/heads/acctests/dme","head":"e249fa1f229c9871d3e8ff21f087ca8e29b6d907","before":"ce718d07fd01c50e47911ae4bcc094d0510a2bac","commits":[{"sha":"1248b147acf55d7f7eaa1a06b6fb89d760d1e334","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"command/meta: always ask for unset variable input\n\nFixes #7975\n\nThis changes the InputMode for the CLI to always be:\n\n    InputModeProvider | InputModeVar | InputModeVarUnset\n\nWhich means:\n\n  * Ask for provider variables\n  * Ask for user variables _that are not already set_\n\nThe change is the latter point. Before, we'd only ask for variables if\nzero were given. This forces the user to either have no variables set\nvia the CLI, env vars, tfvars or ALL variables, but no in between. As\nreported in #7975, this isn't expected behavior.\n\nThe new change makes is so that unset variables are always asked for.\nUsers can retain the previous behavior by setting `-input=false`. This\nwould ensure that variables set by external sources cover all cases.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/1248b147acf55d7f7eaa1a06b6fb89d760d1e334"},{"sha":"d69b6257df6712dc0ab3443dc3d579154941c1f9","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"config: formatlist accepts an empty list\n\nFixes #7607\n\nAn empty list is a valid value for formatlist which means to just return\nan empty list as a result. The logic was somewhat convoluted here so I\ncleaned that up a bit too. The function overall can definitely be\ncleaned up a lot more but I left it mostly as-is to fix the bug.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/d69b6257df6712dc0ab3443dc3d579154941c1f9"},{"sha":"5cd40bce304c8e4b5acbd77811f32822c13843b0","author":{"name":"clint shryock","email":"3c1cae15fe4aee44109fba60770f28420b8d8526@ctshryock.com"},"message":"provider/aws: Modify AWS User-Agent to new format","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/5cd40bce304c8e4b5acbd77811f32822c13843b0"},{"sha":"7834cf7190f0569a34cfcd036e23684ac834703e","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"helper/schema: computed bool fields should not crash\n\nFixes #7715\n\nIf a bool field was computed and the raw value was not convertable to a\nboolean, helper/schema would crash. The correct behavior is to try not\nto read the raw value when the value is computed and to simply mark that\nit is computed. This does that (and matches the behavior of the other\nprimitives).","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/7834cf7190f0569a34cfcd036e23684ac834703e"},{"sha":"f054c5ca2ca0de3b357bcd937299fc42dd5fe4b1","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"config: manually parse variable blocks for better validation\n\nFixes #7846\n\nThis changes from using the HCL decoder to manually decoding the\n`variable` blocks within the configuration. This gives us a lot more\npower to catch validation errors. This PR retains the same tests and\nfixes one additional issue (covered by a test) in the case where a\nvariable has no named assigned.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/f054c5ca2ca0de3b357bcd937299fc42dd5fe4b1"},{"sha":"ef3148bbfaa27467bb106c3d66917a78b8a01be5","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"config: validate that outputs have a name","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/ef3148bbfaa27467bb106c3d66917a78b8a01be5"},{"sha":"65b17ccd0651ff47880ac19b75d34f050afd950c","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"helper/schema: allow ConflictsWith and Computed Optional fields","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/65b17ccd0651ff47880ac19b75d34f050afd950c"},{"sha":"cf3a259cd9fd78bb9f2bc0949866b0708a48c10e","author":{"name":"James Bardin","email":"5192af46395652008fbc97083f552f06bc32f1c0@gmail.com"},"message":"fix CreateBeforeDestroy with datasources\n\nThe graph transformation we implement around create_before_destroy\nneed to re-order all resources that depend on the create_before_destroy\nresource. Up until now, we've requires that users mark all of these\nresources as create_before_destroy. Data soruces however don't have a\nlifecycle block for create_before_destroy, and could not be marked this\nway.\n\nThis PR checks each DestroyNode that doesn't implement CreateBeforeDestroy\nfor any ancestors that do implement CreateBeforeDestroy. If there are\nany, we inherit the behavior and re-order the graph as such.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/cf3a259cd9fd78bb9f2bc0949866b0708a48c10e"},{"sha":"40886218d52766247425693361554246e892a2d6","author":{"name":"James Bardin","email":"5192af46395652008fbc97083f552f06bc32f1c0@gmail.com"},"message":"Add test fixture for new CBD ancestor fix\n\nThis test will fail with a cycle before we check ancestors for\nCreateBeforeDestroy.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/40886218d52766247425693361554246e892a2d6"},{"sha":"24dd4273c77309753b5086186bbd09cb4438439f","author":{"name":"Paddy","email":"d036885be96af0c1cd65d00e1b79f69171c3f919@hashicorp.com"},"message":"Add an acceptance test for adding EBS volumes to a spot fleet req\n\nSpot fleet requests can have EBS volumes attached to them, and at\nthe moment we're getting reports that crashes can be experienced\nwith them. This adds an acceptance test that exercises creating\na Spot Fleet request that has a non-instance EBS volume attached.\nThis successfully reproduces the panic.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/24dd4273c77309753b5086186bbd09cb4438439f"},{"sha":"7d06ea84493cdba8aece7274a9b59f4ff4e3fad7","author":{"name":"Paddy","email":"d036885be96af0c1cd65d00e1b79f69171c3f919@hashicorp.com"},"message":"Fix EBS block device hashing in spot fleet requests.\n\nWhen computing the set key for an EBS block device, we were using\nthe wrong function; we had hashEphemeralBlockDevice instead of\nhashEbsBlockDevice. This caused a panic by trying to access the\nvirtual_name attribute that will never be set for EBS block\ndevices.\n\nTo fix this, I switched to the hashEbsBlockDevice function, which\nis already being used to compute a Set key in the Schema. But in\nthe default case, where the snapshot_id attribute isn't specified,\nthis also caused a panic. I updated the way the string to hash is\ngenerated to check for the existence of the device_name and\nsnapshot_id attributes before we use them, to avoid panics when\nthese optional attributes aren't set.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/7d06ea84493cdba8aece7274a9b59f4ff4e3fad7"},{"sha":"194d7c616867614da2898794b550b292854cb554","author":{"name":"Paul Hinze","email":"159dfe30e937910d8b01ec0f7a7ba528a986e39f@phinze.com"},"message":"vendor: Add acm library to aws-sdk-go","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/194d7c616867614da2898794b550b292854cb554"},{"sha":"ccd745c96fa7fd3e9905052906fe5753cfc33102","author":{"name":"Paul Hinze","email":"159dfe30e937910d8b01ec0f7a7ba528a986e39f@phinze.com"},"message":"provider/aws: New Data Source: aws_acm_certificate\n\nUse this data source to get the ARN of a certificate in AWS Certificate\nManager (ACM). The process of requesting and verifying a certificate in ACM\nrequires some manual steps, which means that Terraform cannot automate the\ncreation of ACM certificates. But using this data source, you can reference\nthem by domain without having to hard code the ARNs as input.\n\nThe acceptance test included requires an ACM certificate be pre-created\nin and information about it passed in via environment variables. It's a\nbit sad but there's really no other way to do it.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/ccd745c96fa7fd3e9905052906fe5753cfc33102"},{"sha":"3361047e38c76c607448aa75277fcebcd61fa6f9","author":{"name":"James Nugent","email":"01cfcc75cc77e42d1369b51ffa1aaa70069d0f46@jen20.com"},"message":"provider/aws: Address acm_certificate review items","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/3361047e38c76c607448aa75277fcebcd61fa6f9"},{"sha":"d429e8266146abd74b1153017ab6f8bd33080c1f","author":{"name":"Mitchell Hashimoto","email":"3146185c3a7398573fd3f22b8eb014cb50a9bffa@gmail.com"},"message":"command: show shadow errors to the user","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/d429e8266146abd74b1153017ab6f8bd33080c1f"},{"sha":"e3246bc63e634e8edb20734343cdca2b48a68b28","author":{"name":"Gavin Williams","email":"54da1005174ade6a03c23cd801e9188a49c116a5@gmail.com"},"message":"provider/openstack: Add 'value_specs' option to 'openstack_fw_rule_v1' resource.\nRefactor to use common 'types.go' and 'MapValueSpecs' function.\nWebsite docs updated.","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/e3246bc63e634e8edb20734343cdca2b48a68b28"},{"sha":"c75369d65d3707cf92c1bae162f080eacc72fab0","author":{"name":"James Nugent","email":"01cfcc75cc77e42d1369b51ffa1aaa70069d0f46@jen20.com"},"message":"Merge pull request #8359 from hashicorp/f-aws-acm-datasource\n\nprovider/aws: New Data Source: aws_acm_certificate","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/c75369d65d3707cf92c1bae162f080eacc72fab0"},{"sha":"95992e681ee8f0d45fe797ae15f77b7455048c8d","author":{"name":"James Nugent","email":"01cfcc75cc77e42d1369b51ffa1aaa70069d0f46@jen20.com"},"message":"Update CHANGELOG.md","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/95992e681ee8f0d45fe797ae15f77b7455048c8d"},{"sha":"07ec946e7e9536816f551efd2a8095a3e0b97a4c","author":{"name":"James Bardin","email":"5192af46395652008fbc97083f552f06bc32f1c0@gmail.com"},"message":"Merge pull request #9853 from hashicorp/jbardin/cbd-datasource\n\nfix CreateBeforeDestroy with datasources","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/07ec946e7e9536816f551efd2a8095a3e0b97a4c"},{"sha":"639a088897799f3555200e19794cfaa8e9c5a9d9","author":{"name":"clint shryock","email":"3c1cae15fe4aee44109fba60770f28420b8d8526@ctshryock.com"},"message":"provider/aws: Decouple and randomize OpsWorks test configs","distinct":false,"url":"https://api.github.com/repos/hashicorp/terraform/commits/639a088897799f3555200e19794cfaa8e9c5a9d9"}]}
{"actor":{"display_login":"terraformbot"}}