{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/175","repository_url":"https://api.github.com/repos/voxpupuli/puppet-hiera","labels_url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/175/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/175/events","html_url":"https://github.com/voxpupuli/puppet-hiera/pull/175","id":194075858,"number":175,"title":"Strict variables fix for `pe_server_version`","user":{"login":"alexjfisher","id":146471,"avatar_url":"https://avatars.githubusercontent.com/u/146471?v=3","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-07T15:14:23Z","updated_at":"2016-12-24T16:17:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-hiera/pulls/175","html_url":"https://github.com/voxpupuli/puppet-hiera/pull/175","diff_url":"https://github.com/voxpupuli/puppet-hiera/pull/175.diff","patch_url":"https://github.com/voxpupuli/puppet-hiera/pull/175.patch"},"body":"<!--\r\nThank you for contributing to this project!\r\n\r\n- This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/\r\n- Please check that here is no existing issue or PR that addresses your problem.\r\n\r\n-->\r\n\r\nhttps://blog.yo61.com/test-for-undefined-fact-in-puppet-with-strict_variables\r\n\r\n`getvar()` has better compatibility that `defined()` which is broken in\r\nearly puppet 3 versions.\r\n\r\nAfter migrating the module to puppet 4, we will then be able to use the\r\nfacts hash instead.\r\n\r\nFixes #GH-171"},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/comments/269090492","html_url":"https://github.com/voxpupuli/puppet-hiera/pull/175#issuecomment-269090492","issue_url":"https://api.github.com/repos/voxpupuli/puppet-hiera/issues/175","id":269090492,"user":{"login":"alexjfisher","id":146471,"avatar_url":"https://avatars.githubusercontent.com/u/146471?v=3","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T16:17:49Z","updated_at":"2016-12-24T16:17:49Z","body":"I was using a release.  I think I had to set the `provider` parameter to `puppetserver_gem` but had `create_keys` set to `false` (I was using eyaml still, just providing my own keys).  I guess the exec would work if you override `cmdpath`?\r\n\r\nWithout the `getvar()` fix I only got a warning, not a hard error.  If you've got strict vars enabled you would need this fix.  I'll rebase."}}
{"actor":{"display_login":"alexjfisher"}}