{"action":"created","issue":{"url":"https://api.github.com/repos/Nek5000/Nek5000/issues/80","repository_url":"https://api.github.com/repos/Nek5000/Nek5000","labels_url":"https://api.github.com/repos/Nek5000/Nek5000/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/Nek5000/Nek5000/issues/80/comments","events_url":"https://api.github.com/repos/Nek5000/Nek5000/issues/80/events","html_url":"https://github.com/Nek5000/Nek5000/pull/80","id":174777902,"number":80,"title":"CMT merge","user":{"login":"RonRahaman","id":5082373,"avatar_url":"https://avatars.githubusercontent.com/u/5082373?v=3","gravatar_id":"","url":"https://api.github.com/users/RonRahaman","html_url":"https://github.com/RonRahaman","followers_url":"https://api.github.com/users/RonRahaman/followers","following_url":"https://api.github.com/users/RonRahaman/following{/other_user}","gists_url":"https://api.github.com/users/RonRahaman/gists{/gist_id}","starred_url":"https://api.github.com/users/RonRahaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonRahaman/subscriptions","organizations_url":"https://api.github.com/users/RonRahaman/orgs","repos_url":"https://api.github.com/users/RonRahaman/repos","events_url":"https://api.github.com/users/RonRahaman/events{/privacy}","received_events_url":"https://api.github.com/users/RonRahaman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"fischer1","id":11255441,"avatar_url":"https://avatars.githubusercontent.com/u/11255441?v=3","gravatar_id":"","url":"https://api.github.com/users/fischer1","html_url":"https://github.com/fischer1","followers_url":"https://api.github.com/users/fischer1/followers","following_url":"https://api.github.com/users/fischer1/following{/other_user}","gists_url":"https://api.github.com/users/fischer1/gists{/gist_id}","starred_url":"https://api.github.com/users/fischer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fischer1/subscriptions","organizations_url":"https://api.github.com/users/fischer1/orgs","repos_url":"https://api.github.com/users/fischer1/repos","events_url":"https://api.github.com/users/fischer1/events{/privacy}","received_events_url":"https://api.github.com/users/fischer1/received_events","type":"User","site_admin":false},"assignees":[{"login":"fischer1","id":11255441,"avatar_url":"https://avatars.githubusercontent.com/u/11255441?v=3","gravatar_id":"","url":"https://api.github.com/users/fischer1","html_url":"https://github.com/fischer1","followers_url":"https://api.github.com/users/fischer1/followers","following_url":"https://api.github.com/users/fischer1/following{/other_user}","gists_url":"https://api.github.com/users/fischer1/gists{/gist_id}","starred_url":"https://api.github.com/users/fischer1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fischer1/subscriptions","organizations_url":"https://api.github.com/users/fischer1/orgs","repos_url":"https://api.github.com/users/fischer1/repos","events_url":"https://api.github.com/users/fischer1/events{/privacy}","received_events_url":"https://api.github.com/users/fischer1/received_events","type":"User","site_admin":false},{"login":"stgeke","id":18589311,"avatar_url":"https://avatars.githubusercontent.com/u/18589311?v=3","gravatar_id":"","url":"https://api.github.com/users/stgeke","html_url":"https://github.com/stgeke","followers_url":"https://api.github.com/users/stgeke/followers","following_url":"https://api.github.com/users/stgeke/following{/other_user}","gists_url":"https://api.github.com/users/stgeke/gists{/gist_id}","starred_url":"https://api.github.com/users/stgeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgeke/subscriptions","organizations_url":"https://api.github.com/users/stgeke/orgs","repos_url":"https://api.github.com/users/stgeke/repos","events_url":"https://api.github.com/users/stgeke/events{/privacy}","received_events_url":"https://api.github.com/users/stgeke/received_events","type":"User","site_admin":false}],"milestone":null,"comments":26,"created_at":"2016-09-02T14:50:14Z","updated_at":"2016-11-10T18:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Nek5000/Nek5000/pulls/80","html_url":"https://github.com/Nek5000/Nek5000/pull/80","diff_url":"https://github.com/Nek5000/Nek5000/pull/80.diff","patch_url":"https://github.com/Nek5000/Nek5000/pull/80.patch"},"body":"This is the first update to the CMT code since November.  It includes many improvements to particle tracking, among other things.  \n\nThis branch results from two merges and a rebase between the UFCCMT BitBucket repo and the Nek5000 GitHub repo.  Let these repos be called 'UFCCMT' and 'Nek5000' respectively. Our workflow was the following:\n- The directories of UFCCMT was restrucuted using 'git filter-branch'.  This was necessary because UFCCMT had the directory structure of the SVN repo.  \n- The first merge was performed:\n  1. We identified the last time UFCCMT had been synced with Nek5000.  That sync was a manual copy-paste of source files, not a Git merge.  \n  2. A new branch (UFCCMT:cmt-sync) was created on UFCCMT:master at the downstream commit identified in (1).  \n  3. A new branch (Nek5000:cmt-merge-1) was created on Nek5000:develop at the downstream commit identified in (1).  \n  4. We merged UFCCMT:cmt-sync into Nek5000:cmt-merge-1\n- A rebase was performed:\n  1. A new branch (UFCCMT:cmt-rebase-1) was created at the most recent commit of UFCCMT:master.\n  2. UFCCMT:cmt-rebase-1 was rebased on top of Nek5000:cmt-merge-1\n  3. The rebased UFCCMT:cmt-rebase-1 was pushed to Nek5000 as a new branch (Nek5000:cmt-rebase-1)\n- A second and final rebase was performed:\n  1. A new branch (Nek5000:cmt-merge-2) was created at the most recent commit of Nek5000:develop.\n  2. Nek5000:cmt-rebase-1 was merged into Nek5000:cmt-merge-2\n"},"comment":{"url":"https://api.github.com/repos/Nek5000/Nek5000/issues/comments/259772045","html_url":"https://github.com/Nek5000/Nek5000/pull/80#issuecomment-259772045","issue_url":"https://api.github.com/repos/Nek5000/Nek5000/issues/80","id":259772045,"user":{"login":"stgeke","id":18589311,"avatar_url":"https://avatars.githubusercontent.com/u/18589311?v=3","gravatar_id":"","url":"https://api.github.com/users/stgeke","html_url":"https://github.com/stgeke","followers_url":"https://api.github.com/users/stgeke/followers","following_url":"https://api.github.com/users/stgeke/following{/other_user}","gists_url":"https://api.github.com/users/stgeke/gists{/gist_id}","starred_url":"https://api.github.com/users/stgeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgeke/subscriptions","organizations_url":"https://api.github.com/users/stgeke/orgs","repos_url":"https://api.github.com/users/stgeke/repos","events_url":"https://api.github.com/users/stgeke/events{/privacy}","received_events_url":"https://api.github.com/users/stgeke/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T18:42:54Z","updated_at":"2016-11-10T18:42:54Z","body":"I think of CMT as an extension which should be encapsulated with a well defined interface. To accept the pull request I recommend the following changes:\r\n\r\n0) Pull in the latest changes and resolve the conflicts\r\n1) Eliminate IFCMT in makenek and add a preprocessor symbol (CMT) instead\r\n2) Compile source code in core/CMT if CMT is defined\r\n3) Use the existing t-array for fields like (phig, …), no need to define extra arrays for them\r\n4) Remove all CMT stuff from core except the top-level driver call in nek_advance() and ifcmt in INPUT\r\n\t- With (3) you don’t need to modify nekuic() anymore\r\n\t- Instead of putting your data into NEKUSE have your own CMTUSE which you include in the .usr file\r\n\t- Not sure how you could avoid the changes in nekasgn(), but may be you have a good idea?\r\n\r\nAny chance to implement the suggest changes within the next 2-3 weeks? It would be good to include them in v16.0.0."}}
{"actor":{"display_login":"stgeke"}}