{"action":"created","issue":{"url":"https://api.github.com/repos/kiddouk/letslambda/issues/7","repository_url":"https://api.github.com/repos/kiddouk/letslambda","labels_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7/comments","events_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7/events","html_url":"https://github.com/kiddouk/letslambda/pull/7","id":159804924,"number":7,"title":"Support for private key encryption (KMS) and other bug fixes","user":{"login":"aureq","id":1161681,"avatar_url":"https://avatars.githubusercontent.com/u/1161681?v=3","gravatar_id":"","url":"https://api.github.com/users/aureq","html_url":"https://github.com/aureq","followers_url":"https://api.github.com/users/aureq/followers","following_url":"https://api.github.com/users/aureq/following{/other_user}","gists_url":"https://api.github.com/users/aureq/gists{/gist_id}","starred_url":"https://api.github.com/users/aureq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aureq/subscriptions","organizations_url":"https://api.github.com/users/aureq/orgs","repos_url":"https://api.github.com/users/aureq/repos","events_url":"https://api.github.com/users/aureq/events{/privacy}","received_events_url":"https://api.github.com/users/aureq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-12T03:09:24Z","updated_at":"2016-06-15T11:35:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kiddouk/letslambda/pulls/7","html_url":"https://github.com/kiddouk/letslambda/pull/7","diff_url":"https://github.com/kiddouk/letslambda/pull/7.diff","patch_url":"https://github.com/kiddouk/letslambda/pull/7.patch"},"body":"Here is the main changelog\r\n\r\n- apply bucket policy to enforce encryption of private keys\r\n- split IAM managed roles for easier reuse\r\n- reworked of all AWS calls using boto3\r\n- do not guess r53 zone name, get it from configuration 'r53_zone'\r\n- added support for elb custom SSL port via 'elb_port'\r\n- save private keys (account and domain) using AES256 or KMS key via 'kmsKeyArn'\r\n- wait for new IAM server certificate to become available when loading into ELB\r\n- correctly handle missing chain certificate\r\n- a lot more debugs and informative messages\r\n- made function names more consistent\r\n- catching more errors and exceptions whenever possible"},"comment":{"url":"https://api.github.com/repos/kiddouk/letslambda/issues/comments/226162038","html_url":"https://github.com/kiddouk/letslambda/pull/7#issuecomment-226162038","issue_url":"https://api.github.com/repos/kiddouk/letslambda/issues/7","id":226162038,"user":{"login":"kiddouk","id":391998,"avatar_url":"https://avatars.githubusercontent.com/u/391998?v=3","gravatar_id":"","url":"https://api.github.com/users/kiddouk","html_url":"https://github.com/kiddouk","followers_url":"https://api.github.com/users/kiddouk/followers","following_url":"https://api.github.com/users/kiddouk/following{/other_user}","gists_url":"https://api.github.com/users/kiddouk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiddouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiddouk/subscriptions","organizations_url":"https://api.github.com/users/kiddouk/orgs","repos_url":"https://api.github.com/users/kiddouk/repos","events_url":"https://api.github.com/users/kiddouk/events{/privacy}","received_events_url":"https://api.github.com/users/kiddouk/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T11:35:50Z","updated_at":"2016-06-15T11:35:50Z","body":"I dont think that we need to mock the HTTP protocol per say. A simple mocking of responses should be enough I think. I myself use mock2 (for python 2.7).\r\n\r\nMock2 made it to python3 code base."}}
{"actor":{"display_login":"kiddouk"}}