{"action":"created","issue":{"url":"https://api.github.com/repos/intercom/ember-href-to/issues/65","repository_url":"https://api.github.com/repos/intercom/ember-href-to","labels_url":"https://api.github.com/repos/intercom/ember-href-to/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/intercom/ember-href-to/issues/65/comments","events_url":"https://api.github.com/repos/intercom/ember-href-to/issues/65/events","html_url":"https://github.com/intercom/ember-href-to/pull/65","id":188997254,"number":65,"title":"(closes #64) Extract class, support href-to on components.","user":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-13T21:45:12Z","updated_at":"2016-11-13T21:59:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intercom/ember-href-to/pulls/65","html_url":"https://github.com/intercom/ember-href-to/pull/65","diff_url":"https://github.com/intercom/ember-href-to/pull/65.diff","patch_url":"https://github.com/intercom/ember-href-to/pull/65.patch"},"body":"The purpose of this PR was to enable the `href-to` functionality to work\r\non components:\r\n\r\n```hbs\r\n{{#my-button style='link' href=(href-to 'about')}}\r\n  About\r\n{{/my-button}}\r\n```\r\n\r\nOriginally, href-to ignored all components by filtering out targets\r\nwith `.ember-view`. This was added so the `href-to` handler wouldn't\r\ninterfere with instances of LinkComponent. However, we want to support\r\nthe above use case.\r\n\r\nAfter updating the `canHandle` code in the original initializer, it was\r\nhard to test the new behavior (because of the dependency on the registry).\r\nWe also thought the initializer logic was becoming complicated.\r\nSo, we extracted the logic into a separate class, and added some more test\r\ncoverage along the way."},"comment":{"url":"https://api.github.com/repos/intercom/ember-href-to/issues/comments/260216079","html_url":"https://github.com/intercom/ember-href-to/pull/65#issuecomment-260216079","issue_url":"https://api.github.com/repos/intercom/ember-href-to/issues/65","id":260216079,"user":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T21:59:59Z","updated_at":"2016-11-13T21:59:59Z","body":"Fixing the beta failures"}}
{"actor":{"display_login":"samselikoff"}}