{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/92294206","pull_request_review_id":12807156,"id":92294206,"diff_hunk":"@@ -33,6 +33,16 @@ public interface ICounter\n         void ResetCurrent();\n         string GetDisplayString();\n         CounterStorage Storage { get; }\n+        void TrackMetric(Logger logger);\n+    }\n+\n+    public static class Metric\n+    {\n+        public static string CreateName(ICounter counter)\n+        {\n+            return counter.Name + \".\" + (counter.IsValueDelta ? \"Delta\" : \"Current\");","path":"src/Orleans/Statistics/CounterStatistic.cs","position":11,"original_position":11,"commit_id":"8b474d2e00fb5e8c3920c0ca8979d9d668221720","original_commit_id":"8b474d2e00fb5e8c3920c0ca8979d9d668221720","user":{"login":"galvesribeiro","id":4714040,"avatar_url":"https://avatars.githubusercontent.com/u/4714040?v=3","gravatar_id":"","url":"https://api.github.com/users/galvesribeiro","html_url":"https://github.com/galvesribeiro","followers_url":"https://api.github.com/users/galvesribeiro/followers","following_url":"https://api.github.com/users/galvesribeiro/following{/other_user}","gists_url":"https://api.github.com/users/galvesribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/galvesribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galvesribeiro/subscriptions","organizations_url":"https://api.github.com/users/galvesribeiro/orgs","repos_url":"https://api.github.com/users/galvesribeiro/repos","events_url":"https://api.github.com/users/galvesribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/galvesribeiro/received_events","type":"User","site_admin":false},"body":"I wonder if we could cache those names on first use...","created_at":"2016-12-13T23:50:28Z","updated_at":"2016-12-13T23:54:50Z","html_url":"https://github.com/dotnet/orleans/pull/2513#discussion_r92294206","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/2513","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/92294206"},"html":{"href":"https://github.com/dotnet/orleans/pull/2513#discussion_r92294206"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2513"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/2513","id":97850842,"html_url":"https://github.com/dotnet/orleans/pull/2513","diff_url":"https://github.com/dotnet/orleans/pull/2513.diff","patch_url":"https://github.com/dotnet/orleans/pull/2513.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/2513","number":2513,"state":"open","locked":false,"title":"Send all statistics to telemetry consumers","user":{"login":"jason-bragg","id":10675494,"avatar_url":"https://avatars.githubusercontent.com/u/10675494?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-bragg","html_url":"https://github.com/jason-bragg","followers_url":"https://api.github.com/users/jason-bragg/followers","following_url":"https://api.github.com/users/jason-bragg/following{/other_user}","gists_url":"https://api.github.com/users/jason-bragg/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-bragg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-bragg/subscriptions","organizations_url":"https://api.github.com/users/jason-bragg/orgs","repos_url":"https://api.github.com/users/jason-bragg/repos","events_url":"https://api.github.com/users/jason-bragg/events{/privacy}","received_events_url":"https://api.github.com/users/jason-bragg/received_events","type":"User","site_admin":false},"body":"Only a hard coded set of statistics were going to telemetry consumers.  Now all non-string statistics are tracked.","created_at":"2016-12-13T22:39:37Z","updated_at":"2016-12-13T23:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c38f3e2a39eec7924fdbe84c0dd6dcd59a50db1","assignee":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"assignees":[{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/14","html_url":"https://github.com/dotnet/orleans/milestone/14","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/14/labels","id":2017852,"number":14,"title":"1.4.0","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":31,"state":"open","created_at":"2016-09-20T23:16:17Z","updated_at":"2016-12-13T22:39:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/2513/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/2513/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/2513/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/8b474d2e00fb5e8c3920c0ca8979d9d668221720","head":{"label":"jason-bragg:StatisticsToTelemetryFix","ref":"StatisticsToTelemetryFix","sha":"8b474d2e00fb5e8c3920c0ca8979d9d668221720","user":{"login":"jason-bragg","id":10675494,"avatar_url":"https://avatars.githubusercontent.com/u/10675494?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-bragg","html_url":"https://github.com/jason-bragg","followers_url":"https://api.github.com/users/jason-bragg/followers","following_url":"https://api.github.com/users/jason-bragg/following{/other_user}","gists_url":"https://api.github.com/users/jason-bragg/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-bragg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-bragg/subscriptions","organizations_url":"https://api.github.com/users/jason-bragg/orgs","repos_url":"https://api.github.com/users/jason-bragg/repos","events_url":"https://api.github.com/users/jason-bragg/events{/privacy}","received_events_url":"https://api.github.com/users/jason-bragg/received_events","type":"User","site_admin":false},"repo":{"id":29758989,"name":"orleans","full_name":"jason-bragg/orleans","owner":{"login":"jason-bragg","id":10675494,"avatar_url":"https://avatars.githubusercontent.com/u/10675494?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-bragg","html_url":"https://github.com/jason-bragg","followers_url":"https://api.github.com/users/jason-bragg/followers","following_url":"https://api.github.com/users/jason-bragg/following{/other_user}","gists_url":"https://api.github.com/users/jason-bragg/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-bragg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-bragg/subscriptions","organizations_url":"https://api.github.com/users/jason-bragg/orgs","repos_url":"https://api.github.com/users/jason-bragg/repos","events_url":"https://api.github.com/users/jason-bragg/events{/privacy}","received_events_url":"https://api.github.com/users/jason-bragg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason-bragg/orleans","description":"Repo for Orleans - Distributed Actor Model","fork":true,"url":"https://api.github.com/repos/jason-bragg/orleans","forks_url":"https://api.github.com/repos/jason-bragg/orleans/forks","keys_url":"https://api.github.com/repos/jason-bragg/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason-bragg/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason-bragg/orleans/teams","hooks_url":"https://api.github.com/repos/jason-bragg/orleans/hooks","issue_events_url":"https://api.github.com/repos/jason-bragg/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/jason-bragg/orleans/events","assignees_url":"https://api.github.com/repos/jason-bragg/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/jason-bragg/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/jason-bragg/orleans/tags","blobs_url":"https://api.github.com/repos/jason-bragg/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason-bragg/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason-bragg/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason-bragg/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason-bragg/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/jason-bragg/orleans/languages","stargazers_url":"https://api.github.com/repos/jason-bragg/orleans/stargazers","contributors_url":"https://api.github.com/repos/jason-bragg/orleans/contributors","subscribers_url":"https://api.github.com/repos/jason-bragg/orleans/subscribers","subscription_url":"https://api.github.com/repos/jason-bragg/orleans/subscription","commits_url":"https://api.github.com/repos/jason-bragg/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason-bragg/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason-bragg/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason-bragg/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason-bragg/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/jason-bragg/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason-bragg/orleans/merges","archive_url":"https://api.github.com/repos/jason-bragg/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason-bragg/orleans/downloads","issues_url":"https://api.github.com/repos/jason-bragg/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/jason-bragg/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/jason-bragg/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/jason-bragg/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason-bragg/orleans/labels{/name}","releases_url":"https://api.github.com/repos/jason-bragg/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/jason-bragg/orleans/deployments","created_at":"2015-01-23T23:54:23Z","updated_at":"2016-01-12T20:12:57Z","pushed_at":"2016-12-13T22:37:32Z","git_url":"git://github.com/jason-bragg/orleans.git","ssh_url":"git@github.com:jason-bragg/orleans.git","clone_url":"https://github.com/jason-bragg/orleans.git","svn_url":"https://github.com/jason-bragg/orleans","homepage":"","size":14868,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e2462e111c9936b71eb29f0f7d0c4148dcc4e22b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2016-12-13T04:36:42Z","pushed_at":"2016-12-13T22:39:37Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":33193,"stargazers_count":2426,"watchers_count":2426,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":605,"mirror_url":null,"open_issues_count":247,"forks":605,"open_issues":247,"watchers":2426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2513"},"html":{"href":"https://github.com/dotnet/orleans/pull/2513"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2513"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2513/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2513/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2513/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/8b474d2e00fb5e8c3920c0ca8979d9d668221720"}}}}
{"actor":{"display_login":"galvesribeiro"}}