{"action":"created","comment":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/comments/62050112","id":62050112,"diff_hunk":"@@ -148,7 +149,7 @@ func (ic *IpmiCollector) GetMetricTypes(cfg plugin.PluginConfigType) ([]plugin.P\n \t\tfor _, req := range ic.Vendor[host] {\n \t\t\tfor _, metric := range req.Format.GetMetrics() {\n \t\t\t\tpath := extendPath(req.MetricsRoot, metric)\n-\t\t\t\tmts = append(mts, plugin.PluginMetricType{Namespace_: makeName(path), Source_: host})\n+\t\t\t\tmts = append(mts, plugin.MetricType{Namespace_: makeName(path), Tags_: map[string]string{\"host\": host}})","path":"nodeManagerPlugin/plugin.go","position":75,"original_position":75,"commit_id":"7c2a28096e527be49a2ffeb3df69aee340d3c3ab","original_commit_id":"7c2a28096e527be49a2ffeb3df69aee340d3c3ab","user":{"login":"PatrykMatyjasek","id":8512296,"avatar_url":"https://avatars.githubusercontent.com/u/8512296?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrykMatyjasek","html_url":"https://github.com/PatrykMatyjasek","followers_url":"https://api.github.com/users/PatrykMatyjasek/followers","following_url":"https://api.github.com/users/PatrykMatyjasek/following{/other_user}","gists_url":"https://api.github.com/users/PatrykMatyjasek/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrykMatyjasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrykMatyjasek/subscriptions","organizations_url":"https://api.github.com/users/PatrykMatyjasek/orgs","repos_url":"https://api.github.com/users/PatrykMatyjasek/repos","events_url":"https://api.github.com/users/PatrykMatyjasek/events{/privacy}","received_events_url":"https://api.github.com/users/PatrykMatyjasek/received_events","type":"User","site_admin":false},"body":"I think key name should be \"source\" instead of \"host\"","created_at":"2016-05-04T14:38:01Z","updated_at":"2016-05-04T14:38:01Z","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21#discussion_r62050112","pull_request_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/comments/62050112"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21#discussion_r62050112"},"pull_request":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21","id":68870443,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21","diff_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21.diff","patch_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21.patch","issue_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/21","number":21,"state":"open","locked":false,"title":"New metric schema","user":{"login":"mkleina","id":18285077,"avatar_url":"https://avatars.githubusercontent.com/u/18285077?v=3","gravatar_id":"","url":"https://api.github.com/users/mkleina","html_url":"https://github.com/mkleina","followers_url":"https://api.github.com/users/mkleina/followers","following_url":"https://api.github.com/users/mkleina/following{/other_user}","gists_url":"https://api.github.com/users/mkleina/gists{/gist_id}","starred_url":"https://api.github.com/users/mkleina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkleina/subscriptions","organizations_url":"https://api.github.com/users/mkleina/orgs","repos_url":"https://api.github.com/users/mkleina/repos","events_url":"https://api.github.com/users/mkleina/events{/privacy}","received_events_url":"https://api.github.com/users/mkleina/received_events","type":"User","site_admin":false},"body":"Plugin updated to new metric schema, now compatible with snap master (v0.13.0-beta-73-g170c8d3)","created_at":"2016-05-04T14:24:07Z","updated_at":"2016-05-04T14:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d339b1ff3ec60292bd4a2161edf3094c34721e80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21/commits","review_comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21/comments","review_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/21/comments","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/statuses/7c2a28096e527be49a2ffeb3df69aee340d3c3ab","head":{"label":"mkleina:master","ref":"master","sha":"7c2a28096e527be49a2ffeb3df69aee340d3c3ab","user":{"login":"mkleina","id":18285077,"avatar_url":"https://avatars.githubusercontent.com/u/18285077?v=3","gravatar_id":"","url":"https://api.github.com/users/mkleina","html_url":"https://github.com/mkleina","followers_url":"https://api.github.com/users/mkleina/followers","following_url":"https://api.github.com/users/mkleina/following{/other_user}","gists_url":"https://api.github.com/users/mkleina/gists{/gist_id}","starred_url":"https://api.github.com/users/mkleina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkleina/subscriptions","organizations_url":"https://api.github.com/users/mkleina/orgs","repos_url":"https://api.github.com/users/mkleina/repos","events_url":"https://api.github.com/users/mkleina/events{/privacy}","received_events_url":"https://api.github.com/users/mkleina/received_events","type":"User","site_admin":false},"repo":{"id":58042992,"name":"snap-plugin-collector-node-manager","full_name":"mkleina/snap-plugin-collector-node-manager","owner":{"login":"mkleina","id":18285077,"avatar_url":"https://avatars.githubusercontent.com/u/18285077?v=3","gravatar_id":"","url":"https://api.github.com/users/mkleina","html_url":"https://github.com/mkleina","followers_url":"https://api.github.com/users/mkleina/followers","following_url":"https://api.github.com/users/mkleina/following{/other_user}","gists_url":"https://api.github.com/users/mkleina/gists{/gist_id}","starred_url":"https://api.github.com/users/mkleina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkleina/subscriptions","organizations_url":"https://api.github.com/users/mkleina/orgs","repos_url":"https://api.github.com/users/mkleina/repos","events_url":"https://api.github.com/users/mkleina/events{/privacy}","received_events_url":"https://api.github.com/users/mkleina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkleina/snap-plugin-collector-node-manager","description":"snap plugin for collecting metrics from Intel Node Manager interface on servers","fork":true,"url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager","forks_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/forks","keys_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/teams","hooks_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/hooks","issue_events_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/issues/events{/number}","events_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/events","assignees_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/assignees{/user}","branches_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/branches{/branch}","tags_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/tags","blobs_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/languages","stargazers_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/stargazers","contributors_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/contributors","subscribers_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/subscribers","subscription_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/subscription","commits_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/contents/{+path}","compare_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/merges","archive_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/downloads","issues_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/issues{/number}","pulls_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/labels{/name}","releases_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/releases{/id}","deployments_url":"https://api.github.com/repos/mkleina/snap-plugin-collector-node-manager/deployments","created_at":"2016-05-04T10:18:00Z","updated_at":"2016-05-04T10:18:01Z","pushed_at":"2016-05-04T14:21:43Z","git_url":"git://github.com/mkleina/snap-plugin-collector-node-manager.git","ssh_url":"git@github.com:mkleina/snap-plugin-collector-node-manager.git","clone_url":"https://github.com/mkleina/snap-plugin-collector-node-manager.git","svn_url":"https://github.com/mkleina/snap-plugin-collector-node-manager","homepage":"","size":60,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intelsdi-x:master","ref":"master","sha":"38b9bb8b8704a15a496da20c63cb9e52f14f52c2","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":43827678,"name":"snap-plugin-collector-node-manager","full_name":"intelsdi-x/snap-plugin-collector-node-manager","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager","description":"snap plugin for collecting metrics from Intel Node Manager interface on servers","fork":false,"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager","forks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/forks","keys_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/events","assignees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/merges","archive_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/deployments","created_at":"2015-10-07T16:01:28Z","updated_at":"2016-04-21T02:50:19Z","pushed_at":"2016-05-04T14:24:08Z","git_url":"git://github.com/intelsdi-x/snap-plugin-collector-node-manager.git","ssh_url":"git@github.com:intelsdi-x/snap-plugin-collector-node-manager.git","clone_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager.git","svn_url":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-node-manager/pull/21"},"issue":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/21"},"comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-node-manager/statuses/7c2a28096e527be49a2ffeb3df69aee340d3c3ab"}}}}