{"action":"created","issue":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/512","repository_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine","labels_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/512/comments","events_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/512/events","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/512","id":161297372,"number":512,"title":"Removed call to setScale in CylinderCollisionShape.createShape","user":{"login":"riccardobl","id":4943530,"avatar_url":"https://avatars.githubusercontent.com/u/4943530?v=3","gravatar_id":"","url":"https://api.github.com/users/riccardobl","html_url":"https://github.com/riccardobl","followers_url":"https://api.github.com/users/riccardobl/followers","following_url":"https://api.github.com/users/riccardobl/following{/other_user}","gists_url":"https://api.github.com/users/riccardobl/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardobl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardobl/subscriptions","organizations_url":"https://api.github.com/users/riccardobl/orgs","repos_url":"https://api.github.com/users/riccardobl/repos","events_url":"https://api.github.com/users/riccardobl/events{/privacy}","received_events_url":"https://api.github.com/users/riccardobl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-20T21:16:13Z","updated_at":"2016-06-21T12:35:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/pulls/512","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/512","diff_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/512.diff","patch_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/512.patch"},"body":"That method just prints a warning, so from my point of view there is no reason to leave the call there.\r\nEDIT: I want to point out that this is an issue because when cylinder shapes are created frequently the logs are polluted with warnings about scaling when the developer isn't actually trying to scale the shape."},"comment":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/comments/227426066","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/512#issuecomment-227426066","issue_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/512","id":227426066,"user":{"login":"empirephoenix","id":2292999,"avatar_url":"https://avatars.githubusercontent.com/u/2292999?v=3","gravatar_id":"","url":"https://api.github.com/users/empirephoenix","html_url":"https://github.com/empirephoenix","followers_url":"https://api.github.com/users/empirephoenix/followers","following_url":"https://api.github.com/users/empirephoenix/following{/other_user}","gists_url":"https://api.github.com/users/empirephoenix/gists{/gist_id}","starred_url":"https://api.github.com/users/empirephoenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/empirephoenix/subscriptions","organizations_url":"https://api.github.com/users/empirephoenix/orgs","repos_url":"https://api.github.com/users/empirephoenix/repos","events_url":"https://api.github.com/users/empirephoenix/events{/privacy}","received_events_url":"https://api.github.com/users/empirephoenix/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T12:35:33Z","updated_at":"2016-06-21T12:35:33Z","body":"Agreed, both jbullet and native bullet just print a warning no need to trigger this manually.\r\n\r\nHowever I would propose instead to check in the setScale if the new scale is not 1,1,1. That way ay generic handling of collision shapes would not generate warning if they are not actually trying to change the scale."}}
{"actor":{"display_login":"empirephoenix"}}