{"action":"created","issue":{"url":"https://api.github.com/repos/mhinz/neovim-remote/issues/6","labels_url":"https://api.github.com/repos/mhinz/neovim-remote/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/mhinz/neovim-remote/issues/6/comments","events_url":"https://api.github.com/repos/mhinz/neovim-remote/issues/6/events","html_url":"https://github.com/mhinz/neovim-remote/pull/6","id":129351382,"number":6,"title":"Support for attaching to tcp sessions of neovim","user":{"login":"nhooyr","id":10180857,"avatar_url":"https://avatars.githubusercontent.com/u/10180857?v=3","gravatar_id":"","url":"https://api.github.com/users/nhooyr","html_url":"https://github.com/nhooyr","followers_url":"https://api.github.com/users/nhooyr/followers","following_url":"https://api.github.com/users/nhooyr/following{/other_user}","gists_url":"https://api.github.com/users/nhooyr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhooyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhooyr/subscriptions","organizations_url":"https://api.github.com/users/nhooyr/orgs","repos_url":"https://api.github.com/users/nhooyr/repos","events_url":"https://api.github.com/users/nhooyr/events{/privacy}","received_events_url":"https://api.github.com/users/nhooyr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-28T06:16:51Z","updated_at":"2016-01-28T10:56:16Z","closed_at":"2016-01-28T10:56:16Z","pull_request":{"url":"https://api.github.com/repos/mhinz/neovim-remote/pulls/6","html_url":"https://github.com/mhinz/neovim-remote/pull/6","diff_url":"https://github.com/mhinz/neovim-remote/pull/6.diff","patch_url":"https://github.com/mhinz/neovim-remote/pull/6.patch"},"body":"I updated the wrapper around nvim.attach() to allow attaching to tcp sessions. Also updated the documentation and variable names to reflect that we take an address, not necessarily a socket path.\r\n\r\nI changed the Try Except to be a catch all because there are a lot of different errors that could arise, the file not being a socket, the file not existing, can't connect to ip:port, whatever it is, just say can't connect. If you want, I can add more specific error messages.\r\n\r\nAlso a small bug was fixed where if NVIM_LISTEN_ADDRESS was set to an empty string nvr would still try to connect instead of setting it to the default '/tmp/nvimsocket'."},"comment":{"url":"https://api.github.com/repos/mhinz/neovim-remote/issues/comments/176123220","html_url":"https://github.com/mhinz/neovim-remote/pull/6#issuecomment-176123220","issue_url":"https://api.github.com/repos/mhinz/neovim-remote/issues/6","id":176123220,"user":{"login":"mhinz","id":972014,"avatar_url":"https://avatars.githubusercontent.com/u/972014?v=3","gravatar_id":"","url":"https://api.github.com/users/mhinz","html_url":"https://github.com/mhinz","followers_url":"https://api.github.com/users/mhinz/followers","following_url":"https://api.github.com/users/mhinz/following{/other_user}","gists_url":"https://api.github.com/users/mhinz/gists{/gist_id}","starred_url":"https://api.github.com/users/mhinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhinz/subscriptions","organizations_url":"https://api.github.com/users/mhinz/orgs","repos_url":"https://api.github.com/users/mhinz/repos","events_url":"https://api.github.com/users/mhinz/events{/privacy}","received_events_url":"https://api.github.com/users/mhinz/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T10:56:16Z","updated_at":"2016-01-28T10:56:16Z","body":"Merged, thanks!"}}