{"action":"closed","number":890,"pull_request":{"url":"https://api.github.com/repos/sasstools/sass-lint/pulls/890","id":89640999,"html_url":"https://github.com/sasstools/sass-lint/pull/890","diff_url":"https://github.com/sasstools/sass-lint/pull/890.diff","patch_url":"https://github.com/sasstools/sass-lint/pull/890.patch","issue_url":"https://api.github.com/repos/sasstools/sass-lint/issues/890","number":890,"state":"closed","locked":false,"title":"Fix false positive in border-zero","user":{"login":"richarddewit","id":7933750,"avatar_url":"https://avatars.githubusercontent.com/u/7933750?v=3","gravatar_id":"","url":"https://api.github.com/users/richarddewit","html_url":"https://github.com/richarddewit","followers_url":"https://api.github.com/users/richarddewit/followers","following_url":"https://api.github.com/users/richarddewit/following{/other_user}","gists_url":"https://api.github.com/users/richarddewit/gists{/gist_id}","starred_url":"https://api.github.com/users/richarddewit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richarddewit/subscriptions","organizations_url":"https://api.github.com/users/richarddewit/orgs","repos_url":"https://api.github.com/users/richarddewit/repos","events_url":"https://api.github.com/users/richarddewit/events{/privacy}","received_events_url":"https://api.github.com/users/richarddewit/received_events","type":"User","site_admin":false},"body":"<!--\r\n## New Pull Request Information\r\n\r\nPlease make sure you have read through our [contribution guidelines](https://github.com/sasstools/sass-lint/blob/develop/CONTRIBUTING.md#pull-requests) before submitting a pull request.\r\n\r\nMost importantly your pull request should provide information on what the changes do and they should reference an already created issue. e.g. 'Fixes #80' for bugs and 'Closes #90' for other issues.\r\n\r\nPlease use the headings below as guidance, you don't need to answer them point for point but the contents give you an idea of what we'd like to know about your PR.\r\n\r\nYou must also include your agreement to the developer certificate of origin below.\r\n\r\n-->\r\n\r\n**What do the changes you have made achieve?**\r\nThis fixes a false positive when `convention` is set to the integer `0` (as opposed to the string, which does work), by casting the `convention` to a string.\r\n\r\n**Are there any new warning messages?**\r\nNo\r\n\r\n**Have you written tests?**\r\nNo but I've tested it manually\r\n\r\n**Have you included relevant documentation**\r\nNot necessary\r\n\r\n**Which issues does this resolve?**\r\n#861\r\n\r\n`<DCO 1.1 Signed-off-by: Richard de Wit henk.exe@gmail.com>`","created_at":"2016-10-17T15:02:05Z","updated_at":"2016-10-26T16:45:13Z","closed_at":"2016-10-26T16:45:13Z","merged_at":null,"merge_commit_sha":"453eb589d10bbfce3b27ea20beff4b800a18d3d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sasstools/sass-lint/pulls/890/commits","review_comments_url":"https://api.github.com/repos/sasstools/sass-lint/pulls/890/comments","review_comment_url":"https://api.github.com/repos/sasstools/sass-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sasstools/sass-lint/issues/890/comments","statuses_url":"https://api.github.com/repos/sasstools/sass-lint/statuses/51ecc398e697fc14cb3667cda4d0d4c1068282de","head":{"label":"richarddewit:patch-1","ref":"patch-1","sha":"51ecc398e697fc14cb3667cda4d0d4c1068282de","user":{"login":"richarddewit","id":7933750,"avatar_url":"https://avatars.githubusercontent.com/u/7933750?v=3","gravatar_id":"","url":"https://api.github.com/users/richarddewit","html_url":"https://github.com/richarddewit","followers_url":"https://api.github.com/users/richarddewit/followers","following_url":"https://api.github.com/users/richarddewit/following{/other_user}","gists_url":"https://api.github.com/users/richarddewit/gists{/gist_id}","starred_url":"https://api.github.com/users/richarddewit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richarddewit/subscriptions","organizations_url":"https://api.github.com/users/richarddewit/orgs","repos_url":"https://api.github.com/users/richarddewit/repos","events_url":"https://api.github.com/users/richarddewit/events{/privacy}","received_events_url":"https://api.github.com/users/richarddewit/received_events","type":"User","site_admin":false},"repo":{"id":71141244,"name":"sass-lint","full_name":"richarddewit/sass-lint","owner":{"login":"richarddewit","id":7933750,"avatar_url":"https://avatars.githubusercontent.com/u/7933750?v=3","gravatar_id":"","url":"https://api.github.com/users/richarddewit","html_url":"https://github.com/richarddewit","followers_url":"https://api.github.com/users/richarddewit/followers","following_url":"https://api.github.com/users/richarddewit/following{/other_user}","gists_url":"https://api.github.com/users/richarddewit/gists{/gist_id}","starred_url":"https://api.github.com/users/richarddewit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richarddewit/subscriptions","organizations_url":"https://api.github.com/users/richarddewit/orgs","repos_url":"https://api.github.com/users/richarddewit/repos","events_url":"https://api.github.com/users/richarddewit/events{/privacy}","received_events_url":"https://api.github.com/users/richarddewit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richarddewit/sass-lint","description":"Pure Node.js Sass linting","fork":true,"url":"https://api.github.com/repos/richarddewit/sass-lint","forks_url":"https://api.github.com/repos/richarddewit/sass-lint/forks","keys_url":"https://api.github.com/repos/richarddewit/sass-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richarddewit/sass-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richarddewit/sass-lint/teams","hooks_url":"https://api.github.com/repos/richarddewit/sass-lint/hooks","issue_events_url":"https://api.github.com/repos/richarddewit/sass-lint/issues/events{/number}","events_url":"https://api.github.com/repos/richarddewit/sass-lint/events","assignees_url":"https://api.github.com/repos/richarddewit/sass-lint/assignees{/user}","branches_url":"https://api.github.com/repos/richarddewit/sass-lint/branches{/branch}","tags_url":"https://api.github.com/repos/richarddewit/sass-lint/tags","blobs_url":"https://api.github.com/repos/richarddewit/sass-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richarddewit/sass-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richarddewit/sass-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/richarddewit/sass-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richarddewit/sass-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/richarddewit/sass-lint/languages","stargazers_url":"https://api.github.com/repos/richarddewit/sass-lint/stargazers","contributors_url":"https://api.github.com/repos/richarddewit/sass-lint/contributors","subscribers_url":"https://api.github.com/repos/richarddewit/sass-lint/subscribers","subscription_url":"https://api.github.com/repos/richarddewit/sass-lint/subscription","commits_url":"https://api.github.com/repos/richarddewit/sass-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/richarddewit/sass-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/richarddewit/sass-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/richarddewit/sass-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/richarddewit/sass-lint/contents/{+path}","compare_url":"https://api.github.com/repos/richarddewit/sass-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richarddewit/sass-lint/merges","archive_url":"https://api.github.com/repos/richarddewit/sass-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richarddewit/sass-lint/downloads","issues_url":"https://api.github.com/repos/richarddewit/sass-lint/issues{/number}","pulls_url":"https://api.github.com/repos/richarddewit/sass-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/richarddewit/sass-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/richarddewit/sass-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richarddewit/sass-lint/labels{/name}","releases_url":"https://api.github.com/repos/richarddewit/sass-lint/releases{/id}","deployments_url":"https://api.github.com/repos/richarddewit/sass-lint/deployments","created_at":"2016-10-17T13:25:26Z","updated_at":"2016-10-17T13:25:27Z","pushed_at":"2016-10-17T13:48:37Z","git_url":"git://github.com/richarddewit/sass-lint.git","ssh_url":"git@github.com:richarddewit/sass-lint.git","clone_url":"https://github.com/richarddewit/sass-lint.git","svn_url":"https://github.com/richarddewit/sass-lint","homepage":"","size":1259,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sasstools:develop","ref":"develop","sha":"b7bcb3a4ec1a9c08d3883eb8c2acb97b6e6513c3","user":{"login":"sasstools","id":11896310,"avatar_url":"https://avatars.githubusercontent.com/u/11896310?v=3","gravatar_id":"","url":"https://api.github.com/users/sasstools","html_url":"https://github.com/sasstools","followers_url":"https://api.github.com/users/sasstools/followers","following_url":"https://api.github.com/users/sasstools/following{/other_user}","gists_url":"https://api.github.com/users/sasstools/gists{/gist_id}","starred_url":"https://api.github.com/users/sasstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasstools/subscriptions","organizations_url":"https://api.github.com/users/sasstools/orgs","repos_url":"https://api.github.com/users/sasstools/repos","events_url":"https://api.github.com/users/sasstools/events{/privacy}","received_events_url":"https://api.github.com/users/sasstools/received_events","type":"Organization","site_admin":false},"repo":{"id":30891787,"name":"sass-lint","full_name":"sasstools/sass-lint","owner":{"login":"sasstools","id":11896310,"avatar_url":"https://avatars.githubusercontent.com/u/11896310?v=3","gravatar_id":"","url":"https://api.github.com/users/sasstools","html_url":"https://github.com/sasstools","followers_url":"https://api.github.com/users/sasstools/followers","following_url":"https://api.github.com/users/sasstools/following{/other_user}","gists_url":"https://api.github.com/users/sasstools/gists{/gist_id}","starred_url":"https://api.github.com/users/sasstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasstools/subscriptions","organizations_url":"https://api.github.com/users/sasstools/orgs","repos_url":"https://api.github.com/users/sasstools/repos","events_url":"https://api.github.com/users/sasstools/events{/privacy}","received_events_url":"https://api.github.com/users/sasstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sasstools/sass-lint","description":"Pure Node.js Sass linting","fork":false,"url":"https://api.github.com/repos/sasstools/sass-lint","forks_url":"https://api.github.com/repos/sasstools/sass-lint/forks","keys_url":"https://api.github.com/repos/sasstools/sass-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sasstools/sass-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sasstools/sass-lint/teams","hooks_url":"https://api.github.com/repos/sasstools/sass-lint/hooks","issue_events_url":"https://api.github.com/repos/sasstools/sass-lint/issues/events{/number}","events_url":"https://api.github.com/repos/sasstools/sass-lint/events","assignees_url":"https://api.github.com/repos/sasstools/sass-lint/assignees{/user}","branches_url":"https://api.github.com/repos/sasstools/sass-lint/branches{/branch}","tags_url":"https://api.github.com/repos/sasstools/sass-lint/tags","blobs_url":"https://api.github.com/repos/sasstools/sass-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sasstools/sass-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sasstools/sass-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/sasstools/sass-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sasstools/sass-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/sasstools/sass-lint/languages","stargazers_url":"https://api.github.com/repos/sasstools/sass-lint/stargazers","contributors_url":"https://api.github.com/repos/sasstools/sass-lint/contributors","subscribers_url":"https://api.github.com/repos/sasstools/sass-lint/subscribers","subscription_url":"https://api.github.com/repos/sasstools/sass-lint/subscription","commits_url":"https://api.github.com/repos/sasstools/sass-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/sasstools/sass-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/sasstools/sass-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/sasstools/sass-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/sasstools/sass-lint/contents/{+path}","compare_url":"https://api.github.com/repos/sasstools/sass-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sasstools/sass-lint/merges","archive_url":"https://api.github.com/repos/sasstools/sass-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sasstools/sass-lint/downloads","issues_url":"https://api.github.com/repos/sasstools/sass-lint/issues{/number}","pulls_url":"https://api.github.com/repos/sasstools/sass-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/sasstools/sass-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/sasstools/sass-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sasstools/sass-lint/labels{/name}","releases_url":"https://api.github.com/repos/sasstools/sass-lint/releases{/id}","deployments_url":"https://api.github.com/repos/sasstools/sass-lint/deployments","created_at":"2015-02-16T22:33:34Z","updated_at":"2016-10-26T15:53:41Z","pushed_at":"2016-10-26T16:44:23Z","git_url":"git://github.com/sasstools/sass-lint.git","ssh_url":"git@github.com:sasstools/sass-lint.git","clone_url":"https://github.com/sasstools/sass-lint.git","svn_url":"https://github.com/sasstools/sass-lint","homepage":"","size":1457,"stargazers_count":798,"watchers_count":798,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":237,"mirror_url":null,"open_issues_count":131,"forks":237,"open_issues":131,"watchers":798,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sasstools/sass-lint/pulls/890"},"html":{"href":"https://github.com/sasstools/sass-lint/pull/890"},"issue":{"href":"https://api.github.com/repos/sasstools/sass-lint/issues/890"},"comments":{"href":"https://api.github.com/repos/sasstools/sass-lint/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/sasstools/sass-lint/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/sasstools/sass-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sasstools/sass-lint/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/sasstools/sass-lint/statuses/51ecc398e697fc14cb3667cda4d0d4c1068282de"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":3,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bgriffith"}}