{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/69677407","id":69677407,"diff_hunk":"@@ -3329,12 +3329,17 @@ int FileStore::_write(const coll_t& cid, const ghobject_t& oid,\n \n   // write\n   r = bl.write_fd(**fd, offset);\n-  if (r == 0)\n+  if (r < 0){","path":"src/os/filestore/FileStore.cc","position":5,"original_position":5,"commit_id":"fe539c1ecdcddb4b385618e6c119271b3791cf79","original_commit_id":"fe539c1ecdcddb4b385618e6c119271b3791cf79","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"need space...","created_at":"2016-07-06T05:35:38Z","updated_at":"2016-07-06T05:35:38Z","html_url":"https://github.com/ceph/ceph/pull/10146#discussion_r69677407","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10146","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/69677407"},"html":{"href":"https://github.com/ceph/ceph/pull/10146#discussion_r69677407"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10146"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10146","id":76377312,"html_url":"https://github.com/ceph/ceph/pull/10146","diff_url":"https://github.com/ceph/ceph/pull/10146.diff","patch_url":"https://github.com/ceph/ceph/pull/10146.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10146","number":10146,"state":"open","locked":false,"title":"os/filestore/FileStore.cc: fix the judgment for write_fd() returned ","user":{"login":"yonghengdexin735","id":13672833,"avatar_url":"https://avatars.githubusercontent.com/u/13672833?v=3","gravatar_id":"","url":"https://api.github.com/users/yonghengdexin735","html_url":"https://github.com/yonghengdexin735","followers_url":"https://api.github.com/users/yonghengdexin735/followers","following_url":"https://api.github.com/users/yonghengdexin735/following{/other_user}","gists_url":"https://api.github.com/users/yonghengdexin735/gists{/gist_id}","starred_url":"https://api.github.com/users/yonghengdexin735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonghengdexin735/subscriptions","organizations_url":"https://api.github.com/users/yonghengdexin735/orgs","repos_url":"https://api.github.com/users/yonghengdexin735/repos","events_url":"https://api.github.com/users/yonghengdexin735/events{/privacy}","received_events_url":"https://api.github.com/users/yonghengdexin735/received_events","type":"User","site_admin":false},"body":"r = bl.write_fd(**fd, offset)  returned negative or zero ,so I fix its judgment.\r\n\r\nSigned-off-by: zhang.zezhu <zhang.zezhu@zte.com.cn>","created_at":"2016-07-06T04:25:58Z","updated_at":"2016-07-06T05:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef7f3e70e343c2e35d4a90421a1680245336827a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10146/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10146/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10146/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/fe539c1ecdcddb4b385618e6c119271b3791cf79","head":{"label":"yonghengdexin735:wip-zzz-filestore-write","ref":"wip-zzz-filestore-write","sha":"fe539c1ecdcddb4b385618e6c119271b3791cf79","user":{"login":"yonghengdexin735","id":13672833,"avatar_url":"https://avatars.githubusercontent.com/u/13672833?v=3","gravatar_id":"","url":"https://api.github.com/users/yonghengdexin735","html_url":"https://github.com/yonghengdexin735","followers_url":"https://api.github.com/users/yonghengdexin735/followers","following_url":"https://api.github.com/users/yonghengdexin735/following{/other_user}","gists_url":"https://api.github.com/users/yonghengdexin735/gists{/gist_id}","starred_url":"https://api.github.com/users/yonghengdexin735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonghengdexin735/subscriptions","organizations_url":"https://api.github.com/users/yonghengdexin735/orgs","repos_url":"https://api.github.com/users/yonghengdexin735/repos","events_url":"https://api.github.com/users/yonghengdexin735/events{/privacy}","received_events_url":"https://api.github.com/users/yonghengdexin735/received_events","type":"User","site_admin":false},"repo":{"id":43876853,"name":"ceph","full_name":"yonghengdexin735/ceph","owner":{"login":"yonghengdexin735","id":13672833,"avatar_url":"https://avatars.githubusercontent.com/u/13672833?v=3","gravatar_id":"","url":"https://api.github.com/users/yonghengdexin735","html_url":"https://github.com/yonghengdexin735","followers_url":"https://api.github.com/users/yonghengdexin735/followers","following_url":"https://api.github.com/users/yonghengdexin735/following{/other_user}","gists_url":"https://api.github.com/users/yonghengdexin735/gists{/gist_id}","starred_url":"https://api.github.com/users/yonghengdexin735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonghengdexin735/subscriptions","organizations_url":"https://api.github.com/users/yonghengdexin735/orgs","repos_url":"https://api.github.com/users/yonghengdexin735/repos","events_url":"https://api.github.com/users/yonghengdexin735/events{/privacy}","received_events_url":"https://api.github.com/users/yonghengdexin735/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yonghengdexin735/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yonghengdexin735/ceph","forks_url":"https://api.github.com/repos/yonghengdexin735/ceph/forks","keys_url":"https://api.github.com/repos/yonghengdexin735/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonghengdexin735/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonghengdexin735/ceph/teams","hooks_url":"https://api.github.com/repos/yonghengdexin735/ceph/hooks","issue_events_url":"https://api.github.com/repos/yonghengdexin735/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yonghengdexin735/ceph/events","assignees_url":"https://api.github.com/repos/yonghengdexin735/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yonghengdexin735/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yonghengdexin735/ceph/tags","blobs_url":"https://api.github.com/repos/yonghengdexin735/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonghengdexin735/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonghengdexin735/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonghengdexin735/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonghengdexin735/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yonghengdexin735/ceph/languages","stargazers_url":"https://api.github.com/repos/yonghengdexin735/ceph/stargazers","contributors_url":"https://api.github.com/repos/yonghengdexin735/ceph/contributors","subscribers_url":"https://api.github.com/repos/yonghengdexin735/ceph/subscribers","subscription_url":"https://api.github.com/repos/yonghengdexin735/ceph/subscription","commits_url":"https://api.github.com/repos/yonghengdexin735/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonghengdexin735/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonghengdexin735/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonghengdexin735/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonghengdexin735/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yonghengdexin735/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonghengdexin735/ceph/merges","archive_url":"https://api.github.com/repos/yonghengdexin735/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonghengdexin735/ceph/downloads","issues_url":"https://api.github.com/repos/yonghengdexin735/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yonghengdexin735/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yonghengdexin735/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yonghengdexin735/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonghengdexin735/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yonghengdexin735/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yonghengdexin735/ceph/deployments","created_at":"2015-10-08T09:19:55Z","updated_at":"2016-05-25T08:24:46Z","pushed_at":"2016-07-06T04:34:15Z","git_url":"git://github.com/yonghengdexin735/ceph.git","ssh_url":"git@github.com:yonghengdexin735/ceph.git","clone_url":"https://github.com/yonghengdexin735/ceph.git","svn_url":"https://github.com/yonghengdexin735/ceph","homepage":"http://ceph.com","size":167157,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"b342bf8ea127dae39cfdaa6558a77640905890f5","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-07-06T04:18:34Z","pushed_at":"2016-07-06T05:29:40Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":225579,"stargazers_count":2283,"watchers_count":2283,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1356,"mirror_url":null,"open_issues_count":455,"forks":1356,"open_issues":455,"watchers":2283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10146"},"html":{"href":"https://github.com/ceph/ceph/pull/10146"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10146"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10146/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10146/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10146/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/fe539c1ecdcddb4b385618e6c119271b3791cf79"}}}}
{"actor":{"display_login":"xiexingguo"}}