{"action":"created","comment":{"url":"https://api.github.com/repos/YPlan/gargoyle/pulls/comments/78283534","id":78283534,"diff_hunk":"@@ -51,7 +50,7 @@ def clean(self, value):\n         return value\n \n     def render(self, value):\n-        return mark_safe('<input type=\"text\" value=\"%s\" name=\"%s\"/>' % (escape(value or ''), escape(self.name)))\n+        return format_html('<input type=\"text\" value=\"%s\" name=\"%s\"/>' % (value or '', self.name))","path":"gargoyle/conditions.py","position":15,"original_position":15,"commit_id":"52ce52a8285a34cb07c4751b29bda26b242af1eb","original_commit_id":"52ce52a8285a34cb07c4751b29bda26b242af1eb","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"body":"I'm afraid this isn't properly using `format_html` because it's passing the fully interpolated string in! You need to do e.g. `format_html('<tag x=\"{y}\">', y=foo)`","created_at":"2016-09-10T20:30:52Z","updated_at":"2016-09-10T20:30:52Z","html_url":"https://github.com/YPlan/gargoyle/pull/93#discussion_r78283534","pull_request_url":"https://api.github.com/repos/YPlan/gargoyle/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/comments/78283534"},"html":{"href":"https://github.com/YPlan/gargoyle/pull/93#discussion_r78283534"},"pull_request":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/YPlan/gargoyle/pulls/93","id":84032687,"html_url":"https://github.com/YPlan/gargoyle/pull/93","diff_url":"https://github.com/YPlan/gargoyle/pull/93.diff","patch_url":"https://github.com/YPlan/gargoyle/pull/93.patch","issue_url":"https://api.github.com/repos/YPlan/gargoyle/issues/93","number":93,"state":"open","locked":false,"title":"Use format_html instead of mark_safe","user":{"login":"nkovshov","id":1019535,"avatar_url":"https://avatars.githubusercontent.com/u/1019535?v=3","gravatar_id":"","url":"https://api.github.com/users/nkovshov","html_url":"https://github.com/nkovshov","followers_url":"https://api.github.com/users/nkovshov/followers","following_url":"https://api.github.com/users/nkovshov/following{/other_user}","gists_url":"https://api.github.com/users/nkovshov/gists{/gist_id}","starred_url":"https://api.github.com/users/nkovshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkovshov/subscriptions","organizations_url":"https://api.github.com/users/nkovshov/orgs","repos_url":"https://api.github.com/users/nkovshov/repos","events_url":"https://api.github.com/users/nkovshov/events{/privacy}","received_events_url":"https://api.github.com/users/nkovshov/received_events","type":"User","site_admin":false},"body":"Fixes issue #25 ","created_at":"2016-09-05T18:52:01Z","updated_at":"2016-09-10T20:30:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7086efaa2f68662e742524fc2b3aee03fb249f5b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/YPlan/gargoyle/pulls/93/commits","review_comments_url":"https://api.github.com/repos/YPlan/gargoyle/pulls/93/comments","review_comment_url":"https://api.github.com/repos/YPlan/gargoyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YPlan/gargoyle/issues/93/comments","statuses_url":"https://api.github.com/repos/YPlan/gargoyle/statuses/52ce52a8285a34cb07c4751b29bda26b242af1eb","head":{"label":"nkovshov:master","ref":"master","sha":"52ce52a8285a34cb07c4751b29bda26b242af1eb","user":{"login":"nkovshov","id":1019535,"avatar_url":"https://avatars.githubusercontent.com/u/1019535?v=3","gravatar_id":"","url":"https://api.github.com/users/nkovshov","html_url":"https://github.com/nkovshov","followers_url":"https://api.github.com/users/nkovshov/followers","following_url":"https://api.github.com/users/nkovshov/following{/other_user}","gists_url":"https://api.github.com/users/nkovshov/gists{/gist_id}","starred_url":"https://api.github.com/users/nkovshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkovshov/subscriptions","organizations_url":"https://api.github.com/users/nkovshov/orgs","repos_url":"https://api.github.com/users/nkovshov/repos","events_url":"https://api.github.com/users/nkovshov/events{/privacy}","received_events_url":"https://api.github.com/users/nkovshov/received_events","type":"User","site_admin":false},"repo":{"id":67408273,"name":"gargoyle","full_name":"nkovshov/gargoyle","owner":{"login":"nkovshov","id":1019535,"avatar_url":"https://avatars.githubusercontent.com/u/1019535?v=3","gravatar_id":"","url":"https://api.github.com/users/nkovshov","html_url":"https://github.com/nkovshov","followers_url":"https://api.github.com/users/nkovshov/followers","following_url":"https://api.github.com/users/nkovshov/following{/other_user}","gists_url":"https://api.github.com/users/nkovshov/gists{/gist_id}","starred_url":"https://api.github.com/users/nkovshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkovshov/subscriptions","organizations_url":"https://api.github.com/users/nkovshov/orgs","repos_url":"https://api.github.com/users/nkovshov/repos","events_url":"https://api.github.com/users/nkovshov/events{/privacy}","received_events_url":"https://api.github.com/users/nkovshov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkovshov/gargoyle","description":":radio_button: Feature switches in Django","fork":true,"url":"https://api.github.com/repos/nkovshov/gargoyle","forks_url":"https://api.github.com/repos/nkovshov/gargoyle/forks","keys_url":"https://api.github.com/repos/nkovshov/gargoyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkovshov/gargoyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkovshov/gargoyle/teams","hooks_url":"https://api.github.com/repos/nkovshov/gargoyle/hooks","issue_events_url":"https://api.github.com/repos/nkovshov/gargoyle/issues/events{/number}","events_url":"https://api.github.com/repos/nkovshov/gargoyle/events","assignees_url":"https://api.github.com/repos/nkovshov/gargoyle/assignees{/user}","branches_url":"https://api.github.com/repos/nkovshov/gargoyle/branches{/branch}","tags_url":"https://api.github.com/repos/nkovshov/gargoyle/tags","blobs_url":"https://api.github.com/repos/nkovshov/gargoyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkovshov/gargoyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkovshov/gargoyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkovshov/gargoyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkovshov/gargoyle/statuses/{sha}","languages_url":"https://api.github.com/repos/nkovshov/gargoyle/languages","stargazers_url":"https://api.github.com/repos/nkovshov/gargoyle/stargazers","contributors_url":"https://api.github.com/repos/nkovshov/gargoyle/contributors","subscribers_url":"https://api.github.com/repos/nkovshov/gargoyle/subscribers","subscription_url":"https://api.github.com/repos/nkovshov/gargoyle/subscription","commits_url":"https://api.github.com/repos/nkovshov/gargoyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkovshov/gargoyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkovshov/gargoyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkovshov/gargoyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkovshov/gargoyle/contents/{+path}","compare_url":"https://api.github.com/repos/nkovshov/gargoyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkovshov/gargoyle/merges","archive_url":"https://api.github.com/repos/nkovshov/gargoyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkovshov/gargoyle/downloads","issues_url":"https://api.github.com/repos/nkovshov/gargoyle/issues{/number}","pulls_url":"https://api.github.com/repos/nkovshov/gargoyle/pulls{/number}","milestones_url":"https://api.github.com/repos/nkovshov/gargoyle/milestones{/number}","notifications_url":"https://api.github.com/repos/nkovshov/gargoyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkovshov/gargoyle/labels{/name}","releases_url":"https://api.github.com/repos/nkovshov/gargoyle/releases{/id}","deployments_url":"https://api.github.com/repos/nkovshov/gargoyle/deployments","created_at":"2016-09-05T09:41:57Z","updated_at":"2016-09-05T09:41:58Z","pushed_at":"2016-09-05T18:47:21Z","git_url":"git://github.com/nkovshov/gargoyle.git","ssh_url":"git@github.com:nkovshov/gargoyle.git","clone_url":"https://github.com/nkovshov/gargoyle.git","svn_url":"https://github.com/nkovshov/gargoyle","homepage":"","size":646,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YPlan:master","ref":"master","sha":"40578771807a7f5d6403a825ea89308153312f90","user":{"login":"YPlan","id":2026115,"avatar_url":"https://avatars.githubusercontent.com/u/2026115?v=3","gravatar_id":"","url":"https://api.github.com/users/YPlan","html_url":"https://github.com/YPlan","followers_url":"https://api.github.com/users/YPlan/followers","following_url":"https://api.github.com/users/YPlan/following{/other_user}","gists_url":"https://api.github.com/users/YPlan/gists{/gist_id}","starred_url":"https://api.github.com/users/YPlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YPlan/subscriptions","organizations_url":"https://api.github.com/users/YPlan/orgs","repos_url":"https://api.github.com/users/YPlan/repos","events_url":"https://api.github.com/users/YPlan/events{/privacy}","received_events_url":"https://api.github.com/users/YPlan/received_events","type":"Organization","site_admin":false},"repo":{"id":42048726,"name":"gargoyle","full_name":"YPlan/gargoyle","owner":{"login":"YPlan","id":2026115,"avatar_url":"https://avatars.githubusercontent.com/u/2026115?v=3","gravatar_id":"","url":"https://api.github.com/users/YPlan","html_url":"https://github.com/YPlan","followers_url":"https://api.github.com/users/YPlan/followers","following_url":"https://api.github.com/users/YPlan/following{/other_user}","gists_url":"https://api.github.com/users/YPlan/gists{/gist_id}","starred_url":"https://api.github.com/users/YPlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YPlan/subscriptions","organizations_url":"https://api.github.com/users/YPlan/orgs","repos_url":"https://api.github.com/users/YPlan/repos","events_url":"https://api.github.com/users/YPlan/events{/privacy}","received_events_url":"https://api.github.com/users/YPlan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YPlan/gargoyle","description":":radio_button: Feature switches in Django","fork":true,"url":"https://api.github.com/repos/YPlan/gargoyle","forks_url":"https://api.github.com/repos/YPlan/gargoyle/forks","keys_url":"https://api.github.com/repos/YPlan/gargoyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YPlan/gargoyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YPlan/gargoyle/teams","hooks_url":"https://api.github.com/repos/YPlan/gargoyle/hooks","issue_events_url":"https://api.github.com/repos/YPlan/gargoyle/issues/events{/number}","events_url":"https://api.github.com/repos/YPlan/gargoyle/events","assignees_url":"https://api.github.com/repos/YPlan/gargoyle/assignees{/user}","branches_url":"https://api.github.com/repos/YPlan/gargoyle/branches{/branch}","tags_url":"https://api.github.com/repos/YPlan/gargoyle/tags","blobs_url":"https://api.github.com/repos/YPlan/gargoyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YPlan/gargoyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YPlan/gargoyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/YPlan/gargoyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YPlan/gargoyle/statuses/{sha}","languages_url":"https://api.github.com/repos/YPlan/gargoyle/languages","stargazers_url":"https://api.github.com/repos/YPlan/gargoyle/stargazers","contributors_url":"https://api.github.com/repos/YPlan/gargoyle/contributors","subscribers_url":"https://api.github.com/repos/YPlan/gargoyle/subscribers","subscription_url":"https://api.github.com/repos/YPlan/gargoyle/subscription","commits_url":"https://api.github.com/repos/YPlan/gargoyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/YPlan/gargoyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/YPlan/gargoyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/YPlan/gargoyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/YPlan/gargoyle/contents/{+path}","compare_url":"https://api.github.com/repos/YPlan/gargoyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YPlan/gargoyle/merges","archive_url":"https://api.github.com/repos/YPlan/gargoyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YPlan/gargoyle/downloads","issues_url":"https://api.github.com/repos/YPlan/gargoyle/issues{/number}","pulls_url":"https://api.github.com/repos/YPlan/gargoyle/pulls{/number}","milestones_url":"https://api.github.com/repos/YPlan/gargoyle/milestones{/number}","notifications_url":"https://api.github.com/repos/YPlan/gargoyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YPlan/gargoyle/labels{/name}","releases_url":"https://api.github.com/repos/YPlan/gargoyle/releases{/id}","deployments_url":"https://api.github.com/repos/YPlan/gargoyle/deployments","created_at":"2015-09-07T11:14:52Z","updated_at":"2016-09-03T11:51:24Z","pushed_at":"2016-09-05T18:52:01Z","git_url":"git://github.com/YPlan/gargoyle.git","ssh_url":"git@github.com:YPlan/gargoyle.git","clone_url":"https://github.com/YPlan/gargoyle.git","svn_url":"https://github.com/YPlan/gargoyle","homepage":"","size":648,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/93"},"html":{"href":"https://github.com/YPlan/gargoyle/pull/93"},"issue":{"href":"https://api.github.com/repos/YPlan/gargoyle/issues/93"},"comments":{"href":"https://api.github.com/repos/YPlan/gargoyle/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YPlan/gargoyle/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/YPlan/gargoyle/statuses/52ce52a8285a34cb07c4751b29bda26b242af1eb"}}}}
{"actor":{"display_login":"adamchainz"}}