{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/brave/issues/126","labels_url":"https://api.github.com/repos/openzipkin/brave/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/brave/issues/126/comments","events_url":"https://api.github.com/repos/openzipkin/brave/issues/126/events","html_url":"https://github.com/openzipkin/brave/pull/126","id":127912468,"number":126,"title":"Package required thrift classes for brave-core","user":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-21T12:19:01Z","updated_at":"2016-01-21T15:36:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/brave/pulls/126","html_url":"https://github.com/openzipkin/brave/pull/126","diff_url":"https://github.com/openzipkin/brave/pull/126.diff","patch_url":"https://github.com/openzipkin/brave/pull/126.patch"},"body":"The generated model classes require thrift, so thrift is not optional.\r\n\r\nlibthrift 0.9.0 has a special problem: it includes java source files.\r\nThe shade-relocate would extract them and inflate brave-core-shaded to 400k\r\nNewer versions no longer have the problem, and as the model classes were\r\ngenerated with 0.9.2, I thought this might be a sensible upgrade."},"comment":{"url":"https://api.github.com/repos/openzipkin/brave/issues/comments/173608747","html_url":"https://github.com/openzipkin/brave/pull/126#issuecomment-173608747","issue_url":"https://api.github.com/repos/openzipkin/brave/issues/126","id":173608747,"user":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T15:36:52Z","updated_at":"2016-01-21T15:36:52Z","body":"Check out this commit:\r\nhttps://github.com/CodingFabian/brave/commit/a91a057d8255be75314f848d787be8b30735226f\r\n\r\nIt *almost* works. you will see compile errors in AnnotationSubmitter. It modifies the current span. So what I used is the copy constructor to make a new span which has the annotation.\r\nBut I was unsuccessful in changing ths SpanState management so that I can set a new span. (basically because this autovalue thing only accepts span, and sometimes I need serverspan)\r\n\r\nShould be manageable by somebody who is more familiar with the code."}}