{"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/66556785","id":66556785,"diff_hunk":"@@ -20,12 +20,12 @@\n public class ColorProperty extends AEditableProperty {\n   // compatible with 0.9.0.2 saved games\n   private static final long serialVersionUID = 6826763550643504789L;\n-  private final int m_max = 0xFFFFFF;\n-  private final int m_min = 0x000000;\n   private Color m_color;\n \n   public ColorProperty(final String name, final String description, final int def) {\n     super(name, description);\n+    int m_max = 0xFFFFFF;","path":"src/games/strategy/engine/data/properties/ColorProperty.java","position":10,"original_position":10,"commit_id":"0a9f4f2c8397cdcdac1b28b4d90cd42e7f1b0bdf","original_commit_id":"0a9f4f2c8397cdcdac1b28b4d90cd42e7f1b0bdf","user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"body":"Should these instead be static final constants?","created_at":"2016-06-10T03:10:11Z","updated_at":"2016-06-10T03:10:11Z","html_url":"https://github.com/triplea-game/triplea/pull/775#discussion_r66556785","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/775","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/66556785"},"html":{"href":"https://github.com/triplea-game/triplea/pull/775#discussion_r66556785"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/775","id":72446972,"html_url":"https://github.com/triplea-game/triplea/pull/775","diff_url":"https://github.com/triplea-game/triplea/pull/775.diff","patch_url":"https://github.com/triplea-game/triplea/pull/775.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/775","number":775,"state":"open","locked":false,"title":"Convert class fields to local","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"body":"Used an IntelliJ code inspection tool to inline class level variables. \r\n\r\n\"This inspection searches for redundant class fields that can be replaced with local variables. If all local usages of a field are preceded by assignments to that field, the field can be removed and its usages replaced with local variables.\"\r\n\r\nIt is a bit of an endemic problem in the code base of too many class level variables.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/triplea-game/triplea/775)\n<!-- Reviewable:end -->\n","created_at":"2016-06-03T02:49:43Z","updated_at":"2016-06-10T03:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf56496a825d254c12b38e8a4ae1c3176432f47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/775/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/775/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/775/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/0a9f4f2c8397cdcdac1b28b4d90cd42e7f1b0bdf","head":{"label":"DanVanAtta:inline_variables","ref":"inline_variables","sha":"0a9f4f2c8397cdcdac1b28b4d90cd42e7f1b0bdf","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"repo":{"id":39811826,"name":"triplea","full_name":"DanVanAtta/triplea","owner":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanVanAtta/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/DanVanAtta/triplea","forks_url":"https://api.github.com/repos/DanVanAtta/triplea/forks","keys_url":"https://api.github.com/repos/DanVanAtta/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanVanAtta/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanVanAtta/triplea/teams","hooks_url":"https://api.github.com/repos/DanVanAtta/triplea/hooks","issue_events_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/DanVanAtta/triplea/events","assignees_url":"https://api.github.com/repos/DanVanAtta/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/DanVanAtta/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/DanVanAtta/triplea/tags","blobs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanVanAtta/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanVanAtta/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanVanAtta/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/DanVanAtta/triplea/languages","stargazers_url":"https://api.github.com/repos/DanVanAtta/triplea/stargazers","contributors_url":"https://api.github.com/repos/DanVanAtta/triplea/contributors","subscribers_url":"https://api.github.com/repos/DanVanAtta/triplea/subscribers","subscription_url":"https://api.github.com/repos/DanVanAtta/triplea/subscription","commits_url":"https://api.github.com/repos/DanVanAtta/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanVanAtta/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanVanAtta/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanVanAtta/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/DanVanAtta/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanVanAtta/triplea/merges","archive_url":"https://api.github.com/repos/DanVanAtta/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanVanAtta/triplea/downloads","issues_url":"https://api.github.com/repos/DanVanAtta/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/DanVanAtta/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/DanVanAtta/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/DanVanAtta/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanVanAtta/triplea/labels{/name}","releases_url":"https://api.github.com/repos/DanVanAtta/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/DanVanAtta/triplea/deployments","created_at":"2015-07-28T03:48:44Z","updated_at":"2016-01-12T03:47:00Z","pushed_at":"2016-06-09T06:53:37Z","git_url":"git://github.com/DanVanAtta/triplea.git","ssh_url":"git@github.com:DanVanAtta/triplea.git","clone_url":"https://github.com/DanVanAtta/triplea.git","svn_url":"https://github.com/DanVanAtta/triplea","homepage":null,"size":701078,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"cabe8a23c7794969a9ff2be70ae9367b2b5a6494","user":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/triplea-game/triplea/deployments","created_at":"2015-07-27T09:32:58Z","updated_at":"2016-06-07T15:57:52Z","pushed_at":"2016-06-10T02:37:05Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":null,"size":711143,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":110,"forks":14,"open_issues":110,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/775"},"html":{"href":"https://github.com/triplea-game/triplea/pull/775"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/775"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/0a9f4f2c8397cdcdac1b28b4d90cd42e7f1b0bdf"}}}}
{"actor":{"display_login":"ron-murhammer"}}