{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/82411400","pull_request_review_id":3323014,"id":82411400,"diff_hunk":"@@ -2,35 +2,65 @@\n source \"$(dirname \"${BASH_SOURCE}\")/../../hack/lib/init.sh\"\n trap os::test::junit::reconcile_output EXIT\n \n+# Cleanup cluster resources created by this test\n+(\n+  set +e\n+  oc delete namespace sdn-test-1\n+  oc delete namespace sdn-test-2\n+  oc delete namespace sdn-test-3\n+  oc delete egressnetworkpolicy --all\n+  exit 0\n+) &>/dev/null\n+\n os::test::junit::declare_suite_start \"cmd/sdn\"\n \n+os::test::junit::declare_suite_start \"cmd/sdn/clusternetworks\"\n os::cmd::expect_success 'oc get clusternetworks'\n+# Sanity check that the environment is as expected, or the NetNamespace tests will fail\n os::cmd::expect_success_and_text 'oc get clusternetwork default -o jsonpath=\"{.pluginName}\"' 'redhat/openshift-ovs-multitenant'\n-os::cmd::expect_failure_and_text 'oc patch clusternetwork default -p \"{\\\"network\\\": \\\"1.0.0.0/8\\\"}\"' 'Invalid value'\n-os::cmd::expect_failure_and_text 'oc patch clusternetwork default -p \"{\\\"hostsubnetlength\\\": 22}\"' 'Invalid value'\n-os::cmd::expect_failure_and_text 'oc patch clusternetwork default -p \"{\\\"serviceNetwork\\\": \\\"1.0.0.0/8\\\"}\"' 'Invalid value'\n+os::test::junit::declare_suite_end\n \n+os::test::junit::declare_suite_start \"cmd/sdn/netnamespaces\"\n orig_project=\"$(oc project -q)\"\n \n os::cmd::expect_success 'oc get netnamespaces'\n os::cmd::expect_success_and_text 'oc get netnamespace default -o jsonpath=\"{.netid}\"' '^0$'\n-os::cmd::expect_failure 'oc get netnamespace sdn-test'\n-os::cmd::expect_success 'oc new-project sdn-test'\n-os::cmd::expect_success 'oc get namespace sdn-test'\n-os::cmd::try_until_success 'oc get netnamespace sdn-test'\n-os::cmd::expect_success_and_not_text 'oc get netnamespace sdn-test -o jsonpath=\"{.netid}\"' '^0$'\n-os::cmd::expect_success 'oc delete namespace sdn-test'\n-os::cmd::try_until_failure 'oc get netnamespace sdn-test'\n+\n+os::cmd::expect_success 'oc new-project sdn-test-1'\n+os::cmd::expect_success 'oc new-project sdn-test-2'\n+os::cmd::expect_success 'oc new-project sdn-test-3'\n+os::cmd::try_until_success 'oc get netnamespace sdn-test-1'\n+os::cmd::expect_success_and_not_text 'oc get netnamespace sdn-test-1 -o jsonpath=\"{.netid}\"' '^0$'\n+orig_vnid1=\"$(oc get netnamespace sdn-test-1 -o jsonpath='{.netid}')\"\n+os::cmd::try_until_success 'oc get netnamespace sdn-test-2'\n+os::cmd::try_until_success 'oc get netnamespace sdn-test-3'\n+\n+os::cmd::expect_success 'oadm pod-network join-projects --to=sdn-test-1 sdn-test-2'\n+os::cmd::expect_success_and_text 'oc get netnamespace sdn-test-2 -o jsonpath=\"{.netid}\"' \"^${orig_vnid1}\\$\"\n+\n+os::cmd::expect_success 'oadm pod-network make-projects-global sdn-test-1'\n+os::cmd::expect_success_and_text 'oc get netnamespace sdn-test-1 -o jsonpath=\"{.netid}\"' '^0$'\n+\n+os::cmd::expect_success 'oadm pod-network isolate-projects sdn-test-1'\n+os::cmd::expect_success_and_not_text 'oc get netnamespace sdn-test-1 -o jsonpath=\"{.netid}\"' '^0$'\n+\n+os::cmd::expect_success 'oc delete namespace sdn-test-1'","path":"test/cmd/sdn.sh","position":56,"original_position":56,"commit_id":"3cbc85c9cd64423e4b88e9fa075d21640ab2227d","original_commit_id":"3cbc85c9cd64423e4b88e9fa075d21640ab2227d","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"We've got these in the cluster cleanup block, I don't think we also need them here.","created_at":"2016-10-07T15:24:07Z","updated_at":"2016-10-07T15:24:29Z","html_url":"https://github.com/openshift/origin/pull/11247#discussion_r82411400","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11247","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/82411400"},"html":{"href":"https://github.com/openshift/origin/pull/11247#discussion_r82411400"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11247"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11247","id":88274887,"html_url":"https://github.com/openshift/origin/pull/11247","diff_url":"https://github.com/openshift/origin/pull/11247.diff","patch_url":"https://github.com/openshift/origin/pull/11247.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11247","number":11247,"state":"open","locked":false,"title":"Add \"oadm pod-network\" tests to test/cmd, remove from test/extended","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"The connectivity testing in test/extended/networking/pod_network_cli.go is more-or-less redundant with other existing extended networking tests. So just remove it and test just the database-manipulating parts of it in test-cmd instead, to speed up the extended networking tests.\r\n\r\n@openshift/networking, @stevekuznetsov PTAL\r\n@danmcp FYI\r\n","created_at":"2016-10-06T14:38:45Z","updated_at":"2016-10-07T15:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8072066ff2eca663923075d0fc747cab49ff4d3d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11247/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11247/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11247/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3cbc85c9cd64423e4b88e9fa075d21640ab2227d","head":{"label":"danwinship:move-pod-network-tests","ref":"move-pod-network-tests","sha":"3cbc85c9cd64423e4b88e9fa075d21640ab2227d","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"repo":{"id":36016405,"name":"origin","full_name":"danwinship/origin","owner":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danwinship/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/danwinship/origin","forks_url":"https://api.github.com/repos/danwinship/origin/forks","keys_url":"https://api.github.com/repos/danwinship/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danwinship/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danwinship/origin/teams","hooks_url":"https://api.github.com/repos/danwinship/origin/hooks","issue_events_url":"https://api.github.com/repos/danwinship/origin/issues/events{/number}","events_url":"https://api.github.com/repos/danwinship/origin/events","assignees_url":"https://api.github.com/repos/danwinship/origin/assignees{/user}","branches_url":"https://api.github.com/repos/danwinship/origin/branches{/branch}","tags_url":"https://api.github.com/repos/danwinship/origin/tags","blobs_url":"https://api.github.com/repos/danwinship/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danwinship/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danwinship/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/danwinship/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danwinship/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/danwinship/origin/languages","stargazers_url":"https://api.github.com/repos/danwinship/origin/stargazers","contributors_url":"https://api.github.com/repos/danwinship/origin/contributors","subscribers_url":"https://api.github.com/repos/danwinship/origin/subscribers","subscription_url":"https://api.github.com/repos/danwinship/origin/subscription","commits_url":"https://api.github.com/repos/danwinship/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/danwinship/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/danwinship/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/danwinship/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/danwinship/origin/contents/{+path}","compare_url":"https://api.github.com/repos/danwinship/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danwinship/origin/merges","archive_url":"https://api.github.com/repos/danwinship/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danwinship/origin/downloads","issues_url":"https://api.github.com/repos/danwinship/origin/issues{/number}","pulls_url":"https://api.github.com/repos/danwinship/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/danwinship/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/danwinship/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danwinship/origin/labels{/name}","releases_url":"https://api.github.com/repos/danwinship/origin/releases{/id}","deployments_url":"https://api.github.com/repos/danwinship/origin/deployments","created_at":"2015-05-21T14:09:10Z","updated_at":"2016-08-20T09:19:19Z","pushed_at":"2016-10-07T15:02:21Z","git_url":"git://github.com/danwinship/origin.git","ssh_url":"git@github.com:danwinship/origin.git","clone_url":"https://github.com/danwinship/origin.git","svn_url":"https://github.com/danwinship/origin","homepage":"http://www.openshift.org","size":342597,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"local-novxlan"}},"base":{"label":"openshift:master","ref":"master","sha":"f243060d044661cb4c416a30e8bded8bfd92d99a","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-10-07T14:12:50Z","pushed_at":"2016-10-07T15:08:19Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":594095,"stargazers_count":1811,"watchers_count":1811,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1195,"mirror_url":null,"open_issues_count":1224,"forks":1195,"open_issues":1224,"watchers":1811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11247"},"html":{"href":"https://github.com/openshift/origin/pull/11247"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11247"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11247/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11247/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11247/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3cbc85c9cd64423e4b88e9fa075d21640ab2227d"}}}}
{"actor":{"display_login":"stevekuznetsov"}}