{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/comments/68107036","id":68107036,"diff_hunk":"@@ -0,0 +1,33 @@\n+# Copyright 2016 Microsoft Corporation\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+# Requires Python 2.4+ and Openssl 1.0+\n+#\n+\n+import azurelinuxagent.common.logger as logger\n+\n+from azurelinuxagent.common.version import DISTRO_NAME\n+from azurelinuxagent.common.rdma import RDMAHandler\n+from .suse import SUSERDMAHandler\n+\n+\n+def get_rdma_handler(distro_name=DISTRO_NAME, distro_version=DISTRO_VERSION):","path":"azurelinuxagent/pa/rdma/factory.py","position":25,"original_position":25,"commit_id":"575e09a2d3945a850af3a4e549c695fb6f042499","original_commit_id":"575e09a2d3945a850af3a4e549c695fb6f042499","user":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"body":"I did move the base class rdma.py into common In pa is the SUSE specialization just like there are OS specializations in provisioning and deprovisioning. Did I miss something or am I misunderstanding the comment?","created_at":"2016-06-22T18:21:01Z","updated_at":"2016-06-22T18:21:01Z","html_url":"https://github.com/Azure/WALinuxAgent/pull/255#discussion_r68107036","pull_request_url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/comments/68107036"},"html":{"href":"https://github.com/Azure/WALinuxAgent/pull/255#discussion_r68107036"},"pull_request":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255","id":74800586,"html_url":"https://github.com/Azure/WALinuxAgent/pull/255","diff_url":"https://github.com/Azure/WALinuxAgent/pull/255.diff","patch_url":"https://github.com/Azure/WALinuxAgent/pull/255.patch","issue_url":"https://api.github.com/repos/Azure/WALinuxAgent/issues/255","number":255,"state":"open","locked":false,"title":"Integrate RDMA handling","user":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"body":"Initial proposal to integrate the RDMA handler into the primary code flow.\r\n\r\n- Given directory names such as ga and pa I was not certain where to place the handler\r\n- Tried to follow the established factory pattern implementation\r\n- Not yet tested, will test when we agree on the structure","created_at":"2016-06-22T15:04:27Z","updated_at":"2016-06-22T18:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c2077bcaeecb30dadba3bf8b98732cbb7a752bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255/commits","review_comments_url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255/comments","review_comment_url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/WALinuxAgent/issues/255/comments","statuses_url":"https://api.github.com/repos/Azure/WALinuxAgent/statuses/575e09a2d3945a850af3a4e549c695fb6f042499","head":{"label":"rjschwei:rdmaIntegrate","ref":"rdmaIntegrate","sha":"575e09a2d3945a850af3a4e549c695fb6f042499","user":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"repo":{"id":12040300,"name":"WALinuxAgent","full_name":"rjschwei/WALinuxAgent","owner":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjschwei/WALinuxAgent","description":"The Windows Azure Linux Agent ","fork":true,"url":"https://api.github.com/repos/rjschwei/WALinuxAgent","forks_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/forks","keys_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/teams","hooks_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/hooks","issue_events_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/issues/events{/number}","events_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/events","assignees_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/assignees{/user}","branches_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/branches{/branch}","tags_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/tags","blobs_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/languages","stargazers_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/stargazers","contributors_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/contributors","subscribers_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/subscribers","subscription_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/subscription","commits_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/contents/{+path}","compare_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/merges","archive_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/downloads","issues_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/issues{/number}","pulls_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/labels{/name}","releases_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/releases{/id}","deployments_url":"https://api.github.com/repos/rjschwei/WALinuxAgent/deployments","created_at":"2013-08-11T18:22:03Z","updated_at":"2014-07-16T12:13:08Z","pushed_at":"2016-06-22T15:01:22Z","git_url":"git://github.com/rjschwei/WALinuxAgent.git","ssh_url":"git@github.com:rjschwei/WALinuxAgent.git","clone_url":"https://github.com/rjschwei/WALinuxAgent.git","svn_url":"https://github.com/rjschwei/WALinuxAgent","homepage":null,"size":2858,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:develop","ref":"develop","sha":"97cdc3e6285e2fe77f0826aaf1cadd7db34b80b5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":4576639,"name":"WALinuxAgent","full_name":"Azure/WALinuxAgent","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/WALinuxAgent","description":"Microsoft Azure Linux Guest Agent ","fork":false,"url":"https://api.github.com/repos/Azure/WALinuxAgent","forks_url":"https://api.github.com/repos/Azure/WALinuxAgent/forks","keys_url":"https://api.github.com/repos/Azure/WALinuxAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/WALinuxAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/WALinuxAgent/teams","hooks_url":"https://api.github.com/repos/Azure/WALinuxAgent/hooks","issue_events_url":"https://api.github.com/repos/Azure/WALinuxAgent/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/WALinuxAgent/events","assignees_url":"https://api.github.com/repos/Azure/WALinuxAgent/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/WALinuxAgent/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/WALinuxAgent/tags","blobs_url":"https://api.github.com/repos/Azure/WALinuxAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/WALinuxAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/WALinuxAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/WALinuxAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/WALinuxAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/WALinuxAgent/languages","stargazers_url":"https://api.github.com/repos/Azure/WALinuxAgent/stargazers","contributors_url":"https://api.github.com/repos/Azure/WALinuxAgent/contributors","subscribers_url":"https://api.github.com/repos/Azure/WALinuxAgent/subscribers","subscription_url":"https://api.github.com/repos/Azure/WALinuxAgent/subscription","commits_url":"https://api.github.com/repos/Azure/WALinuxAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/WALinuxAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/WALinuxAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/WALinuxAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/WALinuxAgent/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/WALinuxAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/WALinuxAgent/merges","archive_url":"https://api.github.com/repos/Azure/WALinuxAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/WALinuxAgent/downloads","issues_url":"https://api.github.com/repos/Azure/WALinuxAgent/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/WALinuxAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/WALinuxAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/WALinuxAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/WALinuxAgent/labels{/name}","releases_url":"https://api.github.com/repos/Azure/WALinuxAgent/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/WALinuxAgent/deployments","created_at":"2012-06-06T18:55:55Z","updated_at":"2016-06-18T01:06:19Z","pushed_at":"2016-06-22T18:09:54Z","git_url":"git://github.com/Azure/WALinuxAgent.git","ssh_url":"git@github.com:Azure/WALinuxAgent.git","clone_url":"https://github.com/Azure/WALinuxAgent.git","svn_url":"https://github.com/Azure/WALinuxAgent","homepage":"http://azure.microsoft.com/","size":3485,"stargazers_count":134,"watchers_count":134,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":32,"forks":118,"open_issues":32,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255"},"html":{"href":"https://github.com/Azure/WALinuxAgent/pull/255"},"issue":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/issues/255"},"comments":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/WALinuxAgent/statuses/575e09a2d3945a850af3a4e549c695fb6f042499"}}}}
{"actor":{"display_login":"rjschwei"}}