{"action":"created","issue":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1654","repository_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1654/labels{/name}","comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1654/comments","events_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1654/events","html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1654","id":158992038,"number":1654,"title":"Implement Objective-C nullability","user":{"login":"Lucashuang0802","id":3754490,"avatar_url":"https://avatars.githubusercontent.com/u/3754490?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucashuang0802","html_url":"https://github.com/Lucashuang0802","followers_url":"https://api.github.com/users/Lucashuang0802/followers","following_url":"https://api.github.com/users/Lucashuang0802/following{/other_user}","gists_url":"https://api.github.com/users/Lucashuang0802/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucashuang0802/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucashuang0802/subscriptions","organizations_url":"https://api.github.com/users/Lucashuang0802/orgs","repos_url":"https://api.github.com/users/Lucashuang0802/repos","events_url":"https://api.github.com/users/Lucashuang0802/events{/privacy}","received_events_url":"https://api.github.com/users/Lucashuang0802/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/labels/enhancement","name":"enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/labels/swift%20support","name":"swift support","color":"FA6E40"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/7","html_url":"https://github.com/jessesquires/JSQMessagesViewController/milestones/8.0.0","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/7/labels","id":917263,"number":7,"title":"8.0.0","description":"* Dropping iOS 7 support. Library will be iOS 8+ only.\r\n* Breaking API changes from version 7.x.x\r\n\r\nWork happening on the [`develop`](https://github.com/jessesquires/JSQMessagesViewController/tree/develop) branch.\r\n","creator":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":40,"state":"open","created_at":"2014-12-30T01:47:08Z","updated_at":"2016-06-11T03:29:29Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-06-07T18:28:02Z","updated_at":"2016-06-12T03:20:16Z","closed_at":"2016-06-10T02:22:36Z","pull_request":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1654","html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1654","diff_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1654.diff","patch_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1654.patch"},"body":"## Pull request checklist\r\n\r\n- [x] All tests pass. Demo project builds and runs.\r\n- [x] I have resolved any merge conflicts.\r\n- [x] I have followed the [coding style](https://github.com/jessesquires/HowToContribute#style-guidelines), and reviewed the [contributing guidelines](https://github.com/jessesquires/JSQMessagesViewController/blob/develop/.github/CONTRIBUTING.md). Confirmation: ____\r\n\r\n#### This fixes issue #776.\r\n\r\n## What's in this pull request?\r\n\r\nThis PR adds the nullability modifiers in Objective-C properties, headers, and method declaration so `Optional Type` is available in Swift version. \r\n\r\nOne thing to notice is all the warnings from the test target. Because we enable this type checking ability, some edge-case testings like checking `nil` warn that it's not supposed to be `nil`. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/comments/225407608","html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1654#issuecomment-225407608","issue_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1654","id":225407608,"user":{"login":"MacMeDan","id":6182351,"avatar_url":"https://avatars.githubusercontent.com/u/6182351?v=3","gravatar_id":"","url":"https://api.github.com/users/MacMeDan","html_url":"https://github.com/MacMeDan","followers_url":"https://api.github.com/users/MacMeDan/followers","following_url":"https://api.github.com/users/MacMeDan/following{/other_user}","gists_url":"https://api.github.com/users/MacMeDan/gists{/gist_id}","starred_url":"https://api.github.com/users/MacMeDan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MacMeDan/subscriptions","organizations_url":"https://api.github.com/users/MacMeDan/orgs","repos_url":"https://api.github.com/users/MacMeDan/repos","events_url":"https://api.github.com/users/MacMeDan/events{/privacy}","received_events_url":"https://api.github.com/users/MacMeDan/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T03:20:16Z","updated_at":"2016-06-12T03:20:16Z","body":"We are just working to get it close to parity with the objective c demo. There are a few pull request waiting to be merged but anything else that you see not there from the objective C version could be added. Currently different types of media are being added to the example. What we have so far : is a group conversation and regular chat pull requested. I believe location media messages was just merged. There is tailless and tailed images added to settings and showing and hiding avatars currently waiting. \n\nWhat still need:\nphoto messages, video and the initial screen could use some help. It needs to be similar to the other example demonstrating different ways of instantiating."}}
{"actor":{"display_login":"MacMeDan"}}