{"action":"created","issue":{"url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/260","repository_url":"https://api.github.com/repos/mongodb/mongo-csharp-driver","labels_url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/260/comments","events_url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/260/events","html_url":"https://github.com/mongodb/mongo-csharp-driver/pull/260","id":192033002,"number":260,"title":"Preserve element name if its characters are all in capital letters in camel-case convention","user":{"login":"mfidemraizer","id":820748,"avatar_url":"https://avatars.githubusercontent.com/u/820748?v=3","gravatar_id":"","url":"https://api.github.com/users/mfidemraizer","html_url":"https://github.com/mfidemraizer","followers_url":"https://api.github.com/users/mfidemraizer/followers","following_url":"https://api.github.com/users/mfidemraizer/following{/other_user}","gists_url":"https://api.github.com/users/mfidemraizer/gists{/gist_id}","starred_url":"https://api.github.com/users/mfidemraizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfidemraizer/subscriptions","organizations_url":"https://api.github.com/users/mfidemraizer/orgs","repos_url":"https://api.github.com/users/mfidemraizer/repos","events_url":"https://api.github.com/users/mfidemraizer/events{/privacy}","received_events_url":"https://api.github.com/users/mfidemraizer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-28T15:21:21Z","updated_at":"2016-11-28T20:38:11Z","closed_at":"2016-11-28T20:34:41Z","pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/pulls/260","html_url":"https://github.com/mongodb/mongo-csharp-driver/pull/260","diff_url":"https://github.com/mongodb/mongo-csharp-driver/pull/260.diff","patch_url":"https://github.com/mongodb/mongo-csharp-driver/pull/260.patch"},"body":"Hi!\r\n\r\nIt's a very simple improvement.\r\n\r\nLet's say we need to serialize a class like this:\r\n\r\n```\r\npublic class Customer\r\n{\r\n       public string Id { get; set; }\r\n       public string TIN { get; set; }\r\n}\r\n```\r\n\r\nCurrent `CamelCaseElementNameConvention` will serialize `Customer.TIN` as `tIN` while it should be just `TIN`.\r\n\r\nIn summary, I would say that if a property is in capital letters **it should mean that it's an *acronym*** (or leaving a property in capital letters is the intended behavior).\r\n\r\n## Solution\r\n\r\nMy proposed solution is a new `else if` in the whole convention code:\r\n\r\n```\r\nelse if (memberName == memberName.ToUpper())\r\n{\r\n        return memberName;\r\n}\r\n```\r\n\r\n---\r\n\r\nThank you in advance and I'll look forward for your comments!"},"comment":{"url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/comments/263387066","html_url":"https://github.com/mongodb/mongo-csharp-driver/pull/260#issuecomment-263387066","issue_url":"https://api.github.com/repos/mongodb/mongo-csharp-driver/issues/260","id":263387066,"user":{"login":"craiggwilson","id":167901,"avatar_url":"https://avatars.githubusercontent.com/u/167901?v=3","gravatar_id":"","url":"https://api.github.com/users/craiggwilson","html_url":"https://github.com/craiggwilson","followers_url":"https://api.github.com/users/craiggwilson/followers","following_url":"https://api.github.com/users/craiggwilson/following{/other_user}","gists_url":"https://api.github.com/users/craiggwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/craiggwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craiggwilson/subscriptions","organizations_url":"https://api.github.com/users/craiggwilson/orgs","repos_url":"https://api.github.com/users/craiggwilson/repos","events_url":"https://api.github.com/users/craiggwilson/events{/privacy}","received_events_url":"https://api.github.com/users/craiggwilson/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T20:38:11Z","updated_at":"2016-11-28T20:38:11Z","body":"I wouldn't close this. It seems like a good solution. Arguably, and acronym in all caps should be all lower-case, hence \"tin\" instead of \"TIN\".\r\n\r\nRobert can comment further about anything that needs to be done for the PR though."}}
{"actor":{"display_login":"craiggwilson"}}