{"action":"created","comment":{"url":"https://api.github.com/repos/phenotips/phenotips/pulls/comments/86905975","pull_request_review_id":7540586,"id":86905975,"diff_hunk":"@@ -427,6 +439,14 @@ var ExtraGeneVariantData = (function (ExtraGeneVariantData) {\n       });\n     },\n \n+    restrictNumericInput : function () {\n+      this._geneTable.select('input:[id$=_start_position]', 'input:[id$=_end_position]').each( function(input) {\n+        input.observe('keyup', function(event){\n+          this.value=this.value.replace(/[^\\d]/,'');","path":"components/widgets/resources/src/main/resources/resources/uicomponents/widgets/extraGeneVariantData.js","position":124,"original_position":124,"commit_id":"db88ef8fdd97be1e2b0f77b8eb3e26ebd9a4b2e2","original_commit_id":"db88ef8fdd97be1e2b0f77b8eb3e26ebd9a4b2e2","user":{"login":"marta-","id":651980,"avatar_url":"https://avatars.githubusercontent.com/u/651980?v=3","gravatar_id":"","url":"https://api.github.com/users/marta-","html_url":"https://github.com/marta-","followers_url":"https://api.github.com/users/marta-/followers","following_url":"https://api.github.com/users/marta-/following{/other_user}","gists_url":"https://api.github.com/users/marta-/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-/subscriptions","organizations_url":"https://api.github.com/users/marta-/orgs","repos_url":"https://api.github.com/users/marta-/repos","events_url":"https://api.github.com/users/marta-/events{/privacy}","received_events_url":"https://api.github.com/users/marta-/received_events","type":"User","site_admin":false},"body":"Duplicated code + bug: this copy of the code which restricts inputs to numerical values doesn't have the global flag and will have the issues I reported in the previous review.\r\n\r\nMust change: `this.value = this.value.replace(/[^\\d]/g,'');`.\r\n\r\nSuggestion for further improvement:\r\n\r\n```\r\nrestrictNumericInput : function (element) {\r\n  (element || this._geneTable).select('input:[id$=_start_position]', 'input:[id$=_end_position]').invoke('observe', 'keyup', function(event) {\r\n    this.value = this.value.replace(/[^\\d]/g,'');\r\n  });\r\n}\r\n```\r\n\r\nCall `this.restrictNumericInput()` (no parameter, defaults to `this._geneTable`) in the initialization, and `this.restrictNumericInput(newMoreInfoRow)` when adding a new variant.","created_at":"2016-11-08T01:13:41Z","updated_at":"2016-11-08T01:20:46Z","html_url":"https://github.com/phenotips/phenotips/pull/2136#discussion_r86905975","pull_request_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2136","_links":{"self":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/comments/86905975"},"html":{"href":"https://github.com/phenotips/phenotips/pull/2136#discussion_r86905975"},"pull_request":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2136"}}},"pull_request":{"url":"https://api.github.com/repos/phenotips/phenotips/pulls/2136","id":92234315,"html_url":"https://github.com/phenotips/phenotips/pull/2136","diff_url":"https://github.com/phenotips/phenotips/pull/2136.diff","patch_url":"https://github.com/phenotips/phenotips/pull/2136.patch","issue_url":"https://api.github.com/repos/phenotips/phenotips/issues/2136","number":2136,"state":"open","locked":false,"title":"PT-2883: Add chromosome, start position, end position and reference genome as fields for variants.","user":{"login":"veronikaslc","id":4371097,"avatar_url":"https://avatars.githubusercontent.com/u/4371097?v=3","gravatar_id":"","url":"https://api.github.com/users/veronikaslc","html_url":"https://github.com/veronikaslc","followers_url":"https://api.github.com/users/veronikaslc/followers","following_url":"https://api.github.com/users/veronikaslc/following{/other_user}","gists_url":"https://api.github.com/users/veronikaslc/gists{/gist_id}","starred_url":"https://api.github.com/users/veronikaslc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronikaslc/subscriptions","organizations_url":"https://api.github.com/users/veronikaslc/orgs","repos_url":"https://api.github.com/users/veronikaslc/repos","events_url":"https://api.github.com/users/veronikaslc/events{/privacy}","received_events_url":"https://api.github.com/users/veronikaslc/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2016-11-03T20:31:51Z","updated_at":"2016-11-08T01:20:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3335db2f4c2b8b8e5c8420ed55161c52dd48f15d","assignee":{"login":"a-gvo","id":7433568,"avatar_url":"https://avatars.githubusercontent.com/u/7433568?v=3","gravatar_id":"","url":"https://api.github.com/users/a-gvo","html_url":"https://github.com/a-gvo","followers_url":"https://api.github.com/users/a-gvo/followers","following_url":"https://api.github.com/users/a-gvo/following{/other_user}","gists_url":"https://api.github.com/users/a-gvo/gists{/gist_id}","starred_url":"https://api.github.com/users/a-gvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-gvo/subscriptions","organizations_url":"https://api.github.com/users/a-gvo/orgs","repos_url":"https://api.github.com/users/a-gvo/repos","events_url":"https://api.github.com/users/a-gvo/events{/privacy}","received_events_url":"https://api.github.com/users/a-gvo/received_events","type":"User","site_admin":false},"assignees":[{"login":"a-gvo","id":7433568,"avatar_url":"https://avatars.githubusercontent.com/u/7433568?v=3","gravatar_id":"","url":"https://api.github.com/users/a-gvo","html_url":"https://github.com/a-gvo","followers_url":"https://api.github.com/users/a-gvo/followers","following_url":"https://api.github.com/users/a-gvo/following{/other_user}","gists_url":"https://api.github.com/users/a-gvo/gists{/gist_id}","starred_url":"https://api.github.com/users/a-gvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-gvo/subscriptions","organizations_url":"https://api.github.com/users/a-gvo/orgs","repos_url":"https://api.github.com/users/a-gvo/repos","events_url":"https://api.github.com/users/a-gvo/events{/privacy}","received_events_url":"https://api.github.com/users/a-gvo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2136/commits","review_comments_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2136/comments","review_comment_url":"https://api.github.com/repos/phenotips/phenotips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phenotips/phenotips/issues/2136/comments","statuses_url":"https://api.github.com/repos/phenotips/phenotips/statuses/db88ef8fdd97be1e2b0f77b8eb3e26ebd9a4b2e2","head":{"label":"phenotips:PT-2883","ref":"PT-2883","sha":"db88ef8fdd97be1e2b0f77b8eb3e26ebd9a4b2e2","user":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"repo":{"id":2685841,"name":"phenotips","full_name":"phenotips/phenotips","owner":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phenotips/phenotips","description":"PhenoTips provides an easy-to-use Web interface and standardized database back-end for collecting clinical findings observed in patients with possible genetic disorders.","fork":false,"url":"https://api.github.com/repos/phenotips/phenotips","forks_url":"https://api.github.com/repos/phenotips/phenotips/forks","keys_url":"https://api.github.com/repos/phenotips/phenotips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenotips/phenotips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenotips/phenotips/teams","hooks_url":"https://api.github.com/repos/phenotips/phenotips/hooks","issue_events_url":"https://api.github.com/repos/phenotips/phenotips/issues/events{/number}","events_url":"https://api.github.com/repos/phenotips/phenotips/events","assignees_url":"https://api.github.com/repos/phenotips/phenotips/assignees{/user}","branches_url":"https://api.github.com/repos/phenotips/phenotips/branches{/branch}","tags_url":"https://api.github.com/repos/phenotips/phenotips/tags","blobs_url":"https://api.github.com/repos/phenotips/phenotips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenotips/phenotips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenotips/phenotips/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenotips/phenotips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenotips/phenotips/statuses/{sha}","languages_url":"https://api.github.com/repos/phenotips/phenotips/languages","stargazers_url":"https://api.github.com/repos/phenotips/phenotips/stargazers","contributors_url":"https://api.github.com/repos/phenotips/phenotips/contributors","subscribers_url":"https://api.github.com/repos/phenotips/phenotips/subscribers","subscription_url":"https://api.github.com/repos/phenotips/phenotips/subscription","commits_url":"https://api.github.com/repos/phenotips/phenotips/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenotips/phenotips/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenotips/phenotips/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenotips/phenotips/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenotips/phenotips/contents/{+path}","compare_url":"https://api.github.com/repos/phenotips/phenotips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenotips/phenotips/merges","archive_url":"https://api.github.com/repos/phenotips/phenotips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenotips/phenotips/downloads","issues_url":"https://api.github.com/repos/phenotips/phenotips/issues{/number}","pulls_url":"https://api.github.com/repos/phenotips/phenotips/pulls{/number}","milestones_url":"https://api.github.com/repos/phenotips/phenotips/milestones{/number}","notifications_url":"https://api.github.com/repos/phenotips/phenotips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenotips/phenotips/labels{/name}","releases_url":"https://api.github.com/repos/phenotips/phenotips/releases{/id}","deployments_url":"https://api.github.com/repos/phenotips/phenotips/deployments","created_at":"2011-11-01T05:55:21Z","updated_at":"2016-10-23T00:55:44Z","pushed_at":"2016-11-07T23:40:14Z","git_url":"git://github.com/phenotips/phenotips.git","ssh_url":"git@github.com:phenotips/phenotips.git","clone_url":"https://github.com/phenotips/phenotips.git","svn_url":"https://github.com/phenotips/phenotips","homepage":"http://phenotips.org/","size":989330,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":303,"forks":39,"open_issues":303,"watchers":42,"default_branch":"master"}},"base":{"label":"phenotips:master","ref":"master","sha":"99c8171bee1bafad6be8217786163ceb01fd00a5","user":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"repo":{"id":2685841,"name":"phenotips","full_name":"phenotips/phenotips","owner":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phenotips/phenotips","description":"PhenoTips provides an easy-to-use Web interface and standardized database back-end for collecting clinical findings observed in patients with possible genetic disorders.","fork":false,"url":"https://api.github.com/repos/phenotips/phenotips","forks_url":"https://api.github.com/repos/phenotips/phenotips/forks","keys_url":"https://api.github.com/repos/phenotips/phenotips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenotips/phenotips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenotips/phenotips/teams","hooks_url":"https://api.github.com/repos/phenotips/phenotips/hooks","issue_events_url":"https://api.github.com/repos/phenotips/phenotips/issues/events{/number}","events_url":"https://api.github.com/repos/phenotips/phenotips/events","assignees_url":"https://api.github.com/repos/phenotips/phenotips/assignees{/user}","branches_url":"https://api.github.com/repos/phenotips/phenotips/branches{/branch}","tags_url":"https://api.github.com/repos/phenotips/phenotips/tags","blobs_url":"https://api.github.com/repos/phenotips/phenotips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenotips/phenotips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenotips/phenotips/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenotips/phenotips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenotips/phenotips/statuses/{sha}","languages_url":"https://api.github.com/repos/phenotips/phenotips/languages","stargazers_url":"https://api.github.com/repos/phenotips/phenotips/stargazers","contributors_url":"https://api.github.com/repos/phenotips/phenotips/contributors","subscribers_url":"https://api.github.com/repos/phenotips/phenotips/subscribers","subscription_url":"https://api.github.com/repos/phenotips/phenotips/subscription","commits_url":"https://api.github.com/repos/phenotips/phenotips/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenotips/phenotips/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenotips/phenotips/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenotips/phenotips/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenotips/phenotips/contents/{+path}","compare_url":"https://api.github.com/repos/phenotips/phenotips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenotips/phenotips/merges","archive_url":"https://api.github.com/repos/phenotips/phenotips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenotips/phenotips/downloads","issues_url":"https://api.github.com/repos/phenotips/phenotips/issues{/number}","pulls_url":"https://api.github.com/repos/phenotips/phenotips/pulls{/number}","milestones_url":"https://api.github.com/repos/phenotips/phenotips/milestones{/number}","notifications_url":"https://api.github.com/repos/phenotips/phenotips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenotips/phenotips/labels{/name}","releases_url":"https://api.github.com/repos/phenotips/phenotips/releases{/id}","deployments_url":"https://api.github.com/repos/phenotips/phenotips/deployments","created_at":"2011-11-01T05:55:21Z","updated_at":"2016-10-23T00:55:44Z","pushed_at":"2016-11-07T23:40:14Z","git_url":"git://github.com/phenotips/phenotips.git","ssh_url":"git@github.com:phenotips/phenotips.git","clone_url":"https://github.com/phenotips/phenotips.git","svn_url":"https://github.com/phenotips/phenotips","homepage":"http://phenotips.org/","size":989330,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":303,"forks":39,"open_issues":303,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2136"},"html":{"href":"https://github.com/phenotips/phenotips/pull/2136"},"issue":{"href":"https://api.github.com/repos/phenotips/phenotips/issues/2136"},"comments":{"href":"https://api.github.com/repos/phenotips/phenotips/issues/2136/comments"},"review_comments":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2136/comments"},"review_comment":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2136/commits"},"statuses":{"href":"https://api.github.com/repos/phenotips/phenotips/statuses/db88ef8fdd97be1e2b0f77b8eb3e26ebd9a4b2e2"}}}}
{"actor":{"display_login":"marta-"}}