{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/52211727","id":52211727,"diff_hunk":"@@ -181,7 +181,7 @@ def deprecate(obj, message=message, name=name, alternative=alternative,\n             name = get_function(obj).__name__\n \n         altmessage = ''\n-        if not message or type(message) == type(deprecate):\n+        if not message or isinstance(message, type(deprecate)):","path":"astropy/utils/decorators.py","position":14,"original_position":14,"commit_id":"ba9858f47b98b2e8ffbaf4f6a2587391aa1f16a0","original_commit_id":"ba9858f47b98b2e8ffbaf4f6a2587391aa1f16a0","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand decorators well enough, but my sense would be to leave this as a `==` -> `is` case; just don't see where subclasses could possibly come in.","created_at":"2016-02-08T19:20:57Z","updated_at":"2016-02-08T19:20:57Z","html_url":"https://github.com/astropy/astropy/pull/4581#discussion_r52211727","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/4581","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/52211727"},"html":{"href":"https://github.com/astropy/astropy/pull/4581#discussion_r52211727"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4581"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4581","id":58556152,"html_url":"https://github.com/astropy/astropy/pull/4581","diff_url":"https://github.com/astropy/astropy/pull/4581.diff","patch_url":"https://github.com/astropy/astropy/pull/4581.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4581","number":4581,"state":"open","locked":false,"title":"Include statement and runtime errors in PEP8 checks","user":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"body":"Specifically these:\r\n\r\n```\r\nE711 - comparison to None should be 'if cond is None:'\r\nE712 - comparison to True should be 'if cond is True:' or 'if cond:'\r\nE713 - test for membership should be 'not in'\r\nE714 - test for object identity should be 'is not'\r\nE721 - do not compare types, use 'isinstance()'\r\nE901 - SyntaxError or IndentationError\r\nE902 - IOError\r\n```","created_at":"2016-02-07T20:27:04Z","updated_at":"2016-02-08T19:20:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e216c74f8acf405e8de4cb01de968c9ecc96b61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4581/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4581/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4581/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/ba9858f47b98b2e8ffbaf4f6a2587391aa1f16a0","head":{"label":"bsipocz:pep8","ref":"pep8","sha":"ba9858f47b98b2e8ffbaf4f6a2587391aa1f16a0","user":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"repo":{"id":17316971,"name":"astropy","full_name":"bsipocz/astropy","owner":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsipocz/astropy","description":"Main Astropy repository","fork":true,"url":"https://api.github.com/repos/bsipocz/astropy","forks_url":"https://api.github.com/repos/bsipocz/astropy/forks","keys_url":"https://api.github.com/repos/bsipocz/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsipocz/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsipocz/astropy/teams","hooks_url":"https://api.github.com/repos/bsipocz/astropy/hooks","issue_events_url":"https://api.github.com/repos/bsipocz/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/bsipocz/astropy/events","assignees_url":"https://api.github.com/repos/bsipocz/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/bsipocz/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/bsipocz/astropy/tags","blobs_url":"https://api.github.com/repos/bsipocz/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsipocz/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsipocz/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsipocz/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsipocz/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/bsipocz/astropy/languages","stargazers_url":"https://api.github.com/repos/bsipocz/astropy/stargazers","contributors_url":"https://api.github.com/repos/bsipocz/astropy/contributors","subscribers_url":"https://api.github.com/repos/bsipocz/astropy/subscribers","subscription_url":"https://api.github.com/repos/bsipocz/astropy/subscription","commits_url":"https://api.github.com/repos/bsipocz/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsipocz/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsipocz/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsipocz/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsipocz/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/bsipocz/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsipocz/astropy/merges","archive_url":"https://api.github.com/repos/bsipocz/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsipocz/astropy/downloads","issues_url":"https://api.github.com/repos/bsipocz/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/bsipocz/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/bsipocz/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/bsipocz/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsipocz/astropy/labels{/name}","releases_url":"https://api.github.com/repos/bsipocz/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/bsipocz/astropy/deployments","created_at":"2014-03-01T14:55:18Z","updated_at":"2014-06-02T12:50:34Z","pushed_at":"2016-02-08T00:07:12Z","git_url":"git://github.com/bsipocz/astropy.git","ssh_url":"git@github.com:bsipocz/astropy.git","clone_url":"https://github.com/bsipocz/astropy.git","svn_url":"https://github.com/bsipocz/astropy","homepage":"astropy.org","size":40293,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"zizike"}},"base":{"label":"astropy:master","ref":"master","sha":"6e14021a9d0ae246612b30b32280c291b1727282","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-02-08T16:47:36Z","pushed_at":"2016-02-08T17:40:32Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":59770,"stargazers_count":780,"watchers_count":780,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":497,"mirror_url":null,"open_issues_count":687,"forks":497,"open_issues":687,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4581"},"html":{"href":"https://github.com/astropy/astropy/pull/4581"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4581"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4581/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4581/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4581/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/ba9858f47b98b2e8ffbaf4f6a2587391aa1f16a0"}}}}