{"action":"created","comment":{"url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/comments/79678833","id":79678833,"diff_hunk":"@@ -34,88 +34,90 @@ const babel = require('gulp-babel');\n const buffer = require('vinyl-buffer');\n \n function onError(err) {\n-    console.warn(err);\n+\tconsole.warn(err);\n }\n \n function reloadChromeExtensionsTab(cb) {\n-    console.log(\"Reloading Chrome extensions tab\");\n-\n-\n-    exec('chrome-cli list tabs', function(err, stdout) {\n-        if (err) cb(err);\n-\n-        var extensionsTabMatches = stdout.match(/\\[\\d{1,5}:(\\d{1,5})\\] Extensions/);\n-        if (extensionsTabMatches) {\n-            var extensionsTabID = extensionsTabMatches[1];\n-\n-            exec('chrome-cli reload -t ' + extensionsTabID, function (err, stdout, stderr) {\n-                if (err) return cb(err);\n-                cb();\n-            });\n-        }\n-        else {\n-            exec('chrome-cli open chrome://extensions && chrome-cli reload', function (err, stdout, stderr) {\n-                if (err) return cb(err);\n-                cb();\n-            });\n-        }\n-    });\n+\tconsole.log(\"Reloading Chrome extensions tab\");\n+\n+\n+\texec('chrome-cli list tabs', function (err, stdout) {\n+\t\tif (err) cb(err);\n+\n+\t\tvar extensionsTabMatches = stdout.match(/\\[\\d{1,5}:(\\d{1,5})\\] Extensions/);\n+\t\tif (extensionsTabMatches) {\n+\t\t\tvar extensionsTabID = extensionsTabMatches[1];\n+\n+\t\t\texec('chrome-cli reload -t ' + extensionsTabID, function (err, stdout, stderr) {\n+\t\t\t\tif (err) return cb(err);\n+\t\t\t\tcb();\n+\t\t\t});\n+\t\t}\n+\t\telse {\n+\t\t\texec('chrome-cli open chrome://extensions && chrome-cli reload', function (err, stdout, stderr) {\n+\t\t\t\tif (err) return cb(err);\n+\t\t\t\tcb();\n+\t\t\t});\n+\t\t}\n+\t});\n }\n \n function babelify() {\n-    return gulp.src('./build/safari.safariextension/zotero/**/*.js')\n-        .pipe(buffer())\n-        .pipe(plumber({errorHandler: onError}))\n-        .pipe(babel({\n-            presets: ['es2015']\n-        }))\n-        .pipe(gulp.dest((data) => data.base));\n+\treturn gulp.src([\n+\t\t'./build/safari.safariextension/**/*.js',\n+\t])\n+\t\t.pipe(buffer())\n+\t\t.pipe(plumber({errorHandler: onError}))\n+\t\t.pipe(babel({\n+\t\t\tpresets: ['es2015']\n+\t\t}))\n+\t\t.pipe(gulp.dest((data) => data.base));\n }\n \n function minify() {\n-\treturn gulp.src('./build/**/*.js')\n+\treturn gulp.src('./build/bookmarklet/**/*.js')\n \t\t.pipe(buffer())\n \t\t.pipe(babel({\n-            presets: ['babili'],\n-            comments: false\n-        }))\n+\t\t\tpresets: ['babili'],\n+\t\t\tcomments: false\n+\t\t}))\n \t\t.pipe(gulp.dest((data) => data.base));\n }\n \n-gulp.task('watch', function() {\n-    gulp.watch(['./src/chrome/**', './src/common/**', './src/safari/**'], ['build-dev']);\n+gulp.task('watch', function () {\n+\tgulp.watch(['./src/chrome/**', './src/common/**', './src/safari/**'], ['build-dev']);\n });\n \n-gulp.task('watch-chrome', function() {\n-    gulp.watch(['./src/chrome/**', './src/common/**', './src/safari/**'], ['build-dev', 'reloadChromeExtensionsTab']);\n+gulp.task('watch-chrome', function () {\n+\tgulp.watch(['./src/chrome/**', './src/common/**', './src/safari/**'], ['build-dev', 'reloadChromeExtensionsTab']);\n });\n \n gulp.task('reloadChromeExtensionsTab', ['build-dev', 'safarify'], reloadChromeExtensionsTab);\n \n-gulp.task('build-sh-dev', function(cb) {\n-    var proc = spawn('./build.sh', ['-d'], {cwd: process.cwd()});\n-    proc.stdout.on('data', function(data) {\n-        process.stdout.write(data);\n-    });\n-    proc.stderr.on('data', function(data) {\n-        process.stderr.write(data);\n-    });\n-    proc.on('close', function(code) {\n-        cb(code)\n-    })\n+gulp.task('build-sh-dev', function (cb) {\n+\tvar proc = spawn('./build.sh', ['-d'], {cwd: process.cwd()});\n+\tproc.stdout.on('data', function (data) {\n+\t\tprocess.stdout.write(data);\n+\t});\n+\tproc.stderr.on('data', function (data) {\n+\t\tprocess.stderr.write(data);\n+\t});\n+\tproc.on('close', function (code) {\n+\t\tcb(code)\n+\t})\n });\n \n-gulp.task('build-sh', function(cb) {\n-    var proc = spawn('./build.sh', [], {cwd: process.cwd()});\n-    proc.stdout.on('data', function(data) {\n-        process.stdout.write(data);\n-    });\n-    proc.stderr.on('data', function(data) {\n-        process.stderr.write(data);\n-    });\n-    proc.on('close', function(code) {\n-        cb(code)\n-    })\n+gulp.task('build-sh', function (cb) {\n+\tvar proc = spawn('./build.sh', [], {cwd: process.cwd()});\n+\tproc.stdout.on('data', function (data) {\n+\t\tprocess.stdout.write(data);\n+\t});\n+\tproc.stderr.on('data', function (data) {\n+\t\tprocess.stderr.write(data);\n+\t});\n+\tproc.on('close', function (code) {\n+\t\tcb(code)\n+\t})","path":"gulpfile.js","position":107,"original_position":156,"commit_id":"25bfc29f31d946072decbc0a6605b8db2507e764","original_commit_id":"25bfc29f31d946072decbc0a6605b8db2507e764","user":{"login":"dstillman","id":783082,"avatar_url":"https://avatars.githubusercontent.com/u/783082?v=3","gravatar_id":"","url":"https://api.github.com/users/dstillman","html_url":"https://github.com/dstillman","followers_url":"https://api.github.com/users/dstillman/followers","following_url":"https://api.github.com/users/dstillman/following{/other_user}","gists_url":"https://api.github.com/users/dstillman/gists{/gist_id}","starred_url":"https://api.github.com/users/dstillman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstillman/subscriptions","organizations_url":"https://api.github.com/users/dstillman/orgs","repos_url":"https://api.github.com/users/dstillman/repos","events_url":"https://api.github.com/users/dstillman/events{/privacy}","received_events_url":"https://api.github.com/users/dstillman/received_events","type":"User","site_admin":false},"body":"Most/all of the above should just be squashed into https://github.com/zotero/zotero-connectors/pull/51/commits/b4f2aaa0db3fd5a49374bfe248e3565c0970a76c.","created_at":"2016-09-20T18:22:34Z","updated_at":"2016-09-20T18:22:34Z","html_url":"https://github.com/zotero/zotero-connectors/pull/51#discussion_r79678833","pull_request_url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/comments/79678833"},"html":{"href":"https://github.com/zotero/zotero-connectors/pull/51#discussion_r79678833"},"pull_request":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51","id":84188730,"html_url":"https://github.com/zotero/zotero-connectors/pull/51","diff_url":"https://github.com/zotero/zotero-connectors/pull/51.diff","patch_url":"https://github.com/zotero/zotero-connectors/pull/51.patch","issue_url":"https://api.github.com/repos/zotero/zotero-connectors/issues/51","number":51,"state":"open","locked":false,"title":"Update to support Zotero 5.0 translator code sharing","user":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-06T20:16:49Z","updated_at":"2016-09-20T18:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"688e0957f579b6fa9462849a63898b46b0ad3699","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51/commits","review_comments_url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51/comments","review_comment_url":"https://api.github.com/repos/zotero/zotero-connectors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zotero/zotero-connectors/issues/51/comments","statuses_url":"https://api.github.com/repos/zotero/zotero-connectors/statuses/25bfc29f31d946072decbc0a6605b8db2507e764","head":{"label":"adomasven:feature/zotero5-translator-code-support","ref":"feature/zotero5-translator-code-support","sha":"25bfc29f31d946072decbc0a6605b8db2507e764","user":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"repo":{"id":55598683,"name":"zotero-connectors","full_name":"adomasven/zotero-connectors","owner":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adomasven/zotero-connectors","description":"Chrome and Safari connectors for Zotero","fork":true,"url":"https://api.github.com/repos/adomasven/zotero-connectors","forks_url":"https://api.github.com/repos/adomasven/zotero-connectors/forks","keys_url":"https://api.github.com/repos/adomasven/zotero-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adomasven/zotero-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adomasven/zotero-connectors/teams","hooks_url":"https://api.github.com/repos/adomasven/zotero-connectors/hooks","issue_events_url":"https://api.github.com/repos/adomasven/zotero-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/adomasven/zotero-connectors/events","assignees_url":"https://api.github.com/repos/adomasven/zotero-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/adomasven/zotero-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/adomasven/zotero-connectors/tags","blobs_url":"https://api.github.com/repos/adomasven/zotero-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adomasven/zotero-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adomasven/zotero-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/adomasven/zotero-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adomasven/zotero-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/adomasven/zotero-connectors/languages","stargazers_url":"https://api.github.com/repos/adomasven/zotero-connectors/stargazers","contributors_url":"https://api.github.com/repos/adomasven/zotero-connectors/contributors","subscribers_url":"https://api.github.com/repos/adomasven/zotero-connectors/subscribers","subscription_url":"https://api.github.com/repos/adomasven/zotero-connectors/subscription","commits_url":"https://api.github.com/repos/adomasven/zotero-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/adomasven/zotero-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/adomasven/zotero-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/adomasven/zotero-connectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/adomasven/zotero-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/adomasven/zotero-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adomasven/zotero-connectors/merges","archive_url":"https://api.github.com/repos/adomasven/zotero-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adomasven/zotero-connectors/downloads","issues_url":"https://api.github.com/repos/adomasven/zotero-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/adomasven/zotero-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/adomasven/zotero-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/adomasven/zotero-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adomasven/zotero-connectors/labels{/name}","releases_url":"https://api.github.com/repos/adomasven/zotero-connectors/releases{/id}","deployments_url":"https://api.github.com/repos/adomasven/zotero-connectors/deployments","created_at":"2016-04-06T11:00:43Z","updated_at":"2016-04-06T11:00:44Z","pushed_at":"2016-09-20T12:41:32Z","git_url":"git://github.com/adomasven/zotero-connectors.git","ssh_url":"git@github.com:adomasven/zotero-connectors.git","clone_url":"https://github.com/adomasven/zotero-connectors.git","svn_url":"https://github.com/adomasven/zotero-connectors","homepage":"http://www.zotero.org/support/standalone","size":40951,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zotero:master","ref":"master","sha":"0cce106f57320cccb1ce8e3656442f881f6f938e","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":2230011,"name":"zotero-connectors","full_name":"zotero/zotero-connectors","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/zotero-connectors","description":"Chrome and Safari connectors for Zotero","fork":false,"url":"https://api.github.com/repos/zotero/zotero-connectors","forks_url":"https://api.github.com/repos/zotero/zotero-connectors/forks","keys_url":"https://api.github.com/repos/zotero/zotero-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/zotero-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/zotero-connectors/teams","hooks_url":"https://api.github.com/repos/zotero/zotero-connectors/hooks","issue_events_url":"https://api.github.com/repos/zotero/zotero-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/zotero-connectors/events","assignees_url":"https://api.github.com/repos/zotero/zotero-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/zotero-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/zotero-connectors/tags","blobs_url":"https://api.github.com/repos/zotero/zotero-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/zotero-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/zotero-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/zotero-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/zotero-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/zotero-connectors/languages","stargazers_url":"https://api.github.com/repos/zotero/zotero-connectors/stargazers","contributors_url":"https://api.github.com/repos/zotero/zotero-connectors/contributors","subscribers_url":"https://api.github.com/repos/zotero/zotero-connectors/subscribers","subscription_url":"https://api.github.com/repos/zotero/zotero-connectors/subscription","commits_url":"https://api.github.com/repos/zotero/zotero-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/zotero-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/zotero-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/zotero-connectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/zotero/zotero-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/zotero-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/zotero-connectors/merges","archive_url":"https://api.github.com/repos/zotero/zotero-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/zotero-connectors/downloads","issues_url":"https://api.github.com/repos/zotero/zotero-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/zotero-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/zotero-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/zotero-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/zotero-connectors/labels{/name}","releases_url":"https://api.github.com/repos/zotero/zotero-connectors/releases{/id}","deployments_url":"https://api.github.com/repos/zotero/zotero-connectors/deployments","created_at":"2011-08-18T19:48:21Z","updated_at":"2016-09-17T21:15:50Z","pushed_at":"2016-09-20T12:41:33Z","git_url":"git://github.com/zotero/zotero-connectors.git","ssh_url":"git@github.com:zotero/zotero-connectors.git","clone_url":"https://github.com/zotero/zotero-connectors.git","svn_url":"https://github.com/zotero/zotero-connectors","homepage":"http://www.zotero.org/support/standalone","size":41107,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":23,"forks":20,"open_issues":23,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51"},"html":{"href":"https://github.com/zotero/zotero-connectors/pull/51"},"issue":{"href":"https://api.github.com/repos/zotero/zotero-connectors/issues/51"},"comments":{"href":"https://api.github.com/repos/zotero/zotero-connectors/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zotero/zotero-connectors/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/zotero-connectors/statuses/25bfc29f31d946072decbc0a6605b8db2507e764"}}}}
{"actor":{"display_login":"dstillman"}}