{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/89631952","pull_request_review_id":10176986,"id":89631952,"diff_hunk":"@@ -74,8 +74,8 @@ private[spark] class PartitionedPairBuffer[K, V](initialCapacity: Int = 64)\n   /** Iterate through the data in a given order. For this class this is not really destructive. */\n   override def partitionedDestructiveSortedIterator(keyComparator: Option[Comparator[K]])\n     : Iterator[((Int, K), V)] = {\n-    val comparator = keyComparator.map(partitionKeyComparator).getOrElse(partitionComparator)\n-    new Sorter(new KVArraySortDataFormat[(Int, K), AnyRef]).sort(data, 0, curSize, comparator)\n+    new Sorter(new KVArraySortDataFormat[(Int, K),","path":"core/src/main/scala/org/apache/spark/util/collection/PartitionedPairBuffer.scala","position":6,"original_position":6,"commit_id":"d3423945c08a8863a63c16005d848af272c025c3","original_commit_id":"d3423945c08a8863a63c16005d848af272c025c3","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"I think breaking the line here is odd. If necesasry, pull out the result of `getComparator` to a statement above to shorten this line, like it was before.","created_at":"2016-11-25T15:25:39Z","updated_at":"2016-11-25T15:32:10Z","html_url":"https://github.com/apache/spark/pull/15736#discussion_r89631952","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15736","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/89631952"},"html":{"href":"https://github.com/apache/spark/pull/15736#discussion_r89631952"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15736"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15736","id":91953534,"html_url":"https://github.com/apache/spark/pull/15736","diff_url":"https://github.com/apache/spark/pull/15736.diff","patch_url":"https://github.com/apache/spark/pull/15736.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15736","number":15736,"state":"open","locked":false,"title":"[SPARK-18224] [CORE] Optimise PartitionedPairBuffer implementation","user":{"login":"a-roberts","id":12814972,"avatar_url":"https://avatars.githubusercontent.com/u/12814972?v=3","gravatar_id":"","url":"https://api.github.com/users/a-roberts","html_url":"https://github.com/a-roberts","followers_url":"https://api.github.com/users/a-roberts/followers","following_url":"https://api.github.com/users/a-roberts/following{/other_user}","gists_url":"https://api.github.com/users/a-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/a-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-roberts/subscriptions","organizations_url":"https://api.github.com/users/a-roberts/orgs","repos_url":"https://api.github.com/users/a-roberts/repos","events_url":"https://api.github.com/users/a-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/a-roberts/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nThis change is very similar to my pull request for improving PartitionedPairAppendOnlyMap: https://github.com/apache/spark/pull/15735\r\n\r\nSummarising (more detail above), we avoid the slow iterator wrapping in favour of helping the inliner. We observed that this, when combined with the above change, leads to a 3% performance increase on the HiBench large PageRank benchmark with both IBM's SDK for Java and with OpenJDK 8\r\n\r\n## How was this patch tested?\r\nExisting unit tests and HiBench large profile with both IBM's SDK for Java and OpenJDK 8, the PageRank benchmark specifically","created_at":"2016-11-02T11:37:25Z","updated_at":"2016-11-25T15:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21f6864ff1678cfd96da4131bf6c9dd4ddfe3720","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15736/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15736/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15736/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/d3423945c08a8863a63c16005d848af272c025c3","head":{"label":"a-roberts:patch-11","ref":"patch-11","sha":"d3423945c08a8863a63c16005d848af272c025c3","user":{"login":"a-roberts","id":12814972,"avatar_url":"https://avatars.githubusercontent.com/u/12814972?v=3","gravatar_id":"","url":"https://api.github.com/users/a-roberts","html_url":"https://github.com/a-roberts","followers_url":"https://api.github.com/users/a-roberts/followers","following_url":"https://api.github.com/users/a-roberts/following{/other_user}","gists_url":"https://api.github.com/users/a-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/a-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-roberts/subscriptions","organizations_url":"https://api.github.com/users/a-roberts/orgs","repos_url":"https://api.github.com/users/a-roberts/repos","events_url":"https://api.github.com/users/a-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/a-roberts/received_events","type":"User","site_admin":false},"repo":{"id":37144138,"name":"spark","full_name":"a-roberts/spark","owner":{"login":"a-roberts","id":12814972,"avatar_url":"https://avatars.githubusercontent.com/u/12814972?v=3","gravatar_id":"","url":"https://api.github.com/users/a-roberts","html_url":"https://github.com/a-roberts","followers_url":"https://api.github.com/users/a-roberts/followers","following_url":"https://api.github.com/users/a-roberts/following{/other_user}","gists_url":"https://api.github.com/users/a-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/a-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-roberts/subscriptions","organizations_url":"https://api.github.com/users/a-roberts/orgs","repos_url":"https://api.github.com/users/a-roberts/repos","events_url":"https://api.github.com/users/a-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/a-roberts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-roberts/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/a-roberts/spark","forks_url":"https://api.github.com/repos/a-roberts/spark/forks","keys_url":"https://api.github.com/repos/a-roberts/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-roberts/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-roberts/spark/teams","hooks_url":"https://api.github.com/repos/a-roberts/spark/hooks","issue_events_url":"https://api.github.com/repos/a-roberts/spark/issues/events{/number}","events_url":"https://api.github.com/repos/a-roberts/spark/events","assignees_url":"https://api.github.com/repos/a-roberts/spark/assignees{/user}","branches_url":"https://api.github.com/repos/a-roberts/spark/branches{/branch}","tags_url":"https://api.github.com/repos/a-roberts/spark/tags","blobs_url":"https://api.github.com/repos/a-roberts/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-roberts/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-roberts/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-roberts/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-roberts/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/a-roberts/spark/languages","stargazers_url":"https://api.github.com/repos/a-roberts/spark/stargazers","contributors_url":"https://api.github.com/repos/a-roberts/spark/contributors","subscribers_url":"https://api.github.com/repos/a-roberts/spark/subscribers","subscription_url":"https://api.github.com/repos/a-roberts/spark/subscription","commits_url":"https://api.github.com/repos/a-roberts/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-roberts/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-roberts/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-roberts/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-roberts/spark/contents/{+path}","compare_url":"https://api.github.com/repos/a-roberts/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-roberts/spark/merges","archive_url":"https://api.github.com/repos/a-roberts/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-roberts/spark/downloads","issues_url":"https://api.github.com/repos/a-roberts/spark/issues{/number}","pulls_url":"https://api.github.com/repos/a-roberts/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/a-roberts/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/a-roberts/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-roberts/spark/labels{/name}","releases_url":"https://api.github.com/repos/a-roberts/spark/releases{/id}","deployments_url":"https://api.github.com/repos/a-roberts/spark/deployments","created_at":"2015-06-09T16:29:10Z","updated_at":"2016-03-03T12:59:26Z","pushed_at":"2016-11-25T13:43:37Z","git_url":"git://github.com/a-roberts/spark.git","ssh_url":"git@github.com:a-roberts/spark.git","clone_url":"https://github.com/a-roberts/spark.git","svn_url":"https://github.com/a-roberts/spark","homepage":null,"size":241275,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f151bd1af8a05d4b6c901ebe6ac0b51a4a1a20df","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-11-25T10:36:51Z","pushed_at":"2016-11-25T13:43:39Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":615002,"stargazers_count":10861,"watchers_count":10861,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10126,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":453,"forks":10126,"open_issues":453,"watchers":10861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15736"},"html":{"href":"https://github.com/apache/spark/pull/15736"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15736"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15736/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15736/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15736/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/d3423945c08a8863a63c16005d848af272c025c3"}}}}
{"actor":{"display_login":"srowen"}}