{"action":"created","comment":{"url":"https://api.github.com/repos/abenari/rbovirt/pulls/comments/56323275","id":56323275,"diff_hunk":"@@ -6,7 +6,11 @@ def vm(vm_id, opts={})\n     end\n \n     def vms(opts={})\n-      headers = {:accept => \"application/xml; detail=disks; detail=nics; detail=hosts\"}\n+      if opts[:without_details]\n+        headers = {:accept => \"application/xml\"}\n+      else\n+        headers = {:accept => \"application/xml; detail=disks; detail=nics; detail=hosts\"}\n+      end\n       path = \"/vms\"\n       path += search_url(opts) unless filtered_api","path":"lib/client/vm_api.rb","position":11,"original_position":11,"commit_id":"b56ec67fd4208e1958957b595f370fd6b96866bd","original_commit_id":"b56ec67fd4208e1958957b595f370fd6b96866bd","user":{"login":"ohadlevy","id":20167,"avatar_url":"https://avatars.githubusercontent.com/u/20167?v=3","gravatar_id":"","url":"https://api.github.com/users/ohadlevy","html_url":"https://github.com/ohadlevy","followers_url":"https://api.github.com/users/ohadlevy/followers","following_url":"https://api.github.com/users/ohadlevy/following{/other_user}","gists_url":"https://api.github.com/users/ohadlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/ohadlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohadlevy/subscriptions","organizations_url":"https://api.github.com/users/ohadlevy/orgs","repos_url":"https://api.github.com/users/ohadlevy/repos","events_url":"https://api.github.com/users/ohadlevy/events{/privacy}","received_events_url":"https://api.github.com/users/ohadlevy/received_events","type":"User","site_admin":false},"body":"@oourfali <https://github.com/oourfali> this can happen when you use\ndifferent compute resources for quota, or just for different datacenter /\ncluster.\n\nso IMHO, its a valid usage case to use the filter api - granted it would be\nnicer if there was no such limitation in ovirt api :)\n","created_at":"2016-03-16T12:16:44Z","updated_at":"2016-03-16T12:16:44Z","html_url":"https://github.com/abenari/rbovirt/pull/102#discussion_r56323275","pull_request_url":"https://api.github.com/repos/abenari/rbovirt/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/comments/56323275"},"html":{"href":"https://github.com/abenari/rbovirt/pull/102#discussion_r56323275"},"pull_request":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/abenari/rbovirt/pulls/102","id":62099002,"html_url":"https://github.com/abenari/rbovirt/pull/102","diff_url":"https://github.com/abenari/rbovirt/pull/102.diff","patch_url":"https://github.com/abenari/rbovirt/pull/102.patch","issue_url":"https://api.github.com/repos/abenari/rbovirt/issues/102","number":102,"state":"open","locked":false,"title":"Added support for VMS search options max/page","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"This adds support for two new options: max and page. This can be used for\npagination. It should work through fog, I need to test tomorrow.","created_at":"2016-03-08T16:45:40Z","updated_at":"2016-03-16T12:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c54f49828d3def595c45fed906a35151a1b01c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abenari/rbovirt/pulls/102/commits","review_comments_url":"https://api.github.com/repos/abenari/rbovirt/pulls/102/comments","review_comment_url":"https://api.github.com/repos/abenari/rbovirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abenari/rbovirt/issues/102/comments","statuses_url":"https://api.github.com/repos/abenari/rbovirt/statuses/b56ec67fd4208e1958957b595f370fd6b96866bd","head":{"label":"lzap:pagination","ref":"pagination","sha":"b56ec67fd4208e1958957b595f370fd6b96866bd","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":11656323,"name":"rbovirt","full_name":"lzap/rbovirt","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/rbovirt","description":"a ruby client for ovirt","fork":true,"url":"https://api.github.com/repos/lzap/rbovirt","forks_url":"https://api.github.com/repos/lzap/rbovirt/forks","keys_url":"https://api.github.com/repos/lzap/rbovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/rbovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/rbovirt/teams","hooks_url":"https://api.github.com/repos/lzap/rbovirt/hooks","issue_events_url":"https://api.github.com/repos/lzap/rbovirt/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/rbovirt/events","assignees_url":"https://api.github.com/repos/lzap/rbovirt/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/rbovirt/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/rbovirt/tags","blobs_url":"https://api.github.com/repos/lzap/rbovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/rbovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/rbovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/rbovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/rbovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/rbovirt/languages","stargazers_url":"https://api.github.com/repos/lzap/rbovirt/stargazers","contributors_url":"https://api.github.com/repos/lzap/rbovirt/contributors","subscribers_url":"https://api.github.com/repos/lzap/rbovirt/subscribers","subscription_url":"https://api.github.com/repos/lzap/rbovirt/subscription","commits_url":"https://api.github.com/repos/lzap/rbovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/rbovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/rbovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/rbovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/rbovirt/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/rbovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/rbovirt/merges","archive_url":"https://api.github.com/repos/lzap/rbovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/rbovirt/downloads","issues_url":"https://api.github.com/repos/lzap/rbovirt/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/rbovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/rbovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/rbovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/rbovirt/labels{/name}","releases_url":"https://api.github.com/repos/lzap/rbovirt/releases{/id}","deployments_url":"https://api.github.com/repos/lzap/rbovirt/deployments","created_at":"2013-07-25T09:01:22Z","updated_at":"2013-07-25T09:09:57Z","pushed_at":"2016-03-11T14:09:18Z","git_url":"git://github.com/lzap/rbovirt.git","ssh_url":"git@github.com:lzap/rbovirt.git","clone_url":"https://github.com/lzap/rbovirt.git","svn_url":"https://github.com/lzap/rbovirt","homepage":"","size":242,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abenari:master","ref":"master","sha":"0ff587acebd2a979885856e3ef8c1778dee36663","user":{"login":"abenari","id":608711,"avatar_url":"https://avatars.githubusercontent.com/u/608711?v=3","gravatar_id":"","url":"https://api.github.com/users/abenari","html_url":"https://github.com/abenari","followers_url":"https://api.github.com/users/abenari/followers","following_url":"https://api.github.com/users/abenari/following{/other_user}","gists_url":"https://api.github.com/users/abenari/gists{/gist_id}","starred_url":"https://api.github.com/users/abenari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abenari/subscriptions","organizations_url":"https://api.github.com/users/abenari/orgs","repos_url":"https://api.github.com/users/abenari/repos","events_url":"https://api.github.com/users/abenari/events{/privacy}","received_events_url":"https://api.github.com/users/abenari/received_events","type":"User","site_admin":false},"repo":{"id":3110248,"name":"rbovirt","full_name":"abenari/rbovirt","owner":{"login":"abenari","id":608711,"avatar_url":"https://avatars.githubusercontent.com/u/608711?v=3","gravatar_id":"","url":"https://api.github.com/users/abenari","html_url":"https://github.com/abenari","followers_url":"https://api.github.com/users/abenari/followers","following_url":"https://api.github.com/users/abenari/following{/other_user}","gists_url":"https://api.github.com/users/abenari/gists{/gist_id}","starred_url":"https://api.github.com/users/abenari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abenari/subscriptions","organizations_url":"https://api.github.com/users/abenari/orgs","repos_url":"https://api.github.com/users/abenari/repos","events_url":"https://api.github.com/users/abenari/events{/privacy}","received_events_url":"https://api.github.com/users/abenari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abenari/rbovirt","description":"a ruby client for ovirt","fork":false,"url":"https://api.github.com/repos/abenari/rbovirt","forks_url":"https://api.github.com/repos/abenari/rbovirt/forks","keys_url":"https://api.github.com/repos/abenari/rbovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abenari/rbovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abenari/rbovirt/teams","hooks_url":"https://api.github.com/repos/abenari/rbovirt/hooks","issue_events_url":"https://api.github.com/repos/abenari/rbovirt/issues/events{/number}","events_url":"https://api.github.com/repos/abenari/rbovirt/events","assignees_url":"https://api.github.com/repos/abenari/rbovirt/assignees{/user}","branches_url":"https://api.github.com/repos/abenari/rbovirt/branches{/branch}","tags_url":"https://api.github.com/repos/abenari/rbovirt/tags","blobs_url":"https://api.github.com/repos/abenari/rbovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abenari/rbovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abenari/rbovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/abenari/rbovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abenari/rbovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/abenari/rbovirt/languages","stargazers_url":"https://api.github.com/repos/abenari/rbovirt/stargazers","contributors_url":"https://api.github.com/repos/abenari/rbovirt/contributors","subscribers_url":"https://api.github.com/repos/abenari/rbovirt/subscribers","subscription_url":"https://api.github.com/repos/abenari/rbovirt/subscription","commits_url":"https://api.github.com/repos/abenari/rbovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/abenari/rbovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/abenari/rbovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/abenari/rbovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/abenari/rbovirt/contents/{+path}","compare_url":"https://api.github.com/repos/abenari/rbovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abenari/rbovirt/merges","archive_url":"https://api.github.com/repos/abenari/rbovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abenari/rbovirt/downloads","issues_url":"https://api.github.com/repos/abenari/rbovirt/issues{/number}","pulls_url":"https://api.github.com/repos/abenari/rbovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/abenari/rbovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/abenari/rbovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abenari/rbovirt/labels{/name}","releases_url":"https://api.github.com/repos/abenari/rbovirt/releases{/id}","deployments_url":"https://api.github.com/repos/abenari/rbovirt/deployments","created_at":"2012-01-05T13:31:09Z","updated_at":"2015-05-08T08:01:44Z","pushed_at":"2016-03-16T09:36:52Z","git_url":"git://github.com/abenari/rbovirt.git","ssh_url":"git@github.com:abenari/rbovirt.git","clone_url":"https://github.com/abenari/rbovirt.git","svn_url":"https://github.com/abenari/rbovirt","homepage":"","size":836,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":10,"forks":35,"open_issues":10,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/102"},"html":{"href":"https://github.com/abenari/rbovirt/pull/102"},"issue":{"href":"https://api.github.com/repos/abenari/rbovirt/issues/102"},"comments":{"href":"https://api.github.com/repos/abenari/rbovirt/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abenari/rbovirt/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/abenari/rbovirt/statuses/b56ec67fd4208e1958957b595f370fd6b96866bd"}}}}