{"action":"created","issue":{"url":"https://api.github.com/repos/mwrlabs/needle/issues/19","repository_url":"https://api.github.com/repos/mwrlabs/needle","labels_url":"https://api.github.com/repos/mwrlabs/needle/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/mwrlabs/needle/issues/19/comments","events_url":"https://api.github.com/repos/mwrlabs/needle/issues/19/events","html_url":"https://github.com/mwrlabs/needle/pull/19","id":176224407,"number":19,"title":"Add a new module to dump ALL Plist files.","user":{"login":"tghosth","id":13623828,"avatar_url":"https://avatars.githubusercontent.com/u/13623828?v=3","gravatar_id":"","url":"https://api.github.com/users/tghosth","html_url":"https://github.com/tghosth","followers_url":"https://api.github.com/users/tghosth/followers","following_url":"https://api.github.com/users/tghosth/following{/other_user}","gists_url":"https://api.github.com/users/tghosth/gists{/gist_id}","starred_url":"https://api.github.com/users/tghosth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tghosth/subscriptions","organizations_url":"https://api.github.com/users/tghosth/orgs","repos_url":"https://api.github.com/users/tghosth/repos","events_url":"https://api.github.com/users/tghosth/events{/privacy}","received_events_url":"https://api.github.com/users/tghosth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-11T06:24:35Z","updated_at":"2016-09-12T05:49:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mwrlabs/needle/pulls/19","html_url":"https://github.com/mwrlabs/needle/pull/19","diff_url":"https://github.com/mwrlabs/needle/pull/19.diff","patch_url":"https://github.com/mwrlabs/needle/pull/19.patch"},"body":"I created a new module based on the files_plist.py module because I wanted to be able to dump all the files simultaneously and I thought it would be too messy to try and integrate that into the existing module.\r\n\r\nMy python-fu is pretty weak so if you have comments or just want to re-write it to make it less bad, feel free :)"},"comment":{"url":"https://api.github.com/repos/mwrlabs/needle/issues/comments/246255391","html_url":"https://github.com/mwrlabs/needle/pull/19#issuecomment-246255391","issue_url":"https://api.github.com/repos/mwrlabs/needle/issues/19","id":246255391,"user":{"login":"tghosth","id":13623828,"avatar_url":"https://avatars.githubusercontent.com/u/13623828?v=3","gravatar_id":"","url":"https://api.github.com/users/tghosth","html_url":"https://github.com/tghosth","followers_url":"https://api.github.com/users/tghosth/followers","following_url":"https://api.github.com/users/tghosth/following{/other_user}","gists_url":"https://api.github.com/users/tghosth/gists{/gist_id}","starred_url":"https://api.github.com/users/tghosth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tghosth/subscriptions","organizations_url":"https://api.github.com/users/tghosth/orgs","repos_url":"https://api.github.com/users/tghosth/repos","events_url":"https://api.github.com/users/tghosth/events{/privacy}","received_events_url":"https://api.github.com/users/tghosth/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T05:49:38Z","updated_at":"2016-09-12T05:49:38Z","body":"OK so I would suggest then that instead of ANALYZE there is a an option called \"ACTION\" which has possible options of \"LIST_FILES\" (same as current ANALYZE=False), \"ANALYZE\" (same as current ANALYZE=True), or \"DUMP_ALL\" (same as my new module). Does the framework currently have a way of specifying valid option values?\r\n\r\nAdditionally, if DUMP_ALL is set, the file specified in the output path will be ignored and files will just be dumped in the containing folder. E.g. if OUTPUT=/var/.needle/tmp/plist.txt and ACTION=DUMP_ALL then all the files will be output to the /var/.needle/tmp/ folder, overwriting any matching files names which already exist.\r\n\r\nDoes the above logic sound sensible?\r\n\r\nPersonally I think it is cleaner to keep it as a separate module but obviously it is your framework :) "}}
{"actor":{"display_login":"tghosth"}}