{"action":"created","issue":{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/21","repository_url":"https://api.github.com/repos/MPAS-Dev/geometric_features","labels_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/21/comments","events_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/21/events","html_url":"https://github.com/MPAS-Dev/geometric_features/pull/21","id":132978869,"number":21,"title":"Add a mask for the MOC region","user":{"login":"xylar","id":4179064,"avatar_url":"https://avatars.githubusercontent.com/u/4179064?v=3","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"milenaveneziani","id":8237579,"avatar_url":"https://avatars.githubusercontent.com/u/8237579?v=3","gravatar_id":"","url":"https://api.github.com/users/milenaveneziani","html_url":"https://github.com/milenaveneziani","followers_url":"https://api.github.com/users/milenaveneziani/followers","following_url":"https://api.github.com/users/milenaveneziani/following{/other_user}","gists_url":"https://api.github.com/users/milenaveneziani/gists{/gist_id}","starred_url":"https://api.github.com/users/milenaveneziani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milenaveneziani/subscriptions","organizations_url":"https://api.github.com/users/milenaveneziani/orgs","repos_url":"https://api.github.com/users/milenaveneziani/repos","events_url":"https://api.github.com/users/milenaveneziani/events{/privacy}","received_events_url":"https://api.github.com/users/milenaveneziani/received_events","type":"User","site_admin":false},"milestone":null,"comments":17,"created_at":"2016-02-11T13:48:47Z","updated_at":"2016-02-16T21:56:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/21","html_url":"https://github.com/MPAS-Dev/geometric_features/pull/21","diff_url":"https://github.com/MPAS-Dev/geometric_features/pull/21.diff","patch_url":"https://github.com/MPAS-Dev/geometric_features/pull/21.patch"},"body":"This merge also modifies the difference_features.py script to handle cases where 1) a feature does not interesect the mask at all (so nothing should happen) and 2) a feature intersects the mask completely so it should be removed entirely.\r\n"},"comment":{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/comments/184891039","html_url":"https://github.com/MPAS-Dev/geometric_features/pull/21#issuecomment-184891039","issue_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/21","id":184891039,"user":{"login":"xylar","id":4179064,"avatar_url":"https://avatars.githubusercontent.com/u/4179064?v=3","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"created_at":"2016-02-16T21:56:28Z","updated_at":"2016-02-16T21:56:28Z","body":"@milenaveneziani, okay, here are the new basins, i think as you requested.\r\n\r\n![atlantic_moc](https://cloud.githubusercontent.com/assets/4179064/13092430/3684afce-d500-11e5-9d60-207cbe5cf438.png)\r\n![indian_moc](https://cloud.githubusercontent.com/assets/4179064/13092431/3689c98c-d500-11e5-8ef6-79efa18c6267.png)\r\n![indopacific_moc](https://cloud.githubusercontent.com/assets/4179064/13092433/3691c902-d500-11e5-8293-b53c520b1a08.png)\r\n![pacific_moc](https://cloud.githubusercontent.com/assets/4179064/13092432/368cfcd8-d500-11e5-8846-328fc46a932b.png)\r\n\r\nIf you want to go ahead and check this PR, you will just need to download the fixed version of difference_features.py from here:\r\nhttps://raw.githubusercontent.com/xylar/geometric_features/666f3a1c9be632253acca01eef32ffc0c3edb296/difference_features.py\r\nWithout that fix, the driver script won't work.\r\n\r\nLet me know how it goes."}}