{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31","id":62228510,"html_url":"https://github.com/prometheus/snmp_exporter/pull/31","diff_url":"https://github.com/prometheus/snmp_exporter/pull/31.diff","patch_url":"https://github.com/prometheus/snmp_exporter/pull/31.patch","issue_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/31","number":31,"state":"closed","locked":false,"title":"Bit more robustness for legacy systems","user":{"login":"iigorr","id":696765,"avatar_url":"https://avatars.githubusercontent.com/u/696765?v=3","gravatar_id":"","url":"https://api.github.com/users/iigorr","html_url":"https://github.com/iigorr","followers_url":"https://api.github.com/users/iigorr/followers","following_url":"https://api.github.com/users/iigorr/following{/other_user}","gists_url":"https://api.github.com/users/iigorr/gists{/gist_id}","starred_url":"https://api.github.com/users/iigorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iigorr/subscriptions","organizations_url":"https://api.github.com/users/iigorr/orgs","repos_url":"https://api.github.com/users/iigorr/repos","events_url":"https://api.github.com/users/iigorr/events{/privacy}","received_events_url":"https://api.github.com/users/iigorr/received_events","type":"User","site_admin":false},"body":"Some devices (e.g. Emerson PSU) do not seem to support getbulk. We have introduced a configuration option \"bulkget\", which allows to switch to simple getnext. \r\n\r\nThis is also introducing more robust termination criteria for the walk. If the same oid reappears, the walk is terminated. This might also fix the hanging request as described in #8. \r\nAlso if the iid is None or empty, which would lead to an invalid oid (terminated by .), the walk is terminated.\r\n\r\n/cc @totallyunknown ","created_at":"2016-03-09T13:32:47Z","updated_at":"2016-09-06T18:43:46Z","closed_at":"2016-09-06T18:43:46Z","merged_at":null,"merge_commit_sha":"553075d44046861fec210940e1ca9f16075c3ad6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31/commits","review_comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31/comments","review_comment_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/31/comments","statuses_url":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/1271461db18e92bbb4bc7eb3a086dd8f8f94597c","head":{"label":"iigorr:master","ref":"master","sha":"1271461db18e92bbb4bc7eb3a086dd8f8f94597c","user":{"login":"iigorr","id":696765,"avatar_url":"https://avatars.githubusercontent.com/u/696765?v=3","gravatar_id":"","url":"https://api.github.com/users/iigorr","html_url":"https://github.com/iigorr","followers_url":"https://api.github.com/users/iigorr/followers","following_url":"https://api.github.com/users/iigorr/following{/other_user}","gists_url":"https://api.github.com/users/iigorr/gists{/gist_id}","starred_url":"https://api.github.com/users/iigorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iigorr/subscriptions","organizations_url":"https://api.github.com/users/iigorr/orgs","repos_url":"https://api.github.com/users/iigorr/repos","events_url":"https://api.github.com/users/iigorr/events{/privacy}","received_events_url":"https://api.github.com/users/iigorr/received_events","type":"User","site_admin":false},"repo":{"id":52954605,"name":"snmp_exporter","full_name":"iigorr/snmp_exporter","owner":{"login":"iigorr","id":696765,"avatar_url":"https://avatars.githubusercontent.com/u/696765?v=3","gravatar_id":"","url":"https://api.github.com/users/iigorr","html_url":"https://github.com/iigorr","followers_url":"https://api.github.com/users/iigorr/followers","following_url":"https://api.github.com/users/iigorr/following{/other_user}","gists_url":"https://api.github.com/users/iigorr/gists{/gist_id}","starred_url":"https://api.github.com/users/iigorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iigorr/subscriptions","organizations_url":"https://api.github.com/users/iigorr/orgs","repos_url":"https://api.github.com/users/iigorr/repos","events_url":"https://api.github.com/users/iigorr/events{/privacy}","received_events_url":"https://api.github.com/users/iigorr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iigorr/snmp_exporter","description":"SNMP Exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/iigorr/snmp_exporter","forks_url":"https://api.github.com/repos/iigorr/snmp_exporter/forks","keys_url":"https://api.github.com/repos/iigorr/snmp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iigorr/snmp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iigorr/snmp_exporter/teams","hooks_url":"https://api.github.com/repos/iigorr/snmp_exporter/hooks","issue_events_url":"https://api.github.com/repos/iigorr/snmp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/iigorr/snmp_exporter/events","assignees_url":"https://api.github.com/repos/iigorr/snmp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/iigorr/snmp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/iigorr/snmp_exporter/tags","blobs_url":"https://api.github.com/repos/iigorr/snmp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iigorr/snmp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iigorr/snmp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/iigorr/snmp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iigorr/snmp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/iigorr/snmp_exporter/languages","stargazers_url":"https://api.github.com/repos/iigorr/snmp_exporter/stargazers","contributors_url":"https://api.github.com/repos/iigorr/snmp_exporter/contributors","subscribers_url":"https://api.github.com/repos/iigorr/snmp_exporter/subscribers","subscription_url":"https://api.github.com/repos/iigorr/snmp_exporter/subscription","commits_url":"https://api.github.com/repos/iigorr/snmp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/iigorr/snmp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/iigorr/snmp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/iigorr/snmp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/iigorr/snmp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/iigorr/snmp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iigorr/snmp_exporter/merges","archive_url":"https://api.github.com/repos/iigorr/snmp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iigorr/snmp_exporter/downloads","issues_url":"https://api.github.com/repos/iigorr/snmp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/iigorr/snmp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/iigorr/snmp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/iigorr/snmp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iigorr/snmp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/iigorr/snmp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/iigorr/snmp_exporter/deployments","created_at":"2016-03-02T10:32:28Z","updated_at":"2016-03-02T10:32:29Z","pushed_at":"2016-03-10T09:12:57Z","git_url":"git://github.com/iigorr/snmp_exporter.git","ssh_url":"git@github.com:iigorr/snmp_exporter.git","clone_url":"https://github.com/iigorr/snmp_exporter.git","svn_url":"https://github.com/iigorr/snmp_exporter","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"80abc28b08b3f2c2231ebd6fa9149cf8956c1358","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":31185891,"name":"snmp_exporter","full_name":"prometheus/snmp_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/snmp_exporter","description":"SNMP Exporter for Prometheus","fork":false,"url":"https://api.github.com/repos/prometheus/snmp_exporter","forks_url":"https://api.github.com/repos/prometheus/snmp_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/snmp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/snmp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/snmp_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/snmp_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/snmp_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/snmp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/snmp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/snmp_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/snmp_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/snmp_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/snmp_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/snmp_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/snmp_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/snmp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/snmp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/snmp_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/snmp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/snmp_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/snmp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/snmp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/snmp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/snmp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/snmp_exporter/deployments","created_at":"2015-02-22T23:24:16Z","updated_at":"2016-09-06T10:47:13Z","pushed_at":"2016-09-06T18:07:56Z","git_url":"git://github.com/prometheus/snmp_exporter.git","ssh_url":"git@github.com:prometheus/snmp_exporter.git","clone_url":"https://github.com/prometheus/snmp_exporter.git","svn_url":"https://github.com/prometheus/snmp_exporter","homepage":null,"size":91,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":15,"forks":29,"open_issues":15,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31"},"html":{"href":"https://github.com/prometheus/snmp_exporter/pull/31"},"issue":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/issues/31"},"comments":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/1271461db18e92bbb4bc7eb3a086dd8f8f94597c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":2,"additions":23,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"brian-brazil"}}