{"action":"created","issue":{"url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/53","repository_url":"https://api.github.com/repos/xyzz/vita-moonlight","labels_url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/53/comments","events_url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/53/events","html_url":"https://github.com/xyzz/vita-moonlight/pull/53","id":183278238,"number":53,"title":"Store debugging logs","user":{"login":"d3m3vilurr","id":47262,"avatar_url":"https://avatars.githubusercontent.com/u/47262?v=3","gravatar_id":"","url":"https://api.github.com/users/d3m3vilurr","html_url":"https://github.com/d3m3vilurr","followers_url":"https://api.github.com/users/d3m3vilurr/followers","following_url":"https://api.github.com/users/d3m3vilurr/following{/other_user}","gists_url":"https://api.github.com/users/d3m3vilurr/gists{/gist_id}","starred_url":"https://api.github.com/users/d3m3vilurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3m3vilurr/subscriptions","organizations_url":"https://api.github.com/users/d3m3vilurr/orgs","repos_url":"https://api.github.com/users/d3m3vilurr/repos","events_url":"https://api.github.com/users/d3m3vilurr/events{/privacy}","received_events_url":"https://api.github.com/users/d3m3vilurr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-16T17:13:04Z","updated_at":"2016-10-17T04:36:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xyzz/vita-moonlight/pulls/53","html_url":"https://github.com/xyzz/vita-moonlight/pull/53","diff_url":"https://github.com/xyzz/vita-moonlight/pull/53.diff","patch_url":"https://github.com/xyzz/vita-moonlight/pull/53.patch"},"body":"New configure options `save_debug_log`\r\n\r\nIf enable this flag, currently, save connection logs to `ux0:data/moonlight/moonlight.log`\r\nBut sadly, we still cannot detect detail error information of `moonlight-common-c` like `RTSP handshake`.\r\nThis project use `stderr` for the logging & always return same error code(-1)\r\nso sometimes we need to modify this project.\r\n\r\nAnyway this hacky print method will help debugging for user's specific problem at next times."},"comment":{"url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/comments/254110911","html_url":"https://github.com/xyzz/vita-moonlight/pull/53#issuecomment-254110911","issue_url":"https://api.github.com/repos/xyzz/vita-moonlight/issues/53","id":254110911,"user":{"login":"d3m3vilurr","id":47262,"avatar_url":"https://avatars.githubusercontent.com/u/47262?v=3","gravatar_id":"","url":"https://api.github.com/users/d3m3vilurr","html_url":"https://github.com/d3m3vilurr","followers_url":"https://api.github.com/users/d3m3vilurr/followers","following_url":"https://api.github.com/users/d3m3vilurr/following{/other_user}","gists_url":"https://api.github.com/users/d3m3vilurr/gists{/gist_id}","starred_url":"https://api.github.com/users/d3m3vilurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3m3vilurr/subscriptions","organizations_url":"https://api.github.com/users/d3m3vilurr/orgs","repos_url":"https://api.github.com/users/d3m3vilurr/repos","events_url":"https://api.github.com/users/d3m3vilurr/events{/privacy}","received_events_url":"https://api.github.com/users/d3m3vilurr/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T04:36:23Z","updated_at":"2016-10-17T04:36:23Z","body":"this pr is just to add debug printing to file, it make to help debugging like #42 case. :)\r\n\r\nbtw, in my case, sometimes want to detail information of the moonlight-common-c.\r\nactually my case was [this](https://github.com/moonlight-stream/moonlight-common-c/blob/master/src/RtspConnection.c#L492-L499)(yea... probably most reasons are this case)\r\nvita version cannot print any debug console message, also message about `just got rtsp handshake error` make hard understand to enduser (they will think `what is rtsp?` :) )\r\n\r\ni guess, if we can get these debug messages(``Failed to connect to UDP port 48010`, `RTSP OPTIONS request failed`, ...), more helpful for the end user.\r\n\r\n`Limelog` is more complicate in this case.\r\nthis macro looks like designed platform independent & capsulation, and many cases just print to stderr.\r\nbut we cannot see debug console on the working, so we only can use alternative methods(like psp2shell, file, whatever) and initialization of their methods require module outside, sometime passing values to the module inside.\r\ni think, it make to break design, so i mentioned just result error codes :)"}}
{"actor":{"display_login":"d3m3vilurr"}}