{"action":"created","comment":{"url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/comments/91830806","pull_request_review_id":12343773,"id":91830806,"diff_hunk":"@@ -74,17 +80,14 @@ def imageStore(self,id,srcImage):\n         :param srcImage: location of source image\n         :return:\n         '''\n-        auth=self.firebase.auth()\n+        auth = self.firebase.auth()\n         user = auth.sign_in_with_email_and_password('yourfirenation@gmail.com', 'yourfirenation')","path":"externalComm/commClass.py","position":77,"original_position":77,"commit_id":"b380e1cef1512aaaffee30eb5df4738841b46dc1","original_commit_id":"b380e1cef1512aaaffee30eb5df4738841b46dc1","user":{"login":"elswenson","id":9125358,"avatar_url":"https://avatars.githubusercontent.com/u/9125358?v=3","gravatar_id":"","url":"https://api.github.com/users/elswenson","html_url":"https://github.com/elswenson","followers_url":"https://api.github.com/users/elswenson/followers","following_url":"https://api.github.com/users/elswenson/following{/other_user}","gists_url":"https://api.github.com/users/elswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/elswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elswenson/subscriptions","organizations_url":"https://api.github.com/users/elswenson/orgs","repos_url":"https://api.github.com/users/elswenson/repos","events_url":"https://api.github.com/users/elswenson/events{/privacy}","received_events_url":"https://api.github.com/users/elswenson/received_events","type":"User","site_admin":false},"body":"Need to check for potential errors in this flow","created_at":"2016-12-10T07:34:01Z","updated_at":"2016-12-10T07:39:52Z","html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9#discussion_r91830806","pull_request_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/comments/91830806"},"html":{"href":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9#discussion_r91830806"},"pull_request":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9","id":96418833,"html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9","diff_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9.diff","patch_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9.patch","issue_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/9","number":9,"state":"open","locked":false,"title":"Feature/design controller","user":{"login":"andrewtran1995","id":6767915,"avatar_url":"https://avatars.githubusercontent.com/u/6767915?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtran1995","html_url":"https://github.com/andrewtran1995","followers_url":"https://api.github.com/users/andrewtran1995/followers","following_url":"https://api.github.com/users/andrewtran1995/following{/other_user}","gists_url":"https://api.github.com/users/andrewtran1995/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtran1995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtran1995/subscriptions","organizations_url":"https://api.github.com/users/andrewtran1995/orgs","repos_url":"https://api.github.com/users/andrewtran1995/repos","events_url":"https://api.github.com/users/andrewtran1995/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtran1995/received_events","type":"User","site_admin":false},"body":"**NOTE**: Developed primarily on the Jetson with pair programming, due to the many dependences needed (many of which are installed on the Jetson and readily available).\r\n## Major Changes\r\n* **EventHandler**\r\n   * Complete overhaul of behavior and implementation\r\n   * Behavior defined and influenced by states (4 possible states total)\r\n* **AeroCubeEvent**\r\n   * Ability to encode AeroCubeEvent objects as stringified JSON objects\r\n   * Ability to decode (\"rehydrate\") AeroCubeEvent objects from JSON objects\r\n* **Controller**\r\n   * All of controller implemented\r\n   * Listens to incoming messages via TCP Server and calls methods depending on signal\r\n* **TcpService**\r\n   * TCP client and server code moved to its own Python module\r\n   * TcpUtil class provides functionality to encode/decode messages for TCP transmission\r\n## Known Issues\r\n* Tests\r\n   * Integration tests for Controller processing a job\r\n   * Integration tests for Event Handler and Controller communicating to process a job\r\n   * Unit tests, especially for Event Handler\r\n* Documentation\r\n   * Event Handler, especially the different states and how state transitions should occur","created_at":"2016-12-04T02:28:03Z","updated_at":"2016-12-10T07:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e432eefcc37f15fa908d43025f8daa5dbf72fb70","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9/commits","review_comments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9/comments","review_comment_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/9/comments","statuses_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/statuses/b380e1cef1512aaaffee30eb5df4738841b46dc1","head":{"label":"UCSB-CS189-2016-17-Aerospace:feature/design_controller","ref":"feature/design_controller","sha":"b380e1cef1512aaaffee30eb5df4738841b46dc1","user":{"login":"UCSB-CS189-2016-17-Aerospace","id":22618714,"avatar_url":"https://avatars.githubusercontent.com/u/22618714?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace","html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace","followers_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/followers","following_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/following{/other_user}","gists_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/subscriptions","organizations_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/orgs","repos_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/repos","events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/events{/privacy}","received_events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/received_events","type":"Organization","site_admin":false},"repo":{"id":70098843,"name":"Aerocube","full_name":"UCSB-CS189-2016-17-Aerospace/Aerocube","owner":{"login":"UCSB-CS189-2016-17-Aerospace","id":22618714,"avatar_url":"https://avatars.githubusercontent.com/u/22618714?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace","html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace","followers_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/followers","following_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/following{/other_user}","gists_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/subscriptions","organizations_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/orgs","repos_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/repos","events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/events{/privacy}","received_events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube","description":null,"fork":false,"url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube","forks_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/forks","keys_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/teams","hooks_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/hooks","issue_events_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/events{/number}","events_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/events","assignees_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/assignees{/user}","branches_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/branches{/branch}","tags_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/tags","blobs_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/languages","stargazers_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/stargazers","contributors_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/contributors","subscribers_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/subscribers","subscription_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/subscription","commits_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/contents/{+path}","compare_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/merges","archive_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/downloads","issues_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues{/number}","pulls_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/labels{/name}","releases_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/releases{/id}","deployments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/deployments","created_at":"2016-10-05T20:57:04Z","updated_at":"2016-10-27T01:30:11Z","pushed_at":"2016-12-04T02:28:03Z","git_url":"git://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube.git","ssh_url":"git@github.com:UCSB-CS189-2016-17-Aerospace/Aerocube.git","clone_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube.git","svn_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube","homepage":null,"size":13138,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"UCSB-CS189-2016-17-Aerospace:master","ref":"master","sha":"f3dd90bd18367d6fc3a4d995a73e19ca0c063e93","user":{"login":"UCSB-CS189-2016-17-Aerospace","id":22618714,"avatar_url":"https://avatars.githubusercontent.com/u/22618714?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace","html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace","followers_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/followers","following_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/following{/other_user}","gists_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/subscriptions","organizations_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/orgs","repos_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/repos","events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/events{/privacy}","received_events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/received_events","type":"Organization","site_admin":false},"repo":{"id":70098843,"name":"Aerocube","full_name":"UCSB-CS189-2016-17-Aerospace/Aerocube","owner":{"login":"UCSB-CS189-2016-17-Aerospace","id":22618714,"avatar_url":"https://avatars.githubusercontent.com/u/22618714?v=3","gravatar_id":"","url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace","html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace","followers_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/followers","following_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/following{/other_user}","gists_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/subscriptions","organizations_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/orgs","repos_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/repos","events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/events{/privacy}","received_events_url":"https://api.github.com/users/UCSB-CS189-2016-17-Aerospace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube","description":null,"fork":false,"url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube","forks_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/forks","keys_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/teams","hooks_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/hooks","issue_events_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/events{/number}","events_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/events","assignees_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/assignees{/user}","branches_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/branches{/branch}","tags_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/tags","blobs_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/languages","stargazers_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/stargazers","contributors_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/contributors","subscribers_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/subscribers","subscription_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/subscription","commits_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/contents/{+path}","compare_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/merges","archive_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/downloads","issues_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues{/number}","pulls_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/labels{/name}","releases_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/releases{/id}","deployments_url":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/deployments","created_at":"2016-10-05T20:57:04Z","updated_at":"2016-10-27T01:30:11Z","pushed_at":"2016-12-04T02:28:03Z","git_url":"git://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube.git","ssh_url":"git@github.com:UCSB-CS189-2016-17-Aerospace/Aerocube.git","clone_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube.git","svn_url":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube","homepage":null,"size":13138,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9"},"html":{"href":"https://github.com/UCSB-CS189-2016-17-Aerospace/Aerocube/pull/9"},"issue":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/9"},"comments":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/UCSB-CS189-2016-17-Aerospace/Aerocube/statuses/b380e1cef1512aaaffee30eb5df4738841b46dc1"}}}}
{"actor":{"display_login":"elswenson"}}