{"action":"created","issue":{"url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/7","repository_url":"https://api.github.com/repos/jsdf/browserify-cache-api","labels_url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/7/comments","events_url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/7/events","html_url":"https://github.com/jsdf/browserify-cache-api/pull/7","id":142455848,"number":7,"title":"Add tests updating dependent file, and handling de-duped modules","user":{"login":"AgentME","id":577345,"avatar_url":"https://avatars.githubusercontent.com/u/577345?v=3","gravatar_id":"","url":"https://api.github.com/users/AgentME","html_url":"https://github.com/AgentME","followers_url":"https://api.github.com/users/AgentME/followers","following_url":"https://api.github.com/users/AgentME/following{/other_user}","gists_url":"https://api.github.com/users/AgentME/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentME/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentME/subscriptions","organizations_url":"https://api.github.com/users/AgentME/orgs","repos_url":"https://api.github.com/users/AgentME/repos","events_url":"https://api.github.com/users/AgentME/events{/privacy}","received_events_url":"https://api.github.com/users/AgentME/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-21T20:08:41Z","updated_at":"2016-03-23T08:04:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jsdf/browserify-cache-api/pulls/7","html_url":"https://github.com/jsdf/browserify-cache-api/pull/7","diff_url":"https://github.com/jsdf/browserify-cache-api/pull/7.diff","patch_url":"https://github.com/jsdf/browserify-cache-api/pull/7.patch"},"body":"This tests that updating a dependent file invalidates the cache correctly (implementing that old TODO note in test/build.js), and tests that de-duplicated modules are handled correctly.\r\n\r\nHandling de-duped modules was broken prior to b4fb18f89a8f79e591819276aced9c78903149eb. If you had two files with the same contents, Browserify would bundle a the first file as-is, and the second module would be replaced with a reference to the first module. Browserify-incremental would cache this link. If you then updated the first module, Browserify-incremental wouldn't invalidate the cache of the second module. But as of 3.0.0, Browserify-incremental's cache is populated before Browserify's dedupe transform, so the issue is fixed now. Good to have a test for it anyway. (I'd originally written the test before it was fixed.)"},"comment":{"url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/comments/200236850","html_url":"https://github.com/jsdf/browserify-cache-api/pull/7#issuecomment-200236850","issue_url":"https://api.github.com/repos/jsdf/browserify-cache-api/issues/7","id":200236850,"user":{"login":"jsdf","id":1232587,"avatar_url":"https://avatars.githubusercontent.com/u/1232587?v=3","gravatar_id":"","url":"https://api.github.com/users/jsdf","html_url":"https://github.com/jsdf","followers_url":"https://api.github.com/users/jsdf/followers","following_url":"https://api.github.com/users/jsdf/following{/other_user}","gists_url":"https://api.github.com/users/jsdf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdf/subscriptions","organizations_url":"https://api.github.com/users/jsdf/orgs","repos_url":"https://api.github.com/users/jsdf/repos","events_url":"https://api.github.com/users/jsdf/events{/privacy}","received_events_url":"https://api.github.com/users/jsdf/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T08:04:21Z","updated_at":"2016-03-23T08:04:21Z","body":"Looks great :+1:"}}