{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/6549","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/6549/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/6549/comments","events_url":"https://api.github.com/repos/electron/electron/issues/6549/events","html_url":"https://github.com/electron/electron/issues/6549","id":166642216,"number":6549,"title":"Support --enable-features","user":{"login":"djpereira","id":15444756,"avatar_url":"https://avatars.githubusercontent.com/u/15444756?v=3","gravatar_id":"","url":"https://api.github.com/users/djpereira","html_url":"https://github.com/djpereira","followers_url":"https://api.github.com/users/djpereira/followers","following_url":"https://api.github.com/users/djpereira/following{/other_user}","gists_url":"https://api.github.com/users/djpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/djpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djpereira/subscriptions","organizations_url":"https://api.github.com/users/djpereira/orgs","repos_url":"https://api.github.com/users/djpereira/repos","events_url":"https://api.github.com/users/djpereira/events{/privacy}","received_events_url":"https://api.github.com/users/djpereira/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron/electron/labels/beginner","name":"beginner","color":"5319e7"},{"url":"https://api.github.com/repos/electron/electron/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-20T17:53:33Z","updated_at":"2016-07-30T03:42:53Z","closed_at":null,"body":"Using the latest version of Electron 1.2.7, I am trying to enable the `#enable-webrtc-h264-with-openh264-ffmpeg` flag in chromium by doing:\r\n```\r\nconst { app, ipcMain, BrowserWindow, Tray } = require('electron')\r\napp.commandLine.appendSwitch('enable-webrtc-h264-with-openh264-ffmpeg');\r\n```\r\nHowever, when I try to establish a call using WebRTC, H.264 (ID 107) is not available.\r\n\r\nIf you try going to the link below, connecting, and then pressing “i”, you will see the protocol being used by chrome/chromium (Video RX/TX: VP8 or H.264).\r\nhttps://apprtc.appspot.com/r/653398468486?vrc=H264&debug=loopback&vsc=H264\r\n\r\nIf you use Chromium 51 (or Chrome 51) by itself (outside of Electron), it works well once you flip the switch on the flag.\r\n\r\nI prepared a quick sample of my code here:\r\nhttps://github.com/djpereira/electron-quick-start/tree/webrtc-h264-flag-issue\r\n\r\nAgain if you download Chromium 51 (same as Electron) at https://github.com/henrypp/chromium/releases/download/v51.0.2704.106-r723-win64/chromium-sync.exe and call `chrome.exe --enable-webrtc-h264-with-openh264-ffmpeg`, the call goes through using H.264.\r\n\r\nI am not sure if the Chromium build used in electron-prebuild is any different from the current stable version (it has the same version number) or if I’m missing something when I call app.commandLine.appendSwitch.\r\n\r\n* Electron version: 1.2.7\r\n* Operating system: Windows 10.\r\n"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/236338844","html_url":"https://github.com/electron/electron/issues/6549#issuecomment-236338844","issue_url":"https://api.github.com/repos/electron/electron/issues/6549","id":236338844,"user":{"login":"liusy182","id":3293332,"avatar_url":"https://avatars.githubusercontent.com/u/3293332?v=3","gravatar_id":"","url":"https://api.github.com/users/liusy182","html_url":"https://github.com/liusy182","followers_url":"https://api.github.com/users/liusy182/followers","following_url":"https://api.github.com/users/liusy182/following{/other_user}","gists_url":"https://api.github.com/users/liusy182/gists{/gist_id}","starred_url":"https://api.github.com/users/liusy182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liusy182/subscriptions","organizations_url":"https://api.github.com/users/liusy182/orgs","repos_url":"https://api.github.com/users/liusy182/repos","events_url":"https://api.github.com/users/liusy182/events{/privacy}","received_events_url":"https://api.github.com/users/liusy182/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T03:42:53Z","updated_at":"2016-07-30T03:42:53Z","body":"I am not 100% certain but it looks like this is already supported by electron. I am able to run the sample code well on Mac OS X.\r\n\r\nFrom chromium src, 1content_main_runner1 used by Electron also checks for features: \r\nhttps://cs.chromium.org/chromium/src/content/app/content_main_runner.cc?sq=package:chromium&dr=CSs&l=158"}}
{"actor":{"display_login":"liusy182"}}