{"action":"created","issue":{"url":"https://api.github.com/repos/beetbox/beets/issues/2138","repository_url":"https://api.github.com/repos/beetbox/beets","labels_url":"https://api.github.com/repos/beetbox/beets/issues/2138/labels{/name}","comments_url":"https://api.github.com/repos/beetbox/beets/issues/2138/comments","events_url":"https://api.github.com/repos/beetbox/beets/issues/2138/events","html_url":"https://github.com/beetbox/beets/issues/2138","id":167145485,"number":2138,"title":"wrapper for calls to ui._raw_main in test_ui.py","user":{"login":"jrobeson","id":56908,"avatar_url":"https://avatars.githubusercontent.com/u/56908?v=3","gravatar_id":"","url":"https://api.github.com/users/jrobeson","html_url":"https://github.com/jrobeson","followers_url":"https://api.github.com/users/jrobeson/followers","following_url":"https://api.github.com/users/jrobeson/following{/other_user}","gists_url":"https://api.github.com/users/jrobeson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobeson/subscriptions","organizations_url":"https://api.github.com/users/jrobeson/orgs","repos_url":"https://api.github.com/users/jrobeson/repos","events_url":"https://api.github.com/users/jrobeson/events{/privacy}","received_events_url":"https://api.github.com/users/jrobeson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/beetbox/beets/labels/testing","name":"testing","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-22T22:35:46Z","updated_at":"2016-07-23T19:21:05Z","closed_at":null,"body":"Currently we're unable to use `run_command` from `helper.py` due to the usage of `self.lib` as seen here https://github.com/beetbox/beets/blob/master/test/helper.py#L424 . Using `run_command` directly ends up causing a problem due to the autodetection of the config filename here: https://github.com/beetbox/beets/blob/master/beets/ui/__init__.py#L1161 Should we create another version of `run_command` for `test_ui.py` or change how `run_command` works? or something else?\r\n\r\nThis would really help make the py3 changes a lot simpler (due to bytes vs string arguments), and seems like a good idea in any case."},"comment":{"url":"https://api.github.com/repos/beetbox/beets/issues/comments/234735355","html_url":"https://github.com/beetbox/beets/issues/2138#issuecomment-234735355","issue_url":"https://api.github.com/repos/beetbox/beets/issues/2138","id":234735355,"user":{"login":"sampsyo","id":188033,"avatar_url":"https://avatars.githubusercontent.com/u/188033?v=3","gravatar_id":"","url":"https://api.github.com/users/sampsyo","html_url":"https://github.com/sampsyo","followers_url":"https://api.github.com/users/sampsyo/followers","following_url":"https://api.github.com/users/sampsyo/following{/other_user}","gists_url":"https://api.github.com/users/sampsyo/gists{/gist_id}","starred_url":"https://api.github.com/users/sampsyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampsyo/subscriptions","organizations_url":"https://api.github.com/users/sampsyo/orgs","repos_url":"https://api.github.com/users/sampsyo/repos","events_url":"https://api.github.com/users/sampsyo/events{/privacy}","received_events_url":"https://api.github.com/users/sampsyo/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T19:21:05Z","updated_at":"2016-07-23T19:21:05Z","body":"> args can't be bytes when using the the default stdio stuff.\r\n\r\nOK, I might need one more step to understand… what do args have to do with stdin and stdout?\r\n\r\nOr, perhaps a more relevant question: what's the exact point in the current workflow that requires that arguments be Unicode strings? Is it some interaction with a standard library module? If so, which module, and where do we call it? (Maybe we can bypass that call to sidestep the requirement.)\r\n\r\nIf I'm understanding correctly, maybe the right thing to do is to rethink the way tests invoke commands. Most commands use `decargs` to retrieve the arguments as Unicode strings, but sometimes I imagine they want the raw bytes (e.g., when a filename is an argument). So with that in mind, we need to decide what tests should be able to supply—should they be able to send Unicode arguments, which we'll then encode so they get decoded correctly? Should they be able to provide bytes (seems necessary for the filename case)?"}}
{"actor":{"display_login":"sampsyo"}}