{"action":"created","issue":{"url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135","repository_url":"https://api.github.com/repos/Accenture/adop-docker-compose","labels_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135/comments","events_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135/events","html_url":"https://github.com/Accenture/adop-docker-compose/pull/135","id":172505445,"number":135,"title":"Modifying LDAP parameters in docker-compose.yml to be read from env.config.sh","user":{"login":"mihail-dev","id":4163233,"avatar_url":"https://avatars.githubusercontent.com/u/4163233?v=3","gravatar_id":"","url":"https://api.github.com/users/mihail-dev","html_url":"https://github.com/mihail-dev","followers_url":"https://api.github.com/users/mihail-dev/followers","following_url":"https://api.github.com/users/mihail-dev/following{/other_user}","gists_url":"https://api.github.com/users/mihail-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/mihail-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihail-dev/subscriptions","organizations_url":"https://api.github.com/users/mihail-dev/orgs","repos_url":"https://api.github.com/users/mihail-dev/repos","events_url":"https://api.github.com/users/mihail-dev/events{/privacy}","received_events_url":"https://api.github.com/users/mihail-dev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-22T17:11:59Z","updated_at":"2016-09-01T05:07:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135","html_url":"https://github.com/Accenture/adop-docker-compose/pull/135","diff_url":"https://github.com/Accenture/adop-docker-compose/pull/135.diff","patch_url":"https://github.com/Accenture/adop-docker-compose/pull/135.patch"},"body":"Hi,\r\n\r\nIn our case we are spinning up ADOP and configuring it to use our existing ldap instead of adop-ldap. We would like to keep our ldap configuration separately to the docker compose file in env.config.sh. This modification will be beneficial because:\r\n- It makes upgrading ADOP to a newer version easier in the future.\r\n- it is simpler and easier to maintain.\r\n\r\nI have tested the change on AWS and everything functions properly.\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/comments/243977189","html_url":"https://github.com/Accenture/adop-docker-compose/pull/135#issuecomment-243977189","issue_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135","id":243977189,"user":{"login":"anton-kasperovich","id":380055,"avatar_url":"https://avatars.githubusercontent.com/u/380055?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-kasperovich","html_url":"https://github.com/anton-kasperovich","followers_url":"https://api.github.com/users/anton-kasperovich/followers","following_url":"https://api.github.com/users/anton-kasperovich/following{/other_user}","gists_url":"https://api.github.com/users/anton-kasperovich/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-kasperovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-kasperovich/subscriptions","organizations_url":"https://api.github.com/users/anton-kasperovich/orgs","repos_url":"https://api.github.com/users/anton-kasperovich/repos","events_url":"https://api.github.com/users/anton-kasperovich/events{/privacy}","received_events_url":"https://api.github.com/users/anton-kasperovich/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T05:07:04Z","updated_at":"2016-09-01T05:07:04Z","body":"Build failed, because of Jenkins and looks like it's related to this PR, i ran it again, let's see on results, if it would fail again i will try this changes locally to have better understanding where's issue."}}
{"actor":{"display_login":"anton-kasperovich"}}