{"action":"opened","issue":{"url":"https://api.github.com/repos/GeoNet/mtr/issues/135","repository_url":"https://api.github.com/repos/GeoNet/mtr","labels_url":"https://api.github.com/repos/GeoNet/mtr/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/GeoNet/mtr/issues/135/comments","events_url":"https://api.github.com/repos/GeoNet/mtr/issues/135/events","html_url":"https://github.com/GeoNet/mtr/issues/135","id":156665457,"number":135,"title":"Code review - could you add new features to mtr-api ?","user":{"login":"gclitheroe","id":1016463,"avatar_url":"https://avatars.githubusercontent.com/u/1016463?v=3","gravatar_id":"","url":"https://api.github.com/users/gclitheroe","html_url":"https://github.com/gclitheroe","followers_url":"https://api.github.com/users/gclitheroe/followers","following_url":"https://api.github.com/users/gclitheroe/following{/other_user}","gists_url":"https://api.github.com/users/gclitheroe/gists{/gist_id}","starred_url":"https://api.github.com/users/gclitheroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gclitheroe/subscriptions","organizations_url":"https://api.github.com/users/gclitheroe/orgs","repos_url":"https://api.github.com/users/gclitheroe/repos","events_url":"https://api.github.com/users/gclitheroe/events{/privacy}","received_events_url":"https://api.github.com/users/gclitheroe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GeoNet/mtr/labels/1%20-%20Ready","name":"1 - Ready","color":"CCCCCC"},{"url":"https://api.github.com/repos/GeoNet/mtr/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/GeoNet/mtr/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":{"login":"bpeng","id":1020745,"avatar_url":"https://avatars.githubusercontent.com/u/1020745?v=3","gravatar_id":"","url":"https://api.github.com/users/bpeng","html_url":"https://github.com/bpeng","followers_url":"https://api.github.com/users/bpeng/followers","following_url":"https://api.github.com/users/bpeng/following{/other_user}","gists_url":"https://api.github.com/users/bpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/bpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpeng/subscriptions","organizations_url":"https://api.github.com/users/bpeng/orgs","repos_url":"https://api.github.com/users/bpeng/repos","events_url":"https://api.github.com/users/bpeng/events{/privacy}","received_events_url":"https://api.github.com/users/bpeng/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2016-05-25T05:21:12Z","updated_at":"2016-05-25T05:21:12Z","closed_at":null,"body":"Hi,\r\n\r\nI have severely re-factored the mtr-api code to try to\r\n\r\n* make it more internally consistent\r\n* easier to understand\r\n* document some assumptions\r\n* document how to add features.\r\n\r\n@bpeng  please could you review the HEAD of my branch https://github.com/gclitheroe/mtr/tree/wip-mtr-api-polish and see if you could understand adding another table to the DB and some services to go with it (if you can't I have more work to do).\r\n\r\nMaybe start with \r\n\r\nhttps://github.com/gclitheroe/mtr/blob/wip-mtr-api-polish/README.md\r\nand also some of the assumptions outlined in https://github.com/gclitheroe/mtr/blob/wip-mtr-api-polish/mtr-api/domain.go\r\n\r\nThe rest of the code is really just handling requests and wiring.\r\n\r\n@crleblanc and @junghao - do these changes answer some of the questions you have had?  Is it obvious enough how to add features.\r\n\r\n@dc735 @ozym @quiffman - feedback welcome.  Especially for anything that might make this clearer.\r\n\r\nFWIW the mtr-api is running the application metric caching code at the moment.  Seems ok.  I'll consider adding it for the field metrics etc based on comments on this issue.  I think mtr will always be DB and network constrained and not actually need horizontal scaling for the mtr-api server so adding some memory read caching to take pressure off the DB makes sense to me."}}
{"actor":{"display_login":"gclitheroe"}}