{"action":"created","issue":{"url":"https://api.github.com/repos/travisbrown/circe/issues/348","repository_url":"https://api.github.com/repos/travisbrown/circe","labels_url":"https://api.github.com/repos/travisbrown/circe/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/travisbrown/circe/issues/348/comments","events_url":"https://api.github.com/repos/travisbrown/circe/issues/348/events","html_url":"https://github.com/travisbrown/circe/issues/348","id":171206343,"number":348,"title":"Json number equality for zero","user":{"login":"travisbrown","id":316049,"avatar_url":"https://avatars.githubusercontent.com/u/316049?v=3","gravatar_id":"","url":"https://api.github.com/users/travisbrown","html_url":"https://github.com/travisbrown","followers_url":"https://api.github.com/users/travisbrown/followers","following_url":"https://api.github.com/users/travisbrown/following{/other_user}","gists_url":"https://api.github.com/users/travisbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbrown/subscriptions","organizations_url":"https://api.github.com/users/travisbrown/orgs","repos_url":"https://api.github.com/users/travisbrown/repos","events_url":"https://api.github.com/users/travisbrown/events{/privacy}","received_events_url":"https://api.github.com/users/travisbrown/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/travisbrown/circe/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/travisbrown/circe/milestones/4","html_url":"https://github.com/travisbrown/circe/milestones/0.5.0","labels_url":"https://api.github.com/repos/travisbrown/circe/milestones/4/labels","id":1607029,"number":4,"title":"0.5.0","description":null,"creator":{"login":"travisbrown","id":316049,"avatar_url":"https://avatars.githubusercontent.com/u/316049?v=3","gravatar_id":"","url":"https://api.github.com/users/travisbrown","html_url":"https://github.com/travisbrown","followers_url":"https://api.github.com/users/travisbrown/followers","following_url":"https://api.github.com/users/travisbrown/following{/other_user}","gists_url":"https://api.github.com/users/travisbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbrown/subscriptions","organizations_url":"https://api.github.com/users/travisbrown/orgs","repos_url":"https://api.github.com/users/travisbrown/repos","events_url":"https://api.github.com/users/travisbrown/events{/privacy}","received_events_url":"https://api.github.com/users/travisbrown/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-02-26T00:54:38Z","updated_at":"2016-08-15T16:26:22Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-08-15T16:26:22Z","updated_at":"2016-08-15T18:03:51Z","closed_at":null,"body":"Thanks to @davegurnell for identifying this issue on Java 7:\r\n\r\n```scala\r\nscala> import io.circe.Encoder, io.circe.jawn.parse\r\nimport io.circe.Encoder\r\nimport io.circe.jawn.parse\r\n\r\nscala> Encoder[Double].apply(0.0) == parse(\"0.0\").toOption.get\r\nres0: Boolean = false\r\n```\r\n\r\nThe equality logic in `BiggerDecimal` is correct, but we're running into [this JDK bug](http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6480539), which is fixed in Java 8. The bug affects both Oracle and OpenJDK.\r\n\r\nThis is bad enough that I think we need to work around the JDK bug for as long as we're supporting Java 7. I'll plan to have the fix ready for the 0.5.0 release, but won't plan to backport to 0.4.x unless someone has a particular need for it."},"comment":{"url":"https://api.github.com/repos/travisbrown/circe/issues/comments/239878422","html_url":"https://github.com/travisbrown/circe/issues/348#issuecomment-239878422","issue_url":"https://api.github.com/repos/travisbrown/circe/issues/348","id":239878422,"user":{"login":"davegurnell","id":231655,"avatar_url":"https://avatars.githubusercontent.com/u/231655?v=3","gravatar_id":"","url":"https://api.github.com/users/davegurnell","html_url":"https://github.com/davegurnell","followers_url":"https://api.github.com/users/davegurnell/followers","following_url":"https://api.github.com/users/davegurnell/following{/other_user}","gists_url":"https://api.github.com/users/davegurnell/gists{/gist_id}","starred_url":"https://api.github.com/users/davegurnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegurnell/subscriptions","organizations_url":"https://api.github.com/users/davegurnell/orgs","repos_url":"https://api.github.com/users/davegurnell/repos","events_url":"https://api.github.com/users/davegurnell/events{/privacy}","received_events_url":"https://api.github.com/users/davegurnell/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T18:03:51Z","updated_at":"2016-08-15T18:03:51Z","body":"Nice sleuthing! I had no idea the issue was that specific!\nOn Mon, 15 Aug 2016 at 17:26, Travis Brown <notifications@github.com> wrote:\n\n> Thanks to @davegurnell <https://github.com/davegurnell> for identifying\n> this issue on Java 7:\n>\n> scala> import io.circe.Encoder, io.circe.jawn.parseimport io.circe.Encoderimport io.circe.jawn.parse\n>\n> scala> Encoder[Double].apply(0.0) == parse(\"0.0\").toOption.get\n> res0: Boolean = false\n>\n> The equality logic in BiggerDecimal is correct, but we're running into this\n> JDK bug <http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6480539>,\n> which is fixed in Java 8. The bug affects both Oracle and OpenJDK.\n>\n> This is bad enough that I think we need to work around the JDK bug for as\n> long as we're supporting Java 7. I'll plan to have the fix ready for the\n> 0.5.0 release, but won't plan to backport to 0.4.x unless someone has a\n> particular need for it.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/travisbrown/circe/issues/348>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAOI53xK4cwenKxMv1Vmjq8TvnEqjOcRks5qgJMwgaJpZM4JkiJ5>\n> .\n>\n"}}
{"actor":{"display_login":"davegurnell"}}