{"action":"created","issue":{"url":"https://api.github.com/repos/istanbuljs/nyc/issues/286","repository_url":"https://api.github.com/repos/istanbuljs/nyc","labels_url":"https://api.github.com/repos/istanbuljs/nyc/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/istanbuljs/nyc/issues/286/comments","events_url":"https://api.github.com/repos/istanbuljs/nyc/issues/286/events","html_url":"https://github.com/istanbuljs/nyc/pull/286","id":162352867,"number":286,"title":"feat: nyc is being refactored to become the official Istanbul 1.0 bin","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-26T23:09:22Z","updated_at":"2016-06-27T02:31:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/istanbuljs/nyc/pulls/286","html_url":"https://github.com/istanbuljs/nyc/pull/286","diff_url":"https://github.com/istanbuljs/nyc/pull/286.diff","patch_url":"https://github.com/istanbuljs/nyc/pull/286.patch"},"body":"This refactoring work moves nyc towards using Istanbul's more modular `v1.0` API.\r\n\r\n## Features of Note\r\n\r\n* I've changed the messaging somewhat, announcing nyc as the official Istanbul bin.\r\n* We no longer call out to the `istanbul` bin for the feature `check-coverage` (calculating this is now our responsibility).\r\n* we no longer load `.istanbul.yml`, we will extend nyc's configuration gradually to support any configuration options that we're missing.\r\n* we now point folks towards `babel-plugin-istanbul` for ES6/ES7 support.\r\n* we no longer use the preamble function for `--all` functionality, using an approach closer to what istanbul's original bin used:\r\n  * this fixes #183 \r\n\r\n## Breaking Changes\r\n\r\n* `.istanbul.js` is no longer supported.\r\n* removed `instrumenter` configuration option for the time being (I think we get pretty far with the new istanbul-lib-instrument, and a noop instrumenter, and can avoid abstracting this part of the API for the time being).\r\n* completely new underlying instrumentation engine.\r\n\r\n## Todo\r\n\r\n- [x] test with a few libraries on Windows (windows testing went very smoothly \\o/)\r\n- [ ] add unit tests for native ES6 code (excited to exercise the new instrumentation library).\r\n- [x] create tickets for further work: porting more istanbul configuration options, switching to the istanbuljs org's source-map library, source-maps for errors?\r\n- [ ]  get `babel-plugin-istanbul@1.0.0` published.\r\n\r\nCC: @novemberborn, @jamestalmage, @dtinth, @gotwarlost"},"comment":{"url":"https://api.github.com/repos/istanbuljs/nyc/issues/comments/228642067","html_url":"https://github.com/istanbuljs/nyc/pull/286#issuecomment-228642067","issue_url":"https://api.github.com/repos/istanbuljs/nyc/issues/286","id":228642067,"user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T02:31:52Z","updated_at":"2016-06-27T02:31:52Z","body":"I'm seeing some issues with the ava test suite, using the new instrumentation approach:\r\n\r\n```sh\r\nnot ok should match pattern provided\r\n    found: >\r\n      /Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/location.js:25\r\n        throw err;\r\n        ^\r\n    \r\n      SyntaxError: 'return' outside of function (14:1)\r\n          at Parser.pp.raise (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/location.js:22:13)\r\n          at Parser.pp.parseReturnStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:321:10)\r\n          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:107:19)\r\n          at Parser.pp.parseBlockBody (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:529:21)\r\n          at Parser.pp.parseBlock (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:510:8)\r\n          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:127:19)\r\n          at Parser.pp.parseIfStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:314:26)\r\n          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:105:19)\r\n          at Parser.pp.parseBlockBody (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:529:21)\r\n          at Parser.pp.parseTopLevel (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:36:8)\r\n```\r\n\r\n@jamestalmage @novemberborn any thoughts?"}}
{"actor":{"display_login":"bcoe"}}