{"action":"created","issue":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/9","repository_url":"https://api.github.com/repos/Betterment/test_track_rails_client","labels_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/9/comments","events_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/9/events","html_url":"https://github.com/Betterment/test_track_rails_client/issues/9","id":187074644,"number":9,"title":"Re-work SafeWrapper default_handler to log.error instead of Airbrake","user":{"login":"samandmoore","id":407586,"avatar_url":"https://avatars.githubusercontent.com/u/407586?v=3","gravatar_id":"","url":"https://api.github.com/users/samandmoore","html_url":"https://github.com/samandmoore","followers_url":"https://api.github.com/users/samandmoore/followers","following_url":"https://api.github.com/users/samandmoore/following{/other_user}","gists_url":"https://api.github.com/users/samandmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/samandmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samandmoore/subscriptions","organizations_url":"https://api.github.com/users/samandmoore/orgs","repos_url":"https://api.github.com/users/samandmoore/repos","events_url":"https://api.github.com/users/samandmoore/events{/privacy}","received_events_url":"https://api.github.com/users/samandmoore/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-11-03T14:26:51Z","updated_at":"2016-11-04T15:14:22Z","closed_at":"2016-11-04T15:14:22Z","body":"The errors that we catch inside of [`SafeWrapper`](https://github.com/Betterment/test_track_rails_client/blob/master/app/models/test_track/analytics/safe_wrapper.rb) are from analytics client libraries. As such, it doesn't make very much sense to send them over to Airbrake as they are likely to be temporary runtime failures (e.g. http connection issues) and not fixable software bugs.\r\n\r\nAlso, given that we have the ability to specify our own custom `error_handler` (in the analytics `SafeWrapper`) via a lambda, there is no need to keep the Airbrake code in the default configuration. If someone really wants to log errors coming out of their analytics library integration, then they can configure the `error_handler` on their custom analytics client.\r\n\r\n_edited: to add clarification_"},"comment":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/comments/258458553","html_url":"https://github.com/Betterment/test_track_rails_client/issues/9#issuecomment-258458553","issue_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/9","id":258458553,"user":{"login":"samandmoore","id":407586,"avatar_url":"https://avatars.githubusercontent.com/u/407586?v=3","gravatar_id":"","url":"https://api.github.com/users/samandmoore","html_url":"https://github.com/samandmoore","followers_url":"https://api.github.com/users/samandmoore/followers","following_url":"https://api.github.com/users/samandmoore/following{/other_user}","gists_url":"https://api.github.com/users/samandmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/samandmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samandmoore/subscriptions","organizations_url":"https://api.github.com/users/samandmoore/orgs","repos_url":"https://api.github.com/users/samandmoore/repos","events_url":"https://api.github.com/users/samandmoore/events{/privacy}","received_events_url":"https://api.github.com/users/samandmoore/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T15:14:22Z","updated_at":"2016-11-04T15:14:22Z","body":"fixed by #12 "}}
{"actor":{"display_login":"samandmoore"}}