{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/67320222","id":67320222,"diff_hunk":"@@ -346,6 +347,13 @@ public IdentityMgtConfig(RealmConfiguration configuration) {\n                 this.registryCleanUpPeriod = Long.parseLong(registryCleanUpPeriod);\n             }\n \n+            String tempNotificationSendingThreadPoolSize = properties\n+                    .getProperty(IdentityMgtConstants.PropertyConfig.NOTIFICATION_SENDING_THREAD_POOL_SIZE);\n+\n+            if (tempNotificationSendingThreadPoolSize != null) {","path":"components/identity-mgt/org.wso2.carbon.identity.mgt/src/main/java/org/wso2/carbon/identity/mgt/IdentityMgtConfig.java","position":15,"original_position":15,"commit_id":"3f3aa79aebb7172b244690d2f15d4c5a411ef325","original_commit_id":"3f3aa79aebb7172b244690d2f15d4c5a411ef325","user":{"login":"thanujalk","id":1498339,"avatar_url":"https://avatars.githubusercontent.com/u/1498339?v=3","gravatar_id":"","url":"https://api.github.com/users/thanujalk","html_url":"https://github.com/thanujalk","followers_url":"https://api.github.com/users/thanujalk/followers","following_url":"https://api.github.com/users/thanujalk/following{/other_user}","gists_url":"https://api.github.com/users/thanujalk/gists{/gist_id}","starred_url":"https://api.github.com/users/thanujalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanujalk/subscriptions","organizations_url":"https://api.github.com/users/thanujalk/orgs","repos_url":"https://api.github.com/users/thanujalk/repos","events_url":"https://api.github.com/users/thanujalk/events{/privacy}","received_events_url":"https://api.github.com/users/thanujalk/received_events","type":"User","site_admin":false},"body":"Can use NumberUtils.isNumber() instead null check.","created_at":"2016-06-16T10:13:57Z","updated_at":"2016-06-16T10:13:58Z","html_url":"https://github.com/wso2/carbon-identity-framework/pull/317#discussion_r67320222","pull_request_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/67320222"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/317#discussion_r67320222"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317","id":74053956,"html_url":"https://github.com/wso2/carbon-identity-framework/pull/317","diff_url":"https://github.com/wso2/carbon-identity-framework/pull/317.diff","patch_url":"https://github.com/wso2/carbon-identity-framework/pull/317.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/317","number":317,"state":"open","locked":false,"title":"fixing IDENTITY-4702","user":{"login":"GayanM","id":3436694,"avatar_url":"https://avatars.githubusercontent.com/u/3436694?v=3","gravatar_id":"","url":"https://api.github.com/users/GayanM","html_url":"https://github.com/GayanM","followers_url":"https://api.github.com/users/GayanM/followers","following_url":"https://api.github.com/users/GayanM/following{/other_user}","gists_url":"https://api.github.com/users/GayanM/gists{/gist_id}","starred_url":"https://api.github.com/users/GayanM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayanM/subscriptions","organizations_url":"https://api.github.com/users/GayanM/orgs","repos_url":"https://api.github.com/users/GayanM/repos","events_url":"https://api.github.com/users/GayanM/events{/privacy}","received_events_url":"https://api.github.com/users/GayanM/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-16T10:06:02Z","updated_at":"2016-06-16T10:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"394f88adf374323bbfa269375906ed8ab85523f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/317/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/3f3aa79aebb7172b244690d2f15d4c5a411ef325","head":{"label":"GayanM:IDENTITY-4702","ref":"IDENTITY-4702","sha":"3f3aa79aebb7172b244690d2f15d4c5a411ef325","user":{"login":"GayanM","id":3436694,"avatar_url":"https://avatars.githubusercontent.com/u/3436694?v=3","gravatar_id":"","url":"https://api.github.com/users/GayanM","html_url":"https://github.com/GayanM","followers_url":"https://api.github.com/users/GayanM/followers","following_url":"https://api.github.com/users/GayanM/following{/other_user}","gists_url":"https://api.github.com/users/GayanM/gists{/gist_id}","starred_url":"https://api.github.com/users/GayanM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayanM/subscriptions","organizations_url":"https://api.github.com/users/GayanM/orgs","repos_url":"https://api.github.com/users/GayanM/repos","events_url":"https://api.github.com/users/GayanM/events{/privacy}","received_events_url":"https://api.github.com/users/GayanM/received_events","type":"User","site_admin":false},"repo":{"id":59995852,"name":"carbon-identity-framework","full_name":"GayanM/carbon-identity-framework","owner":{"login":"GayanM","id":3436694,"avatar_url":"https://avatars.githubusercontent.com/u/3436694?v=3","gravatar_id":"","url":"https://api.github.com/users/GayanM","html_url":"https://github.com/GayanM","followers_url":"https://api.github.com/users/GayanM/followers","following_url":"https://api.github.com/users/GayanM/following{/other_user}","gists_url":"https://api.github.com/users/GayanM/gists{/gist_id}","starred_url":"https://api.github.com/users/GayanM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayanM/subscriptions","organizations_url":"https://api.github.com/users/GayanM/orgs","repos_url":"https://api.github.com/users/GayanM/repos","events_url":"https://api.github.com/users/GayanM/events{/privacy}","received_events_url":"https://api.github.com/users/GayanM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GayanM/carbon-identity-framework","description":"","fork":true,"url":"https://api.github.com/repos/GayanM/carbon-identity-framework","forks_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/GayanM/carbon-identity-framework/deployments","created_at":"2016-05-30T09:01:29Z","updated_at":"2016-05-30T09:01:36Z","pushed_at":"2016-06-16T10:03:34Z","git_url":"git://github.com/GayanM/carbon-identity-framework.git","ssh_url":"git@github.com:GayanM/carbon-identity-framework.git","clone_url":"https://github.com/GayanM/carbon-identity-framework.git","svn_url":"https://github.com/GayanM/carbon-identity-framework","homepage":null,"size":39000,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"594a875ad23a9669e8e35bdccecad57c51e1e858","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":52329722,"name":"carbon-identity-framework","full_name":"wso2/carbon-identity-framework","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity-framework","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity-framework","forks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/deployments","created_at":"2016-02-23T04:20:26Z","updated_at":"2016-05-13T09:11:57Z","pushed_at":"2016-06-16T10:08:49Z","git_url":"git://github.com/wso2/carbon-identity-framework.git","ssh_url":"git@github.com:wso2/carbon-identity-framework.git","clone_url":"https://github.com/wso2/carbon-identity-framework.git","svn_url":"https://github.com/wso2/carbon-identity-framework","homepage":null,"size":39567,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":21,"forks":39,"open_issues":21,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/317"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/317"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/3f3aa79aebb7172b244690d2f15d4c5a411ef325"}}}}
{"actor":{"display_login":"thanujalk"}}