{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/63787981","id":63787981,"diff_hunk":"@@ -0,0 +1,27 @@\n+module Spree\n+  module Core\n+    module Search\n+      class ProductFilter","path":"core/lib/spree/core/search/product_filter.rb","position":4,"original_position":4,"commit_id":"1410c64a77424d0a91464e49533a8bae7ce50667","original_commit_id":"1410c64a77424d0a91464e49533a8bae7ce50667","user":{"login":"cbrunsdon","id":279013,"avatar_url":"https://avatars.githubusercontent.com/u/279013?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrunsdon","html_url":"https://github.com/cbrunsdon","followers_url":"https://api.github.com/users/cbrunsdon/followers","following_url":"https://api.github.com/users/cbrunsdon/following{/other_user}","gists_url":"https://api.github.com/users/cbrunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrunsdon/subscriptions","organizations_url":"https://api.github.com/users/cbrunsdon/orgs","repos_url":"https://api.github.com/users/cbrunsdon/repos","events_url":"https://api.github.com/users/cbrunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/cbrunsdon/received_events","type":"User","site_admin":false},"body":"I like either of those options too.","created_at":"2016-05-18T21:44:31Z","updated_at":"2016-05-18T21:44:31Z","html_url":"https://github.com/solidusio/solidus/pull/1151#discussion_r63787981","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1151","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/63787981"},"html":{"href":"https://github.com/solidusio/solidus/pull/1151#discussion_r63787981"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1151"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1151","id":70212488,"html_url":"https://github.com/solidusio/solidus/pull/1151","diff_url":"https://github.com/solidusio/solidus/pull/1151.diff","patch_url":"https://github.com/solidusio/solidus/pull/1151.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1151","number":1151,"state":"open","locked":false,"title":"Make product filters more configurable","user":{"login":"mtylty","id":167670,"avatar_url":"https://avatars.githubusercontent.com/u/167670?v=3","gravatar_id":"","url":"https://api.github.com/users/mtylty","html_url":"https://github.com/mtylty","followers_url":"https://api.github.com/users/mtylty/followers","following_url":"https://api.github.com/users/mtylty/following{/other_user}","gists_url":"https://api.github.com/users/mtylty/gists{/gist_id}","starred_url":"https://api.github.com/users/mtylty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtylty/subscriptions","organizations_url":"https://api.github.com/users/mtylty/orgs","repos_url":"https://api.github.com/users/mtylty/repos","events_url":"https://api.github.com/users/mtylty/events{/privacy}","received_events_url":"https://api.github.com/users/mtylty/received_events","type":"User","site_admin":false},"body":"Add `Spree::Config.search_filter_presenter_class` configuration variable\r\nso that product filters (those that use the searcher_class to filter\r\nproduct results) are more configurable.\r\n\r\nThis makes filtering more configurable because:\r\n\r\n* `Spree::Config.search_filter_presenter_class` can be used to define which\r\nfilters are presented on the view;\r\n\r\n* The `partial_path` class method can be used to define which partial is\r\nrendered by the above views so that custom view logic can be implemented\r\ndepending on the `searcher_class` and `search_filter_presenter_class`\r\nconfigurations.\r\n\r\nI've made this PR as a proof-of-concept for what I think the product\r\nfiltering should look like in future releases.\r\n\r\nWhat's your opinion on this?","created_at":"2016-05-16T15:22:40Z","updated_at":"2016-05-18T21:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c0eaa4545060cf12db3e2a820fbabb96484dcbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1151/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1151/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1151/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/1410c64a77424d0a91464e49533a8bae7ce50667","head":{"label":"nebulab:add-search-filter-class","ref":"add-search-filter-class","sha":"1410c64a77424d0a91464e49533a8bae7ce50667","user":{"login":"nebulab","id":809406,"avatar_url":"https://avatars.githubusercontent.com/u/809406?v=3","gravatar_id":"","url":"https://api.github.com/users/nebulab","html_url":"https://github.com/nebulab","followers_url":"https://api.github.com/users/nebulab/followers","following_url":"https://api.github.com/users/nebulab/following{/other_user}","gists_url":"https://api.github.com/users/nebulab/gists{/gist_id}","starred_url":"https://api.github.com/users/nebulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebulab/subscriptions","organizations_url":"https://api.github.com/users/nebulab/orgs","repos_url":"https://api.github.com/users/nebulab/repos","events_url":"https://api.github.com/users/nebulab/events{/privacy}","received_events_url":"https://api.github.com/users/nebulab/received_events","type":"Organization","site_admin":false},"repo":{"id":58404218,"name":"solidus","full_name":"nebulab/solidus","owner":{"login":"nebulab","id":809406,"avatar_url":"https://avatars.githubusercontent.com/u/809406?v=3","gravatar_id":"","url":"https://api.github.com/users/nebulab","html_url":"https://github.com/nebulab","followers_url":"https://api.github.com/users/nebulab/followers","following_url":"https://api.github.com/users/nebulab/following{/other_user}","gists_url":"https://api.github.com/users/nebulab/gists{/gist_id}","starred_url":"https://api.github.com/users/nebulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebulab/subscriptions","organizations_url":"https://api.github.com/users/nebulab/orgs","repos_url":"https://api.github.com/users/nebulab/repos","events_url":"https://api.github.com/users/nebulab/events{/privacy}","received_events_url":"https://api.github.com/users/nebulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nebulab/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/nebulab/solidus","forks_url":"https://api.github.com/repos/nebulab/solidus/forks","keys_url":"https://api.github.com/repos/nebulab/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nebulab/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nebulab/solidus/teams","hooks_url":"https://api.github.com/repos/nebulab/solidus/hooks","issue_events_url":"https://api.github.com/repos/nebulab/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/nebulab/solidus/events","assignees_url":"https://api.github.com/repos/nebulab/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/nebulab/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/nebulab/solidus/tags","blobs_url":"https://api.github.com/repos/nebulab/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nebulab/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nebulab/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/nebulab/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nebulab/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/nebulab/solidus/languages","stargazers_url":"https://api.github.com/repos/nebulab/solidus/stargazers","contributors_url":"https://api.github.com/repos/nebulab/solidus/contributors","subscribers_url":"https://api.github.com/repos/nebulab/solidus/subscribers","subscription_url":"https://api.github.com/repos/nebulab/solidus/subscription","commits_url":"https://api.github.com/repos/nebulab/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/nebulab/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/nebulab/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/nebulab/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/nebulab/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/nebulab/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nebulab/solidus/merges","archive_url":"https://api.github.com/repos/nebulab/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nebulab/solidus/downloads","issues_url":"https://api.github.com/repos/nebulab/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/nebulab/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/nebulab/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/nebulab/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nebulab/solidus/labels{/name}","releases_url":"https://api.github.com/repos/nebulab/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/nebulab/solidus/deployments","created_at":"2016-05-09T20:00:17Z","updated_at":"2016-05-09T20:00:21Z","pushed_at":"2016-05-18T16:36:29Z","git_url":"git://github.com/nebulab/solidus.git","ssh_url":"git@github.com:nebulab/solidus.git","clone_url":"https://github.com/nebulab/solidus.git","svn_url":"https://github.com/nebulab/solidus","homepage":"http://solidus.io/","size":63007,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"fdad15b2b223a596e3b475de686d391e1ce33216","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-05-17T18:11:46Z","pushed_at":"2016-05-18T21:14:59Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":69130,"stargazers_count":928,"watchers_count":928,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":118,"forks":256,"open_issues":118,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1151"},"html":{"href":"https://github.com/solidusio/solidus/pull/1151"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1151"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1151/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1151/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1151/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/1410c64a77424d0a91464e49533a8bae7ce50667"}}}}