{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/nyxtom/dive/pulls/5","id":57441982,"html_url":"https://github.com/nyxtom/dive/pull/5","diff_url":"https://github.com/nyxtom/dive/pull/5.diff","patch_url":"https://github.com/nyxtom/dive/pull/5.patch","issue_url":"https://api.github.com/repos/nyxtom/dive/issues/5","number":5,"state":"open","locked":false,"title":"Ndl","user":{"login":"archisgore","id":1592418,"avatar_url":"https://avatars.githubusercontent.com/u/1592418?v=3","gravatar_id":"","url":"https://api.github.com/users/archisgore","html_url":"https://github.com/archisgore","followers_url":"https://api.github.com/users/archisgore/followers","following_url":"https://api.github.com/users/archisgore/following{/other_user}","gists_url":"https://api.github.com/users/archisgore/gists{/gist_id}","starred_url":"https://api.github.com/users/archisgore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archisgore/subscriptions","organizations_url":"https://api.github.com/users/archisgore/orgs","repos_url":"https://api.github.com/users/archisgore/repos","events_url":"https://api.github.com/users/archisgore/events{/privacy}","received_events_url":"https://api.github.com/users/archisgore/received_events","type":"User","site_admin":false},"body":"This fixes a few things:\r\n1. Changed signature of schreinerEquation to match that of instantaneousEquation.\r\n2. addDepthChange == addFlat when rate of change is zero. So reuse more code (and tested that numbers match precisely.)\r\n3. Fixed all tests and added guards in NDL/Deco calculations such that there's no infinite loops (for example NDL on 50% to 10ft would be virtually limitless. Guards prevent infinite loops.)","created_at":"2016-01-27T23:43:24Z","updated_at":"2016-01-27T23:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nyxtom/dive/pulls/5/commits","review_comments_url":"https://api.github.com/repos/nyxtom/dive/pulls/5/comments","review_comment_url":"https://api.github.com/repos/nyxtom/dive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nyxtom/dive/issues/5/comments","statuses_url":"https://api.github.com/repos/nyxtom/dive/statuses/9e17f55a06f4b0a23da909e7cf33c1a200b800ec","head":{"label":"nyxtom:ndl","ref":"ndl","sha":"9e17f55a06f4b0a23da909e7cf33c1a200b800ec","user":{"login":"nyxtom","id":222763,"avatar_url":"https://avatars.githubusercontent.com/u/222763?v=3","gravatar_id":"","url":"https://api.github.com/users/nyxtom","html_url":"https://github.com/nyxtom","followers_url":"https://api.github.com/users/nyxtom/followers","following_url":"https://api.github.com/users/nyxtom/following{/other_user}","gists_url":"https://api.github.com/users/nyxtom/gists{/gist_id}","starred_url":"https://api.github.com/users/nyxtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyxtom/subscriptions","organizations_url":"https://api.github.com/users/nyxtom/orgs","repos_url":"https://api.github.com/users/nyxtom/repos","events_url":"https://api.github.com/users/nyxtom/events{/privacy}","received_events_url":"https://api.github.com/users/nyxtom/received_events","type":"User","site_admin":false},"repo":{"id":7883914,"name":"dive","full_name":"nyxtom/dive","owner":{"login":"nyxtom","id":222763,"avatar_url":"https://avatars.githubusercontent.com/u/222763?v=3","gravatar_id":"","url":"https://api.github.com/users/nyxtom","html_url":"https://github.com/nyxtom","followers_url":"https://api.github.com/users/nyxtom/followers","following_url":"https://api.github.com/users/nyxtom/following{/other_user}","gists_url":"https://api.github.com/users/nyxtom/gists{/gist_id}","starred_url":"https://api.github.com/users/nyxtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyxtom/subscriptions","organizations_url":"https://api.github.com/users/nyxtom/orgs","repos_url":"https://api.github.com/users/nyxtom/repos","events_url":"https://api.github.com/users/nyxtom/events{/privacy}","received_events_url":"https://api.github.com/users/nyxtom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyxtom/dive","description":"Various standard scuba diving algorithms, formulas, calculations and device management.","fork":false,"url":"https://api.github.com/repos/nyxtom/dive","forks_url":"https://api.github.com/repos/nyxtom/dive/forks","keys_url":"https://api.github.com/repos/nyxtom/dive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyxtom/dive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyxtom/dive/teams","hooks_url":"https://api.github.com/repos/nyxtom/dive/hooks","issue_events_url":"https://api.github.com/repos/nyxtom/dive/issues/events{/number}","events_url":"https://api.github.com/repos/nyxtom/dive/events","assignees_url":"https://api.github.com/repos/nyxtom/dive/assignees{/user}","branches_url":"https://api.github.com/repos/nyxtom/dive/branches{/branch}","tags_url":"https://api.github.com/repos/nyxtom/dive/tags","blobs_url":"https://api.github.com/repos/nyxtom/dive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyxtom/dive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyxtom/dive/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyxtom/dive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyxtom/dive/statuses/{sha}","languages_url":"https://api.github.com/repos/nyxtom/dive/languages","stargazers_url":"https://api.github.com/repos/nyxtom/dive/stargazers","contributors_url":"https://api.github.com/repos/nyxtom/dive/contributors","subscribers_url":"https://api.github.com/repos/nyxtom/dive/subscribers","subscription_url":"https://api.github.com/repos/nyxtom/dive/subscription","commits_url":"https://api.github.com/repos/nyxtom/dive/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyxtom/dive/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyxtom/dive/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyxtom/dive/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyxtom/dive/contents/{+path}","compare_url":"https://api.github.com/repos/nyxtom/dive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyxtom/dive/merges","archive_url":"https://api.github.com/repos/nyxtom/dive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyxtom/dive/downloads","issues_url":"https://api.github.com/repos/nyxtom/dive/issues{/number}","pulls_url":"https://api.github.com/repos/nyxtom/dive/pulls{/number}","milestones_url":"https://api.github.com/repos/nyxtom/dive/milestones{/number}","notifications_url":"https://api.github.com/repos/nyxtom/dive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyxtom/dive/labels{/name}","releases_url":"https://api.github.com/repos/nyxtom/dive/releases{/id}","deployments_url":"https://api.github.com/repos/nyxtom/dive/deployments","created_at":"2013-01-29T02:45:41Z","updated_at":"2016-01-27T01:29:44Z","pushed_at":"2016-01-27T23:41:45Z","git_url":"git://github.com/nyxtom/dive.git","ssh_url":"git@github.com:nyxtom/dive.git","clone_url":"https://github.com/nyxtom/dive.git","svn_url":"https://github.com/nyxtom/dive","homepage":"","size":85,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"nyxtom:master","ref":"master","sha":"e48d808648cbb6a1a75cfaf3d78c8c5b66cacaaf","user":{"login":"nyxtom","id":222763,"avatar_url":"https://avatars.githubusercontent.com/u/222763?v=3","gravatar_id":"","url":"https://api.github.com/users/nyxtom","html_url":"https://github.com/nyxtom","followers_url":"https://api.github.com/users/nyxtom/followers","following_url":"https://api.github.com/users/nyxtom/following{/other_user}","gists_url":"https://api.github.com/users/nyxtom/gists{/gist_id}","starred_url":"https://api.github.com/users/nyxtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyxtom/subscriptions","organizations_url":"https://api.github.com/users/nyxtom/orgs","repos_url":"https://api.github.com/users/nyxtom/repos","events_url":"https://api.github.com/users/nyxtom/events{/privacy}","received_events_url":"https://api.github.com/users/nyxtom/received_events","type":"User","site_admin":false},"repo":{"id":7883914,"name":"dive","full_name":"nyxtom/dive","owner":{"login":"nyxtom","id":222763,"avatar_url":"https://avatars.githubusercontent.com/u/222763?v=3","gravatar_id":"","url":"https://api.github.com/users/nyxtom","html_url":"https://github.com/nyxtom","followers_url":"https://api.github.com/users/nyxtom/followers","following_url":"https://api.github.com/users/nyxtom/following{/other_user}","gists_url":"https://api.github.com/users/nyxtom/gists{/gist_id}","starred_url":"https://api.github.com/users/nyxtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyxtom/subscriptions","organizations_url":"https://api.github.com/users/nyxtom/orgs","repos_url":"https://api.github.com/users/nyxtom/repos","events_url":"https://api.github.com/users/nyxtom/events{/privacy}","received_events_url":"https://api.github.com/users/nyxtom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyxtom/dive","description":"Various standard scuba diving algorithms, formulas, calculations and device management.","fork":false,"url":"https://api.github.com/repos/nyxtom/dive","forks_url":"https://api.github.com/repos/nyxtom/dive/forks","keys_url":"https://api.github.com/repos/nyxtom/dive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyxtom/dive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyxtom/dive/teams","hooks_url":"https://api.github.com/repos/nyxtom/dive/hooks","issue_events_url":"https://api.github.com/repos/nyxtom/dive/issues/events{/number}","events_url":"https://api.github.com/repos/nyxtom/dive/events","assignees_url":"https://api.github.com/repos/nyxtom/dive/assignees{/user}","branches_url":"https://api.github.com/repos/nyxtom/dive/branches{/branch}","tags_url":"https://api.github.com/repos/nyxtom/dive/tags","blobs_url":"https://api.github.com/repos/nyxtom/dive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyxtom/dive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyxtom/dive/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyxtom/dive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyxtom/dive/statuses/{sha}","languages_url":"https://api.github.com/repos/nyxtom/dive/languages","stargazers_url":"https://api.github.com/repos/nyxtom/dive/stargazers","contributors_url":"https://api.github.com/repos/nyxtom/dive/contributors","subscribers_url":"https://api.github.com/repos/nyxtom/dive/subscribers","subscription_url":"https://api.github.com/repos/nyxtom/dive/subscription","commits_url":"https://api.github.com/repos/nyxtom/dive/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyxtom/dive/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyxtom/dive/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyxtom/dive/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyxtom/dive/contents/{+path}","compare_url":"https://api.github.com/repos/nyxtom/dive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyxtom/dive/merges","archive_url":"https://api.github.com/repos/nyxtom/dive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyxtom/dive/downloads","issues_url":"https://api.github.com/repos/nyxtom/dive/issues{/number}","pulls_url":"https://api.github.com/repos/nyxtom/dive/pulls{/number}","milestones_url":"https://api.github.com/repos/nyxtom/dive/milestones{/number}","notifications_url":"https://api.github.com/repos/nyxtom/dive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyxtom/dive/labels{/name}","releases_url":"https://api.github.com/repos/nyxtom/dive/releases{/id}","deployments_url":"https://api.github.com/repos/nyxtom/dive/deployments","created_at":"2013-01-29T02:45:41Z","updated_at":"2016-01-27T01:29:44Z","pushed_at":"2016-01-27T23:41:45Z","git_url":"git://github.com/nyxtom/dive.git","ssh_url":"git@github.com:nyxtom/dive.git","clone_url":"https://github.com/nyxtom/dive.git","svn_url":"https://github.com/nyxtom/dive","homepage":"","size":85,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nyxtom/dive/pulls/5"},"html":{"href":"https://github.com/nyxtom/dive/pull/5"},"issue":{"href":"https://api.github.com/repos/nyxtom/dive/issues/5"},"comments":{"href":"https://api.github.com/repos/nyxtom/dive/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/nyxtom/dive/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/nyxtom/dive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nyxtom/dive/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/nyxtom/dive/statuses/9e17f55a06f4b0a23da909e7cf33c1a200b800ec"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":298,"deletions":94,"changed_files":5}}