{"action":"created","comment":{"url":"https://api.github.com/repos/adelbertc/frameless/pulls/comments/83560707","pull_request_review_id":4397058,"id":83560707,"diff_hunk":"@@ -19,6 +19,8 @@ object FramelessInternals {\n \n   def expr(column: Column): Expression = column.expr\n \n+  def column(column: Column): Expression = column.expr","path":"dataset/src/main/scala/org/apache/spark/sql/FramelessInternals.scala","position":4,"original_position":4,"commit_id":"1cad49649cbf10661efb48e9a572621b5491c7e4","original_commit_id":"1cad49649cbf10661efb48e9a572621b5491c7e4","user":{"login":"OlivierBlanvillain","id":1085297,"avatar_url":"https://avatars.githubusercontent.com/u/1085297?v=3","gravatar_id":"","url":"https://api.github.com/users/OlivierBlanvillain","html_url":"https://github.com/OlivierBlanvillain","followers_url":"https://api.github.com/users/OlivierBlanvillain/followers","following_url":"https://api.github.com/users/OlivierBlanvillain/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBlanvillain/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBlanvillain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBlanvillain/subscriptions","organizations_url":"https://api.github.com/users/OlivierBlanvillain/orgs","repos_url":"https://api.github.com/users/OlivierBlanvillain/repos","events_url":"https://api.github.com/users/OlivierBlanvillain/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBlanvillain/received_events","type":"User","site_admin":false},"body":"Do we need both `expr` & `column`?","created_at":"2016-10-16T21:27:05Z","updated_at":"2016-10-16T21:30:58Z","html_url":"https://github.com/adelbertc/frameless/pull/55#discussion_r83560707","pull_request_url":"https://api.github.com/repos/adelbertc/frameless/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/comments/83560707"},"html":{"href":"https://github.com/adelbertc/frameless/pull/55#discussion_r83560707"},"pull_request":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/adelbertc/frameless/pulls/55","id":89526436,"html_url":"https://github.com/adelbertc/frameless/pull/55","diff_url":"https://github.com/adelbertc/frameless/pull/55.diff","patch_url":"https://github.com/adelbertc/frameless/pull/55.patch","issue_url":"https://api.github.com/repos/adelbertc/frameless/issues/55","number":55,"state":"open","locked":false,"title":"Fix column names","user":{"login":"kanterov","id":467927,"avatar_url":"https://avatars.githubusercontent.com/u/467927?v=3","gravatar_id":"","url":"https://api.github.com/users/kanterov","html_url":"https://github.com/kanterov","followers_url":"https://api.github.com/users/kanterov/followers","following_url":"https://api.github.com/users/kanterov/following{/other_user}","gists_url":"https://api.github.com/users/kanterov/gists{/gist_id}","starred_url":"https://api.github.com/users/kanterov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanterov/subscriptions","organizations_url":"https://api.github.com/users/kanterov/orgs","repos_url":"https://api.github.com/users/kanterov/repos","events_url":"https://api.github.com/users/kanterov/events{/privacy}","received_events_url":"https://api.github.com/users/kanterov/received_events","type":"User","site_admin":false},"body":"Column names as seen by frameless, and as done as Spark were different.\r\nThis caused varienty issues with safe column referencing. Now we keep\r\nthis invariant by renaming columns if we find difference in derived vs.\r\nactual schema.","created_at":"2016-10-16T13:55:01Z","updated_at":"2016-10-16T21:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd843960414f225156bf0662388e03445f6d3cd8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adelbertc/frameless/pulls/55/commits","review_comments_url":"https://api.github.com/repos/adelbertc/frameless/pulls/55/comments","review_comment_url":"https://api.github.com/repos/adelbertc/frameless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adelbertc/frameless/issues/55/comments","statuses_url":"https://api.github.com/repos/adelbertc/frameless/statuses/1cad49649cbf10661efb48e9a572621b5491c7e4","head":{"label":"adelbertc:fix-column-names","ref":"fix-column-names","sha":"1cad49649cbf10661efb48e9a572621b5491c7e4","user":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"repo":{"id":33022955,"name":"frameless","full_name":"adelbertc/frameless","owner":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adelbertc/frameless","description":"Expressive types for Spark.","fork":false,"url":"https://api.github.com/repos/adelbertc/frameless","forks_url":"https://api.github.com/repos/adelbertc/frameless/forks","keys_url":"https://api.github.com/repos/adelbertc/frameless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adelbertc/frameless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adelbertc/frameless/teams","hooks_url":"https://api.github.com/repos/adelbertc/frameless/hooks","issue_events_url":"https://api.github.com/repos/adelbertc/frameless/issues/events{/number}","events_url":"https://api.github.com/repos/adelbertc/frameless/events","assignees_url":"https://api.github.com/repos/adelbertc/frameless/assignees{/user}","branches_url":"https://api.github.com/repos/adelbertc/frameless/branches{/branch}","tags_url":"https://api.github.com/repos/adelbertc/frameless/tags","blobs_url":"https://api.github.com/repos/adelbertc/frameless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adelbertc/frameless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adelbertc/frameless/git/refs{/sha}","trees_url":"https://api.github.com/repos/adelbertc/frameless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adelbertc/frameless/statuses/{sha}","languages_url":"https://api.github.com/repos/adelbertc/frameless/languages","stargazers_url":"https://api.github.com/repos/adelbertc/frameless/stargazers","contributors_url":"https://api.github.com/repos/adelbertc/frameless/contributors","subscribers_url":"https://api.github.com/repos/adelbertc/frameless/subscribers","subscription_url":"https://api.github.com/repos/adelbertc/frameless/subscription","commits_url":"https://api.github.com/repos/adelbertc/frameless/commits{/sha}","git_commits_url":"https://api.github.com/repos/adelbertc/frameless/git/commits{/sha}","comments_url":"https://api.github.com/repos/adelbertc/frameless/comments{/number}","issue_comment_url":"https://api.github.com/repos/adelbertc/frameless/issues/comments{/number}","contents_url":"https://api.github.com/repos/adelbertc/frameless/contents/{+path}","compare_url":"https://api.github.com/repos/adelbertc/frameless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adelbertc/frameless/merges","archive_url":"https://api.github.com/repos/adelbertc/frameless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adelbertc/frameless/downloads","issues_url":"https://api.github.com/repos/adelbertc/frameless/issues{/number}","pulls_url":"https://api.github.com/repos/adelbertc/frameless/pulls{/number}","milestones_url":"https://api.github.com/repos/adelbertc/frameless/milestones{/number}","notifications_url":"https://api.github.com/repos/adelbertc/frameless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adelbertc/frameless/labels{/name}","releases_url":"https://api.github.com/repos/adelbertc/frameless/releases{/id}","deployments_url":"https://api.github.com/repos/adelbertc/frameless/deployments","created_at":"2015-03-28T06:03:10Z","updated_at":"2016-10-13T11:15:06Z","pushed_at":"2016-10-16T13:55:01Z","git_url":"git://github.com/adelbertc/frameless.git","ssh_url":"git@github.com:adelbertc/frameless.git","clone_url":"https://github.com/adelbertc/frameless.git","svn_url":"https://github.com/adelbertc/frameless","homepage":"","size":289,"stargazers_count":107,"watchers_count":107,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":13,"forks":11,"open_issues":13,"watchers":107,"default_branch":"master"}},"base":{"label":"adelbertc:master","ref":"master","sha":"dae65268ea4dbfdba1b25b6ac51b506de33d229c","user":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"repo":{"id":33022955,"name":"frameless","full_name":"adelbertc/frameless","owner":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adelbertc/frameless","description":"Expressive types for Spark.","fork":false,"url":"https://api.github.com/repos/adelbertc/frameless","forks_url":"https://api.github.com/repos/adelbertc/frameless/forks","keys_url":"https://api.github.com/repos/adelbertc/frameless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adelbertc/frameless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adelbertc/frameless/teams","hooks_url":"https://api.github.com/repos/adelbertc/frameless/hooks","issue_events_url":"https://api.github.com/repos/adelbertc/frameless/issues/events{/number}","events_url":"https://api.github.com/repos/adelbertc/frameless/events","assignees_url":"https://api.github.com/repos/adelbertc/frameless/assignees{/user}","branches_url":"https://api.github.com/repos/adelbertc/frameless/branches{/branch}","tags_url":"https://api.github.com/repos/adelbertc/frameless/tags","blobs_url":"https://api.github.com/repos/adelbertc/frameless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adelbertc/frameless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adelbertc/frameless/git/refs{/sha}","trees_url":"https://api.github.com/repos/adelbertc/frameless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adelbertc/frameless/statuses/{sha}","languages_url":"https://api.github.com/repos/adelbertc/frameless/languages","stargazers_url":"https://api.github.com/repos/adelbertc/frameless/stargazers","contributors_url":"https://api.github.com/repos/adelbertc/frameless/contributors","subscribers_url":"https://api.github.com/repos/adelbertc/frameless/subscribers","subscription_url":"https://api.github.com/repos/adelbertc/frameless/subscription","commits_url":"https://api.github.com/repos/adelbertc/frameless/commits{/sha}","git_commits_url":"https://api.github.com/repos/adelbertc/frameless/git/commits{/sha}","comments_url":"https://api.github.com/repos/adelbertc/frameless/comments{/number}","issue_comment_url":"https://api.github.com/repos/adelbertc/frameless/issues/comments{/number}","contents_url":"https://api.github.com/repos/adelbertc/frameless/contents/{+path}","compare_url":"https://api.github.com/repos/adelbertc/frameless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adelbertc/frameless/merges","archive_url":"https://api.github.com/repos/adelbertc/frameless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adelbertc/frameless/downloads","issues_url":"https://api.github.com/repos/adelbertc/frameless/issues{/number}","pulls_url":"https://api.github.com/repos/adelbertc/frameless/pulls{/number}","milestones_url":"https://api.github.com/repos/adelbertc/frameless/milestones{/number}","notifications_url":"https://api.github.com/repos/adelbertc/frameless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adelbertc/frameless/labels{/name}","releases_url":"https://api.github.com/repos/adelbertc/frameless/releases{/id}","deployments_url":"https://api.github.com/repos/adelbertc/frameless/deployments","created_at":"2015-03-28T06:03:10Z","updated_at":"2016-10-13T11:15:06Z","pushed_at":"2016-10-16T13:55:01Z","git_url":"git://github.com/adelbertc/frameless.git","ssh_url":"git@github.com:adelbertc/frameless.git","clone_url":"https://github.com/adelbertc/frameless.git","svn_url":"https://github.com/adelbertc/frameless","homepage":"","size":289,"stargazers_count":107,"watchers_count":107,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":13,"forks":11,"open_issues":13,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/55"},"html":{"href":"https://github.com/adelbertc/frameless/pull/55"},"issue":{"href":"https://api.github.com/repos/adelbertc/frameless/issues/55"},"comments":{"href":"https://api.github.com/repos/adelbertc/frameless/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/adelbertc/frameless/statuses/1cad49649cbf10661efb48e9a572621b5491c7e4"}}}}
{"actor":{"display_login":"OlivierBlanvillain"}}