{"push_id":1281796633,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"228c2509e5141c88edd5505d4866ab3b9d8494e2","before":"7b6d2b03d03f325b6a6e2917b7c116d2d426b904","commits":[{"sha":"b8c8103fd4146396a6686d64ea9d75c953f3cabd","author":{"name":"Todd Fiala","email":"b0a4f434e2135c40e9cf11e58196c377094d818f@gmail.com"},"message":"[NFC] Darwin llgs support from Week of Code\n\nThis code represents the Week of Code work I did on bringing up\nlldb-server LLGS support for Darwin.  It does not include the\nXcode project changes needed, as we don't want to throw that switch\nuntil more support is implemented (i.e. this change is inert, no\nbuild systems use it yet.  I've verified on Ubuntu 16.04, macOS\nXcode and macOS cmake builds).\n\nThis change does some minimal refactoring of code that is shared\nwith the Linux LLGS portion, moving it from NativeProcessLinux into\nNativeProcessProtocol.  That code is also used by NativeProcessDarwin.\n\nCurrent state on Darwin:\n* Process launching is implemented.  (Attach is not).\n  Launching on devices has not yet been tested (FBS/BKS might\n  need a bit of work).\n* Inferior waitpid monitoring and communication of exit status\n  via MainLoop callback is implemented.\n* Memory read/write, breakpoints, thread register context, etc.\n  are not yet implemented.  This impacts process stop/resume, as\n  the initial launch suspended immediately starts the process\n  up and running because it doesn't know it is supposed to remain\n  stopped.\n* I implemented the equivalent of MachThreadList as\n  NativeThreadListDarwin, in anticipation that we might want to\n  factor out common parts into NativeThreadList{Protocol} and share\n  some code here.  After writing it, though, the fallout from merging\n  Mach Task/Process into a single concept plus some other minor\n  changes makes the whole NativeThreadListDarwin concept nothing more\n  than dead weight.  I am likely going to get rid of this class and\n  just manage it directly in NativeProcessDarwin, much like I did\n  for NativeProcessLinux.\n* There is a stub-out call for starting a STDIO thread.  That will\n  go away and adopt the MainLoop pselect-based IOObject reading.\n\nI am developing the fully-integrated changes in the following repo,\nwhich contains the necessary Xcode bits and the glue that enables\nlldb-debugserver on a macOS system:\n\n  https://github.com/tfiala/lldb/tree/llgs-darwin\n\nThis change also breaks out a few of the lldb-server tests into\ntheir own directory, and adds some $qHostInfo tests (not sure why\nI didn't write those tests back when I initially implemented that\non the Linux side).\n\ngit-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@280604 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/lldb/commits/b8c8103fd4146396a6686d64ea9d75c953f3cabd"},{"sha":"228c2509e5141c88edd5505d4866ab3b9d8494e2","author":{"name":"Todd Fiala","email":"b0a4f434e2135c40e9cf11e58196c377094d818f@gmail.com"},"message":"XFAIL TestGdbRemoteExitCode failing tests\n\nTracked by:\nllvm.org/pr30271\n\ngit-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@280606 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/kraj/lldb/commits/228c2509e5141c88edd5505d4866ab3b9d8494e2"}]}
{"actor":{"display_login":"kraj"}}