{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/82763899","pull_request_review_id":3647579,"id":82763899,"diff_hunk":"@@ -0,0 +1,102 @@\n+/**\n+ * \\copyright\n+ * Copyright (c) 2012-2016, OpenGeoSys Community (http://www.opengeosys.org)\n+ *            Distributed under a Modified BSD License.\n+ *              See accompanying file LICENSE.txt or\n+ *              http://www.opengeosys.org/project/license\n+ *\n+ * \\file   LiquidFlowProcess.h\n+ *\n+ * Created on August 19, 2016, 1:38 PM\n+ */\n+\n+#ifndef OGS_LIQUIDFLOWPROCESS_H\n+#define OGS_LIQUIDFLOWPROCESS_H\n+\n+#include \"NumLib/DOF/LocalToGlobalIndexMap.h\"\n+#include \"ProcessLib/Process.h\"\n+\n+#include \"LiquidFlowMaterialProperties.h\"\n+#include \"LiquidFlowLocalAssembler.h\"\n+\n+namespace MeshLib\n+{\n+class Element;\n+class Mesh;\n+template <typename PROP_VAL_TYPE>\n+class PropertyVector;\n+}\n+\n+namespace ProcessLib\n+{\n+namespace LiquidFlow\n+{\n+/**\n+ * \\brief A class to simulate the liquid flow process in porous media described\n+ * by\n+ *\n+ * \\f[\n+ *     \\frac{\\partial n \\rho_l}{\\partial T} \\frac{\\partial T}{\\partial t}/\\rho_l\n+ *       + (\\frac{\\partial n \\rho_l}{\\partial p}/\\rho_l + \\beta_s)\n+ *          \\frac{\\partial p}{\\partial t}\n+ *       -\\nabla (\\frac{K}{\\mu}(\\nabla p + \\rho_l g \\nabla z) ) = Q\n+ * \\f]\n+ * where\n+ *    \\f{eqnarray*}{\n+ *       &p:&        \\mbox{pore pressure,}\\\\\n+ *       &T: &       \\mbox{Temperature,}\\\\\n+ *       &\\rho_l:&   \\mbox{liquid density,}\\\\\n+ *       &\\beta_s:&  \\mbox{specific storage,}\\\\\n+ *       &K:&        \\mbox{permeability,}\\\\\n+ *       &\\mu:&      \\mbox{viscosity,}\\\\\n+ *    \\f}\n+ */\n+class LiquidFlowProcess final : public Process\n+{\n+public:\n+    LiquidFlowProcess(\n+        MeshLib::Mesh& mesh,\n+        std::unique_ptr<AbstractJacobianAssembler>&& jacobian_assembler,\n+        std::vector<std::unique_ptr<ParameterBase>> const& parameters,\n+        unsigned const integration_order,\n+        std::vector<std::reference_wrapper<ProcessVariable>>&&\n+            process_variables,\n+        SecondaryVariableCollection&& secondary_variables,\n+        NumLib::NamedFunctionCaller&& named_function_caller,\n+        const bool compute_gravitational_term,\n+        BaseLib::ConfigTree const& config);\n+\n+    void preTimestepConcreteProcess(GlobalVector const& x, const double t,\n+                                    const double delta_t) override;\n+\n+    void preIterationConcreteProcess(const unsigned iter,\n+                                     GlobalVector const& x) override;\n+\n+    bool isLinear() const override { return true; }\n+private:\n+    void initializeConcreteProcess(\n+        NumLib::LocalToGlobalIndexMap const& dof_table,\n+        MeshLib::Mesh const& mesh, unsigned const integration_order) override;\n+\n+    void assembleConcreteProcess(const double t, GlobalVector const& x,\n+                                 GlobalMatrix& M, GlobalMatrix& K,\n+                                 GlobalVector& b) override;\n+\n+    void assembleWithJacobianConcreteProcess(\n+        const double t, GlobalVector const& x, GlobalVector const& xdot,\n+        const double dxdot_dx, const double dx_dx, GlobalMatrix& M,\n+        GlobalMatrix& K, GlobalVector& b, GlobalMatrix& Jac) override;\n+\n+    const bool _compute_gravitational_term;\n+    LiquidFlowMaterialProperties _material_properties;\n+\n+    std::vector<std::unique_ptr<LiquidFlowLocalAssemblerInterface>>\n+        _local_assemblers;\n+\n+    std::unique_ptr<GlobalVector> _p_previous_timestep;","path":"ProcessLib/LiquidFlow/LiquidFlowProcess.h","position":null,"original_position":96,"commit_id":"542b006a6c849c47d30b63834e89bc52b4074008","original_commit_id":"b8f08f7bfaa978f56d9b99931496d6e07234786e","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"Removed.","created_at":"2016-10-11T10:19:39Z","updated_at":"2016-10-11T10:19:39Z","html_url":"https://github.com/ufz/ogs/pull/1468#discussion_r82763899","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1468","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/82763899"},"html":{"href":"https://github.com/ufz/ogs/pull/1468#discussion_r82763899"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1468"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1468","id":88275116,"html_url":"https://github.com/ufz/ogs/pull/1468","diff_url":"https://github.com/ufz/ogs/pull/1468.diff","patch_url":"https://github.com/ufz/ogs/pull/1468.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1468","number":1468,"state":"open","locked":false,"title":"Liquid flow process","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"Added classes for modelling liquid flow process based on the previous implementations about fluid and porous medium properties. The implementation is verified with the following\r\n~~three~~ four tests from OGS5:\r\n- LineDirichletNeumannBC  ~~sat1D~~\r\n- PressureBCatCornerOfHeterogeneousSquare ~~sat2D~~\r\n- GravityDriven\r\n- AxiSymTheis (with axisymmetry)\r\n\r\nIn the current ogs6/master, the calculations of velocity and flux were implemented in wrong places for groundwater, heat conduction. A PR about the correction of such calculations for all non-deformation processes comes immediately once this one is merged.  \r\n","created_at":"2016-10-06T14:39:58Z","updated_at":"2016-10-11T10:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74f5b1808505376e7f4f3658f72c510822cad170","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1468/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1468/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1468/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/542b006a6c849c47d30b63834e89bc52b4074008","head":{"label":"wenqing:liquid_pcs","ref":"liquid_pcs","sha":"542b006a6c849c47d30b63834e89bc52b4074008","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"repo":{"id":12785911,"name":"ogs","full_name":"wenqing/ogs","owner":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wenqing/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/wenqing/ogs","forks_url":"https://api.github.com/repos/wenqing/ogs/forks","keys_url":"https://api.github.com/repos/wenqing/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wenqing/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wenqing/ogs/teams","hooks_url":"https://api.github.com/repos/wenqing/ogs/hooks","issue_events_url":"https://api.github.com/repos/wenqing/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/wenqing/ogs/events","assignees_url":"https://api.github.com/repos/wenqing/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/wenqing/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/wenqing/ogs/tags","blobs_url":"https://api.github.com/repos/wenqing/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wenqing/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wenqing/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wenqing/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wenqing/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/wenqing/ogs/languages","stargazers_url":"https://api.github.com/repos/wenqing/ogs/stargazers","contributors_url":"https://api.github.com/repos/wenqing/ogs/contributors","subscribers_url":"https://api.github.com/repos/wenqing/ogs/subscribers","subscription_url":"https://api.github.com/repos/wenqing/ogs/subscription","commits_url":"https://api.github.com/repos/wenqing/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wenqing/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wenqing/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wenqing/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wenqing/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/wenqing/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wenqing/ogs/merges","archive_url":"https://api.github.com/repos/wenqing/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wenqing/ogs/downloads","issues_url":"https://api.github.com/repos/wenqing/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/wenqing/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/wenqing/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/wenqing/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wenqing/ogs/labels{/name}","releases_url":"https://api.github.com/repos/wenqing/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/wenqing/ogs/deployments","created_at":"2013-09-12T14:33:21Z","updated_at":"2015-02-25T13:44:13Z","pushed_at":"2016-10-11T10:19:29Z","git_url":"git://github.com/wenqing/ogs.git","ssh_url":"git@github.com:wenqing/ogs.git","clone_url":"https://github.com/wenqing/ogs.git","svn_url":"https://github.com/wenqing/ogs","homepage":"www.opengeosys.org","size":15876,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"70b91576d61aa6cfe6b79fbd9f1e46d78d92a8ee","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-10-10T14:28:04Z","pushed_at":"2016-10-11T10:19:30Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":20114,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":92,"forks":53,"open_issues":92,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1468"},"html":{"href":"https://github.com/ufz/ogs/pull/1468"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1468"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1468/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1468/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1468/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/542b006a6c849c47d30b63834e89bc52b4074008"}}}}
{"actor":{"display_login":"wenqing"}}