{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/image-spec/issues/504","repository_url":"https://api.github.com/repos/opencontainers/image-spec","labels_url":"https://api.github.com/repos/opencontainers/image-spec/issues/504/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/issues/504/comments","events_url":"https://api.github.com/repos/opencontainers/image-spec/issues/504/events","html_url":"https://github.com/opencontainers/image-spec/pull/504","id":196287723,"number":504,"title":"config: forbid snapshotting of data volumes","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-18T17:32:09Z","updated_at":"2016-12-21T13:10:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/504","html_url":"https://github.com/opencontainers/image-spec/pull/504","diff_url":"https://github.com/opencontainers/image-spec/pull/504.diff","patch_url":"https://github.com/opencontainers/image-spec/pull/504.patch"},"body":"This is necessary in order to make sure that unpackers all have sane\r\nbehaviour when it comes to handling image repacking and layer\r\ngeneration. Since data volumes are generally bindmounts from sources\r\nexternal to the image, it is not a good idea to snapshot said data --\r\nand thus we should forbid it.\r\n\r\nCloses #496\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>"},"comment":{"url":"https://api.github.com/repos/opencontainers/image-spec/issues/comments/268519339","html_url":"https://github.com/opencontainers/image-spec/pull/504#issuecomment-268519339","issue_url":"https://api.github.com/repos/opencontainers/image-spec/issues/504","id":268519339,"user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T13:10:10Z","updated_at":"2016-12-21T13:10:10Z","body":"@stevvooe Alright, I'll update the wording to include a note saying that `copyup` is permitted by a runtime (though I don't like that we talk about runtimes here...), just that diff generation is not permitted. The thing I don't like about this is that it's a very runtime-specific thing, and honestly I don't like how Docker has two different volume modes (`--volumes-from` and `-v`).\r\n\r\n@jonboulle Yeah, I'll add some words about it, but I won't reference the Docker docs because they specifically refer to the Docker implementation. Something like:\r\n\r\n> Data volumes are directories within the rootfs of an image which are intended to store external (possibly persistent) data in the rootfs of a container based on the image. Any changes to a data volume will not be included in further layers based off the image."}}
{"actor":{"display_login":"cyphar"}}