{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7348","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7348/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7348/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7348/events","html_url":"https://github.com/spring-projects/spring-boot/issues/7348","id":188106037,"number":7348,"title":"Use ResourceLoader when rendering asset links in thymeleaf error pages","user":{"login":"mvitz","id":563587,"avatar_url":"https://avatars.githubusercontent.com/u/563587?v=3","gravatar_id":"","url":"https://api.github.com/users/mvitz","html_url":"https://github.com/mvitz","followers_url":"https://api.github.com/users/mvitz/followers","following_url":"https://api.github.com/users/mvitz/following{/other_user}","gists_url":"https://api.github.com/users/mvitz/gists{/gist_id}","starred_url":"https://api.github.com/users/mvitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvitz/subscriptions","organizations_url":"https://api.github.com/users/mvitz/orgs","repos_url":"https://api.github.com/users/mvitz/repos","events_url":"https://api.github.com/users/mvitz/events{/privacy}","received_events_url":"https://api.github.com/users/mvitz/received_events","type":"User","site_admin":false},"labels":[{"id":293438798,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/waiting-for-triage","name":"waiting-for-triage","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-08T21:19:07Z","updated_at":"2016-11-24T11:13:32Z","closed_at":null,"body":"I'm using thymeleaf as template language for our error pages. Unfortunately when rendering links to our assets e.g. `@{/css/toolkit.css}` the calculated hash which is appended is missing.\r\n\r\nThe bug can be reproduced using the example application at https://github.com/mvitz/spring-boot-exception-handling by doing these steps:\r\n\r\n```\r\ngit clone https://github.com/mvitz/spring-boot-exception-handling\r\ncd spring-boot-exception-handling\r\nmvn spring-boot:run\r\n```\r\n\r\nWhen visiting `localhost:8080/bar` the link looks like `    <link rel=\"stylesheet\" href=\"/css/toolkit-90b322f81f9983dbd5ee8464f3e8b3db.css\" />` on `localhost:8080/foo` it looks like `    <link rel=\"stylesheet\" href=\"/css/toolkit.css\" />`"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/262751967","html_url":"https://github.com/spring-projects/spring-boot/issues/7348#issuecomment-262751967","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7348","id":262751967,"user":{"login":"bclozel","id":103264,"avatar_url":"https://avatars.githubusercontent.com/u/103264?v=3","gravatar_id":"","url":"https://api.github.com/users/bclozel","html_url":"https://github.com/bclozel","followers_url":"https://api.github.com/users/bclozel/followers","following_url":"https://api.github.com/users/bclozel/following{/other_user}","gists_url":"https://api.github.com/users/bclozel/gists{/gist_id}","starred_url":"https://api.github.com/users/bclozel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclozel/subscriptions","organizations_url":"https://api.github.com/users/bclozel/orgs","repos_url":"https://api.github.com/users/bclozel/repos","events_url":"https://api.github.com/users/bclozel/events{/privacy}","received_events_url":"https://api.github.com/users/bclozel/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T11:13:32Z","updated_at":"2016-11-24T11:13:32Z","body":"[SPR-14891](https://jira.spring.io/browse/SPR-14891) is now fixed, and I've checked that this issue is fixed once the app:\r\n* depends on Spring Framework 4.3.5.BUILD-SNAPSHOT\r\n* depends on a local Spring Boot build which changes the automatic registration of the filter\r\n\r\nShould we change all `ResourceUrlEncodingFilter` registrations to use `FilterRegistrationBean`s? Should we still apply `@ConditionalOnMissingBean(ResourceUrlEncodingFilter.class)` on those bean methods or should we adapt the conditional to something else? It seems we're using a different set of conditions when registering the Jersey filter."}}
{"actor":{"display_login":"bclozel"}}