{"action":"created","issue":{"url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/130","repository_url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration","labels_url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/130/comments","events_url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/130/events","html_url":"https://github.com/sibis-platform/ncanda-data-integration/issues/130","id":183252829,"number":130,"title":"Checking also date when creating nifit files ","user":{"login":"kipohl","id":10715920,"avatar_url":"https://avatars.githubusercontent.com/u/10715920?v=3","gravatar_id":"","url":"https://api.github.com/users/kipohl","html_url":"https://github.com/kipohl","followers_url":"https://api.github.com/users/kipohl/followers","following_url":"https://api.github.com/users/kipohl/following{/other_user}","gists_url":"https://api.github.com/users/kipohl/gists{/gist_id}","starred_url":"https://api.github.com/users/kipohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kipohl/subscriptions","organizations_url":"https://api.github.com/users/kipohl/orgs","repos_url":"https://api.github.com/users/kipohl/repos","events_url":"https://api.github.com/users/kipohl/events{/privacy}","received_events_url":"https://api.github.com/users/kipohl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sbenito","id":5200401,"avatar_url":"https://avatars.githubusercontent.com/u/5200401?v=3","gravatar_id":"","url":"https://api.github.com/users/sbenito","html_url":"https://github.com/sbenito","followers_url":"https://api.github.com/users/sbenito/followers","following_url":"https://api.github.com/users/sbenito/following{/other_user}","gists_url":"https://api.github.com/users/sbenito/gists{/gist_id}","starred_url":"https://api.github.com/users/sbenito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbenito/subscriptions","organizations_url":"https://api.github.com/users/sbenito/orgs","repos_url":"https://api.github.com/users/sbenito/repos","events_url":"https://api.github.com/users/sbenito/events{/privacy}","received_events_url":"https://api.github.com/users/sbenito/received_events","type":"User","site_admin":false},"assignees":[{"login":"sbenito","id":5200401,"avatar_url":"https://avatars.githubusercontent.com/u/5200401?v=3","gravatar_id":"","url":"https://api.github.com/users/sbenito","html_url":"https://github.com/sbenito","followers_url":"https://api.github.com/users/sbenito/followers","following_url":"https://api.github.com/users/sbenito/following{/other_user}","gists_url":"https://api.github.com/users/sbenito/gists{/gist_id}","starred_url":"https://api.github.com/users/sbenito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbenito/subscriptions","organizations_url":"https://api.github.com/users/sbenito/orgs","repos_url":"https://api.github.com/users/sbenito/repos","events_url":"https://api.github.com/users/sbenito/events{/privacy}","received_events_url":"https://api.github.com/users/sbenito/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-10-16T06:56:43Z","updated_at":"2016-10-19T17:04:12Z","closed_at":null,"body":"I also know now why when sessions are later uploaded the info is not propagated into production as make_session-nifti checks for nifti file in xnat and if it exists simply does not create the nifti. We should also check the date of the nifit vs all image sessions and if their are newer image sessions they should be uploaded . Lets create a github issue for that one\r\n"},"comment":{"url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/comments/254876567","html_url":"https://github.com/sibis-platform/ncanda-data-integration/issues/130#issuecomment-254876567","issue_url":"https://api.github.com/repos/sibis-platform/ncanda-data-integration/issues/130","id":254876567,"user":{"login":"sbenito","id":5200401,"avatar_url":"https://avatars.githubusercontent.com/u/5200401?v=3","gravatar_id":"","url":"https://api.github.com/users/sbenito","html_url":"https://github.com/sbenito","followers_url":"https://api.github.com/users/sbenito/followers","following_url":"https://api.github.com/users/sbenito/following{/other_user}","gists_url":"https://api.github.com/users/sbenito/gists{/gist_id}","starred_url":"https://api.github.com/users/sbenito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbenito/subscriptions","organizations_url":"https://api.github.com/users/sbenito/orgs","repos_url":"https://api.github.com/users/sbenito/repos","events_url":"https://api.github.com/users/sbenito/events{/privacy}","received_events_url":"https://api.github.com/users/sbenito/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T17:04:12Z","updated_at":"2016-10-19T17:04:12Z","body":"@kipohl \r\nI am looking at the code, check_new_sessions does it's job [check_new_sessions#L156](https://github.com/sibis-platform/ncanda-data-integration/blob/master/scripts/xnat/check_new_sessions#L156)\r\nThere are previous and new sessions. \r\n```python\r\n# All sessions to check - previously flagged plus updated\r\nsessions_to_check = sorted(list(set(new_sessions + previous_sessions)),\r\n                           key=lambda tupl: tupl[0])\r\n```\r\nThen this `sessions_to_check` is passed to the Main Loop,\r\n[check_new_sessions#L484](https://github.com/sibis-platform/ncanda-data-integration/blob/master/scripts/xnat/check_new_sessions#L484)\r\nAnd so, this are the sessions that finally will be evaluated to `make_session_niftis`\r\n\r\nIf it is not working properly, I should look deeper into it.\r\n"}}
{"actor":{"display_login":"sbenito"}}