{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48","id":55349724,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/48","diff_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/48.diff","patch_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/48.patch","issue_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/48","number":48,"state":"closed","locked":false,"title":"Remove unused filtering from getQualifiers","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"This gets rid of an other cloning (see #47). But this one is currently not used outside of tests.\r\n* `getFilteredSnakList` should do exactly that and not have a special case when the filter is a falsy value.\r\n* `getQualifiers` should do exactly that and not do optional filtering.\r\n\r\nIf you want filtering, call `getQualifiers().getFilteredSnakList( propertyId )`.","created_at":"2016-01-07T15:23:49Z","updated_at":"2016-01-12T16:19:55Z","closed_at":"2016-01-12T16:19:55Z","merged_at":"2016-01-12T16:19:55Z","merge_commit_sha":"e8bffc8fcc27983246478bf61758a6226ff3e216","assignee":null,"milestone":{"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones/1","html_url":"https://github.com/wmde/WikibaseDataModelJavaScript/milestones/2.0.0","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones/1/labels","id":1467693,"number":1,"title":"2.0.0","description":null,"creator":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2015-12-19T09:00:37Z","updated_at":"2016-01-12T16:19:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48/commits","review_comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48/comments","review_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/48/comments","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/d36d7bdeef9a20847063b5f9dbe04f46936ee412","head":{"label":"wmde:getFilteredQualifiers","ref":"getFilteredQualifiers","sha":"d36d7bdeef9a20847063b5f9dbe04f46936ee412","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20956401,"name":"WikibaseDataModelJavaScript","full_name":"wmde/WikibaseDataModelJavaScript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript","description":"JavaScript implementation of the Wikibase data model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/releases{/id}","created_at":"2014-06-18T09:16:29Z","updated_at":"2016-01-12T13:34:11Z","pushed_at":"2016-01-12T16:19:56Z","git_url":"git://github.com/wmde/WikibaseDataModelJavaScript.git","ssh_url":"git@github.com:wmde/WikibaseDataModelJavaScript.git","clone_url":"https://github.com/wmde/WikibaseDataModelJavaScript.git","svn_url":"https://github.com/wmde/WikibaseDataModelJavaScript","homepage":"http://wikiba.se","size":343,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"20747f466a3c7c7bb4f4fd7fe3854415b9dd319b","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20956401,"name":"WikibaseDataModelJavaScript","full_name":"wmde/WikibaseDataModelJavaScript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript","description":"JavaScript implementation of the Wikibase data model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/releases{/id}","created_at":"2014-06-18T09:16:29Z","updated_at":"2016-01-12T13:34:11Z","pushed_at":"2016-01-12T16:19:56Z","git_url":"git://github.com/wmde/WikibaseDataModelJavaScript.git","ssh_url":"git@github.com:wmde/WikibaseDataModelJavaScript.git","clone_url":"https://github.com/wmde/WikibaseDataModelJavaScript.git","svn_url":"https://github.com/wmde/WikibaseDataModelJavaScript","homepage":"http://wikiba.se","size":343,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48"},"html":{"href":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/48"},"issue":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/48"},"comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/d36d7bdeef9a20847063b5f9dbe04f46936ee412"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mariushoch","id":2446964,"avatar_url":"https://avatars.githubusercontent.com/u/2446964?v=3","gravatar_id":"","url":"https://api.github.com/users/mariushoch","html_url":"https://github.com/mariushoch","followers_url":"https://api.github.com/users/mariushoch/followers","following_url":"https://api.github.com/users/mariushoch/following{/other_user}","gists_url":"https://api.github.com/users/mariushoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mariushoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariushoch/subscriptions","organizations_url":"https://api.github.com/users/mariushoch/orgs","repos_url":"https://api.github.com/users/mariushoch/repos","events_url":"https://api.github.com/users/mariushoch/events{/privacy}","received_events_url":"https://api.github.com/users/mariushoch/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":21,"deletions":43,"changed_files":4}}