{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments/62924823","id":62924823,"diff_hunk":"@@ -53,19 +53,20 @@ print.gsplot <- function(x, ...){\n \n   for (side.name in side.names){\n     side <- as.side(side.name)\n-    par(x[[side.name]]$par)\n+    old.par <- par(x[[side.name]]$par)\n     set_frame(views, side)\n     if(!side %in% defined.sides){ \n       if(x[[side.name]][['axes']]){\n-        Axis(side=side,x=lim(views, side))\n+        do.call('Axis', append(list(side=side,x=lim(views, side)), config('axis')))","path":"R/print.R","position":19,"original_position":19,"commit_id":"39a1f3d846948838a4a3884a41ac1ad2128bf254","original_commit_id":"39a1f3d846948838a4a3884a41ac1ad2128bf254","user":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"body":"can be done by this: \r\n```r\r\nAxis(side=2,x=c(1,0),NULL,config('axis'))\r\n```\r\nsince usage of `Axis` is `Axis(x = NULL, at = NULL, ..., side, labels = NULL)`\r\nbut...I avoided that because `at` could potentially be in config('axis') although that would be unlikely","created_at":"2016-05-11T20:54:10Z","updated_at":"2016-05-11T20:54:10Z","html_url":"https://github.com/USGS-R/gsplot/pull/345#discussion_r62924823","pull_request_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments/62924823"},"html":{"href":"https://github.com/USGS-R/gsplot/pull/345#discussion_r62924823"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-R/gsplot/pulls/345","id":69737499,"html_url":"https://github.com/USGS-R/gsplot/pull/345","diff_url":"https://github.com/USGS-R/gsplot/pull/345.diff","patch_url":"https://github.com/USGS-R/gsplot/pull/345.patch","issue_url":"https://api.github.com/repos/USGS-R/gsplot/issues/345","number":345,"state":"open","locked":false,"title":"updates after review","user":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"body":"per #344 \r\n\r\n@lindsaycarr the `box()` framing of the plot still isn't active here, and I am still wondering where the best place to store that is. \r\n\r\nAlso \"axis lines not extended to the actual limits\" that is part of the box being missing, so I didn't mess with that. The other issues were related to par slipping out of scope and affecting legend defaults. \r\n\r\nCan you take a look? ","created_at":"2016-05-11T20:32:49Z","updated_at":"2016-05-11T20:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1246a63aed55a3a4cf61af7e129773f598887f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/345/commits","review_comments_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/345/comments","review_comment_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/gsplot/issues/345/comments","statuses_url":"https://api.github.com/repos/USGS-R/gsplot/statuses/39a1f3d846948838a4a3884a41ac1ad2128bf254","head":{"label":"jread-usgs:master","ref":"master","sha":"39a1f3d846948838a4a3884a41ac1ad2128bf254","user":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"repo":{"id":37484990,"name":"gsplot","full_name":"jread-usgs/gsplot","owner":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jread-usgs/gsplot","description":"plotting foundation for timeseries reporting","fork":true,"url":"https://api.github.com/repos/jread-usgs/gsplot","forks_url":"https://api.github.com/repos/jread-usgs/gsplot/forks","keys_url":"https://api.github.com/repos/jread-usgs/gsplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jread-usgs/gsplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jread-usgs/gsplot/teams","hooks_url":"https://api.github.com/repos/jread-usgs/gsplot/hooks","issue_events_url":"https://api.github.com/repos/jread-usgs/gsplot/issues/events{/number}","events_url":"https://api.github.com/repos/jread-usgs/gsplot/events","assignees_url":"https://api.github.com/repos/jread-usgs/gsplot/assignees{/user}","branches_url":"https://api.github.com/repos/jread-usgs/gsplot/branches{/branch}","tags_url":"https://api.github.com/repos/jread-usgs/gsplot/tags","blobs_url":"https://api.github.com/repos/jread-usgs/gsplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jread-usgs/gsplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jread-usgs/gsplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/jread-usgs/gsplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jread-usgs/gsplot/statuses/{sha}","languages_url":"https://api.github.com/repos/jread-usgs/gsplot/languages","stargazers_url":"https://api.github.com/repos/jread-usgs/gsplot/stargazers","contributors_url":"https://api.github.com/repos/jread-usgs/gsplot/contributors","subscribers_url":"https://api.github.com/repos/jread-usgs/gsplot/subscribers","subscription_url":"https://api.github.com/repos/jread-usgs/gsplot/subscription","commits_url":"https://api.github.com/repos/jread-usgs/gsplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/jread-usgs/gsplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/jread-usgs/gsplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/jread-usgs/gsplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/jread-usgs/gsplot/contents/{+path}","compare_url":"https://api.github.com/repos/jread-usgs/gsplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jread-usgs/gsplot/merges","archive_url":"https://api.github.com/repos/jread-usgs/gsplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jread-usgs/gsplot/downloads","issues_url":"https://api.github.com/repos/jread-usgs/gsplot/issues{/number}","pulls_url":"https://api.github.com/repos/jread-usgs/gsplot/pulls{/number}","milestones_url":"https://api.github.com/repos/jread-usgs/gsplot/milestones{/number}","notifications_url":"https://api.github.com/repos/jread-usgs/gsplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jread-usgs/gsplot/labels{/name}","releases_url":"https://api.github.com/repos/jread-usgs/gsplot/releases{/id}","deployments_url":"https://api.github.com/repos/jread-usgs/gsplot/deployments","created_at":"2015-06-15T18:59:47Z","updated_at":"2016-04-17T12:34:12Z","pushed_at":"2016-05-11T20:30:13Z","git_url":"git://github.com/jread-usgs/gsplot.git","ssh_url":"git@github.com:jread-usgs/gsplot.git","clone_url":"https://github.com/jread-usgs/gsplot.git","svn_url":"https://github.com/jread-usgs/gsplot","homepage":"","size":6500,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:master","ref":"master","sha":"f2e642d82be3262bc4490ff9f5b510ef40b2f261","user":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":37219882,"name":"gsplot","full_name":"USGS-R/gsplot","owner":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/gsplot","description":"plotting foundation for timeseries reporting","fork":false,"url":"https://api.github.com/repos/USGS-R/gsplot","forks_url":"https://api.github.com/repos/USGS-R/gsplot/forks","keys_url":"https://api.github.com/repos/USGS-R/gsplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/gsplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/gsplot/teams","hooks_url":"https://api.github.com/repos/USGS-R/gsplot/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/gsplot/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/gsplot/events","assignees_url":"https://api.github.com/repos/USGS-R/gsplot/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/gsplot/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/gsplot/tags","blobs_url":"https://api.github.com/repos/USGS-R/gsplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/gsplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/gsplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/gsplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/gsplot/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/gsplot/languages","stargazers_url":"https://api.github.com/repos/USGS-R/gsplot/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/gsplot/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/gsplot/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/gsplot/subscription","commits_url":"https://api.github.com/repos/USGS-R/gsplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/gsplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/gsplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/gsplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/gsplot/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/gsplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/gsplot/merges","archive_url":"https://api.github.com/repos/USGS-R/gsplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/gsplot/downloads","issues_url":"https://api.github.com/repos/USGS-R/gsplot/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/gsplot/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/gsplot/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/gsplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/gsplot/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/gsplot/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/gsplot/deployments","created_at":"2015-06-10T20:08:10Z","updated_at":"2016-04-17T01:41:45Z","pushed_at":"2016-05-11T20:32:49Z","git_url":"git://github.com/USGS-R/gsplot.git","ssh_url":"git@github.com:USGS-R/gsplot.git","clone_url":"https://github.com/USGS-R/gsplot.git","svn_url":"https://github.com/USGS-R/gsplot","homepage":"","size":6496,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":53,"forks":11,"open_issues":53,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/345"},"html":{"href":"https://github.com/USGS-R/gsplot/pull/345"},"issue":{"href":"https://api.github.com/repos/USGS-R/gsplot/issues/345"},"comments":{"href":"https://api.github.com/repos/USGS-R/gsplot/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/gsplot/statuses/39a1f3d846948838a4a3884a41ac1ad2128bf254"}}}}