{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments/51183820","id":51183820,"diff_hunk":"@@ -380,6 +380,27 @@ module.exports = function (log, error) {\n       )\n   }\n \n+  Memory.prototype.sessionDevice = function (id) {\n+    id = id.toString('hex')\n+\n+    if ( !sessionTokens[id] ) {","path":"lib/db/mem.js","position":7,"original_position":7,"commit_id":"7bacec5429afad97d6c9686b28711393985a67a0","original_commit_id":"7bacec5429afad97d6c9686b28711393985a67a0","user":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"body":"nit: extra spacing is not like any other style in this file \r\n\r\nsee above ` if (! account.devices[deviceKey]) {` for instance ","created_at":"2016-01-28T20:39:51Z","updated_at":"2016-01-28T20:39:51Z","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124#discussion_r51183820","pull_request_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments/51183820"},"html":{"href":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124#discussion_r51183820"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124","id":57561902,"html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124","diff_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124.diff","patch_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/124","number":124,"state":"open","locked":false,"title":"feat(devices): added device lookup by session","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"body":"Supports https://github.com/mozilla/fxa-auth-server/pull/1166","created_at":"2016-01-28T20:37:47Z","updated_at":"2016-01-28T20:39:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3987756bfd5143ac6e53c05cfcf00c84bec17c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/124/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/7bacec5429afad97d6c9686b28711393985a67a0","head":{"label":"dannycoates:sessionDevice","ref":"sessionDevice","sha":"7bacec5429afad97d6c9686b28711393985a67a0","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"repo":{"id":39918760,"name":"fxa-auth-db-mysql","full_name":"dannycoates/fxa-auth-db-mysql","owner":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dannycoates/fxa-auth-db-mysql","description":"MySql backend for the fxa-auth-db-server","fork":true,"url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql","forks_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/forks","keys_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/teams","hooks_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/hooks","issue_events_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/events","assignees_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/tags","blobs_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/languages","stargazers_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/stargazers","contributors_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/contributors","subscribers_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/subscribers","subscription_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/subscription","commits_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/merges","archive_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/downloads","issues_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/labels{/name}","releases_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/deployments","created_at":"2015-07-29T22:10:58Z","updated_at":"2015-07-29T22:10:59Z","pushed_at":"2016-01-28T20:27:47Z","git_url":"git://github.com/dannycoates/fxa-auth-db-mysql.git","ssh_url":"git@github.com:dannycoates/fxa-auth-db-mysql.git","clone_url":"https://github.com/dannycoates/fxa-auth-db-mysql.git","svn_url":"https://github.com/dannycoates/fxa-auth-db-mysql","homepage":"","size":527,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"5598551b07ad8081b6225a0a27b5a831e41cc9cf","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":23937466,"name":"fxa-auth-db-mysql","full_name":"mozilla/fxa-auth-db-mysql","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-auth-db-mysql","description":"MySql backend for the fxa-auth-db-server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql","forks_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/deployments","created_at":"2014-09-11T22:06:52Z","updated_at":"2016-01-11T04:47:05Z","pushed_at":"2016-01-28T20:37:47Z","git_url":"git://github.com/mozilla/fxa-auth-db-mysql.git","ssh_url":"git@github.com:mozilla/fxa-auth-db-mysql.git","clone_url":"https://github.com/mozilla/fxa-auth-db-mysql.git","svn_url":"https://github.com/mozilla/fxa-auth-db-mysql","homepage":"","size":553,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124"},"html":{"href":"https://github.com/mozilla/fxa-auth-db-mysql/pull/124"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/124"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/7bacec5429afad97d6c9686b28711393985a67a0"}}}}