{"action":"created","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/561","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/561/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/561/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/561","id":135313610,"number":561,"title":"tcpServersManager and tests","user":{"login":"tobybrad","id":8226225,"avatar_url":"https://avatars.githubusercontent.com/u/8226225?v=3","gravatar_id":"","url":"https://api.github.com/users/tobybrad","html_url":"https://github.com/tobybrad","followers_url":"https://api.github.com/users/tobybrad/followers","following_url":"https://api.github.com/users/tobybrad/following{/other_user}","gists_url":"https://api.github.com/users/tobybrad/gists{/gist_id}","starred_url":"https://api.github.com/users/tobybrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobybrad/subscriptions","organizations_url":"https://api.github.com/users/tobybrad/orgs","repos_url":"https://api.github.com/users/tobybrad/repos","events_url":"https://api.github.com/users/tobybrad/events{/privacy}","received_events_url":"https://api.github.com/users/tobybrad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/3%20-%20Working","name":"3 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/milestones/New%20Infra","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7/labels","id":1498038,"number":7,"title":"New Infra","description":"This will be the first release of the new infrastructure working end to end.","creator":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":116,"state":"open","created_at":"2016-01-11T19:12:00Z","updated_at":"2016-03-07T18:45:02Z","due_on":"2016-03-31T07:00:00Z","closed_at":null},"comments":22,"created_at":"2016-02-22T04:33:30Z","updated_at":"2016-03-09T01:13:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/pulls/561","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/561","diff_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/561.diff","patch_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/561.patch"},"body":"- [ ] Figure out the maximum call stack size exceeded crashing bug\n- [x] Review createNativeListener to find all the places where the CBs make bad assumptions\n- [x] Punch up the createNativeListener tests to test the weak points where things can fail\n- [x] Add test that we properly close incoming connections when they time out\n- [x] Fix incomingConnectionState events aren't emitting correct values\n- [ ] Check to see if we are using any other native methods and if so that they are expecting strings\n- [ ] Check if routerPortConnectionFailed is emitted correctly\n- [ ] Check if failedconnection is emitted correctly\n- [ ] Fix the tests that are expecting the wrong events\n- [ ] Implement terminateIncomingConnection\n- [ ] Test implementation of terminateIncomingConnection\n- [ ] Check all the cbs in the forward connection code for bad assumptions, also check the pipes for possible closed objects\n- [ ] Check forward connection weak points to make sure we clean up properly\n- [ ] Check the code that creates a listener in response to a peer availability event and make sure that at some point we clean port up.\n- [ ] Figure out how to make sure that the tests run on devices, we don't have to run cross device but we do want the tests running there. Ville suggested we could detect when we are on mobile and run. But I'd like to get rid of the fixed ports and let it run in coordinated as well.\n\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/thaliproject/thali_cordovaplugin/561)\n<!-- Reviewable:end -->\n\n\n<!---\n@huboard:{\"milestone_order\":561.0,\"order\":5.91278076171875e-05,\"custom_state\":\"\"}\n-->\n"},"comment":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/comments/194052900","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/561#issuecomment-194052900","issue_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/561","id":194052900,"user":{"login":"ThaliTester","id":13933164,"avatar_url":"https://avatars.githubusercontent.com/u/13933164?v=3","gravatar_id":"","url":"https://api.github.com/users/ThaliTester","html_url":"https://github.com/ThaliTester","followers_url":"https://api.github.com/users/ThaliTester/followers","following_url":"https://api.github.com/users/ThaliTester/following{/other_user}","gists_url":"https://api.github.com/users/ThaliTester/gists{/gist_id}","starred_url":"https://api.github.com/users/ThaliTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThaliTester/subscriptions","organizations_url":"https://api.github.com/users/ThaliTester/orgs","repos_url":"https://api.github.com/users/ThaliTester/repos","events_url":"https://api.github.com/users/ThaliTester/events{/privacy}","received_events_url":"https://api.github.com/users/ThaliTester/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T01:13:05Z","updated_at":"2016-03-09T01:13:05Z","body":"PR is added to the queue for testing as 1. task. (64ab483)"}}