{"action":"created","issue":{"url":"https://api.github.com/repos/jatoben/CommandLine/issues/67","repository_url":"https://api.github.com/repos/jatoben/CommandLine","labels_url":"https://api.github.com/repos/jatoben/CommandLine/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/jatoben/CommandLine/issues/67/comments","events_url":"https://api.github.com/repos/jatoben/CommandLine/issues/67/events","html_url":"https://github.com/jatoben/CommandLine/pull/67","id":147685525,"number":67,"title":"Add compatibility with Swift 3 (May 9th) snapshot","user":{"login":"IngmarStein","id":490610,"avatar_url":"https://avatars.githubusercontent.com/u/490610?v=3","gravatar_id":"","url":"https://api.github.com/users/IngmarStein","html_url":"https://github.com/IngmarStein","followers_url":"https://api.github.com/users/IngmarStein/followers","following_url":"https://api.github.com/users/IngmarStein/following{/other_user}","gists_url":"https://api.github.com/users/IngmarStein/gists{/gist_id}","starred_url":"https://api.github.com/users/IngmarStein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngmarStein/subscriptions","organizations_url":"https://api.github.com/users/IngmarStein/orgs","repos_url":"https://api.github.com/users/IngmarStein/repos","events_url":"https://api.github.com/users/IngmarStein/events{/privacy}","received_events_url":"https://api.github.com/users/IngmarStein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-12T09:09:51Z","updated_at":"2016-06-03T04:30:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jatoben/CommandLine/pulls/67","html_url":"https://github.com/jatoben/CommandLine/pull/67","diff_url":"https://github.com/jatoben/CommandLine/pull/67.diff","patch_url":"https://github.com/jatoben/CommandLine/pull/67.patch"},"body":"Here's another take on Swift 3 support, based on your current HEAD.\r\n\r\nI used `#if swift(>=3.0)` blocks to maintain Swift 2.2 support, but it's apparent that this is a compiler feature and not a preprocessor, e.g. it's not possible to have something like this:\r\n```\r\n#if swift(>=3.0)\r\n  private struct StderrOutputStream: OutputStream {\r\n#else\r\n  private struct StderrOutputStream: OutputStreamType {\r\n#endif\r\n```\r\nIn that case, I had to duplicate the whole (tiny) struct."},"comment":{"url":"https://api.github.com/repos/jatoben/CommandLine/issues/comments/223488270","html_url":"https://github.com/jatoben/CommandLine/pull/67#issuecomment-223488270","issue_url":"https://api.github.com/repos/jatoben/CommandLine/issues/67","id":223488270,"user":{"login":"jatoben","id":318083,"avatar_url":"https://avatars.githubusercontent.com/u/318083?v=3","gravatar_id":"","url":"https://api.github.com/users/jatoben","html_url":"https://github.com/jatoben","followers_url":"https://api.github.com/users/jatoben/followers","following_url":"https://api.github.com/users/jatoben/following{/other_user}","gists_url":"https://api.github.com/users/jatoben/gists{/gist_id}","starred_url":"https://api.github.com/users/jatoben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jatoben/subscriptions","organizations_url":"https://api.github.com/users/jatoben/orgs","repos_url":"https://api.github.com/users/jatoben/repos","events_url":"https://api.github.com/users/jatoben/events{/privacy}","received_events_url":"https://api.github.com/users/jatoben/received_events","type":"User","site_admin":true},"created_at":"2016-06-03T04:30:02Z","updated_at":"2016-06-03T04:30:02Z","body":"Sorry for being late to the party here, and thanks so much for doing the heavy lifting!\r\n\r\n> Right now, my aim was to compile cleanly without warning in both languages even if that adds some more duplication. I'd like the repo owner to chime in where he wants to strike the balance.\r\n\r\nDefinitely 👍on this. I'm not too concerned about duplication, since when Swift 3 ships, I expect that folks will convert pretty quickly, and we can just delete the `#else` blocks. The old releases will still be around for anyone who wants to use Swift 2.\r\n\r\n> though there's a plenty of the current API that doesn't match the style guide apart from the enums (e.g. splitByCharacter)\r\n\r\nThat method name dates from August 2014 😄 The code could most definitely use a good refactoring, which I'll probably tackle after the Swift 3 release. If anyone wants to take a pass at it before then though, please go ahead."}}
{"actor":{"display_login":"jatoben"}}