{"action":"created","issue":{"url":"https://api.github.com/repos/bitovi/documentcss/issues/24","repository_url":"https://api.github.com/repos/bitovi/documentcss","labels_url":"https://api.github.com/repos/bitovi/documentcss/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/bitovi/documentcss/issues/24/comments","events_url":"https://api.github.com/repos/bitovi/documentcss/issues/24/events","html_url":"https://github.com/bitovi/documentcss/pull/24","id":154068845,"number":24,"title":"Donejs theming!","user":{"login":"lkodai","id":3605094,"avatar_url":"https://avatars.githubusercontent.com/u/3605094?v=3","gravatar_id":"","url":"https://api.github.com/users/lkodai","html_url":"https://github.com/lkodai","followers_url":"https://api.github.com/users/lkodai/followers","following_url":"https://api.github.com/users/lkodai/following{/other_user}","gists_url":"https://api.github.com/users/lkodai/gists{/gist_id}","starred_url":"https://api.github.com/users/lkodai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkodai/subscriptions","organizations_url":"https://api.github.com/users/lkodai/orgs","repos_url":"https://api.github.com/users/lkodai/repos","events_url":"https://api.github.com/users/lkodai/events{/privacy}","received_events_url":"https://api.github.com/users/lkodai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitovi/documentcss/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"lkodai","id":3605094,"avatar_url":"https://avatars.githubusercontent.com/u/3605094?v=3","gravatar_id":"","url":"https://api.github.com/users/lkodai","html_url":"https://github.com/lkodai","followers_url":"https://api.github.com/users/lkodai/followers","following_url":"https://api.github.com/users/lkodai/following{/other_user}","gists_url":"https://api.github.com/users/lkodai/gists{/gist_id}","starred_url":"https://api.github.com/users/lkodai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkodai/subscriptions","organizations_url":"https://api.github.com/users/lkodai/orgs","repos_url":"https://api.github.com/users/lkodai/repos","events_url":"https://api.github.com/users/lkodai/events{/privacy}","received_events_url":"https://api.github.com/users/lkodai/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-05-10T17:59:15Z","updated_at":"2016-05-13T16:46:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitovi/documentcss/pulls/24","html_url":"https://github.com/bitovi/documentcss/pull/24","diff_url":"https://github.com/bitovi/documentcss/pull/24.diff","patch_url":"https://github.com/bitovi/documentcss/pull/24.patch"},"body":"\r\n<img width=\"1286\" alt=\"screen shot 2016-05-10 at 10 58 59 am\" src=\"https://cloud.githubusercontent.com/assets/3605094/15156956/4813daa0-169e-11e6-99c8-3bba87c04a05.png\">\r\n\r\n👯👯🍻🎉🍻👯👯"},"comment":{"url":"https://api.github.com/repos/bitovi/documentcss/issues/comments/219097130","html_url":"https://github.com/bitovi/documentcss/pull/24#issuecomment-219097130","issue_url":"https://api.github.com/repos/bitovi/documentcss/issues/24","id":219097130,"user":{"login":"adrifolio","id":950214,"avatar_url":"https://avatars.githubusercontent.com/u/950214?v=3","gravatar_id":"","url":"https://api.github.com/users/adrifolio","html_url":"https://github.com/adrifolio","followers_url":"https://api.github.com/users/adrifolio/followers","following_url":"https://api.github.com/users/adrifolio/following{/other_user}","gists_url":"https://api.github.com/users/adrifolio/gists{/gist_id}","starred_url":"https://api.github.com/users/adrifolio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrifolio/subscriptions","organizations_url":"https://api.github.com/users/adrifolio/orgs","repos_url":"https://api.github.com/users/adrifolio/repos","events_url":"https://api.github.com/users/adrifolio/events{/privacy}","received_events_url":"https://api.github.com/users/adrifolio/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T16:46:01Z","updated_at":"2016-05-13T16:46:01Z","body":"@lkodai this looks great!\r\n\r\nHere's some things that I spotted:\r\n\r\n- [ ] The font size of the code blocks seems to big and is breaking the layout on the color palette demo:\r\n<img width=\"591\" alt=\"screen shot 2016-05-13 at 8 58 32 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254595/62d3e70e-18ec-11e6-901b-5e57062c1be2.png\">\r\n\r\n- [ ] The header nav demo is not displaying correctly:\r\n<img width=\"601\" alt=\"screen shot 2016-05-13 at 9 03 45 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254627/8d7edcc0-18ec-11e6-972a-b2d5e70cc0ee.png\">\r\n\r\n- [ ] The dropdown seems to be missing a border on the top:\r\n<img width=\"246\" alt=\"screen shot 2016-05-13 at 9 04 09 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254675/ca807962-18ec-11e6-83c0-6afaf6b1e9b8.png\">\r\n\r\n- [ ] The \"button\" class applied to a div is not showing up:\r\n<img width=\"351\" alt=\"screen shot 2016-05-13 at 9 06 42 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254693/eaf06f4a-18ec-11e6-8a72-bd8696c5ce83.png\">\r\n\r\n- [ ] The demos under sidebar are showing empty:\r\n<img width=\"586\" alt=\"screen shot 2016-05-13 at 9 15 33 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254720/0f19f81e-18ed-11e6-917c-4f41c60aabbf.png\">\r\n\r\n- [ ] Some menu items are missing on the style guide section (typography, helpers, layout):\r\n<img width=\"211\" alt=\"screen shot 2016-05-13 at 9 29 48 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254766/53c8abea-18ed-11e6-96ab-ac6a06cb06a9.png\">\r\nvs\r\n<img width=\"231\" alt=\"screen shot 2016-05-13 at 9 29 39 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254770/580ec75c-18ed-11e6-8313-6d7296118b36.png\">\r\n\r\n- [ ] There seems to be two slightly different colors for links:\r\n<img width=\"245\" alt=\"screen shot 2016-05-13 at 9 13 12 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254788/7104ae48-18ed-11e6-8ab8-99bcd8e0f1cf.png\">\r\n\r\n- [ ] I think having some headings match the color of links makes it look like they are links as well. So a couple of suggestions on that:\r\n-- Make the headings a tone of gray and use a lighter font-weight\r\n-- Add \"underline\" on hover to links\r\n\r\nFor example:\r\n<img width=\"725\" alt=\"screen shot 2016-05-13 at 9 17 03 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15254984/52307a50-18ee-11e6-8cc4-42ab8b63d728.png\">\r\n\r\n- [ ] The line height on `<h3>` seems to high right now. Adjusting it to `line-height: normal` seems to work well:\r\n<img width=\"538\" alt=\"screen shot 2016-05-13 at 9 38 23 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15255059/b426ad38-18ee-11e6-840b-38e88ca6941f.png\">\r\nvs\r\n<img width=\"617\" alt=\"screen shot 2016-05-13 at 9 38 29 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15255054/afe64abc-18ee-11e6-9dae-f650c6fcf6b4.png\">\r\n\r\n- [ ] The icon color for open an external site is not matching the link color\r\n<img width=\"116\" alt=\"screen shot 2016-05-13 at 9 18 15 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15255099/db4500c2-18ee-11e6-90f1-5b072c16e4a9.png\">\r\n\r\n- [ ] The hover color on the side nav menu items is the same as the selected, which makes it look like two are selected when hovering on them. I would adjust that:\r\n<img width=\"232\" alt=\"screen shot 2016-05-13 at 9 21 38 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15255126/03b06fce-18ef-11e6-8dc0-1c549e746ba9.png\">\r\n\r\n- [ ] Lastly, I think the gray on the logo could be made tad darker as it doesn't work as well as it does right now in the dark header color:\r\n<img width=\"198\" alt=\"screen shot 2016-05-13 at 9 01 44 am\" src=\"https://cloud.githubusercontent.com/assets/950214/15255179/4c01d038-18ef-11e6-83ae-f2dbe79bc9ad.png\">\r\n\r\n"}}