{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/70176841","id":70176841,"diff_hunk":"@@ -94,12 +95,18 @@ function ComplexSchemaController (avsc, SCHEMA_TYPES, $scope, uuid, $timeout) {\n       };\n     });\n \n+    if (!vm.isDisabled && vm.parsedSchema.length === 0) {\n+      vm.addField();","path":"cdap-ui/app/directives/complex-schema/complex-schema.js","position":24,"original_position":24,"commit_id":"c9b2a509bd821ef438f22b5b0e136704a4f86719","original_commit_id":"c9b2a509bd821ef438f22b5b0e136704a4f86719","user":{"login":"elfenheart","id":4398643,"avatar_url":"https://avatars.githubusercontent.com/u/4398643?v=3","gravatar_id":"","url":"https://api.github.com/users/elfenheart","html_url":"https://github.com/elfenheart","followers_url":"https://api.github.com/users/elfenheart/followers","following_url":"https://api.github.com/users/elfenheart/following{/other_user}","gists_url":"https://api.github.com/users/elfenheart/gists{/gist_id}","starred_url":"https://api.github.com/users/elfenheart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfenheart/subscriptions","organizations_url":"https://api.github.com/users/elfenheart/orgs","repos_url":"https://api.github.com/users/elfenheart/repos","events_url":"https://api.github.com/users/elfenheart/events{/privacy}","received_events_url":"https://api.github.com/users/elfenheart/received_events","type":"User","site_admin":false},"body":"No, that's a mistake. We could add a return statement after the ```vm.addField```","created_at":"2016-07-10T06:24:15Z","updated_at":"2016-07-10T06:24:15Z","html_url":"https://github.com/caskdata/cdap/pull/6004#discussion_r70176841","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6004","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/70176841"},"html":{"href":"https://github.com/caskdata/cdap/pull/6004#discussion_r70176841"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6004"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6004","id":76828670,"html_url":"https://github.com/caskdata/cdap/pull/6004","diff_url":"https://github.com/caskdata/cdap/pull/6004.diff","patch_url":"https://github.com/caskdata/cdap/pull/6004.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6004","number":6004,"state":"open","locked":false,"title":"[CDAP-4986] UI Complex Schema Integration Part 1","user":{"login":"elfenheart","id":4398643,"avatar_url":"https://avatars.githubusercontent.com/u/4398643?v=3","gravatar_id":"","url":"https://api.github.com/users/elfenheart","html_url":"https://github.com/elfenheart","followers_url":"https://api.github.com/users/elfenheart/followers","following_url":"https://api.github.com/users/elfenheart/following{/other_user}","gists_url":"https://api.github.com/users/elfenheart/gists{/gist_id}","starred_url":"https://api.github.com/users/elfenheart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfenheart/subscriptions","organizations_url":"https://api.github.com/users/elfenheart/orgs","repos_url":"https://api.github.com/users/elfenheart/repos","events_url":"https://api.github.com/users/elfenheart/events{/privacy}","received_events_url":"https://api.github.com/users/elfenheart/received_events","type":"User","site_admin":false},"body":"Feature parity is not completed yet. Will add watchable property and stream schema on the next iteration","created_at":"2016-07-08T23:36:35Z","updated_at":"2016-07-10T06:24:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01aec9b6385e8c1e9f40934c611a0d1cbedada1c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/25","html_url":"https://github.com/caskdata/cdap/milestones/3.5","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/25/labels","id":1745860,"number":25,"title":"3.5","description":null,"creator":{"login":"rohitsinha54","id":1472867,"avatar_url":"https://avatars.githubusercontent.com/u/1472867?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitsinha54","html_url":"https://github.com/rohitsinha54","followers_url":"https://api.github.com/users/rohitsinha54/followers","following_url":"https://api.github.com/users/rohitsinha54/following{/other_user}","gists_url":"https://api.github.com/users/rohitsinha54/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitsinha54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitsinha54/subscriptions","organizations_url":"https://api.github.com/users/rohitsinha54/orgs","repos_url":"https://api.github.com/users/rohitsinha54/repos","events_url":"https://api.github.com/users/rohitsinha54/events{/privacy}","received_events_url":"https://api.github.com/users/rohitsinha54/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":42,"state":"open","created_at":"2016-05-03T18:02:56Z","updated_at":"2016-07-10T02:03:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6004/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6004/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6004/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/c9b2a509bd821ef438f22b5b0e136704a4f86719","head":{"label":"caskdata:feature/ui-complex-schema-integration","ref":"feature/ui-complex-schema-integration","sha":"c9b2a509bd821ef438f22b5b0e136704a4f86719","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-03T08:27:44Z","pushed_at":"2016-07-10T06:14:28Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":620956,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":22,"forks":45,"open_issues":22,"watchers":132,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"097e738df0f86539716a268b1d19bb60673fcd82","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-03T08:27:44Z","pushed_at":"2016-07-10T06:14:28Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":620956,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":22,"forks":45,"open_issues":22,"watchers":132,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6004"},"html":{"href":"https://github.com/caskdata/cdap/pull/6004"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6004"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6004/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6004/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6004/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/c9b2a509bd821ef438f22b5b0e136704a4f86719"}}}}
{"actor":{"display_login":"elfenheart"}}