{"action":"created","comment":{"url":"https://api.github.com/repos/apache/log4net/pulls/comments/73228215","id":73228215,"diff_hunk":"@@ -0,0 +1,94 @@\n+﻿{\n+  \"name\": \"log4net\",\n+  \"version\": \"3.0.0\",\n+  \"frameworks\": {\n+    \"netstandard1.3\": {\n+      \"buildOptions\": {\n+        \"compile\": {\n+          \"include\": [ \"*.cs\", \"../../src/**/*.cs\" ],\n+          \"exclude\": [\n+            \"../../src/Appender/AdoNetAppender.cs\",\n+            \"../../src/Appender/AspNetTraceAppender.cs\",\n+            \"../../src/Appender/ColoredConsoleAppender.cs\",\n+            \"../../src/Appender/EventLogAppender.cs\",\n+            \"../../src/Appender/NetSendAppender.cs\",\n+            \"../../src/Appender/RemotingAppender.cs\",\n+            \"../../src/Appender/SmtpAppender.cs\",\n+            \"../../src/LogicalThreadContext.cs\",\n+            \"../../src/Config/DOMConfigurator.cs\",\n+            \"../../src/Config/DOMConfiguratorAttribute.cs\",\n+            \"../../src/Config/Log4NetConfigurationSectionHandler.cs\",\n+            \"../../src/Layout/Pattern/AspNetCachePatternConverter.cs\",\n+            \"../../src/Layout/Pattern/AspNetContextPatternConverter.cs\",\n+            \"../../src/Layout/Pattern/AspNetPatternConverter.cs\",\n+            \"../../src/Layout/Pattern/AspNetRequestPatternConverter.cs\",\n+            \"../../src/Layout/Pattern/AspNetSessionPatternConverter.cs\",\n+            \"../../src/Layout/Pattern/StackTraceDetailPatternConverter.cs\",\n+            \"../../src/Layout/Pattern/StackTracePatternConverter.cs\",\n+            \"../../src/Plugin/RemoteLoggingServerPlugin.cs\",\n+            \"../../src/Util/PatternStringConverters/EnvironmentFolderPathPatternConverter.cs\",\n+            \"../../src/Util/LogicalThreadContextProperties.cs\",\n+            \"../../src/Util/LogicalThreadContextStacks.cs\",\n+            \"../../src/Util/NativeError.cs\",\n+            \"../../src/Util/WindowsSecurityContext.cs\"\n+          ]\n+        },\n+        \"define\": [ \"HAS_READERWRITERLOCKSLIM\", \"NETSTANDARD1_3\" ]","path":"netstandard/log4net/project.json","position":36,"original_position":36,"commit_id":"9aa29db331fd5a76226c18a8c3f96dba3d79dae0","original_commit_id":"9aa29db331fd5a76226c18a8c3f96dba3d79dae0","user":{"login":"jasonwilliams200OK","id":2031765,"avatar_url":"https://avatars.githubusercontent.com/u/2031765?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonwilliams200OK","html_url":"https://github.com/jasonwilliams200OK","followers_url":"https://api.github.com/users/jasonwilliams200OK/followers","following_url":"https://api.github.com/users/jasonwilliams200OK/following{/other_user}","gists_url":"https://api.github.com/users/jasonwilliams200OK/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonwilliams200OK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonwilliams200OK/subscriptions","organizations_url":"https://api.github.com/users/jasonwilliams200OK/orgs","repos_url":"https://api.github.com/users/jasonwilliams200OK/repos","events_url":"https://api.github.com/users/jasonwilliams200OK/events{/privacy}","received_events_url":"https://api.github.com/users/jasonwilliams200OK/received_events","type":"User","site_admin":false},"body":"`NETSTANDARD1_3` definition is redundant here.","created_at":"2016-08-02T20:13:30Z","updated_at":"2016-08-02T20:13:30Z","html_url":"https://github.com/apache/log4net/pull/16#discussion_r73228215","pull_request_url":"https://api.github.com/repos/apache/log4net/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/apache/log4net/pulls/comments/73228215"},"html":{"href":"https://github.com/apache/log4net/pull/16#discussion_r73228215"},"pull_request":{"href":"https://api.github.com/repos/apache/log4net/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/apache/log4net/pulls/16","id":49212813,"html_url":"https://github.com/apache/log4net/pull/16","diff_url":"https://github.com/apache/log4net/pull/16.diff","patch_url":"https://github.com/apache/log4net/pull/16.patch","issue_url":"https://api.github.com/repos/apache/log4net/issues/16","number":16,"state":"open","locked":false,"title":"(LOG4NET-467) .NET Core support","user":{"login":"chlowell","id":10964656,"avatar_url":"https://avatars.githubusercontent.com/u/10964656?v=3","gravatar_id":"","url":"https://api.github.com/users/chlowell","html_url":"https://github.com/chlowell","followers_url":"https://api.github.com/users/chlowell/followers","following_url":"https://api.github.com/users/chlowell/following{/other_user}","gists_url":"https://api.github.com/users/chlowell/gists{/gist_id}","starred_url":"https://api.github.com/users/chlowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlowell/subscriptions","organizations_url":"https://api.github.com/users/chlowell/orgs","repos_url":"https://api.github.com/users/chlowell/repos","events_url":"https://api.github.com/users/chlowell/events{/privacy}","received_events_url":"https://api.github.com/users/chlowell/received_events","type":"User","site_admin":false},"body":"This adds a new solution under `log4net/netstandard`, providing a build for `netstandard1.3`. Using this in Visual Studio requires [Visual Studio 2015 Update 3](https://www.visualstudio.com/news/releasenotes/vs2015-update3-vs) and [.NET Core 1.0 for Visual Studio](https://go.microsoft.com/fwlink/?LinkId=817245). Building and running tests from the command line, without Visual Studio, can be done with [.NET Core SDK Preview 2](https://www.microsoft.com/net/download).\r\n\r\nFollowing established style, the new projects use compilation constant `NETSTANDARD1_3` for platform-specific changes. Some features are excluded entirely because they can't be implemented presently on the .NET Platform Standard. I think stack frame logging is the most important of these.\r\n\r\nSimilarly, due to the lack of `Assembly.GetCallingAssembly()`, only APIs which are explicit about their assembly parameters are exposed. For example, several `LogManager` methods reliant on `GetCallingAssembly()` have overloads with an `Assembly` or `Type` parameter; only the latter are surfaced for `netstandard1.3`.\r\n\r\n#### Known issues:\r\n- `RollingFileAppenderTest.TestExclusiveLockLocks()` fails on Linux; fixing this will probably require a new strategy for file locking, e.g. lock files.","created_at":"2015-10-29T23:10:37Z","updated_at":"2016-08-02T20:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05125bd7323eb91311f89a66d7f5a0241b8ff0b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/log4net/pulls/16/commits","review_comments_url":"https://api.github.com/repos/apache/log4net/pulls/16/comments","review_comment_url":"https://api.github.com/repos/apache/log4net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/log4net/issues/16/comments","statuses_url":"https://api.github.com/repos/apache/log4net/statuses/9aa29db331fd5a76226c18a8c3f96dba3d79dae0","head":{"label":"chlowell:log4net-core-pcl","ref":"log4net-core-pcl","sha":"9aa29db331fd5a76226c18a8c3f96dba3d79dae0","user":{"login":"chlowell","id":10964656,"avatar_url":"https://avatars.githubusercontent.com/u/10964656?v=3","gravatar_id":"","url":"https://api.github.com/users/chlowell","html_url":"https://github.com/chlowell","followers_url":"https://api.github.com/users/chlowell/followers","following_url":"https://api.github.com/users/chlowell/following{/other_user}","gists_url":"https://api.github.com/users/chlowell/gists{/gist_id}","starred_url":"https://api.github.com/users/chlowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlowell/subscriptions","organizations_url":"https://api.github.com/users/chlowell/orgs","repos_url":"https://api.github.com/users/chlowell/repos","events_url":"https://api.github.com/users/chlowell/events{/privacy}","received_events_url":"https://api.github.com/users/chlowell/received_events","type":"User","site_admin":false},"repo":{"id":44706503,"name":"log4net","full_name":"chlowell/log4net","owner":{"login":"chlowell","id":10964656,"avatar_url":"https://avatars.githubusercontent.com/u/10964656?v=3","gravatar_id":"","url":"https://api.github.com/users/chlowell","html_url":"https://github.com/chlowell","followers_url":"https://api.github.com/users/chlowell/followers","following_url":"https://api.github.com/users/chlowell/following{/other_user}","gists_url":"https://api.github.com/users/chlowell/gists{/gist_id}","starred_url":"https://api.github.com/users/chlowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlowell/subscriptions","organizations_url":"https://api.github.com/users/chlowell/orgs","repos_url":"https://api.github.com/users/chlowell/repos","events_url":"https://api.github.com/users/chlowell/events{/privacy}","received_events_url":"https://api.github.com/users/chlowell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chlowell/log4net","description":"Mirror of Apache log4net","fork":true,"url":"https://api.github.com/repos/chlowell/log4net","forks_url":"https://api.github.com/repos/chlowell/log4net/forks","keys_url":"https://api.github.com/repos/chlowell/log4net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chlowell/log4net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chlowell/log4net/teams","hooks_url":"https://api.github.com/repos/chlowell/log4net/hooks","issue_events_url":"https://api.github.com/repos/chlowell/log4net/issues/events{/number}","events_url":"https://api.github.com/repos/chlowell/log4net/events","assignees_url":"https://api.github.com/repos/chlowell/log4net/assignees{/user}","branches_url":"https://api.github.com/repos/chlowell/log4net/branches{/branch}","tags_url":"https://api.github.com/repos/chlowell/log4net/tags","blobs_url":"https://api.github.com/repos/chlowell/log4net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chlowell/log4net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chlowell/log4net/git/refs{/sha}","trees_url":"https://api.github.com/repos/chlowell/log4net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chlowell/log4net/statuses/{sha}","languages_url":"https://api.github.com/repos/chlowell/log4net/languages","stargazers_url":"https://api.github.com/repos/chlowell/log4net/stargazers","contributors_url":"https://api.github.com/repos/chlowell/log4net/contributors","subscribers_url":"https://api.github.com/repos/chlowell/log4net/subscribers","subscription_url":"https://api.github.com/repos/chlowell/log4net/subscription","commits_url":"https://api.github.com/repos/chlowell/log4net/commits{/sha}","git_commits_url":"https://api.github.com/repos/chlowell/log4net/git/commits{/sha}","comments_url":"https://api.github.com/repos/chlowell/log4net/comments{/number}","issue_comment_url":"https://api.github.com/repos/chlowell/log4net/issues/comments{/number}","contents_url":"https://api.github.com/repos/chlowell/log4net/contents/{+path}","compare_url":"https://api.github.com/repos/chlowell/log4net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chlowell/log4net/merges","archive_url":"https://api.github.com/repos/chlowell/log4net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chlowell/log4net/downloads","issues_url":"https://api.github.com/repos/chlowell/log4net/issues{/number}","pulls_url":"https://api.github.com/repos/chlowell/log4net/pulls{/number}","milestones_url":"https://api.github.com/repos/chlowell/log4net/milestones{/number}","notifications_url":"https://api.github.com/repos/chlowell/log4net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chlowell/log4net/labels{/name}","releases_url":"https://api.github.com/repos/chlowell/log4net/releases{/id}","deployments_url":"https://api.github.com/repos/chlowell/log4net/deployments","created_at":"2015-10-21T21:47:31Z","updated_at":"2016-03-18T02:36:22Z","pushed_at":"2016-07-13T17:35:50Z","git_url":"git://github.com/chlowell/log4net.git","ssh_url":"git@github.com:chlowell/log4net.git","clone_url":"https://github.com/chlowell/log4net.git","svn_url":"https://github.com/chlowell/log4net","homepage":null,"size":6580,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"4f600fdd737841ad8962562b507f750c6e7f43d1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206337,"name":"log4net","full_name":"apache/log4net","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/log4net","description":"Mirror of Apache log4net","fork":false,"url":"https://api.github.com/repos/apache/log4net","forks_url":"https://api.github.com/repos/apache/log4net/forks","keys_url":"https://api.github.com/repos/apache/log4net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/log4net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/log4net/teams","hooks_url":"https://api.github.com/repos/apache/log4net/hooks","issue_events_url":"https://api.github.com/repos/apache/log4net/issues/events{/number}","events_url":"https://api.github.com/repos/apache/log4net/events","assignees_url":"https://api.github.com/repos/apache/log4net/assignees{/user}","branches_url":"https://api.github.com/repos/apache/log4net/branches{/branch}","tags_url":"https://api.github.com/repos/apache/log4net/tags","blobs_url":"https://api.github.com/repos/apache/log4net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/log4net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/log4net/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/log4net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/log4net/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/log4net/languages","stargazers_url":"https://api.github.com/repos/apache/log4net/stargazers","contributors_url":"https://api.github.com/repos/apache/log4net/contributors","subscribers_url":"https://api.github.com/repos/apache/log4net/subscribers","subscription_url":"https://api.github.com/repos/apache/log4net/subscription","commits_url":"https://api.github.com/repos/apache/log4net/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/log4net/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/log4net/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/log4net/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/log4net/contents/{+path}","compare_url":"https://api.github.com/repos/apache/log4net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/log4net/merges","archive_url":"https://api.github.com/repos/apache/log4net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/log4net/downloads","issues_url":"https://api.github.com/repos/apache/log4net/issues{/number}","pulls_url":"https://api.github.com/repos/apache/log4net/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/log4net/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/log4net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/log4net/labels{/name}","releases_url":"https://api.github.com/repos/apache/log4net/releases{/id}","deployments_url":"https://api.github.com/repos/apache/log4net/deployments","created_at":"2009-05-21T00:58:13Z","updated_at":"2016-08-02T01:19:57Z","pushed_at":"2016-07-13T17:32:03Z","git_url":"git://github.com/apache/log4net.git","ssh_url":"git@github.com:apache/log4net.git","clone_url":"https://github.com/apache/log4net.git","svn_url":"https://github.com/apache/log4net","homepage":null,"size":7599,"stargazers_count":324,"watchers_count":324,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":"git://git.apache.org/log4net.git","open_issues_count":13,"forks":202,"open_issues":13,"watchers":324,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/log4net/pulls/16"},"html":{"href":"https://github.com/apache/log4net/pull/16"},"issue":{"href":"https://api.github.com/repos/apache/log4net/issues/16"},"comments":{"href":"https://api.github.com/repos/apache/log4net/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/log4net/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/log4net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/log4net/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/apache/log4net/statuses/9aa29db331fd5a76226c18a8c3f96dba3d79dae0"}}}}
{"actor":{"display_login":"jasonwilliams200OK"}}