{"action":"opened","number":1285,"pull_request":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285","id":64180184,"html_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1285","diff_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1285.diff","patch_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1285.patch","issue_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1285","number":1285,"state":"open","locked":false,"title":"clean up minBufferTime in BufferController","user":{"login":"AxelDelmas","id":5991128,"avatar_url":"https://avatars.githubusercontent.com/u/5991128?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelDelmas","html_url":"https://github.com/AxelDelmas","followers_url":"https://api.github.com/users/AxelDelmas/followers","following_url":"https://api.github.com/users/AxelDelmas/following{/other_user}","gists_url":"https://api.github.com/users/AxelDelmas/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelDelmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelDelmas/subscriptions","organizations_url":"https://api.github.com/users/AxelDelmas/orgs","repos_url":"https://api.github.com/users/AxelDelmas/repos","events_url":"https://api.github.com/users/AxelDelmas/events{/privacy}","received_events_url":"https://api.github.com/users/AxelDelmas/received_events","type":"User","site_admin":false},"body":"Cleaned up leftovers around `minBufferTime` in `BufferController`:\r\n- public getter and setter were unused\r\n- the only part of the code where it was used was [here](https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/controllers/BufferController.js#L549)\r\n- it was only set to `manifestInfo.minBufferTime` [here](https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/controllers/BufferController.js#L608)\r\n\r\n:warning: WARNING: \r\n- the [setTimeout](https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/controllers/BufferController.js#L549) was never executed because `clearBuffer(getClearRange())` is not not a function. My pull request will allow it to execute again but it might have side effects if this behavior was actually not wanted anymore (not tested)\r\n- I set the timeout delay to `streamProcessor.getStreamInfo().manifestInfo.minBufferTime * 1000` because that's what it was set at in practice. I don't really understand this value as it seems we only get in that part of the code if we're about to trigger a `QUOTA_EXCEEDED_ERROR` on MSE, so why not do another round of cleaning right away?\r\n- Additionally to last point, I didn't check if `streamProcessor.getStreamInfo().manifestInfo.minBufferTime` was always defined when we got in that part of the code. I suppose it is, but why not set this timeout delay to a short and constant amount of time? ","created_at":"2016-03-25T16:35:08Z","updated_at":"2016-03-25T16:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1285/comments","statuses_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/statuses/3ea06054fae18c1cfd01de8515f7a9b89e68829b","head":{"label":"streamroot:minBufferTime","ref":"minBufferTime","sha":"3ea06054fae18c1cfd01de8515f7a9b89e68829b","user":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"repo":{"id":47977860,"name":"dash.js","full_name":"streamroot/dash.js","owner":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamroot/dash.js","description":"A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.","fork":true,"url":"https://api.github.com/repos/streamroot/dash.js","forks_url":"https://api.github.com/repos/streamroot/dash.js/forks","keys_url":"https://api.github.com/repos/streamroot/dash.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamroot/dash.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamroot/dash.js/teams","hooks_url":"https://api.github.com/repos/streamroot/dash.js/hooks","issue_events_url":"https://api.github.com/repos/streamroot/dash.js/issues/events{/number}","events_url":"https://api.github.com/repos/streamroot/dash.js/events","assignees_url":"https://api.github.com/repos/streamroot/dash.js/assignees{/user}","branches_url":"https://api.github.com/repos/streamroot/dash.js/branches{/branch}","tags_url":"https://api.github.com/repos/streamroot/dash.js/tags","blobs_url":"https://api.github.com/repos/streamroot/dash.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamroot/dash.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamroot/dash.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamroot/dash.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamroot/dash.js/statuses/{sha}","languages_url":"https://api.github.com/repos/streamroot/dash.js/languages","stargazers_url":"https://api.github.com/repos/streamroot/dash.js/stargazers","contributors_url":"https://api.github.com/repos/streamroot/dash.js/contributors","subscribers_url":"https://api.github.com/repos/streamroot/dash.js/subscribers","subscription_url":"https://api.github.com/repos/streamroot/dash.js/subscription","commits_url":"https://api.github.com/repos/streamroot/dash.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamroot/dash.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamroot/dash.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamroot/dash.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamroot/dash.js/contents/{+path}","compare_url":"https://api.github.com/repos/streamroot/dash.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamroot/dash.js/merges","archive_url":"https://api.github.com/repos/streamroot/dash.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamroot/dash.js/downloads","issues_url":"https://api.github.com/repos/streamroot/dash.js/issues{/number}","pulls_url":"https://api.github.com/repos/streamroot/dash.js/pulls{/number}","milestones_url":"https://api.github.com/repos/streamroot/dash.js/milestones{/number}","notifications_url":"https://api.github.com/repos/streamroot/dash.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamroot/dash.js/labels{/name}","releases_url":"https://api.github.com/repos/streamroot/dash.js/releases{/id}","deployments_url":"https://api.github.com/repos/streamroot/dash.js/deployments","created_at":"2015-12-14T13:51:48Z","updated_at":"2016-02-24T15:41:22Z","pushed_at":"2016-03-25T16:23:27Z","git_url":"git://github.com/streamroot/dash.js.git","ssh_url":"git@github.com:streamroot/dash.js.git","clone_url":"https://github.com/streamroot/dash.js.git","svn_url":"https://github.com/streamroot/dash.js","homepage":null,"size":15875,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"Dash-Industry-Forum:development","ref":"development","sha":"e528d091652f9cf5b9fa10be095c1ce525ebd07b","user":{"login":"Dash-Industry-Forum","id":2762280,"avatar_url":"https://avatars.githubusercontent.com/u/2762280?v=3","gravatar_id":"","url":"https://api.github.com/users/Dash-Industry-Forum","html_url":"https://github.com/Dash-Industry-Forum","followers_url":"https://api.github.com/users/Dash-Industry-Forum/followers","following_url":"https://api.github.com/users/Dash-Industry-Forum/following{/other_user}","gists_url":"https://api.github.com/users/Dash-Industry-Forum/gists{/gist_id}","starred_url":"https://api.github.com/users/Dash-Industry-Forum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dash-Industry-Forum/subscriptions","organizations_url":"https://api.github.com/users/Dash-Industry-Forum/orgs","repos_url":"https://api.github.com/users/Dash-Industry-Forum/repos","events_url":"https://api.github.com/users/Dash-Industry-Forum/events{/privacy}","received_events_url":"https://api.github.com/users/Dash-Industry-Forum/received_events","type":"Organization","site_admin":false},"repo":{"id":6621471,"name":"dash.js","full_name":"Dash-Industry-Forum/dash.js","owner":{"login":"Dash-Industry-Forum","id":2762280,"avatar_url":"https://avatars.githubusercontent.com/u/2762280?v=3","gravatar_id":"","url":"https://api.github.com/users/Dash-Industry-Forum","html_url":"https://github.com/Dash-Industry-Forum","followers_url":"https://api.github.com/users/Dash-Industry-Forum/followers","following_url":"https://api.github.com/users/Dash-Industry-Forum/following{/other_user}","gists_url":"https://api.github.com/users/Dash-Industry-Forum/gists{/gist_id}","starred_url":"https://api.github.com/users/Dash-Industry-Forum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dash-Industry-Forum/subscriptions","organizations_url":"https://api.github.com/users/Dash-Industry-Forum/orgs","repos_url":"https://api.github.com/users/Dash-Industry-Forum/repos","events_url":"https://api.github.com/users/Dash-Industry-Forum/events{/privacy}","received_events_url":"https://api.github.com/users/Dash-Industry-Forum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dash-Industry-Forum/dash.js","description":"A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.","fork":false,"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js","forks_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/forks","keys_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/teams","hooks_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/hooks","issue_events_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/events{/number}","events_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/events","assignees_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/assignees{/user}","branches_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/branches{/branch}","tags_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/tags","blobs_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/languages","stargazers_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/stargazers","contributors_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/contributors","subscribers_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/subscribers","subscription_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/subscription","commits_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/contents/{+path}","compare_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/merges","archive_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/downloads","issues_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues{/number}","pulls_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/labels{/name}","releases_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/releases{/id}","deployments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/deployments","created_at":"2012-11-09T22:28:37Z","updated_at":"2016-03-25T15:58:28Z","pushed_at":"2016-03-25T16:18:33Z","git_url":"git://github.com/Dash-Industry-Forum/dash.js.git","ssh_url":"git@github.com:Dash-Industry-Forum/dash.js.git","clone_url":"https://github.com/Dash-Industry-Forum/dash.js.git","svn_url":"https://github.com/Dash-Industry-Forum/dash.js","homepage":null,"size":20337,"stargazers_count":1043,"watchers_count":1043,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":532,"mirror_url":null,"open_issues_count":112,"forks":532,"open_issues":112,"watchers":1043,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285"},"html":{"href":"https://github.com/Dash-Industry-Forum/dash.js/pull/1285"},"issue":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1285"},"comments":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/statuses/3ea06054fae18c1cfd01de8515f7a9b89e68829b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":21,"changed_files":1}}