{"action":"created","comment":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments/56199429","id":56199429,"diff_hunk":"@@ -7,33 +7,54 @@\n from arelle.XmlUtil import dateunionValue\n \n LEGALENTITYAXIS_DEFAULT = ''\n-_dei_pattern = re.compile(r'^http://xbrl\\.((sec\\.gov)|(us))/dei/\\d{4}-\\d{2}-\\d{2}')\n+_dei_pattern = (\n+    re.compile(r'^http://xbrl\\.((sec\\.gov)|(us))/dei/\\d{4}-\\d{2}-\\d{2}'))\n _CODE_NAME = 'DQC.US.0005'\n _RULE_VERSION = '1.0'\n \n \n def _get_end_of_period(val):\n     \"\"\"\n-    Gets the end of period date (dei:DocumentPeriodEndDate).  Returns the fact value or the context end date on the fact, whichever is later,\n-    in a tuple with the fact itself and a string representation of the date. The tuple is in a dict keyed off of any LegalEntityAxis members.\n-    The end of period string is adjusted for viewing to represent the day as expected.  In other words, dates that end in 24:00 will be put at 00:00 of the expected day.\n+    Gets the end of period date (dei:DocumentPeriodEndDate).  Returns the fact\n+    value or the context end date on the fact, whichever is later, in a tuple\n+    with the fact itself and a string representation of the date. The tuple is\n+    in a dict keyed off of any LegalEntityAxis members. The end of period\n+    string is adjusted for viewing to represent the day as expected.  In other\n+    words, dates that end in 24:00 will be put at 00:00 of the expected day.\n \n-    @return A dictionary of tuples containing the fact, found date and a string representation of that date, keyed off of the LegalEntityAxis members in the format {lea_member: (fact, found_date, date_str)}\n+    :param val: bal from which to gather end dates\n+    :type val: val","path":"dqc_us_rules/dqc_us_0005.py","position":25,"original_position":25,"commit_id":"c75dab1641e60bf995ddf4f7624bd6b0317f901c","original_commit_id":"c75dab1641e60bf995ddf4f7624bd6b0317f901c","user":{"login":"chrislococo-wf","id":1738147,"avatar_url":"https://avatars.githubusercontent.com/u/1738147?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislococo-wf","html_url":"https://github.com/chrislococo-wf","followers_url":"https://api.github.com/users/chrislococo-wf/followers","following_url":"https://api.github.com/users/chrislococo-wf/following{/other_user}","gists_url":"https://api.github.com/users/chrislococo-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislococo-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislococo-wf/subscriptions","organizations_url":"https://api.github.com/users/chrislococo-wf/orgs","repos_url":"https://api.github.com/users/chrislococo-wf/repos","events_url":"https://api.github.com/users/chrislococo-wf/events{/privacy}","received_events_url":"https://api.github.com/users/chrislococo-wf/received_events","type":"User","site_admin":false},"body":"SG: val is not a valid type","created_at":"2016-03-15T16:57:31Z","updated_at":"2016-03-15T16:57:31Z","html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62#discussion_r56199429","pull_request_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments/56199429"},"html":{"href":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62#discussion_r56199429"},"pull_request":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62","id":62805497,"html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62","diff_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62.diff","patch_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62.patch","issue_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/62","number":62,"state":"open","locked":false,"title":"Make everything in DQC pass flake8 tests except for the Unit Tests","user":{"login":"sagesmith-wf","id":17255946,"avatar_url":"https://avatars.githubusercontent.com/u/17255946?v=3","gravatar_id":"","url":"https://api.github.com/users/sagesmith-wf","html_url":"https://github.com/sagesmith-wf","followers_url":"https://api.github.com/users/sagesmith-wf/followers","following_url":"https://api.github.com/users/sagesmith-wf/following{/other_user}","gists_url":"https://api.github.com/users/sagesmith-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/sagesmith-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagesmith-wf/subscriptions","organizations_url":"https://api.github.com/users/sagesmith-wf/orgs","repos_url":"https://api.github.com/users/sagesmith-wf/repos","events_url":"https://api.github.com/users/sagesmith-wf/events{/privacy}","received_events_url":"https://api.github.com/users/sagesmith-wf/received_events","type":"User","site_admin":false},"body":"#### Changes:\r\n\r\n- Line lengths of everything are now under 80 character\r\n- Every function contains a summary of the function\r\n- Every function contains a comment on the usage of each parameter\r\n- Every function contains a comment on the type of each parameter\r\n- Every function with a return value contains a comment on the type of the value returned\r\n- Every function with a return value contains a summary of what is being returned\r\n- All unnecessary imports removed\r\n- All unused variables removed\r\n- All parameters of functions are lowercase\r\n\r\nPlease review: @hefischer  @andrewperkins-wf","created_at":"2016-03-14T19:41:57Z","updated_at":"2016-03-15T16:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcfbc1b94997cad35a8fc81b387d19383291e660","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62/commits","review_comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62/comments","review_comment_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/62/comments","statuses_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/c75dab1641e60bf995ddf4f7624bd6b0317f901c","head":{"label":"sagesmith-wf:xs-2879","ref":"xs-2879","sha":"c75dab1641e60bf995ddf4f7624bd6b0317f901c","user":{"login":"sagesmith-wf","id":17255946,"avatar_url":"https://avatars.githubusercontent.com/u/17255946?v=3","gravatar_id":"","url":"https://api.github.com/users/sagesmith-wf","html_url":"https://github.com/sagesmith-wf","followers_url":"https://api.github.com/users/sagesmith-wf/followers","following_url":"https://api.github.com/users/sagesmith-wf/following{/other_user}","gists_url":"https://api.github.com/users/sagesmith-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/sagesmith-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagesmith-wf/subscriptions","organizations_url":"https://api.github.com/users/sagesmith-wf/orgs","repos_url":"https://api.github.com/users/sagesmith-wf/repos","events_url":"https://api.github.com/users/sagesmith-wf/events{/privacy}","received_events_url":"https://api.github.com/users/sagesmith-wf/received_events","type":"User","site_admin":false},"repo":{"id":52021069,"name":"dqc_us_rules","full_name":"sagesmith-wf/dqc_us_rules","owner":{"login":"sagesmith-wf","id":17255946,"avatar_url":"https://avatars.githubusercontent.com/u/17255946?v=3","gravatar_id":"","url":"https://api.github.com/users/sagesmith-wf","html_url":"https://github.com/sagesmith-wf","followers_url":"https://api.github.com/users/sagesmith-wf/followers","following_url":"https://api.github.com/users/sagesmith-wf/following{/other_user}","gists_url":"https://api.github.com/users/sagesmith-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/sagesmith-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagesmith-wf/subscriptions","organizations_url":"https://api.github.com/users/sagesmith-wf/orgs","repos_url":"https://api.github.com/users/sagesmith-wf/repos","events_url":"https://api.github.com/users/sagesmith-wf/events{/privacy}","received_events_url":"https://api.github.com/users/sagesmith-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sagesmith-wf/dqc_us_rules","description":"XBRL US Data Quality Committee Rules","fork":true,"url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules","forks_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/forks","keys_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/teams","hooks_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/hooks","issue_events_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/issues/events{/number}","events_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/events","assignees_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/assignees{/user}","branches_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/branches{/branch}","tags_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/tags","blobs_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/statuses/{sha}","languages_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/languages","stargazers_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/stargazers","contributors_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/contributors","subscribers_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/subscribers","subscription_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/subscription","commits_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/contents/{+path}","compare_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/merges","archive_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/downloads","issues_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/issues{/number}","pulls_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/pulls{/number}","milestones_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/milestones{/number}","notifications_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/labels{/name}","releases_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/releases{/id}","deployments_url":"https://api.github.com/repos/sagesmith-wf/dqc_us_rules/deployments","created_at":"2016-02-18T16:23:42Z","updated_at":"2016-02-18T16:23:43Z","pushed_at":"2016-03-14T21:55:25Z","git_url":"git://github.com/sagesmith-wf/dqc_us_rules.git","ssh_url":"git@github.com:sagesmith-wf/dqc_us_rules.git","clone_url":"https://github.com/sagesmith-wf/dqc_us_rules.git","svn_url":"https://github.com/sagesmith-wf/dqc_us_rules","homepage":"http://xbrl.us/dqc","size":19416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataQualityCommittee:master","ref":"master","sha":"9148b4118bfafb6cd4cde94002e88756ccf6d248","user":{"login":"DataQualityCommittee","id":12073756,"avatar_url":"https://avatars.githubusercontent.com/u/12073756?v=3","gravatar_id":"","url":"https://api.github.com/users/DataQualityCommittee","html_url":"https://github.com/DataQualityCommittee","followers_url":"https://api.github.com/users/DataQualityCommittee/followers","following_url":"https://api.github.com/users/DataQualityCommittee/following{/other_user}","gists_url":"https://api.github.com/users/DataQualityCommittee/gists{/gist_id}","starred_url":"https://api.github.com/users/DataQualityCommittee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataQualityCommittee/subscriptions","organizations_url":"https://api.github.com/users/DataQualityCommittee/orgs","repos_url":"https://api.github.com/users/DataQualityCommittee/repos","events_url":"https://api.github.com/users/DataQualityCommittee/events{/privacy}","received_events_url":"https://api.github.com/users/DataQualityCommittee/received_events","type":"Organization","site_admin":false},"repo":{"id":38648767,"name":"dqc_us_rules","full_name":"DataQualityCommittee/dqc_us_rules","owner":{"login":"DataQualityCommittee","id":12073756,"avatar_url":"https://avatars.githubusercontent.com/u/12073756?v=3","gravatar_id":"","url":"https://api.github.com/users/DataQualityCommittee","html_url":"https://github.com/DataQualityCommittee","followers_url":"https://api.github.com/users/DataQualityCommittee/followers","following_url":"https://api.github.com/users/DataQualityCommittee/following{/other_user}","gists_url":"https://api.github.com/users/DataQualityCommittee/gists{/gist_id}","starred_url":"https://api.github.com/users/DataQualityCommittee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataQualityCommittee/subscriptions","organizations_url":"https://api.github.com/users/DataQualityCommittee/orgs","repos_url":"https://api.github.com/users/DataQualityCommittee/repos","events_url":"https://api.github.com/users/DataQualityCommittee/events{/privacy}","received_events_url":"https://api.github.com/users/DataQualityCommittee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataQualityCommittee/dqc_us_rules","description":"XBRL US Data Quality Committee Rules","fork":false,"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules","forks_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/forks","keys_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/teams","hooks_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/hooks","issue_events_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/events{/number}","events_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/events","assignees_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/assignees{/user}","branches_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/branches{/branch}","tags_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/tags","blobs_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/{sha}","languages_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/languages","stargazers_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/stargazers","contributors_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/contributors","subscribers_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/subscribers","subscription_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/subscription","commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/contents/{+path}","compare_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/merges","archive_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/downloads","issues_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues{/number}","pulls_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls{/number}","milestones_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/milestones{/number}","notifications_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/labels{/name}","releases_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/releases{/id}","deployments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/deployments","created_at":"2015-07-06T22:02:26Z","updated_at":"2016-01-28T21:19:34Z","pushed_at":"2016-03-14T21:55:25Z","git_url":"git://github.com/DataQualityCommittee/dqc_us_rules.git","ssh_url":"git@github.com:DataQualityCommittee/dqc_us_rules.git","clone_url":"https://github.com/DataQualityCommittee/dqc_us_rules.git","svn_url":"https://github.com/DataQualityCommittee/dqc_us_rules","homepage":"http://xbrl.us/dqc","size":19360,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":19,"forks":12,"open_issues":19,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62"},"html":{"href":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/62"},"issue":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/62"},"comments":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/c75dab1641e60bf995ddf4f7624bd6b0317f901c"}}}}