{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5885","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5885/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5885/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5885/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5885","id":170734692,"number":5885,"title":"showqueries debugging tool now inserts parameters in place","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-11T20:10:46Z","updated_at":"2016-08-11T23:45:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5885","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5885","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/5885.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/5885.patch"},"body":"Well, here's something to start a lively debate. Whilst I know in master we show the params at the end of the query and that there's an argument users might not realise their queries are parameterised and thus think this is literal queryies being run - I do think this is much more useful for debugging help.\r\n\r\nA list of params later on is difficult to reconcile to the right `?` when there are a lot of params. (think `IN` clauses).\r\n\r\nIf we're really against this, can I suggest that we have `?showqueries=2` which is basically \"fudge parameters\" (ie: this change)?\r\n\r\nsee #4582"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/239326457","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5885#issuecomment-239326457","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5885","id":239326457,"user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T23:45:17Z","updated_at":"2016-08-11T23:45:17Z","body":"How can you tell if the query you're debugging is parameterised or not unless you have the original query? This change would actually make it harder to track down errors in certain cases.\r\n\r\nIt's also misleading to alter what is being debugged during output.\r\n\r\nI would suggest to limit this behaviour only to showqueries=inline (explicit option rather than a magic number) so that there's no risk of being mislead."}}
{"actor":{"display_login":"tractorcow"}}