{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74838356","id":74838356,"diff_hunk":"@@ -62,7 +62,11 @@ git clean -fdx\n # docker images -q | xargs -r docker rmi\n \n # Build\n-go run ./hack/e2e.go -v --build\n+if [[ \"${KUBE_FASTBUILD:-}\" == \"true\" ]]; then","path":"hack/jenkins/build.sh","position":5,"original_position":5,"commit_id":"306617e484c45eeb4094129a85a9b70c08e0249b","original_commit_id":"306617e484c45eeb4094129a85a9b70c08e0249b","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"I think we just want to make this `make release` - it should the right thing when `KUBE_FASTBUILD` is set (which we do for PR builds, for example).\r\n\r\n(I also feel like maybe we should remove the `--build` option from `hack/e2e.go`...)","created_at":"2016-08-15T21:26:15Z","updated_at":"2016-08-15T21:26:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30640#discussion_r74838356","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74838356"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30640#discussion_r74838356"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640","id":81356533,"html_url":"https://github.com/kubernetes/kubernetes/pull/30640","diff_url":"https://github.com/kubernetes/kubernetes/pull/30640.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30640.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30640","number":30640,"state":"open","locked":false,"title":"Do make release in hack/jenkins/build.sh instead of e2e.go.","user":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"body":"#30384 and https://github.com/kubernetes/test-infra/issues/393\r\n\r\nThis will start building on other architectures again, which will break the build. Lets fix the PPC issue first.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30640)\n<!-- Reviewable:end -->\n","created_at":"2016-08-15T18:52:23Z","updated_at":"2016-08-15T21:26:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbd13b102f0cd0129bb996713f332a45de379dcc","assignee":{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30640/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/306617e484c45eeb4094129a85a9b70c08e0249b","head":{"label":"spxtr:fix-build","ref":"fix-build","sha":"306617e484c45eeb4094129a85a9b70c08e0249b","user":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"repo":{"id":46889288,"name":"kubernetes","full_name":"spxtr/kubernetes","owner":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spxtr/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/spxtr/kubernetes","forks_url":"https://api.github.com/repos/spxtr/kubernetes/forks","keys_url":"https://api.github.com/repos/spxtr/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spxtr/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spxtr/kubernetes/teams","hooks_url":"https://api.github.com/repos/spxtr/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/spxtr/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/spxtr/kubernetes/events","assignees_url":"https://api.github.com/repos/spxtr/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/spxtr/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/spxtr/kubernetes/tags","blobs_url":"https://api.github.com/repos/spxtr/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spxtr/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spxtr/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/spxtr/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spxtr/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/spxtr/kubernetes/languages","stargazers_url":"https://api.github.com/repos/spxtr/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/spxtr/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/spxtr/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/spxtr/kubernetes/subscription","commits_url":"https://api.github.com/repos/spxtr/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/spxtr/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/spxtr/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/spxtr/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/spxtr/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/spxtr/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spxtr/kubernetes/merges","archive_url":"https://api.github.com/repos/spxtr/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spxtr/kubernetes/downloads","issues_url":"https://api.github.com/repos/spxtr/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/spxtr/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/spxtr/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/spxtr/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spxtr/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/spxtr/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/spxtr/kubernetes/deployments","created_at":"2015-11-25T21:49:39Z","updated_at":"2016-01-12T01:15:27Z","pushed_at":"2016-08-15T20:50:46Z","git_url":"git://github.com/spxtr/kubernetes.git","ssh_url":"git@github.com:spxtr/kubernetes.git","clone_url":"https://github.com/spxtr/kubernetes.git","svn_url":"https://github.com/spxtr/kubernetes","homepage":"http://kubernetes.io","size":304248,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"79ed7064cae57a63a161e1bc2c7332dafd720247","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-15T21:14:51Z","pushed_at":"2016-08-15T21:26:07Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":523718,"stargazers_count":16146,"watchers_count":16146,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5136,"mirror_url":null,"open_issues_count":4173,"forks":5136,"open_issues":4173,"watchers":16146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30640"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30640"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30640/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30640/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/306617e484c45eeb4094129a85a9b70c08e0249b"}}}}
{"actor":{"display_login":"ixdy"}}