{"action":"closed","number":278,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-modal/pulls/278","id":97988100,"html_url":"https://github.com/reactjs/react-modal/pull/278","diff_url":"https://github.com/reactjs/react-modal/pull/278.diff","patch_url":"https://github.com/reactjs/react-modal/pull/278.patch","issue_url":"https://api.github.com/repos/reactjs/react-modal/issues/278","number":278,"state":"closed","locked":false,"title":"[fixed] closeTimeoutMS doesn't work without onRequestClose","user":{"login":"galimru","id":5149355,"avatar_url":"https://avatars.githubusercontent.com/u/5149355?v=3","gravatar_id":"","url":"https://api.github.com/users/galimru","html_url":"https://github.com/galimru","followers_url":"https://api.github.com/users/galimru/followers","following_url":"https://api.github.com/users/galimru/following{/other_user}","gists_url":"https://api.github.com/users/galimru/gists{/gist_id}","starred_url":"https://api.github.com/users/galimru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galimru/subscriptions","organizations_url":"https://api.github.com/users/galimru/orgs","repos_url":"https://api.github.com/users/galimru/repos","events_url":"https://api.github.com/users/galimru/events{/privacy}","received_events_url":"https://api.github.com/users/galimru/received_events","type":"User","site_admin":false},"body":"**Fixes #93** \r\n\r\n**Changes proposed:**\r\nI have no idea why we have to use closeTimeoutMS together with onRequestClose.\r\n\r\n**Acceptance Checklist:**\r\n- [x] All commits have been squashed to one.\r\n- [x] The commit message follows the guidelines in `CONTRIBUTING.md`.\r\n- [x] Documentation (README.md) and examples have been updated as needed.\r\n- [x] If this is a code change, a spec testing the functionality has been added.\r\n- [x] If the commit message has [changed] or [removed], there is an upgrade path above.\r\n\r\n","created_at":"2016-12-14T16:34:57Z","updated_at":"2016-12-15T06:15:47Z","closed_at":"2016-12-15T06:15:47Z","merged_at":"2016-12-15T06:15:47Z","merge_commit_sha":"08bf92098f6737c944708a4ee27f6080f0c42790","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/react-modal/pulls/278/commits","review_comments_url":"https://api.github.com/repos/reactjs/react-modal/pulls/278/comments","review_comment_url":"https://api.github.com/repos/reactjs/react-modal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/react-modal/issues/278/comments","statuses_url":"https://api.github.com/repos/reactjs/react-modal/statuses/170c2bcc51e7767f16295b9db48c5d85d0822f8f","head":{"label":"galimru:master","ref":"master","sha":"170c2bcc51e7767f16295b9db48c5d85d0822f8f","user":{"login":"galimru","id":5149355,"avatar_url":"https://avatars.githubusercontent.com/u/5149355?v=3","gravatar_id":"","url":"https://api.github.com/users/galimru","html_url":"https://github.com/galimru","followers_url":"https://api.github.com/users/galimru/followers","following_url":"https://api.github.com/users/galimru/following{/other_user}","gists_url":"https://api.github.com/users/galimru/gists{/gist_id}","starred_url":"https://api.github.com/users/galimru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galimru/subscriptions","organizations_url":"https://api.github.com/users/galimru/orgs","repos_url":"https://api.github.com/users/galimru/repos","events_url":"https://api.github.com/users/galimru/events{/privacy}","received_events_url":"https://api.github.com/users/galimru/received_events","type":"User","site_admin":false},"repo":{"id":76477215,"name":"react-modal","full_name":"galimru/react-modal","owner":{"login":"galimru","id":5149355,"avatar_url":"https://avatars.githubusercontent.com/u/5149355?v=3","gravatar_id":"","url":"https://api.github.com/users/galimru","html_url":"https://github.com/galimru","followers_url":"https://api.github.com/users/galimru/followers","following_url":"https://api.github.com/users/galimru/following{/other_user}","gists_url":"https://api.github.com/users/galimru/gists{/gist_id}","starred_url":"https://api.github.com/users/galimru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galimru/subscriptions","organizations_url":"https://api.github.com/users/galimru/orgs","repos_url":"https://api.github.com/users/galimru/repos","events_url":"https://api.github.com/users/galimru/events{/privacy}","received_events_url":"https://api.github.com/users/galimru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galimru/react-modal","description":"Accessible modal dialog component for React","fork":true,"url":"https://api.github.com/repos/galimru/react-modal","forks_url":"https://api.github.com/repos/galimru/react-modal/forks","keys_url":"https://api.github.com/repos/galimru/react-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galimru/react-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galimru/react-modal/teams","hooks_url":"https://api.github.com/repos/galimru/react-modal/hooks","issue_events_url":"https://api.github.com/repos/galimru/react-modal/issues/events{/number}","events_url":"https://api.github.com/repos/galimru/react-modal/events","assignees_url":"https://api.github.com/repos/galimru/react-modal/assignees{/user}","branches_url":"https://api.github.com/repos/galimru/react-modal/branches{/branch}","tags_url":"https://api.github.com/repos/galimru/react-modal/tags","blobs_url":"https://api.github.com/repos/galimru/react-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galimru/react-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galimru/react-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/galimru/react-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galimru/react-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/galimru/react-modal/languages","stargazers_url":"https://api.github.com/repos/galimru/react-modal/stargazers","contributors_url":"https://api.github.com/repos/galimru/react-modal/contributors","subscribers_url":"https://api.github.com/repos/galimru/react-modal/subscribers","subscription_url":"https://api.github.com/repos/galimru/react-modal/subscription","commits_url":"https://api.github.com/repos/galimru/react-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/galimru/react-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/galimru/react-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/galimru/react-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/galimru/react-modal/contents/{+path}","compare_url":"https://api.github.com/repos/galimru/react-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galimru/react-modal/merges","archive_url":"https://api.github.com/repos/galimru/react-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galimru/react-modal/downloads","issues_url":"https://api.github.com/repos/galimru/react-modal/issues{/number}","pulls_url":"https://api.github.com/repos/galimru/react-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/galimru/react-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/galimru/react-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galimru/react-modal/labels{/name}","releases_url":"https://api.github.com/repos/galimru/react-modal/releases{/id}","deployments_url":"https://api.github.com/repos/galimru/react-modal/deployments","created_at":"2016-12-14T16:29:12Z","updated_at":"2016-12-14T16:29:13Z","pushed_at":"2016-12-14T16:33:19Z","git_url":"git://github.com/galimru/react-modal.git","ssh_url":"git@github.com:galimru/react-modal.git","clone_url":"https://github.com/galimru/react-modal.git","svn_url":"https://github.com/galimru/react-modal","homepage":"https://reactjs.github.io/react-modal","size":5283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"ad0b07159a401298287a82adff5356c717f28a24","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":24278976,"name":"react-modal","full_name":"reactjs/react-modal","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-modal","description":"Accessible modal dialog component for React","fork":false,"url":"https://api.github.com/repos/reactjs/react-modal","forks_url":"https://api.github.com/repos/reactjs/react-modal/forks","keys_url":"https://api.github.com/repos/reactjs/react-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-modal/teams","hooks_url":"https://api.github.com/repos/reactjs/react-modal/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-modal/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-modal/events","assignees_url":"https://api.github.com/repos/reactjs/react-modal/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-modal/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-modal/tags","blobs_url":"https://api.github.com/repos/reactjs/react-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-modal/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-modal/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-modal/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-modal/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-modal/subscription","commits_url":"https://api.github.com/repos/reactjs/react-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-modal/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-modal/merges","archive_url":"https://api.github.com/repos/reactjs/react-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-modal/downloads","issues_url":"https://api.github.com/repos/reactjs/react-modal/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-modal/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-modal/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-modal/deployments","created_at":"2014-09-21T01:30:33Z","updated_at":"2016-12-15T01:23:18Z","pushed_at":"2016-12-15T06:15:47Z","git_url":"git://github.com/reactjs/react-modal.git","ssh_url":"git@github.com:reactjs/react-modal.git","clone_url":"https://github.com/reactjs/react-modal.git","svn_url":"https://github.com/reactjs/react-modal","homepage":"https://reactjs.github.io/react-modal","size":5281,"stargazers_count":1699,"watchers_count":1699,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":293,"mirror_url":null,"open_issues_count":75,"forks":293,"open_issues":75,"watchers":1699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-modal/pulls/278"},"html":{"href":"https://github.com/reactjs/react-modal/pull/278"},"issue":{"href":"https://api.github.com/repos/reactjs/react-modal/issues/278"},"comments":{"href":"https://api.github.com/repos/reactjs/react-modal/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/react-modal/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/react-modal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/react-modal/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/react-modal/statuses/170c2bcc51e7767f16295b9db48c5d85d0822f8f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"claydiffrient","id":606262,"avatar_url":"https://avatars.githubusercontent.com/u/606262?v=3","gravatar_id":"","url":"https://api.github.com/users/claydiffrient","html_url":"https://github.com/claydiffrient","followers_url":"https://api.github.com/users/claydiffrient/followers","following_url":"https://api.github.com/users/claydiffrient/following{/other_user}","gists_url":"https://api.github.com/users/claydiffrient/gists{/gist_id}","starred_url":"https://api.github.com/users/claydiffrient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claydiffrient/subscriptions","organizations_url":"https://api.github.com/users/claydiffrient/orgs","repos_url":"https://api.github.com/users/claydiffrient/repos","events_url":"https://api.github.com/users/claydiffrient/events{/privacy}","received_events_url":"https://api.github.com/users/claydiffrient/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"claydiffrient"}}