{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28","id":56187587,"html_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/28","diff_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/28.diff","patch_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/28.patch","issue_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/28","number":28,"state":"closed","locked":false,"title":"Meaningful thread name for callable establishing SSH connection","user":{"login":"ydubreuil","id":1712489,"avatar_url":"https://avatars.githubusercontent.com/u/1712489?v=3","gravatar_id":"","url":"https://api.github.com/users/ydubreuil","html_url":"https://github.com/ydubreuil","followers_url":"https://api.github.com/users/ydubreuil/followers","following_url":"https://api.github.com/users/ydubreuil/following{/other_user}","gists_url":"https://api.github.com/users/ydubreuil/gists{/gist_id}","starred_url":"https://api.github.com/users/ydubreuil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydubreuil/subscriptions","organizations_url":"https://api.github.com/users/ydubreuil/orgs","repos_url":"https://api.github.com/users/ydubreuil/repos","events_url":"https://api.github.com/users/ydubreuil/events{/privacy}","received_events_url":"https://api.github.com/users/ydubreuil/received_events","type":"User","site_admin":false},"body":"This is needed to diagnose slave connection initialization issues. Currently, SSH connection initialization is done in a  `Callable` running inside an anonymous and dedicated `ExecutorService`. If something goes wrong and connection timeout is set to 0, connection thread can get stuck and never killed. Without this, we can't find which slave is involved.\n\nBumping core dependency was required to use `NamingThreadFactory`.\n\n@reviewbybees \n","created_at":"2016-01-15T16:08:29Z","updated_at":"2016-12-01T19:43:30Z","closed_at":"2016-12-01T19:43:30Z","merged_at":"2016-12-01T19:43:30Z","merge_commit_sha":"6108ad655c6a19064bd8a5580a61b744147d5436","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/28/comments","statuses_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/6108ad655c6a19064bd8a5580a61b744147d5436","head":{"label":"ydubreuil:thread-naming","ref":"thread-naming","sha":"6108ad655c6a19064bd8a5580a61b744147d5436","user":{"login":"ydubreuil","id":1712489,"avatar_url":"https://avatars.githubusercontent.com/u/1712489?v=3","gravatar_id":"","url":"https://api.github.com/users/ydubreuil","html_url":"https://github.com/ydubreuil","followers_url":"https://api.github.com/users/ydubreuil/followers","following_url":"https://api.github.com/users/ydubreuil/following{/other_user}","gists_url":"https://api.github.com/users/ydubreuil/gists{/gist_id}","starred_url":"https://api.github.com/users/ydubreuil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydubreuil/subscriptions","organizations_url":"https://api.github.com/users/ydubreuil/orgs","repos_url":"https://api.github.com/users/ydubreuil/repos","events_url":"https://api.github.com/users/ydubreuil/events{/privacy}","received_events_url":"https://api.github.com/users/ydubreuil/received_events","type":"User","site_admin":false},"repo":{"id":49723475,"name":"ssh-slaves-plugin","full_name":"ydubreuil/ssh-slaves-plugin","owner":{"login":"ydubreuil","id":1712489,"avatar_url":"https://avatars.githubusercontent.com/u/1712489?v=3","gravatar_id":"","url":"https://api.github.com/users/ydubreuil","html_url":"https://github.com/ydubreuil","followers_url":"https://api.github.com/users/ydubreuil/followers","following_url":"https://api.github.com/users/ydubreuil/following{/other_user}","gists_url":"https://api.github.com/users/ydubreuil/gists{/gist_id}","starred_url":"https://api.github.com/users/ydubreuil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydubreuil/subscriptions","organizations_url":"https://api.github.com/users/ydubreuil/orgs","repos_url":"https://api.github.com/users/ydubreuil/repos","events_url":"https://api.github.com/users/ydubreuil/events{/privacy}","received_events_url":"https://api.github.com/users/ydubreuil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ydubreuil/ssh-slaves-plugin","description":"Jenkins ssh-slaves plugin","fork":true,"url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin","forks_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/forks","keys_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/teams","hooks_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/hooks","issue_events_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/events","assignees_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/tags","blobs_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/languages","stargazers_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/stargazers","contributors_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/contributors","subscribers_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/subscribers","subscription_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/subscription","commits_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/merges","archive_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/downloads","issues_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ydubreuil/ssh-slaves-plugin/deployments","created_at":"2016-01-15T14:28:09Z","updated_at":"2016-01-15T14:28:11Z","pushed_at":"2016-01-15T15:57:56Z","git_url":"git://github.com/ydubreuil/ssh-slaves-plugin.git","ssh_url":"git@github.com:ydubreuil/ssh-slaves-plugin.git","clone_url":"https://github.com/ydubreuil/ssh-slaves-plugin.git","svn_url":"https://github.com/ydubreuil/ssh-slaves-plugin","homepage":"http://jenkins-ci.org/","size":364,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"4793e8a4d3641ad6f99aaf3190416c72388a7d9a","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163791,"name":"ssh-slaves-plugin","full_name":"jenkinsci/ssh-slaves-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/ssh-slaves-plugin","description":"Jenkins ssh-slaves plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin","forks_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/deployments","created_at":"2010-12-13T05:56:44Z","updated_at":"2016-12-01T14:43:51Z","pushed_at":"2016-12-01T19:43:29Z","git_url":"git://github.com/jenkinsci/ssh-slaves-plugin.git","ssh_url":"git@github.com:jenkinsci/ssh-slaves-plugin.git","clone_url":"https://github.com/jenkinsci/ssh-slaves-plugin.git","svn_url":"https://github.com/jenkinsci/ssh-slaves-plugin","homepage":"http://jenkins-ci.org/","size":655,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":7,"forks":55,"open_issues":7,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28"},"html":{"href":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/28"},"issue":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/28"},"comments":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/6108ad655c6a19064bd8a5580a61b744147d5436"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"jglick"}}