{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12138","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12138/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12138/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12138/events","html_url":"https://github.com/joomla/joomla-cms/pull/12138","id":178561835,"number":12138,"title":"Custom calendar is not applied to version history preview and compare dates","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-22T09:29:45Z","updated_at":"2016-09-23T10:15:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12138","html_url":"https://github.com/joomla/joomla-cms/pull/12138","diff_url":"https://github.com/joomla/joomla-cms/pull/12138.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12138.patch"},"body":"Testing instructions:\r\nInstall the fa-IR persian language pack.\r\nEdit an article (or a category, or a newsfeed, etc.\r\nClick on the Versions toolbar button.\r\n\r\nBefore patch:\r\n![screen shot 2016-09-22 at 11 14 25](https://cloud.githubusercontent.com/assets/869724/18742698/f5fc4f40-80b5-11e6-9b02-663677648ec0.png)\r\n\r\n\r\nAfter patch\r\n![screen shot 2016-09-22 at 11 01 55](https://cloud.githubusercontent.com/assets/869724/18742428/7b64d140-80b4-11e6-84bb-a849e254e1dd.png)\r\n\r\n**Note:** the order of the date in the title, although now correctly set to Jalali is not in the same order as the other date fields below. These last ones are the same as in the Manager and in the Publishing tab date fields. This is independant from this PR\r\nThis could be solved by checkingif the language is RTL and change the order of Ymd in the models.\r\nInstead of\r\n`$object->save_date = JHtml::_('date', $table->save_date, 'Y-m-d H:i:s');`\r\nwe could use\r\n`$object->save_date = JHtml::_('date', $table->save_date, 'd-m-Y H:i:s');`\r\n\r\nAs I am not sure this would fit for all RTL languages, I did not do it.\r\nTherefore, this is already much better imho as we do get the Jalali date."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/249154667","html_url":"https://github.com/joomla/joomla-cms/pull/12138#issuecomment-249154667","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12138","id":249154667,"user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T10:15:10Z","updated_at":"2016-09-23T10:15:10Z","body":"@infograf768 one space in the foreach: `foreach (...)`"}}
{"actor":{"display_login":"dgt41"}}