{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/zevero/avr_boot/pulls/16","id":81954960,"html_url":"https://github.com/zevero/avr_boot/pull/16","diff_url":"https://github.com/zevero/avr_boot/pull/16.diff","patch_url":"https://github.com/zevero/avr_boot/pull/16.patch","issue_url":"https://api.github.com/repos/zevero/avr_boot/issues/16","number":16,"state":"open","locked":false,"title":"Define SD CS pin using standard AVR register/bit notation","user":{"login":"per1234","id":8572152,"avatar_url":"https://avatars.githubusercontent.com/u/8572152?v=3","gravatar_id":"","url":"https://api.github.com/users/per1234","html_url":"https://github.com/per1234","followers_url":"https://api.github.com/users/per1234/followers","following_url":"https://api.github.com/users/per1234/following{/other_user}","gists_url":"https://api.github.com/users/per1234/gists{/gist_id}","starred_url":"https://api.github.com/users/per1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/per1234/subscriptions","organizations_url":"https://api.github.com/users/per1234/orgs","repos_url":"https://api.github.com/users/per1234/repos","events_url":"https://api.github.com/users/per1234/events{/privacy}","received_events_url":"https://api.github.com/users/per1234/received_events","type":"User","site_admin":false},"body":"As I've started wanting to add Arduino IDE support for new boards I realized that the previous system for SD CS pin definition I created is limiting. The problem is every time I want to add a new processor or variant I need to modify asmfunc.S, cluttering it up more and more.\r\n\r\n### Pros:\r\n- Any standard ATmega microcontroller can be built for without editing source code. If a part has not been defined they only need to add it to spi_pins.h\r\n- Any SD CS pin can be built for. No longer limited to the ones I happened to have defined in asmfunc.S\r\n- Cleaner bootloader source code\r\n- Not Arduino specific - people using avr_boot may not even use Arduino boards or IDE and won't want to figure out the Arduino pin mapping for their MCU.\r\n- Easier to add Arduino IDE support for new boards - I only need to modify the gh-pages branch\r\n- The `VARIANT_1284P` name is no longer appropriate due to supporting new processors and variants\r\n- The previous system didn't lend itself well to multiple processor families with variants\r\n\r\n### Cons:\r\n- Breaks makefile backwards compatibility due to the new parameters. Some breakage may have been desirable anyways due to the increasingly inappropriate name of `VARIANT_1284P`.\r\n- Less easy for Arduino people to build the bootloader. They will now need to look up the pin mappings for their board. However, it's likely that anyone this is a problem for will be using my IDE support files instead of building from source.\r\n\r\nI have added SPI pin definitions for parts that don't have a large enough boot size for avr_boot because it was easier to just define pins for every ATmega instead of checking boot size for every one. \r\n\r\nBuilt without errors for ATmega328/P, 32U4, 1284/P, 644/P/A/PA, 324P/A/PA, 32/A, 64/A, 128/A. Tested with ATmega328P, ATmega32U4, ATmega1284P.","created_at":"2016-08-19T09:53:39Z","updated_at":"2016-08-19T09:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zevero/avr_boot/pulls/16/commits","review_comments_url":"https://api.github.com/repos/zevero/avr_boot/pulls/16/comments","review_comment_url":"https://api.github.com/repos/zevero/avr_boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zevero/avr_boot/issues/16/comments","statuses_url":"https://api.github.com/repos/zevero/avr_boot/statuses/cb6c9f74c8b59bee2311199010889423c6bc153e","head":{"label":"per1234:sd-cs-definition-alternative","ref":"sd-cs-definition-alternative","sha":"cb6c9f74c8b59bee2311199010889423c6bc153e","user":{"login":"per1234","id":8572152,"avatar_url":"https://avatars.githubusercontent.com/u/8572152?v=3","gravatar_id":"","url":"https://api.github.com/users/per1234","html_url":"https://github.com/per1234","followers_url":"https://api.github.com/users/per1234/followers","following_url":"https://api.github.com/users/per1234/following{/other_user}","gists_url":"https://api.github.com/users/per1234/gists{/gist_id}","starred_url":"https://api.github.com/users/per1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/per1234/subscriptions","organizations_url":"https://api.github.com/users/per1234/orgs","repos_url":"https://api.github.com/users/per1234/repos","events_url":"https://api.github.com/users/per1234/events{/privacy}","received_events_url":"https://api.github.com/users/per1234/received_events","type":"User","site_admin":false},"repo":{"id":65262437,"name":"avr_boot","full_name":"per1234/avr_boot","owner":{"login":"per1234","id":8572152,"avatar_url":"https://avatars.githubusercontent.com/u/8572152?v=3","gravatar_id":"","url":"https://api.github.com/users/per1234","html_url":"https://github.com/per1234","followers_url":"https://api.github.com/users/per1234/followers","following_url":"https://api.github.com/users/per1234/following{/other_user}","gists_url":"https://api.github.com/users/per1234/gists{/gist_id}","starred_url":"https://api.github.com/users/per1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/per1234/subscriptions","organizations_url":"https://api.github.com/users/per1234/orgs","repos_url":"https://api.github.com/users/per1234/repos","events_url":"https://api.github.com/users/per1234/events{/privacy}","received_events_url":"https://api.github.com/users/per1234/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/per1234/avr_boot","description":" (DEVELOPMENT FORK)Arduino Bootloader to Flash from SD Card","fork":true,"url":"https://api.github.com/repos/per1234/avr_boot","forks_url":"https://api.github.com/repos/per1234/avr_boot/forks","keys_url":"https://api.github.com/repos/per1234/avr_boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/per1234/avr_boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/per1234/avr_boot/teams","hooks_url":"https://api.github.com/repos/per1234/avr_boot/hooks","issue_events_url":"https://api.github.com/repos/per1234/avr_boot/issues/events{/number}","events_url":"https://api.github.com/repos/per1234/avr_boot/events","assignees_url":"https://api.github.com/repos/per1234/avr_boot/assignees{/user}","branches_url":"https://api.github.com/repos/per1234/avr_boot/branches{/branch}","tags_url":"https://api.github.com/repos/per1234/avr_boot/tags","blobs_url":"https://api.github.com/repos/per1234/avr_boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/per1234/avr_boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/per1234/avr_boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/per1234/avr_boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/per1234/avr_boot/statuses/{sha}","languages_url":"https://api.github.com/repos/per1234/avr_boot/languages","stargazers_url":"https://api.github.com/repos/per1234/avr_boot/stargazers","contributors_url":"https://api.github.com/repos/per1234/avr_boot/contributors","subscribers_url":"https://api.github.com/repos/per1234/avr_boot/subscribers","subscription_url":"https://api.github.com/repos/per1234/avr_boot/subscription","commits_url":"https://api.github.com/repos/per1234/avr_boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/per1234/avr_boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/per1234/avr_boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/per1234/avr_boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/per1234/avr_boot/contents/{+path}","compare_url":"https://api.github.com/repos/per1234/avr_boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/per1234/avr_boot/merges","archive_url":"https://api.github.com/repos/per1234/avr_boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/per1234/avr_boot/downloads","issues_url":"https://api.github.com/repos/per1234/avr_boot/issues{/number}","pulls_url":"https://api.github.com/repos/per1234/avr_boot/pulls{/number}","milestones_url":"https://api.github.com/repos/per1234/avr_boot/milestones{/number}","notifications_url":"https://api.github.com/repos/per1234/avr_boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/per1234/avr_boot/labels{/name}","releases_url":"https://api.github.com/repos/per1234/avr_boot/releases{/id}","deployments_url":"https://api.github.com/repos/per1234/avr_boot/deployments","created_at":"2016-08-09T04:18:46Z","updated_at":"2016-08-18T12:50:47Z","pushed_at":"2016-08-19T08:59:38Z","git_url":"git://github.com/per1234/avr_boot.git","ssh_url":"git@github.com:per1234/avr_boot.git","clone_url":"https://github.com/per1234/avr_boot.git","svn_url":"https://github.com/per1234/avr_boot","homepage":"","size":1307,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zevero:master","ref":"master","sha":"ea973ce017a181f3c3715ffdbb06ca70ded95310","user":{"login":"zevero","id":2234140,"avatar_url":"https://avatars.githubusercontent.com/u/2234140?v=3","gravatar_id":"","url":"https://api.github.com/users/zevero","html_url":"https://github.com/zevero","followers_url":"https://api.github.com/users/zevero/followers","following_url":"https://api.github.com/users/zevero/following{/other_user}","gists_url":"https://api.github.com/users/zevero/gists{/gist_id}","starred_url":"https://api.github.com/users/zevero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zevero/subscriptions","organizations_url":"https://api.github.com/users/zevero/orgs","repos_url":"https://api.github.com/users/zevero/repos","events_url":"https://api.github.com/users/zevero/events{/privacy}","received_events_url":"https://api.github.com/users/zevero/received_events","type":"User","site_admin":false},"repo":{"id":40376964,"name":"avr_boot","full_name":"zevero/avr_boot","owner":{"login":"zevero","id":2234140,"avatar_url":"https://avatars.githubusercontent.com/u/2234140?v=3","gravatar_id":"","url":"https://api.github.com/users/zevero","html_url":"https://github.com/zevero","followers_url":"https://api.github.com/users/zevero/followers","following_url":"https://api.github.com/users/zevero/following{/other_user}","gists_url":"https://api.github.com/users/zevero/gists{/gist_id}","starred_url":"https://api.github.com/users/zevero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zevero/subscriptions","organizations_url":"https://api.github.com/users/zevero/orgs","repos_url":"https://api.github.com/users/zevero/repos","events_url":"https://api.github.com/users/zevero/events{/privacy}","received_events_url":"https://api.github.com/users/zevero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zevero/avr_boot","description":" Arduino Bootloader to Flash from SD Card","fork":false,"url":"https://api.github.com/repos/zevero/avr_boot","forks_url":"https://api.github.com/repos/zevero/avr_boot/forks","keys_url":"https://api.github.com/repos/zevero/avr_boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zevero/avr_boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zevero/avr_boot/teams","hooks_url":"https://api.github.com/repos/zevero/avr_boot/hooks","issue_events_url":"https://api.github.com/repos/zevero/avr_boot/issues/events{/number}","events_url":"https://api.github.com/repos/zevero/avr_boot/events","assignees_url":"https://api.github.com/repos/zevero/avr_boot/assignees{/user}","branches_url":"https://api.github.com/repos/zevero/avr_boot/branches{/branch}","tags_url":"https://api.github.com/repos/zevero/avr_boot/tags","blobs_url":"https://api.github.com/repos/zevero/avr_boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zevero/avr_boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zevero/avr_boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/zevero/avr_boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zevero/avr_boot/statuses/{sha}","languages_url":"https://api.github.com/repos/zevero/avr_boot/languages","stargazers_url":"https://api.github.com/repos/zevero/avr_boot/stargazers","contributors_url":"https://api.github.com/repos/zevero/avr_boot/contributors","subscribers_url":"https://api.github.com/repos/zevero/avr_boot/subscribers","subscription_url":"https://api.github.com/repos/zevero/avr_boot/subscription","commits_url":"https://api.github.com/repos/zevero/avr_boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/zevero/avr_boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/zevero/avr_boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/zevero/avr_boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/zevero/avr_boot/contents/{+path}","compare_url":"https://api.github.com/repos/zevero/avr_boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zevero/avr_boot/merges","archive_url":"https://api.github.com/repos/zevero/avr_boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zevero/avr_boot/downloads","issues_url":"https://api.github.com/repos/zevero/avr_boot/issues{/number}","pulls_url":"https://api.github.com/repos/zevero/avr_boot/pulls{/number}","milestones_url":"https://api.github.com/repos/zevero/avr_boot/milestones{/number}","notifications_url":"https://api.github.com/repos/zevero/avr_boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zevero/avr_boot/labels{/name}","releases_url":"https://api.github.com/repos/zevero/avr_boot/releases{/id}","deployments_url":"https://api.github.com/repos/zevero/avr_boot/deployments","created_at":"2015-08-07T19:16:48Z","updated_at":"2016-06-28T01:29:52Z","pushed_at":"2016-08-19T09:53:39Z","git_url":"git://github.com/zevero/avr_boot.git","ssh_url":"git@github.com:zevero/avr_boot.git","clone_url":"https://github.com/zevero/avr_boot.git","svn_url":"https://github.com/zevero/avr_boot","homepage":null,"size":1301,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zevero/avr_boot/pulls/16"},"html":{"href":"https://github.com/zevero/avr_boot/pull/16"},"issue":{"href":"https://api.github.com/repos/zevero/avr_boot/issues/16"},"comments":{"href":"https://api.github.com/repos/zevero/avr_boot/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/zevero/avr_boot/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/zevero/avr_boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zevero/avr_boot/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/zevero/avr_boot/statuses/cb6c9f74c8b59bee2311199010889423c6bc153e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":63,"deletions":162,"changed_files":4}}
{"actor":{"display_login":"per1234"}}