{"action":"created","issue":{"url":"https://api.github.com/repos/LABSN/expyfun/issues/266","repository_url":"https://api.github.com/repos/LABSN/expyfun","labels_url":"https://api.github.com/repos/LABSN/expyfun/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/LABSN/expyfun/issues/266/comments","events_url":"https://api.github.com/repos/LABSN/expyfun/issues/266/events","html_url":"https://github.com/LABSN/expyfun/pull/266","id":134100929,"number":266,"title":"FIX: Bigger buffer and auto-stop","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-16T21:25:15Z","updated_at":"2016-04-27T17:22:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LABSN/expyfun/pulls/266","html_url":"https://github.com/LABSN/expyfun/pull/266","diff_url":"https://github.com/LABSN/expyfun/pull/266.diff","patch_url":"https://github.com/LABSN/expyfun/pull/266.patch"},"body":"This PR:\r\n\r\n1. Doubles our buffer size to 4e6\r\n2. Reduces circuit complexity\r\n3. Reduces CPU load ~80% -> ~70%\r\n4. Automatically stops+resets the buffer once playback completes\r\n\r\nTodo:\r\n\r\n* [x] Add checking of `load_buffer` size <= allowed size.\r\n* [x] Check it runs on RP2 at UW.\r\n* [x] Check triggers on RP2 (can use EEG system for this).\r\n* [ ] Modify RZ6.\r\n* [ ] Check RZ6 triggers still work."},"comment":{"url":"https://api.github.com/repos/LABSN/expyfun/issues/comments/215158017","html_url":"https://github.com/LABSN/expyfun/pull/266#issuecomment-215158017","issue_url":"https://api.github.com/repos/LABSN/expyfun/issues/266","id":215158017,"user":{"login":"drammock","id":1810515,"avatar_url":"https://avatars.githubusercontent.com/u/1810515?v=3","gravatar_id":"","url":"https://api.github.com/users/drammock","html_url":"https://github.com/drammock","followers_url":"https://api.github.com/users/drammock/followers","following_url":"https://api.github.com/users/drammock/following{/other_user}","gists_url":"https://api.github.com/users/drammock/gists{/gist_id}","starred_url":"https://api.github.com/users/drammock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drammock/subscriptions","organizations_url":"https://api.github.com/users/drammock/orgs","repos_url":"https://api.github.com/users/drammock/repos","events_url":"https://api.github.com/users/drammock/events{/privacy}","received_events_url":"https://api.github.com/users/drammock/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T17:22:26Z","updated_at":"2016-04-27T17:22:26Z","body":"I recommend testing with tones rather than clicks, e.g., load a 1 sec 1kHz tone, followed by a 0.5 sec 700 Hz tone, and see if you hear a tiny bit of the higher tone at the end of the (shorter) lower tone."}}