{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/68370713","id":68370713,"diff_hunk":"@@ -36,14 +36,13 @@ the Mantid :ref:`ConvertUnits <algm-ConvertUnits>`. See also\n :ref:`EnggFitDIFCFromPeaks <algm-EnggFitDIFCFromPeaks>`.\n \n This algorithm currently fits (single) peaks of type\n-:ref:`Back2BackExponential <func-Back2BackExponential>`. Other\n+:ref:`Back2BackExponential <func-BackToBackExponential>`. Other\n alternatives might be added as optional in the future (for example the\n simpler :ref:`Gaussian <func-Gaussian>` or the more complex\n-:ref:`Bk2BkExpConvPV <func-Bk2BkExpConvPV` or :ref:`IkedaCarpenterPV\n-<func-IkedaCarpenterPV>`). To produce an initial guess for the peak\n-function parameters this algorithm uses the :ref:`FindPeaks\n-<algm-FindPeaks>` algorithm starting from the expected peaks list\n-given in the inputs.\n+:ref:`Bk2BkExpConvPV <func-NeutronBk2BkExpConvPVoigt>` or :ref:`IkedaCarpenterPV <func-IkedaCarpenterPV>`). To","path":"docs/source/algorithms/EnggFitPeaks-v1.rst","position":13,"original_position":13,"commit_id":"3a8a181e6666d3b4a432afefaf3422a68d81c11e","original_commit_id":"9db47a8f46909f1538267e28467f0420aeb7ef05","user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"body":"Good catch. I thought I read in a file that Bk2BkExpConvPV had just been renamed but I must have misunderstood.\r\n\r\nI think you are correct, it should not have a link if one does not exist. I'll take it out.","created_at":"2016-06-24T08:56:36Z","updated_at":"2016-06-24T08:56:36Z","html_url":"https://github.com/mantidproject/mantid/pull/16698#discussion_r68370713","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16698","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/68370713"},"html":{"href":"https://github.com/mantidproject/mantid/pull/16698#discussion_r68370713"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16698"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16698","id":74785265,"html_url":"https://github.com/mantidproject/mantid/pull/16698","diff_url":"https://github.com/mantidproject/mantid/pull/16698.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16698.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16698","number":16698,"state":"open","locked":false,"title":"Fix warnings and errors in docs build","user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"body":"Fixes the warnings & errors that are present in a build of the documentation.\r\n\r\n**To test:**\r\n\r\nRemove the `build/docs/html` & `build/docs/doctrees` directories and build the documentation. Build the html documentation and check that there are no errors. Note that you will need `MAKE_VATES=ON` to avoid warnings around `SaveWorkspaceToVTK`.\r\n\r\nNo issue number.\r\n\r\n*Does not need to be in the release notes.*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-06-22T13:38:07Z","updated_at":"2016-06-24T08:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab98cc060934d39ce98e5194bd89345f311d15de","assignee":{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":636,"closed_issues":195,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-06-24T08:01:12Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16698/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16698/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16698/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/3a8a181e6666d3b4a432afefaf3422a68d81c11e","head":{"label":"mantidproject:fix-sphinx-build-errors","ref":"fix-sphinx-build-errors","sha":"3a8a181e6666d3b4a432afefaf3422a68d81c11e","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-06-23T11:40:43Z","pushed_at":"2016-06-24T08:41:44Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":423472,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":1546,"forks":32,"open_issues":1546,"watchers":43,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"141dbd5a00b9e85461f91e97d2f47aee069f2677","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-06-23T11:40:43Z","pushed_at":"2016-06-24T08:41:44Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":423472,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":1546,"forks":32,"open_issues":1546,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16698"},"html":{"href":"https://github.com/mantidproject/mantid/pull/16698"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/16698"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/16698/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16698/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16698/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/3a8a181e6666d3b4a432afefaf3422a68d81c11e"}}}}
{"actor":{"display_login":"martyngigg"}}