{"action":"created","comment":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79194543","id":79194543,"diff_hunk":"@@ -216,7 +222,7 @@ func NewCmdManualBootstrapJoinNode(out io.Writer, s *kubeadmapi.KubeadmConfig) *\n \tcmd.PersistentFlags().StringVarP(&s.ManualFlags.ApiServerURLs, \"api-server-urls\", \"\", \"\",\n \t\t`Comma separated list of API server URLs. Typically this might be just\n \t\thttps://<address-of-master>:8080/`)\n-\tcmd.PersistentFlags().StringVarP(&s.ManualFlags.BearerToken, \"token\", \"\", \"\",\n+\tcmd.PersistentFlags().StringVarP(&s.Secrets.BearerToken, \"token\", \"\", \"\",","path":"pkg/kubeadm/cmd/manual.go","position":20,"original_position":20,"commit_id":"9e3285e29f810208db44690091d669b393f525e1","original_commit_id":"9e3285e29f810208db44690091d669b393f525e1","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"body":"Well spotted, thanks!","created_at":"2016-09-16T15:36:15Z","updated_at":"2016-09-16T15:36:15Z","html_url":"https://github.com/errordeveloper/kubernetes/pull/11#discussion_r79194543","pull_request_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79194543"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/11#discussion_r79194543"},"pull_request":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11","id":85555363,"html_url":"https://github.com/errordeveloper/kubernetes/pull/11","diff_url":"https://github.com/errordeveloper/kubernetes/pull/11.diff","patch_url":"https://github.com/errordeveloper/kubernetes/pull/11.patch","issue_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/11","number":11,"state":"open","locked":false,"title":"Fix cluster CIDR + Fix wrong bearer token ref","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"body":"@errordeveloper Hi, I've been following the sig-cluster-lifecycle for a while, and I am interested in what you guys are doing :) I like it a lot.\r\n\r\nI've been testing out `kubeadm` for the last couple of days and I managed to provision an operational cluster on 2 Ubuntu Xenial nodes. However, I had to introduce the following changes in the code:\r\n\r\n* For some reason the Services CIDR was passed as Cluster CIDR to the controller-manager. Cluster CIDR is there for the pod network, however, so I don't think that was OK. A lot of the current provisioning projects (e.g. bootkube, kube-deploy/docker-multinode) use flannel as an overlay, and without my changes  flannel won't work\r\n\r\n* There was a small bug in the `manual bootstrap`, when the bearer token is referenced in the code.\r\n\r\nIf you need help on any open topics just ping me, I'd be glad to contribute :) \r\n\r\n@kenan435 @cheld","created_at":"2016-09-16T11:09:06Z","updated_at":"2016-09-16T15:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73f5a5113fcc93f1f57bd198acbe7d11f930d454","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11/commits","review_comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11/comments","review_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/11/comments","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/9e3285e29f810208db44690091d669b393f525e1","head":{"label":"taimir:kubeadm","ref":"kubeadm","sha":"9e3285e29f810208db44690091d669b393f525e1","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"repo":{"id":52962277,"name":"kubernetes","full_name":"taimir/kubernetes","owner":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taimir/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/taimir/kubernetes","forks_url":"https://api.github.com/repos/taimir/kubernetes/forks","keys_url":"https://api.github.com/repos/taimir/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taimir/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taimir/kubernetes/teams","hooks_url":"https://api.github.com/repos/taimir/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/taimir/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/taimir/kubernetes/events","assignees_url":"https://api.github.com/repos/taimir/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/taimir/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/taimir/kubernetes/tags","blobs_url":"https://api.github.com/repos/taimir/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taimir/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taimir/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/taimir/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taimir/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/taimir/kubernetes/languages","stargazers_url":"https://api.github.com/repos/taimir/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/taimir/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/taimir/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/taimir/kubernetes/subscription","commits_url":"https://api.github.com/repos/taimir/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/taimir/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/taimir/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/taimir/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/taimir/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/taimir/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taimir/kubernetes/merges","archive_url":"https://api.github.com/repos/taimir/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taimir/kubernetes/downloads","issues_url":"https://api.github.com/repos/taimir/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/taimir/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/taimir/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/taimir/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taimir/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/taimir/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/taimir/kubernetes/deployments","created_at":"2016-03-02T12:48:56Z","updated_at":"2016-03-02T12:49:09Z","pushed_at":"2016-09-16T14:50:14Z","git_url":"git://github.com/taimir/kubernetes.git","ssh_url":"git@github.com:taimir/kubernetes.git","clone_url":"https://github.com/taimir/kubernetes.git","svn_url":"https://github.com/taimir/kubernetes","homepage":"http://kubernetes.io","size":319685,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errordeveloper:kubeadm","ref":"kubeadm","sha":"55d852a306f831f7b50d62c45ff6a4fc862a3244","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":25202727,"name":"kubernetes","full_name":"errordeveloper/kubernetes","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/errordeveloper/kubernetes","forks_url":"https://api.github.com/repos/errordeveloper/kubernetes/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubernetes/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubernetes/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubernetes/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubernetes/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubernetes/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubernetes/deployments","created_at":"2014-10-14T11:13:25Z","updated_at":"2016-03-23T12:29:37Z","pushed_at":"2016-09-16T15:34:23Z","git_url":"git://github.com/errordeveloper/kubernetes.git","ssh_url":"git@github.com:errordeveloper/kubernetes.git","clone_url":"https://github.com/errordeveloper/kubernetes.git","svn_url":"https://github.com/errordeveloper/kubernetes","homepage":null,"size":315546,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/11"},"issue":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/11"},"comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/9e3285e29f810208db44690091d669b393f525e1"}}}}
{"actor":{"display_login":"errordeveloper"}}