{"action":"created","issue":{"url":"https://api.github.com/repos/padsley/k600analyser/issues/88","repository_url":"https://api.github.com/repos/padsley/k600analyser","labels_url":"https://api.github.com/repos/padsley/k600analyser/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/padsley/k600analyser/issues/88/comments","events_url":"https://api.github.com/repos/padsley/k600analyser/issues/88/events","html_url":"https://github.com/padsley/k600analyser/pull/88","id":134213429,"number":88,"title":"Setup dev retief","user":{"login":"neveling","id":8490543,"avatar_url":"https://avatars.githubusercontent.com/u/8490543?v=3","gravatar_id":"","url":"https://api.github.com/users/neveling","html_url":"https://github.com/neveling","followers_url":"https://api.github.com/users/neveling/followers","following_url":"https://api.github.com/users/neveling/following{/other_user}","gists_url":"https://api.github.com/users/neveling/gists{/gist_id}","starred_url":"https://api.github.com/users/neveling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neveling/subscriptions","organizations_url":"https://api.github.com/users/neveling/orgs","repos_url":"https://api.github.com/users/neveling/repos","events_url":"https://api.github.com/users/neveling/events{/privacy}","received_events_url":"https://api.github.com/users/neveling/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"padsley","id":8112824,"avatar_url":"https://avatars.githubusercontent.com/u/8112824?v=3","gravatar_id":"","url":"https://api.github.com/users/padsley","html_url":"https://github.com/padsley","followers_url":"https://api.github.com/users/padsley/followers","following_url":"https://api.github.com/users/padsley/following{/other_user}","gists_url":"https://api.github.com/users/padsley/gists{/gist_id}","starred_url":"https://api.github.com/users/padsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padsley/subscriptions","organizations_url":"https://api.github.com/users/padsley/orgs","repos_url":"https://api.github.com/users/padsley/repos","events_url":"https://api.github.com/users/padsley/events{/privacy}","received_events_url":"https://api.github.com/users/padsley/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-02-17T08:24:42Z","updated_at":"2016-02-17T15:33:08Z","closed_at":"2016-02-17T09:28:47Z","pull_request":{"url":"https://api.github.com/repos/padsley/k600analyser/pulls/88","html_url":"https://github.com/padsley/k600analyser/pull/88","diff_url":"https://github.com/padsley/k600analyser/pull/88.diff","patch_url":"https://github.com/padsley/k600analyser/pull/88.patch"},"body":"A brief description of changes:\r\n\r\nWe no longer have a file called f-plane.c; it is replaced with main.c\r\n\r\nThe code is now structured so that most of the subroutines that used to be in f-plane.c are now moved to FocalPlane.c with definitions to FocalPlane.h.\r\n\r\nThe ANA_MODULE focalplane_module was changed to main_module, and accordingly we have main_event, main_bor, main_eor and main_init instead of focal_event etc. These changes are affected in both analyzer.c and main.c These are just naming conventions that I feel is more logical.\r\n\r\nAlso, a lot of variable definitions that used to be in f-plane.c is moved to parameters.h\r\n\r\nThe codes adc.c and qdc.c were cleaned up. A lot of code that was commented out for the past few years were deleted. Similarly a lot of dead weight code in f-plane.c (now main.c) were deleted. These include provision for histograms for NaI and Si detectors, which is now handled entirely by GammaData.c HagarSort.c MMM.c SiliconData.c W1.c etc.\r\n\r\nThe raytracing code was improved to include fixZ and fixX subroutines. The chisq calculation was changed to a rsquared calculation (the chi sq value was never the proper chisq value in any case)\r\n\r\nA small 3mm adjustment was made to the Y calculation.\r\n\r\nThe code is still not as I want it to be.\r\n\r\nThe main aim is to take out all the VDC content and move it out to a FocalplaneDATA.c/h and VDC.c/h structure that will mimic the structure Phil created for e.g. SiliconDATA.c/h and MMM.c/h. So far all that was done is the first step: to make f-plane.c into main.c, and to take out all the subroutines in this file (that makes it so difficult to read) out to a temporary Focalplane.c/h structure...\r\n\r\nWhat I would also still like to do is to make sure all angle calcs, line shape corrections etc use parameters from the config file. Lets do away with the use of the ODB for these!\r\n\r\nFinaly: I added some comments to config.cfg,  making it prettier in my eyes (^:\r\n"},"comment":{"url":"https://api.github.com/repos/padsley/k600analyser/issues/comments/185256492","html_url":"https://github.com/padsley/k600analyser/pull/88#issuecomment-185256492","issue_url":"https://api.github.com/repos/padsley/k600analyser/issues/88","id":185256492,"user":{"login":"padsley","id":8112824,"avatar_url":"https://avatars.githubusercontent.com/u/8112824?v=3","gravatar_id":"","url":"https://api.github.com/users/padsley","html_url":"https://github.com/padsley","followers_url":"https://api.github.com/users/padsley/followers","following_url":"https://api.github.com/users/padsley/following{/other_user}","gists_url":"https://api.github.com/users/padsley/gists{/gist_id}","starred_url":"https://api.github.com/users/padsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padsley/subscriptions","organizations_url":"https://api.github.com/users/padsley/orgs","repos_url":"https://api.github.com/users/padsley/repos","events_url":"https://api.github.com/users/padsley/events{/privacy}","received_events_url":"https://api.github.com/users/padsley/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T15:33:08Z","updated_at":"2016-02-17T15:33:08Z","body":"Right. Given the information in issue #89, I've restored the SetupDevRetief branch so that I can see the possible differences between the old main.c in that any anything newer."}}