{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/89085428","pull_request_review_id":9634616,"id":89085428,"diff_hunk":"@@ -52,13 +52,18 @@ double PiecewiseLinearInterpolation::getValue(double pnt_to_interpolate) const\n                                     pnt_to_interpolate));\n     std::size_t const interval_idx = std::distance(_supp_pnts.begin(), it) - 1;\n \n+    // support points.\n+    double const x = _supp_pnts[interval_idx];\n+    double const x_r = _supp_pnts[interval_idx + 1];\n+\n+    // values.\n+    double const f = _values_at_supp_pnts[interval_idx];\n+    double const f_r = _values_at_supp_pnts[interval_idx + 1];\n+\n     // compute linear interpolation polynom: y = m * (x - support[i]) + value[i]\n-    const double m((_values_at_supp_pnts[interval_idx + 1] -\n-                    _values_at_supp_pnts[interval_idx]) /\n-                   (_supp_pnts[interval_idx + 1] - _supp_pnts[interval_idx]));\n+    const double m = (f_r - f) / (x_r - x);\n \n-    return m * (pnt_to_interpolate - _supp_pnts[interval_idx]) +\n-           _values_at_supp_pnts[interval_idx];\n+    return m * (pnt_to_interpolate - x) + f;\n }\n \n double PiecewiseLinearInterpolation::getDerivative(","path":"MathLib/InterpolationAlgorithms/PiecewiseLinearInterpolation.cpp","position":23,"original_position":23,"commit_id":"b55b8e3c48d8c20db88f5bc7ae0de2e62ab9373c","original_commit_id":"b55b8e3c48d8c20db88f5bc7ae0de2e62ab9373c","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"It would be good if the implementation would be (re)moved from the class since it neither computes the derivative nor it computes the gradient of a piecewise linear function.","created_at":"2016-11-22T10:34:00Z","updated_at":"2016-11-22T10:34:00Z","html_url":"https://github.com/ufz/ogs/pull/1561#discussion_r89085428","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1561","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/89085428"},"html":{"href":"https://github.com/ufz/ogs/pull/1561#discussion_r89085428"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1561"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1561","id":94646395,"html_url":"https://github.com/ufz/ogs/pull/1561","diff_url":"https://github.com/ufz/ogs/pull/1561.diff","patch_url":"https://github.com/ufz/ogs/pull/1561.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1561","number":1561,"state":"open","locked":false,"title":"Richards flow optimizations","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"A forgotten branch with small improvements.","created_at":"2016-11-21T16:17:12Z","updated_at":"2016-11-22T10:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30aabf4e9f27695b5037e66b02d071c456bb9562","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1561/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1561/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1561/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/b55b8e3c48d8c20db88f5bc7ae0de2e62ab9373c","head":{"label":"endJunction:RichardsFlowOptimizations","ref":"RichardsFlowOptimizations","sha":"b55b8e3c48d8c20db88f5bc7ae0de2e62ab9373c","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"repo":{"id":6429859,"name":"ogs","full_name":"endJunction/ogs","owner":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endJunction/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/endJunction/ogs","forks_url":"https://api.github.com/repos/endJunction/ogs/forks","keys_url":"https://api.github.com/repos/endJunction/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endJunction/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endJunction/ogs/teams","hooks_url":"https://api.github.com/repos/endJunction/ogs/hooks","issue_events_url":"https://api.github.com/repos/endJunction/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/endJunction/ogs/events","assignees_url":"https://api.github.com/repos/endJunction/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/endJunction/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/endJunction/ogs/tags","blobs_url":"https://api.github.com/repos/endJunction/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endJunction/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endJunction/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/endJunction/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endJunction/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/endJunction/ogs/languages","stargazers_url":"https://api.github.com/repos/endJunction/ogs/stargazers","contributors_url":"https://api.github.com/repos/endJunction/ogs/contributors","subscribers_url":"https://api.github.com/repos/endJunction/ogs/subscribers","subscription_url":"https://api.github.com/repos/endJunction/ogs/subscription","commits_url":"https://api.github.com/repos/endJunction/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/endJunction/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/endJunction/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/endJunction/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/endJunction/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/endJunction/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endJunction/ogs/merges","archive_url":"https://api.github.com/repos/endJunction/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endJunction/ogs/downloads","issues_url":"https://api.github.com/repos/endJunction/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/endJunction/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/endJunction/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/endJunction/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endJunction/ogs/labels{/name}","releases_url":"https://api.github.com/repos/endJunction/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/endJunction/ogs/deployments","created_at":"2012-10-28T17:18:48Z","updated_at":"2016-10-30T10:09:59Z","pushed_at":"2016-11-21T23:12:32Z","git_url":"git://github.com/endJunction/ogs.git","ssh_url":"git@github.com:endJunction/ogs.git","clone_url":"https://github.com/endJunction/ogs.git","svn_url":"https://github.com/endJunction/ogs","homepage":"www.opengeosys.net","size":31289,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"dff98b29343b5b11f2f41e5ff2d3b12664e9f8ef","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-10-24T08:18:46Z","pushed_at":"2016-11-22T09:11:26Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":27088,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":96,"forks":55,"open_issues":96,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1561"},"html":{"href":"https://github.com/ufz/ogs/pull/1561"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1561"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1561/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1561/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1561/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/b55b8e3c48d8c20db88f5bc7ae0de2e62ab9373c"}}}}
{"actor":{"display_login":"TomFischer"}}