{"action":"created","comment":{"url":"https://api.github.com/repos/9livesdata/whylog/pulls/comments/63775490","id":63775490,"diff_hunk":"@@ -166,12 +156,61 @@ def set_causes_relation(self, relation):\n         \"\"\"\n         pass\n \n-    def _verify(self):\n-        \"\"\"\n-        Verifies if text patterns and constraints meet all requirements.\n-        E.g it is required text pattern match its line in one way only.\n-        \"\"\"\n-        pass\n+    def _validate_primary_keys(self):\n+        errors = []\n+        for line_id in six.iterkeys(self._parsers):\n+            primary_key = self._parsers[line_id].primary_key\n+            pattern_match = self.pattern_assistant.get_pattern_match(line_id)\n+            group_numbers = pattern_match.param_groups.keys()\n+            if set(primary_key) - set(group_numbers):\n+                errors.append(WrongPrimaryKeyProblem(primary_key, group_numbers, line_id))\n+        return ValidationResult(errors=errors, warnings=[])\n+\n+    def name_is_duplicated(self, searched_name, names):\n+        count = 0\n+        for name in names:\n+            if name == searched_name:\n+                count += 1\n+        return count > 1\n+\n+    def _validate_pattern_names(self):\n+        errors = []\n+        names_blacklist = self._get_names_blacklist()\n+        for line_id in six.iterkeys(self._parsers):\n+            parser = self._parsers[line_id]\n+            blacklist_except_name = set(names_blacklist) - set([parser.name])\n+            if self.name_is_duplicated(parser.name, names_blacklist) or \\\n+                    not self.config.is_free_parser_name(parser.name, blacklist_except_name):\n+                errors.append(NotUniqueParserNameProblem(line_id))\n+        return ValidationResult(errors=errors, warnings=[])\n+\n+    def _validate_log_type(self):","path":"whylog/teacher/__init__.py","position":112,"original_position":112,"commit_id":"6001b3374142d5590a3c0b088d84dfb30e99af53","original_commit_id":"6001b3374142d5590a3c0b088d84dfb30e99af53","user":{"login":"andrzejgorski","id":13272962,"avatar_url":"https://avatars.githubusercontent.com/u/13272962?v=3","gravatar_id":"","url":"https://api.github.com/users/andrzejgorski","html_url":"https://github.com/andrzejgorski","followers_url":"https://api.github.com/users/andrzejgorski/followers","following_url":"https://api.github.com/users/andrzejgorski/following{/other_user}","gists_url":"https://api.github.com/users/andrzejgorski/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzejgorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzejgorski/subscriptions","organizations_url":"https://api.github.com/users/andrzejgorski/orgs","repos_url":"https://api.github.com/users/andrzejgorski/repos","events_url":"https://api.github.com/users/andrzejgorski/events{/privacy}","received_events_url":"https://api.github.com/users/andrzejgorski/received_events","type":"User","site_admin":false},"body":"Move this function to new Validator class.","created_at":"2016-05-18T20:26:03Z","updated_at":"2016-05-18T20:26:03Z","html_url":"https://github.com/9livesdata/whylog/pull/143#discussion_r63775490","pull_request_url":"https://api.github.com/repos/9livesdata/whylog/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/comments/63775490"},"html":{"href":"https://github.com/9livesdata/whylog/pull/143#discussion_r63775490"},"pull_request":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/9livesdata/whylog/pulls/143","id":70578334,"html_url":"https://github.com/9livesdata/whylog/pull/143","diff_url":"https://github.com/9livesdata/whylog/pull/143.diff","patch_url":"https://github.com/9livesdata/whylog/pull/143.patch","issue_url":"https://api.github.com/repos/9livesdata/whylog/issues/143","number":143,"state":"open","locked":false,"title":"Teacher rule validation","user":{"login":"epawlowska","id":15253107,"avatar_url":"https://avatars.githubusercontent.com/u/15253107?v=3","gravatar_id":"","url":"https://api.github.com/users/epawlowska","html_url":"https://github.com/epawlowska","followers_url":"https://api.github.com/users/epawlowska/followers","following_url":"https://api.github.com/users/epawlowska/following{/other_user}","gists_url":"https://api.github.com/users/epawlowska/gists{/gist_id}","starred_url":"https://api.github.com/users/epawlowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epawlowska/subscriptions","organizations_url":"https://api.github.com/users/epawlowska/orgs","repos_url":"https://api.github.com/users/epawlowska/repos","events_url":"https://api.github.com/users/epawlowska/events{/privacy}","received_events_url":"https://api.github.com/users/epawlowska/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-18T18:40:18Z","updated_at":"2016-05-18T20:26:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12fde4a26cd7121ab1e4f89b49ba88f94a538365","assignee":{"login":"andrzejgorski","id":13272962,"avatar_url":"https://avatars.githubusercontent.com/u/13272962?v=3","gravatar_id":"","url":"https://api.github.com/users/andrzejgorski","html_url":"https://github.com/andrzejgorski","followers_url":"https://api.github.com/users/andrzejgorski/followers","following_url":"https://api.github.com/users/andrzejgorski/following{/other_user}","gists_url":"https://api.github.com/users/andrzejgorski/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzejgorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzejgorski/subscriptions","organizations_url":"https://api.github.com/users/andrzejgorski/orgs","repos_url":"https://api.github.com/users/andrzejgorski/repos","events_url":"https://api.github.com/users/andrzejgorski/events{/privacy}","received_events_url":"https://api.github.com/users/andrzejgorski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/9livesdata/whylog/pulls/143/commits","review_comments_url":"https://api.github.com/repos/9livesdata/whylog/pulls/143/comments","review_comment_url":"https://api.github.com/repos/9livesdata/whylog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/9livesdata/whylog/issues/143/comments","statuses_url":"https://api.github.com/repos/9livesdata/whylog/statuses/6001b3374142d5590a3c0b088d84dfb30e99af53","head":{"label":"epawlowska:teacher_rule_validation","ref":"teacher_rule_validation","sha":"6001b3374142d5590a3c0b088d84dfb30e99af53","user":{"login":"epawlowska","id":15253107,"avatar_url":"https://avatars.githubusercontent.com/u/15253107?v=3","gravatar_id":"","url":"https://api.github.com/users/epawlowska","html_url":"https://github.com/epawlowska","followers_url":"https://api.github.com/users/epawlowska/followers","following_url":"https://api.github.com/users/epawlowska/following{/other_user}","gists_url":"https://api.github.com/users/epawlowska/gists{/gist_id}","starred_url":"https://api.github.com/users/epawlowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epawlowska/subscriptions","organizations_url":"https://api.github.com/users/epawlowska/orgs","repos_url":"https://api.github.com/users/epawlowska/repos","events_url":"https://api.github.com/users/epawlowska/events{/privacy}","received_events_url":"https://api.github.com/users/epawlowska/received_events","type":"User","site_admin":false},"repo":{"id":46919661,"name":"whylog","full_name":"epawlowska/whylog","owner":{"login":"epawlowska","id":15253107,"avatar_url":"https://avatars.githubusercontent.com/u/15253107?v=3","gravatar_id":"","url":"https://api.github.com/users/epawlowska","html_url":"https://github.com/epawlowska","followers_url":"https://api.github.com/users/epawlowska/followers","following_url":"https://api.github.com/users/epawlowska/following{/other_user}","gists_url":"https://api.github.com/users/epawlowska/gists{/gist_id}","starred_url":"https://api.github.com/users/epawlowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epawlowska/subscriptions","organizations_url":"https://api.github.com/users/epawlowska/orgs","repos_url":"https://api.github.com/users/epawlowska/repos","events_url":"https://api.github.com/users/epawlowska/events{/privacy}","received_events_url":"https://api.github.com/users/epawlowska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epawlowska/whylog","description":"","fork":true,"url":"https://api.github.com/repos/epawlowska/whylog","forks_url":"https://api.github.com/repos/epawlowska/whylog/forks","keys_url":"https://api.github.com/repos/epawlowska/whylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epawlowska/whylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epawlowska/whylog/teams","hooks_url":"https://api.github.com/repos/epawlowska/whylog/hooks","issue_events_url":"https://api.github.com/repos/epawlowska/whylog/issues/events{/number}","events_url":"https://api.github.com/repos/epawlowska/whylog/events","assignees_url":"https://api.github.com/repos/epawlowska/whylog/assignees{/user}","branches_url":"https://api.github.com/repos/epawlowska/whylog/branches{/branch}","tags_url":"https://api.github.com/repos/epawlowska/whylog/tags","blobs_url":"https://api.github.com/repos/epawlowska/whylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epawlowska/whylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epawlowska/whylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/epawlowska/whylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epawlowska/whylog/statuses/{sha}","languages_url":"https://api.github.com/repos/epawlowska/whylog/languages","stargazers_url":"https://api.github.com/repos/epawlowska/whylog/stargazers","contributors_url":"https://api.github.com/repos/epawlowska/whylog/contributors","subscribers_url":"https://api.github.com/repos/epawlowska/whylog/subscribers","subscription_url":"https://api.github.com/repos/epawlowska/whylog/subscription","commits_url":"https://api.github.com/repos/epawlowska/whylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/epawlowska/whylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/epawlowska/whylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/epawlowska/whylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/epawlowska/whylog/contents/{+path}","compare_url":"https://api.github.com/repos/epawlowska/whylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epawlowska/whylog/merges","archive_url":"https://api.github.com/repos/epawlowska/whylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epawlowska/whylog/downloads","issues_url":"https://api.github.com/repos/epawlowska/whylog/issues{/number}","pulls_url":"https://api.github.com/repos/epawlowska/whylog/pulls{/number}","milestones_url":"https://api.github.com/repos/epawlowska/whylog/milestones{/number}","notifications_url":"https://api.github.com/repos/epawlowska/whylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epawlowska/whylog/labels{/name}","releases_url":"https://api.github.com/repos/epawlowska/whylog/releases{/id}","deployments_url":"https://api.github.com/repos/epawlowska/whylog/deployments","created_at":"2015-11-26T10:22:17Z","updated_at":"2016-03-01T22:57:23Z","pushed_at":"2016-05-18T19:50:14Z","git_url":"git://github.com/epawlowska/whylog.git","ssh_url":"git@github.com:epawlowska/whylog.git","clone_url":"https://github.com/epawlowska/whylog.git","svn_url":"https://github.com/epawlowska/whylog","homepage":null,"size":901,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"9livesdata:master","ref":"master","sha":"51daffdf7a3949320df84b4a2200cd08abb7e504","user":{"login":"9livesdata","id":15250580,"avatar_url":"https://avatars.githubusercontent.com/u/15250580?v=3","gravatar_id":"","url":"https://api.github.com/users/9livesdata","html_url":"https://github.com/9livesdata","followers_url":"https://api.github.com/users/9livesdata/followers","following_url":"https://api.github.com/users/9livesdata/following{/other_user}","gists_url":"https://api.github.com/users/9livesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/9livesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9livesdata/subscriptions","organizations_url":"https://api.github.com/users/9livesdata/orgs","repos_url":"https://api.github.com/users/9livesdata/repos","events_url":"https://api.github.com/users/9livesdata/events{/privacy}","received_events_url":"https://api.github.com/users/9livesdata/received_events","type":"Organization","site_admin":false},"repo":{"id":44754618,"name":"whylog","full_name":"9livesdata/whylog","owner":{"login":"9livesdata","id":15250580,"avatar_url":"https://avatars.githubusercontent.com/u/15250580?v=3","gravatar_id":"","url":"https://api.github.com/users/9livesdata","html_url":"https://github.com/9livesdata","followers_url":"https://api.github.com/users/9livesdata/followers","following_url":"https://api.github.com/users/9livesdata/following{/other_user}","gists_url":"https://api.github.com/users/9livesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/9livesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9livesdata/subscriptions","organizations_url":"https://api.github.com/users/9livesdata/orgs","repos_url":"https://api.github.com/users/9livesdata/repos","events_url":"https://api.github.com/users/9livesdata/events{/privacy}","received_events_url":"https://api.github.com/users/9livesdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/9livesdata/whylog","description":"","fork":false,"url":"https://api.github.com/repos/9livesdata/whylog","forks_url":"https://api.github.com/repos/9livesdata/whylog/forks","keys_url":"https://api.github.com/repos/9livesdata/whylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9livesdata/whylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9livesdata/whylog/teams","hooks_url":"https://api.github.com/repos/9livesdata/whylog/hooks","issue_events_url":"https://api.github.com/repos/9livesdata/whylog/issues/events{/number}","events_url":"https://api.github.com/repos/9livesdata/whylog/events","assignees_url":"https://api.github.com/repos/9livesdata/whylog/assignees{/user}","branches_url":"https://api.github.com/repos/9livesdata/whylog/branches{/branch}","tags_url":"https://api.github.com/repos/9livesdata/whylog/tags","blobs_url":"https://api.github.com/repos/9livesdata/whylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9livesdata/whylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9livesdata/whylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/9livesdata/whylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9livesdata/whylog/statuses/{sha}","languages_url":"https://api.github.com/repos/9livesdata/whylog/languages","stargazers_url":"https://api.github.com/repos/9livesdata/whylog/stargazers","contributors_url":"https://api.github.com/repos/9livesdata/whylog/contributors","subscribers_url":"https://api.github.com/repos/9livesdata/whylog/subscribers","subscription_url":"https://api.github.com/repos/9livesdata/whylog/subscription","commits_url":"https://api.github.com/repos/9livesdata/whylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/9livesdata/whylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/9livesdata/whylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/9livesdata/whylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/9livesdata/whylog/contents/{+path}","compare_url":"https://api.github.com/repos/9livesdata/whylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9livesdata/whylog/merges","archive_url":"https://api.github.com/repos/9livesdata/whylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9livesdata/whylog/downloads","issues_url":"https://api.github.com/repos/9livesdata/whylog/issues{/number}","pulls_url":"https://api.github.com/repos/9livesdata/whylog/pulls{/number}","milestones_url":"https://api.github.com/repos/9livesdata/whylog/milestones{/number}","notifications_url":"https://api.github.com/repos/9livesdata/whylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9livesdata/whylog/labels{/name}","releases_url":"https://api.github.com/repos/9livesdata/whylog/releases{/id}","deployments_url":"https://api.github.com/repos/9livesdata/whylog/deployments","created_at":"2015-10-22T15:28:20Z","updated_at":"2016-02-28T22:54:29Z","pushed_at":"2016-05-18T19:50:14Z","git_url":"git://github.com/9livesdata/whylog.git","ssh_url":"git@github.com:9livesdata/whylog.git","clone_url":"https://github.com/9livesdata/whylog.git","svn_url":"https://github.com/9livesdata/whylog","homepage":null,"size":1151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":28,"forks":6,"open_issues":28,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/143"},"html":{"href":"https://github.com/9livesdata/whylog/pull/143"},"issue":{"href":"https://api.github.com/repos/9livesdata/whylog/issues/143"},"comments":{"href":"https://api.github.com/repos/9livesdata/whylog/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/9livesdata/whylog/statuses/6001b3374142d5590a3c0b088d84dfb30e99af53"}}}}