{"action":"created","issue":{"url":"https://api.github.com/repos/openvstorage/framework/issues/818","repository_url":"https://api.github.com/repos/openvstorage/framework","labels_url":"https://api.github.com/repos/openvstorage/framework/issues/818/labels{/name}","comments_url":"https://api.github.com/repos/openvstorage/framework/issues/818/comments","events_url":"https://api.github.com/repos/openvstorage/framework/issues/818/events","html_url":"https://github.com/openvstorage/framework/issues/818","id":171667379,"number":818,"title":"ArgumentError while executing the rollback","user":{"login":"matthiasdeblock","id":14923932,"avatar_url":"https://avatars.githubusercontent.com/u/14923932?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasdeblock","html_url":"https://github.com/matthiasdeblock","followers_url":"https://api.github.com/users/matthiasdeblock/followers","following_url":"https://api.github.com/users/matthiasdeblock/following{/other_user}","gists_url":"https://api.github.com/users/matthiasdeblock/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasdeblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasdeblock/subscriptions","organizations_url":"https://api.github.com/users/matthiasdeblock/orgs","repos_url":"https://api.github.com/users/matthiasdeblock/repos","events_url":"https://api.github.com/users/matthiasdeblock/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasdeblock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openvstorage/framework/labels/type_bug","name":"type_bug","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-17T14:09:55Z","updated_at":"2016-08-22T08:14:35Z","closed_at":null,"body":"On GIG's environment we had the following error while executing the rollback:\r\n\r\nVersion: 2.7.1-fargo.2-1\r\n\r\n**Error:**\r\n```\r\nIn [23]: VDiskController.rollback('87b309b9-3499-4f5f-bd8a-421e6286e7a0','1471438801')\r\n---------------------------------------------------------------------------\r\nArgumentError                             Traceback (most recent call last)\r\n<ipython-input-23-4d7e3ca8d065> in <module>()\r\n----> 1 VDiskController.rollback('87b309b9-3499-4f5f-bd8a-421e6286e7a0','1471438801')\r\n\r\n/usr/lib/python2.7/dist-packages/celery/local.pyc in <lambda>(x, *a, **kw)\r\n    165     __ge__ = lambda x, o: x._get_current_object() >= o\r\n    166     __hash__ = lambda x: hash(x._get_current_object())\r\n--> 167     __call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw)\r\n    168     __len__ = lambda x: len(x._get_current_object())\r\n    169     __getitem__ = lambda x, i: x._get_current_object()[i]\r\n\r\n/usr/lib/python2.7/dist-packages/celery/app/task.pyc in __call__(self, *args, **kwargs)\r\n    418             if self.__self__ is not None:\r\n    419                 return self.run(self.__self__, *args, **kwargs)\r\n--> 420             return self.run(*args, **kwargs)\r\n    421         finally:\r\n    422             self.pop_request()\r\n\r\n/opt/OpenvStorage/ovs/lib/vdisk.pyc in rollback(vdisk_guid, timestamp)\r\n    395         snapshotguid = snapshots[0]['guid']\r\n    396         VDiskController._wait_for_snapshot_to_be_synced_to_backend(vdisk_guid=vdisk.guid, snapshot_id=snapshotguid)\r\n--> 397         vdisk.storagedriver_client.rollback_volume(str(vdisk.volume_id), snapshotguid)\r\n    398         vdisk.invalidate_dynamics(['snapshots'])\r\n    399         return True\r\n\r\nArgumentError: Python argument types in\r\n    StorageRouterClient.rollback_volume(StorageRouterClient, str, unicode)\r\ndid not match C++ signature:\r\n    rollback_volume(volumedriverfs::PythonClient {lvalue}, std::string volume_id, std::string snapshot_id='')\r\n\r\n```\r\n\r\n**Fix:**\r\n/opt/OpenvStorage/ovs/lib/vdisk.py +397\r\n\r\n* from\r\n```\r\nvdisk.storagedriver_client.rollback_volume(str(vdisk.volume_id), snapshotguid)\r\n```\r\n* to: \r\n```\r\nvdisk.storagedriver_client.rollback_volume(str(vdisk.volume_id), str(snapshotguid))\r\n```"},"comment":{"url":"https://api.github.com/repos/openvstorage/framework/issues/comments/241342529","html_url":"https://github.com/openvstorage/framework/issues/818#issuecomment-241342529","issue_url":"https://api.github.com/repos/openvstorage/framework/issues/818","id":241342529,"user":{"login":"wimpers","id":8392927,"avatar_url":"https://avatars.githubusercontent.com/u/8392927?v=3","gravatar_id":"","url":"https://api.github.com/users/wimpers","html_url":"https://github.com/wimpers","followers_url":"https://api.github.com/users/wimpers/followers","following_url":"https://api.github.com/users/wimpers/following{/other_user}","gists_url":"https://api.github.com/users/wimpers/gists{/gist_id}","starred_url":"https://api.github.com/users/wimpers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimpers/subscriptions","organizations_url":"https://api.github.com/users/wimpers/orgs","repos_url":"https://api.github.com/users/wimpers/repos","events_url":"https://api.github.com/users/wimpers/events{/privacy}","received_events_url":"https://api.github.com/users/wimpers/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T08:14:35Z","updated_at":"2016-08-22T08:14:35Z","body":"@matthiasdeblock can you create a PR for this one?"}}
{"actor":{"display_login":"wimpers"}}