{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/67094084","id":67094084,"diff_hunk":"@@ -64,9 +64,6 @@ internal class StackFrameHelper : IDisposable\n         private static Type s_symbolsType = null;\n         private static MethodInfo s_symbolsMethodInfo = null;\n \n-        [ThreadStatic]\n-        private static int t_reentrancy = 0;","path":"src/mscorlib/src/System/Diagnostics/Stacktrace.cs","position":5,"original_position":5,"commit_id":"e903becd88015878f1ae157cd292c671dc81e4bd","original_commit_id":"e903becd88015878f1ae157cd292c671dc81e4bd","user":{"login":"noahfalk","id":6243776,"avatar_url":"https://avatars.githubusercontent.com/u/6243776?v=3","gravatar_id":"","url":"https://api.github.com/users/noahfalk","html_url":"https://github.com/noahfalk","followers_url":"https://api.github.com/users/noahfalk/followers","following_url":"https://api.github.com/users/noahfalk/following{/other_user}","gists_url":"https://api.github.com/users/noahfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/noahfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahfalk/subscriptions","organizations_url":"https://api.github.com/users/noahfalk/orgs","repos_url":"https://api.github.com/users/noahfalk/repos","events_url":"https://api.github.com/users/noahfalk/events{/privacy}","received_events_url":"https://api.github.com/users/noahfalk/received_events","type":"User","site_admin":false},"body":"It seems safer to leave the reentrancy check in place. Even if we do catch the exceptions, that won't prevent infinite recursion if the code within this block (and its complete call-graph) somewhere throws an exception and then tries to log the stack trace for it.","created_at":"2016-06-15T03:16:32Z","updated_at":"2016-06-15T03:16:32Z","html_url":"https://github.com/dotnet/coreclr/pull/5802#discussion_r67094084","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5802","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/67094084"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5802#discussion_r67094084"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5802"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/5802","id":73827479,"html_url":"https://github.com/dotnet/coreclr/pull/5802","diff_url":"https://github.com/dotnet/coreclr/pull/5802.diff","patch_url":"https://github.com/dotnet/coreclr/pull/5802.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/5802","number":5802,"state":"open","locked":false,"title":"Fix exception stacktrace when ulimit is hit OSX.","user":{"login":"mikem8361","id":10454379,"avatar_url":"https://avatars.githubusercontent.com/u/10454379?v=3","gravatar_id":"","url":"https://api.github.com/users/mikem8361","html_url":"https://github.com/mikem8361","followers_url":"https://api.github.com/users/mikem8361/followers","following_url":"https://api.github.com/users/mikem8361/following{/other_user}","gists_url":"https://api.github.com/users/mikem8361/gists{/gist_id}","starred_url":"https://api.github.com/users/mikem8361/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikem8361/subscriptions","organizations_url":"https://api.github.com/users/mikem8361/orgs","repos_url":"https://api.github.com/users/mikem8361/repos","events_url":"https://api.github.com/users/mikem8361/events{/privacy}","received_events_url":"https://api.github.com/users/mikem8361/received_events","type":"User","site_admin":false},"body":"Fixes issue #5782.\r\n\r\nAdd try/catch for FileLoadException and BadImageFormatException around loading/creating StackTraceSymbols class. These are the exceptions that are still throw even when throwOnError: false. ","created_at":"2016-06-14T22:53:50Z","updated_at":"2016-06-15T03:16:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c579f0b8242d51bf33f3b331483ac63b8cbdebd","assignee":{"login":"mikem8361","id":10454379,"avatar_url":"https://avatars.githubusercontent.com/u/10454379?v=3","gravatar_id":"","url":"https://api.github.com/users/mikem8361","html_url":"https://github.com/mikem8361","followers_url":"https://api.github.com/users/mikem8361/followers","following_url":"https://api.github.com/users/mikem8361/following{/other_user}","gists_url":"https://api.github.com/users/mikem8361/gists{/gist_id}","starred_url":"https://api.github.com/users/mikem8361/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikem8361/subscriptions","organizations_url":"https://api.github.com/users/mikem8361/orgs","repos_url":"https://api.github.com/users/mikem8361/repos","events_url":"https://api.github.com/users/mikem8361/events{/privacy}","received_events_url":"https://api.github.com/users/mikem8361/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/coreclr/milestones/7","html_url":"https://github.com/dotnet/coreclr/milestones/1.1.0","labels_url":"https://api.github.com/repos/dotnet/coreclr/milestones/7/labels","id":1666130,"number":7,"title":"1.1.0","description":"Features associated with 1.1.0 unfortunately won't make it into the initial 1.0.0 RTM release.  We are tentatively planning on shipping them in the initial feature release after 1.0.0 RTM.\r\n\r\nNo calendar date is set.\r\n\r\nhttps://github.com/aspnet/Home/wiki/Roadmap","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":138,"closed_issues":21,"state":"open","created_at":"2016-03-25T17:15:38Z","updated_at":"2016-06-14T22:53:50Z","due_on":"2016-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5802/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/5802/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/5802/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/e903becd88015878f1ae157cd292c671dc81e4bd","head":{"label":"mikem8361:stacktracefix","ref":"stacktracefix","sha":"e903becd88015878f1ae157cd292c671dc81e4bd","user":{"login":"mikem8361","id":10454379,"avatar_url":"https://avatars.githubusercontent.com/u/10454379?v=3","gravatar_id":"","url":"https://api.github.com/users/mikem8361","html_url":"https://github.com/mikem8361","followers_url":"https://api.github.com/users/mikem8361/followers","following_url":"https://api.github.com/users/mikem8361/following{/other_user}","gists_url":"https://api.github.com/users/mikem8361/gists{/gist_id}","starred_url":"https://api.github.com/users/mikem8361/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikem8361/subscriptions","organizations_url":"https://api.github.com/users/mikem8361/orgs","repos_url":"https://api.github.com/users/mikem8361/repos","events_url":"https://api.github.com/users/mikem8361/events{/privacy}","received_events_url":"https://api.github.com/users/mikem8361/received_events","type":"User","site_admin":false},"repo":{"id":30617310,"name":"coreclr","full_name":"mikem8361/coreclr","owner":{"login":"mikem8361","id":10454379,"avatar_url":"https://avatars.githubusercontent.com/u/10454379?v=3","gravatar_id":"","url":"https://api.github.com/users/mikem8361","html_url":"https://github.com/mikem8361","followers_url":"https://api.github.com/users/mikem8361/followers","following_url":"https://api.github.com/users/mikem8361/following{/other_user}","gists_url":"https://api.github.com/users/mikem8361/gists{/gist_id}","starred_url":"https://api.github.com/users/mikem8361/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikem8361/subscriptions","organizations_url":"https://api.github.com/users/mikem8361/orgs","repos_url":"https://api.github.com/users/mikem8361/repos","events_url":"https://api.github.com/users/mikem8361/events{/privacy}","received_events_url":"https://api.github.com/users/mikem8361/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikem8361/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/mikem8361/coreclr","forks_url":"https://api.github.com/repos/mikem8361/coreclr/forks","keys_url":"https://api.github.com/repos/mikem8361/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikem8361/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikem8361/coreclr/teams","hooks_url":"https://api.github.com/repos/mikem8361/coreclr/hooks","issue_events_url":"https://api.github.com/repos/mikem8361/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/mikem8361/coreclr/events","assignees_url":"https://api.github.com/repos/mikem8361/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/mikem8361/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/mikem8361/coreclr/tags","blobs_url":"https://api.github.com/repos/mikem8361/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikem8361/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikem8361/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikem8361/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikem8361/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/mikem8361/coreclr/languages","stargazers_url":"https://api.github.com/repos/mikem8361/coreclr/stargazers","contributors_url":"https://api.github.com/repos/mikem8361/coreclr/contributors","subscribers_url":"https://api.github.com/repos/mikem8361/coreclr/subscribers","subscription_url":"https://api.github.com/repos/mikem8361/coreclr/subscription","commits_url":"https://api.github.com/repos/mikem8361/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikem8361/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikem8361/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikem8361/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikem8361/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/mikem8361/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikem8361/coreclr/merges","archive_url":"https://api.github.com/repos/mikem8361/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikem8361/coreclr/downloads","issues_url":"https://api.github.com/repos/mikem8361/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/mikem8361/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/mikem8361/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/mikem8361/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikem8361/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/mikem8361/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/mikem8361/coreclr/deployments","created_at":"2015-02-10T22:11:46Z","updated_at":"2016-01-11T23:24:12Z","pushed_at":"2016-06-15T03:06:11Z","git_url":"git://github.com/mikem8361/coreclr.git","ssh_url":"git@github.com:mikem8361/coreclr.git","clone_url":"https://github.com/mikem8361/coreclr.git","svn_url":"https://github.com/mikem8361/coreclr","homepage":"","size":86237,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"488c377745cd2cbdfac711d2199dfeefeb24c5f1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-06-14T14:28:15Z","pushed_at":"2016-06-15T03:06:13Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://dotnet.github.io/","size":93969,"stargazers_count":6503,"watchers_count":6503,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1492,"mirror_url":null,"open_issues_count":835,"forks":1492,"open_issues":835,"watchers":6503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5802"},"html":{"href":"https://github.com/dotnet/coreclr/pull/5802"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5802"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/5802/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5802/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/5802/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/e903becd88015878f1ae157cd292c671dc81e4bd"}}}}
{"actor":{"display_login":"noahfalk"}}