{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/67367091","id":67367091,"diff_hunk":"@@ -20,13 +24,19 @@ function UNDEFINED() {}\n  * practice, most use cases satisfy this limitation which is why it is included\n  * in ember-metal.\n  */\n-export default function WeakMap() {\n-  assert(\n-    'Invoking the WeakMap constructor with arguments is not supported at this time',\n-    arguments.length === 0\n-  );\n-\n+export default function WeakMap(iterable) {\n   this._id = GUID_KEY + (id++);\n+\n+  if (iterable === null || iterable === undefined) {\n+    return;\n+  } else if (Array.isArray(iterable)) {","path":"packages/ember-metal/lib/weak_map.js","position":32,"original_position":32,"commit_id":"5143a47c328c2d79fe896a0b47660cf8462cf768","original_commit_id":"5143a47c328c2d79fe896a0b47660cf8462cf768","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"@thoov ^","created_at":"2016-06-16T15:29:53Z","updated_at":"2016-06-16T15:29:53Z","html_url":"https://github.com/emberjs/ember.js/pull/13688#discussion_r67367091","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13688","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/67367091"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13688#discussion_r67367091"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13688"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13688","id":74032313,"html_url":"https://github.com/emberjs/ember.js/pull/13688","diff_url":"https://github.com/emberjs/ember.js/pull/13688.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13688.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13688","number":13688,"state":"open","locked":false,"title":"[FEATURE ember-metal-weakmap] Add a WeakMap polyfill","user":{"login":"mmun","id":1151810,"avatar_url":"https://avatars.githubusercontent.com/u/1151810?v=3","gravatar_id":"","url":"https://api.github.com/users/mmun","html_url":"https://github.com/mmun","followers_url":"https://api.github.com/users/mmun/followers","following_url":"https://api.github.com/users/mmun/following{/other_user}","gists_url":"https://api.github.com/users/mmun/gists{/gist_id}","starred_url":"https://api.github.com/users/mmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmun/subscriptions","organizations_url":"https://api.github.com/users/mmun/orgs","repos_url":"https://api.github.com/users/mmun/repos","events_url":"https://api.github.com/users/mmun/events{/privacy}","received_events_url":"https://api.github.com/users/mmun/received_events","type":"User","site_admin":false},"body":"This patch exposes the Ember's private WeakMap polyfill under a feature flag. This implementation has a small but important caveat. It assumes that the weak map will live longer (in the sense of garbage collection) than all of its keys, otherwise it is possible to leak the values stored in the weak map.\r\n\r\nThis patch also includes a few improvements:\r\n\r\n- implement WeakMap constructor\r\n- implement WeakMap toString\r\n- guard against non-Object keys","created_at":"2016-06-16T07:13:48Z","updated_at":"2016-06-16T15:29:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6edcfb31c8f15d94e43fa2feb752ec6fc2c7b205","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13688/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13688/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13688/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/5143a47c328c2d79fe896a0b47660cf8462cf768","head":{"label":"mmun:public-weakmap","ref":"public-weakmap","sha":"5143a47c328c2d79fe896a0b47660cf8462cf768","user":{"login":"mmun","id":1151810,"avatar_url":"https://avatars.githubusercontent.com/u/1151810?v=3","gravatar_id":"","url":"https://api.github.com/users/mmun","html_url":"https://github.com/mmun","followers_url":"https://api.github.com/users/mmun/followers","following_url":"https://api.github.com/users/mmun/following{/other_user}","gists_url":"https://api.github.com/users/mmun/gists{/gist_id}","starred_url":"https://api.github.com/users/mmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmun/subscriptions","organizations_url":"https://api.github.com/users/mmun/orgs","repos_url":"https://api.github.com/users/mmun/repos","events_url":"https://api.github.com/users/mmun/events{/privacy}","received_events_url":"https://api.github.com/users/mmun/received_events","type":"User","site_admin":false},"repo":{"id":12316599,"name":"ember.js","full_name":"mmun/ember.js","owner":{"login":"mmun","id":1151810,"avatar_url":"https://avatars.githubusercontent.com/u/1151810?v=3","gravatar_id":"","url":"https://api.github.com/users/mmun","html_url":"https://github.com/mmun","followers_url":"https://api.github.com/users/mmun/followers","following_url":"https://api.github.com/users/mmun/following{/other_user}","gists_url":"https://api.github.com/users/mmun/gists{/gist_id}","starred_url":"https://api.github.com/users/mmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmun/subscriptions","organizations_url":"https://api.github.com/users/mmun/orgs","repos_url":"https://api.github.com/users/mmun/repos","events_url":"https://api.github.com/users/mmun/events{/privacy}","received_events_url":"https://api.github.com/users/mmun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmun/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/mmun/ember.js","forks_url":"https://api.github.com/repos/mmun/ember.js/forks","keys_url":"https://api.github.com/repos/mmun/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmun/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmun/ember.js/teams","hooks_url":"https://api.github.com/repos/mmun/ember.js/hooks","issue_events_url":"https://api.github.com/repos/mmun/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/mmun/ember.js/events","assignees_url":"https://api.github.com/repos/mmun/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/mmun/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/mmun/ember.js/tags","blobs_url":"https://api.github.com/repos/mmun/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmun/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmun/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmun/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmun/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mmun/ember.js/languages","stargazers_url":"https://api.github.com/repos/mmun/ember.js/stargazers","contributors_url":"https://api.github.com/repos/mmun/ember.js/contributors","subscribers_url":"https://api.github.com/repos/mmun/ember.js/subscribers","subscription_url":"https://api.github.com/repos/mmun/ember.js/subscription","commits_url":"https://api.github.com/repos/mmun/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmun/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmun/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmun/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmun/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/mmun/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmun/ember.js/merges","archive_url":"https://api.github.com/repos/mmun/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmun/ember.js/downloads","issues_url":"https://api.github.com/repos/mmun/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/mmun/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mmun/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mmun/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmun/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/mmun/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/mmun/ember.js/deployments","created_at":"2013-08-23T06:51:49Z","updated_at":"2014-08-10T23:01:14Z","pushed_at":"2016-06-16T07:13:17Z","git_url":"git://github.com/mmun/ember.js.git","ssh_url":"git@github.com:mmun/ember.js.git","clone_url":"https://github.com/mmun/ember.js.git","svn_url":"https://github.com/mmun/ember.js","homepage":"http://www.emberjs.com","size":33154,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"f9ca19b4b379f817bcab6d29288b06ff29a61d66","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-06-16T13:59:14Z","pushed_at":"2016-06-16T15:22:14Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":69250,"stargazers_count":16347,"watchers_count":16347,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3495,"mirror_url":null,"open_issues_count":262,"forks":3495,"open_issues":262,"watchers":16347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13688"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13688"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13688"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13688/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13688/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13688/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/5143a47c328c2d79fe896a0b47660cf8462cf768"}}}}
{"actor":{"display_login":"stefanpenner"}}