{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/68965755","id":68965755,"diff_hunk":"@@ -100,4 +112,11 @@ def subject.send_login_request(user, password)\n       end\n     end\n   end\n+\n+  describe \"#log_response\" do\n+    it 'handles ASCII-8BIT to UTF-8 encoding gracefully' do\n+      response = TestResponse.new([130, 5, 3120, 130, 4, 171, 160, 3, 2].pack('C*'))\n+      expect(subject.try_log_response(:get, TestClient.hostname, response)).to be_truthy","path":"spaceship/spec/client_spec.rb","position":27,"original_position":27,"commit_id":"f28c7428e640cb8c4b7bb4123154f412b9ff20b6","original_commit_id":"f28c7428e640cb8c4b7bb4123154f412b9ff20b6","user":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"body":"Curious why this calls a local `try_log_response` method instead of just `log_response` directly?","created_at":"2016-06-29T15:17:07Z","updated_at":"2016-06-29T15:17:07Z","html_url":"https://github.com/fastlane/fastlane/pull/4426#discussion_r68965755","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/4426","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/68965755"},"html":{"href":"https://github.com/fastlane/fastlane/pull/4426#discussion_r68965755"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/4426"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/4426","id":68477830,"html_url":"https://github.com/fastlane/fastlane/pull/4426","diff_url":"https://github.com/fastlane/fastlane/pull/4426.diff","patch_url":"https://github.com/fastlane/fastlane/pull/4426.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/4426","number":4426,"state":"open","locked":false,"title":"Force utf8 encoding when logging","user":{"login":"tpalmer","id":584653,"avatar_url":"https://avatars.githubusercontent.com/u/584653?v=3","gravatar_id":"","url":"https://api.github.com/users/tpalmer","html_url":"https://github.com/tpalmer","followers_url":"https://api.github.com/users/tpalmer/followers","following_url":"https://api.github.com/users/tpalmer/following{/other_user}","gists_url":"https://api.github.com/users/tpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/tpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpalmer/subscriptions","organizations_url":"https://api.github.com/users/tpalmer/orgs","repos_url":"https://api.github.com/users/tpalmer/repos","events_url":"https://api.github.com/users/tpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/tpalmer/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/fastlane/fastlane/issues/4087","created_at":"2016-04-30T20:17:41Z","updated_at":"2016-06-29T15:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eedd2e1883368a328a1263981f13c7ca915ab644","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/4426/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/4426/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/4426/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/f28c7428e640cb8c4b7bb4123154f412b9ff20b6","head":{"label":"tpalmer:force-utf8-logging","ref":"force-utf8-logging","sha":"f28c7428e640cb8c4b7bb4123154f412b9ff20b6","user":{"login":"tpalmer","id":584653,"avatar_url":"https://avatars.githubusercontent.com/u/584653?v=3","gravatar_id":"","url":"https://api.github.com/users/tpalmer","html_url":"https://github.com/tpalmer","followers_url":"https://api.github.com/users/tpalmer/followers","following_url":"https://api.github.com/users/tpalmer/following{/other_user}","gists_url":"https://api.github.com/users/tpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/tpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpalmer/subscriptions","organizations_url":"https://api.github.com/users/tpalmer/orgs","repos_url":"https://api.github.com/users/tpalmer/repos","events_url":"https://api.github.com/users/tpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/tpalmer/received_events","type":"User","site_admin":false},"repo":{"id":57451959,"name":"fastlane","full_name":"tpalmer/fastlane","owner":{"login":"tpalmer","id":584653,"avatar_url":"https://avatars.githubusercontent.com/u/584653?v=3","gravatar_id":"","url":"https://api.github.com/users/tpalmer","html_url":"https://github.com/tpalmer","followers_url":"https://api.github.com/users/tpalmer/followers","following_url":"https://api.github.com/users/tpalmer/following{/other_user}","gists_url":"https://api.github.com/users/tpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/tpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpalmer/subscriptions","organizations_url":"https://api.github.com/users/tpalmer/orgs","repos_url":"https://api.github.com/users/tpalmer/repos","events_url":"https://api.github.com/users/tpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/tpalmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpalmer/fastlane","description":"Connect all iOS and Android deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/tpalmer/fastlane","forks_url":"https://api.github.com/repos/tpalmer/fastlane/forks","keys_url":"https://api.github.com/repos/tpalmer/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpalmer/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpalmer/fastlane/teams","hooks_url":"https://api.github.com/repos/tpalmer/fastlane/hooks","issue_events_url":"https://api.github.com/repos/tpalmer/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/tpalmer/fastlane/events","assignees_url":"https://api.github.com/repos/tpalmer/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/tpalmer/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/tpalmer/fastlane/tags","blobs_url":"https://api.github.com/repos/tpalmer/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpalmer/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpalmer/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpalmer/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpalmer/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/tpalmer/fastlane/languages","stargazers_url":"https://api.github.com/repos/tpalmer/fastlane/stargazers","contributors_url":"https://api.github.com/repos/tpalmer/fastlane/contributors","subscribers_url":"https://api.github.com/repos/tpalmer/fastlane/subscribers","subscription_url":"https://api.github.com/repos/tpalmer/fastlane/subscription","commits_url":"https://api.github.com/repos/tpalmer/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpalmer/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpalmer/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpalmer/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpalmer/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/tpalmer/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpalmer/fastlane/merges","archive_url":"https://api.github.com/repos/tpalmer/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpalmer/fastlane/downloads","issues_url":"https://api.github.com/repos/tpalmer/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/tpalmer/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/tpalmer/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/tpalmer/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpalmer/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/tpalmer/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/tpalmer/fastlane/deployments","created_at":"2016-04-30T16:38:47Z","updated_at":"2016-04-30T16:38:52Z","pushed_at":"2016-05-13T18:21:23Z","git_url":"git://github.com/tpalmer/fastlane.git","ssh_url":"git@github.com:tpalmer/fastlane.git","clone_url":"https://github.com/tpalmer/fastlane.git","svn_url":"https://github.com/tpalmer/fastlane","homepage":"https://fastlane.tools","size":49691,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"1229fc55f004975e94226961ef23bbaa554f82b0","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-06-29T14:25:56Z","pushed_at":"2016-06-29T15:01:37Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":60197,"stargazers_count":8969,"watchers_count":8969,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1232,"mirror_url":null,"open_issues_count":467,"forks":1232,"open_issues":467,"watchers":8969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/4426"},"html":{"href":"https://github.com/fastlane/fastlane/pull/4426"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/4426"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/4426/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/4426/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/4426/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/f28c7428e640cb8c4b7bb4123154f412b9ff20b6"}}}}
{"actor":{"display_login":"ohwutup"}}