{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/1153","repository_url":"https://api.github.com/repos/mozilla/activity-stream","labels_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1153/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1153/comments","events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1153/events","html_url":"https://github.com/mozilla/activity-stream/pull/1153","id":172583122,"number":1153,"title":"New design for grouped highlights","user":{"login":"piatra","id":810040,"avatar_url":"https://avatars.githubusercontent.com/u/810040?v=3","gravatar_id":"","url":"https://api.github.com/users/piatra","html_url":"https://github.com/piatra","followers_url":"https://api.github.com/users/piatra/followers","following_url":"https://api.github.com/users/piatra/following{/other_user}","gists_url":"https://api.github.com/users/piatra/gists{/gist_id}","starred_url":"https://api.github.com/users/piatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piatra/subscriptions","organizations_url":"https://api.github.com/users/piatra/orgs","repos_url":"https://api.github.com/users/piatra/repos","events_url":"https://api.github.com/users/piatra/events{/privacy}","received_events_url":"https://api.github.com/users/piatra/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/activity-stream/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/mozilla/activity-stream/labels/PR%20/%20Needs%20work","name":"PR / Needs work","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"piatra","id":810040,"avatar_url":"https://avatars.githubusercontent.com/u/810040?v=3","gravatar_id":"","url":"https://api.github.com/users/piatra","html_url":"https://github.com/piatra","followers_url":"https://api.github.com/users/piatra/followers","following_url":"https://api.github.com/users/piatra/following{/other_user}","gists_url":"https://api.github.com/users/piatra/gists{/gist_id}","starred_url":"https://api.github.com/users/piatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piatra/subscriptions","organizations_url":"https://api.github.com/users/piatra/orgs","repos_url":"https://api.github.com/users/piatra/repos","events_url":"https://api.github.com/users/piatra/events{/privacy}","received_events_url":"https://api.github.com/users/piatra/received_events","type":"User","site_admin":false},"assignees":[{"login":"piatra","id":810040,"avatar_url":"https://avatars.githubusercontent.com/u/810040?v=3","gravatar_id":"","url":"https://api.github.com/users/piatra","html_url":"https://github.com/piatra","followers_url":"https://api.github.com/users/piatra/followers","following_url":"https://api.github.com/users/piatra/following{/other_user}","gists_url":"https://api.github.com/users/piatra/gists{/gist_id}","starred_url":"https://api.github.com/users/piatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piatra/subscriptions","organizations_url":"https://api.github.com/users/piatra/orgs","repos_url":"https://api.github.com/users/piatra/repos","events_url":"https://api.github.com/users/piatra/events{/privacy}","received_events_url":"https://api.github.com/users/piatra/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-08-23T00:04:44Z","updated_at":"2016-08-31T00:00:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1153","html_url":"https://github.com/mozilla/activity-stream/pull/1153","diff_url":"https://github.com/mozilla/activity-stream/pull/1153.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/1153.patch"},"body":"Replace the `Recent activity` section with more highlights. Design mockups are here: https://mozilla.invisionapp.com/share/TN84I7MB2#/screens/177705068\r\nSize chart is here: http://i.imgur.com/RmRnfXK.png\r\n\r\n![screen shot 2016-08-22 at 5 00 55 pm](https://cloud.githubusercontent.com/assets/810040/17875823/23c8ddf6-688a-11e6-8c8c-53d8980c7843.png)\r\n\r\nWork in progress. Amusing how my top recommendations are now CSS related. Centering stuff never works as expected!\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mozilla/activity-stream/1153)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments/243619139","html_url":"https://github.com/mozilla/activity-stream/pull/1153#issuecomment-243619139","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1153","id":243619139,"user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T00:00:59Z","updated_at":"2016-08-31T00:00:59Z","body":"We also have a funny hanging `&middot;` in the above screenshots since the default Highlights tiles don't have a fancy provider name.\r\n\r\n---\r\n\r\nAlso a slight mismatch in the domain/site name that we're displaying. THe mocks say \"fivethirtyeight\" but as far as I can tell, our logic is displaying a pretty-url, which will include a TLD. \r\nThis gets mildly interesting when you start digging. Here's what we see for a random fivethirtyeight article: http://embed.ly/docs/explore/extract?url=http%3A%2F%2Ffivethirtyeight.com%2Ffeatures%2Fthe-broncos-new-quarterback-is-inexperienced-but-at-least-hes-not-peyton-manning%2F\r\n\r\nNote the following keys:\r\n\r\n| `provider_url` | `provider_name` | `provider_display`\r\n|:----|:----|:----\r\n| \"http://fivethirtyeight.com\" | \"FiveThirtyEight\" | \"fivethirtyeight.com\"\r\n| \"http://www.nytimes.com\" | \"Nytimes\" | \"www.nytimes.com\"\r\n| \"http://digg.com\" | \"Digg\" | \"digg.com\"\r\n| \"https://flexbox.webflow.com\" | \"Webflow\" | \"flexbox.webflow.com\"\r\n| \" http://blog.flexexamples.com\" | \"Flexexamples\" | \"blog.flexexamples.com\"\r\n\r\n\r\nOur closest match to the comps is either `provider_name` or `provider_name.toLowerCase()`. The 10 sites I tested all had reasonable `prodiver_name` values, although I'd have to see if we get those same values back from the new non-Embedly proxy server."}}
{"actor":{"display_login":"pdehaan"}}