{"action":"opened","number":3993,"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/3993","id":66592682,"html_url":"https://github.com/BVLC/caffe/pull/3993","diff_url":"https://github.com/BVLC/caffe/pull/3993.diff","patch_url":"https://github.com/BVLC/caffe/pull/3993.patch","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/3993","number":3993,"state":"open","locked":false,"title":"Fix Crop layer dimension checking to only check cropped dimensions","user":{"login":"shelhamer","id":311113,"avatar_url":"https://avatars.githubusercontent.com/u/311113?v=3","gravatar_id":"","url":"https://api.github.com/users/shelhamer","html_url":"https://github.com/shelhamer","followers_url":"https://api.github.com/users/shelhamer/followers","following_url":"https://api.github.com/users/shelhamer/following{/other_user}","gists_url":"https://api.github.com/users/shelhamer/gists{/gist_id}","starred_url":"https://api.github.com/users/shelhamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelhamer/subscriptions","organizations_url":"https://api.github.com/users/shelhamer/orgs","repos_url":"https://api.github.com/users/shelhamer/repos","events_url":"https://api.github.com/users/shelhamer/events{/privacy}","received_events_url":"https://api.github.com/users/shelhamer/received_events","type":"User","site_admin":false},"body":"The `Crop` layer should only check the actual dimensions to be cropped for shape compatibility given the crop size and offset.\n\nThe current, over-general check results in issues like refusing to crop the output for a binary classification task given color input, since the data has 3 channels while the output has 2. As the channels are not cropped (in this use case) that is irrelevant and wrong.\n\nThis PR fixes the check, makes the message clearer, and revises the comments here and there.","created_at":"2016-04-15T05:40:54Z","updated_at":"2016-04-15T05:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BVLC/caffe/pulls/3993/commits","review_comments_url":"https://api.github.com/repos/BVLC/caffe/pulls/3993/comments","review_comment_url":"https://api.github.com/repos/BVLC/caffe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/3993/comments","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/8960c97268e6e9d99d3456cd635c6694f46c8285","head":{"label":"shelhamer:fix-crop","ref":"fix-crop","sha":"8960c97268e6e9d99d3456cd635c6694f46c8285","user":{"login":"shelhamer","id":311113,"avatar_url":"https://avatars.githubusercontent.com/u/311113?v=3","gravatar_id":"","url":"https://api.github.com/users/shelhamer","html_url":"https://github.com/shelhamer","followers_url":"https://api.github.com/users/shelhamer/followers","following_url":"https://api.github.com/users/shelhamer/following{/other_user}","gists_url":"https://api.github.com/users/shelhamer/gists{/gist_id}","starred_url":"https://api.github.com/users/shelhamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelhamer/subscriptions","organizations_url":"https://api.github.com/users/shelhamer/orgs","repos_url":"https://api.github.com/users/shelhamer/repos","events_url":"https://api.github.com/users/shelhamer/events{/privacy}","received_events_url":"https://api.github.com/users/shelhamer/received_events","type":"User","site_admin":false},"repo":{"id":14997441,"name":"caffe","full_name":"shelhamer/caffe","owner":{"login":"shelhamer","id":311113,"avatar_url":"https://avatars.githubusercontent.com/u/311113?v=3","gravatar_id":"","url":"https://api.github.com/users/shelhamer","html_url":"https://github.com/shelhamer","followers_url":"https://api.github.com/users/shelhamer/followers","following_url":"https://api.github.com/users/shelhamer/following{/other_user}","gists_url":"https://api.github.com/users/shelhamer/gists{/gist_id}","starred_url":"https://api.github.com/users/shelhamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelhamer/subscriptions","organizations_url":"https://api.github.com/users/shelhamer/orgs","repos_url":"https://api.github.com/users/shelhamer/repos","events_url":"https://api.github.com/users/shelhamer/events{/privacy}","received_events_url":"https://api.github.com/users/shelhamer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shelhamer/caffe","description":"Caffe","fork":true,"url":"https://api.github.com/repos/shelhamer/caffe","forks_url":"https://api.github.com/repos/shelhamer/caffe/forks","keys_url":"https://api.github.com/repos/shelhamer/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shelhamer/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shelhamer/caffe/teams","hooks_url":"https://api.github.com/repos/shelhamer/caffe/hooks","issue_events_url":"https://api.github.com/repos/shelhamer/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/shelhamer/caffe/events","assignees_url":"https://api.github.com/repos/shelhamer/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/shelhamer/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/shelhamer/caffe/tags","blobs_url":"https://api.github.com/repos/shelhamer/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shelhamer/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shelhamer/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/shelhamer/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shelhamer/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/shelhamer/caffe/languages","stargazers_url":"https://api.github.com/repos/shelhamer/caffe/stargazers","contributors_url":"https://api.github.com/repos/shelhamer/caffe/contributors","subscribers_url":"https://api.github.com/repos/shelhamer/caffe/subscribers","subscription_url":"https://api.github.com/repos/shelhamer/caffe/subscription","commits_url":"https://api.github.com/repos/shelhamer/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/shelhamer/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/shelhamer/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/shelhamer/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/shelhamer/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/shelhamer/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shelhamer/caffe/merges","archive_url":"https://api.github.com/repos/shelhamer/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shelhamer/caffe/downloads","issues_url":"https://api.github.com/repos/shelhamer/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/shelhamer/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/shelhamer/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/shelhamer/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shelhamer/caffe/labels{/name}","releases_url":"https://api.github.com/repos/shelhamer/caffe/releases{/id}","deployments_url":"https://api.github.com/repos/shelhamer/caffe/deployments","created_at":"2013-12-07T00:59:37Z","updated_at":"2016-02-04T22:25:27Z","pushed_at":"2016-04-15T05:37:25Z","git_url":"git://github.com/shelhamer/caffe.git","ssh_url":"git@github.com:shelhamer/caffe.git","clone_url":"https://github.com/shelhamer/caffe.git","svn_url":"https://github.com/shelhamer/caffe","homepage":"caffe.berkeleyvision.org","size":37577,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"BVLC:master","ref":"master","sha":"ae5343d72d04b16cc1f395538012febe75749f65","user":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?v=3","gravatar_id":"","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"repo":{"id":12791642,"name":"caffe","full_name":"BVLC/caffe","owner":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?v=3","gravatar_id":"","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BVLC/caffe","description":"Caffe: a fast open framework for deep learning.","fork":false,"url":"https://api.github.com/repos/BVLC/caffe","forks_url":"https://api.github.com/repos/BVLC/caffe/forks","keys_url":"https://api.github.com/repos/BVLC/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BVLC/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BVLC/caffe/teams","hooks_url":"https://api.github.com/repos/BVLC/caffe/hooks","issue_events_url":"https://api.github.com/repos/BVLC/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/BVLC/caffe/events","assignees_url":"https://api.github.com/repos/BVLC/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/BVLC/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/BVLC/caffe/tags","blobs_url":"https://api.github.com/repos/BVLC/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BVLC/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BVLC/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/BVLC/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/BVLC/caffe/languages","stargazers_url":"https://api.github.com/repos/BVLC/caffe/stargazers","contributors_url":"https://api.github.com/repos/BVLC/caffe/contributors","subscribers_url":"https://api.github.com/repos/BVLC/caffe/subscribers","subscription_url":"https://api.github.com/repos/BVLC/caffe/subscription","commits_url":"https://api.github.com/repos/BVLC/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/BVLC/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/BVLC/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/BVLC/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/BVLC/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/BVLC/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BVLC/caffe/merges","archive_url":"https://api.github.com/repos/BVLC/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BVLC/caffe/downloads","issues_url":"https://api.github.com/repos/BVLC/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/BVLC/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/BVLC/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/BVLC/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BVLC/caffe/labels{/name}","releases_url":"https://api.github.com/repos/BVLC/caffe/releases{/id}","deployments_url":"https://api.github.com/repos/BVLC/caffe/deployments","created_at":"2013-09-12T18:39:48Z","updated_at":"2016-04-15T03:11:20Z","pushed_at":"2016-04-15T00:50:10Z","git_url":"git://github.com/BVLC/caffe.git","ssh_url":"git@github.com:BVLC/caffe.git","clone_url":"https://github.com/BVLC/caffe.git","svn_url":"https://github.com/BVLC/caffe","homepage":"http://caffe.berkeleyvision.org/","size":259327,"stargazers_count":9657,"watchers_count":9657,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5598,"mirror_url":null,"open_issues_count":613,"forks":5598,"open_issues":613,"watchers":9657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/3993"},"html":{"href":"https://github.com/BVLC/caffe/pull/3993"},"issue":{"href":"https://api.github.com/repos/BVLC/caffe/issues/3993"},"comments":{"href":"https://api.github.com/repos/BVLC/caffe/issues/3993/comments"},"review_comments":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/3993/comments"},"review_comment":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/3993/commits"},"statuses":{"href":"https://api.github.com/repos/BVLC/caffe/statuses/8960c97268e6e9d99d3456cd635c6694f46c8285"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":20,"deletions":27,"changed_files":3}}