{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/93959213","pull_request_review_id":14490367,"id":93959213,"diff_hunk":"@@ -60,3 +67,22 @@ type RouteTable interface {\n \t// Registers zero or more procedures with the route table.\n \tRegister([]Procedure)\n }\n+\n+// ProceduresByServiceProcedure offers to sort a slice of Procedure by Service\n+// & Procedure.\n+type ProceduresByServiceProcedure []Procedure","path":"api/transport/router.go","position":21,"original_position":21,"commit_id":"556d2545a3a898b7da32d666c670e35c25b177de","original_commit_id":"556d2545a3a898b7da32d666c670e35c25b177de","user":{"login":"bombela","id":216204,"avatar_url":"https://avatars.githubusercontent.com/u/216204?v=3","gravatar_id":"","url":"https://api.github.com/users/bombela","html_url":"https://github.com/bombela","followers_url":"https://api.github.com/users/bombela/followers","following_url":"https://api.github.com/users/bombela/following{/other_user}","gists_url":"https://api.github.com/users/bombela/gists{/gist_id}","starred_url":"https://api.github.com/users/bombela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bombela/subscriptions","organizations_url":"https://api.github.com/users/bombela/orgs","repos_url":"https://api.github.com/users/bombela/repos","events_url":"https://api.github.com/users/bombela/events{/privacy}","received_events_url":"https://api.github.com/users/bombela/received_events","type":"User","site_admin":false},"body":"I reused the existing naming + some changes that got intertwined during a rebase changing the naming to this as well. I am not against a better name!","created_at":"2016-12-27T18:44:43Z","updated_at":"2016-12-27T18:44:44Z","html_url":"https://github.com/yarpc/yarpc-go/pull/636#discussion_r93959213","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/93959213"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/636#discussion_r93959213"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636","id":99030708,"html_url":"https://github.com/yarpc/yarpc-go/pull/636","diff_url":"https://github.com/yarpc/yarpc-go/pull/636.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/636.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/636","number":636,"state":"open","locked":false,"title":"Introspection 1/7, Support for signature in registered procedures","user":{"login":"bombela","id":216204,"avatar_url":"https://avatars.githubusercontent.com/u/216204?v=3","gravatar_id":"","url":"https://api.github.com/users/bombela","html_url":"https://github.com/bombela","followers_url":"https://api.github.com/users/bombela/followers","following_url":"https://api.github.com/users/bombela/following{/other_user}","gists_url":"https://api.github.com/users/bombela/gists{/gist_id}","starred_url":"https://api.github.com/users/bombela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bombela/subscriptions","organizations_url":"https://api.github.com/users/bombela/orgs","repos_url":"https://api.github.com/users/bombela/repos","events_url":"https://api.github.com/users/bombela/events{/privacy}","received_events_url":"https://api.github.com/users/bombela/received_events","type":"User","site_admin":false},"body":"The router will hold onto extra informations about handlers:\n - encoding of the handler\n - signature of the handler\n\nThe yarpc thriftrw plugins will also register a signature automatically.\n\nThe signature is a simple string, hopefully you write in there some Go looking\nfunction definition. This is convenient when you use thrift (or any IDL system\ndoing the generation for you) because most people wont likely bother adding a\nsignature to a json handler by hand.\n\nWhich means, we could use reflection maybe. I tried keeping things simple for now.","created_at":"2016-12-22T00:46:47Z","updated_at":"2016-12-27T18:44:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91040f19fbfcd1bbf01303da296e749ae656c192","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/yarpc/yarpc-go/milestones/2","html_url":"https://github.com/yarpc/yarpc-go/milestone/2","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones/2/labels","id":1980652,"number":2,"title":"1.0.0","description":"Let's start identifying where we need to get before stabilizing the 1.0.0.","creator":{"login":"breerly","id":263587,"avatar_url":"https://avatars.githubusercontent.com/u/263587?v=3","gravatar_id":"","url":"https://api.github.com/users/breerly","html_url":"https://github.com/breerly","followers_url":"https://api.github.com/users/breerly/followers","following_url":"https://api.github.com/users/breerly/following{/other_user}","gists_url":"https://api.github.com/users/breerly/gists{/gist_id}","starred_url":"https://api.github.com/users/breerly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breerly/subscriptions","organizations_url":"https://api.github.com/users/breerly/orgs","repos_url":"https://api.github.com/users/breerly/repos","events_url":"https://api.github.com/users/breerly/events{/privacy}","received_events_url":"https://api.github.com/users/breerly/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":57,"state":"open","created_at":"2016-09-02T17:50:11Z","updated_at":"2016-12-23T01:54:33Z","due_on":"2016-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/636/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/556d2545a3a898b7da32d666c670e35c25b177de","head":{"label":"yarpc:introspection_1","ref":"introspection_1","sha":"556d2545a3a898b7da32d666c670e35c25b177de","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Golang","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2016-12-05T00:47:16Z","pushed_at":"2016-12-27T18:43:53Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":5160,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":64,"forks":3,"open_issues":64,"watchers":11,"default_branch":"dev"}},"base":{"label":"yarpc:dev","ref":"dev","sha":"f115d08611859d5b68477d2b1d04f157b2837a9d","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Golang","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2016-12-05T00:47:16Z","pushed_at":"2016-12-27T18:43:53Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":5160,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":64,"forks":3,"open_issues":64,"watchers":11,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/636"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/636"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/556d2545a3a898b7da32d666c670e35c25b177de"}}}}
{"actor":{"display_login":"bombela"}}