{"action":"created","comment":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/70014323","id":70014323,"diff_hunk":"@@ -82,6 +84,12 @@ public void Should_return_null_for_nullable_properties()\n             }\r\n \r\n             [Fact]\r\n+            public void Should_return_not_null_for_nullable_properties_that_are_user_defined()\r\n+            {\r\n+                _result.NullableMapFrom.ShouldEqual(0);\r","path":"src/UnitTests/NullBehavior.cs","position":24,"original_position":24,"commit_id":"fe6ad9f72e5708aa17d73d7a48191888e4432a6f","original_commit_id":"fe6ad9f72e5708aa17d73d7a48191888e4432a6f","user":{"login":"jbogard","id":104498,"avatar_url":"https://avatars.githubusercontent.com/u/104498?v=3","gravatar_id":"","url":"https://api.github.com/users/jbogard","html_url":"https://github.com/jbogard","followers_url":"https://api.github.com/users/jbogard/followers","following_url":"https://api.github.com/users/jbogard/following{/other_user}","gists_url":"https://api.github.com/users/jbogard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbogard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbogard/subscriptions","organizations_url":"https://api.github.com/users/jbogard/orgs","repos_url":"https://api.github.com/users/jbogard/repos","events_url":"https://api.github.com/users/jbogard/events{/privacy}","received_events_url":"https://api.github.com/users/jbogard/received_events","type":"User","site_admin":false},"body":"So in this case I think the test is wrong, the result should be null. In\nthe original issue, it should be what was expected there too.\n\nOn Thursday, July 7, 2016, Tyler Carlson <notifications@github.com> wrote:\n\n> In src/UnitTests/NullBehavior.cs\n> <https://github.com/AutoMapper/AutoMapper/pull/1485#discussion_r70010586>:\n>\n> > @@ -82,6 +84,12 @@ public void Should_return_null_for_nullable_properties()\n> >              }\n> >\n> >              [Fact]\n> > +            public void Should_return_not_null_for_nullable_properties_that_are_user_defined()\n> > +            {\n> > +                _result.NullableMapFrom.ShouldEqual(0);\n>\n> I refer to line 49. Cause it was user defined from MapFrom, ala a\n> CustomExpression we use the MapFrom's expression's return type which is int.\n>\n> Yea it's not the best example. The issue is if I put conditions ? : into\n> line 49 the seal would throw an exception. So I'm just saying if user\n> defined it it's possible they are there and therefore we can't assume the\n> nullable return type will work. So tests just say it doesn't null on user\n> defined. Again not the best of tests.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/AutoMapper/AutoMapper/pull/1485/files/fe6ad9f72e5708aa17d73d7a48191888e4432a6f#r70010586>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AAGYMn0j2_Gi9ffwg-V4HYBSwGICAQhXks5qTZnAgaJpZM4JHf0X>\n> .\n>\n","created_at":"2016-07-08T01:24:32Z","updated_at":"2016-07-08T01:24:32Z","html_url":"https://github.com/AutoMapper/AutoMapper/pull/1485#discussion_r70014323","pull_request_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485","_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/70014323"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/1485#discussion_r70014323"},"pull_request":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485"}}},"pull_request":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485","id":76664806,"html_url":"https://github.com/AutoMapper/AutoMapper/pull/1485","diff_url":"https://github.com/AutoMapper/AutoMapper/pull/1485.diff","patch_url":"https://github.com/AutoMapper/AutoMapper/pull/1485.patch","issue_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/1485","number":1485,"state":"open","locked":false,"title":"CustomExpressions don't use dest type and have nullable logic","user":{"login":"TylerCarlson1","id":6801536,"avatar_url":"https://avatars.githubusercontent.com/u/6801536?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerCarlson1","html_url":"https://github.com/TylerCarlson1","followers_url":"https://api.github.com/users/TylerCarlson1/followers","following_url":"https://api.github.com/users/TylerCarlson1/following{/other_user}","gists_url":"https://api.github.com/users/TylerCarlson1/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerCarlson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerCarlson1/subscriptions","organizations_url":"https://api.github.com/users/TylerCarlson1/orgs","repos_url":"https://api.github.com/users/TylerCarlson1/repos","events_url":"https://api.github.com/users/TylerCarlson1/events{/privacy}","received_events_url":"https://api.github.com/users/TylerCarlson1/received_events","type":"User","site_admin":false},"body":"Fixes #1483 using Option 2 in https://github.com/AutoMapper/AutoMapper/issues/1483#issuecomment-231195506","created_at":"2016-07-07T21:03:17Z","updated_at":"2016-07-08T01:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5567fc1f5ffeba72492e8dc3e8e5658abda28911","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485/commits","review_comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485/comments","review_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/1485/comments","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/fe6ad9f72e5708aa17d73d7a48191888e4432a6f","head":{"label":"TylerCarlson1:Issue1483","ref":"Issue1483","sha":"fe6ad9f72e5708aa17d73d7a48191888e4432a6f","user":{"login":"TylerCarlson1","id":6801536,"avatar_url":"https://avatars.githubusercontent.com/u/6801536?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerCarlson1","html_url":"https://github.com/TylerCarlson1","followers_url":"https://api.github.com/users/TylerCarlson1/followers","following_url":"https://api.github.com/users/TylerCarlson1/following{/other_user}","gists_url":"https://api.github.com/users/TylerCarlson1/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerCarlson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerCarlson1/subscriptions","organizations_url":"https://api.github.com/users/TylerCarlson1/orgs","repos_url":"https://api.github.com/users/TylerCarlson1/repos","events_url":"https://api.github.com/users/TylerCarlson1/events{/privacy}","received_events_url":"https://api.github.com/users/TylerCarlson1/received_events","type":"User","site_admin":false},"repo":{"id":17238253,"name":"AutoMapper","full_name":"TylerCarlson1/AutoMapper","owner":{"login":"TylerCarlson1","id":6801536,"avatar_url":"https://avatars.githubusercontent.com/u/6801536?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerCarlson1","html_url":"https://github.com/TylerCarlson1","followers_url":"https://api.github.com/users/TylerCarlson1/followers","following_url":"https://api.github.com/users/TylerCarlson1/following{/other_user}","gists_url":"https://api.github.com/users/TylerCarlson1/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerCarlson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerCarlson1/subscriptions","organizations_url":"https://api.github.com/users/TylerCarlson1/orgs","repos_url":"https://api.github.com/users/TylerCarlson1/repos","events_url":"https://api.github.com/users/TylerCarlson1/events{/privacy}","received_events_url":"https://api.github.com/users/TylerCarlson1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TylerCarlson1/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":true,"url":"https://api.github.com/repos/TylerCarlson1/AutoMapper","forks_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/forks","keys_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/teams","hooks_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/events","assignees_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/tags","blobs_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/subscription","commits_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/merges","archive_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/downloads","issues_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/TylerCarlson1/AutoMapper/deployments","created_at":"2014-02-27T05:47:43Z","updated_at":"2016-06-15T01:49:57Z","pushed_at":"2016-07-07T21:09:01Z","git_url":"git://github.com/TylerCarlson1/AutoMapper.git","ssh_url":"git@github.com:TylerCarlson1/AutoMapper.git","clone_url":"https://github.com/TylerCarlson1/AutoMapper.git","svn_url":"https://github.com/TylerCarlson1/AutoMapper","homepage":"http://automapper.org","size":68607,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"AutoMapper:master","ref":"master","sha":"f3e345d958bb999a54c53e73660b51bf6e8c69ee","user":{"login":"AutoMapper","id":890883,"avatar_url":"https://avatars.githubusercontent.com/u/890883?v=3","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"repo":{"id":505380,"name":"AutoMapper","full_name":"AutoMapper/AutoMapper","owner":{"login":"AutoMapper","id":890883,"avatar_url":"https://avatars.githubusercontent.com/u/890883?v=3","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutoMapper/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":false,"url":"https://api.github.com/repos/AutoMapper/AutoMapper","forks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/forks","keys_url":"https://api.github.com/repos/AutoMapper/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoMapper/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoMapper/AutoMapper/teams","hooks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/events","assignees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/AutoMapper/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/tags","blobs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoMapper/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscription","commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/AutoMapper/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoMapper/AutoMapper/merges","archive_url":"https://api.github.com/repos/AutoMapper/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoMapper/AutoMapper/downloads","issues_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoMapper/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoMapper/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/AutoMapper/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/deployments","created_at":"2010-02-06T15:17:58Z","updated_at":"2016-07-07T14:51:46Z","pushed_at":"2016-07-07T21:09:02Z","git_url":"git://github.com/AutoMapper/AutoMapper.git","ssh_url":"git@github.com:AutoMapper/AutoMapper.git","clone_url":"https://github.com/AutoMapper/AutoMapper.git","svn_url":"https://github.com/AutoMapper/AutoMapper","homepage":"http://automapper.org","size":138358,"stargazers_count":3626,"watchers_count":3626,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":960,"mirror_url":null,"open_issues_count":23,"forks":960,"open_issues":23,"watchers":3626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/1485"},"issue":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/1485"},"comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/1485/comments"},"review_comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485/comments"},"review_comment":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/1485/commits"},"statuses":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/fe6ad9f72e5708aa17d73d7a48191888e4432a6f"}}}}
{"actor":{"display_login":"jbogard"}}