{"action":"created","issue":{"url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/27","repository_url":"https://api.github.com/repos/tim-evans/ember-page-title","labels_url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/27/comments","events_url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/27/events","html_url":"https://github.com/tim-evans/ember-page-title/pull/27","id":143419317,"number":27,"title":"FastBoot compatibility with ember-cli-head","user":{"login":"ronco","id":613156,"avatar_url":"https://avatars.githubusercontent.com/u/613156?v=3","gravatar_id":"","url":"https://api.github.com/users/ronco","html_url":"https://github.com/ronco","followers_url":"https://api.github.com/users/ronco/followers","following_url":"https://api.github.com/users/ronco/following{/other_user}","gists_url":"https://api.github.com/users/ronco/gists{/gist_id}","starred_url":"https://api.github.com/users/ronco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronco/subscriptions","organizations_url":"https://api.github.com/users/ronco/orgs","repos_url":"https://api.github.com/users/ronco/repos","events_url":"https://api.github.com/users/ronco/events{/privacy}","received_events_url":"https://api.github.com/users/ronco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-25T04:08:39Z","updated_at":"2016-03-25T04:15:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tim-evans/ember-page-title/pulls/27","html_url":"https://github.com/tim-evans/ember-page-title/pull/27","diff_url":"https://github.com/tim-evans/ember-page-title/pull/27.diff","patch_url":"https://github.com/tim-evans/ember-page-title/pull/27.patch"},"body":"This will add FastBoot compatibility by way of `ember-cli-head`.\r\n\r\nThere are 2 outstanding issues I'd like to resolve before this get merged:\r\n - [ ] I know @tim-evans wants to ensure consuming apps don't need to change for this functionality.  As it sits now the original `<title>` tag in an app's `index.html` would need to be removed since `ember-cli-head` provides it's own content but doesn't directly manipulate document.title.  I think there are a few options to address this (all of which have potential downsides):\r\n   1. Make the release version a semantic API bump (3.0.0) and provide upgrade instructions to remove your existing `<title>` tag.  This is the implementation as it currently stands in this PR.\r\n   2. Have branching logic around the setting of the head data to set document when FastBoot is not present, and use headData when FastBoot is found.  Downside here is we'd be needlessly pulling in ember-cli-head in those scenarios and we'd need to wrap the display of title in `head.hbs` with an if clause.\r\n   3. Or I go back on my initial thought and do try to tackle this in `ember-cli-head`.  Then we could use the approach in **ii.** but isolate the ugliness to `ember-cli-head`.  This would have the downside of either adding an observer or an explicit setTitle method to the headData service, neither of which I'm not crazy about.\r\n - [ ] I also need to test it out in a consuming app and ensure everything installs correctly.  Acceptance tests are passing for the dummy application (at least in ember release), but need to be certain apps don't run into issues.\r\n\r\nLet me know what you think.  Once we come to a consensus I can clean it up and test it in a consuming app."},"comment":{"url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/comments/201128538","html_url":"https://github.com/tim-evans/ember-page-title/pull/27#issuecomment-201128538","issue_url":"https://api.github.com/repos/tim-evans/ember-page-title/issues/27","id":201128538,"user":{"login":"tim-evans","id":177701,"avatar_url":"https://avatars.githubusercontent.com/u/177701?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-evans","html_url":"https://github.com/tim-evans","followers_url":"https://api.github.com/users/tim-evans/followers","following_url":"https://api.github.com/users/tim-evans/following{/other_user}","gists_url":"https://api.github.com/users/tim-evans/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-evans/subscriptions","organizations_url":"https://api.github.com/users/tim-evans/orgs","repos_url":"https://api.github.com/users/tim-evans/repos","events_url":"https://api.github.com/users/tim-evans/events{/privacy}","received_events_url":"https://api.github.com/users/tim-evans/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T04:15:46Z","updated_at":"2016-03-25T04:15:46Z","body":"The dummy app is a consuming app :wink:, so that should be a good test."}}