{"action":"created","issue":{"url":"https://api.github.com/repos/Brightspace/ifrau/issues/78","repository_url":"https://api.github.com/repos/Brightspace/ifrau","labels_url":"https://api.github.com/repos/Brightspace/ifrau/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/Brightspace/ifrau/issues/78/comments","events_url":"https://api.github.com/repos/Brightspace/ifrau/issues/78/events","html_url":"https://github.com/Brightspace/ifrau/pull/78","id":140436085,"number":78,"title":"send error message for an unknown handler rather than silently ignori…","user":{"login":"mdgbayly","id":493938,"avatar_url":"https://avatars.githubusercontent.com/u/493938?v=3","gravatar_id":"","url":"https://api.github.com/users/mdgbayly","html_url":"https://github.com/mdgbayly","followers_url":"https://api.github.com/users/mdgbayly/followers","following_url":"https://api.github.com/users/mdgbayly/following{/other_user}","gists_url":"https://api.github.com/users/mdgbayly/gists{/gist_id}","starred_url":"https://api.github.com/users/mdgbayly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdgbayly/subscriptions","organizations_url":"https://api.github.com/users/mdgbayly/orgs","repos_url":"https://api.github.com/users/mdgbayly/repos","events_url":"https://api.github.com/users/mdgbayly/events{/privacy}","received_events_url":"https://api.github.com/users/mdgbayly/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Brightspace/ifrau/labels/semver-major","name":"semver-major","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-03-13T01:58:15Z","updated_at":"2016-03-15T17:16:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Brightspace/ifrau/pulls/78","html_url":"https://github.com/Brightspace/ifrau/pull/78","diff_url":"https://github.com/Brightspace/ifrau/pull/78.diff","patch_url":"https://github.com/Brightspace/ifrau/pull/78.patch"},"body":"…ng as causes client to hang.\r\n\r\nWhen adding the new onRequest handler for sending intl config overrides, I wanted to make it so that our FRA could be backwards compatible with LMS instances that do not have this handler deployed.\r\n\r\nMaybe there is a good reason for silently ignoring unknown handlers, and generally you would not configure a FRA version in an LMS that does not support the FRA. But we usually get FRA updates out much more quickly than LMS updates and so it would be annoying to not be able to test new versions of the FRA in an older LMS.\r\n\r\nBy sending an error response we can code our FRA to check for a rejected promise when asking for the intl object.  Without this fix, our FRA just hangs and I wasn't sure if there was any other way to conditionally check for the existence of the handler."},"comment":{"url":"https://api.github.com/repos/Brightspace/ifrau/issues/comments/196931070","html_url":"https://github.com/Brightspace/ifrau/pull/78#issuecomment-196931070","issue_url":"https://api.github.com/repos/Brightspace/ifrau/issues/78","id":196931070,"user":{"login":"omsmith","id":1127384,"avatar_url":"https://avatars.githubusercontent.com/u/1127384?v=3","gravatar_id":"","url":"https://api.github.com/users/omsmith","html_url":"https://github.com/omsmith","followers_url":"https://api.github.com/users/omsmith/followers","following_url":"https://api.github.com/users/omsmith/following{/other_user}","gists_url":"https://api.github.com/users/omsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/omsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omsmith/subscriptions","organizations_url":"https://api.github.com/users/omsmith/orgs","repos_url":"https://api.github.com/users/omsmith/repos","events_url":"https://api.github.com/users/omsmith/events{/privacy}","received_events_url":"https://api.github.com/users/omsmith/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T17:16:30Z","updated_at":"2016-03-15T17:16:30Z","body":"LGTM otherwise as well."}}