{"action":"opened","issue":{"url":"https://api.github.com/repos/maidsafe/safe_launcher/issues/159","repository_url":"https://api.github.com/repos/maidsafe/safe_launcher","labels_url":"https://api.github.com/repos/maidsafe/safe_launcher/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/safe_launcher/issues/159/comments","events_url":"https://api.github.com/repos/maidsafe/safe_launcher/issues/159/events","html_url":"https://github.com/maidsafe/safe_launcher/issues/159","id":161292178,"number":159,"title":"Malformed URLs not filtered by launcher","user":{"login":"davidpbrown","id":1708690,"avatar_url":"https://avatars.githubusercontent.com/u/1708690?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpbrown","html_url":"https://github.com/davidpbrown","followers_url":"https://api.github.com/users/davidpbrown/followers","following_url":"https://api.github.com/users/davidpbrown/following{/other_user}","gists_url":"https://api.github.com/users/davidpbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpbrown/subscriptions","organizations_url":"https://api.github.com/users/davidpbrown/orgs","repos_url":"https://api.github.com/users/davidpbrown/repos","events_url":"https://api.github.com/users/davidpbrown/events{/privacy}","received_events_url":"https://api.github.com/users/davidpbrown/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-20T20:54:59Z","updated_at":"2016-06-20T20:54:59Z","closed_at":null,"body":"I can't see the problem directly but wonder that the launcher/proxy is not checking URLs put to it and instead relying on the network's response.\r\n\r\nAlso, I notice that certain characters appear to see the launcher hang and they get no quick reply.. or likely none at all.\r\n\r\nThe usual reply to a non-existent domain appears to be:\r\n```\r\nERROR 21:36:51.503097038 [safe_core::ffi mod.rs:330] \r\n\r\n --------------------------------------------------\r\n| FfiError::DnsError -> DnsError::CoreError -> No such dataCoreError::GetFailure::{ reason: NoSuchData, request: Structured(dc641a.., 5)}\r\n --------------------------------------------------\r\n``` \r\nI would have expected a different type of error, for malformed urls, like abc_def.safenet or uvw#xyz.safenet\r\n\r\nSo, a PublicID.safenet and I would expect also Subdomain.PublicID.safenet containing # ! * appear to hang waiting forever, while other characters like _ and - get a quick not found error.\r\n\r\nCould launcher proxy filter invalid publicID and subdomain names in safenet URLs? To be clear, it seems the error response is identical to nonexistent domain reply and perhaps that's an unneeded request for the network to deal with. Obviously, the network would still need capability to reject those bad requests but surely it's better not see normal sending of those.\r\n\r\nNote: I'm seeing this when using wget to request files and the response in the launcher's terminal. I can't tell a difference between the hanging requests that follow from characters like # ! * in .safenet requests and that which occurs for bad urls outside of .safenet - so .safetynet hangs in the same way, so perhaps those characters cause a confusion in wget rather than in the launcher. Still, I worry that the characters not being handled might risk user input interactions in the launcher, if that input is being trusted or put to the network without filtering for only [a-z0-9]."}}
{"actor":{"display_login":"davidpbrown"}}