{"action":"created","comment":{"url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments/48697741","id":48697741,"diff_hunk":"@@ -1,13 +1,20 @@\n //\n // Copyright (c) 2015 IronCore Labs\n //\n-package com.ironcorelabs.davenport.db\n+package com.ironcorelabs.davenport\n+package db\n+","path":"src/main/scala/com/ironcorelabs/davenport/db/Wrappers.scala","position":7,"original_position":7,"commit_id":"ce1bf6bb3b5f93c2732adafdc430141379b23c6a","original_commit_id":"ce1bf6bb3b5f93c2732adafdc430141379b23c6a","user":{"login":"zmre","id":71791,"avatar_url":"https://avatars.githubusercontent.com/u/71791?v=3","gravatar_id":"","url":"https://api.github.com/users/zmre","html_url":"https://github.com/zmre","followers_url":"https://api.github.com/users/zmre/followers","following_url":"https://api.github.com/users/zmre/following{/other_user}","gists_url":"https://api.github.com/users/zmre/gists{/gist_id}","starred_url":"https://api.github.com/users/zmre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmre/subscriptions","organizations_url":"https://api.github.com/users/zmre/orgs","repos_url":"https://api.github.com/users/zmre/repos","events_url":"https://api.github.com/users/zmre/events{/privacy}","received_events_url":"https://api.github.com/users/zmre/received_events","type":"User","site_admin":false},"body":"Question: what's the advantage of doing two package lines over just the one?  Does that do an automatic import of the parent scope or something?","created_at":"2016-01-03T21:55:15Z","updated_at":"2016-01-03T21:55:15Z","html_url":"https://github.com/IronCoreLabs/davenport/pull/45#discussion_r48697741","pull_request_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments/48697741"},"html":{"href":"https://github.com/IronCoreLabs/davenport/pull/45#discussion_r48697741"},"pull_request":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45","id":54931924,"html_url":"https://github.com/IronCoreLabs/davenport/pull/45","diff_url":"https://github.com/IronCoreLabs/davenport/pull/45.diff","patch_url":"https://github.com/IronCoreLabs/davenport/pull/45.patch","issue_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/45","number":45,"state":"open","locked":false,"title":"Remove java lib","user":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"body":"This PR does a few things:\r\n- Remove dependency on the Java lib. We didn't real utilize any of the functionality it provided above what the java core provides\r\n- Convert to scalaz.concurrent.Task at the lowest level possible\r\n- Provide a pair of typeclasses that provide the ability to encode and decode raw values coming back from couchbase.\r\n\r\n\r\nFor now I classify errors the same way the Java lib does. See `error` package, but we can expand on it as needed.","created_at":"2016-01-03T20:47:51Z","updated_at":"2016-01-03T21:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eb4635494879dbbb00a10f283c249af98feacd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45/commits","review_comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45/comments","review_comment_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/45/comments","statuses_url":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/ce1bf6bb3b5f93c2732adafdc430141379b23c6a","head":{"label":"coltfred:removeJavaLib","ref":"removeJavaLib","sha":"ce1bf6bb3b5f93c2732adafdc430141379b23c6a","user":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"repo":{"id":41130509,"name":"davenport","full_name":"coltfred/davenport","owner":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coltfred/davenport","description":"A principled CouchBase library for Scala","fork":true,"url":"https://api.github.com/repos/coltfred/davenport","forks_url":"https://api.github.com/repos/coltfred/davenport/forks","keys_url":"https://api.github.com/repos/coltfred/davenport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coltfred/davenport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coltfred/davenport/teams","hooks_url":"https://api.github.com/repos/coltfred/davenport/hooks","issue_events_url":"https://api.github.com/repos/coltfred/davenport/issues/events{/number}","events_url":"https://api.github.com/repos/coltfred/davenport/events","assignees_url":"https://api.github.com/repos/coltfred/davenport/assignees{/user}","branches_url":"https://api.github.com/repos/coltfred/davenport/branches{/branch}","tags_url":"https://api.github.com/repos/coltfred/davenport/tags","blobs_url":"https://api.github.com/repos/coltfred/davenport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coltfred/davenport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coltfred/davenport/git/refs{/sha}","trees_url":"https://api.github.com/repos/coltfred/davenport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coltfred/davenport/statuses/{sha}","languages_url":"https://api.github.com/repos/coltfred/davenport/languages","stargazers_url":"https://api.github.com/repos/coltfred/davenport/stargazers","contributors_url":"https://api.github.com/repos/coltfred/davenport/contributors","subscribers_url":"https://api.github.com/repos/coltfred/davenport/subscribers","subscription_url":"https://api.github.com/repos/coltfred/davenport/subscription","commits_url":"https://api.github.com/repos/coltfred/davenport/commits{/sha}","git_commits_url":"https://api.github.com/repos/coltfred/davenport/git/commits{/sha}","comments_url":"https://api.github.com/repos/coltfred/davenport/comments{/number}","issue_comment_url":"https://api.github.com/repos/coltfred/davenport/issues/comments{/number}","contents_url":"https://api.github.com/repos/coltfred/davenport/contents/{+path}","compare_url":"https://api.github.com/repos/coltfred/davenport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coltfred/davenport/merges","archive_url":"https://api.github.com/repos/coltfred/davenport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coltfred/davenport/downloads","issues_url":"https://api.github.com/repos/coltfred/davenport/issues{/number}","pulls_url":"https://api.github.com/repos/coltfred/davenport/pulls{/number}","milestones_url":"https://api.github.com/repos/coltfred/davenport/milestones{/number}","notifications_url":"https://api.github.com/repos/coltfred/davenport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coltfred/davenport/labels{/name}","releases_url":"https://api.github.com/repos/coltfred/davenport/releases{/id}","created_at":"2015-08-21T02:46:20Z","updated_at":"2015-08-21T02:46:21Z","pushed_at":"2016-01-03T20:59:51Z","git_url":"git://github.com/coltfred/davenport.git","ssh_url":"git@github.com:coltfred/davenport.git","clone_url":"https://github.com/coltfred/davenport.git","svn_url":"https://github.com/coltfred/davenport","homepage":null,"size":278,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IronCoreLabs:master","ref":"master","sha":"98b95738773d5ecdd02cdf4c538227880213275f","user":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars.githubusercontent.com/u/11394047?v=3","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":41042360,"name":"davenport","full_name":"IronCoreLabs/davenport","owner":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars.githubusercontent.com/u/11394047?v=3","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IronCoreLabs/davenport","description":"A principled CouchBase library for Scala","fork":false,"url":"https://api.github.com/repos/IronCoreLabs/davenport","forks_url":"https://api.github.com/repos/IronCoreLabs/davenport/forks","keys_url":"https://api.github.com/repos/IronCoreLabs/davenport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IronCoreLabs/davenport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IronCoreLabs/davenport/teams","hooks_url":"https://api.github.com/repos/IronCoreLabs/davenport/hooks","issue_events_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/events{/number}","events_url":"https://api.github.com/repos/IronCoreLabs/davenport/events","assignees_url":"https://api.github.com/repos/IronCoreLabs/davenport/assignees{/user}","branches_url":"https://api.github.com/repos/IronCoreLabs/davenport/branches{/branch}","tags_url":"https://api.github.com/repos/IronCoreLabs/davenport/tags","blobs_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/refs{/sha}","trees_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/{sha}","languages_url":"https://api.github.com/repos/IronCoreLabs/davenport/languages","stargazers_url":"https://api.github.com/repos/IronCoreLabs/davenport/stargazers","contributors_url":"https://api.github.com/repos/IronCoreLabs/davenport/contributors","subscribers_url":"https://api.github.com/repos/IronCoreLabs/davenport/subscribers","subscription_url":"https://api.github.com/repos/IronCoreLabs/davenport/subscription","commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/commits{/sha}","git_commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/commits{/sha}","comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/comments{/number}","issue_comment_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/comments{/number}","contents_url":"https://api.github.com/repos/IronCoreLabs/davenport/contents/{+path}","compare_url":"https://api.github.com/repos/IronCoreLabs/davenport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IronCoreLabs/davenport/merges","archive_url":"https://api.github.com/repos/IronCoreLabs/davenport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IronCoreLabs/davenport/downloads","issues_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues{/number}","pulls_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls{/number}","milestones_url":"https://api.github.com/repos/IronCoreLabs/davenport/milestones{/number}","notifications_url":"https://api.github.com/repos/IronCoreLabs/davenport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IronCoreLabs/davenport/labels{/name}","releases_url":"https://api.github.com/repos/IronCoreLabs/davenport/releases{/id}","created_at":"2015-08-19T15:22:43Z","updated_at":"2015-11-05T21:35:30Z","pushed_at":"2016-01-03T20:59:52Z","git_url":"git://github.com/IronCoreLabs/davenport.git","ssh_url":"git@github.com:IronCoreLabs/davenport.git","clone_url":"https://github.com/IronCoreLabs/davenport.git","svn_url":"https://github.com/IronCoreLabs/davenport","homepage":"https://ironcorelabs.com/davenport","size":680,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45"},"html":{"href":"https://github.com/IronCoreLabs/davenport/pull/45"},"issue":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/issues/45"},"comments":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/ce1bf6bb3b5f93c2732adafdc430141379b23c6a"}}}}