{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/comments/92280576","pull_request_review_id":12793399,"id":92280576,"diff_hunk":"@@ -73,8 +73,8 @@ class AutoCollectClientRequests {\n      * Tracks an outgoing request. Because it may set headers this method must be called before\n      * writing content to or ending the request.\n      */\n-    public static trackRequest(client: Client, requestOptions: any, request: http.ClientRequest,\n-            properties?: { [key: string]: string }) {\n+    public static trackRequest(client: Client, requestOptions: http.RequestOptions, request: http.ClientRequest,","path":"AutoCollection/ClientRequests.ts","position":29,"original_position":29,"commit_id":"b0b2a8736cfa8a5b66f45d56c70af112ff6360a0","original_commit_id":"b0b2a8736cfa8a5b66f45d56c70af112ff6360a0","user":{"login":"jasongin","id":13093042,"avatar_url":"https://avatars.githubusercontent.com/u/13093042?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongin","html_url":"https://github.com/jasongin","followers_url":"https://api.github.com/users/jasongin/followers","following_url":"https://api.github.com/users/jasongin/following{/other_user}","gists_url":"https://api.github.com/users/jasongin/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongin/subscriptions","organizations_url":"https://api.github.com/users/jasongin/orgs","repos_url":"https://api.github.com/users/jasongin/repos","events_url":"https://api.github.com/users/jasongin/events{/privacy}","received_events_url":"https://api.github.com/users/jasongin/received_events","type":"User","site_admin":false},"body":"Consider adding a host property to the `ClientRequestParser` (and move the call to it up before line 88) so that you can re-use its request options parsing instead of duplicating it. Or something like that.","created_at":"2016-12-13T22:22:05Z","updated_at":"2016-12-13T22:22:05Z","html_url":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156#discussion_r92280576","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/comments/92280576"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156#discussion_r92280576"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156","id":97839945,"html_url":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156","diff_url":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/156","number":156,"state":"open","locked":false,"title":"Do not add correlation headers for excluded domains","user":{"login":"kamilszostak","id":12164228,"avatar_url":"https://avatars.githubusercontent.com/u/12164228?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilszostak","html_url":"https://github.com/kamilszostak","followers_url":"https://api.github.com/users/kamilszostak/followers","following_url":"https://api.github.com/users/kamilszostak/following{/other_user}","gists_url":"https://api.github.com/users/kamilszostak/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilszostak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilszostak/subscriptions","organizations_url":"https://api.github.com/users/kamilszostak/orgs","repos_url":"https://api.github.com/users/kamilszostak/repos","events_url":"https://api.github.com/users/kamilszostak/events{/privacy}","received_events_url":"https://api.github.com/users/kamilszostak/received_events","type":"User","site_admin":false},"body":"Fixes #143","created_at":"2016-12-13T21:32:54Z","updated_at":"2016-12-13T22:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a01c5da44d19979f1f65d0b17900ece7a3e46c2c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/milestones/12","html_url":"https://github.com/Microsoft/ApplicationInsights-node.js/milestone/12","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/milestones/12/labels","id":2192113,"number":12,"title":"v0.17.2","description":null,"creator":{"login":"kamilszostak","id":12164228,"avatar_url":"https://avatars.githubusercontent.com/u/12164228?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilszostak","html_url":"https://github.com/kamilszostak","followers_url":"https://api.github.com/users/kamilszostak/followers","following_url":"https://api.github.com/users/kamilszostak/following{/other_user}","gists_url":"https://api.github.com/users/kamilszostak/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilszostak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilszostak/subscriptions","organizations_url":"https://api.github.com/users/kamilszostak/orgs","repos_url":"https://api.github.com/users/kamilszostak/repos","events_url":"https://api.github.com/users/kamilszostak/events{/privacy}","received_events_url":"https://api.github.com/users/kamilszostak/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-12-12T20:28:44Z","updated_at":"2016-12-13T21:32:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/156/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/statuses/b0b2a8736cfa8a5b66f45d56c70af112ff6360a0","head":{"label":"Microsoft:ExcludedDomains","ref":"ExcludedDomains","sha":"b0b2a8736cfa8a5b66f45d56c70af112ff6360a0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":22624502,"name":"ApplicationInsights-node.js","full_name":"Microsoft/ApplicationInsights-node.js","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-node.js","description":"Microsoft Application Insights SDK for node.js","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/deployments","created_at":"2014-08-05T00:27:13Z","updated_at":"2016-12-02T07:02:19Z","pushed_at":"2016-12-13T21:32:55Z","git_url":"git://github.com/Microsoft/ApplicationInsights-node.js.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-node.js.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-node.js.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-node.js","homepage":null,"size":505,"stargazers_count":77,"watchers_count":77,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":28,"forks":36,"open_issues":28,"watchers":77,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"847fd12db1b2c9d33b968b625fce892ac3b00653","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":22624502,"name":"ApplicationInsights-node.js","full_name":"Microsoft/ApplicationInsights-node.js","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-node.js","description":"Microsoft Application Insights SDK for node.js","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/deployments","created_at":"2014-08-05T00:27:13Z","updated_at":"2016-12-02T07:02:19Z","pushed_at":"2016-12-13T21:32:55Z","git_url":"git://github.com/Microsoft/ApplicationInsights-node.js.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-node.js.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-node.js.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-node.js","homepage":null,"size":505,"stargazers_count":77,"watchers_count":77,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":28,"forks":36,"open_issues":28,"watchers":77,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-node.js/pull/156"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/156"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-node.js/statuses/b0b2a8736cfa8a5b66f45d56c70af112ff6360a0"}}}}
{"actor":{"display_login":"jasongin"}}