{"action":"created","issue":{"url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/28","repository_url":"https://api.github.com/repos/ABAPlan/abaplan-core","labels_url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/28/comments","events_url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/28/events","html_url":"https://github.com/ABAPlan/abaplan-core/pull/28","id":189847378,"number":28,"title":"Add SqlLite in map.service.ts","user":{"login":"JohnerPierre","id":22793285,"avatar_url":"https://avatars.githubusercontent.com/u/22793285?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnerPierre","html_url":"https://github.com/JohnerPierre","followers_url":"https://api.github.com/users/JohnerPierre/followers","following_url":"https://api.github.com/users/JohnerPierre/following{/other_user}","gists_url":"https://api.github.com/users/JohnerPierre/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnerPierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnerPierre/subscriptions","organizations_url":"https://api.github.com/users/JohnerPierre/orgs","repos_url":"https://api.github.com/users/JohnerPierre/repos","events_url":"https://api.github.com/users/JohnerPierre/events{/privacy}","received_events_url":"https://api.github.com/users/JohnerPierre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-11-16T21:15:37Z","updated_at":"2016-11-23T09:18:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ABAPlan/abaplan-core/pulls/28","html_url":"https://github.com/ABAPlan/abaplan-core/pull/28","diff_url":"https://github.com/ABAPlan/abaplan-core/pull/28.diff","patch_url":"https://github.com/ABAPlan/abaplan-core/pull/28.patch"},"body":"J'ai quelques questions sur le code , je le mets en Request directement pour plus de simplicité.\r\n\r\n- J'ai ajouter la base SQLite directement dans le dossier App avec son nom d'origine . Etant temporaire je ne sais si je dois le déplacer ou si je peux le laisser comme ça directement.\r\n\r\nDans le fichier map.service.ts \r\n\r\n- (Ligne 6)J'ai importer directement le module Sqlite mais je ne sais pas comment le faire directement avec npm.\r\n\r\n- (Ligne 38&39) Les champs sont dans la base de données ne sont pas dans la structure donc je les ai mis en constante , mais je sais pas quelle valeur je dois leur assigner par défaut.\r\n\r\n\r\nMerci d'avance et Bonne soirée "},"comment":{"url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/comments/262464777","html_url":"https://github.com/ABAPlan/abaplan-core/pull/28#issuecomment-262464777","issue_url":"https://api.github.com/repos/ABAPlan/abaplan-core/issues/28","id":262464777,"user":{"login":"jcavat","id":1701806,"avatar_url":"https://avatars.githubusercontent.com/u/1701806?v=3","gravatar_id":"","url":"https://api.github.com/users/jcavat","html_url":"https://github.com/jcavat","followers_url":"https://api.github.com/users/jcavat/followers","following_url":"https://api.github.com/users/jcavat/following{/other_user}","gists_url":"https://api.github.com/users/jcavat/gists{/gist_id}","starred_url":"https://api.github.com/users/jcavat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcavat/subscriptions","organizations_url":"https://api.github.com/users/jcavat/orgs","repos_url":"https://api.github.com/users/jcavat/repos","events_url":"https://api.github.com/users/jcavat/events{/privacy}","received_events_url":"https://api.github.com/users/jcavat/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T09:18:18Z","updated_at":"2016-11-23T09:18:18Z","body":"Salut,\n\nLa branche s'appelle feature-sqlite.\n\ngit fetch\ngit checkout feature-sqlite\n\nhttps://github.com/ABAPlan/abaplan-core/tree/feature-sqlite\n\n\n\nLe 22. 11. 16 à 17:06, JohnerPierre a écrit :\n>\n> Bonsoir,\n>\n> J'ai crée une nouvelle branche depuis la master . On avait ajouter \n> dans le typings.json une ligne pour le sqlite3 mais je ne la trouve ni \n> sur l'ancienne branche ni sur la master , du coup même problème que \n> avant avec l'erreur _handler.\n>\n> merci d'avance\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/ABAPlan/abaplan-core/pull/28#issuecomment-262282948>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/ABn3rlIB00lmBZY0cmxVmX2miXQo4o3Sks5rAxL1gaJpZM4K0d0U>.\n>\n\n"}}
{"actor":{"display_login":"jcavat"}}