{"action":"created","comment":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/83736390","pull_request_review_id":4558773,"id":83736390,"diff_hunk":"@@ -83,14 +82,29 @@ ht_neuron_dynamics( double, const double y[], double f[], void* pnode )\n   // Synaptic channels\n   double I_syn = 0;\n \n+  /*\n+   * NMDA conductance\n+   *\n+   * We need to take care to handle instantaneous blocking correctly.\n+   * If the unblock-variables Mg_{fast,slow} > Mg_ss, the steady-state","path":"models/ht_neuron.cpp","position":18,"original_position":18,"commit_id":"ffbdb18bd310bd4eceadb8c8ed9b4e920dad285f","original_commit_id":"ffbdb18bd310bd4eceadb8c8ed9b4e920dad285f","user":{"login":"Silmathoron","id":8523051,"avatar_url":"https://avatars.githubusercontent.com/u/8523051?v=3","gravatar_id":"","url":"https://api.github.com/users/Silmathoron","html_url":"https://github.com/Silmathoron","followers_url":"https://api.github.com/users/Silmathoron/followers","following_url":"https://api.github.com/users/Silmathoron/following{/other_user}","gists_url":"https://api.github.com/users/Silmathoron/gists{/gist_id}","starred_url":"https://api.github.com/users/Silmathoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silmathoron/subscriptions","organizations_url":"https://api.github.com/users/Silmathoron/orgs","repos_url":"https://api.github.com/users/Silmathoron/repos","events_url":"https://api.github.com/users/Silmathoron/events{/privacy}","received_events_url":"https://api.github.com/users/Silmathoron/received_events","type":"User","site_admin":false},"body":"This looks unclear to me, you mean \"if the unblock variables are greater than their respective steady-state values\", right? I think the combination of equation and text sentence with commas is rather disturbing.","created_at":"2016-10-17T21:19:16Z","updated_at":"2016-10-17T21:19:16Z","html_url":"https://github.com/nest/nest-simulator/pull/491#discussion_r83736390","pull_request_url":"https://api.github.com/repos/nest/nest-simulator/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/83736390"},"html":{"href":"https://github.com/nest/nest-simulator/pull/491#discussion_r83736390"},"pull_request":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/491","id":86288803,"html_url":"https://github.com/nest/nest-simulator/pull/491","diff_url":"https://github.com/nest/nest-simulator/pull/491.diff","patch_url":"https://github.com/nest/nest-simulator/pull/491.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/491","number":491,"state":"open","locked":false,"title":"Implement full NMDA dynamics in ht_neuron","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"body":"Implement the full NMDA model from the Hill-Tononi paper with instantaneous blocking and fast and slow unblocking. This PR will change model behavior.\r\n\r\nAs reviewers, I suggest @ingablundell and @suku248.","created_at":"2016-09-22T07:16:35Z","updated_at":"2016-10-17T21:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a42bc17430629e1ff9454f43e24801e86e8df859","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/491/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/491/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/491/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/ffbdb18bd310bd4eceadb8c8ed9b4e920dad285f","head":{"label":"heplesser:HT_NMDA","ref":"HT_NMDA","sha":"ffbdb18bd310bd4eceadb8c8ed9b4e920dad285f","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"repo":{"id":35492378,"name":"nest-simulator","full_name":"heplesser/nest-simulator","owner":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heplesser/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/heplesser/nest-simulator","forks_url":"https://api.github.com/repos/heplesser/nest-simulator/forks","keys_url":"https://api.github.com/repos/heplesser/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heplesser/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heplesser/nest-simulator/teams","hooks_url":"https://api.github.com/repos/heplesser/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/heplesser/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/heplesser/nest-simulator/events","assignees_url":"https://api.github.com/repos/heplesser/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/heplesser/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/heplesser/nest-simulator/tags","blobs_url":"https://api.github.com/repos/heplesser/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heplesser/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heplesser/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/heplesser/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heplesser/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/heplesser/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/heplesser/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/heplesser/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/heplesser/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/heplesser/nest-simulator/subscription","commits_url":"https://api.github.com/repos/heplesser/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/heplesser/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/heplesser/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/heplesser/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/heplesser/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/heplesser/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heplesser/nest-simulator/merges","archive_url":"https://api.github.com/repos/heplesser/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heplesser/nest-simulator/downloads","issues_url":"https://api.github.com/repos/heplesser/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/heplesser/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/heplesser/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/heplesser/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heplesser/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/heplesser/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/heplesser/nest-simulator/deployments","created_at":"2015-05-12T14:16:50Z","updated_at":"2016-01-27T22:26:53Z","pushed_at":"2016-10-13T10:43:54Z","git_url":"git://github.com/heplesser/nest-simulator.git","ssh_url":"git@github.com:heplesser/nest-simulator.git","clone_url":"https://github.com/heplesser/nest-simulator.git","svn_url":"https://github.com/heplesser/nest-simulator","homepage":null,"size":28862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"38a96080ea268e064b9f6df207c06906a0beba97","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-09-30T00:55:47Z","pushed_at":"2016-10-17T15:25:16Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":33565,"stargazers_count":87,"watchers_count":87,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":165,"forks":90,"open_issues":165,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/491"},"html":{"href":"https://github.com/nest/nest-simulator/pull/491"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/491"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/ffbdb18bd310bd4eceadb8c8ed9b4e920dad285f"}}}}
{"actor":{"display_login":"Silmathoron"}}