{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/84764371","pull_request_review_id":5521399,"id":84764371,"diff_hunk":"@@ -243,17 +243,20 @@ and set a new ``Exception`` object, or do nothing::\n \n     As Symfony ensures that the Response status code is set to the most\n     appropriate one depending on the exception, setting the status on the\n-    response won't work. If you want to overwrite the status code (which you\n-    should not without a good reason), set the ``X-Status-Code`` header::\n-\n-        $response = new Response(\n-            'Error',\n-            404, // this status code will be ignored\n-            array(\n-                'X-Status-Code' => 200 // this status code will actually be sent to the client\n-            )\n-        );\n+    response alone won't work. If you want to overwrite the status code\n+    (which you should not without a good reason), call\n+    ``GetResponseForExceptionEvent::setAllowSuccessfulResponse(true)`` and","path":"reference/events.rst","position":16,"original_position":16,"commit_id":"c413297a6324b7c58247b471b12dfc2c86a6b54a","original_commit_id":"c413297a6324b7c58247b471b12dfc2c86a6b54a","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"should be `setAllowCustomResponseCode` as the method has been renamed.","created_at":"2016-10-24T19:27:13Z","updated_at":"2016-10-24T19:27:13Z","html_url":"https://github.com/symfony/symfony-docs/pull/6948#discussion_r84764371","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/84764371"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/6948#discussion_r84764371"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948","id":83780564,"html_url":"https://github.com/symfony/symfony-docs/pull/6948","diff_url":"https://github.com/symfony/symfony-docs/pull/6948.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/6948.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/6948","number":6948,"state":"open","locked":false,"title":"Update docs for setting custom response code in exception handler","user":{"login":"jameshalsall","id":499932,"avatar_url":"https://avatars.githubusercontent.com/u/499932?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshalsall","html_url":"https://github.com/jameshalsall","followers_url":"https://api.github.com/users/jameshalsall/followers","following_url":"https://api.github.com/users/jameshalsall/following{/other_user}","gists_url":"https://api.github.com/users/jameshalsall/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshalsall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshalsall/subscriptions","organizations_url":"https://api.github.com/users/jameshalsall/orgs","repos_url":"https://api.github.com/users/jameshalsall/repos","events_url":"https://api.github.com/users/jameshalsall/events{/privacy}","received_events_url":"https://api.github.com/users/jameshalsall/received_events","type":"User","site_admin":false},"body":"Docs update for the changes applied in https://github.com/symfony/symfony/pull/19822","created_at":"2016-09-02T10:39:44Z","updated_at":"2016-10-24T19:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a2bfede2173dafad7523f611387d29f04c96bcc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/6948/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/c413297a6324b7c58247b471b12dfc2c86a6b54a","head":{"label":"jameshalsall:allow-successful-response-code-docs","ref":"allow-successful-response-code-docs","sha":"c413297a6324b7c58247b471b12dfc2c86a6b54a","user":{"login":"jameshalsall","id":499932,"avatar_url":"https://avatars.githubusercontent.com/u/499932?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshalsall","html_url":"https://github.com/jameshalsall","followers_url":"https://api.github.com/users/jameshalsall/followers","following_url":"https://api.github.com/users/jameshalsall/following{/other_user}","gists_url":"https://api.github.com/users/jameshalsall/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshalsall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshalsall/subscriptions","organizations_url":"https://api.github.com/users/jameshalsall/orgs","repos_url":"https://api.github.com/users/jameshalsall/repos","events_url":"https://api.github.com/users/jameshalsall/events{/privacy}","received_events_url":"https://api.github.com/users/jameshalsall/received_events","type":"User","site_admin":false},"repo":{"id":66255898,"name":"symfony-docs","full_name":"jameshalsall/symfony-docs","owner":{"login":"jameshalsall","id":499932,"avatar_url":"https://avatars.githubusercontent.com/u/499932?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshalsall","html_url":"https://github.com/jameshalsall","followers_url":"https://api.github.com/users/jameshalsall/followers","following_url":"https://api.github.com/users/jameshalsall/following{/other_user}","gists_url":"https://api.github.com/users/jameshalsall/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshalsall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshalsall/subscriptions","organizations_url":"https://api.github.com/users/jameshalsall/orgs","repos_url":"https://api.github.com/users/jameshalsall/repos","events_url":"https://api.github.com/users/jameshalsall/events{/privacy}","received_events_url":"https://api.github.com/users/jameshalsall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jameshalsall/symfony-docs","description":"The Symfony documentation","fork":true,"url":"https://api.github.com/repos/jameshalsall/symfony-docs","forks_url":"https://api.github.com/repos/jameshalsall/symfony-docs/forks","keys_url":"https://api.github.com/repos/jameshalsall/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jameshalsall/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jameshalsall/symfony-docs/teams","hooks_url":"https://api.github.com/repos/jameshalsall/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/jameshalsall/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/jameshalsall/symfony-docs/events","assignees_url":"https://api.github.com/repos/jameshalsall/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/jameshalsall/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/jameshalsall/symfony-docs/tags","blobs_url":"https://api.github.com/repos/jameshalsall/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jameshalsall/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jameshalsall/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jameshalsall/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jameshalsall/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/jameshalsall/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/jameshalsall/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/jameshalsall/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/jameshalsall/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/jameshalsall/symfony-docs/subscription","commits_url":"https://api.github.com/repos/jameshalsall/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jameshalsall/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jameshalsall/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jameshalsall/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jameshalsall/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/jameshalsall/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jameshalsall/symfony-docs/merges","archive_url":"https://api.github.com/repos/jameshalsall/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jameshalsall/symfony-docs/downloads","issues_url":"https://api.github.com/repos/jameshalsall/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/jameshalsall/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/jameshalsall/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/jameshalsall/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jameshalsall/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/jameshalsall/symfony-docs/releases{/id}","deployments_url":"https://api.github.com/repos/jameshalsall/symfony-docs/deployments","created_at":"2016-08-22T08:54:28Z","updated_at":"2016-08-22T08:54:33Z","pushed_at":"2016-09-19T08:34:24Z","git_url":"git://github.com/jameshalsall/symfony-docs.git","ssh_url":"git@github.com:jameshalsall/symfony-docs.git","clone_url":"https://github.com/jameshalsall/symfony-docs.git","svn_url":"https://github.com/jameshalsall/symfony-docs","homepage":"http://symfony.com/doc","size":35985,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"f78d06bd1ab206059c8857f83ac7469b17db58bf","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony-docs/deployments","created_at":"2010-02-17T08:43:51Z","updated_at":"2016-10-22T07:25:30Z","pushed_at":"2016-10-23T16:05:26Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc","size":56107,"stargazers_count":1156,"watchers_count":1156,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2657,"mirror_url":null,"open_issues_count":307,"forks":2657,"open_issues":307,"watchers":1156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/6948"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/6948"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/6948/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/6948/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/c413297a6324b7c58247b471b12dfc2c86a6b54a"}}}}
{"actor":{"display_login":"fabpot"}}