{"action":"created","comment":{"url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/comments/93638120","pull_request_review_id":14169879,"id":93638120,"diff_hunk":"@@ -111,8 +112,11 @@ class UportSubprovider extends Subprovider {\n       let topic = self.msgServer.newTopic('access_token')\n       let ethUri = 'me.uport:me?callback_url=' + topic.url\n       self.uportConnectHandler(ethUri)\n-      self.msgServer.waitForResult(topic, function (err, address) {\n+      self.msgServer.waitForResult(topic, function (err, token) {\n         self.closeQR()\n+        let decoded = jwt.decodeToken(token)","path":"src/uportsubprovider.js","position":15,"original_position":15,"commit_id":"87785e62615f2b4feaae48f8c1cb4e71150c4503","original_commit_id":"87785e62615f2b4feaae48f8c1cb4e71150c4503","user":{"login":"pelle","id":8680,"avatar_url":"https://avatars.githubusercontent.com/u/8680?v=3","gravatar_id":"","url":"https://api.github.com/users/pelle","html_url":"https://github.com/pelle","followers_url":"https://api.github.com/users/pelle/followers","following_url":"https://api.github.com/users/pelle/following{/other_user}","gists_url":"https://api.github.com/users/pelle/gists{/gist_id}","starred_url":"https://api.github.com/users/pelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelle/subscriptions","organizations_url":"https://api.github.com/users/pelle/orgs","repos_url":"https://api.github.com/users/pelle/repos","events_url":"https://api.github.com/users/pelle/events{/privacy}","received_events_url":"https://api.github.com/users/pelle/received_events","type":"User","site_admin":false},"body":"This is fine temporarily but we also need to verify the signature using the public key in ipfs. This code will live in persona. I think @zachferland has already written it or is nearly done.","created_at":"2016-12-22T15:04:53Z","updated_at":"2016-12-22T15:04:53Z","html_url":"https://github.com/ConsenSys/uport-lib/pull/48#discussion_r93638120","pull_request_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/comments/93638120"},"html":{"href":"https://github.com/ConsenSys/uport-lib/pull/48#discussion_r93638120"},"pull_request":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48","id":99039246,"html_url":"https://github.com/ConsenSys/uport-lib/pull/48","diff_url":"https://github.com/ConsenSys/uport-lib/pull/48.diff","patch_url":"https://github.com/ConsenSys/uport-lib/pull/48.patch","issue_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/48","number":48,"state":"open","locked":false,"title":"Extract address from decoded JWT (PT 136539281)","user":{"login":"christianlundkvist","id":6892901,"avatar_url":"https://avatars.githubusercontent.com/u/6892901?v=3","gravatar_id":"","url":"https://api.github.com/users/christianlundkvist","html_url":"https://github.com/christianlundkvist","followers_url":"https://api.github.com/users/christianlundkvist/followers","following_url":"https://api.github.com/users/christianlundkvist/following{/other_user}","gists_url":"https://api.github.com/users/christianlundkvist/gists{/gist_id}","starred_url":"https://api.github.com/users/christianlundkvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianlundkvist/subscriptions","organizations_url":"https://api.github.com/users/christianlundkvist/orgs","repos_url":"https://api.github.com/users/christianlundkvist/repos","events_url":"https://api.github.com/users/christianlundkvist/events{/privacy}","received_events_url":"https://api.github.com/users/christianlundkvist/received_events","type":"User","site_admin":false},"body":"Decode JWT from Chasqui and extract `iss` to get the address.","created_at":"2016-12-22T02:31:13Z","updated_at":"2016-12-22T15:04:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc173d41607d102889ea711dfd66991283c1a89d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48/commits","review_comments_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48/comments","review_comment_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/48/comments","statuses_url":"https://api.github.com/repos/ConsenSys/uport-lib/statuses/87785e62615f2b4feaae48f8c1cb4e71150c4503","head":{"label":"ConsenSys:feature/136539281-decoding-address-jwt","ref":"feature/136539281-decoding-address-jwt","sha":"87785e62615f2b4feaae48f8c1cb4e71150c4503","user":{"login":"ConsenSys","id":10818037,"avatar_url":"https://avatars.githubusercontent.com/u/10818037?v=3","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"repo":{"id":62232333,"name":"uport-lib","full_name":"ConsenSys/uport-lib","owner":{"login":"ConsenSys","id":10818037,"avatar_url":"https://avatars.githubusercontent.com/u/10818037?v=3","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConsenSys/uport-lib","description":"Main uPort library","fork":false,"url":"https://api.github.com/repos/ConsenSys/uport-lib","forks_url":"https://api.github.com/repos/ConsenSys/uport-lib/forks","keys_url":"https://api.github.com/repos/ConsenSys/uport-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConsenSys/uport-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConsenSys/uport-lib/teams","hooks_url":"https://api.github.com/repos/ConsenSys/uport-lib/hooks","issue_events_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ConsenSys/uport-lib/events","assignees_url":"https://api.github.com/repos/ConsenSys/uport-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ConsenSys/uport-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ConsenSys/uport-lib/tags","blobs_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConsenSys/uport-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ConsenSys/uport-lib/languages","stargazers_url":"https://api.github.com/repos/ConsenSys/uport-lib/stargazers","contributors_url":"https://api.github.com/repos/ConsenSys/uport-lib/contributors","subscribers_url":"https://api.github.com/repos/ConsenSys/uport-lib/subscribers","subscription_url":"https://api.github.com/repos/ConsenSys/uport-lib/subscription","commits_url":"https://api.github.com/repos/ConsenSys/uport-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConsenSys/uport-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConsenSys/uport-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ConsenSys/uport-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConsenSys/uport-lib/merges","archive_url":"https://api.github.com/repos/ConsenSys/uport-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConsenSys/uport-lib/downloads","issues_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ConsenSys/uport-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ConsenSys/uport-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConsenSys/uport-lib/labels{/name}","releases_url":"https://api.github.com/repos/ConsenSys/uport-lib/releases{/id}","deployments_url":"https://api.github.com/repos/ConsenSys/uport-lib/deployments","created_at":"2016-06-29T14:29:18Z","updated_at":"2016-12-17T21:27:23Z","pushed_at":"2016-12-22T02:31:13Z","git_url":"git://github.com/ConsenSys/uport-lib.git","ssh_url":"git@github.com:ConsenSys/uport-lib.git","clone_url":"https://github.com/ConsenSys/uport-lib.git","svn_url":"https://github.com/ConsenSys/uport-lib","homepage":null,"size":3439,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":18,"forks":10,"open_issues":18,"watchers":35,"default_branch":"develop"}},"base":{"label":"ConsenSys:develop","ref":"develop","sha":"ed7d2b391dabf2294278f9e3dd5cdb0b5c58e26c","user":{"login":"ConsenSys","id":10818037,"avatar_url":"https://avatars.githubusercontent.com/u/10818037?v=3","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"repo":{"id":62232333,"name":"uport-lib","full_name":"ConsenSys/uport-lib","owner":{"login":"ConsenSys","id":10818037,"avatar_url":"https://avatars.githubusercontent.com/u/10818037?v=3","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConsenSys/uport-lib","description":"Main uPort library","fork":false,"url":"https://api.github.com/repos/ConsenSys/uport-lib","forks_url":"https://api.github.com/repos/ConsenSys/uport-lib/forks","keys_url":"https://api.github.com/repos/ConsenSys/uport-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConsenSys/uport-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConsenSys/uport-lib/teams","hooks_url":"https://api.github.com/repos/ConsenSys/uport-lib/hooks","issue_events_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ConsenSys/uport-lib/events","assignees_url":"https://api.github.com/repos/ConsenSys/uport-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ConsenSys/uport-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ConsenSys/uport-lib/tags","blobs_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConsenSys/uport-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ConsenSys/uport-lib/languages","stargazers_url":"https://api.github.com/repos/ConsenSys/uport-lib/stargazers","contributors_url":"https://api.github.com/repos/ConsenSys/uport-lib/contributors","subscribers_url":"https://api.github.com/repos/ConsenSys/uport-lib/subscribers","subscription_url":"https://api.github.com/repos/ConsenSys/uport-lib/subscription","commits_url":"https://api.github.com/repos/ConsenSys/uport-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConsenSys/uport-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConsenSys/uport-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConsenSys/uport-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ConsenSys/uport-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConsenSys/uport-lib/merges","archive_url":"https://api.github.com/repos/ConsenSys/uport-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConsenSys/uport-lib/downloads","issues_url":"https://api.github.com/repos/ConsenSys/uport-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ConsenSys/uport-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ConsenSys/uport-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ConsenSys/uport-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConsenSys/uport-lib/labels{/name}","releases_url":"https://api.github.com/repos/ConsenSys/uport-lib/releases{/id}","deployments_url":"https://api.github.com/repos/ConsenSys/uport-lib/deployments","created_at":"2016-06-29T14:29:18Z","updated_at":"2016-12-17T21:27:23Z","pushed_at":"2016-12-22T02:31:13Z","git_url":"git://github.com/ConsenSys/uport-lib.git","ssh_url":"git@github.com:ConsenSys/uport-lib.git","clone_url":"https://github.com/ConsenSys/uport-lib.git","svn_url":"https://github.com/ConsenSys/uport-lib","homepage":null,"size":3439,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":18,"forks":10,"open_issues":18,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48"},"html":{"href":"https://github.com/ConsenSys/uport-lib/pull/48"},"issue":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/issues/48"},"comments":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/ConsenSys/uport-lib/statuses/87785e62615f2b4feaae48f8c1cb4e71150c4503"}}}}
{"actor":{"display_login":"pelle"}}