{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/3823","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3823/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3823/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3823/events","html_url":"https://github.com/mne-tools/mne-python/pull/3823","id":194190667,"number":3823,"title":"spectrogram instead of welch","user":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-07T22:28:53Z","updated_at":"2016-12-08T14:31:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3823","html_url":"https://github.com/mne-tools/mne-python/pull/3823","diff_url":"https://github.com/mne-tools/mne-python/pull/3823.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3823.patch"},"body":"Breaking up #3820 into smaller steps.  \r\na better way than #3822 -almost too simple ;)\r\n\r\nThis makes `psd_welch` use scipy's `spectral` instead of `welch`. `spectral` is used with the defaults used in welch here, but the windows are not averaged over - allowing for further steps outlined in #3820\r\n\r\nI also removed `_compute_psd` because it was not used anywhere."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/265753082","html_url":"https://github.com/mne-tools/mne-python/pull/3823#issuecomment-265753082","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3823","id":265753082,"user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T14:31:04Z","updated_at":"2016-12-08T14:31:04Z","body":"@mmagnuski I think that's basically what #3822 was doing, just based off of SciPy's initial implementation which is fine.\r\n\r\nAnother option is just to put a copy of `spectrogram` in fixes. That seems like the easiest approach to me. Then when we eventually move our SciPy requirement to 0.16 our code stays simple."}}
{"actor":{"display_login":"Eric89GXL"}}