{"action":"created","issue":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/507","repository_url":"https://api.github.com/repos/iea-annex60/modelica-annex60","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/507/labels{/name}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/507/comments","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/507/events","html_url":"https://github.com/iea-annex60/modelica-annex60/issues/507","id":173139872,"number":507,"title":"Nominal trace concentrations","user":{"login":"rubenbaetens","id":1235535,"avatar_url":"https://avatars.githubusercontent.com/u/1235535?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenbaetens","html_url":"https://github.com/rubenbaetens","followers_url":"https://api.github.com/users/rubenbaetens/followers","following_url":"https://api.github.com/users/rubenbaetens/following{/other_user}","gists_url":"https://api.github.com/users/rubenbaetens/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenbaetens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenbaetens/subscriptions","organizations_url":"https://api.github.com/users/rubenbaetens/orgs","repos_url":"https://api.github.com/users/rubenbaetens/repos","events_url":"https://api.github.com/users/rubenbaetens/events{/privacy}","received_events_url":"https://api.github.com/users/rubenbaetens/received_events","type":"User","site_admin":false},"labels":[{"id":60711405,"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/labels/suggestion","name":"suggestion","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-25T08:13:28Z","updated_at":"2016-11-22T16:46:02Z","closed_at":null,"body":"The `Medium` package has a parameter `C_nominal` for trace concentrations, but this is never used. For example, the current implementation of `IDEAS.Fluid.Interfaces.LumpedVolumeDeclarations` states:\n\n```\n  parameter Medium.ExtraProperty C_start[Medium.nC](\n       quantity=Medium.extraPropertiesNames)=fill(0, Medium.nC)\n    \"Start value of trace substances\"\n    annotation (Dialog(tab=\"Initialization\", enable=Medium.nC > 0));\n  parameter Medium.ExtraProperty C_nominal[Medium.nC](\n       quantity=Medium.extraPropertiesNames) = fill(1E-2, Medium.nC)\n    \"Nominal value of trace substances. (Set to typical order of magnitude.)\"\n   annotation (Dialog(tab=\"Initialization\", enable=Medium.nC > 0));\n```\n\nThis however complexifies the use of e.g. CO2 in air where you want to set a default 400 ppm as starting value (now air volumes start at 0 ppm). I suggest to change this into:\n\n```\n  parameter Medium.ExtraProperty C_start[Medium.nC](\n       quantity=Medium.extraPropertiesNames)=Medium.C_nominal\n    \"Start value of trace substances\"\n    annotation (Dialog(tab=\"Initialization\", enable=Medium.nC > 0));\n  parameter Medium.ExtraProperty C_nominal[Medium.nC](\n       quantity=Medium.extraPropertiesNames) = Medium.C_nominal\n    \"Nominal value of trace substances. (Set to typical order of magnitude.)\"\n   annotation (Dialog(tab=\"Initialization\", enable=Medium.nC > 0));\n```\n\nThe same can be stated for e.g. `IDEAS.Fluid.Sources.Boundary_pT` which defines\n\n```\n  parameter Medium.ExtraProperty C[Medium.nC](\n    final quantity=Medium.extraPropertiesNames) = fill(0, Medium.nC)\n    \"Fixed values of trace substances\"\n    annotation (Dialog(enable = (not use_C_in) and Medium.nC > 0));\n```\n\nwhereas i propose to change this into\n\n```\n  parameter Medium.ExtraProperty C[Medium.nC](\n    final quantity=Medium.extraPropertiesNames) = Medium.C_nominal\n    \"Fixed values of trace substances\"\n    annotation (Dialog(enable = (not use_C_in) and Medium.nC > 0));\n```\n"},"comment":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/comments/262294846","html_url":"https://github.com/iea-annex60/modelica-annex60/issues/507#issuecomment-262294846","issue_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/507","id":262294846,"user":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T16:46:02Z","updated_at":"2016-11-22T16:46:02Z","body":"@rubenbaetens Can this issue be closed?"}}
{"actor":{"display_login":"mwetter"}}