{"action":"opened","number":2405,"pull_request":{"url":"https://api.github.com/repos/SickRage/SickRage/pulls/2405","id":87396657,"html_url":"https://github.com/SickRage/SickRage/pull/2405","diff_url":"https://github.com/SickRage/SickRage/pull/2405.diff","patch_url":"https://github.com/SickRage/SickRage/pull/2405.patch","issue_url":"https://api.github.com/repos/SickRage/SickRage/issues/2405","number":2405,"state":"open","locked":false,"title":"Add more clarity to log message when connection fails while downloadi…","user":{"login":"felipebrahm","id":626213,"avatar_url":"https://avatars.githubusercontent.com/u/626213?v=3","gravatar_id":"","url":"https://api.github.com/users/felipebrahm","html_url":"https://github.com/felipebrahm","followers_url":"https://api.github.com/users/felipebrahm/followers","following_url":"https://api.github.com/users/felipebrahm/following{/other_user}","gists_url":"https://api.github.com/users/felipebrahm/gists{/gist_id}","starred_url":"https://api.github.com/users/felipebrahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipebrahm/subscriptions","organizations_url":"https://api.github.com/users/felipebrahm/orgs","repos_url":"https://api.github.com/users/felipebrahm/repos","events_url":"https://api.github.com/users/felipebrahm/events{/privacy}","received_events_url":"https://api.github.com/users/felipebrahm/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request:\r\n- Change the log message to include a better description of the actual error when trying to download a file\r\n\r\n- [x] PR is based on the DEVELOP branch\r\n- [x] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review\r\n- [x] Read [contribution guide](https://github.com/SickRage/SickRage/blob/master/.github/CONTRIBUTING.md)\r\n\r\n### Explanation\r\n\r\nMy SickRage setup had been working without an issue for a few months but all of a sudden all torrents failed to download with a log message like this:\r\n\r\n```\r\nProblem setting permissions or writing file to C:\\Users\\xxx\\sickrage\\foo.torrent\r\n```\r\n\r\nI tried changing the permissions of the folder but nothing helped. Then I modified the code so I could read the actual error message and this is what I got:\r\n\r\n```\r\n('Connection broken: IncompleteRead(29 bytes read)', IncompleteRead(29 bytes read))\r\n```\r\n\r\nBasically, it was failing to *download* the file, not *write* it. I still haven't been able to figure out why it's failing to download (all other scripts that are running on my computer are able to download files just fine), but in the meantime I'm submitting this PR to fix the log message.","created_at":"2016-09-29T21:22:47Z","updated_at":"2016-09-29T21:22:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SickRage/SickRage/pulls/2405/commits","review_comments_url":"https://api.github.com/repos/SickRage/SickRage/pulls/2405/comments","review_comment_url":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SickRage/SickRage/issues/2405/comments","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/30662231c7893eb81f5d8fae12facf4fffb122c4","head":{"label":"felipebrahm:better_error_message","ref":"better_error_message","sha":"30662231c7893eb81f5d8fae12facf4fffb122c4","user":{"login":"felipebrahm","id":626213,"avatar_url":"https://avatars.githubusercontent.com/u/626213?v=3","gravatar_id":"","url":"https://api.github.com/users/felipebrahm","html_url":"https://github.com/felipebrahm","followers_url":"https://api.github.com/users/felipebrahm/followers","following_url":"https://api.github.com/users/felipebrahm/following{/other_user}","gists_url":"https://api.github.com/users/felipebrahm/gists{/gist_id}","starred_url":"https://api.github.com/users/felipebrahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipebrahm/subscriptions","organizations_url":"https://api.github.com/users/felipebrahm/orgs","repos_url":"https://api.github.com/users/felipebrahm/repos","events_url":"https://api.github.com/users/felipebrahm/events{/privacy}","received_events_url":"https://api.github.com/users/felipebrahm/received_events","type":"User","site_admin":false},"repo":{"id":69608114,"name":"SickRage","full_name":"felipebrahm/SickRage","owner":{"login":"felipebrahm","id":626213,"avatar_url":"https://avatars.githubusercontent.com/u/626213?v=3","gravatar_id":"","url":"https://api.github.com/users/felipebrahm","html_url":"https://github.com/felipebrahm","followers_url":"https://api.github.com/users/felipebrahm/followers","following_url":"https://api.github.com/users/felipebrahm/following{/other_user}","gists_url":"https://api.github.com/users/felipebrahm/gists{/gist_id}","starred_url":"https://api.github.com/users/felipebrahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipebrahm/subscriptions","organizations_url":"https://api.github.com/users/felipebrahm/orgs","repos_url":"https://api.github.com/users/felipebrahm/repos","events_url":"https://api.github.com/users/felipebrahm/events{/privacy}","received_events_url":"https://api.github.com/users/felipebrahm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felipebrahm/SickRage","description":"The new home of the SickRage community","fork":true,"url":"https://api.github.com/repos/felipebrahm/SickRage","forks_url":"https://api.github.com/repos/felipebrahm/SickRage/forks","keys_url":"https://api.github.com/repos/felipebrahm/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felipebrahm/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felipebrahm/SickRage/teams","hooks_url":"https://api.github.com/repos/felipebrahm/SickRage/hooks","issue_events_url":"https://api.github.com/repos/felipebrahm/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/felipebrahm/SickRage/events","assignees_url":"https://api.github.com/repos/felipebrahm/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/felipebrahm/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/felipebrahm/SickRage/tags","blobs_url":"https://api.github.com/repos/felipebrahm/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felipebrahm/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felipebrahm/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/felipebrahm/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felipebrahm/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/felipebrahm/SickRage/languages","stargazers_url":"https://api.github.com/repos/felipebrahm/SickRage/stargazers","contributors_url":"https://api.github.com/repos/felipebrahm/SickRage/contributors","subscribers_url":"https://api.github.com/repos/felipebrahm/SickRage/subscribers","subscription_url":"https://api.github.com/repos/felipebrahm/SickRage/subscription","commits_url":"https://api.github.com/repos/felipebrahm/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/felipebrahm/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/felipebrahm/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/felipebrahm/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/felipebrahm/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/felipebrahm/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felipebrahm/SickRage/merges","archive_url":"https://api.github.com/repos/felipebrahm/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felipebrahm/SickRage/downloads","issues_url":"https://api.github.com/repos/felipebrahm/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/felipebrahm/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/felipebrahm/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/felipebrahm/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felipebrahm/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/felipebrahm/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/felipebrahm/SickRage/deployments","created_at":"2016-09-29T21:09:39Z","updated_at":"2016-09-29T21:09:48Z","pushed_at":"2016-09-29T21:14:36Z","git_url":"git://github.com/felipebrahm/SickRage.git","ssh_url":"git@github.com:felipebrahm/SickRage.git","clone_url":"https://github.com/felipebrahm/SickRage.git","svn_url":"https://github.com/felipebrahm/SickRage","homepage":"https://sickrage.github.io","size":72080,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SickRage:develop","ref":"develop","sha":"2d9a6c1f4a837fa4030fb53a884117dfcdf6a2bb","user":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars.githubusercontent.com/u/15840255?v=3","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"repo":{"id":46151823,"name":"SickRage","full_name":"SickRage/SickRage","owner":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars.githubusercontent.com/u/15840255?v=3","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SickRage/SickRage","description":"The new home of the SickRage community","fork":false,"url":"https://api.github.com/repos/SickRage/SickRage","forks_url":"https://api.github.com/repos/SickRage/SickRage/forks","keys_url":"https://api.github.com/repos/SickRage/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SickRage/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SickRage/SickRage/teams","hooks_url":"https://api.github.com/repos/SickRage/SickRage/hooks","issue_events_url":"https://api.github.com/repos/SickRage/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/SickRage/SickRage/events","assignees_url":"https://api.github.com/repos/SickRage/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/SickRage/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/SickRage/SickRage/tags","blobs_url":"https://api.github.com/repos/SickRage/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SickRage/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SickRage/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SickRage/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/SickRage/SickRage/languages","stargazers_url":"https://api.github.com/repos/SickRage/SickRage/stargazers","contributors_url":"https://api.github.com/repos/SickRage/SickRage/contributors","subscribers_url":"https://api.github.com/repos/SickRage/SickRage/subscribers","subscription_url":"https://api.github.com/repos/SickRage/SickRage/subscription","commits_url":"https://api.github.com/repos/SickRage/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SickRage/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SickRage/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SickRage/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SickRage/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/SickRage/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SickRage/SickRage/merges","archive_url":"https://api.github.com/repos/SickRage/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SickRage/SickRage/downloads","issues_url":"https://api.github.com/repos/SickRage/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/SickRage/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/SickRage/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/SickRage/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SickRage/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/SickRage/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/SickRage/SickRage/deployments","created_at":"2015-11-13T23:01:22Z","updated_at":"2016-09-29T08:44:02Z","pushed_at":"2016-09-29T21:22:47Z","git_url":"git://github.com/SickRage/SickRage.git","ssh_url":"git@github.com:SickRage/SickRage.git","clone_url":"https://github.com/SickRage/SickRage.git","svn_url":"https://github.com/SickRage/SickRage","homepage":"https://sickrage.github.io","size":72080,"stargazers_count":803,"watchers_count":803,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":46,"forks":273,"open_issues":46,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/2405"},"html":{"href":"https://github.com/SickRage/SickRage/pull/2405"},"issue":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/2405"},"comments":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/2405/comments"},"review_comments":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/2405/comments"},"review_comment":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/2405/commits"},"statuses":{"href":"https://api.github.com/repos/SickRage/SickRage/statuses/30662231c7893eb81f5d8fae12facf4fffb122c4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"felipebrahm"}}