{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/83561723","pull_request_review_id":4398036,"id":83561723,"diff_hunk":"@@ -627,6 +627,33 @@ describe \"String\" do\n     end\n   end\n \n+  describe \"rpartition\" do\n+    describe \"by char\" do\n+      \"hello\".rpartition('l').should eq ({\"hel\", \"l\", \"o\"})\n+      \"hello\".rpartition('o').should eq ({\"\", \"\", \"hello\"})\n+      \"hello\".rpartition('h').should eq ({\"\", \"\", \"hello\"})","path":"spec/std/string_spec.cr","position":8,"original_position":8,"commit_id":"e9577ec56033259a6cd7d3d59fbf6f9f5625c008","original_commit_id":"e9577ec56033259a6cd7d3d59fbf6f9f5625c008","user":{"login":"bcardiff","id":459923,"avatar_url":"https://avatars.githubusercontent.com/u/459923?v=3","gravatar_id":"","url":"https://api.github.com/users/bcardiff","html_url":"https://github.com/bcardiff","followers_url":"https://api.github.com/users/bcardiff/followers","following_url":"https://api.github.com/users/bcardiff/following{/other_user}","gists_url":"https://api.github.com/users/bcardiff/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardiff/subscriptions","organizations_url":"https://api.github.com/users/bcardiff/orgs","repos_url":"https://api.github.com/users/bcardiff/repos","events_url":"https://api.github.com/users/bcardiff/events{/privacy}","received_events_url":"https://api.github.com/users/bcardiff/received_events","type":"User","site_admin":false},"body":"Why if the char is at the beginning or at the end of the string is the same as if they were not found at all?\r\n\r\n```ruby\r\n> \"hello\".rpartition(\"o\")\r\n=> [\"hell\", \"o\", \"\"]\r\n> \"hello\".rpartition(\"h\")\r\n=> [\"\", \"h\", \"ello\"]\r\n```","created_at":"2016-10-16T22:21:51Z","updated_at":"2016-10-16T22:23:26Z","html_url":"https://github.com/crystal-lang/crystal/pull/3429#discussion_r83561723","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/83561723"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3429#discussion_r83561723"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429","id":89542069,"html_url":"https://github.com/crystal-lang/crystal/pull/3429","diff_url":"https://github.com/crystal-lang/crystal/pull/3429.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/3429.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3429","number":3429,"state":"open","locked":false,"title":"String#rpartition","user":{"login":"johnjansen","id":105938,"avatar_url":"https://avatars.githubusercontent.com/u/105938?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjansen","html_url":"https://github.com/johnjansen","followers_url":"https://api.github.com/users/johnjansen/followers","following_url":"https://api.github.com/users/johnjansen/following{/other_user}","gists_url":"https://api.github.com/users/johnjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjansen/subscriptions","organizations_url":"https://api.github.com/users/johnjansen/orgs","repos_url":"https://api.github.com/users/johnjansen/repos","events_url":"https://api.github.com/users/johnjansen/events{/privacy}","received_events_url":"https://api.github.com/users/johnjansen/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-16T22:14:31Z","updated_at":"2016-10-16T22:23:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5ea60ce0e2fdcbc7acb5ce51c31c50583be1c62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3429/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/e9577ec56033259a6cd7d3d59fbf6f9f5625c008","head":{"label":"johnjansen:string-rpartition","ref":"string-rpartition","sha":"e9577ec56033259a6cd7d3d59fbf6f9f5625c008","user":{"login":"johnjansen","id":105938,"avatar_url":"https://avatars.githubusercontent.com/u/105938?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjansen","html_url":"https://github.com/johnjansen","followers_url":"https://api.github.com/users/johnjansen/followers","following_url":"https://api.github.com/users/johnjansen/following{/other_user}","gists_url":"https://api.github.com/users/johnjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjansen/subscriptions","organizations_url":"https://api.github.com/users/johnjansen/orgs","repos_url":"https://api.github.com/users/johnjansen/repos","events_url":"https://api.github.com/users/johnjansen/events{/privacy}","received_events_url":"https://api.github.com/users/johnjansen/received_events","type":"User","site_admin":false},"repo":{"id":68772599,"name":"crystal","full_name":"johnjansen/crystal","owner":{"login":"johnjansen","id":105938,"avatar_url":"https://avatars.githubusercontent.com/u/105938?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjansen","html_url":"https://github.com/johnjansen","followers_url":"https://api.github.com/users/johnjansen/followers","following_url":"https://api.github.com/users/johnjansen/following{/other_user}","gists_url":"https://api.github.com/users/johnjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjansen/subscriptions","organizations_url":"https://api.github.com/users/johnjansen/orgs","repos_url":"https://api.github.com/users/johnjansen/repos","events_url":"https://api.github.com/users/johnjansen/events{/privacy}","received_events_url":"https://api.github.com/users/johnjansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnjansen/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/johnjansen/crystal","forks_url":"https://api.github.com/repos/johnjansen/crystal/forks","keys_url":"https://api.github.com/repos/johnjansen/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnjansen/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnjansen/crystal/teams","hooks_url":"https://api.github.com/repos/johnjansen/crystal/hooks","issue_events_url":"https://api.github.com/repos/johnjansen/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/johnjansen/crystal/events","assignees_url":"https://api.github.com/repos/johnjansen/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/johnjansen/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/johnjansen/crystal/tags","blobs_url":"https://api.github.com/repos/johnjansen/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnjansen/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnjansen/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnjansen/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnjansen/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/johnjansen/crystal/languages","stargazers_url":"https://api.github.com/repos/johnjansen/crystal/stargazers","contributors_url":"https://api.github.com/repos/johnjansen/crystal/contributors","subscribers_url":"https://api.github.com/repos/johnjansen/crystal/subscribers","subscription_url":"https://api.github.com/repos/johnjansen/crystal/subscription","commits_url":"https://api.github.com/repos/johnjansen/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnjansen/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnjansen/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnjansen/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnjansen/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/johnjansen/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnjansen/crystal/merges","archive_url":"https://api.github.com/repos/johnjansen/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnjansen/crystal/downloads","issues_url":"https://api.github.com/repos/johnjansen/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/johnjansen/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/johnjansen/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/johnjansen/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnjansen/crystal/labels{/name}","releases_url":"https://api.github.com/repos/johnjansen/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/johnjansen/crystal/deployments","created_at":"2016-09-21T02:36:47Z","updated_at":"2016-09-21T02:36:50Z","pushed_at":"2016-10-16T22:12:23Z","git_url":"git://github.com/johnjansen/crystal.git","ssh_url":"git@github.com:johnjansen/crystal.git","clone_url":"https://github.com/johnjansen/crystal.git","svn_url":"https://github.com/johnjansen/crystal","homepage":"http://crystal-lang.org","size":66888,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"9119c338628a6fc77af789a1b5aee68185e78b8f","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2016-10-16T20:34:00Z","pushed_at":"2016-10-16T22:14:31Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"http://crystal-lang.org","size":67206,"stargazers_count":6269,"watchers_count":6269,"language":"Crystal","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":513,"mirror_url":null,"open_issues_count":332,"forks":513,"open_issues":332,"watchers":6269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3429"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3429"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3429/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3429/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/e9577ec56033259a6cd7d3d59fbf6f9f5625c008"}}}}
{"actor":{"display_login":"bcardiff"}}