{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/7036","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/7036/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7036/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/7036/events","html_url":"https://github.com/facebook/react-native/pull/7036","id":149195198,"number":7036,"title":"Bug Fix - Renamed --flavor to --variant","user":{"login":"jaggs6","id":1941517,"avatar_url":"https://avatars.githubusercontent.com/u/1941517?v=3","gravatar_id":"","url":"https://api.github.com/users/jaggs6","html_url":"https://github.com/jaggs6","followers_url":"https://api.github.com/users/jaggs6/followers","following_url":"https://api.github.com/users/jaggs6/following{/other_user}","gists_url":"https://api.github.com/users/jaggs6/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggs6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggs6/subscriptions","organizations_url":"https://api.github.com/users/jaggs6/orgs","repos_url":"https://api.github.com/users/jaggs6/repos","events_url":"https://api.github.com/users/jaggs6/events{/privacy}","received_events_url":"https://api.github.com/users/jaggs6/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20needs-revision","name":"GH Review: needs-revision","color":"e11d21"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-04-18T16:03:49Z","updated_at":"2016-04-19T11:34:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7036","html_url":"https://github.com/facebook/react-native/pull/7036","diff_url":"https://github.com/facebook/react-native/pull/7036.diff","patch_url":"https://github.com/facebook/react-native/pull/7036.patch"},"body":"This small update to runAndroid.js which renames --flavor to --variant.\r\n~~`react-native run-android --flavor=staging`~~\r\n\r\n~~doesn't work as it needs build type as well~~\r\n\r\n~~so at present it needs to be like this~~\r\n\r\n~~`react-native run-android --flavor=stagingDebug`~~\r\n\r\n~~it looks messy, instead if we want to use the original spec then Debug must be concatenated to the end all the time as run-android was speced to trigger only debug builds~~\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/211869181","html_url":"https://github.com/facebook/react-native/pull/7036#issuecomment-211869181","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7036","id":211869181,"user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T11:34:47Z","updated_at":"2016-04-19T11:34:47Z","body":"> Then lets change name to --variant. We should still support --flavor for next few releases and show a deprecation warning, then eventually remove it.\r\n\r\nThis is a good way to do it, people should have say 3 months notice for breaking changes."}}