{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/comments/52792817","id":52792817,"diff_hunk":"@@ -68,7 +70,25 @@ func (n NoopTracer) StartSpanWithOptions(opts StartSpanOptions) Span {\n \treturn defaultNoopSpan\n }\n \n+// Extractor belongs to the Tracer interface.\n+func (n NoopTracer) Extractor(format interface{}) Extractor {\n+\treturn defaultNoopInjectorExtractor\n+}\n+\n+// Injector belongs to the Tracer interface.\n+func (n NoopTracer) Injector(format interface{}) Injector {\n+\treturn defaultNoopInjectorExtractor\n+}\n+\n // JoinTrace belongs to the Tracer interface.\n func (n NoopTracer) JoinTrace(operationName string, parent interface{}) Span {\n \treturn defaultNoopSpan\n }\n+\n+func (n noopInjectorExtractor) InjectSpan(span Span, carrier interface{}) error {\n+\treturn nil\n+}\n+\n+func (n noopInjectorExtractor) JoinTrace(operationName string, carrier interface{}) (Span, error) {","path":"noop.go","position":44,"original_position":44,"commit_id":"f9cb07b0e94d8f7a971a966b47fc2eb8e50fe71b","original_commit_id":"f9cb07b0e94d8f7a971a966b47fc2eb8e50fe71b","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"@yurishkuro do we want this to return the `defaultNoopSpan` or `nil` for the `Span` return val? I think `nil` is more honest, but it's a toss-up.","created_at":"2016-02-12T20:15:24Z","updated_at":"2016-02-12T20:15:24Z","html_url":"https://github.com/opentracing/opentracing-go/pull/48#discussion_r52792817","pull_request_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/comments/52792817"},"html":{"href":"https://github.com/opentracing/opentracing-go/pull/48#discussion_r52792817"},"pull_request":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48","id":58531465,"html_url":"https://github.com/opentracing/opentracing-go/pull/48","diff_url":"https://github.com/opentracing/opentracing-go/pull/48.diff","patch_url":"https://github.com/opentracing/opentracing-go/pull/48.patch","issue_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/48","number":48,"state":"open","locked":false,"title":"RFC for Injection/Extraction in Go","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"C.f. https://github.com/opentracing/opentracing.github.io/pull/45 and https://github.com/opentracing/opentracing.github.io/issues/44#issuecomment-179654948.\r\n\r\nThere are some good things and some less-good things here... I will add a few comments inline.\r\n\r\nI didn't adjust the standardtracer, noop.go, etc: just trying to illustrate the user-facing pieces of this.","created_at":"2016-02-06T21:57:25Z","updated_at":"2016-02-12T20:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5a27d8495cea428342ede67a4114f0a7b501a7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48/commits","review_comments_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48/comments","review_comment_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/48/comments","statuses_url":"https://api.github.com/repos/opentracing/opentracing-go/statuses/f9cb07b0e94d8f7a971a966b47fc2eb8e50fe71b","head":{"label":"opentracing:wire_rfc","ref":"wire_rfc","sha":"f9cb07b0e94d8f7a971a966b47fc2eb8e50fe71b","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":46904685,"name":"opentracing-go","full_name":"opentracing/opentracing-go","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-go","description":"Go implementation of Open Tracing API","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-go","forks_url":"https://api.github.com/repos/opentracing/opentracing-go/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-go/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-go/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-go/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-go/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-go/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-go/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-go/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-go/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-go/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-go/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-go/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-go/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-go/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-go/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-go/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-go/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-go/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-go/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-go/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-go/deployments","created_at":"2015-11-26T04:52:54Z","updated_at":"2016-02-12T01:49:41Z","pushed_at":"2016-02-12T05:40:22Z","git_url":"git://github.com/opentracing/opentracing-go.git","ssh_url":"git@github.com:opentracing/opentracing-go.git","clone_url":"https://github.com/opentracing/opentracing-go.git","svn_url":"https://github.com/opentracing/opentracing-go","homepage":"","size":172,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":55,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"c179d7bedd0f473e5b893b0485ffc846cab7da3a","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":46904685,"name":"opentracing-go","full_name":"opentracing/opentracing-go","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-go","description":"Go implementation of Open Tracing API","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-go","forks_url":"https://api.github.com/repos/opentracing/opentracing-go/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-go/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-go/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-go/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-go/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-go/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-go/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-go/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-go/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-go/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-go/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-go/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-go/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-go/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-go/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-go/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-go/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-go/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-go/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-go/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-go/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-go/deployments","created_at":"2015-11-26T04:52:54Z","updated_at":"2016-02-12T01:49:41Z","pushed_at":"2016-02-12T05:40:22Z","git_url":"git://github.com/opentracing/opentracing-go.git","ssh_url":"git@github.com:opentracing/opentracing-go.git","clone_url":"https://github.com/opentracing/opentracing-go.git","svn_url":"https://github.com/opentracing/opentracing-go","homepage":"","size":172,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48"},"html":{"href":"https://github.com/opentracing/opentracing-go/pull/48"},"issue":{"href":"https://api.github.com/repos/opentracing/opentracing-go/issues/48"},"comments":{"href":"https://api.github.com/repos/opentracing/opentracing-go/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/opentracing-go/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/opentracing-go/statuses/f9cb07b0e94d8f7a971a966b47fc2eb8e50fe71b"}}}}