{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21","id":98616324,"html_url":"https://github.com/azavea/terraform-aws-postgresql-rds/pull/21","diff_url":"https://github.com/azavea/terraform-aws-postgresql-rds/pull/21.diff","patch_url":"https://github.com/azavea/terraform-aws-postgresql-rds/pull/21.patch","issue_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/21","number":21,"state":"open","locked":false,"title":"Add support for creating final snapshot","user":{"login":"hectcastro","id":43639,"avatar_url":"https://avatars.githubusercontent.com/u/43639?v=3","gravatar_id":"","url":"https://api.github.com/users/hectcastro","html_url":"https://github.com/hectcastro","followers_url":"https://api.github.com/users/hectcastro/followers","following_url":"https://api.github.com/users/hectcastro/following{/other_user}","gists_url":"https://api.github.com/users/hectcastro/gists{/gist_id}","starred_url":"https://api.github.com/users/hectcastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hectcastro/subscriptions","organizations_url":"https://api.github.com/users/hectcastro/orgs","repos_url":"https://api.github.com/users/hectcastro/repos","events_url":"https://api.github.com/users/hectcastro/events{/privacy}","received_events_url":"https://api.github.com/users/hectcastro/received_events","type":"User","site_admin":false},"body":"If the RDS instance is terminated, add support for taking a final snapshot of its contents, naming it, and copying existing tags to it.\r\n\r\nBuilds on top of #19 \r\nResolves #18 \r\n\r\nA side-effect of giving `final_snapshot_identifier` a default value is that even if you change no module variables, it'll mark that attribute as changed:\r\n\r\n```\r\n~ module.database.aws_db_instance.postgresql\r\n    final_snapshot_identifier: \"\" => \"terraform-aws-postgresql-rds-snapshot\"\r\n\r\n\r\nPlan: 0 to add, 1 to change, 0 to destroy.\r\n```\r\n\r\nLeaving the attribute set to `\"`\" leads to an error, and there is no way to easily leave just that attribute unset completely. I think that the inclusion of this feature in a release would require bumping at least the minor version.","created_at":"2016-12-19T18:32:34Z","updated_at":"2016-12-19T18:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"tnation14","id":2507188,"avatar_url":"https://avatars.githubusercontent.com/u/2507188?v=3","gravatar_id":"","url":"https://api.github.com/users/tnation14","html_url":"https://github.com/tnation14","followers_url":"https://api.github.com/users/tnation14/followers","following_url":"https://api.github.com/users/tnation14/following{/other_user}","gists_url":"https://api.github.com/users/tnation14/gists{/gist_id}","starred_url":"https://api.github.com/users/tnation14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnation14/subscriptions","organizations_url":"https://api.github.com/users/tnation14/orgs","repos_url":"https://api.github.com/users/tnation14/repos","events_url":"https://api.github.com/users/tnation14/events{/privacy}","received_events_url":"https://api.github.com/users/tnation14/received_events","type":"User","site_admin":false},"assignees":[{"login":"tnation14","id":2507188,"avatar_url":"https://avatars.githubusercontent.com/u/2507188?v=3","gravatar_id":"","url":"https://api.github.com/users/tnation14","html_url":"https://github.com/tnation14","followers_url":"https://api.github.com/users/tnation14/followers","following_url":"https://api.github.com/users/tnation14/following{/other_user}","gists_url":"https://api.github.com/users/tnation14/gists{/gist_id}","starred_url":"https://api.github.com/users/tnation14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnation14/subscriptions","organizations_url":"https://api.github.com/users/tnation14/orgs","repos_url":"https://api.github.com/users/tnation14/repos","events_url":"https://api.github.com/users/tnation14/events{/privacy}","received_events_url":"https://api.github.com/users/tnation14/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21/commits","review_comments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21/comments","review_comment_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/21/comments","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/statuses/6297e2d04062576c92475baa442fa27439de8528","head":{"label":"azavea:feature/hmc/final-snapshot","ref":"feature/hmc/final-snapshot","sha":"6297e2d04062576c92475baa442fa27439de8528","user":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":46007776,"name":"terraform-aws-postgresql-rds","full_name":"azavea/terraform-aws-postgresql-rds","owner":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/terraform-aws-postgresql-rds","description":"A Terraform module to create an Amazon Web Services (AWS) PostgreSQL Relational Database Server (RDS).","fork":false,"url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds","forks_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/forks","keys_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/teams","hooks_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/hooks","issue_events_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/events","assignees_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/tags","blobs_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/languages","stargazers_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/stargazers","contributors_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/contributors","subscribers_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/subscribers","subscription_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/subscription","commits_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/merges","archive_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/downloads","issues_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/labels{/name}","releases_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/deployments","created_at":"2015-11-11T20:23:14Z","updated_at":"2016-11-14T17:43:50Z","pushed_at":"2016-12-19T18:32:34Z","git_url":"git://github.com/azavea/terraform-aws-postgresql-rds.git","ssh_url":"git@github.com:azavea/terraform-aws-postgresql-rds.git","clone_url":"https://github.com/azavea/terraform-aws-postgresql-rds.git","svn_url":"https://github.com/azavea/terraform-aws-postgresql-rds","homepage":null,"size":32,"stargazers_count":5,"watchers_count":5,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":5,"default_branch":"develop"}},"base":{"label":"azavea:develop","ref":"develop","sha":"b360ed7a63c0836fa2963c92bc15c6df16885026","user":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":46007776,"name":"terraform-aws-postgresql-rds","full_name":"azavea/terraform-aws-postgresql-rds","owner":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/terraform-aws-postgresql-rds","description":"A Terraform module to create an Amazon Web Services (AWS) PostgreSQL Relational Database Server (RDS).","fork":false,"url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds","forks_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/forks","keys_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/teams","hooks_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/hooks","issue_events_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/events","assignees_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/tags","blobs_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/languages","stargazers_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/stargazers","contributors_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/contributors","subscribers_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/subscribers","subscription_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/subscription","commits_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/merges","archive_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/downloads","issues_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/labels{/name}","releases_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/deployments","created_at":"2015-11-11T20:23:14Z","updated_at":"2016-11-14T17:43:50Z","pushed_at":"2016-12-19T18:32:34Z","git_url":"git://github.com/azavea/terraform-aws-postgresql-rds.git","ssh_url":"git@github.com:azavea/terraform-aws-postgresql-rds.git","clone_url":"https://github.com/azavea/terraform-aws-postgresql-rds.git","svn_url":"https://github.com/azavea/terraform-aws-postgresql-rds","homepage":null,"size":32,"stargazers_count":5,"watchers_count":5,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21"},"html":{"href":"https://github.com/azavea/terraform-aws-postgresql-rds/pull/21"},"issue":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/21"},"comments":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/azavea/terraform-aws-postgresql-rds/statuses/6297e2d04062576c92475baa442fa27439de8528"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":37,"deletions":18,"changed_files":3}}
{"actor":{"display_login":"hectcastro"}}