{"action":"created","issue":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/398","repository_url":"https://api.github.com/repos/jeff-regier/Celeste.jl","labels_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/398/labels{/name}","comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/398/comments","events_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/398/events","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/398","id":187535957,"number":398,"title":"Disable bounds checking in ","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-06T01:47:37Z","updated_at":"2016-11-06T07:35:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/398","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/398","diff_url":"https://github.com/jeff-regier/Celeste.jl/pull/398.diff","patch_url":"https://github.com/jeff-regier/Celeste.jl/pull/398.patch"},"body":"`calculate_source_pixel_brightness!`, `add_elbo_log_term!`, `evaluate_psf_pixel_fit!`, `evaluate_psf_fit!`, `and get_bvn_derivs!`.\r\n\r\nThis gives a decent speedup. Single threaded, I get\r\n\r\n#### master\r\n10.146384 seconds (4.08 M allocations: 623.774 MB, 7.43% gc time)\r\n\r\n#### PR\r\n8.841830 seconds (4.08 M allocations: 623.774 MB, 8.80% gc time)\r\n\r\nThis can, of course, hide some errors but we can always run Julia with `--check-bounds=yes` if we see segfaults. Generally, LLVM is much better in vectorizing code when bounds checking is off so this might become even more relevant on KNL. I haven't checked if the code in any of these function is getting vectorized though."},"comment":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/comments/258665348","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/398#issuecomment-258665348","issue_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/398","id":258665348,"user":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T07:35:33Z","updated_at":"2016-11-06T07:35:33Z","body":"Nice, thanks!"}}
{"actor":{"display_login":"jeff-regier"}}