{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/511","repository_url":"https://api.github.com/repos/kubernetes/minikube","labels_url":"https://api.github.com/repos/kubernetes/minikube/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/511/comments","events_url":"https://api.github.com/repos/kubernetes/minikube/issues/511/events","html_url":"https://github.com/kubernetes/minikube/pull/511","id":172723787,"number":511,"title":"localkube: add rkt support","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/minikube/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-08-23T15:03:12Z","updated_at":"2016-09-08T12:39:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/511","html_url":"https://github.com/kubernetes/minikube/pull/511","diff_url":"https://github.com/kubernetes/minikube/pull/511.diff","patch_url":"https://github.com/kubernetes/minikube/pull/511.patch"},"body":"This is a first pass to enable other container runtimes in minikube. While the changes here are pretty small, a bigger effort was to create an ISO that contains docker, rkt, and systemd, being ~67MB in size.\r\n\r\nThe https://buildroot.org/ based config for that image is available here: https://github.com/coreos/minikube-iso. I can include those configs in-tree in this PR too.\r\n\r\nWe are also investigating a \"CoreOS-slim\" based ISO image which could replace the aforementioned buildroot ISO, but as long as that is not available we could go with this solution first.\r\n\r\nWhat I did for testing locally was to start minikube as follows (after building my PR branch):\r\n\r\n```\r\n$ ./out/minikube start \\\r\n\t--kubernetes-version=file:///home/sur/src/minikube/src/k8s.io/minikube/out/localkube \\\r\n\t--iso-url=https://github.com/coreos/minikube-iso/releases/download/v0.0.2/minikube-v0.0.2.iso \\\r\n\t--vm-driver=kvm\r\n```\r\n\r\n/cc @dlorenc This PR also introduces more than I envisioned initially ;-) I added a small provisioner for the buildroot based \"minikube\" image, and the ISO image includes docker as well.\r\n\r\nTODOs:\r\n\r\n- [x] Use rkt with the cni plugin rather than the default no-op\r\n- [x] use rkt v1.14.0 (landing on 9/1) fixing a bug in conjunction with minikube\r\n- [x] Rethink/configure persisting `/var/lib/kubelet`\r\n\r\nFixes #168"},"comment":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/comments/245583925","html_url":"https://github.com/kubernetes/minikube/pull/511#issuecomment-245583925","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/511","id":245583925,"user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T12:39:39Z","updated_at":"2016-09-08T12:39:39Z","body":"@dlorenc I added CNI support, which can be enabled using `--network-plugin=cni`. The minikube-iso image also provides the necessary additional plugins, as well as some default config, see https://github.com/coreos/minikube-iso/releases/tag/v0.0.3.\r\n\r\nSo what do you think, could we land this?"}}
{"actor":{"display_login":"s-urbaniak"}}