{"action":"created","issue":{"url":"https://api.github.com/repos/firehol/netdata/issues/677","repository_url":"https://api.github.com/repos/firehol/netdata","labels_url":"https://api.github.com/repos/firehol/netdata/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/677/comments","events_url":"https://api.github.com/repos/firehol/netdata/issues/677/events","html_url":"https://github.com/firehol/netdata/pull/677","id":165110107,"number":677,"title":"Redis python module + minor fixes","user":{"login":"paulfantom","id":3531758,"avatar_url":"https://avatars.githubusercontent.com/u/3531758?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-12T15:30:30Z","updated_at":"2016-07-12T22:37:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/677","html_url":"https://github.com/firehol/netdata/pull/677","diff_url":"https://github.com/firehol/netdata/pull/677.diff","patch_url":"https://github.com/firehol/netdata/pull/677.patch"},"body":"1. Nginx is shown as `nginx: local` in dashboard while using python or bash module.\r\n2. `NetSocketService` changed name to `SocketService`, which now can use unix sockets as well as TCP/IP sockets\r\n3. changed and tested new python shebang (yes it works)\r\n4. fixed issue with wrong data parsing in `exim.chart.py`\r\n5. changed whitelisting method in `ExecutableService`. It is very probable that whitelisting is not needed, but I am not sure.\r\n6. Added `redis.chart.py`\r\n\r\nI have tested this and it works.\r\n\r\nAfter merging this I need to take a break from rewriting modules to python. There are only 3 modules left, but I don't have any data to create `opensips.chart.py` as well as `nut.chart.py` (so I cannot code parsers). I also need to do some more research to create `ap.chart.py` since using `iw` isn't the best method. "},"comment":{"url":"https://api.github.com/repos/firehol/netdata/issues/comments/232203290","html_url":"https://github.com/firehol/netdata/pull/677#issuecomment-232203290","issue_url":"https://api.github.com/repos/firehol/netdata/issues/677","id":232203290,"user":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T22:37:25Z","updated_at":"2016-07-12T22:37:25Z","body":"You are the best!\r\n\r\n1. Should there be a `redis.conf` with the auto-detection settings?\r\n2. redis is missing from `python.d.conf`\r\n3. For some reason the mysql charts have now an id `mysqllocal` - it should be `mysql_local`. The same happens with squid.\r\n4. I also get these errors:\r\n\r\n   ```\r\npython.d ERROR: squidlocal wrong dimension id: client_http_kbytes_in\r\npython.d ERROR: squidlocal wrong dimension id: client_http_kbytes_out\r\npython.d ERROR: squidlocal wrong dimension id: client_http_hit_kbytes_out\r\npython.d ERROR: squidlocal wrong dimension id: client_http_requests\r\npython.d ERROR: squidlocal wrong dimension id: client_http_hits\r\npython.d ERROR: squidlocal wrong dimension id: client_http_errors\r\npython.d ERROR: squidlocal wrong dimension id: server_all_kbytes_in\r\npython.d ERROR: squidlocal wrong dimension id: server_all_kbytes_out\r\npython.d ERROR: squidlocal wrong dimension id: server_all_requests\r\npython.d ERROR: squidlocal wrong dimension id: server_all_errors\r\n```\r\n\r\n\r\n"}}
{"actor":{"display_login":"ktsaou"}}