{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments/75432833","id":75432833,"diff_hunk":"@@ -131,11 +131,16 @@ sub get_volatility {\n         if $args->{from}->epoch > $args->{to}->epoch;\n \n     # This sanity check prevents negative variance\n-    die 'Requested dates are too far in the past ['\n-        . $args->{from}->datetime\n-        . '] with surface recorded date ['\n-        . $self->recorded_date->datetime . ']'\n-        if $args->{from}->epoch < $self->recorded_date->epoch;\n+    # This will happen when we are trying to price a contract that has expired but not settled.\n+    # Yng Shan will fix the settlement problem.","path":"lib/Quant/Framework/VolSurface/Delta.pm","position":10,"original_position":10,"commit_id":"c10e30d6af534788bd36a8e1ce59cee4e02ce4d8","original_commit_id":"c10e30d6af534788bd36a8e1ce59cee4e02ce4d8","user":{"login":"jy-binary","id":4658418,"avatar_url":"https://avatars.githubusercontent.com/u/4658418?v=3","gravatar_id":"","url":"https://api.github.com/users/jy-binary","html_url":"https://github.com/jy-binary","followers_url":"https://api.github.com/users/jy-binary/followers","following_url":"https://api.github.com/users/jy-binary/following{/other_user}","gists_url":"https://api.github.com/users/jy-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/jy-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jy-binary/subscriptions","organizations_url":"https://api.github.com/users/jy-binary/orgs","repos_url":"https://api.github.com/users/jy-binary/repos","events_url":"https://api.github.com/users/jy-binary/events{/privacy}","received_events_url":"https://api.github.com/users/jy-binary/received_events","type":"User","site_admin":false},"body":"this is an open-source repo. I don't think Yng Shan needs her name exposed to the public","created_at":"2016-08-19T06:27:12Z","updated_at":"2016-08-19T06:27:12Z","html_url":"https://github.com/binary-com/perl-Quant-Framework/pull/61#discussion_r75432833","pull_request_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments/75432833"},"html":{"href":"https://github.com/binary-com/perl-Quant-Framework/pull/61#discussion_r75432833"},"pull_request":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61","id":81576276,"html_url":"https://github.com/binary-com/perl-Quant-Framework/pull/61","diff_url":"https://github.com/binary-com/perl-Quant-Framework/pull/61.diff","patch_url":"https://github.com/binary-com/perl-Quant-Framework/pull/61.patch","issue_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/61","number":61,"state":"open","locked":false,"title":"junbon/negative_variance","user":{"login":"junbon","id":715553,"avatar_url":"https://avatars.githubusercontent.com/u/715553?v=3","gravatar_id":"","url":"https://api.github.com/users/junbon","html_url":"https://github.com/junbon","followers_url":"https://api.github.com/users/junbon/followers","following_url":"https://api.github.com/users/junbon/following{/other_user}","gists_url":"https://api.github.com/users/junbon/gists{/gist_id}","starred_url":"https://api.github.com/users/junbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junbon/subscriptions","organizations_url":"https://api.github.com/users/junbon/orgs","repos_url":"https://api.github.com/users/junbon/repos","events_url":"https://api.github.com/users/junbon/events{/privacy}","received_events_url":"https://api.github.com/users/junbon/received_events","type":"User","site_admin":false},"body":"set the volatility to 1% if requested period for volatility is in the past","created_at":"2016-08-17T02:43:01Z","updated_at":"2016-08-19T06:27:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddcef6aab1b615ef76efc3cb9a2a5ddf5e546914","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61/commits","review_comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61/comments","review_comment_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/61/comments","statuses_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/c10e30d6af534788bd36a8e1ce59cee4e02ce4d8","head":{"label":"junbon:junbon/negative_variance","ref":"junbon/negative_variance","sha":"c10e30d6af534788bd36a8e1ce59cee4e02ce4d8","user":{"login":"junbon","id":715553,"avatar_url":"https://avatars.githubusercontent.com/u/715553?v=3","gravatar_id":"","url":"https://api.github.com/users/junbon","html_url":"https://github.com/junbon","followers_url":"https://api.github.com/users/junbon/followers","following_url":"https://api.github.com/users/junbon/following{/other_user}","gists_url":"https://api.github.com/users/junbon/gists{/gist_id}","starred_url":"https://api.github.com/users/junbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junbon/subscriptions","organizations_url":"https://api.github.com/users/junbon/orgs","repos_url":"https://api.github.com/users/junbon/repos","events_url":"https://api.github.com/users/junbon/events{/privacy}","received_events_url":"https://api.github.com/users/junbon/received_events","type":"User","site_admin":false},"repo":{"id":60576293,"name":"perl-Quant-Framework","full_name":"junbon/perl-Quant-Framework","owner":{"login":"junbon","id":715553,"avatar_url":"https://avatars.githubusercontent.com/u/715553?v=3","gravatar_id":"","url":"https://api.github.com/users/junbon","html_url":"https://github.com/junbon","followers_url":"https://api.github.com/users/junbon/followers","following_url":"https://api.github.com/users/junbon/following{/other_user}","gists_url":"https://api.github.com/users/junbon/gists{/gist_id}","starred_url":"https://api.github.com/users/junbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junbon/subscriptions","organizations_url":"https://api.github.com/users/junbon/orgs","repos_url":"https://api.github.com/users/junbon/repos","events_url":"https://api.github.com/users/junbon/events{/privacy}","received_events_url":"https://api.github.com/users/junbon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junbon/perl-Quant-Framework","description":"A framework of objects upon which to build Financial Quantitative Analysis code","fork":true,"url":"https://api.github.com/repos/junbon/perl-Quant-Framework","forks_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/forks","keys_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/teams","hooks_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/hooks","issue_events_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/events","assignees_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/tags","blobs_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/languages","stargazers_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/stargazers","contributors_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/contributors","subscribers_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/subscribers","subscription_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/subscription","commits_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/merges","archive_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/downloads","issues_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/labels{/name}","releases_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/junbon/perl-Quant-Framework/deployments","created_at":"2016-06-07T02:40:20Z","updated_at":"2016-06-07T02:40:22Z","pushed_at":"2016-08-19T02:35:11Z","git_url":"git://github.com/junbon/perl-Quant-Framework.git","ssh_url":"git@github.com:junbon/perl-Quant-Framework.git","clone_url":"https://github.com/junbon/perl-Quant-Framework.git","svn_url":"https://github.com/junbon/perl-Quant-Framework","homepage":null,"size":794,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binary-com:master","ref":"master","sha":"29b38cd27ad09bfa9bd69063f323d49b4cb69afa","user":{"login":"binary-com","id":7437559,"avatar_url":"https://avatars.githubusercontent.com/u/7437559?v=3","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":50404733,"name":"perl-Quant-Framework","full_name":"binary-com/perl-Quant-Framework","owner":{"login":"binary-com","id":7437559,"avatar_url":"https://avatars.githubusercontent.com/u/7437559?v=3","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binary-com/perl-Quant-Framework","description":"A framework of objects upon which to build Financial Quantitative Analysis code","fork":false,"url":"https://api.github.com/repos/binary-com/perl-Quant-Framework","forks_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/forks","keys_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/teams","hooks_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/hooks","issue_events_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/events","assignees_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/tags","blobs_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/languages","stargazers_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/stargazers","contributors_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/contributors","subscribers_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/subscribers","subscription_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/subscription","commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/merges","archive_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/downloads","issues_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/perl-Quant-Framework/deployments","created_at":"2016-01-26T05:05:38Z","updated_at":"2016-06-13T17:26:41Z","pushed_at":"2016-08-19T02:35:12Z","git_url":"git://github.com/binary-com/perl-Quant-Framework.git","ssh_url":"git@github.com:binary-com/perl-Quant-Framework.git","clone_url":"https://github.com/binary-com/perl-Quant-Framework.git","svn_url":"https://github.com/binary-com/perl-Quant-Framework","homepage":null,"size":859,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61"},"html":{"href":"https://github.com/binary-com/perl-Quant-Framework/pull/61"},"issue":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/61"},"comments":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/perl-Quant-Framework/statuses/c10e30d6af534788bd36a8e1ce59cee4e02ce4d8"}}}}
{"actor":{"display_login":"jy-binary"}}