{"action":"created","comment":{"url":"https://api.github.com/repos/joost/phony_rails/pulls/comments/84342260","pull_request_review_id":5126323,"id":84342260,"diff_hunk":"@@ -9,7 +9,7 @@ def validate_each(record, attribute, value)\n \n     @record = record\n     value = PhonyRails.normalize_number(value.dup, default_country_code: normalized_country_code) if normalized_country_code\n-    value, = PhonyRails.extract_extension(value)\n+    value = PhonyRails.extract_extension(value).first","path":"lib/validators/phony_validator.rb","position":null,"original_position":5,"commit_id":"885e5bb121b32ced312b7fa3188f8eeab265a5c4","original_commit_id":"167b1029e2166319606cdefcdbc7a9ac2083974e","user":{"login":"Kukunin","id":237993,"avatar_url":"https://avatars.githubusercontent.com/u/237993?v=3","gravatar_id":"","url":"https://api.github.com/users/Kukunin","html_url":"https://github.com/Kukunin","followers_url":"https://api.github.com/users/Kukunin/followers","following_url":"https://api.github.com/users/Kukunin/following{/other_user}","gists_url":"https://api.github.com/users/Kukunin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kukunin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kukunin/subscriptions","organizations_url":"https://api.github.com/users/Kukunin/orgs","repos_url":"https://api.github.com/users/Kukunin/repos","events_url":"https://api.github.com/users/Kukunin/events{/privacy}","received_events_url":"https://api.github.com/users/Kukunin/received_events","type":"User","site_admin":false},"body":"Actually rubocop advices `value,  = PhonyRails.extract_extension(value)` instead, which looks confusing","created_at":"2016-10-20T18:03:54Z","updated_at":"2016-10-20T18:03:54Z","html_url":"https://github.com/joost/phony_rails/pull/153#discussion_r84342260","pull_request_url":"https://api.github.com/repos/joost/phony_rails/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/comments/84342260"},"html":{"href":"https://github.com/joost/phony_rails/pull/153#discussion_r84342260"},"pull_request":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/joost/phony_rails/pulls/153","id":90099971,"html_url":"https://github.com/joost/phony_rails/pull/153","diff_url":"https://github.com/joost/phony_rails/pull/153.diff","patch_url":"https://github.com/joost/phony_rails/pull/153.patch","issue_url":"https://api.github.com/repos/joost/phony_rails/issues/153","number":153,"state":"open","locked":false,"title":"Support of phone numbers with extension in validator","user":{"login":"Kukunin","id":237993,"avatar_url":"https://avatars.githubusercontent.com/u/237993?v=3","gravatar_id":"","url":"https://api.github.com/users/Kukunin","html_url":"https://github.com/Kukunin","followers_url":"https://api.github.com/users/Kukunin/followers","following_url":"https://api.github.com/users/Kukunin/following{/other_user}","gists_url":"https://api.github.com/users/Kukunin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kukunin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kukunin/subscriptions","organizations_url":"https://api.github.com/users/Kukunin/orgs","repos_url":"https://api.github.com/users/Kukunin/repos","events_url":"https://api.github.com/users/Kukunin/events{/privacy}","received_events_url":"https://api.github.com/users/Kukunin/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-19T22:06:59Z","updated_at":"2016-10-20T18:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ecf574501411ce8888f9ca00dba2095d5d7f190","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joost/phony_rails/pulls/153/commits","review_comments_url":"https://api.github.com/repos/joost/phony_rails/pulls/153/comments","review_comment_url":"https://api.github.com/repos/joost/phony_rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joost/phony_rails/issues/153/comments","statuses_url":"https://api.github.com/repos/joost/phony_rails/statuses/885e5bb121b32ced312b7fa3188f8eeab265a5c4","head":{"label":"Kukunin:master","ref":"master","sha":"885e5bb121b32ced312b7fa3188f8eeab265a5c4","user":{"login":"Kukunin","id":237993,"avatar_url":"https://avatars.githubusercontent.com/u/237993?v=3","gravatar_id":"","url":"https://api.github.com/users/Kukunin","html_url":"https://github.com/Kukunin","followers_url":"https://api.github.com/users/Kukunin/followers","following_url":"https://api.github.com/users/Kukunin/following{/other_user}","gists_url":"https://api.github.com/users/Kukunin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kukunin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kukunin/subscriptions","organizations_url":"https://api.github.com/users/Kukunin/orgs","repos_url":"https://api.github.com/users/Kukunin/repos","events_url":"https://api.github.com/users/Kukunin/events{/privacy}","received_events_url":"https://api.github.com/users/Kukunin/received_events","type":"User","site_admin":false},"repo":{"id":60812839,"name":"phony_rails","full_name":"Kukunin/phony_rails","owner":{"login":"Kukunin","id":237993,"avatar_url":"https://avatars.githubusercontent.com/u/237993?v=3","gravatar_id":"","url":"https://api.github.com/users/Kukunin","html_url":"https://github.com/Kukunin","followers_url":"https://api.github.com/users/Kukunin/followers","following_url":"https://api.github.com/users/Kukunin/following{/other_user}","gists_url":"https://api.github.com/users/Kukunin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kukunin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kukunin/subscriptions","organizations_url":"https://api.github.com/users/Kukunin/orgs","repos_url":"https://api.github.com/users/Kukunin/repos","events_url":"https://api.github.com/users/Kukunin/events{/privacy}","received_events_url":"https://api.github.com/users/Kukunin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kukunin/phony_rails","description":"This Gem adds useful methods to your Rails app to validate, display and save phone numbers. It uses the super awesome Phony gem (https://github.com/floere/phony).","fork":true,"url":"https://api.github.com/repos/Kukunin/phony_rails","forks_url":"https://api.github.com/repos/Kukunin/phony_rails/forks","keys_url":"https://api.github.com/repos/Kukunin/phony_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kukunin/phony_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kukunin/phony_rails/teams","hooks_url":"https://api.github.com/repos/Kukunin/phony_rails/hooks","issue_events_url":"https://api.github.com/repos/Kukunin/phony_rails/issues/events{/number}","events_url":"https://api.github.com/repos/Kukunin/phony_rails/events","assignees_url":"https://api.github.com/repos/Kukunin/phony_rails/assignees{/user}","branches_url":"https://api.github.com/repos/Kukunin/phony_rails/branches{/branch}","tags_url":"https://api.github.com/repos/Kukunin/phony_rails/tags","blobs_url":"https://api.github.com/repos/Kukunin/phony_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kukunin/phony_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kukunin/phony_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kukunin/phony_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kukunin/phony_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/Kukunin/phony_rails/languages","stargazers_url":"https://api.github.com/repos/Kukunin/phony_rails/stargazers","contributors_url":"https://api.github.com/repos/Kukunin/phony_rails/contributors","subscribers_url":"https://api.github.com/repos/Kukunin/phony_rails/subscribers","subscription_url":"https://api.github.com/repos/Kukunin/phony_rails/subscription","commits_url":"https://api.github.com/repos/Kukunin/phony_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kukunin/phony_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kukunin/phony_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kukunin/phony_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kukunin/phony_rails/contents/{+path}","compare_url":"https://api.github.com/repos/Kukunin/phony_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kukunin/phony_rails/merges","archive_url":"https://api.github.com/repos/Kukunin/phony_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kukunin/phony_rails/downloads","issues_url":"https://api.github.com/repos/Kukunin/phony_rails/issues{/number}","pulls_url":"https://api.github.com/repos/Kukunin/phony_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/Kukunin/phony_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/Kukunin/phony_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kukunin/phony_rails/labels{/name}","releases_url":"https://api.github.com/repos/Kukunin/phony_rails/releases{/id}","deployments_url":"https://api.github.com/repos/Kukunin/phony_rails/deployments","created_at":"2016-06-09T23:11:25Z","updated_at":"2016-06-09T23:11:26Z","pushed_at":"2016-10-19T22:05:34Z","git_url":"git://github.com/Kukunin/phony_rails.git","ssh_url":"git@github.com:Kukunin/phony_rails.git","clone_url":"https://github.com/Kukunin/phony_rails.git","svn_url":"https://github.com/Kukunin/phony_rails","homepage":"","size":323,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joost:master","ref":"master","sha":"0d0bdf2ddeb3859f7b50b08df797142441f4fc40","user":{"login":"joost","id":91466,"avatar_url":"https://avatars.githubusercontent.com/u/91466?v=3","gravatar_id":"","url":"https://api.github.com/users/joost","html_url":"https://github.com/joost","followers_url":"https://api.github.com/users/joost/followers","following_url":"https://api.github.com/users/joost/following{/other_user}","gists_url":"https://api.github.com/users/joost/gists{/gist_id}","starred_url":"https://api.github.com/users/joost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joost/subscriptions","organizations_url":"https://api.github.com/users/joost/orgs","repos_url":"https://api.github.com/users/joost/repos","events_url":"https://api.github.com/users/joost/events{/privacy}","received_events_url":"https://api.github.com/users/joost/received_events","type":"User","site_admin":false},"repo":{"id":4192705,"name":"phony_rails","full_name":"joost/phony_rails","owner":{"login":"joost","id":91466,"avatar_url":"https://avatars.githubusercontent.com/u/91466?v=3","gravatar_id":"","url":"https://api.github.com/users/joost","html_url":"https://github.com/joost","followers_url":"https://api.github.com/users/joost/followers","following_url":"https://api.github.com/users/joost/following{/other_user}","gists_url":"https://api.github.com/users/joost/gists{/gist_id}","starred_url":"https://api.github.com/users/joost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joost/subscriptions","organizations_url":"https://api.github.com/users/joost/orgs","repos_url":"https://api.github.com/users/joost/repos","events_url":"https://api.github.com/users/joost/events{/privacy}","received_events_url":"https://api.github.com/users/joost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joost/phony_rails","description":"This Gem adds useful methods to your Rails app to validate, display and save phone numbers. It uses the super awesome Phony gem (https://github.com/floere/phony).","fork":false,"url":"https://api.github.com/repos/joost/phony_rails","forks_url":"https://api.github.com/repos/joost/phony_rails/forks","keys_url":"https://api.github.com/repos/joost/phony_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joost/phony_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joost/phony_rails/teams","hooks_url":"https://api.github.com/repos/joost/phony_rails/hooks","issue_events_url":"https://api.github.com/repos/joost/phony_rails/issues/events{/number}","events_url":"https://api.github.com/repos/joost/phony_rails/events","assignees_url":"https://api.github.com/repos/joost/phony_rails/assignees{/user}","branches_url":"https://api.github.com/repos/joost/phony_rails/branches{/branch}","tags_url":"https://api.github.com/repos/joost/phony_rails/tags","blobs_url":"https://api.github.com/repos/joost/phony_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joost/phony_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joost/phony_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/joost/phony_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joost/phony_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/joost/phony_rails/languages","stargazers_url":"https://api.github.com/repos/joost/phony_rails/stargazers","contributors_url":"https://api.github.com/repos/joost/phony_rails/contributors","subscribers_url":"https://api.github.com/repos/joost/phony_rails/subscribers","subscription_url":"https://api.github.com/repos/joost/phony_rails/subscription","commits_url":"https://api.github.com/repos/joost/phony_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/joost/phony_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/joost/phony_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/joost/phony_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/joost/phony_rails/contents/{+path}","compare_url":"https://api.github.com/repos/joost/phony_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joost/phony_rails/merges","archive_url":"https://api.github.com/repos/joost/phony_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joost/phony_rails/downloads","issues_url":"https://api.github.com/repos/joost/phony_rails/issues{/number}","pulls_url":"https://api.github.com/repos/joost/phony_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/joost/phony_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/joost/phony_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joost/phony_rails/labels{/name}","releases_url":"https://api.github.com/repos/joost/phony_rails/releases{/id}","deployments_url":"https://api.github.com/repos/joost/phony_rails/deployments","created_at":"2012-05-01T13:55:42Z","updated_at":"2016-10-19T15:38:13Z","pushed_at":"2016-10-19T22:06:59Z","git_url":"git://github.com/joost/phony_rails.git","ssh_url":"git@github.com:joost/phony_rails.git","clone_url":"https://github.com/joost/phony_rails.git","svn_url":"https://github.com/joost/phony_rails","homepage":"","size":378,"stargazers_count":305,"watchers_count":305,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":2,"forks":80,"open_issues":2,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/153"},"html":{"href":"https://github.com/joost/phony_rails/pull/153"},"issue":{"href":"https://api.github.com/repos/joost/phony_rails/issues/153"},"comments":{"href":"https://api.github.com/repos/joost/phony_rails/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joost/phony_rails/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/joost/phony_rails/statuses/885e5bb121b32ced312b7fa3188f8eeab265a5c4"}}}}
{"actor":{"display_login":"Kukunin"}}