{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/62039228","id":62039228,"diff_hunk":"@@ -32,6 +32,7 @@ def read_config(self, config):\n             )\n \n         self.registration_shared_secret = config.get(\"registration_shared_secret\")\n+        self.user_creation_max_duration = config.get(\"user_creation_max_duration\")","path":"synapse/config/registration.py","position":4,"original_position":4,"commit_id":"0edbaf4ffe6f703354be8749784f8a8e7348f59e","original_commit_id":"0edbaf4ffe6f703354be8749784f8a8e7348f59e","user":{"login":"erikjohnston","id":8428120,"avatar_url":"https://avatars.githubusercontent.com/u/8428120?v=3","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"body":"This should probably be `config[\"user_creation_max_duration\"]` as the default is handled by the default config below, and we probably don't ever want `user_creation_max_duration` to be `None` rather than an int","created_at":"2016-05-04T13:36:20Z","updated_at":"2016-05-04T13:36:20Z","html_url":"https://github.com/matrix-org/synapse/pull/741#discussion_r62039228","pull_request_url":"https://api.github.com/repos/matrix-org/synapse/pulls/741","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/62039228"},"html":{"href":"https://github.com/matrix-org/synapse/pull/741#discussion_r62039228"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/741"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/741","id":67333408,"html_url":"https://github.com/matrix-org/synapse/pull/741","diff_url":"https://github.com/matrix-org/synapse/pull/741.diff","patch_url":"https://github.com/matrix-org/synapse/pull/741.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/741","number":741,"state":"open","locked":false,"title":"Create user with expiry","user":{"login":"negzi","id":6698393,"avatar_url":"https://avatars.githubusercontent.com/u/6698393?v=3","gravatar_id":"","url":"https://api.github.com/users/negzi","html_url":"https://github.com/negzi","followers_url":"https://api.github.com/users/negzi/followers","following_url":"https://api.github.com/users/negzi/following{/other_user}","gists_url":"https://api.github.com/users/negzi/gists{/gist_id}","starred_url":"https://api.github.com/users/negzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negzi/subscriptions","organizations_url":"https://api.github.com/users/negzi/orgs","repos_url":"https://api.github.com/users/negzi/repos","events_url":"https://api.github.com/users/negzi/events{/privacy}","received_events_url":"https://api.github.com/users/negzi/received_events","type":"User","site_admin":false},"body":" - Add unit tests for client, api and handler","created_at":"2016-04-21T10:48:14Z","updated_at":"2016-05-04T13:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7735ecc6c890cbb8fd17404fe18629eaa7220a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/741/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/741/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/741/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/0edbaf4ffe6f703354be8749784f8a8e7348f59e","head":{"label":"negzi:create_user_with_expiry","ref":"create_user_with_expiry","sha":"0edbaf4ffe6f703354be8749784f8a8e7348f59e","user":{"login":"negzi","id":6698393,"avatar_url":"https://avatars.githubusercontent.com/u/6698393?v=3","gravatar_id":"","url":"https://api.github.com/users/negzi","html_url":"https://github.com/negzi","followers_url":"https://api.github.com/users/negzi/followers","following_url":"https://api.github.com/users/negzi/following{/other_user}","gists_url":"https://api.github.com/users/negzi/gists{/gist_id}","starred_url":"https://api.github.com/users/negzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negzi/subscriptions","organizations_url":"https://api.github.com/users/negzi/orgs","repos_url":"https://api.github.com/users/negzi/repos","events_url":"https://api.github.com/users/negzi/events{/privacy}","received_events_url":"https://api.github.com/users/negzi/received_events","type":"User","site_admin":false},"repo":{"id":54387187,"name":"synapse","full_name":"negzi/synapse","owner":{"login":"negzi","id":6698393,"avatar_url":"https://avatars.githubusercontent.com/u/6698393?v=3","gravatar_id":"","url":"https://api.github.com/users/negzi","html_url":"https://github.com/negzi","followers_url":"https://api.github.com/users/negzi/followers","following_url":"https://api.github.com/users/negzi/following{/other_user}","gists_url":"https://api.github.com/users/negzi/gists{/gist_id}","starred_url":"https://api.github.com/users/negzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negzi/subscriptions","organizations_url":"https://api.github.com/users/negzi/orgs","repos_url":"https://api.github.com/users/negzi/repos","events_url":"https://api.github.com/users/negzi/events{/privacy}","received_events_url":"https://api.github.com/users/negzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/negzi/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/negzi/synapse","forks_url":"https://api.github.com/repos/negzi/synapse/forks","keys_url":"https://api.github.com/repos/negzi/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/negzi/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/negzi/synapse/teams","hooks_url":"https://api.github.com/repos/negzi/synapse/hooks","issue_events_url":"https://api.github.com/repos/negzi/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/negzi/synapse/events","assignees_url":"https://api.github.com/repos/negzi/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/negzi/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/negzi/synapse/tags","blobs_url":"https://api.github.com/repos/negzi/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/negzi/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/negzi/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/negzi/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/negzi/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/negzi/synapse/languages","stargazers_url":"https://api.github.com/repos/negzi/synapse/stargazers","contributors_url":"https://api.github.com/repos/negzi/synapse/contributors","subscribers_url":"https://api.github.com/repos/negzi/synapse/subscribers","subscription_url":"https://api.github.com/repos/negzi/synapse/subscription","commits_url":"https://api.github.com/repos/negzi/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/negzi/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/negzi/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/negzi/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/negzi/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/negzi/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/negzi/synapse/merges","archive_url":"https://api.github.com/repos/negzi/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/negzi/synapse/downloads","issues_url":"https://api.github.com/repos/negzi/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/negzi/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/negzi/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/negzi/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/negzi/synapse/labels{/name}","releases_url":"https://api.github.com/repos/negzi/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/negzi/synapse/deployments","created_at":"2016-03-21T12:33:46Z","updated_at":"2016-03-21T12:33:48Z","pushed_at":"2016-04-21T10:46:21Z","git_url":"git://github.com/negzi/synapse.git","ssh_url":"git@github.com:negzi/synapse.git","clone_url":"https://github.com/negzi/synapse.git","svn_url":"https://github.com/negzi/synapse","homepage":"http://matrix.org","size":10435,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"68ebb81e86572daa04367c4d81c59a5eca151c65","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2016-05-03T05:26:13Z","pushed_at":"2016-05-04T12:21:15Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":16792,"stargazers_count":828,"watchers_count":828,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":16,"forks":86,"open_issues":16,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/741"},"html":{"href":"https://github.com/matrix-org/synapse/pull/741"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/741"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/741/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/741/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/741/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/0edbaf4ffe6f703354be8749784f8a8e7348f59e"}}}}