{"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/57602508","id":57602508,"diff_hunk":"@@ -19,15 +19,21 @@\n \n #include \"script_component.hpp\"\n \n-params [\"_tagPosASL\", \"_vectorDirAndUp\", \"_color\", \"_object\"];\n-TRACE_4(\"createTag:\", _tagPosASL, _vectorDirAndUp, _color, _object);\n+params [\"_tagPosASL\", \"_vectorDirAndUp\", \"_colorTexture\", \"_object\"];\n+TRACE_4(\"createTag:\",_tagPosASL,_vectorDirAndUp,_colorTexture,_object);\n \n-if !((toLower _color) in [\"black\", \"red\", \"green\", \"blue\"]) exitWith {\n-    ACE_LOGERROR_1(\"%1 is not a valid tag colour.\", _color);\n+private _customTexture = [true, false] select (_colorTexture find \".paa\" == -1);\n+\n+if (!_customTexture && {!((toLower _colorTexture) in [\"black\", \"red\", \"green\", \"blue\"])}) exitWith {\n+    ACE_LOGERROR_1(\"%1 is not a valid tag colour.\",_colorTexture);\n };\n \n private _tag = \"UserTexture1m_F\" createVehicle [0,0,0];\n-_tag setObjectTextureGlobal [0, '\\z\\ace\\addons\\tagging\\UI\\tags\\' + _color + '\\' + str (floor (random 3)) + '.paa'];\n+if (!_customTexture) then {\n+    _tag setObjectTextureGlobal [0, \"\\z\\ace\\addons\\tagging\\UI\\tags\\\" + _colorTexture + \"\\\" + str (floor (random 3)) + \".paa\"];","path":"addons/tagging/functions/fnc_createTag.sqf","position":29,"original_position":29,"commit_id":"dc1af390cdf70459f284a44860b7b531c0e3390b","original_commit_id":"dc1af390cdf70459f284a44860b7b531c0e3390b","user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"body":"Yeah I had that idea as well, will get around to it later.","created_at":"2016-03-28T17:40:16Z","updated_at":"2016-03-28T17:40:16Z","html_url":"https://github.com/acemod/ACE3/pull/3631#discussion_r57602508","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/3631","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/57602508"},"html":{"href":"https://github.com/acemod/ACE3/pull/3631#discussion_r57602508"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3631"}}},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/3631","id":64343337,"html_url":"https://github.com/acemod/ACE3/pull/3631","diff_url":"https://github.com/acemod/ACE3/pull/3631.diff","patch_url":"https://github.com/acemod/ACE3/pull/3631.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/3631","number":3631,"state":"open","locked":false,"title":"Add support for custom textures in tagging","user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"body":"**When merged this pull request will:**\r\n- Allow custom texture usage in tagging\r\n- Support for 3rd party mods, with this they only need the ACE Actions definition, they can handle randomness themselves with a custom function before calling `FUNC(tagWall)`\r\n- Adds a requested feature: https://github.com/acemod/ACE3/issues/3594#issuecomment-199326646 and https://github.com/acemod/ACE3/issues/3594#issuecomment-199398152\r\n\r\nExample:\r\n```\r\n// Internal\r\nstatement = QUOTE([ARR_2(ACE_player,'black')] call FUNC(tagWall));\r\n\r\n// Full path support (texture in mission folder)\r\nstatement = QUOTE([ARR_2(ACE_player,'tags\\tag.paa')] call FUNC(tagWall));\r\n```\r\n\r\nTagging @BaerMitUmlaut","created_at":"2016-03-28T16:57:17Z","updated_at":"2016-03-28T17:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cc1fa10e5e003d63f5fe1c715148c62a1b9e054","assignee":null,"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/16","html_url":"https://github.com/acemod/ACE3/milestones/3.6.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/16/labels","id":1464664,"number":16,"title":"3.6.0","description":"","creator":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":9,"state":"open","created_at":"2015-12-17T10:06:07Z","updated_at":"2016-03-28T16:57:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/3631/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/3631/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/3631/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/dc1af390cdf70459f284a44860b7b531c0e3390b","head":{"label":"acemod:customTaggingTextureSupport","ref":"customTaggingTextureSupport","sha":"dc1af390cdf70459f284a44860b7b531c0e3390b","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/acemod/ACE3/deployments","created_at":"2015-01-10T19:59:12Z","updated_at":"2016-03-27T18:01:52Z","pushed_at":"2016-03-28T16:57:17Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":455098,"stargazers_count":377,"watchers_count":377,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":318,"mirror_url":null,"open_issues_count":241,"forks":318,"open_issues":241,"watchers":377,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"4e3b342a7fa3f59b613d067b848ac5586149b490","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","deployments_url":"https://api.github.com/repos/acemod/ACE3/deployments","created_at":"2015-01-10T19:59:12Z","updated_at":"2016-03-27T18:01:52Z","pushed_at":"2016-03-28T16:57:17Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":455098,"stargazers_count":377,"watchers_count":377,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":318,"mirror_url":null,"open_issues_count":241,"forks":318,"open_issues":241,"watchers":377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3631"},"html":{"href":"https://github.com/acemod/ACE3/pull/3631"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/3631"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/3631/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3631/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3631/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/dc1af390cdf70459f284a44860b7b531c0e3390b"}}}}