{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/70323658","id":70323658,"diff_hunk":"@@ -277,14 +279,42 @@ func (s *walletServer) ImportPrivateKey(ctx context.Context, req *pb.ImportPriva\n \t\t\t\"Only the imported account accepts private key imports\")\n \t}\n \n-\t_, err = s.wallet.ImportPrivateKey(wif, nil, req.Rescan, 0)\n+\t_, err = s.wallet.ImportPrivateKey(wif, nil, req.Rescan, req.ScanFrom)","path":"rpc/rpcserver/server.go","position":31,"original_position":31,"commit_id":"13ce392ca65c844cc37560ed4c3c863bff1df41f","original_commit_id":"13ce392ca65c844cc37560ed4c3c863bff1df41f","user":{"login":"jrick","id":1420313,"avatar_url":"https://avatars.githubusercontent.com/u/1420313?v=3","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"body":"Before this, I would check for non-zero scan_from and error when rescan is false.","created_at":"2016-07-11T19:47:04Z","updated_at":"2016-07-11T19:47:04Z","html_url":"https://github.com/decred/dcrwallet/pull/293#discussion_r70323658","pull_request_url":"https://api.github.com/repos/decred/dcrwallet/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/70323658"},"html":{"href":"https://github.com/decred/dcrwallet/pull/293#discussion_r70323658"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/293","id":77009017,"html_url":"https://github.com/decred/dcrwallet/pull/293","diff_url":"https://github.com/decred/dcrwallet/pull/293.diff","patch_url":"https://github.com/decred/dcrwallet/pull/293.patch","issue_url":"https://api.github.com/repos/decred/dcrwallet/issues/293","number":293,"state":"open","locked":false,"title":"Add new stake-related RPCs to the gRPC interface","user":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"body":"The following new stake related RPC calls have been added to the\r\ngRPC:\r\n\r\n 1. StakeInfo\r\n 2. TicketPrice\r\n 3. ImportScript\r\n 4. PurchaseTickets\r\n\r\nImportPrivateKey has been updated to take the new ScanFrom variable\r\nfrom Decred.\r\n\r\nThe GetStakeInfo handling method for the legacy RPC has been modified\r\nto call a more general API from wallet.\r\n\r\nThe CreatePurchaseTicket API in wallet has been modified to take the\r\nfees to use for both the split transaction and ticket as arguments.\r\n\r\nThe SemVer minor version for the gRPC server has been bumped to 2.2.0.\r\n\r\nThe function to retrieve the stake difficulty from wallet has been\r\nchanged to simply use the fetch function from the daemon, and the\r\nregistration for stake difficulty notifications has been removed.","created_at":"2016-07-11T19:27:42Z","updated_at":"2016-07-11T19:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e56d4bb8b5ac02a0243f1692f75be391ea9a43e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrwallet/pulls/293/commits","review_comments_url":"https://api.github.com/repos/decred/dcrwallet/pulls/293/comments","review_comment_url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrwallet/issues/293/comments","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/13ce392ca65c844cc37560ed4c3c863bff1df41f","head":{"label":"cjepson:cj_080716grpcpurchaseticket","ref":"cj_080716grpcpurchaseticket","sha":"13ce392ca65c844cc37560ed4c3c863bff1df41f","user":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"repo":{"id":31670208,"name":"btcwallet","full_name":"cjepson/btcwallet","owner":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjepson/btcwallet","description":"","fork":true,"url":"https://api.github.com/repos/cjepson/btcwallet","forks_url":"https://api.github.com/repos/cjepson/btcwallet/forks","keys_url":"https://api.github.com/repos/cjepson/btcwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjepson/btcwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjepson/btcwallet/teams","hooks_url":"https://api.github.com/repos/cjepson/btcwallet/hooks","issue_events_url":"https://api.github.com/repos/cjepson/btcwallet/issues/events{/number}","events_url":"https://api.github.com/repos/cjepson/btcwallet/events","assignees_url":"https://api.github.com/repos/cjepson/btcwallet/assignees{/user}","branches_url":"https://api.github.com/repos/cjepson/btcwallet/branches{/branch}","tags_url":"https://api.github.com/repos/cjepson/btcwallet/tags","blobs_url":"https://api.github.com/repos/cjepson/btcwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjepson/btcwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjepson/btcwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjepson/btcwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjepson/btcwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/cjepson/btcwallet/languages","stargazers_url":"https://api.github.com/repos/cjepson/btcwallet/stargazers","contributors_url":"https://api.github.com/repos/cjepson/btcwallet/contributors","subscribers_url":"https://api.github.com/repos/cjepson/btcwallet/subscribers","subscription_url":"https://api.github.com/repos/cjepson/btcwallet/subscription","commits_url":"https://api.github.com/repos/cjepson/btcwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjepson/btcwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjepson/btcwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjepson/btcwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjepson/btcwallet/contents/{+path}","compare_url":"https://api.github.com/repos/cjepson/btcwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjepson/btcwallet/merges","archive_url":"https://api.github.com/repos/cjepson/btcwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjepson/btcwallet/downloads","issues_url":"https://api.github.com/repos/cjepson/btcwallet/issues{/number}","pulls_url":"https://api.github.com/repos/cjepson/btcwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/cjepson/btcwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/cjepson/btcwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjepson/btcwallet/labels{/name}","releases_url":"https://api.github.com/repos/cjepson/btcwallet/releases{/id}","deployments_url":"https://api.github.com/repos/cjepson/btcwallet/deployments","created_at":"2015-03-04T17:32:08Z","updated_at":"2015-03-06T04:02:56Z","pushed_at":"2016-07-11T19:45:20Z","git_url":"git://github.com/cjepson/btcwallet.git","ssh_url":"git@github.com:cjepson/btcwallet.git","clone_url":"https://github.com/cjepson/btcwallet.git","svn_url":"https://github.com/cjepson/btcwallet","homepage":null,"size":4308,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"d29c46b03850caa2a67155a21e0c6ba80d20c66c","user":{"login":"decred","id":16297194,"avatar_url":"https://avatars.githubusercontent.com/u/16297194?v=3","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457727,"name":"dcrwallet","full_name":"decred/dcrwallet","owner":{"login":"decred","id":16297194,"avatar_url":"https://avatars.githubusercontent.com/u/16297194?v=3","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrwallet","description":"A secure decred wallet daemon written in Go (golang)","fork":true,"url":"https://api.github.com/repos/decred/dcrwallet","forks_url":"https://api.github.com/repos/decred/dcrwallet/forks","keys_url":"https://api.github.com/repos/decred/dcrwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrwallet/teams","hooks_url":"https://api.github.com/repos/decred/dcrwallet/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrwallet/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrwallet/events","assignees_url":"https://api.github.com/repos/decred/dcrwallet/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrwallet/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrwallet/tags","blobs_url":"https://api.github.com/repos/decred/dcrwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrwallet/languages","stargazers_url":"https://api.github.com/repos/decred/dcrwallet/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrwallet/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrwallet/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrwallet/subscription","commits_url":"https://api.github.com/repos/decred/dcrwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrwallet/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrwallet/merges","archive_url":"https://api.github.com/repos/decred/dcrwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrwallet/downloads","issues_url":"https://api.github.com/repos/decred/dcrwallet/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrwallet/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrwallet/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrwallet/deployments","created_at":"2016-01-26T20:40:34Z","updated_at":"2016-05-27T08:23:11Z","pushed_at":"2016-07-11T19:45:20Z","git_url":"git://github.com/decred/dcrwallet.git","ssh_url":"git@github.com:decred/dcrwallet.git","clone_url":"https://github.com/decred/dcrwallet.git","svn_url":"https://github.com/decred/dcrwallet","homepage":"https://decred.org","size":4593,"stargazers_count":24,"watchers_count":24,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":48,"forks":14,"open_issues":48,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/293"},"html":{"href":"https://github.com/decred/dcrwallet/pull/293"},"issue":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/293"},"comments":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrwallet/statuses/13ce392ca65c844cc37560ed4c3c863bff1df41f"}}}}
{"actor":{"display_login":"jrick"}}