{"action":"created","comment":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/63244135","id":63244135,"diff_hunk":"@@ -64,6 +64,33 @@\n   boolean flush(K key, ValueHolder<V> valueHolder);\n \n   /**\n+   * Injects the {@link InvalidationValve} to be used by this {@code AuthoritativeTier}.\n+   * <P>\n+   *   The role of the invalidation valve is to provide a way for the {@code AuthoritativeTier} to force invalidation of\n+   *   {@link CachingTier} entries when that is required.\n+   * </P>\n+   *\n+   * @param valve the valve to use for triggering invalidations\n+   */\n+  void setInvalidationValve(InvalidationValve<K> valve);\n+\n+  /**\n+   * Invalidation valve, that is the mechanism through which an {@link AuthoritativeTier} can request invalidations\n+   * from the {@link CachingTier}.\n+   *\n+   * @param <K> the key type\n+   */\n+  interface InvalidationValve<K> {\n+\n+    /**\n+     * Requests an invalidation of all {@link CachingTier} mappings.","path":"core/src/main/java/org/ehcache/core/spi/store/tiering/AuthoritativeTier.java","position":23,"original_position":23,"commit_id":"caab97399841f2c38e0dde89a4188d77848d7fe6","original_commit_id":"f13fceeddc98f6279e9c220cf711b89282554736","user":{"login":"chrisdennis","id":954331,"avatar_url":"https://avatars.githubusercontent.com/u/954331?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdennis","html_url":"https://github.com/chrisdennis","followers_url":"https://api.github.com/users/chrisdennis/followers","following_url":"https://api.github.com/users/chrisdennis/following{/other_user}","gists_url":"https://api.github.com/users/chrisdennis/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdennis/subscriptions","organizations_url":"https://api.github.com/users/chrisdennis/orgs","repos_url":"https://api.github.com/users/chrisdennis/repos","events_url":"https://api.github.com/users/chrisdennis/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdennis/received_events","type":"User","site_admin":false},"body":"Is there a reason this is \"all mappings\"?  Would \"some\" mappings suffice?  Do we call this thing in some kind of loop or not?","created_at":"2016-05-13T20:12:02Z","updated_at":"2016-05-13T20:12:02Z","html_url":"https://github.com/ehcache/ehcache3/pull/1060#discussion_r63244135","pull_request_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060","_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/63244135"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/1060#discussion_r63244135"},"pull_request":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060"}}},"pull_request":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060","id":70049553,"html_url":"https://github.com/ehcache/ehcache3/pull/1060","diff_url":"https://github.com/ehcache/ehcache3/pull/1060.diff","patch_url":"https://github.com/ehcache/ehcache3/pull/1060.patch","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/1060","number":1060,"state":"open","locked":false,"title":"Issue #1030: InvalidationValve","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"body":"* InvalidationValve interface and wiring\r\n* Tests\r\n* Delete unused code","created_at":"2016-05-13T19:55:40Z","updated_at":"2016-05-13T20:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e93752c4bd649562fa0d4cd725811d7bf2a1c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060/commits","review_comments_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060/comments","review_comment_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/1060/comments","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/caab97399841f2c38e0dde89a4188d77848d7fe6","head":{"label":"ljacomet:issue-1030","ref":"issue-1030","sha":"caab97399841f2c38e0dde89a4188d77848d7fe6","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"repo":{"id":17280834,"name":"ehcache3","full_name":"ljacomet/ehcache3","owner":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljacomet/ehcache3","description":"","fork":true,"url":"https://api.github.com/repos/ljacomet/ehcache3","forks_url":"https://api.github.com/repos/ljacomet/ehcache3/forks","keys_url":"https://api.github.com/repos/ljacomet/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljacomet/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljacomet/ehcache3/teams","hooks_url":"https://api.github.com/repos/ljacomet/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ljacomet/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ljacomet/ehcache3/events","assignees_url":"https://api.github.com/repos/ljacomet/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ljacomet/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ljacomet/ehcache3/tags","blobs_url":"https://api.github.com/repos/ljacomet/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljacomet/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljacomet/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljacomet/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljacomet/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ljacomet/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ljacomet/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ljacomet/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ljacomet/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ljacomet/ehcache3/subscription","commits_url":"https://api.github.com/repos/ljacomet/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljacomet/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljacomet/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljacomet/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljacomet/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ljacomet/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljacomet/ehcache3/merges","archive_url":"https://api.github.com/repos/ljacomet/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljacomet/ehcache3/downloads","issues_url":"https://api.github.com/repos/ljacomet/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ljacomet/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ljacomet/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ljacomet/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljacomet/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ljacomet/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/ljacomet/ehcache3/deployments","created_at":"2014-02-28T09:03:27Z","updated_at":"2015-05-08T16:39:31Z","pushed_at":"2016-05-13T19:52:07Z","git_url":"git://github.com/ljacomet/ehcache3.git","ssh_url":"git@github.com:ljacomet/ehcache3.git","clone_url":"https://github.com/ljacomet/ehcache3.git","svn_url":"https://github.com/ljacomet/ehcache3","homepage":null,"size":9077,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehcache:master","ref":"master","sha":"a547228e20538be8de52da3057d838d90f4ae6fd","user":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"repo":{"id":17224514,"name":"ehcache3","full_name":"ehcache/ehcache3","owner":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ehcache/ehcache3","description":"Ehcache 3.x line ","fork":false,"url":"https://api.github.com/repos/ehcache/ehcache3","forks_url":"https://api.github.com/repos/ehcache/ehcache3/forks","keys_url":"https://api.github.com/repos/ehcache/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehcache/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehcache/ehcache3/teams","hooks_url":"https://api.github.com/repos/ehcache/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ehcache/ehcache3/events","assignees_url":"https://api.github.com/repos/ehcache/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ehcache/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ehcache/ehcache3/tags","blobs_url":"https://api.github.com/repos/ehcache/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehcache/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehcache/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehcache/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ehcache/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ehcache/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ehcache/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ehcache/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ehcache/ehcache3/subscription","commits_url":"https://api.github.com/repos/ehcache/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehcache/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehcache/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ehcache/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehcache/ehcache3/merges","archive_url":"https://api.github.com/repos/ehcache/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehcache/ehcache3/downloads","issues_url":"https://api.github.com/repos/ehcache/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ehcache/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ehcache/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ehcache/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehcache/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ehcache/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/ehcache/ehcache3/deployments","created_at":"2014-02-26T20:39:16Z","updated_at":"2016-05-12T01:35:32Z","pushed_at":"2016-05-13T19:56:52Z","git_url":"git://github.com/ehcache/ehcache3.git","ssh_url":"git@github.com:ehcache/ehcache3.git","clone_url":"https://github.com/ehcache/ehcache3.git","svn_url":"https://github.com/ehcache/ehcache3","homepage":"http://www.ehcache.org","size":11115,"stargazers_count":387,"watchers_count":387,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":201,"mirror_url":null,"open_issues_count":77,"forks":201,"open_issues":77,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/1060"},"issue":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/1060"},"comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/1060/comments"},"review_comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060/comments"},"review_comment":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1060/commits"},"statuses":{"href":"https://api.github.com/repos/ehcache/ehcache3/statuses/caab97399841f2c38e0dde89a4188d77848d7fe6"}}}}