{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/15337","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/15337/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/15337/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/15337/events","html_url":"https://github.com/rust-lang/rust/issues/15337","id":36990432,"number":15337,"title":"make check should suspend TIME_PASSES env var for pretty tests?","user":{"login":"jbclements","id":226617,"avatar_url":"https://avatars.githubusercontent.com/u/226617?v=3","gravatar_id":"","url":"https://api.github.com/users/jbclements","html_url":"https://github.com/jbclements","followers_url":"https://api.github.com/users/jbclements/followers","following_url":"https://api.github.com/users/jbclements/following{/other_user}","gists_url":"https://api.github.com/users/jbclements/gists{/gist_id}","starred_url":"https://api.github.com/users/jbclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbclements/subscriptions","organizations_url":"https://api.github.com/users/jbclements/orgs","repos_url":"https://api.github.com/users/jbclements/repos","events_url":"https://api.github.com/users/jbclements/events{/privacy}","received_events_url":"https://api.github.com/users/jbclements/received_events","type":"User","site_admin":false},"labels":[{"id":177808,"url":"https://api.github.com/repos/rust-lang/rust/labels/A-build","name":"A-build","color":"d7e102","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2014-07-02T14:59:16Z","updated_at":"2016-10-29T12:57:51Z","closed_at":null,"body":"It appears to me that running `make check` while there's an env var `TIME_PASSES` set to 1 causes all pretty-print tests to fail, because (it appears to me) the makefile passes `-Z time-passes` to the invocation of `rustc --pretty normal`, causing (e.g.) this failure:\n\n``` rust\n\n    task '[pretty] run-pass/writealias.rs' failed at 'explicit failure', /Users/clements/rust/src/compiletest/runtest.rs:1311\n\n\n---- [pretty] run-pass/x86stdcall.rs stdout ----\n\n    error: pretty-printing failed in round 1\n    status: exit code: 101\n    command: x86_64-apple-darwin/stage2/bin/rustc - --pretty normal --target=x86_64-apple-darwin -L x86_64-apple-darwin/test/run-pass/x86stdcall.stage2-x86_64-apple-darwin.libaux --cfg rtopt --cfg debug -Z time-passes -O -L x86_64-apple-darwin/rt\n    stdout:\n    ------------------------------------------\n\n    ------------------------------------------\n    stderr:\n    ------------------------------------------\n    <anon>:1:1: 1:5 error: expected item but found `time`\n    <anon>:1 time: 0.001 s  parsing\n             ^~~~\n\n    ------------------------------------------\n```\n\n... note that the parser is failing in trying to parse the line `time: 0.001 s  parsing`.. \n\nlooks like an easy fix in a makefile, if it's even worth fixing. Depends on how other folks feel about it.\n"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/257090276","html_url":"https://github.com/rust-lang/rust/issues/15337#issuecomment-257090276","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/15337","id":257090276,"user":{"login":"Mark-Simulacrum","id":5047365,"avatar_url":"https://avatars.githubusercontent.com/u/5047365?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-Simulacrum","html_url":"https://github.com/Mark-Simulacrum","followers_url":"https://api.github.com/users/Mark-Simulacrum/followers","following_url":"https://api.github.com/users/Mark-Simulacrum/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Simulacrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Simulacrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Simulacrum/subscriptions","organizations_url":"https://api.github.com/users/Mark-Simulacrum/orgs","repos_url":"https://api.github.com/users/Mark-Simulacrum/repos","events_url":"https://api.github.com/users/Mark-Simulacrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Simulacrum/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T12:57:51Z","updated_at":"2016-10-29T12:57:51Z","body":"#14607 is a more specific and likely easier/faster to reproduce."}}
{"actor":{"display_login":"Mark-Simulacrum"}}