{"action":"created","comment":{"url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/comments/66303861","id":66303861,"diff_hunk":"@@ -1315,7 +1315,7 @@ start_test Shutting down.\n fire_ab_load\n \n if $USE_VALGRIND; then\n-    kill -s quit $VALGRIND_PID\n+    kill -s TERM $VALGRIND_PID","path":"test/nginx_system_test.sh","position":33,"original_position":33,"commit_id":"9a382884aad876233258162eb86b048a0e6aaa75","original_commit_id":"9a382884aad876233258162eb86b048a0e6aaa75","user":{"login":"oschaaf","id":2239556,"avatar_url":"https://avatars.githubusercontent.com/u/2239556?v=3","gravatar_id":"","url":"https://api.github.com/users/oschaaf","html_url":"https://github.com/oschaaf","followers_url":"https://api.github.com/users/oschaaf/followers","following_url":"https://api.github.com/users/oschaaf/following{/other_user}","gists_url":"https://api.github.com/users/oschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/oschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oschaaf/subscriptions","organizations_url":"https://api.github.com/users/oschaaf/orgs","repos_url":"https://api.github.com/users/oschaaf/repos","events_url":"https://api.github.com/users/oschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/oschaaf/received_events","type":"User","site_admin":false},"body":"I think this switches us to a quick shutdown instead of a graceful one when testing a stressed shutdown under Valgrind. Is that intentional?","created_at":"2016-06-08T17:45:54Z","updated_at":"2016-06-08T17:45:54Z","html_url":"https://github.com/pagespeed/ngx_pagespeed/pull/1210#discussion_r66303861","pull_request_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210","_links":{"self":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/comments/66303861"},"html":{"href":"https://github.com/pagespeed/ngx_pagespeed/pull/1210#discussion_r66303861"},"pull_request":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210"}}},"pull_request":{"url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210","id":73081867,"html_url":"https://github.com/pagespeed/ngx_pagespeed/pull/1210","diff_url":"https://github.com/pagespeed/ngx_pagespeed/pull/1210.diff","patch_url":"https://github.com/pagespeed/ngx_pagespeed/pull/1210.patch","issue_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/1210","number":1210,"state":"open","locked":false,"title":"Suppress controller warnings in test, fix up kill signals","user":{"login":"hillsp","id":7683950,"avatar_url":"https://avatars.githubusercontent.com/u/7683950?v=3","gravatar_id":"","url":"https://api.github.com/users/hillsp","html_url":"https://github.com/hillsp","followers_url":"https://api.github.com/users/hillsp/followers","following_url":"https://api.github.com/users/hillsp/following{/other_user}","gists_url":"https://api.github.com/users/hillsp/gists{/gist_id}","starred_url":"https://api.github.com/users/hillsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hillsp/subscriptions","organizations_url":"https://api.github.com/users/hillsp/orgs","repos_url":"https://api.github.com/users/hillsp/repos","events_url":"https://api.github.com/users/hillsp/events{/privacy}","received_events_url":"https://api.github.com/users/hillsp/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-08T16:49:49Z","updated_at":"2016-06-08T17:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d385b20b246666be4a7282b42afbc94d624ace27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210/commits","review_comments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210/comments","review_comment_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/1210/comments","statuses_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/statuses/9a382884aad876233258162eb86b048a0e6aaa75","head":{"label":"pagespeed:cheesy-123590492","ref":"cheesy-123590492","sha":"9a382884aad876233258162eb86b048a0e6aaa75","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":4766638,"name":"ngx_pagespeed","full_name":"pagespeed/ngx_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/ngx_pagespeed","description":"Automatic PageSpeed optimization module for Nginx","fork":false,"url":"https://api.github.com/repos/pagespeed/ngx_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/releases{/id}","deployments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/deployments","created_at":"2012-06-23T18:30:14Z","updated_at":"2016-06-08T04:42:15Z","pushed_at":"2016-06-08T17:06:26Z","git_url":"git://github.com/pagespeed/ngx_pagespeed.git","ssh_url":"git@github.com:pagespeed/ngx_pagespeed.git","clone_url":"https://github.com/pagespeed/ngx_pagespeed.git","svn_url":"https://github.com/pagespeed/ngx_pagespeed","homepage":"http://ngxpagespeed.com/","size":44812,"stargazers_count":3049,"watchers_count":3049,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":187,"forks":227,"open_issues":187,"watchers":3049,"default_branch":"master"}},"base":{"label":"pagespeed:trunk-tracking","ref":"trunk-tracking","sha":"03d69e53b120d06572eb50e5a1caf98b0b069b48","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":4766638,"name":"ngx_pagespeed","full_name":"pagespeed/ngx_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/ngx_pagespeed","description":"Automatic PageSpeed optimization module for Nginx","fork":false,"url":"https://api.github.com/repos/pagespeed/ngx_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/releases{/id}","deployments_url":"https://api.github.com/repos/pagespeed/ngx_pagespeed/deployments","created_at":"2012-06-23T18:30:14Z","updated_at":"2016-06-08T04:42:15Z","pushed_at":"2016-06-08T17:06:26Z","git_url":"git://github.com/pagespeed/ngx_pagespeed.git","ssh_url":"git@github.com:pagespeed/ngx_pagespeed.git","clone_url":"https://github.com/pagespeed/ngx_pagespeed.git","svn_url":"https://github.com/pagespeed/ngx_pagespeed","homepage":"http://ngxpagespeed.com/","size":44812,"stargazers_count":3049,"watchers_count":3049,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":187,"forks":227,"open_issues":187,"watchers":3049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210"},"html":{"href":"https://github.com/pagespeed/ngx_pagespeed/pull/1210"},"issue":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/1210"},"comments":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/issues/1210/comments"},"review_comments":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210/comments"},"review_comment":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/pulls/1210/commits"},"statuses":{"href":"https://api.github.com/repos/pagespeed/ngx_pagespeed/statuses/9a382884aad876233258162eb86b048a0e6aaa75"}}}}
{"actor":{"display_login":"oschaaf"}}