{"action":"created","issue":{"url":"https://api.github.com/repos/hhzl/LearnWords2/issues/49","repository_url":"https://api.github.com/repos/hhzl/LearnWords2","labels_url":"https://api.github.com/repos/hhzl/LearnWords2/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/hhzl/LearnWords2/issues/49/comments","events_url":"https://api.github.com/repos/hhzl/LearnWords2/issues/49/events","html_url":"https://github.com/hhzl/LearnWords2/issues/49","id":191766802,"number":49,"title":"Is the open method actually the init method of LW1 LWdb?","user":{"login":"hhzl","id":1112023,"avatar_url":"https://avatars.githubusercontent.com/u/1112023?v=3","gravatar_id":"","url":"https://api.github.com/users/hhzl","html_url":"https://github.com/hhzl","followers_url":"https://api.github.com/users/hhzl/followers","following_url":"https://api.github.com/users/hhzl/following{/other_user}","gists_url":"https://api.github.com/users/hhzl/gists{/gist_id}","starred_url":"https://api.github.com/users/hhzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhzl/subscriptions","organizations_url":"https://api.github.com/users/hhzl/orgs","repos_url":"https://api.github.com/users/hhzl/repos","events_url":"https://api.github.com/users/hhzl/events{/privacy}","received_events_url":"https://api.github.com/users/hhzl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hhzl/LearnWords2/milestones/1","html_url":"https://github.com/hhzl/LearnWords2/milestones/release%200.1","labels_url":"https://api.github.com/repos/hhzl/LearnWords2/milestones/1/labels","id":2131074,"number":1,"title":"release 0.1","description":null,"creator":{"login":"hhzl","id":1112023,"avatar_url":"https://avatars.githubusercontent.com/u/1112023?v=3","gravatar_id":"","url":"https://api.github.com/users/hhzl","html_url":"https://github.com/hhzl","followers_url":"https://api.github.com/users/hhzl/followers","following_url":"https://api.github.com/users/hhzl/following{/other_user}","gists_url":"https://api.github.com/users/hhzl/gists{/gist_id}","starred_url":"https://api.github.com/users/hhzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhzl/subscriptions","organizations_url":"https://api.github.com/users/hhzl/orgs","repos_url":"https://api.github.com/users/hhzl/repos","events_url":"https://api.github.com/users/hhzl/events{/privacy}","received_events_url":"https://api.github.com/users/hhzl/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":23,"state":"open","created_at":"2016-11-12T15:48:58Z","updated_at":"2016-12-02T05:05:56Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-11-25T21:28:39Z","updated_at":"2016-12-03T03:13:02Z","closed_at":null,"body":"https://github.com/hhzl/LearnWords2/blob/JasmineInBrowser/src/LWdb.js#L187"},"comment":{"url":"https://api.github.com/repos/hhzl/LearnWords2/issues/comments/264612325","html_url":"https://github.com/hhzl/LearnWords2/issues/49#issuecomment-264612325","issue_url":"https://api.github.com/repos/hhzl/LearnWords2/issues/49","id":264612325,"user":{"login":"hhzl","id":1112023,"avatar_url":"https://avatars.githubusercontent.com/u/1112023?v=3","gravatar_id":"","url":"https://api.github.com/users/hhzl","html_url":"https://github.com/hhzl","followers_url":"https://api.github.com/users/hhzl/followers","following_url":"https://api.github.com/users/hhzl/following{/other_user}","gists_url":"https://api.github.com/users/hhzl/gists{/gist_id}","starred_url":"https://api.github.com/users/hhzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhzl/subscriptions","organizations_url":"https://api.github.com/users/hhzl/orgs","repos_url":"https://api.github.com/users/hhzl/repos","events_url":"https://api.github.com/users/hhzl/events{/privacy}","received_events_url":"https://api.github.com/users/hhzl/received_events","type":"User","site_admin":false},"created_at":"2016-12-03T03:13:02Z","updated_at":"2016-12-03T03:13:02Z","body":"**Answer point 1** is done in LW2\r\n\r\n````\r\nLWdb.prototype.persistentStorageOK = function() {\r\n        return !!localStorage;\r\n    };\r\n\r\n\r\n\r\n    LWdb.prototype.isOK = function() {\r\n        return this.persistentStorageOK();\r\n    };\r\n````\r\nNo need to implement it.\r\n\r\n**Answer point 2**\r\n\r\nIs done in the constructor function\r\n\r\n**Answer point 3**\r\n\r\nThe index is calculated in the function `keysOfAllWords` and cached. So no action is needed.\r\n\r\nConclusion: There is nothing to do for an open method at the moment.  Thus delete it.\r\n"}}
{"actor":{"display_login":"hhzl"}}