{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcompose/pulls/comments/72268535","id":72268535,"diff_hunk":"@@ -75,3 +75,23 @@ func (s *CliSuite) TestNamedVolume(c *C) {\n \tc.Assert(cn.Mounts[0].Name, DeepEquals, \"vol\")\n \tc.Assert(cn.Mounts[0].Destination, DeepEquals, \"/path\")\n }\n+\n+func (s *CliSuite) TestV2Volume(c *C) {","path":"integration/volume_test.go","position":5,"original_position":5,"commit_id":"187c3ce4d4b464dc077349cbb4999c04d521788c","original_commit_id":"187c3ce4d4b464dc077349cbb4999c04d521788c","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"I shoud complete this one to make sure `Bind` and/or `Mounts` uses `project_test` as the name for the volume 👼","created_at":"2016-07-26T15:07:36Z","updated_at":"2016-07-26T15:07:36Z","html_url":"https://github.com/docker/libcompose/pull/339#discussion_r72268535","pull_request_url":"https://api.github.com/repos/docker/libcompose/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/docker/libcompose/pulls/comments/72268535"},"html":{"href":"https://github.com/docker/libcompose/pull/339#discussion_r72268535"},"pull_request":{"href":"https://api.github.com/repos/docker/libcompose/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcompose/pulls/339","id":78868204,"html_url":"https://github.com/docker/libcompose/pull/339","diff_url":"https://github.com/docker/libcompose/pull/339.diff","patch_url":"https://github.com/docker/libcompose/pull/339.patch","issue_url":"https://api.github.com/repos/docker/libcompose/issues/339","number":339,"state":"open","locked":false,"title":" Add support to volume v2 🐡","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"This PR brings the first and main step to add support for volumes for v2 compose files 🐹. Thanks to @joshwget and @shouze 🐳\r\n\r\n- Introduce new `yaml.Volume{,s}` struct\r\n- Introduce new `docker/volume` package (like `network/volume`)\r\n\r\n- [ ] Make sure tests are a little bit complete (at least)\r\n\r\nThis closes #277\r\n\r\n/cc @joshwget \r\n\r\n🐸\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>","created_at":"2016-07-26T15:03:42Z","updated_at":"2016-07-26T15:07:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9272372a09c4999855ee6229bd1875fec8ef3230","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/libcompose/milestones/4","html_url":"https://github.com/docker/libcompose/milestones/0.3.0%20Admiring%20Murdock","labels_url":"https://api.github.com/repos/docker/libcompose/milestones/4/labels","id":1667694,"number":4,"title":"0.3.0 Admiring Murdock","description":"https://github.com/docker/libcompose/wiki/0.3.0-Milestone-Project-Page","creator":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":89,"state":"open","created_at":"2016-03-27T18:38:57Z","updated_at":"2016-07-26T15:03:42Z","due_on":"2016-07-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/libcompose/pulls/339/commits","review_comments_url":"https://api.github.com/repos/docker/libcompose/pulls/339/comments","review_comment_url":"https://api.github.com/repos/docker/libcompose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcompose/issues/339/comments","statuses_url":"https://api.github.com/repos/docker/libcompose/statuses/187c3ce4d4b464dc077349cbb4999c04d521788c","head":{"label":"vdemeester:v2-volumes","ref":"v2-volumes","sha":"187c3ce4d4b464dc077349cbb4999c04d521788c","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":40345435,"name":"libcompose","full_name":"vdemeester/libcompose","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/libcompose","description":" An experimental go library providing Compose-like functionality","fork":true,"url":"https://api.github.com/repos/vdemeester/libcompose","forks_url":"https://api.github.com/repos/vdemeester/libcompose/forks","keys_url":"https://api.github.com/repos/vdemeester/libcompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/libcompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/libcompose/teams","hooks_url":"https://api.github.com/repos/vdemeester/libcompose/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/libcompose/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/libcompose/events","assignees_url":"https://api.github.com/repos/vdemeester/libcompose/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/libcompose/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/libcompose/tags","blobs_url":"https://api.github.com/repos/vdemeester/libcompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/libcompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/libcompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/libcompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/libcompose/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/libcompose/languages","stargazers_url":"https://api.github.com/repos/vdemeester/libcompose/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/libcompose/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/libcompose/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/libcompose/subscription","commits_url":"https://api.github.com/repos/vdemeester/libcompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/libcompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/libcompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/libcompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/libcompose/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/libcompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/libcompose/merges","archive_url":"https://api.github.com/repos/vdemeester/libcompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/libcompose/downloads","issues_url":"https://api.github.com/repos/vdemeester/libcompose/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/libcompose/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/libcompose/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/libcompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/libcompose/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/libcompose/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/libcompose/deployments","created_at":"2015-08-07T06:44:24Z","updated_at":"2016-02-07T20:50:29Z","pushed_at":"2016-07-26T15:06:08Z","git_url":"git://github.com/vdemeester/libcompose.git","ssh_url":"git@github.com:vdemeester/libcompose.git","clone_url":"https://github.com/vdemeester/libcompose.git","svn_url":"https://github.com/vdemeester/libcompose","homepage":"https://godoc.org/github.com/docker/libcompose","size":3318,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e1a83f7bb6aee428e9d3d68302524c8f04791461","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":35969237,"name":"libcompose","full_name":"docker/libcompose","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcompose","description":"An experimental go library providing Compose-like functionality","fork":false,"url":"https://api.github.com/repos/docker/libcompose","forks_url":"https://api.github.com/repos/docker/libcompose/forks","keys_url":"https://api.github.com/repos/docker/libcompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcompose/teams","hooks_url":"https://api.github.com/repos/docker/libcompose/hooks","issue_events_url":"https://api.github.com/repos/docker/libcompose/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcompose/events","assignees_url":"https://api.github.com/repos/docker/libcompose/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcompose/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcompose/tags","blobs_url":"https://api.github.com/repos/docker/libcompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcompose/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcompose/languages","stargazers_url":"https://api.github.com/repos/docker/libcompose/stargazers","contributors_url":"https://api.github.com/repos/docker/libcompose/contributors","subscribers_url":"https://api.github.com/repos/docker/libcompose/subscribers","subscription_url":"https://api.github.com/repos/docker/libcompose/subscription","commits_url":"https://api.github.com/repos/docker/libcompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcompose/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcompose/merges","archive_url":"https://api.github.com/repos/docker/libcompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcompose/downloads","issues_url":"https://api.github.com/repos/docker/libcompose/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcompose/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcompose/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcompose/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcompose/releases{/id}","deployments_url":"https://api.github.com/repos/docker/libcompose/deployments","created_at":"2015-05-20T19:22:20Z","updated_at":"2016-07-26T02:03:36Z","pushed_at":"2016-07-26T15:06:09Z","git_url":"git://github.com/docker/libcompose.git","ssh_url":"git@github.com:docker/libcompose.git","clone_url":"https://github.com/docker/libcompose.git","svn_url":"https://github.com/docker/libcompose","homepage":"https://godoc.org/github.com/docker/libcompose","size":3474,"stargazers_count":334,"watchers_count":334,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":48,"forks":76,"open_issues":48,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcompose/pulls/339"},"html":{"href":"https://github.com/docker/libcompose/pull/339"},"issue":{"href":"https://api.github.com/repos/docker/libcompose/issues/339"},"comments":{"href":"https://api.github.com/repos/docker/libcompose/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcompose/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcompose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcompose/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcompose/statuses/187c3ce4d4b464dc077349cbb4999c04d521788c"}}}}
{"actor":{"display_login":"vdemeester"}}