{"action":"opened","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/9235","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/9235/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9235/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/9235/events","html_url":"https://github.com/openshift/origin/issues/9235","id":159273712,"number":9235,"title":"need to dump build logs on any extended test failure","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-08T21:13:11Z","updated_at":"2016-06-08T21:13:11Z","closed_at":null,"body":"Many of our extended tests wait for a build to succeed.  Some of them will dump the logs if that build fails, like this one:\r\nhttps://github.com/openshift/origin/blob/master/test/extended/builds/docker_pullsecret.go#L54-L57\r\n\r\nbut other ones don't.  Any place where we're doing a waitforabuild we should be dumping the logs on failure (unless the test is expecting the build to fail).\r\n\r\nwe also have another pattern in some places:\r\nhttps://github.com/openshift/origin/blob/master/test/extended/builds/no_outputname.go#L41-L46\r\n\r\nwe should change it, as was done in this PR:\r\nhttps://github.com/openshift/origin/pull/9186/files\r\n\r\nbecause the --wait --follow pattern is problematic if the build immediately fails, and we don't end up getting any logs.\r\n"}}
{"actor":{"display_login":"bparees"}}