{"action":"opened","issue":{"url":"https://api.github.com/repos/phetsims/unit-rates/issues/79","repository_url":"https://api.github.com/repos/phetsims/unit-rates","labels_url":"https://api.github.com/repos/phetsims/unit-rates/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/unit-rates/issues/79/comments","events_url":"https://api.github.com/repos/phetsims/unit-rates/issues/79/events","html_url":"https://github.com/phetsims/unit-rates/issues/79","id":180740341,"number":79,"title":"do a heap comparison","user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/unit-rates/labels/dev:code-review","name":"dev:code-review","color":"104E8B"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-03T20:36:59Z","updated_at":"2016-10-03T20:36:59Z","closed_at":null,"body":"Code review #52, checklist item:\r\n\r\n> Does a heap comparison using Chrome Developer Tools indicate a memory leak? (Describing this process is beyond the scope of this document.)\r\n\r\nIn implementation-notes.md, @schmitzware indicated:\r\n\r\n> - When profiling memory usage, if asserts are enabled the sim will leak memory because of the\r\nSUN/buttons/RectangularPushButton's being used. Apparently SUN buttons dispose fails when assertions are enabled, so the disposes are turned off if asserts are turned on (see sun/#212)\r\n> \r\n> - FuzzMouse memory testing seems to stabilize around 30Mb, though I have a sneaking suspicion a few URNumberLineMarkers are still not getting disposed of properly.\r\n\r\nSo it sounds like heap companions have been done, but more investigation may be needed.\r\n\r\nI'm not going to do this as part of code review, since I think that it makes sense only after the sim is feature complete (which it's not yet)."}}
{"actor":{"display_login":"pixelzoom"}}