{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16439","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16439/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16439/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16439/events","html_url":"https://github.com/mantidproject/mantid/pull/16439","id":156950243,"number":16439,"title":"16326 remove unused functions from application window","user":{"login":"lottiegreenwood","id":8983317,"avatar_url":"https://avatars.githubusercontent.com/u/8983317?v=3","gravatar_id":"","url":"https://api.github.com/users/lottiegreenwood","html_url":"https://github.com/lottiegreenwood","followers_url":"https://api.github.com/users/lottiegreenwood/followers","following_url":"https://api.github.com/users/lottiegreenwood/following{/other_user}","gists_url":"https://api.github.com/users/lottiegreenwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lottiegreenwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lottiegreenwood/subscriptions","organizations_url":"https://api.github.com/users/lottiegreenwood/orgs","repos_url":"https://api.github.com/users/lottiegreenwood/repos","events_url":"https://api.github.com/users/lottiegreenwood/events{/privacy}","received_events_url":"https://api.github.com/users/lottiegreenwood/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":559,"closed_issues":36,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-05-27T07:42:04Z","due_on":"2016-10-16T23:00:00Z","closed_at":null},"comments":4,"created_at":"2016-05-26T10:13:43Z","updated_at":"2016-05-27T07:50:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16439","html_url":"https://github.com/mantidproject/mantid/pull/16439","diff_url":"https://github.com/mantidproject/mantid/pull/16439.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16439.patch"},"body":"Removed code that had been commented out in ApplicationWindow, and some code that wasn't being called\r\n\r\n**To test:**\r\n\r\nReview code\r\n\r\nFixes #16326.\r\n\r\nDoes not need to be in the release notes.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/222082906","html_url":"https://github.com/mantidproject/mantid/pull/16439#issuecomment-222082906","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16439","id":222082906,"user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T07:50:22Z","updated_at":"2016-05-27T07:50:22Z","body":"I'm afraid this branch has developed a merge conflict, probably with the other many branches that have updated ApplicationWindow to remove Qt3Support warnings. Hopefully it's not a big one."}}
{"actor":{"display_login":"FedeMPouzols"}}