{"action":"created","issue":{"url":"https://api.github.com/repos/microprofile/microprofile-config/issues/1","repository_url":"https://api.github.com/repos/microprofile/microprofile-config","labels_url":"https://api.github.com/repos/microprofile/microprofile-config/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/microprofile/microprofile-config/issues/1/comments","events_url":"https://api.github.com/repos/microprofile/microprofile-config/issues/1/events","html_url":"https://github.com/microprofile/microprofile-config/pull/1","id":190188444,"number":1,"title":"Update based on Mark's comments","user":{"login":"Emily-Jiang","id":10999780,"avatar_url":"https://avatars.githubusercontent.com/u/10999780?v=3","gravatar_id":"","url":"https://api.github.com/users/Emily-Jiang","html_url":"https://github.com/Emily-Jiang","followers_url":"https://api.github.com/users/Emily-Jiang/followers","following_url":"https://api.github.com/users/Emily-Jiang/following{/other_user}","gists_url":"https://api.github.com/users/Emily-Jiang/gists{/gist_id}","starred_url":"https://api.github.com/users/Emily-Jiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emily-Jiang/subscriptions","organizations_url":"https://api.github.com/users/Emily-Jiang/orgs","repos_url":"https://api.github.com/users/Emily-Jiang/repos","events_url":"https://api.github.com/users/Emily-Jiang/events{/privacy}","received_events_url":"https://api.github.com/users/Emily-Jiang/received_events","type":"User","site_admin":false},"labels":[{"id":469391231,"url":"https://api.github.com/repos/microprofile/microprofile-config/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-17T22:54:49Z","updated_at":"2016-11-25T17:10:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/microprofile/microprofile-config/pulls/1","html_url":"https://github.com/microprofile/microprofile-config/pull/1","diff_url":"https://github.com/microprofile/microprofile-config/pull/1.diff","patch_url":"https://github.com/microprofile/microprofile-config/pull/1.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/microprofile/microprofile-config/issues/comments/262999734","html_url":"https://github.com/microprofile/microprofile-config/pull/1#issuecomment-262999734","issue_url":"https://api.github.com/repos/microprofile/microprofile-config/issues/1","id":262999734,"user":{"login":"struberg","id":79310,"avatar_url":"https://avatars.githubusercontent.com/u/79310?v=3","gravatar_id":"","url":"https://api.github.com/users/struberg","html_url":"https://github.com/struberg","followers_url":"https://api.github.com/users/struberg/followers","following_url":"https://api.github.com/users/struberg/following{/other_user}","gists_url":"https://api.github.com/users/struberg/gists{/gist_id}","starred_url":"https://api.github.com/users/struberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struberg/subscriptions","organizations_url":"https://api.github.com/users/struberg/orgs","repos_url":"https://api.github.com/users/struberg/repos","events_url":"https://api.github.com/users/struberg/events{/privacy}","received_events_url":"https://api.github.com/users/struberg/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T17:10:54Z","updated_at":"2016-11-25T17:10:54Z","body":"I remember this got discussed in Tamaya. \nI don't remember exactly why it got ditched but there have been solid reasons afair.\nWould need to lookup the archives.\n\nI think most of the times a configured value has to be present. And if you really need it you could still do a ofNullable.\n\nLieGrue,\nstrub\n\n\n> Am 25.11.2016 um 18:04 schrieb Viktor Klang (√) <notifications@github.com>:\n> \n> @viktorklang commented on this pull request.\n> \n> In src/main/java/io/microprofile/config/Config.java:\n> \n> > @@ -54,7 +50,7 @@\n>  \t * @param defaultValue the default value\n>  \t * @return the property value or the defult value if the property does not exist.\n>  \t */\n> -\t<T> T getProperty(String propertyName, Class<T> propertyType, T defaultValue);\n> +\t<T> T getPropertyValue(String propertyName, Class<T> propertyType, T defaultValue);\n> \n> Returning an Optional<T> would be more flexible and would allow to test for presence as well as provide for the default use-case as well as interoperate with all other code which deals with Optional. It would also make it less appealing to add defaults to the code (where they shouldn't be, in my experience).\n> \n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n\n"}}
{"actor":{"display_login":"struberg"}}