{"action":"created","issue":{"url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/138","repository_url":"https://api.github.com/repos/fau-fablab/FabLabKasse","labels_url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/138/comments","events_url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/138/events","html_url":"https://github.com/fau-fablab/FabLabKasse/pull/138","id":159435993,"number":138,"title":"Improve kassenbuch speed","user":{"login":"patkan","id":4189642,"avatar_url":"https://avatars.githubusercontent.com/u/4189642?v=3","gravatar_id":"","url":"https://api.github.com/users/patkan","html_url":"https://github.com/patkan","followers_url":"https://api.github.com/users/patkan/followers","following_url":"https://api.github.com/users/patkan/following{/other_user}","gists_url":"https://api.github.com/users/patkan/gists{/gist_id}","starred_url":"https://api.github.com/users/patkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patkan/subscriptions","organizations_url":"https://api.github.com/users/patkan/orgs","repos_url":"https://api.github.com/users/patkan/repos","events_url":"https://api.github.com/users/patkan/events{/privacy}","received_events_url":"https://api.github.com/users/patkan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fau-fablab/FabLabKasse/labels/needs-review","name":"needs-review","color":"f9d0c4"},{"url":"https://api.github.com/repos/fau-fablab/FabLabKasse/labels/ready-to-merge","name":"ready-to-merge","color":"c2e0c6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-06-09T15:23:39Z","updated_at":"2016-06-12T11:26:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fau-fablab/FabLabKasse/pulls/138","html_url":"https://github.com/fau-fablab/FabLabKasse/pull/138","diff_url":"https://github.com/fau-fablab/FabLabKasse/pull/138.diff","patch_url":"https://github.com/fau-fablab/FabLabKasse/pull/138.patch"},"body":"Nachdem der Julian von der Kassenbuch-Performance begeistert war, ich auch und überhaupt alle, haben @schrolli und ich uns hingesetzt und ein paar einfache Perfomance-Upgrades eingefrickelt :-)\r\n\r\nIch bitte um ein Review, da es auf der Datenbank rumschreibt :-P"},"comment":{"url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/comments/225427433","html_url":"https://github.com/fau-fablab/FabLabKasse/pull/138#issuecomment-225427433","issue_url":"https://api.github.com/repos/fau-fablab/FabLabKasse/issues/138","id":225427433,"user":{"login":"schrolli","id":2263484,"avatar_url":"https://avatars.githubusercontent.com/u/2263484?v=3","gravatar_id":"","url":"https://api.github.com/users/schrolli","html_url":"https://github.com/schrolli","followers_url":"https://api.github.com/users/schrolli/followers","following_url":"https://api.github.com/users/schrolli/following{/other_user}","gists_url":"https://api.github.com/users/schrolli/gists{/gist_id}","starred_url":"https://api.github.com/users/schrolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schrolli/subscriptions","organizations_url":"https://api.github.com/users/schrolli/orgs","repos_url":"https://api.github.com/users/schrolli/repos","events_url":"https://api.github.com/users/schrolli/events{/privacy}","received_events_url":"https://api.github.com/users/schrolli/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T11:26:23Z","updated_at":"2016-06-12T11:26:23Z","body":"in the meantime i have got a populated database to play with and have implemented the above mentioned query. it works fine in the sense of displaying the same results as the former object-crawl version. By this i got the execution time from 1.2s down to under 0.25s. I agree to the problems of summing up many float values. But when this is a mission-breaker, i would move away from sqlite to a more sophisticated database-engine like mysql/mariadb or postgres, that have decimal maths build in.\r\n\r\nTesting: I can imagine to provide a \"test database\" file with special values inserted and asserting against a preprocessed result. the values include some corner cases like a buchung with the exact datetime of an `--until` argument, where this buchung should not be included..."}}
{"actor":{"display_login":"schrolli"}}