{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5726","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5726/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5726/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5726/events","html_url":"https://github.com/Automattic/wp-calypso/pull/5726","id":157899961,"number":5726,"title":"Framework: Only render react server-side for logged-out users","user":{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Themes","name":"Themes","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/53","html_url":"https://github.com/Automattic/wp-calypso/milestones/Themes:%20Showcase%20M4-ThemeSheets","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/53/labels","id":1530833,"number":53,"title":"Themes: Showcase M4-ThemeSheets","description":"Implementing the single theme page with screenshots, description and support (if any).","creator":{"login":"folletto","id":4389,"avatar_url":"https://avatars.githubusercontent.com/u/4389?v=3","gravatar_id":"","url":"https://api.github.com/users/folletto","html_url":"https://github.com/folletto","followers_url":"https://api.github.com/users/folletto/followers","following_url":"https://api.github.com/users/folletto/following{/other_user}","gists_url":"https://api.github.com/users/folletto/gists{/gist_id}","starred_url":"https://api.github.com/users/folletto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folletto/subscriptions","organizations_url":"https://api.github.com/users/folletto/orgs","repos_url":"https://api.github.com/users/folletto/repos","events_url":"https://api.github.com/users/folletto/events{/privacy}","received_events_url":"https://api.github.com/users/folletto/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":84,"state":"open","created_at":"2016-01-21T11:26:19Z","updated_at":"2016-06-02T09:57:00Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-01T12:57:55Z","updated_at":"2016-06-02T10:27:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/5726","html_url":"https://github.com/Automattic/wp-calypso/pull/5726","diff_url":"https://github.com/Automattic/wp-calypso/pull/5726.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/5726.patch"},"body":"Fixes #5580.\r\n\r\nNo visual changes.\r\n\r\nAvoid filling the render cache with markup for every site slug, and avoid flash of english content for users with non-english locales.\r\n\r\nThis PR also removes the path from the render-cache key. Layout + state is unique for a rendered logged-out page. Using the request path as well only adds duplicate entries to the cache.\r\n\r\n**To Test**\r\nTricky, since dev mode thinks all users are logged out.\r\n* Test cache key change by trying a few theme urls, e.g.:\r\n\r\nhttp://calypso.localhost:3000/theme/twentysixteen/setup\r\nhttp://calypso.localhost:3000/theme/twentysixteen/support\r\nhttp://calypso.localhost:3000/theme/mood/support\r\n\r\nAll should show expected content\r\n\r\n**Note**\r\nThis change does not stop logged-in users going through the server middlewares for the /theme route, which means some requests will be delayed waiting for an API return (though this means that logged-in hits will keep the theme-details cache updated for logged-out hits)."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/223254020","html_url":"https://github.com/Automattic/wp-calypso/pull/5726#issuecomment-223254020","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5726","id":223254020,"user":{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T10:27:25Z","updated_at":"2016-06-02T10:27:25Z","body":"> Not sure I'm getting you right -- do you mean the fetchThemeDetailsData mw specifically? That bails early on server, before any API request is made...\r\n\r\nIt bails early on the client. The thing to note is that, for logged-in users, even though no markup will ever be rendered on the server, server-side data fetches will still happen as if a render were going to take place, then it will bail at the markup-cache stage because of `! context.user`, and render the empty jade template.\r\n\r\nSo we have unnecessary server-side data fetches, but they are cached for future logged-out requests."}}
{"actor":{"display_login":"seear"}}