{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/2","repository_url":"https://api.github.com/repos/cloudfoundry/jvmkill","labels_url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/2/comments","events_url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/2/events","html_url":"https://github.com/cloudfoundry/jvmkill/pull/2","id":150136310,"number":2,"title":"Heap histogram and dedicated parameters parsing code  ","user":{"login":"rafaelri","id":7011501,"avatar_url":"https://avatars.githubusercontent.com/u/7011501?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelri","html_url":"https://github.com/rafaelri","followers_url":"https://api.github.com/users/rafaelri/followers","following_url":"https://api.github.com/users/rafaelri/following{/other_user}","gists_url":"https://api.github.com/users/rafaelri/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelri/subscriptions","organizations_url":"https://api.github.com/users/rafaelri/orgs","repos_url":"https://api.github.com/users/rafaelri/repos","events_url":"https://api.github.com/users/rafaelri/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-04-21T17:12:16Z","updated_at":"2016-05-09T10:37:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/jvmkill/pulls/2","html_url":"https://github.com/cloudfoundry/jvmkill/pull/2","diff_url":"https://github.com/cloudfoundry/jvmkill/pull/2.diff","patch_url":"https://github.com/cloudfoundry/jvmkill/pull/2.patch"},"body":"This PR integrates polarbear heap histogram code into jvmkill agent. Apart from this, the code for parsing agent parameters has been moved to a new ParametersParser class that creates AgentParameters structs from agent command line parameters. Also there were changes to the jvmkill.c++ in order to extract the logic that mediated the OOM events between the Heuristics implementation and the registered actions this resulted in the new class AgentController that aims to hold all this responsibility and also to make tests easier, turning jvmkill.c++ in a simple \"glue\" between the JVM and our agent."},"comment":{"url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/comments/217831434","html_url":"https://github.com/cloudfoundry/jvmkill/pull/2#issuecomment-217831434","issue_url":"https://api.github.com/repos/cloudfoundry/jvmkill/issues/2","id":217831434,"user":{"login":"glyn","id":94953,"avatar_url":"https://avatars.githubusercontent.com/u/94953?v=3","gravatar_id":"","url":"https://api.github.com/users/glyn","html_url":"https://github.com/glyn","followers_url":"https://api.github.com/users/glyn/followers","following_url":"https://api.github.com/users/glyn/following{/other_user}","gists_url":"https://api.github.com/users/glyn/gists{/gist_id}","starred_url":"https://api.github.com/users/glyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyn/subscriptions","organizations_url":"https://api.github.com/users/glyn/orgs","repos_url":"https://api.github.com/users/glyn/repos","events_url":"https://api.github.com/users/glyn/events{/privacy}","received_events_url":"https://api.github.com/users/glyn/received_events","type":"User","site_admin":false},"created_at":"2016-05-09T10:37:42Z","updated_at":"2016-05-09T10:37:42Z","body":"@rafaelri ok. I think agentcontroller.c++ might need a bit of rework too, e.g. to enable setSignal to be passed down (but only to the kill action?!)."}}