{"action":"closed","number":1328,"pull_request":{"url":"https://api.github.com/repos/lxc/lxc/pulls/1328","id":95391187,"html_url":"https://github.com/lxc/lxc/pull/1328","diff_url":"https://github.com/lxc/lxc/pull/1328.diff","patch_url":"https://github.com/lxc/lxc/pull/1328.patch","issue_url":"https://api.github.com/repos/lxc/lxc/issues/1328","number":1328,"state":"closed","locked":false,"title":"conf: remove thread-unsafe strsignal + improve log","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"The thread-unsafe functions strsignal() is called in run_buffer() which in turn\r\nis called in run_buffer_argv() which is responsible for running __all__ lxc\r\nhooks. This is pretty dangerous for multi-threaded users like LXD.\r\n\r\nSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>","created_at":"2016-11-27T03:47:13Z","updated_at":"2016-11-27T05:10:53Z","closed_at":"2016-11-27T05:10:53Z","merged_at":"2016-11-27T05:10:53Z","merge_commit_sha":"d0f03fd75254ad1ab9428adbe61206895da3c410","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxc/pulls/1328/commits","review_comments_url":"https://api.github.com/repos/lxc/lxc/pulls/1328/comments","review_comment_url":"https://api.github.com/repos/lxc/lxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxc/issues/1328/comments","statuses_url":"https://api.github.com/repos/lxc/lxc/statuses/062b72c6b981d735d9642addad7e82cb68c05d8f","head":{"label":"brauner:2016-11-27/make_running_hooks_async_signal_safe","ref":"2016-11-27/make_running_hooks_async_signal_safe","sha":"062b72c6b981d735d9642addad7e82cb68c05d8f","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"repo":{"id":34560469,"name":"lxc","full_name":"brauner/lxc","owner":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brauner/lxc","description":"LXC - Linux Containers","fork":true,"url":"https://api.github.com/repos/brauner/lxc","forks_url":"https://api.github.com/repos/brauner/lxc/forks","keys_url":"https://api.github.com/repos/brauner/lxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brauner/lxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brauner/lxc/teams","hooks_url":"https://api.github.com/repos/brauner/lxc/hooks","issue_events_url":"https://api.github.com/repos/brauner/lxc/issues/events{/number}","events_url":"https://api.github.com/repos/brauner/lxc/events","assignees_url":"https://api.github.com/repos/brauner/lxc/assignees{/user}","branches_url":"https://api.github.com/repos/brauner/lxc/branches{/branch}","tags_url":"https://api.github.com/repos/brauner/lxc/tags","blobs_url":"https://api.github.com/repos/brauner/lxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brauner/lxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brauner/lxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/brauner/lxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brauner/lxc/statuses/{sha}","languages_url":"https://api.github.com/repos/brauner/lxc/languages","stargazers_url":"https://api.github.com/repos/brauner/lxc/stargazers","contributors_url":"https://api.github.com/repos/brauner/lxc/contributors","subscribers_url":"https://api.github.com/repos/brauner/lxc/subscribers","subscription_url":"https://api.github.com/repos/brauner/lxc/subscription","commits_url":"https://api.github.com/repos/brauner/lxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/brauner/lxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/brauner/lxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/brauner/lxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/brauner/lxc/contents/{+path}","compare_url":"https://api.github.com/repos/brauner/lxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brauner/lxc/merges","archive_url":"https://api.github.com/repos/brauner/lxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brauner/lxc/downloads","issues_url":"https://api.github.com/repos/brauner/lxc/issues{/number}","pulls_url":"https://api.github.com/repos/brauner/lxc/pulls{/number}","milestones_url":"https://api.github.com/repos/brauner/lxc/milestones{/number}","notifications_url":"https://api.github.com/repos/brauner/lxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brauner/lxc/labels{/name}","releases_url":"https://api.github.com/repos/brauner/lxc/releases{/id}","deployments_url":"https://api.github.com/repos/brauner/lxc/deployments","created_at":"2015-04-25T08:02:11Z","updated_at":"2016-02-10T12:26:23Z","pushed_at":"2016-11-27T05:02:05Z","git_url":"git://github.com/brauner/lxc.git","ssh_url":"git@github.com:brauner/lxc.git","clone_url":"https://github.com/brauner/lxc.git","svn_url":"https://github.com/brauner/lxc","homepage":"https://linuxcontainers.org","size":12636,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"8d58eea994be73f97e7e739fc13164aa694ed94d","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":5720995,"name":"lxc","full_name":"lxc/lxc","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxc","description":"LXC - Linux Containers","fork":false,"url":"https://api.github.com/repos/lxc/lxc","forks_url":"https://api.github.com/repos/lxc/lxc/forks","keys_url":"https://api.github.com/repos/lxc/lxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxc/teams","hooks_url":"https://api.github.com/repos/lxc/lxc/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxc/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxc/events","assignees_url":"https://api.github.com/repos/lxc/lxc/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxc/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxc/tags","blobs_url":"https://api.github.com/repos/lxc/lxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxc/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxc/languages","stargazers_url":"https://api.github.com/repos/lxc/lxc/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxc/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxc/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxc/subscription","commits_url":"https://api.github.com/repos/lxc/lxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxc/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxc/merges","archive_url":"https://api.github.com/repos/lxc/lxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxc/downloads","issues_url":"https://api.github.com/repos/lxc/lxc/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxc/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxc/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxc/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxc/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxc/deployments","created_at":"2012-09-07T18:50:27Z","updated_at":"2016-11-26T09:54:41Z","pushed_at":"2016-11-27T05:10:53Z","git_url":"git://github.com/lxc/lxc.git","ssh_url":"git@github.com:lxc/lxc.git","clone_url":"https://github.com/lxc/lxc.git","svn_url":"https://github.com/lxc/lxc","homepage":"https://linuxcontainers.org/lxc","size":15675,"stargazers_count":1584,"watchers_count":1584,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":559,"mirror_url":null,"open_issues_count":177,"forks":559,"open_issues":177,"watchers":1584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1328"},"html":{"href":"https://github.com/lxc/lxc/pull/1328"},"issue":{"href":"https://api.github.com/repos/lxc/lxc/issues/1328"},"comments":{"href":"https://api.github.com/repos/lxc/lxc/issues/1328/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1328/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1328/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxc/statuses/062b72c6b981d735d9642addad7e82cb68c05d8f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":26,"changed_files":1}}
{"actor":{"display_login":"stgraber"}}