{"action":"opened","number":54,"pull_request":{"url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54","id":94150321,"html_url":"https://github.com/PopulateTools/gobierto-dev/pull/54","diff_url":"https://github.com/PopulateTools/gobierto-dev/pull/54.diff","patch_url":"https://github.com/PopulateTools/gobierto-dev/pull/54.patch","issue_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/54","number":54,"state":"open","locked":false,"title":"User management within the the Admin namespace","user":{"login":"danguita","id":126392,"avatar_url":"https://avatars.githubusercontent.com/u/126392?v=3","gravatar_id":"","url":"https://api.github.com/users/danguita","html_url":"https://github.com/danguita","followers_url":"https://api.github.com/users/danguita/followers","following_url":"https://api.github.com/users/danguita/following{/other_user}","gists_url":"https://api.github.com/users/danguita/gists{/gist_id}","starred_url":"https://api.github.com/users/danguita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danguita/subscriptions","organizations_url":"https://api.github.com/users/danguita/orgs","repos_url":"https://api.github.com/users/danguita/repos","events_url":"https://api.github.com/users/danguita/events{/privacy}","received_events_url":"https://api.github.com/users/danguita/received_events","type":"User","site_admin":false},"body":"This PR implements #32. \r\n\r\n### Before reviewing\r\n\r\nThis PR strongly depends on #53, so let's get it fully merged before checking this out.\r\n\r\n### What does this PR do?\r\n\r\nThis PR pretends to implement all User management features through the Admin UI.\r\n\r\nThose features are:\r\n\r\n- List Users\r\n- Edit User\r\n- View User details\r\n- Change User password\r\n- Resend Welcome email\r\n- Resend Confirmation instructions, when email changes\r\n\r\nRegarding technical stuff, both Admin and User implementations have been normalized in terms of code and architecture. The test coverage in both namespaces has been increased as well.\r\n\r\n### How should this be manually tested?\r\n\r\nThis PR is pretty large as well, so let's split it into smaller entry points:\r\n\r\n#### List Users\r\n\r\nStarting from http://gobierto.dev/admin/users, just check that data are displayed correctly, and every single row links to the corresponding Edit and Show actions.\r\n\r\n#### Edit User\r\n\r\nFrom the Edit view (`http://gobierto.dev/admin/users/<user_id>/edit`), check that only `name` and `email` fields are editable, and there are links for changing password and resending the welcome email.\r\n\r\n#### Resend confirmation instructions\r\n\r\nBeing in the same view (`http://gobierto.dev/admin/users/<user_id>/edit`), the welcome email should be delivered by hitting the \"Resend welcome email\" button.\r\n\r\n#### Change User password\r\n\r\nRight in `http://gobierto.dev/admin/users/<user_id>/passwords/new` (also reachable from the Edit view), check the user password is actually changed.\r\n\r\n#### Admin management normalization\r\n\r\nThe UI between Admin and User management has been normalized as well. Check it out at http://gobierto.dev/admin/admins.","created_at":"2016-11-17T11:35:10Z","updated_at":"2016-11-17T11:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54/commits","review_comments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54/comments","review_comment_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/54/comments","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/statuses/6d2e7d079fe137fb950842fdfc196a342e238973","head":{"label":"PopulateTools:32-admin-users-management","ref":"32-admin-users-management","sha":"6d2e7d079fe137fb950842fdfc196a342e238973","user":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars.githubusercontent.com/u/12809868?v=3","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"repo":{"id":71801692,"name":"gobierto-dev","full_name":"PopulateTools/gobierto-dev","owner":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars.githubusercontent.com/u/12809868?v=3","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PopulateTools/gobierto-dev","description":"Herramienta para facilitar la transparencia y la participación ciudadana (WIP)","fork":false,"url":"https://api.github.com/repos/PopulateTools/gobierto-dev","forks_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/forks","keys_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/teams","hooks_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/hooks","issue_events_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/events{/number}","events_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/events","assignees_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/assignees{/user}","branches_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/branches{/branch}","tags_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/tags","blobs_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/languages","stargazers_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/stargazers","contributors_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/contributors","subscribers_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/subscribers","subscription_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/subscription","commits_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/contents/{+path}","compare_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/merges","archive_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/downloads","issues_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues{/number}","pulls_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/labels{/name}","releases_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/releases{/id}","deployments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/deployments","created_at":"2016-10-24T15:13:26Z","updated_at":"2016-11-16T10:26:41Z","pushed_at":"2016-11-17T11:13:33Z","git_url":"git://github.com/PopulateTools/gobierto-dev.git","ssh_url":"git@github.com:PopulateTools/gobierto-dev.git","clone_url":"https://github.com/PopulateTools/gobierto-dev.git","svn_url":"https://github.com/PopulateTools/gobierto-dev","homepage":"","size":2768,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"PopulateTools:master","ref":"master","sha":"e4caecf2ad0560c43139105e5da67249faeeef40","user":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars.githubusercontent.com/u/12809868?v=3","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"repo":{"id":71801692,"name":"gobierto-dev","full_name":"PopulateTools/gobierto-dev","owner":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars.githubusercontent.com/u/12809868?v=3","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PopulateTools/gobierto-dev","description":"Herramienta para facilitar la transparencia y la participación ciudadana (WIP)","fork":false,"url":"https://api.github.com/repos/PopulateTools/gobierto-dev","forks_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/forks","keys_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/teams","hooks_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/hooks","issue_events_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/events{/number}","events_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/events","assignees_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/assignees{/user}","branches_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/branches{/branch}","tags_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/tags","blobs_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/languages","stargazers_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/stargazers","contributors_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/contributors","subscribers_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/subscribers","subscription_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/subscription","commits_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/contents/{+path}","compare_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/merges","archive_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/downloads","issues_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues{/number}","pulls_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/labels{/name}","releases_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/releases{/id}","deployments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/deployments","created_at":"2016-10-24T15:13:26Z","updated_at":"2016-11-16T10:26:41Z","pushed_at":"2016-11-17T11:13:33Z","git_url":"git://github.com/PopulateTools/gobierto-dev.git","ssh_url":"git@github.com:PopulateTools/gobierto-dev.git","clone_url":"https://github.com/PopulateTools/gobierto-dev.git","svn_url":"https://github.com/PopulateTools/gobierto-dev","homepage":"","size":2768,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54"},"html":{"href":"https://github.com/PopulateTools/gobierto-dev/pull/54"},"issue":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/54"},"comments":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/PopulateTools/gobierto-dev/statuses/6d2e7d079fe137fb950842fdfc196a342e238973"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":2146,"deletions":48,"changed_files":104}}
{"actor":{"display_login":"danguita"}}