{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/ello/webapp/pulls/11","id":86153526,"html_url":"https://github.com/ello/webapp/pull/11","diff_url":"https://github.com/ello/webapp/pull/11.diff","patch_url":"https://github.com/ello/webapp/pull/11.patch","issue_url":"https://api.github.com/repos/ello/webapp/issues/11","number":11,"state":"closed","locked":false,"title":"Fix settings layout and misc. cleanup","user":{"login":"mkitt","id":78967,"avatar_url":"https://avatars.githubusercontent.com/u/78967?v=3","gravatar_id":"","url":"https://api.github.com/users/mkitt","html_url":"https://github.com/mkitt","followers_url":"https://api.github.com/users/mkitt/followers","following_url":"https://api.github.com/users/mkitt/following{/other_user}","gists_url":"https://api.github.com/users/mkitt/gists{/gist_id}","starred_url":"https://api.github.com/users/mkitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkitt/subscriptions","organizations_url":"https://api.github.com/users/mkitt/orgs","repos_url":"https://api.github.com/users/mkitt/repos","events_url":"https://api.github.com/users/mkitt/events{/privacy}","received_events_url":"https://api.github.com/users/mkitt/received_events","type":"User","site_admin":false},"body":"With all the updates to covers and scrolling this was the path to least resistance in fixing the settings layout. Settings is now similar to the on-boarding experience. This will also help us move to managing multiple images when carousels show up. \r\n\r\nI removed the `CoverMini` since it is actively being replaced by the `BackgroundImage` component (`Cover` will also be removed shortly). Eventually I'd like to move the settings and on-boarding `BackgroundImage` and `Uploader` into the `Hero` container (same with on-boarding's broadcast message). \r\n\r\nFound a few random layout issues that were updated as well:\r\n\r\n- [x] Removed some dead code from `Avatar`\r\n- [x] Fix an overflow issue on `Promotions`\r\n- [x] Fix mismatched media query for on-boarding in the `InfoForm`\r\n- [x] Rename `FakeCover` to `HeroImage`\r\n- [x] Hide the `Footer` while requesting the next page (`isPaginatoring`)\r\n\r\n📻 ","created_at":"2016-09-21T12:34:54Z","updated_at":"2016-09-21T15:55:49Z","closed_at":"2016-09-21T15:55:49Z","merged_at":"2016-09-21T15:55:49Z","merge_commit_sha":"e1ede79ceefadb10eec79ebc6a9236ba71b5a25a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ello/webapp/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ello/webapp/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ello/webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ello/webapp/issues/11/comments","statuses_url":"https://api.github.com/repos/ello/webapp/statuses/6ba6abcfe2d0c371e27fc9cae615d3e66b682430","head":{"label":"ello:mk/fix/settings","ref":"mk/fix/settings","sha":"6ba6abcfe2d0c371e27fc9cae615d3e66b682430","user":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"repo":{"id":68226310,"name":"webapp","full_name":"ello/webapp","owner":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ello/webapp","description":"The web front end for ello.co","fork":false,"url":"https://api.github.com/repos/ello/webapp","forks_url":"https://api.github.com/repos/ello/webapp/forks","keys_url":"https://api.github.com/repos/ello/webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ello/webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ello/webapp/teams","hooks_url":"https://api.github.com/repos/ello/webapp/hooks","issue_events_url":"https://api.github.com/repos/ello/webapp/issues/events{/number}","events_url":"https://api.github.com/repos/ello/webapp/events","assignees_url":"https://api.github.com/repos/ello/webapp/assignees{/user}","branches_url":"https://api.github.com/repos/ello/webapp/branches{/branch}","tags_url":"https://api.github.com/repos/ello/webapp/tags","blobs_url":"https://api.github.com/repos/ello/webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ello/webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ello/webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ello/webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ello/webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/ello/webapp/languages","stargazers_url":"https://api.github.com/repos/ello/webapp/stargazers","contributors_url":"https://api.github.com/repos/ello/webapp/contributors","subscribers_url":"https://api.github.com/repos/ello/webapp/subscribers","subscription_url":"https://api.github.com/repos/ello/webapp/subscription","commits_url":"https://api.github.com/repos/ello/webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ello/webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ello/webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ello/webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ello/webapp/contents/{+path}","compare_url":"https://api.github.com/repos/ello/webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ello/webapp/merges","archive_url":"https://api.github.com/repos/ello/webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ello/webapp/downloads","issues_url":"https://api.github.com/repos/ello/webapp/issues{/number}","pulls_url":"https://api.github.com/repos/ello/webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/ello/webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/ello/webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ello/webapp/labels{/name}","releases_url":"https://api.github.com/repos/ello/webapp/releases{/id}","deployments_url":"https://api.github.com/repos/ello/webapp/deployments","created_at":"2016-09-14T17:07:03Z","updated_at":"2016-09-20T19:38:31Z","pushed_at":"2016-09-21T15:55:50Z","git_url":"git://github.com/ello/webapp.git","ssh_url":"git@github.com:ello/webapp.git","clone_url":"https://github.com/ello/webapp.git","svn_url":"https://github.com/ello/webapp","homepage":"ello.co","size":5239,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":13,"default_branch":"master"}},"base":{"label":"ello:epic/profiles-v2","ref":"epic/profiles-v2","sha":"e617fb094877a6cc2b9b3275016892888ca0d5ff","user":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"repo":{"id":68226310,"name":"webapp","full_name":"ello/webapp","owner":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ello/webapp","description":"The web front end for ello.co","fork":false,"url":"https://api.github.com/repos/ello/webapp","forks_url":"https://api.github.com/repos/ello/webapp/forks","keys_url":"https://api.github.com/repos/ello/webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ello/webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ello/webapp/teams","hooks_url":"https://api.github.com/repos/ello/webapp/hooks","issue_events_url":"https://api.github.com/repos/ello/webapp/issues/events{/number}","events_url":"https://api.github.com/repos/ello/webapp/events","assignees_url":"https://api.github.com/repos/ello/webapp/assignees{/user}","branches_url":"https://api.github.com/repos/ello/webapp/branches{/branch}","tags_url":"https://api.github.com/repos/ello/webapp/tags","blobs_url":"https://api.github.com/repos/ello/webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ello/webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ello/webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ello/webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ello/webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/ello/webapp/languages","stargazers_url":"https://api.github.com/repos/ello/webapp/stargazers","contributors_url":"https://api.github.com/repos/ello/webapp/contributors","subscribers_url":"https://api.github.com/repos/ello/webapp/subscribers","subscription_url":"https://api.github.com/repos/ello/webapp/subscription","commits_url":"https://api.github.com/repos/ello/webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ello/webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ello/webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ello/webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ello/webapp/contents/{+path}","compare_url":"https://api.github.com/repos/ello/webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ello/webapp/merges","archive_url":"https://api.github.com/repos/ello/webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ello/webapp/downloads","issues_url":"https://api.github.com/repos/ello/webapp/issues{/number}","pulls_url":"https://api.github.com/repos/ello/webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/ello/webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/ello/webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ello/webapp/labels{/name}","releases_url":"https://api.github.com/repos/ello/webapp/releases{/id}","deployments_url":"https://api.github.com/repos/ello/webapp/deployments","created_at":"2016-09-14T17:07:03Z","updated_at":"2016-09-20T19:38:31Z","pushed_at":"2016-09-21T15:55:50Z","git_url":"git://github.com/ello/webapp.git","ssh_url":"git@github.com:ello/webapp.git","clone_url":"https://github.com/ello/webapp.git","svn_url":"https://github.com/ello/webapp","homepage":"ello.co","size":5239,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ello/webapp/pulls/11"},"html":{"href":"https://github.com/ello/webapp/pull/11"},"issue":{"href":"https://api.github.com/repos/ello/webapp/issues/11"},"comments":{"href":"https://api.github.com/repos/ello/webapp/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ello/webapp/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ello/webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ello/webapp/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ello/webapp/statuses/6ba6abcfe2d0c371e27fc9cae615d3e66b682430"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mkitt","id":78967,"avatar_url":"https://avatars.githubusercontent.com/u/78967?v=3","gravatar_id":"","url":"https://api.github.com/users/mkitt","html_url":"https://github.com/mkitt","followers_url":"https://api.github.com/users/mkitt/followers","following_url":"https://api.github.com/users/mkitt/following{/other_user}","gists_url":"https://api.github.com/users/mkitt/gists{/gist_id}","starred_url":"https://api.github.com/users/mkitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkitt/subscriptions","organizations_url":"https://api.github.com/users/mkitt/orgs","repos_url":"https://api.github.com/users/mkitt/repos","events_url":"https://api.github.com/users/mkitt/events{/privacy}","received_events_url":"https://api.github.com/users/mkitt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":60,"deletions":247,"changed_files":18}}
{"actor":{"display_login":"mkitt"}}