{"action":"closed","number":6795,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795","id":67296550,"html_url":"https://github.com/rapid7/metasploit-framework/pull/6795","diff_url":"https://github.com/rapid7/metasploit-framework/pull/6795.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/6795.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6795","number":6795,"state":"closed","locked":false,"title":"File.exists? must die","user":{"login":"bcook-r7","id":10031469,"avatar_url":"https://avatars.githubusercontent.com/u/10031469?v=3","gravatar_id":"","url":"https://api.github.com/users/bcook-r7","html_url":"https://github.com/bcook-r7","followers_url":"https://api.github.com/users/bcook-r7/followers","following_url":"https://api.github.com/users/bcook-r7/following{/other_user}","gists_url":"https://api.github.com/users/bcook-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bcook-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcook-r7/subscriptions","organizations_url":"https://api.github.com/users/bcook-r7/orgs","repos_url":"https://api.github.com/users/bcook-r7/repos","events_url":"https://api.github.com/users/bcook-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bcook-r7/received_events","type":"User","site_admin":false},"body":"This removes the deprecated calls to File.exists? in favor of File.exist?, the lowest of low-hanging fruit from running 'ruby -w'\r\n\r\n## Verification\r\n\r\n- [ ] Start `msfconsole` with 'ruby -w ./msfconsole'\r\n- [ ] **Verify** the warnings about File.exists? do not appear","created_at":"2016-04-21T04:49:02Z","updated_at":"2016-04-21T16:55:33Z","closed_at":"2016-04-21T16:55:33Z","merged_at":"2016-04-21T16:55:33Z","merge_commit_sha":"e75ce8b248f80d49954746696ed2c8cb0794f691","assignee":{"login":"tdoan-r7","id":1195616,"avatar_url":"https://avatars.githubusercontent.com/u/1195616?v=3","gravatar_id":"","url":"https://api.github.com/users/tdoan-r7","html_url":"https://github.com/tdoan-r7","followers_url":"https://api.github.com/users/tdoan-r7/followers","following_url":"https://api.github.com/users/tdoan-r7/following{/other_user}","gists_url":"https://api.github.com/users/tdoan-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tdoan-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdoan-r7/subscriptions","organizations_url":"https://api.github.com/users/tdoan-r7/orgs","repos_url":"https://api.github.com/users/tdoan-r7/repos","events_url":"https://api.github.com/users/tdoan-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tdoan-r7/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6795/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/e75ce8b248f80d49954746696ed2c8cb0794f691","head":{"label":"bcook-r7:fix-exists","ref":"fix-exists","sha":"e75ce8b248f80d49954746696ed2c8cb0794f691","user":{"login":"bcook-r7","id":10031469,"avatar_url":"https://avatars.githubusercontent.com/u/10031469?v=3","gravatar_id":"","url":"https://api.github.com/users/bcook-r7","html_url":"https://github.com/bcook-r7","followers_url":"https://api.github.com/users/bcook-r7/followers","following_url":"https://api.github.com/users/bcook-r7/following{/other_user}","gists_url":"https://api.github.com/users/bcook-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bcook-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcook-r7/subscriptions","organizations_url":"https://api.github.com/users/bcook-r7/orgs","repos_url":"https://api.github.com/users/bcook-r7/repos","events_url":"https://api.github.com/users/bcook-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bcook-r7/received_events","type":"User","site_admin":false},"repo":{"id":27561397,"name":"metasploit-framework","full_name":"bcook-r7/metasploit-framework","owner":{"login":"bcook-r7","id":10031469,"avatar_url":"https://avatars.githubusercontent.com/u/10031469?v=3","gravatar_id":"","url":"https://api.github.com/users/bcook-r7","html_url":"https://github.com/bcook-r7","followers_url":"https://api.github.com/users/bcook-r7/followers","following_url":"https://api.github.com/users/bcook-r7/following{/other_user}","gists_url":"https://api.github.com/users/bcook-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bcook-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcook-r7/subscriptions","organizations_url":"https://api.github.com/users/bcook-r7/orgs","repos_url":"https://api.github.com/users/bcook-r7/repos","events_url":"https://api.github.com/users/bcook-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bcook-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcook-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/bcook-r7/metasploit-framework","forks_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/bcook-r7/metasploit-framework/deployments","created_at":"2014-12-04T21:42:14Z","updated_at":"2016-01-23T07:29:42Z","pushed_at":"2016-04-21T10:57:01Z","git_url":"git://github.com/bcook-r7/metasploit-framework.git","ssh_url":"git@github.com:bcook-r7/metasploit-framework.git","clone_url":"https://github.com/bcook-r7/metasploit-framework.git","svn_url":"https://github.com/bcook-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":289191,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"6b3326eab2c3c841c95bc5cbd03901408528a869","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"name":"metasploit-framework","full_name":"rapid7/metasploit-framework","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/metasploit-framework/deployments","created_at":"2011-08-30T06:13:20Z","updated_at":"2016-04-21T13:04:21Z","pushed_at":"2016-04-21T16:55:23Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"http://www.metasploit.com/","size":472972,"stargazers_count":5590,"watchers_count":5590,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3912,"mirror_url":null,"open_issues_count":267,"forks":3912,"open_issues":267,"watchers":5590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/6795"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6795"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6795/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6795/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/e75ce8b248f80d49954746696ed2c8cb0794f691"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tdoan-r7","id":1195616,"avatar_url":"https://avatars.githubusercontent.com/u/1195616?v=3","gravatar_id":"","url":"https://api.github.com/users/tdoan-r7","html_url":"https://github.com/tdoan-r7","followers_url":"https://api.github.com/users/tdoan-r7/followers","following_url":"https://api.github.com/users/tdoan-r7/following{/other_user}","gists_url":"https://api.github.com/users/tdoan-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tdoan-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdoan-r7/subscriptions","organizations_url":"https://api.github.com/users/tdoan-r7/orgs","repos_url":"https://api.github.com/users/tdoan-r7/repos","events_url":"https://api.github.com/users/tdoan-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tdoan-r7/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":103,"deletions":103,"changed_files":60}}