{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/91859532","pull_request_review_id":12369916,"id":91859532,"diff_hunk":"@@ -4454,20 +4434,21 @@ public void doResources(StaplerRequest req, StaplerResponse rsp) throws IOExcept\n      * Checks if container uses UTF-8 to decode URLs. See\n      * http://wiki.jenkins-ci.org/display/JENKINS/Tomcat#Tomcat-i18n\n      */\n+    @Restricted(NoExternalUse.class)\n+    @RestrictedSince(\"since TODO\")\n+    @Deprecated\n     public FormValidation doCheckURIEncoding(StaplerRequest request) throws IOException {\n-        // expected is non-ASCII String\n-        final String expected = \"\\u57f7\\u4e8b\";\n-        final String value = fixEmpty(request.getParameter(\"value\"));\n-        if (!expected.equals(value))\n-            return FormValidation.warningWithMarkup(Messages.Hudson_NotUsesUTF8ToDecodeURL());\n-        return FormValidation.ok();\n+        return ExtensionList.lookup(URICheckEncodingMonitor.class).get(0).doCheckURIEncoding(request);","path":"core/src/main/java/jenkins/model/Jenkins.java","position":48,"original_position":48,"commit_id":"71d9db6b6c0e705dad79ececea5e6e3fe707b78d","original_commit_id":"71d9db6b6c0e705dad79ececea5e6e3fe707b78d","user":{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"body":"> It would be more relevant to return FormValidation error in such case than to blow u the UI\r\n\r\nThese deprecated methods aren't used anymore. I tried to be nice here instead of just returning `false` or something similar…","created_at":"2016-12-11T16:40:56Z","updated_at":"2016-12-11T16:40:56Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2661#discussion_r91859532","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/91859532"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2661#discussion_r91859532"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661","id":97401117,"html_url":"https://github.com/jenkinsci/jenkins/pull/2661","diff_url":"https://github.com/jenkinsci/jenkins/pull/2661.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2661.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2661","number":2661,"state":"open","locked":false,"title":"[FIX JENKINS-39433] Make URI encoding check into admin monitor","user":{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"body":"Basically move the code into an administrative monitor.\r\n\r\nTested manually that sending a different string than expected results in a warning, and that the deprecated code still works as expected despite being obsolete.\r\n\r\nThe original request in JENKINS-39433 was to be able to disable the check, but the implementation was a hack anyway. Now it's an admin monitor, and can be disabled in Configure System as a side effect.\r\n","created_at":"2016-12-09T23:58:14Z","updated_at":"2016-12-11T16:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d236c58907b0c960a527ac1545748634bce2669d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2661/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/71d9db6b6c0e705dad79ececea5e6e3fe707b78d","head":{"label":"daniel-beck:JENKINS-39433","ref":"JENKINS-39433","sha":"71d9db6b6c0e705dad79ececea5e6e3fe707b78d","user":{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"repo":{"id":11509651,"name":"jenkins","full_name":"daniel-beck/jenkins","owner":{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-beck/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/daniel-beck/jenkins","forks_url":"https://api.github.com/repos/daniel-beck/jenkins/forks","keys_url":"https://api.github.com/repos/daniel-beck/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-beck/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-beck/jenkins/teams","hooks_url":"https://api.github.com/repos/daniel-beck/jenkins/hooks","issue_events_url":"https://api.github.com/repos/daniel-beck/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-beck/jenkins/events","assignees_url":"https://api.github.com/repos/daniel-beck/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-beck/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-beck/jenkins/tags","blobs_url":"https://api.github.com/repos/daniel-beck/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-beck/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-beck/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-beck/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-beck/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-beck/jenkins/languages","stargazers_url":"https://api.github.com/repos/daniel-beck/jenkins/stargazers","contributors_url":"https://api.github.com/repos/daniel-beck/jenkins/contributors","subscribers_url":"https://api.github.com/repos/daniel-beck/jenkins/subscribers","subscription_url":"https://api.github.com/repos/daniel-beck/jenkins/subscription","commits_url":"https://api.github.com/repos/daniel-beck/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-beck/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-beck/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-beck/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-beck/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-beck/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-beck/jenkins/merges","archive_url":"https://api.github.com/repos/daniel-beck/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-beck/jenkins/downloads","issues_url":"https://api.github.com/repos/daniel-beck/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-beck/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-beck/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-beck/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-beck/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/daniel-beck/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-beck/jenkins/deployments","created_at":"2013-07-18T17:52:48Z","updated_at":"2016-11-15T13:20:07Z","pushed_at":"2016-12-10T16:47:11Z","git_url":"git://github.com/daniel-beck/jenkins.git","ssh_url":"git@github.com:daniel-beck/jenkins.git","clone_url":"https://github.com/daniel-beck/jenkins.git","svn_url":"https://github.com/daniel-beck/jenkins","homepage":"http://jenkins-ci.org/","size":106787,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"ba2900b27dba97c70d2bdbce043b752907ea7ea3","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-12-11T13:40:43Z","pushed_at":"2016-12-11T12:00:49Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":143632,"stargazers_count":7254,"watchers_count":7254,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3026,"mirror_url":null,"open_issues_count":114,"forks":3026,"open_issues":114,"watchers":7254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2661"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2661"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2661/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2661/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/71d9db6b6c0e705dad79ececea5e6e3fe707b78d"}}}}
{"actor":{"display_login":"daniel-beck"}}