{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/48971314","id":48971314,"diff_hunk":"@@ -0,0 +1,19 @@\n+'use strict';\n+var common = require('../common');\n+var assert = require('assert');\n+var path = require('path'),","path":"test/parallel/test-fs-read-buffer-zero-length.js","position":4,"original_position":4,"commit_id":"8d939e3cbd5504e4a47f21945ed512339d525980","original_commit_id":"8d939e3cbd5504e4a47f21945ed512339d525980","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"these should use `const`","created_at":"2016-01-06T15:52:04Z","updated_at":"2016-01-06T15:52:04Z","html_url":"https://github.com/nodejs/node/pull/4518#discussion_r48971314","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4518","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/48971314"},"html":{"href":"https://github.com/nodejs/node/pull/4518#discussion_r48971314"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4518"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4518","id":54927709,"html_url":"https://github.com/nodejs/node/pull/4518","diff_url":"https://github.com/nodejs/node/pull/4518.diff","patch_url":"https://github.com/nodejs/node/pull/4518.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4518","number":4518,"state":"open","locked":false,"title":"fs.read into zero buffer should not throw exception","user":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"body":"Fixes #4517.","created_at":"2016-01-03T16:28:57Z","updated_at":"2016-01-06T15:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12945c60a06c34de14464a2a80a6945409b2ee06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4518/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4518/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4518/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8d939e3cbd5504e4a47f21945ed512339d525980","head":{"label":"feross:fs-read-fix","ref":"fs-read-fix","sha":"8d939e3cbd5504e4a47f21945ed512339d525980","user":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"repo":{"id":48952585,"name":"node","full_name":"feross/node","owner":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feross/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/feross/node","forks_url":"https://api.github.com/repos/feross/node/forks","keys_url":"https://api.github.com/repos/feross/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feross/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feross/node/teams","hooks_url":"https://api.github.com/repos/feross/node/hooks","issue_events_url":"https://api.github.com/repos/feross/node/issues/events{/number}","events_url":"https://api.github.com/repos/feross/node/events","assignees_url":"https://api.github.com/repos/feross/node/assignees{/user}","branches_url":"https://api.github.com/repos/feross/node/branches{/branch}","tags_url":"https://api.github.com/repos/feross/node/tags","blobs_url":"https://api.github.com/repos/feross/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feross/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feross/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/feross/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feross/node/statuses/{sha}","languages_url":"https://api.github.com/repos/feross/node/languages","stargazers_url":"https://api.github.com/repos/feross/node/stargazers","contributors_url":"https://api.github.com/repos/feross/node/contributors","subscribers_url":"https://api.github.com/repos/feross/node/subscribers","subscription_url":"https://api.github.com/repos/feross/node/subscription","commits_url":"https://api.github.com/repos/feross/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/feross/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/feross/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/feross/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/feross/node/contents/{+path}","compare_url":"https://api.github.com/repos/feross/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feross/node/merges","archive_url":"https://api.github.com/repos/feross/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feross/node/downloads","issues_url":"https://api.github.com/repos/feross/node/issues{/number}","pulls_url":"https://api.github.com/repos/feross/node/pulls{/number}","milestones_url":"https://api.github.com/repos/feross/node/milestones{/number}","notifications_url":"https://api.github.com/repos/feross/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feross/node/labels{/name}","releases_url":"https://api.github.com/repos/feross/node/releases{/id}","created_at":"2016-01-03T16:28:10Z","updated_at":"2016-01-03T16:28:18Z","pushed_at":"2016-01-06T14:36:52Z","git_url":"git://github.com/feross/node.git","ssh_url":"git@github.com:feross/node.git","clone_url":"https://github.com/feross/node.git","svn_url":"https://github.com/feross/node","homepage":"https://nodejs.org","size":167017,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e51bbfd487e4ca8ebe79e423eb9aa057028cc37d","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-01-06T15:39:34Z","pushed_at":"2016-01-06T14:53:10Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":181337,"stargazers_count":18889,"watchers_count":18889,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2198,"mirror_url":null,"open_issues_count":665,"forks":2198,"open_issues":665,"watchers":18889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4518"},"html":{"href":"https://github.com/nodejs/node/pull/4518"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4518"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4518/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4518/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4518/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8d939e3cbd5504e4a47f21945ed512339d525980"}}}}