{"action":"created","issue":{"url":"https://api.github.com/repos/pnedev/compare-plugin/issues/59","repository_url":"https://api.github.com/repos/pnedev/compare-plugin","labels_url":"https://api.github.com/repos/pnedev/compare-plugin/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/pnedev/compare-plugin/issues/59/comments","events_url":"https://api.github.com/repos/pnedev/compare-plugin/issues/59/events","html_url":"https://github.com/pnedev/compare-plugin/issues/59","id":154361061,"number":59,"title":"Wrong file is activated in Two-Views mode","user":{"login":"Yaron10","id":10229320,"avatar_url":"https://avatars.githubusercontent.com/u/10229320?v=3","gravatar_id":"","url":"https://api.github.com/users/Yaron10","html_url":"https://github.com/Yaron10","followers_url":"https://api.github.com/users/Yaron10/followers","following_url":"https://api.github.com/users/Yaron10/following{/other_user}","gists_url":"https://api.github.com/users/Yaron10/gists{/gist_id}","starred_url":"https://api.github.com/users/Yaron10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yaron10/subscriptions","organizations_url":"https://api.github.com/users/Yaron10/orgs","repos_url":"https://api.github.com/users/Yaron10/repos","events_url":"https://api.github.com/users/Yaron10/events{/privacy}","received_events_url":"https://api.github.com/users/Yaron10/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pnedev/compare-plugin/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-05-11T22:53:57Z","updated_at":"2016-05-26T08:35:58Z","closed_at":"2016-05-26T08:35:58Z","body":"Hello Pavel,\r\n\r\nA minor regression after the last refactoring.\r\n\r\nSTR:\r\nSet \"Old file position\" to left/top.\r\nHave two files in Two-Views mode.\r\nActivate the file at top.\r\nCompare.\r\n\r\nResult:\r\nThe file at bottom is activated.\r\n\r\nNOTE: if you set \"Old file position\" to right/bottom, the file at *top* is always activated.\r\n\r\nThank you.\r\nBR\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pnedev/compare-plugin/issues/comments/221810782","html_url":"https://github.com/pnedev/compare-plugin/issues/59#issuecomment-221810782","issue_url":"https://api.github.com/repos/pnedev/compare-plugin/issues/59","id":221810782,"user":{"login":"pnedev","id":6064913,"avatar_url":"https://avatars.githubusercontent.com/u/6064913?v=3","gravatar_id":"","url":"https://api.github.com/users/pnedev","html_url":"https://github.com/pnedev","followers_url":"https://api.github.com/users/pnedev/followers","following_url":"https://api.github.com/users/pnedev/following{/other_user}","gists_url":"https://api.github.com/users/pnedev/gists{/gist_id}","starred_url":"https://api.github.com/users/pnedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnedev/subscriptions","organizations_url":"https://api.github.com/users/pnedev/orgs","repos_url":"https://api.github.com/users/pnedev/repos","events_url":"https://api.github.com/users/pnedev/events{/privacy}","received_events_url":"https://api.github.com/users/pnedev/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T08:35:58Z","updated_at":"2016-05-26T08:35:58Z","body":"Hello Yaron,\r\n\r\nHm, that regression had happened before the current fix.\r\nAnyway:\r\n\r\nCase 1 is fixed.\r\nCase 2 is fixed.\r\n\r\nCase 3 is normal behavior and I intend to leave it as it is. I'm pretty sure we have discussed that before. The thing is, when you manually move the file before compare you explicitly force it to be in the other (sub) view. Then when you close the other file (in main view) the current one is restored as it was before the compare -> it remains in the sub-view.\r\nImagine that you have 1 file (A) in main view and two files in the sub view (B and C).\r\nNow you compare A and B.\r\nClose A.\r\nNow B and C remain in the sub view and we are in single view. Moving B to main view would be weird in that case.\r\nOf course I can check if B will be the only file remaining after the close and move it to the main view but I think that is too much.\r\nI'm sure you would like such functionality :)\r\n@xylographe , could you share your opinion on this?\r\n\r\nThank you both.\r\n\r\nBR"}}
{"actor":{"display_login":"pnedev"}}