{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/1352","repository_url":"https://api.github.com/repos/guardian/membership-frontend","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/1352/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/1352/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/1352/events","html_url":"https://github.com/guardian/membership-frontend/pull/1352","id":184286294,"number":1352,"title":"Stop Sending INTCMP to Identity","user":{"login":"Ap0c","id":5131341,"avatar_url":"https://avatars.githubusercontent.com/u/5131341?v=3","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/guardian/membership-frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-20T17:04:03Z","updated_at":"2016-10-21T15:12:10Z","closed_at":"2016-10-21T14:54:19Z","pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/1352","html_url":"https://github.com/guardian/membership-frontend/pull/1352","diff_url":"https://github.com/guardian/membership-frontend/pull/1352.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/1352.patch"},"body":"# Plan\r\n\r\nCurrently we're sending internal campaign codes to identity every time a user registers or logs in via membership. Previously introduced in [this PR](https://github.com/guardian/membership-frontend/pull/818). This functionality is not needed any more, so we're removing it. Also, all the information we pass in the `INTCMP` query param is already present in the return URL itself.\r\n\r\n# Additional Info\r\n\r\nCurrently when a user attempts to become a supporter (or partner or patron) they are passed through an authentication action. If they are logged in, they are sent straight to the checkout page. If not, they are redirected to identity for signup (with an option to log in). A return url is given to identity, to send them on to the checkout once they have signed up/logged in. Currently an internal campaign code it also sent.\r\n\r\n# Changes\r\n\r\n- Remove `RegistrationUri` module, as the entire thing exists to send this code.\r\n- Update `chooseRegister` to build the registration url straight from the config, rather than going via `RegistrationUri`.\r\n- Remove tests for `RegistrationUri` module.\r\n\r\n@rtyley @markjamesbutler @paulbrown1982 "},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/255403867","html_url":"https://github.com/guardian/membership-frontend/pull/1352#issuecomment-255403867","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/1352","id":255403867,"user":{"login":"Ap0c","id":5131341,"avatar_url":"https://avatars.githubusercontent.com/u/5131341?v=3","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T15:12:10Z","updated_at":"2016-10-21T15:12:10Z","body":"INTCMP param not being sent to identity:\r\n\r\n![intcmp-identity-gone](https://cloud.githubusercontent.com/assets/5131341/19603443/09473844-97a9-11e6-9ff9-950986ca3a20.png)\r\n\r\nIdentity not passing it on to checkout:\r\n![intcmp-gone](https://cloud.githubusercontent.com/assets/5131341/19603260/667b600e-97a8-11e6-8a33-8ef728a32d2a.png)\r\n\r\nThis seems to be working!"}}
{"actor":{"display_login":"Ap0c"}}