{"action":"created","issue":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1307","repository_url":"https://api.github.com/repos/rcbops/rpc-openstack","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1307/labels{/name}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1307/comments","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1307/events","html_url":"https://github.com/rcbops/rpc-openstack/issues/1307","id":170398205,"number":1307,"title":"cinder_backup maas check doesn't use venv","user":{"login":"mancdaz","id":562262,"avatar_url":"https://avatars.githubusercontent.com/u/562262?v=3","gravatar_id":"","url":"https://api.github.com/users/mancdaz","html_url":"https://github.com/mancdaz","followers_url":"https://api.github.com/users/mancdaz/followers","following_url":"https://api.github.com/users/mancdaz/following{/other_user}","gists_url":"https://api.github.com/users/mancdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mancdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mancdaz/subscriptions","organizations_url":"https://api.github.com/users/mancdaz/orgs","repos_url":"https://api.github.com/users/mancdaz/repos","events_url":"https://api.github.com/users/mancdaz/events{/privacy}","received_events_url":"https://api.github.com/users/mancdaz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/feature-monitoring","name":"feature-monitoring","color":"fef2c0"},{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/impacts-qe","name":"impacts-qe","color":"d4c5f9"},{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/prio-2","name":"prio-2","color":"fbca04"},{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/type-bug","name":"type-bug","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-10T11:50:09Z","updated_at":"2016-08-15T14:59:16Z","closed_at":null,"body":"##### On which version(s) do you encounter this issue?\r\n\r\nheads/master\r\n\r\n##### What type of issue is this? Please tick the appropriate box.\r\n- [x] bug - existing functionality that does not work for you as documented\r\n- [ ] feature - new functionality that you would like to see added\r\n\r\n##### What is the expected behavior?\r\n\r\nThe cinder backup check is created as expected, using the venv wrapper where necessary\r\n\r\n##### What is actually happening?\r\n\r\nThe cinder backup check was added without the 'run_plugin_in_venv' wrapper, which creates the check incorrectly. It actually still runs, but at some point if dependencies are added in to the venv in the future, that don't exist on the host, it will fail.\r\n\r\nhttps://github.com/rcbops/rpc-openstack/blob/e1dd1a4ab74d8de14d6ffedb7d53b3c6d6d913c0/rpcd/playbooks/roles/rpc_maas/templates/cinder_backup_check.yaml.j2#L7-L8\r\n\r\n##### What were you attempting to do when you encountered this error (give as much detail as possible)? \r\n\r\nRun a multinode deployment, and then run setup-maas and check the cinder_backup template.\r\n\r\nExpected content:\r\n\r\n```\r\n---snip---\r\ndetails     :\r\n    file    : run_plugin_in_venv.sh\r\n    args    : [\"/usr/lib/rackspace-monitoring-agent/plugins/cinder_service_check.py\", \"--host\", \"533811-node15\", \"192.168.100.2\"]\r\n---snip---\r\n```\r\n\r\nActual content:\r\n\r\n```\r\n---snip---\r\ndetails     :\r\n    file    : cinder_service_check.py\r\n    args    : [\"--host\", \"533811-node15\", \"192.168.100.2\"]\r\n---snip---\r\n```\r\n\r\n##### How can we reproduce this issue?\r\n\r\nRun a multinode deployment, and then run setup-maas and verify-maas - the cinder_backup check template will not have the run_plugin_in_venv wrapper.\r\n\r\n\r\n##### How can we verify your issue is addressed?\r\n\r\nAfter running setup-maas, check the cinder_backup template and ensure it has the run_plugin_in_venv wrapper configured\r\n\r\n##### If you are using or know of a workaround please describe the necessary steps?\r\n\r\nAt this time, not necessary as the plugin still runs\r\n\r\n##### What is your evaluation on the importance of this issue, and why?\r\n\r\nLow as the plugin still runs from outside the venv\r\n\r\n----------------------------------------------------------------------------------------------------------------------------\r\n#### This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.\r\n##### Which branches are impacted by this issue?\r\n###### Remove branches that are not impacted.\r\n###### For each pull request, update the branch line to reference it.\r\n- [ ] master\r\n- [ ] liberty-12.2\r\n- [ ] kilo\r\n\r\n##### Upgrade impact. Consider the impact on moving between major, minor and patch releases.\r\n- [ ] This change does not impact upgrades\r\n- [ ] This change addresses a potential upgrade impact\r\n- [ ] The upgrade impact is being tracked by another issue.\r\n\r\nThe issue tracking the upgrade impact is:\r\n\r\n##### Testing impact\r\n- [ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below\r\n- [ ] This change includes additional testing\r\n- [ ] This change is tested by the existing setup\r\n\r\nAdditional testing links:\r\n\r\n##### Release note\r\n- [ ] This change includes a release note.\r\n- [ ] This change does not require a release note.\r\n\r\n##### Doc Impact\r\n##### Does your change require documentation?\r\n- [ ] Yes, and I submitted an issue to [Docs issues](https://github.com/rackerlabs/docs-rpc/issues \"Docs issues\")\r\n- [ ] Yes, and I contributed a documentation patch to [docs-rpc](https://github.com/rackerlabs/docs-rpc \"docs-rpc\")\r\n- [ ] No documentation required for this change\r\n\r\nAdditional documentation links (please add links if you have ticked yes):\r\n"},"comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments/239824599","html_url":"https://github.com/rcbops/rpc-openstack/issues/1307#issuecomment-239824599","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1307","id":239824599,"user":{"login":"Frank-ZhangXin","id":5384857,"avatar_url":"https://avatars.githubusercontent.com/u/5384857?v=3","gravatar_id":"","url":"https://api.github.com/users/Frank-ZhangXin","html_url":"https://github.com/Frank-ZhangXin","followers_url":"https://api.github.com/users/Frank-ZhangXin/followers","following_url":"https://api.github.com/users/Frank-ZhangXin/following{/other_user}","gists_url":"https://api.github.com/users/Frank-ZhangXin/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-ZhangXin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-ZhangXin/subscriptions","organizations_url":"https://api.github.com/users/Frank-ZhangXin/orgs","repos_url":"https://api.github.com/users/Frank-ZhangXin/repos","events_url":"https://api.github.com/users/Frank-ZhangXin/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-ZhangXin/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T14:59:15Z","updated_at":"2016-08-15T14:59:15Z","body":"@mancdaz hi, Darren, did this only happened when multi-node deployment? Previous venv patch of MaaS should be based on AIO test environment I think. Thanks."}}
{"actor":{"display_login":"Frank-ZhangXin"}}