{"action":"opened","number":1921,"pull_request":{"url":"https://api.github.com/repos/mtgred/netrunner/pulls/1921","id":83672802,"html_url":"https://github.com/mtgred/netrunner/pull/1921","diff_url":"https://github.com/mtgred/netrunner/pull/1921.diff","patch_url":"https://github.com/mtgred/netrunner/pull/1921.patch","issue_url":"https://api.github.com/repos/mtgred/netrunner/issues/1921","number":1921,"state":"open","locked":false,"title":"Fixes scoring","user":{"login":"Saintis","id":13198563,"avatar_url":"https://avatars.githubusercontent.com/u/13198563?v=3","gravatar_id":"","url":"https://api.github.com/users/Saintis","html_url":"https://github.com/Saintis","followers_url":"https://api.github.com/users/Saintis/followers","following_url":"https://api.github.com/users/Saintis/following{/other_user}","gists_url":"https://api.github.com/users/Saintis/gists{/gist_id}","starred_url":"https://api.github.com/users/Saintis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saintis/subscriptions","organizations_url":"https://api.github.com/users/Saintis/orgs","repos_url":"https://api.github.com/users/Saintis/repos","events_url":"https://api.github.com/users/Saintis/events{/privacy}","received_events_url":"https://api.github.com/users/Saintis/received_events","type":"User","site_admin":false},"body":"Fixes NPE on trying to score with no advancement counters (and updates related test).\r\nFixes Plan B by moving `get-card` out from the `score` function into the commands map in `main`.\r\nAdds test for Plan B.\r\n\r\nJust three changes to `score`:\r\n\r\n- Removed `get-card`\r\n- Added default value for `:advancement-counter` to prevent NPE\r\n- Combined the two `when` checks into one `and`\r\n\r\nFixes #1919.","created_at":"2016-09-01T17:20:32Z","updated_at":"2016-09-01T17:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9debc861343e7a2d1c53db096c9afe6323d2b87b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mtgred/netrunner/issues/1921/comments","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/57fec1c8fed3cf843ec22732f7d3fbb1375225e3","head":{"label":"Saintis:scoring","ref":"scoring","sha":"57fec1c8fed3cf843ec22732f7d3fbb1375225e3","user":{"login":"Saintis","id":13198563,"avatar_url":"https://avatars.githubusercontent.com/u/13198563?v=3","gravatar_id":"","url":"https://api.github.com/users/Saintis","html_url":"https://github.com/Saintis","followers_url":"https://api.github.com/users/Saintis/followers","following_url":"https://api.github.com/users/Saintis/following{/other_user}","gists_url":"https://api.github.com/users/Saintis/gists{/gist_id}","starred_url":"https://api.github.com/users/Saintis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saintis/subscriptions","organizations_url":"https://api.github.com/users/Saintis/orgs","repos_url":"https://api.github.com/users/Saintis/repos","events_url":"https://api.github.com/users/Saintis/events{/privacy}","received_events_url":"https://api.github.com/users/Saintis/received_events","type":"User","site_admin":false},"repo":{"id":48078468,"name":"netrunner","full_name":"Saintis/netrunner","owner":{"login":"Saintis","id":13198563,"avatar_url":"https://avatars.githubusercontent.com/u/13198563?v=3","gravatar_id":"","url":"https://api.github.com/users/Saintis","html_url":"https://github.com/Saintis","followers_url":"https://api.github.com/users/Saintis/followers","following_url":"https://api.github.com/users/Saintis/following{/other_user}","gists_url":"https://api.github.com/users/Saintis/gists{/gist_id}","starred_url":"https://api.github.com/users/Saintis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saintis/subscriptions","organizations_url":"https://api.github.com/users/Saintis/orgs","repos_url":"https://api.github.com/users/Saintis/repos","events_url":"https://api.github.com/users/Saintis/events{/privacy}","received_events_url":"https://api.github.com/users/Saintis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Saintis/netrunner","description":"","fork":true,"url":"https://api.github.com/repos/Saintis/netrunner","forks_url":"https://api.github.com/repos/Saintis/netrunner/forks","keys_url":"https://api.github.com/repos/Saintis/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Saintis/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Saintis/netrunner/teams","hooks_url":"https://api.github.com/repos/Saintis/netrunner/hooks","issue_events_url":"https://api.github.com/repos/Saintis/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/Saintis/netrunner/events","assignees_url":"https://api.github.com/repos/Saintis/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/Saintis/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/Saintis/netrunner/tags","blobs_url":"https://api.github.com/repos/Saintis/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Saintis/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Saintis/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Saintis/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Saintis/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/Saintis/netrunner/languages","stargazers_url":"https://api.github.com/repos/Saintis/netrunner/stargazers","contributors_url":"https://api.github.com/repos/Saintis/netrunner/contributors","subscribers_url":"https://api.github.com/repos/Saintis/netrunner/subscribers","subscription_url":"https://api.github.com/repos/Saintis/netrunner/subscription","commits_url":"https://api.github.com/repos/Saintis/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Saintis/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Saintis/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Saintis/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Saintis/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/Saintis/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Saintis/netrunner/merges","archive_url":"https://api.github.com/repos/Saintis/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Saintis/netrunner/downloads","issues_url":"https://api.github.com/repos/Saintis/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/Saintis/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/Saintis/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/Saintis/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Saintis/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/Saintis/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/Saintis/netrunner/deployments","created_at":"2015-12-16T01:06:49Z","updated_at":"2016-01-11T16:30:58Z","pushed_at":"2016-09-01T17:15:02Z","git_url":"git://github.com/Saintis/netrunner.git","ssh_url":"git@github.com:Saintis/netrunner.git","clone_url":"https://github.com/Saintis/netrunner.git","svn_url":"https://github.com/Saintis/netrunner","homepage":"http://www.jinteki.net","size":11744,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mtgred/master"}},"base":{"label":"mtgred:master","ref":"master","sha":"6b6f9af8bea10d6f915f3be2a698a136693f4308","user":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"repo":{"id":19079918,"name":"netrunner","full_name":"mtgred/netrunner","owner":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtgred/netrunner","description":"","fork":false,"url":"https://api.github.com/repos/mtgred/netrunner","forks_url":"https://api.github.com/repos/mtgred/netrunner/forks","keys_url":"https://api.github.com/repos/mtgred/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtgred/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtgred/netrunner/teams","hooks_url":"https://api.github.com/repos/mtgred/netrunner/hooks","issue_events_url":"https://api.github.com/repos/mtgred/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/mtgred/netrunner/events","assignees_url":"https://api.github.com/repos/mtgred/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/mtgred/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/mtgred/netrunner/tags","blobs_url":"https://api.github.com/repos/mtgred/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtgred/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtgred/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtgred/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/mtgred/netrunner/languages","stargazers_url":"https://api.github.com/repos/mtgred/netrunner/stargazers","contributors_url":"https://api.github.com/repos/mtgred/netrunner/contributors","subscribers_url":"https://api.github.com/repos/mtgred/netrunner/subscribers","subscription_url":"https://api.github.com/repos/mtgred/netrunner/subscription","commits_url":"https://api.github.com/repos/mtgred/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtgred/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtgred/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtgred/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtgred/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/mtgred/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtgred/netrunner/merges","archive_url":"https://api.github.com/repos/mtgred/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtgred/netrunner/downloads","issues_url":"https://api.github.com/repos/mtgred/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/mtgred/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/mtgred/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/mtgred/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtgred/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/mtgred/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/mtgred/netrunner/deployments","created_at":"2014-04-23T17:57:52Z","updated_at":"2016-08-27T14:06:18Z","pushed_at":"2016-09-01T17:20:32Z","git_url":"git://github.com/mtgred/netrunner.git","ssh_url":"git@github.com:mtgred/netrunner.git","clone_url":"https://github.com/mtgred/netrunner.git","svn_url":"https://github.com/mtgred/netrunner","homepage":"http://www.jinteki.net","size":13498,"stargazers_count":408,"watchers_count":408,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":160,"forks":200,"open_issues":160,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1921"},"html":{"href":"https://github.com/mtgred/netrunner/pull/1921"},"issue":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1921"},"comments":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/mtgred/netrunner/statuses/57fec1c8fed3cf843ec22732f7d3fbb1375225e3"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":54,"deletions":35,"changed_files":5}}
{"actor":{"display_login":"Saintis"}}