{"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/comments/91724097","pull_request_review_id":12235177,"id":91724097,"diff_hunk":"@@ -17,17 +17,29 @@\n @VertxGen\n public interface SQLRowStream extends ReadStream<JsonArray> {\n \n-    /**\n-     * Will convert the column name to the json array index\n-     *\n-     * @param name\n-     * @return\n-     */\n-    int column(String name);\n+  /**\n+   * Will convert the column name to the json array index\n+   *\n+   * @param name\n+   * @return\n+   */\n+  int column(String name);\n \n-    /**\n-     * Closes the stream/underlying cursor(s)\n-     * @param handler\n-     */\n-    void close(Handler<AsyncResult<Void>> handler);\n+  /**\n+   * Closes the stream/underlying cursor(s)\n+   *\n+   * @param handler\n+   */\n+  void close(Handler<AsyncResult<Void>> handler);\n+\n+  /**\n+   * Event handler when a resultset is closed. This is useful to request for more results.\n+   * @param handler\n+   */\n+  SQLRowStream resultSetClosed(Handler<Void> handler);","path":"src/main/java/io/vertx/ext/sql/SQLRowStream.java","position":35,"original_position":35,"commit_id":"e9d86be326f27912eade1937a818c3df877eaadd","original_commit_id":"e9d86be326f27912eade1937a818c3df877eaadd","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"body":"should be named `resultSetClosedHandler`","created_at":"2016-12-09T14:25:03Z","updated_at":"2016-12-09T14:25:04Z","html_url":"https://github.com/vert-x3/vertx-sql-common/pull/36#discussion_r91724097","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/comments/91724097"},"html":{"href":"https://github.com/vert-x3/vertx-sql-common/pull/36#discussion_r91724097"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36","id":96694597,"html_url":"https://github.com/vert-x3/vertx-sql-common/pull/36","diff_url":"https://github.com/vert-x3/vertx-sql-common/pull/36.diff","patch_url":"https://github.com/vert-x3/vertx-sql-common/pull/36.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/36","number":36,"state":"open","locked":false,"title":"Proposal for multiple resultset support","user":{"login":"pmlopes","id":849467,"avatar_url":"https://avatars.githubusercontent.com/u/849467?v=3","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"body":"see vert-x3/vertx-jdbc-client#80","created_at":"2016-12-06T10:10:12Z","updated_at":"2016-12-09T14:25:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99cfc7002d1b781b38850250b36f65331b878abf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/36/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/statuses/e9d86be326f27912eade1937a818c3df877eaadd","head":{"label":"vert-x3:issues/multiple-resultset","ref":"issues/multiple-resultset","sha":"e9d86be326f27912eade1937a818c3df877eaadd","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":30586758,"name":"vertx-sql-common","full_name":"vert-x3/vertx-sql-common","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-sql-common","description":"Common SQL interfaces for Vert.x SQL services","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-sql-common","forks_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/deployments","created_at":"2015-02-10T10:21:09Z","updated_at":"2016-11-27T19:54:18Z","pushed_at":"2016-12-09T13:40:52Z","git_url":"git://github.com/vert-x3/vertx-sql-common.git","ssh_url":"git@github.com:vert-x3/vertx-sql-common.git","clone_url":"https://github.com/vert-x3/vertx-sql-common.git","svn_url":"https://github.com/vert-x3/vertx-sql-common","homepage":null,"size":363,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":13,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"5806234a8f44eda63e6b56ce622daabd86b62fd4","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":30586758,"name":"vertx-sql-common","full_name":"vert-x3/vertx-sql-common","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-sql-common","description":"Common SQL interfaces for Vert.x SQL services","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-sql-common","forks_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-sql-common/deployments","created_at":"2015-02-10T10:21:09Z","updated_at":"2016-11-27T19:54:18Z","pushed_at":"2016-12-09T13:40:52Z","git_url":"git://github.com/vert-x3/vertx-sql-common.git","ssh_url":"git@github.com:vert-x3/vertx-sql-common.git","clone_url":"https://github.com/vert-x3/vertx-sql-common.git","svn_url":"https://github.com/vert-x3/vertx-sql-common","homepage":null,"size":363,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36"},"html":{"href":"https://github.com/vert-x3/vertx-sql-common/pull/36"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/36"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-sql-common/statuses/e9d86be326f27912eade1937a818c3df877eaadd"}}}}
{"actor":{"display_login":"vietj"}}