{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1159","repository_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1159/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1159/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1159/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/1159","id":140668562,"number":1159,"title":"Corrupt SDK downloaded from Espressif breaks build","user":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-03-14T13:09:00Z","updated_at":"2016-03-15T10:48:50Z","closed_at":"2016-03-15T09:09:20Z","body":"Starting from this morning all `dev` builds in my build service fail.\r\n\r\n> sha1sum: WARNING: 1 computed checksum did NOT match\r\n\r\nTurns out the file we download from http://bbs.espressif.com/download/file.php?id=1046 does not just have an unexpected SHA1 checksum, it isn't even a valid ZIP file.\r\n\r\n> /tmp > unzip -t esp_iot_sdk_v1.5.1_16_01_08.zip \r\nArchive:  esp_iot_sdk_v1.5.1_16_01_08.zip\r\nwarning [esp_iot_sdk_v1.5.1_16_01_08.zip]:  7637 extra bytes at beginning or within zipfile\r\n  (attempting to process anyway)\r\nerror [esp_iot_sdk_v1.5.1_16_01_08.zip]:  start of central directory not found;\r\n  zipfile corrupt.\r\n  (please check that you have transferred or created the zipfile in the\r\n  appropriate BINARY mode and that you have compiled UnZip properly)\r\n\r\n-> all CI builds Travis runs for submitted PRs will fail as well\r\n\r\nIf we really wanted to we could slightly improve https://github.com/nodemcu/nodemcu-firmware/blob/dev/Makefile#L193 by running `unzip -t` before the checksum verification. The build would still break but we'd get a more precise error message."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/196763064","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/1159#issuecomment-196763064","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1159","id":196763064,"user":{"login":"NicolSpies","id":15835606,"avatar_url":"https://avatars.githubusercontent.com/u/15835606?v=3","gravatar_id":"","url":"https://api.github.com/users/NicolSpies","html_url":"https://github.com/NicolSpies","followers_url":"https://api.github.com/users/NicolSpies/followers","following_url":"https://api.github.com/users/NicolSpies/following{/other_user}","gists_url":"https://api.github.com/users/NicolSpies/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolSpies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolSpies/subscriptions","organizations_url":"https://api.github.com/users/NicolSpies/orgs","repos_url":"https://api.github.com/users/NicolSpies/repos","events_url":"https://api.github.com/users/NicolSpies/events{/privacy}","received_events_url":"https://api.github.com/users/NicolSpies/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T10:48:50Z","updated_at":"2016-03-15T10:48:50Z","body":"Thank you sir, all good !"}}