{"action":"opened","number":342,"pull_request":{"url":"https://api.github.com/repos/haxenme/nme/pulls/342","id":79043314,"html_url":"https://github.com/haxenme/nme/pull/342","diff_url":"https://github.com/haxenme/nme/pull/342.diff","patch_url":"https://github.com/haxenme/nme/pull/342.patch","issue_url":"https://api.github.com/repos/haxenme/nme/issues/342","number":342,"state":"open","locked":false,"title":"Fix OpenAL sound resuming","user":{"login":"jskuse","id":6178279,"avatar_url":"https://avatars.githubusercontent.com/u/6178279?v=3","gravatar_id":"","url":"https://api.github.com/users/jskuse","html_url":"https://github.com/jskuse","followers_url":"https://api.github.com/users/jskuse/followers","following_url":"https://api.github.com/users/jskuse/following{/other_user}","gists_url":"https://api.github.com/users/jskuse/gists{/gist_id}","starred_url":"https://api.github.com/users/jskuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskuse/subscriptions","organizations_url":"https://api.github.com/users/jskuse/orgs","repos_url":"https://api.github.com/users/jskuse/repos","events_url":"https://api.github.com/users/jskuse/events{/privacy}","received_events_url":"https://api.github.com/users/jskuse/received_events","type":"User","site_admin":false},"body":"I've made some changes which seemingly fixes #338. I'm absolutely unfamiliar with OpenAL, but it appears that the issue was that on suspend and resume we were looping through the ChannelList (which also contained our old non-GC'd channels) and calling resume on them which was in turn playing them regardless if they were complete or not. \r\n\r\nGiven that Sound calls SuspendOpenAl() and ResumeOpenAl() anyway, it seemed to me that the contents of the OpenALSourceChannel suspend() and resume() may be pretty redundant if OpenAL was resumed using alcProcessContext. \r\n\r\nThis works well at this end, but obviously I'd recommend you sanity check my reasoning!","created_at":"2016-07-27T15:16:53Z","updated_at":"2016-07-27T15:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haxenme/nme/pulls/342/commits","review_comments_url":"https://api.github.com/repos/haxenme/nme/pulls/342/comments","review_comment_url":"https://api.github.com/repos/haxenme/nme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haxenme/nme/issues/342/comments","statuses_url":"https://api.github.com/repos/haxenme/nme/statuses/534cdd692749d6557a08e215da071249a076b3b6","head":{"label":"popleaf:openal_resume_fix","ref":"openal_resume_fix","sha":"534cdd692749d6557a08e215da071249a076b3b6","user":{"login":"popleaf","id":6178281,"avatar_url":"https://avatars.githubusercontent.com/u/6178281?v=3","gravatar_id":"","url":"https://api.github.com/users/popleaf","html_url":"https://github.com/popleaf","followers_url":"https://api.github.com/users/popleaf/followers","following_url":"https://api.github.com/users/popleaf/following{/other_user}","gists_url":"https://api.github.com/users/popleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/popleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popleaf/subscriptions","organizations_url":"https://api.github.com/users/popleaf/orgs","repos_url":"https://api.github.com/users/popleaf/repos","events_url":"https://api.github.com/users/popleaf/events{/privacy}","received_events_url":"https://api.github.com/users/popleaf/received_events","type":"Organization","site_admin":false},"repo":{"id":64238115,"name":"nme","full_name":"popleaf/nme","owner":{"login":"popleaf","id":6178281,"avatar_url":"https://avatars.githubusercontent.com/u/6178281?v=3","gravatar_id":"","url":"https://api.github.com/users/popleaf","html_url":"https://github.com/popleaf","followers_url":"https://api.github.com/users/popleaf/followers","following_url":"https://api.github.com/users/popleaf/following{/other_user}","gists_url":"https://api.github.com/users/popleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/popleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popleaf/subscriptions","organizations_url":"https://api.github.com/users/popleaf/orgs","repos_url":"https://api.github.com/users/popleaf/repos","events_url":"https://api.github.com/users/popleaf/events{/privacy}","received_events_url":"https://api.github.com/users/popleaf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/popleaf/nme","description":"A cross-platform native backend for Haxe projects","fork":true,"url":"https://api.github.com/repos/popleaf/nme","forks_url":"https://api.github.com/repos/popleaf/nme/forks","keys_url":"https://api.github.com/repos/popleaf/nme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popleaf/nme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popleaf/nme/teams","hooks_url":"https://api.github.com/repos/popleaf/nme/hooks","issue_events_url":"https://api.github.com/repos/popleaf/nme/issues/events{/number}","events_url":"https://api.github.com/repos/popleaf/nme/events","assignees_url":"https://api.github.com/repos/popleaf/nme/assignees{/user}","branches_url":"https://api.github.com/repos/popleaf/nme/branches{/branch}","tags_url":"https://api.github.com/repos/popleaf/nme/tags","blobs_url":"https://api.github.com/repos/popleaf/nme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popleaf/nme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popleaf/nme/git/refs{/sha}","trees_url":"https://api.github.com/repos/popleaf/nme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popleaf/nme/statuses/{sha}","languages_url":"https://api.github.com/repos/popleaf/nme/languages","stargazers_url":"https://api.github.com/repos/popleaf/nme/stargazers","contributors_url":"https://api.github.com/repos/popleaf/nme/contributors","subscribers_url":"https://api.github.com/repos/popleaf/nme/subscribers","subscription_url":"https://api.github.com/repos/popleaf/nme/subscription","commits_url":"https://api.github.com/repos/popleaf/nme/commits{/sha}","git_commits_url":"https://api.github.com/repos/popleaf/nme/git/commits{/sha}","comments_url":"https://api.github.com/repos/popleaf/nme/comments{/number}","issue_comment_url":"https://api.github.com/repos/popleaf/nme/issues/comments{/number}","contents_url":"https://api.github.com/repos/popleaf/nme/contents/{+path}","compare_url":"https://api.github.com/repos/popleaf/nme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popleaf/nme/merges","archive_url":"https://api.github.com/repos/popleaf/nme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popleaf/nme/downloads","issues_url":"https://api.github.com/repos/popleaf/nme/issues{/number}","pulls_url":"https://api.github.com/repos/popleaf/nme/pulls{/number}","milestones_url":"https://api.github.com/repos/popleaf/nme/milestones{/number}","notifications_url":"https://api.github.com/repos/popleaf/nme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popleaf/nme/labels{/name}","releases_url":"https://api.github.com/repos/popleaf/nme/releases{/id}","deployments_url":"https://api.github.com/repos/popleaf/nme/deployments","created_at":"2016-07-26T16:44:49Z","updated_at":"2016-07-26T16:44:52Z","pushed_at":"2016-07-27T15:01:09Z","git_url":"git://github.com/popleaf/nme.git","ssh_url":"git@github.com:popleaf/nme.git","clone_url":"https://github.com/popleaf/nme.git","svn_url":"https://github.com/popleaf/nme","homepage":"","size":220311,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haxenme:master","ref":"master","sha":"f6184cfe1647d98bb628be064328da18ab4bdf58","user":{"login":"haxenme","id":2187351,"avatar_url":"https://avatars.githubusercontent.com/u/2187351?v=3","gravatar_id":"","url":"https://api.github.com/users/haxenme","html_url":"https://github.com/haxenme","followers_url":"https://api.github.com/users/haxenme/followers","following_url":"https://api.github.com/users/haxenme/following{/other_user}","gists_url":"https://api.github.com/users/haxenme/gists{/gist_id}","starred_url":"https://api.github.com/users/haxenme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haxenme/subscriptions","organizations_url":"https://api.github.com/users/haxenme/orgs","repos_url":"https://api.github.com/users/haxenme/repos","events_url":"https://api.github.com/users/haxenme/events{/privacy}","received_events_url":"https://api.github.com/users/haxenme/received_events","type":"Organization","site_admin":false},"repo":{"id":5051566,"name":"nme","full_name":"haxenme/nme","owner":{"login":"haxenme","id":2187351,"avatar_url":"https://avatars.githubusercontent.com/u/2187351?v=3","gravatar_id":"","url":"https://api.github.com/users/haxenme","html_url":"https://github.com/haxenme","followers_url":"https://api.github.com/users/haxenme/followers","following_url":"https://api.github.com/users/haxenme/following{/other_user}","gists_url":"https://api.github.com/users/haxenme/gists{/gist_id}","starred_url":"https://api.github.com/users/haxenme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haxenme/subscriptions","organizations_url":"https://api.github.com/users/haxenme/orgs","repos_url":"https://api.github.com/users/haxenme/repos","events_url":"https://api.github.com/users/haxenme/events{/privacy}","received_events_url":"https://api.github.com/users/haxenme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haxenme/nme","description":"A cross-platform native backend for Haxe projects","fork":false,"url":"https://api.github.com/repos/haxenme/nme","forks_url":"https://api.github.com/repos/haxenme/nme/forks","keys_url":"https://api.github.com/repos/haxenme/nme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haxenme/nme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haxenme/nme/teams","hooks_url":"https://api.github.com/repos/haxenme/nme/hooks","issue_events_url":"https://api.github.com/repos/haxenme/nme/issues/events{/number}","events_url":"https://api.github.com/repos/haxenme/nme/events","assignees_url":"https://api.github.com/repos/haxenme/nme/assignees{/user}","branches_url":"https://api.github.com/repos/haxenme/nme/branches{/branch}","tags_url":"https://api.github.com/repos/haxenme/nme/tags","blobs_url":"https://api.github.com/repos/haxenme/nme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haxenme/nme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haxenme/nme/git/refs{/sha}","trees_url":"https://api.github.com/repos/haxenme/nme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haxenme/nme/statuses/{sha}","languages_url":"https://api.github.com/repos/haxenme/nme/languages","stargazers_url":"https://api.github.com/repos/haxenme/nme/stargazers","contributors_url":"https://api.github.com/repos/haxenme/nme/contributors","subscribers_url":"https://api.github.com/repos/haxenme/nme/subscribers","subscription_url":"https://api.github.com/repos/haxenme/nme/subscription","commits_url":"https://api.github.com/repos/haxenme/nme/commits{/sha}","git_commits_url":"https://api.github.com/repos/haxenme/nme/git/commits{/sha}","comments_url":"https://api.github.com/repos/haxenme/nme/comments{/number}","issue_comment_url":"https://api.github.com/repos/haxenme/nme/issues/comments{/number}","contents_url":"https://api.github.com/repos/haxenme/nme/contents/{+path}","compare_url":"https://api.github.com/repos/haxenme/nme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haxenme/nme/merges","archive_url":"https://api.github.com/repos/haxenme/nme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haxenme/nme/downloads","issues_url":"https://api.github.com/repos/haxenme/nme/issues{/number}","pulls_url":"https://api.github.com/repos/haxenme/nme/pulls{/number}","milestones_url":"https://api.github.com/repos/haxenme/nme/milestones{/number}","notifications_url":"https://api.github.com/repos/haxenme/nme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haxenme/nme/labels{/name}","releases_url":"https://api.github.com/repos/haxenme/nme/releases{/id}","deployments_url":"https://api.github.com/repos/haxenme/nme/deployments","created_at":"2012-07-14T22:19:48Z","updated_at":"2016-07-22T11:37:02Z","pushed_at":"2016-07-27T15:16:53Z","git_url":"git://github.com/haxenme/nme.git","ssh_url":"git@github.com:haxenme/nme.git","clone_url":"https://github.com/haxenme/nme.git","svn_url":"https://github.com/haxenme/nme","homepage":"","size":224310,"stargazers_count":359,"watchers_count":359,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":29,"forks":114,"open_issues":29,"watchers":359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haxenme/nme/pulls/342"},"html":{"href":"https://github.com/haxenme/nme/pull/342"},"issue":{"href":"https://api.github.com/repos/haxenme/nme/issues/342"},"comments":{"href":"https://api.github.com/repos/haxenme/nme/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/haxenme/nme/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/haxenme/nme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haxenme/nme/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/haxenme/nme/statuses/534cdd692749d6557a08e215da071249a076b3b6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"jskuse"}}