{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/relay/issues/1017","repository_url":"https://api.github.com/repos/facebook/relay","labels_url":"https://api.github.com/repos/facebook/relay/issues/1017/labels{/name}","comments_url":"https://api.github.com/repos/facebook/relay/issues/1017/comments","events_url":"https://api.github.com/repos/facebook/relay/issues/1017/events","html_url":"https://github.com/facebook/relay/pull/1017","id":145809358,"number":1017,"title":"Relax connectionName validation slightly","user":{"login":"wincent","id":7074,"avatar_url":"https://avatars.githubusercontent.com/u/7074?v=3","gravatar_id":"","url":"https://api.github.com/users/wincent","html_url":"https://github.com/wincent","followers_url":"https://api.github.com/users/wincent/followers","following_url":"https://api.github.com/users/wincent/following{/other_user}","gists_url":"https://api.github.com/users/wincent/gists{/gist_id}","starred_url":"https://api.github.com/users/wincent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincent/subscriptions","organizations_url":"https://api.github.com/users/wincent/orgs","repos_url":"https://api.github.com/users/wincent/repos","events_url":"https://api.github.com/users/wincent/events{/privacy}","received_events_url":"https://api.github.com/users/wincent/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/relay/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-04T21:26:19Z","updated_at":"2016-04-04T22:15:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/relay/pulls/1017","html_url":"https://github.com/facebook/relay/pull/1017","diff_url":"https://github.com/facebook/relay/pull/1017.diff","patch_url":"https://github.com/facebook/relay/pull/1017.patch"},"body":"In f2aa5b0e78c2f5 (D3095672) we tightened up mutation config validation a little too much, breaking product code that didn't explicitly include the connection field in the fat query definition.\r\n\r\nIn this commit we make it a little less aggressive:\r\n\r\n- If the connection field is explicit in the fat query, we validate it.\r\n- If it is not explicit but we can get it by intersecting with a tracked query, we validate that.\r\n- Otherwise we let things slide and give up.\r\n\r\nNote that in doing this I addressed the TODO comment and moved the code that deals with fields on the fat parent outside the conditional, so that it runs even when we don't have any tracked queries. That TODO predates even the open source release of Relay, so if somebody has context on if this is a terrible idea, please let me know."},"comment":{"url":"https://api.github.com/repos/facebook/relay/issues/comments/205519010","html_url":"https://github.com/facebook/relay/pull/1017#issuecomment-205519010","issue_url":"https://api.github.com/repos/facebook/relay/issues/1017","id":205519010,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T22:15:03Z","updated_at":"2016-04-04T22:15:03Z","body":"Thanks for importing. If you are an FB employee go to [Phabricator](https://our.intern.facebook.com/intern/opensource/github/pull_request/1526261181014626/int_phab) to review."}}