{"action":"created","issue":{"url":"https://api.github.com/repos/AtomLinter/linter-php/issues/218","repository_url":"https://api.github.com/repos/AtomLinter/linter-php","labels_url":"https://api.github.com/repos/AtomLinter/linter-php/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/AtomLinter/linter-php/issues/218/comments","events_url":"https://api.github.com/repos/AtomLinter/linter-php/issues/218/events","html_url":"https://github.com/AtomLinter/linter-php/issues/218","id":184109814,"number":218,"title":"php -l can get really really slow","user":{"login":"jeanrajotte","id":312996,"avatar_url":"https://avatars.githubusercontent.com/u/312996?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanrajotte","html_url":"https://github.com/jeanrajotte","followers_url":"https://api.github.com/users/jeanrajotte/followers","following_url":"https://api.github.com/users/jeanrajotte/following{/other_user}","gists_url":"https://api.github.com/users/jeanrajotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanrajotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanrajotte/subscriptions","organizations_url":"https://api.github.com/users/jeanrajotte/orgs","repos_url":"https://api.github.com/users/jeanrajotte/repos","events_url":"https://api.github.com/users/jeanrajotte/events{/privacy}","received_events_url":"https://api.github.com/users/jeanrajotte/received_events","type":"User","site_admin":false},"labels":[{"id":99047727,"url":"https://api.github.com/repos/AtomLinter/linter-php/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-10-20T00:47:29Z","updated_at":"2016-11-25T01:37:29Z","closed_at":null,"body":"I found the plugin became super slow. I think something changed in my _php.ini_, so each invocation of `php -l` by the package became very slow, making the JIT linting an aggravation.\n\nI added `-n` to the invocation of php, which bypasses loading _php.ini_, and we're back to being lightning fast.\n\nSo, \n1. Could \"-n\" be added permanently to the invocation, or is there something in _php.ini_ that configures `-l` somehow?  Or,\n2. Could there be a setting so the user can add whatever additional command line argument they see fit?\n\nI vote for option 2, but it's more work.\n"},"comment":{"url":"https://api.github.com/repos/AtomLinter/linter-php/issues/comments/262864354","html_url":"https://github.com/AtomLinter/linter-php/issues/218#issuecomment-262864354","issue_url":"https://api.github.com/repos/AtomLinter/linter-php/issues/218","id":262864354,"user":{"login":"ubergeekzone","id":6809045,"avatar_url":"https://avatars.githubusercontent.com/u/6809045?v=3","gravatar_id":"","url":"https://api.github.com/users/ubergeekzone","html_url":"https://github.com/ubergeekzone","followers_url":"https://api.github.com/users/ubergeekzone/followers","following_url":"https://api.github.com/users/ubergeekzone/following{/other_user}","gists_url":"https://api.github.com/users/ubergeekzone/gists{/gist_id}","starred_url":"https://api.github.com/users/ubergeekzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubergeekzone/subscriptions","organizations_url":"https://api.github.com/users/ubergeekzone/orgs","repos_url":"https://api.github.com/users/ubergeekzone/repos","events_url":"https://api.github.com/users/ubergeekzone/events{/privacy}","received_events_url":"https://api.github.com/users/ubergeekzone/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T01:37:29Z","updated_at":"2016-11-25T01:37:29Z","body":" No Syntax errors, i understand how atom is wrote. It works fine but a\nlittle slow until i added that line of code. Was strange is after i take\naway that line of code i added it wont work until I reinstall the\nlinter-php package. Did you add -n before you installed the package or\nafter?\n\nOn Thu, Nov 24, 2016 at 8:31 PM Jean Rajotte <notifications@github.com>\nwrote:\n\n> Did you introduce a syntax error in your change main.js file? That would\n> explain such drastic malfunction.\n>\n> In case you don't know this: Atom is written in Javascript. The plugins\n> are written in JS also.\n>\n> This plugin invokes PHP to do the linting. The JS array we're changing w/\n> the adding of\n>\n>    `'-n',`\n>\n> just contains the command line arguments that'll be given to PHP when it's\n> invoked for linting.\n>\n> The -n switch is telling PHP to not load its php.ini file(s) when\n> starting. Hence the speed gain. I really don't know whether under some\n> circumstances PHP *does need* php.ini in order to lint properly. It\n> doesn't on my machine, so this fix worked for me.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/AtomLinter/linter-php/issues/218#issuecomment-262863858>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGfl1avVy7B9K-IZ77ldY57Hm1SOUxcLks5rBjpugaJpZM4KbnEA>\n> .\n>\n-- \nSent from iPhone\n"}}
{"actor":{"display_login":"ubergeekzone"}}