{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/79939056","id":79939056,"diff_hunk":"@@ -82,28 +82,41 @@ static constexpr int64_t DEFAULT_PAGE_SIZE = 1024 * 1024;\n static constexpr bool DEFAULT_IS_DICTIONARY_ENABLED = true;\n static constexpr int64_t DEFAULT_DICTIONARY_PAGE_SIZE_LIMIT = DEFAULT_PAGE_SIZE;\n static constexpr int64_t DEFAULT_WRITE_BATCH_SIZE = 1024;\n+static constexpr bool DEFAULT_COLLECT_STATISTICS = false;","path":"src/parquet/column/properties.h","position":null,"original_position":4,"commit_id":"c3ed17ffea9160af2bb2ac1070e3ef533a96345c","original_commit_id":"461865ba635247a46d8a85f1b83e479a1a1a4d49","user":{"login":"lomereiter","id":662555,"avatar_url":"https://avatars.githubusercontent.com/u/662555?v=3","gravatar_id":"","url":"https://api.github.com/users/lomereiter","html_url":"https://github.com/lomereiter","followers_url":"https://api.github.com/users/lomereiter/followers","following_url":"https://api.github.com/users/lomereiter/following{/other_user}","gists_url":"https://api.github.com/users/lomereiter/gists{/gist_id}","starred_url":"https://api.github.com/users/lomereiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomereiter/subscriptions","organizations_url":"https://api.github.com/users/lomereiter/orgs","repos_url":"https://api.github.com/users/lomereiter/repos","events_url":"https://api.github.com/users/lomereiter/events{/privacy}","received_events_url":"https://api.github.com/users/lomereiter/received_events","type":"User","site_admin":false},"body":"I checked and they are indeed enabled by default. However, if values of min/max are large (> 4KB) they are not written (https://issues.apache.org/jira/browse/PARQUET-372).","created_at":"2016-09-21T21:40:22Z","updated_at":"2016-09-21T21:40:22Z","html_url":"https://github.com/apache/parquet-cpp/pull/129#discussion_r79939056","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/79939056"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/129#discussion_r79939056"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/129","id":75237341,"html_url":"https://github.com/apache/parquet-cpp/pull/129","diff_url":"https://github.com/apache/parquet-cpp/pull/129.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/129.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/129","number":129,"state":"open","locked":false,"title":"PARQUET-593: Add API for writing Page statistics","user":{"login":"lomereiter","id":662555,"avatar_url":"https://avatars.githubusercontent.com/u/662555?v=3","gravatar_id":"","url":"https://api.github.com/users/lomereiter","html_url":"https://github.com/lomereiter","followers_url":"https://api.github.com/users/lomereiter/followers","following_url":"https://api.github.com/users/lomereiter/following{/other_user}","gists_url":"https://api.github.com/users/lomereiter/gists{/gist_id}","starred_url":"https://api.github.com/users/lomereiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomereiter/subscriptions","organizations_url":"https://api.github.com/users/lomereiter/orgs","repos_url":"https://api.github.com/users/lomereiter/repos","events_url":"https://api.github.com/users/lomereiter/events{/privacy}","received_events_url":"https://api.github.com/users/lomereiter/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-26T18:44:21Z","updated_at":"2016-09-21T21:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2cc21a74b962afc81ca0f9184a033ee1f50c9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/129/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/129/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/129/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/c3ed17ffea9160af2bb2ac1070e3ef533a96345c","head":{"label":"lomereiter:parquet-593","ref":"parquet-593","sha":"c3ed17ffea9160af2bb2ac1070e3ef533a96345c","user":{"login":"lomereiter","id":662555,"avatar_url":"https://avatars.githubusercontent.com/u/662555?v=3","gravatar_id":"","url":"https://api.github.com/users/lomereiter","html_url":"https://github.com/lomereiter","followers_url":"https://api.github.com/users/lomereiter/followers","following_url":"https://api.github.com/users/lomereiter/following{/other_user}","gists_url":"https://api.github.com/users/lomereiter/gists{/gist_id}","starred_url":"https://api.github.com/users/lomereiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomereiter/subscriptions","organizations_url":"https://api.github.com/users/lomereiter/orgs","repos_url":"https://api.github.com/users/lomereiter/repos","events_url":"https://api.github.com/users/lomereiter/events{/privacy}","received_events_url":"https://api.github.com/users/lomereiter/received_events","type":"User","site_admin":false},"repo":{"id":61423005,"name":"parquet-cpp","full_name":"lomereiter/parquet-cpp","owner":{"login":"lomereiter","id":662555,"avatar_url":"https://avatars.githubusercontent.com/u/662555?v=3","gravatar_id":"","url":"https://api.github.com/users/lomereiter","html_url":"https://github.com/lomereiter","followers_url":"https://api.github.com/users/lomereiter/followers","following_url":"https://api.github.com/users/lomereiter/following{/other_user}","gists_url":"https://api.github.com/users/lomereiter/gists{/gist_id}","starred_url":"https://api.github.com/users/lomereiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomereiter/subscriptions","organizations_url":"https://api.github.com/users/lomereiter/orgs","repos_url":"https://api.github.com/users/lomereiter/repos","events_url":"https://api.github.com/users/lomereiter/events{/privacy}","received_events_url":"https://api.github.com/users/lomereiter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lomereiter/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/lomereiter/parquet-cpp","forks_url":"https://api.github.com/repos/lomereiter/parquet-cpp/forks","keys_url":"https://api.github.com/repos/lomereiter/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lomereiter/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lomereiter/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/lomereiter/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/lomereiter/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/lomereiter/parquet-cpp/events","assignees_url":"https://api.github.com/repos/lomereiter/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/lomereiter/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/lomereiter/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/lomereiter/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lomereiter/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lomereiter/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lomereiter/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lomereiter/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/lomereiter/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/lomereiter/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/lomereiter/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/lomereiter/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/lomereiter/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/lomereiter/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lomereiter/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lomereiter/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lomereiter/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lomereiter/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/lomereiter/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lomereiter/parquet-cpp/merges","archive_url":"https://api.github.com/repos/lomereiter/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lomereiter/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/lomereiter/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/lomereiter/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/lomereiter/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/lomereiter/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lomereiter/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/lomereiter/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/lomereiter/parquet-cpp/deployments","created_at":"2016-06-18T07:47:14Z","updated_at":"2016-06-18T07:47:16Z","pushed_at":"2016-09-21T21:37:26Z","git_url":"git://github.com/lomereiter/parquet-cpp.git","ssh_url":"git@github.com:lomereiter/parquet-cpp.git","clone_url":"https://github.com/lomereiter/parquet-cpp.git","svn_url":"https://github.com/lomereiter/parquet-cpp","homepage":null,"size":1090,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4a7bf1174419db6b2e4fc1847d866c4763b7be44","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-09-20T20:28:43Z","pushed_at":"2016-09-21T21:37:26Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":1588,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":3,"forks":40,"open_issues":3,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/129"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/129"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/129"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/c3ed17ffea9160af2bb2ac1070e3ef533a96345c"}}}}
{"actor":{"display_login":"lomereiter"}}