{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/contactlab/saray/pulls/8","id":89174321,"html_url":"https://github.com/contactlab/saray/pull/8","diff_url":"https://github.com/contactlab/saray/pull/8.diff","patch_url":"https://github.com/contactlab/saray/pull/8.patch","issue_url":"https://api.github.com/repos/contactlab/saray/issues/8","number":8,"state":"closed","locked":false,"title":"handle OPTIONS request in a better way","user":{"login":"tsriram","id":450559,"avatar_url":"https://avatars.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"body":"Have modified the header `Access-Control-Allow-Methods` to include only GET & POST now. I'm not sure if we need other methods as they don't serve the purpose they're meant for. For example, we're not deleting a resource when we get a DELETE request. This came across my mind when I wanted to send allowed methods for an OPTIONS request. Would like to hear from you on how to go about it.","created_at":"2016-10-13T10:21:54Z","updated_at":"2016-10-14T08:50:39Z","closed_at":"2016-10-14T08:50:39Z","merged_at":"2016-10-14T08:50:39Z","merge_commit_sha":"f91b79e1b04455c09ae5a1c8017ec3c6b96c4bc0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/contactlab/saray/pulls/8/commits","review_comments_url":"https://api.github.com/repos/contactlab/saray/pulls/8/comments","review_comment_url":"https://api.github.com/repos/contactlab/saray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contactlab/saray/issues/8/comments","statuses_url":"https://api.github.com/repos/contactlab/saray/statuses/d6aa844b1971ffdac7d9584fd9d799d19e66a78b","head":{"label":"tsriram:handle_options","ref":"handle_options","sha":"d6aa844b1971ffdac7d9584fd9d799d19e66a78b","user":{"login":"tsriram","id":450559,"avatar_url":"https://avatars.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"repo":{"id":70774401,"name":"saray","full_name":"tsriram/saray","owner":{"login":"tsriram","id":450559,"avatar_url":"https://avatars.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsriram/saray","description":"'Yet Another Rest API Stubber'.split(' ').reverse().map(item => item[0].toLowerCase()).join('')","fork":true,"url":"https://api.github.com/repos/tsriram/saray","forks_url":"https://api.github.com/repos/tsriram/saray/forks","keys_url":"https://api.github.com/repos/tsriram/saray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsriram/saray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsriram/saray/teams","hooks_url":"https://api.github.com/repos/tsriram/saray/hooks","issue_events_url":"https://api.github.com/repos/tsriram/saray/issues/events{/number}","events_url":"https://api.github.com/repos/tsriram/saray/events","assignees_url":"https://api.github.com/repos/tsriram/saray/assignees{/user}","branches_url":"https://api.github.com/repos/tsriram/saray/branches{/branch}","tags_url":"https://api.github.com/repos/tsriram/saray/tags","blobs_url":"https://api.github.com/repos/tsriram/saray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsriram/saray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsriram/saray/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsriram/saray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsriram/saray/statuses/{sha}","languages_url":"https://api.github.com/repos/tsriram/saray/languages","stargazers_url":"https://api.github.com/repos/tsriram/saray/stargazers","contributors_url":"https://api.github.com/repos/tsriram/saray/contributors","subscribers_url":"https://api.github.com/repos/tsriram/saray/subscribers","subscription_url":"https://api.github.com/repos/tsriram/saray/subscription","commits_url":"https://api.github.com/repos/tsriram/saray/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsriram/saray/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsriram/saray/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsriram/saray/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsriram/saray/contents/{+path}","compare_url":"https://api.github.com/repos/tsriram/saray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsriram/saray/merges","archive_url":"https://api.github.com/repos/tsriram/saray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsriram/saray/downloads","issues_url":"https://api.github.com/repos/tsriram/saray/issues{/number}","pulls_url":"https://api.github.com/repos/tsriram/saray/pulls{/number}","milestones_url":"https://api.github.com/repos/tsriram/saray/milestones{/number}","notifications_url":"https://api.github.com/repos/tsriram/saray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsriram/saray/labels{/name}","releases_url":"https://api.github.com/repos/tsriram/saray/releases{/id}","deployments_url":"https://api.github.com/repos/tsriram/saray/deployments","created_at":"2016-10-13T06:07:24Z","updated_at":"2016-10-13T06:07:25Z","pushed_at":"2016-10-14T07:37:06Z","git_url":"git://github.com/tsriram/saray.git","ssh_url":"git@github.com:tsriram/saray.git","clone_url":"https://github.com/tsriram/saray.git","svn_url":"https://github.com/tsriram/saray","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contactlab:develop","ref":"develop","sha":"9497f2da2aabbcba2ef04574fffd88aed8d79a9f","user":{"login":"contactlab","id":10923213,"avatar_url":"https://avatars.githubusercontent.com/u/10923213?v=3","gravatar_id":"","url":"https://api.github.com/users/contactlab","html_url":"https://github.com/contactlab","followers_url":"https://api.github.com/users/contactlab/followers","following_url":"https://api.github.com/users/contactlab/following{/other_user}","gists_url":"https://api.github.com/users/contactlab/gists{/gist_id}","starred_url":"https://api.github.com/users/contactlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contactlab/subscriptions","organizations_url":"https://api.github.com/users/contactlab/orgs","repos_url":"https://api.github.com/users/contactlab/repos","events_url":"https://api.github.com/users/contactlab/events{/privacy}","received_events_url":"https://api.github.com/users/contactlab/received_events","type":"Organization","site_admin":false},"repo":{"id":66646285,"name":"saray","full_name":"contactlab/saray","owner":{"login":"contactlab","id":10923213,"avatar_url":"https://avatars.githubusercontent.com/u/10923213?v=3","gravatar_id":"","url":"https://api.github.com/users/contactlab","html_url":"https://github.com/contactlab","followers_url":"https://api.github.com/users/contactlab/followers","following_url":"https://api.github.com/users/contactlab/following{/other_user}","gists_url":"https://api.github.com/users/contactlab/gists{/gist_id}","starred_url":"https://api.github.com/users/contactlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contactlab/subscriptions","organizations_url":"https://api.github.com/users/contactlab/orgs","repos_url":"https://api.github.com/users/contactlab/repos","events_url":"https://api.github.com/users/contactlab/events{/privacy}","received_events_url":"https://api.github.com/users/contactlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contactlab/saray","description":"'Yet Another Rest API Stubber'.split(' ').reverse().map(item => item[0].toLowerCase()).join('')","fork":false,"url":"https://api.github.com/repos/contactlab/saray","forks_url":"https://api.github.com/repos/contactlab/saray/forks","keys_url":"https://api.github.com/repos/contactlab/saray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contactlab/saray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contactlab/saray/teams","hooks_url":"https://api.github.com/repos/contactlab/saray/hooks","issue_events_url":"https://api.github.com/repos/contactlab/saray/issues/events{/number}","events_url":"https://api.github.com/repos/contactlab/saray/events","assignees_url":"https://api.github.com/repos/contactlab/saray/assignees{/user}","branches_url":"https://api.github.com/repos/contactlab/saray/branches{/branch}","tags_url":"https://api.github.com/repos/contactlab/saray/tags","blobs_url":"https://api.github.com/repos/contactlab/saray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contactlab/saray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contactlab/saray/git/refs{/sha}","trees_url":"https://api.github.com/repos/contactlab/saray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contactlab/saray/statuses/{sha}","languages_url":"https://api.github.com/repos/contactlab/saray/languages","stargazers_url":"https://api.github.com/repos/contactlab/saray/stargazers","contributors_url":"https://api.github.com/repos/contactlab/saray/contributors","subscribers_url":"https://api.github.com/repos/contactlab/saray/subscribers","subscription_url":"https://api.github.com/repos/contactlab/saray/subscription","commits_url":"https://api.github.com/repos/contactlab/saray/commits{/sha}","git_commits_url":"https://api.github.com/repos/contactlab/saray/git/commits{/sha}","comments_url":"https://api.github.com/repos/contactlab/saray/comments{/number}","issue_comment_url":"https://api.github.com/repos/contactlab/saray/issues/comments{/number}","contents_url":"https://api.github.com/repos/contactlab/saray/contents/{+path}","compare_url":"https://api.github.com/repos/contactlab/saray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contactlab/saray/merges","archive_url":"https://api.github.com/repos/contactlab/saray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contactlab/saray/downloads","issues_url":"https://api.github.com/repos/contactlab/saray/issues{/number}","pulls_url":"https://api.github.com/repos/contactlab/saray/pulls{/number}","milestones_url":"https://api.github.com/repos/contactlab/saray/milestones{/number}","notifications_url":"https://api.github.com/repos/contactlab/saray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contactlab/saray/labels{/name}","releases_url":"https://api.github.com/repos/contactlab/saray/releases{/id}","deployments_url":"https://api.github.com/repos/contactlab/saray/deployments","created_at":"2016-08-26T12:34:09Z","updated_at":"2016-10-13T14:38:27Z","pushed_at":"2016-10-14T08:50:39Z","git_url":"git://github.com/contactlab/saray.git","ssh_url":"git@github.com:contactlab/saray.git","clone_url":"https://github.com/contactlab/saray.git","svn_url":"https://github.com/contactlab/saray","homepage":null,"size":18,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contactlab/saray/pulls/8"},"html":{"href":"https://github.com/contactlab/saray/pull/8"},"issue":{"href":"https://api.github.com/repos/contactlab/saray/issues/8"},"comments":{"href":"https://api.github.com/repos/contactlab/saray/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/contactlab/saray/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/contactlab/saray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contactlab/saray/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/contactlab/saray/statuses/d6aa844b1971ffdac7d9584fd9d799d19e66a78b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pferretti","id":1481654,"avatar_url":"https://avatars.githubusercontent.com/u/1481654?v=3","gravatar_id":"","url":"https://api.github.com/users/pferretti","html_url":"https://github.com/pferretti","followers_url":"https://api.github.com/users/pferretti/followers","following_url":"https://api.github.com/users/pferretti/following{/other_user}","gists_url":"https://api.github.com/users/pferretti/gists{/gist_id}","starred_url":"https://api.github.com/users/pferretti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferretti/subscriptions","organizations_url":"https://api.github.com/users/pferretti/orgs","repos_url":"https://api.github.com/users/pferretti/repos","events_url":"https://api.github.com/users/pferretti/events{/privacy}","received_events_url":"https://api.github.com/users/pferretti/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":4,"additions":28,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"pferretti"}}