{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/90882060","pull_request_review_id":11395506,"id":90882060,"diff_hunk":"@@ -250,7 +254,30 @@ func (c *connection) ImageByTag(namespace, name, tag string) (*Image, error) {\n \t\treturn nil, err\n \t}\n \n-\treturn repo.getTaggedImage(c, searchTag, tag)\n+\timage, _, err := repo.getTaggedImage(c, searchTag, tag)\n+\treturn image, err\n+}\n+\n+// ImageManifest returns raw manifest of the specified image within the named Docker image repository\n+func (c *connection) ImageManifest(namespace, name, tag string) (string, []byte, error) {","path":"pkg/dockerregistry/client.go","position":30,"original_position":30,"commit_id":"5be4fa023fb94f6a32c0eb20e4835551db73efe6","original_commit_id":"5be4fa023fb94f6a32c0eb20e4835551db73efe6","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"A unit test would be awesome.","created_at":"2016-12-05T15:06:44Z","updated_at":"2016-12-05T15:06:44Z","html_url":"https://github.com/openshift/origin/pull/11925#discussion_r90882060","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11925","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/90882060"},"html":{"href":"https://github.com/openshift/origin/pull/11925#discussion_r90882060"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11925"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11925","id":93848751,"html_url":"https://github.com/openshift/origin/pull/11925","diff_url":"https://github.com/openshift/origin/pull/11925.diff","patch_url":"https://github.com/openshift/origin/pull/11925.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11925","number":11925,"state":"open","locked":false,"title":"Remove manifest from Image","user":{"login":"legionus","id":1690313,"avatar_url":"https://avatars.githubusercontent.com/u/1690313?v=3","gravatar_id":"","url":"https://api.github.com/users/legionus","html_url":"https://github.com/legionus","followers_url":"https://api.github.com/users/legionus/followers","following_url":"https://api.github.com/users/legionus/following{/other_user}","gists_url":"https://api.github.com/users/legionus/gists{/gist_id}","starred_url":"https://api.github.com/users/legionus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legionus/subscriptions","organizations_url":"https://api.github.com/users/legionus/orgs","repos_url":"https://api.github.com/users/legionus/repos","events_url":"https://api.github.com/users/legionus/events{/privacy}","received_events_url":"https://api.github.com/users/legionus/received_events","type":"User","site_admin":false},"body":"We need to remove manifest from `Image` to reduce the amount of occupied etcd data. The docker-registry will store the manifest in the storage (where it stores the blobs). It removes the manifest from the `Image` after fills in  all metadata fields. The manifest will be removed when importing the image from an external `docker/distribution`.\r\n\r\n@miminar @soltysh @mfojtik please review.","created_at":"2016-11-15T21:10:40Z","updated_at":"2016-12-05T15:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9406b1dced5632db0774ccfab44afe3dd14e6b8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11925/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11925/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11925/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/5be4fa023fb94f6a32c0eb20e4835551db73efe6","head":{"label":"legionus:reduce-etcd","ref":"reduce-etcd","sha":"5be4fa023fb94f6a32c0eb20e4835551db73efe6","user":{"login":"legionus","id":1690313,"avatar_url":"https://avatars.githubusercontent.com/u/1690313?v=3","gravatar_id":"","url":"https://api.github.com/users/legionus","html_url":"https://github.com/legionus","followers_url":"https://api.github.com/users/legionus/followers","following_url":"https://api.github.com/users/legionus/following{/other_user}","gists_url":"https://api.github.com/users/legionus/gists{/gist_id}","starred_url":"https://api.github.com/users/legionus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legionus/subscriptions","organizations_url":"https://api.github.com/users/legionus/orgs","repos_url":"https://api.github.com/users/legionus/repos","events_url":"https://api.github.com/users/legionus/events{/privacy}","received_events_url":"https://api.github.com/users/legionus/received_events","type":"User","site_admin":false},"repo":{"id":49266113,"name":"origin","full_name":"legionus/origin","owner":{"login":"legionus","id":1690313,"avatar_url":"https://avatars.githubusercontent.com/u/1690313?v=3","gravatar_id":"","url":"https://api.github.com/users/legionus","html_url":"https://github.com/legionus","followers_url":"https://api.github.com/users/legionus/followers","following_url":"https://api.github.com/users/legionus/following{/other_user}","gists_url":"https://api.github.com/users/legionus/gists{/gist_id}","starred_url":"https://api.github.com/users/legionus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legionus/subscriptions","organizations_url":"https://api.github.com/users/legionus/orgs","repos_url":"https://api.github.com/users/legionus/repos","events_url":"https://api.github.com/users/legionus/events{/privacy}","received_events_url":"https://api.github.com/users/legionus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/legionus/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/legionus/origin","forks_url":"https://api.github.com/repos/legionus/origin/forks","keys_url":"https://api.github.com/repos/legionus/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legionus/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legionus/origin/teams","hooks_url":"https://api.github.com/repos/legionus/origin/hooks","issue_events_url":"https://api.github.com/repos/legionus/origin/issues/events{/number}","events_url":"https://api.github.com/repos/legionus/origin/events","assignees_url":"https://api.github.com/repos/legionus/origin/assignees{/user}","branches_url":"https://api.github.com/repos/legionus/origin/branches{/branch}","tags_url":"https://api.github.com/repos/legionus/origin/tags","blobs_url":"https://api.github.com/repos/legionus/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legionus/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legionus/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/legionus/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legionus/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/legionus/origin/languages","stargazers_url":"https://api.github.com/repos/legionus/origin/stargazers","contributors_url":"https://api.github.com/repos/legionus/origin/contributors","subscribers_url":"https://api.github.com/repos/legionus/origin/subscribers","subscription_url":"https://api.github.com/repos/legionus/origin/subscription","commits_url":"https://api.github.com/repos/legionus/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/legionus/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/legionus/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/legionus/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/legionus/origin/contents/{+path}","compare_url":"https://api.github.com/repos/legionus/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legionus/origin/merges","archive_url":"https://api.github.com/repos/legionus/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legionus/origin/downloads","issues_url":"https://api.github.com/repos/legionus/origin/issues{/number}","pulls_url":"https://api.github.com/repos/legionus/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/legionus/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/legionus/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legionus/origin/labels{/name}","releases_url":"https://api.github.com/repos/legionus/origin/releases{/id}","deployments_url":"https://api.github.com/repos/legionus/origin/deployments","created_at":"2016-01-08T10:32:30Z","updated_at":"2016-07-15T15:52:46Z","pushed_at":"2016-12-05T14:57:23Z","git_url":"git://github.com/legionus/origin.git","ssh_url":"git@github.com:legionus/origin.git","clone_url":"https://github.com/legionus/origin.git","svn_url":"https://github.com/legionus/origin","homepage":"http://www.openshift.org","size":409366,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"de44433dd288ca65e8ae64b91fef76f887aebe4c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-12-05T14:36:44Z","pushed_at":"2016-12-05T14:57:24Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":663327,"stargazers_count":2109,"watchers_count":2109,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1393,"mirror_url":null,"open_issues_count":1158,"forks":1393,"open_issues":1158,"watchers":2109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11925"},"html":{"href":"https://github.com/openshift/origin/pull/11925"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11925"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11925/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11925/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11925/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/5be4fa023fb94f6a32c0eb20e4835551db73efe6"}}}}
{"actor":{"display_login":"miminar"}}