{"action":"created","comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/48711831","id":48711831,"diff_hunk":"@@ -2086,7 +2086,7 @@ bool FramebufferManager::GetDepthbuffer(u32 fb_address, int fb_stride, u32 z_add\n \tif (vfb->fbo)\n \t\tfbo_bind_for_read(vfb->fbo);\n \tif (gl_extensions.GLES3 || !gl_extensions.IsGLES)\n-\t\tglReadBuffer(GL_DEPTH_ATTACHMENT);\n+\t\tglReadBuffer(GL_COLOR_ATTACHMENT0);","path":"GPU/GLES/Framebuffer.cpp","position":5,"original_position":5,"commit_id":"79263a73e59f8ddfc1a481df7552d2f24e32d120","original_commit_id":"79263a73e59f8ddfc1a481df7552d2f24e32d120","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"body":"I don't think we ever switch to GL_COLOR_ATTACHMENT1 or higher to this is probably redundant. But hey, doesn't hurt.","created_at":"2016-01-04T08:44:25Z","updated_at":"2016-01-04T08:44:25Z","html_url":"https://github.com/hrydgard/ppsspp/pull/8377#discussion_r48711831","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/48711831"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/8377#discussion_r48711831"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377"}}},"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377","id":54934544,"html_url":"https://github.com/hrydgard/ppsspp/pull/8377","diff_url":"https://github.com/hrydgard/ppsspp/pull/8377.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/8377.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8377","number":8377,"state":"open","locked":false,"title":"Improve some ifdef usage, minor GL error fix","user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"body":"This should make it easier to deal with ports that have _WIN32 or _MSC_VER defined, such as Windows 10.\r\n\r\n-[Unknown]","created_at":"2016-01-03T23:12:57Z","updated_at":"2016-01-04T08:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a73caece263865e8f92c872083b6c0d946d1c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8377/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/79263a73e59f8ddfc1a481df7552d2f24e32d120","head":{"label":"unknownbrackets:minor","ref":"minor","sha":"79263a73e59f8ddfc1a481df7552d2f24e32d120","user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"repo":{"id":6645850,"name":"ppsspp","full_name":"unknownbrackets/ppsspp","owner":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unknownbrackets/ppsspp","description":"A PSP emulator for many platforms, written in C++. This is a fork of the primary repo, where testing branches are pushed.","fork":true,"url":"https://api.github.com/repos/unknownbrackets/ppsspp","forks_url":"https://api.github.com/repos/unknownbrackets/ppsspp/forks","keys_url":"https://api.github.com/repos/unknownbrackets/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unknownbrackets/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unknownbrackets/ppsspp/teams","hooks_url":"https://api.github.com/repos/unknownbrackets/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/unknownbrackets/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/unknownbrackets/ppsspp/events","assignees_url":"https://api.github.com/repos/unknownbrackets/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/unknownbrackets/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/unknownbrackets/ppsspp/tags","blobs_url":"https://api.github.com/repos/unknownbrackets/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unknownbrackets/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unknownbrackets/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/unknownbrackets/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unknownbrackets/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/unknownbrackets/ppsspp/languages","stargazers_url":"https://api.github.com/repos/unknownbrackets/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/unknownbrackets/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/unknownbrackets/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/unknownbrackets/ppsspp/subscription","commits_url":"https://api.github.com/repos/unknownbrackets/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/unknownbrackets/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/unknownbrackets/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/unknownbrackets/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/unknownbrackets/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/unknownbrackets/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unknownbrackets/ppsspp/merges","archive_url":"https://api.github.com/repos/unknownbrackets/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unknownbrackets/ppsspp/downloads","issues_url":"https://api.github.com/repos/unknownbrackets/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/unknownbrackets/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/unknownbrackets/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/unknownbrackets/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unknownbrackets/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/unknownbrackets/ppsspp/releases{/id}","created_at":"2012-11-11T23:10:45Z","updated_at":"2015-04-28T16:12:11Z","pushed_at":"2016-01-04T07:51:20Z","git_url":"git://github.com/unknownbrackets/ppsspp.git","ssh_url":"git@github.com:unknownbrackets/ppsspp.git","clone_url":"https://github.com/unknownbrackets/ppsspp.git","svn_url":"https://github.com/unknownbrackets/ppsspp","homepage":"http://www.ppsspp.org","size":103278,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"055aa0c881afe4ac10f3c067fcfa5a9cfaedc9e6","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","created_at":"2012-11-01T08:41:48Z","updated_at":"2016-01-03T04:10:48Z","pushed_at":"2016-01-04T08:43:15Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":417379,"stargazers_count":2049,"watchers_count":2049,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":845,"mirror_url":null,"open_issues_count":573,"forks":845,"open_issues":573,"watchers":2049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/8377"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8377"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8377/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8377/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/79263a73e59f8ddfc1a481df7552d2f24e32d120"}}}}