{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material/pulls/comments/61825412","id":61825412,"diff_hunk":"@@ -558,17 +562,22 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp\n   }\n \n   /**\n+   * Calculates the width of the pagination wrapper by summing the widths of the dummy tabs.\n    * @returns {number}\n    */\n   function calcPagingWidth () {\n-    var width = 1;\n+    return calcTabsWidth(getElements().dummies);\n+  }\n+\n+  function calcTabsWidth(tabs) {\n+    var width = 0;","path":"src/components/tabs/js/tabsController.js","position":26,"original_position":26,"commit_id":"7d8be35b1b5c04a2ca14d107276c2a0620304c2a","original_commit_id":"7d8be35b1b5c04a2ca14d107276c2a0620304c2a","user":{"login":"robertmesserle","id":571363,"avatar_url":"https://avatars.githubusercontent.com/u/571363?v=3","gravatar_id":"","url":"https://api.github.com/users/robertmesserle","html_url":"https://github.com/robertmesserle","followers_url":"https://api.github.com/users/robertmesserle/followers","following_url":"https://api.github.com/users/robertmesserle/following{/other_user}","gists_url":"https://api.github.com/users/robertmesserle/gists{/gist_id}","starred_url":"https://api.github.com/users/robertmesserle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertmesserle/subscriptions","organizations_url":"https://api.github.com/users/robertmesserle/orgs","repos_url":"https://api.github.com/users/robertmesserle/repos","events_url":"https://api.github.com/users/robertmesserle/events{/privacy}","received_events_url":"https://api.github.com/users/robertmesserle/received_events","type":"User","site_admin":false},"body":"I'll also note that this is added in response to issues with tabs living inside of dialogs, so you might try creating that sort of test case and see if any bugs show up.","created_at":"2016-05-03T00:12:01Z","updated_at":"2016-05-03T00:12:01Z","html_url":"https://github.com/angular/material/pull/8293#discussion_r61825412","pull_request_url":"https://api.github.com/repos/angular/material/pulls/8293","_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/comments/61825412"},"html":{"href":"https://github.com/angular/material/pull/8293#discussion_r61825412"},"pull_request":{"href":"https://api.github.com/repos/angular/material/pulls/8293"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/8293","id":68494368,"html_url":"https://github.com/angular/material/pull/8293","diff_url":"https://github.com/angular/material/pull/8293.diff","patch_url":"https://github.com/angular/material/pull/8293.patch","issue_url":"https://api.github.com/repos/angular/material/issues/8293","number":8293,"state":"open","locked":false,"title":"fix(tabs): avoid width calculation deviations.","user":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"body":"* Currently when using centered tabs, the `updateInkBarStyles` method is getting executed infinitely (even without $$rAF, sync)\r\n This is impacting the performance significant, because we're calculating the styles on each function call.\r\n\r\nThe problem is, that the pagination wrapper uses another rounding process than the `updateInkBarStyle` method.\r\nNow both calculations are using the same rounding process / logic and the width's are now correct.\r\n\r\nFixes #8289.","created_at":"2016-05-01T12:00:24Z","updated_at":"2016-05-03T00:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07bd956812177cbea5a7355737462e064f02bd36","assignee":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars.githubusercontent.com/u/210413?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/material/pulls/8293/commits","review_comments_url":"https://api.github.com/repos/angular/material/pulls/8293/comments","review_comment_url":"https://api.github.com/repos/angular/material/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material/issues/8293/comments","statuses_url":"https://api.github.com/repos/angular/material/statuses/7d8be35b1b5c04a2ca14d107276c2a0620304c2a","head":{"label":"DevVersion:fix/tabs-endless-ink-update","ref":"fix/tabs-endless-ink-update","sha":"7d8be35b1b5c04a2ca14d107276c2a0620304c2a","user":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"repo":{"id":45487944,"name":"material","full_name":"DevVersion/material","owner":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DevVersion/material","description":"Material design for Angular","fork":true,"url":"https://api.github.com/repos/DevVersion/material","forks_url":"https://api.github.com/repos/DevVersion/material/forks","keys_url":"https://api.github.com/repos/DevVersion/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevVersion/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevVersion/material/teams","hooks_url":"https://api.github.com/repos/DevVersion/material/hooks","issue_events_url":"https://api.github.com/repos/DevVersion/material/issues/events{/number}","events_url":"https://api.github.com/repos/DevVersion/material/events","assignees_url":"https://api.github.com/repos/DevVersion/material/assignees{/user}","branches_url":"https://api.github.com/repos/DevVersion/material/branches{/branch}","tags_url":"https://api.github.com/repos/DevVersion/material/tags","blobs_url":"https://api.github.com/repos/DevVersion/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevVersion/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevVersion/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevVersion/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevVersion/material/statuses/{sha}","languages_url":"https://api.github.com/repos/DevVersion/material/languages","stargazers_url":"https://api.github.com/repos/DevVersion/material/stargazers","contributors_url":"https://api.github.com/repos/DevVersion/material/contributors","subscribers_url":"https://api.github.com/repos/DevVersion/material/subscribers","subscription_url":"https://api.github.com/repos/DevVersion/material/subscription","commits_url":"https://api.github.com/repos/DevVersion/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevVersion/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevVersion/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevVersion/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevVersion/material/contents/{+path}","compare_url":"https://api.github.com/repos/DevVersion/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevVersion/material/merges","archive_url":"https://api.github.com/repos/DevVersion/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevVersion/material/downloads","issues_url":"https://api.github.com/repos/DevVersion/material/issues{/number}","pulls_url":"https://api.github.com/repos/DevVersion/material/pulls{/number}","milestones_url":"https://api.github.com/repos/DevVersion/material/milestones{/number}","notifications_url":"https://api.github.com/repos/DevVersion/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevVersion/material/labels{/name}","releases_url":"https://api.github.com/repos/DevVersion/material/releases{/id}","deployments_url":"https://api.github.com/repos/DevVersion/material/deployments","created_at":"2015-11-03T18:45:53Z","updated_at":"2016-04-30T12:55:57Z","pushed_at":"2016-05-02T15:25:28Z","git_url":"git://github.com/DevVersion/material.git","ssh_url":"git@github.com:DevVersion/material.git","clone_url":"https://github.com/DevVersion/material.git","svn_url":"https://github.com/DevVersion/material","homepage":"https://material.angularjs.org/","size":42253,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f5af7a12f2149c7df946e27570c78b7da1f13a9c","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material/deployments","created_at":"2014-07-01T19:20:06Z","updated_at":"2016-05-02T22:49:23Z","pushed_at":"2016-05-02T23:27:35Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":80125,"stargazers_count":13400,"watchers_count":13400,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2720,"mirror_url":null,"open_issues_count":579,"forks":2720,"open_issues":579,"watchers":13400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/8293"},"html":{"href":"https://github.com/angular/material/pull/8293"},"issue":{"href":"https://api.github.com/repos/angular/material/issues/8293"},"comments":{"href":"https://api.github.com/repos/angular/material/issues/8293/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material/pulls/8293/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material/pulls/8293/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material/statuses/7d8be35b1b5c04a2ca14d107276c2a0620304c2a"}}}}