{"action":"closed","number":2784,"pull_request":{"url":"https://api.github.com/repos/mperham/sidekiq/pulls/2784","id":56614616,"html_url":"https://github.com/mperham/sidekiq/pull/2784","diff_url":"https://github.com/mperham/sidekiq/pull/2784.diff","patch_url":"https://github.com/mperham/sidekiq/pull/2784.patch","issue_url":"https://api.github.com/repos/mperham/sidekiq/issues/2784","number":2784,"state":"closed","locked":false,"title":"Change relative_time method behaviour","user":{"login":"maxehmookau","id":690977,"avatar_url":"https://avatars.githubusercontent.com/u/690977?v=3","gravatar_id":"","url":"https://api.github.com/users/maxehmookau","html_url":"https://github.com/maxehmookau","followers_url":"https://api.github.com/users/maxehmookau/followers","following_url":"https://api.github.com/users/maxehmookau/following{/other_user}","gists_url":"https://api.github.com/users/maxehmookau/gists{/gist_id}","starred_url":"https://api.github.com/users/maxehmookau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxehmookau/subscriptions","organizations_url":"https://api.github.com/users/maxehmookau/orgs","repos_url":"https://api.github.com/users/maxehmookau/repos","events_url":"https://api.github.com/users/maxehmookau/events{/privacy}","received_events_url":"https://api.github.com/users/maxehmookau/received_events","type":"User","site_admin":false},"body":"This commit updates the `relative_method` on `Sidekiq::WebHelpers` so that it responds with something more specific rather than a Rails-y style *\"3 years from now\"* as it seems to do now (although, only sometimes?) I'm guessing there's some magic in the Rails Time class which overrides the `to_s` method in certain circumstances?\r\n![screen shot 2016-01-20 at 14 29 51](https://cloud.githubusercontent.com/assets/690977/12451597/4c5c3e54-bf82-11e5-8617-cb469e6545d0.png)\r\n\r\nIt also adds a test for this method as there weren't any before.","created_at":"2016-01-20T14:30:35Z","updated_at":"2016-01-20T15:06:47Z","closed_at":"2016-01-20T15:06:47Z","merged_at":null,"merge_commit_sha":"f1a94ad80715b753665e64dcc9b11e6d9249782f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mperham/sidekiq/pulls/2784/commits","review_comments_url":"https://api.github.com/repos/mperham/sidekiq/pulls/2784/comments","review_comment_url":"https://api.github.com/repos/mperham/sidekiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mperham/sidekiq/issues/2784/comments","statuses_url":"https://api.github.com/repos/mperham/sidekiq/statuses/a502123de20cda43c0cfde87a6ed555f9f3ea272","head":{"label":"maxehmookau:specific_relative_time","ref":"specific_relative_time","sha":"a502123de20cda43c0cfde87a6ed555f9f3ea272","user":{"login":"maxehmookau","id":690977,"avatar_url":"https://avatars.githubusercontent.com/u/690977?v=3","gravatar_id":"","url":"https://api.github.com/users/maxehmookau","html_url":"https://github.com/maxehmookau","followers_url":"https://api.github.com/users/maxehmookau/followers","following_url":"https://api.github.com/users/maxehmookau/following{/other_user}","gists_url":"https://api.github.com/users/maxehmookau/gists{/gist_id}","starred_url":"https://api.github.com/users/maxehmookau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxehmookau/subscriptions","organizations_url":"https://api.github.com/users/maxehmookau/orgs","repos_url":"https://api.github.com/users/maxehmookau/repos","events_url":"https://api.github.com/users/maxehmookau/events{/privacy}","received_events_url":"https://api.github.com/users/maxehmookau/received_events","type":"User","site_admin":false},"repo":{"id":50032555,"name":"sidekiq","full_name":"maxehmookau/sidekiq","owner":{"login":"maxehmookau","id":690977,"avatar_url":"https://avatars.githubusercontent.com/u/690977?v=3","gravatar_id":"","url":"https://api.github.com/users/maxehmookau","html_url":"https://github.com/maxehmookau","followers_url":"https://api.github.com/users/maxehmookau/followers","following_url":"https://api.github.com/users/maxehmookau/following{/other_user}","gists_url":"https://api.github.com/users/maxehmookau/gists{/gist_id}","starred_url":"https://api.github.com/users/maxehmookau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxehmookau/subscriptions","organizations_url":"https://api.github.com/users/maxehmookau/orgs","repos_url":"https://api.github.com/users/maxehmookau/repos","events_url":"https://api.github.com/users/maxehmookau/events{/privacy}","received_events_url":"https://api.github.com/users/maxehmookau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxehmookau/sidekiq","description":"Simple, efficient background processing for Ruby","fork":true,"url":"https://api.github.com/repos/maxehmookau/sidekiq","forks_url":"https://api.github.com/repos/maxehmookau/sidekiq/forks","keys_url":"https://api.github.com/repos/maxehmookau/sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxehmookau/sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxehmookau/sidekiq/teams","hooks_url":"https://api.github.com/repos/maxehmookau/sidekiq/hooks","issue_events_url":"https://api.github.com/repos/maxehmookau/sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/maxehmookau/sidekiq/events","assignees_url":"https://api.github.com/repos/maxehmookau/sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/maxehmookau/sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/maxehmookau/sidekiq/tags","blobs_url":"https://api.github.com/repos/maxehmookau/sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxehmookau/sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxehmookau/sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxehmookau/sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxehmookau/sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/maxehmookau/sidekiq/languages","stargazers_url":"https://api.github.com/repos/maxehmookau/sidekiq/stargazers","contributors_url":"https://api.github.com/repos/maxehmookau/sidekiq/contributors","subscribers_url":"https://api.github.com/repos/maxehmookau/sidekiq/subscribers","subscription_url":"https://api.github.com/repos/maxehmookau/sidekiq/subscription","commits_url":"https://api.github.com/repos/maxehmookau/sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxehmookau/sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxehmookau/sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxehmookau/sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxehmookau/sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/maxehmookau/sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxehmookau/sidekiq/merges","archive_url":"https://api.github.com/repos/maxehmookau/sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxehmookau/sidekiq/downloads","issues_url":"https://api.github.com/repos/maxehmookau/sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/maxehmookau/sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/maxehmookau/sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/maxehmookau/sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxehmookau/sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/maxehmookau/sidekiq/releases{/id}","created_at":"2016-01-20T13:41:38Z","updated_at":"2016-01-20T13:41:40Z","pushed_at":"2016-01-20T14:27:58Z","git_url":"git://github.com/maxehmookau/sidekiq.git","ssh_url":"git@github.com:maxehmookau/sidekiq.git","clone_url":"https://github.com/maxehmookau/sidekiq.git","svn_url":"https://github.com/maxehmookau/sidekiq","homepage":"http://sidekiq.org","size":8231,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mperham:master","ref":"master","sha":"865d12755ab97135ff2deb1928cf6890e88ab524","user":{"login":"mperham","id":2911,"avatar_url":"https://avatars.githubusercontent.com/u/2911?v=3","gravatar_id":"","url":"https://api.github.com/users/mperham","html_url":"https://github.com/mperham","followers_url":"https://api.github.com/users/mperham/followers","following_url":"https://api.github.com/users/mperham/following{/other_user}","gists_url":"https://api.github.com/users/mperham/gists{/gist_id}","starred_url":"https://api.github.com/users/mperham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperham/subscriptions","organizations_url":"https://api.github.com/users/mperham/orgs","repos_url":"https://api.github.com/users/mperham/repos","events_url":"https://api.github.com/users/mperham/events{/privacy}","received_events_url":"https://api.github.com/users/mperham/received_events","type":"User","site_admin":false},"repo":{"id":3195124,"name":"sidekiq","full_name":"mperham/sidekiq","owner":{"login":"mperham","id":2911,"avatar_url":"https://avatars.githubusercontent.com/u/2911?v=3","gravatar_id":"","url":"https://api.github.com/users/mperham","html_url":"https://github.com/mperham","followers_url":"https://api.github.com/users/mperham/followers","following_url":"https://api.github.com/users/mperham/following{/other_user}","gists_url":"https://api.github.com/users/mperham/gists{/gist_id}","starred_url":"https://api.github.com/users/mperham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperham/subscriptions","organizations_url":"https://api.github.com/users/mperham/orgs","repos_url":"https://api.github.com/users/mperham/repos","events_url":"https://api.github.com/users/mperham/events{/privacy}","received_events_url":"https://api.github.com/users/mperham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mperham/sidekiq","description":"Simple, efficient background processing for Ruby","fork":false,"url":"https://api.github.com/repos/mperham/sidekiq","forks_url":"https://api.github.com/repos/mperham/sidekiq/forks","keys_url":"https://api.github.com/repos/mperham/sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mperham/sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mperham/sidekiq/teams","hooks_url":"https://api.github.com/repos/mperham/sidekiq/hooks","issue_events_url":"https://api.github.com/repos/mperham/sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/mperham/sidekiq/events","assignees_url":"https://api.github.com/repos/mperham/sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/mperham/sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/mperham/sidekiq/tags","blobs_url":"https://api.github.com/repos/mperham/sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mperham/sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mperham/sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mperham/sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mperham/sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/mperham/sidekiq/languages","stargazers_url":"https://api.github.com/repos/mperham/sidekiq/stargazers","contributors_url":"https://api.github.com/repos/mperham/sidekiq/contributors","subscribers_url":"https://api.github.com/repos/mperham/sidekiq/subscribers","subscription_url":"https://api.github.com/repos/mperham/sidekiq/subscription","commits_url":"https://api.github.com/repos/mperham/sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mperham/sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mperham/sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mperham/sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mperham/sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/mperham/sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mperham/sidekiq/merges","archive_url":"https://api.github.com/repos/mperham/sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mperham/sidekiq/downloads","issues_url":"https://api.github.com/repos/mperham/sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/mperham/sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/mperham/sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/mperham/sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mperham/sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/mperham/sidekiq/releases{/id}","created_at":"2012-01-16T23:17:27Z","updated_at":"2016-01-20T09:28:58Z","pushed_at":"2016-01-20T14:30:36Z","git_url":"git://github.com/mperham/sidekiq.git","ssh_url":"git@github.com:mperham/sidekiq.git","clone_url":"https://github.com/mperham/sidekiq.git","svn_url":"https://github.com/mperham/sidekiq","homepage":"http://sidekiq.org","size":10935,"stargazers_count":5903,"watchers_count":5903,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1026,"mirror_url":null,"open_issues_count":17,"forks":1026,"open_issues":17,"watchers":5903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2784"},"html":{"href":"https://github.com/mperham/sidekiq/pull/2784"},"issue":{"href":"https://api.github.com/repos/mperham/sidekiq/issues/2784"},"comments":{"href":"https://api.github.com/repos/mperham/sidekiq/issues/2784/comments"},"review_comments":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2784/comments"},"review_comment":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2784/commits"},"statuses":{"href":"https://api.github.com/repos/mperham/sidekiq/statuses/a502123de20cda43c0cfde87a6ed555f9f3ea272"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":2}}