{"push_id":1471682489,"size":341,"distinct_size":341,"ref":"refs/heads/fix-throw-message","head":"6c49a29cb3b436fb47d905a9af62f82ca9d5b0ea","before":"791698a7e226360b770be7536c269dd1b4747ee5","commits":[{"sha":"cf719152b01a68bc65f80842799b4c6be0299d78","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"test: refactor test-crypto-timing-safe-equal\n\nAdd RegExp arguments to throws assertions.\n\nPR-URL: https://github.com/nodejs/node/pull/9843\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Teddy Katz <teddy.katz@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/cf719152b01a68bc65f80842799b4c6be0299d78"},{"sha":"18016d3b3fd27fd2744a17a54f15631af6206df1","author":{"name":"brad-decker","email":"cc31f0a9cc9c35b4ad71a38f3ec77c8234f53530@gmail.com"},"message":"test: replace assert.equal with assert.strictEqual\n\nUsing NodeTodo I learned of a need to swap out the .equal function\nwith .strictEqual in a few test files.\n\nhttps://twitter.com/NodeTodo/status/803657321993961472\nhttps://gist.github.com/Trott/864401455d4afa2428cd4814e072bd7c\n\nadditional commits squashed:\n.strictEqual's argument signature is actual, expected, [message].\nPreviously some statements were listed as expected, actual.\nAs asked in PR i swapped them to match the correct argument signature.\n\nPR-URL: https://github.com/nodejs/node/pull/9842\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/18016d3b3fd27fd2744a17a54f15631af6206df1"},{"sha":"517e3a642552679c855595baeff46ff81720fae4","author":{"name":"Trevor Norris","email":"0a8be19b2b7c7ea625a056fed86c35fc02725498@gmail.com"},"message":"async_wrap: mode constructor/destructor to .cc\n\nThe constructor and destructor shouldn't have been placed in the -inl.h\nfile from the beginning.\n\nPR-URL: https://github.com/nodejs/node/pull/9753\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/517e3a642552679c855595baeff46ff81720fae4"},{"sha":"cf5f4b85f5ef7befa592d83b69be646f7efb236a","author":{"name":"Trevor Norris","email":"0a8be19b2b7c7ea625a056fed86c35fc02725498@gmail.com"},"message":"async_wrap: make Initialize a static class member\n\nThis is how it's done everywhere else in core. Make it follow suit.\n\nPR-URL: https://github.com/nodejs/node/pull/9753\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/cf5f4b85f5ef7befa592d83b69be646f7efb236a"},{"sha":"b49b496a92118bf786176bc3c763a292b9bdff5d","author":{"name":"Trevor Norris","email":"0a8be19b2b7c7ea625a056fed86c35fc02725498@gmail.com"},"message":"async_wrap: call destroy() callback in uv_idle_t\n\nCalling JS during GC is a no-no. So intead create a queue of all ids\nthat need to have their destroy() callback called and call them later.\n\nRemoved checking destroy() in test-async-wrap-uid because destroy() can\nbe called after the 'exit' callback.\n\nMissing a reliable test to reproduce the issue that caused the\nFATAL_ERROR.\n\nPR-URL: https://github.com/nodejs/node/pull/9753\nFixes: https://github.com/nodejs/node/issues/8216\nFixes: https://github.com/nodejs/node/issues/9465\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/b49b496a92118bf786176bc3c763a292b9bdff5d"},{"sha":"24a98dd810d0713d736fb82aec284773b855064e","author":{"name":"Teddy Katz","email":"9431307bf9352f2f1a7bd2cbca88613fe84e1247@gmail.com"},"message":"repl: fix generator function preprocessing\n\nFunction declarations in the REPL are preprocessed into variable\ndeclarations before being evaluated. However, the preprocessing logic\ndid not account for the star in a generator function declaration, which\ncaused the preprocessor to output invalid syntax in some circumstances.\n\nPR-URL: https://github.com/nodejs/node/pull/9852\nFixes: https://github.com/nodejs/node/issues/9850\nReviewed-By: Prince John Wesley <princejohnwesley@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/24a98dd810d0713d736fb82aec284773b855064e"},{"sha":"de495c0669345892beb6d9f025e9a9b7b6a59df1","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"test: refactor test-fs-non-number-arguments-throw\n\n* Add RegExp arguments to throws assertions.\n* Use common.mustCall for emitter callback.\n\nPR-URL: https://github.com/nodejs/node/pull/9844\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/de495c0669345892beb6d9f025e9a9b7b6a59df1"},{"sha":"98f9b5df1268a9473bf36a48373fc2b3792b3dd0","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: remove minor contradiction in debugger doc\n\nThe doc says the debugger is and also isn't full-featured. Even if the\nsentences are talking about different things, it's confusing.\n`full-featured` seems superfluous in the first sentence anyway, so\nremove it. Remove a superfluous `simple` while we're at it.\n\nPR-URL: https://github.com/nodejs/node/pull/9832\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/98f9b5df1268a9473bf36a48373fc2b3792b3dd0"},{"sha":"cf2562bf60be77be18acf3514855b0288ed33464","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"test: refactor test-debug-args\n\n* indexOf() -> includes()\n* var -> const\n\nPR-URL: https://github.com/nodejs/node/pull/9833\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Prince John Wesley <princejohnwesley@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/cf2562bf60be77be18acf3514855b0288ed33464"},{"sha":"22752a36cddc0ba2134b6f3f781da411869f1acd","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: update Collaborators list in README\n\nThe Collaborators list in the README has a couple entries of people that\nhave left the Collaborators team in GitHub. This updates the list in the\nREADME accordingly.\n\nPR-URL: https://github.com/nodejs/node/pull/9846\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/22752a36cddc0ba2134b6f3f781da411869f1acd"},{"sha":"479822c45ef527386390227a1f8e086f6128d9e8","author":{"name":"Devon Rifkin","email":"df0664ad91003b8c08be0cf874d855526a636b47@drifkin.net"},"message":"doc: it’s -> its in api/child_process.md\n\nPR-URL: https://github.com/nodejs/node/pull/10090\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/479822c45ef527386390227a1f8e086f6128d9e8"},{"sha":"4658d0c8ce08790b0e9c231bb2d98ca119f972c0","author":{"name":"ben_cripps","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@benjamincripps.com"},"message":"test: use strictEqual in test-debugger-client.js\n\nPR-URL: https://github.com/nodejs/node/pull/9857\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/4658d0c8ce08790b0e9c231bb2d98ca119f972c0"},{"sha":"8e1e15f163f6ec23e242edd3baf67f4b49655aa8","author":{"name":"ben_cripps","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@benjamincripps.com"},"message":"test: use strictEqual in test-zlib-truncated\n\nPR-URL: https://github.com/nodejs/node/pull/9858\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/8e1e15f163f6ec23e242edd3baf67f4b49655aa8"},{"sha":"20fa6e7d07c8c593548330b478c1869adaaf1456","author":{"name":"Walter Beller-Morales","email":"ef12631c73054bd16631dceee0da3792e5ce8b57@gmail.com"},"message":"lib: use === in _http_server and _tls_wrap\n\nMinor fix to favor strict equality in http_server.js and tls_wrap.js\nto ensure accurate comparisons without type coercion.\n\nPR-URL: https://github.com/nodejs/node/pull/9849\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/20fa6e7d07c8c593548330b478c1869adaaf1456"},{"sha":"a912b791d4dd10d694c8b278fea9345f377adf58","author":{"name":"Safia Abdalla","email":"785f548598044ff0af749e97ccdea39aef93ac1e@safia.rocks"},"message":"test: increase coverage for lib/events.js\n\nAdds tests for the case in which listeners() is invoked on a\nEventEmitter with no events.\n\nAdds a new test case for the situation in which a class\ninherits from the EventEmitter but overrides the constructor\nin the EventEmitter so that the _events is never set.\n\nPR-URL: https://github.com/nodejs/node/pull/9865\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Myles Borins <myles.borins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/a912b791d4dd10d694c8b278fea9345f377adf58"},{"sha":"947baaf5b70d9fa653eecf42d7c9fb27b28427bd","author":{"name":"Safia Abdalla","email":"785f548598044ff0af749e97ccdea39aef93ac1e@safia.rocks"},"message":"doc: rename writing_tests.md to writing-tests.md\n\nThe writing_tests.md file did not utilize kebab-case as the other files\nin the directory did.\n\nPR-URL: https://github.com/nodejs/node/pull/9867\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/947baaf5b70d9fa653eecf42d7c9fb27b28427bd"},{"sha":"88924337926372d931be408b6cb19e3930461cdb","author":{"name":"makenova","email":"fc15aa81dbaaf40d3bdc0a303a8d7a9a56d916ec@gmail.com"},"message":"test: refactor test-vm-debug-context\n\nchange var to const or let\nchange assert.equal to assert.strictEqual\n\nPR-URL: https://github.com/nodejs/node/pull/9875\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/88924337926372d931be408b6cb19e3930461cdb"},{"sha":"efa84563f21bbf14c90a8e697478c223b4be20c9","author":{"name":"Adriana Rios","email":"67e32ffe214f18c14b8b827afd4dadaedc5fab9e@gmail.com"},"message":"test: refactor test-tls-ecdh\n\nclear out const/let\nchange assert.notEqual to assert\nmove assert after common.hasCrypto check\n\nPR-URL: https://github.com/nodejs/node/pull/9878\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/efa84563f21bbf14c90a8e697478c223b4be20c9"},{"sha":"c0d11752d9c90d6c1c58f9cfd552b9c78f806cd0","author":{"name":"scalkpdev","email":"a2d5efd65c58a0638144a316ddab89e3a01044bc@kp.org"},"message":"test: update net-local-address-port\n\n- changed var to const\n- changed assert.equal to assert.strictEqual\n\nPR-URL: https://github.com/nodejs/node/pull/9885\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/c0d11752d9c90d6c1c58f9cfd552b9c78f806cd0"},{"sha":"c5ccc50d1f5d2ae451233aa4d6b327d318ed2825","author":{"name":"Ashton Kinslow","email":"f27a17fc90c00d8c248d8510a1084221738b492b@ashtonkinslow.com"},"message":"test: test for http.request() invalid method error\n\nAdds a test for when an invalid http method is passed into\nhttp.request() to verify an error is thrown, that the\nerror is the correct type, and the error message is correct.\n\nPR-URL: https://github.com/nodejs/node/pull/10080\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/russokj/node/commits/c5ccc50d1f5d2ae451233aa4d6b327d318ed2825"}]}
{"actor":{"display_login":"Trott"}}