{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1034","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1034/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1034/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1034/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/issues/1034","id":173904329,"number":1034,"title":"[Discussion] Switching our data format language.","user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-30T00:35:18Z","updated_at":"2016-08-30T02:24:13Z","closed_at":null,"body":"Surprisingly, we've never had a discussion directly about if we want to continue using XML as our data format or switch to something else. We've only discussed it in passing ( in #25 and #21 ). Our primary other candidate would be JSON as Unity already has some degree of support for it and further support could be achieved through [SimpleJSON](http://wiki.unity3d.com/index.php/SimpleJSON).\r\n\r\nWe have added outside libraries in the past when we needed to, so I don't think that should be a primary concern. Quills only recently stated concern was that we use one language for it, and that someone would need to volunteer to make the needed changes, stated in #25 (I don't claim that this is the entirety of his opinion on the matter, only that it is the only semi-recent statement on the matter). I know I, for one, would be willing to assist on making the changeover, if that's what's decided, and I'm confident that if we choose to do it, others will help, so I also don't think that should be a primary concern.\r\n\r\nWith JSON (via SimpleJSON) we wouldn't need to loop over the data structure, which can be error prone, such as if you skip reading a line and try to readToNextSibling from the wrong depth, you instead just check if the data you want exists and use it to populate the objects you need populated.\r\n\r\nIf interest is shown in switching to JSON we can do further investigation into what exactly it will mean for our data loading and how it will work for us.\r\n\r\nThoughts and opinions for or against?"},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/243314819","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/issues/1034#issuecomment-243314819","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1034","id":243314819,"user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T02:24:13Z","updated_at":"2016-08-30T02:24:13Z","body":"I find that the verbosity of xml hinders readability more than JSON's brevity does as xml the data is mixed in the structural elements, and sometimes can be partially concealed by it. The data is either wrapped in the tag of the semantics of the data (So the name of a furniture, for example, is write in the middle of the stuff telling you that it is the name), or it's alternatively part of what's otherwise telling us the semantics of the data (such as the jobTime of BuildingJob in furniture being an attribute). It's often unclear as to what exactly the data is and what's the semantics... though that may be Quill's fault and ours for continuing to not have any guidelines on what should be the contents of a tag and what should be an attribute.\r\n\r\nUltimately it comes down to what is preferred by the community, brevity or verbosity. "}}
{"actor":{"display_login":"koosemose"}}