{"action":"created","issue":{"url":"https://api.github.com/repos/kivy/kivy/issues/3901","repository_url":"https://api.github.com/repos/kivy/kivy","labels_url":"https://api.github.com/repos/kivy/kivy/issues/3901/labels{/name}","comments_url":"https://api.github.com/repos/kivy/kivy/issues/3901/comments","events_url":"https://api.github.com/repos/kivy/kivy/issues/3901/events","html_url":"https://github.com/kivy/kivy/pull/3901","id":125584588,"number":3901,"title":"Add kivy.uix.behaviors.touchripple module","user":{"login":"rnixx","id":246021,"avatar_url":"https://avatars.githubusercontent.com/u/246021?v=3","gravatar_id":"","url":"https://api.github.com/users/rnixx","html_url":"https://github.com/rnixx","followers_url":"https://api.github.com/users/rnixx/followers","following_url":"https://api.github.com/users/rnixx/following{/other_user}","gists_url":"https://api.github.com/users/rnixx/gists{/gist_id}","starred_url":"https://api.github.com/users/rnixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnixx/subscriptions","organizations_url":"https://api.github.com/users/rnixx/orgs","repos_url":"https://api.github.com/users/rnixx/repos","events_url":"https://api.github.com/users/rnixx/events{/privacy}","received_events_url":"https://api.github.com/users/rnixx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-01-08T10:36:00Z","updated_at":"2016-06-29T15:37:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kivy/kivy/pulls/3901","html_url":"https://github.com/kivy/kivy/pull/3901","diff_url":"https://github.com/kivy/kivy/pull/3901.diff","patch_url":"https://github.com/kivy/kivy/pull/3901.patch"},"body":"Introduces general TouchRippleBehavior and TouchRippleButtonBehavior classes"},"comment":{"url":"https://api.github.com/repos/kivy/kivy/issues/comments/229395931","html_url":"https://github.com/kivy/kivy/pull/3901#issuecomment-229395931","issue_url":"https://api.github.com/repos/kivy/kivy/issues/3901","id":229395931,"user":{"login":"rnixx","id":246021,"avatar_url":"https://avatars.githubusercontent.com/u/246021?v=3","gravatar_id":"","url":"https://api.github.com/users/rnixx","html_url":"https://github.com/rnixx","followers_url":"https://api.github.com/users/rnixx/followers","following_url":"https://api.github.com/users/rnixx/following{/other_user}","gists_url":"https://api.github.com/users/rnixx/gists{/gist_id}","starred_url":"https://api.github.com/users/rnixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnixx/subscriptions","organizations_url":"https://api.github.com/users/rnixx/orgs","repos_url":"https://api.github.com/users/rnixx/repos","events_url":"https://api.github.com/users/rnixx/events{/privacy}","received_events_url":"https://api.github.com/users/rnixx/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T15:37:48Z","updated_at":"2016-06-29T15:37:48Z","body":"I fear the TouchRippleButtonBehavior cannot stay as it is right now.\r\n\r\nWe have different behviour how on_release gets triggered. thus is think we cannot work with super calls because on_touch_up of ButtonBehavior would be called then, which causes the behaviour trouble.\r\n\r\nBut we want to delegate on_touch_down and on_touch_up anyways to other superclasses, right?\r\n\r\nAn option would be to create a ButtonBehaviorBase class, not implementing on_touch_down and on_touch_up. This base gets inherited from then in ButtonBehavior and TouchRippleButtonBehavior which implement the touch event handlers.\r\n\r\nNext, if i understand ButtonBehavior and how it is used in uix.button and kv, state is only used for visual effect, which is also not desired in a TouchRippleButton because the ripple animation is the visual effect there. So the base class also might not provide state and min_state_time."}}
{"actor":{"display_login":"rnixx"}}