{"push_id":1200373549,"size":1000,"distinct_size":1027,"ref":"refs/heads/master","head":"12351f2b35f0fecf6d7d30a5776f81e8a5e38404","before":"4fae534820183f5c71afbca0300ebfffb7e30b39","commits":[{"sha":"d8ed06285b14a97eeaa1db8ab691bec99ffe225f","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"remove generic parameter on ParamInfo\n\nSummary:These generic parameters are put there for `traverse`. However, in all use\ncases of traverse, the object is either cast to the correct type, or the\nParamInfo is created on the spot with that object in mind.\n\nTest Plan: compiles.\n\nReviewed By: Coneko\n\nfb-gh-sync-id: 237dfee\nshipit-source-id: 237dfee","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/d8ed06285b14a97eeaa1db8ab691bec99ffe225f"},{"sha":"88f32c97d27b7fa6a78aacc1bc9ccd7cf83633c6","author":{"name":"Andrew Gallagher","email":"32fec84bb4a669750632a875aaca9f8c685892bf@fb.com"},"message":"C/C++: allow platform tools to use binary build rules\n\nSummary:Although C/C++ platform objects wrapped `Tool` objects, which can\nwrap `BinaryBuildRule`s, our C/C++ platform objects were always\nconstructed well before the action graph was built.  This diff adds\na layer of indirection -- a `ToolProvider` class, along with\n`PreprocessorProvider` and `CompilerProvider` -- so that `Tool`\nconstruction can be delayed until action graph construction, when\na `BuildRuleResolver` is available to resolve `BinaryBuildRule`s.\n\nAs part of this refactoring, the clang detection logic is moved into\nthe new `CxxToolProvider` base class, allowing the provider classes\nto take the place of the suppliers.\n\nTest Plan: Added integration test using `sh_binary` rules as compilers.\n\nReviewed By: k21\n\nfb-gh-sync-id: 9f57f0e\nshipit-source-id: 9f57f0e","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/88f32c97d27b7fa6a78aacc1bc9ccd7cf83633c6"},{"sha":"3cc29767f981d4c6340ccaa7a423c559e5c95623","author":{"name":"Andrew Gallagher","email":"32fec84bb4a669750632a875aaca9f8c685892bf@fb.com"},"message":"C/C++: allow platform linker to use binary build rules\n\nSummary:Allow the `CxxPlatform`s linker to wrap binary build rules by adding\na layer of indirection -- the `LinkerProvider` -- so that instantiating\nthe linker can be deferred until action graph construction time.\n\nTest Plan: added test\n\nReviewed By: k21\n\nfb-gh-sync-id: bd77886\nshipit-source-id: bd77886","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/3cc29767f981d4c6340ccaa7a423c559e5c95623"},{"sha":"3d524eb0f0f8c3310701c8dd033da4f1216a27f9","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove hardcoded output paths in tests.\n\nTest Plan: CI\n\nReviewed By: beefon\n\nfb-gh-sync-id: 807cb1a\nshipit-source-id: 807cb1a","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/3d524eb0f0f8c3310701c8dd033da4f1216a27f9"},{"sha":"32870e2ba5a22c8e2d37efb020d0f58c4590b521","author":{"name":"Jakub Zika","email":"baff7152439df344bfd58532c85ff94583f29f02@fb.com"},"message":"Don't drop known cells on an overflow event\n\nSummary:Fix overflow exception handling in `DaemonicParserState` so that\n`buckd` does not forget about its cells. Previously, when a\noverflow event was received, `buckd` forgot about all of its cells\nand stopped processing all further modification events. To make\nsure this does not regress in the future, this change also\nintroduces a regression test and `Precondition` checks in places\nwhere we expect Buck to know about its cells.\n\nTest Plan: `buck test`\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: 7ef1d4f\nshipit-source-id: 7ef1d4f","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/32870e2ba5a22c8e2d37efb020d0f58c4590b521"},{"sha":"d45e522102a543d32d239d4609b79dbb8e3bb3b8","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove hardcoded output paths in tests.\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: 43d8d4a\nshipit-source-id: 43d8d4a","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/d45e522102a543d32d239d4609b79dbb8e3bb3b8"},{"sha":"4543dd8e969dd7bdf5dafea8ead88cb98756b813","author":{"name":"Mark Wang","email":"ef7450a1f0ef1dd83819119188f9feef0990e9ee@fb.com"},"message":"Update to newest version of dd-plist\n\nSummary:Update to the newest version which fixes some cases where binary `.plist`s were being written that were causing errors with iOS's validation for device builds.\n\nhttps://github.com/3breadt/dd-plist/commit/3fa1fa56c82df169e06079feb54ba281ad41cae6\n\n```\ndd-plist$ ant jar\ndd-plist/src/main/java$ jar cf dd-plist-sources.jar com\n```\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfb-gh-sync-id: 9c36b72\nshipit-source-id: 9c36b72","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/4543dd8e969dd7bdf5dafea8ead88cb98756b813"},{"sha":"1f59e6f1445e94cbbd460895844ce45dafc471e8","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"More refactoring in TargetsCommand\n\nSummary: `computeShowRules` is too big, splitting it into smaller methods.\n\nTest Plan: CI\n\nReviewed By: k21\n\nfb-gh-sync-id: bf4f23f\nshipit-source-id: bf4f23f","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/1f59e6f1445e94cbbd460895844ce45dafc471e8"},{"sha":"7179435ad7c07fad61c202eb69075d4af548557a","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove hardcoded output paths in tests.\n\nTest Plan: CI\n\nReviewed By: k21\n\nfb-gh-sync-id: 3300ef1\nshipit-source-id: 3300ef1","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/7179435ad7c07fad61c202eb69075d4af548557a"},{"sha":"22c2a26b09480c9182cacfb6f5dc6f87cad58cb1","author":{"name":"Andrew Gallagher","email":"32fec84bb4a669750632a875aaca9f8c685892bf@fb.com"},"message":"C/C++: add preprocessor tool to deps for preprocess-and-compile rules\n\nSummary:Previously, even we may have been using the tool (e.g. in piped mode),\npreprocess and compile rules were never adding it's deps to the rule deps,\nwhich didn't actually cause issues since our tools were always paths.\nUsing an actual binary rule as the preprocessor causes the the input\ninput-based rule key factory to die.\n\nTest Plan: added unittest\n\nReviewed By: k21\n\nfb-gh-sync-id: 03b93a5\nshipit-source-id: 03b93a5","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/22c2a26b09480c9182cacfb6f5dc6f87cad58cb1"},{"sha":"410b8345ce323922b1231d61552a1c15b15f8b90","author":{"name":"Theodor-Cosmin Didii","email":"117f221f91799a7d192dc6bb02896dc9bdc42759@fb.com"},"message":"Changed Buck Silent verbosity to show only errors\n\nSummary: Buck silent verbosity should not display the usual output.\n\nTest Plan:Tested by running buck with -v 0\n{F60332003}\n\n{F60332004}\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: c6a7ba6\nshipit-source-id: c6a7ba6","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/410b8345ce323922b1231d61552a1c15b15f8b90"},{"sha":"44065ad5dc8d522702ffc516d2146ad3a2654143","author":{"name":"Theodor-Cosmin Didii","email":"117f221f91799a7d192dc6bb02896dc9bdc42759@fb.com"},"message":"Adding multiple parameters to commands\n\nSummary: Adding the possibility of setting multiple commands parameters in the BuckCommand, since buck has commands like \"buck audit rule...\". Also added the silent verbosity to the commands whose output we parse.\n\nTest Plan: Tested in intellij.\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: e02920a\nshipit-source-id: e02920a","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/44065ad5dc8d522702ffc516d2146ad3a2654143"},{"sha":"2a90909ee4badc960c62088276ee964d229053c3","author":{"name":"Theodor-Cosmin Didii","email":"117f221f91799a7d192dc6bb02896dc9bdc42759@fb.com"},"message":"Buck parse stderr\n\nSummary: Buck doesn't send all the error events to the plugin and some are from python, so we parse the stderr of the buck command. Commented out the Console event.\n\nTest Plan: Ran in intellij.\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: 2622ead\nshipit-source-id: 2622ead","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/2a90909ee4badc960c62088276ee964d229053c3"},{"sha":"9b97b5a769a0de49ffc7777f71ee489a465c5ea6","author":{"name":"Martino Luca","email":"bc39cf26caffb8d5b7f43458ab0463d2c1c72bbf@fb.com"},"message":"Simple refactoring to make use of flavors more explicit\n\nSummary: No functionalities added/removed, simple refactoring that exposes infer-related flavors better\n\nTest Plan: CI, tests\n\nReviewed By: Coneko\n\nfb-gh-sync-id: f3d7827\nshipit-source-id: f3d7827","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/9b97b5a769a0de49ffc7777f71ee489a465c5ea6"},{"sha":"0d22582bc90ab6e5fc0b859b671615dbcc702526","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove hardcoded output paths in tests.\n\nTest Plan: CI\n\nReviewed By: k21\n\nfb-gh-sync-id: b6fe958\nshipit-source-id: b6fe958","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/0d22582bc90ab6e5fc0b859b671615dbcc702526"},{"sha":"4dcf749ae6ec8ed70ab8e10d5243a5e4897a709a","author":{"name":"Martin Kosiba","email":"6bd994d075fcd7642f04677ba9960527dece6461@fb.com"},"message":"Resolve specs and parse in one go.\n\nSummary:In Parser.buildTargetGraphForTargetNodeSpecs we were effectively\ncreating the parser pipeline twice - once to resolve target specs\nand once to actually parse the graph. We can achieve slightly deeper\npipelining by creating one state and reusing it across spec resolution\nand parsing.\nI also needed to move the speculative deps traversal scheduling\nso that it's also invoked in the case where we already have the raw node.\n\nTest Plan:CI, manually inspect traces to confirm parsing happens\nconcurrently with specs resolution.\n\nReviewed By: Coneko\n\nfb-gh-sync-id: d8f1bf4\nshipit-source-id: d8f1bf4","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/4dcf749ae6ec8ed70ab8e10d5243a5e4897a709a"},{"sha":"d19cd076a47474560e4a3d2f22be554ad1310235","author":{"name":"Martino Luca","email":"bc39cf26caffb8d5b7f43458ab0463d2c1c72bbf@fb.com"},"message":"extract step that emits infer dependencies' info into its own class\n\nSummary:This step emits information about capture/analysis steps in the following format:\n<target name> \\\\t <flavors> \\\\t <buck-out-path>\n\nTest Plan: Integration tests, CI\n\nReviewed By: Coneko\n\nfb-gh-sync-id: 294cb9b\nshipit-source-id: 294cb9b","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/d19cd076a47474560e4a3d2f22be554ad1310235"},{"sha":"cec848133f50f2ae46f2f0026afb66bb1fe8affb","author":{"name":"Martino Luca","email":"bc39cf26caffb8d5b7f43458ab0463d2c1c72bbf@fb.com"},"message":"Compute Rule keys over version rather than binaries' hashes\n\nSummary: Compute Rule keys over version rather than binaries' hashes\n\nTest Plan: CI and Integration tests\n\nReviewed By: Coneko\n\nfb-gh-sync-id: 3356fb8\nshipit-source-id: 3356fb8","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/cec848133f50f2ae46f2f0026afb66bb1fe8affb"},{"sha":"9f5fa0fa5ee7de7e85b87cf0a397a251ddc61363","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Emit python profiler output to trace, and make it per file\n\nSummary:Due to parsers being persistent, the `--profile` output were effectively\nmeaningless.\n\nHere I profile processing of each file separately, and record the results in\nthe trace event for that file, instead of splattering it out to the log.\n\nTest Plan:1. buck query --profile 'deps(target)'\n2. stare at 'parse_file' entries of the trace.\n\nReviewed By: marcinkosiba\n\nfb-gh-sync-id: 01a34fa\nshipit-source-id: 01a34fa","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/9f5fa0fa5ee7de7e85b87cf0a397a251ddc61363"},{"sha":"a71c156e919567e62c0152796f9c6fc64f373c09","author":{"name":"Andrew Gallagher","email":"32fec84bb4a669750632a875aaca9f8c685892bf@fb.com"},"message":"C/C++: include compiler tool deps in preprocess-only rules\n\nSummary:We add the `CompilerDelegate` to the rule key of preprocess-only\nC/C++ rules, so the input-based rule key builder expects to see\nany associated deps in the dep list.  Previously, we only allowed\npaths as the compiler tool, but now that we accept outputs generated\nby other rules, this started failing.\n\nTest Plan: update unittest\n\nReviewed By: yiding\n\nfb-gh-sync-id: 20721da\nshipit-source-id: 20721da","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/a71c156e919567e62c0152796f9c6fc64f373c09"}]}
{"actor":{"display_login":"shs96c"}}