{"action":"created","comment":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/48857623","id":48857623,"diff_hunk":"@@ -1,34 +1,35 @@\n (function(env) {\n     \"use strict\";\n-\n+    \n     env.ddg_spice_flash_version = function() {\n-\n-\tif(!FlashDetect) {\n-\t    return Spice.failed('flash_version');\n-\t}\n-\n-\t// Display the plugin.\n-\tSpice.add({\n-            data: {\n-\t\tinstalled: FlashDetect.installed,\n-\t\traw: FlashDetect.raw\n-\t    },\n-\t    id: 'flash_version',\n-\t    name: 'Software',\n-\t    meta: {\n-\t\tsourceName: 'Adobe',\n-\t\tsourceUrl: 'https://get.adobe.com/flashplayer/',\n-\t\tsourceIcon: true\n-\t    },\n-            templates: {\n-\t\tgroup: 'base',\n-\t\toptions: {\n-\t\t    content: Spice.flash_version.content,\n-\t\t    moreAt: true\n-\t\t}\n+        \n+        DDG.require('flash_detect.js', function(){","path":"share/spice/flash_version/flash_version.js","position":null,"original_position":31,"commit_id":"a3552365e597ca50cee6151cf746f16f97056f48","original_commit_id":"cf14244c4afcad892177ae0457ee256c0866a35e","user":{"login":"MrChrisW","id":5282264,"avatar_url":"https://avatars.githubusercontent.com/u/5282264?v=3","gravatar_id":"","url":"https://api.github.com/users/MrChrisW","html_url":"https://github.com/MrChrisW","followers_url":"https://api.github.com/users/MrChrisW/followers","following_url":"https://api.github.com/users/MrChrisW/following{/other_user}","gists_url":"https://api.github.com/users/MrChrisW/gists{/gist_id}","starred_url":"https://api.github.com/users/MrChrisW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrChrisW/subscriptions","organizations_url":"https://api.github.com/users/MrChrisW/orgs","repos_url":"https://api.github.com/users/MrChrisW/repos","events_url":"https://api.github.com/users/MrChrisW/events{/privacy}","received_events_url":"https://api.github.com/users/MrChrisW/received_events","type":"User","site_admin":false},"body":":+1: done","created_at":"2016-01-05T15:42:37Z","updated_at":"2016-01-05T15:42:37Z","html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373#discussion_r48857623","pull_request_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373","_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments/48857623"},"html":{"href":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373#discussion_r48857623"},"pull_request":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373"}}},"pull_request":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373","id":55072480,"html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373","diff_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373.diff","patch_url":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373.patch","issue_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/2373","number":2373,"state":"open","locked":false,"title":"FlashVersion: Use DDG.require for 'flash_detect.js' file","user":{"login":"MrChrisW","id":5282264,"avatar_url":"https://avatars.githubusercontent.com/u/5282264?v=3","gravatar_id":"","url":"https://api.github.com/users/MrChrisW","html_url":"https://github.com/MrChrisW","followers_url":"https://api.github.com/users/MrChrisW/followers","following_url":"https://api.github.com/users/MrChrisW/following{/other_user}","gists_url":"https://api.github.com/users/MrChrisW/gists{/gist_id}","starred_url":"https://api.github.com/users/MrChrisW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrChrisW/subscriptions","organizations_url":"https://api.github.com/users/MrChrisW/orgs","repos_url":"https://api.github.com/users/MrChrisW/repos","events_url":"https://api.github.com/users/MrChrisW/events{/privacy}","received_events_url":"https://api.github.com/users/MrChrisW/received_events","type":"User","site_admin":false},"body":"Partially fixing #99\r\n\r\n>DDG can tell you your flash version but it doesn't give you the last 3 numbers:  by @zekiel \r\n\r\nUnable to implement this functionality. \r\n\r\n+ Unable to show the last three numbers without using [SWFObject](https://code.google.com/p/swfobject/) to embed a swf file - which is not recommended.\r\n+ All js implementation of flash detection including Adobe official kit only display 3 version numbers. See http://isflashinstalled.com/\r\n\r\n**This PR relates to [comments made](https://github.com/duckduckgo/zeroclickinfo-spice/issues/99#issuecomment-49634404) by @bsstoner regarding the removal of FlashDetect from core.**\r\n\r\nWe should include [flash_detect_min.js](http://www.featureblend.com/flash_detect_1-0-4/flash_detect_min.js) and call it using `DDG.require` the same way we do `moment.js` - this will require internal changes.\r\n","created_at":"2016-01-05T09:55:54Z","updated_at":"2016-01-05T15:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b5f2f600667b1128fdff81cdce68750a5665d78","assignee":{"login":"moollaza","id":873785,"avatar_url":"https://avatars.githubusercontent.com/u/873785?v=3","gravatar_id":"","url":"https://api.github.com/users/moollaza","html_url":"https://github.com/moollaza","followers_url":"https://api.github.com/users/moollaza/followers","following_url":"https://api.github.com/users/moollaza/following{/other_user}","gists_url":"https://api.github.com/users/moollaza/gists{/gist_id}","starred_url":"https://api.github.com/users/moollaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moollaza/subscriptions","organizations_url":"https://api.github.com/users/moollaza/orgs","repos_url":"https://api.github.com/users/moollaza/repos","events_url":"https://api.github.com/users/moollaza/events{/privacy}","received_events_url":"https://api.github.com/users/moollaza/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373/commits","review_comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373/comments","review_comment_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/2373/comments","statuses_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/a3552365e597ca50cee6151cf746f16f97056f48","head":{"label":"MrChrisW:flash-detect","ref":"flash-detect","sha":"a3552365e597ca50cee6151cf746f16f97056f48","user":{"login":"MrChrisW","id":5282264,"avatar_url":"https://avatars.githubusercontent.com/u/5282264?v=3","gravatar_id":"","url":"https://api.github.com/users/MrChrisW","html_url":"https://github.com/MrChrisW","followers_url":"https://api.github.com/users/MrChrisW/followers","following_url":"https://api.github.com/users/MrChrisW/following{/other_user}","gists_url":"https://api.github.com/users/MrChrisW/gists{/gist_id}","starred_url":"https://api.github.com/users/MrChrisW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrChrisW/subscriptions","organizations_url":"https://api.github.com/users/MrChrisW/orgs","repos_url":"https://api.github.com/users/MrChrisW/repos","events_url":"https://api.github.com/users/MrChrisW/events{/privacy}","received_events_url":"https://api.github.com/users/MrChrisW/received_events","type":"User","site_admin":false},"repo":{"id":24491125,"name":"zeroclickinfo-spice","full_name":"MrChrisW/zeroclickinfo-spice","owner":{"login":"MrChrisW","id":5282264,"avatar_url":"https://avatars.githubusercontent.com/u/5282264?v=3","gravatar_id":"","url":"https://api.github.com/users/MrChrisW","html_url":"https://github.com/MrChrisW","followers_url":"https://api.github.com/users/MrChrisW/followers","following_url":"https://api.github.com/users/MrChrisW/following{/other_user}","gists_url":"https://api.github.com/users/MrChrisW/gists{/gist_id}","starred_url":"https://api.github.com/users/MrChrisW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrChrisW/subscriptions","organizations_url":"https://api.github.com/users/MrChrisW/orgs","repos_url":"https://api.github.com/users/MrChrisW/repos","events_url":"https://api.github.com/users/MrChrisW/events{/privacy}","received_events_url":"https://api.github.com/users/MrChrisW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrChrisW/zeroclickinfo-spice","description":"DuckDuckGo instant answer plugins based on JavaScript APIs","fork":true,"url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice","forks_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/forks","keys_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/teams","hooks_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/hooks","issue_events_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/issues/events{/number}","events_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/events","assignees_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/assignees{/user}","branches_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/branches{/branch}","tags_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/tags","blobs_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/statuses/{sha}","languages_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/languages","stargazers_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/stargazers","contributors_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/contributors","subscribers_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/subscribers","subscription_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/subscription","commits_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/contents/{+path}","compare_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/merges","archive_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/downloads","issues_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/issues{/number}","pulls_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/pulls{/number}","milestones_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/milestones{/number}","notifications_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/labels{/name}","releases_url":"https://api.github.com/repos/MrChrisW/zeroclickinfo-spice/releases{/id}","created_at":"2014-09-26T07:53:14Z","updated_at":"2015-05-08T01:24:17Z","pushed_at":"2016-01-05T15:42:31Z","git_url":"git://github.com/MrChrisW/zeroclickinfo-spice.git","ssh_url":"git@github.com:MrChrisW/zeroclickinfo-spice.git","clone_url":"https://github.com/MrChrisW/zeroclickinfo-spice.git","svn_url":"https://github.com/MrChrisW/zeroclickinfo-spice","homepage":"http://duckduckhack.com/","size":17170,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duckduckgo:master","ref":"master","sha":"5efb70c7ca651b03861290c8c2660aa1bd5c05c8","user":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars.githubusercontent.com/u/342708?v=3","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"repo":{"id":1997671,"name":"zeroclickinfo-spice","full_name":"duckduckgo/zeroclickinfo-spice","owner":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars.githubusercontent.com/u/342708?v=3","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duckduckgo/zeroclickinfo-spice","description":"DuckDuckGo instant answer plugins based on JavaScript APIs","fork":false,"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice","forks_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/forks","keys_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/teams","hooks_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/hooks","issue_events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/events{/number}","events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/events","assignees_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/assignees{/user}","branches_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/branches{/branch}","tags_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/tags","blobs_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/refs{/sha}","trees_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/{sha}","languages_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/languages","stargazers_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/stargazers","contributors_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/contributors","subscribers_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/subscribers","subscription_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/subscription","commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/commits{/sha}","git_commits_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/git/commits{/sha}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/comments{/number}","issue_comment_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/comments{/number}","contents_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/contents/{+path}","compare_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/merges","archive_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/downloads","issues_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues{/number}","pulls_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls{/number}","milestones_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/milestones{/number}","notifications_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/labels{/name}","releases_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/releases{/id}","created_at":"2011-07-04T22:08:37Z","updated_at":"2016-01-05T08:49:25Z","pushed_at":"2016-01-05T15:42:32Z","git_url":"git://github.com/duckduckgo/zeroclickinfo-spice.git","ssh_url":"git@github.com:duckduckgo/zeroclickinfo-spice.git","clone_url":"https://github.com/duckduckgo/zeroclickinfo-spice.git","svn_url":"https://github.com/duckduckgo/zeroclickinfo-spice","homepage":"http://duckduckhack.com/","size":21538,"stargazers_count":274,"watchers_count":274,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":739,"mirror_url":null,"open_issues_count":143,"forks":739,"open_issues":143,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373"},"html":{"href":"https://github.com/duckduckgo/zeroclickinfo-spice/pull/2373"},"issue":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/2373"},"comments":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/2373/comments"},"review_comments":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373/comments"},"review_comment":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/pulls/2373/commits"},"statuses":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/statuses/a3552365e597ca50cee6151cf746f16f97056f48"}}}}