{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-go/pulls/comments/71002764","id":71002764,"diff_hunk":"@@ -583,9 +588,13 @@ func (c Client) newRequest(method string, metadata requestMetadata) (req *http.R\n \t\t// set sha256 sum for signature calculation only with\n \t\t// signature version '4'.\n \t\tif c.signature.isV4() {\n-\t\t\treq.Header.Set(\"X-Amz-Content-Sha256\", hex.EncodeToString(sum256([]byte{})))\n-\t\t\tif metadata.contentSHA256Bytes != nil {\n-\t\t\t\treq.Header.Set(\"X-Amz-Content-Sha256\", hex.EncodeToString(metadata.contentSHA256Bytes))\n+\t\t\tif !c.secure {\n+\t\t\t\treq.Header.Set(\"X-Amz-Content-Sha256\", hex.EncodeToString(sum256([]byte{})))\n+\t\t\t\tif metadata.contentSHA256Bytes != nil {\n+\t\t\t\t\treq.Header.Set(\"X-Amz-Content-Sha256\", hex.EncodeToString(metadata.contentSHA256Bytes))\n+\t\t\t\t}\n+\t\t\t} else {\n+\t\t\t\treq.Header.Set(\"X-Amz-Content-Sha256\", \"UNSIGNED-PAYLOAD\")","path":"api.go","position":32,"original_position":32,"commit_id":"5d2921f1661295326d4259d1b98be4109c0887b2","original_commit_id":"5d2921f1661295326d4259d1b98be4109c0887b2","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-07-15T16:39:26Z","updated_at":"2016-07-15T16:39:26Z","html_url":"https://github.com/minio/minio-go/pull/443#discussion_r71002764","pull_request_url":"https://api.github.com/repos/minio/minio-go/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments/71002764"},"html":{"href":"https://github.com/minio/minio-go/pull/443#discussion_r71002764"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-go/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio-go/pulls/443","id":77612346,"html_url":"https://github.com/minio/minio-go/pull/443","diff_url":"https://github.com/minio/minio-go/pull/443.diff","patch_url":"https://github.com/minio/minio-go/pull/443.patch","issue_url":"https://api.github.com/repos/minio/minio-go/issues/443","number":443,"state":"open","locked":false,"title":"Do not compute payload sha256 with https endpoint","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"Fixes #428 \r\n\r\nIt would be better to make the layer responsible for putting objects chooses what hash algorithms should be computed","created_at":"2016-07-15T13:05:29Z","updated_at":"2016-07-15T16:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24a9cdb7ecb0bb555c09b6873fe21327c64597a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-go/pulls/443/commits","review_comments_url":"https://api.github.com/repos/minio/minio-go/pulls/443/comments","review_comment_url":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-go/issues/443/comments","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/5d2921f1661295326d4259d1b98be4109c0887b2","head":{"label":"vadmeste:dont_use_sha256_in_https","ref":"dont_use_sha256_in_https","sha":"5d2921f1661295326d4259d1b98be4109c0887b2","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"repo":{"id":55795857,"name":"minio-go","full_name":"vadmeste/minio-go","owner":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadmeste/minio-go","description":":green_book: Minio Go Library for Amazon S3 compatible cloud storage","fork":true,"url":"https://api.github.com/repos/vadmeste/minio-go","forks_url":"https://api.github.com/repos/vadmeste/minio-go/forks","keys_url":"https://api.github.com/repos/vadmeste/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadmeste/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadmeste/minio-go/teams","hooks_url":"https://api.github.com/repos/vadmeste/minio-go/hooks","issue_events_url":"https://api.github.com/repos/vadmeste/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/vadmeste/minio-go/events","assignees_url":"https://api.github.com/repos/vadmeste/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/vadmeste/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/vadmeste/minio-go/tags","blobs_url":"https://api.github.com/repos/vadmeste/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadmeste/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadmeste/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadmeste/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadmeste/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/vadmeste/minio-go/languages","stargazers_url":"https://api.github.com/repos/vadmeste/minio-go/stargazers","contributors_url":"https://api.github.com/repos/vadmeste/minio-go/contributors","subscribers_url":"https://api.github.com/repos/vadmeste/minio-go/subscribers","subscription_url":"https://api.github.com/repos/vadmeste/minio-go/subscription","commits_url":"https://api.github.com/repos/vadmeste/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadmeste/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadmeste/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadmeste/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadmeste/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/vadmeste/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadmeste/minio-go/merges","archive_url":"https://api.github.com/repos/vadmeste/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadmeste/minio-go/downloads","issues_url":"https://api.github.com/repos/vadmeste/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/vadmeste/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/vadmeste/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/vadmeste/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadmeste/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/vadmeste/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/vadmeste/minio-go/deployments","created_at":"2016-04-08T17:02:58Z","updated_at":"2016-04-08T17:02:59Z","pushed_at":"2016-07-15T13:02:16Z","git_url":"git://github.com/vadmeste/minio-go.git","ssh_url":"git@github.com:vadmeste/minio-go.git","clone_url":"https://github.com/vadmeste/minio-go.git","svn_url":"https://github.com/vadmeste/minio-go","homepage":"http://minio.io/download/#minio-sdk","size":3582,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"7f5706b303743c9b9c5f4ad251cf6e9a4f2cb85e","user":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":34933072,"name":"minio-go","full_name":"minio/minio-go","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-go","description":"Minio Go Library for Amazon S3 compatible cloud storage","fork":false,"url":"https://api.github.com/repos/minio/minio-go","forks_url":"https://api.github.com/repos/minio/minio-go/forks","keys_url":"https://api.github.com/repos/minio/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-go/teams","hooks_url":"https://api.github.com/repos/minio/minio-go/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-go/events","assignees_url":"https://api.github.com/repos/minio/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-go/tags","blobs_url":"https://api.github.com/repos/minio/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-go/languages","stargazers_url":"https://api.github.com/repos/minio/minio-go/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-go/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-go/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-go/subscription","commits_url":"https://api.github.com/repos/minio/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-go/merges","archive_url":"https://api.github.com/repos/minio/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-go/downloads","issues_url":"https://api.github.com/repos/minio/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-go/deployments","created_at":"2015-05-02T02:36:46Z","updated_at":"2016-07-15T10:23:16Z","pushed_at":"2016-07-15T13:05:29Z","git_url":"git://github.com/minio/minio-go.git","ssh_url":"git@github.com:minio/minio-go.git","clone_url":"https://github.com/minio/minio-go.git","svn_url":"https://github.com/minio/minio-go","homepage":"http://minio.io/downloads/#minio-sdk","size":3652,"stargazers_count":116,"watchers_count":116,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":14,"forks":38,"open_issues":14,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/443"},"html":{"href":"https://github.com/minio/minio-go/pull/443"},"issue":{"href":"https://api.github.com/repos/minio/minio-go/issues/443"},"comments":{"href":"https://api.github.com/repos/minio/minio-go/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-go/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-go/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-go/statuses/5d2921f1661295326d4259d1b98be4109c0887b2"}}}}
{"actor":{"display_login":"vadmeste"}}