{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/comments/87558306","pull_request_review_id":8166610,"id":87558306,"diff_hunk":"@@ -146,6 +147,19 @@ def validate_url\n \n       private\n \n+      def set_proxy_environment\n+        return if @machine.config.servicemanager.proxy.nil?\n+\n+        env_proxy = @machine.config.servicemanager.proxy\n+        if @machine.config.servicemanager.proxy_user\n+          user = @machine.config.servicemanager.proxy_user\n+          password = @machine.config.servicemanager.proxy_password\n+          env_proxy = env_proxy.sub(%r{(https?:\\/\\/)*}, \"\\\\1#{user}:#{password}@\")\n+        end\n+\n+        ENV['https_proxy'] = env_proxy","path":"lib/vagrant-service-manager/binary_handlers/binary_handler.rb","position":22,"original_position":22,"commit_id":"b2d30e10b28e7a99058a301a588c436fec138bf1","original_commit_id":"b2d30e10b28e7a99058a301a588c436fec138bf1","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"Again, a comment on why you set this variable and why you set it in this format.","created_at":"2016-11-11T09:20:33Z","updated_at":"2016-11-11T09:20:33Z","html_url":"https://github.com/projectatomic/vagrant-service-manager/pull/438#discussion_r87558306","pull_request_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/comments/87558306"},"html":{"href":"https://github.com/projectatomic/vagrant-service-manager/pull/438#discussion_r87558306"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438","id":93297571,"html_url":"https://github.com/projectatomic/vagrant-service-manager/pull/438","diff_url":"https://github.com/projectatomic/vagrant-service-manager/pull/438.diff","patch_url":"https://github.com/projectatomic/vagrant-service-manager/pull/438.patch","issue_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/438","number":438,"state":"open","locked":false,"title":"Fix #389 Support the use of install-cli in HTTP proxy environment","user":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"body":"Fix #389 \r\n\r\ncc @hferentschik ","created_at":"2016-11-11T08:45:46Z","updated_at":"2016-11-11T09:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"605c3b3bb1e722abef27b9e021070d9b20ee76c7","assignee":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"assignees":[{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438/commits","review_comments_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438/comments","review_comment_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/438/comments","statuses_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/statuses/b2d30e10b28e7a99058a301a588c436fec138bf1","head":{"label":"budhrg:fix-389","ref":"fix-389","sha":"b2d30e10b28e7a99058a301a588c436fec138bf1","user":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"repo":{"id":64914171,"name":"vagrant-service-manager","full_name":"budhrg/vagrant-service-manager","owner":{"login":"budhrg","id":1132451,"avatar_url":"https://avatars.githubusercontent.com/u/1132451?v=3","gravatar_id":"","url":"https://api.github.com/users/budhrg","html_url":"https://github.com/budhrg","followers_url":"https://api.github.com/users/budhrg/followers","following_url":"https://api.github.com/users/budhrg/following{/other_user}","gists_url":"https://api.github.com/users/budhrg/gists{/gist_id}","starred_url":"https://api.github.com/users/budhrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budhrg/subscriptions","organizations_url":"https://api.github.com/users/budhrg/orgs","repos_url":"https://api.github.com/users/budhrg/repos","events_url":"https://api.github.com/users/budhrg/events{/privacy}","received_events_url":"https://api.github.com/users/budhrg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/budhrg/vagrant-service-manager","description":"To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.","fork":true,"url":"https://api.github.com/repos/budhrg/vagrant-service-manager","forks_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/forks","keys_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/teams","hooks_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/hooks","issue_events_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/issues/events{/number}","events_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/events","assignees_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/assignees{/user}","branches_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/branches{/branch}","tags_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/tags","blobs_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/languages","stargazers_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/stargazers","contributors_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/contributors","subscribers_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/subscribers","subscription_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/subscription","commits_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/contents/{+path}","compare_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/merges","archive_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/downloads","issues_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/issues{/number}","pulls_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/labels{/name}","releases_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/releases{/id}","deployments_url":"https://api.github.com/repos/budhrg/vagrant-service-manager/deployments","created_at":"2016-08-04T07:46:43Z","updated_at":"2016-08-04T07:46:44Z","pushed_at":"2016-11-11T08:44:41Z","git_url":"git://github.com/budhrg/vagrant-service-manager.git","ssh_url":"git@github.com:budhrg/vagrant-service-manager.git","clone_url":"https://github.com/budhrg/vagrant-service-manager.git","svn_url":"https://github.com/budhrg/vagrant-service-manager","homepage":null,"size":380,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"18002f35eae560bff80468d6b9fdc343b514f140","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":51367450,"name":"vagrant-service-manager","full_name":"projectatomic/vagrant-service-manager","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/vagrant-service-manager","description":"To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.","fork":false,"url":"https://api.github.com/repos/projectatomic/vagrant-service-manager","forks_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/forks","keys_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/teams","hooks_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/events","assignees_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/tags","blobs_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/languages","stargazers_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/subscription","commits_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/merges","archive_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/downloads","issues_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/vagrant-service-manager/deployments","created_at":"2016-02-09T13:12:07Z","updated_at":"2016-11-08T07:29:44Z","pushed_at":"2016-11-11T08:45:46Z","git_url":"git://github.com/projectatomic/vagrant-service-manager.git","ssh_url":"git@github.com:projectatomic/vagrant-service-manager.git","clone_url":"https://github.com/projectatomic/vagrant-service-manager.git","svn_url":"https://github.com/projectatomic/vagrant-service-manager","homepage":null,"size":454,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":45,"forks":14,"open_issues":45,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438"},"html":{"href":"https://github.com/projectatomic/vagrant-service-manager/pull/438"},"issue":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/438"},"comments":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/vagrant-service-manager/statuses/b2d30e10b28e7a99058a301a588c436fec138bf1"}}}}
{"actor":{"display_login":"hferentschik"}}