{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2","id":76878014,"html_url":"https://github.com/bucandy/Basic-Calculator/pull/2","diff_url":"https://github.com/bucandy/Basic-Calculator/pull/2.diff","patch_url":"https://github.com/bucandy/Basic-Calculator/pull/2.patch","issue_url":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/2","number":2,"state":"open","locked":false,"title":"Code refactor + add tests","user":{"login":"DennisDenuto","id":2989269,"avatar_url":"https://avatars.githubusercontent.com/u/2989269?v=3","gravatar_id":"","url":"https://api.github.com/users/DennisDenuto","html_url":"https://github.com/DennisDenuto","followers_url":"https://api.github.com/users/DennisDenuto/followers","following_url":"https://api.github.com/users/DennisDenuto/following{/other_user}","gists_url":"https://api.github.com/users/DennisDenuto/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisDenuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisDenuto/subscriptions","organizations_url":"https://api.github.com/users/DennisDenuto/orgs","repos_url":"https://api.github.com/users/DennisDenuto/repos","events_url":"https://api.github.com/users/DennisDenuto/events{/privacy}","received_events_url":"https://api.github.com/users/DennisDenuto/received_events","type":"User","site_admin":false},"body":"Refactored out calculator logic (addition, subtraction, multiplication and division) into a seperate class. \r\n\r\nThis allowed the calc logic to be easily tested (I chose junit).  I have only tested the 'happy case' paths of the calc logic. i.e. only small positive floating point numbers.\r\n\r\nI have also added a `compile_run` and `compile_test` convenient scripts. The name implies what it does.","created_at":"2016-07-10T16:55:26Z","updated_at":"2016-07-10T16:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"499e17e54866b6a1fc994d4a97258d53b0ebadee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2/commits","review_comments_url":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2/comments","review_comment_url":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/2/comments","statuses_url":"https://api.github.com/repos/bucandy/Basic-Calculator/statuses/48894bbf1f774afea615fe7f5619c46400357c9a","head":{"label":"DennisDenuto:master","ref":"master","sha":"48894bbf1f774afea615fe7f5619c46400357c9a","user":{"login":"DennisDenuto","id":2989269,"avatar_url":"https://avatars.githubusercontent.com/u/2989269?v=3","gravatar_id":"","url":"https://api.github.com/users/DennisDenuto","html_url":"https://github.com/DennisDenuto","followers_url":"https://api.github.com/users/DennisDenuto/followers","following_url":"https://api.github.com/users/DennisDenuto/following{/other_user}","gists_url":"https://api.github.com/users/DennisDenuto/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisDenuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisDenuto/subscriptions","organizations_url":"https://api.github.com/users/DennisDenuto/orgs","repos_url":"https://api.github.com/users/DennisDenuto/repos","events_url":"https://api.github.com/users/DennisDenuto/events{/privacy}","received_events_url":"https://api.github.com/users/DennisDenuto/received_events","type":"User","site_admin":false},"repo":{"id":63006718,"name":"Basic-Calculator","full_name":"DennisDenuto/Basic-Calculator","owner":{"login":"DennisDenuto","id":2989269,"avatar_url":"https://avatars.githubusercontent.com/u/2989269?v=3","gravatar_id":"","url":"https://api.github.com/users/DennisDenuto","html_url":"https://github.com/DennisDenuto","followers_url":"https://api.github.com/users/DennisDenuto/followers","following_url":"https://api.github.com/users/DennisDenuto/following{/other_user}","gists_url":"https://api.github.com/users/DennisDenuto/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisDenuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisDenuto/subscriptions","organizations_url":"https://api.github.com/users/DennisDenuto/orgs","repos_url":"https://api.github.com/users/DennisDenuto/repos","events_url":"https://api.github.com/users/DennisDenuto/events{/privacy}","received_events_url":"https://api.github.com/users/DennisDenuto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DennisDenuto/Basic-Calculator","description":"1.1 Improvements","fork":true,"url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator","forks_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/forks","keys_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/teams","hooks_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/hooks","issue_events_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/events","assignees_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/tags","blobs_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/languages","stargazers_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/stargazers","contributors_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/contributors","subscribers_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/subscribers","subscription_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/subscription","commits_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/merges","archive_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/downloads","issues_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/DennisDenuto/Basic-Calculator/deployments","created_at":"2016-07-10T15:59:51Z","updated_at":"2016-07-10T15:59:52Z","pushed_at":"2016-07-10T16:50:41Z","git_url":"git://github.com/DennisDenuto/Basic-Calculator.git","ssh_url":"git@github.com:DennisDenuto/Basic-Calculator.git","clone_url":"https://github.com/DennisDenuto/Basic-Calculator.git","svn_url":"https://github.com/DennisDenuto/Basic-Calculator","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.1"}},"base":{"label":"bucandy:master","ref":"master","sha":"97b8937825bf0a7dc87fce9c8dd91e13f55d122d","user":{"login":"bucandy","id":20282671,"avatar_url":"https://avatars.githubusercontent.com/u/20282671?v=3","gravatar_id":"","url":"https://api.github.com/users/bucandy","html_url":"https://github.com/bucandy","followers_url":"https://api.github.com/users/bucandy/followers","following_url":"https://api.github.com/users/bucandy/following{/other_user}","gists_url":"https://api.github.com/users/bucandy/gists{/gist_id}","starred_url":"https://api.github.com/users/bucandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bucandy/subscriptions","organizations_url":"https://api.github.com/users/bucandy/orgs","repos_url":"https://api.github.com/users/bucandy/repos","events_url":"https://api.github.com/users/bucandy/events{/privacy}","received_events_url":"https://api.github.com/users/bucandy/received_events","type":"User","site_admin":false},"repo":{"id":62977115,"name":"Basic-Calculator","full_name":"bucandy/Basic-Calculator","owner":{"login":"bucandy","id":20282671,"avatar_url":"https://avatars.githubusercontent.com/u/20282671?v=3","gravatar_id":"","url":"https://api.github.com/users/bucandy","html_url":"https://github.com/bucandy","followers_url":"https://api.github.com/users/bucandy/followers","following_url":"https://api.github.com/users/bucandy/following{/other_user}","gists_url":"https://api.github.com/users/bucandy/gists{/gist_id}","starred_url":"https://api.github.com/users/bucandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bucandy/subscriptions","organizations_url":"https://api.github.com/users/bucandy/orgs","repos_url":"https://api.github.com/users/bucandy/repos","events_url":"https://api.github.com/users/bucandy/events{/privacy}","received_events_url":"https://api.github.com/users/bucandy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bucandy/Basic-Calculator","description":"1.1 Improvements","fork":false,"url":"https://api.github.com/repos/bucandy/Basic-Calculator","forks_url":"https://api.github.com/repos/bucandy/Basic-Calculator/forks","keys_url":"https://api.github.com/repos/bucandy/Basic-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bucandy/Basic-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bucandy/Basic-Calculator/teams","hooks_url":"https://api.github.com/repos/bucandy/Basic-Calculator/hooks","issue_events_url":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/bucandy/Basic-Calculator/events","assignees_url":"https://api.github.com/repos/bucandy/Basic-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/bucandy/Basic-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/bucandy/Basic-Calculator/tags","blobs_url":"https://api.github.com/repos/bucandy/Basic-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bucandy/Basic-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bucandy/Basic-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/bucandy/Basic-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bucandy/Basic-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/bucandy/Basic-Calculator/languages","stargazers_url":"https://api.github.com/repos/bucandy/Basic-Calculator/stargazers","contributors_url":"https://api.github.com/repos/bucandy/Basic-Calculator/contributors","subscribers_url":"https://api.github.com/repos/bucandy/Basic-Calculator/subscribers","subscription_url":"https://api.github.com/repos/bucandy/Basic-Calculator/subscription","commits_url":"https://api.github.com/repos/bucandy/Basic-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/bucandy/Basic-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/bucandy/Basic-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/bucandy/Basic-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/bucandy/Basic-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bucandy/Basic-Calculator/merges","archive_url":"https://api.github.com/repos/bucandy/Basic-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bucandy/Basic-Calculator/downloads","issues_url":"https://api.github.com/repos/bucandy/Basic-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/bucandy/Basic-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/bucandy/Basic-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bucandy/Basic-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/bucandy/Basic-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/bucandy/Basic-Calculator/deployments","created_at":"2016-07-10T01:57:54Z","updated_at":"2016-07-10T09:32:50Z","pushed_at":"2016-07-10T09:34:29Z","git_url":"git://github.com/bucandy/Basic-Calculator.git","ssh_url":"git@github.com:bucandy/Basic-Calculator.git","clone_url":"https://github.com/bucandy/Basic-Calculator.git","svn_url":"https://github.com/bucandy/Basic-Calculator","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2"},"html":{"href":"https://github.com/bucandy/Basic-Calculator/pull/2"},"issue":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/2"},"comments":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/bucandy/Basic-Calculator/statuses/48894bbf1f774afea615fe7f5619c46400357c9a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":153,"deletions":73,"changed_files":7}}
{"actor":{"display_login":"DennisDenuto"}}