{"action":"created","comment":{"url":"https://api.github.com/repos/Alephbet/gimel/pulls/comments/62546549","id":62546549,"diff_hunk":"@@ -4,3 +4,8 @@ include gimel/VERSION\n include gimel/config.json.template\n include requirements.txt\n recursive-include gimel/vendor *\n+\n+exclude tox.ini\n+exclude requirements.in\n+exclude requirements.txt","path":"MANIFEST.in","position":9,"original_position":7,"commit_id":"7077055862e150175e1014b0fe11f9c69e8a27c7","original_commit_id":"375db02ece677e34a193228974d7c6402063846e","user":{"login":"gingerlime","id":524274,"avatar_url":"https://avatars.githubusercontent.com/u/524274?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerlime","html_url":"https://github.com/gingerlime","followers_url":"https://api.github.com/users/gingerlime/followers","following_url":"https://api.github.com/users/gingerlime/following{/other_user}","gists_url":"https://api.github.com/users/gingerlime/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerlime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerlime/subscriptions","organizations_url":"https://api.github.com/users/gingerlime/orgs","repos_url":"https://api.github.com/users/gingerlime/repos","events_url":"https://api.github.com/users/gingerlime/events{/privacy}","received_events_url":"https://api.github.com/users/gingerlime/received_events","type":"User","site_admin":false},"body":"Currently the setup.py requirements are explicitly defined without `requirements.txt`. See https://github.com/Alephbet/gimel/blob/master/setup.py#L6 - not sure what's the best practice though.","created_at":"2016-05-09T18:17:33Z","updated_at":"2016-05-09T18:17:33Z","html_url":"https://github.com/Alephbet/gimel/pull/5#discussion_r62546549","pull_request_url":"https://api.github.com/repos/Alephbet/gimel/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/comments/62546549"},"html":{"href":"https://github.com/Alephbet/gimel/pull/5#discussion_r62546549"},"pull_request":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Alephbet/gimel/pulls/5","id":69376195,"html_url":"https://github.com/Alephbet/gimel/pull/5","diff_url":"https://github.com/Alephbet/gimel/pull/5.diff","patch_url":"https://github.com/Alephbet/gimel/pull/5.patch","issue_url":"https://api.github.com/repos/Alephbet/gimel/issues/5","number":5,"state":"open","locked":false,"title":"Travis","user":{"login":"Azd325","id":426541,"avatar_url":"https://avatars.githubusercontent.com/u/426541?v=3","gravatar_id":"","url":"https://api.github.com/users/Azd325","html_url":"https://github.com/Azd325","followers_url":"https://api.github.com/users/Azd325/followers","following_url":"https://api.github.com/users/Azd325/following{/other_user}","gists_url":"https://api.github.com/users/Azd325/gists{/gist_id}","starred_url":"https://api.github.com/users/Azd325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azd325/subscriptions","organizations_url":"https://api.github.com/users/Azd325/orgs","repos_url":"https://api.github.com/users/Azd325/repos","events_url":"https://api.github.com/users/Azd325/events{/privacy}","received_events_url":"https://api.github.com/users/Azd325/received_events","type":"User","site_admin":false},"body":"This adds  some simple support to run tox on travis and locally. \r\n- pep8 checks for python2 and python3\r\n- packaging check of manifest and readme(for pypi)\r\n\r\nI adapt the files to let the test pass\r\n\r\n- Manifest files reflects now the new files\r\n- *.pyc files got removed from the vendor package.\r\n- Some pep8 fixes\r\n- Convert readme.md to .rst to let it render on pypi","created_at":"2016-05-09T16:53:15Z","updated_at":"2016-05-09T18:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5df2319179e6eb64c2dfd15469f18added41074","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alephbet/gimel/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Alephbet/gimel/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Alephbet/gimel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alephbet/gimel/issues/5/comments","statuses_url":"https://api.github.com/repos/Alephbet/gimel/statuses/7077055862e150175e1014b0fe11f9c69e8a27c7","head":{"label":"Azd325:travis","ref":"travis","sha":"7077055862e150175e1014b0fe11f9c69e8a27c7","user":{"login":"Azd325","id":426541,"avatar_url":"https://avatars.githubusercontent.com/u/426541?v=3","gravatar_id":"","url":"https://api.github.com/users/Azd325","html_url":"https://github.com/Azd325","followers_url":"https://api.github.com/users/Azd325/followers","following_url":"https://api.github.com/users/Azd325/following{/other_user}","gists_url":"https://api.github.com/users/Azd325/gists{/gist_id}","starred_url":"https://api.github.com/users/Azd325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azd325/subscriptions","organizations_url":"https://api.github.com/users/Azd325/orgs","repos_url":"https://api.github.com/users/Azd325/repos","events_url":"https://api.github.com/users/Azd325/events{/privacy}","received_events_url":"https://api.github.com/users/Azd325/received_events","type":"User","site_admin":false},"repo":{"id":58384586,"name":"gimel","full_name":"Azd325/gimel","owner":{"login":"Azd325","id":426541,"avatar_url":"https://avatars.githubusercontent.com/u/426541?v=3","gravatar_id":"","url":"https://api.github.com/users/Azd325","html_url":"https://github.com/Azd325","followers_url":"https://api.github.com/users/Azd325/followers","following_url":"https://api.github.com/users/Azd325/following{/other_user}","gists_url":"https://api.github.com/users/Azd325/gists{/gist_id}","starred_url":"https://api.github.com/users/Azd325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azd325/subscriptions","organizations_url":"https://api.github.com/users/Azd325/orgs","repos_url":"https://api.github.com/users/Azd325/repos","events_url":"https://api.github.com/users/Azd325/events{/privacy}","received_events_url":"https://api.github.com/users/Azd325/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Azd325/gimel","description":"Run your own A/B testing backend using AWS Lambda and Redis HyperLogLog","fork":true,"url":"https://api.github.com/repos/Azd325/gimel","forks_url":"https://api.github.com/repos/Azd325/gimel/forks","keys_url":"https://api.github.com/repos/Azd325/gimel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azd325/gimel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azd325/gimel/teams","hooks_url":"https://api.github.com/repos/Azd325/gimel/hooks","issue_events_url":"https://api.github.com/repos/Azd325/gimel/issues/events{/number}","events_url":"https://api.github.com/repos/Azd325/gimel/events","assignees_url":"https://api.github.com/repos/Azd325/gimel/assignees{/user}","branches_url":"https://api.github.com/repos/Azd325/gimel/branches{/branch}","tags_url":"https://api.github.com/repos/Azd325/gimel/tags","blobs_url":"https://api.github.com/repos/Azd325/gimel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azd325/gimel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azd325/gimel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azd325/gimel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azd325/gimel/statuses/{sha}","languages_url":"https://api.github.com/repos/Azd325/gimel/languages","stargazers_url":"https://api.github.com/repos/Azd325/gimel/stargazers","contributors_url":"https://api.github.com/repos/Azd325/gimel/contributors","subscribers_url":"https://api.github.com/repos/Azd325/gimel/subscribers","subscription_url":"https://api.github.com/repos/Azd325/gimel/subscription","commits_url":"https://api.github.com/repos/Azd325/gimel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azd325/gimel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azd325/gimel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azd325/gimel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azd325/gimel/contents/{+path}","compare_url":"https://api.github.com/repos/Azd325/gimel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azd325/gimel/merges","archive_url":"https://api.github.com/repos/Azd325/gimel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azd325/gimel/downloads","issues_url":"https://api.github.com/repos/Azd325/gimel/issues{/number}","pulls_url":"https://api.github.com/repos/Azd325/gimel/pulls{/number}","milestones_url":"https://api.github.com/repos/Azd325/gimel/milestones{/number}","notifications_url":"https://api.github.com/repos/Azd325/gimel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azd325/gimel/labels{/name}","releases_url":"https://api.github.com/repos/Azd325/gimel/releases{/id}","deployments_url":"https://api.github.com/repos/Azd325/gimel/deployments","created_at":"2016-05-09T14:49:54Z","updated_at":"2016-05-09T14:49:54Z","pushed_at":"2016-05-09T18:15:55Z","git_url":"git://github.com/Azd325/gimel.git","ssh_url":"git@github.com:Azd325/gimel.git","clone_url":"https://github.com/Azd325/gimel.git","svn_url":"https://github.com/Azd325/gimel","homepage":"","size":1275,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alephbet:master","ref":"master","sha":"03fba60307e457a41428d35cc583cad03a92be36","user":{"login":"Alephbet","id":16772317,"avatar_url":"https://avatars.githubusercontent.com/u/16772317?v=3","gravatar_id":"","url":"https://api.github.com/users/Alephbet","html_url":"https://github.com/Alephbet","followers_url":"https://api.github.com/users/Alephbet/followers","following_url":"https://api.github.com/users/Alephbet/following{/other_user}","gists_url":"https://api.github.com/users/Alephbet/gists{/gist_id}","starred_url":"https://api.github.com/users/Alephbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alephbet/subscriptions","organizations_url":"https://api.github.com/users/Alephbet/orgs","repos_url":"https://api.github.com/users/Alephbet/repos","events_url":"https://api.github.com/users/Alephbet/events{/privacy}","received_events_url":"https://api.github.com/users/Alephbet/received_events","type":"Organization","site_admin":false},"repo":{"id":50009661,"name":"gimel","full_name":"Alephbet/gimel","owner":{"login":"Alephbet","id":16772317,"avatar_url":"https://avatars.githubusercontent.com/u/16772317?v=3","gravatar_id":"","url":"https://api.github.com/users/Alephbet","html_url":"https://github.com/Alephbet","followers_url":"https://api.github.com/users/Alephbet/followers","following_url":"https://api.github.com/users/Alephbet/following{/other_user}","gists_url":"https://api.github.com/users/Alephbet/gists{/gist_id}","starred_url":"https://api.github.com/users/Alephbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alephbet/subscriptions","organizations_url":"https://api.github.com/users/Alephbet/orgs","repos_url":"https://api.github.com/users/Alephbet/repos","events_url":"https://api.github.com/users/Alephbet/events{/privacy}","received_events_url":"https://api.github.com/users/Alephbet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alephbet/gimel","description":"Run your own A/B testing backend using AWS Lambda and Redis HyperLogLog","fork":false,"url":"https://api.github.com/repos/Alephbet/gimel","forks_url":"https://api.github.com/repos/Alephbet/gimel/forks","keys_url":"https://api.github.com/repos/Alephbet/gimel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alephbet/gimel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alephbet/gimel/teams","hooks_url":"https://api.github.com/repos/Alephbet/gimel/hooks","issue_events_url":"https://api.github.com/repos/Alephbet/gimel/issues/events{/number}","events_url":"https://api.github.com/repos/Alephbet/gimel/events","assignees_url":"https://api.github.com/repos/Alephbet/gimel/assignees{/user}","branches_url":"https://api.github.com/repos/Alephbet/gimel/branches{/branch}","tags_url":"https://api.github.com/repos/Alephbet/gimel/tags","blobs_url":"https://api.github.com/repos/Alephbet/gimel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alephbet/gimel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alephbet/gimel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alephbet/gimel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alephbet/gimel/statuses/{sha}","languages_url":"https://api.github.com/repos/Alephbet/gimel/languages","stargazers_url":"https://api.github.com/repos/Alephbet/gimel/stargazers","contributors_url":"https://api.github.com/repos/Alephbet/gimel/contributors","subscribers_url":"https://api.github.com/repos/Alephbet/gimel/subscribers","subscription_url":"https://api.github.com/repos/Alephbet/gimel/subscription","commits_url":"https://api.github.com/repos/Alephbet/gimel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alephbet/gimel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alephbet/gimel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alephbet/gimel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alephbet/gimel/contents/{+path}","compare_url":"https://api.github.com/repos/Alephbet/gimel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alephbet/gimel/merges","archive_url":"https://api.github.com/repos/Alephbet/gimel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alephbet/gimel/downloads","issues_url":"https://api.github.com/repos/Alephbet/gimel/issues{/number}","pulls_url":"https://api.github.com/repos/Alephbet/gimel/pulls{/number}","milestones_url":"https://api.github.com/repos/Alephbet/gimel/milestones{/number}","notifications_url":"https://api.github.com/repos/Alephbet/gimel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alephbet/gimel/labels{/name}","releases_url":"https://api.github.com/repos/Alephbet/gimel/releases{/id}","deployments_url":"https://api.github.com/repos/Alephbet/gimel/deployments","created_at":"2016-01-20T06:28:14Z","updated_at":"2016-05-09T18:05:28Z","pushed_at":"2016-05-09T18:15:55Z","git_url":"git://github.com/Alephbet/gimel.git","ssh_url":"git@github.com:Alephbet/gimel.git","clone_url":"https://github.com/Alephbet/gimel.git","svn_url":"https://github.com/Alephbet/gimel","homepage":"","size":1264,"stargazers_count":112,"watchers_count":112,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/5"},"html":{"href":"https://github.com/Alephbet/gimel/pull/5"},"issue":{"href":"https://api.github.com/repos/Alephbet/gimel/issues/5"},"comments":{"href":"https://api.github.com/repos/Alephbet/gimel/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alephbet/gimel/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Alephbet/gimel/statuses/7077055862e150175e1014b0fe11f9c69e8a27c7"}}}}