{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/1260","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/1260/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1260/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/1260/events","html_url":"https://github.com/codice/ddf/pull/1260","id":176470378,"number":1260,"title":"DDF-2468 Add support for more FTP commands","user":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"beyelerb","id":4429907,"avatar_url":"https://avatars.githubusercontent.com/u/4429907?v=3","gravatar_id":"","url":"https://api.github.com/users/beyelerb","html_url":"https://github.com/beyelerb","followers_url":"https://api.github.com/users/beyelerb/followers","following_url":"https://api.github.com/users/beyelerb/following{/other_user}","gists_url":"https://api.github.com/users/beyelerb/gists{/gist_id}","starred_url":"https://api.github.com/users/beyelerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyelerb/subscriptions","organizations_url":"https://api.github.com/users/beyelerb/orgs","repos_url":"https://api.github.com/users/beyelerb/repos","events_url":"https://api.github.com/users/beyelerb/events{/privacy}","received_events_url":"https://api.github.com/users/beyelerb/received_events","type":"User","site_admin":false},"assignees":[{"login":"beyelerb","id":4429907,"avatar_url":"https://avatars.githubusercontent.com/u/4429907?v=3","gravatar_id":"","url":"https://api.github.com/users/beyelerb","html_url":"https://github.com/beyelerb","followers_url":"https://api.github.com/users/beyelerb/followers","following_url":"https://api.github.com/users/beyelerb/following{/other_user}","gists_url":"https://api.github.com/users/beyelerb/gists{/gist_id}","starred_url":"https://api.github.com/users/beyelerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyelerb/subscriptions","organizations_url":"https://api.github.com/users/beyelerb/orgs","repos_url":"https://api.github.com/users/beyelerb/repos","events_url":"https://api.github.com/users/beyelerb/events{/privacy}","received_events_url":"https://api.github.com/users/beyelerb/received_events","type":"User","site_admin":false},{"login":"kcwire","id":4631300,"avatar_url":"https://avatars.githubusercontent.com/u/4631300?v=3","gravatar_id":"","url":"https://api.github.com/users/kcwire","html_url":"https://github.com/kcwire","followers_url":"https://api.github.com/users/kcwire/followers","following_url":"https://api.github.com/users/kcwire/following{/other_user}","gists_url":"https://api.github.com/users/kcwire/gists{/gist_id}","starred_url":"https://api.github.com/users/kcwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcwire/subscriptions","organizations_url":"https://api.github.com/users/kcwire/orgs","repos_url":"https://api.github.com/users/kcwire/repos","events_url":"https://api.github.com/users/kcwire/events{/privacy}","received_events_url":"https://api.github.com/users/kcwire/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-12T20:03:42Z","updated_at":"2016-09-12T22:08:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1260","html_url":"https://github.com/codice/ddf/pull/1260","diff_url":"https://github.com/codice/ddf/pull/1260.diff","patch_url":"https://github.com/codice/ddf/pull/1260.patch"},"body":"#### What does this PR do?\r\n\r\nSTOU - Full support is added. The FTP server will return a success message that\r\nincludes the metacard id, which the client can interpret as the unique name given\r\nto the object.\r\n    \r\nSITE - Since the FTP server does not have any site-specific commands, the server\r\nnow returns the status code 202, which indicates that SITE is not implemented.\r\n    \r\nDELE, RETR, RMD, MKD, APPE, RNTO - The FTP server returns a response indicating\r\nsuccess, even though no action was taken. Some clients, for example, always\r\nattempt to make a new directory and then CD to it. This isn't necessary from\r\nthe DDF point of view. Previously, the server would return an error that would\r\ncause the client to fail.\r\n\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@peterhuffer \r\n@beyelerb \r\n@troymohl \r\n\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@beyelerb\r\n@kcwire\r\n#### How should this be tested?\r\nBuild and install DDF. Enable the catalog-ftp feature. From the command line, start an ftp client:\r\n\r\n$ ftp admin@localhost 8021\r\nftp> binary\r\nftp> sunique on\r\nftp> put some-file.pdf\r\n\r\nFrom the catalog search, confirm that the file was uploaded.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nDDF-2468\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/246510873","html_url":"https://github.com/codice/ddf/pull/1260#issuecomment-246510873","issue_url":"https://api.github.com/repos/codice/ddf/issues/1260","id":246510873,"user":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T22:08:54Z","updated_at":"2016-09-12T22:08:54Z","body":"Note: I still need to add support for clients that upload to .filename and then rename"}}
{"actor":{"display_login":"glenhein"}}