{"action":"closed","number":231,"pull_request":{"url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231","id":98221055,"html_url":"https://github.com/Preston-Crary/liferay-portal/pull/231","diff_url":"https://github.com/Preston-Crary/liferay-portal/pull/231.diff","patch_url":"https://github.com/Preston-Crary/liferay-portal/pull/231.patch","issue_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/231","number":231,"state":"closed","locked":false,"title":"LPS-69516","user":{"login":"ChrisKian","id":10406971,"avatar_url":"https://avatars.githubusercontent.com/u/10406971?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"body":"I think we were failing tests for two reasons: 1, the SQL would be improperly formatted in some scenarios (see \tba20623 and 70b8c40), and 2, I was adding groupIds as resourcePermission.primKeyIds when they should not be added anywhere (see 573e54f and 9654a76).  \r\n\r\nI've tested the following tests and MySql and they work fine: InlineSQLHelperImplTest, MBCategoryPersistenceTest (was failing due to bad SQL), and DLAppServiceTest (was failing due to groupIds injected at primKeyIds).\r\n\r\nThis PR obviously won't be the final one in terms of commit history, but I'm going to send it to you to look over the changes, as well as to run the CI.  Let me know what you think","created_at":"2016-12-15T20:05:32Z","updated_at":"2016-12-15T21:00:18Z","closed_at":"2016-12-15T21:00:18Z","merged_at":null,"merge_commit_sha":"051f992005bc27232d713ea3e41f5209552e89f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231/commits","review_comments_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231/comments","review_comment_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/231/comments","statuses_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/statuses/9654a767877305da44607170b49181fcfcbe37ff","head":{"label":"ChrisKian:LPS-69516-pr11","ref":"LPS-69516-pr11","sha":"9654a767877305da44607170b49181fcfcbe37ff","user":{"login":"ChrisKian","id":10406971,"avatar_url":"https://avatars.githubusercontent.com/u/10406971?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"repo":{"id":28833685,"name":"liferay-portal","full_name":"ChrisKian/liferay-portal","owner":{"login":"ChrisKian","id":10406971,"avatar_url":"https://avatars.githubusercontent.com/u/10406971?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisKian/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/ChrisKian/liferay-portal","forks_url":"https://api.github.com/repos/ChrisKian/liferay-portal/forks","keys_url":"https://api.github.com/repos/ChrisKian/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisKian/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisKian/liferay-portal/teams","hooks_url":"https://api.github.com/repos/ChrisKian/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisKian/liferay-portal/events","assignees_url":"https://api.github.com/repos/ChrisKian/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisKian/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisKian/liferay-portal/tags","blobs_url":"https://api.github.com/repos/ChrisKian/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisKian/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisKian/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisKian/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisKian/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisKian/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/ChrisKian/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/ChrisKian/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/ChrisKian/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/ChrisKian/liferay-portal/subscription","commits_url":"https://api.github.com/repos/ChrisKian/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisKian/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisKian/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisKian/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisKian/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisKian/liferay-portal/merges","archive_url":"https://api.github.com/repos/ChrisKian/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisKian/liferay-portal/downloads","issues_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisKian/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisKian/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisKian/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisKian/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/ChrisKian/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisKian/liferay-portal/deployments","created_at":"2015-01-05T21:55:20Z","updated_at":"2016-05-13T18:53:33Z","pushed_at":"2016-12-15T20:00:28Z","git_url":"git://github.com/ChrisKian/liferay-portal.git","ssh_url":"git@github.com:ChrisKian/liferay-portal.git","clone_url":"https://github.com/ChrisKian/liferay-portal.git","svn_url":"https://github.com/ChrisKian/liferay-portal","homepage":"http://liferay.com","size":10706061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Preston-Crary:master","ref":"master","sha":"b483a6fe9a9f080f4aa809ec80e3b61f2e149e85","user":{"login":"Preston-Crary","id":1714297,"avatar_url":"https://avatars.githubusercontent.com/u/1714297?v=3","gravatar_id":"","url":"https://api.github.com/users/Preston-Crary","html_url":"https://github.com/Preston-Crary","followers_url":"https://api.github.com/users/Preston-Crary/followers","following_url":"https://api.github.com/users/Preston-Crary/following{/other_user}","gists_url":"https://api.github.com/users/Preston-Crary/gists{/gist_id}","starred_url":"https://api.github.com/users/Preston-Crary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preston-Crary/subscriptions","organizations_url":"https://api.github.com/users/Preston-Crary/orgs","repos_url":"https://api.github.com/users/Preston-Crary/repos","events_url":"https://api.github.com/users/Preston-Crary/events{/privacy}","received_events_url":"https://api.github.com/users/Preston-Crary/received_events","type":"User","site_admin":false},"repo":{"id":10059083,"name":"liferay-portal","full_name":"Preston-Crary/liferay-portal","owner":{"login":"Preston-Crary","id":1714297,"avatar_url":"https://avatars.githubusercontent.com/u/1714297?v=3","gravatar_id":"","url":"https://api.github.com/users/Preston-Crary","html_url":"https://github.com/Preston-Crary","followers_url":"https://api.github.com/users/Preston-Crary/followers","following_url":"https://api.github.com/users/Preston-Crary/following{/other_user}","gists_url":"https://api.github.com/users/Preston-Crary/gists{/gist_id}","starred_url":"https://api.github.com/users/Preston-Crary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preston-Crary/subscriptions","organizations_url":"https://api.github.com/users/Preston-Crary/orgs","repos_url":"https://api.github.com/users/Preston-Crary/repos","events_url":"https://api.github.com/users/Preston-Crary/events{/privacy}","received_events_url":"https://api.github.com/users/Preston-Crary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Preston-Crary/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/Preston-Crary/liferay-portal","forks_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/forks","keys_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/teams","hooks_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/events","assignees_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/tags","blobs_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/subscription","commits_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/merges","archive_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/downloads","issues_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/deployments","created_at":"2013-05-14T16:01:48Z","updated_at":"2015-05-08T18:32:12Z","pushed_at":"2016-12-15T20:05:32Z","git_url":"git://github.com/Preston-Crary/liferay-portal.git","ssh_url":"git@github.com:Preston-Crary/liferay-portal.git","clone_url":"https://github.com/Preston-Crary/liferay-portal.git","svn_url":"https://github.com/Preston-Crary/liferay-portal","homepage":"http://liferay.com","size":10761948,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231"},"html":{"href":"https://github.com/Preston-Crary/liferay-portal/pull/231"},"issue":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/231"},"comments":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/Preston-Crary/liferay-portal/statuses/9654a767877305da44607170b49181fcfcbe37ff"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":20,"additions":572,"deletions":117,"changed_files":3}}
{"actor":{"display_login":"liferay-continuous-integration"}}