{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/58096712","id":58096712,"diff_hunk":"@@ -89,6 +89,39 @@ static void teardown(void)\n \n TestSuite(endpoint, .init = setup, .fini = teardown);\n \n+Test(endpoint_info, info)\n+{\n+\tint ret;\n+\n+\thints = fi_allocinfo();\n+\tcr_assert(hints, \"fi_allocinfo\");\n+\thints->fabric_attr->name = strdup(\"gni\");\n+\n+\tret = fi_getinfo(FI_VERSION(1, 0), NULL, 0, 0, hints, &fi);\n+\tcr_assert(!ret, \"fi_getinfo\");\n+\tcr_assert_eq(fi->ep_attr->type, FI_EP_RDM);\n+\tcr_assert_eq(fi->next->ep_attr->type, FI_EP_DGRAM);\n+\n+\tfi_freeinfo(fi);\n+\n+\thints->ep_attr->type = FI_EP_RDM;\n+\tret = fi_getinfo(FI_VERSION(1, 0), NULL, 0, 0, hints, &fi);\n+\tcr_assert(!ret, \"fi_getinfo\");\n+\tcr_assert_eq(fi->ep_attr->type, FI_EP_RDM);\n+\tcr_assert_eq(fi->next, NULL);\n+\n+\tfi_freeinfo(fi);\n+\n+\thints->ep_attr->type = FI_EP_DGRAM;\n+\tret = fi_getinfo(FI_VERSION(1, 0), NULL, 0, 0, hints, &fi);\n+\tcr_assert(!ret, \"fi_getinfo\");\n+\tcr_assert_eq(fi->ep_attr->type, FI_EP_DGRAM);\n+\tcr_assert_eq(fi->next, NULL);\n+\n+\tfi_freeinfo(fi);\n+\tfi_freeinfo(hints);\n+}","path":"prov/gni/test/ep.c","position":42,"original_position":42,"commit_id":"753d4e3642885f470d2df443cb2c44b898d48944","original_commit_id":"753d4e3642885f470d2df443cb2c44b898d48944","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"I'd like a make check which has something like a ```TEST_RUNNER``` make variable which allows those who use systems where one can't just run the tests on a front-end node to have a simple way to run on a compute node.\r\nFor example,  to run sandia shmem make check on a slurm system one can do\r\nmake check TEST_RUNNER='srun -n 1 --slurm options'\r\n\r\nthis is very handy.\r\n\r\nSee PR #1921 for a good demonstration of the importance of a make check.\r\n","created_at":"2016-03-31T17:46:58Z","updated_at":"2016-03-31T17:46:58Z","html_url":"https://github.com/ofiwg/libfabric/pull/1923#discussion_r58096712","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/58096712"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1923#discussion_r58096712"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923","id":64686966,"html_url":"https://github.com/ofiwg/libfabric/pull/1923","diff_url":"https://github.com/ofiwg/libfabric/pull/1923.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1923.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1923","number":1923,"state":"open","locked":false,"title":"prov/gni: Return info struct for all supported","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"endpoint types.\r\n\r\nGroup hints->ep_attr checks together in gnix_getinfo.\r\nDuplicate default EP_RDM info to EP_DGRAM info.\r\nAdd test to check returned info structs from fi_getinfo are correct.\r\n\r\nFixes:ofi-cray/libfabric-cray#747\r\n\r\nSigned-off-by: Chuck Fossen <chuckf@cray.com>\r\n(cherry picked from commit ofi-cray/libfabric-cray@86b4fdd03b5e96aa16a66964fe2ab2635dc094b7)\r\nupstream merge of ofi-cray/libfabric-cray#757\r\n@sungeunchoi ","created_at":"2016-03-30T19:56:35Z","updated_at":"2016-03-31T17:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c9cde96f4786b662e8798b4403ae41710ce6f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1923/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/753d4e3642885f470d2df443cb2c44b898d48944","head":{"label":"hppritcha:upstream_merge_pr757","ref":"upstream_merge_pr757","sha":"753d4e3642885f470d2df443cb2c44b898d48944","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"repo":{"id":29201359,"name":"libfabric","full_name":"hppritcha/libfabric","owner":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hppritcha/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/hppritcha/libfabric","forks_url":"https://api.github.com/repos/hppritcha/libfabric/forks","keys_url":"https://api.github.com/repos/hppritcha/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hppritcha/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hppritcha/libfabric/teams","hooks_url":"https://api.github.com/repos/hppritcha/libfabric/hooks","issue_events_url":"https://api.github.com/repos/hppritcha/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/hppritcha/libfabric/events","assignees_url":"https://api.github.com/repos/hppritcha/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/hppritcha/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/hppritcha/libfabric/tags","blobs_url":"https://api.github.com/repos/hppritcha/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hppritcha/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hppritcha/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hppritcha/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hppritcha/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hppritcha/libfabric/languages","stargazers_url":"https://api.github.com/repos/hppritcha/libfabric/stargazers","contributors_url":"https://api.github.com/repos/hppritcha/libfabric/contributors","subscribers_url":"https://api.github.com/repos/hppritcha/libfabric/subscribers","subscription_url":"https://api.github.com/repos/hppritcha/libfabric/subscription","commits_url":"https://api.github.com/repos/hppritcha/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hppritcha/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hppritcha/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hppritcha/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hppritcha/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/hppritcha/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hppritcha/libfabric/merges","archive_url":"https://api.github.com/repos/hppritcha/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hppritcha/libfabric/downloads","issues_url":"https://api.github.com/repos/hppritcha/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/hppritcha/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hppritcha/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hppritcha/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hppritcha/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/hppritcha/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/hppritcha/libfabric/deployments","created_at":"2015-01-13T17:14:54Z","updated_at":"2016-02-24T03:51:39Z","pushed_at":"2016-03-31T17:07:51Z","git_url":"git://github.com/hppritcha/libfabric.git","ssh_url":"git@github.com:hppritcha/libfabric.git","clone_url":"https://github.com/hppritcha/libfabric.git","svn_url":"https://github.com/hppritcha/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":11833,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"14aae2c3e62dbdab38fa6abd0eb2e137c792edc6","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2016-03-10T08:50:51Z","pushed_at":"2016-03-31T17:10:24Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":11563,"stargazers_count":64,"watchers_count":64,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":83,"forks":63,"open_issues":83,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1923"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1923"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/753d4e3642885f470d2df443cb2c44b898d48944"}}}}