{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/63060798","id":63060798,"diff_hunk":"@@ -1,7 +1,20 @@\n /* @flow */\n 'use strict'\n \n+// SIGINT and uncaughtException do not run cleanup\n+// so we have an exitHandler to clean up the database connection\n+function exitHandler (error) {\n+  if (error) {\n+    console.error('Exiting: ', error)\n+    process.exit(1)\n+  }\n+  process.exit(0)\n+}\n+\n module.exports = require('./lib/app')\n if (!module.parent) {\n+  process.on('SIGINT', exitHandler)\n+  process.on('uncaughtException', exitHandler)","path":"src/app.js","position":17,"original_position":17,"commit_id":"ec2512a8fd40a49ae08d223ede3ace9de3ed12ae","original_commit_id":"4f292fc830b576ef72149afa7ef76e41af2df826","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"I've just tested again locally.\r\n\r\n1) Calling knex.destroy() in process.on('exit') doesn't do anything. The documentation states, \"Therefore you must only perform synchronous operations in this handler.\" knex.destroy is async\r\n\r\n2) If the process handles SIGINT and doesn't exit, it must be sent a SIGKILL (`kill -9`)\r\n\r\nThis must be sent a SIGKILL for it to exit, ctrl+c won't work.\r\n```\r\nprocess.on('SIGINT', () => {})\r\nsetTimeout(() => {}, 1000000)\r\n```","created_at":"2016-05-12T17:22:13Z","updated_at":"2016-05-12T17:22:13Z","html_url":"https://github.com/interledger/five-bells-ledger/pull/245#discussion_r63060798","pull_request_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/63060798"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/245#discussion_r63060798"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245","id":69719699,"html_url":"https://github.com/interledger/five-bells-ledger/pull/245","diff_url":"https://github.com/interledger/five-bells-ledger/pull/245.diff","patch_url":"https://github.com/interledger/five-bells-ledger/pull/245.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/245","number":245,"state":"open","locked":false,"title":"fix: teardown database connection on exit","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-11T18:29:16Z","updated_at":"2016-05-12T17:22:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f878a100c3b5ffdf5d1d2ed68830fca629ed8a46","assignee":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/245/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/ec2512a8fd40a49ae08d223ede3ace9de3ed12ae","head":{"label":"lumberj:fix/close-pool","ref":"fix/close-pool","sha":"ec2512a8fd40a49ae08d223ede3ace9de3ed12ae","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"repo":{"id":49240165,"name":"five-bells-ledger","full_name":"lumberj/five-bells-ledger","owner":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumberj/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":true,"url":"https://api.github.com/repos/lumberj/five-bells-ledger","forks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/lumberj/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumberj/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumberj/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/lumberj/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumberj/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/lumberj/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/lumberj/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumberj/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/lumberj/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumberj/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/lumberj/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/lumberj/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/lumberj/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumberj/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/lumberj/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/deployments","created_at":"2016-01-08T00:53:53Z","updated_at":"2016-01-08T00:53:54Z","pushed_at":"2016-05-11T21:18:10Z","git_url":"git://github.com/lumberj/five-bells-ledger.git","ssh_url":"git@github.com:lumberj/five-bells-ledger.git","clone_url":"https://github.com/lumberj/five-bells-ledger.git","svn_url":"https://github.com/lumberj/five-bells-ledger","homepage":null,"size":1112,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"bedfa432845cccfa55d5ad2a8a0600d2adf8b9d6","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608771,"name":"five-bells-ledger","full_name":"interledger/five-bells-ledger","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-ledger","forks_url":"https://api.github.com/repos/interledger/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-ledger/deployments","created_at":"2015-02-10T18:59:20Z","updated_at":"2016-04-29T19:27:04Z","pushed_at":"2016-05-11T22:05:31Z","git_url":"git://github.com/interledger/five-bells-ledger.git","ssh_url":"git@github.com:interledger/five-bells-ledger.git","clone_url":"https://github.com/interledger/five-bells-ledger.git","svn_url":"https://github.com/interledger/five-bells-ledger","homepage":null,"size":1187,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":12,"forks":8,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/245"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/245"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/ec2512a8fd40a49ae08d223ede3ace9de3ed12ae"}}}}