{"action":"opened","issue":{"url":"https://api.github.com/repos/hnarayanan/shpotify/issues/63","repository_url":"https://api.github.com/repos/hnarayanan/shpotify","labels_url":"https://api.github.com/repos/hnarayanan/shpotify/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/hnarayanan/shpotify/issues/63/comments","events_url":"https://api.github.com/repos/hnarayanan/shpotify/issues/63/events","html_url":"https://github.com/hnarayanan/shpotify/issues/63","id":178774712,"number":63,"title":"Sub commands should show separate help messages when used incorrectly","user":{"login":"ericmarkmartin","id":5509414,"avatar_url":"https://avatars.githubusercontent.com/u/5509414?v=3","gravatar_id":"","url":"https://api.github.com/users/ericmarkmartin","html_url":"https://github.com/ericmarkmartin","followers_url":"https://api.github.com/users/ericmarkmartin/followers","following_url":"https://api.github.com/users/ericmarkmartin/following{/other_user}","gists_url":"https://api.github.com/users/ericmarkmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmarkmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmarkmartin/subscriptions","organizations_url":"https://api.github.com/users/ericmarkmartin/orgs","repos_url":"https://api.github.com/users/ericmarkmartin/repos","events_url":"https://api.github.com/users/ericmarkmartin/events{/privacy}","received_events_url":"https://api.github.com/users/ericmarkmartin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-23T03:15:39Z","updated_at":"2016-09-23T03:15:39Z","closed_at":null,"body":"Currently, `spotify vol` will give you a message if you use the command incorrectly:\r\n```\r\n$ spotify vol foo\r\nImproper use of 'vol' command\r\nThe 'vol' command should be used as follows:\r\n  vol up                       # Increases the volume by 10%.\r\n  vol down                     # Decreases the volume by 10%.\r\n  vol [amount]                 # Sets the volume to an amount between 0 and 100.\r\n  vol                          # Shows the current Spotify volume.\r\n```\r\n\r\nI think it would be wise to make all commands conform to this, because otherwise things like this happen:\r\n\r\n```\r\n$ spotify toggle\r\n$\r\n$ spotify toggle foo\r\n$\r\n```\r\n\r\nI suppose that for most commands, this isn't particularly helpful (`status`, `next`, etc) but for some current commands and especially in the future, I think it would be helpful as new commands are implemented.\r\n\r\nAdditionally, I think that sub commands should allow this help menu to be invoked with \"help\" parameter, eg:\r\n\r\n```\r\n$ spotify vol help\r\nThe 'vol' command should be used as follows:\r\n  vol up                       # Increases the volume by 10%.\r\n  vol down                     # Decreases the volume by 10%.\r\n  vol [amount]                 # Sets the volume to an amount between 0 and 100.\r\n  vol                          # Shows the current Spotify volume.\r\n```\r\n\r\nMaybe that \"should\" should be changed to \"can\", but at that point I'm just messing with semantics.\r\n\r\nOf course, if we decide to go this route, `spotify play` poses an issue:\r\n\r\n```\r\n$ spotify play help\r\nSearching tracks for: help\r\nPlaying (help Search) -> Spotify URI: spotify:track:55jAHaYaZtUImilMnroSna\r\nEricMacbookPro:shpotify ericmarkmartin$ spotify status\r\nSpotify is currently playing.\r\nArtist: The Beatles\r\nAlbum: Live At The Hollywood Bowl\r\nTrack: Help! - Live / Remastered\r\nPosition: 0:02 / 2:52\r\n```\r\n\r\nwhich totally skipped my mind. Unfortunately, this is a completely valid usage, so we'll have to think of a way to deal with that...\r\n\r\nOf course, we could also implement a synonymous -h flag for sub commands.\r\n\r\nSide note, and maybe I'm getting too ambitious (especially for `1.3.0`) but just screwing around with the implementation of this sort of a feature is indicating to me that maybe it's time for the sub commands to separated out into their own files? I don't know.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"ericmarkmartin"}}