{"action":"created","comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/50540118","id":50540118,"diff_hunk":"@@ -0,0 +1,63 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<lccdd xmlns:compact=\"http://www.lcsim.org/schemas/compact/1.0\"\n+  xmlns:xs=\"http://www.w3.org/2001/XMLSchema\"\n+  xs:noNamespaceSchemaLocation=\"http://www.lcsim.org/schemas/compact/1.0/compact.xsd\">\n+\n+  <info name=\"HCal_Barrel\"\n+    title=\"Tile Calorimeter barrel\"\n+    author=\"C. Solans, J. Lingemann\"\n+    url=\"no\"\n+    status=\"development\"\n+    version=\"$Id:??$\">\n+    <comment>HCal layout based on ATLAS HCal</comment>\n+  </info>\n+\n+  <define>\n+\n+    <!-- NOTE: All lengths (anything but radii) given below are interpreted as half-lenghts! -->\n+    <!-- dimensions in R / rho of actual detector modules (face-plate is placed inside)-->\n+    <constant name=\"BarHCal_rmin\" value=\"1010*mm\"/>\n+    <constant name=\"BarHCal_rmax\" value=\"6000*mm\"/>\n+    <!-- length in z -->\n+    <!-- Note that this is just a guideline to the factory method: It will actually do a HCal of length\n+      static_cast<int>(BarHCal_dz / Module_thickness) +\n+    -->\n+    <constant name=\"BarHCal_dz\" value=\"6000*mm\"/>\n+    <!-- tile dimensions -->\n+    <constant name=\"BarHCal_n_phi_modules\" value=\"120\"/>\n+    <constant name=\"BarHCal_module_drho\" value=\"100*mm\"/>\n+    <constant name=\"BarHCAL_module_spacing_phi\" value=\"0.5*mm\"/>\n+    <!-- component dimensions -->\n+    <constant name=\"BarHCal_master_plate_thickness\" value=\"5*mm\" />\n+    <constant name=\"BarHCal_spacer_plate_thickness\" value=\"4*mm\" />\n+    <constant name=\"BarHCal_air_space_thickness\" value=\"0.5*mm\" />\n+    <constant name=\"BarHCal_scintillator_thickness\" value=\"3*mm\" />\n+    <!-- face and end-plate dimensions -->\n+    <constant name=\"BarHCal_end_plate_thickness\" value=\"5*mm\" />\n+    <constant name=\"BarHCal_face_plate_thickness\" value=\"10*mm\" />\n+  </define>\n+\n+  <display>\n+    <vis name=\"hcal_steel_vis\" r=\"0.5\" g=\"0.5\" b=\"0.5\" alpha=\"1\" showDaughters=\"false\" visible=\"true\" drawingStyle=\"solid\" />\n+    <vis name=\"hcal_steel_master_vis\" r=\"0.6\" g=\"0.6\" b=\"0.6\" alpha=\"1\" showDaughters=\"false\" visible=\"true\" drawingStyle=\"solid\" />\n+    <vis name=\"hcal_face_plate_vis\" r=\"0.8\" g=\"0.3\" b=\"0.3\" alpha=\"1\" showDaughters=\"false\" visible=\"true\" drawingStyle=\"solid\" />\n+    <vis name=\"hcal_end_plate_vis\" r=\"0.8\" g=\"0.3\" b=\"0.3\" alpha=\"1\" showDaughters=\"false\" visible=\"true\" drawingStyle=\"solid\" />\n+    <vis name=\"hcal_polystyrene_vis\" r=\"0.4\" g=\"0.4\" b=\"0.8\" alpha=\"1\" showDaughters=\"false\" visible=\"true\" drawingStyle=\"solid\" />\n+    <vis name=\"hcal_envelope\" r=\"0.6\" g=\"0.8\" b=\"0.6\" alpha=\"1\" showDaughers=\"true\" visible=\"false\" />\n+    <vis name=\"hcal_barrel_seq1_vis\" r=\"0.6\" g=\"0.8\" b=\"0.6\" alpha=\"1\" showDaughers=\"true\" visible=\"true\" />\n+    <vis name=\"hcal_barrel_seq2_vis\" r=\"0.6\" g=\"0.6\" b=\"0.8\" alpha=\"1\" showDaughers=\"true\" visible=\"true\" />\n+    <vis name=\"hcal_air_vis\" r=\"1\" g=\"1\" b=\"1\" alpha=\"1\" showDaughers=\"true\" visible=\"true\" />\n+  </display>\n+\n+  <readouts>\n+    <readout name=\"BarHCal_Readout\">\n+      <segmentation type=\"CartesianGridXY\" grid_size_x=\"0.05*mm\" grid_size_y=\"0.05*mm\"/>\n+      <id>system:3,layer:10,wedge:7,sub_module:2,row:9,x:32:-16,y:-16</id>\n+    </readout>\n+  </readouts>\n+\n+  <detectors>\n+    <include ref=\"FCChh_HCal.xml\" />\n+  </detectors>\n+</lccdd>\n+","path":"DetectorDescription/Detectors/compact/FCChh_HCalBarrel.xml","position":63,"original_position":63,"commit_id":"d07d257c8d76d7ef1b52c0237eb0de2b6fa640a4","original_commit_id":"d07d257c8d76d7ef1b52c0237eb0de2b6fa640a4","user":{"login":"jlingema","id":5601483,"avatar_url":"https://avatars.githubusercontent.com/u/5601483?v=3","gravatar_id":"","url":"https://api.github.com/users/jlingema","html_url":"https://github.com/jlingema","followers_url":"https://api.github.com/users/jlingema/followers","following_url":"https://api.github.com/users/jlingema/following{/other_user}","gists_url":"https://api.github.com/users/jlingema/gists{/gist_id}","starred_url":"https://api.github.com/users/jlingema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlingema/subscriptions","organizations_url":"https://api.github.com/users/jlingema/orgs","repos_url":"https://api.github.com/users/jlingema/repos","events_url":"https://api.github.com/users/jlingema/events{/privacy}","received_events_url":"https://api.github.com/users/jlingema/received_events","type":"User","site_admin":false},"body":"Same as for the other HCal description: Maybe just do a git mv instead?","created_at":"2016-01-22T14:11:59Z","updated_at":"2016-01-22T14:11:59Z","html_url":"https://github.com/HEP-FCC/FCCSW/pull/49#discussion_r50540118","pull_request_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/50540118"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/49#discussion_r50540118"},"pull_request":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49","id":55455835,"html_url":"https://github.com/HEP-FCC/FCCSW/pull/49","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/49.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/49.patch","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/49","number":49,"state":"open","locked":false,"title":"FCC DD4HEP detector geometry","user":{"login":"clementhelsens","id":5268237,"avatar_url":"https://avatars.githubusercontent.com/u/5268237?v=3","gravatar_id":"","url":"https://api.github.com/users/clementhelsens","html_url":"https://github.com/clementhelsens","followers_url":"https://api.github.com/users/clementhelsens/followers","following_url":"https://api.github.com/users/clementhelsens/following{/other_user}","gists_url":"https://api.github.com/users/clementhelsens/gists{/gist_id}","starred_url":"https://api.github.com/users/clementhelsens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementhelsens/subscriptions","organizations_url":"https://api.github.com/users/clementhelsens/orgs","repos_url":"https://api.github.com/users/clementhelsens/repos","events_url":"https://api.github.com/users/clementhelsens/events{/privacy}","received_events_url":"https://api.github.com/users/clementhelsens/received_events","type":"User","site_admin":false},"body":"Hello, \r\n\r\nI added simple cxx geometries to DD4HEP (cylinder, cone, parallelogram) and xml detectors elements for FCChh.\r\nFor this setup, I also added a Master file: FCChh_DectMaster.xml, containing includes and world dimensions.\r\nI also added a GUI: FCChh_DD4HEPgui.py to easily control the displays.\r\n\r\nClement","created_at":"2016-01-08T12:20:21Z","updated_at":"2016-01-22T14:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb695f27200051cd3b3707edaced95866ac8e7eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49/commits","review_comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49/comments","review_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/49/comments","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/d07d257c8d76d7ef1b52c0237eb0de2b6fa640a4","head":{"label":"clementhelsens:mockupdetetor","ref":"mockupdetetor","sha":"d07d257c8d76d7ef1b52c0237eb0de2b6fa640a4","user":{"login":"clementhelsens","id":5268237,"avatar_url":"https://avatars.githubusercontent.com/u/5268237?v=3","gravatar_id":"","url":"https://api.github.com/users/clementhelsens","html_url":"https://github.com/clementhelsens","followers_url":"https://api.github.com/users/clementhelsens/followers","following_url":"https://api.github.com/users/clementhelsens/following{/other_user}","gists_url":"https://api.github.com/users/clementhelsens/gists{/gist_id}","starred_url":"https://api.github.com/users/clementhelsens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementhelsens/subscriptions","organizations_url":"https://api.github.com/users/clementhelsens/orgs","repos_url":"https://api.github.com/users/clementhelsens/repos","events_url":"https://api.github.com/users/clementhelsens/events{/privacy}","received_events_url":"https://api.github.com/users/clementhelsens/received_events","type":"User","site_admin":false},"repo":{"id":21650890,"name":"FCCSW","full_name":"clementhelsens/FCCSW","owner":{"login":"clementhelsens","id":5268237,"avatar_url":"https://avatars.githubusercontent.com/u/5268237?v=3","gravatar_id":"","url":"https://api.github.com/users/clementhelsens","html_url":"https://github.com/clementhelsens","followers_url":"https://api.github.com/users/clementhelsens/followers","following_url":"https://api.github.com/users/clementhelsens/following{/other_user}","gists_url":"https://api.github.com/users/clementhelsens/gists{/gist_id}","starred_url":"https://api.github.com/users/clementhelsens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementhelsens/subscriptions","organizations_url":"https://api.github.com/users/clementhelsens/orgs","repos_url":"https://api.github.com/users/clementhelsens/repos","events_url":"https://api.github.com/users/clementhelsens/events{/privacy}","received_events_url":"https://api.github.com/users/clementhelsens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clementhelsens/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":true,"url":"https://api.github.com/repos/clementhelsens/FCCSW","forks_url":"https://api.github.com/repos/clementhelsens/FCCSW/forks","keys_url":"https://api.github.com/repos/clementhelsens/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clementhelsens/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clementhelsens/FCCSW/teams","hooks_url":"https://api.github.com/repos/clementhelsens/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/clementhelsens/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/clementhelsens/FCCSW/events","assignees_url":"https://api.github.com/repos/clementhelsens/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/clementhelsens/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/clementhelsens/FCCSW/tags","blobs_url":"https://api.github.com/repos/clementhelsens/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clementhelsens/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clementhelsens/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/clementhelsens/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clementhelsens/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/clementhelsens/FCCSW/languages","stargazers_url":"https://api.github.com/repos/clementhelsens/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/clementhelsens/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/clementhelsens/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/clementhelsens/FCCSW/subscription","commits_url":"https://api.github.com/repos/clementhelsens/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/clementhelsens/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/clementhelsens/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/clementhelsens/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/clementhelsens/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/clementhelsens/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clementhelsens/FCCSW/merges","archive_url":"https://api.github.com/repos/clementhelsens/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clementhelsens/FCCSW/downloads","issues_url":"https://api.github.com/repos/clementhelsens/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/clementhelsens/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/clementhelsens/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/clementhelsens/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clementhelsens/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/clementhelsens/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/clementhelsens/FCCSW/deployments","created_at":"2014-07-09T12:08:02Z","updated_at":"2015-04-01T08:37:45Z","pushed_at":"2016-01-08T12:56:46Z","git_url":"git://github.com/clementhelsens/FCCSW.git","ssh_url":"git@github.com:clementhelsens/FCCSW.git","clone_url":"https://github.com/clementhelsens/FCCSW.git","svn_url":"https://github.com/clementhelsens/FCCSW","homepage":null,"size":172712,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HEP-FCC:master","ref":"master","sha":"1f475f19721eb25a6a040931f5aa14b9217ad751","user":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"repo":{"id":21388221,"name":"FCCSW","full_name":"HEP-FCC/FCCSW","owner":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HEP-FCC/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":false,"url":"https://api.github.com/repos/HEP-FCC/FCCSW","forks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/forks","keys_url":"https://api.github.com/repos/HEP-FCC/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HEP-FCC/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HEP-FCC/FCCSW/teams","hooks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/events","assignees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/HEP-FCC/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/tags","blobs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/HEP-FCC/FCCSW/languages","stargazers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscription","commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/HEP-FCC/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HEP-FCC/FCCSW/merges","archive_url":"https://api.github.com/repos/HEP-FCC/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HEP-FCC/FCCSW/downloads","issues_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/HEP-FCC/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/HEP-FCC/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/deployments","created_at":"2014-07-01T13:16:22Z","updated_at":"2015-10-22T16:35:37Z","pushed_at":"2016-01-20T12:22:46Z","git_url":"git://github.com/HEP-FCC/FCCSW.git","ssh_url":"git@github.com:HEP-FCC/FCCSW.git","clone_url":"https://github.com/HEP-FCC/FCCSW.git","svn_url":"https://github.com/HEP-FCC/FCCSW","homepage":null,"size":172753,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":3,"forks":53,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/49"},"issue":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/49"},"comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/d07d257c8d76d7ef1b52c0237eb0de2b6fa640a4"}}}}