{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ignition/pulls/comments/77508801","id":77508801,"diff_hunk":"@@ -12,4 +30,7 @@ nconf.argv()\n     });\n \n nconf.defaults(defaults);\n-module.exports = nconf;\n\\ No newline at end of file\n+\n+// @TODO: this file gets cached after the first require, we need to redesign how we load the config\n+// @TODO: for example: require('ghost-ignition').config()","path":"lib/config/index.js","position":40,"original_position":36,"commit_id":"e6fd3f9ca1cd6c3987369e49925c521cb209b1d4","original_commit_id":"1cb2d2e4a4ba1c313455b5268e892509a39449f2","user":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars.githubusercontent.com/u/101513?v=3","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"body":"To be clear, what I'm saying with 1. is that I think this fix looks like it's trying to patch a bad assumption, whereas I'd suggest we change or remove the assumption","created_at":"2016-09-05T11:32:21Z","updated_at":"2016-09-05T11:32:21Z","html_url":"https://github.com/TryGhost/Ignition/pull/4#discussion_r77508801","pull_request_url":"https://api.github.com/repos/TryGhost/Ignition/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/comments/77508801"},"html":{"href":"https://github.com/TryGhost/Ignition/pull/4#discussion_r77508801"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ignition/pulls/4","id":83978338,"html_url":"https://github.com/TryGhost/Ignition/pull/4","diff_url":"https://github.com/TryGhost/Ignition/pull/4.diff","patch_url":"https://github.com/TryGhost/Ignition/pull/4.patch","issue_url":"https://api.github.com/repos/TryGhost/Ignition/issues/4","number":4,"state":"open","locked":false,"title":"🐛  change how we load config.example","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"refs #3\r\n\r\nThere are three problems:\r\n\r\n1. config.example.js was loaded via `process.cwd`, which can be wrong, because its the current working directory. the path must be the path to the parent who required the module (solved in this PR)\r\n2. it required a config.example.json, which needs to be optional (solved in this PR)\r\n3. config is a cached file, we need a dynamic function here because if multiple modules using ghost-ignition, we need to load the config files again (not solved in this PR, see TODO in PR)","created_at":"2016-09-05T10:03:06Z","updated_at":"2016-09-05T11:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0c970f8c4473d884896015b864a29a14c7d990f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ignition/pulls/4/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ignition/pulls/4/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ignition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ignition/issues/4/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ignition/statuses/e6fd3f9ca1cd6c3987369e49925c521cb209b1d4","head":{"label":"kirrg001:fix/config.example.js","ref":"fix/config.example.js","sha":"e6fd3f9ca1cd6c3987369e49925c521cb209b1d4","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"repo":{"id":67409587,"name":"Ignition","full_name":"kirrg001/Ignition","owner":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirrg001/Ignition","description":"Basic configuration and tooling shared across applications","fork":true,"url":"https://api.github.com/repos/kirrg001/Ignition","forks_url":"https://api.github.com/repos/kirrg001/Ignition/forks","keys_url":"https://api.github.com/repos/kirrg001/Ignition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirrg001/Ignition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirrg001/Ignition/teams","hooks_url":"https://api.github.com/repos/kirrg001/Ignition/hooks","issue_events_url":"https://api.github.com/repos/kirrg001/Ignition/issues/events{/number}","events_url":"https://api.github.com/repos/kirrg001/Ignition/events","assignees_url":"https://api.github.com/repos/kirrg001/Ignition/assignees{/user}","branches_url":"https://api.github.com/repos/kirrg001/Ignition/branches{/branch}","tags_url":"https://api.github.com/repos/kirrg001/Ignition/tags","blobs_url":"https://api.github.com/repos/kirrg001/Ignition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirrg001/Ignition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirrg001/Ignition/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirrg001/Ignition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirrg001/Ignition/statuses/{sha}","languages_url":"https://api.github.com/repos/kirrg001/Ignition/languages","stargazers_url":"https://api.github.com/repos/kirrg001/Ignition/stargazers","contributors_url":"https://api.github.com/repos/kirrg001/Ignition/contributors","subscribers_url":"https://api.github.com/repos/kirrg001/Ignition/subscribers","subscription_url":"https://api.github.com/repos/kirrg001/Ignition/subscription","commits_url":"https://api.github.com/repos/kirrg001/Ignition/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirrg001/Ignition/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirrg001/Ignition/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirrg001/Ignition/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirrg001/Ignition/contents/{+path}","compare_url":"https://api.github.com/repos/kirrg001/Ignition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirrg001/Ignition/merges","archive_url":"https://api.github.com/repos/kirrg001/Ignition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirrg001/Ignition/downloads","issues_url":"https://api.github.com/repos/kirrg001/Ignition/issues{/number}","pulls_url":"https://api.github.com/repos/kirrg001/Ignition/pulls{/number}","milestones_url":"https://api.github.com/repos/kirrg001/Ignition/milestones{/number}","notifications_url":"https://api.github.com/repos/kirrg001/Ignition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirrg001/Ignition/labels{/name}","releases_url":"https://api.github.com/repos/kirrg001/Ignition/releases{/id}","deployments_url":"https://api.github.com/repos/kirrg001/Ignition/deployments","created_at":"2016-09-05T09:57:35Z","updated_at":"2016-09-05T09:57:36Z","pushed_at":"2016-09-05T11:23:41Z","git_url":"git://github.com/kirrg001/Ignition.git","ssh_url":"git@github.com:kirrg001/Ignition.git","clone_url":"https://github.com/kirrg001/Ignition.git","svn_url":"https://github.com/kirrg001/Ignition","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"c24224ff20bd44cd6be225398546d78034f6834e","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":64837161,"name":"Ignition","full_name":"TryGhost/Ignition","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ignition","description":"Basic configuration and tooling shared across applications","fork":false,"url":"https://api.github.com/repos/TryGhost/Ignition","forks_url":"https://api.github.com/repos/TryGhost/Ignition/forks","keys_url":"https://api.github.com/repos/TryGhost/Ignition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ignition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ignition/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ignition/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ignition/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ignition/events","assignees_url":"https://api.github.com/repos/TryGhost/Ignition/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ignition/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ignition/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ignition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ignition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ignition/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ignition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ignition/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ignition/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ignition/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ignition/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ignition/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ignition/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ignition/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ignition/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ignition/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ignition/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ignition/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ignition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ignition/merges","archive_url":"https://api.github.com/repos/TryGhost/Ignition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ignition/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ignition/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ignition/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ignition/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ignition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ignition/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ignition/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ignition/deployments","created_at":"2016-08-03T10:27:11Z","updated_at":"2016-08-03T20:28:54Z","pushed_at":"2016-09-05T11:23:41Z","git_url":"git://github.com/TryGhost/Ignition.git","ssh_url":"git@github.com:TryGhost/Ignition.git","clone_url":"https://github.com/TryGhost/Ignition.git","svn_url":"https://github.com/TryGhost/Ignition","homepage":null,"size":10,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/4"},"html":{"href":"https://github.com/TryGhost/Ignition/pull/4"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ignition/issues/4"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ignition/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ignition/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ignition/statuses/e6fd3f9ca1cd6c3987369e49925c521cb209b1d4"}}}}
{"actor":{"display_login":"ErisDS"}}