{"action":"created","comment":{"url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/comments/81288104","pull_request_review_id":2276667,"id":81288104,"diff_hunk":"@@ -367,15 +368,22 @@ public void JoinRoom(ChatUser user, ChatRoom room, string inviteCode)\n                 }\n             }\n \n+\n             // Add this user to the room\n+\n+            //REMOVE _openroom\n+            //var _repository = new InMemoryRepository();\n+\n             _repository.AddUserRoom(user, room);\n \n             ChatUserPreferences userPreferences = user.Preferences;\n             userPreferences.TabOrder.Add(room.Name);\n             user.Preferences = userPreferences;\n \n             // Clear the cache\n-            _cache.RemoveUserInRoom(user, room);\n+            ","path":"src/JabbR-Core/Services/ChatService.cs","position":26,"original_position":26,"commit_id":"b64dcdbdeb9a5b0dc4ff42fd82167a9e9459a01b","original_commit_id":"b64dcdbdeb9a5b0dc4ff42fd82167a9e9459a01b","user":{"login":"adamtuliper","id":1740557,"avatar_url":"https://avatars.githubusercontent.com/u/1740557?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtuliper","html_url":"https://github.com/adamtuliper","followers_url":"https://api.github.com/users/adamtuliper/followers","following_url":"https://api.github.com/users/adamtuliper/following{/other_user}","gists_url":"https://api.github.com/users/adamtuliper/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtuliper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtuliper/subscriptions","organizations_url":"https://api.github.com/users/adamtuliper/orgs","repos_url":"https://api.github.com/users/adamtuliper/repos","events_url":"https://api.github.com/users/adamtuliper/events{/privacy}","received_events_url":"https://api.github.com/users/adamtuliper/received_events","type":"User","site_admin":false},"body":"CodeBeGone(tm)? or is this ok?","created_at":"2016-09-30T07:11:30Z","updated_at":"2016-09-30T07:12:05Z","html_url":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128#discussion_r81288104","pull_request_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/comments/81288104"},"html":{"href":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128#discussion_r81288104"},"pull_request":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128","id":87358423,"html_url":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128","diff_url":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128.diff","patch_url":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128.patch","issue_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/128","number":128,"state":"open","locked":false,"title":"Heather/leave command","user":{"login":"heatherbshapiro","id":8547756,"avatar_url":"https://avatars.githubusercontent.com/u/8547756?v=3","gravatar_id":"","url":"https://api.github.com/users/heatherbshapiro","html_url":"https://github.com/heatherbshapiro","followers_url":"https://api.github.com/users/heatherbshapiro/followers","following_url":"https://api.github.com/users/heatherbshapiro/following{/other_user}","gists_url":"https://api.github.com/users/heatherbshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/heatherbshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heatherbshapiro/subscriptions","organizations_url":"https://api.github.com/users/heatherbshapiro/orgs","repos_url":"https://api.github.com/users/heatherbshapiro/repos","events_url":"https://api.github.com/users/heatherbshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/heatherbshapiro/received_events","type":"User","site_admin":false},"body":"Implemented leave command. Currently works without the cache in LeaveRoom in chatservice.cs, but we will need to go back and add that back in once the cache is implemented. \r\n\r\nThe UI updates when you 'x' out of the room. Had to hack this as well in chat.js since leaveroom is checking to see if you are the correct user. Right now it closes the tab no matter what, but once authentication is properly implemented, we can change it back.","created_at":"2016-09-29T17:33:50Z","updated_at":"2016-09-30T07:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4ddde2e5ee20f02691dfe3381a15397055f3bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128/commits","review_comments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128/comments","review_comment_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/128/comments","statuses_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/statuses/b64dcdbdeb9a5b0dc4ff42fd82167a9e9459a01b","head":{"label":"MachUpskillingFY17:Heather/leaveCommand","ref":"Heather/leaveCommand","sha":"b64dcdbdeb9a5b0dc4ff42fd82167a9e9459a01b","user":{"login":"MachUpskillingFY17","id":21183238,"avatar_url":"https://avatars.githubusercontent.com/u/21183238?v=3","gravatar_id":"","url":"https://api.github.com/users/MachUpskillingFY17","html_url":"https://github.com/MachUpskillingFY17","followers_url":"https://api.github.com/users/MachUpskillingFY17/followers","following_url":"https://api.github.com/users/MachUpskillingFY17/following{/other_user}","gists_url":"https://api.github.com/users/MachUpskillingFY17/gists{/gist_id}","starred_url":"https://api.github.com/users/MachUpskillingFY17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachUpskillingFY17/subscriptions","organizations_url":"https://api.github.com/users/MachUpskillingFY17/orgs","repos_url":"https://api.github.com/users/MachUpskillingFY17/repos","events_url":"https://api.github.com/users/MachUpskillingFY17/events{/privacy}","received_events_url":"https://api.github.com/users/MachUpskillingFY17/received_events","type":"Organization","site_admin":false},"repo":{"id":66598928,"name":"JabbR-Core","full_name":"MachUpskillingFY17/JabbR-Core","owner":{"login":"MachUpskillingFY17","id":21183238,"avatar_url":"https://avatars.githubusercontent.com/u/21183238?v=3","gravatar_id":"","url":"https://api.github.com/users/MachUpskillingFY17","html_url":"https://github.com/MachUpskillingFY17","followers_url":"https://api.github.com/users/MachUpskillingFY17/followers","following_url":"https://api.github.com/users/MachUpskillingFY17/following{/other_user}","gists_url":"https://api.github.com/users/MachUpskillingFY17/gists{/gist_id}","starred_url":"https://api.github.com/users/MachUpskillingFY17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachUpskillingFY17/subscriptions","organizations_url":"https://api.github.com/users/MachUpskillingFY17/orgs","repos_url":"https://api.github.com/users/MachUpskillingFY17/repos","events_url":"https://api.github.com/users/MachUpskillingFY17/events{/privacy}","received_events_url":"https://api.github.com/users/MachUpskillingFY17/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MachUpskillingFY17/JabbR-Core","description":"Modern edition of JabbR chat client using .NET Core","fork":false,"url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core","forks_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/forks","keys_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/teams","hooks_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/hooks","issue_events_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/events","assignees_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/tags","blobs_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/languages","stargazers_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/stargazers","contributors_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/contributors","subscribers_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/subscribers","subscription_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/subscription","commits_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/merges","archive_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/downloads","issues_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/labels{/name}","releases_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/releases{/id}","deployments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/deployments","created_at":"2016-08-25T22:57:30Z","updated_at":"2016-09-28T20:01:33Z","pushed_at":"2016-09-29T23:10:54Z","git_url":"git://github.com/MachUpskillingFY17/JabbR-Core.git","ssh_url":"git@github.com:MachUpskillingFY17/JabbR-Core.git","clone_url":"https://github.com/MachUpskillingFY17/JabbR-Core.git","svn_url":"https://github.com/MachUpskillingFY17/JabbR-Core","homepage":"","size":36989,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":59,"forks":0,"open_issues":59,"watchers":1,"default_branch":"master"}},"base":{"label":"MachUpskillingFY17:dev","ref":"dev","sha":"68a8ed36af23ccd9a25a46c92bdd3598e3505688","user":{"login":"MachUpskillingFY17","id":21183238,"avatar_url":"https://avatars.githubusercontent.com/u/21183238?v=3","gravatar_id":"","url":"https://api.github.com/users/MachUpskillingFY17","html_url":"https://github.com/MachUpskillingFY17","followers_url":"https://api.github.com/users/MachUpskillingFY17/followers","following_url":"https://api.github.com/users/MachUpskillingFY17/following{/other_user}","gists_url":"https://api.github.com/users/MachUpskillingFY17/gists{/gist_id}","starred_url":"https://api.github.com/users/MachUpskillingFY17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachUpskillingFY17/subscriptions","organizations_url":"https://api.github.com/users/MachUpskillingFY17/orgs","repos_url":"https://api.github.com/users/MachUpskillingFY17/repos","events_url":"https://api.github.com/users/MachUpskillingFY17/events{/privacy}","received_events_url":"https://api.github.com/users/MachUpskillingFY17/received_events","type":"Organization","site_admin":false},"repo":{"id":66598928,"name":"JabbR-Core","full_name":"MachUpskillingFY17/JabbR-Core","owner":{"login":"MachUpskillingFY17","id":21183238,"avatar_url":"https://avatars.githubusercontent.com/u/21183238?v=3","gravatar_id":"","url":"https://api.github.com/users/MachUpskillingFY17","html_url":"https://github.com/MachUpskillingFY17","followers_url":"https://api.github.com/users/MachUpskillingFY17/followers","following_url":"https://api.github.com/users/MachUpskillingFY17/following{/other_user}","gists_url":"https://api.github.com/users/MachUpskillingFY17/gists{/gist_id}","starred_url":"https://api.github.com/users/MachUpskillingFY17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachUpskillingFY17/subscriptions","organizations_url":"https://api.github.com/users/MachUpskillingFY17/orgs","repos_url":"https://api.github.com/users/MachUpskillingFY17/repos","events_url":"https://api.github.com/users/MachUpskillingFY17/events{/privacy}","received_events_url":"https://api.github.com/users/MachUpskillingFY17/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MachUpskillingFY17/JabbR-Core","description":"Modern edition of JabbR chat client using .NET Core","fork":false,"url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core","forks_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/forks","keys_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/teams","hooks_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/hooks","issue_events_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/events","assignees_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/tags","blobs_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/languages","stargazers_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/stargazers","contributors_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/contributors","subscribers_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/subscribers","subscription_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/subscription","commits_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/merges","archive_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/downloads","issues_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/labels{/name}","releases_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/releases{/id}","deployments_url":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/deployments","created_at":"2016-08-25T22:57:30Z","updated_at":"2016-09-28T20:01:33Z","pushed_at":"2016-09-29T23:10:54Z","git_url":"git://github.com/MachUpskillingFY17/JabbR-Core.git","ssh_url":"git@github.com:MachUpskillingFY17/JabbR-Core.git","clone_url":"https://github.com/MachUpskillingFY17/JabbR-Core.git","svn_url":"https://github.com/MachUpskillingFY17/JabbR-Core","homepage":"","size":36989,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":59,"forks":0,"open_issues":59,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128"},"html":{"href":"https://github.com/MachUpskillingFY17/JabbR-Core/pull/128"},"issue":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/128"},"comments":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/MachUpskillingFY17/JabbR-Core/statuses/b64dcdbdeb9a5b0dc4ff42fd82167a9e9459a01b"}}}}
{"actor":{"display_login":"adamtuliper"}}