{"action":"created","comment":{"url":"https://api.github.com/repos/jmdns/jmdns/pulls/comments/73118530","id":73118530,"diff_hunk":"@@ -470,7 +470,10 @@ private void openMulticastSocket(HostInfo hostInfo) throws IOException {\n             }\n         }\n         _socket.setTimeToLive(255);\n-        _socket.joinGroup(_group);","path":"src/main/java/javax/jmdns/impl/JmDNSImpl.java","position":4,"original_position":4,"commit_id":"1bc816b2456e7fd6592159d316fd5b8443d2fca6","original_commit_id":"1bc816b2456e7fd6592159d316fd5b8443d2fca6","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"What about all the logic in lines 443ff which now seem to be out of effect? That does not look right to me.","created_at":"2016-08-02T08:57:44Z","updated_at":"2016-08-02T08:57:44Z","html_url":"https://github.com/jmdns/jmdns/pull/84#discussion_r73118530","pull_request_url":"https://api.github.com/repos/jmdns/jmdns/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/comments/73118530"},"html":{"href":"https://github.com/jmdns/jmdns/pull/84#discussion_r73118530"},"pull_request":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/jmdns/jmdns/pulls/84","id":79546767,"html_url":"https://github.com/jmdns/jmdns/pull/84","diff_url":"https://github.com/jmdns/jmdns/pull/84.diff","patch_url":"https://github.com/jmdns/jmdns/pull/84.patch","issue_url":"https://api.github.com/repos/jmdns/jmdns/issues/84","number":84,"state":"open","locked":false,"title":"Fix for java.net.SocketException: setsockopt failed: ENODEV (No such device) on android as on Wifi Hotspot(AP Mode)","user":{"login":"filipemagomes","id":20770135,"avatar_url":"https://avatars.githubusercontent.com/u/20770135?v=3","gravatar_id":"","url":"https://api.github.com/users/filipemagomes","html_url":"https://github.com/filipemagomes","followers_url":"https://api.github.com/users/filipemagomes/followers","following_url":"https://api.github.com/users/filipemagomes/following{/other_user}","gists_url":"https://api.github.com/users/filipemagomes/gists{/gist_id}","starred_url":"https://api.github.com/users/filipemagomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipemagomes/subscriptions","organizations_url":"https://api.github.com/users/filipemagomes/orgs","repos_url":"https://api.github.com/users/filipemagomes/repos","events_url":"https://api.github.com/users/filipemagomes/events{/privacy}","received_events_url":"https://api.github.com/users/filipemagomes/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI'm working with jmdns on Android.\r\n\r\nI have problems publishing services when android as on Wifi Hotspot(AP Mode).\r\nIt gives me \"java.net.SocketException: setsockopt failed: ENODEV (No such device)\"\r\n\r\nI make one change on method \"openMulticastSocket(HostInfo hostInfo)\" on \"JmDNSImpl\" class and now its working.\r\nThe change was: Replace \"_socket.joinGroup(_group);\" with _socket.joinGroup(new InetSocketAddress(_group,DNSConstants.MDNS_PORT),hostInfo.getInterface());\r\n\r\nSomebody else had this problem? Can someone try replicate the problem?","created_at":"2016-08-01T10:29:05Z","updated_at":"2016-08-02T08:57:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d4e049e7348648a1527b1a3d018c29699944fc9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jmdns/jmdns/pulls/84/commits","review_comments_url":"https://api.github.com/repos/jmdns/jmdns/pulls/84/comments","review_comment_url":"https://api.github.com/repos/jmdns/jmdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmdns/jmdns/issues/84/comments","statuses_url":"https://api.github.com/repos/jmdns/jmdns/statuses/1bc816b2456e7fd6592159d316fd5b8443d2fca6","head":{"label":"filipemagomes:master","ref":"master","sha":"1bc816b2456e7fd6592159d316fd5b8443d2fca6","user":{"login":"filipemagomes","id":20770135,"avatar_url":"https://avatars.githubusercontent.com/u/20770135?v=3","gravatar_id":"","url":"https://api.github.com/users/filipemagomes","html_url":"https://github.com/filipemagomes","followers_url":"https://api.github.com/users/filipemagomes/followers","following_url":"https://api.github.com/users/filipemagomes/following{/other_user}","gists_url":"https://api.github.com/users/filipemagomes/gists{/gist_id}","starred_url":"https://api.github.com/users/filipemagomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipemagomes/subscriptions","organizations_url":"https://api.github.com/users/filipemagomes/orgs","repos_url":"https://api.github.com/users/filipemagomes/repos","events_url":"https://api.github.com/users/filipemagomes/events{/privacy}","received_events_url":"https://api.github.com/users/filipemagomes/received_events","type":"User","site_admin":false},"repo":{"id":64657754,"name":"jmdns","full_name":"filipemagomes/jmdns","owner":{"login":"filipemagomes","id":20770135,"avatar_url":"https://avatars.githubusercontent.com/u/20770135?v=3","gravatar_id":"","url":"https://api.github.com/users/filipemagomes","html_url":"https://github.com/filipemagomes","followers_url":"https://api.github.com/users/filipemagomes/followers","following_url":"https://api.github.com/users/filipemagomes/following{/other_user}","gists_url":"https://api.github.com/users/filipemagomes/gists{/gist_id}","starred_url":"https://api.github.com/users/filipemagomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipemagomes/subscriptions","organizations_url":"https://api.github.com/users/filipemagomes/orgs","repos_url":"https://api.github.com/users/filipemagomes/repos","events_url":"https://api.github.com/users/filipemagomes/events{/privacy}","received_events_url":"https://api.github.com/users/filipemagomes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filipemagomes/jmdns","description":"Official home of the jmDNS library","fork":true,"url":"https://api.github.com/repos/filipemagomes/jmdns","forks_url":"https://api.github.com/repos/filipemagomes/jmdns/forks","keys_url":"https://api.github.com/repos/filipemagomes/jmdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipemagomes/jmdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipemagomes/jmdns/teams","hooks_url":"https://api.github.com/repos/filipemagomes/jmdns/hooks","issue_events_url":"https://api.github.com/repos/filipemagomes/jmdns/issues/events{/number}","events_url":"https://api.github.com/repos/filipemagomes/jmdns/events","assignees_url":"https://api.github.com/repos/filipemagomes/jmdns/assignees{/user}","branches_url":"https://api.github.com/repos/filipemagomes/jmdns/branches{/branch}","tags_url":"https://api.github.com/repos/filipemagomes/jmdns/tags","blobs_url":"https://api.github.com/repos/filipemagomes/jmdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipemagomes/jmdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipemagomes/jmdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipemagomes/jmdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipemagomes/jmdns/statuses/{sha}","languages_url":"https://api.github.com/repos/filipemagomes/jmdns/languages","stargazers_url":"https://api.github.com/repos/filipemagomes/jmdns/stargazers","contributors_url":"https://api.github.com/repos/filipemagomes/jmdns/contributors","subscribers_url":"https://api.github.com/repos/filipemagomes/jmdns/subscribers","subscription_url":"https://api.github.com/repos/filipemagomes/jmdns/subscription","commits_url":"https://api.github.com/repos/filipemagomes/jmdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipemagomes/jmdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipemagomes/jmdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipemagomes/jmdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipemagomes/jmdns/contents/{+path}","compare_url":"https://api.github.com/repos/filipemagomes/jmdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipemagomes/jmdns/merges","archive_url":"https://api.github.com/repos/filipemagomes/jmdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipemagomes/jmdns/downloads","issues_url":"https://api.github.com/repos/filipemagomes/jmdns/issues{/number}","pulls_url":"https://api.github.com/repos/filipemagomes/jmdns/pulls{/number}","milestones_url":"https://api.github.com/repos/filipemagomes/jmdns/milestones{/number}","notifications_url":"https://api.github.com/repos/filipemagomes/jmdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipemagomes/jmdns/labels{/name}","releases_url":"https://api.github.com/repos/filipemagomes/jmdns/releases{/id}","deployments_url":"https://api.github.com/repos/filipemagomes/jmdns/deployments","created_at":"2016-08-01T10:21:04Z","updated_at":"2016-08-01T10:21:05Z","pushed_at":"2016-08-01T10:25:38Z","git_url":"git://github.com/filipemagomes/jmdns.git","ssh_url":"git@github.com:filipemagomes/jmdns.git","clone_url":"https://github.com/filipemagomes/jmdns.git","svn_url":"https://github.com/filipemagomes/jmdns","homepage":"http://www.jmdns.org","size":2348,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmdns:master","ref":"master","sha":"ce2de155bad1e12d872afda05294f217b6eef6aa","user":{"login":"jmdns","id":16348169,"avatar_url":"https://avatars.githubusercontent.com/u/16348169?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdns","html_url":"https://github.com/jmdns","followers_url":"https://api.github.com/users/jmdns/followers","following_url":"https://api.github.com/users/jmdns/following{/other_user}","gists_url":"https://api.github.com/users/jmdns/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdns/subscriptions","organizations_url":"https://api.github.com/users/jmdns/orgs","repos_url":"https://api.github.com/users/jmdns/repos","events_url":"https://api.github.com/users/jmdns/events{/privacy}","received_events_url":"https://api.github.com/users/jmdns/received_events","type":"Organization","site_admin":false},"repo":{"id":21750896,"name":"jmdns","full_name":"jmdns/jmdns","owner":{"login":"jmdns","id":16348169,"avatar_url":"https://avatars.githubusercontent.com/u/16348169?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdns","html_url":"https://github.com/jmdns","followers_url":"https://api.github.com/users/jmdns/followers","following_url":"https://api.github.com/users/jmdns/following{/other_user}","gists_url":"https://api.github.com/users/jmdns/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdns/subscriptions","organizations_url":"https://api.github.com/users/jmdns/orgs","repos_url":"https://api.github.com/users/jmdns/repos","events_url":"https://api.github.com/users/jmdns/events{/privacy}","received_events_url":"https://api.github.com/users/jmdns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jmdns/jmdns","description":"Official home of the jmDNS library","fork":false,"url":"https://api.github.com/repos/jmdns/jmdns","forks_url":"https://api.github.com/repos/jmdns/jmdns/forks","keys_url":"https://api.github.com/repos/jmdns/jmdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmdns/jmdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmdns/jmdns/teams","hooks_url":"https://api.github.com/repos/jmdns/jmdns/hooks","issue_events_url":"https://api.github.com/repos/jmdns/jmdns/issues/events{/number}","events_url":"https://api.github.com/repos/jmdns/jmdns/events","assignees_url":"https://api.github.com/repos/jmdns/jmdns/assignees{/user}","branches_url":"https://api.github.com/repos/jmdns/jmdns/branches{/branch}","tags_url":"https://api.github.com/repos/jmdns/jmdns/tags","blobs_url":"https://api.github.com/repos/jmdns/jmdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmdns/jmdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmdns/jmdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmdns/jmdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmdns/jmdns/statuses/{sha}","languages_url":"https://api.github.com/repos/jmdns/jmdns/languages","stargazers_url":"https://api.github.com/repos/jmdns/jmdns/stargazers","contributors_url":"https://api.github.com/repos/jmdns/jmdns/contributors","subscribers_url":"https://api.github.com/repos/jmdns/jmdns/subscribers","subscription_url":"https://api.github.com/repos/jmdns/jmdns/subscription","commits_url":"https://api.github.com/repos/jmdns/jmdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmdns/jmdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmdns/jmdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmdns/jmdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmdns/jmdns/contents/{+path}","compare_url":"https://api.github.com/repos/jmdns/jmdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmdns/jmdns/merges","archive_url":"https://api.github.com/repos/jmdns/jmdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmdns/jmdns/downloads","issues_url":"https://api.github.com/repos/jmdns/jmdns/issues{/number}","pulls_url":"https://api.github.com/repos/jmdns/jmdns/pulls{/number}","milestones_url":"https://api.github.com/repos/jmdns/jmdns/milestones{/number}","notifications_url":"https://api.github.com/repos/jmdns/jmdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmdns/jmdns/labels{/name}","releases_url":"https://api.github.com/repos/jmdns/jmdns/releases{/id}","deployments_url":"https://api.github.com/repos/jmdns/jmdns/deployments","created_at":"2014-07-11T20:47:29Z","updated_at":"2016-08-01T15:44:46Z","pushed_at":"2016-08-02T06:19:32Z","git_url":"git://github.com/jmdns/jmdns.git","ssh_url":"git@github.com:jmdns/jmdns.git","clone_url":"https://github.com/jmdns/jmdns.git","svn_url":"https://github.com/jmdns/jmdns","homepage":"http://www.jmdns.org","size":2539,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":33,"forks":56,"open_issues":33,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/84"},"html":{"href":"https://github.com/jmdns/jmdns/pull/84"},"issue":{"href":"https://api.github.com/repos/jmdns/jmdns/issues/84"},"comments":{"href":"https://api.github.com/repos/jmdns/jmdns/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmdns/jmdns/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/jmdns/jmdns/statuses/1bc816b2456e7fd6592159d316fd5b8443d2fca6"}}}}
{"actor":{"display_login":"kaikreuzer"}}