{"action":"created","comment":{"url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/comments/56271036","id":56271036,"diff_hunk":"@@ -82,10 +82,14 @@ defmodule ExCsv.Parser do\n   end\n \n   # NEWLINE\n+  defp build(<<rt,nl>> <> rest, [[current_field | previous_fields] | previous_rows], %{return: rt, newline: nl, quoting: false} = config) do\n+    build_newline(rest, current_field, previous_fields, previous_rows, config)\n+  end\n+  defp build(<<char>> <> rest, [[current_field | previous_fields] | previous_rows], %{return: char, quoting: false} = config) do","path":"lib/ex_csv/parser.ex","position":14,"original_position":14,"commit_id":"1319f9bd7696149e980e7df34f6dfeec938c59db","original_commit_id":"1319f9bd7696149e980e7df34f6dfeec938c59db","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars.githubusercontent.com/u/247817?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"Nah let's go with the pattern.","created_at":"2016-03-16T01:45:26Z","updated_at":"2016-03-16T01:45:26Z","html_url":"https://github.com/CargoSense/ex_csv/pull/7#discussion_r56271036","pull_request_url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/comments/56271036"},"html":{"href":"https://github.com/CargoSense/ex_csv/pull/7#discussion_r56271036"},"pull_request":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7","id":63001151,"html_url":"https://github.com/CargoSense/ex_csv/pull/7","diff_url":"https://github.com/CargoSense/ex_csv/pull/7.diff","patch_url":"https://github.com/CargoSense/ex_csv/pull/7.patch","issue_url":"https://api.github.com/repos/CargoSense/ex_csv/issues/7","number":7,"state":"open","locked":false,"title":"Support different newlines","user":{"login":"doomspork","id":73386,"avatar_url":"https://avatars.githubusercontent.com/u/73386?v=3","gravatar_id":"","url":"https://api.github.com/users/doomspork","html_url":"https://github.com/doomspork","followers_url":"https://api.github.com/users/doomspork/followers","following_url":"https://api.github.com/users/doomspork/following{/other_user}","gists_url":"https://api.github.com/users/doomspork/gists{/gist_id}","starred_url":"https://api.github.com/users/doomspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomspork/subscriptions","organizations_url":"https://api.github.com/users/doomspork/orgs","repos_url":"https://api.github.com/users/doomspork/repos","events_url":"https://api.github.com/users/doomspork/events{/privacy}","received_events_url":"https://api.github.com/users/doomspork/received_events","type":"User","site_admin":false},"body":"Howdy @cargosensedev, thanks for ex_csv!\r\n\r\nFollowing some discussion in Slack today and after seeing #6, I thought I'd take a stab at supporting different newlines (`\\r`, `\\n`, and `\\r\\n`).  Is this a feature you'd be willing to support?  If so, I'd be glad to incorporate the necessary feedback into this PR.\r\n\r\nQuestions/comments/concerns welcome :grinning: ","created_at":"2016-03-16T01:08:19Z","updated_at":"2016-03-16T01:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9948634793c688466ebeab5908dac3aa41c86cf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7/commits","review_comments_url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7/comments","review_comment_url":"https://api.github.com/repos/CargoSense/ex_csv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CargoSense/ex_csv/issues/7/comments","statuses_url":"https://api.github.com/repos/CargoSense/ex_csv/statuses/1319f9bd7696149e980e7df34f6dfeec938c59db","head":{"label":"doomspork:newlines","ref":"newlines","sha":"1319f9bd7696149e980e7df34f6dfeec938c59db","user":{"login":"doomspork","id":73386,"avatar_url":"https://avatars.githubusercontent.com/u/73386?v=3","gravatar_id":"","url":"https://api.github.com/users/doomspork","html_url":"https://github.com/doomspork","followers_url":"https://api.github.com/users/doomspork/followers","following_url":"https://api.github.com/users/doomspork/following{/other_user}","gists_url":"https://api.github.com/users/doomspork/gists{/gist_id}","starred_url":"https://api.github.com/users/doomspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomspork/subscriptions","organizations_url":"https://api.github.com/users/doomspork/orgs","repos_url":"https://api.github.com/users/doomspork/repos","events_url":"https://api.github.com/users/doomspork/events{/privacy}","received_events_url":"https://api.github.com/users/doomspork/received_events","type":"User","site_admin":false},"repo":{"id":53989577,"name":"ex_csv","full_name":"doomspork/ex_csv","owner":{"login":"doomspork","id":73386,"avatar_url":"https://avatars.githubusercontent.com/u/73386?v=3","gravatar_id":"","url":"https://api.github.com/users/doomspork","html_url":"https://github.com/doomspork","followers_url":"https://api.github.com/users/doomspork/followers","following_url":"https://api.github.com/users/doomspork/following{/other_user}","gists_url":"https://api.github.com/users/doomspork/gists{/gist_id}","starred_url":"https://api.github.com/users/doomspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomspork/subscriptions","organizations_url":"https://api.github.com/users/doomspork/orgs","repos_url":"https://api.github.com/users/doomspork/repos","events_url":"https://api.github.com/users/doomspork/events{/privacy}","received_events_url":"https://api.github.com/users/doomspork/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doomspork/ex_csv","description":"CSV for Elixir","fork":true,"url":"https://api.github.com/repos/doomspork/ex_csv","forks_url":"https://api.github.com/repos/doomspork/ex_csv/forks","keys_url":"https://api.github.com/repos/doomspork/ex_csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doomspork/ex_csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doomspork/ex_csv/teams","hooks_url":"https://api.github.com/repos/doomspork/ex_csv/hooks","issue_events_url":"https://api.github.com/repos/doomspork/ex_csv/issues/events{/number}","events_url":"https://api.github.com/repos/doomspork/ex_csv/events","assignees_url":"https://api.github.com/repos/doomspork/ex_csv/assignees{/user}","branches_url":"https://api.github.com/repos/doomspork/ex_csv/branches{/branch}","tags_url":"https://api.github.com/repos/doomspork/ex_csv/tags","blobs_url":"https://api.github.com/repos/doomspork/ex_csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doomspork/ex_csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doomspork/ex_csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/doomspork/ex_csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doomspork/ex_csv/statuses/{sha}","languages_url":"https://api.github.com/repos/doomspork/ex_csv/languages","stargazers_url":"https://api.github.com/repos/doomspork/ex_csv/stargazers","contributors_url":"https://api.github.com/repos/doomspork/ex_csv/contributors","subscribers_url":"https://api.github.com/repos/doomspork/ex_csv/subscribers","subscription_url":"https://api.github.com/repos/doomspork/ex_csv/subscription","commits_url":"https://api.github.com/repos/doomspork/ex_csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/doomspork/ex_csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/doomspork/ex_csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/doomspork/ex_csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/doomspork/ex_csv/contents/{+path}","compare_url":"https://api.github.com/repos/doomspork/ex_csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doomspork/ex_csv/merges","archive_url":"https://api.github.com/repos/doomspork/ex_csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doomspork/ex_csv/downloads","issues_url":"https://api.github.com/repos/doomspork/ex_csv/issues{/number}","pulls_url":"https://api.github.com/repos/doomspork/ex_csv/pulls{/number}","milestones_url":"https://api.github.com/repos/doomspork/ex_csv/milestones{/number}","notifications_url":"https://api.github.com/repos/doomspork/ex_csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doomspork/ex_csv/labels{/name}","releases_url":"https://api.github.com/repos/doomspork/ex_csv/releases{/id}","deployments_url":"https://api.github.com/repos/doomspork/ex_csv/deployments","created_at":"2016-03-16T00:58:27Z","updated_at":"2016-03-16T00:58:28Z","pushed_at":"2016-03-16T01:04:54Z","git_url":"git://github.com/doomspork/ex_csv.git","ssh_url":"git@github.com:doomspork/ex_csv.git","clone_url":"https://github.com/doomspork/ex_csv.git","svn_url":"https://github.com/doomspork/ex_csv","homepage":"","size":26,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CargoSense:master","ref":"master","sha":"9c23c4c9872efb50b5d93bcde7bd977b32c04d84","user":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"repo":{"id":24176578,"name":"ex_csv","full_name":"CargoSense/ex_csv","owner":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CargoSense/ex_csv","description":"CSV for Elixir","fork":false,"url":"https://api.github.com/repos/CargoSense/ex_csv","forks_url":"https://api.github.com/repos/CargoSense/ex_csv/forks","keys_url":"https://api.github.com/repos/CargoSense/ex_csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CargoSense/ex_csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CargoSense/ex_csv/teams","hooks_url":"https://api.github.com/repos/CargoSense/ex_csv/hooks","issue_events_url":"https://api.github.com/repos/CargoSense/ex_csv/issues/events{/number}","events_url":"https://api.github.com/repos/CargoSense/ex_csv/events","assignees_url":"https://api.github.com/repos/CargoSense/ex_csv/assignees{/user}","branches_url":"https://api.github.com/repos/CargoSense/ex_csv/branches{/branch}","tags_url":"https://api.github.com/repos/CargoSense/ex_csv/tags","blobs_url":"https://api.github.com/repos/CargoSense/ex_csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CargoSense/ex_csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CargoSense/ex_csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/CargoSense/ex_csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CargoSense/ex_csv/statuses/{sha}","languages_url":"https://api.github.com/repos/CargoSense/ex_csv/languages","stargazers_url":"https://api.github.com/repos/CargoSense/ex_csv/stargazers","contributors_url":"https://api.github.com/repos/CargoSense/ex_csv/contributors","subscribers_url":"https://api.github.com/repos/CargoSense/ex_csv/subscribers","subscription_url":"https://api.github.com/repos/CargoSense/ex_csv/subscription","commits_url":"https://api.github.com/repos/CargoSense/ex_csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/CargoSense/ex_csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/CargoSense/ex_csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/CargoSense/ex_csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/CargoSense/ex_csv/contents/{+path}","compare_url":"https://api.github.com/repos/CargoSense/ex_csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CargoSense/ex_csv/merges","archive_url":"https://api.github.com/repos/CargoSense/ex_csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CargoSense/ex_csv/downloads","issues_url":"https://api.github.com/repos/CargoSense/ex_csv/issues{/number}","pulls_url":"https://api.github.com/repos/CargoSense/ex_csv/pulls{/number}","milestones_url":"https://api.github.com/repos/CargoSense/ex_csv/milestones{/number}","notifications_url":"https://api.github.com/repos/CargoSense/ex_csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CargoSense/ex_csv/labels{/name}","releases_url":"https://api.github.com/repos/CargoSense/ex_csv/releases{/id}","deployments_url":"https://api.github.com/repos/CargoSense/ex_csv/deployments","created_at":"2014-09-18T06:24:31Z","updated_at":"2016-03-04T15:01:39Z","pushed_at":"2016-03-16T01:08:19Z","git_url":"git://github.com/CargoSense/ex_csv.git","ssh_url":"git@github.com:CargoSense/ex_csv.git","clone_url":"https://github.com/CargoSense/ex_csv.git","svn_url":"https://github.com/CargoSense/ex_csv","homepage":"","size":26,"stargazers_count":18,"watchers_count":18,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7"},"html":{"href":"https://github.com/CargoSense/ex_csv/pull/7"},"issue":{"href":"https://api.github.com/repos/CargoSense/ex_csv/issues/7"},"comments":{"href":"https://api.github.com/repos/CargoSense/ex_csv/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CargoSense/ex_csv/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/CargoSense/ex_csv/statuses/1319f9bd7696149e980e7df34f6dfeec938c59db"}}}}