{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72713878","id":72713878,"diff_hunk":"@@ -920,7 +920,7 @@ public static class TupleExtensions\n         }\n         #endregion\n \n-        private static ValueTuple<T1, T2, T3, T4, T5, T6, T7, TRest> CreateLong<T1, T2, T3, T4, T5, T6, T7, TRest>(T1 item1, T2 item2, T3 item3, T4 item4, T5 item5, T6 item6, T7 item7, TRest rest) where TRest : struct =>\n+        private static ValueTuple<T1, T2, T3, T4, T5, T6, T7, TRest> CreateLong<T1, T2, T3, T4, T5, T6, T7, TRest>(T1 item1, T2 item2, T3 item3, T4 item4, T5 item5, T6 item6, T7 item7, TRest rest) where TRest : struct, ITuple =>\n             new ValueTuple<T1, T2, T3, T4, T5, T6, T7, TRest>(item1, item2, item3, item4, item5, item6, item7, rest);","path":"src/System.ValueTuple/src/System/ValueTuple/TupleExtensions.cs","position":6,"original_position":6,"commit_id":"c02d8372e2b68dd7359db76401ebe3de2d8dcbc0","original_commit_id":"c02d8372e2b68dd7359db76401ebe3de2d8dcbc0","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"I don't have a strong opinion on the struct constraint, but note that removing it will likely force us to add a bit more code, e.g. to protect against Rest being null here:\r\nhttps://github.com/dotnet/corefx/blob/master/src/System.ValueTuple/src/System/ValueTuple/ValueTuple.cs#L2042\r\nSince we really want this to be constrained to be a value tuple, all of which are structs, and we don't expect nor want anything else in this position, why remove the constraint?  What harm does it cause to have it (i.e. what scenario are you envisioning)?","created_at":"2016-07-28T22:21:05Z","updated_at":"2016-07-28T22:21:05Z","html_url":"https://github.com/dotnet/corefx/pull/10068#discussion_r72713878","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/10068","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72713878"},"html":{"href":"https://github.com/dotnet/corefx/pull/10068#discussion_r72713878"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10068"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/10068","id":77529297,"html_url":"https://github.com/dotnet/corefx/pull/10068","diff_url":"https://github.com/dotnet/corefx/pull/10068.diff","patch_url":"https://github.com/dotnet/corefx/pull/10068.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/10068","number":10068,"state":"open","locked":false,"title":"Adding ITuple interface and implementation in ValueTuple","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"body":"Re-opening the discussion following C# language design meeting yesterday.\r\n\r\nThe purpose of this interface is to allow objects to be used in positional pattern matching.\r\n`ValueTuple` is the first type to implement it.\r\n\r\nFrom discussion with LDM yesterday, it seems that existing collection interfaces (IReadOnlyCollection and IReadOnlyList) don't fit the purpose. We feel there should be no iterator involved. Also we need an interface as a marker to identify types that are suitable for such usage.\r\nWe are still having some debate on the proper name for this interface (ITuple, IDeconstructable, IIndexable, ...).\r\nI renamed `Size` to be `Length` to avoid introducing a new term.","created_at":"2016-07-14T21:29:45Z","updated_at":"2016-07-28T22:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b912e02cfb8a7f63ba33a730b207dd60e8350a","assignee":{"login":"terrajobst","id":5169960,"avatar_url":"https://avatars.githubusercontent.com/u/5169960?v=3","gravatar_id":"","url":"https://api.github.com/users/terrajobst","html_url":"https://github.com/terrajobst","followers_url":"https://api.github.com/users/terrajobst/followers","following_url":"https://api.github.com/users/terrajobst/following{/other_user}","gists_url":"https://api.github.com/users/terrajobst/gists{/gist_id}","starred_url":"https://api.github.com/users/terrajobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrajobst/subscriptions","organizations_url":"https://api.github.com/users/terrajobst/orgs","repos_url":"https://api.github.com/users/terrajobst/repos","events_url":"https://api.github.com/users/terrajobst/events{/privacy}","received_events_url":"https://api.github.com/users/terrajobst/received_events","type":"User","site_admin":false},"assignees":[{"login":"terrajobst","id":5169960,"avatar_url":"https://avatars.githubusercontent.com/u/5169960?v=3","gravatar_id":"","url":"https://api.github.com/users/terrajobst","html_url":"https://github.com/terrajobst","followers_url":"https://api.github.com/users/terrajobst/followers","following_url":"https://api.github.com/users/terrajobst/following{/other_user}","gists_url":"https://api.github.com/users/terrajobst/gists{/gist_id}","starred_url":"https://api.github.com/users/terrajobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrajobst/subscriptions","organizations_url":"https://api.github.com/users/terrajobst/orgs","repos_url":"https://api.github.com/users/terrajobst/repos","events_url":"https://api.github.com/users/terrajobst/events{/privacy}","received_events_url":"https://api.github.com/users/terrajobst/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/10068/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/10068/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/10068/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/c02d8372e2b68dd7359db76401ebe3de2d8dcbc0","head":{"label":"jcouv:adding-ituple","ref":"adding-ituple","sha":"c02d8372e2b68dd7359db76401ebe3de2d8dcbc0","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"repo":{"id":55807182,"name":"corefx","full_name":"jcouv/corefx","owner":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcouv/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/jcouv/corefx","forks_url":"https://api.github.com/repos/jcouv/corefx/forks","keys_url":"https://api.github.com/repos/jcouv/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcouv/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcouv/corefx/teams","hooks_url":"https://api.github.com/repos/jcouv/corefx/hooks","issue_events_url":"https://api.github.com/repos/jcouv/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/jcouv/corefx/events","assignees_url":"https://api.github.com/repos/jcouv/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/jcouv/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/jcouv/corefx/tags","blobs_url":"https://api.github.com/repos/jcouv/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcouv/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcouv/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcouv/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcouv/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/jcouv/corefx/languages","stargazers_url":"https://api.github.com/repos/jcouv/corefx/stargazers","contributors_url":"https://api.github.com/repos/jcouv/corefx/contributors","subscribers_url":"https://api.github.com/repos/jcouv/corefx/subscribers","subscription_url":"https://api.github.com/repos/jcouv/corefx/subscription","commits_url":"https://api.github.com/repos/jcouv/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcouv/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcouv/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcouv/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcouv/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/jcouv/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcouv/corefx/merges","archive_url":"https://api.github.com/repos/jcouv/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcouv/corefx/downloads","issues_url":"https://api.github.com/repos/jcouv/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/jcouv/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/jcouv/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/jcouv/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcouv/corefx/labels{/name}","releases_url":"https://api.github.com/repos/jcouv/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/jcouv/corefx/deployments","created_at":"2016-04-08T20:16:49Z","updated_at":"2016-04-08T20:17:12Z","pushed_at":"2016-07-15T20:21:23Z","git_url":"git://github.com/jcouv/corefx.git","ssh_url":"git@github.com:jcouv/corefx.git","clone_url":"https://github.com/jcouv/corefx.git","svn_url":"https://github.com/jcouv/corefx","homepage":"http://dotnet.github.io/","size":78940,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b0045645433b457df9ce2503fdfeb19066d84dfd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-07-28T15:32:09Z","pushed_at":"2016-07-28T22:20:49Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":122926,"stargazers_count":10297,"watchers_count":10297,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2513,"mirror_url":null,"open_issues_count":1185,"forks":2513,"open_issues":1185,"watchers":10297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10068"},"html":{"href":"https://github.com/dotnet/corefx/pull/10068"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10068"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10068/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10068/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10068/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/c02d8372e2b68dd7359db76401ebe3de2d8dcbc0"}}}}
{"actor":{"display_login":"stephentoub"}}