{"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/62877789","id":62877789,"diff_hunk":"@@ -0,0 +1,72 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.jclouds.azurecompute.arm.domain;\n+\n+import com.google.auto.value.AutoValue;\n+import com.google.common.collect.ImmutableList;\n+import org.jclouds.javax.annotation.Nullable;\n+import org.jclouds.json.SerializedNames;\n+\n+import java.util.List;\n+\n+@AutoValue\n+public abstract class NetworkInterfaceCardProperties {\n+\n+   @Nullable\n+   public abstract String provisioningState();\n+\n+   @Nullable\n+   public abstract String resourceGuid();\n+\n+   @Nullable\n+   public abstract Boolean enableIPForwarding();\n+\n+   @Nullable\n+   public abstract ImmutableList<IpConfiguration> ipConfigurations();\n+\n+   @SerializedNames({\"provisioningState\", \"resourceGuid\", \"enableIPForwarding\", \"ipConfigurations\"})\n+   public static NetworkInterfaceCardProperties create(final String provisioningState, final String resourceGuid, final Boolean enableIPForwarding, final List<IpConfiguration> ipConfigurations) {\n+      NetworkInterfaceCardProperties.Builder builder = NetworkInterfaceCardProperties.builder()\n+              .provisioningState(provisioningState)\n+              .resourceGuid(resourceGuid)\n+              .enableIPForwarding(enableIPForwarding);\n+\n+      if (ipConfigurations != null)\n+         builder.ipConfigurations(ipConfigurations);\n+\n+      return builder.build();\n+   }\n+\n+   public static Builder builder() {\n+      return new AutoValue_NetworkInterfaceCardProperties.Builder();\n+   }\n+\n+   @AutoValue.Builder\n+   public abstract static class Builder {\n+      public abstract Builder provisioningState(String provisioningState);\n+\n+      public abstract Builder resourceGuid(String resourceGuid);\n+\n+      public abstract Builder enableIPForwarding(Boolean enableIPForwarding);\n+\n+      public abstract Builder ipConfigurations(List<IpConfiguration> ipConfigurations);","path":"azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/NetworkInterfaceCardProperties.java","position":64,"original_position":66,"commit_id":"e4129688520e3e28b8068e0514a11f41e1cfa568","original_commit_id":"c0cc2c907c9f82844ca9a18b2b61aa31e84aca86","user":{"login":"nacx","id":446705,"avatar_url":"https://avatars.githubusercontent.com/u/446705?v=3","gravatar_id":"","url":"https://api.github.com/users/nacx","html_url":"https://github.com/nacx","followers_url":"https://api.github.com/users/nacx/followers","following_url":"https://api.github.com/users/nacx/following{/other_user}","gists_url":"https://api.github.com/users/nacx/gists{/gist_id}","starred_url":"https://api.github.com/users/nacx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacx/subscriptions","organizations_url":"https://api.github.com/users/nacx/orgs","repos_url":"https://api.github.com/users/nacx/repos","events_url":"https://api.github.com/users/nacx/events{/privacy}","received_events_url":"https://api.github.com/users/nacx/received_events","type":"User","site_admin":false},"body":"This pattern still needs to be applied? That is, providing those hidden methods so we can change the build method to enforce an immutable list. Otherwise the we can't guarantee collection immutability. (Apply this to other builders that accept collection parameters).","created_at":"2016-05-11T16:11:47Z","updated_at":"2016-05-11T16:11:47Z","html_url":"https://github.com/jclouds/jclouds-labs/pull/265#discussion_r62877789","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/62877789"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/265#discussion_r62877789"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265","id":68142717,"html_url":"https://github.com/jclouds/jclouds-labs/pull/265","diff_url":"https://github.com/jclouds/jclouds-labs/pull/265.diff","patch_url":"https://github.com/jclouds/jclouds-labs/pull/265.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/265","number":265,"state":"open","locked":false,"title":"JCLOUDS-664 Azurecompute-arm NicApi PublicIPApi and VMApi","user":{"login":"ritazh","id":1856066,"avatar_url":"https://avatars.githubusercontent.com/u/1856066?v=3","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"body":"@nacx @andreaturli \r\nThis PR is for `NetworkInterfaceCardApi`, `PublicIPAddressApi`, and `VirtualMachineApi`, part of the foundations needed for interacting with Azure Resource Manager (ARM) Rest APIs.\r\n\r\nFYI\r\n@jtjk @isalento @jmspring","created_at":"2016-04-27T23:39:06Z","updated_at":"2016-05-11T16:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ecbbb772df971e9aaebd65f65210a27c29e1ac6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/265/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/e4129688520e3e28b8068e0514a11f41e1cfa568","head":{"label":"ritazh:azurecomputearm-nicapi-publicipapi-vmapi","ref":"azurecomputearm-nicapi-publicipapi-vmapi","sha":"e4129688520e3e28b8068e0514a11f41e1cfa568","user":{"login":"ritazh","id":1856066,"avatar_url":"https://avatars.githubusercontent.com/u/1856066?v=3","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"repo":{"id":51454434,"name":"jclouds-labs","full_name":"ritazh/jclouds-labs","owner":{"login":"ritazh","id":1856066,"avatar_url":"https://avatars.githubusercontent.com/u/1856066?v=3","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ritazh/jclouds-labs","description":"Azurecompute-arm development for jclouds labs","fork":true,"url":"https://api.github.com/repos/ritazh/jclouds-labs","forks_url":"https://api.github.com/repos/ritazh/jclouds-labs/forks","keys_url":"https://api.github.com/repos/ritazh/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ritazh/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ritazh/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/ritazh/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/ritazh/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/ritazh/jclouds-labs/events","assignees_url":"https://api.github.com/repos/ritazh/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/ritazh/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/ritazh/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/ritazh/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ritazh/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ritazh/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ritazh/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ritazh/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/ritazh/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/ritazh/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/ritazh/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/ritazh/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/ritazh/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/ritazh/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ritazh/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ritazh/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ritazh/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ritazh/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/ritazh/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ritazh/jclouds-labs/merges","archive_url":"https://api.github.com/repos/ritazh/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ritazh/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/ritazh/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/ritazh/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/ritazh/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/ritazh/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ritazh/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/ritazh/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/ritazh/jclouds-labs/deployments","created_at":"2016-02-10T16:37:03Z","updated_at":"2016-04-08T18:52:40Z","pushed_at":"2016-05-11T14:22:42Z","git_url":"git://github.com/ritazh/jclouds-labs.git","ssh_url":"git@github.com:ritazh/jclouds-labs.git","clone_url":"https://github.com/ritazh/jclouds-labs.git","svn_url":"https://github.com/ritazh/jclouds-labs","homepage":"","size":21384,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"azurecompute-arm-dev"}},"base":{"label":"jclouds:master","ref":"master","sha":"1f2153799190d06b64295f65607e2b0bb3600903","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040970,"name":"jclouds-labs","full_name":"jclouds/jclouds-labs","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/jclouds/jclouds-labs/deployments","created_at":"2013-05-13T20:47:47Z","updated_at":"2016-04-27T18:12:35Z","pushed_at":"2016-05-10T00:47:23Z","git_url":"git://github.com/jclouds/jclouds-labs.git","ssh_url":"git@github.com:jclouds/jclouds-labs.git","clone_url":"https://github.com/jclouds/jclouds-labs.git","svn_url":"https://github.com/jclouds/jclouds-labs","homepage":null,"size":24779,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":5,"forks":82,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/265"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/265"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/e4129688520e3e28b8068e0514a11f41e1cfa568"}}}}