{"action":"created","comment":{"url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/comments/86654601","pull_request_review_id":7305365,"id":86654601,"diff_hunk":"@@ -47,7 +47,16 @@\n             final boolean isPlaced = BlockStateHelper.areBlockStatesEqual(blockState, mcBlockState);\n \n             ItemStack stack = null;\n-\n+            \n+            if (block.getIdFromBlock(block) == 43 || block.getIdFromBlock(block) == 125 || block.getIdFromBlock(block) == 181 || block.getIdFromBlock(block) == 204) {","path":"src/main/java/com/github/lunatrius/schematica/client/util/BlockList.java","position":6,"original_position":6,"commit_id":"7289568eb19245bf5cb7a6ce03fc2ec82bb2e7a4","original_commit_id":"7289568eb19245bf5cb7a6ce03fc2ec82bb2e7a4","user":{"login":"Lunatrius","id":864627,"avatar_url":"https://avatars.githubusercontent.com/u/864627?v=3","gravatar_id":"","url":"https://api.github.com/users/Lunatrius","html_url":"https://github.com/Lunatrius","followers_url":"https://api.github.com/users/Lunatrius/followers","following_url":"https://api.github.com/users/Lunatrius/following{/other_user}","gists_url":"https://api.github.com/users/Lunatrius/gists{/gist_id}","starred_url":"https://api.github.com/users/Lunatrius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lunatrius/subscriptions","organizations_url":"https://api.github.com/users/Lunatrius/orgs","repos_url":"https://api.github.com/users/Lunatrius/repos","events_url":"https://api.github.com/users/Lunatrius/events{/privacy}","received_events_url":"https://api.github.com/users/Lunatrius/received_events","type":"User","site_admin":false},"body":"This is definitely a no. I am against any special cases where possible, but using the block IDs directly is a definite no go.\r\n\r\nI didn't have time to check this today, I'll check the code tomorrow.","created_at":"2016-11-05T01:07:59Z","updated_at":"2016-11-05T01:07:59Z","html_url":"https://github.com/Lunatrius/Schematica/pull/179#discussion_r86654601","pull_request_url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/comments/86654601"},"html":{"href":"https://github.com/Lunatrius/Schematica/pull/179#discussion_r86654601"},"pull_request":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179","id":92216878,"html_url":"https://github.com/Lunatrius/Schematica/pull/179","diff_url":"https://github.com/Lunatrius/Schematica/pull/179.diff","patch_url":"https://github.com/Lunatrius/Schematica/pull/179.patch","issue_url":"https://api.github.com/repos/Lunatrius/Schematica/issues/179","number":179,"state":"open","locked":false,"title":"double slabs didnt count the original slab 2 times","user":{"login":"coehlrich","id":22903392,"avatar_url":"https://avatars.githubusercontent.com/u/22903392?v=3","gravatar_id":"","url":"https://api.github.com/users/coehlrich","html_url":"https://github.com/coehlrich","followers_url":"https://api.github.com/users/coehlrich/followers","following_url":"https://api.github.com/users/coehlrich/following{/other_user}","gists_url":"https://api.github.com/users/coehlrich/gists{/gist_id}","starred_url":"https://api.github.com/users/coehlrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coehlrich/subscriptions","organizations_url":"https://api.github.com/users/coehlrich/orgs","repos_url":"https://api.github.com/users/coehlrich/repos","events_url":"https://api.github.com/users/coehlrich/events{/privacy}","received_events_url":"https://api.github.com/users/coehlrich/received_events","type":"User","site_admin":false},"body":"this makes double slabs count the original half slab slab 2 times (also this is the first time i finished making something in java and not javascript so sorry if there are any errors)","created_at":"2016-11-03T18:48:01Z","updated_at":"2016-11-05T01:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10857f636bc547bbe37f609e71954bdab8ee7827","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179/commits","review_comments_url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179/comments","review_comment_url":"https://api.github.com/repos/Lunatrius/Schematica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lunatrius/Schematica/issues/179/comments","statuses_url":"https://api.github.com/repos/Lunatrius/Schematica/statuses/7289568eb19245bf5cb7a6ce03fc2ec82bb2e7a4","head":{"label":"coehlrich:master","ref":"master","sha":"7289568eb19245bf5cb7a6ce03fc2ec82bb2e7a4","user":{"login":"coehlrich","id":22903392,"avatar_url":"https://avatars.githubusercontent.com/u/22903392?v=3","gravatar_id":"","url":"https://api.github.com/users/coehlrich","html_url":"https://github.com/coehlrich","followers_url":"https://api.github.com/users/coehlrich/followers","following_url":"https://api.github.com/users/coehlrich/following{/other_user}","gists_url":"https://api.github.com/users/coehlrich/gists{/gist_id}","starred_url":"https://api.github.com/users/coehlrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coehlrich/subscriptions","organizations_url":"https://api.github.com/users/coehlrich/orgs","repos_url":"https://api.github.com/users/coehlrich/repos","events_url":"https://api.github.com/users/coehlrich/events{/privacy}","received_events_url":"https://api.github.com/users/coehlrich/received_events","type":"User","site_admin":false},"repo":{"id":72706038,"name":"Schematica","full_name":"coehlrich/Schematica","owner":{"login":"coehlrich","id":22903392,"avatar_url":"https://avatars.githubusercontent.com/u/22903392?v=3","gravatar_id":"","url":"https://api.github.com/users/coehlrich","html_url":"https://github.com/coehlrich","followers_url":"https://api.github.com/users/coehlrich/followers","following_url":"https://api.github.com/users/coehlrich/following{/other_user}","gists_url":"https://api.github.com/users/coehlrich/gists{/gist_id}","starred_url":"https://api.github.com/users/coehlrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coehlrich/subscriptions","organizations_url":"https://api.github.com/users/coehlrich/orgs","repos_url":"https://api.github.com/users/coehlrich/repos","events_url":"https://api.github.com/users/coehlrich/events{/privacy}","received_events_url":"https://api.github.com/users/coehlrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coehlrich/Schematica","description":"Import schematics, export schematics, build schematics. All inside Minecraft!","fork":true,"url":"https://api.github.com/repos/coehlrich/Schematica","forks_url":"https://api.github.com/repos/coehlrich/Schematica/forks","keys_url":"https://api.github.com/repos/coehlrich/Schematica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coehlrich/Schematica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coehlrich/Schematica/teams","hooks_url":"https://api.github.com/repos/coehlrich/Schematica/hooks","issue_events_url":"https://api.github.com/repos/coehlrich/Schematica/issues/events{/number}","events_url":"https://api.github.com/repos/coehlrich/Schematica/events","assignees_url":"https://api.github.com/repos/coehlrich/Schematica/assignees{/user}","branches_url":"https://api.github.com/repos/coehlrich/Schematica/branches{/branch}","tags_url":"https://api.github.com/repos/coehlrich/Schematica/tags","blobs_url":"https://api.github.com/repos/coehlrich/Schematica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coehlrich/Schematica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coehlrich/Schematica/git/refs{/sha}","trees_url":"https://api.github.com/repos/coehlrich/Schematica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coehlrich/Schematica/statuses/{sha}","languages_url":"https://api.github.com/repos/coehlrich/Schematica/languages","stargazers_url":"https://api.github.com/repos/coehlrich/Schematica/stargazers","contributors_url":"https://api.github.com/repos/coehlrich/Schematica/contributors","subscribers_url":"https://api.github.com/repos/coehlrich/Schematica/subscribers","subscription_url":"https://api.github.com/repos/coehlrich/Schematica/subscription","commits_url":"https://api.github.com/repos/coehlrich/Schematica/commits{/sha}","git_commits_url":"https://api.github.com/repos/coehlrich/Schematica/git/commits{/sha}","comments_url":"https://api.github.com/repos/coehlrich/Schematica/comments{/number}","issue_comment_url":"https://api.github.com/repos/coehlrich/Schematica/issues/comments{/number}","contents_url":"https://api.github.com/repos/coehlrich/Schematica/contents/{+path}","compare_url":"https://api.github.com/repos/coehlrich/Schematica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coehlrich/Schematica/merges","archive_url":"https://api.github.com/repos/coehlrich/Schematica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coehlrich/Schematica/downloads","issues_url":"https://api.github.com/repos/coehlrich/Schematica/issues{/number}","pulls_url":"https://api.github.com/repos/coehlrich/Schematica/pulls{/number}","milestones_url":"https://api.github.com/repos/coehlrich/Schematica/milestones{/number}","notifications_url":"https://api.github.com/repos/coehlrich/Schematica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coehlrich/Schematica/labels{/name}","releases_url":"https://api.github.com/repos/coehlrich/Schematica/releases{/id}","deployments_url":"https://api.github.com/repos/coehlrich/Schematica/deployments","created_at":"2016-11-03T03:38:33Z","updated_at":"2016-11-03T03:38:34Z","pushed_at":"2016-11-04T18:05:25Z","git_url":"git://github.com/coehlrich/Schematica.git","ssh_url":"git@github.com:coehlrich/Schematica.git","clone_url":"https://github.com/coehlrich/Schematica.git","svn_url":"https://github.com/coehlrich/Schematica","homepage":"","size":1612,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Lunatrius:master","ref":"master","sha":"e15022c7949c8f926569a37feaa26482e6c408d1","user":{"login":"Lunatrius","id":864627,"avatar_url":"https://avatars.githubusercontent.com/u/864627?v=3","gravatar_id":"","url":"https://api.github.com/users/Lunatrius","html_url":"https://github.com/Lunatrius","followers_url":"https://api.github.com/users/Lunatrius/followers","following_url":"https://api.github.com/users/Lunatrius/following{/other_user}","gists_url":"https://api.github.com/users/Lunatrius/gists{/gist_id}","starred_url":"https://api.github.com/users/Lunatrius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lunatrius/subscriptions","organizations_url":"https://api.github.com/users/Lunatrius/orgs","repos_url":"https://api.github.com/users/Lunatrius/repos","events_url":"https://api.github.com/users/Lunatrius/events{/privacy}","received_events_url":"https://api.github.com/users/Lunatrius/received_events","type":"User","site_admin":false},"repo":{"id":6422358,"name":"Schematica","full_name":"Lunatrius/Schematica","owner":{"login":"Lunatrius","id":864627,"avatar_url":"https://avatars.githubusercontent.com/u/864627?v=3","gravatar_id":"","url":"https://api.github.com/users/Lunatrius","html_url":"https://github.com/Lunatrius","followers_url":"https://api.github.com/users/Lunatrius/followers","following_url":"https://api.github.com/users/Lunatrius/following{/other_user}","gists_url":"https://api.github.com/users/Lunatrius/gists{/gist_id}","starred_url":"https://api.github.com/users/Lunatrius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lunatrius/subscriptions","organizations_url":"https://api.github.com/users/Lunatrius/orgs","repos_url":"https://api.github.com/users/Lunatrius/repos","events_url":"https://api.github.com/users/Lunatrius/events{/privacy}","received_events_url":"https://api.github.com/users/Lunatrius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lunatrius/Schematica","description":"Import schematics, export schematics, build schematics. All inside Minecraft!","fork":false,"url":"https://api.github.com/repos/Lunatrius/Schematica","forks_url":"https://api.github.com/repos/Lunatrius/Schematica/forks","keys_url":"https://api.github.com/repos/Lunatrius/Schematica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lunatrius/Schematica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lunatrius/Schematica/teams","hooks_url":"https://api.github.com/repos/Lunatrius/Schematica/hooks","issue_events_url":"https://api.github.com/repos/Lunatrius/Schematica/issues/events{/number}","events_url":"https://api.github.com/repos/Lunatrius/Schematica/events","assignees_url":"https://api.github.com/repos/Lunatrius/Schematica/assignees{/user}","branches_url":"https://api.github.com/repos/Lunatrius/Schematica/branches{/branch}","tags_url":"https://api.github.com/repos/Lunatrius/Schematica/tags","blobs_url":"https://api.github.com/repos/Lunatrius/Schematica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lunatrius/Schematica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lunatrius/Schematica/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lunatrius/Schematica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lunatrius/Schematica/statuses/{sha}","languages_url":"https://api.github.com/repos/Lunatrius/Schematica/languages","stargazers_url":"https://api.github.com/repos/Lunatrius/Schematica/stargazers","contributors_url":"https://api.github.com/repos/Lunatrius/Schematica/contributors","subscribers_url":"https://api.github.com/repos/Lunatrius/Schematica/subscribers","subscription_url":"https://api.github.com/repos/Lunatrius/Schematica/subscription","commits_url":"https://api.github.com/repos/Lunatrius/Schematica/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lunatrius/Schematica/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lunatrius/Schematica/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lunatrius/Schematica/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lunatrius/Schematica/contents/{+path}","compare_url":"https://api.github.com/repos/Lunatrius/Schematica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lunatrius/Schematica/merges","archive_url":"https://api.github.com/repos/Lunatrius/Schematica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lunatrius/Schematica/downloads","issues_url":"https://api.github.com/repos/Lunatrius/Schematica/issues{/number}","pulls_url":"https://api.github.com/repos/Lunatrius/Schematica/pulls{/number}","milestones_url":"https://api.github.com/repos/Lunatrius/Schematica/milestones{/number}","notifications_url":"https://api.github.com/repos/Lunatrius/Schematica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lunatrius/Schematica/labels{/name}","releases_url":"https://api.github.com/repos/Lunatrius/Schematica/releases{/id}","deployments_url":"https://api.github.com/repos/Lunatrius/Schematica/deployments","created_at":"2012-10-27T22:55:49Z","updated_at":"2016-10-25T14:52:01Z","pushed_at":"2016-11-04T18:05:25Z","git_url":"git://github.com/Lunatrius/Schematica.git","ssh_url":"git@github.com:Lunatrius/Schematica.git","clone_url":"https://github.com/Lunatrius/Schematica.git","svn_url":"https://github.com/Lunatrius/Schematica","homepage":"","size":1847,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":16,"forks":46,"open_issues":16,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179"},"html":{"href":"https://github.com/Lunatrius/Schematica/pull/179"},"issue":{"href":"https://api.github.com/repos/Lunatrius/Schematica/issues/179"},"comments":{"href":"https://api.github.com/repos/Lunatrius/Schematica/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lunatrius/Schematica/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/Lunatrius/Schematica/statuses/7289568eb19245bf5cb7a6ce03fc2ec82bb2e7a4"}}}}
{"actor":{"display_login":"Lunatrius"}}