{"action":"closed","number":168,"pull_request":{"url":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168","id":65293951,"html_url":"https://github.com/js-cookie/js-cookie/pull/168","diff_url":"https://github.com/js-cookie/js-cookie/pull/168.diff","patch_url":"https://github.com/js-cookie/js-cookie/pull/168.patch","issue_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/168","number":168,"state":"closed","locked":false,"title":"Do not create cookie if using .set() incorrectly","user":{"login":"FagnerMartinsBrack","id":835857,"avatar_url":"https://avatars.githubusercontent.com/u/835857?v=3","gravatar_id":"","url":"https://api.github.com/users/FagnerMartinsBrack","html_url":"https://github.com/FagnerMartinsBrack","followers_url":"https://api.github.com/users/FagnerMartinsBrack/followers","following_url":"https://api.github.com/users/FagnerMartinsBrack/following{/other_user}","gists_url":"https://api.github.com/users/FagnerMartinsBrack/gists{/gist_id}","starred_url":"https://api.github.com/users/FagnerMartinsBrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FagnerMartinsBrack/subscriptions","organizations_url":"https://api.github.com/users/FagnerMartinsBrack/orgs","repos_url":"https://api.github.com/users/FagnerMartinsBrack/repos","events_url":"https://api.github.com/users/FagnerMartinsBrack/events{/privacy}","received_events_url":"https://api.github.com/users/FagnerMartinsBrack/received_events","type":"User","site_admin":false},"body":"If someone uses the undocumented `.set(String, Object Literal)` signature, there should be no side-effect of creating the cookie for a read operation.\r\n\r\n<img width=\"539\" alt=\"screenshot 2016-04-10 00 48 53\" src=\"https://cloud.githubusercontent.com/assets/835857/14404320/04cb4742-feb6-11e5-8602-a23529976f42.png\">\r\n","created_at":"2016-04-05T12:13:50Z","updated_at":"2016-04-09T14:51:17Z","closed_at":"2016-04-09T14:51:17Z","merged_at":null,"merge_commit_sha":"46d29db1d4e30761a3b39fb8d022d7e726d685db","assignee":null,"milestone":{"url":"https://api.github.com/repos/js-cookie/js-cookie/milestones/5","html_url":"https://github.com/js-cookie/js-cookie/milestones/v2.1.1","labels_url":"https://api.github.com/repos/js-cookie/js-cookie/milestones/5/labels","id":1479049,"number":5,"title":"v2.1.1","description":"","creator":{"login":"FagnerMartinsBrack","id":835857,"avatar_url":"https://avatars.githubusercontent.com/u/835857?v=3","gravatar_id":"","url":"https://api.github.com/users/FagnerMartinsBrack","html_url":"https://github.com/FagnerMartinsBrack","followers_url":"https://api.github.com/users/FagnerMartinsBrack/followers","following_url":"https://api.github.com/users/FagnerMartinsBrack/following{/other_user}","gists_url":"https://api.github.com/users/FagnerMartinsBrack/gists{/gist_id}","starred_url":"https://api.github.com/users/FagnerMartinsBrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FagnerMartinsBrack/subscriptions","organizations_url":"https://api.github.com/users/FagnerMartinsBrack/orgs","repos_url":"https://api.github.com/users/FagnerMartinsBrack/repos","events_url":"https://api.github.com/users/FagnerMartinsBrack/events{/privacy}","received_events_url":"https://api.github.com/users/FagnerMartinsBrack/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":34,"state":"open","created_at":"2015-12-31T11:18:47Z","updated_at":"2016-04-09T14:51:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168/commits","review_comments_url":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168/comments","review_comment_url":"https://api.github.com/repos/js-cookie/js-cookie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/168/comments","statuses_url":"https://api.github.com/repos/js-cookie/js-cookie/statuses/1beef567b47171604e7e4ea72fe5c7f2e6721524","head":{"label":"js-cookie:get-not-set","ref":"get-not-set","sha":"1beef567b47171604e7e4ea72fe5c7f2e6721524","user":{"login":"js-cookie","id":11557446,"avatar_url":"https://avatars.githubusercontent.com/u/11557446?v=3","gravatar_id":"","url":"https://api.github.com/users/js-cookie","html_url":"https://github.com/js-cookie","followers_url":"https://api.github.com/users/js-cookie/followers","following_url":"https://api.github.com/users/js-cookie/following{/other_user}","gists_url":"https://api.github.com/users/js-cookie/gists{/gist_id}","starred_url":"https://api.github.com/users/js-cookie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-cookie/subscriptions","organizations_url":"https://api.github.com/users/js-cookie/orgs","repos_url":"https://api.github.com/users/js-cookie/repos","events_url":"https://api.github.com/users/js-cookie/events{/privacy}","received_events_url":"https://api.github.com/users/js-cookie/received_events","type":"Organization","site_admin":false},"repo":{"id":32531480,"name":"js-cookie","full_name":"js-cookie/js-cookie","owner":{"login":"js-cookie","id":11557446,"avatar_url":"https://avatars.githubusercontent.com/u/11557446?v=3","gravatar_id":"","url":"https://api.github.com/users/js-cookie","html_url":"https://github.com/js-cookie","followers_url":"https://api.github.com/users/js-cookie/followers","following_url":"https://api.github.com/users/js-cookie/following{/other_user}","gists_url":"https://api.github.com/users/js-cookie/gists{/gist_id}","starred_url":"https://api.github.com/users/js-cookie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-cookie/subscriptions","organizations_url":"https://api.github.com/users/js-cookie/orgs","repos_url":"https://api.github.com/users/js-cookie/repos","events_url":"https://api.github.com/users/js-cookie/events{/privacy}","received_events_url":"https://api.github.com/users/js-cookie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/js-cookie/js-cookie","description":"A simple, lightweight JavaScript API for handling browser cookies","fork":false,"url":"https://api.github.com/repos/js-cookie/js-cookie","forks_url":"https://api.github.com/repos/js-cookie/js-cookie/forks","keys_url":"https://api.github.com/repos/js-cookie/js-cookie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/js-cookie/js-cookie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/js-cookie/js-cookie/teams","hooks_url":"https://api.github.com/repos/js-cookie/js-cookie/hooks","issue_events_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/events{/number}","events_url":"https://api.github.com/repos/js-cookie/js-cookie/events","assignees_url":"https://api.github.com/repos/js-cookie/js-cookie/assignees{/user}","branches_url":"https://api.github.com/repos/js-cookie/js-cookie/branches{/branch}","tags_url":"https://api.github.com/repos/js-cookie/js-cookie/tags","blobs_url":"https://api.github.com/repos/js-cookie/js-cookie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/js-cookie/js-cookie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/js-cookie/js-cookie/git/refs{/sha}","trees_url":"https://api.github.com/repos/js-cookie/js-cookie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/js-cookie/js-cookie/statuses/{sha}","languages_url":"https://api.github.com/repos/js-cookie/js-cookie/languages","stargazers_url":"https://api.github.com/repos/js-cookie/js-cookie/stargazers","contributors_url":"https://api.github.com/repos/js-cookie/js-cookie/contributors","subscribers_url":"https://api.github.com/repos/js-cookie/js-cookie/subscribers","subscription_url":"https://api.github.com/repos/js-cookie/js-cookie/subscription","commits_url":"https://api.github.com/repos/js-cookie/js-cookie/commits{/sha}","git_commits_url":"https://api.github.com/repos/js-cookie/js-cookie/git/commits{/sha}","comments_url":"https://api.github.com/repos/js-cookie/js-cookie/comments{/number}","issue_comment_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/comments{/number}","contents_url":"https://api.github.com/repos/js-cookie/js-cookie/contents/{+path}","compare_url":"https://api.github.com/repos/js-cookie/js-cookie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/js-cookie/js-cookie/merges","archive_url":"https://api.github.com/repos/js-cookie/js-cookie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/js-cookie/js-cookie/downloads","issues_url":"https://api.github.com/repos/js-cookie/js-cookie/issues{/number}","pulls_url":"https://api.github.com/repos/js-cookie/js-cookie/pulls{/number}","milestones_url":"https://api.github.com/repos/js-cookie/js-cookie/milestones{/number}","notifications_url":"https://api.github.com/repos/js-cookie/js-cookie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/js-cookie/js-cookie/labels{/name}","releases_url":"https://api.github.com/repos/js-cookie/js-cookie/releases{/id}","deployments_url":"https://api.github.com/repos/js-cookie/js-cookie/deployments","created_at":"2015-03-19T15:57:47Z","updated_at":"2016-04-09T14:05:06Z","pushed_at":"2016-04-09T14:51:17Z","git_url":"git://github.com/js-cookie/js-cookie.git","ssh_url":"git@github.com:js-cookie/js-cookie.git","clone_url":"https://github.com/js-cookie/js-cookie.git","svn_url":"https://github.com/js-cookie/js-cookie","homepage":"","size":698,"stargazers_count":2454,"watchers_count":2454,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"open_issues_count":8,"forks":370,"open_issues":8,"watchers":2454,"default_branch":"master"}},"base":{"label":"js-cookie:master","ref":"master","sha":"dc8f4376d30ba0165df6c6124173ceccf360a442","user":{"login":"js-cookie","id":11557446,"avatar_url":"https://avatars.githubusercontent.com/u/11557446?v=3","gravatar_id":"","url":"https://api.github.com/users/js-cookie","html_url":"https://github.com/js-cookie","followers_url":"https://api.github.com/users/js-cookie/followers","following_url":"https://api.github.com/users/js-cookie/following{/other_user}","gists_url":"https://api.github.com/users/js-cookie/gists{/gist_id}","starred_url":"https://api.github.com/users/js-cookie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-cookie/subscriptions","organizations_url":"https://api.github.com/users/js-cookie/orgs","repos_url":"https://api.github.com/users/js-cookie/repos","events_url":"https://api.github.com/users/js-cookie/events{/privacy}","received_events_url":"https://api.github.com/users/js-cookie/received_events","type":"Organization","site_admin":false},"repo":{"id":32531480,"name":"js-cookie","full_name":"js-cookie/js-cookie","owner":{"login":"js-cookie","id":11557446,"avatar_url":"https://avatars.githubusercontent.com/u/11557446?v=3","gravatar_id":"","url":"https://api.github.com/users/js-cookie","html_url":"https://github.com/js-cookie","followers_url":"https://api.github.com/users/js-cookie/followers","following_url":"https://api.github.com/users/js-cookie/following{/other_user}","gists_url":"https://api.github.com/users/js-cookie/gists{/gist_id}","starred_url":"https://api.github.com/users/js-cookie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-cookie/subscriptions","organizations_url":"https://api.github.com/users/js-cookie/orgs","repos_url":"https://api.github.com/users/js-cookie/repos","events_url":"https://api.github.com/users/js-cookie/events{/privacy}","received_events_url":"https://api.github.com/users/js-cookie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/js-cookie/js-cookie","description":"A simple, lightweight JavaScript API for handling browser cookies","fork":false,"url":"https://api.github.com/repos/js-cookie/js-cookie","forks_url":"https://api.github.com/repos/js-cookie/js-cookie/forks","keys_url":"https://api.github.com/repos/js-cookie/js-cookie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/js-cookie/js-cookie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/js-cookie/js-cookie/teams","hooks_url":"https://api.github.com/repos/js-cookie/js-cookie/hooks","issue_events_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/events{/number}","events_url":"https://api.github.com/repos/js-cookie/js-cookie/events","assignees_url":"https://api.github.com/repos/js-cookie/js-cookie/assignees{/user}","branches_url":"https://api.github.com/repos/js-cookie/js-cookie/branches{/branch}","tags_url":"https://api.github.com/repos/js-cookie/js-cookie/tags","blobs_url":"https://api.github.com/repos/js-cookie/js-cookie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/js-cookie/js-cookie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/js-cookie/js-cookie/git/refs{/sha}","trees_url":"https://api.github.com/repos/js-cookie/js-cookie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/js-cookie/js-cookie/statuses/{sha}","languages_url":"https://api.github.com/repos/js-cookie/js-cookie/languages","stargazers_url":"https://api.github.com/repos/js-cookie/js-cookie/stargazers","contributors_url":"https://api.github.com/repos/js-cookie/js-cookie/contributors","subscribers_url":"https://api.github.com/repos/js-cookie/js-cookie/subscribers","subscription_url":"https://api.github.com/repos/js-cookie/js-cookie/subscription","commits_url":"https://api.github.com/repos/js-cookie/js-cookie/commits{/sha}","git_commits_url":"https://api.github.com/repos/js-cookie/js-cookie/git/commits{/sha}","comments_url":"https://api.github.com/repos/js-cookie/js-cookie/comments{/number}","issue_comment_url":"https://api.github.com/repos/js-cookie/js-cookie/issues/comments{/number}","contents_url":"https://api.github.com/repos/js-cookie/js-cookie/contents/{+path}","compare_url":"https://api.github.com/repos/js-cookie/js-cookie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/js-cookie/js-cookie/merges","archive_url":"https://api.github.com/repos/js-cookie/js-cookie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/js-cookie/js-cookie/downloads","issues_url":"https://api.github.com/repos/js-cookie/js-cookie/issues{/number}","pulls_url":"https://api.github.com/repos/js-cookie/js-cookie/pulls{/number}","milestones_url":"https://api.github.com/repos/js-cookie/js-cookie/milestones{/number}","notifications_url":"https://api.github.com/repos/js-cookie/js-cookie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/js-cookie/js-cookie/labels{/name}","releases_url":"https://api.github.com/repos/js-cookie/js-cookie/releases{/id}","deployments_url":"https://api.github.com/repos/js-cookie/js-cookie/deployments","created_at":"2015-03-19T15:57:47Z","updated_at":"2016-04-09T14:05:06Z","pushed_at":"2016-04-09T14:51:17Z","git_url":"git://github.com/js-cookie/js-cookie.git","ssh_url":"git@github.com:js-cookie/js-cookie.git","clone_url":"https://github.com/js-cookie/js-cookie.git","svn_url":"https://github.com/js-cookie/js-cookie","homepage":"","size":698,"stargazers_count":2454,"watchers_count":2454,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"open_issues_count":8,"forks":370,"open_issues":8,"watchers":2454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168"},"html":{"href":"https://github.com/js-cookie/js-cookie/pull/168"},"issue":{"href":"https://api.github.com/repos/js-cookie/js-cookie/issues/168"},"comments":{"href":"https://api.github.com/repos/js-cookie/js-cookie/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/js-cookie/js-cookie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/js-cookie/js-cookie/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/js-cookie/js-cookie/statuses/1beef567b47171604e7e4ea72fe5c7f2e6721524"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":2}}