{"action":"closed","issue":{"url":"https://api.github.com/repos/garethr/garethr-docker/issues/361","repository_url":"https://api.github.com/repos/garethr/garethr-docker","labels_url":"https://api.github.com/repos/garethr/garethr-docker/issues/361/labels{/name}","comments_url":"https://api.github.com/repos/garethr/garethr-docker/issues/361/comments","events_url":"https://api.github.com/repos/garethr/garethr-docker/issues/361/events","html_url":"https://github.com/garethr/garethr-docker/issues/361","id":112002320,"number":361,"title":"Centos7.1 + docker-engine compatibility","user":{"login":"flyinprogrammer","id":1844847,"avatar_url":"https://avatars.githubusercontent.com/u/1844847?v=3","gravatar_id":"","url":"https://api.github.com/users/flyinprogrammer","html_url":"https://github.com/flyinprogrammer","followers_url":"https://api.github.com/users/flyinprogrammer/followers","following_url":"https://api.github.com/users/flyinprogrammer/following{/other_user}","gists_url":"https://api.github.com/users/flyinprogrammer/gists{/gist_id}","starred_url":"https://api.github.com/users/flyinprogrammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyinprogrammer/subscriptions","organizations_url":"https://api.github.com/users/flyinprogrammer/orgs","repos_url":"https://api.github.com/users/flyinprogrammer/repos","events_url":"https://api.github.com/users/flyinprogrammer/events{/privacy}","received_events_url":"https://api.github.com/users/flyinprogrammer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/garethr/garethr-docker/labels/bug","name":"bug","color":"bfdadc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-18T05:32:25Z","updated_at":"2016-02-19T17:37:24Z","closed_at":"2016-02-19T17:37:24Z","body":"Given I want to use my own repos\r\nWhen I use this module\r\nThen it should be as simple as:\r\nuse_upstream_package_source => false,\r\n\r\nActual:\r\nSo with the new docker-engine packages on centos they now use $other_args in /etc/init.d/docker\r\nWhich means I want:\r\nhttps://github.com/garethr/garethr-docker/blob/master/manifests/service.pp#L96\r\nTo evaluate to False when I'm using the docker-engine package\r\nBut True when you're using the older 'docker' packages.\r\n\r\nI have no problem writing the code to do this little case statement around package name. I just wasn't sure what you want?\r\n\r\n\r\nAlso:\r\nhttps://github.com/garethr/garethr-docker/blob/master/manifests/service.pp#L104\r\nSeems real bad? It would seem like coupling whose package to use with what init system to use might be a little overloaded, or have I misunderstood how this works?\r\n\r\n\r\nTotally down for writing code and submitting a PR to get this issue closed. Just looking to know what direction you might want to go with any of this!!\r\n\r\n"}}