{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/comments/65000535","id":65000535,"diff_hunk":"@@ -0,0 +1,151 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony CMF package.\n+ *\n+ * (c) 2011-2016 Symfony CMF\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Cmf\\Bundle\\ResourceBundle\\Tests\\Unit\\DependencyInjection;\n+\n+use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n+use Symfony\\Cmf\\Bundle\\ResourceBundle\\DependencyInjection\\Compiler\\DescriptionEnhancerPass;\n+use Symfony\\Component\\DependencyInjection\\Definition;\n+use Prophecy\\Argument;\n+use Symfony\\Component\\DependencyInjection\\Reference;\n+\n+class DescriptionEnhancerPassTest extends \\PHPUnit_Framework_TestCase\n+{\n+    public function setUp()\n+    {\n+        $this->container = $this->prophesize(ContainerBuilder::class);\n+        $this->factoryDefinition = $this->prophesize(Definition::class);\n+        $this->pass = new DescriptionEnhancerPass();\n+    }\n+\n+    /**\n+     * It should return early if the factory does not exist.\n+     *\n+     * TODO: WHY????\n+     */\n+    public function testReturnEarlyFactoryNotExist()\n+    {\n+        $this->container->has(\n+            'cmf_resource.description.factory'\n+        )->willReturn(false);","path":"Tests/Unit/DependencyInjection/Compiler/DescriptionEnhancerPassTest.php","position":38,"original_position":38,"commit_id":"ea041bf2deceb08b8715f5d97c5fc4f8ce8becfe","original_commit_id":"ea041bf2deceb08b8715f5d97c5fc4f8ce8becfe","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"no need to use line wrapping here","created_at":"2016-05-29T09:47:46Z","updated_at":"2016-05-29T09:47:46Z","html_url":"https://github.com/symfony-cmf/resource-bundle/pull/29#discussion_r65000535","pull_request_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/comments/65000535"},"html":{"href":"https://github.com/symfony-cmf/resource-bundle/pull/29#discussion_r65000535"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29","id":71802385,"html_url":"https://github.com/symfony-cmf/resource-bundle/pull/29","diff_url":"https://github.com/symfony-cmf/resource-bundle/pull/29.diff","patch_url":"https://github.com/symfony-cmf/resource-bundle/pull/29.patch","issue_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/29","number":29,"state":"open","locked":false,"title":"Description Enhancer integration","user":{"login":"dantleech","id":530801,"avatar_url":"https://avatars.githubusercontent.com/u/530801?v=3","gravatar_id":"","url":"https://api.github.com/users/dantleech","html_url":"https://github.com/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","following_url":"https://api.github.com/users/dantleech/following{/other_user}","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","organizations_url":"https://api.github.com/users/dantleech/orgs","repos_url":"https://api.github.com/users/dantleech/repos","events_url":"https://api.github.com/users/dantleech/events{/privacy}","received_events_url":"https://api.github.com/users/dantleech/received_events","type":"User","site_admin":false},"body":"Integrates description enhancers (replaces #26 ).\r\n\r\n```yaml\r\ncmf_resource:\r\n    description:\r\n        enhancers: [ \"sonata_admin\", \"foobar\" ]\r\n```","created_at":"2016-05-28T13:48:26Z","updated_at":"2016-05-29T09:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48959131aaafd228de29ae32538e1e6b4bedac9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/29/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/statuses/ea041bf2deceb08b8715f5d97c5fc4f8ce8becfe","head":{"label":"symfony-cmf:description_enhancers","ref":"description_enhancers","sha":"ea041bf2deceb08b8715f5d97c5fc4f8ce8becfe","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":26688804,"name":"resource-bundle","full_name":"symfony-cmf/resource-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/resource-bundle","description":"Resource Location for CMF documents based on Puli","fork":false,"url":"https://api.github.com/repos/symfony-cmf/resource-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/deployments","created_at":"2014-11-15T18:08:45Z","updated_at":"2016-04-07T08:02:23Z","pushed_at":"2016-05-28T19:26:17Z","git_url":"git://github.com/symfony-cmf/resource-bundle.git","ssh_url":"git@github.com:symfony-cmf/resource-bundle.git","clone_url":"https://github.com/symfony-cmf/resource-bundle.git","svn_url":"https://github.com/symfony-cmf/resource-bundle","homepage":null,"size":115,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"67983e3638e173091983a46e6c37647e8e87cb08","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":26688804,"name":"resource-bundle","full_name":"symfony-cmf/resource-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/resource-bundle","description":"Resource Location for CMF documents based on Puli","fork":false,"url":"https://api.github.com/repos/symfony-cmf/resource-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/resource-bundle/deployments","created_at":"2014-11-15T18:08:45Z","updated_at":"2016-04-07T08:02:23Z","pushed_at":"2016-05-28T19:26:17Z","git_url":"git://github.com/symfony-cmf/resource-bundle.git","ssh_url":"git@github.com:symfony-cmf/resource-bundle.git","clone_url":"https://github.com/symfony-cmf/resource-bundle.git","svn_url":"https://github.com/symfony-cmf/resource-bundle","homepage":null,"size":115,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29"},"html":{"href":"https://github.com/symfony-cmf/resource-bundle/pull/29"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/29"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/resource-bundle/statuses/ea041bf2deceb08b8715f5d97c5fc4f8ce8becfe"}}}}
{"actor":{"display_login":"WouterJ"}}