{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23","id":85358552,"html_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client/pull/23","diff_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client/pull/23.diff","patch_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client/pull/23.patch","issue_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/23","number":23,"state":"closed","locked":false,"title":"Feature/kk/projekte anzeigen","user":{"login":"kreuzerk","id":5468954,"avatar_url":"https://avatars.githubusercontent.com/u/5468954?v=3","gravatar_id":"","url":"https://api.github.com/users/kreuzerk","html_url":"https://github.com/kreuzerk","followers_url":"https://api.github.com/users/kreuzerk/followers","following_url":"https://api.github.com/users/kreuzerk/following{/other_user}","gists_url":"https://api.github.com/users/kreuzerk/gists{/gist_id}","starred_url":"https://api.github.com/users/kreuzerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreuzerk/subscriptions","organizations_url":"https://api.github.com/users/kreuzerk/orgs","repos_url":"https://api.github.com/users/kreuzerk/repos","events_url":"https://api.github.com/users/kreuzerk/events{/privacy}","received_events_url":"https://api.github.com/users/kreuzerk/received_events","type":"User","site_admin":false},"body":"@surech In diesem Branch habe ich die Anzeige der Projekte umgesetzt. Zuerst hole ich mir die Mitarbeiter - für jeden Mitarbeiter dann die Einsätze - dann iteriere ich über die Einsätze und hole mir dann pro Einsatz das Projekt. All dies passiert asynchron und daher wird das Ganze ein wenig unübersichtlich.\r\n\r\nIch verstehe die Idee die Projekte nicht mit dem Einsatz herauszugeben um diese evtl. Clientseitig zu cashen und so die Datenmenge zu reduzieren. Bin mir aber nicht sicher ob sich das stark auf die Performance auswirkt - besonders da wir wahrscheinlich noch eine Pagination einbauen und pro Anfrage dann nur 20 Mitarbeiter mit den Projekten und nicht 200 herausgeben. Clientseitig würde es den Code übersichtlicher machen. \r\n\r\nSchau dir die Änderungen mal an - wenn das so passt dann können wir das so mergen und ich versuche anschliessend noch das Caching einzubauen. Andernfalls würden wir diesen PR ablehnen und im Backend noch Anpassungen machen und die Projekte nun doch mitgeben. \r\n\r\nIch verstehe den Vorteil die Projekte separat anzufragen, sehe aber auch Vorteile sie embedded mit dem Einsatz herauszugeben","created_at":"2016-09-15T07:47:38Z","updated_at":"2016-09-15T12:39:45Z","closed_at":"2016-09-15T12:39:45Z","merged_at":"2016-09-15T12:39:45Z","merge_commit_sha":"6512e82b45fb51d8032dad7fb90a65d40ec9ba4b","assignee":{"login":"surech","id":6444041,"avatar_url":"https://avatars.githubusercontent.com/u/6444041?v=3","gravatar_id":"","url":"https://api.github.com/users/surech","html_url":"https://github.com/surech","followers_url":"https://api.github.com/users/surech/followers","following_url":"https://api.github.com/users/surech/following{/other_user}","gists_url":"https://api.github.com/users/surech/gists{/gist_id}","starred_url":"https://api.github.com/users/surech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surech/subscriptions","organizations_url":"https://api.github.com/users/surech/orgs","repos_url":"https://api.github.com/users/surech/repos","events_url":"https://api.github.com/users/surech/events{/privacy}","received_events_url":"https://api.github.com/users/surech/received_events","type":"User","site_admin":false},"assignees":[{"login":"surech","id":6444041,"avatar_url":"https://avatars.githubusercontent.com/u/6444041?v=3","gravatar_id":"","url":"https://api.github.com/users/surech","html_url":"https://github.com/surech","followers_url":"https://api.github.com/users/surech/followers","following_url":"https://api.github.com/users/surech/following{/other_user}","gists_url":"https://api.github.com/users/surech/gists{/gist_id}","starred_url":"https://api.github.com/users/surech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surech/subscriptions","organizations_url":"https://api.github.com/users/surech/orgs","repos_url":"https://api.github.com/users/surech/repos","events_url":"https://api.github.com/users/surech/events{/privacy}","received_events_url":"https://api.github.com/users/surech/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23/commits","review_comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23/comments","review_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/23/comments","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/statuses/7cef5a12fed04e36a1464c4e156789fb09e73643","head":{"label":"SchweizerischeBundesbahnen:feature/kk/projekteAnzeigen","ref":"feature/kk/projekteAnzeigen","sha":"7cef5a12fed04e36a1464c4e156789fb09e73643","user":{"login":"SchweizerischeBundesbahnen","id":6974750,"avatar_url":"https://avatars.githubusercontent.com/u/6974750?v=3","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"repo":{"id":63719557,"name":"roterOktober-client","full_name":"SchweizerischeBundesbahnen/roterOktober-client","owner":{"login":"SchweizerischeBundesbahnen","id":6974750,"avatar_url":"https://avatars.githubusercontent.com/u/6974750?v=3","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client","description":"\"Anatoli, you're afraid of our fleet. Well, you should be. Personally, I'd give us...one chance in three. More tea anyone?\" -- Capt. Marko Ramius","fork":false,"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client","forks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/forks","keys_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/teams","hooks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/hooks","issue_events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/events{/number}","events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/events","assignees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/assignees{/user}","branches_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/branches{/branch}","tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/tags","blobs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/statuses/{sha}","languages_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/languages","stargazers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/stargazers","contributors_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/contributors","subscribers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/subscribers","subscription_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/subscription","commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/contents/{+path}","compare_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/merges","archive_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/downloads","issues_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues{/number}","pulls_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls{/number}","milestones_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/milestones{/number}","notifications_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/labels{/name}","releases_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/releases{/id}","deployments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/deployments","created_at":"2016-07-19T18:48:21Z","updated_at":"2016-07-26T16:16:58Z","pushed_at":"2016-09-15T12:39:45Z","git_url":"git://github.com/SchweizerischeBundesbahnen/roterOktober-client.git","ssh_url":"git@github.com:SchweizerischeBundesbahnen/roterOktober-client.git","clone_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client.git","svn_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client","homepage":null,"size":631,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"develop"}},"base":{"label":"SchweizerischeBundesbahnen:develop","ref":"develop","sha":"1f4cab652d735c61cb757140b9e45b95398c4c69","user":{"login":"SchweizerischeBundesbahnen","id":6974750,"avatar_url":"https://avatars.githubusercontent.com/u/6974750?v=3","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"repo":{"id":63719557,"name":"roterOktober-client","full_name":"SchweizerischeBundesbahnen/roterOktober-client","owner":{"login":"SchweizerischeBundesbahnen","id":6974750,"avatar_url":"https://avatars.githubusercontent.com/u/6974750?v=3","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client","description":"\"Anatoli, you're afraid of our fleet. Well, you should be. Personally, I'd give us...one chance in three. More tea anyone?\" -- Capt. Marko Ramius","fork":false,"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client","forks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/forks","keys_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/teams","hooks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/hooks","issue_events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/events{/number}","events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/events","assignees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/assignees{/user}","branches_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/branches{/branch}","tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/tags","blobs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/statuses/{sha}","languages_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/languages","stargazers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/stargazers","contributors_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/contributors","subscribers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/subscribers","subscription_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/subscription","commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/contents/{+path}","compare_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/merges","archive_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/downloads","issues_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues{/number}","pulls_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls{/number}","milestones_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/milestones{/number}","notifications_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/labels{/name}","releases_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/releases{/id}","deployments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/deployments","created_at":"2016-07-19T18:48:21Z","updated_at":"2016-07-26T16:16:58Z","pushed_at":"2016-09-15T12:39:45Z","git_url":"git://github.com/SchweizerischeBundesbahnen/roterOktober-client.git","ssh_url":"git@github.com:SchweizerischeBundesbahnen/roterOktober-client.git","clone_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client.git","svn_url":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client","homepage":null,"size":631,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23"},"html":{"href":"https://github.com/SchweizerischeBundesbahnen/roterOktober-client/pull/23"},"issue":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/23"},"comments":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/roterOktober-client/statuses/7cef5a12fed04e36a1464c4e156789fb09e73643"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"surech","id":6444041,"avatar_url":"https://avatars.githubusercontent.com/u/6444041?v=3","gravatar_id":"","url":"https://api.github.com/users/surech","html_url":"https://github.com/surech","followers_url":"https://api.github.com/users/surech/followers","following_url":"https://api.github.com/users/surech/following{/other_user}","gists_url":"https://api.github.com/users/surech/gists{/gist_id}","starred_url":"https://api.github.com/users/surech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surech/subscriptions","organizations_url":"https://api.github.com/users/surech/orgs","repos_url":"https://api.github.com/users/surech/repos","events_url":"https://api.github.com/users/surech/events{/privacy}","received_events_url":"https://api.github.com/users/surech/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":56,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"surech"}}