{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/58239805","id":58239805,"diff_hunk":"@@ -25,24 +25,42 @@\n import java.util.List;\n \n public class MetadataRequest extends AbstractRequest {\n-    \n+\n     private static final Schema CURRENT_SCHEMA = ProtoUtils.currentRequestSchema(ApiKeys.METADATA.id);\n     private static final String TOPICS_KEY_NAME = \"topics\";\n \n+    private final boolean allTopics;\n     private final List<String> topics;\n \n     public MetadataRequest(List<String> topics) {\n+        this(topics, false);\n+    }\n+\n+    /**\n+     * If allTopics is true, then the passed topics will be ignored.\n+     */\n+    public MetadataRequest(List<String> topics, boolean allTopics) {","path":"clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java","position":19,"original_position":19,"commit_id":"b1c510793b193c81511ce135f33682137f5189b7","original_commit_id":"b1c510793b193c81511ce135f33682137f5189b7","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"In current proposal, we are saying a null indicates all topics. Would it be possible to use that here as well?","created_at":"2016-04-01T17:36:14Z","updated_at":"2016-04-01T17:36:14Z","html_url":"https://github.com/apache/kafka/pull/1095#discussion_r58239805","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1095","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/58239805"},"html":{"href":"https://github.com/apache/kafka/pull/1095#discussion_r58239805"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1095"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1095","id":63403078,"html_url":"https://github.com/apache/kafka/pull/1095","diff_url":"https://github.com/apache/kafka/pull/1095.diff","patch_url":"https://github.com/apache/kafka/pull/1095.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1095","number":1095,"state":"open","locked":false,"title":"KAFKA-3306: Change metadata response to include required additional fi…","user":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"body":"…elds\r\n\r\n- Allows protocol arrays to be null (optionally)\r\n- Adds support to ask for no topics in the metadata request\r\n- Adds new fields to the Metadata response protocol\r\n- Adds server code to handle new fields\r\n   - Support no-topic metadata requests\r\n   - Track controller id in the metadata cache\r\n   - Check if a topic is considered internal\r\n   - Check if a topic is marked for deletion\r\n   - included rack information if present\r\n- Adds test code to test new functionality independent of the client","created_at":"2016-03-18T16:45:04Z","updated_at":"2016-04-01T17:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"856ab6f1f7129cab8fbcb0d259b364b16206a332","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1095/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1095/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1095/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/b1c510793b193c81511ce135f33682137f5189b7","head":{"label":"granthenke:metadata-changes","ref":"metadata-changes","sha":"b1c510793b193c81511ce135f33682137f5189b7","user":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"repo":{"id":31473093,"name":"kafka","full_name":"granthenke/kafka","owner":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/granthenke/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/granthenke/kafka","forks_url":"https://api.github.com/repos/granthenke/kafka/forks","keys_url":"https://api.github.com/repos/granthenke/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/granthenke/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/granthenke/kafka/teams","hooks_url":"https://api.github.com/repos/granthenke/kafka/hooks","issue_events_url":"https://api.github.com/repos/granthenke/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/granthenke/kafka/events","assignees_url":"https://api.github.com/repos/granthenke/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/granthenke/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/granthenke/kafka/tags","blobs_url":"https://api.github.com/repos/granthenke/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/granthenke/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/granthenke/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/granthenke/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/granthenke/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/granthenke/kafka/languages","stargazers_url":"https://api.github.com/repos/granthenke/kafka/stargazers","contributors_url":"https://api.github.com/repos/granthenke/kafka/contributors","subscribers_url":"https://api.github.com/repos/granthenke/kafka/subscribers","subscription_url":"https://api.github.com/repos/granthenke/kafka/subscription","commits_url":"https://api.github.com/repos/granthenke/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/granthenke/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/granthenke/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/granthenke/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/granthenke/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/granthenke/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/granthenke/kafka/merges","archive_url":"https://api.github.com/repos/granthenke/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/granthenke/kafka/downloads","issues_url":"https://api.github.com/repos/granthenke/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/granthenke/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/granthenke/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/granthenke/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/granthenke/kafka/labels{/name}","releases_url":"https://api.github.com/repos/granthenke/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/granthenke/kafka/deployments","created_at":"2015-02-28T19:08:22Z","updated_at":"2015-02-28T19:08:24Z","pushed_at":"2016-04-01T02:24:16Z","git_url":"git://github.com/granthenke/kafka.git","ssh_url":"git@github.com:granthenke/kafka.git","clone_url":"https://github.com/granthenke/kafka.git","svn_url":"https://github.com/granthenke/kafka","homepage":null,"size":29607,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"623ab1e7c6497c000bc9c9978637f20542a3191c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-04-01T09:59:03Z","pushed_at":"2016-04-01T17:00:32Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":38592,"stargazers_count":2884,"watchers_count":2884,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1741,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":174,"forks":1741,"open_issues":174,"watchers":2884,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1095"},"html":{"href":"https://github.com/apache/kafka/pull/1095"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1095"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1095/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1095/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1095/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/b1c510793b193c81511ce135f33682137f5189b7"}}}}