{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/53326306","id":53326306,"diff_hunk":"@@ -612,21 +645,20 @@ angular.module('openshiftConsole')\n       }\n       triggers = triggers.concat(_.filter($scope.buildConfig.spec.triggers, function(obj) { return obj.type === \"Generic\" }));\n \n-      if ($scope.triggers.imageChange) {\n-        var imageChangeTriggers = _.filter($scope.buildConfig.spec.triggers, function(obj) { return obj.type === \"ImageChange\" });\n-        if (imageChangeTriggers.length === 0) {\n-          imageChangeTriggers.push({\n-            imageChange: {},\n-            type: \"ImageChange\"\n-          });\n-        }\n-        triggers = triggers.concat(imageChangeTriggers);\n-      }\n-      if ($scope.triggers.configChange) {\n+      if (presentTriggers.configChange) {\n         triggers.push({\n           type: \"ConfigChange\"\n         });\n       }\n+\n+      // Add all imageChange triggers to the triggers array. The imageChange trigger for the builder is added in getTriggerMap()\n+      // method into imageChangeTriggers array, even if the buildConfig doesn't contain it. If builder imageChange trigger is checked, \n+      // keep the trigger, otherwise delete it.","path":"assets/app/scripts/controllers/edit/buildConfig.js","position":127,"original_position":127,"commit_id":"6f937dede07a0e29eada6699d20be42d7f80b39a","original_commit_id":"6f937dede07a0e29eada6699d20be42d7f80b39a","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Thanks, much clearer.","created_at":"2016-02-18T15:13:16Z","updated_at":"2016-02-18T15:13:16Z","html_url":"https://github.com/openshift/origin/pull/7374#discussion_r53326306","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/7374","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/53326306"},"html":{"href":"https://github.com/openshift/origin/pull/7374#discussion_r53326306"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/7374"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7374","id":59643240,"html_url":"https://github.com/openshift/origin/pull/7374","diff_url":"https://github.com/openshift/origin/pull/7374.diff","patch_url":"https://github.com/openshift/origin/pull/7374.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/7374","number":7374,"state":"open","locked":false,"title":"Handle multiple imageChange triggers in BC edit page","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"body":"BuildConfig can specify multiple imageChange triggers pointing on multiple images. Adding option to disable those triggers and also prevent loss of data.\r\nIf only one imageChange trigger is set(for the builder), the trigger will be displayed inline:\r\n![screenshot-6](https://cloud.githubusercontent.com/assets/1668218/13110567/2aed46a4-d581-11e5-9967-82450a029da1.png)\r\n\r\nIn case of multiple imageChange triggers, they will be displayed in a list:\r\n![screenshot-4](https://cloud.githubusercontent.com/assets/1668218/13110584/46df2f12-d581-11e5-88b3-51bfd1db030a.png)\r\n\r\nIf the builder imageChange trigger is disabled, user will be able to enable it in next edit form:\r\n![screenshot-7](https://cloud.githubusercontent.com/assets/1668218/13110691/d3df261a-d581-11e5-9f27-0b4bea3ab0c3.png)\r\n\r\n\r\n@spadgett PTAL","created_at":"2016-02-17T13:27:14Z","updated_at":"2016-02-18T15:13:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0f7f479f72250eb0460ba343b42485618bc01b9","assignee":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/7374/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/7374/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7374/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/6f937dede07a0e29eada6699d20be42d7f80b39a","head":{"label":"jhadvig:bc_triggers","ref":"bc_triggers","sha":"6f937dede07a0e29eada6699d20be42d7f80b39a","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"repo":{"id":24180023,"name":"origin","full_name":"jhadvig/origin","owner":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhadvig/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jhadvig/origin","forks_url":"https://api.github.com/repos/jhadvig/origin/forks","keys_url":"https://api.github.com/repos/jhadvig/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhadvig/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhadvig/origin/teams","hooks_url":"https://api.github.com/repos/jhadvig/origin/hooks","issue_events_url":"https://api.github.com/repos/jhadvig/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jhadvig/origin/events","assignees_url":"https://api.github.com/repos/jhadvig/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jhadvig/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jhadvig/origin/tags","blobs_url":"https://api.github.com/repos/jhadvig/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhadvig/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhadvig/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhadvig/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhadvig/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jhadvig/origin/languages","stargazers_url":"https://api.github.com/repos/jhadvig/origin/stargazers","contributors_url":"https://api.github.com/repos/jhadvig/origin/contributors","subscribers_url":"https://api.github.com/repos/jhadvig/origin/subscribers","subscription_url":"https://api.github.com/repos/jhadvig/origin/subscription","commits_url":"https://api.github.com/repos/jhadvig/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhadvig/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhadvig/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhadvig/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhadvig/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jhadvig/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhadvig/origin/merges","archive_url":"https://api.github.com/repos/jhadvig/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhadvig/origin/downloads","issues_url":"https://api.github.com/repos/jhadvig/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jhadvig/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jhadvig/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jhadvig/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhadvig/origin/labels{/name}","releases_url":"https://api.github.com/repos/jhadvig/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jhadvig/origin/deployments","created_at":"2014-09-18T08:22:36Z","updated_at":"2015-08-13T16:47:19Z","pushed_at":"2016-02-18T14:58:31Z","git_url":"git://github.com/jhadvig/origin.git","ssh_url":"git@github.com:jhadvig/origin.git","clone_url":"https://github.com/jhadvig/origin.git","svn_url":"https://github.com/jhadvig/origin","homepage":"https://openshift.github.io","size":211181,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a95876f0da9cd432bf45057f2d4e48a29c212171","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-02-18T12:17:28Z","pushed_at":"2016-02-18T15:10:47Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":269161,"stargazers_count":1046,"watchers_count":1046,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":640,"mirror_url":null,"open_issues_count":865,"forks":640,"open_issues":865,"watchers":1046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/7374"},"html":{"href":"https://github.com/openshift/origin/pull/7374"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/7374"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/7374/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/7374/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/7374/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/6f937dede07a0e29eada6699d20be42d7f80b39a"}}}}