{"action":"created","comment":{"url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/71560502","id":71560502,"diff_hunk":"@@ -0,0 +1,121 @@\n+from firedrake import *\n+from abc import *\n+\n+class _Limiter(object):","path":"firedrake/slope_limiter/limiter.py","position":4,"original_position":4,"commit_id":"d7b006207d9d822607522cbf04edb33d254dee69","original_commit_id":"d7b006207d9d822607522cbf04edb33d254dee69","user":{"login":"wence-","id":1126981,"avatar_url":"https://avatars.githubusercontent.com/u/1126981?v=3","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"I anticipate that users will want to inherit from this.  So let's make a it a public class (no `_` to start the name).\r\n\r\nAlso, you can provide an `__init__` method that has a default signature.  Additionally, a docstring describing what this object is for would be good.","created_at":"2016-07-20T16:37:21Z","updated_at":"2016-07-20T16:37:21Z","html_url":"https://github.com/firedrakeproject/firedrake/pull/832#discussion_r71560502","pull_request_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/71560502"},"html":{"href":"https://github.com/firedrakeproject/firedrake/pull/832#discussion_r71560502"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832"}}},"pull_request":{"url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832","id":78170706,"html_url":"https://github.com/firedrakeproject/firedrake/pull/832","diff_url":"https://github.com/firedrakeproject/firedrake/pull/832.diff","patch_url":"https://github.com/firedrakeproject/firedrake/pull/832.patch","issue_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/832","number":832,"state":"open","locked":false,"title":"Slope limiters","user":{"login":"chawkm","id":20336731,"avatar_url":"https://avatars.githubusercontent.com/u/20336731?v=3","gravatar_id":"","url":"https://api.github.com/users/chawkm","html_url":"https://github.com/chawkm","followers_url":"https://api.github.com/users/chawkm/followers","following_url":"https://api.github.com/users/chawkm/following{/other_user}","gists_url":"https://api.github.com/users/chawkm/gists{/gist_id}","starred_url":"https://api.github.com/users/chawkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chawkm/subscriptions","organizations_url":"https://api.github.com/users/chawkm/orgs","repos_url":"https://api.github.com/users/chawkm/repos","events_url":"https://api.github.com/users/chawkm/events{/privacy}","received_events_url":"https://api.github.com/users/chawkm/received_events","type":"User","site_admin":false},"body":"Limiter abstract class for all limiters to inherit.\r\n\r\nVectorBased class which is based on Colin Cotter's implementation for P1DG field limiters and inherits Limiter.","created_at":"2016-07-20T15:43:19Z","updated_at":"2016-07-20T16:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b511a93f26e4c928d9a8a5eddced6b39568d3c85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832/commits","review_comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832/comments","review_comment_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/832/comments","statuses_url":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/d7b006207d9d822607522cbf04edb33d254dee69","head":{"label":"chawkm:slope-limiters","ref":"slope-limiters","sha":"d7b006207d9d822607522cbf04edb33d254dee69","user":{"login":"chawkm","id":20336731,"avatar_url":"https://avatars.githubusercontent.com/u/20336731?v=3","gravatar_id":"","url":"https://api.github.com/users/chawkm","html_url":"https://github.com/chawkm","followers_url":"https://api.github.com/users/chawkm/followers","following_url":"https://api.github.com/users/chawkm/following{/other_user}","gists_url":"https://api.github.com/users/chawkm/gists{/gist_id}","starred_url":"https://api.github.com/users/chawkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chawkm/subscriptions","organizations_url":"https://api.github.com/users/chawkm/orgs","repos_url":"https://api.github.com/users/chawkm/repos","events_url":"https://api.github.com/users/chawkm/events{/privacy}","received_events_url":"https://api.github.com/users/chawkm/received_events","type":"User","site_admin":false},"repo":{"id":63151992,"name":"firedrake","full_name":"chawkm/firedrake","owner":{"login":"chawkm","id":20336731,"avatar_url":"https://avatars.githubusercontent.com/u/20336731?v=3","gravatar_id":"","url":"https://api.github.com/users/chawkm","html_url":"https://github.com/chawkm","followers_url":"https://api.github.com/users/chawkm/followers","following_url":"https://api.github.com/users/chawkm/following{/other_user}","gists_url":"https://api.github.com/users/chawkm/gists{/gist_id}","starred_url":"https://api.github.com/users/chawkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chawkm/subscriptions","organizations_url":"https://api.github.com/users/chawkm/orgs","repos_url":"https://api.github.com/users/chawkm/repos","events_url":"https://api.github.com/users/chawkm/events{/privacy}","received_events_url":"https://api.github.com/users/chawkm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chawkm/firedrake","description":"Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)","fork":true,"url":"https://api.github.com/repos/chawkm/firedrake","forks_url":"https://api.github.com/repos/chawkm/firedrake/forks","keys_url":"https://api.github.com/repos/chawkm/firedrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chawkm/firedrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chawkm/firedrake/teams","hooks_url":"https://api.github.com/repos/chawkm/firedrake/hooks","issue_events_url":"https://api.github.com/repos/chawkm/firedrake/issues/events{/number}","events_url":"https://api.github.com/repos/chawkm/firedrake/events","assignees_url":"https://api.github.com/repos/chawkm/firedrake/assignees{/user}","branches_url":"https://api.github.com/repos/chawkm/firedrake/branches{/branch}","tags_url":"https://api.github.com/repos/chawkm/firedrake/tags","blobs_url":"https://api.github.com/repos/chawkm/firedrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chawkm/firedrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chawkm/firedrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/chawkm/firedrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chawkm/firedrake/statuses/{sha}","languages_url":"https://api.github.com/repos/chawkm/firedrake/languages","stargazers_url":"https://api.github.com/repos/chawkm/firedrake/stargazers","contributors_url":"https://api.github.com/repos/chawkm/firedrake/contributors","subscribers_url":"https://api.github.com/repos/chawkm/firedrake/subscribers","subscription_url":"https://api.github.com/repos/chawkm/firedrake/subscription","commits_url":"https://api.github.com/repos/chawkm/firedrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/chawkm/firedrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/chawkm/firedrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/chawkm/firedrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/chawkm/firedrake/contents/{+path}","compare_url":"https://api.github.com/repos/chawkm/firedrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chawkm/firedrake/merges","archive_url":"https://api.github.com/repos/chawkm/firedrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chawkm/firedrake/downloads","issues_url":"https://api.github.com/repos/chawkm/firedrake/issues{/number}","pulls_url":"https://api.github.com/repos/chawkm/firedrake/pulls{/number}","milestones_url":"https://api.github.com/repos/chawkm/firedrake/milestones{/number}","notifications_url":"https://api.github.com/repos/chawkm/firedrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chawkm/firedrake/labels{/name}","releases_url":"https://api.github.com/repos/chawkm/firedrake/releases{/id}","deployments_url":"https://api.github.com/repos/chawkm/firedrake/deployments","created_at":"2016-07-12T11:20:31Z","updated_at":"2016-07-12T11:20:33Z","pushed_at":"2016-07-20T15:52:20Z","git_url":"git://github.com/chawkm/firedrake.git","ssh_url":"git@github.com:chawkm/firedrake.git","clone_url":"https://github.com/chawkm/firedrake.git","svn_url":"https://github.com/chawkm/firedrake","homepage":"http://firedrakeproject.org","size":14911,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firedrakeproject:master","ref":"master","sha":"410201c94c8b50dafc67ccfc731f3986a8a80a84","user":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":13384052,"name":"firedrake","full_name":"firedrakeproject/firedrake","owner":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/firedrake","description":"Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)","fork":false,"url":"https://api.github.com/repos/firedrakeproject/firedrake","forks_url":"https://api.github.com/repos/firedrakeproject/firedrake/forks","keys_url":"https://api.github.com/repos/firedrakeproject/firedrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/firedrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/firedrake/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/firedrake/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/firedrake/events","assignees_url":"https://api.github.com/repos/firedrakeproject/firedrake/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/firedrake/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/firedrake/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/firedrake/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/firedrake/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/firedrake/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/firedrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/firedrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/firedrake/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/firedrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/firedrake/merges","archive_url":"https://api.github.com/repos/firedrakeproject/firedrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/firedrake/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/firedrake/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/firedrake/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/firedrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/firedrake/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/firedrake/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/firedrake/deployments","created_at":"2013-10-07T13:07:44Z","updated_at":"2016-07-15T15:53:03Z","pushed_at":"2016-07-20T15:58:32Z","git_url":"git://github.com/firedrakeproject/firedrake.git","ssh_url":"git@github.com:firedrakeproject/firedrake.git","clone_url":"https://github.com/firedrakeproject/firedrake.git","svn_url":"https://github.com/firedrakeproject/firedrake","homepage":"http://firedrakeproject.org","size":15311,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":57,"forks":25,"open_issues":57,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832"},"html":{"href":"https://github.com/firedrakeproject/firedrake/pull/832"},"issue":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/issues/832"},"comments":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/issues/832/comments"},"review_comments":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832/comments"},"review_comment":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/832/commits"},"statuses":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/statuses/d7b006207d9d822607522cbf04edb33d254dee69"}}}}
{"actor":{"display_login":"wence-"}}