{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/10227","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/10227/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10227/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/10227/events","html_url":"https://github.com/nodejs/node/pull/10227","id":194841350,"number":10227,"title":"src: don't overwrite non-writable vm globals","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21","default":false},{"id":463619724,"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v6.x","name":"lts-watch-v6.x","color":"d93f0b","default":false},{"id":155436007,"url":"https://api.github.com/repos/nodejs/node/labels/vm","name":"vm","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-11T16:38:51Z","updated_at":"2016-12-29T01:40:55Z","closed_at":"2016-12-13T12:18:10Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10227","html_url":"https://github.com/nodejs/node/pull/10227","diff_url":"https://github.com/nodejs/node/pull/10227.diff","patch_url":"https://github.com/nodejs/node/pull/10227.patch"},"body":"@fhinkel Can you take a look?  I couldn't figure out what `is_contextual_store` is needed for.  Tests pass without it.\r\n\r\nCI: https://ci.nodejs.org/job/node-test-pull-request/5357/"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/269569052","html_url":"https://github.com/nodejs/node/pull/10227#issuecomment-269569052","issue_url":"https://api.github.com/repos/nodejs/node/issues/10227","id":269569052,"user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T01:40:55Z","updated_at":"2016-12-29T01:40:55Z","body":"See https://github.com/facebook/jest/pull/2457#issuecomment-269527981 for @TheAlphaNerd's repro. This also applies to globals like `setTimeout` and other timer related features. The only workaround I can find so far is to set the fields in a non-strict module, which seems quite hacky. Can we at least make `Object.defineProperty` work for these."}}
{"actor":{"display_login":"cpojer"}}