{"action":"created","issue":{"url":"https://api.github.com/repos/Polymer/polymer-build/issues/83","repository_url":"https://api.github.com/repos/Polymer/polymer-build","labels_url":"https://api.github.com/repos/Polymer/polymer-build/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/Polymer/polymer-build/issues/83/comments","events_url":"https://api.github.com/repos/Polymer/polymer-build/issues/83/events","html_url":"https://github.com/Polymer/polymer-build/pull/83","id":192133971,"number":83,"title":"fix vulcanize to bundle absolute url paths in the entrypoint","user":{"login":"FredKSchott","id":622227,"avatar_url":"https://avatars.githubusercontent.com/u/622227?v=3","gravatar_id":"","url":"https://api.github.com/users/FredKSchott","html_url":"https://github.com/FredKSchott","followers_url":"https://api.github.com/users/FredKSchott/followers","following_url":"https://api.github.com/users/FredKSchott/following{/other_user}","gists_url":"https://api.github.com/users/FredKSchott/gists{/gist_id}","starred_url":"https://api.github.com/users/FredKSchott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredKSchott/subscriptions","organizations_url":"https://api.github.com/users/FredKSchott/orgs","repos_url":"https://api.github.com/users/FredKSchott/repos","events_url":"https://api.github.com/users/FredKSchott/events{/privacy}","received_events_url":"https://api.github.com/users/FredKSchott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"usergenic","id":578,"avatar_url":"https://avatars.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},"assignees":[{"login":"usergenic","id":578,"avatar_url":"https://avatars.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-28T22:25:16Z","updated_at":"2016-12-05T01:06:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-build/pulls/83","html_url":"https://github.com/Polymer/polymer-build/pull/83","diff_url":"https://github.com/Polymer/polymer-build/pull/83.diff","patch_url":"https://github.com/Polymer/polymer-build/pull/83.patch"},"body":"Should fix #78, https://github.com/Polymer/polymer-cli/issues/373, https://github.com/Polymer/polymer-cli/issues/453, https://github.com/Polymer/polymer-cli/issues/371, https://github.com/Polymer/polymer-cli/issues/369, https://github.com/Polymer/polymer-cli/issues/245, https://github.com/Polymer/polymer-cli/issues/444, https://github.com/Polymer/polymer-cli/issues/448, and many of the problems brought up in the #tools Slack channel.\r\n\r\nCurrently, absolute path imports in `index.html` break bundling in non-app-style projects. This breaks the build for many of our users projects, including our own `application` template. This is due to a bug in vulcanize where `path.dirname('index.html')` returned `.`, which broke future calls to `path.resolve()` where an actual directory name was expected.\r\n\r\nA fix has been submitted for that bug in vulcanize as well, but the bug does not occur when the projects root is properly set in the options. This PR updates bundling to use this more standard call to Vulcanize, similar to the way it is tested. The bug only exists when it is called with `inputUrl` and no `abspath`.\r\n\r\n/cc @justinfagnani @usergenic @rictic"},"comment":{"url":"https://api.github.com/repos/Polymer/polymer-build/issues/comments/264746936","html_url":"https://github.com/Polymer/polymer-build/pull/83#issuecomment-264746936","issue_url":"https://api.github.com/repos/Polymer/polymer-build/issues/83","id":264746936,"user":{"login":"mercmobily","id":2128734,"avatar_url":"https://avatars.githubusercontent.com/u/2128734?v=3","gravatar_id":"","url":"https://api.github.com/users/mercmobily","html_url":"https://github.com/mercmobily","followers_url":"https://api.github.com/users/mercmobily/followers","following_url":"https://api.github.com/users/mercmobily/following{/other_user}","gists_url":"https://api.github.com/users/mercmobily/gists{/gist_id}","starred_url":"https://api.github.com/users/mercmobily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercmobily/subscriptions","organizations_url":"https://api.github.com/users/mercmobily/orgs","repos_url":"https://api.github.com/users/mercmobily/repos","events_url":"https://api.github.com/users/mercmobily/events{/privacy}","received_events_url":"https://api.github.com/users/mercmobily/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T01:06:13Z","updated_at":"2016-12-05T01:06:13Z","body":"Sorry about the noise, but... can I just say: \"THANK YOU\"!"}}
{"actor":{"display_login":"mercmobily"}}