{"push_id":1297849829,"size":339,"distinct_size":1,"ref":"refs/heads/translate_not_null_violation_to_specific_exception","head":"ea91a504d997c16fb5001fef696a4921df84507c","before":"818f8e1461d6ba91279ac632395e9d767e518797","commits":[{"sha":"1896fafa602d46b833845e2dda3896de983ce0ab","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl needed for Chapters column, instead of leaking to other lists.\n\nBefore:\n https://monosnap.com/file/CNIMXcqv3HuRrObTNYWYFis8I3G8PT\nAfter:\n https://monosnap.com/file/0IyEKEy9hcRCIx82etR8ikinCo3vNb\n\nChapters column remains as is: http://take.ms/M0BkF","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/1896fafa602d46b833845e2dda3896de983ce0ab"},{"sha":"b76f82d714e590c20370e72fa36fa574c4f17650","author":{"name":"Yosuke Kabuto","email":"ad991f0fa4a76291132486a29b31815a6d3fc19b@gmail.com"},"message":"Update CHANGELOG.md for #25628 [ci skip]\n\nMove new CHANGELOG entry top [ci skip]\n\nRemove parameter \"options = nil\" for #clear","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/b76f82d714e590c20370e72fa36fa574c4f17650"},{"sha":"eb8cd81859bd9f7df8cc08602200847e41e85f0d","author":{"name":"Santosh Wadghule","email":"c730d7c5ee5de4322bef90d57dec4fcc77ce2a5d@gmail.com"},"message":"Remove duplicate test.\n\nWe already test similar stuff in `test_really_long_keys` so removing\nthis extra and duplicated test.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/eb8cd81859bd9f7df8cc08602200847e41e85f0d"},{"sha":"c0eb542e57fe6eaa959218c1a7026e53673ba0cb","author":{"name":"Jack","email":"cb156f9ad6bff64206c26f177479318304a5df17@gmail.com"},"message":"have does_not_support_reverse? support sql functions with commas in nested brackets","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/c0eb542e57fe6eaa959218c1a7026e53673ba0cb"},{"sha":"d929a218c47b7a5ffc3f8989676a99edb992e2aa","author":{"name":"Jack Chen Songyong","email":"cb156f9ad6bff64206c26f177479318304a5df17@gmail.com"},"message":"check if order contains comma first in does_not_support_reverse?","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/d929a218c47b7a5ffc3f8989676a99edb992e2aa"},{"sha":"411e4597d552aa091cfe3dc76a83bdaffe02da1a","author":{"name":"Takashi Kokubun","email":"b01f0c46b88888a17b7c3c9b379a42b1ab53f1e9@gmail.com"},"message":"Preserve readonly flag only for readonly association\n\nFixes #24093","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/411e4597d552aa091cfe3dc76a83bdaffe02da1a"},{"sha":"d14a5defeb0c9f2972f90d83cb625beed8105d76","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Remove internal `sanitize` method\n\nCurrently internal `sanitize`/`quote_value` method is only used for `quoted_id`.\nSimply it is enough to use `connection.quote` public API instead.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/d14a5defeb0c9f2972f90d83cb625beed8105d76"},{"sha":"ab5070ede10c4ad9332f342232ab4d12db2bc5b0","author":{"name":"monmon","email":"f872999a9fd037f4458d1133413553b6898b3fa0@skimatalk.com"},"message":"Check if the logger exists before trying to use it","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/ab5070ede10c4ad9332f342232ab4d12db2bc5b0"},{"sha":"3a8a9979acab6a6f4c6d759521c052fe2ac46d2b","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"`pluck` should use `records` (`load_target`) when `loaded?` is true","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/3a8a9979acab6a6f4c6d759521c052fe2ac46d2b"},{"sha":"2ed25b31d423384219c7fa6d55e82d5327c14157","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"`sql_for_insert` should be called inside `exec_insert`\n\n`exec_insert` cannot return last inserted id if `use_insert_returning?`\nis true. `sql_for_insert` should be called inside `exec_insert`.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/2ed25b31d423384219c7fa6d55e82d5327c14157"},{"sha":"d93fc73f111fc1f5e8bd27afe09ef9c0763584a3","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Fix error message for out of range byte size integer value for consistency\n\nRelated f27a932, #25391.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/d93fc73f111fc1f5e8bd27afe09ef9c0763584a3"},{"sha":"484b3ca4023c04fa31c7dc8c3de4dcd428d6e63b","author":{"name":"Prathamesh Sonpatki","email":"29d2da6661b27593dde2bb79ed7f671147541054@gmail.com"},"message":"Fix remaining broadcasting_name example from Action Cable guide [ci skip]\n\n- Followup of https://github.com/rails/rails/pull/26125.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/484b3ca4023c04fa31c7dc8c3de4dcd428d6e63b"},{"sha":"5047a1229fe13983274bf9675d09748cba281645","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Remove unnecessary `query_scope`","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/5047a1229fe13983274bf9675d09748cba281645"},{"sha":"c6a62dc327c54baec87306f5c381e13cacc00a19","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Do not handle as an associated predicate if a table has the column\n\nIf handled as an associated predicate even though a table has the\ncolumn, will generate invalid SQL by valid column name treated as a\ntable name.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/c6a62dc327c54baec87306f5c381e13cacc00a19"},{"sha":"3a1f6fe7b4a70bf0698b0684dd48ac712c6883b6","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Extract `PredicateBuilder::CaseSensitiveHandler`\n\nCurrently uniqueness validator is coupled with building Arel ASTs.\nThis commit extracts `PredicateBuilder::CaseSensitiveHandler` for\ndecouple the building Arel ASTs.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/3a1f6fe7b4a70bf0698b0684dd48ac712c6883b6"},{"sha":"ed34b6760793ebc8477f3cd6398ac3ef829b57d1","author":{"name":"Jean Boussier","email":"789edfb0f74b5e773dc1c618c10e3403f79cbe2d@gmail.com"},"message":"Makes touch_later respects no_touching policy","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/ed34b6760793ebc8477f3cd6398ac3ef829b57d1"},{"sha":"0aae7806c10e3e3cce671c23dac6a8958ba89629","author":{"name":"Maxime Lapointe","email":"efe9389cd7a5c74126c16882b8e20a4f5dae9b1a@hotmail.com"},"message":"Fix count which would sometimes force a DISTINCT\nThe current behaviour of checking if there is a LEFT OUTER JOIN arel\nnode to detect if we are doing eager_loading is wrong. This problem\nwasn't frequent before as only some pretty specific cases would add\na LEFT OUTER JOIN arel node. However, the recent new feature\nleft_outer_joins also add this node and made this problem happen\nfrequently.\n\nSince in the perform_calculation function, we don't have access to\neager_loading information, I had to extract the logic for the distinct\nout to the calculate method.\n\nAs I was in the file for left_outer_join tests, I fixed a few that had\nbugs and I replaced some that were really weak with something that\nwill catch more issues.\n\nIn relation tests, the first test I changed would have failed if it\nhad validated the hash returned by count instead of just checking how\nmany pairs were in it. This is because this merge of join currently\ntransforms the join node into an outer join node, which then made\ncount do a distinct. So before this change, the return was\n{1=>1, 4=>1, 5=>1}.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/0aae7806c10e3e3cce671c23dac6a8958ba89629"},{"sha":"46380674d31af542a07de93a21d6be3a9cddb64b","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Fix inconsistent the signature of finder methods for collection association\n\n`#second`, `#third`, etc finder methods was added in 03855e790de2224519f55382e3c32118be31eeff.\nBut the signature of these methods is inconsistent with the original\nfinder methods. And also the signature of `#first` and `#last` methods\nis different from the original. This commit fixes the inconsistency.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/46380674d31af542a07de93a21d6be3a9cddb64b"},{"sha":"9d0088840cfa57018d2f1b60d8e6a6842b60fc61","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Finder bang method should call non bang method\n\nOtherwise CollectionProxy's bang methdos cannot respect dirty target.","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/9d0088840cfa57018d2f1b60d8e6a6842b60fc61"},{"sha":"149c144409cc9cbc4e960dbd70c9c77d86b06d8d","author":{"name":"Rafael França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Merge pull request #26183 from Shopify/fix-no-touching-touch-later\n\nMakes touch_later respects no_touching policy","distinct":false,"url":"https://api.github.com/repos/kamipo/rails/commits/149c144409cc9cbc4e960dbd70c9c77d86b06d8d"}]}
{"actor":{"display_login":"kamipo"}}