{"push_id":1333504809,"size":344,"distinct_size":344,"ref":"refs/heads/framework_flavor","head":"d33613aa97ca083aebea95377d70871b50d98be6","before":"c9915e3fb02e9296139e9902534446866f09378e","commits":[{"sha":"c86ea06a0f2f2e163b37e3be324c5f4f91f1edac","author":{"name":"Simon Stewart","email":"a307737e0baed0f262e1c289e04672a27ab22017@gmail.com"},"message":"Prevent the fact that we're using antiquated APIs poking through.\n\nSummary:\nThe ProcessBuilder is from the Dawn of Computing, and uses `File`\ninstead of `Path`. Clean up the abstraction leakage.\nCloses https://github.com/facebook/buck/pull/852\n\nReviewed By: Coneko\n\nfbshipit-source-id: f9dba46","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/c86ea06a0f2f2e163b37e3be324c5f4f91f1edac"},{"sha":"08cd88eaabff1eff87a4667b143c342b162f8d08","author":{"name":"Kevin Lacker","email":"4f8256ed59811c7dd7ca32acad9a4d5484fc1d6c@parse.com"},"message":"Fix Google Analytics integration\n\nSummary:\nThe previous PR wasn't the right way to include javascript in a soy template - it needs {literal} {/literal} so the code doesn't get processed.\nCloses https://github.com/facebook/buck/pull/849\n\nReviewed By: Coneko\n\nfbshipit-source-id: f3f950b","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/08cd88eaabff1eff87a4667b143c342b162f8d08"},{"sha":"267766df946e20dd59aae5384c7fc278c7c3e9d6","author":{"name":"Simon Stewart","email":"a307737e0baed0f262e1c289e04672a27ab22017@gmail.com"},"message":"Use the system default XSLT engine when generating junit reports\n\nSummary:\nBecause we use the user-provided classpath when running junit tests\nit's possible that they will specify an XSLT engine that can not be\nloaded. Avoid this problem by using the platform default one.\nCloses https://github.com/facebook/buck/pull/853\n\nReviewed By: Coneko\n\nfbshipit-source-id: fa9ac4e","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/267766df946e20dd59aae5384c7fc278c7c3e9d6"},{"sha":"6a19cf921c107ea0f1751e4f84c639e5050e2da7","author":{"name":"Michal Lowicki","email":"99c4bc4e11de5b5d1714066d4b2c27e0dfc0e0e4@fb.com"},"message":"Improve `allow_unsafe_import` documentation\n\nSummary: More details in the `allow_unsafe_import` documentation.\n\nTest Plan: ./docs/soyweb-local.sh\n\nReviewed By: k21\n\nfbshipit-source-id: a52d8ab","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/6a19cf921c107ea0f1751e4f84c639e5050e2da7"},{"sha":"b539617fb67c7f9117f8e3aa5cf0dad374fb60a9","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Check and upload missing files before starting a build\n\nSummary:\n- Refactor some distributed build code.\n- Added logic to check if the CAS contains all reqd files, if not, upload them.\n\nTest Plan: CI\n\nReviewed By: alisdair04\n\nfbshipit-source-id: 94907a8","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/b539617fb67c7f9117f8e3aa5cf0dad374fb60a9"},{"sha":"35371c36a87034ee075759973c7c2d31d5b83bcf","author":{"name":"Dan Yang","email":"67cb0e5b09e0481df512c743e94efca9705146a3@gmail.com"},"message":"Rudimentary kotlin support.\n\nSummary:\nRight now this change doesn't to much more than enable `kotlin_library()` and `kotlin_test()` build rules. You will still need to include the kotlin runtime as a separate prebuilt_jar() build rule or else your kotlin targets will crash and burn.\n\nThere isn't a `kotlin_binary()` target yet. Use `java_binary()` instead and remember to add the suffix 'Kt' when specifying the main class (see https://kotlinlang.org/docs/reference/java-to-kotlin-interop.html)\n\nTo use this you will need to:\n\n- Have `kotlinc` in your path or specify it in your .buckconfig\n````\n[kotlin]\n   compiler = ...\n````\n- Copy the kotlin-runtime.jar into your repo (intellij can do this for you when setting up kotlin) and create a `prebuilt_jar()` build rule for it. Include this target as a dependency under your `kotlin_library()` target.\nCloses https://github.com/facebook/buck/pull/810\n\nReviewed By: Coneko\n\nfbshipit-source-id: a47790d","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/35371c36a87034ee075759973c7c2d31d5b83bcf"},{"sha":"669dcd5b68e6b5aba27b2730fc80b0ee5c15312f","author":{"name":"Gautam Korlam","email":"a70b17c4b77b9b5f936f1ba7f5e2b8be80f39ff8@uber.com"},"message":"Add support for coverage includes/excludes in jacoco\n\nSummary:\nAdd support for maven/gradle style jacoco coverage options for including and excluding classes\n\nPlease let me know if the approach is ok and I will add some tests\nCloses https://github.com/facebook/buck/pull/850\n\nReviewed By: Coneko\n\nfbshipit-source-id: ba78ed0","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/669dcd5b68e6b5aba27b2730fc80b0ee5c15312f"},{"sha":"e90c3ca7dce0dfcf921df8106503ae6eda13c369","author":{"name":"Jakub Zika","email":"baff7152439df344bfd58532c85ff94583f29f02@fb.com"},"message":"Avoid deadlock caused by blocking xctool's stderr\n\nSummary:\nRead xctool's stderr in a separate thread to avoid a deadlock when\nxctool tries to write more bytes on its stderr than fit in the\noperating system's pipe buffer (tens of KiB on Mac OS X).\n\nTest Plan:\nModify the test runner to output a lot of text on stderr, check\nthat Buck does not deadlock when running tests.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 368f080","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/e90c3ca7dce0dfcf921df8106503ae6eda13c369"},{"sha":"d479cfcbaae9f658ada51dee68eaeb65dd811e96","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Upload target graph to the frontend for distbuild\n\nTest Plan: CI\n\nReviewed By: ruibm\n\nfbshipit-source-id: a8bb5dd","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/d479cfcbaae9f658ada51dee68eaeb65dd811e96"},{"sha":"fad49d9785f7077441805bd8bcaa88f4ef2dc882","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Exclude Kotlin test data directory.\n\nTest Plan: Build project in IntelliJ.\n\nReviewed By: k21\n\nfbshipit-source-id: 286e14a","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/fad49d9785f7077441805bd8bcaa88f4ef2dc882"},{"sha":"ff6b13710b85b0feb68f5d78bbbd942c3a867e37","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Breaking log->network dependency - moved MemoryHandler\n\nSummary: Moving MemoryHandler to log/memory. This will help break log->network dependency which we need to use new ScribeLoggers (and is generally inconvenient).\n\nTest Plan: buck build, buck test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 5f5f62b","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/ff6b13710b85b0feb68f5d78bbbd942c3a867e37"},{"sha":"6d50c950fc10acab6db5de81a727bd4498d65df5","author":{"name":"Cristiano Calcagno","email":"7c2209db9677677e48bc82c116c896e4182ca89a@fb.com"},"message":"Add support for Reason files.\n\nSummary:\nReason files add two more file extensions: .`re` for implementations and `.rei` for interfaces.\nThe build rules need to recognize the new `.re` and `.rei` extensions.\nCompilation commands need extra parameters in case of Reason files:\n- `ocamlc` and `ocamlopt` need the Reason formatter `refmt` passed via the `-pp` option, and need to know whether files are implementation `-impl` or interface `-intf` files.\n- `ocamldep` needs, for each file, to know whether it is an implementation or interface file, and whether an external processor needs to be used. Since once a processor is set, then it applies to all the subsequent files, and since Ocaml and Reason files can alternate, the `refmt` preprocessor needs to be sometimes set, and sometimes the default no-op formatter needs to be reset (currently by passing `cat` as the preprocessor).\n- There are minor complication in the treatment of dependencies: `ocamldep` produces a dependency graph in terms of `.cmx` and `.cmi` files, and these need to be mapped back to source files. While with a project consisting only of Ocaml files the mapping is unique, with mixed Ocaml/Reason files there are two possible mappings, e.g. a `.cmx` file can map to a `.ml` or a `.re` file. The diff duplicates the dependency graph so that all the possibilities are covered, then uses filtering w.r.t. the input files to pick the correct ones.\n\nThe intent of the diff is to change as little as possible in Ocaml-only projects. This is partially possible, except for the dependency graph, which needs to take into account the possible existence of Reason files.\n\nTest Plan:\nTest on CI.\nTested separately on toy projects that mix `.ml` and `.re` files. Currently, I can't add them as extra tests until Reason is available on CI machines.\n\nReviewed By: Coneko\n\nfbshipit-source-id: fb64e74","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/6d50c950fc10acab6db5de81a727bd4498d65df5"},{"sha":"6c0b0c71b63cd46df3a49661fad2f399e6a82715","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Breaking log->network dependency - moved Hostname* files\n\nSummary: Moving Hostname* files to network/hostname. This helps break log->network dependency which we need to use new ScribeLoggers (and is generally inconvenient).\n\nTest Plan: buck build, buck test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 39029b5","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/6c0b0c71b63cd46df3a49661fad2f399e6a82715"},{"sha":"5120dc57894e935b776fcaf7f0f7dc216c39cb84","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Breaking log->network dependency - removed redundant network/thrift subpackage\n\nSummary: Final step of breaking log->network dependency. We can now remove the network/thrift subpackage which was an earlier partial solution - now redundant.\n\nTest Plan: buck build, buck test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 2bbe7ce","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/5120dc57894e935b776fcaf7f0f7dc216c39cb84"},{"sha":"196e77effdeb6bb985237135fe5883237150428f","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Stop passing multimap when only the keys are needed for DefaultSuggestBuildRules\n\nSummary: No one actually use the multimap nature of transitiveClasspathEntries...\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: e8f51d7","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/196e77effdeb6bb985237135fe5883237150428f"},{"sha":"d2a3cfb3ed2dc87597d373d6e9e7aee6d6f9e553","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove HasTests implementation from Genrule.\n\nSummary:\nThis was added to implement test discovery for genrules\nbut it is unnecessary as that works completely on the target graph.\n\nTest Plan: CI\n\nReviewed By: yiding\n\nfbshipit-source-id: 684d8f3","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/d2a3cfb3ed2dc87597d373d6e9e7aee6d6f9e553"},{"sha":"291cfea62fed143e952253a4fb1f183ee8c60404","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove NoopBuildRuleWithTests.\n\nSummary:\nThis was added to enable test discovery for go libraries, but that works\nentirely on the target graph and does not require annotating build rules.\n\nTest Plan: CI\n\nReviewed By: yiding\n\nfbshipit-source-id: dcaac86","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/291cfea62fed143e952253a4fb1f183ee8c60404"},{"sha":"c883167574b7857d658051a2f9f7c98ed9ff5f29","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove Beta annotations.\n\nSummary: We don't really take them into consideration.\n\nTest Plan: CI\n\nReviewed By: bolinfest\n\nfbshipit-source-id: 2c7d07a","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/c883167574b7857d658051a2f9f7c98ed9ff5f29"},{"sha":"0507c50b3c0277fc4e76054e15d9119d7a92c82f","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove Immutable annotations.\n\nSummary: We don't use them consistently.\n\nTest Plan: CI\n\nReviewed By: bolinfest\n\nfbshipit-source-id: 23e5735","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/0507c50b3c0277fc4e76054e15d9119d7a92c82f"},{"sha":"83a0d0ab08f975d79933ab1da9942e17810b6e71","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Fix missing dep. on log/memory\n\nSummary: We need to add the dependency to the new log/memory as autodeps seems to not find deps that come from bootstrapper loading classes (only clue is probably a string with class name in code).\n\nTest Plan:\nCheck locally bootstrapper no longer fails to load the class.\n\nSandcastle.\n\nReviewed By: Coneko\n\nfbshipit-source-id: e54a9c5","distinct":true,"url":"https://api.github.com/repos/robbertvanginkel/buck/commits/83a0d0ab08f975d79933ab1da9942e17810b6e71"}]}
{"actor":{"display_login":"robbertvanginkel"}}