{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5327","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5327/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5327/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5327/events","html_url":"https://github.com/matplotlib/matplotlib/issues/5327","id":113437515,"number":5327,"title":"Make `mpl_toolkits` a non-namespace package","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.1%20(next%20point%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12/labels","id":534144,"number":12,"title":"2.1 (next point release)","description":"Next feature release.\r\n\r\nBig ticket items:\r\n\r\n - MEP 22/27\r\n - traitlets","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":538,"closed_issues":483,"state":"open","created_at":"2014-01-13T03:21:09Z","updated_at":"2016-10-11T07:00:10Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-10-26T19:53:18Z","updated_at":"2016-10-11T16:37:36Z","closed_at":null,"body":"Namespace packages are the source of all kinds of user errors.\r\n\r\nThis would involve moving basemap (and any other 3rd-party packages that install into `mpl_toolkits`, if they exist) to the top-level and installing a shim so it could still be imported from the old location.\r\n\r\nCc: ~~@jswhit~~ @WeatherGod to coordinate.\r\n\r\nCc: @jenshnielsen "},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/252972090","html_url":"https://github.com/matplotlib/matplotlib/issues/5327#issuecomment-252972090","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5327","id":252972090,"user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T16:37:36Z","updated_at":"2016-10-11T16:37:36Z","body":"You would need to make one shim for Python 3.3 and above; and another shim\nfor Python 2.7.\n\nOn Tue, Oct 11, 2016 at 11:54 AM, Jens Hedegaard Nielsen <\nnotifications@github.com> wrote:\n\n> That might be a reasonable temporary solution (if it can work with 2.7\n> some how) which is easier to implement. I sagree with @NelleV\n> <https://github.com/NelleV> that we should get rid of the namespace\n> package completely and\n> I think the best way would be something like:\n>\n>    1. Change basemap to install outside mpl_toolkits as a regular package.\n>    2. In basemap provide a shim that installs into mpl_toolkits provided\n>    that mpl_toolkits is a namespace package (for old matplotlib versions with\n>    the namespace package)\n>    3. In matplotlib switch mpl_toolkits to be a regular package but ship\n>    a shim for basemap in mpl_toolkits with matplotlib.\n>    4. Deprecate the shim raising warnings when in use (this can also be\n>    done much earlier)\n>    5. Several releases of matplotlib in the future (multiple years,\n>    perhaps never) remove the shim\n>\n> My main concern with this approach is what happens at upgrade time but on\n> the other hand namespace packages as they currently are tend to result in\n> upgrade issues anyway\n>\n> We also need to handle natgrid but that is only uses internally in\n> matplotlib so it should be simple enough to handle or perhaps just remove.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/matplotlib/matplotlib/issues/5327#issuecomment-252959880>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AB1cd4FYVsjTqyFu8PrDKIB-zSyMPI7Jks5qy7E-gaJpZM4GV8sd>\n> .\n>\n"}}
{"actor":{"display_login":"citibeth"}}