{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/comments/56847757","id":56847757,"diff_hunk":"@@ -41,16 +41,15 @@ mca_coll_basic_neighbor_allgatherv_cart(const void *sbuf, int scount, struct omp\n                                         struct ompi_datatype_t *rdtype, struct ompi_communicator_t *comm,\n                                         mca_coll_base_module_t *module)\n {\n-    mca_coll_basic_module_t *basic_module = (mca_coll_basic_module_t *) module;\n     const mca_topo_base_comm_cart_2_2_0_t *cart = comm->c_topo->mtc.cart;\n     const int rank = ompi_comm_rank (comm);\n-    ompi_request_t **reqs;\n+    ompi_request_t **reqs, **preqs;\n     ptrdiff_t lb, extent;\n     int rc = MPI_SUCCESS, dim, i, nreqs;\n \n     ompi_datatype_get_extent(rdtype, &lb, &extent);\n \n-    reqs = basic_module->mccb_reqs;\n+    reqs = preqs = coll_base_comm_get_reqs( module->base_data, 4 * cart->ndims);","path":"ompi/mca/coll/basic/coll_basic_neighbor_allgatherv.c","position":24,"original_position":24,"commit_id":"e39b9b997aac50e4102461450843d1d13990d6b2","original_commit_id":"e39b9b997aac50e4102461450843d1d13990d6b2","user":{"login":"derbeyn","id":17765844,"avatar_url":"https://avatars.githubusercontent.com/u/17765844?v=3","gravatar_id":"","url":"https://api.github.com/users/derbeyn","html_url":"https://github.com/derbeyn","followers_url":"https://api.github.com/users/derbeyn/followers","following_url":"https://api.github.com/users/derbeyn/following{/other_user}","gists_url":"https://api.github.com/users/derbeyn/gists{/gist_id}","starred_url":"https://api.github.com/users/derbeyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derbeyn/subscriptions","organizations_url":"https://api.github.com/users/derbeyn/orgs","repos_url":"https://api.github.com/users/derbeyn/repos","events_url":"https://api.github.com/users/derbeyn/events{/privacy}","received_events_url":"https://api.github.com/users/derbeyn/received_events","type":"User","site_admin":false},"body":"@bosilca Missing check on the pointer returned by coll_base_comm_get_reqs()\r\n","created_at":"2016-03-21T16:03:04Z","updated_at":"2016-03-21T16:03:04Z","html_url":"https://github.com/open-mpi/ompi-release/pull/1015#discussion_r56847757","pull_request_url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/comments/56847757"},"html":{"href":"https://github.com/open-mpi/ompi-release/pull/1015#discussion_r56847757"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015","id":62402566,"html_url":"https://github.com/open-mpi/ompi-release/pull/1015","diff_url":"https://github.com/open-mpi/ompi-release/pull/1015.diff","patch_url":"https://github.com/open-mpi/ompi-release/pull/1015.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/1015","number":1015,"state":"open","locked":false,"title":"Fix a segfault occuring in IMB Alltoall if tuned is unselected","user":{"login":"derbeyn","id":17765844,"avatar_url":"https://avatars.githubusercontent.com/u/17765844?v=3","gravatar_id":"","url":"https://api.github.com/users/derbeyn","html_url":"https://github.com/derbeyn","followers_url":"https://api.github.com/users/derbeyn/followers","following_url":"https://api.github.com/users/derbeyn/following{/other_user}","gists_url":"https://api.github.com/users/derbeyn/gists{/gist_id}","starred_url":"https://api.github.com/users/derbeyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derbeyn/subscriptions","organizations_url":"https://api.github.com/users/derbeyn/orgs","repos_url":"https://api.github.com/users/derbeyn/repos","events_url":"https://api.github.com/users/derbeyn/events{/privacy}","received_events_url":"https://api.github.com/users/derbeyn/received_events","type":"User","site_admin":false},"body":"If tuned is unselected, it's up to the basic module to handle the collectives.\r\nThe problem is that the request arrays are not consistently used in that module.\r\nCherry picking three commits fixes the issue.","created_at":"2016-03-10T15:05:15Z","updated_at":"2016-03-21T16:03:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c6d1b048843731250ab9af531a6ef16e1790526","assignee":null,"milestone":{"url":"https://api.github.com/repos/open-mpi/ompi-release/milestones/7","html_url":"https://github.com/open-mpi/ompi-release/milestones/v2.0.0","labels_url":"https://api.github.com/repos/open-mpi/ompi-release/milestones/7/labels","id":1136176,"number":7,"title":"v2.0.0","description":"","creator":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":407,"state":"open","created_at":"2015-05-27T14:23:44Z","updated_at":"2016-03-20T17:48:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/1015/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi-release/statuses/e39b9b997aac50e4102461450843d1d13990d6b2","head":{"label":"derbeyn:coll_pr","ref":"coll_pr","sha":"e39b9b997aac50e4102461450843d1d13990d6b2","user":{"login":"derbeyn","id":17765844,"avatar_url":"https://avatars.githubusercontent.com/u/17765844?v=3","gravatar_id":"","url":"https://api.github.com/users/derbeyn","html_url":"https://github.com/derbeyn","followers_url":"https://api.github.com/users/derbeyn/followers","following_url":"https://api.github.com/users/derbeyn/following{/other_user}","gists_url":"https://api.github.com/users/derbeyn/gists{/gist_id}","starred_url":"https://api.github.com/users/derbeyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derbeyn/subscriptions","organizations_url":"https://api.github.com/users/derbeyn/orgs","repos_url":"https://api.github.com/users/derbeyn/repos","events_url":"https://api.github.com/users/derbeyn/events{/privacy}","received_events_url":"https://api.github.com/users/derbeyn/received_events","type":"User","site_admin":false},"repo":{"id":53590802,"name":"ompi-release","full_name":"derbeyn/ompi-release","owner":{"login":"derbeyn","id":17765844,"avatar_url":"https://avatars.githubusercontent.com/u/17765844?v=3","gravatar_id":"","url":"https://api.github.com/users/derbeyn","html_url":"https://github.com/derbeyn","followers_url":"https://api.github.com/users/derbeyn/followers","following_url":"https://api.github.com/users/derbeyn/following{/other_user}","gists_url":"https://api.github.com/users/derbeyn/gists{/gist_id}","starred_url":"https://api.github.com/users/derbeyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derbeyn/subscriptions","organizations_url":"https://api.github.com/users/derbeyn/orgs","repos_url":"https://api.github.com/users/derbeyn/repos","events_url":"https://api.github.com/users/derbeyn/events{/privacy}","received_events_url":"https://api.github.com/users/derbeyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derbeyn/ompi-release","description":"Open MPI official release branches","fork":true,"url":"https://api.github.com/repos/derbeyn/ompi-release","forks_url":"https://api.github.com/repos/derbeyn/ompi-release/forks","keys_url":"https://api.github.com/repos/derbeyn/ompi-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derbeyn/ompi-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derbeyn/ompi-release/teams","hooks_url":"https://api.github.com/repos/derbeyn/ompi-release/hooks","issue_events_url":"https://api.github.com/repos/derbeyn/ompi-release/issues/events{/number}","events_url":"https://api.github.com/repos/derbeyn/ompi-release/events","assignees_url":"https://api.github.com/repos/derbeyn/ompi-release/assignees{/user}","branches_url":"https://api.github.com/repos/derbeyn/ompi-release/branches{/branch}","tags_url":"https://api.github.com/repos/derbeyn/ompi-release/tags","blobs_url":"https://api.github.com/repos/derbeyn/ompi-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derbeyn/ompi-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derbeyn/ompi-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/derbeyn/ompi-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derbeyn/ompi-release/statuses/{sha}","languages_url":"https://api.github.com/repos/derbeyn/ompi-release/languages","stargazers_url":"https://api.github.com/repos/derbeyn/ompi-release/stargazers","contributors_url":"https://api.github.com/repos/derbeyn/ompi-release/contributors","subscribers_url":"https://api.github.com/repos/derbeyn/ompi-release/subscribers","subscription_url":"https://api.github.com/repos/derbeyn/ompi-release/subscription","commits_url":"https://api.github.com/repos/derbeyn/ompi-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/derbeyn/ompi-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/derbeyn/ompi-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/derbeyn/ompi-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/derbeyn/ompi-release/contents/{+path}","compare_url":"https://api.github.com/repos/derbeyn/ompi-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derbeyn/ompi-release/merges","archive_url":"https://api.github.com/repos/derbeyn/ompi-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derbeyn/ompi-release/downloads","issues_url":"https://api.github.com/repos/derbeyn/ompi-release/issues{/number}","pulls_url":"https://api.github.com/repos/derbeyn/ompi-release/pulls{/number}","milestones_url":"https://api.github.com/repos/derbeyn/ompi-release/milestones{/number}","notifications_url":"https://api.github.com/repos/derbeyn/ompi-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derbeyn/ompi-release/labels{/name}","releases_url":"https://api.github.com/repos/derbeyn/ompi-release/releases{/id}","deployments_url":"https://api.github.com/repos/derbeyn/ompi-release/deployments","created_at":"2016-03-10T14:28:11Z","updated_at":"2016-03-10T14:28:30Z","pushed_at":"2016-03-10T14:44:31Z","git_url":"git://github.com/derbeyn/ompi-release.git","ssh_url":"git@github.com:derbeyn/ompi-release.git","clone_url":"https://github.com/derbeyn/ompi-release.git","svn_url":"https://github.com/derbeyn/ompi-release","homepage":null,"size":87431,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.10"}},"base":{"label":"open-mpi:v2.x","ref":"v2.x","sha":"98ac7a8a3ba656dd574a346a63e859ac331c86ac","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107214,"name":"ompi-release","full_name":"open-mpi/ompi-release","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi-release","description":"Open MPI official release branches","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi-release","forks_url":"https://api.github.com/repos/open-mpi/ompi-release/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi-release/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi-release/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi-release/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi-release/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi-release/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi-release/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi-release/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi-release/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi-release/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi-release/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi-release/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi-release/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi-release/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi-release/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi-release/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi-release/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi-release/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi-release/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi-release/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi-release/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi-release/deployments","created_at":"2014-09-16T16:12:46Z","updated_at":"2016-03-04T15:20:40Z","pushed_at":"2016-03-20T17:48:17Z","git_url":"git://github.com/open-mpi/ompi-release.git","ssh_url":"git@github.com:open-mpi/ompi-release.git","clone_url":"https://github.com/open-mpi/ompi-release.git","svn_url":"https://github.com/open-mpi/ompi-release","homepage":null,"size":103757,"stargazers_count":38,"watchers_count":38,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":26,"forks":72,"open_issues":26,"watchers":38,"default_branch":"v1.10"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015"},"html":{"href":"https://github.com/open-mpi/ompi-release/pull/1015"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi-release/issues/1015"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi-release/issues/1015/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi-release/pulls/1015/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi-release/statuses/e39b9b997aac50e4102461450843d1d13990d6b2"}}}}