{"action":"opened","number":239,"pull_request":{"url":"https://api.github.com/repos/yeoman/generator-node/pulls/239","id":78435639,"html_url":"https://github.com/yeoman/generator-node/pull/239","diff_url":"https://github.com/yeoman/generator-node/pull/239.diff","patch_url":"https://github.com/yeoman/generator-node/pull/239.patch","issue_url":"https://api.github.com/repos/yeoman/generator-node/issues/239","number":239,"state":"open","locked":false,"title":"Fix errors caused on Windows due to path.join","user":{"login":"aardmark","id":322919,"avatar_url":"https://avatars.githubusercontent.com/u/322919?v=3","gravatar_id":"","url":"https://api.github.com/users/aardmark","html_url":"https://github.com/aardmark","followers_url":"https://api.github.com/users/aardmark/followers","following_url":"https://api.github.com/users/aardmark/following{/other_user}","gists_url":"https://api.github.com/users/aardmark/gists{/gist_id}","starred_url":"https://api.github.com/users/aardmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardmark/subscriptions","organizations_url":"https://api.github.com/users/aardmark/orgs","repos_url":"https://api.github.com/users/aardmark/repos","events_url":"https://api.github.com/users/aardmark/events{/privacy}","received_events_url":"https://api.github.com/users/aardmark/received_events","type":"User","site_admin":false},"body":"On Windows there are some tests that fail and some of the generated code is wrong due to path.join converting forward slashes to backslashes on Windows.\r\n\r\nFor example (from the generator's test suite): \r\n\r\n```\r\n  1) node:app --no-babel include the raw files:\r\n\r\n      AssertionError: 'lib\\\\index.js' == 'lib/index.js'\r\n      + expected - actual\r\n\r\n      -lib\\index.js\r\n      +lib/index.js\r\n```\r\nAnd (from the generated gulpfile). Note the backslashes in the path:\r\n\r\n```js\r\ngulp.task('pre-test', function () {\r\n  return gulp.src('lib\\**\\*.js')\r\n    .pipe(excludeGitignore())\r\n    .pipe(istanbul({\r\n      includeUntested: true,\r\n      instrumenter: isparta.Instrumenter\r\n    }))\r\n    .pipe(istanbul.hookRequire());\r\n});\r\n```\r\n","created_at":"2016-07-22T07:34:46Z","updated_at":"2016-07-22T07:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"971f97df3bad1009cd999901ff65c0b9b571f453","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yeoman/generator-node/pulls/239/commits","review_comments_url":"https://api.github.com/repos/yeoman/generator-node/pulls/239/comments","review_comment_url":"https://api.github.com/repos/yeoman/generator-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeoman/generator-node/issues/239/comments","statuses_url":"https://api.github.com/repos/yeoman/generator-node/statuses/44f40f07de3c2f2b2d8535adaa4f5ef45c166799","head":{"label":"aardmark:windows-fixes","ref":"windows-fixes","sha":"44f40f07de3c2f2b2d8535adaa4f5ef45c166799","user":{"login":"aardmark","id":322919,"avatar_url":"https://avatars.githubusercontent.com/u/322919?v=3","gravatar_id":"","url":"https://api.github.com/users/aardmark","html_url":"https://github.com/aardmark","followers_url":"https://api.github.com/users/aardmark/followers","following_url":"https://api.github.com/users/aardmark/following{/other_user}","gists_url":"https://api.github.com/users/aardmark/gists{/gist_id}","starred_url":"https://api.github.com/users/aardmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardmark/subscriptions","organizations_url":"https://api.github.com/users/aardmark/orgs","repos_url":"https://api.github.com/users/aardmark/repos","events_url":"https://api.github.com/users/aardmark/events{/privacy}","received_events_url":"https://api.github.com/users/aardmark/received_events","type":"User","site_admin":false},"repo":{"id":63742833,"name":"generator-node","full_name":"aardmark/generator-node","owner":{"login":"aardmark","id":322919,"avatar_url":"https://avatars.githubusercontent.com/u/322919?v=3","gravatar_id":"","url":"https://api.github.com/users/aardmark","html_url":"https://github.com/aardmark","followers_url":"https://api.github.com/users/aardmark/followers","following_url":"https://api.github.com/users/aardmark/following{/other_user}","gists_url":"https://api.github.com/users/aardmark/gists{/gist_id}","starred_url":"https://api.github.com/users/aardmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardmark/subscriptions","organizations_url":"https://api.github.com/users/aardmark/orgs","repos_url":"https://api.github.com/users/aardmark/repos","events_url":"https://api.github.com/users/aardmark/events{/privacy}","received_events_url":"https://api.github.com/users/aardmark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aardmark/generator-node","description":"Create a Node.js module","fork":true,"url":"https://api.github.com/repos/aardmark/generator-node","forks_url":"https://api.github.com/repos/aardmark/generator-node/forks","keys_url":"https://api.github.com/repos/aardmark/generator-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aardmark/generator-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aardmark/generator-node/teams","hooks_url":"https://api.github.com/repos/aardmark/generator-node/hooks","issue_events_url":"https://api.github.com/repos/aardmark/generator-node/issues/events{/number}","events_url":"https://api.github.com/repos/aardmark/generator-node/events","assignees_url":"https://api.github.com/repos/aardmark/generator-node/assignees{/user}","branches_url":"https://api.github.com/repos/aardmark/generator-node/branches{/branch}","tags_url":"https://api.github.com/repos/aardmark/generator-node/tags","blobs_url":"https://api.github.com/repos/aardmark/generator-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aardmark/generator-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aardmark/generator-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/aardmark/generator-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aardmark/generator-node/statuses/{sha}","languages_url":"https://api.github.com/repos/aardmark/generator-node/languages","stargazers_url":"https://api.github.com/repos/aardmark/generator-node/stargazers","contributors_url":"https://api.github.com/repos/aardmark/generator-node/contributors","subscribers_url":"https://api.github.com/repos/aardmark/generator-node/subscribers","subscription_url":"https://api.github.com/repos/aardmark/generator-node/subscription","commits_url":"https://api.github.com/repos/aardmark/generator-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/aardmark/generator-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/aardmark/generator-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/aardmark/generator-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/aardmark/generator-node/contents/{+path}","compare_url":"https://api.github.com/repos/aardmark/generator-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aardmark/generator-node/merges","archive_url":"https://api.github.com/repos/aardmark/generator-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aardmark/generator-node/downloads","issues_url":"https://api.github.com/repos/aardmark/generator-node/issues{/number}","pulls_url":"https://api.github.com/repos/aardmark/generator-node/pulls{/number}","milestones_url":"https://api.github.com/repos/aardmark/generator-node/milestones{/number}","notifications_url":"https://api.github.com/repos/aardmark/generator-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aardmark/generator-node/labels{/name}","releases_url":"https://api.github.com/repos/aardmark/generator-node/releases{/id}","deployments_url":"https://api.github.com/repos/aardmark/generator-node/deployments","created_at":"2016-07-20T02:17:03Z","updated_at":"2016-07-20T02:17:05Z","pushed_at":"2016-07-22T06:55:28Z","git_url":"git://github.com/aardmark/generator-node.git","ssh_url":"git@github.com:aardmark/generator-node.git","clone_url":"https://github.com/aardmark/generator-node.git","svn_url":"https://github.com/aardmark/generator-node","homepage":"http://yeoman.io","size":296,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeoman:master","ref":"master","sha":"2f038c9303c71caf67615c02a1835e6f4d8d1fcd","user":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"repo":{"id":10081651,"name":"generator-node","full_name":"yeoman/generator-node","owner":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yeoman/generator-node","description":"Create a Node.js module","fork":false,"url":"https://api.github.com/repos/yeoman/generator-node","forks_url":"https://api.github.com/repos/yeoman/generator-node/forks","keys_url":"https://api.github.com/repos/yeoman/generator-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeoman/generator-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeoman/generator-node/teams","hooks_url":"https://api.github.com/repos/yeoman/generator-node/hooks","issue_events_url":"https://api.github.com/repos/yeoman/generator-node/issues/events{/number}","events_url":"https://api.github.com/repos/yeoman/generator-node/events","assignees_url":"https://api.github.com/repos/yeoman/generator-node/assignees{/user}","branches_url":"https://api.github.com/repos/yeoman/generator-node/branches{/branch}","tags_url":"https://api.github.com/repos/yeoman/generator-node/tags","blobs_url":"https://api.github.com/repos/yeoman/generator-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeoman/generator-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeoman/generator-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeoman/generator-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeoman/generator-node/statuses/{sha}","languages_url":"https://api.github.com/repos/yeoman/generator-node/languages","stargazers_url":"https://api.github.com/repos/yeoman/generator-node/stargazers","contributors_url":"https://api.github.com/repos/yeoman/generator-node/contributors","subscribers_url":"https://api.github.com/repos/yeoman/generator-node/subscribers","subscription_url":"https://api.github.com/repos/yeoman/generator-node/subscription","commits_url":"https://api.github.com/repos/yeoman/generator-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeoman/generator-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeoman/generator-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeoman/generator-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeoman/generator-node/contents/{+path}","compare_url":"https://api.github.com/repos/yeoman/generator-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeoman/generator-node/merges","archive_url":"https://api.github.com/repos/yeoman/generator-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeoman/generator-node/downloads","issues_url":"https://api.github.com/repos/yeoman/generator-node/issues{/number}","pulls_url":"https://api.github.com/repos/yeoman/generator-node/pulls{/number}","milestones_url":"https://api.github.com/repos/yeoman/generator-node/milestones{/number}","notifications_url":"https://api.github.com/repos/yeoman/generator-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeoman/generator-node/labels{/name}","releases_url":"https://api.github.com/repos/yeoman/generator-node/releases{/id}","deployments_url":"https://api.github.com/repos/yeoman/generator-node/deployments","created_at":"2013-05-15T15:15:10Z","updated_at":"2016-07-18T13:44:31Z","pushed_at":"2016-07-22T07:34:46Z","git_url":"git://github.com/yeoman/generator-node.git","ssh_url":"git@github.com:yeoman/generator-node.git","clone_url":"https://github.com/yeoman/generator-node.git","svn_url":"https://github.com/yeoman/generator-node","homepage":"http://yeoman.io","size":356,"stargazers_count":344,"watchers_count":344,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":15,"forks":114,"open_issues":15,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/239"},"html":{"href":"https://github.com/yeoman/generator-node/pull/239"},"issue":{"href":"https://api.github.com/repos/yeoman/generator-node/issues/239"},"comments":{"href":"https://api.github.com/repos/yeoman/generator-node/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/yeoman/generator-node/statuses/44f40f07de3c2f2b2d8535adaa4f5ef45c166799"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"aardmark"}}