{"action":"created","comment":{"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/comments/70585971","id":70585971,"diff_hunk":"@@ -0,0 +1,102 @@\n+<?php","path":"src/Kunstmaan/AdminBundle/Twig/MultiDomainAdminTwigExtension.php","position":1,"original_position":1,"commit_id":"353e9f1221321150d70998050c678872617ccc5e","original_commit_id":"353e9f1221321150d70998050c678872617ccc5e","user":{"login":"sandergo90","id":1516413,"avatar_url":"https://avatars.githubusercontent.com/u/1516413?v=3","gravatar_id":"","url":"https://api.github.com/users/sandergo90","html_url":"https://github.com/sandergo90","followers_url":"https://api.github.com/users/sandergo90/followers","following_url":"https://api.github.com/users/sandergo90/following{/other_user}","gists_url":"https://api.github.com/users/sandergo90/gists{/gist_id}","starred_url":"https://api.github.com/users/sandergo90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandergo90/subscriptions","organizations_url":"https://api.github.com/users/sandergo90/orgs","repos_url":"https://api.github.com/users/sandergo90/repos","events_url":"https://api.github.com/users/sandergo90/events{/privacy}","received_events_url":"https://api.github.com/users/sandergo90/received_events","type":"User","site_admin":false},"body":"I think the name should stay this way. It's an extension for the AdminBundle with functionality for the multidomain.","created_at":"2016-07-13T08:43:23Z","updated_at":"2016-07-13T08:43:23Z","html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225#discussion_r70585971","pull_request_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225","_links":{"self":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/comments/70585971"},"html":{"href":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225#discussion_r70585971"},"pull_request":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225"}}},"pull_request":{"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225","id":75986821,"html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225","diff_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225.diff","patch_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225.patch","issue_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1225","number":1225,"state":"open","locked":false,"title":"[AllBundles] URLChooser major changes","user":{"login":"sandergo90","id":1516413,"avatar_url":"https://avatars.githubusercontent.com/u/1516413?v=3","gravatar_id":"","url":"https://api.github.com/users/sandergo90","html_url":"https://github.com/sandergo90","followers_url":"https://api.github.com/users/sandergo90/followers","following_url":"https://api.github.com/users/sandergo90/following{/other_user}","gists_url":"https://api.github.com/users/sandergo90/gists{/gist_id}","starred_url":"https://api.github.com/users/sandergo90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandergo90/subscriptions","organizations_url":"https://api.github.com/users/sandergo90/orgs","repos_url":"https://api.github.com/users/sandergo90/repos","events_url":"https://api.github.com/users/sandergo90/events{/privacy}","received_events_url":"https://api.github.com/users/sandergo90/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Fixed tickets |\r\n\r\n## URL Chooser\r\n\r\nThe URLChooserType had been rewritten.\r\n\r\nYou now have the option to add the following type of links:\r\n\r\n- Internal\r\n- External (external links or for example anchors)\r\n- Email (mailto: will be automatically added)\r\n\r\nWe have added this rewrite especially for the MultiDomainBundle but it's completely integrated in the KunstmaanBundlesCMS.\r\n\r\nWhen you choose for an internal link type, you will need to choose a link in the menu tree. On a multidomain website, you can switch you're domain on the right site of the URL chooser.\r\n\r\nWhen clicking a node in the left node tree, a token is generated and saved for the URL. \r\n\r\n##For example: in a single domain website##\r\n\r\nSelecting the node in the tree with node translation id 50, will generate a token like \"[NT50]\".\r\n\r\n##For example: in a multi domain website##\r\n\r\nSelecting the node in the tree with node translation id 50, on domain \"my_domain_en\" will generate a token like \"[my_domain_en:NT50]\".\r\n\r\n\r\n##MAJOR CHANGE##\r\n\r\nFor the new URL chooser to work, we have added a new twig filter \"replace_url\". This filter needs to be used to generate the correct url automatically.\r\n\r\nWhen creating a new pagePart with an url field, the twig filter is automatically being added. \r\n\r\nOn all the exiting pageParts with an URLChooser field, you need to change the twig files of the pagePart and pipe all URL's to the replace_url filter.\r\n\r\nWhen adding a rich text field or a wysiwyg field, you will need to pipe the output of this field also to the replace_url filter. Hereby, all URL's chosen in the wysiwyg will also be replaced correctly.\r\n","created_at":"2016-07-01T14:18:55Z","updated_at":"2016-07-13T08:43:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f671274be7ddd9c04b0b2fe1549801b403fb1d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225/commits","review_comments_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225/comments","review_comment_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1225/comments","statuses_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/statuses/353e9f1221321150d70998050c678872617ccc5e","head":{"label":"sandergo90:urlchooserMultidomain","ref":"urlchooserMultidomain","sha":"353e9f1221321150d70998050c678872617ccc5e","user":{"login":"sandergo90","id":1516413,"avatar_url":"https://avatars.githubusercontent.com/u/1516413?v=3","gravatar_id":"","url":"https://api.github.com/users/sandergo90","html_url":"https://github.com/sandergo90","followers_url":"https://api.github.com/users/sandergo90/followers","following_url":"https://api.github.com/users/sandergo90/following{/other_user}","gists_url":"https://api.github.com/users/sandergo90/gists{/gist_id}","starred_url":"https://api.github.com/users/sandergo90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandergo90/subscriptions","organizations_url":"https://api.github.com/users/sandergo90/orgs","repos_url":"https://api.github.com/users/sandergo90/repos","events_url":"https://api.github.com/users/sandergo90/events{/privacy}","received_events_url":"https://api.github.com/users/sandergo90/received_events","type":"User","site_admin":false},"repo":{"id":49947119,"name":"KunstmaanBundlesCMS","full_name":"sandergo90/KunstmaanBundlesCMS","owner":{"login":"sandergo90","id":1516413,"avatar_url":"https://avatars.githubusercontent.com/u/1516413?v=3","gravatar_id":"","url":"https://api.github.com/users/sandergo90","html_url":"https://github.com/sandergo90","followers_url":"https://api.github.com/users/sandergo90/followers","following_url":"https://api.github.com/users/sandergo90/following{/other_user}","gists_url":"https://api.github.com/users/sandergo90/gists{/gist_id}","starred_url":"https://api.github.com/users/sandergo90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandergo90/subscriptions","organizations_url":"https://api.github.com/users/sandergo90/orgs","repos_url":"https://api.github.com/users/sandergo90/repos","events_url":"https://api.github.com/users/sandergo90/events{/privacy}","received_events_url":"https://api.github.com/users/sandergo90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandergo90/KunstmaanBundlesCMS","description":"An advanced yet user-friendly content management system, based on the full stack Symfony2 framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.","fork":true,"url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS","forks_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/forks","keys_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/teams","hooks_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/hooks","issue_events_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/issues/events{/number}","events_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/events","assignees_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/assignees{/user}","branches_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/branches{/branch}","tags_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/tags","blobs_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/statuses/{sha}","languages_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/languages","stargazers_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/stargazers","contributors_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/contributors","subscribers_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/subscribers","subscription_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/subscription","commits_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/contents/{+path}","compare_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/merges","archive_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/downloads","issues_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/issues{/number}","pulls_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/pulls{/number}","milestones_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/milestones{/number}","notifications_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/labels{/name}","releases_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/releases{/id}","deployments_url":"https://api.github.com/repos/sandergo90/KunstmaanBundlesCMS/deployments","created_at":"2016-01-19T11:06:41Z","updated_at":"2016-01-19T11:06:45Z","pushed_at":"2016-07-13T08:40:35Z","git_url":"git://github.com/sandergo90/KunstmaanBundlesCMS.git","ssh_url":"git@github.com:sandergo90/KunstmaanBundlesCMS.git","clone_url":"https://github.com/sandergo90/KunstmaanBundlesCMS.git","svn_url":"https://github.com/sandergo90/KunstmaanBundlesCMS","homepage":"https://bundles.kunstmaan.be","size":40703,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kunstmaan:sf3","ref":"sf3","sha":"f6ed373d68f2d17706a36ea250123f0d794590e9","user":{"login":"Kunstmaan","id":441259,"avatar_url":"https://avatars.githubusercontent.com/u/441259?v=3","gravatar_id":"","url":"https://api.github.com/users/Kunstmaan","html_url":"https://github.com/Kunstmaan","followers_url":"https://api.github.com/users/Kunstmaan/followers","following_url":"https://api.github.com/users/Kunstmaan/following{/other_user}","gists_url":"https://api.github.com/users/Kunstmaan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kunstmaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kunstmaan/subscriptions","organizations_url":"https://api.github.com/users/Kunstmaan/orgs","repos_url":"https://api.github.com/users/Kunstmaan/repos","events_url":"https://api.github.com/users/Kunstmaan/events{/privacy}","received_events_url":"https://api.github.com/users/Kunstmaan/received_events","type":"Organization","site_admin":false},"repo":{"id":22946859,"name":"KunstmaanBundlesCMS","full_name":"Kunstmaan/KunstmaanBundlesCMS","owner":{"login":"Kunstmaan","id":441259,"avatar_url":"https://avatars.githubusercontent.com/u/441259?v=3","gravatar_id":"","url":"https://api.github.com/users/Kunstmaan","html_url":"https://github.com/Kunstmaan","followers_url":"https://api.github.com/users/Kunstmaan/followers","following_url":"https://api.github.com/users/Kunstmaan/following{/other_user}","gists_url":"https://api.github.com/users/Kunstmaan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kunstmaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kunstmaan/subscriptions","organizations_url":"https://api.github.com/users/Kunstmaan/orgs","repos_url":"https://api.github.com/users/Kunstmaan/repos","events_url":"https://api.github.com/users/Kunstmaan/events{/privacy}","received_events_url":"https://api.github.com/users/Kunstmaan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS","description":"An advanced yet user-friendly content management system, based on the full stack Symfony2 framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.","fork":false,"url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS","forks_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/forks","keys_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/teams","hooks_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/hooks","issue_events_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/events{/number}","events_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/events","assignees_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/assignees{/user}","branches_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/branches{/branch}","tags_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/tags","blobs_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/statuses/{sha}","languages_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/languages","stargazers_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/stargazers","contributors_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/contributors","subscribers_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/subscribers","subscription_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/subscription","commits_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/contents/{+path}","compare_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/merges","archive_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/downloads","issues_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues{/number}","pulls_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls{/number}","milestones_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/milestones{/number}","notifications_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/labels{/name}","releases_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/releases{/id}","deployments_url":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/deployments","created_at":"2014-08-14T08:32:55Z","updated_at":"2016-07-12T05:56:42Z","pushed_at":"2016-07-13T08:40:35Z","git_url":"git://github.com/Kunstmaan/KunstmaanBundlesCMS.git","ssh_url":"git@github.com:Kunstmaan/KunstmaanBundlesCMS.git","clone_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS.git","svn_url":"https://github.com/Kunstmaan/KunstmaanBundlesCMS","homepage":"https://bundles.kunstmaan.be","size":44562,"stargazers_count":161,"watchers_count":161,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":82,"forks":112,"open_issues":82,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225"},"html":{"href":"https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1225"},"issue":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1225"},"comments":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/issues/1225/comments"},"review_comments":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225/comments"},"review_comment":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/pulls/1225/commits"},"statuses":{"href":"https://api.github.com/repos/Kunstmaan/KunstmaanBundlesCMS/statuses/353e9f1221321150d70998050c678872617ccc5e"}}}}
{"actor":{"display_login":"sandergo90"}}