{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8072","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8072/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8072/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8072/events","html_url":"https://github.com/nodejs/node/pull/8072","id":170737513,"number":8072,"title":"url: make `url.format()` encode all occurrences of `#` in `search`","user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/url","name":"url","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-11T20:24:38Z","updated_at":"2016-08-18T17:28:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8072","html_url":"https://github.com/nodejs/node/pull/8072","diff_url":"https://github.com/nodejs/node/pull/8072.diff","patch_url":"https://github.com/nodejs/node/pull/8072.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nurl\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nThis fixes an error where the first occurrence of `#` in `search` parameter is URL encoded, and subsequent occurrences are not.\r\n\r\nAlso added a test for the case.\r\n\r\nFixes: #8064 "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/240795971","html_url":"https://github.com/nodejs/node/pull/8072#issuecomment-240795971","issue_url":"https://api.github.com/repos/nodejs/node/issues/8072","id":240795971,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T17:28:33Z","updated_at":"2016-08-18T17:28:33Z","body":"One more CI before landing: https://ci.nodejs.org/job/node-test-pull-request/3730/"}}
{"actor":{"display_login":"jasnell"}}