{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4696","repository_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4696/labels{/name}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4696/comments","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4696/events","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4696","id":184823477,"number":4696,"title":"Night Light Effects (partially functional)","user":{"login":"IntelOrca","id":1482259,"avatar_url":"https://avatars.githubusercontent.com/u/1482259?v=3","gravatar_id":"","url":"https://api.github.com/users/IntelOrca","html_url":"https://github.com/IntelOrca","followers_url":"https://api.github.com/users/IntelOrca/followers","following_url":"https://api.github.com/users/IntelOrca/following{/other_user}","gists_url":"https://api.github.com/users/IntelOrca/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelOrca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelOrca/subscriptions","organizations_url":"https://api.github.com/users/IntelOrca/orgs","repos_url":"https://api.github.com/users/IntelOrca/repos","events_url":"https://api.github.com/users/IntelOrca/events{/privacy}","received_events_url":"https://api.github.com/users/IntelOrca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T12:12:14Z","updated_at":"2016-10-24T16:35:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/4696","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4696","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4696.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4696.patch"},"body":"The light effects mod branch #3798 by @JeroenDStout has become quite out of date. I plan to properly implement it, but first I want to merge in what we have already, so that I can branch off develop again and rebase (currently rebasing this branch is too difficult, far too many commits).\r\n\r\nMost code that this is merging is protected by the `__ENABLE_LIGHTFX__` directive, so it should not make any difference until its time to enable it via a new pull request.\r\n\r\nI have isolated it as much as possible to lightfx.c."},"comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments/255793576","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/4696#issuecomment-255793576","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/4696","id":255793576,"user":{"login":"AaronVanGeffen","id":604665,"avatar_url":"https://avatars.githubusercontent.com/u/604665?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronVanGeffen","html_url":"https://github.com/AaronVanGeffen","followers_url":"https://api.github.com/users/AaronVanGeffen/followers","following_url":"https://api.github.com/users/AaronVanGeffen/following{/other_user}","gists_url":"https://api.github.com/users/AaronVanGeffen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronVanGeffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronVanGeffen/subscriptions","organizations_url":"https://api.github.com/users/AaronVanGeffen/orgs","repos_url":"https://api.github.com/users/AaronVanGeffen/repos","events_url":"https://api.github.com/users/AaronVanGeffen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronVanGeffen/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T16:35:02Z","updated_at":"2016-10-24T16:35:02Z","body":"Any particular reason to use underscores in the guard? As far as I'm aware, these are generally left for compiler-internal use. I mention this in particular because cmake isn't letting me define `__ENABLE_LIGHTFX__`, or at least not like it did with `STOUT_EXPANDED_RENDERING_LIGHT` before that."}}
{"actor":{"display_login":"AaronVanGeffen"}}