{"action":"opened","number":409,"pull_request":{"url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409","id":57533296,"html_url":"https://github.com/plainblack/Lacuna-Server-Open/pull/409","diff_url":"https://github.com/plainblack/Lacuna-Server-Open/pull/409.diff","patch_url":"https://github.com/plainblack/Lacuna-Server-Open/pull/409.patch","issue_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/409","number":409,"state":"open","locked":false,"title":"Captcha secure","user":{"login":"icydee","id":175633,"avatar_url":"https://avatars.githubusercontent.com/u/175633?v=3","gravatar_id":"","url":"https://api.github.com/users/icydee","html_url":"https://github.com/icydee","followers_url":"https://api.github.com/users/icydee/followers","following_url":"https://api.github.com/users/icydee/following{/other_user}","gists_url":"https://api.github.com/users/icydee/gists{/gist_id}","starred_url":"https://api.github.com/users/icydee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icydee/subscriptions","organizations_url":"https://api.github.com/users/icydee/orgs","repos_url":"https://api.github.com/users/icydee/repos","events_url":"https://api.github.com/users/icydee/events{/privacy}","received_events_url":"https://api.github.com/users/icydee/received_events","type":"User","site_admin":false},"body":"This branch does away with the initial generation of captchas. Instead, as each captcha is requested it creates a job on a queue to create a new one, the new one is supplied on the next request. This means every GUID and image is unique and never repeated. This prevents scripts 'remembering' either the guid or taking a hash of the image content.\r\n\r\nIn development mode (a new config setting) the captcha is always generated with an answer of '1'.\r\n\r\nCaptchas older than 1hr are purged from both the file-system and the database.\r\n\r\nThis has been tested in a docker container, both with and without 'develop_mode' so all code paths have been tested, however since there are no TTF images in a docker container this will need to be tested on the PT server to be sure.\r\n\r\nIn addition, schedule_buildings and schedule_ship_arrival scripts have had the automatic 1hr timeout removed. This is redundant, if a cron job is running to restart the scheduler then the old job will be stopped anyway, if not then the scheduler runs forever.","created_at":"2016-01-28T17:10:01Z","updated_at":"2016-01-28T17:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409/commits","review_comments_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409/comments","review_comment_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/409/comments","statuses_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/statuses/4b33d1c0d55329774c8130537aa56f23919dd0e9","head":{"label":"icydee:captcha-secure","ref":"captcha-secure","sha":"4b33d1c0d55329774c8130537aa56f23919dd0e9","user":{"login":"icydee","id":175633,"avatar_url":"https://avatars.githubusercontent.com/u/175633?v=3","gravatar_id":"","url":"https://api.github.com/users/icydee","html_url":"https://github.com/icydee","followers_url":"https://api.github.com/users/icydee/followers","following_url":"https://api.github.com/users/icydee/following{/other_user}","gists_url":"https://api.github.com/users/icydee/gists{/gist_id}","starred_url":"https://api.github.com/users/icydee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icydee/subscriptions","organizations_url":"https://api.github.com/users/icydee/orgs","repos_url":"https://api.github.com/users/icydee/repos","events_url":"https://api.github.com/users/icydee/events{/privacy}","received_events_url":"https://api.github.com/users/icydee/received_events","type":"User","site_admin":false},"repo":{"id":4909671,"name":"Lacuna-Server-Open","full_name":"icydee/Lacuna-Server-Open","owner":{"login":"icydee","id":175633,"avatar_url":"https://avatars.githubusercontent.com/u/175633?v=3","gravatar_id":"","url":"https://api.github.com/users/icydee","html_url":"https://github.com/icydee","followers_url":"https://api.github.com/users/icydee/followers","following_url":"https://api.github.com/users/icydee/following{/other_user}","gists_url":"https://api.github.com/users/icydee/gists{/gist_id}","starred_url":"https://api.github.com/users/icydee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icydee/subscriptions","organizations_url":"https://api.github.com/users/icydee/orgs","repos_url":"https://api.github.com/users/icydee/repos","events_url":"https://api.github.com/users/icydee/events{/privacy}","received_events_url":"https://api.github.com/users/icydee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icydee/Lacuna-Server-Open","description":"The open source Lacuna Server repository.","fork":true,"url":"https://api.github.com/repos/icydee/Lacuna-Server-Open","forks_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/forks","keys_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/teams","hooks_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/hooks","issue_events_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/issues/events{/number}","events_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/events","assignees_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/assignees{/user}","branches_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/branches{/branch}","tags_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/tags","blobs_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/git/refs{/sha}","trees_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/statuses/{sha}","languages_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/languages","stargazers_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/stargazers","contributors_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/contributors","subscribers_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/subscribers","subscription_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/subscription","commits_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/commits{/sha}","git_commits_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/git/commits{/sha}","comments_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/comments{/number}","issue_comment_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/issues/comments{/number}","contents_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/contents/{+path}","compare_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/merges","archive_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/downloads","issues_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/issues{/number}","pulls_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/pulls{/number}","milestones_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/milestones{/number}","notifications_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/labels{/name}","releases_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/releases{/id}","deployments_url":"https://api.github.com/repos/icydee/Lacuna-Server-Open/deployments","created_at":"2012-07-05T15:39:18Z","updated_at":"2014-09-09T03:08:35Z","pushed_at":"2016-01-28T16:57:27Z","git_url":"git://github.com/icydee/Lacuna-Server-Open.git","ssh_url":"git@github.com:icydee/Lacuna-Server-Open.git","clone_url":"https://github.com/icydee/Lacuna-Server-Open.git","svn_url":"https://github.com/icydee/Lacuna-Server-Open","homepage":null,"size":43559,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"plainblack:develop","ref":"develop","sha":"e4d89b0b1d965b58b967b8069349095e05b1cb97","user":{"login":"plainblack","id":52236,"avatar_url":"https://avatars.githubusercontent.com/u/52236?v=3","gravatar_id":"","url":"https://api.github.com/users/plainblack","html_url":"https://github.com/plainblack","followers_url":"https://api.github.com/users/plainblack/followers","following_url":"https://api.github.com/users/plainblack/following{/other_user}","gists_url":"https://api.github.com/users/plainblack/gists{/gist_id}","starred_url":"https://api.github.com/users/plainblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plainblack/subscriptions","organizations_url":"https://api.github.com/users/plainblack/orgs","repos_url":"https://api.github.com/users/plainblack/repos","events_url":"https://api.github.com/users/plainblack/events{/privacy}","received_events_url":"https://api.github.com/users/plainblack/received_events","type":"Organization","site_admin":false},"repo":{"id":4628948,"name":"Lacuna-Server-Open","full_name":"plainblack/Lacuna-Server-Open","owner":{"login":"plainblack","id":52236,"avatar_url":"https://avatars.githubusercontent.com/u/52236?v=3","gravatar_id":"","url":"https://api.github.com/users/plainblack","html_url":"https://github.com/plainblack","followers_url":"https://api.github.com/users/plainblack/followers","following_url":"https://api.github.com/users/plainblack/following{/other_user}","gists_url":"https://api.github.com/users/plainblack/gists{/gist_id}","starred_url":"https://api.github.com/users/plainblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plainblack/subscriptions","organizations_url":"https://api.github.com/users/plainblack/orgs","repos_url":"https://api.github.com/users/plainblack/repos","events_url":"https://api.github.com/users/plainblack/events{/privacy}","received_events_url":"https://api.github.com/users/plainblack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plainblack/Lacuna-Server-Open","description":"The open source Lacuna Server repository.","fork":false,"url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open","forks_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/forks","keys_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/teams","hooks_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/hooks","issue_events_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/events{/number}","events_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/events","assignees_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/assignees{/user}","branches_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/branches{/branch}","tags_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/tags","blobs_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/git/refs{/sha}","trees_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/statuses/{sha}","languages_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/languages","stargazers_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/stargazers","contributors_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/contributors","subscribers_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/subscribers","subscription_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/subscription","commits_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/commits{/sha}","git_commits_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/git/commits{/sha}","comments_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/comments{/number}","issue_comment_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/comments{/number}","contents_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/contents/{+path}","compare_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/merges","archive_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/downloads","issues_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues{/number}","pulls_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls{/number}","milestones_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/milestones{/number}","notifications_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/labels{/name}","releases_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/releases{/id}","deployments_url":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/deployments","created_at":"2012-06-11T19:05:21Z","updated_at":"2016-01-13T05:34:22Z","pushed_at":"2016-01-27T15:10:25Z","git_url":"git://github.com/plainblack/Lacuna-Server-Open.git","ssh_url":"git@github.com:plainblack/Lacuna-Server-Open.git","clone_url":"https://github.com/plainblack/Lacuna-Server-Open.git","svn_url":"https://github.com/plainblack/Lacuna-Server-Open","homepage":null,"size":45872,"stargazers_count":33,"watchers_count":33,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":67,"forks":21,"open_issues":67,"watchers":33,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409"},"html":{"href":"https://github.com/plainblack/Lacuna-Server-Open/pull/409"},"issue":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/409"},"comments":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/plainblack/Lacuna-Server-Open/statuses/4b33d1c0d55329774c8130537aa56f23919dd0e9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":570,"deletions":354,"changed_files":25}}