{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/52466275","id":52466275,"diff_hunk":"@@ -239,16 +239,12 @@ LibraryLoader* DllLoaderContainer::LoadDll(const char* sName, bool bLoadSymbols)\n \n   LibraryLoader* pLoader;\n #ifdef TARGET_POSIX\n-  if (strstr(sName, \".so\") != NULL || strstr(sName, \".vis\") != NULL || strstr(sName, \".xbs\") != NULL\n-      || strstr(sName, \".mvis\") != NULL || strstr(sName, \".dylib\") != NULL || strstr(sName, \".framework\") != NULL || strstr(sName, \".pvr\") != NULL)\n-    pLoader = new SoLoader(sName, bLoadSymbols);\n-  else\n+  pLoader = new SoLoader(sName, bLoadSymbols);\n #elif defined(TARGET_WINDOWS)\n-  if (1)\n-    pLoader = new Win32DllLoader(sName);\n-  else\n+  pLoader = new Win32DllLoader(sName);\n+#else\n+  pLoader = new DllLoader(sName, m_bTrack, false, bLoadSymbols);","path":"xbmc/cores/DllLoader/DllLoaderContainer.cpp","position":15,"original_position":15,"commit_id":"6d7969ea8df43aa698c61edb952ee9db120b0386","original_commit_id":"6d7969ea8df43aa698c61edb952ee9db120b0386","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"I was tempted to drop this branch but hesitated. Maybe in next round ","created_at":"2016-02-10T14:49:56Z","updated_at":"2016-02-10T14:49:56Z","html_url":"https://github.com/xbmc/xbmc/pull/9101#discussion_r52466275","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9101","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/52466275"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9101#discussion_r52466275"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9101"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9101","id":58894952,"html_url":"https://github.com/xbmc/xbmc/pull/9101","diff_url":"https://github.com/xbmc/xbmc/pull/9101.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9101.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9101","number":9101,"state":"open","locked":false,"title":"fix loading of shared libraries on POSIX systems","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"grrr\r\n\r\nIt took me hours to locate this hack. My lib was named after Linux convention something like bla.so.1.0.0 and DllLoader was chosen instead of SoLoader.\r\n@wsnipex pvr libs did only work by change because strstr found \"pvr\" in the middle of the library name.","created_at":"2016-02-10T14:10:57Z","updated_at":"2016-02-10T14:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76ee2c16a6549293b3a58179ce3a38c85b415890","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9101/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9101/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9101/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/6d7969ea8df43aa698c61edb952ee9db120b0386","head":{"label":"FernetMenta:dllload","ref":"dllload","sha":"6d7969ea8df43aa698c61edb952ee9db120b0386","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"repo":{"id":1278128,"name":"xbmc","full_name":"FernetMenta/xbmc","owner":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FernetMenta/xbmc","description":"Fork of  XBMC Main PVR Development Repository.","fork":true,"url":"https://api.github.com/repos/FernetMenta/xbmc","forks_url":"https://api.github.com/repos/FernetMenta/xbmc/forks","keys_url":"https://api.github.com/repos/FernetMenta/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FernetMenta/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FernetMenta/xbmc/teams","hooks_url":"https://api.github.com/repos/FernetMenta/xbmc/hooks","issue_events_url":"https://api.github.com/repos/FernetMenta/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/FernetMenta/xbmc/events","assignees_url":"https://api.github.com/repos/FernetMenta/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/FernetMenta/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/FernetMenta/xbmc/tags","blobs_url":"https://api.github.com/repos/FernetMenta/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FernetMenta/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FernetMenta/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/FernetMenta/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FernetMenta/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/FernetMenta/xbmc/languages","stargazers_url":"https://api.github.com/repos/FernetMenta/xbmc/stargazers","contributors_url":"https://api.github.com/repos/FernetMenta/xbmc/contributors","subscribers_url":"https://api.github.com/repos/FernetMenta/xbmc/subscribers","subscription_url":"https://api.github.com/repos/FernetMenta/xbmc/subscription","commits_url":"https://api.github.com/repos/FernetMenta/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/FernetMenta/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/FernetMenta/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/FernetMenta/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/FernetMenta/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/FernetMenta/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FernetMenta/xbmc/merges","archive_url":"https://api.github.com/repos/FernetMenta/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FernetMenta/xbmc/downloads","issues_url":"https://api.github.com/repos/FernetMenta/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/FernetMenta/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/FernetMenta/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/FernetMenta/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FernetMenta/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/FernetMenta/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/FernetMenta/xbmc/deployments","created_at":"2011-01-21T11:28:28Z","updated_at":"2016-01-28T19:37:38Z","pushed_at":"2016-02-10T14:13:39Z","git_url":"git://github.com/FernetMenta/xbmc.git","ssh_url":"git@github.com:FernetMenta/xbmc.git","clone_url":"https://github.com/FernetMenta/xbmc.git","svn_url":"https://github.com/FernetMenta/xbmc","homepage":"http://xbmc.org","size":552807,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":14,"forks":20,"open_issues":14,"watchers":59,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"8e70e63e432d750898d3ce1573c3d1f7f89f5407","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-02-10T03:27:46Z","pushed_at":"2016-02-10T14:13:40Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1717096,"stargazers_count":4486,"watchers_count":4486,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3313,"mirror_url":null,"open_issues_count":228,"forks":3313,"open_issues":228,"watchers":4486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9101"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9101"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9101"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9101/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9101/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9101/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/6d7969ea8df43aa698c61edb952ee9db120b0386"}}}}