{"action":"created","comment":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/92920148","pull_request_review_id":13445179,"id":92920148,"diff_hunk":"@@ -452,6 +538,14 @@ static void strength_callback(GtkWidget *slider, gpointer user_data)\n   dt_dev_add_history_item(darktable.develop, self, TRUE);\n }\n \n+static void midtones_bias_callback(GtkWidget *slider, gpointer user_data)\n+{\n+  dt_iop_module_t *self = (dt_iop_module_t *)user_data;\n+  if(self->dt->gui->reset) return;\n+  dt_iop_grain_params_t *p = (dt_iop_grain_params_t *)self->params;\n+  p->midtones_bias = dt_bauhaus_slider_get(slider);","path":"src/iop/grain.c","position":146,"original_position":146,"commit_id":"31a278b247f77453a5756c060cfe0c12ae292860","original_commit_id":"31a278b247f77453a5756c060cfe0c12ae292860","user":{"login":"houz","id":1624064,"avatar_url":"https://avatars.githubusercontent.com/u/1624064?v=3","gravatar_id":"","url":"https://api.github.com/users/houz","html_url":"https://github.com/houz","followers_url":"https://api.github.com/users/houz/followers","following_url":"https://api.github.com/users/houz/following{/other_user}","gists_url":"https://api.github.com/users/houz/gists{/gist_id}","starred_url":"https://api.github.com/users/houz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houz/subscriptions","organizations_url":"https://api.github.com/users/houz/orgs","repos_url":"https://api.github.com/users/houz/repos","events_url":"https://api.github.com/users/houz/events{/privacy}","received_events_url":"https://api.github.com/users/houz/received_events","type":"User","site_admin":false},"body":"The other GUI callbacks do the scaling of the slider values here already.","created_at":"2016-12-17T11:35:12Z","updated_at":"2016-12-17T11:39:06Z","html_url":"https://github.com/darktable-org/darktable/pull/1386#discussion_r92920148","pull_request_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1386","_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/92920148"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1386#discussion_r92920148"},"pull_request":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/1386","id":98113549,"html_url":"https://github.com/darktable-org/darktable/pull/1386","diff_url":"https://github.com/darktable-org/darktable/pull/1386.diff","patch_url":"https://github.com/darktable-org/darktable/pull/1386.patch","issue_url":"https://api.github.com/repos/darktable-org/darktable/issues/1386","number":1386,"state":"open","locked":false,"title":"Update grain.c: grain blending using photographic-paper response. Fixes #11335","user":{"login":"arctee","id":23696095,"avatar_url":"https://avatars.githubusercontent.com/u/23696095?v=3","gravatar_id":"","url":"https://api.github.com/users/arctee","html_url":"https://github.com/arctee","followers_url":"https://api.github.com/users/arctee/followers","following_url":"https://api.github.com/users/arctee/following{/other_user}","gists_url":"https://api.github.com/users/arctee/gists{/gist_id}","starred_url":"https://api.github.com/users/arctee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arctee/subscriptions","organizations_url":"https://api.github.com/users/arctee/orgs","repos_url":"https://api.github.com/users/arctee/repos","events_url":"https://api.github.com/users/arctee/events{/privacy}","received_events_url":"https://api.github.com/users/arctee/received_events","type":"User","site_admin":false},"body":"A sigmoidal function is used to model a the exposure-density characteristic curve of photographic paper, and the lightness channel is used to modulate the grain accordingly to the characteristic curve. A LUT is used for computational efficiency. The main effect is a fall off of the grain in shadows and highlights accompanied by the skewing of grain distribution (for further info see the discussion on discuss.pixls.us: https://discuss.pixls.us/t/lets-improve-grain/2709/22). A \"midtones bias\" slider has been added, at 0% the added grain is indistinguishable from the old implementation.","created_at":"2016-12-15T09:26:49Z","updated_at":"2016-12-17T11:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69ac3cb9bc8981d309c28dbec171b5a00ffeb7eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darktable-org/darktable/issues/1386/comments","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/31a278b247f77453a5756c060cfe0c12ae292860","head":{"label":"arctee:master","ref":"master","sha":"31a278b247f77453a5756c060cfe0c12ae292860","user":{"login":"arctee","id":23696095,"avatar_url":"https://avatars.githubusercontent.com/u/23696095?v=3","gravatar_id":"","url":"https://api.github.com/users/arctee","html_url":"https://github.com/arctee","followers_url":"https://api.github.com/users/arctee/followers","following_url":"https://api.github.com/users/arctee/following{/other_user}","gists_url":"https://api.github.com/users/arctee/gists{/gist_id}","starred_url":"https://api.github.com/users/arctee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arctee/subscriptions","organizations_url":"https://api.github.com/users/arctee/orgs","repos_url":"https://api.github.com/users/arctee/repos","events_url":"https://api.github.com/users/arctee/events{/privacy}","received_events_url":"https://api.github.com/users/arctee/received_events","type":"User","site_admin":false},"repo":{"id":76465650,"name":"darktable","full_name":"arctee/darktable","owner":{"login":"arctee","id":23696095,"avatar_url":"https://avatars.githubusercontent.com/u/23696095?v=3","gravatar_id":"","url":"https://api.github.com/users/arctee","html_url":"https://github.com/arctee","followers_url":"https://api.github.com/users/arctee/followers","following_url":"https://api.github.com/users/arctee/following{/other_user}","gists_url":"https://api.github.com/users/arctee/gists{/gist_id}","starred_url":"https://api.github.com/users/arctee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arctee/subscriptions","organizations_url":"https://api.github.com/users/arctee/orgs","repos_url":"https://api.github.com/users/arctee/repos","events_url":"https://api.github.com/users/arctee/events{/privacy}","received_events_url":"https://api.github.com/users/arctee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arctee/darktable","description":"darktable is an open source photography workflow application and raw developer","fork":true,"url":"https://api.github.com/repos/arctee/darktable","forks_url":"https://api.github.com/repos/arctee/darktable/forks","keys_url":"https://api.github.com/repos/arctee/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arctee/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arctee/darktable/teams","hooks_url":"https://api.github.com/repos/arctee/darktable/hooks","issue_events_url":"https://api.github.com/repos/arctee/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/arctee/darktable/events","assignees_url":"https://api.github.com/repos/arctee/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/arctee/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/arctee/darktable/tags","blobs_url":"https://api.github.com/repos/arctee/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arctee/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arctee/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/arctee/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arctee/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/arctee/darktable/languages","stargazers_url":"https://api.github.com/repos/arctee/darktable/stargazers","contributors_url":"https://api.github.com/repos/arctee/darktable/contributors","subscribers_url":"https://api.github.com/repos/arctee/darktable/subscribers","subscription_url":"https://api.github.com/repos/arctee/darktable/subscription","commits_url":"https://api.github.com/repos/arctee/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/arctee/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/arctee/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/arctee/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/arctee/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/arctee/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arctee/darktable/merges","archive_url":"https://api.github.com/repos/arctee/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arctee/darktable/downloads","issues_url":"https://api.github.com/repos/arctee/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/arctee/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/arctee/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/arctee/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arctee/darktable/labels{/name}","releases_url":"https://api.github.com/repos/arctee/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/arctee/darktable/deployments","created_at":"2016-12-14T14:15:44Z","updated_at":"2016-12-14T14:15:50Z","pushed_at":"2016-12-16T15:47:01Z","git_url":"git://github.com/arctee/darktable.git","ssh_url":"git@github.com:arctee/darktable.git","clone_url":"https://github.com/arctee/darktable.git","svn_url":"https://github.com/arctee/darktable","homepage":"https://www.darktable.org","size":234548,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darktable-org:master","ref":"master","sha":"2e2ff0679fb7c0ecbe7580122dff89d353cb5300","user":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"repo":{"id":3791835,"name":"darktable","full_name":"darktable-org/darktable","owner":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darktable-org/darktable","description":"darktable is an open source photography workflow application and raw developer","fork":false,"url":"https://api.github.com/repos/darktable-org/darktable","forks_url":"https://api.github.com/repos/darktable-org/darktable/forks","keys_url":"https://api.github.com/repos/darktable-org/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktable-org/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktable-org/darktable/teams","hooks_url":"https://api.github.com/repos/darktable-org/darktable/hooks","issue_events_url":"https://api.github.com/repos/darktable-org/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/darktable-org/darktable/events","assignees_url":"https://api.github.com/repos/darktable-org/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/darktable-org/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/darktable-org/darktable/tags","blobs_url":"https://api.github.com/repos/darktable-org/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktable-org/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktable-org/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktable-org/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/darktable-org/darktable/languages","stargazers_url":"https://api.github.com/repos/darktable-org/darktable/stargazers","contributors_url":"https://api.github.com/repos/darktable-org/darktable/contributors","subscribers_url":"https://api.github.com/repos/darktable-org/darktable/subscribers","subscription_url":"https://api.github.com/repos/darktable-org/darktable/subscription","commits_url":"https://api.github.com/repos/darktable-org/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktable-org/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktable-org/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktable-org/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/darktable-org/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/darktable-org/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktable-org/darktable/merges","archive_url":"https://api.github.com/repos/darktable-org/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktable-org/darktable/downloads","issues_url":"https://api.github.com/repos/darktable-org/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/darktable-org/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/darktable-org/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/darktable-org/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktable-org/darktable/labels{/name}","releases_url":"https://api.github.com/repos/darktable-org/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/darktable-org/darktable/deployments","created_at":"2012-03-21T21:53:04Z","updated_at":"2016-12-17T03:26:29Z","pushed_at":"2016-12-17T10:37:24Z","git_url":"git://github.com/darktable-org/darktable.git","ssh_url":"git@github.com:darktable-org/darktable.git","clone_url":"https://github.com/darktable-org/darktable.git","svn_url":"https://github.com/darktable-org/darktable","homepage":"https://www.darktable.org","size":234676,"stargazers_count":1066,"watchers_count":1066,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":24,"forks":339,"open_issues":24,"watchers":1066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1386"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1386"},"issue":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1386"},"comments":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/darktable-org/darktable/statuses/31a278b247f77453a5756c060cfe0c12ae292860"}}}}
{"actor":{"display_login":"houz"}}