{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/comments/67336328","id":67336328,"diff_hunk":"@@ -101,11 +101,6 @@ def map_sections(fun, nrn, neurite_type=NeuriteType.all):\n                 for s in i_chain2(nrn.neurites, tree_filter=is_type(neurite_type)))\n \n \n-def section_lengths(nrn, neurite_type=NeuriteType.all):\n-    '''section lengths'''\n-    return map_sections(mm.path_distance, nrn, neurite_type)","path":"neurom/fst/_mm.py","position":6,"original_position":6,"commit_id":"59dc97ed0e0f305e3d07c900ee32d16c2a948ba1","original_commit_id":"59dc97ed0e0f305e3d07c900ee32d16c2a948ba1","user":{"login":"lidakanari","id":14071443,"avatar_url":"https://avatars.githubusercontent.com/u/14071443?v=3","gravatar_id":"","url":"https://api.github.com/users/lidakanari","html_url":"https://github.com/lidakanari","followers_url":"https://api.github.com/users/lidakanari/followers","following_url":"https://api.github.com/users/lidakanari/following{/other_user}","gists_url":"https://api.github.com/users/lidakanari/gists{/gist_id}","starred_url":"https://api.github.com/users/lidakanari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lidakanari/subscriptions","organizations_url":"https://api.github.com/users/lidakanari/orgs","repos_url":"https://api.github.com/users/lidakanari/repos","events_url":"https://api.github.com/users/lidakanari/events{/privacy}","received_events_url":"https://api.github.com/users/lidakanari/received_events","type":"User","site_admin":false},"body":"OK, that is a better name for the section_length (=sum(length of segments in a section) indeed. However, that is not what path distance should be. The path distance is supposed to be the sum of all the segment lengths from a section to the root (so the section-length plus all its ancestors section-lengths). ","created_at":"2016-06-16T12:38:31Z","updated_at":"2016-06-16T12:38:31Z","html_url":"https://github.com/BlueBrain/NeuroM/pull/382#discussion_r67336328","pull_request_url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/comments/67336328"},"html":{"href":"https://github.com/BlueBrain/NeuroM/pull/382#discussion_r67336328"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382","id":74067709,"html_url":"https://github.com/BlueBrain/NeuroM/pull/382","diff_url":"https://github.com/BlueBrain/NeuroM/pull/382.diff","patch_url":"https://github.com/BlueBrain/NeuroM/pull/382.patch","issue_url":"https://api.github.com/repos/BlueBrain/NeuroM/issues/382","number":382,"state":"open","locked":false,"title":"Add section tortuosity feature to fst module.","user":{"login":"juanchopanza","id":675013,"avatar_url":"https://avatars.githubusercontent.com/u/675013?v=3","gravatar_id":"","url":"https://api.github.com/users/juanchopanza","html_url":"https://github.com/juanchopanza","followers_url":"https://api.github.com/users/juanchopanza/followers","following_url":"https://api.github.com/users/juanchopanza/following{/other_user}","gists_url":"https://api.github.com/users/juanchopanza/gists{/gist_id}","starred_url":"https://api.github.com/users/juanchopanza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanchopanza/subscriptions","organizations_url":"https://api.github.com/users/juanchopanza/orgs","repos_url":"https://api.github.com/users/juanchopanza/repos","events_url":"https://api.github.com/users/juanchopanza/events{/privacy}","received_events_url":"https://api.github.com/users/juanchopanza/received_events","type":"User","site_admin":false},"body":"Resolves #375.","created_at":"2016-06-16T11:56:51Z","updated_at":"2016-06-16T12:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6779e7513104e8ee09767aa20bedb1db66974d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/NeuroM/issues/382/comments","statuses_url":"https://api.github.com/repos/BlueBrain/NeuroM/statuses/59dc97ed0e0f305e3d07c900ee32d16c2a948ba1","head":{"label":"juanchopanza:section_tortuosity","ref":"section_tortuosity","sha":"59dc97ed0e0f305e3d07c900ee32d16c2a948ba1","user":{"login":"juanchopanza","id":675013,"avatar_url":"https://avatars.githubusercontent.com/u/675013?v=3","gravatar_id":"","url":"https://api.github.com/users/juanchopanza","html_url":"https://github.com/juanchopanza","followers_url":"https://api.github.com/users/juanchopanza/followers","following_url":"https://api.github.com/users/juanchopanza/following{/other_user}","gists_url":"https://api.github.com/users/juanchopanza/gists{/gist_id}","starred_url":"https://api.github.com/users/juanchopanza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanchopanza/subscriptions","organizations_url":"https://api.github.com/users/juanchopanza/orgs","repos_url":"https://api.github.com/users/juanchopanza/repos","events_url":"https://api.github.com/users/juanchopanza/events{/privacy}","received_events_url":"https://api.github.com/users/juanchopanza/received_events","type":"User","site_admin":false},"repo":{"id":40894014,"name":"NeuroM","full_name":"juanchopanza/NeuroM","owner":{"login":"juanchopanza","id":675013,"avatar_url":"https://avatars.githubusercontent.com/u/675013?v=3","gravatar_id":"","url":"https://api.github.com/users/juanchopanza","html_url":"https://github.com/juanchopanza","followers_url":"https://api.github.com/users/juanchopanza/followers","following_url":"https://api.github.com/users/juanchopanza/following{/other_user}","gists_url":"https://api.github.com/users/juanchopanza/gists{/gist_id}","starred_url":"https://api.github.com/users/juanchopanza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanchopanza/subscriptions","organizations_url":"https://api.github.com/users/juanchopanza/orgs","repos_url":"https://api.github.com/users/juanchopanza/repos","events_url":"https://api.github.com/users/juanchopanza/events{/privacy}","received_events_url":"https://api.github.com/users/juanchopanza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanchopanza/NeuroM","description":"Neuronal Morphology Analysis Tool","fork":true,"url":"https://api.github.com/repos/juanchopanza/NeuroM","forks_url":"https://api.github.com/repos/juanchopanza/NeuroM/forks","keys_url":"https://api.github.com/repos/juanchopanza/NeuroM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanchopanza/NeuroM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanchopanza/NeuroM/teams","hooks_url":"https://api.github.com/repos/juanchopanza/NeuroM/hooks","issue_events_url":"https://api.github.com/repos/juanchopanza/NeuroM/issues/events{/number}","events_url":"https://api.github.com/repos/juanchopanza/NeuroM/events","assignees_url":"https://api.github.com/repos/juanchopanza/NeuroM/assignees{/user}","branches_url":"https://api.github.com/repos/juanchopanza/NeuroM/branches{/branch}","tags_url":"https://api.github.com/repos/juanchopanza/NeuroM/tags","blobs_url":"https://api.github.com/repos/juanchopanza/NeuroM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanchopanza/NeuroM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanchopanza/NeuroM/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanchopanza/NeuroM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanchopanza/NeuroM/statuses/{sha}","languages_url":"https://api.github.com/repos/juanchopanza/NeuroM/languages","stargazers_url":"https://api.github.com/repos/juanchopanza/NeuroM/stargazers","contributors_url":"https://api.github.com/repos/juanchopanza/NeuroM/contributors","subscribers_url":"https://api.github.com/repos/juanchopanza/NeuroM/subscribers","subscription_url":"https://api.github.com/repos/juanchopanza/NeuroM/subscription","commits_url":"https://api.github.com/repos/juanchopanza/NeuroM/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanchopanza/NeuroM/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanchopanza/NeuroM/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanchopanza/NeuroM/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanchopanza/NeuroM/contents/{+path}","compare_url":"https://api.github.com/repos/juanchopanza/NeuroM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanchopanza/NeuroM/merges","archive_url":"https://api.github.com/repos/juanchopanza/NeuroM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanchopanza/NeuroM/downloads","issues_url":"https://api.github.com/repos/juanchopanza/NeuroM/issues{/number}","pulls_url":"https://api.github.com/repos/juanchopanza/NeuroM/pulls{/number}","milestones_url":"https://api.github.com/repos/juanchopanza/NeuroM/milestones{/number}","notifications_url":"https://api.github.com/repos/juanchopanza/NeuroM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanchopanza/NeuroM/labels{/name}","releases_url":"https://api.github.com/repos/juanchopanza/NeuroM/releases{/id}","deployments_url":"https://api.github.com/repos/juanchopanza/NeuroM/deployments","created_at":"2015-08-17T12:45:31Z","updated_at":"2016-05-26T12:29:34Z","pushed_at":"2016-06-16T11:54:49Z","git_url":"git://github.com/juanchopanza/NeuroM.git","ssh_url":"git@github.com:juanchopanza/NeuroM.git","clone_url":"https://github.com/juanchopanza/NeuroM.git","svn_url":"https://github.com/juanchopanza/NeuroM","homepage":"","size":5092,"stargazers_count":1,"watchers_count":1,"language":"AGS Script","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"3980cf7fd696471e0e0c2a3c632d5858c1ab3612","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":34906350,"name":"NeuroM","full_name":"BlueBrain/NeuroM","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/NeuroM","description":"Neuronal Morphology Analysis Tool","fork":false,"url":"https://api.github.com/repos/BlueBrain/NeuroM","forks_url":"https://api.github.com/repos/BlueBrain/NeuroM/forks","keys_url":"https://api.github.com/repos/BlueBrain/NeuroM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/NeuroM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/NeuroM/teams","hooks_url":"https://api.github.com/repos/BlueBrain/NeuroM/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/NeuroM/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/NeuroM/events","assignees_url":"https://api.github.com/repos/BlueBrain/NeuroM/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/NeuroM/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/NeuroM/tags","blobs_url":"https://api.github.com/repos/BlueBrain/NeuroM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/NeuroM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/NeuroM/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/NeuroM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/NeuroM/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/NeuroM/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/NeuroM/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/NeuroM/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/NeuroM/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/NeuroM/subscription","commits_url":"https://api.github.com/repos/BlueBrain/NeuroM/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/NeuroM/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/NeuroM/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/NeuroM/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/NeuroM/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/NeuroM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/NeuroM/merges","archive_url":"https://api.github.com/repos/BlueBrain/NeuroM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/NeuroM/downloads","issues_url":"https://api.github.com/repos/BlueBrain/NeuroM/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/NeuroM/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/NeuroM/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/NeuroM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/NeuroM/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/NeuroM/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/NeuroM/deployments","created_at":"2015-05-01T14:21:43Z","updated_at":"2016-05-26T11:43:32Z","pushed_at":"2016-06-16T11:56:51Z","git_url":"git://github.com/BlueBrain/NeuroM.git","ssh_url":"git@github.com:BlueBrain/NeuroM.git","clone_url":"https://github.com/BlueBrain/NeuroM.git","svn_url":"https://github.com/BlueBrain/NeuroM","homepage":"","size":5109,"stargazers_count":14,"watchers_count":14,"language":"AGS Script","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":22,"forks":13,"open_issues":22,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382"},"html":{"href":"https://github.com/BlueBrain/NeuroM/pull/382"},"issue":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/issues/382"},"comments":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/NeuroM/statuses/59dc97ed0e0f305e3d07c900ee32d16c2a948ba1"}}}}
{"actor":{"display_login":"lidakanari"}}