{"action":"created","issue":{"url":"https://api.github.com/repos/sstsimulator/sst-core/issues/136","repository_url":"https://api.github.com/repos/sstsimulator/sst-core","labels_url":"https://api.github.com/repos/sstsimulator/sst-core/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/sstsimulator/sst-core/issues/136/comments","events_url":"https://api.github.com/repos/sstsimulator/sst-core/issues/136/events","html_url":"https://github.com/sstsimulator/sst-core/issues/136","id":164971528,"number":136,"title":"returning reference to temporary","user":{"login":"jjwilke","id":106969,"avatar_url":"https://avatars.githubusercontent.com/u/106969?v=3","gravatar_id":"","url":"https://api.github.com/users/jjwilke","html_url":"https://github.com/jjwilke","followers_url":"https://api.github.com/users/jjwilke/followers","following_url":"https://api.github.com/users/jjwilke/following{/other_user}","gists_url":"https://api.github.com/users/jjwilke/gists{/gist_id}","starred_url":"https://api.github.com/users/jjwilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjwilke/subscriptions","organizations_url":"https://api.github.com/users/jjwilke/orgs","repos_url":"https://api.github.com/users/jjwilke/repos","events_url":"https://api.github.com/users/jjwilke/events{/privacy}","received_events_url":"https://api.github.com/users/jjwilke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sstsimulator/sst-core/labels/Bug","name":"Bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"feldergast","id":14928630,"avatar_url":"https://avatars.githubusercontent.com/u/14928630?v=3","gravatar_id":"","url":"https://api.github.com/users/feldergast","html_url":"https://github.com/feldergast","followers_url":"https://api.github.com/users/feldergast/followers","following_url":"https://api.github.com/users/feldergast/following{/other_user}","gists_url":"https://api.github.com/users/feldergast/gists{/gist_id}","starred_url":"https://api.github.com/users/feldergast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feldergast/subscriptions","organizations_url":"https://api.github.com/users/feldergast/orgs","repos_url":"https://api.github.com/users/feldergast/repos","events_url":"https://api.github.com/users/feldergast/events{/privacy}","received_events_url":"https://api.github.com/users/feldergast/received_events","type":"User","site_admin":false},"assignees":[{"login":"feldergast","id":14928630,"avatar_url":"https://avatars.githubusercontent.com/u/14928630?v=3","gravatar_id":"","url":"https://api.github.com/users/feldergast","html_url":"https://github.com/feldergast","followers_url":"https://api.github.com/users/feldergast/followers","following_url":"https://api.github.com/users/feldergast/following{/other_user}","gists_url":"https://api.github.com/users/feldergast/gists{/gist_id}","starred_url":"https://api.github.com/users/feldergast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feldergast/subscriptions","organizations_url":"https://api.github.com/users/feldergast/orgs","repos_url":"https://api.github.com/users/feldergast/repos","events_url":"https://api.github.com/users/feldergast/events{/privacy}","received_events_url":"https://api.github.com/users/feldergast/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/sstsimulator/sst-core/milestones/1","html_url":"https://github.com/sstsimulator/sst-core/milestones/SST%20v6.0.0","labels_url":"https://api.github.com/repos/sstsimulator/sst-core/milestones/1/labels","id":1343367,"number":1,"title":"SST v6.0.0","description":"SST v6.0.0 Release","creator":{"login":"allevin","id":13543471,"avatar_url":"https://avatars.githubusercontent.com/u/13543471?v=3","gravatar_id":"","url":"https://api.github.com/users/allevin","html_url":"https://github.com/allevin","followers_url":"https://api.github.com/users/allevin/followers","following_url":"https://api.github.com/users/allevin/following{/other_user}","gists_url":"https://api.github.com/users/allevin/gists{/gist_id}","starred_url":"https://api.github.com/users/allevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allevin/subscriptions","organizations_url":"https://api.github.com/users/allevin/orgs","repos_url":"https://api.github.com/users/allevin/repos","events_url":"https://api.github.com/users/allevin/events{/privacy}","received_events_url":"https://api.github.com/users/allevin/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":38,"state":"open","created_at":"2015-10-07T20:01:13Z","updated_at":"2016-07-12T14:32:00Z","due_on":"2016-04-14T06:00:00Z","closed_at":null},"comments":2,"created_at":"2016-07-12T00:53:48Z","updated_at":"2016-07-12T15:10:56Z","closed_at":"2016-07-12T14:32:00Z","body":"##### New Issue for sst-core\r\n`1` Detailed description of problem or enhancement\r\n\r\nReturning an r-value reference to a temporary seems like a bad idea\r\n\r\n`2` Describe how to reproduce\r\n\r\n`3` What Operating system(s) and versions \r\n\r\n`4` What version of external libraries (Boost, MPI)\r\n\r\n`5` Provide sha1 of all relevant sst repositories (sst-core, sst-elements, etc)\r\n\r\n`6` Fill out Labels, Milestones, and Assignee fields as best possible\r\nScott, fix this\r\n\r\nLine 121 in elemLoader.cc\r\n\r\nstatic std::vector<std::string>&& splitPath(const std::string & searchPaths)\r\n{\r\n    std::vector<std::string> paths;\r\n\r\nThe likely behavior is that you just end up with an empty return value and the appearance that SST_LIB_PATH has been ignored. \r\n\r\nThis array will never be that big.  Just return a regular value and hope copy elision does its job.\r\n"},"comment":{"url":"https://api.github.com/repos/sstsimulator/sst-core/issues/comments/232078764","html_url":"https://github.com/sstsimulator/sst-core/issues/136#issuecomment-232078764","issue_url":"https://api.github.com/repos/sstsimulator/sst-core/issues/136","id":232078764,"user":{"login":"jjwilke","id":106969,"avatar_url":"https://avatars.githubusercontent.com/u/106969?v=3","gravatar_id":"","url":"https://api.github.com/users/jjwilke","html_url":"https://github.com/jjwilke","followers_url":"https://api.github.com/users/jjwilke/followers","following_url":"https://api.github.com/users/jjwilke/following{/other_user}","gists_url":"https://api.github.com/users/jjwilke/gists{/gist_id}","starred_url":"https://api.github.com/users/jjwilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjwilke/subscriptions","organizations_url":"https://api.github.com/users/jjwilke/orgs","repos_url":"https://api.github.com/users/jjwilke/repos","events_url":"https://api.github.com/users/jjwilke/events{/privacy}","received_events_url":"https://api.github.com/users/jjwilke/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T15:10:56Z","updated_at":"2016-07-12T15:10:56Z","body":"It would be C++11 move semantics if you had moved into another function or another variable before the end of the function.  The destructor of the vector is getting called at the end of the function before it's captured by any move constructor.\r\n\r\nIt might accidentally work on some systems, but on Mac with Clang and CentOS with gcc you always get an empty array returned by splitPaths, which breaks all our stuff.\r\n"}}
{"actor":{"display_login":"jjwilke"}}