{"action":"created","comment":{"url":"https://api.github.com/repos/chireiden/shanghai/pulls/comments/87717791","pull_request_review_id":8319343,"id":87717791,"diff_hunk":"@@ -68,38 +69,52 @@ def next_server(self):\n     async def run(self):\n         self.log_context.push()\n \n-        def cancel_other_task_if_failed(task, other_task):\n-            current_logger.info('cancel_other_task_if_failed', task)\n-            if task.exception():\n-                task.print_stack()\n+        def cancel_other(task: asyncio.Task, other_task: asyncio.Task):\n+            try:","path":"shanghai/network.py","position":17,"original_position":17,"commit_id":"77735b9ed03fb42b8cdb326a2fe30f62dea99a6e","original_commit_id":"77735b9ed03fb42b8cdb326a2fe30f62dea99a6e","user":{"login":"FichteFoll","id":931051,"avatar_url":"https://avatars.githubusercontent.com/u/931051?v=3","gravatar_id":"","url":"https://api.github.com/users/FichteFoll","html_url":"https://github.com/FichteFoll","followers_url":"https://api.github.com/users/FichteFoll/followers","following_url":"https://api.github.com/users/FichteFoll/following{/other_user}","gists_url":"https://api.github.com/users/FichteFoll/gists{/gist_id}","starred_url":"https://api.github.com/users/FichteFoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FichteFoll/subscriptions","organizations_url":"https://api.github.com/users/FichteFoll/orgs","repos_url":"https://api.github.com/users/FichteFoll/repos","events_url":"https://api.github.com/users/FichteFoll/events{/privacy}","received_events_url":"https://api.github.com/users/FichteFoll/received_events","type":"User","site_admin":false},"body":"Could also check for `.cancelled()` instead.","created_at":"2016-11-13T18:11:01Z","updated_at":"2016-11-13T18:17:23Z","html_url":"https://github.com/chireiden/shanghai/pull/28#discussion_r87717791","pull_request_url":"https://api.github.com/repos/chireiden/shanghai/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/comments/87717791"},"html":{"href":"https://github.com/chireiden/shanghai/pull/28#discussion_r87717791"},"pull_request":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/chireiden/shanghai/pulls/28","id":93480685,"html_url":"https://github.com/chireiden/shanghai/pull/28","diff_url":"https://github.com/chireiden/shanghai/pull/28.diff","patch_url":"https://github.com/chireiden/shanghai/pull/28.patch","issue_url":"https://api.github.com/repos/chireiden/shanghai/issues/28","number":28,"state":"open","locked":false,"title":"Try to get the shutdown and handling of exceptions right","user":{"login":"knitori","id":1561831,"avatar_url":"https://avatars.githubusercontent.com/u/1561831?v=3","gravatar_id":"","url":"https://api.github.com/users/knitori","html_url":"https://github.com/knitori","followers_url":"https://api.github.com/users/knitori/followers","following_url":"https://api.github.com/users/knitori/following{/other_user}","gists_url":"https://api.github.com/users/knitori/gists{/gist_id}","starred_url":"https://api.github.com/users/knitori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knitori/subscriptions","organizations_url":"https://api.github.com/users/knitori/orgs","repos_url":"https://api.github.com/users/knitori/repos","events_url":"https://api.github.com/users/knitori/events{/privacy}","received_events_url":"https://api.github.com/users/knitori/received_events","type":"User","site_admin":false},"body":"This doesn't really feel right though.\r\n\r\nSome dirty hacks like line 77 in network.py …\r\n\r\nI think there still are issues. Ctrl+C doesn't seem to work right yet.","created_at":"2016-11-13T18:02:30Z","updated_at":"2016-11-13T18:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b61fa156fd9abdd9fe43fd60a51ee7940f1e1628","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chireiden/shanghai/pulls/28/commits","review_comments_url":"https://api.github.com/repos/chireiden/shanghai/pulls/28/comments","review_comment_url":"https://api.github.com/repos/chireiden/shanghai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chireiden/shanghai/issues/28/comments","statuses_url":"https://api.github.com/repos/chireiden/shanghai/statuses/77735b9ed03fb42b8cdb326a2fe30f62dea99a6e","head":{"label":"knitori:master","ref":"master","sha":"77735b9ed03fb42b8cdb326a2fe30f62dea99a6e","user":{"login":"knitori","id":1561831,"avatar_url":"https://avatars.githubusercontent.com/u/1561831?v=3","gravatar_id":"","url":"https://api.github.com/users/knitori","html_url":"https://github.com/knitori","followers_url":"https://api.github.com/users/knitori/followers","following_url":"https://api.github.com/users/knitori/following{/other_user}","gists_url":"https://api.github.com/users/knitori/gists{/gist_id}","starred_url":"https://api.github.com/users/knitori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knitori/subscriptions","organizations_url":"https://api.github.com/users/knitori/orgs","repos_url":"https://api.github.com/users/knitori/repos","events_url":"https://api.github.com/users/knitori/events{/privacy}","received_events_url":"https://api.github.com/users/knitori/received_events","type":"User","site_admin":false},"repo":{"id":58546400,"name":"shanghai","full_name":"knitori/shanghai","owner":{"login":"knitori","id":1561831,"avatar_url":"https://avatars.githubusercontent.com/u/1561831?v=3","gravatar_id":"","url":"https://api.github.com/users/knitori","html_url":"https://github.com/knitori","followers_url":"https://api.github.com/users/knitori/followers","following_url":"https://api.github.com/users/knitori/following{/other_user}","gists_url":"https://api.github.com/users/knitori/gists{/gist_id}","starred_url":"https://api.github.com/users/knitori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knitori/subscriptions","organizations_url":"https://api.github.com/users/knitori/orgs","repos_url":"https://api.github.com/users/knitori/repos","events_url":"https://api.github.com/users/knitori/events{/privacy}","received_events_url":"https://api.github.com/users/knitori/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knitori/shanghai","description":"Shanghai","fork":true,"url":"https://api.github.com/repos/knitori/shanghai","forks_url":"https://api.github.com/repos/knitori/shanghai/forks","keys_url":"https://api.github.com/repos/knitori/shanghai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knitori/shanghai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knitori/shanghai/teams","hooks_url":"https://api.github.com/repos/knitori/shanghai/hooks","issue_events_url":"https://api.github.com/repos/knitori/shanghai/issues/events{/number}","events_url":"https://api.github.com/repos/knitori/shanghai/events","assignees_url":"https://api.github.com/repos/knitori/shanghai/assignees{/user}","branches_url":"https://api.github.com/repos/knitori/shanghai/branches{/branch}","tags_url":"https://api.github.com/repos/knitori/shanghai/tags","blobs_url":"https://api.github.com/repos/knitori/shanghai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knitori/shanghai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knitori/shanghai/git/refs{/sha}","trees_url":"https://api.github.com/repos/knitori/shanghai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knitori/shanghai/statuses/{sha}","languages_url":"https://api.github.com/repos/knitori/shanghai/languages","stargazers_url":"https://api.github.com/repos/knitori/shanghai/stargazers","contributors_url":"https://api.github.com/repos/knitori/shanghai/contributors","subscribers_url":"https://api.github.com/repos/knitori/shanghai/subscribers","subscription_url":"https://api.github.com/repos/knitori/shanghai/subscription","commits_url":"https://api.github.com/repos/knitori/shanghai/commits{/sha}","git_commits_url":"https://api.github.com/repos/knitori/shanghai/git/commits{/sha}","comments_url":"https://api.github.com/repos/knitori/shanghai/comments{/number}","issue_comment_url":"https://api.github.com/repos/knitori/shanghai/issues/comments{/number}","contents_url":"https://api.github.com/repos/knitori/shanghai/contents/{+path}","compare_url":"https://api.github.com/repos/knitori/shanghai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knitori/shanghai/merges","archive_url":"https://api.github.com/repos/knitori/shanghai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knitori/shanghai/downloads","issues_url":"https://api.github.com/repos/knitori/shanghai/issues{/number}","pulls_url":"https://api.github.com/repos/knitori/shanghai/pulls{/number}","milestones_url":"https://api.github.com/repos/knitori/shanghai/milestones{/number}","notifications_url":"https://api.github.com/repos/knitori/shanghai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knitori/shanghai/labels{/name}","releases_url":"https://api.github.com/repos/knitori/shanghai/releases{/id}","deployments_url":"https://api.github.com/repos/knitori/shanghai/deployments","created_at":"2016-05-11T13:16:52Z","updated_at":"2016-05-11T13:16:53Z","pushed_at":"2016-11-13T17:59:49Z","git_url":"git://github.com/knitori/shanghai.git","ssh_url":"git@github.com:knitori/shanghai.git","clone_url":"https://github.com/knitori/shanghai.git","svn_url":"https://github.com/knitori/shanghai","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chireiden:master","ref":"master","sha":"1465c548aa08ee828527c8f829535e5c0217513b","user":{"login":"chireiden","id":19307081,"avatar_url":"https://avatars.githubusercontent.com/u/19307081?v=3","gravatar_id":"","url":"https://api.github.com/users/chireiden","html_url":"https://github.com/chireiden","followers_url":"https://api.github.com/users/chireiden/followers","following_url":"https://api.github.com/users/chireiden/following{/other_user}","gists_url":"https://api.github.com/users/chireiden/gists{/gist_id}","starred_url":"https://api.github.com/users/chireiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chireiden/subscriptions","organizations_url":"https://api.github.com/users/chireiden/orgs","repos_url":"https://api.github.com/users/chireiden/repos","events_url":"https://api.github.com/users/chireiden/events{/privacy}","received_events_url":"https://api.github.com/users/chireiden/received_events","type":"Organization","site_admin":false},"repo":{"id":56868784,"name":"shanghai","full_name":"chireiden/shanghai","owner":{"login":"chireiden","id":19307081,"avatar_url":"https://avatars.githubusercontent.com/u/19307081?v=3","gravatar_id":"","url":"https://api.github.com/users/chireiden","html_url":"https://github.com/chireiden","followers_url":"https://api.github.com/users/chireiden/followers","following_url":"https://api.github.com/users/chireiden/following{/other_user}","gists_url":"https://api.github.com/users/chireiden/gists{/gist_id}","starred_url":"https://api.github.com/users/chireiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chireiden/subscriptions","organizations_url":"https://api.github.com/users/chireiden/orgs","repos_url":"https://api.github.com/users/chireiden/repos","events_url":"https://api.github.com/users/chireiden/events{/privacy}","received_events_url":"https://api.github.com/users/chireiden/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chireiden/shanghai","description":"Shanghai","fork":false,"url":"https://api.github.com/repos/chireiden/shanghai","forks_url":"https://api.github.com/repos/chireiden/shanghai/forks","keys_url":"https://api.github.com/repos/chireiden/shanghai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chireiden/shanghai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chireiden/shanghai/teams","hooks_url":"https://api.github.com/repos/chireiden/shanghai/hooks","issue_events_url":"https://api.github.com/repos/chireiden/shanghai/issues/events{/number}","events_url":"https://api.github.com/repos/chireiden/shanghai/events","assignees_url":"https://api.github.com/repos/chireiden/shanghai/assignees{/user}","branches_url":"https://api.github.com/repos/chireiden/shanghai/branches{/branch}","tags_url":"https://api.github.com/repos/chireiden/shanghai/tags","blobs_url":"https://api.github.com/repos/chireiden/shanghai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chireiden/shanghai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chireiden/shanghai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chireiden/shanghai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chireiden/shanghai/statuses/{sha}","languages_url":"https://api.github.com/repos/chireiden/shanghai/languages","stargazers_url":"https://api.github.com/repos/chireiden/shanghai/stargazers","contributors_url":"https://api.github.com/repos/chireiden/shanghai/contributors","subscribers_url":"https://api.github.com/repos/chireiden/shanghai/subscribers","subscription_url":"https://api.github.com/repos/chireiden/shanghai/subscription","commits_url":"https://api.github.com/repos/chireiden/shanghai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chireiden/shanghai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chireiden/shanghai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chireiden/shanghai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chireiden/shanghai/contents/{+path}","compare_url":"https://api.github.com/repos/chireiden/shanghai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chireiden/shanghai/merges","archive_url":"https://api.github.com/repos/chireiden/shanghai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chireiden/shanghai/downloads","issues_url":"https://api.github.com/repos/chireiden/shanghai/issues{/number}","pulls_url":"https://api.github.com/repos/chireiden/shanghai/pulls{/number}","milestones_url":"https://api.github.com/repos/chireiden/shanghai/milestones{/number}","notifications_url":"https://api.github.com/repos/chireiden/shanghai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chireiden/shanghai/labels{/name}","releases_url":"https://api.github.com/repos/chireiden/shanghai/releases{/id}","deployments_url":"https://api.github.com/repos/chireiden/shanghai/deployments","created_at":"2016-04-22T16:13:37Z","updated_at":"2016-10-30T10:40:37Z","pushed_at":"2016-11-13T18:02:30Z","git_url":"git://github.com/chireiden/shanghai.git","ssh_url":"git@github.com:chireiden/shanghai.git","clone_url":"https://github.com/chireiden/shanghai.git","svn_url":"https://github.com/chireiden/shanghai","homepage":null,"size":120,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/28"},"html":{"href":"https://github.com/chireiden/shanghai/pull/28"},"issue":{"href":"https://api.github.com/repos/chireiden/shanghai/issues/28"},"comments":{"href":"https://api.github.com/repos/chireiden/shanghai/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chireiden/shanghai/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/chireiden/shanghai/statuses/77735b9ed03fb42b8cdb326a2fe30f62dea99a6e"}}}}
{"actor":{"display_login":"FichteFoll"}}