{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/62502168","id":62502168,"diff_hunk":"@@ -0,0 +1,40 @@\n+<?php\n+\n+\n+class InsightsService extends WikiaService\n+{\n+\n+\t/**\n+\t * @param string $type type of model\n+\t * @param int $size number of pages we need\n+\t * @return array\n+\t */\n+\tpublic function getInsightPages( $type, $size, $sortingType ) {\n+\t\tif ( InsightsHelper::isInsightPage( $type ) ) {\n+\t\t\t$model = InsightsHelper::getInsightModel( $type );\n+\t\t\t$insightData = ( new InsightsContext( $model ) )->fetchData();\n+\t\t\t$sortedInsightArticleIds = ( new InsightsSorting( $model->getConfig() ) )->getSortedData( $insightData, ['sort' => $sortingType] );\n+\t\t\t$aritclesIds = $this->truncateTo( $sortedInsightArticleIds, $size );\n+\t\t\treturn $this->getArticlesData( $insightData, $aritclesIds );\n+\t\t}\n+\t\treturn [];","path":"extensions/wikia/InsightsV2/services/InsightsService.class.php","position":20,"original_position":20,"commit_id":"eed655b7d500bde2466e2e3a59a7b3d0bee5dea5","original_commit_id":"eed655b7d500bde2466e2e3a59a7b3d0bee5dea5","user":{"login":"Grunny","id":230630,"avatar_url":"https://avatars.githubusercontent.com/u/230630?v=3","gravatar_id":"","url":"https://api.github.com/users/Grunny","html_url":"https://github.com/Grunny","followers_url":"https://api.github.com/users/Grunny/followers","following_url":"https://api.github.com/users/Grunny/following{/other_user}","gists_url":"https://api.github.com/users/Grunny/gists{/gist_id}","starred_url":"https://api.github.com/users/Grunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grunny/subscriptions","organizations_url":"https://api.github.com/users/Grunny/orgs","repos_url":"https://api.github.com/users/Grunny/repos","events_url":"https://api.github.com/users/Grunny/events{/privacy}","received_events_url":"https://api.github.com/users/Grunny/received_events","type":"User","site_admin":false},"body":"I'd consider reversing this so the early return of empty data is in an if block, and the main work of the method is unindented.","created_at":"2016-05-09T14:01:38Z","updated_at":"2016-05-09T14:01:38Z","html_url":"https://github.com/Wikia/app/pull/10429#discussion_r62502168","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/10429","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/62502168"},"html":{"href":"https://github.com/Wikia/app/pull/10429#discussion_r62502168"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/10429"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/10429","id":69344129,"html_url":"https://github.com/Wikia/app/pull/10429","diff_url":"https://github.com/Wikia/app/pull/10429.diff","patch_url":"https://github.com/Wikia/app/pull/10429.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/10429","number":10429,"state":"open","locked":false,"title":"JPN-436 | Initial backend of Insights module","user":{"login":"d34th4ck3r","id":890900,"avatar_url":"https://avatars.githubusercontent.com/u/890900?v=3","gravatar_id":"","url":"https://api.github.com/users/d34th4ck3r","html_url":"https://github.com/d34th4ck3r","followers_url":"https://api.github.com/users/d34th4ck3r/followers","following_url":"https://api.github.com/users/d34th4ck3r/following{/other_user}","gists_url":"https://api.github.com/users/d34th4ck3r/gists{/gist_id}","starred_url":"https://api.github.com/users/d34th4ck3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d34th4ck3r/subscriptions","organizations_url":"https://api.github.com/users/d34th4ck3r/orgs","repos_url":"https://api.github.com/users/d34th4ck3r/repos","events_url":"https://api.github.com/users/d34th4ck3r/events{/privacy}","received_events_url":"https://api.github.com/users/d34th4ck3r/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-09T13:22:32Z","updated_at":"2016-05-09T14:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b8eb27626d3a058490cad462d4583e3d9ec483b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/10429/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/10429/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/10429/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/eed655b7d500bde2466e2e3a59a7b3d0bee5dea5","head":{"label":"Wikia:JPN-436","ref":"JPN-436","sha":"eed655b7d500bde2466e2e3a59a7b3d0bee5dea5","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-04-20T18:06:47Z","pushed_at":"2016-05-09T14:00:48Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":2310833,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":100,"forks":78,"open_issues":100,"watchers":95,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"52863d8355e897654bf0eeb4793fb426f46e6729","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-04-20T18:06:47Z","pushed_at":"2016-05-09T14:00:48Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":2310833,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":100,"forks":78,"open_issues":100,"watchers":95,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/10429"},"html":{"href":"https://github.com/Wikia/app/pull/10429"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/10429"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/10429/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/10429/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/10429/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/eed655b7d500bde2466e2e3a59a7b3d0bee5dea5"}}}}