{"action":"closed","number":4141,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/4141","id":97847819,"html_url":"https://github.com/mono/mono/pull/4141","diff_url":"https://github.com/mono/mono/pull/4141.diff","patch_url":"https://github.com/mono/mono/pull/4141.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/4141","number":4141,"state":"closed","locked":false,"title":"[C9][sre] Implement DynamicMethod.GetCustomAttributes() and IsDefined() (Fixes #49686)","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"body":"Do what the documentation says:\r\n> Custom attributes are not currently supported on dynamic methods. The only attribute returned is `MethodImplAttribute`; you can get the method implementation flags more easily using the `GetMethodImplementationFlags` method.\r\n\r\nand\r\n\r\n> Currently, method implementation attributes for dynamic methods are always IL and NoInlining.\r\n\r\nFixes https://bugzilla.xamarin.com/show_bug.cgi?id=49686\r\n\r\nThis is #4139 backported to `mono-4.8.0-branch`","created_at":"2016-12-13T22:20:05Z","updated_at":"2016-12-14T10:08:57Z","closed_at":"2016-12-14T10:08:57Z","merged_at":"2016-12-14T10:08:57Z","merge_commit_sha":"01d393001870d254706d2e66ed36c215ef3b2f51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/4141/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/4141/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/4141/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/29827d656b06bf87845a6f8effe3212c483a472a","head":{"label":"lambdageek:bug-49686-c9","ref":"bug-49686-c9","sha":"29827d656b06bf87845a6f8effe3212c483a472a","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"repo":{"id":40153659,"name":"mono","full_name":"lambdageek/mono","owner":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lambdageek/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/lambdageek/mono","forks_url":"https://api.github.com/repos/lambdageek/mono/forks","keys_url":"https://api.github.com/repos/lambdageek/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lambdageek/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lambdageek/mono/teams","hooks_url":"https://api.github.com/repos/lambdageek/mono/hooks","issue_events_url":"https://api.github.com/repos/lambdageek/mono/issues/events{/number}","events_url":"https://api.github.com/repos/lambdageek/mono/events","assignees_url":"https://api.github.com/repos/lambdageek/mono/assignees{/user}","branches_url":"https://api.github.com/repos/lambdageek/mono/branches{/branch}","tags_url":"https://api.github.com/repos/lambdageek/mono/tags","blobs_url":"https://api.github.com/repos/lambdageek/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lambdageek/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lambdageek/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/lambdageek/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lambdageek/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/lambdageek/mono/languages","stargazers_url":"https://api.github.com/repos/lambdageek/mono/stargazers","contributors_url":"https://api.github.com/repos/lambdageek/mono/contributors","subscribers_url":"https://api.github.com/repos/lambdageek/mono/subscribers","subscription_url":"https://api.github.com/repos/lambdageek/mono/subscription","commits_url":"https://api.github.com/repos/lambdageek/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/lambdageek/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/lambdageek/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/lambdageek/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/lambdageek/mono/contents/{+path}","compare_url":"https://api.github.com/repos/lambdageek/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lambdageek/mono/merges","archive_url":"https://api.github.com/repos/lambdageek/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lambdageek/mono/downloads","issues_url":"https://api.github.com/repos/lambdageek/mono/issues{/number}","pulls_url":"https://api.github.com/repos/lambdageek/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/lambdageek/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/lambdageek/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lambdageek/mono/labels{/name}","releases_url":"https://api.github.com/repos/lambdageek/mono/releases{/id}","deployments_url":"https://api.github.com/repos/lambdageek/mono/deployments","created_at":"2015-08-03T23:55:25Z","updated_at":"2016-06-09T01:07:23Z","pushed_at":"2016-12-13T22:18:18Z","git_url":"git://github.com/lambdageek/mono.git","ssh_url":"git@github.com:lambdageek/mono.git","clone_url":"https://github.com/lambdageek/mono.git","svn_url":"https://github.com/lambdageek/mono","homepage":"http://www.mono-project.com/","size":422273,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:mono-4.8.0-branch","ref":"mono-4.8.0-branch","sha":"ded59a04cefe8739d13b2ca113217308d61d5a50","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-12-14T03:01:42Z","pushed_at":"2016-12-14T10:08:57Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":433929,"stargazers_count":5120,"watchers_count":5120,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2447,"mirror_url":null,"open_issues_count":154,"forks":2447,"open_issues":154,"watchers":5120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/4141"},"html":{"href":"https://github.com/mono/mono/pull/4141"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/4141"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/4141/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/4141/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/4141/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/29827d656b06bf87845a6f8effe3212c483a472a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marek-safar","id":250852,"avatar_url":"https://avatars.githubusercontent.com/u/250852?v=3","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":75,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"marek-safar"}}