{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/63904311","id":63904311,"diff_hunk":"@@ -0,0 +1,49 @@\n+#ifndef TkDetLayers_Phase2OTtiltedBarrelLayer_h\n+#define TkDetLayers_Phase2OTtiltedBarrelLayer_h\n+\n+\n+#include \"TrackingTools/DetLayers/interface/RodBarrelLayer.h\"\n+#include \"Phase2OTBarrelLayer.h\"\n+#include \"Phase2OTBarrelRod.h\"\n+#include \"Phase2OTEndcapRing.h\"\n+#include \"SubLayerCrossings.h\"\n+\n+\n+/** A concrete implementation for Phase2OTtiltedBarrel layer \n+ *  built out of BarrelPhase2OTBarrelRod\n+ */\n+\n+#pragma GCC visibility push(hidden)","path":"RecoTracker/TkDetLayers/src/Phase2OTtiltedBarrelLayer.h","position":16,"original_position":16,"commit_id":"11e9b9824533c8dc4ffc8fd8bf04ee285a2d1603","original_commit_id":"11e9b9824533c8dc4ffc8fd8bf04ee285a2d1603","user":{"login":"VinInn","id":4143702,"avatar_url":"https://avatars.githubusercontent.com/u/4143702?v=3","gravatar_id":"","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"body":"\"namespace {\"  defines it in the context of the file (equivalent to inline)\r\nhidden visibility in the context of shared library","created_at":"2016-05-19T15:51:11Z","updated_at":"2016-05-19T15:51:11Z","html_url":"https://github.com/cms-sw/cmssw/pull/14523#discussion_r63904311","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/63904311"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14523#discussion_r63904311"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523","id":70249224,"html_url":"https://github.com/cms-sw/cmssw/pull/14523","diff_url":"https://github.com/cms-sw/cmssw/pull/14523.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14523.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14523","number":14523,"state":"open","locked":false,"title":"2023 workflows up to tracking reco","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"body":"With this PR, the tracking reconstruction has been introduced in the 2023 scenario with both the tilted (2023tilted workflow) and the flat (2023GReco workflow) tracker geometry. \r\nIn order to fix also the Lorentz Angle message for the tilted, this PR should be integrated together with cms-data/SLHCUpgradeSimulations-Geometry#2.\r\n\r\n@boudoul @delaere @VinInn @rovere ","created_at":"2016-05-16T19:42:10Z","updated_at":"2016-05-19T15:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a03a83416a0614e31a53b36fba6bf20280fd5d","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":643,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-05-19T14:44:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14523/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/11e9b9824533c8dc4ffc8fd8bf04ee285a2d1603","head":{"label":"ebrondol:fixWF_phase2tracking_81X","ref":"fixWF_phase2tracking_81X","sha":"11e9b9824533c8dc4ffc8fd8bf04ee285a2d1603","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"repo":{"id":18753381,"name":"cmssw","full_name":"ebrondol/cmssw","owner":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebrondol/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/ebrondol/cmssw","forks_url":"https://api.github.com/repos/ebrondol/cmssw/forks","keys_url":"https://api.github.com/repos/ebrondol/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebrondol/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebrondol/cmssw/teams","hooks_url":"https://api.github.com/repos/ebrondol/cmssw/hooks","issue_events_url":"https://api.github.com/repos/ebrondol/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/ebrondol/cmssw/events","assignees_url":"https://api.github.com/repos/ebrondol/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/ebrondol/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/ebrondol/cmssw/tags","blobs_url":"https://api.github.com/repos/ebrondol/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebrondol/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebrondol/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebrondol/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebrondol/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/ebrondol/cmssw/languages","stargazers_url":"https://api.github.com/repos/ebrondol/cmssw/stargazers","contributors_url":"https://api.github.com/repos/ebrondol/cmssw/contributors","subscribers_url":"https://api.github.com/repos/ebrondol/cmssw/subscribers","subscription_url":"https://api.github.com/repos/ebrondol/cmssw/subscription","commits_url":"https://api.github.com/repos/ebrondol/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebrondol/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebrondol/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebrondol/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebrondol/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/ebrondol/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebrondol/cmssw/merges","archive_url":"https://api.github.com/repos/ebrondol/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebrondol/cmssw/downloads","issues_url":"https://api.github.com/repos/ebrondol/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/ebrondol/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/ebrondol/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/ebrondol/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebrondol/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/ebrondol/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/ebrondol/cmssw/deployments","created_at":"2014-04-14T08:22:32Z","updated_at":"2015-10-28T20:46:48Z","pushed_at":"2016-05-19T14:01:37Z","git_url":"git://github.com/ebrondol/cmssw.git","ssh_url":"git@github.com:ebrondol/cmssw.git","clone_url":"https://github.com/ebrondol/cmssw.git","svn_url":"https://github.com/ebrondol/cmssw","homepage":"cms-sw.github.io/cmssw","size":869636,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"1550b933dbb059bb5804c02e23edfbfa1757ad5f","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-05-16T03:58:09Z","pushed_at":"2016-05-19T15:10:58Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1080342,"stargazers_count":307,"watchers_count":307,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1816,"mirror_url":null,"open_issues_count":345,"forks":1816,"open_issues":345,"watchers":307,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14523"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14523"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14523/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14523/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/11e9b9824533c8dc4ffc8fd8bf04ee285a2d1603"}}}}