{"action":"created","comment":{"url":"https://api.github.com/repos/pluginsGLPI/order/pulls/comments/85095509","pull_request_review_id":5829987,"id":85095509,"diff_hunk":"@@ -32,15 +32,21 @@\n }\n \n class PluginOrderOrderInjection extends PluginOrderOrder implements PluginDatainjectionInjectionInterface {\n-   public function __construct() {\n+   function __construct() {\n       $this->table = getTableForItemType(get_parent_class($this));\n    }\n \n-   public function isPrimaryType() {\n+    static function getTable() {\n+     \n+       $parenttype = get_parent_class();","path":"inc/orderinjection.class.php","position":12,"original_position":12,"commit_id":"ff23f437e684f5e2fd8a3f8cf1db880cdff4caaf","original_commit_id":"ff23f437e684f5e2fd8a3f8cf1db880cdff4caaf","user":{"login":"trasher","id":224733,"avatar_url":"https://avatars.githubusercontent.com/u/224733?v=3","gravatar_id":"","url":"https://api.github.com/users/trasher","html_url":"https://github.com/trasher","followers_url":"https://api.github.com/users/trasher/followers","following_url":"https://api.github.com/users/trasher/following{/other_user}","gists_url":"https://api.github.com/users/trasher/gists{/gist_id}","starred_url":"https://api.github.com/users/trasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trasher/subscriptions","organizations_url":"https://api.github.com/users/trasher/orgs","repos_url":"https://api.github.com/users/trasher/repos","events_url":"https://api.github.com/users/trasher/events{/privacy}","received_events_url":"https://api.github.com/users/trasher/received_events","type":"User","site_admin":false},"body":"`parent::getTable()` would not work?","created_at":"2016-10-26T10:44:01Z","updated_at":"2016-10-26T10:44:32Z","html_url":"https://github.com/pluginsGLPI/order/pull/79#discussion_r85095509","pull_request_url":"https://api.github.com/repos/pluginsGLPI/order/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/comments/85095509"},"html":{"href":"https://github.com/pluginsGLPI/order/pull/79#discussion_r85095509"},"pull_request":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/pluginsGLPI/order/pulls/79","id":90973166,"html_url":"https://github.com/pluginsGLPI/order/pull/79","diff_url":"https://github.com/pluginsGLPI/order/pull/79.diff","patch_url":"https://github.com/pluginsGLPI/order/pull/79.patch","issue_url":"https://api.github.com/repos/pluginsGLPI/order/issues/79","number":79,"state":"open","locked":false,"title":"Missing getTable function preventing data injection","user":{"login":"dr-redoute","id":22367372,"avatar_url":"https://avatars.githubusercontent.com/u/22367372?v=3","gravatar_id":"","url":"https://api.github.com/users/dr-redoute","html_url":"https://github.com/dr-redoute","followers_url":"https://api.github.com/users/dr-redoute/followers","following_url":"https://api.github.com/users/dr-redoute/following{/other_user}","gists_url":"https://api.github.com/users/dr-redoute/gists{/gist_id}","starred_url":"https://api.github.com/users/dr-redoute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr-redoute/subscriptions","organizations_url":"https://api.github.com/users/dr-redoute/orgs","repos_url":"https://api.github.com/users/dr-redoute/repos","events_url":"https://api.github.com/users/dr-redoute/events{/privacy}","received_events_url":"https://api.github.com/users/dr-redoute/received_events","type":"User","site_admin":false},"body":"The static function getTable() was missing from both orderinjection.class.php and referenceinjection.class.php files causing wrong table names to be used in datainjection plugin\r\n\r\nThis solves issue #67 ","created_at":"2016-10-26T10:05:10Z","updated_at":"2016-10-26T10:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a0d6ba072a438686efa43dfa0a8472e7fd36072","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pluginsGLPI/order/pulls/79/commits","review_comments_url":"https://api.github.com/repos/pluginsGLPI/order/pulls/79/comments","review_comment_url":"https://api.github.com/repos/pluginsGLPI/order/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pluginsGLPI/order/issues/79/comments","statuses_url":"https://api.github.com/repos/pluginsGLPI/order/statuses/ff23f437e684f5e2fd8a3f8cf1db880cdff4caaf","head":{"label":"dr-redoute:patch-1","ref":"patch-1","sha":"ff23f437e684f5e2fd8a3f8cf1db880cdff4caaf","user":{"login":"dr-redoute","id":22367372,"avatar_url":"https://avatars.githubusercontent.com/u/22367372?v=3","gravatar_id":"","url":"https://api.github.com/users/dr-redoute","html_url":"https://github.com/dr-redoute","followers_url":"https://api.github.com/users/dr-redoute/followers","following_url":"https://api.github.com/users/dr-redoute/following{/other_user}","gists_url":"https://api.github.com/users/dr-redoute/gists{/gist_id}","starred_url":"https://api.github.com/users/dr-redoute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr-redoute/subscriptions","organizations_url":"https://api.github.com/users/dr-redoute/orgs","repos_url":"https://api.github.com/users/dr-redoute/repos","events_url":"https://api.github.com/users/dr-redoute/events{/privacy}","received_events_url":"https://api.github.com/users/dr-redoute/received_events","type":"User","site_admin":false},"repo":{"id":69972724,"name":"order","full_name":"dr-redoute/order","owner":{"login":"dr-redoute","id":22367372,"avatar_url":"https://avatars.githubusercontent.com/u/22367372?v=3","gravatar_id":"","url":"https://api.github.com/users/dr-redoute","html_url":"https://github.com/dr-redoute","followers_url":"https://api.github.com/users/dr-redoute/followers","following_url":"https://api.github.com/users/dr-redoute/following{/other_user}","gists_url":"https://api.github.com/users/dr-redoute/gists{/gist_id}","starred_url":"https://api.github.com/users/dr-redoute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr-redoute/subscriptions","organizations_url":"https://api.github.com/users/dr-redoute/orgs","repos_url":"https://api.github.com/users/dr-redoute/repos","events_url":"https://api.github.com/users/dr-redoute/events{/privacy}","received_events_url":"https://api.github.com/users/dr-redoute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dr-redoute/order","description":"Order plugin for GLPI","fork":true,"url":"https://api.github.com/repos/dr-redoute/order","forks_url":"https://api.github.com/repos/dr-redoute/order/forks","keys_url":"https://api.github.com/repos/dr-redoute/order/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dr-redoute/order/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dr-redoute/order/teams","hooks_url":"https://api.github.com/repos/dr-redoute/order/hooks","issue_events_url":"https://api.github.com/repos/dr-redoute/order/issues/events{/number}","events_url":"https://api.github.com/repos/dr-redoute/order/events","assignees_url":"https://api.github.com/repos/dr-redoute/order/assignees{/user}","branches_url":"https://api.github.com/repos/dr-redoute/order/branches{/branch}","tags_url":"https://api.github.com/repos/dr-redoute/order/tags","blobs_url":"https://api.github.com/repos/dr-redoute/order/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dr-redoute/order/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dr-redoute/order/git/refs{/sha}","trees_url":"https://api.github.com/repos/dr-redoute/order/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dr-redoute/order/statuses/{sha}","languages_url":"https://api.github.com/repos/dr-redoute/order/languages","stargazers_url":"https://api.github.com/repos/dr-redoute/order/stargazers","contributors_url":"https://api.github.com/repos/dr-redoute/order/contributors","subscribers_url":"https://api.github.com/repos/dr-redoute/order/subscribers","subscription_url":"https://api.github.com/repos/dr-redoute/order/subscription","commits_url":"https://api.github.com/repos/dr-redoute/order/commits{/sha}","git_commits_url":"https://api.github.com/repos/dr-redoute/order/git/commits{/sha}","comments_url":"https://api.github.com/repos/dr-redoute/order/comments{/number}","issue_comment_url":"https://api.github.com/repos/dr-redoute/order/issues/comments{/number}","contents_url":"https://api.github.com/repos/dr-redoute/order/contents/{+path}","compare_url":"https://api.github.com/repos/dr-redoute/order/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dr-redoute/order/merges","archive_url":"https://api.github.com/repos/dr-redoute/order/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dr-redoute/order/downloads","issues_url":"https://api.github.com/repos/dr-redoute/order/issues{/number}","pulls_url":"https://api.github.com/repos/dr-redoute/order/pulls{/number}","milestones_url":"https://api.github.com/repos/dr-redoute/order/milestones{/number}","notifications_url":"https://api.github.com/repos/dr-redoute/order/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dr-redoute/order/labels{/name}","releases_url":"https://api.github.com/repos/dr-redoute/order/releases{/id}","deployments_url":"https://api.github.com/repos/dr-redoute/order/deployments","created_at":"2016-10-04T14:26:51Z","updated_at":"2016-10-04T14:26:53Z","pushed_at":"2016-10-26T10:02:46Z","git_url":"git://github.com/dr-redoute/order.git","ssh_url":"git@github.com:dr-redoute/order.git","clone_url":"https://github.com/dr-redoute/order.git","svn_url":"https://github.com/dr-redoute/order","homepage":null,"size":2066,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pluginsGLPI:master","ref":"master","sha":"5592e9a1c2c5e23a8114eac23b14c13371e645af","user":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars.githubusercontent.com/u/10156352?v=3","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"repo":{"id":40370076,"name":"order","full_name":"pluginsGLPI/order","owner":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars.githubusercontent.com/u/10156352?v=3","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pluginsGLPI/order","description":"Order plugin for GLPI","fork":false,"url":"https://api.github.com/repos/pluginsGLPI/order","forks_url":"https://api.github.com/repos/pluginsGLPI/order/forks","keys_url":"https://api.github.com/repos/pluginsGLPI/order/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluginsGLPI/order/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluginsGLPI/order/teams","hooks_url":"https://api.github.com/repos/pluginsGLPI/order/hooks","issue_events_url":"https://api.github.com/repos/pluginsGLPI/order/issues/events{/number}","events_url":"https://api.github.com/repos/pluginsGLPI/order/events","assignees_url":"https://api.github.com/repos/pluginsGLPI/order/assignees{/user}","branches_url":"https://api.github.com/repos/pluginsGLPI/order/branches{/branch}","tags_url":"https://api.github.com/repos/pluginsGLPI/order/tags","blobs_url":"https://api.github.com/repos/pluginsGLPI/order/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluginsGLPI/order/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluginsGLPI/order/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluginsGLPI/order/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluginsGLPI/order/statuses/{sha}","languages_url":"https://api.github.com/repos/pluginsGLPI/order/languages","stargazers_url":"https://api.github.com/repos/pluginsGLPI/order/stargazers","contributors_url":"https://api.github.com/repos/pluginsGLPI/order/contributors","subscribers_url":"https://api.github.com/repos/pluginsGLPI/order/subscribers","subscription_url":"https://api.github.com/repos/pluginsGLPI/order/subscription","commits_url":"https://api.github.com/repos/pluginsGLPI/order/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluginsGLPI/order/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluginsGLPI/order/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluginsGLPI/order/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluginsGLPI/order/contents/{+path}","compare_url":"https://api.github.com/repos/pluginsGLPI/order/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluginsGLPI/order/merges","archive_url":"https://api.github.com/repos/pluginsGLPI/order/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluginsGLPI/order/downloads","issues_url":"https://api.github.com/repos/pluginsGLPI/order/issues{/number}","pulls_url":"https://api.github.com/repos/pluginsGLPI/order/pulls{/number}","milestones_url":"https://api.github.com/repos/pluginsGLPI/order/milestones{/number}","notifications_url":"https://api.github.com/repos/pluginsGLPI/order/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluginsGLPI/order/labels{/name}","releases_url":"https://api.github.com/repos/pluginsGLPI/order/releases{/id}","deployments_url":"https://api.github.com/repos/pluginsGLPI/order/deployments","created_at":"2015-08-07T16:29:54Z","updated_at":"2016-10-25T06:14:51Z","pushed_at":"2016-10-26T10:05:11Z","git_url":"git://github.com/pluginsGLPI/order.git","ssh_url":"git@github.com:pluginsGLPI/order.git","clone_url":"https://github.com/pluginsGLPI/order.git","svn_url":"https://github.com/pluginsGLPI/order","homepage":null,"size":2533,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":34,"forks":19,"open_issues":34,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/79"},"html":{"href":"https://github.com/pluginsGLPI/order/pull/79"},"issue":{"href":"https://api.github.com/repos/pluginsGLPI/order/issues/79"},"comments":{"href":"https://api.github.com/repos/pluginsGLPI/order/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pluginsGLPI/order/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/pluginsGLPI/order/statuses/ff23f437e684f5e2fd8a3f8cf1db880cdff4caaf"}}}}
{"actor":{"display_login":"trasher"}}