{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/comments/77242710","id":77242710,"diff_hunk":"@@ -34,21 +33,25 @@ namespace System.ServiceModel.Channels\n     /// </summary>\n     internal sealed class BufferedWriteStream : Stream\n     {\n-        public const int DefaultBufferSize = 4096;\n+        public const int DefaultBufferSize = 8192;","path":"src/System.Private.ServiceModel/src/System/ServiceModel/Channels/BufferedWriteStream.cs","position":13,"original_position":13,"commit_id":"33e3167a1f0703e68cea7e8131476ea8a1df0a83","original_commit_id":"33e3167a1f0703e68cea7e8131476ea8a1df0a83","user":{"login":"mconnew","id":8648390,"avatar_url":"https://avatars.githubusercontent.com/u/8648390?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnew","html_url":"https://github.com/mconnew","followers_url":"https://api.github.com/users/mconnew/followers","following_url":"https://api.github.com/users/mconnew/following{/other_user}","gists_url":"https://api.github.com/users/mconnew/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnew/subscriptions","organizations_url":"https://api.github.com/users/mconnew/orgs","repos_url":"https://api.github.com/users/mconnew/repos","events_url":"https://api.github.com/users/mconnew/events{/privacy}","received_events_url":"https://api.github.com/users/mconnew/received_events","type":"User","site_admin":false},"body":"Yes, perf improvement. As we have a synchronous read/write path in streaming scenarios, this reduces the number of times we require 2 threads to do anything. Additionally, the buffers now comes from the BufferManager so if the stream is disposed, this will reduce memory consumption so the larger buffer won't have a negative effect.","created_at":"2016-09-01T19:58:33Z","updated_at":"2016-09-01T19:58:33Z","html_url":"https://github.com/dotnet/wcf/pull/1495#discussion_r77242710","pull_request_url":"https://api.github.com/repos/dotnet/wcf/pulls/1495","_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments/77242710"},"html":{"href":"https://github.com/dotnet/wcf/pull/1495#discussion_r77242710"},"pull_request":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1495"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/1495","id":83150434,"html_url":"https://github.com/dotnet/wcf/pull/1495","diff_url":"https://github.com/dotnet/wcf/pull/1495.diff","patch_url":"https://github.com/dotnet/wcf/pull/1495.patch","issue_url":"https://api.github.com/repos/dotnet/wcf/issues/1495","number":1495,"state":"open","locked":false,"title":"Fix Net.Tcp duplex streaming with authentication","user":{"login":"mconnew","id":8648390,"avatar_url":"https://avatars.githubusercontent.com/u/8648390?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnew","html_url":"https://github.com/mconnew","followers_url":"https://api.github.com/users/mconnew/followers","following_url":"https://api.github.com/users/mconnew/following{/other_user}","gists_url":"https://api.github.com/users/mconnew/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnew/subscriptions","organizations_url":"https://api.github.com/users/mconnew/orgs","repos_url":"https://api.github.com/users/mconnew/repos","events_url":"https://api.github.com/users/mconnew/events{/privacy}","received_events_url":"https://api.github.com/users/mconnew/received_events","type":"User","site_admin":false},"body":"Fixes #1443 \r\nAlso improves performance with HTTP streaming and stops threadpool exhaustion with synchronous calls.\r\nAlso fixes an issue where our pre-fetch GET for authentication was causing a null-ref exception which was (correctly) being caught and ignored.","created_at":"2016-08-29T19:08:26Z","updated_at":"2016-09-01T19:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6acab2dbc84cd7cc9c54d6fd1e21834d054637c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/wcf/pulls/1495/commits","review_comments_url":"https://api.github.com/repos/dotnet/wcf/pulls/1495/comments","review_comment_url":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/wcf/issues/1495/comments","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/33e3167a1f0703e68cea7e8131476ea8a1df0a83","head":{"label":"mconnew:Issue1467","ref":"Issue1467","sha":"33e3167a1f0703e68cea7e8131476ea8a1df0a83","user":{"login":"mconnew","id":8648390,"avatar_url":"https://avatars.githubusercontent.com/u/8648390?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnew","html_url":"https://github.com/mconnew","followers_url":"https://api.github.com/users/mconnew/followers","following_url":"https://api.github.com/users/mconnew/following{/other_user}","gists_url":"https://api.github.com/users/mconnew/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnew/subscriptions","organizations_url":"https://api.github.com/users/mconnew/orgs","repos_url":"https://api.github.com/users/mconnew/repos","events_url":"https://api.github.com/users/mconnew/events{/privacy}","received_events_url":"https://api.github.com/users/mconnew/received_events","type":"User","site_admin":false},"repo":{"id":35959856,"name":"wcf","full_name":"mconnew/wcf","owner":{"login":"mconnew","id":8648390,"avatar_url":"https://avatars.githubusercontent.com/u/8648390?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnew","html_url":"https://github.com/mconnew","followers_url":"https://api.github.com/users/mconnew/followers","following_url":"https://api.github.com/users/mconnew/following{/other_user}","gists_url":"https://api.github.com/users/mconnew/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnew/subscriptions","organizations_url":"https://api.github.com/users/mconnew/orgs","repos_url":"https://api.github.com/users/mconnew/repos","events_url":"https://api.github.com/users/mconnew/events{/privacy}","received_events_url":"https://api.github.com/users/mconnew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mconnew/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":true,"url":"https://api.github.com/repos/mconnew/wcf","forks_url":"https://api.github.com/repos/mconnew/wcf/forks","keys_url":"https://api.github.com/repos/mconnew/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mconnew/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mconnew/wcf/teams","hooks_url":"https://api.github.com/repos/mconnew/wcf/hooks","issue_events_url":"https://api.github.com/repos/mconnew/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/mconnew/wcf/events","assignees_url":"https://api.github.com/repos/mconnew/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/mconnew/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/mconnew/wcf/tags","blobs_url":"https://api.github.com/repos/mconnew/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mconnew/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mconnew/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mconnew/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mconnew/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/mconnew/wcf/languages","stargazers_url":"https://api.github.com/repos/mconnew/wcf/stargazers","contributors_url":"https://api.github.com/repos/mconnew/wcf/contributors","subscribers_url":"https://api.github.com/repos/mconnew/wcf/subscribers","subscription_url":"https://api.github.com/repos/mconnew/wcf/subscription","commits_url":"https://api.github.com/repos/mconnew/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mconnew/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mconnew/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mconnew/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mconnew/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/mconnew/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mconnew/wcf/merges","archive_url":"https://api.github.com/repos/mconnew/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mconnew/wcf/downloads","issues_url":"https://api.github.com/repos/mconnew/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/mconnew/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/mconnew/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/mconnew/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mconnew/wcf/labels{/name}","releases_url":"https://api.github.com/repos/mconnew/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/mconnew/wcf/deployments","created_at":"2015-05-20T16:24:51Z","updated_at":"2016-01-12T08:02:10Z","pushed_at":"2016-08-29T18:58:17Z","git_url":"git://github.com/mconnew/wcf.git","ssh_url":"git@github.com:mconnew/wcf.git","clone_url":"https://github.com/mconnew/wcf.git","svn_url":"https://github.com/mconnew/wcf","homepage":"","size":6634,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"aedb049318058cbde1bd33692d3b2ff88a1b2886","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35562993,"name":"wcf","full_name":"dotnet/wcf","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":false,"url":"https://api.github.com/repos/dotnet/wcf","forks_url":"https://api.github.com/repos/dotnet/wcf/forks","keys_url":"https://api.github.com/repos/dotnet/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/wcf/teams","hooks_url":"https://api.github.com/repos/dotnet/wcf/hooks","issue_events_url":"https://api.github.com/repos/dotnet/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/wcf/events","assignees_url":"https://api.github.com/repos/dotnet/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/wcf/tags","blobs_url":"https://api.github.com/repos/dotnet/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/wcf/languages","stargazers_url":"https://api.github.com/repos/dotnet/wcf/stargazers","contributors_url":"https://api.github.com/repos/dotnet/wcf/contributors","subscribers_url":"https://api.github.com/repos/dotnet/wcf/subscribers","subscription_url":"https://api.github.com/repos/dotnet/wcf/subscription","commits_url":"https://api.github.com/repos/dotnet/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/wcf/merges","archive_url":"https://api.github.com/repos/dotnet/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/wcf/downloads","issues_url":"https://api.github.com/repos/dotnet/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/wcf/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/wcf/deployments","created_at":"2015-05-13T17:17:03Z","updated_at":"2016-08-30T18:30:34Z","pushed_at":"2016-09-01T18:13:50Z","git_url":"git://github.com/dotnet/wcf.git","ssh_url":"git@github.com:dotnet/wcf.git","clone_url":"https://github.com/dotnet/wcf.git","svn_url":"https://github.com/dotnet/wcf","homepage":"","size":8680,"stargazers_count":687,"watchers_count":687,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"open_issues_count":179,"forks":241,"open_issues":179,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1495"},"html":{"href":"https://github.com/dotnet/wcf/pull/1495"},"issue":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1495"},"comments":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1495/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1495/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1495/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/wcf/statuses/33e3167a1f0703e68cea7e8131476ea8a1df0a83"}}}}
{"actor":{"display_login":"mconnew"}}