{"action":"created","comment":{"url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/comments/61673758","id":61673758,"diff_hunk":"@@ -356,21 +356,23 @@ set_target_properties (${PROJECT_NAME} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PRO\n set_target_properties (${PROJECT_NAME} PROPERTIES ARCHIVE_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR})\n \n target_link_libraries (${PROJECT_NAME} ${NN_REQUIRED_LIBRARIES})\n-if (WIN32)\n-    target_link_libraries (${PROJECT_NAME} ws2_32)\n-    target_link_libraries (${PROJECT_NAME} mswsock)\n-    target_link_libraries (${PROJECT_NAME} advapi32)\n-elseif (UNIX)\n-    if(THREADS_HAVE_PTHREAD_ARG)\n-        add_definitions (-pthread)\n-    endif()\n-    if(CMAKE_THREAD_LIBS_INIT)\n-        target_link_libraries (${PROJECT_NAME} \"${CMAKE_THREAD_LIBS_INIT}\")\n-    endif()\n-else ()\n-    message (FATAL_ERROR \"Assertion failed; this path is unreachable.\")\n-endif ()\n+if(THREADS_HAVE_PTHREAD_ARG)\n+    add_definitions (-pthread)\n+endif()\n+if(CMAKE_THREAD_LIBS_INIT)\n+    target_link_libraries (${PROJECT_NAME} \"${CMAKE_THREAD_LIBS_INIT}\")\n+endif()\n \n+# pkg-config file\n+if(NN_REQUIRED_LIBRARIES)\n+    foreach (lib ${NN_REQUIRED_LIBRARIES})\n+        set (NN_REQUIRED_LFLAGS \"${NN_REQUIRED_LFLAGS} -l${lib}\")","path":"src/CMakeLists.txt","position":28,"original_position":28,"commit_id":"53fb83ec118813b7d3ff94651365ff738477b759","original_commit_id":"53fb83ec118813b7d3ff94651365ff738477b759","user":{"login":"Snaipe","id":977973,"avatar_url":"https://avatars.githubusercontent.com/u/977973?v=3","gravatar_id":"","url":"https://api.github.com/users/Snaipe","html_url":"https://github.com/Snaipe","followers_url":"https://api.github.com/users/Snaipe/followers","following_url":"https://api.github.com/users/Snaipe/following{/other_user}","gists_url":"https://api.github.com/users/Snaipe/gists{/gist_id}","starred_url":"https://api.github.com/users/Snaipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snaipe/subscriptions","organizations_url":"https://api.github.com/users/Snaipe/orgs","repos_url":"https://api.github.com/users/Snaipe/repos","events_url":"https://api.github.com/users/Snaipe/events{/privacy}","received_events_url":"https://api.github.com/users/Snaipe/received_events","type":"User","site_admin":false},"body":"Following the current CMakeLists.txt, this is going to have `-lpthread` rather than `-pthread`. I don't think it matters in practice though (I've never seen any pthread linker flag other than `-lpthread`), but it might be desirable for compliance/portability of user programs.","created_at":"2016-04-30T19:19:16Z","updated_at":"2016-04-30T19:19:16Z","html_url":"https://github.com/nanomsg/nanomsg/pull/686#discussion_r61673758","pull_request_url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686","_links":{"self":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/comments/61673758"},"html":{"href":"https://github.com/nanomsg/nanomsg/pull/686#discussion_r61673758"},"pull_request":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686"}}},"pull_request":{"url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686","id":68476117,"html_url":"https://github.com/nanomsg/nanomsg/pull/686","diff_url":"https://github.com/nanomsg/nanomsg/pull/686.diff","patch_url":"https://github.com/nanomsg/nanomsg/pull/686.patch","issue_url":"https://api.github.com/repos/nanomsg/nanomsg/issues/686","number":686,"state":"open","locked":false,"title":"fixes #685 cmake needs to deliver libnanomsg.pc (pkg-config data file)","user":{"login":"gdamore","id":1295229,"avatar_url":"https://avatars.githubusercontent.com/u/1295229?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamore","html_url":"https://github.com/gdamore","followers_url":"https://api.github.com/users/gdamore/followers","following_url":"https://api.github.com/users/gdamore/following{/other_user}","gists_url":"https://api.github.com/users/gdamore/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamore/subscriptions","organizations_url":"https://api.github.com/users/gdamore/orgs","repos_url":"https://api.github.com/users/gdamore/repos","events_url":"https://api.github.com/users/gdamore/events{/privacy}","received_events_url":"https://api.github.com/users/gdamore/received_events","type":"User","site_admin":false},"body":"This creates a file, nanomsg.pc  -- (note the absence of the leading lib prefix) for nanomsg.)\r\n\r\nThis new file behaves as specified in #561 -- and furthermore, simplifies Windows library detection works -- checking using the same tests we use for other platforms.  (Hopefully it will work!)\r\n\r\nAs a  bonus, it corrects the Libs.private entry so that users wanting to link statically can get the right answers with pkg-config --static --libs nanomsg\r\n\r\nThe version emitted is the library version, not the ABI version.\r\n\r\nThis pkg-config file departs rather significantly from the version used in autotools; folks relying on it will have to change things.  But this is a big improvement IMO.","created_at":"2016-04-30T19:04:44Z","updated_at":"2016-04-30T19:19:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b53c5dd3e96f900071b6f91b445527950fd873c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686/commits","review_comments_url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686/comments","review_comment_url":"https://api.github.com/repos/nanomsg/nanomsg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nanomsg/nanomsg/issues/686/comments","statuses_url":"https://api.github.com/repos/nanomsg/nanomsg/statuses/53fb83ec118813b7d3ff94651365ff738477b759","head":{"label":"gdamore:pkgconfig","ref":"pkgconfig","sha":"53fb83ec118813b7d3ff94651365ff738477b759","user":{"login":"gdamore","id":1295229,"avatar_url":"https://avatars.githubusercontent.com/u/1295229?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamore","html_url":"https://github.com/gdamore","followers_url":"https://api.github.com/users/gdamore/followers","following_url":"https://api.github.com/users/gdamore/following{/other_user}","gists_url":"https://api.github.com/users/gdamore/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamore/subscriptions","organizations_url":"https://api.github.com/users/gdamore/orgs","repos_url":"https://api.github.com/users/gdamore/repos","events_url":"https://api.github.com/users/gdamore/events{/privacy}","received_events_url":"https://api.github.com/users/gdamore/received_events","type":"User","site_admin":false},"repo":{"id":18065990,"name":"nanomsg","full_name":"gdamore/nanomsg","owner":{"login":"gdamore","id":1295229,"avatar_url":"https://avatars.githubusercontent.com/u/1295229?v=3","gravatar_id":"","url":"https://api.github.com/users/gdamore","html_url":"https://github.com/gdamore","followers_url":"https://api.github.com/users/gdamore/followers","following_url":"https://api.github.com/users/gdamore/following{/other_user}","gists_url":"https://api.github.com/users/gdamore/gists{/gist_id}","starred_url":"https://api.github.com/users/gdamore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdamore/subscriptions","organizations_url":"https://api.github.com/users/gdamore/orgs","repos_url":"https://api.github.com/users/gdamore/repos","events_url":"https://api.github.com/users/gdamore/events{/privacy}","received_events_url":"https://api.github.com/users/gdamore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdamore/nanomsg","description":"nanomsg library","fork":true,"url":"https://api.github.com/repos/gdamore/nanomsg","forks_url":"https://api.github.com/repos/gdamore/nanomsg/forks","keys_url":"https://api.github.com/repos/gdamore/nanomsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdamore/nanomsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdamore/nanomsg/teams","hooks_url":"https://api.github.com/repos/gdamore/nanomsg/hooks","issue_events_url":"https://api.github.com/repos/gdamore/nanomsg/issues/events{/number}","events_url":"https://api.github.com/repos/gdamore/nanomsg/events","assignees_url":"https://api.github.com/repos/gdamore/nanomsg/assignees{/user}","branches_url":"https://api.github.com/repos/gdamore/nanomsg/branches{/branch}","tags_url":"https://api.github.com/repos/gdamore/nanomsg/tags","blobs_url":"https://api.github.com/repos/gdamore/nanomsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdamore/nanomsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdamore/nanomsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdamore/nanomsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdamore/nanomsg/statuses/{sha}","languages_url":"https://api.github.com/repos/gdamore/nanomsg/languages","stargazers_url":"https://api.github.com/repos/gdamore/nanomsg/stargazers","contributors_url":"https://api.github.com/repos/gdamore/nanomsg/contributors","subscribers_url":"https://api.github.com/repos/gdamore/nanomsg/subscribers","subscription_url":"https://api.github.com/repos/gdamore/nanomsg/subscription","commits_url":"https://api.github.com/repos/gdamore/nanomsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdamore/nanomsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdamore/nanomsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdamore/nanomsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdamore/nanomsg/contents/{+path}","compare_url":"https://api.github.com/repos/gdamore/nanomsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdamore/nanomsg/merges","archive_url":"https://api.github.com/repos/gdamore/nanomsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdamore/nanomsg/downloads","issues_url":"https://api.github.com/repos/gdamore/nanomsg/issues{/number}","pulls_url":"https://api.github.com/repos/gdamore/nanomsg/pulls{/number}","milestones_url":"https://api.github.com/repos/gdamore/nanomsg/milestones{/number}","notifications_url":"https://api.github.com/repos/gdamore/nanomsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdamore/nanomsg/labels{/name}","releases_url":"https://api.github.com/repos/gdamore/nanomsg/releases{/id}","deployments_url":"https://api.github.com/repos/gdamore/nanomsg/deployments","created_at":"2014-03-24T14:48:56Z","updated_at":"2016-04-13T01:03:05Z","pushed_at":"2016-04-30T19:17:41Z","git_url":"git://github.com/gdamore/nanomsg.git","ssh_url":"git@github.com:gdamore/nanomsg.git","clone_url":"https://github.com/gdamore/nanomsg.git","svn_url":"https://github.com/gdamore/nanomsg","homepage":"","size":6706,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nanomsg:master","ref":"master","sha":"20afcf864f71803f1c5a0d7a3d45d56372f77f3e","user":{"login":"nanomsg","id":5398713,"avatar_url":"https://avatars.githubusercontent.com/u/5398713?v=3","gravatar_id":"","url":"https://api.github.com/users/nanomsg","html_url":"https://github.com/nanomsg","followers_url":"https://api.github.com/users/nanomsg/followers","following_url":"https://api.github.com/users/nanomsg/following{/other_user}","gists_url":"https://api.github.com/users/nanomsg/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomsg/subscriptions","organizations_url":"https://api.github.com/users/nanomsg/orgs","repos_url":"https://api.github.com/users/nanomsg/repos","events_url":"https://api.github.com/users/nanomsg/events{/privacy}","received_events_url":"https://api.github.com/users/nanomsg/received_events","type":"Organization","site_admin":false},"repo":{"id":6154315,"name":"nanomsg","full_name":"nanomsg/nanomsg","owner":{"login":"nanomsg","id":5398713,"avatar_url":"https://avatars.githubusercontent.com/u/5398713?v=3","gravatar_id":"","url":"https://api.github.com/users/nanomsg","html_url":"https://github.com/nanomsg","followers_url":"https://api.github.com/users/nanomsg/followers","following_url":"https://api.github.com/users/nanomsg/following{/other_user}","gists_url":"https://api.github.com/users/nanomsg/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomsg/subscriptions","organizations_url":"https://api.github.com/users/nanomsg/orgs","repos_url":"https://api.github.com/users/nanomsg/repos","events_url":"https://api.github.com/users/nanomsg/events{/privacy}","received_events_url":"https://api.github.com/users/nanomsg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nanomsg/nanomsg","description":"nanomsg library","fork":false,"url":"https://api.github.com/repos/nanomsg/nanomsg","forks_url":"https://api.github.com/repos/nanomsg/nanomsg/forks","keys_url":"https://api.github.com/repos/nanomsg/nanomsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanomsg/nanomsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanomsg/nanomsg/teams","hooks_url":"https://api.github.com/repos/nanomsg/nanomsg/hooks","issue_events_url":"https://api.github.com/repos/nanomsg/nanomsg/issues/events{/number}","events_url":"https://api.github.com/repos/nanomsg/nanomsg/events","assignees_url":"https://api.github.com/repos/nanomsg/nanomsg/assignees{/user}","branches_url":"https://api.github.com/repos/nanomsg/nanomsg/branches{/branch}","tags_url":"https://api.github.com/repos/nanomsg/nanomsg/tags","blobs_url":"https://api.github.com/repos/nanomsg/nanomsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanomsg/nanomsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanomsg/nanomsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanomsg/nanomsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanomsg/nanomsg/statuses/{sha}","languages_url":"https://api.github.com/repos/nanomsg/nanomsg/languages","stargazers_url":"https://api.github.com/repos/nanomsg/nanomsg/stargazers","contributors_url":"https://api.github.com/repos/nanomsg/nanomsg/contributors","subscribers_url":"https://api.github.com/repos/nanomsg/nanomsg/subscribers","subscription_url":"https://api.github.com/repos/nanomsg/nanomsg/subscription","commits_url":"https://api.github.com/repos/nanomsg/nanomsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanomsg/nanomsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanomsg/nanomsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanomsg/nanomsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanomsg/nanomsg/contents/{+path}","compare_url":"https://api.github.com/repos/nanomsg/nanomsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanomsg/nanomsg/merges","archive_url":"https://api.github.com/repos/nanomsg/nanomsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanomsg/nanomsg/downloads","issues_url":"https://api.github.com/repos/nanomsg/nanomsg/issues{/number}","pulls_url":"https://api.github.com/repos/nanomsg/nanomsg/pulls{/number}","milestones_url":"https://api.github.com/repos/nanomsg/nanomsg/milestones{/number}","notifications_url":"https://api.github.com/repos/nanomsg/nanomsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanomsg/nanomsg/labels{/name}","releases_url":"https://api.github.com/repos/nanomsg/nanomsg/releases{/id}","deployments_url":"https://api.github.com/repos/nanomsg/nanomsg/deployments","created_at":"2012-10-10T08:32:14Z","updated_at":"2016-04-30T18:43:38Z","pushed_at":"2016-04-30T19:17:41Z","git_url":"git://github.com/nanomsg/nanomsg.git","ssh_url":"git@github.com:nanomsg/nanomsg.git","clone_url":"https://github.com/nanomsg/nanomsg.git","svn_url":"https://github.com/nanomsg/nanomsg","homepage":"","size":8803,"stargazers_count":2740,"watchers_count":2740,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":429,"mirror_url":null,"open_issues_count":46,"forks":429,"open_issues":46,"watchers":2740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686"},"html":{"href":"https://github.com/nanomsg/nanomsg/pull/686"},"issue":{"href":"https://api.github.com/repos/nanomsg/nanomsg/issues/686"},"comments":{"href":"https://api.github.com/repos/nanomsg/nanomsg/issues/686/comments"},"review_comments":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686/comments"},"review_comment":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nanomsg/nanomsg/pulls/686/commits"},"statuses":{"href":"https://api.github.com/repos/nanomsg/nanomsg/statuses/53fb83ec118813b7d3ff94651365ff738477b759"}}}}