{"action":"closed","number":1388,"pull_request":{"url":"https://api.github.com/repos/enyojs/enyo/pulls/1388","id":60034755,"html_url":"https://github.com/enyojs/enyo/pull/1388","diff_url":"https://github.com/enyojs/enyo/pull/1388.diff","patch_url":"https://github.com/enyojs/enyo/pull/1388.patch","issue_url":"https://api.github.com/repos/enyojs/enyo/issues/1388","number":1388,"state":"closed","locked":false,"title":"ENYO-3098: Switch to a logical panel after replacement occurs.","user":{"login":"aarontam","id":463191,"avatar_url":"https://avatars.githubusercontent.com/u/463191?v=3","gravatar_id":"","url":"https://api.github.com/users/aarontam","html_url":"https://github.com/aarontam","followers_url":"https://api.github.com/users/aarontam/followers","following_url":"https://api.github.com/users/aarontam/following{/other_user}","gists_url":"https://api.github.com/users/aarontam/gists{/gist_id}","starred_url":"https://api.github.com/users/aarontam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarontam/subscriptions","organizations_url":"https://api.github.com/users/aarontam/orgs","repos_url":"https://api.github.com/users/aarontam/repos","events_url":"https://api.github.com/users/aarontam/events{/privacy}","received_events_url":"https://api.github.com/users/aarontam/received_events","type":"User","site_admin":false},"body":"### Issue\r\nWhen using `replaceAt`, we weren't doing anything intelligent with respect to the destination index, after the replacement had completed. This could result in being left with a panel-less display (not a TV panel, mind you).\r\n\r\n### Fix\r\nWe have added options support to `replaceAt`, which takes in the same options set as `pushPanel`/`pushPanels` for consistency. We are only concerned with `targetIndex` for the time being, which is used if specified, otherwise the first replacement panel will become the destination panel, after the replacement.\r\n\r\nEnyo-DCO-1.1-Signed-off-by: Aaron Tam <aaron.tam@lge.com>","created_at":"2016-02-20T02:45:20Z","updated_at":"2016-02-27T01:00:00Z","closed_at":"2016-02-27T01:00:00Z","merged_at":"2016-02-27T01:00:00Z","merge_commit_sha":"f6fb8ecce6f8767a74fa8acd87403af548569ea2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/enyo/pulls/1388/commits","review_comments_url":"https://api.github.com/repos/enyojs/enyo/pulls/1388/comments","review_comment_url":"https://api.github.com/repos/enyojs/enyo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enyojs/enyo/issues/1388/comments","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/c866d971f035f38e706f681e50541cf863e95ab2","head":{"label":"enyojs:ENYO-3098-aarontam","ref":"ENYO-3098-aarontam","sha":"c866d971f035f38e706f681e50541cf863e95ab2","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":2983241,"name":"enyo","full_name":"enyojs/enyo","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/enyo","description":"A JavaScript application framework emphasizing modularity and encapsulation","fork":false,"url":"https://api.github.com/repos/enyojs/enyo","forks_url":"https://api.github.com/repos/enyojs/enyo/forks","keys_url":"https://api.github.com/repos/enyojs/enyo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/enyo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/enyo/teams","hooks_url":"https://api.github.com/repos/enyojs/enyo/hooks","issue_events_url":"https://api.github.com/repos/enyojs/enyo/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/enyo/events","assignees_url":"https://api.github.com/repos/enyojs/enyo/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/enyo/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/enyo/tags","blobs_url":"https://api.github.com/repos/enyojs/enyo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/enyo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/enyo/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/enyo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/enyo/languages","stargazers_url":"https://api.github.com/repos/enyojs/enyo/stargazers","contributors_url":"https://api.github.com/repos/enyojs/enyo/contributors","subscribers_url":"https://api.github.com/repos/enyojs/enyo/subscribers","subscription_url":"https://api.github.com/repos/enyojs/enyo/subscription","commits_url":"https://api.github.com/repos/enyojs/enyo/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/enyo/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/enyo/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/enyo/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/enyo/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/enyo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/enyo/merges","archive_url":"https://api.github.com/repos/enyojs/enyo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/enyo/downloads","issues_url":"https://api.github.com/repos/enyojs/enyo/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/enyo/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/enyo/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/enyo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/enyo/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/enyo/releases{/id}","deployments_url":"https://api.github.com/repos/enyojs/enyo/deployments","created_at":"2011-12-14T21:30:25Z","updated_at":"2016-02-21T22:22:14Z","pushed_at":"2016-02-27T01:00:00Z","git_url":"git://github.com/enyojs/enyo.git","ssh_url":"git@github.com:enyojs/enyo.git","clone_url":"https://github.com/enyojs/enyo.git","svn_url":"https://github.com/enyojs/enyo","homepage":"","size":29724,"stargazers_count":1914,"watchers_count":1914,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":28,"forks":289,"open_issues":28,"watchers":1914,"default_branch":"master"}},"base":{"label":"enyojs:2.6.0-dev","ref":"2.6.0-dev","sha":"5bc95ff6bd497b1f2974a122984948c67e74d546","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":2983241,"name":"enyo","full_name":"enyojs/enyo","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/enyo","description":"A JavaScript application framework emphasizing modularity and encapsulation","fork":false,"url":"https://api.github.com/repos/enyojs/enyo","forks_url":"https://api.github.com/repos/enyojs/enyo/forks","keys_url":"https://api.github.com/repos/enyojs/enyo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/enyo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/enyo/teams","hooks_url":"https://api.github.com/repos/enyojs/enyo/hooks","issue_events_url":"https://api.github.com/repos/enyojs/enyo/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/enyo/events","assignees_url":"https://api.github.com/repos/enyojs/enyo/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/enyo/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/enyo/tags","blobs_url":"https://api.github.com/repos/enyojs/enyo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/enyo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/enyo/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/enyo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/enyo/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/enyo/languages","stargazers_url":"https://api.github.com/repos/enyojs/enyo/stargazers","contributors_url":"https://api.github.com/repos/enyojs/enyo/contributors","subscribers_url":"https://api.github.com/repos/enyojs/enyo/subscribers","subscription_url":"https://api.github.com/repos/enyojs/enyo/subscription","commits_url":"https://api.github.com/repos/enyojs/enyo/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/enyo/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/enyo/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/enyo/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/enyo/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/enyo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/enyo/merges","archive_url":"https://api.github.com/repos/enyojs/enyo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/enyo/downloads","issues_url":"https://api.github.com/repos/enyojs/enyo/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/enyo/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/enyo/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/enyo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/enyo/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/enyo/releases{/id}","deployments_url":"https://api.github.com/repos/enyojs/enyo/deployments","created_at":"2011-12-14T21:30:25Z","updated_at":"2016-02-21T22:22:14Z","pushed_at":"2016-02-27T01:00:00Z","git_url":"git://github.com/enyojs/enyo.git","ssh_url":"git@github.com:enyojs/enyo.git","clone_url":"https://github.com/enyojs/enyo.git","svn_url":"https://github.com/enyojs/enyo","homepage":"","size":29724,"stargazers_count":1914,"watchers_count":1914,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":28,"forks":289,"open_issues":28,"watchers":1914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/1388"},"html":{"href":"https://github.com/enyojs/enyo/pull/1388"},"issue":{"href":"https://api.github.com/repos/enyojs/enyo/issues/1388"},"comments":{"href":"https://api.github.com/repos/enyojs/enyo/issues/1388/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/1388/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enyojs/enyo/pulls/1388/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/enyo/statuses/c866d971f035f38e706f681e50541cf863e95ab2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"webOS101","id":328450,"avatar_url":"https://avatars.githubusercontent.com/u/328450?v=3","gravatar_id":"","url":"https://api.github.com/users/webOS101","html_url":"https://github.com/webOS101","followers_url":"https://api.github.com/users/webOS101/followers","following_url":"https://api.github.com/users/webOS101/following{/other_user}","gists_url":"https://api.github.com/users/webOS101/gists{/gist_id}","starred_url":"https://api.github.com/users/webOS101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webOS101/subscriptions","organizations_url":"https://api.github.com/users/webOS101/orgs","repos_url":"https://api.github.com/users/webOS101/repos","events_url":"https://api.github.com/users/webOS101/events{/privacy}","received_events_url":"https://api.github.com/users/webOS101/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":7,"changed_files":1}}