{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/58571618","id":58571618,"diff_hunk":"@@ -18,6 +18,18 @@\n   # Vultr account api key\n   api_key: <supersecretapi_key>\n   driver: vultr\n+  \n+  \n+Set up the cloud profile at ``/etc/salt/cloud.profiles`` or\n+``/etc/salt/cloud.profiles.d/vultr.conf``:\n+\n+.. code-block:: yaml\n+nyc-4gb-4cpu-ubuntu-14-04:","path":"salt/cloud/clouds/vultrpy.py","position":10,"original_position":10,"commit_id":"910d47256434e47ebfcf6e8ed5bd68aa9c6fbe9e","original_commit_id":"910d47256434e47ebfcf6e8ed5bd68aa9c6fbe9e","user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"body":"To get this block to render properly in the docs, this entire example needs to be bumped in:\r\n```\r\n.. code-block:: yaml\r\n\r\n    nyc-4gb-4cpu-ubuntu-14-04:\r\n      location: 1\r\n      provider: my-vultr-config\r\n      image: 160\r\n      size: 95\r\n      enable_private_network: True\r\n```","created_at":"2016-04-05T16:37:16Z","updated_at":"2016-04-05T16:37:16Z","html_url":"https://github.com/saltstack/salt/pull/32362#discussion_r58571618","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/32362","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/58571618"},"html":{"href":"https://github.com/saltstack/salt/pull/32362#discussion_r58571618"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32362"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/32362","id":65330182,"html_url":"https://github.com/saltstack/salt/pull/32362","diff_url":"https://github.com/saltstack/salt/pull/32362.diff","patch_url":"https://github.com/saltstack/salt/pull/32362.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/32362","number":32362,"state":"open","locked":false,"title":"Support Private Networking and Hostnames","user":{"login":"naegelin","id":1544569,"avatar_url":"https://avatars.githubusercontent.com/u/1544569?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelin","html_url":"https://github.com/naegelin","followers_url":"https://api.github.com/users/naegelin/followers","following_url":"https://api.github.com/users/naegelin/following{/other_user}","gists_url":"https://api.github.com/users/naegelin/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelin/subscriptions","organizations_url":"https://api.github.com/users/naegelin/orgs","repos_url":"https://api.github.com/users/naegelin/repos","events_url":"https://api.github.com/users/naegelin/events{/privacy}","received_events_url":"https://api.github.com/users/naegelin/received_events","type":"User","site_admin":false},"body":"What does this PR do?\r\n\r\nSupport passing in hostname so the spun up instance does not default to 'vultr' as hostname\r\nSupport enabling private networking in the salt cloud profile\r\nExtend salt exceptions\r\nExtend documentation to be more inclusive of\r\nPrevious Behavior\r\n\r\nHostnames were defaulted to 'vultr'\r\nNon support for private networking\r\n\r\nTests written?\r\n\r\nNo - tested manually","created_at":"2016-04-05T15:59:43Z","updated_at":"2016-04-05T16:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3877968ef57cb62f8ab5cc3d6d054c6ae4d4535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/32362/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/32362/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/32362/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/910d47256434e47ebfcf6e8ed5bd68aa9c6fbe9e","head":{"label":"naegelin:develop","ref":"develop","sha":"910d47256434e47ebfcf6e8ed5bd68aa9c6fbe9e","user":{"login":"naegelin","id":1544569,"avatar_url":"https://avatars.githubusercontent.com/u/1544569?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelin","html_url":"https://github.com/naegelin","followers_url":"https://api.github.com/users/naegelin/followers","following_url":"https://api.github.com/users/naegelin/following{/other_user}","gists_url":"https://api.github.com/users/naegelin/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelin/subscriptions","organizations_url":"https://api.github.com/users/naegelin/orgs","repos_url":"https://api.github.com/users/naegelin/repos","events_url":"https://api.github.com/users/naegelin/events{/privacy}","received_events_url":"https://api.github.com/users/naegelin/received_events","type":"User","site_admin":false},"repo":{"id":55521528,"name":"salt","full_name":"naegelin/salt","owner":{"login":"naegelin","id":1544569,"avatar_url":"https://avatars.githubusercontent.com/u/1544569?v=3","gravatar_id":"","url":"https://api.github.com/users/naegelin","html_url":"https://github.com/naegelin","followers_url":"https://api.github.com/users/naegelin/followers","following_url":"https://api.github.com/users/naegelin/following{/other_user}","gists_url":"https://api.github.com/users/naegelin/gists{/gist_id}","starred_url":"https://api.github.com/users/naegelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naegelin/subscriptions","organizations_url":"https://api.github.com/users/naegelin/orgs","repos_url":"https://api.github.com/users/naegelin/repos","events_url":"https://api.github.com/users/naegelin/events{/privacy}","received_events_url":"https://api.github.com/users/naegelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naegelin/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/naegelin/salt","forks_url":"https://api.github.com/repos/naegelin/salt/forks","keys_url":"https://api.github.com/repos/naegelin/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naegelin/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naegelin/salt/teams","hooks_url":"https://api.github.com/repos/naegelin/salt/hooks","issue_events_url":"https://api.github.com/repos/naegelin/salt/issues/events{/number}","events_url":"https://api.github.com/repos/naegelin/salt/events","assignees_url":"https://api.github.com/repos/naegelin/salt/assignees{/user}","branches_url":"https://api.github.com/repos/naegelin/salt/branches{/branch}","tags_url":"https://api.github.com/repos/naegelin/salt/tags","blobs_url":"https://api.github.com/repos/naegelin/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naegelin/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naegelin/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/naegelin/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naegelin/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/naegelin/salt/languages","stargazers_url":"https://api.github.com/repos/naegelin/salt/stargazers","contributors_url":"https://api.github.com/repos/naegelin/salt/contributors","subscribers_url":"https://api.github.com/repos/naegelin/salt/subscribers","subscription_url":"https://api.github.com/repos/naegelin/salt/subscription","commits_url":"https://api.github.com/repos/naegelin/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/naegelin/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/naegelin/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/naegelin/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/naegelin/salt/contents/{+path}","compare_url":"https://api.github.com/repos/naegelin/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naegelin/salt/merges","archive_url":"https://api.github.com/repos/naegelin/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naegelin/salt/downloads","issues_url":"https://api.github.com/repos/naegelin/salt/issues{/number}","pulls_url":"https://api.github.com/repos/naegelin/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/naegelin/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/naegelin/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naegelin/salt/labels{/name}","releases_url":"https://api.github.com/repos/naegelin/salt/releases{/id}","deployments_url":"https://api.github.com/repos/naegelin/salt/deployments","created_at":"2016-04-05T15:53:49Z","updated_at":"2016-04-05T15:54:02Z","pushed_at":"2016-04-05T15:57:29Z","git_url":"git://github.com/naegelin/salt.git","ssh_url":"git@github.com:naegelin/salt.git","clone_url":"https://github.com/naegelin/salt.git","svn_url":"https://github.com/naegelin/salt","homepage":"https://repo.saltstack.com/","size":157600,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"5db7aec4305721614682efac0abbdb2576be3576","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-04-05T14:19:51Z","pushed_at":"2016-04-05T16:28:07Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":172280,"stargazers_count":6394,"watchers_count":6394,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2815,"mirror_url":null,"open_issues_count":3468,"forks":2815,"open_issues":3468,"watchers":6394,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32362"},"html":{"href":"https://github.com/saltstack/salt/pull/32362"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/32362"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/32362/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32362/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32362/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/910d47256434e47ebfcf6e8ed5bd68aa9c6fbe9e"}}}}