{"action":"opened","number":499,"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499","id":83141160,"html_url":"https://github.com/Microsoft/react-native-code-push/pull/499","diff_url":"https://github.com/Microsoft/react-native-code-push/pull/499.diff","patch_url":"https://github.com/Microsoft/react-native-code-push/pull/499.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/499","number":499,"state":"open","locked":false,"title":"Guard against NSError null pointer dereferences","user":{"login":"daniel-beard","id":2645146,"avatar_url":"https://avatars.githubusercontent.com/u/2645146?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beard","html_url":"https://github.com/daniel-beard","followers_url":"https://api.github.com/users/daniel-beard/followers","following_url":"https://api.github.com/users/daniel-beard/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beard/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beard/subscriptions","organizations_url":"https://api.github.com/users/daniel-beard/orgs","repos_url":"https://api.github.com/users/daniel-beard/repos","events_url":"https://api.github.com/users/daniel-beard/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beard/received_events","type":"User","site_admin":false},"body":"- This fixes #490 \r\n- Guards against null dereference of `NSError **` pointers.\r\n- Fixes some of the fragile error checks.\r\n- Future fixes here may require changing some public method signatures, as all methods that take an `NSError **` parameter should at *least* return a `BOOL` indicating success/failure. I haven't done that in this PR, as I wasn't sure how this team handles breaking API changes.","created_at":"2016-08-29T18:07:20Z","updated_at":"2016-08-29T18:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/499/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/c517c59ea60eb909fd2ba1de86e40d9c30a070e6","head":{"label":"daniel-beard:dbeard_guard_against_nserror_null_pointer_derefs","ref":"dbeard_guard_against_nserror_null_pointer_derefs","sha":"c517c59ea60eb909fd2ba1de86e40d9c30a070e6","user":{"login":"daniel-beard","id":2645146,"avatar_url":"https://avatars.githubusercontent.com/u/2645146?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beard","html_url":"https://github.com/daniel-beard","followers_url":"https://api.github.com/users/daniel-beard/followers","following_url":"https://api.github.com/users/daniel-beard/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beard/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beard/subscriptions","organizations_url":"https://api.github.com/users/daniel-beard/orgs","repos_url":"https://api.github.com/users/daniel-beard/repos","events_url":"https://api.github.com/users/daniel-beard/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beard/received_events","type":"User","site_admin":false},"repo":{"id":66578185,"name":"react-native-code-push","full_name":"daniel-beard/react-native-code-push","owner":{"login":"daniel-beard","id":2645146,"avatar_url":"https://avatars.githubusercontent.com/u/2645146?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beard","html_url":"https://github.com/daniel-beard","followers_url":"https://api.github.com/users/daniel-beard/followers","following_url":"https://api.github.com/users/daniel-beard/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beard/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beard/subscriptions","organizations_url":"https://api.github.com/users/daniel-beard/orgs","repos_url":"https://api.github.com/users/daniel-beard/repos","events_url":"https://api.github.com/users/daniel-beard/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-beard/react-native-code-push","description":"React Native module for CodePush","fork":true,"url":"https://api.github.com/repos/daniel-beard/react-native-code-push","forks_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/forks","keys_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/teams","hooks_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/hooks","issue_events_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/events","assignees_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/tags","blobs_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/languages","stargazers_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/stargazers","contributors_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/contributors","subscribers_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/subscribers","subscription_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/subscription","commits_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/merges","archive_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/downloads","issues_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/labels{/name}","releases_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-beard/react-native-code-push/deployments","created_at":"2016-08-25T17:15:38Z","updated_at":"2016-08-25T17:15:39Z","pushed_at":"2016-08-29T18:05:01Z","git_url":"git://github.com/daniel-beard/react-native-code-push.git","ssh_url":"git@github.com:daniel-beard/react-native-code-push.git","clone_url":"https://github.com/daniel-beard/react-native-code-push.git","svn_url":"https://github.com/daniel-beard/react-native-code-push","homepage":"http://codepush.tools","size":5710,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a2aacffd2c2b50e59d8a9455fe84b16cdab52695","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36749153,"name":"react-native-code-push","full_name":"Microsoft/react-native-code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-code-push","description":"React Native module for CodePush","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-code-push","forks_url":"https://api.github.com/repos/Microsoft/react-native-code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/deployments","created_at":"2015-06-02T17:19:20Z","updated_at":"2016-08-29T15:57:40Z","pushed_at":"2016-08-29T18:07:20Z","git_url":"git://github.com/Microsoft/react-native-code-push.git","ssh_url":"git@github.com:Microsoft/react-native-code-push.git","clone_url":"https://github.com/Microsoft/react-native-code-push.git","svn_url":"https://github.com/Microsoft/react-native-code-push","homepage":"http://codepush.tools","size":7591,"stargazers_count":1543,"watchers_count":1543,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":21,"forks":185,"open_issues":21,"watchers":1543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499"},"html":{"href":"https://github.com/Microsoft/react-native-code-push/pull/499"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/499"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/c517c59ea60eb909fd2ba1de86e40d9c30a070e6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":191,"deletions":75,"changed_files":2}}
{"actor":{"display_login":"daniel-beard"}}