{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/5179","repository_url":"https://api.github.com/repos/jekyll/jekyll","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/5179/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/5179/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/5179/events","html_url":"https://github.com/jekyll/jekyll/issues/5179","id":168801610,"number":5179,"title":"Get Jekyll Tests Working on Windows","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"labels":[{"id":350839385,"url":"https://api.github.com/repos/jekyll/jekyll/labels/tests","name":"tests","color":"d4c5f9","default":false},{"id":151345987,"url":"https://api.github.com/repos/jekyll/jekyll/labels/windows","name":"windows","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-08-02T05:21:36Z","updated_at":"2016-11-11T00:18:11Z","closed_at":"2016-11-10T21:48:00Z","body":"Hello, valiant members of @jekyll/windows. We have a quest for you all. @XhmikosR recently added AppVeyor as a CI target for Jekyll so we might be better equipped to maintain compatibility with Jekyll in the longer term. When it was introduced, AppVeyor was constantly failing. We knew this would be a big lift, so we have not been checking failures yet.\n\nWell, 3.2.0 came out and what do you know: a Windows incompatibility. Jekyll 3.2.0 didn't work at all on Windows. Taking a look at the AppVeyor failures, they had the same errors that users were seeing! We could have caught this. I was disappointed (as were all of you) and so now it is time to figure them out once and for all. \n\nAccording to [this build](https://ci.appveyor.com/project/jekyll/jekyll/build/108), there are 9 failures (mostly symlink handling or paths):\n- [ ] configuring sites should have an array for plugins if passed as a string. (`test/test_site.rb:17`) (Expected: `[\"/tmp/plugins\"]`, Actual: `[\"C:/tmp/plugins\"]`)\n- [ ] configuring sites should have an array for plugins if passed as an array. (`test/test_site.rb:24`) (Expected `[\"/tmp/plugins\", \"/tmp/otherplugins\"]`, Actual: `[\"C:/tmp/plugins\", \"C:/tmp/otherplugins\"]`)\n- [ ] creating sites should sort pages alphabetically.  (`test/test_site.rb:201`) \n  \n  ```\n  Expected \n  [\"%# +.md\", \".htaccess\", \"about.html\", \"bar.html\", \"coffeescript.coffee\", \"contacts.html\", \"deal.with.dots.html\", \"dynamic_file.php\", \"environment.html\", \"exploit.md\", \"foo.md\", \"humans.txt\", \"index.html\", \"index.html\", \"main.scss\", \"main.scss\", \"properties.html\", \"sitemap.xml\", \"static_files.html\", \"symlinked-file\"]\n  but got\n  [\"%# +.md\", \".htaccess\", \"about.html\", \"bar.html\", \"coffeescript.coffee\", \"contacts.html\", \"deal.with.dots.html\", \"dynamic_file.php\", \"environment.html\", \"exploit.md\", \"foo.md\", \"humans.txt\", \"index.html\", \"index.html\", \"main.scss\", \"properties.html\", \"sitemap.xml\", \"static_files.html\"]\n  ```\n- [ ] filters group_by filter should successfully group array of Jekyll::Page's.  (`test/test_filters.rb:466`) (Expected: `4`, Actual: `5`)\n- [ ] path generation should return the resolved path when a symlink & resolved path exists.  (`test/test_theme.rb:59`) (Expected: `\"C:/projects/jekyll/test/fixtures/test-theme/_layouts\"`, Actual: `nil`)\n- [ ] in safe mode should include the symlinked file from site.source in the list of docs.  (`test/test_collections.rb:189`) (Expected `[\"_methods/collection/entries\", \"_methods/configuration.md\", \"_methods/escape-+ #%20[].md\", \"_methods/sanitized_path.md\", \"_methods/site/generate.md\", \"_methods/site/initialize.md\", \"_methods/yaml_with_dots.md\"]` to include `\"_methods/um_hi.md\"`.)\n- [ ] generated sites should print a nice list of static files.  (`test/test_generated_site.rb:59`)\n  \n  ```\n  Expected\n  /- \\/css\\/screen.css last edited at \\d+:\\d+ with extname .css\n   - \\/pgp.key last edited at \\d+:\\d+ with extname .key\n   - \\/products.yml last edited at \\d+:\\d+ with extname .yml\n   - \\/symlink-test\\/symlinked-dir\\/screen.css last edited at \\d+:\\d+ with extname .css\n   /\n   to match \n   \"- /css/screen.css last edited at 00:08 with extname .css\n    - /pgp.key last edited at 00:08 with extname .key\n    - /products.yml last edited at 00:08 with extname .yml\n    - /symlink-test/symlinked-dir last edited at 00:08 with extname \n    - /symlink-test/symlinked-file last edited at 00:08 with extname \\n\"\n  ```\n- [ ] Filtering entries should include only safe symlinks in safe mode.  (`test/test_entry_filter.rb:88`) (Expected: `2`, Actual: `0`)\n- [ ] Filtering entries should include symlinks in unsafe mode.  (`test/test_entry_filter.rb:97`) (Expected `[]` to not be equal to `[]`.)\n\n**Please** submit pull requests which fix these issues in a _system-agnostic_ way (they should work for both Linux/Mac & Windows). Some of these test failures are related or are symptoms of the same problem. Any PR's that come up with an elegant solution to a gross failure will be gratefully accepted. Let's get AppVeyor green! 💚 \n\n/cc #5164 #4677 #5146\n"},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/259847003","html_url":"https://github.com/jekyll/jekyll/issues/5179#issuecomment-259847003","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/5179","id":259847003,"user":{"login":"XhmikosR","id":349621,"avatar_url":"https://avatars.githubusercontent.com/u/349621?v=3","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T00:18:11Z","updated_at":"2016-11-11T00:18:11Z","body":"@parkr: the only test I can see that can be sped up is the default-site one. Can you make that use a Gemfile or something so that we can cache it?\r\n\r\nAdditionally, we could skip perhaps the fmt target on Windows."}}
{"actor":{"display_login":"XhmikosR"}}