{"action":"closed","number":2594,"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/2594","id":67130646,"html_url":"https://github.com/dotnet/cli/pull/2594","diff_url":"https://github.com/dotnet/cli/pull/2594.diff","patch_url":"https://github.com/dotnet/cli/pull/2594.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/2594","number":2594,"state":"closed","locked":false,"title":"Remove System.CommandLine and Microsoft.Extensions.CommandLineUtils.Sources dependencies","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"- Checking in the source files for Microsoft.Extensions.CommandLineUtils.Sources instead of relying on the NuGet package. There were two changes to these files on the 1st commit:\r\n\r\n 1. Change the copyright header.  (Working with @richlander and legal to exactly how we should approach this).\r\n 2. Change the namespace to Microsoft.DotNet.Cli.CommandLine.\r\n\r\n No actual command line utils logic changed in these files in the first commit.\r\n\r\n- Removed all usages of System.CommandLine in the CLI and replaced them with the copied Microsoft.DotNet.Cli.CommandLine APIs.\r\n - This required some enhancements to the command line utils code. You can see all the enhancements in the 2nd commit.\r\n - The 3rd commit is uptaking the new enhancements.\r\n\r\nSome notes:\r\n- I changed resgen to not use a command line util at all, and instead compile explicitly passes the parameters. This is because resgen can't be invoked by a user at all, so there was no reason to write and read an .rsp file in this scenario. If we need to add a command line interface to resgen, it can be added on top of the current code in the future.\r\n- F# compiler shares the CommandLine files and two common compiler utility files with the C# compiler. This is needed to keep our CommandLine APIs internal. If/when F# moves to a different repo, these files will need to be copied.\r\n\r\nFix #2526 \r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dotnet/cli/2594)\r\n<!-- Reviewable:end -->","created_at":"2016-04-20T05:32:44Z","updated_at":"2016-04-21T02:02:05Z","closed_at":"2016-04-21T02:02:04Z","merged_at":"2016-04-21T02:02:04Z","merge_commit_sha":"8cf36612e8f3565ef12b99911e4bfde410fc3201","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/2594/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/2594/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/2594/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/0c64a7ebc9b8d287c783da42720d97433740b0c6","head":{"label":"eerhardt:CommandLine","ref":"CommandLine","sha":"0c64a7ebc9b8d287c783da42720d97433740b0c6","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":50930406,"name":"cli","full_name":"eerhardt/cli","owner":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/eerhardt/cli","forks_url":"https://api.github.com/repos/eerhardt/cli/forks","keys_url":"https://api.github.com/repos/eerhardt/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/cli/teams","hooks_url":"https://api.github.com/repos/eerhardt/cli/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/cli/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/cli/events","assignees_url":"https://api.github.com/repos/eerhardt/cli/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/cli/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/cli/tags","blobs_url":"https://api.github.com/repos/eerhardt/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/cli/languages","stargazers_url":"https://api.github.com/repos/eerhardt/cli/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/cli/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/cli/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/cli/subscription","commits_url":"https://api.github.com/repos/eerhardt/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/cli/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/cli/merges","archive_url":"https://api.github.com/repos/eerhardt/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/cli/downloads","issues_url":"https://api.github.com/repos/eerhardt/cli/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/cli/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/cli/releases{/id}","deployments_url":"https://api.github.com/repos/eerhardt/cli/deployments","created_at":"2016-02-02T15:31:54Z","updated_at":"2016-02-02T15:32:00Z","pushed_at":"2016-04-20T23:52:32Z","git_url":"git://github.com/eerhardt/cli.git","ssh_url":"git@github.com:eerhardt/cli.git","clone_url":"https://github.com/eerhardt/cli.git","svn_url":"https://github.com/eerhardt/cli","homepage":"http://dotnet.github.io/","size":20418,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"d06418509d6962ccb9cf064d1089dea56b677b13","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-04-20T23:41:59Z","pushed_at":"2016-04-21T02:02:04Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"http://dotnet.github.io/","size":26963,"stargazers_count":831,"watchers_count":831,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":682,"forks":167,"open_issues":682,"watchers":831,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/2594"},"html":{"href":"https://github.com/dotnet/cli/pull/2594"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/2594"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/2594/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/2594/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/2594/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/0c64a7ebc9b8d287c783da42720d97433740b0c6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"comments":7,"review_comments":9,"commits":4,"additions":1423,"deletions":768,"changed_files":43}}