{"action":"created","comment":{"url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/comments/68915456","id":68915456,"diff_hunk":"@@ -1,27 +1,65 @@\n-var app = angular.module('pokemonDraft', []);\n-app.controller('serverTableController', function($scope, $http) {\n+var app = angular.module('pokemonDraft', ['ui.bootstrap.modal', 'ui.bootstrap.tpls']);\n+app.controller('serverTableController', function($scope, $http, $modal) {\n+\t// server list\n+\t$scope.hostedGames = [];\n+\t$scope.usersID;\n+\n+    $scope.openModal = function(item) {\n+        var modalInstance = $modal.open({\n+            templateUrl: 'views/joinGame.html',\n+            backdrop: 'static',\n+            controller: function($scope, $modalInstance, $sce, item) {\n+            \t$scope.clone = item;\n+                $scope.close = function() {\n+                    $modalInstance.dismiss('cancel');\n+                };\n+            }\n+        });\n+    }\n \n \n     var socket = io.connect('http://localhost:4200');\n     socket.on('connect', function(data) {\n-        socket.emit('join', 'Hello World from client');\n+    \t// default namespace/room (its a lobby)\n+        socket.emit('initialConnection', 'New client has joined :)');\n+\n+        // Gets users socket ID\n+        $scope.usersID = socket.io.engine.id\n     });\n \n-    \n \n-\t// Testing array :)\n-\t$scope.hostedGames = [\n-\t{name: \"Greg\", hostName: \"George\", players: \"1/4\", private: \"No\"}, \n-\t{name: \"Cool Game\", hostName: \"Jim\", players: \"1/2\", private: \"Yes\"},\n-\t{name: \"Fun Game\", hostName: \"Tim\", players: \"1/3\", private: \"No\"},\n-\t{name: \"Crazy Game\", hostName: \"Old'greg\", players: \"1/5\", private: \"Yes\"},\n-\t{name: \"Interesting Game\", hostName: \"Jay\", players: \"1/4\", private: \"Yes\"}\n-\t];\n+\t$scope.joinGame = function(id){","path":"controllers/serverTableController.js","position":43,"original_position":43,"commit_id":"869c3c365856c9a2b8452ef0f58e16dbd2120880","original_commit_id":"869c3c365856c9a2b8452ef0f58e16dbd2120880","user":{"login":"konk353535","id":7227153,"avatar_url":"https://avatars.githubusercontent.com/u/7227153?v=3","gravatar_id":"","url":"https://api.github.com/users/konk353535","html_url":"https://github.com/konk353535","followers_url":"https://api.github.com/users/konk353535/followers","following_url":"https://api.github.com/users/konk353535/following{/other_user}","gists_url":"https://api.github.com/users/konk353535/gists{/gist_id}","starred_url":"https://api.github.com/users/konk353535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konk353535/subscriptions","organizations_url":"https://api.github.com/users/konk353535/orgs","repos_url":"https://api.github.com/users/konk353535/repos","events_url":"https://api.github.com/users/konk353535/events{/privacy}","received_events_url":"https://api.github.com/users/konk353535/received_events","type":"User","site_admin":false},"body":"If possible install eslint on sublime, it's a module which will let u know if u disobey a style guide. In airbnb's style guide it is recommended to have a space after a function decleration eg\r\n\r\n`$scope.joinGame = function(id) {`","created_at":"2016-06-29T09:40:41Z","updated_at":"2016-06-29T09:40:41Z","html_url":"https://github.com/donnellbob/PokemonDraft/pull/2#discussion_r68915456","pull_request_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/comments/68915456"},"html":{"href":"https://github.com/donnellbob/PokemonDraft/pull/2#discussion_r68915456"},"pull_request":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2","id":75591427,"html_url":"https://github.com/donnellbob/PokemonDraft/pull/2","diff_url":"https://github.com/donnellbob/PokemonDraft/pull/2.diff","patch_url":"https://github.com/donnellbob/PokemonDraft/pull/2.patch","issue_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/2","number":2,"state":"open","locked":false,"title":"Lobby system","user":{"login":"donnellbob","id":11920019,"avatar_url":"https://avatars.githubusercontent.com/u/11920019?v=3","gravatar_id":"","url":"https://api.github.com/users/donnellbob","html_url":"https://github.com/donnellbob","followers_url":"https://api.github.com/users/donnellbob/followers","following_url":"https://api.github.com/users/donnellbob/following{/other_user}","gists_url":"https://api.github.com/users/donnellbob/gists{/gist_id}","starred_url":"https://api.github.com/users/donnellbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnellbob/subscriptions","organizations_url":"https://api.github.com/users/donnellbob/orgs","repos_url":"https://api.github.com/users/donnellbob/repos","events_url":"https://api.github.com/users/donnellbob/events{/privacy}","received_events_url":"https://api.github.com/users/donnellbob/received_events","type":"User","site_admin":false},"body":"User can:\r\n\r\n- Make Room\r\n\r\n- Join Room\r\n\r\n- Refresh room list\r\n\r\n** Rooms are backend logic only and do not currently have visual representation. ","created_at":"2016-06-29T05:48:05Z","updated_at":"2016-06-29T09:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"783ae32007e0efbe7adae94ac703a422dadf0caf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2/commits","review_comments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2/comments","review_comment_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/2/comments","statuses_url":"https://api.github.com/repos/donnellbob/PokemonDraft/statuses/869c3c365856c9a2b8452ef0f58e16dbd2120880","head":{"label":"donnellbob:Lobby-System","ref":"Lobby-System","sha":"869c3c365856c9a2b8452ef0f58e16dbd2120880","user":{"login":"donnellbob","id":11920019,"avatar_url":"https://avatars.githubusercontent.com/u/11920019?v=3","gravatar_id":"","url":"https://api.github.com/users/donnellbob","html_url":"https://github.com/donnellbob","followers_url":"https://api.github.com/users/donnellbob/followers","following_url":"https://api.github.com/users/donnellbob/following{/other_user}","gists_url":"https://api.github.com/users/donnellbob/gists{/gist_id}","starred_url":"https://api.github.com/users/donnellbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnellbob/subscriptions","organizations_url":"https://api.github.com/users/donnellbob/orgs","repos_url":"https://api.github.com/users/donnellbob/repos","events_url":"https://api.github.com/users/donnellbob/events{/privacy}","received_events_url":"https://api.github.com/users/donnellbob/received_events","type":"User","site_admin":false},"repo":{"id":61620315,"name":"PokemonDraft","full_name":"donnellbob/PokemonDraft","owner":{"login":"donnellbob","id":11920019,"avatar_url":"https://avatars.githubusercontent.com/u/11920019?v=3","gravatar_id":"","url":"https://api.github.com/users/donnellbob","html_url":"https://github.com/donnellbob","followers_url":"https://api.github.com/users/donnellbob/followers","following_url":"https://api.github.com/users/donnellbob/following{/other_user}","gists_url":"https://api.github.com/users/donnellbob/gists{/gist_id}","starred_url":"https://api.github.com/users/donnellbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnellbob/subscriptions","organizations_url":"https://api.github.com/users/donnellbob/orgs","repos_url":"https://api.github.com/users/donnellbob/repos","events_url":"https://api.github.com/users/donnellbob/events{/privacy}","received_events_url":"https://api.github.com/users/donnellbob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donnellbob/PokemonDraft","description":"A pokemon styled combat game with multiplayer online \"draft mode\" features. Using Node & angular.","fork":false,"url":"https://api.github.com/repos/donnellbob/PokemonDraft","forks_url":"https://api.github.com/repos/donnellbob/PokemonDraft/forks","keys_url":"https://api.github.com/repos/donnellbob/PokemonDraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donnellbob/PokemonDraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donnellbob/PokemonDraft/teams","hooks_url":"https://api.github.com/repos/donnellbob/PokemonDraft/hooks","issue_events_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/events{/number}","events_url":"https://api.github.com/repos/donnellbob/PokemonDraft/events","assignees_url":"https://api.github.com/repos/donnellbob/PokemonDraft/assignees{/user}","branches_url":"https://api.github.com/repos/donnellbob/PokemonDraft/branches{/branch}","tags_url":"https://api.github.com/repos/donnellbob/PokemonDraft/tags","blobs_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donnellbob/PokemonDraft/statuses/{sha}","languages_url":"https://api.github.com/repos/donnellbob/PokemonDraft/languages","stargazers_url":"https://api.github.com/repos/donnellbob/PokemonDraft/stargazers","contributors_url":"https://api.github.com/repos/donnellbob/PokemonDraft/contributors","subscribers_url":"https://api.github.com/repos/donnellbob/PokemonDraft/subscribers","subscription_url":"https://api.github.com/repos/donnellbob/PokemonDraft/subscription","commits_url":"https://api.github.com/repos/donnellbob/PokemonDraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/donnellbob/PokemonDraft/contents/{+path}","compare_url":"https://api.github.com/repos/donnellbob/PokemonDraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donnellbob/PokemonDraft/merges","archive_url":"https://api.github.com/repos/donnellbob/PokemonDraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donnellbob/PokemonDraft/downloads","issues_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues{/number}","pulls_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls{/number}","milestones_url":"https://api.github.com/repos/donnellbob/PokemonDraft/milestones{/number}","notifications_url":"https://api.github.com/repos/donnellbob/PokemonDraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donnellbob/PokemonDraft/labels{/name}","releases_url":"https://api.github.com/repos/donnellbob/PokemonDraft/releases{/id}","deployments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/deployments","created_at":"2016-06-21T09:24:55Z","updated_at":"2016-06-21T09:25:40Z","pushed_at":"2016-06-29T09:25:50Z","git_url":"git://github.com/donnellbob/PokemonDraft.git","ssh_url":"git@github.com:donnellbob/PokemonDraft.git","clone_url":"https://github.com/donnellbob/PokemonDraft.git","svn_url":"https://github.com/donnellbob/PokemonDraft","homepage":null,"size":910,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"donnellbob:master","ref":"master","sha":"a28b735a0ffb65d542b0bd2866904274e0530633","user":{"login":"donnellbob","id":11920019,"avatar_url":"https://avatars.githubusercontent.com/u/11920019?v=3","gravatar_id":"","url":"https://api.github.com/users/donnellbob","html_url":"https://github.com/donnellbob","followers_url":"https://api.github.com/users/donnellbob/followers","following_url":"https://api.github.com/users/donnellbob/following{/other_user}","gists_url":"https://api.github.com/users/donnellbob/gists{/gist_id}","starred_url":"https://api.github.com/users/donnellbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnellbob/subscriptions","organizations_url":"https://api.github.com/users/donnellbob/orgs","repos_url":"https://api.github.com/users/donnellbob/repos","events_url":"https://api.github.com/users/donnellbob/events{/privacy}","received_events_url":"https://api.github.com/users/donnellbob/received_events","type":"User","site_admin":false},"repo":{"id":61620315,"name":"PokemonDraft","full_name":"donnellbob/PokemonDraft","owner":{"login":"donnellbob","id":11920019,"avatar_url":"https://avatars.githubusercontent.com/u/11920019?v=3","gravatar_id":"","url":"https://api.github.com/users/donnellbob","html_url":"https://github.com/donnellbob","followers_url":"https://api.github.com/users/donnellbob/followers","following_url":"https://api.github.com/users/donnellbob/following{/other_user}","gists_url":"https://api.github.com/users/donnellbob/gists{/gist_id}","starred_url":"https://api.github.com/users/donnellbob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnellbob/subscriptions","organizations_url":"https://api.github.com/users/donnellbob/orgs","repos_url":"https://api.github.com/users/donnellbob/repos","events_url":"https://api.github.com/users/donnellbob/events{/privacy}","received_events_url":"https://api.github.com/users/donnellbob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donnellbob/PokemonDraft","description":"A pokemon styled combat game with multiplayer online \"draft mode\" features. Using Node & angular.","fork":false,"url":"https://api.github.com/repos/donnellbob/PokemonDraft","forks_url":"https://api.github.com/repos/donnellbob/PokemonDraft/forks","keys_url":"https://api.github.com/repos/donnellbob/PokemonDraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donnellbob/PokemonDraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donnellbob/PokemonDraft/teams","hooks_url":"https://api.github.com/repos/donnellbob/PokemonDraft/hooks","issue_events_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/events{/number}","events_url":"https://api.github.com/repos/donnellbob/PokemonDraft/events","assignees_url":"https://api.github.com/repos/donnellbob/PokemonDraft/assignees{/user}","branches_url":"https://api.github.com/repos/donnellbob/PokemonDraft/branches{/branch}","tags_url":"https://api.github.com/repos/donnellbob/PokemonDraft/tags","blobs_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donnellbob/PokemonDraft/statuses/{sha}","languages_url":"https://api.github.com/repos/donnellbob/PokemonDraft/languages","stargazers_url":"https://api.github.com/repos/donnellbob/PokemonDraft/stargazers","contributors_url":"https://api.github.com/repos/donnellbob/PokemonDraft/contributors","subscribers_url":"https://api.github.com/repos/donnellbob/PokemonDraft/subscribers","subscription_url":"https://api.github.com/repos/donnellbob/PokemonDraft/subscription","commits_url":"https://api.github.com/repos/donnellbob/PokemonDraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/donnellbob/PokemonDraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/donnellbob/PokemonDraft/contents/{+path}","compare_url":"https://api.github.com/repos/donnellbob/PokemonDraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donnellbob/PokemonDraft/merges","archive_url":"https://api.github.com/repos/donnellbob/PokemonDraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donnellbob/PokemonDraft/downloads","issues_url":"https://api.github.com/repos/donnellbob/PokemonDraft/issues{/number}","pulls_url":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls{/number}","milestones_url":"https://api.github.com/repos/donnellbob/PokemonDraft/milestones{/number}","notifications_url":"https://api.github.com/repos/donnellbob/PokemonDraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donnellbob/PokemonDraft/labels{/name}","releases_url":"https://api.github.com/repos/donnellbob/PokemonDraft/releases{/id}","deployments_url":"https://api.github.com/repos/donnellbob/PokemonDraft/deployments","created_at":"2016-06-21T09:24:55Z","updated_at":"2016-06-21T09:25:40Z","pushed_at":"2016-06-29T09:25:50Z","git_url":"git://github.com/donnellbob/PokemonDraft.git","ssh_url":"git@github.com:donnellbob/PokemonDraft.git","clone_url":"https://github.com/donnellbob/PokemonDraft.git","svn_url":"https://github.com/donnellbob/PokemonDraft","homepage":null,"size":910,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2"},"html":{"href":"https://github.com/donnellbob/PokemonDraft/pull/2"},"issue":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/2"},"comments":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/donnellbob/PokemonDraft/statuses/869c3c365856c9a2b8452ef0f58e16dbd2120880"}}}}
{"actor":{"display_login":"konk353535"}}