{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/74859776","id":74859776,"diff_hunk":"@@ -0,0 +1,52 @@\n+/*\n+ *\n+ * Copyright 2016, Google Inc.\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are\n+ * met:\n+ *\n+ *     * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ *     * Redistributions in binary form must reproduce the above\n+ * copyright notice, this list of conditions and the following disclaimer\n+ * in the documentation and/or other materials provided with the\n+ * distribution.\n+ *     * Neither the name of Google Inc. nor the names of its\n+ * contributors may be used to endorse or promote products derived from\n+ * this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ */\n+\n+#ifndef GRPC_TEST_CPP_UTIL_CLI_CREDENTIALS_H\n+#define GRPC_TEST_CPP_UTIL_CLI_CREDENTIALS_H\n+\n+#include <grpc++/security/credentials.h>\n+#include <grpc++/support/config.h>\n+\n+namespace grpc {\n+namespace testing {\n+\n+class CliCredentials {\n+ public:\n+  virtual std::shared_ptr<grpc::ChannelCredentials> GetCredentials() const;","path":"test/cpp/util/cli_credentials.h","position":null,"original_position":45,"commit_id":"9bf906234e6e1245e54185a84f132e1fe462757e","original_commit_id":"02139a05dc928ac4fa27c7b794a859e42f3b0831","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"body":"Added a virtual dtor. Thanks a lot for the review!","created_at":"2016-08-16T00:29:04Z","updated_at":"2016-08-16T00:29:04Z","html_url":"https://github.com/grpc/grpc/pull/7735#discussion_r74859776","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/7735","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/74859776"},"html":{"href":"https://github.com/grpc/grpc/pull/7735#discussion_r74859776"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/7735"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/7735","id":81354807,"html_url":"https://github.com/grpc/grpc/pull/7735","diff_url":"https://github.com/grpc/grpc/pull/7735.diff","patch_url":"https://github.com/grpc/grpc/pull/7735.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/7735","number":7735,"state":"open","locked":false,"title":"Improve gRPC CLI","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"body":"This PR adds the following improvements to the gRPC command line tool\r\n- Command processing\r\n- `grpc_cli help` command\r\n- CliCrendtials\r\n- Input validation\r\n- Tests for grpc_tool\r\n- Improvements in ProtoFileParser","created_at":"2016-08-15T18:40:20Z","updated_at":"2016-08-16T00:29:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3d7ff70681e2e9e6895280647079a85432c7af","assignee":{"login":"yang-g","id":10122250,"avatar_url":"https://avatars.githubusercontent.com/u/10122250?v=3","gravatar_id":"","url":"https://api.github.com/users/yang-g","html_url":"https://github.com/yang-g","followers_url":"https://api.github.com/users/yang-g/followers","following_url":"https://api.github.com/users/yang-g/following{/other_user}","gists_url":"https://api.github.com/users/yang-g/gists{/gist_id}","starred_url":"https://api.github.com/users/yang-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang-g/subscriptions","organizations_url":"https://api.github.com/users/yang-g/orgs","repos_url":"https://api.github.com/users/yang-g/repos","events_url":"https://api.github.com/users/yang-g/events{/privacy}","received_events_url":"https://api.github.com/users/yang-g/received_events","type":"User","site_admin":false},"assignees":[{"login":"yang-g","id":10122250,"avatar_url":"https://avatars.githubusercontent.com/u/10122250?v=3","gravatar_id":"","url":"https://api.github.com/users/yang-g","html_url":"https://github.com/yang-g","followers_url":"https://api.github.com/users/yang-g/followers","following_url":"https://api.github.com/users/yang-g/following{/other_user}","gists_url":"https://api.github.com/users/yang-g/gists{/gist_id}","starred_url":"https://api.github.com/users/yang-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang-g/subscriptions","organizations_url":"https://api.github.com/users/yang-g/orgs","repos_url":"https://api.github.com/users/yang-g/repos","events_url":"https://api.github.com/users/yang-g/events{/privacy}","received_events_url":"https://api.github.com/users/yang-g/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/7735/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/7735/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/7735/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/9bf906234e6e1245e54185a84f132e1fe462757e","head":{"label":"y-zeng:cli_main_fork","ref":"cli_main_fork","sha":"9bf906234e6e1245e54185a84f132e1fe462757e","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"repo":{"id":52568937,"name":"grpc","full_name":"y-zeng/grpc","owner":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/y-zeng/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/y-zeng/grpc","forks_url":"https://api.github.com/repos/y-zeng/grpc/forks","keys_url":"https://api.github.com/repos/y-zeng/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-zeng/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-zeng/grpc/teams","hooks_url":"https://api.github.com/repos/y-zeng/grpc/hooks","issue_events_url":"https://api.github.com/repos/y-zeng/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/y-zeng/grpc/events","assignees_url":"https://api.github.com/repos/y-zeng/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/y-zeng/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/y-zeng/grpc/tags","blobs_url":"https://api.github.com/repos/y-zeng/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-zeng/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-zeng/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-zeng/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-zeng/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/y-zeng/grpc/languages","stargazers_url":"https://api.github.com/repos/y-zeng/grpc/stargazers","contributors_url":"https://api.github.com/repos/y-zeng/grpc/contributors","subscribers_url":"https://api.github.com/repos/y-zeng/grpc/subscribers","subscription_url":"https://api.github.com/repos/y-zeng/grpc/subscription","commits_url":"https://api.github.com/repos/y-zeng/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-zeng/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-zeng/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-zeng/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-zeng/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/y-zeng/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-zeng/grpc/merges","archive_url":"https://api.github.com/repos/y-zeng/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-zeng/grpc/downloads","issues_url":"https://api.github.com/repos/y-zeng/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/y-zeng/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/y-zeng/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/y-zeng/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-zeng/grpc/labels{/name}","releases_url":"https://api.github.com/repos/y-zeng/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/y-zeng/grpc/deployments","created_at":"2016-02-26T01:16:00Z","updated_at":"2016-02-26T01:16:07Z","pushed_at":"2016-08-16T00:28:33Z","git_url":"git://github.com/y-zeng/grpc.git","ssh_url":"git@github.com:y-zeng/grpc.git","clone_url":"https://github.com/y-zeng/grpc.git","svn_url":"https://github.com/y-zeng/grpc","homepage":"","size":79090,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"5a22a598b3d986a31215e24ee75468eb2e97aa99","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-08-15T22:35:17Z","pushed_at":"2016-08-16T00:28:34Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":203755,"stargazers_count":5813,"watchers_count":5813,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1085,"mirror_url":null,"open_issues_count":705,"forks":1085,"open_issues":705,"watchers":5813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/7735"},"html":{"href":"https://github.com/grpc/grpc/pull/7735"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/7735"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/7735/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/7735/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/7735/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/9bf906234e6e1245e54185a84f132e1fe462757e"}}}}
{"actor":{"display_login":"y-zeng"}}