{"action":"created","comment":{"url":"https://api.github.com/repos/cerebral/cerebral/pulls/comments/88806720","pull_request_review_id":9368795,"id":88806720,"diff_hunk":"@@ -1,38 +1,60 @@\n {\n-  \"name\": \"cerebral-debugger\",\n-  \"version\": \"2.0.0\",\n+  \"name\": \"electron-quick-start\",\n+  \"version\": \"1.0.0\",\n   \"private\": true,\n-  \"description\": \"Cerebral Debugger\",\n-  \"repository\": {\n-    \"type\": \"git\",\n-    \"url\": \"https://github.com/cerebral/cerebral.git\"\n+  \"description\": \"A minimal Electron application\",\n+  \"main\": \"electron/main.js\",\n+  \"scripts\": {\n+    \"start\": \"DEBUGGER_TARGET=electron NODE_ENV=development concurrently -k 'node ./electron/devServer.js' 'npm run electron'\",\n+    \"electron\": \"electron .\",\n+    \"build:chromeExtension\": \"NODE_ENV=production webpack --config webpack.chromeExtension.config\",\n+    \"build:electron\": \"NODE_ENV=production webpack --config webpack.electron.config && npm run prepare:electron && npm run package:electron\",\n+    \"prepare:electron\": \"rimraf electron/dist electron/node_modules && copyfiles 'node_modules/ws/**/*' 'node_modules/ultron/**/*' 'node_modules/options/**/*' electron\",\n+    \"package:electron\": \"electron-packager ./electron CerebralDebugger --platform=darwin --out ./electron/dist\"\n   },\n+  \"repository\": \"https://github.com/electron/electron-quick-start\",","path":"packages/cerebral-debugger/package.json","position":21,"original_position":21,"commit_id":"b218355f3a1dee1b84461fc375467a5e6d87c3d0","original_commit_id":"b218355f3a1dee1b84461fc375467a5e6d87c3d0","user":{"login":"Guria","id":36270,"avatar_url":"https://avatars.githubusercontent.com/u/36270?v=3","gravatar_id":"","url":"https://api.github.com/users/Guria","html_url":"https://github.com/Guria","followers_url":"https://api.github.com/users/Guria/followers","following_url":"https://api.github.com/users/Guria/following{/other_user}","gists_url":"https://api.github.com/users/Guria/gists{/gist_id}","starred_url":"https://api.github.com/users/Guria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guria/subscriptions","organizations_url":"https://api.github.com/users/Guria/orgs","repos_url":"https://api.github.com/users/Guria/repos","events_url":"https://api.github.com/users/Guria/events{/privacy}","received_events_url":"https://api.github.com/users/Guria/received_events","type":"User","site_admin":false},"body":"wrong, keep previous","created_at":"2016-11-20T17:33:19Z","updated_at":"2016-11-20T17:33:19Z","html_url":"https://github.com/cerebral/cerebral/pull/463#discussion_r88806720","pull_request_url":"https://api.github.com/repos/cerebral/cerebral/pulls/463","_links":{"self":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/comments/88806720"},"html":{"href":"https://github.com/cerebral/cerebral/pull/463#discussion_r88806720"},"pull_request":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/cerebral/cerebral/pulls/463","id":94489131,"html_url":"https://github.com/cerebral/cerebral/pull/463","diff_url":"https://github.com/cerebral/cerebral/pull/463.diff","patch_url":"https://github.com/cerebral/cerebral/pull/463.patch","issue_url":"https://api.github.com/repos/cerebral/cerebral/issues/463","number":463,"state":"open","locked":false,"title":"Electron debugger","user":{"login":"christianalfoni","id":3956929,"avatar_url":"https://avatars.githubusercontent.com/u/3956929?v=3","gravatar_id":"","url":"https://api.github.com/users/christianalfoni","html_url":"https://github.com/christianalfoni","followers_url":"https://api.github.com/users/christianalfoni/followers","following_url":"https://api.github.com/users/christianalfoni/following{/other_user}","gists_url":"https://api.github.com/users/christianalfoni/gists{/gist_id}","starred_url":"https://api.github.com/users/christianalfoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianalfoni/subscriptions","organizations_url":"https://api.github.com/users/christianalfoni/orgs","repos_url":"https://api.github.com/users/christianalfoni/repos","events_url":"https://api.github.com/users/christianalfoni/events{/privacy}","received_events_url":"https://api.github.com/users/christianalfoni/received_events","type":"User","site_admin":false},"body":"Allright this is pretty awesome!\r\n\r\n- I have structured pretty well now, so building makes sense:\r\n\r\n`npm run build:electron` or `npm run build:chromeExtension`\r\n\r\nBoth of these uses the same `src` folder to build the debugger itself. The webpack config decides which `connector` to use.\r\n\r\nElectron application is outputted in: `cerebral-debugger/electron/dist`, the Chrome extension is in `cerebral-debugger/chromeExtension`\r\n\r\n- To develop you use `npm start`, which uses electron. This is great, because now we can develop the debugger using a real app to test handling of the passed data. This was a pain earlier, no need to simulate anymore\r\n\r\nTo try it out just add config:\r\n\r\n```js\r\nController({\r\n  devtools: Devtools({\r\n    remoteDebugger: 'localhost:8080'\r\n  })\r\n})\r\n```\r\n\r\n:)","created_at":"2016-11-19T17:47:42Z","updated_at":"2016-11-20T17:37:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"622fab4b8429c3b0acfd7ffa72300253587cdbb9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerebral/cerebral/pulls/463/commits","review_comments_url":"https://api.github.com/repos/cerebral/cerebral/pulls/463/comments","review_comment_url":"https://api.github.com/repos/cerebral/cerebral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerebral/cerebral/issues/463/comments","statuses_url":"https://api.github.com/repos/cerebral/cerebral/statuses/b218355f3a1dee1b84461fc375467a5e6d87c3d0","head":{"label":"cerebral:electronDebugger","ref":"electronDebugger","sha":"b218355f3a1dee1b84461fc375467a5e6d87c3d0","user":{"login":"cerebral","id":15994611,"avatar_url":"https://avatars.githubusercontent.com/u/15994611?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebral","html_url":"https://github.com/cerebral","followers_url":"https://api.github.com/users/cerebral/followers","following_url":"https://api.github.com/users/cerebral/following{/other_user}","gists_url":"https://api.github.com/users/cerebral/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebral/subscriptions","organizations_url":"https://api.github.com/users/cerebral/orgs","repos_url":"https://api.github.com/users/cerebral/repos","events_url":"https://api.github.com/users/cerebral/events{/privacy}","received_events_url":"https://api.github.com/users/cerebral/received_events","type":"Organization","site_admin":false},"repo":{"id":35326416,"name":"cerebral","full_name":"cerebral/cerebral","owner":{"login":"cerebral","id":15994611,"avatar_url":"https://avatars.githubusercontent.com/u/15994611?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebral","html_url":"https://github.com/cerebral","followers_url":"https://api.github.com/users/cerebral/followers","following_url":"https://api.github.com/users/cerebral/following{/other_user}","gists_url":"https://api.github.com/users/cerebral/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebral/subscriptions","organizations_url":"https://api.github.com/users/cerebral/orgs","repos_url":"https://api.github.com/users/cerebral/repos","events_url":"https://api.github.com/users/cerebral/events{/privacy}","received_events_url":"https://api.github.com/users/cerebral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerebral/cerebral","description":"A state controller with its own debugger","fork":false,"url":"https://api.github.com/repos/cerebral/cerebral","forks_url":"https://api.github.com/repos/cerebral/cerebral/forks","keys_url":"https://api.github.com/repos/cerebral/cerebral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerebral/cerebral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerebral/cerebral/teams","hooks_url":"https://api.github.com/repos/cerebral/cerebral/hooks","issue_events_url":"https://api.github.com/repos/cerebral/cerebral/issues/events{/number}","events_url":"https://api.github.com/repos/cerebral/cerebral/events","assignees_url":"https://api.github.com/repos/cerebral/cerebral/assignees{/user}","branches_url":"https://api.github.com/repos/cerebral/cerebral/branches{/branch}","tags_url":"https://api.github.com/repos/cerebral/cerebral/tags","blobs_url":"https://api.github.com/repos/cerebral/cerebral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerebral/cerebral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerebral/cerebral/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerebral/cerebral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerebral/cerebral/statuses/{sha}","languages_url":"https://api.github.com/repos/cerebral/cerebral/languages","stargazers_url":"https://api.github.com/repos/cerebral/cerebral/stargazers","contributors_url":"https://api.github.com/repos/cerebral/cerebral/contributors","subscribers_url":"https://api.github.com/repos/cerebral/cerebral/subscribers","subscription_url":"https://api.github.com/repos/cerebral/cerebral/subscription","commits_url":"https://api.github.com/repos/cerebral/cerebral/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerebral/cerebral/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerebral/cerebral/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerebral/cerebral/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerebral/cerebral/contents/{+path}","compare_url":"https://api.github.com/repos/cerebral/cerebral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerebral/cerebral/merges","archive_url":"https://api.github.com/repos/cerebral/cerebral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerebral/cerebral/downloads","issues_url":"https://api.github.com/repos/cerebral/cerebral/issues{/number}","pulls_url":"https://api.github.com/repos/cerebral/cerebral/pulls{/number}","milestones_url":"https://api.github.com/repos/cerebral/cerebral/milestones{/number}","notifications_url":"https://api.github.com/repos/cerebral/cerebral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerebral/cerebral/labels{/name}","releases_url":"https://api.github.com/repos/cerebral/cerebral/releases{/id}","deployments_url":"https://api.github.com/repos/cerebral/cerebral/deployments","created_at":"2015-05-09T11:40:05Z","updated_at":"2016-11-20T14:55:07Z","pushed_at":"2016-11-20T17:33:28Z","git_url":"git://github.com/cerebral/cerebral.git","ssh_url":"git@github.com:cerebral/cerebral.git","clone_url":"https://github.com/cerebral/cerebral.git","svn_url":"https://github.com/cerebral/cerebral","homepage":"","size":6521,"stargazers_count":858,"watchers_count":858,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":22,"forks":40,"open_issues":22,"watchers":858,"default_branch":"master"}},"base":{"label":"cerebral:master","ref":"master","sha":"5a3d129e47a2184a641ba4b1dc76afbf2fc7dcff","user":{"login":"cerebral","id":15994611,"avatar_url":"https://avatars.githubusercontent.com/u/15994611?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebral","html_url":"https://github.com/cerebral","followers_url":"https://api.github.com/users/cerebral/followers","following_url":"https://api.github.com/users/cerebral/following{/other_user}","gists_url":"https://api.github.com/users/cerebral/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebral/subscriptions","organizations_url":"https://api.github.com/users/cerebral/orgs","repos_url":"https://api.github.com/users/cerebral/repos","events_url":"https://api.github.com/users/cerebral/events{/privacy}","received_events_url":"https://api.github.com/users/cerebral/received_events","type":"Organization","site_admin":false},"repo":{"id":35326416,"name":"cerebral","full_name":"cerebral/cerebral","owner":{"login":"cerebral","id":15994611,"avatar_url":"https://avatars.githubusercontent.com/u/15994611?v=3","gravatar_id":"","url":"https://api.github.com/users/cerebral","html_url":"https://github.com/cerebral","followers_url":"https://api.github.com/users/cerebral/followers","following_url":"https://api.github.com/users/cerebral/following{/other_user}","gists_url":"https://api.github.com/users/cerebral/gists{/gist_id}","starred_url":"https://api.github.com/users/cerebral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerebral/subscriptions","organizations_url":"https://api.github.com/users/cerebral/orgs","repos_url":"https://api.github.com/users/cerebral/repos","events_url":"https://api.github.com/users/cerebral/events{/privacy}","received_events_url":"https://api.github.com/users/cerebral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerebral/cerebral","description":"A state controller with its own debugger","fork":false,"url":"https://api.github.com/repos/cerebral/cerebral","forks_url":"https://api.github.com/repos/cerebral/cerebral/forks","keys_url":"https://api.github.com/repos/cerebral/cerebral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerebral/cerebral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerebral/cerebral/teams","hooks_url":"https://api.github.com/repos/cerebral/cerebral/hooks","issue_events_url":"https://api.github.com/repos/cerebral/cerebral/issues/events{/number}","events_url":"https://api.github.com/repos/cerebral/cerebral/events","assignees_url":"https://api.github.com/repos/cerebral/cerebral/assignees{/user}","branches_url":"https://api.github.com/repos/cerebral/cerebral/branches{/branch}","tags_url":"https://api.github.com/repos/cerebral/cerebral/tags","blobs_url":"https://api.github.com/repos/cerebral/cerebral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerebral/cerebral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerebral/cerebral/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerebral/cerebral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerebral/cerebral/statuses/{sha}","languages_url":"https://api.github.com/repos/cerebral/cerebral/languages","stargazers_url":"https://api.github.com/repos/cerebral/cerebral/stargazers","contributors_url":"https://api.github.com/repos/cerebral/cerebral/contributors","subscribers_url":"https://api.github.com/repos/cerebral/cerebral/subscribers","subscription_url":"https://api.github.com/repos/cerebral/cerebral/subscription","commits_url":"https://api.github.com/repos/cerebral/cerebral/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerebral/cerebral/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerebral/cerebral/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerebral/cerebral/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerebral/cerebral/contents/{+path}","compare_url":"https://api.github.com/repos/cerebral/cerebral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerebral/cerebral/merges","archive_url":"https://api.github.com/repos/cerebral/cerebral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerebral/cerebral/downloads","issues_url":"https://api.github.com/repos/cerebral/cerebral/issues{/number}","pulls_url":"https://api.github.com/repos/cerebral/cerebral/pulls{/number}","milestones_url":"https://api.github.com/repos/cerebral/cerebral/milestones{/number}","notifications_url":"https://api.github.com/repos/cerebral/cerebral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerebral/cerebral/labels{/name}","releases_url":"https://api.github.com/repos/cerebral/cerebral/releases{/id}","deployments_url":"https://api.github.com/repos/cerebral/cerebral/deployments","created_at":"2015-05-09T11:40:05Z","updated_at":"2016-11-20T14:55:07Z","pushed_at":"2016-11-20T17:33:28Z","git_url":"git://github.com/cerebral/cerebral.git","ssh_url":"git@github.com:cerebral/cerebral.git","clone_url":"https://github.com/cerebral/cerebral.git","svn_url":"https://github.com/cerebral/cerebral","homepage":"","size":6521,"stargazers_count":858,"watchers_count":858,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":22,"forks":40,"open_issues":22,"watchers":858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/463"},"html":{"href":"https://github.com/cerebral/cerebral/pull/463"},"issue":{"href":"https://api.github.com/repos/cerebral/cerebral/issues/463"},"comments":{"href":"https://api.github.com/repos/cerebral/cerebral/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerebral/cerebral/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/cerebral/cerebral/statuses/b218355f3a1dee1b84461fc375467a5e6d87c3d0"}}}}
{"actor":{"display_login":"Guria"}}