{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16589","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16589/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16589/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16589/events","html_url":"https://github.com/cms-sw/cmssw/pull/16589","id":189451874,"number":16589,"title":"fix some DQM sequences for phase1 scenario","user":{"login":"mtosi","id":4946419,"avatar_url":"https://avatars.githubusercontent.com/u/4946419?v=3","gravatar_id":"","url":"https://api.github.com/users/mtosi","html_url":"https://github.com/mtosi","followers_url":"https://api.github.com/users/mtosi/followers","following_url":"https://api.github.com/users/mtosi/following{/other_user}","gists_url":"https://api.github.com/users/mtosi/gists{/gist_id}","starred_url":"https://api.github.com/users/mtosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtosi/subscriptions","organizations_url":"https://api.github.com/users/mtosi/orgs","repos_url":"https://api.github.com/users/mtosi/repos","events_url":"https://api.github.com/users/mtosi/events{/privacy}","received_events_url":"https://api.github.com/users/mtosi/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":1914,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-15T18:21:50Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-11-15T17:13:38Z","updated_at":"2016-11-15T20:44:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16589","html_url":"https://github.com/cms-sw/cmssw/pull/16589","diff_url":"https://github.com/cms-sw/cmssw/pull/16589.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16589.patch"},"body":"thanks to @makortel \r\nI went through the list of python config files which still handle the phase1\r\nby dropping some DQM/Validation modules\r\n\r\nI did not update the following ones, though\r\n- DQMOffline/Configuration/python/DQMOffline_CRT_cff.py:phase1Pixel.toReplaceWith(crt_dqmoffline, crt_dqmoffline.copyAndExclude([ # FIXME\r\n- Validation/RecoTrack/python/SiTrackingRecHitsValid_cff.py:phase1Pixel.toReplaceWith(trackingRecHitsValid, trackingRecHitsValid.copyAndExclude([ # FIXME\r\n\r\nbecause the comment suggests that need some work on the DQM side\r\n\r\nin addition, I was not able to merge my original updates\r\nbecause of conflict w/\r\n- DQM/Physics/python/DQMPhysics_cff.py:phase1Pixel.toReplaceWith(dqmPhysics, dqmPhysics.copyAndExclude([ # FIXME\r\nso, it still needs to be updated\r\n\r\n\r\nI do not think they are super urgent, but I would suggest to integrate this PR as soon as possible ..."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/260762102","html_url":"https://github.com/cms-sw/cmssw/pull/16589#issuecomment-260762102","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16589","id":260762102,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T20:44:38Z","updated_at":"2016-11-15T20:44:38Z","body":"+1\nTested at: 1258b100679bce8fb2618db00b3aa128d978bffb\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16589/16359/summary.html"}}
{"actor":{"display_login":"cmsbuild"}}