{"action":"opened","issue":{"url":"https://api.github.com/repos/CCallahanIV/portfolio/issues/8","repository_url":"https://api.github.com/repos/CCallahanIV/portfolio","labels_url":"https://api.github.com/repos/CCallahanIV/portfolio/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/CCallahanIV/portfolio/issues/8/comments","events_url":"https://api.github.com/repos/CCallahanIV/portfolio/issues/8/events","html_url":"https://github.com/CCallahanIV/portfolio/issues/8","id":187643419,"number":8,"title":"Portfolio Peer Review #2","user":{"login":"reganoneill","id":13720327,"avatar_url":"https://avatars.githubusercontent.com/u/13720327?v=3","gravatar_id":"","url":"https://api.github.com/users/reganoneill","html_url":"https://github.com/reganoneill","followers_url":"https://api.github.com/users/reganoneill/followers","following_url":"https://api.github.com/users/reganoneill/following{/other_user}","gists_url":"https://api.github.com/users/reganoneill/gists{/gist_id}","starred_url":"https://api.github.com/users/reganoneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reganoneill/subscriptions","organizations_url":"https://api.github.com/users/reganoneill/orgs","repos_url":"https://api.github.com/users/reganoneill/repos","events_url":"https://api.github.com/users/reganoneill/events{/privacy}","received_events_url":"https://api.github.com/users/reganoneill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-07T07:35:37Z","updated_at":"2016-11-07T07:35:37Z","closed_at":null,"body":"All in all, the site looks and functions great. Your directory structure is sound and your files are well named and structured as well. Clear MVC organization which will make your codebase more manageable for future updates or if others wish to work on it. \r\nIt was useful reviewing your code to get ideas to implement on my own project.\r\nI only have two small issues to note:\r\n1) Your portfolio container (<ul id=\"portList\"..>) could be filled by its child elements for better layout. Only about 60% of the container's width is ever filled. This is especially noticeable on mobile layouts. I noticed that your .portLinks have absolute sizes which could be causing issues.\r\n2) Again, your code looks great over all so I'm kind of being nit-picky on this one - on line 10 of resource.js you name an array inside the parent Resource object resources. This is a bit redundant/confusing but it also makes sense in some ways. This would probably be more of a concern for a larger site with multiple devs but it's not a big deal for a personal site. \r\n\r\n"}}
{"actor":{"display_login":"reganoneill"}}