{"action":"created","comment":{"url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments/69472282","id":69472282,"diff_hunk":"@@ -45,6 +48,44 @@ PluginVideo.prototype.processMessage = function(message) {\n };\n \n /**\n+ * @inheritDoc\n+ */\n+PluginVideo.prototype.publish = function() {\n+  return PluginVideo.super_.prototype.publish.call(this)\n+    .then(function(result) {\n+      this._isPublish = true;","path":"lib/janus/plugin/video.js","position":24,"original_position":24,"commit_id":"82bad5f1baa47e4cc8ea1b8738810064761b6f0d","original_commit_id":"82bad5f1baa47e4cc8ea1b8738810064761b6f0d","user":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"body":"We should probably set this back to null/false when removing stream. Plus set it to false when subscribing?","created_at":"2016-07-04T15:28:56Z","updated_at":"2016-07-04T15:28:56Z","html_url":"https://github.com/cargomedia/cm-janus/pull/275#discussion_r69472282","pull_request_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments/69472282"},"html":{"href":"https://github.com/cargomedia/cm-janus/pull/275#discussion_r69472282"},"pull_request":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275","id":76000918,"html_url":"https://github.com/cargomedia/cm-janus/pull/275","diff_url":"https://github.com/cargomedia/cm-janus/pull/275.diff","patch_url":"https://github.com/cargomedia/cm-janus/pull/275.patch","issue_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/275","number":275,"state":"open","locked":false,"title":"Remove all \"subscribe\" streams when a rtpbroadcast \"publish\" stream is removed","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"body":"Goal: make sure that all \"subscribes\" are removed against CM's API *before* sending the \"unpublish\" call. This way we can avoid streamchannels with only subscribes that appear briefly after an unsubscribe.\r\n\r\nWould it make sense to send \"unsubscribe\" for all subscribers in `PluginVideo.removeStream()`, if the publish stream is removed?\r\nWe could also remove the whole plugin then…\r\n\r\nNote: the plugin is in a unusable state after unpublish anyway, because any attempts to republish will fail, because CM will find that this \"mediaId\" already existed.\r\n\r\n@tomaszdurka @vogdb wdyt?","created_at":"2016-07-01T15:55:24Z","updated_at":"2016-07-04T15:28:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d65f861de401e13b74011749f7ea97bf52919280","assignee":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"assignees":[{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275/commits","review_comments_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275/comments","review_comment_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/275/comments","statuses_url":"https://api.github.com/repos/cargomedia/cm-janus/statuses/82bad5f1baa47e4cc8ea1b8738810064761b6f0d","head":{"label":"vogdb:issue-275","ref":"issue-275","sha":"82bad5f1baa47e4cc8ea1b8738810064761b6f0d","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"repo":{"id":44749606,"name":"cm-janus","full_name":"vogdb/cm-janus","owner":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vogdb/cm-janus","description":"cm/janus bridge","fork":true,"url":"https://api.github.com/repos/vogdb/cm-janus","forks_url":"https://api.github.com/repos/vogdb/cm-janus/forks","keys_url":"https://api.github.com/repos/vogdb/cm-janus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vogdb/cm-janus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vogdb/cm-janus/teams","hooks_url":"https://api.github.com/repos/vogdb/cm-janus/hooks","issue_events_url":"https://api.github.com/repos/vogdb/cm-janus/issues/events{/number}","events_url":"https://api.github.com/repos/vogdb/cm-janus/events","assignees_url":"https://api.github.com/repos/vogdb/cm-janus/assignees{/user}","branches_url":"https://api.github.com/repos/vogdb/cm-janus/branches{/branch}","tags_url":"https://api.github.com/repos/vogdb/cm-janus/tags","blobs_url":"https://api.github.com/repos/vogdb/cm-janus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vogdb/cm-janus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vogdb/cm-janus/git/refs{/sha}","trees_url":"https://api.github.com/repos/vogdb/cm-janus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vogdb/cm-janus/statuses/{sha}","languages_url":"https://api.github.com/repos/vogdb/cm-janus/languages","stargazers_url":"https://api.github.com/repos/vogdb/cm-janus/stargazers","contributors_url":"https://api.github.com/repos/vogdb/cm-janus/contributors","subscribers_url":"https://api.github.com/repos/vogdb/cm-janus/subscribers","subscription_url":"https://api.github.com/repos/vogdb/cm-janus/subscription","commits_url":"https://api.github.com/repos/vogdb/cm-janus/commits{/sha}","git_commits_url":"https://api.github.com/repos/vogdb/cm-janus/git/commits{/sha}","comments_url":"https://api.github.com/repos/vogdb/cm-janus/comments{/number}","issue_comment_url":"https://api.github.com/repos/vogdb/cm-janus/issues/comments{/number}","contents_url":"https://api.github.com/repos/vogdb/cm-janus/contents/{+path}","compare_url":"https://api.github.com/repos/vogdb/cm-janus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vogdb/cm-janus/merges","archive_url":"https://api.github.com/repos/vogdb/cm-janus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vogdb/cm-janus/downloads","issues_url":"https://api.github.com/repos/vogdb/cm-janus/issues{/number}","pulls_url":"https://api.github.com/repos/vogdb/cm-janus/pulls{/number}","milestones_url":"https://api.github.com/repos/vogdb/cm-janus/milestones{/number}","notifications_url":"https://api.github.com/repos/vogdb/cm-janus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vogdb/cm-janus/labels{/name}","releases_url":"https://api.github.com/repos/vogdb/cm-janus/releases{/id}","deployments_url":"https://api.github.com/repos/vogdb/cm-janus/deployments","created_at":"2015-10-22T14:11:13Z","updated_at":"2016-01-12T16:15:48Z","pushed_at":"2016-07-04T10:40:13Z","git_url":"git://github.com/vogdb/cm-janus.git","ssh_url":"git@github.com:vogdb/cm-janus.git","clone_url":"https://github.com/vogdb/cm-janus.git","svn_url":"https://github.com/vogdb/cm-janus","homepage":null,"size":855,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cargomedia:master","ref":"master","sha":"a9d7684413c86beb790d20be4810791eba89fbea","user":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":44678874,"name":"cm-janus","full_name":"cargomedia/cm-janus","owner":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cargomedia/cm-janus","description":"cm/janus bridge","fork":false,"url":"https://api.github.com/repos/cargomedia/cm-janus","forks_url":"https://api.github.com/repos/cargomedia/cm-janus/forks","keys_url":"https://api.github.com/repos/cargomedia/cm-janus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cargomedia/cm-janus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cargomedia/cm-janus/teams","hooks_url":"https://api.github.com/repos/cargomedia/cm-janus/hooks","issue_events_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/events{/number}","events_url":"https://api.github.com/repos/cargomedia/cm-janus/events","assignees_url":"https://api.github.com/repos/cargomedia/cm-janus/assignees{/user}","branches_url":"https://api.github.com/repos/cargomedia/cm-janus/branches{/branch}","tags_url":"https://api.github.com/repos/cargomedia/cm-janus/tags","blobs_url":"https://api.github.com/repos/cargomedia/cm-janus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cargomedia/cm-janus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cargomedia/cm-janus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cargomedia/cm-janus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cargomedia/cm-janus/statuses/{sha}","languages_url":"https://api.github.com/repos/cargomedia/cm-janus/languages","stargazers_url":"https://api.github.com/repos/cargomedia/cm-janus/stargazers","contributors_url":"https://api.github.com/repos/cargomedia/cm-janus/contributors","subscribers_url":"https://api.github.com/repos/cargomedia/cm-janus/subscribers","subscription_url":"https://api.github.com/repos/cargomedia/cm-janus/subscription","commits_url":"https://api.github.com/repos/cargomedia/cm-janus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cargomedia/cm-janus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cargomedia/cm-janus/contents/{+path}","compare_url":"https://api.github.com/repos/cargomedia/cm-janus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cargomedia/cm-janus/merges","archive_url":"https://api.github.com/repos/cargomedia/cm-janus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cargomedia/cm-janus/downloads","issues_url":"https://api.github.com/repos/cargomedia/cm-janus/issues{/number}","pulls_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls{/number}","milestones_url":"https://api.github.com/repos/cargomedia/cm-janus/milestones{/number}","notifications_url":"https://api.github.com/repos/cargomedia/cm-janus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cargomedia/cm-janus/labels{/name}","releases_url":"https://api.github.com/repos/cargomedia/cm-janus/releases{/id}","deployments_url":"https://api.github.com/repos/cargomedia/cm-janus/deployments","created_at":"2015-10-21T13:41:09Z","updated_at":"2016-01-12T15:46:59Z","pushed_at":"2016-07-04T15:00:52Z","git_url":"git://github.com/cargomedia/cm-janus.git","ssh_url":"git@github.com:cargomedia/cm-janus.git","clone_url":"https://github.com/cargomedia/cm-janus.git","svn_url":"https://github.com/cargomedia/cm-janus","homepage":null,"size":919,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275"},"html":{"href":"https://github.com/cargomedia/cm-janus/pull/275"},"issue":{"href":"https://api.github.com/repos/cargomedia/cm-janus/issues/275"},"comments":{"href":"https://api.github.com/repos/cargomedia/cm-janus/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/cargomedia/cm-janus/statuses/82bad5f1baa47e4cc8ea1b8738810064761b6f0d"}}}}
{"actor":{"display_login":"tomaszdurka"}}