{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/88793332","pull_request_review_id":9357512,"id":88793332,"diff_hunk":"@@ -14,52 +14,57 @@ namespace json_parse {\n         INT,\n         FLOAT,\n         LIST,\n-        DICT\n+        DICT,\n+        INVELIED\n     };\n \n     struct Object {\n-        Type type;\n+        const Type type;\n         int integer;\n         std::string str;\n         bool boolean;\n         float floating;\n \n-        Object(Type t,int i) :\n-            type(t), integer(i)\n+        std::map<std::string, Object> dictSub;\n+        std::vector<Object> listSub;\n+\n+        Object(const Type& t,const int& i) :\n+            type(std::move(t)), integer(std::move(i))\n         {\n             if(t != Type::INT) throw \"TypeError\"; //WIP\n         }\n \n-        Object(Type t,std::string s) :\n+        Object(const Type& t,const std::string& s) :\n             type(t), str(s)\n         {\n             if(t != Type::STR) throw \"TypeError\"; //WIP\n         }\n \n-        Object(Type t,bool s) :\n+        Object(const Type& t,const bool& s) :\n             type(t), boolean(s)\n         {\n             if(t != Type::BOOL) throw \"TypeError\"; //WIP\n         }\n \n-        Object(Type t,float f) :\n+        Object(const Type& t,const float& f) :\n                 type(t), floating(f)\n         {\n             if(t != Type::FLOAT) throw \"TypeError\"; //WIP\n         }\n \n+        Object():type(Type::INVELIED){};","path":"core/service/json_parse.hpp","position":49,"original_position":49,"commit_id":"23727fabf149b22f5afdc5f6b4a3fc23537d5a86","original_commit_id":"23727fabf149b22f5afdc5f6b4a3fc23537d5a86","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars.githubusercontent.com/u/20982317?v=3","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Member variable 'Object::integer' is not initialized in the constructor.](https://www.codacy.com/app/soramitsu/iroha/file/4478128075/issues/source?bid=3712491&fileBranchId=3923596#l55)","created_at":"2016-11-20T04:34:03Z","updated_at":"2016-11-20T04:34:03Z","html_url":"https://github.com/hyperledger/iroha/pull/65#discussion_r88793332","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/88793332"},"html":{"href":"https://github.com/hyperledger/iroha/pull/65#discussion_r88793332"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/65","id":94506858,"html_url":"https://github.com/hyperledger/iroha/pull/65","diff_url":"https://github.com/hyperledger/iroha/pull/65.diff","patch_url":"https://github.com/hyperledger/iroha/pull/65.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/65","number":65,"state":"open","locked":false,"title":"Feature/fix sumeragi","user":{"login":"MizukiSonoko","id":6281583,"avatar_url":"https://avatars.githubusercontent.com/u/6281583?v=3","gravatar_id":"","url":"https://api.github.com/users/MizukiSonoko","html_url":"https://github.com/MizukiSonoko","followers_url":"https://api.github.com/users/MizukiSonoko/followers","following_url":"https://api.github.com/users/MizukiSonoko/following{/other_user}","gists_url":"https://api.github.com/users/MizukiSonoko/gists{/gist_id}","starred_url":"https://api.github.com/users/MizukiSonoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MizukiSonoko/subscriptions","organizations_url":"https://api.github.com/users/MizukiSonoko/orgs","repos_url":"https://api.github.com/users/MizukiSonoko/repos","events_url":"https://api.github.com/users/MizukiSonoko/events{/privacy}","received_events_url":"https://api.github.com/users/MizukiSonoko/received_events","type":"User","site_admin":false},"body":"Major update\r\n\r\n- sumeragi\r\n- transaction model\r\n- json parse\r\n","created_at":"2016-11-20T04:31:13Z","updated_at":"2016-11-20T04:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/65/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/65/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/65/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/23727fabf149b22f5afdc5f6b4a3fc23537d5a86","head":{"label":"hyperledger:feature/fix-sumeragi","ref":"feature/fix-sumeragi","sha":"23727fabf149b22f5afdc5f6b4a3fc23537d5a86","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-11-20T01:56:57Z","pushed_at":"2016-11-20T04:31:13Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":20080,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":53,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"67cfb1120edc50d8942a0163a279ca936f028701","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-11-20T01:56:57Z","pushed_at":"2016-11-20T04:31:13Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":20080,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/65"},"html":{"href":"https://github.com/hyperledger/iroha/pull/65"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/65"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/23727fabf149b22f5afdc5f6b4a3fc23537d5a86"}}}}
{"actor":{"display_login":"takemiyamakoto"}}