{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/puppet-harden/issues/8","labels_url":"https://api.github.com/repos/alphagov/puppet-harden/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/puppet-harden/issues/8/comments","events_url":"https://api.github.com/repos/alphagov/puppet-harden/issues/8/events","html_url":"https://github.com/alphagov/puppet-harden/pull/8","id":126906896,"number":8,"title":"Use lowercase 'n' in 'no'","user":{"login":"mattbostock","id":4348848,"avatar_url":"https://avatars.githubusercontent.com/u/4348848?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbostock","html_url":"https://github.com/mattbostock","followers_url":"https://api.github.com/users/mattbostock/followers","following_url":"https://api.github.com/users/mattbostock/following{/other_user}","gists_url":"https://api.github.com/users/mattbostock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbostock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbostock/subscriptions","organizations_url":"https://api.github.com/users/mattbostock/orgs","repos_url":"https://api.github.com/users/mattbostock/repos","events_url":"https://api.github.com/users/mattbostock/events{/privacy}","received_events_url":"https://api.github.com/users/mattbostock/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-15T16:30:04Z","updated_at":"2016-01-21T13:10:19Z","closed_at":"2016-01-18T16:19:51Z","pull_request":{"url":"https://api.github.com/repos/alphagov/puppet-harden/pulls/8","html_url":"https://github.com/alphagov/puppet-harden/pull/8","diff_url":"https://github.com/alphagov/puppet-harden/pull/8.diff","patch_url":"https://github.com/alphagov/puppet-harden/pull/8.patch"},"body":"Most OpenSSH options take a value of `yes` or `no` (lowercase) according\r\nto the man pages.\r\n\r\nHaving looked at the code with @rboulton, we don't think this will make\r\nany difference, but it's good to be consistent:\r\n\r\nhttps://github.com/openssh/openssh-portable/blob/V_6_6/readconf.c#L772\r\n\r\nFrom http://linux.die.net/man/3/strcasecmp:\r\n> The strcasecmp() function compares the two strings s1 and s2, ignoring\r\n> the case of the characters."},"comment":{"url":"https://api.github.com/repos/alphagov/puppet-harden/issues/comments/173564032","html_url":"https://github.com/alphagov/puppet-harden/pull/8#issuecomment-173564032","issue_url":"https://api.github.com/repos/alphagov/puppet-harden/issues/8","id":173564032,"user":{"login":"alexmuller","id":121219,"avatar_url":"https://avatars.githubusercontent.com/u/121219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmuller","html_url":"https://github.com/alexmuller","followers_url":"https://api.github.com/users/alexmuller/followers","following_url":"https://api.github.com/users/alexmuller/following{/other_user}","gists_url":"https://api.github.com/users/alexmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmuller/subscriptions","organizations_url":"https://api.github.com/users/alexmuller/orgs","repos_url":"https://api.github.com/users/alexmuller/repos","events_url":"https://api.github.com/users/alexmuller/events{/privacy}","received_events_url":"https://api.github.com/users/alexmuller/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T13:10:19Z","updated_at":"2016-01-21T13:10:19Z","body":"Interestingly @deanwilson and I have discovered the uppercase does appear to be a problem in at least some places:\r\n\r\n```\r\n2016-01-21T13:06:18Z: [mongo-licensify] /etc/ssh/ssh_config line 13: Bad yes/no argument.\r\n```"}}