{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eigen/pulls/comments/58566660","id":58566660,"diff_hunk":"@@ -229,17 +207,23 @@ extension SliderView {\n     }\n }\n \n-private typealias TableView = AuctionRefineViewController\n-extension TableView: UITableViewDataSource, UITableViewDelegate {\n+class RefineViewControllerTableViewHandler: NSObject, UITableViewDataSource, UITableViewDelegate  {\n+    \n+    // closures from currentSettings","path":"Artsy/View_Controllers/Auction/RefineViewController+Private.swift","position":160,"original_position":160,"commit_id":"c68caec4ef5ab7d2f512814e29571e5b321e0e4e","original_commit_id":"c68caec4ef5ab7d2f512814e29571e5b321e0e4e","user":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"body":"@ashfurrow since the tableViewHandler needs so much information from the RefineSettings (i.e. how many sections it needs, how many rows in each section, titles for each row, and selection state), does it make sense to pass in the RefineSettings in the initializer instead of a bunch of closures?","created_at":"2016-04-05T16:07:31Z","updated_at":"2016-04-05T16:07:31Z","html_url":"https://github.com/artsy/eigen/pull/1355#discussion_r58566660","pull_request_url":"https://api.github.com/repos/artsy/eigen/pulls/1355","_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments/58566660"},"html":{"href":"https://github.com/artsy/eigen/pull/1355#discussion_r58566660"},"pull_request":{"href":"https://api.github.com/repos/artsy/eigen/pulls/1355"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eigen/pulls/1355","id":63953431,"html_url":"https://github.com/artsy/eigen/pull/1355","diff_url":"https://github.com/artsy/eigen/pull/1355.diff","patch_url":"https://github.com/artsy/eigen/pull/1355.patch","issue_url":"https://api.github.com/repos/artsy/eigen/issues/1355","number":1355,"state":"open","locked":false,"title":"[WIP][GeneUpdate] Generalizing the AuctionRefineVC","user":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"body":"- [x] Added a way to use developerExtras in swift\r\n- [x] Started generalizing the AuctionRefineViewController into the new RefineArtworksViewController\r\n- [ ] Complete generalization ","created_at":"2016-03-23T21:09:51Z","updated_at":"2016-04-05T16:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19c7dabb4ca290209ce98778178a6ac44f1dfcaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eigen/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/artsy/eigen/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/1355/comments","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/c68caec4ef5ab7d2f512814e29571e5b321e0e4e","head":{"label":"artsy:sarahscott-generic-refine-vc","ref":"sarahscott-generic-refine-vc","sha":"c68caec4ef5ab7d2f512814e29571e5b321e0e4e","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/eigen/deployments","created_at":"2015-01-22T21:52:39Z","updated_at":"2016-04-05T05:11:59Z","pushed_at":"2016-04-05T14:46:46Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":114004,"stargazers_count":1250,"watchers_count":1250,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":270,"forks":185,"open_issues":270,"watchers":1250,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"7146db78253485452e06992c006ebd8afe5def31","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/eigen/deployments","created_at":"2015-01-22T21:52:39Z","updated_at":"2016-04-05T05:11:59Z","pushed_at":"2016-04-05T14:46:46Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":114004,"stargazers_count":1250,"watchers_count":1250,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":270,"forks":185,"open_issues":270,"watchers":1250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/1355"},"html":{"href":"https://github.com/artsy/eigen/pull/1355"},"issue":{"href":"https://api.github.com/repos/artsy/eigen/issues/1355"},"comments":{"href":"https://api.github.com/repos/artsy/eigen/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eigen/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eigen/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eigen/statuses/c68caec4ef5ab7d2f512814e29571e5b321e0e4e"}}}}