{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/63330017","id":63330017,"diff_hunk":"@@ -1971,50 +1965,32 @@ public function buildBreadcrumbs($action, MenuItemInterface $menu = null)\n             return $this->breadcrumbs[$action];\n         }\n \n-        if (!$menu) {\n-            $menu = $this->menuFactory->createItem('root');\n+        return $this->breadcrumbs[$action] = $this->getBreadcrumbsBuilder()\n+            ->buildBreadcrumbs($this, $action, $menu);\n+    }\n \n-            $menu = $menu->addChild(\n-                $this->trans($this->getLabelTranslatorStrategy()->getLabel('dashboard', 'breadcrumb', 'link'), array(), 'SonataAdminBundle'),\n-                array('uri' => $this->routeGenerator->generate('sonata_admin_dashboard'))\n-            );\n+    /**\n+     * @return BreadcrumbsBuilderInterface\n+     */\n+    final public function getBreadcrumbsBuilder()","path":"Admin/AbstractAdmin.php","position":53,"original_position":53,"commit_id":"677f17c72fa6ca6be2712a73fd32ba4a232f6163","original_commit_id":"677f17c72fa6ca6be2712a73fd32ba4a232f6163","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"Why are you making this final? ","created_at":"2016-05-16T09:37:23Z","updated_at":"2016-05-16T09:37:23Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3791#discussion_r63330017","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/63330017"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3791#discussion_r63330017"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791","id":69576803,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3791","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3791.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3791.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3791","number":3791,"state":"open","locked":false,"title":"move the breadcrumb build in a separate component","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"The Admin class is huge (~ 3000 lines), and it handles many unrelated\r\nthings. Let's move out what we can, starting with the breadcrumb\r\ngeneration code.","created_at":"2016-05-10T20:59:42Z","updated_at":"2016-05-16T09:37:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e4c76428ef8f16d8f0dd3e3695168778088fffb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3791/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/677f17c72fa6ca6be2712a73fd32ba4a232f6163","head":{"label":"greg0ire:bc_extract_breadcrumbs_builder","ref":"bc_extract_breadcrumbs_builder","sha":"677f17c72fa6ca6be2712a73fd32ba4a232f6163","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":19613045,"name":"SonataAdminBundle","full_name":"greg0ire/SonataAdminBundle","owner":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg0ire/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/greg0ire/SonataAdminBundle","forks_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/deployments","created_at":"2014-05-09T14:02:34Z","updated_at":"2014-06-09T11:24:36Z","pushed_at":"2016-05-15T12:55:59Z","git_url":"git://github.com/greg0ire/SonataAdminBundle.git","ssh_url":"git@github.com:greg0ire/SonataAdminBundle.git","clone_url":"https://github.com/greg0ire/SonataAdminBundle.git","svn_url":"https://github.com/greg0ire/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":17876,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"d41f15897fd3372a9240dd22e55f6554b45d2fab","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-05-13T20:58:48Z","pushed_at":"2016-05-16T08:59:43Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22209,"stargazers_count":1376,"watchers_count":1376,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":973,"mirror_url":null,"open_issues_count":382,"forks":973,"open_issues":382,"watchers":1376,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3791"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3791"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3791/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3791/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/677f17c72fa6ca6be2712a73fd32ba4a232f6163"}}}}