{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/2890","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/2890/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/2890/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/2890/events","html_url":"https://github.com/dotnet/coreclr/pull/2890","id":129305096,"number":2890,"title":"Fix gc-hole while emitting CORINFO_HELP_ASSIGN_BYREF helper call on Unix","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-27T23:48:33Z","updated_at":"2016-01-28T04:26:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/2890","html_url":"https://github.com/dotnet/coreclr/pull/2890","diff_url":"https://github.com/dotnet/coreclr/pull/2890.diff","patch_url":"https://github.com/dotnet/coreclr/pull/2890.patch"},"body":"CORINFO_HELP_ASSIGN_BYREF is a no-gc helper that takes its parameters in RSI and RDI and doesn't trash them.\r\n\r\nEmit.cpp!emitNoGCHelper() is used by emitter to compute the registers that are trashed by a helper call to update gc-info state maintained by emitter (see emitxarch.cpp!emitins_call()).  emitNoGCHelper() on Windows is modeled to return RBM_CALLEE_TRASH_NOGC (which is same as RBM_CALLEE_TRASH) and it happens to work fine because RSI and RDI are not part of\r\nRBM_CALLEE_TRASH set.  But on Unix Amd64, RSI and RDI are part of RBM_CALLEE_TRASH and hence gets reported as killed by ASSIGN_BYREF helper and hence the gc-hole.\r\n\r\nFix: exclude RSI and RDI in set of registers killed by ASSIGN_BYREF helper.\r\n\r\nFix #2763"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/175967092","html_url":"https://github.com/dotnet/coreclr/pull/2890#issuecomment-175967092","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/2890","id":175967092,"user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T04:26:50Z","updated_at":"2016-01-28T04:26:50Z","body":"@dotnet-bot test Windows_NT x86 Debug Build"}}