{"action":"created","issue":{"url":"https://api.github.com/repos/conda/conda/issues/2623","repository_url":"https://api.github.com/repos/conda/conda","labels_url":"https://api.github.com/repos/conda/conda/issues/2623/labels{/name}","comments_url":"https://api.github.com/repos/conda/conda/issues/2623/comments","events_url":"https://api.github.com/repos/conda/conda/issues/2623/events","html_url":"https://github.com/conda/conda/pull/2623","id":159248441,"number":2623,"title":"add --shortcuts option that installs shortcuts.  Disables shortcuts b…","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/conda/conda/milestones/2","html_url":"https://github.com/conda/conda/milestones/4.1","labels_url":"https://api.github.com/repos/conda/conda/milestones/2/labels","id":1716159,"number":2,"title":"4.1","description":"","creator":{"login":"kalefranz","id":1418419,"avatar_url":"https://avatars.githubusercontent.com/u/1418419?v=3","gravatar_id":"","url":"https://api.github.com/users/kalefranz","html_url":"https://github.com/kalefranz","followers_url":"https://api.github.com/users/kalefranz/followers","following_url":"https://api.github.com/users/kalefranz/following{/other_user}","gists_url":"https://api.github.com/users/kalefranz/gists{/gist_id}","starred_url":"https://api.github.com/users/kalefranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalefranz/subscriptions","organizations_url":"https://api.github.com/users/kalefranz/orgs","repos_url":"https://api.github.com/users/kalefranz/repos","events_url":"https://api.github.com/users/kalefranz/events{/privacy}","received_events_url":"https://api.github.com/users/kalefranz/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":65,"state":"open","created_at":"2016-04-19T03:25:44Z","updated_at":"2016-06-11T20:09:29Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-08T19:14:17Z","updated_at":"2016-06-11T23:15:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda/conda/pulls/2623","html_url":"https://github.com/conda/conda/pull/2623","diff_url":"https://github.com/conda/conda/pull/2623.diff","patch_url":"https://github.com/conda/conda/pull/2623.patch"},"body":"Purpose here is to provide a --shortcut argument to conda create and conda install that enables shortcut installation.  This replaces the current default of always installing shortcuts, which causes problems on Windows when a system-wide install is given to users - though they may have write permissions to the root conda environment, they can't do the elevation to install shortcuts as all users.\r\n\r\nNeeds tests.  I'm thinking it should be a test that runs a dummy creation/install with:\r\n    - install console_shortcut package, known to have a shortcut\r\n    - environment starting with _ should have output text about prefix starting with '_', so no shortcuts installed.  This is sufficient to know that the correct code path is exercised.\r\n    - environment not starting with _ should not raise any exceptions.  Do we want to clean up any shortcut files that this would create?\r\n\r\nI have not altered removal logic, with the thought that removal can safely always happen - this needs a test, too: install console_shortcut to a prefix without --shortcuts, (shortcuts should not be created), then remove the package with conda remove - any barfs?\r\n\r\nWhere should these tests go, Kale?   Do you see any way to do these in-process?\r\n\r\n@kalefranz @joelhullcio "},"comment":{"url":"https://api.github.com/repos/conda/conda/issues/comments/225399690","html_url":"https://github.com/conda/conda/pull/2623#issuecomment-225399690","issue_url":"https://api.github.com/repos/conda/conda/issues/2623","id":225399690,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T23:15:08Z","updated_at":"2016-06-11T23:15:08Z","body":"## [Current coverage][cc-pull] is **69.41%**\n> Merging [#2623][cc-pull] into [master][cc-base-branch] will increase coverage by **<.01%**\n\n```diff\n@@             master      #2623   diff @@\n==========================================\n  Files            45         45          \n  Lines          6971       6985    +14   \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n+ Hits           4838       4848    +10   \n- Misses         2133       2137     +4   \n  Partials          0          0          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [fe1ed21...7fb1eda][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/conda/conda/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/conda/conda/compare/fe1ed21a98f7e8be02f3506f49d742abb43f3ee9...7fb1eda7987946f343be029f5fdbfec1904d65c7\n[cc-pull]: https://codecov.io/gh/conda/conda/pull/2623?src=pr"}}
{"actor":{"display_login":"codecov-io"}}