{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11","id":85708564,"html_url":"https://github.com/it-is-5pm-somwhere/team-chess-app/pull/11","diff_url":"https://github.com/it-is-5pm-somwhere/team-chess-app/pull/11.diff","patch_url":"https://github.com/it-is-5pm-somwhere/team-chess-app/pull/11.patch","issue_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/11","number":11,"state":"closed","locked":false,"title":"STI Pieces creation and started building the logic","user":{"login":"EGimenoS","id":18742365,"avatar_url":"https://avatars.githubusercontent.com/u/18742365?v=3","gravatar_id":"","url":"https://api.github.com/users/EGimenoS","html_url":"https://github.com/EGimenoS","followers_url":"https://api.github.com/users/EGimenoS/followers","following_url":"https://api.github.com/users/EGimenoS/following{/other_user}","gists_url":"https://api.github.com/users/EGimenoS/gists{/gist_id}","starred_url":"https://api.github.com/users/EGimenoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EGimenoS/subscriptions","organizations_url":"https://api.github.com/users/EGimenoS/orgs","repos_url":"https://api.github.com/users/EGimenoS/repos","events_url":"https://api.github.com/users/EGimenoS/events{/privacy}","received_events_url":"https://api.github.com/users/EGimenoS/received_events","type":"User","site_admin":false},"body":"[EDIT] Refactored the tests and some of the logic making more use of the superclass Piece.\r\n\r\n\r\nI have created the models to define the type of pieces by using Single Table Inheritance, and defined several methods that describe the basic movement of the pieces. I have also write some basic tests.\r\n\r\nthings to take into account: \r\n\r\n- To be defined the knight moves\r\n\r\n- To be defined how the pawn moves when captures another piece\r\n\r\n- To be defined Castling\r\n\r\n- To be defined Pawn promotion\r\n\r\n[EDIT: already solved] Also, I'm having problems with the Pawn logic to pass the tests. The method advancing? is returning true no matter what. I'm absolutely sure I'm missing something obvious but I've ben trying for a while and I would like that some fresh eyes take a look on that.\r\n\r\nWe should also think if we shoud refactor some of the logic, cause there are several moves that are the same for more than one piece (for example, the queen movements is a combination of both the rok and the bishop). I rather have them the way I wrote them cause I think the code is more readable as you don't have to refer to a method placed in other model, but I'm aware is not the standard.","created_at":"2016-09-18T12:28:51Z","updated_at":"2016-09-21T02:17:46Z","closed_at":"2016-09-21T02:17:46Z","merged_at":"2016-09-21T02:17:46Z","merge_commit_sha":"f9ef46b7afc1d9326a41a1a8a2ef94e90c72d667","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11/commits","review_comments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11/comments","review_comment_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/11/comments","statuses_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/statuses/bee6007daf5f471890383bc58086232209caef8c","head":{"label":"it-is-5pm-somwhere:STI-Pieces","ref":"STI-Pieces","sha":"bee6007daf5f471890383bc58086232209caef8c","user":{"login":"it-is-5pm-somwhere","id":22102565,"avatar_url":"https://avatars.githubusercontent.com/u/22102565?v=3","gravatar_id":"","url":"https://api.github.com/users/it-is-5pm-somwhere","html_url":"https://github.com/it-is-5pm-somwhere","followers_url":"https://api.github.com/users/it-is-5pm-somwhere/followers","following_url":"https://api.github.com/users/it-is-5pm-somwhere/following{/other_user}","gists_url":"https://api.github.com/users/it-is-5pm-somwhere/gists{/gist_id}","starred_url":"https://api.github.com/users/it-is-5pm-somwhere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/it-is-5pm-somwhere/subscriptions","organizations_url":"https://api.github.com/users/it-is-5pm-somwhere/orgs","repos_url":"https://api.github.com/users/it-is-5pm-somwhere/repos","events_url":"https://api.github.com/users/it-is-5pm-somwhere/events{/privacy}","received_events_url":"https://api.github.com/users/it-is-5pm-somwhere/received_events","type":"Organization","site_admin":false},"repo":{"id":67812988,"name":"team-chess-app","full_name":"it-is-5pm-somwhere/team-chess-app","owner":{"login":"it-is-5pm-somwhere","id":22102565,"avatar_url":"https://avatars.githubusercontent.com/u/22102565?v=3","gravatar_id":"","url":"https://api.github.com/users/it-is-5pm-somwhere","html_url":"https://github.com/it-is-5pm-somwhere","followers_url":"https://api.github.com/users/it-is-5pm-somwhere/followers","following_url":"https://api.github.com/users/it-is-5pm-somwhere/following{/other_user}","gists_url":"https://api.github.com/users/it-is-5pm-somwhere/gists{/gist_id}","starred_url":"https://api.github.com/users/it-is-5pm-somwhere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/it-is-5pm-somwhere/subscriptions","organizations_url":"https://api.github.com/users/it-is-5pm-somwhere/orgs","repos_url":"https://api.github.com/users/it-is-5pm-somwhere/repos","events_url":"https://api.github.com/users/it-is-5pm-somwhere/events{/privacy}","received_events_url":"https://api.github.com/users/it-is-5pm-somwhere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/it-is-5pm-somwhere/team-chess-app","description":null,"fork":false,"url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app","forks_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/forks","keys_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/teams","hooks_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/hooks","issue_events_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/events{/number}","events_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/events","assignees_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/assignees{/user}","branches_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/branches{/branch}","tags_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/tags","blobs_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/statuses/{sha}","languages_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/languages","stargazers_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/stargazers","contributors_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/contributors","subscribers_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/subscribers","subscription_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/subscription","commits_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/contents/{+path}","compare_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/merges","archive_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/downloads","issues_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues{/number}","pulls_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls{/number}","milestones_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/milestones{/number}","notifications_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/labels{/name}","releases_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/releases{/id}","deployments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/deployments","created_at":"2016-09-09T16:03:54Z","updated_at":"2016-09-14T21:44:34Z","pushed_at":"2016-09-21T02:17:47Z","git_url":"git://github.com/it-is-5pm-somwhere/team-chess-app.git","ssh_url":"git@github.com:it-is-5pm-somwhere/team-chess-app.git","clone_url":"https://github.com/it-is-5pm-somwhere/team-chess-app.git","svn_url":"https://github.com/it-is-5pm-somwhere/team-chess-app","homepage":null,"size":102,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"it-is-5pm-somwhere:master","ref":"master","sha":"41d7ad8aec5047657b60202afc73bb9d7af4e98c","user":{"login":"it-is-5pm-somwhere","id":22102565,"avatar_url":"https://avatars.githubusercontent.com/u/22102565?v=3","gravatar_id":"","url":"https://api.github.com/users/it-is-5pm-somwhere","html_url":"https://github.com/it-is-5pm-somwhere","followers_url":"https://api.github.com/users/it-is-5pm-somwhere/followers","following_url":"https://api.github.com/users/it-is-5pm-somwhere/following{/other_user}","gists_url":"https://api.github.com/users/it-is-5pm-somwhere/gists{/gist_id}","starred_url":"https://api.github.com/users/it-is-5pm-somwhere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/it-is-5pm-somwhere/subscriptions","organizations_url":"https://api.github.com/users/it-is-5pm-somwhere/orgs","repos_url":"https://api.github.com/users/it-is-5pm-somwhere/repos","events_url":"https://api.github.com/users/it-is-5pm-somwhere/events{/privacy}","received_events_url":"https://api.github.com/users/it-is-5pm-somwhere/received_events","type":"Organization","site_admin":false},"repo":{"id":67812988,"name":"team-chess-app","full_name":"it-is-5pm-somwhere/team-chess-app","owner":{"login":"it-is-5pm-somwhere","id":22102565,"avatar_url":"https://avatars.githubusercontent.com/u/22102565?v=3","gravatar_id":"","url":"https://api.github.com/users/it-is-5pm-somwhere","html_url":"https://github.com/it-is-5pm-somwhere","followers_url":"https://api.github.com/users/it-is-5pm-somwhere/followers","following_url":"https://api.github.com/users/it-is-5pm-somwhere/following{/other_user}","gists_url":"https://api.github.com/users/it-is-5pm-somwhere/gists{/gist_id}","starred_url":"https://api.github.com/users/it-is-5pm-somwhere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/it-is-5pm-somwhere/subscriptions","organizations_url":"https://api.github.com/users/it-is-5pm-somwhere/orgs","repos_url":"https://api.github.com/users/it-is-5pm-somwhere/repos","events_url":"https://api.github.com/users/it-is-5pm-somwhere/events{/privacy}","received_events_url":"https://api.github.com/users/it-is-5pm-somwhere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/it-is-5pm-somwhere/team-chess-app","description":null,"fork":false,"url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app","forks_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/forks","keys_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/teams","hooks_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/hooks","issue_events_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/events{/number}","events_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/events","assignees_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/assignees{/user}","branches_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/branches{/branch}","tags_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/tags","blobs_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/statuses/{sha}","languages_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/languages","stargazers_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/stargazers","contributors_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/contributors","subscribers_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/subscribers","subscription_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/subscription","commits_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/contents/{+path}","compare_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/merges","archive_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/downloads","issues_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues{/number}","pulls_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls{/number}","milestones_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/milestones{/number}","notifications_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/labels{/name}","releases_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/releases{/id}","deployments_url":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/deployments","created_at":"2016-09-09T16:03:54Z","updated_at":"2016-09-14T21:44:34Z","pushed_at":"2016-09-21T02:17:47Z","git_url":"git://github.com/it-is-5pm-somwhere/team-chess-app.git","ssh_url":"git@github.com:it-is-5pm-somwhere/team-chess-app.git","clone_url":"https://github.com/it-is-5pm-somwhere/team-chess-app.git","svn_url":"https://github.com/it-is-5pm-somwhere/team-chess-app","homepage":null,"size":102,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11"},"html":{"href":"https://github.com/it-is-5pm-somwhere/team-chess-app/pull/11"},"issue":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/11"},"comments":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/it-is-5pm-somwhere/team-chess-app/statuses/bee6007daf5f471890383bc58086232209caef8c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lasley","id":7397578,"avatar_url":"https://avatars.githubusercontent.com/u/7397578?v=3","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"comments":4,"review_comments":42,"commits":17,"additions":447,"deletions":142,"changed_files":32}}
{"actor":{"display_login":"lasley"}}