{"action":"closed","number":213,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213","id":64899072,"html_url":"https://github.com/open-source-economics/OG-USA/pull/213","diff_url":"https://github.com/open-source-economics/OG-USA/pull/213.diff","patch_url":"https://github.com/open-source-economics/OG-USA/pull/213.patch","issue_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/213","number":213,"state":"closed","locked":false,"title":"Update outlier identification in txfunc.py","user":{"login":"rickecon","id":4317690,"avatar_url":"https://avatars.githubusercontent.com/u/4317690?v=3","gravatar_id":"","url":"https://api.github.com/users/rickecon","html_url":"https://github.com/rickecon","followers_url":"https://api.github.com/users/rickecon/followers","following_url":"https://api.github.com/users/rickecon/following{/other_user}","gists_url":"https://api.github.com/users/rickecon/gists{/gist_id}","starred_url":"https://api.github.com/users/rickecon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickecon/subscriptions","organizations_url":"https://api.github.com/users/rickecon/orgs","repos_url":"https://api.github.com/users/rickecon/repos","events_url":"https://api.github.com/users/rickecon/events{/privacy}","received_events_url":"https://api.github.com/users/rickecon/received_events","type":"User","site_admin":false},"body":"1) This PR updates the outlier identification in the find_outliers() function in txfunc.py. In particular, I look at SSE/N, where SSE is the sum of squared errors and N is the number of observations in a particular age and year. This provides better outlier identification than the previous method that only tracked SSE.\r\n\r\n2) I also did extensive updating of the commenting docstrings in the txfunc.py module. It still needs some more work, but the pattern is there.\r\n\r\n\r\n","created_at":"2016-04-01T06:00:55Z","updated_at":"2016-04-01T14:45:58Z","closed_at":"2016-04-01T14:45:58Z","merged_at":"2016-04-01T14:45:58Z","merge_commit_sha":"aeb831f5f1932fc5a2b56766cc0d917c48084878","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/213/comments","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/5e067c1b4f7ab9cedd394a449744a2f8ae814b11","head":{"label":"rickecon:master","ref":"master","sha":"5e067c1b4f7ab9cedd394a449744a2f8ae814b11","user":{"login":"rickecon","id":4317690,"avatar_url":"https://avatars.githubusercontent.com/u/4317690?v=3","gravatar_id":"","url":"https://api.github.com/users/rickecon","html_url":"https://github.com/rickecon","followers_url":"https://api.github.com/users/rickecon/followers","following_url":"https://api.github.com/users/rickecon/following{/other_user}","gists_url":"https://api.github.com/users/rickecon/gists{/gist_id}","starred_url":"https://api.github.com/users/rickecon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickecon/subscriptions","organizations_url":"https://api.github.com/users/rickecon/orgs","repos_url":"https://api.github.com/users/rickecon/repos","events_url":"https://api.github.com/users/rickecon/events{/privacy}","received_events_url":"https://api.github.com/users/rickecon/received_events","type":"User","site_admin":false},"repo":{"id":53560361,"name":"OG-USA","full_name":"rickecon/OG-USA","owner":{"login":"rickecon","id":4317690,"avatar_url":"https://avatars.githubusercontent.com/u/4317690?v=3","gravatar_id":"","url":"https://api.github.com/users/rickecon","html_url":"https://github.com/rickecon","followers_url":"https://api.github.com/users/rickecon/followers","following_url":"https://api.github.com/users/rickecon/following{/other_user}","gists_url":"https://api.github.com/users/rickecon/gists{/gist_id}","starred_url":"https://api.github.com/users/rickecon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickecon/subscriptions","organizations_url":"https://api.github.com/users/rickecon/orgs","repos_url":"https://api.github.com/users/rickecon/repos","events_url":"https://api.github.com/users/rickecon/events{/privacy}","received_events_url":"https://api.github.com/users/rickecon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rickecon/OG-USA","description":"Dynamic Tax Scoring Model","fork":true,"url":"https://api.github.com/repos/rickecon/OG-USA","forks_url":"https://api.github.com/repos/rickecon/OG-USA/forks","keys_url":"https://api.github.com/repos/rickecon/OG-USA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rickecon/OG-USA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rickecon/OG-USA/teams","hooks_url":"https://api.github.com/repos/rickecon/OG-USA/hooks","issue_events_url":"https://api.github.com/repos/rickecon/OG-USA/issues/events{/number}","events_url":"https://api.github.com/repos/rickecon/OG-USA/events","assignees_url":"https://api.github.com/repos/rickecon/OG-USA/assignees{/user}","branches_url":"https://api.github.com/repos/rickecon/OG-USA/branches{/branch}","tags_url":"https://api.github.com/repos/rickecon/OG-USA/tags","blobs_url":"https://api.github.com/repos/rickecon/OG-USA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rickecon/OG-USA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rickecon/OG-USA/git/refs{/sha}","trees_url":"https://api.github.com/repos/rickecon/OG-USA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rickecon/OG-USA/statuses/{sha}","languages_url":"https://api.github.com/repos/rickecon/OG-USA/languages","stargazers_url":"https://api.github.com/repos/rickecon/OG-USA/stargazers","contributors_url":"https://api.github.com/repos/rickecon/OG-USA/contributors","subscribers_url":"https://api.github.com/repos/rickecon/OG-USA/subscribers","subscription_url":"https://api.github.com/repos/rickecon/OG-USA/subscription","commits_url":"https://api.github.com/repos/rickecon/OG-USA/commits{/sha}","git_commits_url":"https://api.github.com/repos/rickecon/OG-USA/git/commits{/sha}","comments_url":"https://api.github.com/repos/rickecon/OG-USA/comments{/number}","issue_comment_url":"https://api.github.com/repos/rickecon/OG-USA/issues/comments{/number}","contents_url":"https://api.github.com/repos/rickecon/OG-USA/contents/{+path}","compare_url":"https://api.github.com/repos/rickecon/OG-USA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rickecon/OG-USA/merges","archive_url":"https://api.github.com/repos/rickecon/OG-USA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rickecon/OG-USA/downloads","issues_url":"https://api.github.com/repos/rickecon/OG-USA/issues{/number}","pulls_url":"https://api.github.com/repos/rickecon/OG-USA/pulls{/number}","milestones_url":"https://api.github.com/repos/rickecon/OG-USA/milestones{/number}","notifications_url":"https://api.github.com/repos/rickecon/OG-USA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rickecon/OG-USA/labels{/name}","releases_url":"https://api.github.com/repos/rickecon/OG-USA/releases{/id}","deployments_url":"https://api.github.com/repos/rickecon/OG-USA/deployments","created_at":"2016-03-10T06:17:06Z","updated_at":"2016-03-10T06:17:09Z","pushed_at":"2016-04-01T05:55:02Z","git_url":"git://github.com/rickecon/OG-USA.git","ssh_url":"git@github.com:rickecon/OG-USA.git","clone_url":"https://github.com/rickecon/OG-USA.git","svn_url":"https://github.com/rickecon/OG-USA","homepage":"","size":474227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"38e6432548ea515eb4dffb805f8e1726a66e9af4","user":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":30023836,"name":"OG-USA","full_name":"open-source-economics/OG-USA","owner":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/OG-USA","description":"Dynamic Tax Scoring Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/OG-USA","forks_url":"https://api.github.com/repos/open-source-economics/OG-USA/forks","keys_url":"https://api.github.com/repos/open-source-economics/OG-USA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/OG-USA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/OG-USA/teams","hooks_url":"https://api.github.com/repos/open-source-economics/OG-USA/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/OG-USA/events","assignees_url":"https://api.github.com/repos/open-source-economics/OG-USA/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/OG-USA/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/tags","blobs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/OG-USA/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/OG-USA/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/OG-USA/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscription","commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/OG-USA/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/OG-USA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/OG-USA/merges","archive_url":"https://api.github.com/repos/open-source-economics/OG-USA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/OG-USA/downloads","issues_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/OG-USA/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/OG-USA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/OG-USA/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/OG-USA/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/OG-USA/deployments","created_at":"2015-01-29T14:33:14Z","updated_at":"2016-03-08T08:43:48Z","pushed_at":"2016-04-01T14:45:58Z","git_url":"git://github.com/open-source-economics/OG-USA.git","ssh_url":"git@github.com:open-source-economics/OG-USA.git","clone_url":"https://github.com/open-source-economics/OG-USA.git","svn_url":"https://github.com/open-source-economics/OG-USA","homepage":"","size":480818,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":43,"forks":18,"open_issues":43,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213"},"html":{"href":"https://github.com/open-source-economics/OG-USA/pull/213"},"issue":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/213"},"comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/5e067c1b4f7ab9cedd394a449744a2f8ae814b11"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jdebacker","id":10715924,"avatar_url":"https://avatars.githubusercontent.com/u/10715924?v=3","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":235,"deletions":184,"changed_files":3}}