{"action":"created","issue":{"url":"https://api.github.com/repos/php-http/client-common/issues/45","repository_url":"https://api.github.com/repos/php-http/client-common","labels_url":"https://api.github.com/repos/php-http/client-common/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/php-http/client-common/issues/45/comments","events_url":"https://api.github.com/repos/php-http/client-common/issues/45/events","html_url":"https://github.com/php-http/client-common/issues/45","id":174720620,"number":45,"title":"Rewrite tests to avoid mocking HTTP messages","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-02T09:43:51Z","updated_at":"2016-09-06T09:23:34Z","closed_at":null,"body":"| Q            | A\r\n| ------------ | ---\r\n| Bug?         | no\r\n| New Feature? | no\r\n| Version      | <=1.3.x\r\n\r\n\r\n#### Actual Behavior\r\n\r\nTesting our code is pretty hard because of all the mocks necessary to test HTTP Message related code and Plugin Chain.\r\n\r\n#### Expected Behavior\r\n\r\nIt should be pretty easy to understand tests, modify behaviour, provide new test cases, etc.\r\n\r\n\r\n#### Possible Solutions\r\n\r\n- Rewrite specifications to simple unit tests using the MockClient.\r\n- Rewrite specifications to use actual Message objects (so only remove mocking, but preserve specifications)\r\n\r\nWDYT?\r\n"},"comment":{"url":"https://api.github.com/repos/php-http/client-common/issues/comments/244896995","html_url":"https://github.com/php-http/client-common/issues/45#issuecomment-244896995","issue_url":"https://api.github.com/repos/php-http/client-common/issues/45","id":244896995,"user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T09:23:34Z","updated_at":"2016-09-06T09:23:34Z","body":"Of course PHPSpec can use actual objects, but it would be pointless to use the MockClient in that case, since PHPSpec (obviously) does not allow such assertions."}}
{"actor":{"display_login":"sagikazarmark"}}