{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/4090","repository_url":"https://api.github.com/repos/hypothesis/h","labels_url":"https://api.github.com/repos/hypothesis/h/issues/4090/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/4090/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/4090/events","html_url":"https://github.com/hypothesis/h/pull/4090","id":190084482,"number":4090,"title":"Make document links in URL buckets clickable","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"labels":[{"id":460185610,"url":"https://api.github.com/repos/hypothesis/h/labels/In%20Review","name":"In Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-17T15:50:24Z","updated_at":"2016-11-21T16:37:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/4090","html_url":"https://github.com/hypothesis/h/pull/4090","diff_url":"https://github.com/hypothesis/h/pull/4090.diff","patch_url":"https://github.com/hypothesis/h/pull/4090.patch"},"body":"This implements the document links as shown in the \"URLs\" section of the bucket in the mocks at https://projects.invisionapp.com/share/B88RCLRFN#/screens\r\n\r\nFor each bucket, there are two links at the top:\r\n- A prettified version of the URL which goes to the URL without the Hypothesis overlay activated\r\n- A \"Visit annotations in context\" link which is a direct link to the first annotation in the bucket. When the user lands on that URL, they can click \"Show all annotations\" to see the rest of the annotations from that bucket\r\n\r\nIf the user happens to be looking at a specific group, then this will result in the overlay automatically switching to the appropriate group.\r\n\r\nThe implementation here changes the label from \"Address\" to \"URLs\" as in the mock and tweaks the presentation of the section labels in the bucket sidebar, but does not currently include the icons.\r\n\r\nFixes #4058 \r\n\r\n![bucket-url-links](https://cloud.githubusercontent.com/assets/2458/20396327/ba07819a-acdd-11e6-987b-34fb1c648ded.png)\r\n"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/261991586","html_url":"https://github.com/hypothesis/h/pull/4090#issuecomment-261991586","issue_url":"https://api.github.com/repos/hypothesis/h/issues/4090","id":261991586,"user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T16:37:11Z","updated_at":"2016-11-21T16:37:11Z","body":"> > What was the reason for opening the annotation in context in a new tab? I think links that open new \r\n> > tabs are generally considered a bit of an annoyance, most of the time.\r\n> My thinking was to avoid losing the user's place in the search result list, similar to how links in your \r\n> Facebook or Twitter feeds are opened externally.\r\n\r\nAh ok. I guess it depends whether activity pages is more like twitter, or more like google! Fair enough, I'm happy to go with this."}}
{"actor":{"display_login":"seanh"}}