{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker-py/pulls/comments/89329499","pull_request_review_id":9875049,"id":89329499,"diff_hunk":"@@ -1,5 +1,6 @@\n import datetime\n import docker\n+from docker.utils import kwargs_from_env","path":"tests/unit/client_test.py","position":3,"original_position":3,"commit_id":"d239161360fe763defc9545aa2e9fe86dd07bfa5","original_commit_id":"d239161360fe763defc9545aa2e9fe86dd07bfa5","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"body":"I know I could have just used `docker.from_env()` in the test, but I wanted something as close as possible to what users of the old docker-py would actually have written. Let me know if you think this is silly.","created_at":"2016-11-23T14:46:21Z","updated_at":"2016-11-23T14:46:21Z","html_url":"https://github.com/docker/docker-py/pull/1303#discussion_r89329499","pull_request_url":"https://api.github.com/repos/docker/docker-py/pulls/1303","_links":{"self":{"href":"https://api.github.com/repos/docker/docker-py/pulls/comments/89329499"},"html":{"href":"https://github.com/docker/docker-py/pull/1303#discussion_r89329499"},"pull_request":{"href":"https://api.github.com/repos/docker/docker-py/pulls/1303"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker-py/pulls/1303","id":95016077,"html_url":"https://github.com/docker/docker-py/pull/1303","diff_url":"https://github.com/docker/docker-py/pull/1303.diff","patch_url":"https://github.com/docker/docker-py/pull/1303.patch","issue_url":"https://api.github.com/repos/docker/docker-py/issues/1303","number":1303,"state":"open","locked":false,"title":"Show a helpful warning when people try to call `client.containers()`","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"body":"People upgrading to docker-py 2.0 without being aware of the new client API will likely try to call the old `containers()` method. This adds a helpful warning telling them to use APIClient to get the old API.","created_at":"2016-11-23T14:44:23Z","updated_at":"2016-11-23T14:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ffab805c8d900df538a87842ad60602434b1145","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker-py/pulls/1303/commits","review_comments_url":"https://api.github.com/repos/docker/docker-py/pulls/1303/comments","review_comment_url":"https://api.github.com/repos/docker/docker-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker-py/issues/1303/comments","statuses_url":"https://api.github.com/repos/docker/docker-py/statuses/d239161360fe763defc9545aa2e9fe86dd07bfa5","head":{"label":"aanand:helpful-containers-warning","ref":"helpful-containers-warning","sha":"d239161360fe763defc9545aa2e9fe86dd07bfa5","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"repo":{"id":12514557,"name":"docker-py","full_name":"aanand/docker-py","owner":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aanand/docker-py","description":null,"fork":true,"url":"https://api.github.com/repos/aanand/docker-py","forks_url":"https://api.github.com/repos/aanand/docker-py/forks","keys_url":"https://api.github.com/repos/aanand/docker-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aanand/docker-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aanand/docker-py/teams","hooks_url":"https://api.github.com/repos/aanand/docker-py/hooks","issue_events_url":"https://api.github.com/repos/aanand/docker-py/issues/events{/number}","events_url":"https://api.github.com/repos/aanand/docker-py/events","assignees_url":"https://api.github.com/repos/aanand/docker-py/assignees{/user}","branches_url":"https://api.github.com/repos/aanand/docker-py/branches{/branch}","tags_url":"https://api.github.com/repos/aanand/docker-py/tags","blobs_url":"https://api.github.com/repos/aanand/docker-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aanand/docker-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aanand/docker-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/aanand/docker-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aanand/docker-py/statuses/{sha}","languages_url":"https://api.github.com/repos/aanand/docker-py/languages","stargazers_url":"https://api.github.com/repos/aanand/docker-py/stargazers","contributors_url":"https://api.github.com/repos/aanand/docker-py/contributors","subscribers_url":"https://api.github.com/repos/aanand/docker-py/subscribers","subscription_url":"https://api.github.com/repos/aanand/docker-py/subscription","commits_url":"https://api.github.com/repos/aanand/docker-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/aanand/docker-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/aanand/docker-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/aanand/docker-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/aanand/docker-py/contents/{+path}","compare_url":"https://api.github.com/repos/aanand/docker-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aanand/docker-py/merges","archive_url":"https://api.github.com/repos/aanand/docker-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aanand/docker-py/downloads","issues_url":"https://api.github.com/repos/aanand/docker-py/issues{/number}","pulls_url":"https://api.github.com/repos/aanand/docker-py/pulls{/number}","milestones_url":"https://api.github.com/repos/aanand/docker-py/milestones{/number}","notifications_url":"https://api.github.com/repos/aanand/docker-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aanand/docker-py/labels{/name}","releases_url":"https://api.github.com/repos/aanand/docker-py/releases{/id}","deployments_url":"https://api.github.com/repos/aanand/docker-py/deployments","created_at":"2013-09-01T02:24:12Z","updated_at":"2014-07-24T20:52:08Z","pushed_at":"2016-11-23T14:45:38Z","git_url":"git://github.com/aanand/docker-py.git","ssh_url":"git@github.com:aanand/docker-py.git","clone_url":"https://github.com/aanand/docker-py.git","svn_url":"https://github.com/aanand/docker-py","homepage":null,"size":2779,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"8478491cf8cef62d210e477befc02efc6f241ba3","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":10247874,"name":"docker-py","full_name":"docker/docker-py","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker-py","description":"An API client for docker written in Python","fork":false,"url":"https://api.github.com/repos/docker/docker-py","forks_url":"https://api.github.com/repos/docker/docker-py/forks","keys_url":"https://api.github.com/repos/docker/docker-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker-py/teams","hooks_url":"https://api.github.com/repos/docker/docker-py/hooks","issue_events_url":"https://api.github.com/repos/docker/docker-py/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker-py/events","assignees_url":"https://api.github.com/repos/docker/docker-py/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker-py/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker-py/tags","blobs_url":"https://api.github.com/repos/docker/docker-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker-py/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker-py/languages","stargazers_url":"https://api.github.com/repos/docker/docker-py/stargazers","contributors_url":"https://api.github.com/repos/docker/docker-py/contributors","subscribers_url":"https://api.github.com/repos/docker/docker-py/subscribers","subscription_url":"https://api.github.com/repos/docker/docker-py/subscription","commits_url":"https://api.github.com/repos/docker/docker-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker-py/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker-py/merges","archive_url":"https://api.github.com/repos/docker/docker-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker-py/downloads","issues_url":"https://api.github.com/repos/docker/docker-py/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker-py/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker-py/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker-py/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker-py/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker-py/deployments","created_at":"2013-05-23T16:15:07Z","updated_at":"2016-11-23T13:44:32Z","pushed_at":"2016-11-23T14:45:38Z","git_url":"git://github.com/docker/docker-py.git","ssh_url":"git@github.com:docker/docker-py.git","clone_url":"https://github.com/docker/docker-py.git","svn_url":"https://github.com/docker/docker-py","homepage":"","size":4451,"stargazers_count":1808,"watchers_count":1808,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":705,"mirror_url":null,"open_issues_count":129,"forks":705,"open_issues":129,"watchers":1808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker-py/pulls/1303"},"html":{"href":"https://github.com/docker/docker-py/pull/1303"},"issue":{"href":"https://api.github.com/repos/docker/docker-py/issues/1303"},"comments":{"href":"https://api.github.com/repos/docker/docker-py/issues/1303/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker-py/pulls/1303/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker-py/pulls/1303/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker-py/statuses/d239161360fe763defc9545aa2e9fe86dd07bfa5"}}}}
{"actor":{"display_login":"aanand"}}