{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/riff-raff/pulls/comments/81951228","pull_request_review_id":2892161,"id":81951228,"diff_hunk":"@@ -11,44 +11,48 @@ object AmiCloudFormationParameter extends DeploymentType {\n       |on the provided CloudFormation stack.\n     \"\"\".stripMargin\n \n-  val cloudFormationStackName = Param[String](\"cloudFormationStackName\",\n-    documentation = \"The name of the CloudFormation stack to update\"\n-  ).defaultFromPackage(_.name)\n-  val prependStackToCloudFormationStackName = Param[Boolean](\"prependStackToCloudFormationStackName\",\n-    documentation = \"Whether to prepend '`stack`-' to the `cloudFormationStackName`, e.g. MyApp => service-preview-MyApp\"\n-  ).default(true)\n-  val appendStageToCloudFormationStackName = Param[Boolean](\"appendStageToCloudFormationStackName\",\n-    documentation = \"Whether to add '-`stage`' to the `cloudFormationStackName`, e.g. MyApp => MyApp-PROD\"\n-  ).default(true)\n-  val amiTags = Param[Map[String,String]](\"amiTags\",\n-    documentation = \"Specify the set of tags to use to find the latest AMI\"\n-  )\n-  val amiParameter = Param[String](\"amiParameter\",\n-    documentation = \"The CloudFormation parameter name for the AMI\"\n-  ).default(\"AMI\")\n+  val cloudFormationStackName =\n+    Param[String](\"cloudFormationStackName\", documentation = \"The name of the CloudFormation stack to update\")\n+      .defaultFromPackage(_.name)\n+  val prependStackToCloudFormationStackName = Param[Boolean](","path":"magenta-lib/src/main/scala/magenta/deployment_type/AmiCloudFormationParameter.scala","position":22,"original_position":22,"commit_id":"7e7ada09d910eec22c0f427dfebdea7d97594470","original_commit_id":"7e7ada09d910eec22c0f427dfebdea7d97594470","user":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"body":"Fair point.","created_at":"2016-10-05T11:23:22Z","updated_at":"2016-10-05T11:23:22Z","html_url":"https://github.com/guardian/riff-raff/pull/365#discussion_r81951228","pull_request_url":"https://api.github.com/repos/guardian/riff-raff/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/comments/81951228"},"html":{"href":"https://github.com/guardian/riff-raff/pull/365#discussion_r81951228"},"pull_request":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/riff-raff/pulls/365","id":88057826,"html_url":"https://github.com/guardian/riff-raff/pull/365","diff_url":"https://github.com/guardian/riff-raff/pull/365.diff","patch_url":"https://github.com/guardian/riff-raff/pull/365.patch","issue_url":"https://api.github.com/repos/guardian/riff-raff/issues/365","number":365,"state":"open","locked":false,"title":"Install scalafmt and reformat all source","user":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"body":"Tackle #335.\r\n\r\nWhilst I've installed scalafmt as a plugin it is not wired up to run automatically as my reading of #335 indicates that @philwills would be disappointed if this were the case.\r\n\r\nI'm happy to remove the plugin entirely if that is deemed better.","created_at":"2016-10-05T11:09:41Z","updated_at":"2016-10-05T11:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c7e25e71f2ccf2a14180e9f9c6f50ea4f4b527f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/riff-raff/pulls/365/commits","review_comments_url":"https://api.github.com/repos/guardian/riff-raff/pulls/365/comments","review_comment_url":"https://api.github.com/repos/guardian/riff-raff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/riff-raff/issues/365/comments","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/7e7ada09d910eec22c0f427dfebdea7d97594470","head":{"label":"guardian:sh-code-formatting","ref":"sh-code-formatting","sha":"7e7ada09d910eec22c0f427dfebdea7d97594470","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"riff-raff","full_name":"guardian/riff-raff","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riff-raff","description":"Guardian deployment libraries and RiffRaff frontend","fork":false,"url":"https://api.github.com/repos/guardian/riff-raff","forks_url":"https://api.github.com/repos/guardian/riff-raff/forks","keys_url":"https://api.github.com/repos/guardian/riff-raff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riff-raff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riff-raff/teams","hooks_url":"https://api.github.com/repos/guardian/riff-raff/hooks","issue_events_url":"https://api.github.com/repos/guardian/riff-raff/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riff-raff/events","assignees_url":"https://api.github.com/repos/guardian/riff-raff/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riff-raff/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riff-raff/tags","blobs_url":"https://api.github.com/repos/guardian/riff-raff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riff-raff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riff-raff/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riff-raff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riff-raff/languages","stargazers_url":"https://api.github.com/repos/guardian/riff-raff/stargazers","contributors_url":"https://api.github.com/repos/guardian/riff-raff/contributors","subscribers_url":"https://api.github.com/repos/guardian/riff-raff/subscribers","subscription_url":"https://api.github.com/repos/guardian/riff-raff/subscription","commits_url":"https://api.github.com/repos/guardian/riff-raff/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riff-raff/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riff-raff/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riff-raff/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riff-raff/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riff-raff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riff-raff/merges","archive_url":"https://api.github.com/repos/guardian/riff-raff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riff-raff/downloads","issues_url":"https://api.github.com/repos/guardian/riff-raff/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riff-raff/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riff-raff/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riff-raff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riff-raff/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riff-raff/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/riff-raff/deployments","created_at":"2011-08-19T09:05:26Z","updated_at":"2016-10-03T18:44:41Z","pushed_at":"2016-10-05T11:09:41Z","git_url":"git://github.com/guardian/riff-raff.git","ssh_url":"git@github.com:guardian/riff-raff.git","clone_url":"https://github.com/guardian/riff-raff.git","svn_url":"https://github.com/guardian/riff-raff","homepage":"","size":9078,"stargazers_count":150,"watchers_count":150,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":150,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"191b6dd6d0338f5c1ec40bb08d1f5d8105324af7","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"riff-raff","full_name":"guardian/riff-raff","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riff-raff","description":"Guardian deployment libraries and RiffRaff frontend","fork":false,"url":"https://api.github.com/repos/guardian/riff-raff","forks_url":"https://api.github.com/repos/guardian/riff-raff/forks","keys_url":"https://api.github.com/repos/guardian/riff-raff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riff-raff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riff-raff/teams","hooks_url":"https://api.github.com/repos/guardian/riff-raff/hooks","issue_events_url":"https://api.github.com/repos/guardian/riff-raff/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riff-raff/events","assignees_url":"https://api.github.com/repos/guardian/riff-raff/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riff-raff/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riff-raff/tags","blobs_url":"https://api.github.com/repos/guardian/riff-raff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riff-raff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riff-raff/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riff-raff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riff-raff/languages","stargazers_url":"https://api.github.com/repos/guardian/riff-raff/stargazers","contributors_url":"https://api.github.com/repos/guardian/riff-raff/contributors","subscribers_url":"https://api.github.com/repos/guardian/riff-raff/subscribers","subscription_url":"https://api.github.com/repos/guardian/riff-raff/subscription","commits_url":"https://api.github.com/repos/guardian/riff-raff/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riff-raff/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riff-raff/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riff-raff/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riff-raff/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riff-raff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riff-raff/merges","archive_url":"https://api.github.com/repos/guardian/riff-raff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riff-raff/downloads","issues_url":"https://api.github.com/repos/guardian/riff-raff/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riff-raff/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riff-raff/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riff-raff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riff-raff/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riff-raff/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/riff-raff/deployments","created_at":"2011-08-19T09:05:26Z","updated_at":"2016-10-03T18:44:41Z","pushed_at":"2016-10-05T11:09:41Z","git_url":"git://github.com/guardian/riff-raff.git","ssh_url":"git@github.com:guardian/riff-raff.git","clone_url":"https://github.com/guardian/riff-raff.git","svn_url":"https://github.com/guardian/riff-raff","homepage":"","size":9078,"stargazers_count":150,"watchers_count":150,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/365"},"html":{"href":"https://github.com/guardian/riff-raff/pull/365"},"issue":{"href":"https://api.github.com/repos/guardian/riff-raff/issues/365"},"comments":{"href":"https://api.github.com/repos/guardian/riff-raff/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/riff-raff/statuses/7e7ada09d910eec22c0f427dfebdea7d97594470"}}}}
{"actor":{"display_login":"sihil"}}