{"action":"created","comment":{"url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/comments/78723721","id":78723721,"diff_hunk":"@@ -0,0 +1,66 @@\n+GIT_COMMIT:=$(shell git rev-parse --short HEAD)\n+DOCKER_IMAGE:=saltside/ad-moderation-service\n+\n+TEST_ENVIRONMENT:=\\\n+\t\t-e LOG_LEVEL=debug \\\n+\t\t-e APP_ENV=sandbox \\\n+\t\t-e MARKET=tonaton\n+\n+DOCKER_VOLUME:=-v tmp:/app\n+DOCKER_RUN:=docker run --rm -it\n+NAME:=ad-moderation-service\n+\n+DEPS:=tmp/deps\n+ENVIRONMENT:=tmp/environment\n+APP:=tmp/app\n+PRODUCTION_ENV:=$(shell jq -re '.environment.production | to_entries | map(\"-e \\\"\\(.key)=\\(.value)\\\"\") | join(\" \")' apollo.json)\n+\n+\n+THRIFT_DEPS:=src/kviberg\n+\n+# Get source dependency source files\n+.PHONY: vendor/thrift-files\n+vendor/thrift-files:\n+\tgit submodule update --init\n+\n+$(DEPS): vendor/thrift-files\n+\t@mkdir -p libs\n+\t@cp -rf vendor/thrift-files/generated-code/gen-py/kviberg \\\n+\t\t$(THRIFT_DEPS)\n+\t@sh python_keyword_changes.sh \n+\tmkdir -p $(@D)\n+\ttouch $@\n+\n+.PHONY: ready\n+ready: clean\n+\n+.PHONY: clean\n+clean:\n+\t$(info --- Tearing down environment)\n+\t@rm -rf $(APP) $(ENVIRONMENT) $(DEPS) $(THRIFT_DEPS)\n+\t@rm -rf ./log/*\n+\n+$(APP): Dockerfile $(DEPS)\n+\t$(info --- Building docker image)\n+\tdocker build -t $(DOCKER_IMAGE) .\n+\t@mkdir -p $(@D)\n+\t@touch $@\n+\n+.PHONY: build\n+build: $(APP)\n+\n+.PHONY: push\n+push: build\n+\t$(info --- Tag and push docker image)\n+\tdocker tag $(DOCKER_IMAGE) $(DOCKER_IMAGE):$(GIT_COMMIT)\n+\tdocker push $(DOCKER_IMAGE):$(GIT_COMMIT)\n+\n+.PHONY: unit-test\n+unit-test:\n+\t-@docker stop ad-moderation-service \n+\t-@docker rm ad-moderation-service \n+\tdocker run -it --name ad-moderation-service $(DOCKER_IMAGE):$(GIT_COMMIT)","path":"Makefile","position":62,"original_position":62,"commit_id":"8ac5c2cbc61054561be546af96ef836a59fd6f51","original_commit_id":"8ac5c2cbc61054561be546af96ef836a59fd6f51","user":{"login":"ahawkins","id":48928,"avatar_url":"https://avatars.githubusercontent.com/u/48928?v=3","gravatar_id":"","url":"https://api.github.com/users/ahawkins","html_url":"https://github.com/ahawkins","followers_url":"https://api.github.com/users/ahawkins/followers","following_url":"https://api.github.com/users/ahawkins/following{/other_user}","gists_url":"https://api.github.com/users/ahawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahawkins/subscriptions","organizations_url":"https://api.github.com/users/ahawkins/orgs","repos_url":"https://api.github.com/users/ahawkins/repos","events_url":"https://api.github.com/users/ahawkins/events{/privacy}","received_events_url":"https://api.github.com/users/ahawkins/received_events","type":"User","site_admin":false},"body":"You can remove the `--name` and simply use `--rm`. This will autoremove containers after the command exits (successfully or not). Then you can remove the 2 lines above this.","created_at":"2016-09-14T10:31:44Z","updated_at":"2016-09-14T10:31:44Z","html_url":"https://github.com/Saltside/ad-moderation-automation/pull/1#discussion_r78723721","pull_request_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/comments/78723721"},"html":{"href":"https://github.com/Saltside/ad-moderation-automation/pull/1#discussion_r78723721"},"pull_request":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1","id":83578519,"html_url":"https://github.com/Saltside/ad-moderation-automation/pull/1","diff_url":"https://github.com/Saltside/ad-moderation-automation/pull/1.diff","patch_url":"https://github.com/Saltside/ad-moderation-automation/pull/1.patch","issue_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/1","number":1,"state":"open","locked":false,"title":"Feature/duplicate identification","user":{"login":"skrisshnaswamy","id":10529428,"avatar_url":"https://avatars.githubusercontent.com/u/10529428?v=3","gravatar_id":"","url":"https://api.github.com/users/skrisshnaswamy","html_url":"https://github.com/skrisshnaswamy","followers_url":"https://api.github.com/users/skrisshnaswamy/followers","following_url":"https://api.github.com/users/skrisshnaswamy/following{/other_user}","gists_url":"https://api.github.com/users/skrisshnaswamy/gists{/gist_id}","starred_url":"https://api.github.com/users/skrisshnaswamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrisshnaswamy/subscriptions","organizations_url":"https://api.github.com/users/skrisshnaswamy/orgs","repos_url":"https://api.github.com/users/skrisshnaswamy/repos","events_url":"https://api.github.com/users/skrisshnaswamy/events{/privacy}","received_events_url":"https://api.github.com/users/skrisshnaswamy/received_events","type":"User","site_admin":false},"body":"**Overview of changes**\r\n- [ ] Implemented Thrift server & handler for ad-moderation.thrift\r\n- [ ] Created Makefile, Dockerfile and buildkite scripts\r\n- [ ] Implemented logic for `Duplicate`, `Repost` ad detection","created_at":"2016-09-01T06:45:29Z","updated_at":"2016-09-14T10:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12c4c22b8b14ce7122724f7d8d808e2bed0bdfd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/1/comments","statuses_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/statuses/8ac5c2cbc61054561be546af96ef836a59fd6f51","head":{"label":"Saltside:feature/duplicate-identification","ref":"feature/duplicate-identification","sha":"8ac5c2cbc61054561be546af96ef836a59fd6f51","user":{"login":"Saltside","id":951567,"avatar_url":"https://avatars.githubusercontent.com/u/951567?v=3","gravatar_id":"","url":"https://api.github.com/users/Saltside","html_url":"https://github.com/Saltside","followers_url":"https://api.github.com/users/Saltside/followers","following_url":"https://api.github.com/users/Saltside/following{/other_user}","gists_url":"https://api.github.com/users/Saltside/gists{/gist_id}","starred_url":"https://api.github.com/users/Saltside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saltside/subscriptions","organizations_url":"https://api.github.com/users/Saltside/orgs","repos_url":"https://api.github.com/users/Saltside/repos","events_url":"https://api.github.com/users/Saltside/events{/privacy}","received_events_url":"https://api.github.com/users/Saltside/received_events","type":"Organization","site_admin":false},"repo":{"id":65978634,"name":"ad-moderation-automation","full_name":"Saltside/ad-moderation-automation","owner":{"login":"Saltside","id":951567,"avatar_url":"https://avatars.githubusercontent.com/u/951567?v=3","gravatar_id":"","url":"https://api.github.com/users/Saltside","html_url":"https://github.com/Saltside","followers_url":"https://api.github.com/users/Saltside/followers","following_url":"https://api.github.com/users/Saltside/following{/other_user}","gists_url":"https://api.github.com/users/Saltside/gists{/gist_id}","starred_url":"https://api.github.com/users/Saltside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saltside/subscriptions","organizations_url":"https://api.github.com/users/Saltside/orgs","repos_url":"https://api.github.com/users/Saltside/repos","events_url":"https://api.github.com/users/Saltside/events{/privacy}","received_events_url":"https://api.github.com/users/Saltside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Saltside/ad-moderation-automation","description":null,"fork":false,"url":"https://api.github.com/repos/Saltside/ad-moderation-automation","forks_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/forks","keys_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/teams","hooks_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/hooks","issue_events_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/events{/number}","events_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/events","assignees_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/assignees{/user}","branches_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/branches{/branch}","tags_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/tags","blobs_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/languages","stargazers_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/stargazers","contributors_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/contributors","subscribers_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/subscribers","subscription_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/subscription","commits_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/contents/{+path}","compare_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/merges","archive_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/downloads","issues_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues{/number}","pulls_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/labels{/name}","releases_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/releases{/id}","deployments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/deployments","created_at":"2016-08-18T08:15:45Z","updated_at":"2016-08-18T08:15:45Z","pushed_at":"2016-09-14T06:21:02Z","git_url":"git://github.com/Saltside/ad-moderation-automation.git","ssh_url":"git@github.com:Saltside/ad-moderation-automation.git","clone_url":"https://github.com/Saltside/ad-moderation-automation.git","svn_url":"https://github.com/Saltside/ad-moderation-automation","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Saltside:master","ref":"master","sha":"c8c6195a0cbf0c52f6f4fd545c968948703ab241","user":{"login":"Saltside","id":951567,"avatar_url":"https://avatars.githubusercontent.com/u/951567?v=3","gravatar_id":"","url":"https://api.github.com/users/Saltside","html_url":"https://github.com/Saltside","followers_url":"https://api.github.com/users/Saltside/followers","following_url":"https://api.github.com/users/Saltside/following{/other_user}","gists_url":"https://api.github.com/users/Saltside/gists{/gist_id}","starred_url":"https://api.github.com/users/Saltside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saltside/subscriptions","organizations_url":"https://api.github.com/users/Saltside/orgs","repos_url":"https://api.github.com/users/Saltside/repos","events_url":"https://api.github.com/users/Saltside/events{/privacy}","received_events_url":"https://api.github.com/users/Saltside/received_events","type":"Organization","site_admin":false},"repo":{"id":65978634,"name":"ad-moderation-automation","full_name":"Saltside/ad-moderation-automation","owner":{"login":"Saltside","id":951567,"avatar_url":"https://avatars.githubusercontent.com/u/951567?v=3","gravatar_id":"","url":"https://api.github.com/users/Saltside","html_url":"https://github.com/Saltside","followers_url":"https://api.github.com/users/Saltside/followers","following_url":"https://api.github.com/users/Saltside/following{/other_user}","gists_url":"https://api.github.com/users/Saltside/gists{/gist_id}","starred_url":"https://api.github.com/users/Saltside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saltside/subscriptions","organizations_url":"https://api.github.com/users/Saltside/orgs","repos_url":"https://api.github.com/users/Saltside/repos","events_url":"https://api.github.com/users/Saltside/events{/privacy}","received_events_url":"https://api.github.com/users/Saltside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Saltside/ad-moderation-automation","description":null,"fork":false,"url":"https://api.github.com/repos/Saltside/ad-moderation-automation","forks_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/forks","keys_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/teams","hooks_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/hooks","issue_events_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/events{/number}","events_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/events","assignees_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/assignees{/user}","branches_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/branches{/branch}","tags_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/tags","blobs_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/languages","stargazers_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/stargazers","contributors_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/contributors","subscribers_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/subscribers","subscription_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/subscription","commits_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/contents/{+path}","compare_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/merges","archive_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/downloads","issues_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues{/number}","pulls_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/labels{/name}","releases_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/releases{/id}","deployments_url":"https://api.github.com/repos/Saltside/ad-moderation-automation/deployments","created_at":"2016-08-18T08:15:45Z","updated_at":"2016-08-18T08:15:45Z","pushed_at":"2016-09-14T06:21:02Z","git_url":"git://github.com/Saltside/ad-moderation-automation.git","ssh_url":"git@github.com:Saltside/ad-moderation-automation.git","clone_url":"https://github.com/Saltside/ad-moderation-automation.git","svn_url":"https://github.com/Saltside/ad-moderation-automation","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1"},"html":{"href":"https://github.com/Saltside/ad-moderation-automation/pull/1"},"issue":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/1"},"comments":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Saltside/ad-moderation-automation/statuses/8ac5c2cbc61054561be546af96ef836a59fd6f51"}}}}
{"actor":{"display_login":"ahawkins"}}