{"action":"created","comment":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments/72295508","id":72295508,"diff_hunk":"@@ -411,6 +419,12 @@ export default class VictoryGroup extends React.Component {\n     });\n   }\n \n+  getDomainPadding(props, childComponents, calculatedProps) {\n+    const { horizontal } = calculatedProps;\n+    return horizontal ? {y: (props.offset * childComponents.length) / 2}","path":"src/components/victory-group/victory-group.js","position":43,"original_position":43,"commit_id":"38a6f083f3569cf8cd81351d71146c905ec70b12","original_commit_id":"38a6f083f3569cf8cd81351d71146c905ec70b12","user":{"login":"boygirl","id":3719995,"avatar_url":"https://avatars.githubusercontent.com/u/3719995?v=3","gravatar_id":"","url":"https://api.github.com/users/boygirl","html_url":"https://github.com/boygirl","followers_url":"https://api.github.com/users/boygirl/followers","following_url":"https://api.github.com/users/boygirl/following{/other_user}","gists_url":"https://api.github.com/users/boygirl/gists{/gist_id}","starred_url":"https://api.github.com/users/boygirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boygirl/subscriptions","organizations_url":"https://api.github.com/users/boygirl/orgs","repos_url":"https://api.github.com/users/boygirl/repos","events_url":"https://api.github.com/users/boygirl/events{/privacy}","received_events_url":"https://api.github.com/users/boygirl/received_events","type":"User","site_admin":false},"body":"or just \r\n```\r\ndefaultDomainPadding = horizontal ? \r\n  {y: (props.offset * childComponents.length) / 2} : \r\n  {x: (props.offset * childComponents.length) / 2};\r\n```\r\nand kill this method","created_at":"2016-07-26T17:19:03Z","updated_at":"2016-07-26T17:19:03Z","html_url":"https://github.com/FormidableLabs/victory-chart/pull/313#discussion_r72295508","pull_request_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments/72295508"},"html":{"href":"https://github.com/FormidableLabs/victory-chart/pull/313#discussion_r72295508"},"pull_request":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313","id":78542861,"html_url":"https://github.com/FormidableLabs/victory-chart/pull/313","diff_url":"https://github.com/FormidableLabs/victory-chart/pull/313.diff","patch_url":"https://github.com/FormidableLabs/victory-chart/pull/313.patch","issue_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/313","number":313,"state":"open","locked":false,"title":"Domain padding for grouped charts","user":{"login":"ebrillhart","id":13110279,"avatar_url":"https://avatars.githubusercontent.com/u/13110279?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrillhart","html_url":"https://github.com/ebrillhart","followers_url":"https://api.github.com/users/ebrillhart/followers","following_url":"https://api.github.com/users/ebrillhart/following{/other_user}","gists_url":"https://api.github.com/users/ebrillhart/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrillhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrillhart/subscriptions","organizations_url":"https://api.github.com/users/ebrillhart/orgs","repos_url":"https://api.github.com/users/ebrillhart/repos","events_url":"https://api.github.com/users/ebrillhart/events{/privacy}","received_events_url":"https://api.github.com/users/ebrillhart/received_events","type":"User","site_admin":false},"body":"@boygirl this should be working great, but the furthest left group doesn't get shifted over... I think this is by design so that axes don't cross, but it definitely looks weird for bars.\r\n\r\nthis addresses https://github.com/FormidableLabs/victory-chart/issues/301#issuecomment-233692371","created_at":"2016-07-22T21:28:15Z","updated_at":"2016-07-26T17:19:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ddfd903d6f2d1125868b594e1026addae929c55","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313/commits","review_comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313/comments","review_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/313/comments","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/38a6f083f3569cf8cd81351d71146c905ec70b12","head":{"label":"FormidableLabs:domainpadding-grouped-bars","ref":"domainpadding-grouped-bars","sha":"38a6f083f3569cf8cd81351d71146c905ec70b12","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40037231,"name":"victory-chart","full_name":"FormidableLabs/victory-chart","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/victory-chart","description":"Chart Component for Victory","fork":false,"url":"https://api.github.com/repos/FormidableLabs/victory-chart","forks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/forks","keys_url":"https://api.github.com/repos/FormidableLabs/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/victory-chart/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/events","assignees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/victory-chart/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/victory-chart/merges","archive_url":"https://api.github.com/repos/FormidableLabs/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/victory-chart/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/deployments","created_at":"2015-08-01T06:05:36Z","updated_at":"2016-07-22T06:04:30Z","pushed_at":"2016-07-26T17:15:36Z","git_url":"git://github.com/FormidableLabs/victory-chart.git","ssh_url":"git@github.com:FormidableLabs/victory-chart.git","clone_url":"https://github.com/FormidableLabs/victory-chart.git","svn_url":"https://github.com/FormidableLabs/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14277,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":31,"forks":28,"open_issues":31,"watchers":59,"default_branch":"master"}},"base":{"label":"FormidableLabs:master","ref":"master","sha":"b7019ceae3d713281af9eae11d4428a0d0e75f56","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40037231,"name":"victory-chart","full_name":"FormidableLabs/victory-chart","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/victory-chart","description":"Chart Component for Victory","fork":false,"url":"https://api.github.com/repos/FormidableLabs/victory-chart","forks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/forks","keys_url":"https://api.github.com/repos/FormidableLabs/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/victory-chart/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/events","assignees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/victory-chart/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/victory-chart/merges","archive_url":"https://api.github.com/repos/FormidableLabs/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/victory-chart/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/deployments","created_at":"2015-08-01T06:05:36Z","updated_at":"2016-07-22T06:04:30Z","pushed_at":"2016-07-26T17:15:36Z","git_url":"git://github.com/FormidableLabs/victory-chart.git","ssh_url":"git@github.com:FormidableLabs/victory-chart.git","clone_url":"https://github.com/FormidableLabs/victory-chart.git","svn_url":"https://github.com/FormidableLabs/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14277,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":31,"forks":28,"open_issues":31,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313"},"html":{"href":"https://github.com/FormidableLabs/victory-chart/pull/313"},"issue":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/313"},"comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/38a6f083f3569cf8cd81351d71146c905ec70b12"}}}}
{"actor":{"display_login":"boygirl"}}