{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/1154","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/1154/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/1154/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/1154/events","html_url":"https://github.com/zulip/zulip/pull/1154","id":163285530,"number":1154,"title":"Add support for subdomains.","user":{"login":"hackerkid","id":7190633,"avatar_url":"https://avatars.githubusercontent.com/u/7190633?v=3","gravatar_id":"","url":"https://api.github.com/users/hackerkid","html_url":"https://github.com/hackerkid","followers_url":"https://api.github.com/users/hackerkid/followers","following_url":"https://api.github.com/users/hackerkid/following{/other_user}","gists_url":"https://api.github.com/users/hackerkid/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerkid/subscriptions","organizations_url":"https://api.github.com/users/hackerkid/orgs","repos_url":"https://api.github.com/users/hackerkid/repos","events_url":"https://api.github.com/users/hackerkid/events{/privacy}","received_events_url":"https://api.github.com/users/hackerkid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-06-30T23:04:07Z","updated_at":"2016-07-08T23:48:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/1154","html_url":"https://github.com/zulip/zulip/pull/1154","diff_url":"https://github.com/zulip/zulip/pull/1154.diff","patch_url":"https://github.com/zulip/zulip/pull/1154.patch"},"body":"Under development :hourglass_flowing_sand: Please ignore :see_no_evil: \r\n\r\n- [X] Modify the realm registration form\r\n- [X] Validate login so that the user is logged in correct subdomain\r\n- [x] Change the confirmation link\r\n- [x] Show error if sub domain doesn't exists \r\n- [ ] Add support for more than 1 open realms\r\n- [ ] Tests"},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/231498391","html_url":"https://github.com/zulip/zulip/pull/1154#issuecomment-231498391","issue_url":"https://api.github.com/repos/zulip/zulip/issues/1154","id":231498391,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T23:48:22Z","updated_at":"2016-07-08T23:48:22Z","body":"Well, the tests need to run locally (either in Vagrant or via manual setup), not just in Travis CI.  There's a few different testing methods we should be thinking about here:\r\n* Manual testing.  For this, the `by-urls` concept is probably easiest, since we don't want to be in the business of modifying /etc/hosts on users' host machines.\r\n* Backend tests.  For this, we can mock the DNS calls to make the `subdomains` version work, either in Python or via an LD_PRELOAD hack like http://jhrozek.livejournal.com/4301.html.  I think those approaches may suffice for testing the subdomains codepath.\r\n* Casper tests.  For this, the `by-urls` set of pages will be the same (but with different URLs), so it might be good enough to just do that (or we can use the LD_PRELOAD approach or Travis' support for custom subdomains to do it with subdomains).\r\n\r\nDoes that make sense?\r\n"}}
{"actor":{"display_login":"timabbott"}}