{"action":"created","issue":{"url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/3","repository_url":"https://api.github.com/repos/graphiq/TagSelect.js","labels_url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/3/comments","events_url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/3/events","html_url":"https://github.com/graphiq/TagSelect.js/pull/3","id":154939090,"number":3,"title":"Create standalone builds.","user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars.githubusercontent.com/u/1848368?v=3","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-15T23:40:38Z","updated_at":"2016-05-21T23:48:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphiq/TagSelect.js/pulls/3","html_url":"https://github.com/graphiq/TagSelect.js/pull/3","diff_url":"https://github.com/graphiq/TagSelect.js/pull/3.diff","patch_url":"https://github.com/graphiq/TagSelect.js/pull/3.patch"},"body":"Fixes #2.\r\n\r\nThis adds two builds – one (\"lite\") depends on lodash and weighs 8kb minified. The second includes all its dependencies, and weighs 11kb. I assume you'll want the first, but the second seems more user-friendly for NPM and Bower. Or maybe 3kb is a pointless optimization for an internal package, and we should get rid of the \"lite\" build?\r\n\r\nWould have liked to use the `lodash.*` modules, but individually packaging the parts we use add +60kb. So I've cut corners and used dedicated NPM packages like `object-assign` instead, for the standalone build. +3kb vs +60kb for the dependencies seems like a win.\r\n\r\nFinally, I removed Grunt, since it's overkill and you use Gulp anyway. There are a few basic tasks defined in package.json – `npm run dev`, `npm run dist`, `npm version [major | minor | patch]`, etc.\r\n\r\nSending as a PR to sanity-check this – are you OK with including `dist/tagselect.lite.js` from your submodule? (Assuming you don't just stick with v0.6.* indefinitely.)\r\n\r\nIf we want to merge this I'll add docs and bump to v1.0.0."},"comment":{"url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/comments/220806465","html_url":"https://github.com/graphiq/TagSelect.js/pull/3#issuecomment-220806465","issue_url":"https://api.github.com/repos/graphiq/TagSelect.js/issues/3","id":220806465,"user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars.githubusercontent.com/u/1848368?v=3","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"created_at":"2016-05-21T23:48:10Z","updated_at":"2016-05-21T23:48:10Z","body":"Docs are updated! I can't bump the version in the PR (without manually doing all the git tagging afterward) but either of us can run `npm version major` to bump it once this is in.\r\n\r\nAfter this PR we won't need to rebuild `dist/` in commits either – that happens automatically on version release, basically like a deploy."}}
{"actor":{"display_login":"donmccurdy"}}