{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95","id":83618246,"html_url":"https://github.com/MindscapeHQ/raygun4ruby/pull/95","diff_url":"https://github.com/MindscapeHQ/raygun4ruby/pull/95.diff","patch_url":"https://github.com/MindscapeHQ/raygun4ruby/pull/95.patch","issue_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/95","number":95,"state":"closed","locked":false,"title":"Prevent logging of password confirmations","user":{"login":"bestie","id":145723,"avatar_url":"https://avatars.githubusercontent.com/u/145723?v=3","gravatar_id":"","url":"https://api.github.com/users/bestie","html_url":"https://github.com/bestie","followers_url":"https://api.github.com/users/bestie/followers","following_url":"https://api.github.com/users/bestie/following{/other_user}","gists_url":"https://api.github.com/users/bestie/gists{/gist_id}","starred_url":"https://api.github.com/users/bestie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestie/subscriptions","organizations_url":"https://api.github.com/users/bestie/orgs","repos_url":"https://api.github.com/users/bestie/repos","events_url":"https://api.github.com/users/bestie/events{/privacy}","received_events_url":"https://api.github.com/users/bestie/received_events","type":"User","site_admin":false},"body":"This change ensures that parameters such as `password_confirmation` are\r\nnot sent to the server.\r\n\r\nPreviously parameters were only filtered when their name exactly matched\r\na member of the `filter_parameters` list. The test\r\n`test_filter_parameters_using_proc` in `client_test.rb` uses a custom\r\n`Proc` to demonstrate filtering of all parameters starting with\r\n'nsa_only'. This is a valid demonstration however the default\r\nconfiguration for Rails applications uses a different code path not\r\ncontaining the logic from that `Proc`.\r\n\r\nA default configuration for Rails applications is something like the\r\nfollowing where the Raygun client inherits the filter list from Rails as\r\nan array of Symbols. In most cases this will result in an Array\r\ncontaining a single element `:password`.\r\n\r\n```\r\nconfig.filter_parameters = Rails.application.config.filter_parameters\r\n```\r\n\r\nThis will trigger a code path running through the private client method\r\n`filter_params_with_array` which as previously stated requires an exact\r\nname match in order to filter the parameter.\r\n\r\nIn an attempt to remain consistent with Rails users' expectations and\r\nwithout creating a hard dependency I have emulated ActionDispatch's\r\nmethod of matching with a case insensitive regular\r\nexpression.","created_at":"2016-09-01T11:50:06Z","updated_at":"2016-09-05T11:51:28Z","closed_at":"2016-09-05T11:51:27Z","merged_at":"2016-09-05T11:51:27Z","merge_commit_sha":"13b31a4459cc00a42007257e34d0d4ef1f06801a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95/commits","review_comments_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95/comments","review_comment_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/95/comments","statuses_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/statuses/1347402cf8c1b2c87318f74a4c5394d255c58afb","head":{"label":"Alliants:filter-password-confirmations","ref":"filter-password-confirmations","sha":"1347402cf8c1b2c87318f74a4c5394d255c58afb","user":{"login":"Alliants","id":1121072,"avatar_url":"https://avatars.githubusercontent.com/u/1121072?v=3","gravatar_id":"","url":"https://api.github.com/users/Alliants","html_url":"https://github.com/Alliants","followers_url":"https://api.github.com/users/Alliants/followers","following_url":"https://api.github.com/users/Alliants/following{/other_user}","gists_url":"https://api.github.com/users/Alliants/gists{/gist_id}","starred_url":"https://api.github.com/users/Alliants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alliants/subscriptions","organizations_url":"https://api.github.com/users/Alliants/orgs","repos_url":"https://api.github.com/users/Alliants/repos","events_url":"https://api.github.com/users/Alliants/events{/privacy}","received_events_url":"https://api.github.com/users/Alliants/received_events","type":"Organization","site_admin":false},"repo":{"id":67126113,"name":"raygun4ruby","full_name":"Alliants/raygun4ruby","owner":{"login":"Alliants","id":1121072,"avatar_url":"https://avatars.githubusercontent.com/u/1121072?v=3","gravatar_id":"","url":"https://api.github.com/users/Alliants","html_url":"https://github.com/Alliants","followers_url":"https://api.github.com/users/Alliants/followers","following_url":"https://api.github.com/users/Alliants/following{/other_user}","gists_url":"https://api.github.com/users/Alliants/gists{/gist_id}","starred_url":"https://api.github.com/users/Alliants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alliants/subscriptions","organizations_url":"https://api.github.com/users/Alliants/orgs","repos_url":"https://api.github.com/users/Alliants/repos","events_url":"https://api.github.com/users/Alliants/events{/privacy}","received_events_url":"https://api.github.com/users/Alliants/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alliants/raygun4ruby","description":"The Ruby & Ruby on Rails provider for Raygun.io","fork":true,"url":"https://api.github.com/repos/Alliants/raygun4ruby","forks_url":"https://api.github.com/repos/Alliants/raygun4ruby/forks","keys_url":"https://api.github.com/repos/Alliants/raygun4ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alliants/raygun4ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alliants/raygun4ruby/teams","hooks_url":"https://api.github.com/repos/Alliants/raygun4ruby/hooks","issue_events_url":"https://api.github.com/repos/Alliants/raygun4ruby/issues/events{/number}","events_url":"https://api.github.com/repos/Alliants/raygun4ruby/events","assignees_url":"https://api.github.com/repos/Alliants/raygun4ruby/assignees{/user}","branches_url":"https://api.github.com/repos/Alliants/raygun4ruby/branches{/branch}","tags_url":"https://api.github.com/repos/Alliants/raygun4ruby/tags","blobs_url":"https://api.github.com/repos/Alliants/raygun4ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alliants/raygun4ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alliants/raygun4ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alliants/raygun4ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alliants/raygun4ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/Alliants/raygun4ruby/languages","stargazers_url":"https://api.github.com/repos/Alliants/raygun4ruby/stargazers","contributors_url":"https://api.github.com/repos/Alliants/raygun4ruby/contributors","subscribers_url":"https://api.github.com/repos/Alliants/raygun4ruby/subscribers","subscription_url":"https://api.github.com/repos/Alliants/raygun4ruby/subscription","commits_url":"https://api.github.com/repos/Alliants/raygun4ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alliants/raygun4ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alliants/raygun4ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alliants/raygun4ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alliants/raygun4ruby/contents/{+path}","compare_url":"https://api.github.com/repos/Alliants/raygun4ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alliants/raygun4ruby/merges","archive_url":"https://api.github.com/repos/Alliants/raygun4ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alliants/raygun4ruby/downloads","issues_url":"https://api.github.com/repos/Alliants/raygun4ruby/issues{/number}","pulls_url":"https://api.github.com/repos/Alliants/raygun4ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/Alliants/raygun4ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/Alliants/raygun4ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alliants/raygun4ruby/labels{/name}","releases_url":"https://api.github.com/repos/Alliants/raygun4ruby/releases{/id}","deployments_url":"https://api.github.com/repos/Alliants/raygun4ruby/deployments","created_at":"2016-09-01T11:39:32Z","updated_at":"2016-09-01T11:39:33Z","pushed_at":"2016-09-01T11:48:59Z","git_url":"git://github.com/Alliants/raygun4ruby.git","ssh_url":"git@github.com:Alliants/raygun4ruby.git","clone_url":"https://github.com/Alliants/raygun4ruby.git","svn_url":"https://github.com/Alliants/raygun4ruby","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"filter-password-confirmations"}},"base":{"label":"MindscapeHQ:master","ref":"master","sha":"4763cd9ad8ba6f803d89451957c32338c42de2d0","user":{"login":"MindscapeHQ","id":1767684,"avatar_url":"https://avatars.githubusercontent.com/u/1767684?v=3","gravatar_id":"","url":"https://api.github.com/users/MindscapeHQ","html_url":"https://github.com/MindscapeHQ","followers_url":"https://api.github.com/users/MindscapeHQ/followers","following_url":"https://api.github.com/users/MindscapeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MindscapeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MindscapeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MindscapeHQ/subscriptions","organizations_url":"https://api.github.com/users/MindscapeHQ/orgs","repos_url":"https://api.github.com/users/MindscapeHQ/repos","events_url":"https://api.github.com/users/MindscapeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MindscapeHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":11411835,"name":"raygun4ruby","full_name":"MindscapeHQ/raygun4ruby","owner":{"login":"MindscapeHQ","id":1767684,"avatar_url":"https://avatars.githubusercontent.com/u/1767684?v=3","gravatar_id":"","url":"https://api.github.com/users/MindscapeHQ","html_url":"https://github.com/MindscapeHQ","followers_url":"https://api.github.com/users/MindscapeHQ/followers","following_url":"https://api.github.com/users/MindscapeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MindscapeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MindscapeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MindscapeHQ/subscriptions","organizations_url":"https://api.github.com/users/MindscapeHQ/orgs","repos_url":"https://api.github.com/users/MindscapeHQ/repos","events_url":"https://api.github.com/users/MindscapeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MindscapeHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MindscapeHQ/raygun4ruby","description":"The Ruby & Ruby on Rails provider for Raygun.io","fork":false,"url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby","forks_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/forks","keys_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/teams","hooks_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/hooks","issue_events_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/events{/number}","events_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/events","assignees_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/assignees{/user}","branches_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/branches{/branch}","tags_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/tags","blobs_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/languages","stargazers_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/stargazers","contributors_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/contributors","subscribers_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/subscribers","subscription_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/subscription","commits_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/contents/{+path}","compare_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/merges","archive_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/downloads","issues_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues{/number}","pulls_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/labels{/name}","releases_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/releases{/id}","deployments_url":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/deployments","created_at":"2013-07-15T00:49:24Z","updated_at":"2016-09-04T15:42:52Z","pushed_at":"2016-09-05T11:51:27Z","git_url":"git://github.com/MindscapeHQ/raygun4ruby.git","ssh_url":"git@github.com:MindscapeHQ/raygun4ruby.git","clone_url":"https://github.com/MindscapeHQ/raygun4ruby.git","svn_url":"https://github.com/MindscapeHQ/raygun4ruby","homepage":null,"size":174,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":18,"forks":32,"open_issues":18,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95"},"html":{"href":"https://github.com/MindscapeHQ/raygun4ruby/pull/95"},"issue":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/95"},"comments":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/MindscapeHQ/raygun4ruby/statuses/1347402cf8c1b2c87318f74a4c5394d255c58afb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nikz","id":6474,"avatar_url":"https://avatars.githubusercontent.com/u/6474?v=3","gravatar_id":"","url":"https://api.github.com/users/nikz","html_url":"https://github.com/nikz","followers_url":"https://api.github.com/users/nikz/followers","following_url":"https://api.github.com/users/nikz/following{/other_user}","gists_url":"https://api.github.com/users/nikz/gists{/gist_id}","starred_url":"https://api.github.com/users/nikz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikz/subscriptions","organizations_url":"https://api.github.com/users/nikz/orgs","repos_url":"https://api.github.com/users/nikz/repos","events_url":"https://api.github.com/users/nikz/events{/privacy}","received_events_url":"https://api.github.com/users/nikz/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":28,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"nikz"}}