{"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/directory-sso/pulls/comments/86780917","pull_request_review_id":7419969,"id":86780917,"diff_hunk":"@@ -8,6 +9,14 @@ class IndentedInvalidFieldsMixin:\n \n \n class SignupForm(IndentedInvalidFieldsMixin, forms.SignupForm):\n+    terms_agreed = BooleanField(","path":"sso/user/forms.py","position":11,"original_position":11,"commit_id":"e5fa77a7aa4743956f49f309bbece05b4642ea1b","original_commit_id":"e5fa77a7aa4743956f49f309bbece05b4642ea1b","user":{"login":"richtier","id":5485798,"avatar_url":"https://avatars.githubusercontent.com/u/5485798?v=3","gravatar_id":"","url":"https://api.github.com/users/richtier","html_url":"https://github.com/richtier","followers_url":"https://api.github.com/users/richtier/followers","following_url":"https://api.github.com/users/richtier/following{/other_user}","gists_url":"https://api.github.com/users/richtier/gists{/gist_id}","starred_url":"https://api.github.com/users/richtier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richtier/subscriptions","organizations_url":"https://api.github.com/users/richtier/orgs","repos_url":"https://api.github.com/users/richtier/repos","events_url":"https://api.github.com/users/richtier/events{/privacy}","received_events_url":"https://api.github.com/users/richtier/received_events","type":"User","site_admin":false},"body":"its `require=True` by default, I will add a test","created_at":"2016-11-07T14:06:18Z","updated_at":"2016-11-07T14:06:18Z","html_url":"https://github.com/uktrade/directory-sso/pull/35#discussion_r86780917","pull_request_url":"https://api.github.com/repos/uktrade/directory-sso/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/comments/86780917"},"html":{"href":"https://github.com/uktrade/directory-sso/pull/35#discussion_r86780917"},"pull_request":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/uktrade/directory-sso/pulls/35","id":92577560,"html_url":"https://github.com/uktrade/directory-sso/pull/35","diff_url":"https://github.com/uktrade/directory-sso/pull/35.diff","patch_url":"https://github.com/uktrade/directory-sso/pull/35.patch","issue_url":"https://api.github.com/repos/uktrade/directory-sso/issues/35","number":35,"state":"open","locked":false,"title":"Add check for terms accepted","user":{"login":"richtier","id":5485798,"avatar_url":"https://avatars.githubusercontent.com/u/5485798?v=3","gravatar_id":"","url":"https://api.github.com/users/richtier","html_url":"https://github.com/richtier","followers_url":"https://api.github.com/users/richtier/followers","following_url":"https://api.github.com/users/richtier/following{/other_user}","gists_url":"https://api.github.com/users/richtier/gists{/gist_id}","starred_url":"https://api.github.com/users/richtier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richtier/subscriptions","organizations_url":"https://api.github.com/users/richtier/orgs","repos_url":"https://api.github.com/users/richtier/repos","events_url":"https://api.github.com/users/richtier/events{/privacy}","received_events_url":"https://api.github.com/users/richtier/received_events","type":"User","site_admin":false},"body":"[this task](https://uktrade.atlassian.net/browse/ED-295)\r\n\r\nI considered linking to UI's terms, but that would add extra complexity that is easily solved by duplicating the view here.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5485798/20058407/c396008a-a4e8-11e6-911c-fde8ec53aebb.png)\r\n","created_at":"2016-11-07T12:50:49Z","updated_at":"2016-11-07T14:06:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d0f3b6450c7983b517bbaf1f7763a77eacff524","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/directory-sso/pulls/35/commits","review_comments_url":"https://api.github.com/repos/uktrade/directory-sso/pulls/35/comments","review_comment_url":"https://api.github.com/repos/uktrade/directory-sso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/directory-sso/issues/35/comments","statuses_url":"https://api.github.com/repos/uktrade/directory-sso/statuses/e5fa77a7aa4743956f49f309bbece05b4642ea1b","head":{"label":"uktrade:ED-295-terms","ref":"ED-295-terms","sha":"e5fa77a7aa4743956f49f309bbece05b4642ea1b","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":71396361,"name":"directory-sso","full_name":"uktrade/directory-sso","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/directory-sso","description":null,"fork":false,"url":"https://api.github.com/repos/uktrade/directory-sso","forks_url":"https://api.github.com/repos/uktrade/directory-sso/forks","keys_url":"https://api.github.com/repos/uktrade/directory-sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/directory-sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/directory-sso/teams","hooks_url":"https://api.github.com/repos/uktrade/directory-sso/hooks","issue_events_url":"https://api.github.com/repos/uktrade/directory-sso/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/directory-sso/events","assignees_url":"https://api.github.com/repos/uktrade/directory-sso/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/directory-sso/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/directory-sso/tags","blobs_url":"https://api.github.com/repos/uktrade/directory-sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/directory-sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/directory-sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/directory-sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/directory-sso/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/directory-sso/languages","stargazers_url":"https://api.github.com/repos/uktrade/directory-sso/stargazers","contributors_url":"https://api.github.com/repos/uktrade/directory-sso/contributors","subscribers_url":"https://api.github.com/repos/uktrade/directory-sso/subscribers","subscription_url":"https://api.github.com/repos/uktrade/directory-sso/subscription","commits_url":"https://api.github.com/repos/uktrade/directory-sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/directory-sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/directory-sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/directory-sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/directory-sso/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/directory-sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/directory-sso/merges","archive_url":"https://api.github.com/repos/uktrade/directory-sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/directory-sso/downloads","issues_url":"https://api.github.com/repos/uktrade/directory-sso/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/directory-sso/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/directory-sso/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/directory-sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/directory-sso/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/directory-sso/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/directory-sso/deployments","created_at":"2016-10-19T20:25:54Z","updated_at":"2016-10-26T09:27:25Z","pushed_at":"2016-11-07T13:29:35Z","git_url":"git://github.com/uktrade/directory-sso.git","ssh_url":"git@github.com:uktrade/directory-sso.git","clone_url":"https://github.com/uktrade/directory-sso.git","svn_url":"https://github.com/uktrade/directory-sso","homepage":null,"size":734,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"uktrade:master","ref":"master","sha":"0566e6f2caf4754a29d5331c47a9cee9325e7711","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":71396361,"name":"directory-sso","full_name":"uktrade/directory-sso","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/directory-sso","description":null,"fork":false,"url":"https://api.github.com/repos/uktrade/directory-sso","forks_url":"https://api.github.com/repos/uktrade/directory-sso/forks","keys_url":"https://api.github.com/repos/uktrade/directory-sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/directory-sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/directory-sso/teams","hooks_url":"https://api.github.com/repos/uktrade/directory-sso/hooks","issue_events_url":"https://api.github.com/repos/uktrade/directory-sso/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/directory-sso/events","assignees_url":"https://api.github.com/repos/uktrade/directory-sso/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/directory-sso/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/directory-sso/tags","blobs_url":"https://api.github.com/repos/uktrade/directory-sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/directory-sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/directory-sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/directory-sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/directory-sso/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/directory-sso/languages","stargazers_url":"https://api.github.com/repos/uktrade/directory-sso/stargazers","contributors_url":"https://api.github.com/repos/uktrade/directory-sso/contributors","subscribers_url":"https://api.github.com/repos/uktrade/directory-sso/subscribers","subscription_url":"https://api.github.com/repos/uktrade/directory-sso/subscription","commits_url":"https://api.github.com/repos/uktrade/directory-sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/directory-sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/directory-sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/directory-sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/directory-sso/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/directory-sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/directory-sso/merges","archive_url":"https://api.github.com/repos/uktrade/directory-sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/directory-sso/downloads","issues_url":"https://api.github.com/repos/uktrade/directory-sso/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/directory-sso/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/directory-sso/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/directory-sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/directory-sso/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/directory-sso/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/directory-sso/deployments","created_at":"2016-10-19T20:25:54Z","updated_at":"2016-10-26T09:27:25Z","pushed_at":"2016-11-07T13:29:35Z","git_url":"git://github.com/uktrade/directory-sso.git","ssh_url":"git@github.com:uktrade/directory-sso.git","clone_url":"https://github.com/uktrade/directory-sso.git","svn_url":"https://github.com/uktrade/directory-sso","homepage":null,"size":734,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/35"},"html":{"href":"https://github.com/uktrade/directory-sso/pull/35"},"issue":{"href":"https://api.github.com/repos/uktrade/directory-sso/issues/35"},"comments":{"href":"https://api.github.com/repos/uktrade/directory-sso/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/directory-sso/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/directory-sso/statuses/e5fa77a7aa4743956f49f309bbece05b4642ea1b"}}}}
{"actor":{"display_login":"richtier"}}