{"action":"created","comment":{"url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/comments/85676804","pull_request_review_id":6378655,"id":85676804,"diff_hunk":"@@ -0,0 +1,124 @@\n+class Api::AuthOverrides::PasswordsController < DeviseTokenAuth::PasswordsController\n+  def edit\n+    @resource = resource_class.reset_password_by_token(\n+      reset_password_token: edit_params[:reset_password_token]\n+    )\n+\n+    if @resource && @resource.id\n+      client_id  = SecureRandom.urlsafe_base64(nil, false)\n+      token      = SecureRandom.urlsafe_base64(nil, false)\n+      token_hash = BCrypt::Password.create(token)\n+      expiry     = (Time.now + DeviseTokenAuth.token_lifespan).to_i # rubocop:disable Rails/TimeZone","path":"lib/overrides/app/controllers/api/auth_overrides/passwords_controller.rb","position":11,"original_position":11,"commit_id":"9390d6f109ab413c33c992c3dd234a09ada9cccd","original_commit_id":"9390d6f109ab413c33c992c3dd234a09ada9cccd","user":{"login":"jahammo2","id":9851764,"avatar_url":"https://avatars.githubusercontent.com/u/9851764?v=3","gravatar_id":"","url":"https://api.github.com/users/jahammo2","html_url":"https://github.com/jahammo2","followers_url":"https://api.github.com/users/jahammo2/followers","following_url":"https://api.github.com/users/jahammo2/following{/other_user}","gists_url":"https://api.github.com/users/jahammo2/gists{/gist_id}","starred_url":"https://api.github.com/users/jahammo2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahammo2/subscriptions","organizations_url":"https://api.github.com/users/jahammo2/orgs","repos_url":"https://api.github.com/users/jahammo2/repos","events_url":"https://api.github.com/users/jahammo2/events{/privacy}","received_events_url":"https://api.github.com/users/jahammo2/received_events","type":"User","site_admin":false},"body":"There are two other rubocop_disables for the auth overrides. I purposefully did that because most of the overrides' content code was copied right from devise token auth. And I want the overrides to look as similar to the real thing as possible. So that's why I'm not making alterations where rubocop tells me to","created_at":"2016-10-31T01:47:21Z","updated_at":"2016-10-31T01:47:21Z","html_url":"https://github.com/smashingboxes/boxcar/pull/32#discussion_r85676804","pull_request_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/comments/85676804"},"html":{"href":"https://github.com/smashingboxes/boxcar/pull/32#discussion_r85676804"},"pull_request":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32","id":91546444,"html_url":"https://github.com/smashingboxes/boxcar/pull/32","diff_url":"https://github.com/smashingboxes/boxcar/pull/32.diff","patch_url":"https://github.com/smashingboxes/boxcar/pull/32.patch","issue_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/32","number":32,"state":"open","locked":false,"title":"Task/add json api compliance option","user":{"login":"jahammo2","id":9851764,"avatar_url":"https://avatars.githubusercontent.com/u/9851764?v=3","gravatar_id":"","url":"https://api.github.com/users/jahammo2","html_url":"https://github.com/jahammo2","followers_url":"https://api.github.com/users/jahammo2/followers","following_url":"https://api.github.com/users/jahammo2/following{/other_user}","gists_url":"https://api.github.com/users/jahammo2/gists{/gist_id}","starred_url":"https://api.github.com/users/jahammo2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahammo2/subscriptions","organizations_url":"https://api.github.com/users/jahammo2/orgs","repos_url":"https://api.github.com/users/jahammo2/repos","events_url":"https://api.github.com/users/jahammo2/events{/privacy}","received_events_url":"https://api.github.com/users/jahammo2/received_events","type":"User","site_admin":false},"body":"#### Why\r\nBecause if you want to use Devise Token Auth and be json-api compliant, you'll have to override the controllers. Now you can say yes to the question in the prompt, `Make the auth errors json-api compliant via controller overrides? (y/n)`, and the overrides will be automatically created.\r\n\r\n#### What\r\n- Added documentation to Readme regarding testing\r\n- Added `Controller` configuration to manipulate/add controllers\r\n- Added `JsonApiCompliance` configuration to handle all tasks related to making the api json-api compliant. For now, it only deals with making devise token auth errors json-api compliant.\r\n- Added a `content_editor` to hold methods I kept using\r\n- Everything from `lib/overrides` down just holds the file content that will be going into the newly created api","created_at":"2016-10-31T01:41:38Z","updated_at":"2016-10-31T01:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd9c6950cdb959f1db58b54a3743bc3761f82290","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32/commits","review_comments_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32/comments","review_comment_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/32/comments","statuses_url":"https://api.github.com/repos/smashingboxes/boxcar/statuses/9390d6f109ab413c33c992c3dd234a09ada9cccd","head":{"label":"smashingboxes:task/add_json_api_compliance_option","ref":"task/add_json_api_compliance_option","sha":"9390d6f109ab413c33c992c3dd234a09ada9cccd","user":{"login":"smashingboxes","id":784473,"avatar_url":"https://avatars.githubusercontent.com/u/784473?v=3","gravatar_id":"","url":"https://api.github.com/users/smashingboxes","html_url":"https://github.com/smashingboxes","followers_url":"https://api.github.com/users/smashingboxes/followers","following_url":"https://api.github.com/users/smashingboxes/following{/other_user}","gists_url":"https://api.github.com/users/smashingboxes/gists{/gist_id}","starred_url":"https://api.github.com/users/smashingboxes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashingboxes/subscriptions","organizations_url":"https://api.github.com/users/smashingboxes/orgs","repos_url":"https://api.github.com/users/smashingboxes/repos","events_url":"https://api.github.com/users/smashingboxes/events{/privacy}","received_events_url":"https://api.github.com/users/smashingboxes/received_events","type":"Organization","site_admin":false},"repo":{"id":53594968,"name":"boxcar","full_name":"smashingboxes/boxcar","owner":{"login":"smashingboxes","id":784473,"avatar_url":"https://avatars.githubusercontent.com/u/784473?v=3","gravatar_id":"","url":"https://api.github.com/users/smashingboxes","html_url":"https://github.com/smashingboxes","followers_url":"https://api.github.com/users/smashingboxes/followers","following_url":"https://api.github.com/users/smashingboxes/following{/other_user}","gists_url":"https://api.github.com/users/smashingboxes/gists{/gist_id}","starred_url":"https://api.github.com/users/smashingboxes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashingboxes/subscriptions","organizations_url":"https://api.github.com/users/smashingboxes/orgs","repos_url":"https://api.github.com/users/smashingboxes/repos","events_url":"https://api.github.com/users/smashingboxes/events{/privacy}","received_events_url":"https://api.github.com/users/smashingboxes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smashingboxes/boxcar","description":"A Rails template for generating Rails applications with the best practices of the Smashing Boxes team.","fork":false,"url":"https://api.github.com/repos/smashingboxes/boxcar","forks_url":"https://api.github.com/repos/smashingboxes/boxcar/forks","keys_url":"https://api.github.com/repos/smashingboxes/boxcar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smashingboxes/boxcar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smashingboxes/boxcar/teams","hooks_url":"https://api.github.com/repos/smashingboxes/boxcar/hooks","issue_events_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/events{/number}","events_url":"https://api.github.com/repos/smashingboxes/boxcar/events","assignees_url":"https://api.github.com/repos/smashingboxes/boxcar/assignees{/user}","branches_url":"https://api.github.com/repos/smashingboxes/boxcar/branches{/branch}","tags_url":"https://api.github.com/repos/smashingboxes/boxcar/tags","blobs_url":"https://api.github.com/repos/smashingboxes/boxcar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smashingboxes/boxcar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smashingboxes/boxcar/git/refs{/sha}","trees_url":"https://api.github.com/repos/smashingboxes/boxcar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smashingboxes/boxcar/statuses/{sha}","languages_url":"https://api.github.com/repos/smashingboxes/boxcar/languages","stargazers_url":"https://api.github.com/repos/smashingboxes/boxcar/stargazers","contributors_url":"https://api.github.com/repos/smashingboxes/boxcar/contributors","subscribers_url":"https://api.github.com/repos/smashingboxes/boxcar/subscribers","subscription_url":"https://api.github.com/repos/smashingboxes/boxcar/subscription","commits_url":"https://api.github.com/repos/smashingboxes/boxcar/commits{/sha}","git_commits_url":"https://api.github.com/repos/smashingboxes/boxcar/git/commits{/sha}","comments_url":"https://api.github.com/repos/smashingboxes/boxcar/comments{/number}","issue_comment_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/comments{/number}","contents_url":"https://api.github.com/repos/smashingboxes/boxcar/contents/{+path}","compare_url":"https://api.github.com/repos/smashingboxes/boxcar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smashingboxes/boxcar/merges","archive_url":"https://api.github.com/repos/smashingboxes/boxcar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smashingboxes/boxcar/downloads","issues_url":"https://api.github.com/repos/smashingboxes/boxcar/issues{/number}","pulls_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls{/number}","milestones_url":"https://api.github.com/repos/smashingboxes/boxcar/milestones{/number}","notifications_url":"https://api.github.com/repos/smashingboxes/boxcar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smashingboxes/boxcar/labels{/name}","releases_url":"https://api.github.com/repos/smashingboxes/boxcar/releases{/id}","deployments_url":"https://api.github.com/repos/smashingboxes/boxcar/deployments","created_at":"2016-03-10T15:23:34Z","updated_at":"2016-10-29T14:44:32Z","pushed_at":"2016-10-31T01:41:38Z","git_url":"git://github.com/smashingboxes/boxcar.git","ssh_url":"git@github.com:smashingboxes/boxcar.git","clone_url":"https://github.com/smashingboxes/boxcar.git","svn_url":"https://github.com/smashingboxes/boxcar","homepage":"","size":105,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"smashingboxes:master","ref":"master","sha":"3a26817bf7b5625bcbfd38b3200d70e3b4f5d73d","user":{"login":"smashingboxes","id":784473,"avatar_url":"https://avatars.githubusercontent.com/u/784473?v=3","gravatar_id":"","url":"https://api.github.com/users/smashingboxes","html_url":"https://github.com/smashingboxes","followers_url":"https://api.github.com/users/smashingboxes/followers","following_url":"https://api.github.com/users/smashingboxes/following{/other_user}","gists_url":"https://api.github.com/users/smashingboxes/gists{/gist_id}","starred_url":"https://api.github.com/users/smashingboxes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashingboxes/subscriptions","organizations_url":"https://api.github.com/users/smashingboxes/orgs","repos_url":"https://api.github.com/users/smashingboxes/repos","events_url":"https://api.github.com/users/smashingboxes/events{/privacy}","received_events_url":"https://api.github.com/users/smashingboxes/received_events","type":"Organization","site_admin":false},"repo":{"id":53594968,"name":"boxcar","full_name":"smashingboxes/boxcar","owner":{"login":"smashingboxes","id":784473,"avatar_url":"https://avatars.githubusercontent.com/u/784473?v=3","gravatar_id":"","url":"https://api.github.com/users/smashingboxes","html_url":"https://github.com/smashingboxes","followers_url":"https://api.github.com/users/smashingboxes/followers","following_url":"https://api.github.com/users/smashingboxes/following{/other_user}","gists_url":"https://api.github.com/users/smashingboxes/gists{/gist_id}","starred_url":"https://api.github.com/users/smashingboxes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashingboxes/subscriptions","organizations_url":"https://api.github.com/users/smashingboxes/orgs","repos_url":"https://api.github.com/users/smashingboxes/repos","events_url":"https://api.github.com/users/smashingboxes/events{/privacy}","received_events_url":"https://api.github.com/users/smashingboxes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smashingboxes/boxcar","description":"A Rails template for generating Rails applications with the best practices of the Smashing Boxes team.","fork":false,"url":"https://api.github.com/repos/smashingboxes/boxcar","forks_url":"https://api.github.com/repos/smashingboxes/boxcar/forks","keys_url":"https://api.github.com/repos/smashingboxes/boxcar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smashingboxes/boxcar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smashingboxes/boxcar/teams","hooks_url":"https://api.github.com/repos/smashingboxes/boxcar/hooks","issue_events_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/events{/number}","events_url":"https://api.github.com/repos/smashingboxes/boxcar/events","assignees_url":"https://api.github.com/repos/smashingboxes/boxcar/assignees{/user}","branches_url":"https://api.github.com/repos/smashingboxes/boxcar/branches{/branch}","tags_url":"https://api.github.com/repos/smashingboxes/boxcar/tags","blobs_url":"https://api.github.com/repos/smashingboxes/boxcar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smashingboxes/boxcar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smashingboxes/boxcar/git/refs{/sha}","trees_url":"https://api.github.com/repos/smashingboxes/boxcar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smashingboxes/boxcar/statuses/{sha}","languages_url":"https://api.github.com/repos/smashingboxes/boxcar/languages","stargazers_url":"https://api.github.com/repos/smashingboxes/boxcar/stargazers","contributors_url":"https://api.github.com/repos/smashingboxes/boxcar/contributors","subscribers_url":"https://api.github.com/repos/smashingboxes/boxcar/subscribers","subscription_url":"https://api.github.com/repos/smashingboxes/boxcar/subscription","commits_url":"https://api.github.com/repos/smashingboxes/boxcar/commits{/sha}","git_commits_url":"https://api.github.com/repos/smashingboxes/boxcar/git/commits{/sha}","comments_url":"https://api.github.com/repos/smashingboxes/boxcar/comments{/number}","issue_comment_url":"https://api.github.com/repos/smashingboxes/boxcar/issues/comments{/number}","contents_url":"https://api.github.com/repos/smashingboxes/boxcar/contents/{+path}","compare_url":"https://api.github.com/repos/smashingboxes/boxcar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smashingboxes/boxcar/merges","archive_url":"https://api.github.com/repos/smashingboxes/boxcar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smashingboxes/boxcar/downloads","issues_url":"https://api.github.com/repos/smashingboxes/boxcar/issues{/number}","pulls_url":"https://api.github.com/repos/smashingboxes/boxcar/pulls{/number}","milestones_url":"https://api.github.com/repos/smashingboxes/boxcar/milestones{/number}","notifications_url":"https://api.github.com/repos/smashingboxes/boxcar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smashingboxes/boxcar/labels{/name}","releases_url":"https://api.github.com/repos/smashingboxes/boxcar/releases{/id}","deployments_url":"https://api.github.com/repos/smashingboxes/boxcar/deployments","created_at":"2016-03-10T15:23:34Z","updated_at":"2016-10-29T14:44:32Z","pushed_at":"2016-10-31T01:41:38Z","git_url":"git://github.com/smashingboxes/boxcar.git","ssh_url":"git@github.com:smashingboxes/boxcar.git","clone_url":"https://github.com/smashingboxes/boxcar.git","svn_url":"https://github.com/smashingboxes/boxcar","homepage":"","size":105,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32"},"html":{"href":"https://github.com/smashingboxes/boxcar/pull/32"},"issue":{"href":"https://api.github.com/repos/smashingboxes/boxcar/issues/32"},"comments":{"href":"https://api.github.com/repos/smashingboxes/boxcar/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smashingboxes/boxcar/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/smashingboxes/boxcar/statuses/9390d6f109ab413c33c992c3dd234a09ada9cccd"}}}}
{"actor":{"display_login":"jahammo2"}}