{"action":"created","comment":{"url":"https://api.github.com/repos/ovh/cds/pulls/comments/88270168","pull_request_review_id":8848485,"id":88270168,"diff_hunk":"@@ -114,17 +57,18 @@ func (ops *OpenstackStore) Status() string {\n \treturn \"Openstack OK\"\n }\n \n-// DeleteArtifact removes artifact data from openstack\n-func (ops *OpenstackStore) DeleteArtifact(art sdk.Artifact) error {\n-\tcontainer, object := ops.format(art.Name, art.Project, art.Application, art.Environment, art.Pipeline, art.Tag)\n-\tlog.Info(\"OpenstackStore> Deleting /%s/%s\\n\", container, object)\n-\n-\treturn deleteObject(ops.token.ID, ops.endpoint, container, object)\n+// Delete should delete on openstack\n+func (ops *OpenstackStore) Delete(o Object) error {\n+\treturn nil","path":"engine/api/objectstore/openstack.go","position":96,"original_position":96,"commit_id":"fcc4671d6a82f83ec2ef050ab106a4478e5b033b","original_commit_id":"fcc4671d6a82f83ec2ef050ab106a4478e5b033b","user":{"login":"fsamin","id":684151,"avatar_url":"https://avatars.githubusercontent.com/u/684151?v=3","gravatar_id":"","url":"https://api.github.com/users/fsamin","html_url":"https://github.com/fsamin","followers_url":"https://api.github.com/users/fsamin/followers","following_url":"https://api.github.com/users/fsamin/following{/other_user}","gists_url":"https://api.github.com/users/fsamin/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamin/subscriptions","organizations_url":"https://api.github.com/users/fsamin/orgs","repos_url":"https://api.github.com/users/fsamin/repos","events_url":"https://api.github.com/users/fsamin/events{/privacy}","received_events_url":"https://api.github.com/users/fsamin/received_events","type":"User","site_admin":false},"body":"fixed : #68 ","created_at":"2016-11-16T16:17:28Z","updated_at":"2016-11-16T16:17:28Z","html_url":"https://github.com/ovh/cds/pull/64#discussion_r88270168","pull_request_url":"https://api.github.com/repos/ovh/cds/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments/88270168"},"html":{"href":"https://github.com/ovh/cds/pull/64#discussion_r88270168"},"pull_request":{"href":"https://api.github.com/repos/ovh/cds/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/ovh/cds/pulls/64","id":93588020,"html_url":"https://github.com/ovh/cds/pull/64","diff_url":"https://github.com/ovh/cds/pull/64.diff","patch_url":"https://github.com/ovh/cds/pull/64.patch","issue_url":"https://api.github.com/repos/ovh/cds/issues/64","number":64,"state":"closed","locked":false,"title":"Fsamin/template","user":{"login":"fsamin","id":684151,"avatar_url":"https://avatars.githubusercontent.com/u/684151?v=3","gravatar_id":"","url":"https://api.github.com/users/fsamin","html_url":"https://github.com/fsamin","followers_url":"https://api.github.com/users/fsamin/followers","following_url":"https://api.github.com/users/fsamin/following{/other_user}","gists_url":"https://api.github.com/users/fsamin/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamin/subscriptions","organizations_url":"https://api.github.com/users/fsamin/orgs","repos_url":"https://api.github.com/users/fsamin/repos","events_url":"https://api.github.com/users/fsamin/events{/privacy}","received_events_url":"https://api.github.com/users/fsamin/received_events","type":"User","site_admin":false},"body":"feat (api): templates as go-plugin\r\nfeat (api): manage templates api handlers\r\nfeat (api): load action as HCL script\r\nfeat (api): Import function handler\r\nfeat (cli): admin templates management\r\nfeat (cli): apply template rework","created_at":"2016-11-14T15:33:23Z","updated_at":"2016-11-16T16:17:28Z","closed_at":"2016-11-15T15:23:13Z","merged_at":"2016-11-15T15:23:13Z","merge_commit_sha":"3732bf9bef939749089efb7d70b9f7f1c789da25","assignee":{"login":"yesnault","id":395454,"avatar_url":"https://avatars.githubusercontent.com/u/395454?v=3","gravatar_id":"","url":"https://api.github.com/users/yesnault","html_url":"https://github.com/yesnault","followers_url":"https://api.github.com/users/yesnault/followers","following_url":"https://api.github.com/users/yesnault/following{/other_user}","gists_url":"https://api.github.com/users/yesnault/gists{/gist_id}","starred_url":"https://api.github.com/users/yesnault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesnault/subscriptions","organizations_url":"https://api.github.com/users/yesnault/orgs","repos_url":"https://api.github.com/users/yesnault/repos","events_url":"https://api.github.com/users/yesnault/events{/privacy}","received_events_url":"https://api.github.com/users/yesnault/received_events","type":"User","site_admin":false},"assignees":[{"login":"yesnault","id":395454,"avatar_url":"https://avatars.githubusercontent.com/u/395454?v=3","gravatar_id":"","url":"https://api.github.com/users/yesnault","html_url":"https://github.com/yesnault","followers_url":"https://api.github.com/users/yesnault/followers","following_url":"https://api.github.com/users/yesnault/following{/other_user}","gists_url":"https://api.github.com/users/yesnault/gists{/gist_id}","starred_url":"https://api.github.com/users/yesnault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesnault/subscriptions","organizations_url":"https://api.github.com/users/yesnault/orgs","repos_url":"https://api.github.com/users/yesnault/repos","events_url":"https://api.github.com/users/yesnault/events{/privacy}","received_events_url":"https://api.github.com/users/yesnault/received_events","type":"User","site_admin":false},{"login":"sguiheux","id":1478025,"avatar_url":"https://avatars.githubusercontent.com/u/1478025?v=3","gravatar_id":"","url":"https://api.github.com/users/sguiheux","html_url":"https://github.com/sguiheux","followers_url":"https://api.github.com/users/sguiheux/followers","following_url":"https://api.github.com/users/sguiheux/following{/other_user}","gists_url":"https://api.github.com/users/sguiheux/gists{/gist_id}","starred_url":"https://api.github.com/users/sguiheux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguiheux/subscriptions","organizations_url":"https://api.github.com/users/sguiheux/orgs","repos_url":"https://api.github.com/users/sguiheux/repos","events_url":"https://api.github.com/users/sguiheux/events{/privacy}","received_events_url":"https://api.github.com/users/sguiheux/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ovh/cds/pulls/64/commits","review_comments_url":"https://api.github.com/repos/ovh/cds/pulls/64/comments","review_comment_url":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh/cds/issues/64/comments","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/fcc4671d6a82f83ec2ef050ab106a4478e5b033b","head":{"label":"ovh:fsamin/template","ref":"fsamin/template","sha":"fcc4671d6a82f83ec2ef050ab106a4478e5b033b","user":{"login":"ovh","id":1698434,"avatar_url":"https://avatars.githubusercontent.com/u/1698434?v=3","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"name":"cds","full_name":"ovh/cds","owner":{"login":"ovh","id":1698434,"avatar_url":"https://avatars.githubusercontent.com/u/1698434?v=3","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh/cds","description":"Continuous Delivery Service (Engine / SDK / CLI)","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2016-11-15T14:11:12Z","pushed_at":"2016-11-16T16:16:48Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"","size":11195,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":30,"default_branch":"master"}},"base":{"label":"ovh:master","ref":"master","sha":"b610f26c208a49d89b11ca1dc9f81750a351a8af","user":{"login":"ovh","id":1698434,"avatar_url":"https://avatars.githubusercontent.com/u/1698434?v=3","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"name":"cds","full_name":"ovh/cds","owner":{"login":"ovh","id":1698434,"avatar_url":"https://avatars.githubusercontent.com/u/1698434?v=3","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh/cds","description":"Continuous Delivery Service (Engine / SDK / CLI)","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2016-11-15T14:11:12Z","pushed_at":"2016-11-16T16:16:48Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"","size":11195,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/64"},"html":{"href":"https://github.com/ovh/cds/pull/64"},"issue":{"href":"https://api.github.com/repos/ovh/cds/issues/64"},"comments":{"href":"https://api.github.com/repos/ovh/cds/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh/cds/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh/cds/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/ovh/cds/statuses/fcc4671d6a82f83ec2ef050ab106a4478e5b033b"}}}}
{"actor":{"display_login":"fsamin"}}