{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/52112180","id":52112180,"diff_hunk":"@@ -369,16 +369,42 @@ static inline bool ompi_proc_is_sentinel (ompi_proc_t *proc)\n     return (intptr_t) proc & 0x1;\n }\n \n-static inline intptr_t ompi_proc_name_to_sentinel (opal_process_name_t name)\n+/*\n+ * we assume an ompi_proc_t is at least aligned on two bytes,\n+ * so if the LSB of a pointer to an ompi_proc_t is 1, we have to handle\n+ * this pointer as a sentinel instead of a pointer.\n+ * a sentinel can be seen as a 64 bits array with the following format :\n+ * - bit  0     : 1\n+ * - bits 1-15  : local jobid\n+ * - bits 16-31 : job family\n+ * - bits 32-63 : vpid","path":"ompi/proc/proc.h","position":22,"original_position":22,"commit_id":"fe3941c21a6f695d76e7861eeebff99770fef3d3","original_commit_id":"fe3941c21a6f695d76e7861eeebff99770fef3d3","user":{"login":"rhc54","id":2440928,"avatar_url":"https://avatars.githubusercontent.com/u/2440928?v=3","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"body":"I agree with using the MSB of the local jobid. What I'm confused by is that your documented bitmap is incorrect. The local jobid is in the middle of the object, not at the edge as you show.\r\n\r\nNathan mistakenly used the MSB of the entire structure instead of the local jobid. Your bitmap moves it to the LSB of the entire structure, which is the LSB of the vpid, not the local jobid.","created_at":"2016-02-07T03:56:28Z","updated_at":"2016-02-07T03:56:28Z","html_url":"https://github.com/open-mpi/ompi/pull/1345#discussion_r52112180","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/1345","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/52112180"},"html":{"href":"https://github.com/open-mpi/ompi/pull/1345#discussion_r52112180"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/1345"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/1345","id":58518392,"html_url":"https://github.com/open-mpi/ompi/pull/1345","diff_url":"https://github.com/open-mpi/ompi/pull/1345.diff","patch_url":"https://github.com/open-mpi/ompi/pull/1345.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/1345","number":1345,"state":"open","locked":false,"title":"Topic/sentinel proc name conversion","user":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-06T11:42:54Z","updated_at":"2016-02-07T03:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4535b18e2a1c60a6d6a374030d96e73df353d3d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/1345/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/1345/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/1345/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/fe3941c21a6f695d76e7861eeebff99770fef3d3","head":{"label":"ggouaillardet:topic/sentinel_proc_name_conversion","ref":"topic/sentinel_proc_name_conversion","sha":"fe3941c21a6f695d76e7861eeebff99770fef3d3","user":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"repo":{"id":24743931,"name":"ompi","full_name":"ggouaillardet/ompi","owner":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggouaillardet/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/ggouaillardet/ompi","forks_url":"https://api.github.com/repos/ggouaillardet/ompi/forks","keys_url":"https://api.github.com/repos/ggouaillardet/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggouaillardet/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggouaillardet/ompi/teams","hooks_url":"https://api.github.com/repos/ggouaillardet/ompi/hooks","issue_events_url":"https://api.github.com/repos/ggouaillardet/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/ggouaillardet/ompi/events","assignees_url":"https://api.github.com/repos/ggouaillardet/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/ggouaillardet/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/ggouaillardet/ompi/tags","blobs_url":"https://api.github.com/repos/ggouaillardet/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggouaillardet/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggouaillardet/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggouaillardet/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggouaillardet/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/ggouaillardet/ompi/languages","stargazers_url":"https://api.github.com/repos/ggouaillardet/ompi/stargazers","contributors_url":"https://api.github.com/repos/ggouaillardet/ompi/contributors","subscribers_url":"https://api.github.com/repos/ggouaillardet/ompi/subscribers","subscription_url":"https://api.github.com/repos/ggouaillardet/ompi/subscription","commits_url":"https://api.github.com/repos/ggouaillardet/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggouaillardet/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggouaillardet/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggouaillardet/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggouaillardet/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/ggouaillardet/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggouaillardet/ompi/merges","archive_url":"https://api.github.com/repos/ggouaillardet/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggouaillardet/ompi/downloads","issues_url":"https://api.github.com/repos/ggouaillardet/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/ggouaillardet/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/ggouaillardet/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/ggouaillardet/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggouaillardet/ompi/labels{/name}","releases_url":"https://api.github.com/repos/ggouaillardet/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/ggouaillardet/ompi/deployments","created_at":"2014-10-03T02:05:35Z","updated_at":"2014-10-06T10:38:18Z","pushed_at":"2016-02-06T11:42:07Z","git_url":"git://github.com/ggouaillardet/ompi.git","ssh_url":"git@github.com:ggouaillardet/ompi.git","clone_url":"https://github.com/ggouaillardet/ompi.git","svn_url":"https://github.com/ggouaillardet/ompi","homepage":null,"size":121203,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"a1e784d76fba3fe7746914f3e59cdaadc9f56e2a","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2016-02-06T11:23:16Z","pushed_at":"2016-02-06T13:38:06Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":91042,"stargazers_count":148,"watchers_count":148,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":237,"forks":113,"open_issues":237,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/1345"},"html":{"href":"https://github.com/open-mpi/ompi/pull/1345"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/1345"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/1345/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/1345/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/1345/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/fe3941c21a6f695d76e7861eeebff99770fef3d3"}}}}