{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2870","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2870/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2870/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2870/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2870","id":165613529,"number":2870,"title":"Add flow def","user":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars.githubusercontent.com/u/628431?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-07-14T17:18:49Z","updated_at":"2016-08-23T18:05:56Z","closed_at":"2016-08-23T18:05:56Z","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/2870","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2870","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/2870.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/2870.patch"},"body":"Ref #2851.\r\n\r\nUnfortunately, I'm not yet sure I'm doing this right ...\r\n\r\n[The Flow docs](https://flowtype.org/docs/declarations.html#declaration-files) suggest that we should be able to put `mapbox-gl.js.flow` next to `mapbox-gl.js` and in there `export` an object; then Flow will automatically pick up the definition. I've tried to do that following [the example I see in Immutable.js](https://github.com/facebook/immutable-js/blob/master/dist/immutable.js.flow) (the only example I've yet been able to find), but when I then type-check in Studio it looks like the definition file is not in fact registered.\r\n\r\nWhat I have in this PR right now works as long as you manually add `mapbox-gl.js.flow` to a `.flowconfig` file.\r\n\r\nI'm going to try poking around a little more to see why the automatic definition registration doesn't seem to work ..."},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/241821585","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2870#issuecomment-241821585","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2870","id":241821585,"user":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T18:05:56Z","updated_at":"2016-08-23T18:05:56Z","body":"We cannot merge this PR until we have some way to test this interface. We can't commit to supporting untested and unused code in this repo. "}}
{"actor":{"display_login":"lucaswoj"}}