{"action":"created","comment":{"url":"https://api.github.com/repos/campagnola/pyacq/pulls/comments/63810708","id":63810708,"diff_hunk":"@@ -215,8 +215,15 @@ def get_data(self, start, stop, copy=False, join=True):\n         copied = False\n         \n         if self.double:\n-            start_ind = start % bsize\n-            stop_ind = start_ind + (stop - start)\n+            # This do not work when get_data(-10, 50) meaning stop=50 length=60 (start=stop-length)","path":"pyacq/core/stream/ringbuffer.py","position":6,"original_position":6,"commit_id":"9aa29784af8a7b6568e583c1d544b9a0f9657f7f","original_commit_id":"9aa29784af8a7b6568e583c1d544b9a0f9657f7f","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"body":"It seems like these only give different results if you request a data chunk that is larger than the buffer. In that case, we should probably just raise an exception anyway, right? ","created_at":"2016-05-19T01:28:53Z","updated_at":"2016-05-19T01:28:53Z","html_url":"https://github.com/campagnola/pyacq/pull/4#discussion_r63810708","pull_request_url":"https://api.github.com/repos/campagnola/pyacq/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/comments/63810708"},"html":{"href":"https://github.com/campagnola/pyacq/pull/4#discussion_r63810708"},"pull_request":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/campagnola/pyacq/pulls/4","id":66694180,"html_url":"https://github.com/campagnola/pyacq/pull/4","diff_url":"https://github.com/campagnola/pyacq/pull/4.diff","patch_url":"https://github.com/campagnola/pyacq/pull/4.patch","issue_url":"https://api.github.com/repos/campagnola/pyacq/issues/4","number":4,"state":"open","locked":false,"title":"Modification on qoscilloscope and npbufferdevice for new stream","user":{"login":"samuelgarcia","id":815627,"avatar_url":"https://avatars.githubusercontent.com/u/815627?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelgarcia","html_url":"https://github.com/samuelgarcia","followers_url":"https://api.github.com/users/samuelgarcia/followers","following_url":"https://api.github.com/users/samuelgarcia/following{/other_user}","gists_url":"https://api.github.com/users/samuelgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelgarcia/subscriptions","organizations_url":"https://api.github.com/users/samuelgarcia/orgs","repos_url":"https://api.github.com/users/samuelgarcia/repos","events_url":"https://api.github.com/users/samuelgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/samuelgarcia/received_events","type":"User","site_admin":false},"body":"First modification for this sub PR.\r\ndo not merge now. \r\nMore changes soon.","created_at":"2016-04-15T19:40:21Z","updated_at":"2016-05-19T01:28:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9244e72da0624e07509d02a28aa2647dd248eea5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/campagnola/pyacq/pulls/4/commits","review_comments_url":"https://api.github.com/repos/campagnola/pyacq/pulls/4/comments","review_comment_url":"https://api.github.com/repos/campagnola/pyacq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/campagnola/pyacq/issues/4/comments","statuses_url":"https://api.github.com/repos/campagnola/pyacq/statuses/9aa29784af8a7b6568e583c1d544b9a0f9657f7f","head":{"label":"samuelgarcia:stream-performance","ref":"stream-performance","sha":"9aa29784af8a7b6568e583c1d544b9a0f9657f7f","user":{"login":"samuelgarcia","id":815627,"avatar_url":"https://avatars.githubusercontent.com/u/815627?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelgarcia","html_url":"https://github.com/samuelgarcia","followers_url":"https://api.github.com/users/samuelgarcia/followers","following_url":"https://api.github.com/users/samuelgarcia/following{/other_user}","gists_url":"https://api.github.com/users/samuelgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelgarcia/subscriptions","organizations_url":"https://api.github.com/users/samuelgarcia/orgs","repos_url":"https://api.github.com/users/samuelgarcia/repos","events_url":"https://api.github.com/users/samuelgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/samuelgarcia/received_events","type":"User","site_admin":false},"repo":{"id":37719652,"name":"pyacq","full_name":"samuelgarcia/pyacq","owner":{"login":"samuelgarcia","id":815627,"avatar_url":"https://avatars.githubusercontent.com/u/815627?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelgarcia","html_url":"https://github.com/samuelgarcia","followers_url":"https://api.github.com/users/samuelgarcia/followers","following_url":"https://api.github.com/users/samuelgarcia/following{/other_user}","gists_url":"https://api.github.com/users/samuelgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelgarcia/subscriptions","organizations_url":"https://api.github.com/users/samuelgarcia/orgs","repos_url":"https://api.github.com/users/samuelgarcia/repos","events_url":"https://api.github.com/users/samuelgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/samuelgarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelgarcia/pyacq","description":"Simple Framework for data acquisition (signal, video) in pure python.","fork":true,"url":"https://api.github.com/repos/samuelgarcia/pyacq","forks_url":"https://api.github.com/repos/samuelgarcia/pyacq/forks","keys_url":"https://api.github.com/repos/samuelgarcia/pyacq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelgarcia/pyacq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelgarcia/pyacq/teams","hooks_url":"https://api.github.com/repos/samuelgarcia/pyacq/hooks","issue_events_url":"https://api.github.com/repos/samuelgarcia/pyacq/issues/events{/number}","events_url":"https://api.github.com/repos/samuelgarcia/pyacq/events","assignees_url":"https://api.github.com/repos/samuelgarcia/pyacq/assignees{/user}","branches_url":"https://api.github.com/repos/samuelgarcia/pyacq/branches{/branch}","tags_url":"https://api.github.com/repos/samuelgarcia/pyacq/tags","blobs_url":"https://api.github.com/repos/samuelgarcia/pyacq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelgarcia/pyacq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelgarcia/pyacq/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelgarcia/pyacq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelgarcia/pyacq/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelgarcia/pyacq/languages","stargazers_url":"https://api.github.com/repos/samuelgarcia/pyacq/stargazers","contributors_url":"https://api.github.com/repos/samuelgarcia/pyacq/contributors","subscribers_url":"https://api.github.com/repos/samuelgarcia/pyacq/subscribers","subscription_url":"https://api.github.com/repos/samuelgarcia/pyacq/subscription","commits_url":"https://api.github.com/repos/samuelgarcia/pyacq/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelgarcia/pyacq/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelgarcia/pyacq/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelgarcia/pyacq/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelgarcia/pyacq/contents/{+path}","compare_url":"https://api.github.com/repos/samuelgarcia/pyacq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelgarcia/pyacq/merges","archive_url":"https://api.github.com/repos/samuelgarcia/pyacq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelgarcia/pyacq/downloads","issues_url":"https://api.github.com/repos/samuelgarcia/pyacq/issues{/number}","pulls_url":"https://api.github.com/repos/samuelgarcia/pyacq/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelgarcia/pyacq/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelgarcia/pyacq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelgarcia/pyacq/labels{/name}","releases_url":"https://api.github.com/repos/samuelgarcia/pyacq/releases{/id}","deployments_url":"https://api.github.com/repos/samuelgarcia/pyacq/deployments","created_at":"2015-06-19T12:07:23Z","updated_at":"2016-03-04T11:30:52Z","pushed_at":"2016-05-11T19:00:34Z","git_url":"git://github.com/samuelgarcia/pyacq.git","ssh_url":"git@github.com:samuelgarcia/pyacq.git","clone_url":"https://github.com/samuelgarcia/pyacq.git","svn_url":"https://github.com/samuelgarcia/pyacq","homepage":null,"size":989,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"campagnola:stream-performance","ref":"stream-performance","sha":"5db6747ad8300ae207c45e55e4ab2eda8e6fdca3","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"repo":{"id":39262280,"name":"pyacq","full_name":"campagnola/pyacq","owner":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/campagnola/pyacq","description":"Simple Framework for data acquisition (signal, video) in pure python.","fork":true,"url":"https://api.github.com/repos/campagnola/pyacq","forks_url":"https://api.github.com/repos/campagnola/pyacq/forks","keys_url":"https://api.github.com/repos/campagnola/pyacq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campagnola/pyacq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campagnola/pyacq/teams","hooks_url":"https://api.github.com/repos/campagnola/pyacq/hooks","issue_events_url":"https://api.github.com/repos/campagnola/pyacq/issues/events{/number}","events_url":"https://api.github.com/repos/campagnola/pyacq/events","assignees_url":"https://api.github.com/repos/campagnola/pyacq/assignees{/user}","branches_url":"https://api.github.com/repos/campagnola/pyacq/branches{/branch}","tags_url":"https://api.github.com/repos/campagnola/pyacq/tags","blobs_url":"https://api.github.com/repos/campagnola/pyacq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campagnola/pyacq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campagnola/pyacq/git/refs{/sha}","trees_url":"https://api.github.com/repos/campagnola/pyacq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campagnola/pyacq/statuses/{sha}","languages_url":"https://api.github.com/repos/campagnola/pyacq/languages","stargazers_url":"https://api.github.com/repos/campagnola/pyacq/stargazers","contributors_url":"https://api.github.com/repos/campagnola/pyacq/contributors","subscribers_url":"https://api.github.com/repos/campagnola/pyacq/subscribers","subscription_url":"https://api.github.com/repos/campagnola/pyacq/subscription","commits_url":"https://api.github.com/repos/campagnola/pyacq/commits{/sha}","git_commits_url":"https://api.github.com/repos/campagnola/pyacq/git/commits{/sha}","comments_url":"https://api.github.com/repos/campagnola/pyacq/comments{/number}","issue_comment_url":"https://api.github.com/repos/campagnola/pyacq/issues/comments{/number}","contents_url":"https://api.github.com/repos/campagnola/pyacq/contents/{+path}","compare_url":"https://api.github.com/repos/campagnola/pyacq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campagnola/pyacq/merges","archive_url":"https://api.github.com/repos/campagnola/pyacq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campagnola/pyacq/downloads","issues_url":"https://api.github.com/repos/campagnola/pyacq/issues{/number}","pulls_url":"https://api.github.com/repos/campagnola/pyacq/pulls{/number}","milestones_url":"https://api.github.com/repos/campagnola/pyacq/milestones{/number}","notifications_url":"https://api.github.com/repos/campagnola/pyacq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campagnola/pyacq/labels{/name}","releases_url":"https://api.github.com/repos/campagnola/pyacq/releases{/id}","deployments_url":"https://api.github.com/repos/campagnola/pyacq/deployments","created_at":"2015-07-17T15:53:47Z","updated_at":"2016-03-17T04:29:10Z","pushed_at":"2016-05-11T19:00:34Z","git_url":"git://github.com/campagnola/pyacq.git","ssh_url":"git@github.com:campagnola/pyacq.git","clone_url":"https://github.com/campagnola/pyacq.git","svn_url":"https://github.com/campagnola/pyacq","homepage":null,"size":1106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/4"},"html":{"href":"https://github.com/campagnola/pyacq/pull/4"},"issue":{"href":"https://api.github.com/repos/campagnola/pyacq/issues/4"},"comments":{"href":"https://api.github.com/repos/campagnola/pyacq/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/campagnola/pyacq/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/campagnola/pyacq/statuses/9aa29784af8a7b6568e583c1d544b9a0f9657f7f"}}}}