{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/3539","repository_url":"https://api.github.com/repos/concrete5/concrete5","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/3539/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3539/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/3539/events","html_url":"https://github.com/concrete5/concrete5/issues/3539","id":133616420,"number":3539,"title":"Proposal: Define rules for things PSR-2 doesn't cover","user":{"login":"KorvinSzanto","id":1007419,"avatar_url":"https://avatars.githubusercontent.com/u/1007419?v=3","gravatar_id":"","url":"https://api.github.com/users/KorvinSzanto","html_url":"https://github.com/KorvinSzanto","followers_url":"https://api.github.com/users/KorvinSzanto/followers","following_url":"https://api.github.com/users/KorvinSzanto/following{/other_user}","gists_url":"https://api.github.com/users/KorvinSzanto/gists{/gist_id}","starred_url":"https://api.github.com/users/KorvinSzanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorvinSzanto/subscriptions","organizations_url":"https://api.github.com/users/KorvinSzanto/orgs","repos_url":"https://api.github.com/users/KorvinSzanto/repos","events_url":"https://api.github.com/users/KorvinSzanto/events{/privacy}","received_events_url":"https://api.github.com/users/KorvinSzanto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-02-15T03:46:52Z","updated_at":"2016-03-05T22:12:32Z","closed_at":null,"body":"PSR-1 and PSR-2 [intentionally omit judgements on certain things](http://www.php-fig.org/psr/psr-2/#7-conclusion), I think we should discuss some things left out and come up with some concrete rules that we all hold ourselves to with the help of the cs-fixer config and potentially scrutinizer (#3310).\r\n\r\nSome things that would be good to clear up:\r\n\r\n* Doc block comments. We should review PSR-5 briefly and come up with real requirements for method comments.\r\n* Inline namespacing. We should have an individual use statement for every class we use, even ones at the root namespace. Having a list of use statements at the top makes it really easy to see what the dependencies of a class are.\r\n* new class vs new class();\r\n* Class constant naming\r\n* Class configuration, what's in the constructor vs what's in the service provider\r\n* When to use a service provider\r\n* When to use IoC\r\n* When to use singletons\r\n* Test coverage requirements, we should figure out what percentage coverage we have today and make sure that it continues to go up and not down.\r\n\r\nComment here with more things to add."},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/192750978","html_url":"https://github.com/concrete5/concrete5/issues/3539#issuecomment-192750978","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3539","id":192750978,"user":{"login":"ahukkanen","id":864340,"avatar_url":"https://avatars.githubusercontent.com/u/864340?v=3","gravatar_id":"","url":"https://api.github.com/users/ahukkanen","html_url":"https://github.com/ahukkanen","followers_url":"https://api.github.com/users/ahukkanen/followers","following_url":"https://api.github.com/users/ahukkanen/following{/other_user}","gists_url":"https://api.github.com/users/ahukkanen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahukkanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahukkanen/subscriptions","organizations_url":"https://api.github.com/users/ahukkanen/orgs","repos_url":"https://api.github.com/users/ahukkanen/repos","events_url":"https://api.github.com/users/ahukkanen/events{/privacy}","received_events_url":"https://api.github.com/users/ahukkanen/received_events","type":"User","site_admin":false},"created_at":"2016-03-05T22:12:32Z","updated_at":"2016-03-05T22:12:32Z","body":"@KorvinSzanto I'm not trying to argue here that we should introduce the underscore convention for function/variable naming."}}