{"action":"closed","issue":{"url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/1289","repository_url":"https://api.github.com/repos/Bilibili/ijkplayer","labels_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/1289/labels{/name}","comments_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/1289/comments","events_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/1289/events","html_url":"https://github.com/Bilibili/ijkplayer/issues/1289","id":153740263,"number":1289,"title":"一些关于onCompletion的建议","user":{"login":"NoGirlFriendException","id":11241910,"avatar_url":"https://avatars.githubusercontent.com/u/11241910?v=3","gravatar_id":"","url":"https://api.github.com/users/NoGirlFriendException","html_url":"https://github.com/NoGirlFriendException","followers_url":"https://api.github.com/users/NoGirlFriendException/followers","following_url":"https://api.github.com/users/NoGirlFriendException/following{/other_user}","gists_url":"https://api.github.com/users/NoGirlFriendException/gists{/gist_id}","starred_url":"https://api.github.com/users/NoGirlFriendException/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoGirlFriendException/subscriptions","organizations_url":"https://api.github.com/users/NoGirlFriendException/orgs","repos_url":"https://api.github.com/users/NoGirlFriendException/repos","events_url":"https://api.github.com/users/NoGirlFriendException/events{/privacy}","received_events_url":"https://api.github.com/users/NoGirlFriendException/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-05-09T09:50:01Z","updated_at":"2016-07-18T09:18:19Z","closed_at":"2016-07-18T09:18:19Z","body":"我个人感觉ijkPlayer 对于 onCompletion的回调时机 使用的并不完全正确\r\nonCompletion 应该是在一个**电影正常状态下播放完毕**后产生的回调\r\n但是在ijkPlayer中 不仅仅是在电影播放完毕后 会回调. 而且在出现error的时候 也会出现这个回调\r\n这个逻辑明显是和 android 源生播放器 以及exoPlayer 以及我最早使用的Vitiamio 播放器都不一样.\r\n并不是太明白为什么你们这样设计\r\n你们大部分的接口都是与androidmediaPlayer 保持一致的 但是在这个地方是和他完全不一样的.\r\n\r\n以及 你们的demo中 exoplayer 的wrapper类 中对于exoPlayer 报出的 状态改变的监听\r\n   case ExoPlayer.STATE_IDLE:\r\n            notifyOnCompletion();\r\n我个人认为这也是不合理的 这句话应该注释掉. \r\ngoogle 官方应该希望 仅仅是在ExoPlayer.STATE_ENDED: 的回调中才 应该 回调 notifyOnCompletion();\r\n而不是你们现在的写法。\r\n\r\n以上只是个人的一些看法和建议 如果有说的不对的地方和 错怪你们的地方 请见谅。"}}
{"actor":{"display_login":"bbcallen"}}