{"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/64588901","id":64588901,"diff_hunk":"@@ -0,0 +1,88 @@\n+package java.util.logging\n+\n+import java.io.OutputStream\n+\n+class StreamHandler(private[this] val _out: OutputStream,\n+    private[this] val _formatter: Formatter) extends Handler {\n+\n+  // Required by javadoc but it is unspecified what to do if formatter is null\n+  def this() = this(null, null)\n+\n+  protected var out:Option[OutputStream] = Option(_out)","path":"javalib/src/main/scala/java/util/logging/StreamHandler.scala","position":11,"original_position":11,"commit_id":"f691bdaab7e79bd6f92597983c2281366df48ba8","original_commit_id":"f691bdaab7e79bd6f92597983c2281366df48ba8","user":{"login":"nicolasstucki","id":3648029,"avatar_url":"https://avatars.githubusercontent.com/u/3648029?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasstucki","html_url":"https://github.com/nicolasstucki","followers_url":"https://api.github.com/users/nicolasstucki/followers","following_url":"https://api.github.com/users/nicolasstucki/following{/other_user}","gists_url":"https://api.github.com/users/nicolasstucki/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasstucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasstucki/subscriptions","organizations_url":"https://api.github.com/users/nicolasstucki/orgs","repos_url":"https://api.github.com/users/nicolasstucki/repos","events_url":"https://api.github.com/users/nicolasstucki/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasstucki/received_events","type":"User","site_admin":false},"body":"You are also duplicating the fields that you need to keep one reference. ","created_at":"2016-05-25T14:59:15Z","updated_at":"2016-05-25T14:59:15Z","html_url":"https://github.com/scala-js/scala-js/pull/2410#discussion_r64588901","pull_request_url":"https://api.github.com/repos/scala-js/scala-js/pulls/2410","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/64588901"},"html":{"href":"https://github.com/scala-js/scala-js/pull/2410#discussion_r64588901"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/2410"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/2410","id":71082402,"html_url":"https://github.com/scala-js/scala-js/pull/2410","diff_url":"https://github.com/scala-js/scala-js/pull/2410.diff","patch_url":"https://github.com/scala-js/scala-js/pull/2410.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/2410","number":2410,"state":"open","locked":false,"title":"java.util.logging implementation","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"body":"This PR contains a partial implementation of the java.util.logging package. JULI is not so widely used but still is part of the platform and we have several packages using it. Having support in the platform would make porting much easier. This PR includes all the clases on the package as it is practical and tests\r\n\r\nSome Notes:\r\n* The PR is missing some of the handlers (Like `SocketHandler` or `FileHandler`) that don't make sense in the js environment.\r\n* Another missing class is `LogManager`, used to configure logging but it relies heavily on configuration files and reflection. Instead you can manually configure on code the output handlers, formats, levels, etc\r\n* Console handler uses `System.err` as indicated on the javadocs. That is a poor choice for the browser environment but I don't think we are allowed to change it\r\n* I have a handler that uses Ajax to post to the backend but I believe this wouldn't belong to the core scala.js. Would it be a good addition to scala-js-dom?\r\n\r\nPlease let me know if this is an acceptable contribution to the platform and if it needs any changes on code formatting, history, etc\r\n","created_at":"2016-05-23T16:49:30Z","updated_at":"2016-05-25T14:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6915f95ab22cde4e5d9544255e5ddc45e44eb963","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js/pulls/2410/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js/pulls/2410/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/2410/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/f691bdaab7e79bd6f92597983c2281366df48ba8","head":{"label":"cquiroz:juli","ref":"juli","sha":"f691bdaab7e79bd6f92597983c2281366df48ba8","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"repo":{"id":57993390,"name":"scala-js","full_name":"cquiroz/scala-js","owner":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cquiroz/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":true,"url":"https://api.github.com/repos/cquiroz/scala-js","forks_url":"https://api.github.com/repos/cquiroz/scala-js/forks","keys_url":"https://api.github.com/repos/cquiroz/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cquiroz/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cquiroz/scala-js/teams","hooks_url":"https://api.github.com/repos/cquiroz/scala-js/hooks","issue_events_url":"https://api.github.com/repos/cquiroz/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/cquiroz/scala-js/events","assignees_url":"https://api.github.com/repos/cquiroz/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/cquiroz/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/cquiroz/scala-js/tags","blobs_url":"https://api.github.com/repos/cquiroz/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cquiroz/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cquiroz/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/cquiroz/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cquiroz/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/cquiroz/scala-js/languages","stargazers_url":"https://api.github.com/repos/cquiroz/scala-js/stargazers","contributors_url":"https://api.github.com/repos/cquiroz/scala-js/contributors","subscribers_url":"https://api.github.com/repos/cquiroz/scala-js/subscribers","subscription_url":"https://api.github.com/repos/cquiroz/scala-js/subscription","commits_url":"https://api.github.com/repos/cquiroz/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/cquiroz/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/cquiroz/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/cquiroz/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/cquiroz/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/cquiroz/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cquiroz/scala-js/merges","archive_url":"https://api.github.com/repos/cquiroz/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cquiroz/scala-js/downloads","issues_url":"https://api.github.com/repos/cquiroz/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/cquiroz/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/cquiroz/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/cquiroz/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cquiroz/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/cquiroz/scala-js/releases{/id}","deployments_url":"https://api.github.com/repos/cquiroz/scala-js/deployments","created_at":"2016-05-03T18:53:11Z","updated_at":"2016-05-03T18:53:14Z","pushed_at":"2016-05-24T18:17:33Z","git_url":"git://github.com/cquiroz/scala-js.git","ssh_url":"git@github.com:cquiroz/scala-js.git","clone_url":"https://github.com/cquiroz/scala-js.git","svn_url":"https://github.com/cquiroz/scala-js","homepage":"http://www.scala-js.org/","size":11890,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"cf04cc375e0a138b452cea6c3d39c6cf1e000478","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":8272315,"name":"scala-js","full_name":"scala-js/scala-js","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js","forks_url":"https://api.github.com/repos/scala-js/scala-js/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-js/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js/releases{/id}","deployments_url":"https://api.github.com/repos/scala-js/scala-js/deployments","created_at":"2013-02-18T16:33:55Z","updated_at":"2016-05-25T09:21:42Z","pushed_at":"2016-05-25T13:56:36Z","git_url":"git://github.com/scala-js/scala-js.git","ssh_url":"git@github.com:scala-js/scala-js.git","clone_url":"https://github.com/scala-js/scala-js.git","svn_url":"https://github.com/scala-js/scala-js","homepage":"https://www.scala-js.org/","size":14920,"stargazers_count":2333,"watchers_count":2333,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":98,"forks":214,"open_issues":98,"watchers":2333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/2410"},"html":{"href":"https://github.com/scala-js/scala-js/pull/2410"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/2410"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/2410/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/2410/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/2410/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js/statuses/f691bdaab7e79bd6f92597983c2281366df48ba8"}}}}
{"actor":{"display_login":"nicolasstucki"}}