{"action":"created","issue":{"url":"https://api.github.com/repos/DiUS/java-faker/issues/133","repository_url":"https://api.github.com/repos/DiUS/java-faker","labels_url":"https://api.github.com/repos/DiUS/java-faker/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/DiUS/java-faker/issues/133/comments","events_url":"https://api.github.com/repos/DiUS/java-faker/issues/133/events","html_url":"https://github.com/DiUS/java-faker/pull/133","id":181806642,"number":133,"title":"Fix locale chaining. Add yml only resolution.","user":{"login":"trevershick","id":509549,"avatar_url":"https://avatars.githubusercontent.com/u/509549?v=3","gravatar_id":"","url":"https://api.github.com/users/trevershick","html_url":"https://github.com/trevershick","followers_url":"https://api.github.com/users/trevershick/followers","following_url":"https://api.github.com/users/trevershick/following{/other_user}","gists_url":"https://api.github.com/users/trevershick/gists{/gist_id}","starred_url":"https://api.github.com/users/trevershick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevershick/subscriptions","organizations_url":"https://api.github.com/users/trevershick/orgs","repos_url":"https://api.github.com/users/trevershick/repos","events_url":"https://api.github.com/users/trevershick/events{/privacy}","received_events_url":"https://api.github.com/users/trevershick/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-08T05:42:36Z","updated_at":"2016-10-11T17:01:14Z","closed_at":"2016-10-11T10:41:22Z","pull_request":{"url":"https://api.github.com/repos/DiUS/java-faker/pulls/133","html_url":"https://github.com/DiUS/java-faker/pull/133","diff_url":"https://github.com/DiUS/java-faker/pull/133.diff","patch_url":"https://github.com/DiUS/java-faker/pull/133.patch"},"body":"\r\nThe following tests fail, which lead me down the road of fix/refactor...\r\n\r\n```\r\n@Test\r\npublic void testStreetName_uk() {\r\n    final String actual = new Faker(new Locale(\"uk\")).address().streetName();\r\n    System.out.println(actual);\r\n}\r\n\r\n@Test\r\npublic void testCellPhone_enUS() {\r\n    assertThat(new Faker(Locale.US).phoneNumber().cellPhone(), matchesRegularExpression(\"\\\\(?\\\\d+\\\\)?([- .]\\\\d+){1,3}\"));\r\n}\r\n```\r\n\r\nGot rid of 'defaulting' interface, make the fake value service do multi-locale resolution via chaining. (fr_FR will create a resolution chain of fr_FR, fr, en).\r\n\r\nAltered all lookups from Faker child objects to use a consistent interface .resolve() vs .fetchString.  fetchObject() still exists, haven't changed that ATT."},"comment":{"url":"https://api.github.com/repos/DiUS/java-faker/issues/comments/252978701","html_url":"https://github.com/DiUS/java-faker/pull/133#issuecomment-252978701","issue_url":"https://api.github.com/repos/DiUS/java-faker/issues/133","id":252978701,"user":{"login":"trevershick","id":509549,"avatar_url":"https://avatars.githubusercontent.com/u/509549?v=3","gravatar_id":"","url":"https://api.github.com/users/trevershick","html_url":"https://github.com/trevershick","followers_url":"https://api.github.com/users/trevershick/followers","following_url":"https://api.github.com/users/trevershick/following{/other_user}","gists_url":"https://api.github.com/users/trevershick/gists{/gist_id}","starred_url":"https://api.github.com/users/trevershick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevershick/subscriptions","organizations_url":"https://api.github.com/users/trevershick/orgs","repos_url":"https://api.github.com/users/trevershick/repos","events_url":"https://api.github.com/users/trevershick/events{/privacy}","received_events_url":"https://api.github.com/users/trevershick/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T17:01:14Z","updated_at":"2016-10-11T17:01:14Z","body":"you're welcome. i wanted to get this refactored before adding any more functionality."}}
{"actor":{"display_login":"trevershick"}}