{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/fiberassign/issues/31","repository_url":"https://api.github.com/repos/desihub/fiberassign","labels_url":"https://api.github.com/repos/desihub/fiberassign/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/desihub/fiberassign/issues/31/comments","events_url":"https://api.github.com/repos/desihub/fiberassign/issues/31/events","html_url":"https://github.com/desihub/fiberassign/issues/31","id":143556318,"number":31,"title":"fiberassign doesn't produce reproducible results","user":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/desihub/fiberassign/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"rncahn","id":8890589,"avatar_url":"https://avatars.githubusercontent.com/u/8890589?v=3","gravatar_id":"","url":"https://api.github.com/users/rncahn","html_url":"https://github.com/rncahn","followers_url":"https://api.github.com/users/rncahn/followers","following_url":"https://api.github.com/users/rncahn/following{/other_user}","gists_url":"https://api.github.com/users/rncahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rncahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rncahn/subscriptions","organizations_url":"https://api.github.com/users/rncahn/orgs","repos_url":"https://api.github.com/users/rncahn/repos","events_url":"https://api.github.com/users/rncahn/events{/privacy}","received_events_url":"https://api.github.com/users/rncahn/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-03-25T18:05:37Z","updated_at":"2016-03-28T17:50:47Z","closed_at":null,"body":"Multiple runs of fiberassign on the same machine using the same compilation produce different results, even when not using random numbers (Bob inspected code by grep+eye and says that none of the random number calls are used by the main fiberassign code).  Possible causes are uninitialized variables being used or array overruns clobbering some other piece of memory that is later used.\r\n\r\nAfter fixing, fiberassign should give bitwise identical results when run on multiple machines, at multiple concurrencies, and by multiple people."},"comment":{"url":"https://api.github.com/repos/desihub/fiberassign/issues/comments/202505231","html_url":"https://github.com/desihub/fiberassign/issues/31#issuecomment-202505231","issue_url":"https://api.github.com/repos/desihub/fiberassign/issues/31","id":202505231,"user":{"login":"tskisner","id":84221,"avatar_url":"https://avatars.githubusercontent.com/u/84221?v=3","gravatar_id":"","url":"https://api.github.com/users/tskisner","html_url":"https://github.com/tskisner","followers_url":"https://api.github.com/users/tskisner/followers","following_url":"https://api.github.com/users/tskisner/following{/other_user}","gists_url":"https://api.github.com/users/tskisner/gists{/gist_id}","starred_url":"https://api.github.com/users/tskisner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tskisner/subscriptions","organizations_url":"https://api.github.com/users/tskisner/orgs","repos_url":"https://api.github.com/users/tskisner/repos","events_url":"https://api.github.com/users/tskisner/events{/privacy}","received_events_url":"https://api.github.com/users/tskisner/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T17:50:47Z","updated_at":"2016-03-28T17:50:47Z","body":"The <> bracket convention is preferred over quotes, but this does not \nmatter in this case.  Putting a header in quotes simply allows the \ncompiler to search in the current working directory.  Since fitsio is \nnot in the fiberassign source tree, the two forms are identical.\n\nWhen searching for headers, the compiler looks in default system \nlocations (e.g. /usr/include), and (for gcc anyway) it looks in any \nlocations specified by the CPATH environment variable.\n\nIf you have cfitsio installed somewhere else, then you must specify the \ninclude path as part of the compilation with \n\"-I/path/to/cfitsio/include\"\n\n-T\n\nOn Mon, Mar 28, 2016 at 10:45 AM, Yu Feng <notifications@github.com> \nwrote:\n> I am combing through building. The line\n> \n> #include \"fitsio.h\"\n> is causing some slight issues. It could have been <fitsio.h> or \n> better <cfitsio/fitsio.h> (for Fedora at least..)\n> \n> I really would prefer to reproduce the irrepreducibility of \n> fiberassign on my own computer. Is it possible?\n> \n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly or view it on GitHub\n> \n"}}