{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/76754979","id":76754979,"diff_hunk":"@@ -476,6 +481,7 @@ function update-addons() {\n     # be careful, reconcile-objects uses global variables\n     reconcile-objects ${addon_path} ReplicationController \"-\" &\n     reconcile-objects ${addon_path} Deployment \"-\" &\n+    reconcile-objects ${addon_path} DaemonSet \"-\" &","path":"ansible/roles/kubernetes-addons/files/common/kube-addon-update.sh","position":60,"original_position":60,"commit_id":"11d843ae68a7806d0378a0a29b48810fa5eaa6d3","original_commit_id":"239a92dc0e83efa2ca6f6146154703f016710fb7","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"This has nothing to do with the kubeconfig.","created_at":"2016-08-30T08:55:22Z","updated_at":"2016-08-30T08:55:22Z","html_url":"https://github.com/kubernetes/contrib/pull/1660#discussion_r76754979","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1660","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/76754979"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1660#discussion_r76754979"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1660"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/1660","id":83222135,"html_url":"https://github.com/kubernetes/contrib/pull/1660","diff_url":"https://github.com/kubernetes/contrib/pull/1660.diff","patch_url":"https://github.com/kubernetes/contrib/pull/1660.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/1660","number":1660,"state":"open","locked":false,"title":"Update kubernetes addons scripts","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"When deploying kube-apiserver listening on secure port, kubernetes addons are not deployed as the script calling kubectl does not posses kubeconfig.\r\n\r\nThe first commits cherry picks changes from [1].\r\n\r\n[1] https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/addon-manager\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/contrib/1660)\n<!-- Reviewable:end -->\n","created_at":"2016-08-30T07:38:57Z","updated_at":"2016-08-30T08:55:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab8ecd2f24bdfcbe6a267b2cef61efeb41fd207a","assignee":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"assignees":[{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1660/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1660/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/1660/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/11d843ae68a7806d0378a0a29b48810fa5eaa6d3","head":{"label":"ingvagabund:update-kubernetes-addons-scripts","ref":"update-kubernetes-addons-scripts","sha":"11d843ae68a7806d0378a0a29b48810fa5eaa6d3","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"repo":{"id":54469633,"name":"contrib","full_name":"ingvagabund/contrib","owner":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingvagabund/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/ingvagabund/contrib","forks_url":"https://api.github.com/repos/ingvagabund/contrib/forks","keys_url":"https://api.github.com/repos/ingvagabund/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingvagabund/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingvagabund/contrib/teams","hooks_url":"https://api.github.com/repos/ingvagabund/contrib/hooks","issue_events_url":"https://api.github.com/repos/ingvagabund/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/ingvagabund/contrib/events","assignees_url":"https://api.github.com/repos/ingvagabund/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/ingvagabund/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/ingvagabund/contrib/tags","blobs_url":"https://api.github.com/repos/ingvagabund/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingvagabund/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingvagabund/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingvagabund/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingvagabund/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/ingvagabund/contrib/languages","stargazers_url":"https://api.github.com/repos/ingvagabund/contrib/stargazers","contributors_url":"https://api.github.com/repos/ingvagabund/contrib/contributors","subscribers_url":"https://api.github.com/repos/ingvagabund/contrib/subscribers","subscription_url":"https://api.github.com/repos/ingvagabund/contrib/subscription","commits_url":"https://api.github.com/repos/ingvagabund/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingvagabund/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingvagabund/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingvagabund/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingvagabund/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/ingvagabund/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingvagabund/contrib/merges","archive_url":"https://api.github.com/repos/ingvagabund/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingvagabund/contrib/downloads","issues_url":"https://api.github.com/repos/ingvagabund/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/ingvagabund/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/ingvagabund/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/ingvagabund/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingvagabund/contrib/labels{/name}","releases_url":"https://api.github.com/repos/ingvagabund/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/ingvagabund/contrib/deployments","created_at":"2016-03-22T11:27:12Z","updated_at":"2016-03-22T11:27:15Z","pushed_at":"2016-08-30T07:58:10Z","git_url":"git://github.com/ingvagabund/contrib.git","ssh_url":"git@github.com:ingvagabund/contrib.git","clone_url":"https://github.com/ingvagabund/contrib.git","svn_url":"https://github.com/ingvagabund/contrib","homepage":"","size":268153,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a8f32c3408b1345306c0f426a32f2ce9017ff627","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-08-30T01:44:10Z","pushed_at":"2016-08-30T08:31:54Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":72905,"stargazers_count":461,"watchers_count":461,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":448,"mirror_url":null,"open_issues_count":286,"forks":448,"open_issues":286,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1660"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1660"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1660"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1660/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1660/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1660/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/11d843ae68a7806d0378a0a29b48810fa5eaa6d3"}}}}
{"actor":{"display_login":"sttts"}}