{"action":"closed","number":8319,"pull_request":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/8319","id":35595793,"html_url":"https://github.com/Elgg/Elgg/pull/8319","diff_url":"https://github.com/Elgg/Elgg/pull/8319.diff","patch_url":"https://github.com/Elgg/Elgg/pull/8319.patch","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8319","number":8319,"state":"closed","locked":false,"title":"WIP: Adds race-condition-proof plugin booting and handling of new DOM content","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"This introduces \"plugin boot\" modules which, if present, are automatically required by a new `elgg/booted` module. This is a solution to #7926 (race conditions with plugin hook registrations).\r\n\r\nAs well, this adds a \"behaviors\" system modeled after [Drupal's](https://www.lullabot.com/blog/article/understanding-javascript-behaviors-drupal). If you have to transform DOM content (can't rely on event delegation), you write your boot module to return a \"attachBehavior\" function, and if all scripts properly use `elgg.ajax.attachBehaviors()`, then your transformations will be applied to XHR-loaded content. Yes, this is a convention that devs will have to follow, but it works.\r\n\r\nI applied this to enough stuff in plugins and core stuff to get an idea for how this works.\r\n\r\n- [x] test in other browsers (particularly async require inside definition)\r\n- [x] fix AudioPlayer.embed() in IE9\r\n- [x] complain if boot module returns non-object or unexpected keys.\r\n- [x] change standard boot module to `boot/$plugin_id` to avoid NS collisions\r\n- [ ] docs\r\n- [ ] after 1.x merged, attach behaviors in elgg.Comment save action\r\n- [ ] after #8993 is merged, rebase this to just add behaviors","created_at":"2015-05-17T23:53:42Z","updated_at":"2016-05-13T18:23:20Z","closed_at":"2016-05-13T18:23:20Z","merged_at":null,"merge_commit_sha":"fcc3829d21c181924d06bd8fdccd7a1aa04b235e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8319/commits","review_comments_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8319/comments","review_comment_url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8319/comments","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/da49c5e52ec043d6074a945ee93c293cd9584c5c","head":{"label":"mrclay:behave","ref":"behave","sha":"da49c5e52ec043d6074a945ee93c293cd9584c5c","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"repo":{"id":2142685,"name":"Elgg-leaf","full_name":"mrclay/Elgg-leaf","owner":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrclay/Elgg-leaf","description":"A social networking engine","fork":true,"url":"https://api.github.com/repos/mrclay/Elgg-leaf","forks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/forks","keys_url":"https://api.github.com/repos/mrclay/Elgg-leaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrclay/Elgg-leaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrclay/Elgg-leaf/teams","hooks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/hooks","issue_events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/events{/number}","events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/events","assignees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/assignees{/user}","branches_url":"https://api.github.com/repos/mrclay/Elgg-leaf/branches{/branch}","tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/tags","blobs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrclay/Elgg-leaf/statuses/{sha}","languages_url":"https://api.github.com/repos/mrclay/Elgg-leaf/languages","stargazers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/stargazers","contributors_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contributors","subscribers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscribers","subscription_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscription","commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrclay/Elgg-leaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contents/{+path}","compare_url":"https://api.github.com/repos/mrclay/Elgg-leaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrclay/Elgg-leaf/merges","archive_url":"https://api.github.com/repos/mrclay/Elgg-leaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrclay/Elgg-leaf/downloads","issues_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues{/number}","pulls_url":"https://api.github.com/repos/mrclay/Elgg-leaf/pulls{/number}","milestones_url":"https://api.github.com/repos/mrclay/Elgg-leaf/milestones{/number}","notifications_url":"https://api.github.com/repos/mrclay/Elgg-leaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrclay/Elgg-leaf/labels{/name}","releases_url":"https://api.github.com/repos/mrclay/Elgg-leaf/releases{/id}","deployments_url":"https://api.github.com/repos/mrclay/Elgg-leaf/deployments","created_at":"2011-08-02T13:45:11Z","updated_at":"2014-06-24T23:34:38Z","pushed_at":"2016-05-13T18:22:18Z","git_url":"git://github.com/mrclay/Elgg-leaf.git","ssh_url":"git@github.com:mrclay/Elgg-leaf.git","clone_url":"https://github.com/mrclay/Elgg-leaf.git","svn_url":"https://github.com/mrclay/Elgg-leaf","homepage":"http://elgg.org","size":54532,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Elgg:master","ref":"master","sha":"b40d0f607f1817b1fc339120a5fa990acf0219c1","user":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"repo":{"id":299271,"name":"Elgg","full_name":"Elgg/Elgg","owner":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elgg/Elgg","description":"A social networking engine in PHP/MySQL","fork":false,"url":"https://api.github.com/repos/Elgg/Elgg","forks_url":"https://api.github.com/repos/Elgg/Elgg/forks","keys_url":"https://api.github.com/repos/Elgg/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elgg/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elgg/Elgg/teams","hooks_url":"https://api.github.com/repos/Elgg/Elgg/hooks","issue_events_url":"https://api.github.com/repos/Elgg/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/Elgg/Elgg/events","assignees_url":"https://api.github.com/repos/Elgg/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/Elgg/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/Elgg/Elgg/tags","blobs_url":"https://api.github.com/repos/Elgg/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elgg/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elgg/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elgg/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/Elgg/Elgg/languages","stargazers_url":"https://api.github.com/repos/Elgg/Elgg/stargazers","contributors_url":"https://api.github.com/repos/Elgg/Elgg/contributors","subscribers_url":"https://api.github.com/repos/Elgg/Elgg/subscribers","subscription_url":"https://api.github.com/repos/Elgg/Elgg/subscription","commits_url":"https://api.github.com/repos/Elgg/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elgg/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elgg/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elgg/Elgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elgg/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/Elgg/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elgg/Elgg/merges","archive_url":"https://api.github.com/repos/Elgg/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elgg/Elgg/downloads","issues_url":"https://api.github.com/repos/Elgg/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/Elgg/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/Elgg/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/Elgg/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elgg/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/Elgg/Elgg/releases{/id}","deployments_url":"https://api.github.com/repos/Elgg/Elgg/deployments","created_at":"2009-09-06T17:10:11Z","updated_at":"2016-05-11T13:56:03Z","pushed_at":"2016-05-13T18:22:43Z","git_url":"git://github.com/Elgg/Elgg.git","ssh_url":"git@github.com:Elgg/Elgg.git","clone_url":"https://github.com/Elgg/Elgg.git","svn_url":"https://github.com/Elgg/Elgg","homepage":"http://elgg.org","size":84250,"stargazers_count":865,"watchers_count":865,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":null,"open_issues_count":801,"forks":504,"open_issues":801,"watchers":865,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8319"},"html":{"href":"https://github.com/Elgg/Elgg/pull/8319"},"issue":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8319"},"comments":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8319/comments"},"review_comments":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8319/comments"},"review_comment":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8319/commits"},"statuses":{"href":"https://api.github.com/repos/Elgg/Elgg/statuses/da49c5e52ec043d6074a945ee93c293cd9584c5c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":16,"commits":8,"additions":361,"deletions":196,"changed_files":18}}