{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/58887799","id":58887799,"diff_hunk":"@@ -88,7 +88,12 @@\n         var index;\n         var panel;\n \n-        item.split('.');\n+        item = item.split('.');\n+        if (item.length !== 3 || item[1] !== \"panel\" || item[2] !== \"active\") {\n+          // if this is a change to a scope in a different panel we should\n+          // not switch tabs\n+          return;\n+        }","path":"src/ggrc/assets/javascripts/components/tabs.js","position":10,"original_position":10,"commit_id":"828b73e8235c39921ea7dc554a9ee56b4c0e94ef","original_commit_id":"13c9084a669178d7985c0ed968accf65128d9a43","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"body":"To the best of my knowledge there are no tests covering the tab switcher component.","created_at":"2016-04-07T15:07:35Z","updated_at":"2016-04-07T15:07:35Z","html_url":"https://github.com/google/ggrc-core/pull/3734#discussion_r58887799","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/3734","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/58887799"},"html":{"href":"https://github.com/google/ggrc-core/pull/3734#discussion_r58887799"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3734"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/3734","id":65610608,"html_url":"https://github.com/google/ggrc-core/pull/3734","diff_url":"https://github.com/google/ggrc-core/pull/3734.diff","patch_url":"https://github.com/google/ggrc-core/pull/3734.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/3734","number":3734,"state":"open","locked":false,"title":"CORE-3382 show evidence in the change log","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"body":"This does two things:\r\n- enables fetching of indirect mappings (currently coded here, not exploring mappings.js)\r\n- enables indexing of `ObjectDocument` join objects","created_at":"2016-04-07T10:56:22Z","updated_at":"2016-04-07T15:07:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7381393a1378786a2e0fa43b68bda2e6820d0b0d","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/16","html_url":"https://github.com/google/ggrc-core/milestones/0.9.6-Plum%20Jelly","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/16/labels","id":1058061,"number":16,"title":"0.9.6-Plum Jelly","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":262,"state":"open","created_at":"2015-04-08T11:38:13Z","updated_at":"2016-04-07T13:17:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/3734/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/3734/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/3734/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/828b73e8235c39921ea7dc554a9ee56b4c0e94ef","head":{"label":"edofic:feature/CORE-3382-req-log-attachments","ref":"feature/CORE-3382-req-log-attachments","sha":"828b73e8235c39921ea7dc554a9ee56b4c0e94ef","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"repo":{"id":36659264,"name":"ggrc-core","full_name":"edofic/ggrc-core","owner":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edofic/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/edofic/ggrc-core","forks_url":"https://api.github.com/repos/edofic/ggrc-core/forks","keys_url":"https://api.github.com/repos/edofic/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edofic/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edofic/ggrc-core/teams","hooks_url":"https://api.github.com/repos/edofic/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/edofic/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/edofic/ggrc-core/events","assignees_url":"https://api.github.com/repos/edofic/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/edofic/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/edofic/ggrc-core/tags","blobs_url":"https://api.github.com/repos/edofic/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edofic/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edofic/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/edofic/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edofic/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/edofic/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/edofic/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/edofic/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/edofic/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/edofic/ggrc-core/subscription","commits_url":"https://api.github.com/repos/edofic/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/edofic/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/edofic/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/edofic/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/edofic/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/edofic/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edofic/ggrc-core/merges","archive_url":"https://api.github.com/repos/edofic/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edofic/ggrc-core/downloads","issues_url":"https://api.github.com/repos/edofic/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/edofic/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/edofic/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/edofic/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edofic/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/edofic/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/edofic/ggrc-core/deployments","created_at":"2015-06-01T12:28:36Z","updated_at":"2016-01-12T09:58:54Z","pushed_at":"2016-04-07T15:07:18Z","git_url":"git://github.com/edofic/ggrc-core.git","ssh_url":"git@github.com:edofic/ggrc-core.git","clone_url":"https://github.com/edofic/ggrc-core.git","svn_url":"https://github.com/edofic/ggrc-core","homepage":null,"size":50686,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"86b775a9af4d05b8d9c18788fd9ae0952cf9f2d1","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-04-05T14:33:43Z","pushed_at":"2016-04-07T15:07:18Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":57918,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":22,"forks":53,"open_issues":22,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3734"},"html":{"href":"https://github.com/google/ggrc-core/pull/3734"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3734"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3734/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3734/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3734/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/828b73e8235c39921ea7dc554a9ee56b4c0e94ef"}}}}