{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/76001294","id":76001294,"diff_hunk":"@@ -75,7 +76,11 @@ def _get_delivery_methods(self):\n         # Following loop is done to avoid displaying delivery methods who are not available for this order\n         # This can surely be done in a more efficient way, but at the moment, it mimics the way it's\n         # done in delivery_set method of sale.py, from delivery module\n-        carrier_ids = DeliveryCarrier.sudo().search(\n+        user = request.env.user\n+        if user.has_group('base.group_website_publisher') and user.has_group('sales_team.group_sale_manager'):\n+            carrier_ids = DeliveryCarrier.search([]).ids","path":"addons/website_sale_delivery/models/sale_order.py","position":15,"original_position":15,"commit_id":"4692d331b36d8b53fd371efbd234e6ed96a87eb8","original_commit_id":"4692d331b36d8b53fd371efbd234e6ed96a87eb8","user":{"login":"rop-odoo","id":10609000,"avatar_url":"https://avatars.githubusercontent.com/u/10609000?v=3","gravatar_id":"","url":"https://api.github.com/users/rop-odoo","html_url":"https://github.com/rop-odoo","followers_url":"https://api.github.com/users/rop-odoo/followers","following_url":"https://api.github.com/users/rop-odoo/following{/other_user}","gists_url":"https://api.github.com/users/rop-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/rop-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rop-odoo/subscriptions","organizations_url":"https://api.github.com/users/rop-odoo/orgs","repos_url":"https://api.github.com/users/rop-odoo/repos","events_url":"https://api.github.com/users/rop-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/rop-odoo/received_events","type":"User","site_admin":false},"body":"@rim-odoo  sales_team.group_sale_manager has already rights of manager for delivery.carrier https://github.com/odoo/odoo/blob/master/addons/delivery/security/ir.model.access.csv#L4  so, not use sudo()","created_at":"2016-08-24T06:33:56Z","updated_at":"2016-08-24T06:33:56Z","html_url":"https://github.com/odoo/odoo/pull/12707#discussion_r76001294","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/12707","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/76001294"},"html":{"href":"https://github.com/odoo/odoo/pull/12707#discussion_r76001294"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12707"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/12707","id":76543492,"html_url":"https://github.com/odoo/odoo/pull/12707","diff_url":"https://github.com/odoo/odoo/pull/12707.diff","patch_url":"https://github.com/odoo/odoo/pull/12707.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/12707","number":12707,"state":"open","locked":false,"title":"[Delivery Methods] Simplify the process for front-end","user":{"login":"rop-odoo","id":10609000,"avatar_url":"https://avatars.githubusercontent.com/u/10609000?v=3","gravatar_id":"","url":"https://api.github.com/users/rop-odoo","html_url":"https://github.com/rop-odoo","followers_url":"https://api.github.com/users/rop-odoo/followers","following_url":"https://api.github.com/users/rop-odoo/following{/other_user}","gists_url":"https://api.github.com/users/rop-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/rop-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rop-odoo/subscriptions","organizations_url":"https://api.github.com/users/rop-odoo/orgs","repos_url":"https://api.github.com/users/rop-odoo/repos","events_url":"https://api.github.com/users/rop-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/rop-odoo/received_events","type":"User","site_admin":false},"body":"Task: https://www.odoo.com/web?#id=21267&view_type=form&model=project.task&action=327&menu_id=4720\r\nPad: https://pad.odoo.com/p/r.03fe4aa4f94d445866359f1ee770a20e\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2016-07-07T06:09:10Z","updated_at":"2016-08-24T06:33:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a40aac38fb80068bd5ee71636c2b1b78811d917","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/12707/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/12707/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/12707/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/4692d331b36d8b53fd371efbd234e6ed96a87eb8","head":{"label":"odoo-dev:master-website-sale-delivery-method-rop","ref":"master-website-sale-delivery-method-rop","sha":"4692d331b36d8b53fd371efbd234e6ed96a87eb8","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2016-07-08T06:06:40Z","pushed_at":"2016-08-24T05:31:51Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":3671064,"stargazers_count":70,"watchers_count":70,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":0,"forks":28,"open_issues":0,"watchers":70,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"2adae8ff0f530ce219570bd27610561b42dbc55a","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2016-08-24T05:32:10Z","pushed_at":"2016-08-24T05:31:57Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1857055,"stargazers_count":4866,"watchers_count":4866,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4645,"mirror_url":null,"open_issues_count":3200,"forks":4645,"open_issues":3200,"watchers":4866,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12707"},"html":{"href":"https://github.com/odoo/odoo/pull/12707"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/12707"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/12707/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12707/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12707/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/4692d331b36d8b53fd371efbd234e6ed96a87eb8"}}}}
{"actor":{"display_login":"rop-odoo"}}