{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/65937580","id":65937580,"diff_hunk":"@@ -79,72 +79,72 @@\n       <div id=\"mainContainer\">\n         <div class=\"findbar hidden doorHanger hiddenSmallView\" id=\"findbar\">\n           <label for=\"findInput\" class=\"toolbarLabel\" data-l10n-id=\"find_label\">Find:</label>\n-          <input id=\"findInput\" class=\"toolbarField\" tabindex=\"91\">\n+          <input id=\"findInput\" class=\"toolbarField\">\n           <div class=\"splitToolbarButton\">\n-            <button class=\"toolbarButton findPrevious\" title=\"\" id=\"findPrevious\" tabindex=\"92\" data-l10n-id=\"find_previous\">\n+            <button class=\"toolbarButton findPrevious\" title=\"\" id=\"findPrevious\" data-l10n-id=\"find_previous\">\n               <span data-l10n-id=\"find_previous_label\">Previous</span>\n             </button>\n             <div class=\"splitToolbarButtonSeparator\"></div>\n-            <button class=\"toolbarButton findNext\" title=\"\" id=\"findNext\" tabindex=\"93\" data-l10n-id=\"find_next\">\n+            <button class=\"toolbarButton findNext\" title=\"\" id=\"findNext\" data-l10n-id=\"find_next\">\n               <span data-l10n-id=\"find_next_label\">Next</span>\n             </button>\n           </div>\n           <input type=\"checkbox\" id=\"findHighlightAll\" class=\"toolbarField\">\n-          <label for=\"findHighlightAll\" class=\"toolbarLabel\" tabindex=\"94\" data-l10n-id=\"find_highlight\">Highlight all</label>\n+          <label for=\"findHighlightAll\" class=\"toolbarLabel\" tabindex=\"0\" data-l10n-id=\"find_highlight\">Highlight all</label>","path":"lms/templates/pdf_viewer.html","position":43,"original_position":43,"commit_id":"7b99d332e716b7d2ce6deb96b94bb1e06f0a056d","original_commit_id":"7b99d332e716b7d2ce6deb96b94bb1e06f0a056d","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"Labels that are properly identified by their input counterparts don't need `tabindex`. Let's remove this one.","created_at":"2016-06-06T18:00:33Z","updated_at":"2016-06-06T18:00:33Z","html_url":"https://github.com/edx/edx-platform/pull/12656#discussion_r65937580","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12656","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/65937580"},"html":{"href":"https://github.com/edx/edx-platform/pull/12656#discussion_r65937580"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12656"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12656","id":72561541,"html_url":"https://github.com/edx/edx-platform/pull/12656","diff_url":"https://github.com/edx/edx-platform/pull/12656.diff","patch_url":"https://github.com/edx/edx-platform/pull/12656.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12656","number":12656,"state":"open","locked":false,"title":"Removing instances of positive integer tab index values","user":{"login":"ssemenova","id":6182097,"avatar_url":"https://avatars.githubusercontent.com/u/6182097?v=3","gravatar_id":"","url":"https://api.github.com/users/ssemenova","html_url":"https://github.com/ssemenova","followers_url":"https://api.github.com/users/ssemenova/followers","following_url":"https://api.github.com/users/ssemenova/following{/other_user}","gists_url":"https://api.github.com/users/ssemenova/gists{/gist_id}","starred_url":"https://api.github.com/users/ssemenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssemenova/subscriptions","organizations_url":"https://api.github.com/users/ssemenova/orgs","repos_url":"https://api.github.com/users/ssemenova/repos","events_url":"https://api.github.com/users/ssemenova/events{/privacy}","received_events_url":"https://api.github.com/users/ssemenova/received_events","type":"User","site_admin":false},"body":"I'm not sure if I've deleted the right values and replaced them correctly, but here's what I did:\r\n\r\nThere weren't that many cases of positive values, only in 4 files. For those 4 files, I deleted every tabindex that was in a button, form input, or otherwise natively focusable element. I replaced the tab index value with 0 if it wasn't natively focusable but seemed like it might need to be focused, but that's something that needs to be double-checked.\r\n\r\nThe Jira ticket includes making a test for the new changes, but we talked about potential ways we could make those tests - I just wanted to show what I had already so it was clear what needed to be tested.","created_at":"2016-06-03T19:58:12Z","updated_at":"2016-06-06T18:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f6eda255e90d4a826fe52474475ed731891d97d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12656/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12656/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12656/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/7b99d332e716b7d2ce6deb96b94bb1e06f0a056d","head":{"label":"edx:ssemenova/tabindex","ref":"ssemenova/tabindex","sha":"7b99d332e716b7d2ce6deb96b94bb1e06f0a056d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-06T16:16:54Z","pushed_at":"2016-06-06T17:59:35Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":764761,"stargazers_count":2605,"watchers_count":2605,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1585,"mirror_url":null,"open_issues_count":179,"forks":1585,"open_issues":179,"watchers":2605,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"4b25766aedd5960d60ef8a5e0e028a23d707765e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-06T16:16:54Z","pushed_at":"2016-06-06T17:59:35Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":764761,"stargazers_count":2605,"watchers_count":2605,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1585,"mirror_url":null,"open_issues_count":179,"forks":1585,"open_issues":179,"watchers":2605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12656"},"html":{"href":"https://github.com/edx/edx-platform/pull/12656"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12656"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12656/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12656/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12656/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/7b99d332e716b7d2ce6deb96b94bb1e06f0a056d"}}}}
{"actor":{"display_login":"clrux"}}