{"action":"created","issue":{"url":"https://api.github.com/repos/volkanceylan/Serenity/issues/1237","repository_url":"https://api.github.com/repos/volkanceylan/Serenity","labels_url":"https://api.github.com/repos/volkanceylan/Serenity/issues/1237/labels{/name}","comments_url":"https://api.github.com/repos/volkanceylan/Serenity/issues/1237/comments","events_url":"https://api.github.com/repos/volkanceylan/Serenity/issues/1237/events","html_url":"https://github.com/volkanceylan/Serenity/pull/1237","id":179322411,"number":1237,"title":"InnerJoin","user":{"login":"marcobisio","id":17425690,"avatar_url":"https://avatars.githubusercontent.com/u/17425690?v=3","gravatar_id":"","url":"https://api.github.com/users/marcobisio","html_url":"https://github.com/marcobisio","followers_url":"https://api.github.com/users/marcobisio/followers","following_url":"https://api.github.com/users/marcobisio/following{/other_user}","gists_url":"https://api.github.com/users/marcobisio/gists{/gist_id}","starred_url":"https://api.github.com/users/marcobisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcobisio/subscriptions","organizations_url":"https://api.github.com/users/marcobisio/orgs","repos_url":"https://api.github.com/users/marcobisio/repos","events_url":"https://api.github.com/users/marcobisio/events{/privacy}","received_events_url":"https://api.github.com/users/marcobisio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-26T19:58:11Z","updated_at":"2016-09-26T20:04:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/volkanceylan/Serenity/pulls/1237","html_url":"https://github.com/volkanceylan/Serenity/pull/1237","diff_url":"https://github.com/volkanceylan/Serenity/pull/1237.diff","patch_url":"https://github.com/volkanceylan/Serenity/pull/1237.patch"},"body":"Dear @volkanceylan,\r\nthis is my first pull request so please be indulgent :D\r\nI added a new InnerJoinAttribute that can be used in the entity (row) class like the already existing LeftJoin one.\r\nAlso I've modified a bit the RowFieldsBase in order to handle such new attribute and in my project it's working fine...I've also verified the correctness of the executed query enabling the debug (log) in web.config.\r\n\r\nThank you very much\r\nBye"},"comment":{"url":"https://api.github.com/repos/volkanceylan/Serenity/issues/comments/249681294","html_url":"https://github.com/volkanceylan/Serenity/pull/1237#issuecomment-249681294","issue_url":"https://api.github.com/repos/volkanceylan/Serenity/issues/1237","id":249681294,"user":{"login":"volkanceylan","id":752470,"avatar_url":"https://avatars.githubusercontent.com/u/752470?v=3","gravatar_id":"","url":"https://api.github.com/users/volkanceylan","html_url":"https://github.com/volkanceylan","followers_url":"https://api.github.com/users/volkanceylan/followers","following_url":"https://api.github.com/users/volkanceylan/following{/other_user}","gists_url":"https://api.github.com/users/volkanceylan/gists{/gist_id}","starred_url":"https://api.github.com/users/volkanceylan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volkanceylan/subscriptions","organizations_url":"https://api.github.com/users/volkanceylan/orgs","repos_url":"https://api.github.com/users/volkanceylan/repos","events_url":"https://api.github.com/users/volkanceylan/events{/privacy}","received_events_url":"https://api.github.com/users/volkanceylan/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T20:04:15Z","updated_at":"2016-09-26T20:04:15Z","body":"Thanks @marcobisio. It looks fine. I'm just not sure why would you want to use inner join in a row? If somehow, a row doesn't match from right table, your row will get lost on listings and it might become hard to fix it. Anyway i might still merge it, if it doesn't break something."}}
{"actor":{"display_login":"volkanceylan"}}