{"action":"created","comment":{"url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/comments/77127200","id":77127200,"diff_hunk":"@@ -199,7 +270,11 @@ describe('Hapi server', () => {\n         }, (err) => {\n \n             expect(err).to.not.exist();\n-            expect(server.plugins['hapi-mongodb'].db.options.url).to.equal('mongodb://localhost:27017');\n+            const db = server.plugins['hapi-mongodb'].db;\n+            expect(db).to.be.instanceof(Mongodb.Db);\n+            expect(db.databaseName).to.equal('test');\n+            expect(db.topology.s.clonedOptions.host).to.equal('localhost');","path":"test/connection.js","position":93,"original_position":93,"commit_id":"49699dbcb5dd3482c6ec905f4035b392c8f31899","original_commit_id":"49699dbcb5dd3482c6ec905f4035b392c8f31899","user":{"login":"iamdoron","id":3956042,"avatar_url":"https://avatars.githubusercontent.com/u/3956042?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdoron","html_url":"https://github.com/iamdoron","followers_url":"https://api.github.com/users/iamdoron/followers","following_url":"https://api.github.com/users/iamdoron/following{/other_user}","gists_url":"https://api.github.com/users/iamdoron/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdoron/subscriptions","organizations_url":"https://api.github.com/users/iamdoron/orgs","repos_url":"https://api.github.com/users/iamdoron/repos","events_url":"https://api.github.com/users/iamdoron/events{/privacy}","received_events_url":"https://api.github.com/users/iamdoron/received_events","type":"User","site_admin":false},"body":"You are right.\r\nThe problem is that when using  `mongodb@2.1.20` or above\r\n```javascript\r\nexpect(server.plugins['hapi-mongodb'].db.options.url).to.equal('mongodb://localhost:27017');\r\n```\r\nDoesn't pass\r\n\r\nSo it might be a driver's internal too (it might also be a bug) - I will check that.\r\nWe can also just create a different test that fakes mongodb just to check the options are being passed correctly\r\n","created_at":"2016-09-01T07:41:01Z","updated_at":"2016-09-01T07:41:01Z","html_url":"https://github.com/Marsup/hapi-mongodb/pull/26#discussion_r77127200","pull_request_url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/comments/77127200"},"html":{"href":"https://github.com/Marsup/hapi-mongodb/pull/26#discussion_r77127200"},"pull_request":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26","id":82384745,"html_url":"https://github.com/Marsup/hapi-mongodb/pull/26","diff_url":"https://github.com/Marsup/hapi-mongodb/pull/26.diff","patch_url":"https://github.com/Marsup/hapi-mongodb/pull/26.patch","issue_url":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/26","number":26,"state":"open","locked":false,"title":"Don't log password & some minor changes","user":{"login":"iamdoron","id":3956042,"avatar_url":"https://avatars.githubusercontent.com/u/3956042?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdoron","html_url":"https://github.com/iamdoron","followers_url":"https://api.github.com/users/iamdoron/followers","following_url":"https://api.github.com/users/iamdoron/following{/other_user}","gists_url":"https://api.github.com/users/iamdoron/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdoron/subscriptions","organizations_url":"https://api.github.com/users/iamdoron/orgs","repos_url":"https://api.github.com/users/iamdoron/repos","events_url":"https://api.github.com/users/iamdoron/events{/privacy}","received_events_url":"https://api.github.com/users/iamdoron/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI think it's best if the password won't be logged on successful connection - at the beginning I thought I would introduce a new flag for it, but I believe it's a good practice that might be good to enforce. \r\n\r\nI also updated some packages and how the db object was tested to be exposed.","created_at":"2016-08-23T15:16:19Z","updated_at":"2016-09-01T07:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5e8f763db3693492c39cda34e4f94b08c231004","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/26/comments","statuses_url":"https://api.github.com/repos/Marsup/hapi-mongodb/statuses/49699dbcb5dd3482c6ec905f4035b392c8f31899","head":{"label":"iamdoron:master","ref":"master","sha":"49699dbcb5dd3482c6ec905f4035b392c8f31899","user":{"login":"iamdoron","id":3956042,"avatar_url":"https://avatars.githubusercontent.com/u/3956042?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdoron","html_url":"https://github.com/iamdoron","followers_url":"https://api.github.com/users/iamdoron/followers","following_url":"https://api.github.com/users/iamdoron/following{/other_user}","gists_url":"https://api.github.com/users/iamdoron/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdoron/subscriptions","organizations_url":"https://api.github.com/users/iamdoron/orgs","repos_url":"https://api.github.com/users/iamdoron/repos","events_url":"https://api.github.com/users/iamdoron/events{/privacy}","received_events_url":"https://api.github.com/users/iamdoron/received_events","type":"User","site_admin":false},"repo":{"id":66370070,"name":"hapi-mongodb","full_name":"iamdoron/hapi-mongodb","owner":{"login":"iamdoron","id":3956042,"avatar_url":"https://avatars.githubusercontent.com/u/3956042?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdoron","html_url":"https://github.com/iamdoron","followers_url":"https://api.github.com/users/iamdoron/followers","following_url":"https://api.github.com/users/iamdoron/following{/other_user}","gists_url":"https://api.github.com/users/iamdoron/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdoron/subscriptions","organizations_url":"https://api.github.com/users/iamdoron/orgs","repos_url":"https://api.github.com/users/iamdoron/repos","events_url":"https://api.github.com/users/iamdoron/events{/privacy}","received_events_url":"https://api.github.com/users/iamdoron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamdoron/hapi-mongodb","description":"A simple Hapi MongoDB connection plugin, accessing one or several connections pools through server or request properties","fork":true,"url":"https://api.github.com/repos/iamdoron/hapi-mongodb","forks_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/forks","keys_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/teams","hooks_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/hooks","issue_events_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/issues/events{/number}","events_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/events","assignees_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/assignees{/user}","branches_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/branches{/branch}","tags_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/tags","blobs_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/statuses/{sha}","languages_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/languages","stargazers_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/stargazers","contributors_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/contributors","subscribers_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/subscribers","subscription_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/subscription","commits_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/contents/{+path}","compare_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/merges","archive_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/downloads","issues_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/issues{/number}","pulls_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/pulls{/number}","milestones_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/milestones{/number}","notifications_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/labels{/name}","releases_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/releases{/id}","deployments_url":"https://api.github.com/repos/iamdoron/hapi-mongodb/deployments","created_at":"2016-08-23T13:37:12Z","updated_at":"2016-08-23T13:37:13Z","pushed_at":"2016-08-23T15:10:47Z","git_url":"git://github.com/iamdoron/hapi-mongodb.git","ssh_url":"git@github.com:iamdoron/hapi-mongodb.git","clone_url":"https://github.com/iamdoron/hapi-mongodb.git","svn_url":"https://github.com/iamdoron/hapi-mongodb","homepage":"","size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Marsup:master","ref":"master","sha":"d697e80ff5cb1bf6a3ec8daf4261f26fe646b70f","user":{"login":"Marsup","id":796194,"avatar_url":"https://avatars.githubusercontent.com/u/796194?v=3","gravatar_id":"","url":"https://api.github.com/users/Marsup","html_url":"https://github.com/Marsup","followers_url":"https://api.github.com/users/Marsup/followers","following_url":"https://api.github.com/users/Marsup/following{/other_user}","gists_url":"https://api.github.com/users/Marsup/gists{/gist_id}","starred_url":"https://api.github.com/users/Marsup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marsup/subscriptions","organizations_url":"https://api.github.com/users/Marsup/orgs","repos_url":"https://api.github.com/users/Marsup/repos","events_url":"https://api.github.com/users/Marsup/events{/privacy}","received_events_url":"https://api.github.com/users/Marsup/received_events","type":"User","site_admin":false},"repo":{"id":13773635,"name":"hapi-mongodb","full_name":"Marsup/hapi-mongodb","owner":{"login":"Marsup","id":796194,"avatar_url":"https://avatars.githubusercontent.com/u/796194?v=3","gravatar_id":"","url":"https://api.github.com/users/Marsup","html_url":"https://github.com/Marsup","followers_url":"https://api.github.com/users/Marsup/followers","following_url":"https://api.github.com/users/Marsup/following{/other_user}","gists_url":"https://api.github.com/users/Marsup/gists{/gist_id}","starred_url":"https://api.github.com/users/Marsup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marsup/subscriptions","organizations_url":"https://api.github.com/users/Marsup/orgs","repos_url":"https://api.github.com/users/Marsup/repos","events_url":"https://api.github.com/users/Marsup/events{/privacy}","received_events_url":"https://api.github.com/users/Marsup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Marsup/hapi-mongodb","description":"A simple Hapi MongoDB connection plugin, accessing one or several connections pools through server or request properties","fork":false,"url":"https://api.github.com/repos/Marsup/hapi-mongodb","forks_url":"https://api.github.com/repos/Marsup/hapi-mongodb/forks","keys_url":"https://api.github.com/repos/Marsup/hapi-mongodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Marsup/hapi-mongodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Marsup/hapi-mongodb/teams","hooks_url":"https://api.github.com/repos/Marsup/hapi-mongodb/hooks","issue_events_url":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/events{/number}","events_url":"https://api.github.com/repos/Marsup/hapi-mongodb/events","assignees_url":"https://api.github.com/repos/Marsup/hapi-mongodb/assignees{/user}","branches_url":"https://api.github.com/repos/Marsup/hapi-mongodb/branches{/branch}","tags_url":"https://api.github.com/repos/Marsup/hapi-mongodb/tags","blobs_url":"https://api.github.com/repos/Marsup/hapi-mongodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Marsup/hapi-mongodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Marsup/hapi-mongodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Marsup/hapi-mongodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Marsup/hapi-mongodb/statuses/{sha}","languages_url":"https://api.github.com/repos/Marsup/hapi-mongodb/languages","stargazers_url":"https://api.github.com/repos/Marsup/hapi-mongodb/stargazers","contributors_url":"https://api.github.com/repos/Marsup/hapi-mongodb/contributors","subscribers_url":"https://api.github.com/repos/Marsup/hapi-mongodb/subscribers","subscription_url":"https://api.github.com/repos/Marsup/hapi-mongodb/subscription","commits_url":"https://api.github.com/repos/Marsup/hapi-mongodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Marsup/hapi-mongodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Marsup/hapi-mongodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Marsup/hapi-mongodb/contents/{+path}","compare_url":"https://api.github.com/repos/Marsup/hapi-mongodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Marsup/hapi-mongodb/merges","archive_url":"https://api.github.com/repos/Marsup/hapi-mongodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Marsup/hapi-mongodb/downloads","issues_url":"https://api.github.com/repos/Marsup/hapi-mongodb/issues{/number}","pulls_url":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls{/number}","milestones_url":"https://api.github.com/repos/Marsup/hapi-mongodb/milestones{/number}","notifications_url":"https://api.github.com/repos/Marsup/hapi-mongodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Marsup/hapi-mongodb/labels{/name}","releases_url":"https://api.github.com/repos/Marsup/hapi-mongodb/releases{/id}","deployments_url":"https://api.github.com/repos/Marsup/hapi-mongodb/deployments","created_at":"2013-10-22T13:13:11Z","updated_at":"2016-08-08T12:58:48Z","pushed_at":"2016-08-23T15:16:19Z","git_url":"git://github.com/Marsup/hapi-mongodb.git","ssh_url":"git@github.com:Marsup/hapi-mongodb.git","clone_url":"https://github.com/Marsup/hapi-mongodb.git","svn_url":"https://github.com/Marsup/hapi-mongodb","homepage":"","size":38,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26"},"html":{"href":"https://github.com/Marsup/hapi-mongodb/pull/26"},"issue":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/26"},"comments":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Marsup/hapi-mongodb/statuses/49699dbcb5dd3482c6ec905f4035b392c8f31899"}}}}
{"actor":{"display_login":"iamdoron"}}