{"action":"opened","issue":{"url":"https://api.github.com/repos/neomake/neomake/issues/766","repository_url":"https://api.github.com/repos/neomake/neomake","labels_url":"https://api.github.com/repos/neomake/neomake/issues/766/labels{/name}","comments_url":"https://api.github.com/repos/neomake/neomake/issues/766/comments","events_url":"https://api.github.com/repos/neomake/neomake/issues/766/events","html_url":"https://github.com/neomake/neomake/issues/766","id":188992356,"number":766,"title":"postprocess: pass in jobinfo to callback","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-13T20:22:35Z","updated_at":"2016-11-13T20:22:35Z","closed_at":null,"body":"When writing some test, I thought that having the `jobinfo` would be nice to have in the `postprocess` callback.\r\n\r\n```diff\r\ndiff --git i/autoload/neomake.vim w/autoload/neomake.vim\r\nindex 350ca5e..3403b5d 100644\r\n--- i/autoload/neomake.vim\r\n+++ w/autoload/neomake.vim\r\n@@ -548,11 +548,13 @@ function! s:AddExprCallback(jobinfo) abort\r\n         let index += 1\r\n \r\n         if has_key(maker, 'postprocess')\r\n+            \"\"\" XXX: breaking change: previously there was only entry\r\n+            let entryinfo = {'entry': entry, 'jobinfo': a:jobinfo}\r\n             if list_modified\r\n-                call maker.postprocess(entry)\r\n+                call maker.postprocess(entryinfo)\r\n             else\r\n                 let before = copy(entry)\r\n-                call maker.postprocess(entry)\r\n+                call maker.postprocess(entryinfo)\r\n                 if entry != before\r\n                     let list_modified = 1\r\n                 endif\r\n```\r\n\r\nCan this be done in a backward compatible way?\r\nIt might be when using an extra argument: then you could catch the error about \"too many arguments\", but I think a dict is better to use here in general, and for future changes."}}
{"actor":{"display_login":"blueyed"}}