{"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/1330","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/1330/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/1330/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/1330/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/1330","id":194651842,"number":1330,"title":"Limit countries in enterprise sign up to those with states","user":{"login":"lin-d-hop","id":8669848,"avatar_url":"https://avatars.githubusercontent.com/u/8669848?v=3","gravatar_id":"","url":"https://api.github.com/users/lin-d-hop","html_url":"https://github.com/lin-d-hop","followers_url":"https://api.github.com/users/lin-d-hop/followers","following_url":"https://api.github.com/users/lin-d-hop/following{/other_user}","gists_url":"https://api.github.com/users/lin-d-hop/gists{/gist_id}","starred_url":"https://api.github.com/users/lin-d-hop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lin-d-hop/subscriptions","organizations_url":"https://api.github.com/users/lin-d-hop/orgs","repos_url":"https://api.github.com/users/lin-d-hop/repos","events_url":"https://api.github.com/users/lin-d-hop/events{/privacy}","received_events_url":"https://api.github.com/users/lin-d-hop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/milestones/7","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/milestone/7","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/milestones/7/labels","id":909777,"number":7,"title":"UK Current","description":"","creator":{"login":"pmackay","id":115115,"avatar_url":"https://avatars.githubusercontent.com/u/115115?v=3","gravatar_id":"","url":"https://api.github.com/users/pmackay","html_url":"https://github.com/pmackay","followers_url":"https://api.github.com/users/pmackay/followers","following_url":"https://api.github.com/users/pmackay/following{/other_user}","gists_url":"https://api.github.com/users/pmackay/gists{/gist_id}","starred_url":"https://api.github.com/users/pmackay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmackay/subscriptions","organizations_url":"https://api.github.com/users/pmackay/orgs","repos_url":"https://api.github.com/users/pmackay/repos","events_url":"https://api.github.com/users/pmackay/events{/privacy}","received_events_url":"https://api.github.com/users/pmackay/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":101,"state":"open","created_at":"2014-12-19T08:33:01Z","updated_at":"2016-12-09T17:52:48Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-12-09T17:26:03Z","updated_at":"2016-12-12T08:51:13Z","closed_at":null,"body":"In the enterprise sign up form State (or County in UK translation) a required field. However not all countries have states attached to them.\r\n\r\nIt is likely that many countries will have producers from multiple countries. But if a country has no states linked to it a user cannot sign up to this country. Therefore it would make sense to limit the countries displayed in the enterprise sign up drop down to those with states attached.\r\n\r\nIn fixing this issue it would be great if you could check that 'setting states' is clearly documented in the github wiki.\r\n\r\nNote on UK staging default is not set to UK. Would be good to fix this at the same time.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments/266373602","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/1330#issuecomment-266373602","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/1330","id":266373602,"user":{"login":"myriamboure","id":8135376,"avatar_url":"https://avatars.githubusercontent.com/u/8135376?v=3","gravatar_id":"","url":"https://api.github.com/users/myriamboure","html_url":"https://github.com/myriamboure","followers_url":"https://api.github.com/users/myriamboure/followers","following_url":"https://api.github.com/users/myriamboure/following{/other_user}","gists_url":"https://api.github.com/users/myriamboure/gists{/gist_id}","starred_url":"https://api.github.com/users/myriamboure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myriamboure/subscriptions","organizations_url":"https://api.github.com/users/myriamboure/orgs","repos_url":"https://api.github.com/users/myriamboure/repos","events_url":"https://api.github.com/users/myriamboure/events{/privacy}","received_events_url":"https://api.github.com/users/myriamboure/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T08:51:13Z","updated_at":"2016-12-12T08:51:13Z","body":"Ok, @Matt-Yorkley it seems to me that by default, all countries have the \"state required\" checkbox checked. So do you mean you would change that, say that by default the checkbox is unchecked and only when checkbox is checked the country is proposed in the list at registration?\r\nI'm just wondering if that wouldn't be more logical to add a checkbox saying \"active for the instance\" and if checked country is displayed if not not displayed, just thinking if we have more and more people setting up instances it's better if it is logical and not too much tweaked. I think we should leave the instance decide if they want this info to be compulsory or not for the user to fill in (state required or not), which won't be the case anymore. BUT if it's much simpler to do the tweak as long as we know it is fine :-)\r\n\r\nThen I would suggest to rename the filled then \"active for the instance\" and just say in the super admin guidebook that it is compulsory to set up an notion of a regional level that entreprises can associate to their profile and that users can search by.\r\nInstances are then free to have some autofill rule if they don't want to ask the user to fill it.\r\n\r\nFor France it's ok, I said we can find an equivalent of \"county\" for France. No ideal in terms of user friendliness, usually platforms don't ask that usually. But we kept this and we asked the \"departement\" (small region) in order to enable people to search for hubs around them by \"departement\". We can work later on having it filled in automatically as the departement is the first to figures of the postcode, so we'll make our cuisine out of it!"}}
{"actor":{"display_login":"myriamboure"}}