{"push_id":1320394193,"size":1,"distinct_size":1,"ref":"refs/heads/clear-tlsconfig-unix-socket","head":"dc9f5c2ca3cdf8fef5786a80a0a1b0e7c18d4420","before":"eec84aecbfe7c498650447bd16e80375247f7512","commits":[{"sha":"dc9f5c2ca3cdf8fef5786a80a0a1b0e7c18d4420","author":{"name":"Stephen J Day","email":"f612758db3805c4abe0d56243c03a33f3294af3f@docker.com"},"message":"client: pedantic checking of tlsconfig\n\nUnder the convoluted code path for the transport configuration,\nTLSConfig was being set even though the socket type is unix. This caused\nother code detecting the TLSConfig to assume https, rather than using\nthe http scheme. This led to a situation where if `DOCKER_CERT_PATH` is\nset, unix sockets start reverting to https. There is other odd behavior\nfrom go-connections that is also reproduced here.\n\nFor the most part, we try to reproduce the side-effecting behavior from\ngo-connections to retain the current docker behavior. This whole mess\nneeds to ripped out and fixed, as this pile spaghetti is unnacceptable.\n\nThis code is way to convoluted for an http client. We'll need to fix\nthis but the Go API will break to do it.\n\nSigned-off-by: Stephen J Day <stephen.day@docker.com>","distinct":true,"url":"https://api.github.com/repos/stevvooe/docker/commits/dc9f5c2ca3cdf8fef5786a80a0a1b0e7c18d4420"}]}
{"actor":{"display_login":"stevvooe"}}