{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/26729","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/26729/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/26729/comments","events_url":"https://api.github.com/repos/docker/docker/issues/26729/events","html_url":"https://github.com/docker/docker/issues/26729","id":177914580,"number":26729,"title":"Leftover PID file after host crash prevents docker service from recovering on Windows","user":{"login":"swernli","id":10567287,"avatar_url":"https://avatars.githubusercontent.com/u/10567287?v=3","gravatar_id":"","url":"https://api.github.com/users/swernli","html_url":"https://github.com/swernli","followers_url":"https://api.github.com/users/swernli/followers","following_url":"https://api.github.com/users/swernli/following{/other_user}","gists_url":"https://api.github.com/users/swernli/gists{/gist_id}","starred_url":"https://api.github.com/users/swernli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swernli/subscriptions","organizations_url":"https://api.github.com/users/swernli/orgs","repos_url":"https://api.github.com/users/swernli/repos","events_url":"https://api.github.com/users/swernli/events{/privacy}","received_events_url":"https://api.github.com/users/swernli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-19T22:26:13Z","updated_at":"2016-09-19T22:53:28Z","closed_at":null,"body":"Because the docker daemon will fail to start if the PID file it creates is already present, a Windows machine that is running docker as a service and crashes will fail to start the service when the machine starts back up again.  The daemon could do better by checking if a process with that PID still exists, or perhaps having the active daemon keep the file open and new daemon unconditionally attempt a delete that would fail if the file is already open.\r\n\r\n@jhowardmsft @jstarks "},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/248152378","html_url":"https://github.com/docker/docker/issues/26729#issuecomment-248152378","issue_url":"https://api.github.com/repos/docker/docker/issues/26729","id":248152378,"user":{"login":"darrenstahlmsft","id":14114019,"avatar_url":"https://avatars.githubusercontent.com/u/14114019?v=3","gravatar_id":"","url":"https://api.github.com/users/darrenstahlmsft","html_url":"https://github.com/darrenstahlmsft","followers_url":"https://api.github.com/users/darrenstahlmsft/followers","following_url":"https://api.github.com/users/darrenstahlmsft/following{/other_user}","gists_url":"https://api.github.com/users/darrenstahlmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/darrenstahlmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrenstahlmsft/subscriptions","organizations_url":"https://api.github.com/users/darrenstahlmsft/orgs","repos_url":"https://api.github.com/users/darrenstahlmsft/repos","events_url":"https://api.github.com/users/darrenstahlmsft/events{/privacy}","received_events_url":"https://api.github.com/users/darrenstahlmsft/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T22:53:28Z","updated_at":"2016-09-19T22:53:28Z","body":"The daemon currently checks if an existing process with the PID stored in the pidfile exists. I suspect what we saw in the test run is that a new process took the old daemon's PID. Maybe we should check if the process with the PID in the pidfile is a Docker Daemon. That change would be made to all platforms I suspect."}}
{"actor":{"display_login":"darrenstahlmsft"}}