{"push_id":1319618210,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"b0c3d2b1c31694c458177259182b95d304646302","before":"f98fb4e108e81fda0c3591252122264f861312f3","commits":[{"sha":"c5777528e25b761f9e3a73b4ddebd72e20f45e7b","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"lib.js: Add helper function for easily linking to email addresses\n\nThe lib.js file is riddled with small helper functions that makes the\ncode inside of the listview renderers neat and tidy.\n\nThis function in particular will be needed when we expose the email\naddress on the contacts table.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":true,"url":"https://api.github.com/repos/op5/ninja/commits/c5777528e25b761f9e3a73b4ddebd72e20f45e7b"},{"sha":"c5252e2f2dc55536998fd51965bc8c8b3798e8b9","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"cucumber/mock: Do not treat all fields ending with 's' as pluralized\n\nThe mocking library tries to be smart by assuming that everything that\nends with an 's' is plural instead of singular.\n\nI tried to mock the alias field, but it did not show up on any\nscreenshots. When debugging the ORMDriverNative, the alias column was\napparently being fed an array, because the part of our mocking library\nthat is used from Cucumber was a bit optimistic.\n\nI'm going ahead to leave a comment in the code. I'm all for better ideas\nto solving this code, but the only thing I can think of is to parse the\nORM structure files (which are written in PHP) and feed the data to this\nRuby script but.. I don't want to rewrite that part of our structures to\nmake a one-off error test case work again. If you find this commit\nmessage after reading that comment, we might have to look into it again\nthough.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":true,"url":"https://api.github.com/repos/op5/ninja/commits/c5252e2f2dc55536998fd51965bc8c8b3798e8b9"},{"sha":"11684fb8a2e4f70f7f327f33f5f9b9875cf78324","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"listview: Render the email field on the contacts table\n\nThe extinfo page shows a list of contacts. In previous versions, we\nprinted the contacts along with their email and pager information. Since\nwe switched to presenting the contacts through a listview, we lost the\nemail and pager fields along the way.\n\nThis fixes MON-9647\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":true,"url":"https://api.github.com/repos/op5/ninja/commits/11684fb8a2e4f70f7f327f33f5f9b9875cf78324"},{"sha":"03e42086b38ab6f44e80191d5f03a029e90baeec","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"listview: Order tables alphabetically in graphical filter builder\n\nWhile trying to reproduce an issue, by selecting the \"contacts\" table in\nthe graphical filter builder, it took time to find that particular\noption because the list was not ordered. Now it is.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":true,"url":"https://api.github.com/repos/op5/ninja/commits/03e42086b38ab6f44e80191d5f03a029e90baeec"},{"sha":"b0c3d2b1c31694c458177259182b95d304646302","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"Merge pull request #148 in MONITOR/ninja from bugfix/MON-9647-column-definition-for-contacts-in to master\n\n* commit '03e42086b38ab6f44e80191d5f03a029e90baeec':\n  listview: Order tables alphabetically in graphical filter builder\n  listview: Render the email field on the contacts table\n  cucumber/mock: Do not treat all fields ending with 's' as pluralized\n  lib.js: Add helper function for easily linking to email addresses","distinct":true,"url":"https://api.github.com/repos/op5/ninja/commits/b0c3d2b1c31694c458177259182b95d304646302"}]}
{"actor":{"display_login":"op5-ci-user"}}