{"action":"closed","issue":{"url":"https://api.github.com/repos/Versent/unicreds/issues/54","repository_url":"https://api.github.com/repos/Versent/unicreds","labels_url":"https://api.github.com/repos/Versent/unicreds/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/Versent/unicreds/issues/54/comments","events_url":"https://api.github.com/repos/Versent/unicreds/issues/54/events","html_url":"https://github.com/Versent/unicreds/issues/54","id":184375834,"number":54,"title":"[BUG] ListSecrets() and GetAllSecrets() returns only the first page","user":{"login":"afirth","id":1820656,"avatar_url":"https://avatars.githubusercontent.com/u/1820656?v=3","gravatar_id":"","url":"https://api.github.com/users/afirth","html_url":"https://github.com/afirth","followers_url":"https://api.github.com/users/afirth/followers","following_url":"https://api.github.com/users/afirth/following{/other_user}","gists_url":"https://api.github.com/users/afirth/gists{/gist_id}","starred_url":"https://api.github.com/users/afirth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afirth/subscriptions","organizations_url":"https://api.github.com/users/afirth/orgs","repos_url":"https://api.github.com/users/afirth/repos","events_url":"https://api.github.com/users/afirth/events{/privacy}","received_events_url":"https://api.github.com/users/afirth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Versent/unicreds/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-21T00:55:49Z","updated_at":"2016-10-23T19:57:33Z","closed_at":"2016-10-23T19:57:33Z","body":"If Table.scan would return more than 1MB, the result is paginated.\r\nLastEvaluatedKey is set and scan() could be called again, or ScanPages could be used.\r\nThis bug appears to exist [in credstash too](https://github.com/fugue/credstash/issues/109)\r\n\r\n[ListSecrets()](https://github.com/Versent/unicreds/blob/3c288d0714289b8b4286c4fc7c9c7f47bfa2a6c3/ds.go#L266)\r\n[GetAllSecrets()](https://github.com/Versent/unicreds/blob/3c288d0714289b8b4286c4fc7c9c7f47bfa2a6c3/ds.go#L302)\r\n[go docs](https://godoc.org/github.com/aws/aws-sdk-go/service/dynamodb#DynamoDB.Scan)\r\n[AWS docs](http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/QueryAndScan.html#Pagination)"}}
{"actor":{"display_login":"wolfeidau"}}