{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/77412477","id":77412477,"diff_hunk":"@@ -224,39 +247,65 @@ Test(add_contextual_data, test_import_with_valid_csv)\n             \"The context_info_db_is_indexed reports False after successful import&load operations.\");\n   fclose(fp);\n \n-  TestNVPair expected_nvpairs_selector1[2] =\n+  TestNVPair expected_nvpairs_selector1[] =","path":"modules/add-contextual-data/tests/test_context_info_db.c","position":58,"original_position":58,"commit_id":"e1e8b833e969b35d17fb2c18a14d8422d6075533","original_commit_id":"acea4c19007a75a87369f7f23f97e87337875d07","user":{"login":"MrAnno","id":3130044,"avatar_url":"https://avatars.githubusercontent.com/u/3130044?v=3","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"body":"@kvch Sorry, I thought you asked me to change the names of my _own_ tests.\r\n\r\nThese three `TestNVPair`s are introduced in 141fcb0b769092d9fab04ce2b7cd0a1b164533c8. I don't think that these should be changed since they contain meaningless values and are used exactly to test `selector1`, `selector2` and `selector3`.\r\n\r\nNevertheless, feel free to make a suggestion.","created_at":"2016-09-02T21:11:03Z","updated_at":"2016-09-02T21:11:03Z","html_url":"https://github.com/balabit/syslog-ng/pull/1184#discussion_r77412477","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/77412477"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1184#discussion_r77412477"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184"}}},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184","id":82866844,"html_url":"https://github.com/balabit/syslog-ng/pull/1184","diff_url":"https://github.com/balabit/syslog-ng/pull/1184.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/1184.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1184","number":1184,"state":"open","locked":false,"title":"Minor add-contextual-data fixes","user":{"login":"MrAnno","id":3130044,"avatar_url":"https://avatars.githubusercontent.com/u/3130044?v=3","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"body":"This PR\r\n- adds CRLF line ending support to add-contextual-data\r\n- sets the dialect of `CSVScanner` to [escape-double-char](https://www.balabit.com/sites/default/files/documents/syslog-ng-ose-latest-guides/en/syslog-ng-ose-guide-admin/html-single/index.html#reference-parsers-csv) in `ContextualDataRecordScanner` (as recorded in [RFC 4180](https://www.ietf.org/rfc/rfc4180.txt))\r\n\r\nFixes #1179 (Issue 1 and 3)\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/balabit/syslog-ng/1184)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-26T10:35:50Z","updated_at":"2016-09-02T21:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"882cca7846d034e9ff87e60b9eb43c7ae0102626","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1184/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/e1e8b833e969b35d17fb2c18a14d8422d6075533","head":{"label":"MrAnno:fix-kvtagger-rfc4180","ref":"fix-kvtagger-rfc4180","sha":"e1e8b833e969b35d17fb2c18a14d8422d6075533","user":{"login":"MrAnno","id":3130044,"avatar_url":"https://avatars.githubusercontent.com/u/3130044?v=3","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"repo":{"id":48989715,"name":"syslog-ng","full_name":"MrAnno/syslog-ng","owner":{"login":"MrAnno","id":3130044,"avatar_url":"https://avatars.githubusercontent.com/u/3130044?v=3","gravatar_id":"","url":"https://api.github.com/users/MrAnno","html_url":"https://github.com/MrAnno","followers_url":"https://api.github.com/users/MrAnno/followers","following_url":"https://api.github.com/users/MrAnno/following{/other_user}","gists_url":"https://api.github.com/users/MrAnno/gists{/gist_id}","starred_url":"https://api.github.com/users/MrAnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrAnno/subscriptions","organizations_url":"https://api.github.com/users/MrAnno/orgs","repos_url":"https://api.github.com/users/MrAnno/repos","events_url":"https://api.github.com/users/MrAnno/events{/privacy}","received_events_url":"https://api.github.com/users/MrAnno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrAnno/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/MrAnno/syslog-ng","forks_url":"https://api.github.com/repos/MrAnno/syslog-ng/forks","keys_url":"https://api.github.com/repos/MrAnno/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrAnno/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrAnno/syslog-ng/teams","hooks_url":"https://api.github.com/repos/MrAnno/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/MrAnno/syslog-ng/events","assignees_url":"https://api.github.com/repos/MrAnno/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/MrAnno/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/MrAnno/syslog-ng/tags","blobs_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrAnno/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/MrAnno/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/MrAnno/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/MrAnno/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/MrAnno/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/MrAnno/syslog-ng/subscription","commits_url":"https://api.github.com/repos/MrAnno/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrAnno/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrAnno/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrAnno/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/MrAnno/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrAnno/syslog-ng/merges","archive_url":"https://api.github.com/repos/MrAnno/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrAnno/syslog-ng/downloads","issues_url":"https://api.github.com/repos/MrAnno/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/MrAnno/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/MrAnno/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/MrAnno/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrAnno/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/MrAnno/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/MrAnno/syslog-ng/deployments","created_at":"2016-01-04T10:17:25Z","updated_at":"2016-08-12T07:54:13Z","pushed_at":"2016-09-02T14:57:08Z","git_url":"git://github.com/MrAnno/syslog-ng.git","ssh_url":"git@github.com:MrAnno/syslog-ng.git","clone_url":"https://github.com/MrAnno/syslog-ng.git","svn_url":"https://github.com/MrAnno/syslog-ng","homepage":"http://www.syslog-ng.org/","size":16409,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"9439db40c12928a97b06e219c1f63bc05e623685","user":{"login":"balabit","id":986981,"avatar_url":"https://avatars.githubusercontent.com/u/986981?v=3","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"name":"syslog-ng","full_name":"balabit/syslog-ng","owner":{"login":"balabit","id":986981,"avatar_url":"https://avatars.githubusercontent.com/u/986981?v=3","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2016-09-02T14:14:17Z","pushed_at":"2016-09-02T20:00:07Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":24373,"stargazers_count":349,"watchers_count":349,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":187,"forks":129,"open_issues":187,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1184"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1184"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1184/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1184/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/e1e8b833e969b35d17fb2c18a14d8422d6075533"}}}}
{"actor":{"display_login":"MrAnno"}}