{"action":"opened","number":2978,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978","id":57955704,"html_url":"https://github.com/Automattic/wp-calypso/pull/2978","diff_url":"https://github.com/Automattic/wp-calypso/pull/2978.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/2978.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/2978","number":2978,"state":"open","locked":false,"title":"i18k: reverse direction of some gridicons in RTL","user":{"login":"yoavf","id":844866,"avatar_url":"https://avatars.githubusercontent.com/u/844866?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavf","html_url":"https://github.com/yoavf","followers_url":"https://api.github.com/users/yoavf/followers","following_url":"https://api.github.com/users/yoavf/following{/other_user}","gists_url":"https://api.github.com/users/yoavf/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavf/subscriptions","organizations_url":"https://api.github.com/users/yoavf/orgs","repos_url":"https://api.github.com/users/yoavf/repos","events_url":"https://api.github.com/users/yoavf/events{/privacy}","received_events_url":"https://api.github.com/users/yoavf/received_events","type":"User","site_admin":false},"body":"Across the codebase, we're often using specific gridicons to emphasis directionality: for example, `chevron-right` to expand a compact card, or `arrow-left` for back links. In RTL, those icons needs to be reversed.\r\n\r\nThe best semantical solution would be to abstract the arrows into a direction aware component, and then make sure we use this component everywhere. However, I feel this would add too much complexity, and propose a workaround we've used before: reverse using css.\r\n\r\nThis fixes #1734, and also other various issues (see screenshots below) \r\n\r\n**Before patch**\r\n\r\nIssue in domains list compact card: \r\n<img width=\"804\" alt=\"screen shot 2016-02-02 at 10 06 50\" src=\"https://cloud.githubusercontent.com/assets/844866/12743820/0e3213da-c999-11e5-8118-db2a30b126ba.png\">\r\n\r\nIssue in domains back link: \r\n<img width=\"760\" alt=\"screen shot 2016-02-02 at 10 39 05\" src=\"https://cloud.githubusercontent.com/assets/844866/12743833/388b6a32-c999-11e5-8684-7aad3e4667f3.png\">\r\n\r\nIssue in editor back link:\r\n<img width=\"292\" alt=\"screen shot 2015-10-21 at 3 32 01 pm\" src=\"https://cloud.githubusercontent.com/assets/5835847/10649315/f421bab8-7808-11e5-9c0c-808cc13072d9.png\">\r\n\r\n**After patch:**\r\ndomains list compact card: \r\n<img width=\"791\" alt=\"screen shot 2016-02-02 at 10 06 29\" src=\"https://cloud.githubusercontent.com/assets/844866/12743874/842f23de-c999-11e5-8577-5207f58d0ae3.png\">\r\n\r\ndomains back link: \r\n<img width=\"758\" alt=\"screen shot 2016-02-02 at 10 41 40\" src=\"https://cloud.githubusercontent.com/assets/844866/12743885/9b654b00-c999-11e5-98ca-11ac2d358435.png\">\r\n\r\n\r\neditor back link:\r\n<img width=\"283\" alt=\"screen shot 2016-02-02 at 10 40 52\" src=\"https://cloud.githubusercontent.com/assets/844866/12743872/7a90c530-c999-11e5-9901-b1346d9dab48.png\">","created_at":"2016-02-02T08:44:22Z","updated_at":"2016-02-02T08:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"yoavf","id":844866,"avatar_url":"https://avatars.githubusercontent.com/u/844866?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavf","html_url":"https://github.com/yoavf","followers_url":"https://api.github.com/users/yoavf/followers","following_url":"https://api.github.com/users/yoavf/following{/other_user}","gists_url":"https://api.github.com/users/yoavf/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavf/subscriptions","organizations_url":"https://api.github.com/users/yoavf/orgs","repos_url":"https://api.github.com/users/yoavf/repos","events_url":"https://api.github.com/users/yoavf/events{/privacy}","received_events_url":"https://api.github.com/users/yoavf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/2978/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/114226359bfd326dfd89b10db4acb68d98a5d2df","head":{"label":"Automattic:fix/RTLGridicons","ref":"fix/RTLGridicons","sha":"114226359bfd326dfd89b10db4acb68d98a5d2df","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-02-02T01:18:18Z","pushed_at":"2016-02-02T08:31:13Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":53749,"stargazers_count":6721,"watchers_count":6721,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":755,"mirror_url":null,"open_issues_count":1205,"forks":755,"open_issues":1205,"watchers":6721,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"efa3b867527bca48257238f5d3f3891d8d4d0c99","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-02-02T01:18:18Z","pushed_at":"2016-02-02T08:31:13Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":53749,"stargazers_count":6721,"watchers_count":6721,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":755,"mirror_url":null,"open_issues_count":1205,"forks":755,"open_issues":1205,"watchers":6721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/2978"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/2978"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/2978/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2978/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/114226359bfd326dfd89b10db4acb68d98a5d2df"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":0,"changed_files":1}}