{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19218","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19218/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19218/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19218/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19218","id":188161778,"number":19218,"title":"Fix bugged cash cards","user":{"login":"sethsimon","id":16765166,"avatar_url":"https://avatars.githubusercontent.com/u/16765166?v=3","gravatar_id":"","url":"https://api.github.com/users/sethsimon","html_url":"https://github.com/sethsimon","followers_url":"https://api.github.com/users/sethsimon/followers","following_url":"https://api.github.com/users/sethsimon/following{/other_user}","gists_url":"https://api.github.com/users/sethsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/sethsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethsimon/subscriptions","organizations_url":"https://api.github.com/users/sethsimon/orgs","repos_url":"https://api.github.com/users/sethsimon/repos","events_url":"https://api.github.com/users/sethsimon/events{/privacy}","received_events_url":"https://api.github.com/users/sethsimon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-09T03:46:05Z","updated_at":"2016-11-12T02:34:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19218","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19218","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19218.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19218.patch"},"body":"Fixes #16885.\r\n\r\nThe first commit is a partial fix: `rand_charges` wasn't being read because its JSON entry wasn't within a `spawn_data` object/block. `islot_spawn` was marked with a `todo: deprecate`, so I did that and moved `rand_charges` to `islot_tool`.\r\n\r\nHowever, that only fixes part of the problem; 200,000,000 cash cards still appear for the reason that BevapDin cited in #16885. I could remove the `0` from all `rand_charges` entries, but if possible, I prefer a fix that allows items with no charges to spawn.\r\n\r\nI suspect that `Item_group::create` never needs to add ammo or magazines to any tools (it's taken care of by the call to `item::item` by `Single_item_creator::create_single`), but I'll have to look into that to make sure that it wouldn't break anything."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/260096274","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19218#issuecomment-260096274","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19218","id":260096274,"user":{"login":"sethsimon","id":16765166,"avatar_url":"https://avatars.githubusercontent.com/u/16765166?v=3","gravatar_id":"","url":"https://api.github.com/users/sethsimon","html_url":"https://github.com/sethsimon","followers_url":"https://api.github.com/users/sethsimon/followers","following_url":"https://api.github.com/users/sethsimon/following{/other_user}","gists_url":"https://api.github.com/users/sethsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/sethsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethsimon/subscriptions","organizations_url":"https://api.github.com/users/sethsimon/orgs","repos_url":"https://api.github.com/users/sethsimon/repos","events_url":"https://api.github.com/users/sethsimon/events{/privacy}","received_events_url":"https://api.github.com/users/sethsimon/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T02:34:03Z","updated_at":"2016-11-12T02:34:03Z","body":"This is ready."}}
{"actor":{"display_login":"sethsimon"}}