{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/kakaroto/SWParser/pulls/32","id":58530288,"html_url":"https://github.com/kakaroto/SWParser/pull/32","diff_url":"https://github.com/kakaroto/SWParser/pull/32.diff","patch_url":"https://github.com/kakaroto/SWParser/pull/32.patch","issue_url":"https://api.github.com/repos/kakaroto/SWParser/issues/32","number":32,"state":"closed","locked":false,"title":"SWProxy.py structural cleanups + Readability improvements","user":{"login":"azrethos","id":17094863,"avatar_url":"https://avatars.githubusercontent.com/u/17094863?v=3","gravatar_id":"","url":"https://api.github.com/users/azrethos","html_url":"https://github.com/azrethos","followers_url":"https://api.github.com/users/azrethos/followers","following_url":"https://api.github.com/users/azrethos/following{/other_user}","gists_url":"https://api.github.com/users/azrethos/gists{/gist_id}","starred_url":"https://api.github.com/users/azrethos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azrethos/subscriptions","organizations_url":"https://api.github.com/users/azrethos/orgs","repos_url":"https://api.github.com/users/azrethos/repos","events_url":"https://api.github.com/users/azrethos/events{/privacy}","received_events_url":"https://api.github.com/users/azrethos/received_events","type":"User","site_admin":false},"body":"I moved the python requirements into a standard requirements.txt\r\n\r\nAlso helped make the SWProxy.py code a bit more structured and readable, let me know what you think. I am a big fan of abstracting away complex conditions into lambdas so the implementation code can look much cleaner.\r\n\r\nAlso added an optional debug flag to get more verbose logging. I'm for converting the args options into argparse. Also, do you want me to move the 3 main SWParser blocks into plugins? (visit friend, runes, etc)","created_at":"2016-02-06T21:04:47Z","updated_at":"2016-02-06T23:41:19Z","closed_at":"2016-02-06T23:41:19Z","merged_at":null,"merge_commit_sha":"15c0843b9ceb777caa462831fdf3a3725a7a161e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kakaroto/SWParser/pulls/32/commits","review_comments_url":"https://api.github.com/repos/kakaroto/SWParser/pulls/32/comments","review_comment_url":"https://api.github.com/repos/kakaroto/SWParser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kakaroto/SWParser/issues/32/comments","statuses_url":"https://api.github.com/repos/kakaroto/SWParser/statuses/5deb923978894f81d52afa42028839436f6a6959","head":{"label":"azrethos:master","ref":"master","sha":"5deb923978894f81d52afa42028839436f6a6959","user":{"login":"azrethos","id":17094863,"avatar_url":"https://avatars.githubusercontent.com/u/17094863?v=3","gravatar_id":"","url":"https://api.github.com/users/azrethos","html_url":"https://github.com/azrethos","followers_url":"https://api.github.com/users/azrethos/followers","following_url":"https://api.github.com/users/azrethos/following{/other_user}","gists_url":"https://api.github.com/users/azrethos/gists{/gist_id}","starred_url":"https://api.github.com/users/azrethos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azrethos/subscriptions","organizations_url":"https://api.github.com/users/azrethos/orgs","repos_url":"https://api.github.com/users/azrethos/repos","events_url":"https://api.github.com/users/azrethos/events{/privacy}","received_events_url":"https://api.github.com/users/azrethos/received_events","type":"User","site_admin":false},"repo":{"id":51193819,"name":"SWParser","full_name":"azrethos/SWParser","owner":{"login":"azrethos","id":17094863,"avatar_url":"https://avatars.githubusercontent.com/u/17094863?v=3","gravatar_id":"","url":"https://api.github.com/users/azrethos","html_url":"https://github.com/azrethos","followers_url":"https://api.github.com/users/azrethos/followers","following_url":"https://api.github.com/users/azrethos/following{/other_user}","gists_url":"https://api.github.com/users/azrethos/gists{/gist_id}","starred_url":"https://api.github.com/users/azrethos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azrethos/subscriptions","organizations_url":"https://api.github.com/users/azrethos/orgs","repos_url":"https://api.github.com/users/azrethos/repos","events_url":"https://api.github.com/users/azrethos/events{/privacy}","received_events_url":"https://api.github.com/users/azrethos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azrethos/SWParser","description":"Summoners War Data Extractor and Parser","fork":true,"url":"https://api.github.com/repos/azrethos/SWParser","forks_url":"https://api.github.com/repos/azrethos/SWParser/forks","keys_url":"https://api.github.com/repos/azrethos/SWParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azrethos/SWParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azrethos/SWParser/teams","hooks_url":"https://api.github.com/repos/azrethos/SWParser/hooks","issue_events_url":"https://api.github.com/repos/azrethos/SWParser/issues/events{/number}","events_url":"https://api.github.com/repos/azrethos/SWParser/events","assignees_url":"https://api.github.com/repos/azrethos/SWParser/assignees{/user}","branches_url":"https://api.github.com/repos/azrethos/SWParser/branches{/branch}","tags_url":"https://api.github.com/repos/azrethos/SWParser/tags","blobs_url":"https://api.github.com/repos/azrethos/SWParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azrethos/SWParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azrethos/SWParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/azrethos/SWParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azrethos/SWParser/statuses/{sha}","languages_url":"https://api.github.com/repos/azrethos/SWParser/languages","stargazers_url":"https://api.github.com/repos/azrethos/SWParser/stargazers","contributors_url":"https://api.github.com/repos/azrethos/SWParser/contributors","subscribers_url":"https://api.github.com/repos/azrethos/SWParser/subscribers","subscription_url":"https://api.github.com/repos/azrethos/SWParser/subscription","commits_url":"https://api.github.com/repos/azrethos/SWParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/azrethos/SWParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/azrethos/SWParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/azrethos/SWParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/azrethos/SWParser/contents/{+path}","compare_url":"https://api.github.com/repos/azrethos/SWParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azrethos/SWParser/merges","archive_url":"https://api.github.com/repos/azrethos/SWParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azrethos/SWParser/downloads","issues_url":"https://api.github.com/repos/azrethos/SWParser/issues{/number}","pulls_url":"https://api.github.com/repos/azrethos/SWParser/pulls{/number}","milestones_url":"https://api.github.com/repos/azrethos/SWParser/milestones{/number}","notifications_url":"https://api.github.com/repos/azrethos/SWParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azrethos/SWParser/labels{/name}","releases_url":"https://api.github.com/repos/azrethos/SWParser/releases{/id}","deployments_url":"https://api.github.com/repos/azrethos/SWParser/deployments","created_at":"2016-02-06T07:27:09Z","updated_at":"2016-02-06T07:27:11Z","pushed_at":"2016-02-06T21:01:40Z","git_url":"git://github.com/azrethos/SWParser.git","ssh_url":"git@github.com:azrethos/SWParser.git","clone_url":"https://github.com/azrethos/SWParser.git","svn_url":"https://github.com/azrethos/SWParser","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kakaroto:master","ref":"master","sha":"b35c48a37cdb858bf717816c99f069bf85e6d145","user":{"login":"kakaroto","id":27990,"avatar_url":"https://avatars.githubusercontent.com/u/27990?v=3","gravatar_id":"","url":"https://api.github.com/users/kakaroto","html_url":"https://github.com/kakaroto","followers_url":"https://api.github.com/users/kakaroto/followers","following_url":"https://api.github.com/users/kakaroto/following{/other_user}","gists_url":"https://api.github.com/users/kakaroto/gists{/gist_id}","starred_url":"https://api.github.com/users/kakaroto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakaroto/subscriptions","organizations_url":"https://api.github.com/users/kakaroto/orgs","repos_url":"https://api.github.com/users/kakaroto/repos","events_url":"https://api.github.com/users/kakaroto/events{/privacy}","received_events_url":"https://api.github.com/users/kakaroto/received_events","type":"User","site_admin":false},"repo":{"id":48861543,"name":"SWParser","full_name":"kakaroto/SWParser","owner":{"login":"kakaroto","id":27990,"avatar_url":"https://avatars.githubusercontent.com/u/27990?v=3","gravatar_id":"","url":"https://api.github.com/users/kakaroto","html_url":"https://github.com/kakaroto","followers_url":"https://api.github.com/users/kakaroto/followers","following_url":"https://api.github.com/users/kakaroto/following{/other_user}","gists_url":"https://api.github.com/users/kakaroto/gists{/gist_id}","starred_url":"https://api.github.com/users/kakaroto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakaroto/subscriptions","organizations_url":"https://api.github.com/users/kakaroto/orgs","repos_url":"https://api.github.com/users/kakaroto/repos","events_url":"https://api.github.com/users/kakaroto/events{/privacy}","received_events_url":"https://api.github.com/users/kakaroto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kakaroto/SWParser","description":"Summoners War Data Extractor and Parser","fork":false,"url":"https://api.github.com/repos/kakaroto/SWParser","forks_url":"https://api.github.com/repos/kakaroto/SWParser/forks","keys_url":"https://api.github.com/repos/kakaroto/SWParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kakaroto/SWParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kakaroto/SWParser/teams","hooks_url":"https://api.github.com/repos/kakaroto/SWParser/hooks","issue_events_url":"https://api.github.com/repos/kakaroto/SWParser/issues/events{/number}","events_url":"https://api.github.com/repos/kakaroto/SWParser/events","assignees_url":"https://api.github.com/repos/kakaroto/SWParser/assignees{/user}","branches_url":"https://api.github.com/repos/kakaroto/SWParser/branches{/branch}","tags_url":"https://api.github.com/repos/kakaroto/SWParser/tags","blobs_url":"https://api.github.com/repos/kakaroto/SWParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kakaroto/SWParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kakaroto/SWParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/kakaroto/SWParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kakaroto/SWParser/statuses/{sha}","languages_url":"https://api.github.com/repos/kakaroto/SWParser/languages","stargazers_url":"https://api.github.com/repos/kakaroto/SWParser/stargazers","contributors_url":"https://api.github.com/repos/kakaroto/SWParser/contributors","subscribers_url":"https://api.github.com/repos/kakaroto/SWParser/subscribers","subscription_url":"https://api.github.com/repos/kakaroto/SWParser/subscription","commits_url":"https://api.github.com/repos/kakaroto/SWParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/kakaroto/SWParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/kakaroto/SWParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/kakaroto/SWParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/kakaroto/SWParser/contents/{+path}","compare_url":"https://api.github.com/repos/kakaroto/SWParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kakaroto/SWParser/merges","archive_url":"https://api.github.com/repos/kakaroto/SWParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kakaroto/SWParser/downloads","issues_url":"https://api.github.com/repos/kakaroto/SWParser/issues{/number}","pulls_url":"https://api.github.com/repos/kakaroto/SWParser/pulls{/number}","milestones_url":"https://api.github.com/repos/kakaroto/SWParser/milestones{/number}","notifications_url":"https://api.github.com/repos/kakaroto/SWParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kakaroto/SWParser/labels{/name}","releases_url":"https://api.github.com/repos/kakaroto/SWParser/releases{/id}","deployments_url":"https://api.github.com/repos/kakaroto/SWParser/deployments","created_at":"2015-12-31T20:30:55Z","updated_at":"2016-02-03T23:09:38Z","pushed_at":"2016-02-06T21:04:47Z","git_url":"git://github.com/kakaroto/SWParser.git","ssh_url":"git@github.com:kakaroto/SWParser.git","clone_url":"https://github.com/kakaroto/SWParser.git","svn_url":"https://github.com/kakaroto/SWParser","homepage":null,"size":143,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kakaroto/SWParser/pulls/32"},"html":{"href":"https://github.com/kakaroto/SWParser/pull/32"},"issue":{"href":"https://api.github.com/repos/kakaroto/SWParser/issues/32"},"comments":{"href":"https://api.github.com/repos/kakaroto/SWParser/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/kakaroto/SWParser/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/kakaroto/SWParser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kakaroto/SWParser/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/kakaroto/SWParser/statuses/5deb923978894f81d52afa42028839436f6a6959"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":128,"deletions":42,"changed_files":3}}