{"action":"created","issue":{"url":"https://api.github.com/repos/uwiger/setup/issues/29","repository_url":"https://api.github.com/repos/uwiger/setup","labels_url":"https://api.github.com/repos/uwiger/setup/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/uwiger/setup/issues/29/comments","events_url":"https://api.github.com/repos/uwiger/setup/issues/29/events","html_url":"https://github.com/uwiger/setup/issues/29","id":155444440,"number":29,"title":"stop_when_done = true always triggers timeout","user":{"login":"meike-hecker","id":6086492,"avatar_url":"https://avatars.githubusercontent.com/u/6086492?v=3","gravatar_id":"","url":"https://api.github.com/users/meike-hecker","html_url":"https://github.com/meike-hecker","followers_url":"https://api.github.com/users/meike-hecker/followers","following_url":"https://api.github.com/users/meike-hecker/following{/other_user}","gists_url":"https://api.github.com/users/meike-hecker/gists{/gist_id}","starred_url":"https://api.github.com/users/meike-hecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meike-hecker/subscriptions","organizations_url":"https://api.github.com/users/meike-hecker/orgs","repos_url":"https://api.github.com/users/meike-hecker/repos","events_url":"https://api.github.com/users/meike-hecker/events{/privacy}","received_events_url":"https://api.github.com/users/meike-hecker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-18T08:31:23Z","updated_at":"2016-05-19T07:39:30Z","closed_at":null,"body":"In setup_srv:run_setup/0 gen_server call has default timeout of 5 sec. At the end of setup:run_setup/0 in case of stop_when_done=true process sleeps for 5 seconds which leads to a timeout in setup_srv in any case and I guess next line to stop system gracefully will never be called.\r\nMy intention to use setup was to do some mnesia table preparation and some other stuff which might take much longer than 5 seconds.\r\nI would do the timeout configurable to allow time consuming setup steps.\r\nhttps://github.com/meike-hecker/setup/commit/aefeb8ebbcdcc1174b01515ca2aafa4304391532\r\nI am also not sure the sleep really makes sense here."},"comment":{"url":"https://api.github.com/repos/uwiger/setup/issues/comments/220250070","html_url":"https://github.com/uwiger/setup/issues/29#issuecomment-220250070","issue_url":"https://api.github.com/repos/uwiger/setup/issues/29","id":220250070,"user":{"login":"uwiger","id":160216,"avatar_url":"https://avatars.githubusercontent.com/u/160216?v=3","gravatar_id":"","url":"https://api.github.com/users/uwiger","html_url":"https://github.com/uwiger","followers_url":"https://api.github.com/users/uwiger/followers","following_url":"https://api.github.com/users/uwiger/following{/other_user}","gists_url":"https://api.github.com/users/uwiger/gists{/gist_id}","starred_url":"https://api.github.com/users/uwiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwiger/subscriptions","organizations_url":"https://api.github.com/users/uwiger/orgs","repos_url":"https://api.github.com/users/uwiger/repos","events_url":"https://api.github.com/users/uwiger/events{/privacy}","received_events_url":"https://api.github.com/users/uwiger/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T07:39:30Z","updated_at":"2016-05-19T07:39:30Z","body":"The timeout error was an unintended consequence of introducing an OTP-style start structure for setup. I've changed it to never time out, unless the user specifies a `run_timeout' value. I've also made the stop delay configurable."}}