{"action":"created","issue":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/210","repository_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/210/comments","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/210/events","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/210","id":170882334,"number":210,"title":"Safe ScriptUtil#loadScript() method","user":{"login":"tsareg","id":1167285,"avatar_url":"https://avatars.githubusercontent.com/u/1167285?v=3","gravatar_id":"","url":"https://api.github.com/users/tsareg","html_url":"https://github.com/tsareg","followers_url":"https://api.github.com/users/tsareg/followers","following_url":"https://api.github.com/users/tsareg/following{/other_user}","gists_url":"https://api.github.com/users/tsareg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsareg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsareg/subscriptions","organizations_url":"https://api.github.com/users/tsareg/orgs","repos_url":"https://api.github.com/users/tsareg/repos","events_url":"https://api.github.com/users/tsareg/events{/privacy}","received_events_url":"https://api.github.com/users/tsareg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"assignees":[{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-12T14:22:11Z","updated_at":"2016-08-12T20:58:05Z","closed_at":"2016-08-12T20:58:05Z","pull_request":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/210","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/210","diff_url":"https://github.com/jitsi/lib-jitsi-meet/pull/210.diff","patch_url":"https://github.com/jitsi/lib-jitsi-meet/pull/210.patch"},"body":"Some environments (e.g. React-Native) do not have ```<script>``` tags and do not load JS files in this way, so we need add additional safe checks in \"loadScript\" method."},"comment":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments/239558008","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/210#issuecomment-239558008","issue_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/210","id":239558008,"user":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T20:58:05Z","updated_at":"2016-08-12T20:58:05Z","body":"I'm afraid I disagree with this PR. It merely prevents the ScriptUtil#loadScript() from throwing an error. But I find that prevention to be worse than throwing an error because the function still fails to carry out its task and now it fails silently."}}
{"actor":{"display_login":"lyubomir"}}