{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7511","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7511/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7511/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7511/events","html_url":"https://github.com/ManageIQ/manageiq/pull/7511","id":143256637,"number":7511,"title":"The if and else both do the same thing so remove the if.","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-24T14:09:59Z","updated_at":"2016-03-24T14:11:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7511","html_url":"https://github.com/ManageIQ/manageiq/pull/7511","diff_url":"https://github.com/ManageIQ/manageiq/pull/7511.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7511.patch"},"body":"Seen, while reviewing the chargeback pull requests.\r\n\r\nFlay:\r\n2) IDENTICAL code found in :iter (mass*2 = 256)\r\n  app/controllers/chargeback_controller.rb:696\r\n  app/controllers/chargeback_controller.rb:704\r\n\r\nFlog before and after:\r\n147.2: ChargebackController#cb_assign_set_form_vars app/controllers/chargeback_controller.rb:655\r\n105.0: ChargebackController#cb_assign_set_form_vars app/controllers/chargeback_controller.rb:655\r\n\r\nTo be very careful, since I don't think this method is tested or easily testable... Here is the output of `git log -p --color-words` showing that the code is identical... Because, yes, I didn't believe it either.\r\n\r\n![screen shot 2016-03-24 at 10 08 16 am](https://cloud.githubusercontent.com/assets/19339/14019303/7cd237fc-f1a8-11e5-9e82-29db24d950c7.png)\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/200853930","html_url":"https://github.com/ManageIQ/manageiq/pull/7511#issuecomment-200853930","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7511","id":200853930,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T14:11:36Z","updated_at":"2016-03-24T14:11:36Z","body":"@gtanzillo @dclarizio Please review.  Gregg, note, this is not in the same area of code as #5828 so we should be able to easily rebase after this gets merged."}}