{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/66074731","id":66074731,"diff_hunk":"@@ -71,12 +71,16 @@ type RowChannel struct {\n \n var _ rowReceiver = &RowChannel{}\n \n-func (rc *RowChannel) init() {\n-\trc.dataChan = make(chan StreamMsg, rowChannelBuf)\n+func (rc *RowChannel) initWithBufSize(chanBuf int) {","path":"sql/distsql/base.go","position":null,"original_position":6,"commit_id":"a481c1752c9d6dea0061ff8f9a94a07678f20eae","original_commit_id":"7061e5fb56c9605e3726b794aad54fd7eb34d557","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-06-07T13:56:07Z","updated_at":"2016-06-07T13:56:07Z","html_url":"https://github.com/cockroachdb/cockroach/pull/7072#discussion_r66074731","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/66074731"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/7072#discussion_r66074731"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072","id":72769760,"html_url":"https://github.com/cockroachdb/cockroach/pull/7072","diff_url":"https://github.com/cockroachdb/cockroach/pull/7072.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/7072.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7072","number":7072,"state":"open","locked":false,"title":"sql/distsql: joinreader implementation","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"See individual commits for descriptions.\r\nCC @paperstreet, @nvanbenschoten\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/7072)\n<!-- Reviewable:end -->\n","created_at":"2016-06-06T20:10:52Z","updated_at":"2016-06-07T13:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb3ec9758472e5c36c6d8013a0875151d88c3dbf","assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7072/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a481c1752c9d6dea0061ff8f9a94a07678f20eae","head":{"label":"RaduBerinde:joinreader","ref":"joinreader","sha":"a481c1752c9d6dea0061ff8f9a94a07678f20eae","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"repo":{"id":49111463,"name":"cockroach","full_name":"RaduBerinde/cockroach","owner":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaduBerinde/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/RaduBerinde/cockroach","forks_url":"https://api.github.com/repos/RaduBerinde/cockroach/forks","keys_url":"https://api.github.com/repos/RaduBerinde/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaduBerinde/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaduBerinde/cockroach/teams","hooks_url":"https://api.github.com/repos/RaduBerinde/cockroach/hooks","issue_events_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/RaduBerinde/cockroach/events","assignees_url":"https://api.github.com/repos/RaduBerinde/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/RaduBerinde/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/tags","blobs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaduBerinde/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/RaduBerinde/cockroach/languages","stargazers_url":"https://api.github.com/repos/RaduBerinde/cockroach/stargazers","contributors_url":"https://api.github.com/repos/RaduBerinde/cockroach/contributors","subscribers_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscribers","subscription_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscription","commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaduBerinde/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaduBerinde/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/RaduBerinde/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaduBerinde/cockroach/merges","archive_url":"https://api.github.com/repos/RaduBerinde/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaduBerinde/cockroach/downloads","issues_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/RaduBerinde/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/RaduBerinde/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/RaduBerinde/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaduBerinde/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/RaduBerinde/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/RaduBerinde/cockroach/deployments","created_at":"2016-01-06T04:07:30Z","updated_at":"2016-04-16T08:06:40Z","pushed_at":"2016-06-07T13:55:30Z","git_url":"git://github.com/RaduBerinde/cockroach.git","ssh_url":"git@github.com:RaduBerinde/cockroach.git","clone_url":"https://github.com/RaduBerinde/cockroach.git","svn_url":"https://github.com/RaduBerinde/cockroach","homepage":"http://www.cockroachlabs.com","size":176188,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"5ea4fa18a15ce71e6d7caf5738584ed36698800f","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-06-07T13:26:38Z","pushed_at":"2016-06-07T13:55:36Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":225801,"stargazers_count":7028,"watchers_count":7028,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":682,"mirror_url":null,"open_issues_count":480,"forks":682,"open_issues":480,"watchers":7028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/7072"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/7072"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/7072/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7072/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a481c1752c9d6dea0061ff8f9a94a07678f20eae"}}}}
{"actor":{"display_login":"RaduBerinde"}}