{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/91608350","pull_request_review_id":12119260,"id":91608350,"diff_hunk":"@@ -28,6 +28,19 @@ class MenusTableMenu extends JTableMenu\n \t */\n \tpublic function delete($pk = null, $children = false)\n \t{\n-\t\treturn parent::delete($pk, $children);\n+\t\t$return = parent::delete($pk, $children);\n+\n+\t\tif ($return)\n+\t\t{\n+\t\t\t// Delete key from the #__modules_menu table\n+\t\t\t$db = JFactory::getDbo();\n+\t\t\t$query = $db->getQuery(true)\n+\t\t\t\t->delete($db->quoteName('#__modules_menu'))\n+\t\t\t\t->where($db->quoteName('moduleid') . ' = ' . $pk);","path":"administrator/components/com_menus/tables/menu.php","position":null,"original_position":13,"commit_id":"84d656521b54de6f851ebb75f6c535b2f5f67959","original_commit_id":"91d1c062cf40fd65528431a633f24febb2e3c20b","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"body":"yes thanks for reporting","created_at":"2016-12-08T21:16:41Z","updated_at":"2016-12-08T21:16:41Z","html_url":"https://github.com/joomla/joomla-cms/pull/13126#discussion_r91608350","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/91608350"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13126#discussion_r91608350"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126","id":97085441,"html_url":"https://github.com/joomla/joomla-cms/pull/13126","diff_url":"https://github.com/joomla/joomla-cms/pull/13126.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13126.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13126","number":13126,"state":"open","locked":false,"title":"[com_menu] - delete reference on #_modules_menu deleting a menu item","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #13108 .\r\n\r\n### Summary of Changes\r\ndelete reference on `#_modules_menu` table when is deleted a trashed menu item\r\n\r\n### Testing Instructions\r\n\r\nsee https://github.com/joomla/joomla-cms/issues/13108#issue-193896370\r\n\r\n","created_at":"2016-12-08T09:24:20Z","updated_at":"2016-12-08T21:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65c7381b8324067ef85100afd846ef9129531000","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13126/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/84d656521b54de6f851ebb75f6c535b2f5f67959","head":{"label":"alikon:patch-86","ref":"patch-86","sha":"84d656521b54de6f851ebb75f6c535b2f5f67959","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"repo":{"id":27932665,"name":"joomla-cms","full_name":"alikon/joomla-cms","owner":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alikon/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/alikon/joomla-cms","forks_url":"https://api.github.com/repos/alikon/joomla-cms/forks","keys_url":"https://api.github.com/repos/alikon/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alikon/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alikon/joomla-cms/teams","hooks_url":"https://api.github.com/repos/alikon/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/alikon/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/alikon/joomla-cms/events","assignees_url":"https://api.github.com/repos/alikon/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/alikon/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/alikon/joomla-cms/tags","blobs_url":"https://api.github.com/repos/alikon/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alikon/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alikon/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/alikon/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alikon/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/alikon/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/alikon/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/alikon/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/alikon/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/alikon/joomla-cms/subscription","commits_url":"https://api.github.com/repos/alikon/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/alikon/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/alikon/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/alikon/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/alikon/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/alikon/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alikon/joomla-cms/merges","archive_url":"https://api.github.com/repos/alikon/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alikon/joomla-cms/downloads","issues_url":"https://api.github.com/repos/alikon/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/alikon/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/alikon/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/alikon/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alikon/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/alikon/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/alikon/joomla-cms/deployments","created_at":"2014-12-12T18:26:04Z","updated_at":"2016-06-01T05:07:02Z","pushed_at":"2016-12-08T21:14:04Z","git_url":"git://github.com/alikon/joomla-cms.git","ssh_url":"git@github.com:alikon/joomla-cms.git","clone_url":"https://github.com/alikon/joomla-cms.git","svn_url":"https://github.com/alikon/joomla-cms","homepage":"http://joomla.org","size":166095,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"cd9b02f2f567e2efd88cda2e4ef9cd13df3fde8a","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-12-08T21:10:06Z","pushed_at":"2016-12-08T21:14:04Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":313279,"stargazers_count":2207,"watchers_count":2207,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2348,"mirror_url":null,"open_issues_count":592,"forks":2348,"open_issues":592,"watchers":2207,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13126"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13126"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13126/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13126/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/84d656521b54de6f851ebb75f6c535b2f5f67959"}}}}
{"actor":{"display_login":"alikon"}}