{"action":"created","comment":{"url":"https://api.github.com/repos/deis/controller/pulls/comments/68124699","id":68124699,"diff_hunk":"@@ -252,6 +307,21 @@ def validate_registry(self, data):\n \n         return data\n \n+    def validate_healthcheck(self, data):\n+        for key, value in data.items():\n+            if value is None:\n+                raise serializers.ValidationError(\"Healthcheck value for \" + key + \"can't be None\")\n+\n+            if key not in ['livenessProbe', 'readinessProbe']:\n+                raise serializers.ValidationError(\n+                    \"Healthcheck keys must be either livenessProbe or readinessProbe\")\n+            try:\n+                jsonschema.validate(value, PROBE_SCHEMA)\n+            except jsonschema.ValidationError as e:","path":"rootfs/api/serializers.py","position":119,"original_position":104,"commit_id":"4973fbea2687816e56e3da38de5a193b37f8f16d","original_commit_id":"fcc0aa97457b977d22ca8d7b4559dd414443cfca","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"its done as part of the test_config by sending invalid import","created_at":"2016-06-22T20:04:43Z","updated_at":"2016-06-22T20:04:44Z","html_url":"https://github.com/deis/controller/pull/823#discussion_r68124699","pull_request_url":"https://api.github.com/repos/deis/controller/pulls/823","_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/comments/68124699"},"html":{"href":"https://github.com/deis/controller/pull/823#discussion_r68124699"},"pull_request":{"href":"https://api.github.com/repos/deis/controller/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/deis/controller/pulls/823","id":74165121,"html_url":"https://github.com/deis/controller/pull/823","diff_url":"https://github.com/deis/controller/pull/823.diff","patch_url":"https://github.com/deis/controller/pull/823.patch","issue_url":"https://api.github.com/repos/deis/controller/issues/823","number":823,"state":"closed","locked":false,"title":"feat(healthcheck): Add healthchecks as separate configuration","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"# Summary of Changes\r\n\r\nConsume health checks as separate configuration.\r\n\r\n# Issue(s) that this PR Closes\r\n\r\nfixes #603 \r\n\r\n# Associated [End To End Test](https://github.com/deis/workflow-e2e) PR(s)\r\n\r\n# Associated [Documentation](https://github.com/deis/workflow) PR(s)\r\n\r\nhttps://github.com/deis/workflow/pull/322\r\n\r\n# Associated [Design Document](http://docs.deis.io/en/latest/contributing/design-documents)(s)\r\n\r\n# Testing Instructions\r\n\r\nhttps://github.com/deis/workflow/pull/322\r\n\r\n# Pull Request Hygiene TODOs\r\n\r\nPlease make sure the below checklist is complete.\r\n\r\n- [x] Your pull request is concise and to the point (make another PR for refactoring nearby code)\r\n- [x] Your commits are squashed into logical units of work\r\n- [x] Your commits follow the [commit style guidelines](http://docs.deis.io/en/latest/contributing/standards/#commit-style-guide)\r\n\r\n:cherry_blossom: Thank you! :cherry_blossom:\r\n\r\n","created_at":"2016-06-16T22:48:53Z","updated_at":"2016-06-22T20:04:44Z","closed_at":"2016-06-22T19:34:24Z","merged_at":null,"merge_commit_sha":"318b4fcc5b3df4a7cc90e4148e0afd92a99ddb84","assignee":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller/milestones/11","html_url":"https://github.com/deis/controller/milestones/v2.1","labels_url":"https://api.github.com/repos/deis/controller/milestones/11/labels","id":1786079,"number":11,"title":"v2.1","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":7,"state":"open","created_at":"2016-05-24T21:42:12Z","updated_at":"2016-06-22T19:34:24Z","due_on":"2016-07-06T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/controller/pulls/823/commits","review_comments_url":"https://api.github.com/repos/deis/controller/pulls/823/comments","review_comment_url":"https://api.github.com/repos/deis/controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/controller/issues/823/comments","statuses_url":"https://api.github.com/repos/deis/controller/statuses/4973fbea2687816e56e3da38de5a193b37f8f16d","head":{"label":"kmala:healthz","ref":"healthz","sha":"4973fbea2687816e56e3da38de5a193b37f8f16d","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"repo":{"id":53718963,"name":"workflow","full_name":"kmala/workflow","owner":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmala/workflow","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/kmala/workflow","forks_url":"https://api.github.com/repos/kmala/workflow/forks","keys_url":"https://api.github.com/repos/kmala/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmala/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmala/workflow/teams","hooks_url":"https://api.github.com/repos/kmala/workflow/hooks","issue_events_url":"https://api.github.com/repos/kmala/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/kmala/workflow/events","assignees_url":"https://api.github.com/repos/kmala/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/kmala/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/kmala/workflow/tags","blobs_url":"https://api.github.com/repos/kmala/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmala/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmala/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmala/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmala/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kmala/workflow/languages","stargazers_url":"https://api.github.com/repos/kmala/workflow/stargazers","contributors_url":"https://api.github.com/repos/kmala/workflow/contributors","subscribers_url":"https://api.github.com/repos/kmala/workflow/subscribers","subscription_url":"https://api.github.com/repos/kmala/workflow/subscription","commits_url":"https://api.github.com/repos/kmala/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmala/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmala/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmala/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmala/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/kmala/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmala/workflow/merges","archive_url":"https://api.github.com/repos/kmala/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmala/workflow/downloads","issues_url":"https://api.github.com/repos/kmala/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/kmala/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kmala/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kmala/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmala/workflow/labels{/name}","releases_url":"https://api.github.com/repos/kmala/workflow/releases{/id}","deployments_url":"https://api.github.com/repos/kmala/workflow/deployments","created_at":"2016-03-12T07:20:34Z","updated_at":"2016-03-12T07:20:35Z","pushed_at":"2016-06-22T00:48:58Z","git_url":"git://github.com/kmala/workflow.git","ssh_url":"git@github.com:kmala/workflow.git","clone_url":"https://github.com/kmala/workflow.git","svn_url":"https://github.com/kmala/workflow","homepage":"http://deis.io","size":15893,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"49745842cd81b1fb217958dca78a7d326ffcf4bc","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"controller","full_name":"deis/controller","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/controller","description":"Deis Workflow Controller (API)","fork":false,"url":"https://api.github.com/repos/deis/controller","forks_url":"https://api.github.com/repos/deis/controller/forks","keys_url":"https://api.github.com/repos/deis/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/controller/teams","hooks_url":"https://api.github.com/repos/deis/controller/hooks","issue_events_url":"https://api.github.com/repos/deis/controller/issues/events{/number}","events_url":"https://api.github.com/repos/deis/controller/events","assignees_url":"https://api.github.com/repos/deis/controller/assignees{/user}","branches_url":"https://api.github.com/repos/deis/controller/branches{/branch}","tags_url":"https://api.github.com/repos/deis/controller/tags","blobs_url":"https://api.github.com/repos/deis/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/controller/languages","stargazers_url":"https://api.github.com/repos/deis/controller/stargazers","contributors_url":"https://api.github.com/repos/deis/controller/contributors","subscribers_url":"https://api.github.com/repos/deis/controller/subscribers","subscription_url":"https://api.github.com/repos/deis/controller/subscription","commits_url":"https://api.github.com/repos/deis/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/controller/contents/{+path}","compare_url":"https://api.github.com/repos/deis/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/controller/merges","archive_url":"https://api.github.com/repos/deis/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/controller/downloads","issues_url":"https://api.github.com/repos/deis/controller/issues{/number}","pulls_url":"https://api.github.com/repos/deis/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/controller/labels{/name}","releases_url":"https://api.github.com/repos/deis/controller/releases{/id}","deployments_url":"https://api.github.com/repos/deis/controller/deployments","created_at":"2015-11-06T20:06:05Z","updated_at":"2016-05-17T09:06:13Z","pushed_at":"2016-06-22T18:52:22Z","git_url":"git://github.com/deis/controller.git","ssh_url":"git@github.com:deis/controller.git","clone_url":"https://github.com/deis/controller.git","svn_url":"https://github.com/deis/controller","homepage":"https://deis.com","size":16900,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":66,"forks":23,"open_issues":66,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/823"},"html":{"href":"https://github.com/deis/controller/pull/823"},"issue":{"href":"https://api.github.com/repos/deis/controller/issues/823"},"comments":{"href":"https://api.github.com/repos/deis/controller/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/controller/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/controller/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/deis/controller/statuses/4973fbea2687816e56e3da38de5a193b37f8f16d"}}}}
{"actor":{"display_login":"kmala"}}