{"action":"created","issue":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/444","repository_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit","labels_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/444/comments","events_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/444/events","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/444","id":174453253,"number":444,"title":"Makes the dynamicType the default name for Operations.","user":{"login":"enhorn","id":657370,"avatar_url":"https://avatars.githubusercontent.com/u/657370?v=3","gravatar_id":"","url":"https://api.github.com/users/enhorn","html_url":"https://github.com/enhorn","followers_url":"https://api.github.com/users/enhorn/followers","following_url":"https://api.github.com/users/enhorn/following{/other_user}","gists_url":"https://api.github.com/users/enhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/enhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enhorn/subscriptions","organizations_url":"https://api.github.com/users/enhorn/orgs","repos_url":"https://api.github.com/users/enhorn/repos","events_url":"https://api.github.com/users/enhorn/events{/privacy}","received_events_url":"https://api.github.com/users/enhorn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-01T07:17:52Z","updated_at":"2016-09-17T16:53:17Z","closed_at":"2016-09-17T16:53:16Z","pull_request":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/pulls/444","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/444","diff_url":"https://github.com/ProcedureKit/ProcedureKit/pull/444.diff","patch_url":"https://github.com/ProcedureKit/ProcedureKit/pull/444.patch"},"body":"Having default names on operations is something that have been of great value for me when reading logs.\r\n\r\nThis only changes so the name property at init(), and will not interfere will later setting of the property.\r\n\r\nExample in for log in old for a cancelled dependency:\r\n\r\n```\r\nUnnamed Operation Evaluate Conditions: Will finish with 1 errors.\r\nUnnamed Operation: Did cancel with errors: [Operations.NoFailedDependenciesCondition.Error.CancelledDependencies].\r\nUnnamed Operation: Did cancel with errors: [Operations.OperationError.ParentOperationCancelledWithErrors([Operations.NoFailedDependenciesCondition.Error.CancelledDependencies])].\r\n```\r\n\r\n```\r\nMySubclassedGroupOperationWithAUsefulName Evaluate Conditions: Will finish with 1 errors.\r\nMySubclassedGroupOperationWithAUsefulName: Did cancel with errors: [Operations.NoFailedDependenciesCondition.Error.CancelledDependencies].\r\nMyInternalOperationWithAUsefulName: Did cancel with errors: [Operations.OperationError.ParentOperationCancelledWithErrors([Operations.NoFailedDependenciesCondition.Error.CancelledDependencies])].\r\n```\r\n\r\n\"Unnamed Operation\" comes from Logging.swift line 367 and will still be used of the operation name have been set to nil."},"comment":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/comments/247788063","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/444#issuecomment-247788063","issue_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/444","id":247788063,"user":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars.githubusercontent.com/u/309420?v=3","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"created_at":"2016-09-17T16:53:16Z","updated_at":"2016-09-17T16:53:16Z","body":"@enhorn - I've implemented this in #478 in _ProcedureKit_ and it will be in Beta 2. But it's not going to go into _Operations_."}}
{"actor":{"display_login":"danthorpe"}}