{"action":"created","comment":{"url":"https://api.github.com/repos/hhru/frontik/pulls/comments/61405324","id":61405324,"diff_hunk":"@@ -193,3 +193,13 @@ def test_assertXmlCompatible_incompatible_less_tags(self):\n             self.assertXmlCompatible(old, new)\n         except self.failureException as e:\n             self.assertIn('Children length differs', str(e))\n+\n+    def test_assertXmlEqual_with_similar_children(self):\n+        xml_string = ('<a><b><c><d>1</d><e>2</e></c><f><g>3</g></f></b><h>4</h><i><l>5</l><m>6</m></i>'\n+                      '<i><l>7</l><m>8</m></i></a>')\n+        xml = etree.fromstring(xml_string)\n+\n+        try:\n+            self.assertXmlEqual(xml_string, xml)\n+        except self.failureException as e:\n+            self.fail('XML should be equals (Reported error: \"{}\")'.format(e))","path":"tests/test_xml_asserts.py","position":null,"original_position":70,"commit_id":"852cbf387e8ae04f7eb9cee292a9e5c8f4966c37","original_commit_id":"07ad567d0e7e8ae5b2a35146a5776189472b3826","user":{"login":"maizy","id":789623,"avatar_url":"https://avatars.githubusercontent.com/u/789623?v=3","gravatar_id":"","url":"https://api.github.com/users/maizy","html_url":"https://github.com/maizy","followers_url":"https://api.github.com/users/maizy/followers","following_url":"https://api.github.com/users/maizy/following{/other_user}","gists_url":"https://api.github.com/users/maizy/gists{/gist_id}","starred_url":"https://api.github.com/users/maizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maizy/subscriptions","organizations_url":"https://api.github.com/users/maizy/orgs","repos_url":"https://api.github.com/users/maizy/repos","events_url":"https://api.github.com/users/maizy/events{/privacy}","received_events_url":"https://api.github.com/users/maizy/received_events","type":"User","site_admin":false},"body":"... а нет. не пофикшу. это типо указание на то какой способ сравнения используется. у нас есть equal для xml и compatible и прочие хитрые случаи сравненения.\r\nВместо того, чтобы убрать я дописал полезной инфы.","created_at":"2016-04-28T10:27:10Z","updated_at":"2016-04-28T10:27:10Z","html_url":"https://github.com/hhru/frontik/pull/229#discussion_r61405324","pull_request_url":"https://api.github.com/repos/hhru/frontik/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/hhru/frontik/pulls/comments/61405324"},"html":{"href":"https://github.com/hhru/frontik/pull/229#discussion_r61405324"},"pull_request":{"href":"https://api.github.com/repos/hhru/frontik/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/hhru/frontik/pulls/229","id":68195215,"html_url":"https://github.com/hhru/frontik/pull/229","diff_url":"https://github.com/hhru/frontik/pull/229.diff","patch_url":"https://github.com/hhru/frontik/pull/229.patch","issue_url":"https://api.github.com/repos/hhru/frontik/issues/229","number":229,"state":"open","locked":false,"title":"HH-59025 fix assertXmlEqual: order xml children with deep comparing","user":{"login":"maizy","id":789623,"avatar_url":"https://avatars.githubusercontent.com/u/789623?v=3","gravatar_id":"","url":"https://api.github.com/users/maizy","html_url":"https://github.com/maizy","followers_url":"https://api.github.com/users/maizy/followers","following_url":"https://api.github.com/users/maizy/following{/other_user}","gists_url":"https://api.github.com/users/maizy/gists{/gist_id}","starred_url":"https://api.github.com/users/maizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maizy/subscriptions","organizations_url":"https://api.github.com/users/maizy/orgs","repos_url":"https://api.github.com/users/maizy/repos","events_url":"https://api.github.com/users/maizy/events{/privacy}","received_events_url":"https://api.github.com/users/maizy/received_events","type":"User","site_admin":false},"body":"причина была в отсутствии глубокой сортировки xml нод, удивительно, что так долго мы это не замечали.\r\n\r\nпроверил master всех проектов, зависящих от frontik, тесты проходят.","created_at":"2016-04-28T10:08:37Z","updated_at":"2016-04-28T10:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b45efa9cf85938cb6afd89c3bc0c6bb13b6d921","assignee":{"login":"App3x","id":2619866,"avatar_url":"https://avatars.githubusercontent.com/u/2619866?v=3","gravatar_id":"","url":"https://api.github.com/users/App3x","html_url":"https://github.com/App3x","followers_url":"https://api.github.com/users/App3x/followers","following_url":"https://api.github.com/users/App3x/following{/other_user}","gists_url":"https://api.github.com/users/App3x/gists{/gist_id}","starred_url":"https://api.github.com/users/App3x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/App3x/subscriptions","organizations_url":"https://api.github.com/users/App3x/orgs","repos_url":"https://api.github.com/users/App3x/repos","events_url":"https://api.github.com/users/App3x/events{/privacy}","received_events_url":"https://api.github.com/users/App3x/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hhru/frontik/pulls/229/commits","review_comments_url":"https://api.github.com/repos/hhru/frontik/pulls/229/comments","review_comment_url":"https://api.github.com/repos/hhru/frontik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhru/frontik/issues/229/comments","statuses_url":"https://api.github.com/repos/hhru/frontik/statuses/852cbf387e8ae04f7eb9cee292a9e5c8f4966c37","head":{"label":"hhru:HH-59025","ref":"HH-59025","sha":"852cbf387e8ae04f7eb9cee292a9e5c8f4966c37","user":{"login":"hhru","id":152753,"avatar_url":"https://avatars.githubusercontent.com/u/152753?v=3","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"repo":{"id":825839,"name":"frontik","full_name":"hhru/frontik","owner":{"login":"hhru","id":152753,"avatar_url":"https://avatars.githubusercontent.com/u/152753?v=3","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhru/frontik","description":"Maintainers: Сумин","fork":false,"url":"https://api.github.com/repos/hhru/frontik","forks_url":"https://api.github.com/repos/hhru/frontik/forks","keys_url":"https://api.github.com/repos/hhru/frontik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhru/frontik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhru/frontik/teams","hooks_url":"https://api.github.com/repos/hhru/frontik/hooks","issue_events_url":"https://api.github.com/repos/hhru/frontik/issues/events{/number}","events_url":"https://api.github.com/repos/hhru/frontik/events","assignees_url":"https://api.github.com/repos/hhru/frontik/assignees{/user}","branches_url":"https://api.github.com/repos/hhru/frontik/branches{/branch}","tags_url":"https://api.github.com/repos/hhru/frontik/tags","blobs_url":"https://api.github.com/repos/hhru/frontik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhru/frontik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhru/frontik/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhru/frontik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhru/frontik/statuses/{sha}","languages_url":"https://api.github.com/repos/hhru/frontik/languages","stargazers_url":"https://api.github.com/repos/hhru/frontik/stargazers","contributors_url":"https://api.github.com/repos/hhru/frontik/contributors","subscribers_url":"https://api.github.com/repos/hhru/frontik/subscribers","subscription_url":"https://api.github.com/repos/hhru/frontik/subscription","commits_url":"https://api.github.com/repos/hhru/frontik/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhru/frontik/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhru/frontik/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhru/frontik/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhru/frontik/contents/{+path}","compare_url":"https://api.github.com/repos/hhru/frontik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhru/frontik/merges","archive_url":"https://api.github.com/repos/hhru/frontik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhru/frontik/downloads","issues_url":"https://api.github.com/repos/hhru/frontik/issues{/number}","pulls_url":"https://api.github.com/repos/hhru/frontik/pulls{/number}","milestones_url":"https://api.github.com/repos/hhru/frontik/milestones{/number}","notifications_url":"https://api.github.com/repos/hhru/frontik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhru/frontik/labels{/name}","releases_url":"https://api.github.com/repos/hhru/frontik/releases{/id}","deployments_url":"https://api.github.com/repos/hhru/frontik/deployments","created_at":"2010-08-09T05:13:13Z","updated_at":"2015-09-13T14:41:45Z","pushed_at":"2016-04-28T10:26:35Z","git_url":"git://github.com/hhru/frontik.git","ssh_url":"git@github.com:hhru/frontik.git","clone_url":"https://github.com/hhru/frontik.git","svn_url":"https://github.com/hhru/frontik","homepage":"","size":2564,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":30,"default_branch":"master"}},"base":{"label":"hhru:master","ref":"master","sha":"9c6219a6e319aa03885784adaf0523cb1b41136c","user":{"login":"hhru","id":152753,"avatar_url":"https://avatars.githubusercontent.com/u/152753?v=3","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"repo":{"id":825839,"name":"frontik","full_name":"hhru/frontik","owner":{"login":"hhru","id":152753,"avatar_url":"https://avatars.githubusercontent.com/u/152753?v=3","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhru/frontik","description":"Maintainers: Сумин","fork":false,"url":"https://api.github.com/repos/hhru/frontik","forks_url":"https://api.github.com/repos/hhru/frontik/forks","keys_url":"https://api.github.com/repos/hhru/frontik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhru/frontik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhru/frontik/teams","hooks_url":"https://api.github.com/repos/hhru/frontik/hooks","issue_events_url":"https://api.github.com/repos/hhru/frontik/issues/events{/number}","events_url":"https://api.github.com/repos/hhru/frontik/events","assignees_url":"https://api.github.com/repos/hhru/frontik/assignees{/user}","branches_url":"https://api.github.com/repos/hhru/frontik/branches{/branch}","tags_url":"https://api.github.com/repos/hhru/frontik/tags","blobs_url":"https://api.github.com/repos/hhru/frontik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhru/frontik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhru/frontik/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhru/frontik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhru/frontik/statuses/{sha}","languages_url":"https://api.github.com/repos/hhru/frontik/languages","stargazers_url":"https://api.github.com/repos/hhru/frontik/stargazers","contributors_url":"https://api.github.com/repos/hhru/frontik/contributors","subscribers_url":"https://api.github.com/repos/hhru/frontik/subscribers","subscription_url":"https://api.github.com/repos/hhru/frontik/subscription","commits_url":"https://api.github.com/repos/hhru/frontik/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhru/frontik/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhru/frontik/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhru/frontik/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhru/frontik/contents/{+path}","compare_url":"https://api.github.com/repos/hhru/frontik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhru/frontik/merges","archive_url":"https://api.github.com/repos/hhru/frontik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhru/frontik/downloads","issues_url":"https://api.github.com/repos/hhru/frontik/issues{/number}","pulls_url":"https://api.github.com/repos/hhru/frontik/pulls{/number}","milestones_url":"https://api.github.com/repos/hhru/frontik/milestones{/number}","notifications_url":"https://api.github.com/repos/hhru/frontik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhru/frontik/labels{/name}","releases_url":"https://api.github.com/repos/hhru/frontik/releases{/id}","deployments_url":"https://api.github.com/repos/hhru/frontik/deployments","created_at":"2010-08-09T05:13:13Z","updated_at":"2015-09-13T14:41:45Z","pushed_at":"2016-04-28T10:26:35Z","git_url":"git://github.com/hhru/frontik.git","ssh_url":"git@github.com:hhru/frontik.git","clone_url":"https://github.com/hhru/frontik.git","svn_url":"https://github.com/hhru/frontik","homepage":"","size":2564,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhru/frontik/pulls/229"},"html":{"href":"https://github.com/hhru/frontik/pull/229"},"issue":{"href":"https://api.github.com/repos/hhru/frontik/issues/229"},"comments":{"href":"https://api.github.com/repos/hhru/frontik/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/hhru/frontik/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/hhru/frontik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhru/frontik/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/hhru/frontik/statuses/852cbf387e8ae04f7eb9cee292a9e5c8f4966c37"}}}}