{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/58080966","id":58080966,"diff_hunk":"@@ -1,6 +1,7 @@\n-*   Add `String#upcase_first` method.\n+*   Add `String#upcase_first` method. Converts just the first character to uppercase,","path":"activesupport/CHANGELOG.md","position":2,"original_position":2,"commit_id":"31804ac28c838845a957e48683a095d03f1363d9","original_commit_id":"31804ac28c838845a957e48683a095d03f1363d9","user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"body":"There is not need to change the CHANGELOG entry.","created_at":"2016-03-31T16:07:07Z","updated_at":"2016-03-31T16:07:07Z","html_url":"https://github.com/rails/rails/pull/24377#discussion_r58080966","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/24377","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/58080966"},"html":{"href":"https://github.com/rails/rails/pull/24377#discussion_r58080966"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/24377"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/24377","id":64713892,"html_url":"https://github.com/rails/rails/pull/24377","diff_url":"https://github.com/rails/rails/pull/24377.diff","patch_url":"https://github.com/rails/rails/pull/24377.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/24377","number":24377,"state":"open","locked":false,"title":"Fix method String#upcase_first","user":{"login":"bogdanvlviv","id":6443532,"avatar_url":"https://avatars.githubusercontent.com/u/6443532?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"body":"Method `String#upcase_first` called to empty string raises error because of \r\n`\"\"[0] # => nil` \r\n`\"\"[0].upcase # => NoMethodError: undefined method 'upcase' for nil:NilClass`\r\nor \r\n`\"\"[1..-1] #=> nil` \r\n`i_am_string.concat(nil) # => TypeError: no implicit conversion of nil into String`\r\n\r\n\r\nWe have method `String#upcase`. it work with empty string. I think expected that `String#upcase_string` will be work with empty strings instead of raise error.\r\n\r\nIf this changes is not correct, at least we must raise another error instead of `NoMethodError: undefined method 'upcase' for nil:NilClass`.\r\n","created_at":"2016-03-30T23:31:05Z","updated_at":"2016-03-31T16:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c538f5b5c5d4b1d9362430d58d8c6f476a3be5d1","assignee":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/24377/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/24377/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/24377/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/31804ac28c838845a957e48683a095d03f1363d9","head":{"label":"bogdanvlviv:fix_upcase_first","ref":"fix_upcase_first","sha":"31804ac28c838845a957e48683a095d03f1363d9","user":{"login":"bogdanvlviv","id":6443532,"avatar_url":"https://avatars.githubusercontent.com/u/6443532?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"repo":{"id":54744114,"name":"rails","full_name":"bogdanvlviv/rails","owner":{"login":"bogdanvlviv","id":6443532,"avatar_url":"https://avatars.githubusercontent.com/u/6443532?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdanvlviv/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/bogdanvlviv/rails","forks_url":"https://api.github.com/repos/bogdanvlviv/rails/forks","keys_url":"https://api.github.com/repos/bogdanvlviv/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdanvlviv/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdanvlviv/rails/teams","hooks_url":"https://api.github.com/repos/bogdanvlviv/rails/hooks","issue_events_url":"https://api.github.com/repos/bogdanvlviv/rails/issues/events{/number}","events_url":"https://api.github.com/repos/bogdanvlviv/rails/events","assignees_url":"https://api.github.com/repos/bogdanvlviv/rails/assignees{/user}","branches_url":"https://api.github.com/repos/bogdanvlviv/rails/branches{/branch}","tags_url":"https://api.github.com/repos/bogdanvlviv/rails/tags","blobs_url":"https://api.github.com/repos/bogdanvlviv/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdanvlviv/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdanvlviv/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdanvlviv/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdanvlviv/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdanvlviv/rails/languages","stargazers_url":"https://api.github.com/repos/bogdanvlviv/rails/stargazers","contributors_url":"https://api.github.com/repos/bogdanvlviv/rails/contributors","subscribers_url":"https://api.github.com/repos/bogdanvlviv/rails/subscribers","subscription_url":"https://api.github.com/repos/bogdanvlviv/rails/subscription","commits_url":"https://api.github.com/repos/bogdanvlviv/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdanvlviv/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdanvlviv/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdanvlviv/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdanvlviv/rails/contents/{+path}","compare_url":"https://api.github.com/repos/bogdanvlviv/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdanvlviv/rails/merges","archive_url":"https://api.github.com/repos/bogdanvlviv/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdanvlviv/rails/downloads","issues_url":"https://api.github.com/repos/bogdanvlviv/rails/issues{/number}","pulls_url":"https://api.github.com/repos/bogdanvlviv/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdanvlviv/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdanvlviv/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdanvlviv/rails/labels{/name}","releases_url":"https://api.github.com/repos/bogdanvlviv/rails/releases{/id}","deployments_url":"https://api.github.com/repos/bogdanvlviv/rails/deployments","created_at":"2016-03-25T19:54:02Z","updated_at":"2016-03-25T19:55:12Z","pushed_at":"2016-03-30T23:12:02Z","git_url":"git://github.com/bogdanvlviv/rails.git","ssh_url":"git@github.com:bogdanvlviv/rails.git","clone_url":"https://github.com/bogdanvlviv/rails.git","svn_url":"https://github.com/bogdanvlviv/rails","homepage":"http://rubyonrails.org","size":129229,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"a564fecbd0c96815664067b727817045459cae98","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-03-31T16:06:20Z","pushed_at":"2016-03-31T15:38:44Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":331738,"stargazers_count":30418,"watchers_count":30418,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12330,"mirror_url":null,"open_issues_count":917,"forks":12330,"open_issues":917,"watchers":30418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/24377"},"html":{"href":"https://github.com/rails/rails/pull/24377"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/24377"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/24377/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/24377/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/24377/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/31804ac28c838845a957e48683a095d03f1363d9"}}}}