{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/devlib/pulls/comments/80664742","pull_request_review_id":1706199,"id":80664742,"diff_hunk":"@@ -832,8 +833,17 @@ def kick_off(self, command, as_root=None):\n         else:\n             raise ValueError('Background command exited before timeout; got \"{}\"'.format(output))\n \n+    def __setup_list_directory(self):","path":"devlib/target.py","position":12,"original_position":12,"commit_id":"508caf63966deb94360705b7ffbd3d25bdabd26a","original_commit_id":"508caf63966deb94360705b7ffbd3d25bdabd26a","user":{"login":"credp","id":1324538,"avatar_url":"https://avatars.githubusercontent.com/u/1324538?v=3","gravatar_id":"","url":"https://api.github.com/users/credp","html_url":"https://github.com/credp","followers_url":"https://api.github.com/users/credp/followers","following_url":"https://api.github.com/users/credp/following{/other_user}","gists_url":"https://api.github.com/users/credp/gists{/gist_id}","starred_url":"https://api.github.com/users/credp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/credp/subscriptions","organizations_url":"https://api.github.com/users/credp/orgs","repos_url":"https://api.github.com/users/credp/repos","events_url":"https://api.github.com/users/credp/events{/privacy}","received_events_url":"https://api.github.com/users/credp/received_events","type":"User","site_admin":false},"body":"ok :)","created_at":"2016-09-27T10:45:05Z","updated_at":"2016-09-27T10:45:05Z","html_url":"https://github.com/ARM-software/devlib/pull/58#discussion_r80664742","pull_request_url":"https://api.github.com/repos/ARM-software/devlib/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/comments/80664742"},"html":{"href":"https://github.com/ARM-software/devlib/pull/58#discussion_r80664742"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/devlib/pulls/58","id":86895944,"html_url":"https://github.com/ARM-software/devlib/pull/58","diff_url":"https://github.com/ARM-software/devlib/pull/58.diff","patch_url":"https://github.com/ARM-software/devlib/pull/58.patch","issue_url":"https://api.github.com/repos/ARM-software/devlib/issues/58","number":58,"state":"open","locked":false,"title":"AndroidTarget: Handle ls format change in Android 7.0","user":{"login":"credp","id":1324538,"avatar_url":"https://avatars.githubusercontent.com/u/1324538?v=3","gravatar_id":"","url":"https://api.github.com/users/credp","html_url":"https://github.com/credp","followers_url":"https://api.github.com/users/credp/followers","following_url":"https://api.github.com/users/credp/following{/other_user}","gists_url":"https://api.github.com/users/credp/gists{/gist_id}","starred_url":"https://api.github.com/users/credp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/credp/subscriptions","organizations_url":"https://api.github.com/users/credp/orgs","repos_url":"https://api.github.com/users/credp/repos","events_url":"https://api.github.com/users/credp/events{/privacy}","received_events_url":"https://api.github.com/users/credp/received_events","type":"User","site_admin":false},"body":"We expect ls to output single column listings. Previous to Linaro Android\r\n16.09 release, this was the default. From the 16.09 release onwards, the\r\ndefault is multi-column. Unfortunately, pre-16.09 ls does not support the\r\n'-1' option to guarantee single column output.\r\n\r\nTest for ls supporting '-1' and use it if possible.\r\n\r\nSigned-off-by: Chris Redpath <chris.redpath@arm.com>","created_at":"2016-09-27T09:48:05Z","updated_at":"2016-09-27T10:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"971ce9c44835cf48d9b5662e418edb706726bd23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/devlib/pulls/58/commits","review_comments_url":"https://api.github.com/repos/ARM-software/devlib/pulls/58/comments","review_comment_url":"https://api.github.com/repos/ARM-software/devlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/devlib/issues/58/comments","statuses_url":"https://api.github.com/repos/ARM-software/devlib/statuses/508caf63966deb94360705b7ffbd3d25bdabd26a","head":{"label":"credp:android7_ls","ref":"android7_ls","sha":"508caf63966deb94360705b7ffbd3d25bdabd26a","user":{"login":"credp","id":1324538,"avatar_url":"https://avatars.githubusercontent.com/u/1324538?v=3","gravatar_id":"","url":"https://api.github.com/users/credp","html_url":"https://github.com/credp","followers_url":"https://api.github.com/users/credp/followers","following_url":"https://api.github.com/users/credp/following{/other_user}","gists_url":"https://api.github.com/users/credp/gists{/gist_id}","starred_url":"https://api.github.com/users/credp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/credp/subscriptions","organizations_url":"https://api.github.com/users/credp/orgs","repos_url":"https://api.github.com/users/credp/repos","events_url":"https://api.github.com/users/credp/events{/privacy}","received_events_url":"https://api.github.com/users/credp/received_events","type":"User","site_admin":false},"repo":{"id":48038660,"name":"devlib","full_name":"credp/devlib","owner":{"login":"credp","id":1324538,"avatar_url":"https://avatars.githubusercontent.com/u/1324538?v=3","gravatar_id":"","url":"https://api.github.com/users/credp","html_url":"https://github.com/credp","followers_url":"https://api.github.com/users/credp/followers","following_url":"https://api.github.com/users/credp/following{/other_user}","gists_url":"https://api.github.com/users/credp/gists{/gist_id}","starred_url":"https://api.github.com/users/credp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/credp/subscriptions","organizations_url":"https://api.github.com/users/credp/orgs","repos_url":"https://api.github.com/users/credp/repos","events_url":"https://api.github.com/users/credp/events{/privacy}","received_events_url":"https://api.github.com/users/credp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/credp/devlib","description":"Library for interaction with and instrumentation of remote devices.","fork":true,"url":"https://api.github.com/repos/credp/devlib","forks_url":"https://api.github.com/repos/credp/devlib/forks","keys_url":"https://api.github.com/repos/credp/devlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/credp/devlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/credp/devlib/teams","hooks_url":"https://api.github.com/repos/credp/devlib/hooks","issue_events_url":"https://api.github.com/repos/credp/devlib/issues/events{/number}","events_url":"https://api.github.com/repos/credp/devlib/events","assignees_url":"https://api.github.com/repos/credp/devlib/assignees{/user}","branches_url":"https://api.github.com/repos/credp/devlib/branches{/branch}","tags_url":"https://api.github.com/repos/credp/devlib/tags","blobs_url":"https://api.github.com/repos/credp/devlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/credp/devlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/credp/devlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/credp/devlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/credp/devlib/statuses/{sha}","languages_url":"https://api.github.com/repos/credp/devlib/languages","stargazers_url":"https://api.github.com/repos/credp/devlib/stargazers","contributors_url":"https://api.github.com/repos/credp/devlib/contributors","subscribers_url":"https://api.github.com/repos/credp/devlib/subscribers","subscription_url":"https://api.github.com/repos/credp/devlib/subscription","commits_url":"https://api.github.com/repos/credp/devlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/credp/devlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/credp/devlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/credp/devlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/credp/devlib/contents/{+path}","compare_url":"https://api.github.com/repos/credp/devlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/credp/devlib/merges","archive_url":"https://api.github.com/repos/credp/devlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/credp/devlib/downloads","issues_url":"https://api.github.com/repos/credp/devlib/issues{/number}","pulls_url":"https://api.github.com/repos/credp/devlib/pulls{/number}","milestones_url":"https://api.github.com/repos/credp/devlib/milestones{/number}","notifications_url":"https://api.github.com/repos/credp/devlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/credp/devlib/labels{/name}","releases_url":"https://api.github.com/repos/credp/devlib/releases{/id}","deployments_url":"https://api.github.com/repos/credp/devlib/deployments","created_at":"2015-12-15T11:28:06Z","updated_at":"2015-12-15T11:28:06Z","pushed_at":"2016-09-27T09:44:59Z","git_url":"git://github.com/credp/devlib.git","ssh_url":"git@github.com:credp/devlib.git","clone_url":"https://github.com/credp/devlib.git","svn_url":"https://github.com/credp/devlib","homepage":null,"size":4706,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"08b36e71cbb6b58e40e8f13abd84bf1ba14911df","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":43942363,"name":"devlib","full_name":"ARM-software/devlib","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/devlib","description":"Library for interaction with and instrumentation of remote devices.","fork":false,"url":"https://api.github.com/repos/ARM-software/devlib","forks_url":"https://api.github.com/repos/ARM-software/devlib/forks","keys_url":"https://api.github.com/repos/ARM-software/devlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/devlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/devlib/teams","hooks_url":"https://api.github.com/repos/ARM-software/devlib/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/devlib/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/devlib/events","assignees_url":"https://api.github.com/repos/ARM-software/devlib/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/devlib/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/devlib/tags","blobs_url":"https://api.github.com/repos/ARM-software/devlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/devlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/devlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/devlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/devlib/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/devlib/languages","stargazers_url":"https://api.github.com/repos/ARM-software/devlib/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/devlib/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/devlib/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/devlib/subscription","commits_url":"https://api.github.com/repos/ARM-software/devlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/devlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/devlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/devlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/devlib/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/devlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/devlib/merges","archive_url":"https://api.github.com/repos/ARM-software/devlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/devlib/downloads","issues_url":"https://api.github.com/repos/ARM-software/devlib/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/devlib/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/devlib/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/devlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/devlib/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/devlib/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/devlib/deployments","created_at":"2015-10-09T08:22:12Z","updated_at":"2016-07-29T11:48:31Z","pushed_at":"2016-09-27T09:48:05Z","git_url":"git://github.com/ARM-software/devlib.git","ssh_url":"git@github.com:ARM-software/devlib.git","clone_url":"https://github.com/ARM-software/devlib.git","svn_url":"https://github.com/ARM-software/devlib","homepage":null,"size":6216,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/58"},"html":{"href":"https://github.com/ARM-software/devlib/pull/58"},"issue":{"href":"https://api.github.com/repos/ARM-software/devlib/issues/58"},"comments":{"href":"https://api.github.com/repos/ARM-software/devlib/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/devlib/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/devlib/statuses/508caf63966deb94360705b7ffbd3d25bdabd26a"}}}}
{"actor":{"display_login":"credp"}}