{"action":"created","issue":{"url":"https://api.github.com/repos/rrag/react-stockcharts/issues/131","repository_url":"https://api.github.com/repos/rrag/react-stockcharts","labels_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/131/comments","events_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/131/events","html_url":"https://github.com/rrag/react-stockcharts/issues/131","id":176242531,"number":131,"title":"CandlestickSires (or other OHLC-sires) are not working with custom data format","user":{"login":"iNikNik","id":7679749,"avatar_url":"https://avatars.githubusercontent.com/u/7679749?v=3","gravatar_id":"","url":"https://api.github.com/users/iNikNik","html_url":"https://github.com/iNikNik","followers_url":"https://api.github.com/users/iNikNik/followers","following_url":"https://api.github.com/users/iNikNik/following{/other_user}","gists_url":"https://api.github.com/users/iNikNik/gists{/gist_id}","starred_url":"https://api.github.com/users/iNikNik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNikNik/subscriptions","organizations_url":"https://api.github.com/users/iNikNik/orgs","repos_url":"https://api.github.com/users/iNikNik/repos","events_url":"https://api.github.com/users/iNikNik/events{/privacy}","received_events_url":"https://api.github.com/users/iNikNik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-11T12:55:40Z","updated_at":"2016-10-13T01:58:50Z","closed_at":"2016-10-13T01:58:50Z","body":"Hello! My input data looks like:\r\n```javascript\r\n[\r\n  {\r\n    \"date\":\"2016-09-09T14:03:21.000Z\",\r\n    \"forex.instrument.bid.10s.avg\":1.1207925423728817,\r\n    \"forex.instrument.bid.10s.min\":1.12027,\r\n    \"forex.instrument.bid.10s.max\":0,\r\n    \"forex.instrument.bid.10s.open\":0,\r\n    \"forex.instrument.bid.10s.close\":0\r\n  }\r\n]\r\n```\r\nAnd I'm using yAccessor to convert it to OHLC-object, but there is no one candle on chart (no errors\\warnings).\r\n\r\nSo, I've investigated this bug and there is some problems with [getWickData method](https://github.com/rrag/react-stockcharts/blob/master/src/lib/series/CandlestickSeries.jsx#L178):\r\n\r\n```javascript\r\nvar wickData = plotData\r\n\t\t\t.filter(d => isDefined(d.close))\r\n```\r\n\r\nFor my data d.close is always undefined. I beilive we should use yAccessor to get that property:\r\n\r\n```javascript\r\nvar wickData = plotData\r\n\t\t\t.filter(d => isDefined(yAccessor(d).close))\r\n```\r\n\r\nIt should fix the problem. But I'm not shure how to fix **PointAndFigureSeries** [here](https://github.com/rrag/react-stockcharts/blob/master/src/lib/series/PointAndFigureSeries.jsx#L110) and [here](https://github.com/rrag/react-stockcharts/blob/master/src/lib/series/PointAndFigureSeries.jsx#L119)  because there is no yAccessor."},"comment":{"url":"https://api.github.com/repos/rrag/react-stockcharts/issues/comments/253391438","html_url":"https://github.com/rrag/react-stockcharts/issues/131#issuecomment-253391438","issue_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/131","id":253391438,"user":{"login":"rrag","id":10691183,"avatar_url":"https://avatars.githubusercontent.com/u/10691183?v=3","gravatar_id":"","url":"https://api.github.com/users/rrag","html_url":"https://github.com/rrag","followers_url":"https://api.github.com/users/rrag/followers","following_url":"https://api.github.com/users/rrag/following{/other_user}","gists_url":"https://api.github.com/users/rrag/gists{/gist_id}","starred_url":"https://api.github.com/users/rrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrag/subscriptions","organizations_url":"https://api.github.com/users/rrag/orgs","repos_url":"https://api.github.com/users/rrag/repos","events_url":"https://api.github.com/users/rrag/events{/privacy}","received_events_url":"https://api.github.com/users/rrag/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T01:58:50Z","updated_at":"2016-10-13T01:58:50Z","body":"point and figure is not ohlc data, it uses ohlc to calculate the columns. it needs high/low or close only depending on the type of calculation method for each `x` or `o` \r\n\r\nhttps://github.com/rrag/react-stockcharts/blob/next/src/lib/indicator/algorithm/pointAndFigure.js#L82-L83"}}
{"actor":{"display_login":"rrag"}}