{"action":"created","comment":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments/71213975","id":71213975,"diff_hunk":"@@ -1637,6 +1637,15 @@ void Vehicle::guidedModeChangeAltitude(double altitudeRel)\n     _firmwarePlugin->guidedModeChangeAltitude(this, altitudeRel);\n }\n \n+void Vehicle::guidedModeOrbit(const QGeoCoordinate& centerCoord, double radius, double velocity, double altitude)\n+{\n+    if (!guidedModeSupported()) {\n+        qgcApp()->showMessage(guided_mode_not_supported_by_vehicle);","path":"src/Vehicle/Vehicle.cc","position":7,"original_position":7,"commit_id":"b7e6281a7efd02f751008985fec682a556983cb8","original_commit_id":"b7e6281a7efd02f751008985fec682a556983cb8","user":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars.githubusercontent.com/u/5876851?v=3","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"body":"camelCase?","created_at":"2016-07-18T19:36:49Z","updated_at":"2016-07-18T19:36:49Z","html_url":"https://github.com/mavlink/qgroundcontrol/pull/3804#discussion_r71213975","pull_request_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804","_links":{"self":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments/71213975"},"html":{"href":"https://github.com/mavlink/qgroundcontrol/pull/3804#discussion_r71213975"},"pull_request":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804"}}},"pull_request":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804","id":77411319,"html_url":"https://github.com/mavlink/qgroundcontrol/pull/3804","diff_url":"https://github.com/mavlink/qgroundcontrol/pull/3804.diff","patch_url":"https://github.com/mavlink/qgroundcontrol/pull/3804.patch","issue_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/3804","number":3804,"state":"open","locked":false,"title":"Adding Orbit Mode to Guided Bar","user":{"login":"dogmaphobic","id":749243,"avatar_url":"https://avatars.githubusercontent.com/u/749243?v=3","gravatar_id":"","url":"https://api.github.com/users/dogmaphobic","html_url":"https://github.com/dogmaphobic","followers_url":"https://api.github.com/users/dogmaphobic/followers","following_url":"https://api.github.com/users/dogmaphobic/following{/other_user}","gists_url":"https://api.github.com/users/dogmaphobic/gists{/gist_id}","starred_url":"https://api.github.com/users/dogmaphobic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogmaphobic/subscriptions","organizations_url":"https://api.github.com/users/dogmaphobic/orgs","repos_url":"https://api.github.com/users/dogmaphobic/repos","events_url":"https://api.github.com/users/dogmaphobic/events{/privacy}","received_events_url":"https://api.github.com/users/dogmaphobic/received_events","type":"User","site_admin":false},"body":"WIP (in conjunction with https://github.com/PX4/Firmware/pull/4792)\r\n\r\nUntil we figure out a UX to handle these \"smart modes\", I just added a button to the *Guided Bar* to initiate *Orbit Mode*.\r\n\r\nThis needs a corresponding change in the firmware. If used against a different firmware version, it will be simply ignored.\r\n\r\n@tumbili Your newest commit (the current pr-circleMode branch) is not working for some reason. I didn't have a lot of time to debug on the firmware side. The previous commit (691e664f48818844232757b8eb6899579e5f6a0e) is working fine (with the vehicle moving to the assigned radius distance though).\r\n\r\nI also noticed you are not reading in (on the firmware side) parameters other than radius and center coordinates. Note the `PX4FirmwarePlugin::guidedModeOrbit()` function below to see how I setup the parameters. \r\n\r\nThe current UI implementation (pressing the \"Orbit\" button) uses defaults (NAN) to all parameters. There is a commented off version, which sets the orbit center to the map center and a radius of 50m.\r\n\r\n","created_at":"2016-07-14T07:30:06Z","updated_at":"2016-07-18T19:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0a5a0f62d4d87254d24ae65445f23e94ce109b4","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/milestones/11","html_url":"https://github.com/mavlink/qgroundcontrol/milestones/Release%20V3.1","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/milestones/11/labels","id":1474006,"number":11,"title":"Release V3.1","description":null,"creator":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars.githubusercontent.com/u/5876851?v=3","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"open_issues":164,"closed_issues":15,"state":"open","created_at":"2015-12-24T23:53:04Z","updated_at":"2016-07-17T18:36:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804/commits","review_comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804/comments","review_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/3804/comments","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/b7e6281a7efd02f751008985fec682a556983cb8","head":{"label":"dogmaphobic:orbitOnGuidedBar","ref":"orbitOnGuidedBar","sha":"b7e6281a7efd02f751008985fec682a556983cb8","user":{"login":"dogmaphobic","id":749243,"avatar_url":"https://avatars.githubusercontent.com/u/749243?v=3","gravatar_id":"","url":"https://api.github.com/users/dogmaphobic","html_url":"https://github.com/dogmaphobic","followers_url":"https://api.github.com/users/dogmaphobic/followers","following_url":"https://api.github.com/users/dogmaphobic/following{/other_user}","gists_url":"https://api.github.com/users/dogmaphobic/gists{/gist_id}","starred_url":"https://api.github.com/users/dogmaphobic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogmaphobic/subscriptions","organizations_url":"https://api.github.com/users/dogmaphobic/orgs","repos_url":"https://api.github.com/users/dogmaphobic/repos","events_url":"https://api.github.com/users/dogmaphobic/events{/privacy}","received_events_url":"https://api.github.com/users/dogmaphobic/received_events","type":"User","site_admin":false},"repo":{"id":29939414,"name":"qgroundcontrol","full_name":"dogmaphobic/qgroundcontrol","owner":{"login":"dogmaphobic","id":749243,"avatar_url":"https://avatars.githubusercontent.com/u/749243?v=3","gravatar_id":"","url":"https://api.github.com/users/dogmaphobic","html_url":"https://github.com/dogmaphobic","followers_url":"https://api.github.com/users/dogmaphobic/followers","following_url":"https://api.github.com/users/dogmaphobic/following{/other_user}","gists_url":"https://api.github.com/users/dogmaphobic/gists{/gist_id}","starred_url":"https://api.github.com/users/dogmaphobic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogmaphobic/subscriptions","organizations_url":"https://api.github.com/users/dogmaphobic/orgs","repos_url":"https://api.github.com/users/dogmaphobic/repos","events_url":"https://api.github.com/users/dogmaphobic/events{/privacy}","received_events_url":"https://api.github.com/users/dogmaphobic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dogmaphobic/qgroundcontrol","description":"QGroundControl Ground Control Station","fork":true,"url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol","forks_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/dogmaphobic/qgroundcontrol/deployments","created_at":"2015-01-27T23:00:57Z","updated_at":"2016-01-12T21:50:53Z","pushed_at":"2016-07-14T07:12:10Z","git_url":"git://github.com/dogmaphobic/qgroundcontrol.git","ssh_url":"git@github.com:dogmaphobic/qgroundcontrol.git","clone_url":"https://github.com/dogmaphobic/qgroundcontrol.git","svn_url":"https://github.com/dogmaphobic/qgroundcontrol","homepage":"http://qgroundcontrol.org","size":186618,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"b516429073b1c40c11d2d0e71902d1408edc77e8","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":2567844,"name":"qgroundcontrol","full_name":"mavlink/qgroundcontrol","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/qgroundcontrol","description":"QGroundControl Ground Control Station","fork":false,"url":"https://api.github.com/repos/mavlink/qgroundcontrol","forks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/mavlink/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/mavlink/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/qgroundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/deployments","created_at":"2011-10-13T07:31:07Z","updated_at":"2016-07-18T04:05:30Z","pushed_at":"2016-07-18T19:30:23Z","git_url":"git://github.com/mavlink/qgroundcontrol.git","ssh_url":"git@github.com:mavlink/qgroundcontrol.git","clone_url":"https://github.com/mavlink/qgroundcontrol.git","svn_url":"https://github.com/mavlink/qgroundcontrol","homepage":"http://qgroundcontrol.org","size":204650,"stargazers_count":352,"watchers_count":352,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":600,"mirror_url":null,"open_issues_count":342,"forks":600,"open_issues":342,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804"},"html":{"href":"https://github.com/mavlink/qgroundcontrol/pull/3804"},"issue":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/3804"},"comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/3804/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/3804/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/b7e6281a7efd02f751008985fec682a556983cb8"}}}}
{"actor":{"display_login":"DonLakeFlyer"}}