{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/91812735","pull_request_review_id":12326273,"id":91812735,"diff_hunk":"@@ -102,27 +121,66 @@ public OfferRequirement getExistingOfferRequirement(PodInstance podInstance, Lis\n     }\n \n \n-    private List<Protos.TaskInfo> getNewTaskInfos(PodInstance podInstance) throws InvalidRequirementException {\n+    private List<Protos.TaskInfo> getNewTaskInfos(\n+            PodInstance podInstance,\n+            Collection<String> tasksToLaunch) throws InvalidRequirementException {\n+\n+        LOGGER.info(\"Getting new TaskInfos for tasks: {}\", tasksToLaunch);\n+\n+        ArrayList<String> usedResourceSets = new ArrayList<>();\n         List<Protos.TaskInfo> taskInfos = new ArrayList<>();\n+\n+        LOGGER.info(\"Generating TaskInfos to launch.\");\n         for (TaskSpec taskSpec : podInstance.getPod().getTasks()) {\n-            if (taskSpec.getGoal().equals(TaskSpec.GoalState.RUNNING)) {\n-                taskInfos.add(getNewTaskInfo(podInstance, taskSpec));\n+            if (!tasksToLaunch.contains(taskSpec.getName())) {\n+                continue;\n+            }\n+\n+            if (!usedResourceSets.contains(taskSpec.getResourceSet().getId())) {\n+                LOGGER.info(\"Generating taskInfo for: {}\", taskSpec.getName());\n+                Protos.TaskInfo taskInfo = getNewTaskInfo(podInstance, taskSpec);\n+                LOGGER.info(\"Using resource set: {}\", taskSpec.getResourceSet().getId());\n+                usedResourceSets.add(taskSpec.getResourceSet().getId());\n+                taskInfos.add(taskInfo);\n+            }\n+        }\n+\n+        LOGGER.info(\"Generating TaskInfos to complete Pod footprint.\");\n+        for (TaskSpec taskSpec : podInstance.getPod().getTasks()) {\n+            if (tasksToLaunch.contains(taskSpec.getName())) {\n+                continue;\n+            }\n+\n+            if (!usedResourceSets.contains(taskSpec.getResourceSet().getId())) {\n+                LOGGER.info(\"Generating taskInfo for: {}\", taskSpec.getName());\n+                Protos.TaskInfo taskInfo = getNewTaskInfo(podInstance, taskSpec);\n+                LOGGER.info(\"Marking as transient: {}\", taskSpec.getName());\n+                taskInfo = TaskUtils.setTransient(taskInfo);\n+                LOGGER.info(\"Using resource set: {}\", taskSpec.getResourceSet().getId());","path":"sdk/scheduler/src/main/java/org/apache/mesos/offer/DefaultOfferRequirementProvider.java","position":117,"original_position":117,"commit_id":"53b585052830accb9b5b743f93865b4dd8f71559","original_commit_id":"53b585052830accb9b5b743f93865b4dd8f71559","user":{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars.githubusercontent.com/u/567111?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-12-09T23:03:20Z","updated_at":"2016-12-09T23:03:20Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/374#discussion_r91812735","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/91812735"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/374#discussion_r91812735"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374","id":97359796,"html_url":"https://github.com/mesosphere/dcos-commons/pull/374","diff_url":"https://github.com/mesosphere/dcos-commons/pull/374.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/374.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/374","number":374,"state":"open","locked":false,"title":"Hdfs better","user":{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars.githubusercontent.com/u/567111?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-09T18:46:42Z","updated_at":"2016-12-09T23:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"nickbp","id":35933,"avatar_url":"https://avatars.githubusercontent.com/u/35933?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false},"assignees":[{"login":"nickbp","id":35933,"avatar_url":"https://avatars.githubusercontent.com/u/35933?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/374/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/53b585052830accb9b5b743f93865b4dd8f71559","head":{"label":"mesosphere:hdfs_better","ref":"hdfs_better","sha":"53b585052830accb9b5b743f93865b4dd8f71559","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":null,"fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2016-12-04T11:18:57Z","pushed_at":"2016-12-09T18:46:42Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":null,"size":39887,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":19,"forks":19,"open_issues":19,"watchers":29,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"cc183d3a117c74e5ff37475e3daa162acd7c99d4","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":null,"fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2016-12-04T11:18:57Z","pushed_at":"2016-12-09T18:46:42Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":null,"size":39887,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":19,"forks":19,"open_issues":19,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/374"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/374"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/53b585052830accb9b5b743f93865b4dd8f71559"}}}}
{"actor":{"display_login":"gabrielhartmann"}}