{"action":"closed","issue":{"url":"https://api.github.com/repos/FNA-XNA/FNA/issues/66","repository_url":"https://api.github.com/repos/FNA-XNA/FNA","labels_url":"https://api.github.com/repos/FNA-XNA/FNA/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/FNA-XNA/FNA/issues/66/comments","events_url":"https://api.github.com/repos/FNA-XNA/FNA/issues/66/events","html_url":"https://github.com/FNA-XNA/FNA/issues/66","id":186458093,"number":66,"title":"Vector2 == should not use epsilon check","user":{"login":"TrevorSundberg","id":4644253,"avatar_url":"https://avatars.githubusercontent.com/u/4644253?v=3","gravatar_id":"","url":"https://api.github.com/users/TrevorSundberg","html_url":"https://github.com/TrevorSundberg","followers_url":"https://api.github.com/users/TrevorSundberg/followers","following_url":"https://api.github.com/users/TrevorSundberg/following{/other_user}","gists_url":"https://api.github.com/users/TrevorSundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/TrevorSundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrevorSundberg/subscriptions","organizations_url":"https://api.github.com/users/TrevorSundberg/orgs","repos_url":"https://api.github.com/users/TrevorSundberg/repos","events_url":"https://api.github.com/users/TrevorSundberg/events{/privacy}","received_events_url":"https://api.github.com/users/TrevorSundberg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-01T04:42:50Z","updated_at":"2016-11-01T05:33:37Z","closed_at":"2016-11-01T05:33:37Z","body":"I know from experience that the best way to get your bugs solved is to be positive, so right off the bat, I love FNA!\r\n\r\nNow to the point, XNA does not use epsilon checks when comparing Vectors (Equals and operator==), it uses the built in floating point equality which has a well defined behavior.\r\n\r\nI know the reasoning behind floating point epsilons, however generally they should only be applied on a case by case basis, rather than a blanket over all floating point comparisons.\r\n\r\nThe current implementation causes unexpected behaviors, such as comparing a Vector2 initialized with Single.PositiveInfinity to compare incorrectly with itself (infinity comparison is well defined). Another example is if you were to use the Vector2 as a key in a Dictionary, the GetHashCode becomes inconsistent with the equality tests."}}
{"actor":{"display_login":"flibitijibibo"}}