{"action":"created","comment":{"url":"https://api.github.com/repos/php-edifact/edifact/pulls/comments/88903517","pull_request_review_id":9460518,"id":88903517,"diff_hunk":"@@ -31,41 +64,80 @@ public function encode($arr, $wrap = true)\n                 $edistring .= \"\\n\";\n             }\n         }\n+        $this->output = $edistring;\n         return $edistring;\n     }\n \n-    public function encodeSegment($row)\n-    {\n-        $str='';\n+    public function encodeSegment($row) {\n+        $str = '';\n         $t = count($row);\n-        for ($i=0; $i<$t; $i++) {\n+        for ($i = 0; $i < $t; $i++) {\n             $elm = '';\n             if (!is_array($row[$i])) {\n                 $elm = $this->escapeValue($row[$i]);\n             } else {\n                 foreach ($row[$i] as &$temp) {\n                     $temp = $this->escapeValue($temp);\n+                    //var_dump($temp);\n                 }\n-                $elm = implode(\":\", $row[$i]);\n+                $elm = implode($this->sep_comp, $row[$i]);\n             }\n             $str .= $elm;\n-            if ($i == $t-1) {\n+            if ($i == $t - 1) {\n                 break;\n             }\n-            $str .= \"+\";\n+            $str .= $this->sep_data;\n         }\n-        $str .= \"'\";\n+        $str .= $this->symb_end;\n         return $str;\n     }\n \n-    private function escapeValue($str)\n-    {\n+//    private function escapeValue($str) {","path":"src/EDI/Encoder.php","position":109,"original_position":109,"commit_id":"a6af915614de6727f62f532d4bedd6fc836e87b4","original_commit_id":"60433d9e8b3dbeccd038b4f3f17d638c521345d5","user":{"login":"sabas","id":1304918,"avatar_url":"https://avatars.githubusercontent.com/u/1304918?v=3","gravatar_id":"","url":"https://api.github.com/users/sabas","html_url":"https://github.com/sabas","followers_url":"https://api.github.com/users/sabas/followers","following_url":"https://api.github.com/users/sabas/following{/other_user}","gists_url":"https://api.github.com/users/sabas/gists{/gist_id}","starred_url":"https://api.github.com/users/sabas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabas/subscriptions","organizations_url":"https://api.github.com/users/sabas/orgs","repos_url":"https://api.github.com/users/sabas/repos","events_url":"https://api.github.com/users/sabas/events{/privacy}","received_events_url":"https://api.github.com/users/sabas/received_events","type":"User","site_admin":false},"body":"This commented out version is here to be tested?","created_at":"2016-11-21T14:25:00Z","updated_at":"2016-11-21T14:25:00Z","html_url":"https://github.com/php-edifact/edifact/pull/53#discussion_r88903517","pull_request_url":"https://api.github.com/repos/php-edifact/edifact/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/comments/88903517"},"html":{"href":"https://github.com/php-edifact/edifact/pull/53#discussion_r88903517"},"pull_request":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/php-edifact/edifact/pulls/53","id":94614176,"html_url":"https://github.com/php-edifact/edifact/pull/53","diff_url":"https://github.com/php-edifact/edifact/pull/53.diff","patch_url":"https://github.com/php-edifact/edifact/pull/53.patch","issue_url":"https://api.github.com/repos/php-edifact/edifact/issues/53","number":53,"state":"open","locked":false,"title":"Parser UNOC support + Encoder UNA segment support","user":{"login":"homer8173","id":8720867,"avatar_url":"https://avatars.githubusercontent.com/u/8720867?v=3","gravatar_id":"","url":"https://api.github.com/users/homer8173","html_url":"https://github.com/homer8173","followers_url":"https://api.github.com/users/homer8173/followers","following_url":"https://api.github.com/users/homer8173/following{/other_user}","gists_url":"https://api.github.com/users/homer8173/gists{/gist_id}","starred_url":"https://api.github.com/users/homer8173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homer8173/subscriptions","organizations_url":"https://api.github.com/users/homer8173/orgs","repos_url":"https://api.github.com/users/homer8173/repos","events_url":"https://api.github.com/users/homer8173/events{/privacy}","received_events_url":"https://api.github.com/users/homer8173/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-21T13:23:20Z","updated_at":"2016-11-21T14:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67ab3f5cb59c0167566be12cf6ec0569d5ab53b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-edifact/edifact/pulls/53/commits","review_comments_url":"https://api.github.com/repos/php-edifact/edifact/pulls/53/comments","review_comment_url":"https://api.github.com/repos/php-edifact/edifact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-edifact/edifact/issues/53/comments","statuses_url":"https://api.github.com/repos/php-edifact/edifact/statuses/a6af915614de6727f62f532d4bedd6fc836e87b4","head":{"label":"homer8173:master","ref":"master","sha":"a6af915614de6727f62f532d4bedd6fc836e87b4","user":{"login":"homer8173","id":8720867,"avatar_url":"https://avatars.githubusercontent.com/u/8720867?v=3","gravatar_id":"","url":"https://api.github.com/users/homer8173","html_url":"https://github.com/homer8173","followers_url":"https://api.github.com/users/homer8173/followers","following_url":"https://api.github.com/users/homer8173/following{/other_user}","gists_url":"https://api.github.com/users/homer8173/gists{/gist_id}","starred_url":"https://api.github.com/users/homer8173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homer8173/subscriptions","organizations_url":"https://api.github.com/users/homer8173/orgs","repos_url":"https://api.github.com/users/homer8173/repos","events_url":"https://api.github.com/users/homer8173/events{/privacy}","received_events_url":"https://api.github.com/users/homer8173/received_events","type":"User","site_admin":false},"repo":{"id":67794675,"name":"edifact","full_name":"homer8173/edifact","owner":{"login":"homer8173","id":8720867,"avatar_url":"https://avatars.githubusercontent.com/u/8720867?v=3","gravatar_id":"","url":"https://api.github.com/users/homer8173","html_url":"https://github.com/homer8173","followers_url":"https://api.github.com/users/homer8173/followers","following_url":"https://api.github.com/users/homer8173/following{/other_user}","gists_url":"https://api.github.com/users/homer8173/gists{/gist_id}","starred_url":"https://api.github.com/users/homer8173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homer8173/subscriptions","organizations_url":"https://api.github.com/users/homer8173/orgs","repos_url":"https://api.github.com/users/homer8173/repos","events_url":"https://api.github.com/users/homer8173/events{/privacy}","received_events_url":"https://api.github.com/users/homer8173/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/homer8173/edifact","description":"Tools to process EDI messages in UN/EDIFACT format","fork":true,"url":"https://api.github.com/repos/homer8173/edifact","forks_url":"https://api.github.com/repos/homer8173/edifact/forks","keys_url":"https://api.github.com/repos/homer8173/edifact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homer8173/edifact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homer8173/edifact/teams","hooks_url":"https://api.github.com/repos/homer8173/edifact/hooks","issue_events_url":"https://api.github.com/repos/homer8173/edifact/issues/events{/number}","events_url":"https://api.github.com/repos/homer8173/edifact/events","assignees_url":"https://api.github.com/repos/homer8173/edifact/assignees{/user}","branches_url":"https://api.github.com/repos/homer8173/edifact/branches{/branch}","tags_url":"https://api.github.com/repos/homer8173/edifact/tags","blobs_url":"https://api.github.com/repos/homer8173/edifact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homer8173/edifact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homer8173/edifact/git/refs{/sha}","trees_url":"https://api.github.com/repos/homer8173/edifact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homer8173/edifact/statuses/{sha}","languages_url":"https://api.github.com/repos/homer8173/edifact/languages","stargazers_url":"https://api.github.com/repos/homer8173/edifact/stargazers","contributors_url":"https://api.github.com/repos/homer8173/edifact/contributors","subscribers_url":"https://api.github.com/repos/homer8173/edifact/subscribers","subscription_url":"https://api.github.com/repos/homer8173/edifact/subscription","commits_url":"https://api.github.com/repos/homer8173/edifact/commits{/sha}","git_commits_url":"https://api.github.com/repos/homer8173/edifact/git/commits{/sha}","comments_url":"https://api.github.com/repos/homer8173/edifact/comments{/number}","issue_comment_url":"https://api.github.com/repos/homer8173/edifact/issues/comments{/number}","contents_url":"https://api.github.com/repos/homer8173/edifact/contents/{+path}","compare_url":"https://api.github.com/repos/homer8173/edifact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homer8173/edifact/merges","archive_url":"https://api.github.com/repos/homer8173/edifact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homer8173/edifact/downloads","issues_url":"https://api.github.com/repos/homer8173/edifact/issues{/number}","pulls_url":"https://api.github.com/repos/homer8173/edifact/pulls{/number}","milestones_url":"https://api.github.com/repos/homer8173/edifact/milestones{/number}","notifications_url":"https://api.github.com/repos/homer8173/edifact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homer8173/edifact/labels{/name}","releases_url":"https://api.github.com/repos/homer8173/edifact/releases{/id}","deployments_url":"https://api.github.com/repos/homer8173/edifact/deployments","created_at":"2016-09-09T11:48:14Z","updated_at":"2016-09-09T11:48:15Z","pushed_at":"2016-11-21T13:19:07Z","git_url":"git://github.com/homer8173/edifact.git","ssh_url":"git@github.com:homer8173/edifact.git","clone_url":"https://github.com/homer8173/edifact.git","svn_url":"https://github.com/homer8173/edifact","homepage":null,"size":1718,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-edifact:master","ref":"master","sha":"67d6e6f7dc3e533e0e0922bd437709d6d925f7c7","user":{"login":"php-edifact","id":19282682,"avatar_url":"https://avatars.githubusercontent.com/u/19282682?v=3","gravatar_id":"","url":"https://api.github.com/users/php-edifact","html_url":"https://github.com/php-edifact","followers_url":"https://api.github.com/users/php-edifact/followers","following_url":"https://api.github.com/users/php-edifact/following{/other_user}","gists_url":"https://api.github.com/users/php-edifact/gists{/gist_id}","starred_url":"https://api.github.com/users/php-edifact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-edifact/subscriptions","organizations_url":"https://api.github.com/users/php-edifact/orgs","repos_url":"https://api.github.com/users/php-edifact/repos","events_url":"https://api.github.com/users/php-edifact/events{/privacy}","received_events_url":"https://api.github.com/users/php-edifact/received_events","type":"Organization","site_admin":false},"repo":{"id":14014481,"name":"edifact","full_name":"php-edifact/edifact","owner":{"login":"php-edifact","id":19282682,"avatar_url":"https://avatars.githubusercontent.com/u/19282682?v=3","gravatar_id":"","url":"https://api.github.com/users/php-edifact","html_url":"https://github.com/php-edifact","followers_url":"https://api.github.com/users/php-edifact/followers","following_url":"https://api.github.com/users/php-edifact/following{/other_user}","gists_url":"https://api.github.com/users/php-edifact/gists{/gist_id}","starred_url":"https://api.github.com/users/php-edifact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-edifact/subscriptions","organizations_url":"https://api.github.com/users/php-edifact/orgs","repos_url":"https://api.github.com/users/php-edifact/repos","events_url":"https://api.github.com/users/php-edifact/events{/privacy}","received_events_url":"https://api.github.com/users/php-edifact/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-edifact/edifact","description":"Tools to process EDI messages in UN/EDIFACT format","fork":false,"url":"https://api.github.com/repos/php-edifact/edifact","forks_url":"https://api.github.com/repos/php-edifact/edifact/forks","keys_url":"https://api.github.com/repos/php-edifact/edifact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-edifact/edifact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-edifact/edifact/teams","hooks_url":"https://api.github.com/repos/php-edifact/edifact/hooks","issue_events_url":"https://api.github.com/repos/php-edifact/edifact/issues/events{/number}","events_url":"https://api.github.com/repos/php-edifact/edifact/events","assignees_url":"https://api.github.com/repos/php-edifact/edifact/assignees{/user}","branches_url":"https://api.github.com/repos/php-edifact/edifact/branches{/branch}","tags_url":"https://api.github.com/repos/php-edifact/edifact/tags","blobs_url":"https://api.github.com/repos/php-edifact/edifact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-edifact/edifact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-edifact/edifact/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-edifact/edifact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-edifact/edifact/statuses/{sha}","languages_url":"https://api.github.com/repos/php-edifact/edifact/languages","stargazers_url":"https://api.github.com/repos/php-edifact/edifact/stargazers","contributors_url":"https://api.github.com/repos/php-edifact/edifact/contributors","subscribers_url":"https://api.github.com/repos/php-edifact/edifact/subscribers","subscription_url":"https://api.github.com/repos/php-edifact/edifact/subscription","commits_url":"https://api.github.com/repos/php-edifact/edifact/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-edifact/edifact/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-edifact/edifact/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-edifact/edifact/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-edifact/edifact/contents/{+path}","compare_url":"https://api.github.com/repos/php-edifact/edifact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-edifact/edifact/merges","archive_url":"https://api.github.com/repos/php-edifact/edifact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-edifact/edifact/downloads","issues_url":"https://api.github.com/repos/php-edifact/edifact/issues{/number}","pulls_url":"https://api.github.com/repos/php-edifact/edifact/pulls{/number}","milestones_url":"https://api.github.com/repos/php-edifact/edifact/milestones{/number}","notifications_url":"https://api.github.com/repos/php-edifact/edifact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-edifact/edifact/labels{/name}","releases_url":"https://api.github.com/repos/php-edifact/edifact/releases{/id}","deployments_url":"https://api.github.com/repos/php-edifact/edifact/deployments","created_at":"2013-10-31T11:00:16Z","updated_at":"2016-11-10T19:19:45Z","pushed_at":"2016-11-21T13:23:21Z","git_url":"git://github.com/php-edifact/edifact.git","ssh_url":"git@github.com:php-edifact/edifact.git","clone_url":"https://github.com/php-edifact/edifact.git","svn_url":"https://github.com/php-edifact/edifact","homepage":null,"size":1786,"stargazers_count":58,"watchers_count":58,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":4,"forks":26,"open_issues":4,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/53"},"html":{"href":"https://github.com/php-edifact/edifact/pull/53"},"issue":{"href":"https://api.github.com/repos/php-edifact/edifact/issues/53"},"comments":{"href":"https://api.github.com/repos/php-edifact/edifact/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-edifact/edifact/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/php-edifact/edifact/statuses/a6af915614de6727f62f532d4bedd6fc836e87b4"}}}}
{"actor":{"display_login":"sabas"}}