{"action":"created","issue":{"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/310","repository_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial","labels_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/310/comments","events_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/310/events","html_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/310","id":168234467,"number":310,"title":"[Possible No-op] Adjust Procfiles for compatibility with both foreman and forego","user":{"login":"zph","id":1026584,"avatar_url":"https://avatars.githubusercontent.com/u/1026584?v=3","gravatar_id":"","url":"https://api.github.com/users/zph","html_url":"https://github.com/zph","followers_url":"https://api.github.com/users/zph/followers","following_url":"https://api.github.com/users/zph/following{/other_user}","gists_url":"https://api.github.com/users/zph/gists{/gist_id}","starred_url":"https://api.github.com/users/zph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zph/subscriptions","organizations_url":"https://api.github.com/users/zph/orgs","repos_url":"https://api.github.com/users/zph/repos","events_url":"https://api.github.com/users/zph/events{/privacy}","received_events_url":"https://api.github.com/users/zph/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-29T01:51:51Z","updated_at":"2016-07-29T16:33:14Z","closed_at":"2016-07-29T16:33:14Z","pull_request":{"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/310","html_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/310","diff_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/310.diff","patch_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/310.patch"},"body":"First off, thanks for all your work on this project :).\r\n\r\nforego doesn't allow - in the name of processes. This allows both\r\nforeman and forego to work with these procfiles.\r\n\r\nLink to regex in forego looks like it should work for dashes:\r\nhttps://github.com/ddollar/forego/blob/master/procfile.go#L12. But\r\ntesting on my OSX dev machine using forego 0.16.1 (latest) shows it\r\nfail to parse any of them beyond the `rails` entry. I also tried\r\nrearranging order of entries in Procfiles, with same issue.\r\n\r\nI'll take a look in forego to see if it should be fixed upstream, but\r\nwanted to log this here in case anyone else get stumped for a bit trying\r\nto debug this :).\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/shakacode/react-webpack-rails-tutorial/310)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/comments/236228694","html_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/310#issuecomment-236228694","issue_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/310","id":236228694,"user":{"login":"zph","id":1026584,"avatar_url":"https://avatars.githubusercontent.com/u/1026584?v=3","gravatar_id":"","url":"https://api.github.com/users/zph","html_url":"https://github.com/zph","followers_url":"https://api.github.com/users/zph/followers","following_url":"https://api.github.com/users/zph/following{/other_user}","gists_url":"https://api.github.com/users/zph/gists{/gist_id}","starred_url":"https://api.github.com/users/zph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zph/subscriptions","organizations_url":"https://api.github.com/users/zph/orgs","repos_url":"https://api.github.com/users/zph/repos","events_url":"https://api.github.com/users/zph/events{/privacy}","received_events_url":"https://api.github.com/users/zph/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T16:33:14Z","updated_at":"2016-07-29T16:33:14Z","body":"Filed in forego: https://github.com/ddollar/forego/issues/87\r\n\r\nWith forego's master copy, the existing Procfiles work if the rails entry is also wrapped in a `sh -c`. With master's forego, the dashes work ^_^.\r\n\r\nClosing and will re-open if there's something actionable here.\r\n\r\nMahalo."}}
{"actor":{"display_login":"zph"}}