{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16388","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16388/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16388/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16388/events","html_url":"https://github.com/cms-sw/cmssw/pull/16388","id":186090208,"number":16388,"title":"fix unnecessary ptr copy in HcalObjects","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881671,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":1792,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-10-29T17:26:02Z","due_on":"2016-11-01T00:00:00Z","closed_at":null},"comments":2,"created_at":"2016-10-29T17:25:48Z","updated_at":"2016-10-29T17:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16388","html_url":"https://github.com/cms-sw/cmssw/pull/16388","diff_url":"https://github.com/cms-sw/cmssw/pull/16388.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16388.patch"},"body":"@slava77 followup to https://github.com/cms-sw/cmssw/pull/15959#issuecomment-256348080, this propagates the fix from https://github.com/cms-sw/cmssw/commit/df0c1b3a3f41c978caa40b76f0b0f9240170be58 to all other affected classes in `CondFormats/HcalObjects`. CPU usage in `HBHEIsolatedNoiseReflagger` is reduced dramatically (igprof output from step3 of WF 10024.0):\r\n```\r\nCMSSW_8_1_X_2016-10-27-1100:             0.1  .........       0.13 / 0.13         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [2893]\r\n                    PR15959:             0.1  .........       0.26 / 0.26         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [1932]\r\n                     fixptr:             0.0  .........       0.02 / 0.02         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [6527]\r\n             fixptr+PR15959:             0.0  .........       0.04 / 0.04         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [5496]\r\n```\r\n\r\nattn: @igv4321"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/257104299","html_url":"https://github.com/cms-sw/cmssw/pull/16388#issuecomment-257104299","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16388","id":257104299,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T17:26:44Z","updated_at":"2016-10-29T17:26:44Z","body":"The tests are being triggered in jenkins."}}
{"actor":{"display_login":"cmsbuild"}}