{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/61891736","id":61891736,"diff_hunk":"@@ -0,0 +1,154 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package v1alpha1\n+\n+import (\n+\t\"k8s.io/kubernetes/pkg/api/unversioned\"\n+\t\"k8s.io/kubernetes/pkg/api/v1\"\n+\t\"k8s.io/kubernetes/pkg/runtime\"\n+)\n+\n+// Authorization is calculated against\n+// 1. all deny RoleBinding PolicyRules in the master namespace - short circuit on match","path":"pkg/apis/rbac/v1alpha1/types.go","position":26,"original_position":26,"commit_id":"a8c3183b5e2bdfd6d869c893c2209067dc3766e9","original_commit_id":"d517901a0c6e14c0a2e210bd34177059f0b92909","user":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"body":"Verify this comment is correct?","created_at":"2016-05-03T14:37:08Z","updated_at":"2016-05-03T14:37:08Z","html_url":"https://github.com/kubernetes/kubernetes/pull/24900#discussion_r61891736","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/61891736"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24900#discussion_r61891736"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900","id":68147926,"html_url":"https://github.com/kubernetes/kubernetes/pull/24900","diff_url":"https://github.com/kubernetes/kubernetes/pull/24900.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/24900.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24900","number":24900,"state":"open","locked":false,"title":"Add Openshift RBAC authz types to API [WIP]","user":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"body":"This PR updates #23396 by adding the Openshift RBAC types to a new API group.\r\n\r\nChanges from Openshift:\r\n\r\n* Omission of [ResourceGroups](https://github.com/openshift/origin/blob/458998788337e983fa3e5f9a837664ec00a89204/pkg/authorization/api/types.go#L32-L104) as most of these were Openshift specific. Would like to add the concept back in for a later release of the API.\r\n* Omission of IsPersonalSubjectAccessReview as its implementation relied on Openshift capability.\r\n* Omission of SubjectAccessReview and ResourceAccessReview types. These are defined in `authorization.k8s.io`\r\n\r\n~~API group is named `rbac.authorization.openshift.com` as we omitted the AccessReview stuff and that seemed to be the lest controversial based on conversations in #23396. Would be happy to change it if there's a dislike for the name.~~ Edit: API groups is named `rbac`, sorry misread the original thread.\r\n\r\nAs discussed in #18762, creating a new API group is kind difficult right now and the documentation is very out of date. Got a little help from @soltysh but I'm sure I'm missing some things. Also still need to add validation and a RESTStorage registry interface. Hence \"WIP\".\r\n\r\nAny initial comments welcome.\r\n\r\ncc @erictune @deads2k @sym3tri @philips","created_at":"2016-04-28T00:42:05Z","updated_at":"2016-05-03T14:37:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab07e9ba8c9f01fbd2f5340ed710b1dbe70e6a40","assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24900/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a8c3183b5e2bdfd6d869c893c2209067dc3766e9","head":{"label":"ericchiang:rbac_types","ref":"rbac_types","sha":"a8c3183b5e2bdfd6d869c893c2209067dc3766e9","user":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"repo":{"id":47780236,"name":"kubernetes","full_name":"ericchiang/kubernetes","owner":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericchiang/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/ericchiang/kubernetes","forks_url":"https://api.github.com/repos/ericchiang/kubernetes/forks","keys_url":"https://api.github.com/repos/ericchiang/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericchiang/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericchiang/kubernetes/teams","hooks_url":"https://api.github.com/repos/ericchiang/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ericchiang/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ericchiang/kubernetes/events","assignees_url":"https://api.github.com/repos/ericchiang/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ericchiang/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ericchiang/kubernetes/tags","blobs_url":"https://api.github.com/repos/ericchiang/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericchiang/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericchiang/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericchiang/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericchiang/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ericchiang/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ericchiang/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ericchiang/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ericchiang/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ericchiang/kubernetes/subscription","commits_url":"https://api.github.com/repos/ericchiang/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericchiang/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericchiang/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericchiang/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericchiang/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ericchiang/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericchiang/kubernetes/merges","archive_url":"https://api.github.com/repos/ericchiang/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericchiang/kubernetes/downloads","issues_url":"https://api.github.com/repos/ericchiang/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ericchiang/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ericchiang/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ericchiang/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericchiang/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ericchiang/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ericchiang/kubernetes/deployments","created_at":"2015-12-10T18:35:52Z","updated_at":"2016-01-25T23:01:45Z","pushed_at":"2016-05-03T04:29:56Z","git_url":"git://github.com/ericchiang/kubernetes.git","ssh_url":"git@github.com:ericchiang/kubernetes.git","clone_url":"https://github.com/ericchiang/kubernetes.git","svn_url":"https://github.com/ericchiang/kubernetes","homepage":"http://kubernetes.io","size":187847,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c53d3e1e262c3365f8cc6277be5025e4d94bb53b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-03T14:14:13Z","pushed_at":"2016-05-03T14:34:17Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":389879,"stargazers_count":14183,"watchers_count":14183,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4233,"mirror_url":null,"open_issues_count":3543,"forks":4233,"open_issues":3543,"watchers":14183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24900"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24900"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24900/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24900/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a8c3183b5e2bdfd6d869c893c2209067dc3766e9"}}}}