{"action":"created","comment":{"url":"https://api.github.com/repos/Points/PyLCP/pulls/comments/55045424","id":55045424,"diff_hunk":"@@ -5,8 +5,8 @@ python:\n   - \"3.4\"\n   - \"3.5\"\n install:\n-  - \"pip install -r requirements.txt\"\n-  - \"pip install -r requirements-dev.txt\"\n+  - \"pip install -U pip\"","path":".travis.yml","position":null,"original_position":6,"commit_id":"be7d9c52e42c43d224192fb1c39562fbc530b6a6","original_commit_id":"0aa7baaf632a3d5d573aa442dc1d55e11c2fbb99","user":{"login":"biniambekele","id":9507109,"avatar_url":"https://avatars.githubusercontent.com/u/9507109?v=3","gravatar_id":"","url":"https://api.github.com/users/biniambekele","html_url":"https://github.com/biniambekele","followers_url":"https://api.github.com/users/biniambekele/followers","following_url":"https://api.github.com/users/biniambekele/following{/other_user}","gists_url":"https://api.github.com/users/biniambekele/gists{/gist_id}","starred_url":"https://api.github.com/users/biniambekele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biniambekele/subscriptions","organizations_url":"https://api.github.com/users/biniambekele/orgs","repos_url":"https://api.github.com/users/biniambekele/repos","events_url":"https://api.github.com/users/biniambekele/events{/privacy}","received_events_url":"https://api.github.com/users/biniambekele/received_events","type":"User","site_admin":false},"body":"@dorianpula Done","created_at":"2016-03-04T15:44:29Z","updated_at":"2016-03-04T15:44:29Z","html_url":"https://github.com/Points/PyLCP/pull/46#discussion_r55045424","pull_request_url":"https://api.github.com/repos/Points/PyLCP/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/comments/55045424"},"html":{"href":"https://github.com/Points/PyLCP/pull/46#discussion_r55045424"},"pull_request":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/Points/PyLCP/pulls/46","id":61719401,"html_url":"https://github.com/Points/PyLCP/pull/46","diff_url":"https://github.com/Points/PyLCP/pull/46.diff","patch_url":"https://github.com/Points/PyLCP/pull/46.patch","issue_url":"https://api.github.com/repos/Points/PyLCP/issues/46","number":46,"state":"open","locked":false,"title":"DPPTSBGTC-2838 Use setup(extras_require...) instead of requirements.txt.","user":{"login":"biniambekele","id":9507109,"avatar_url":"https://avatars.githubusercontent.com/u/9507109?v=3","gravatar_id":"","url":"https://api.github.com/users/biniambekele","html_url":"https://github.com/biniambekele","followers_url":"https://api.github.com/users/biniambekele/followers","following_url":"https://api.github.com/users/biniambekele/following{/other_user}","gists_url":"https://api.github.com/users/biniambekele/gists{/gist_id}","starred_url":"https://api.github.com/users/biniambekele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biniambekele/subscriptions","organizations_url":"https://api.github.com/users/biniambekele/orgs","repos_url":"https://api.github.com/users/biniambekele/repos","events_url":"https://api.github.com/users/biniambekele/events{/privacy}","received_events_url":"https://api.github.com/users/biniambekele/received_events","type":"User","site_admin":false},"body":"See DPPTSBGTC-2838.\r\n\r\n``setup.py#read_requirements()`` fails while parsing the first line of \"requirements-dev.txt\", because it does not correctly handle the content \"-r requirements.txt\".\r\n\r\nThis PR implements the second suggested fix in the sub-task description:\r\n> Alternatively, instead of fixing ``read_requirements()``, we can eschew the requirements.txt files entirely by leveraging [extras_require](https://pythonhosted.org/setuptools/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies).\r\n\r\nThis is the other proposed solution is:\r\n```bash\r\n$ python -c \"\\\r\n> def read_requirements(file_path):\r\n>     lines = pkg_resources.resource_string(__name__, file_path).splitlines()\r\n>     return clean_requirements(lines)\r\n> \r\n> def clean_requirements(lines):\r\n>     lines = (line.strip() for line in lines)\r\n>     lines = (line for line in lines if line)\r\n>     lines = (line.split()[0].strip() for line in lines)\r\n>     return [line for line in lines if line[0] not in ('-', '#')]\r\n> \r\n> if __name__ == '__main__':\r\n>     sample = (\r\n>         '-r requirements.txt',\r\n>         '--index-url',\r\n>         ' good ',\r\n>         'great #bad',\r\n>         '# bad',\r\n>         '',\r\n>         ' ',\r\n>     )\r\n>     assert clean_requirements(sample) == ['good', 'great']\r\n>     print('OK')\"\r\nOK\r\n```","created_at":"2016-03-04T14:34:14Z","updated_at":"2016-03-04T15:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd315f3bc7f0026807f1d23599b766134bd55732","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Points/PyLCP/pulls/46/commits","review_comments_url":"https://api.github.com/repos/Points/PyLCP/pulls/46/comments","review_comment_url":"https://api.github.com/repos/Points/PyLCP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Points/PyLCP/issues/46/comments","statuses_url":"https://api.github.com/repos/Points/PyLCP/statuses/be7d9c52e42c43d224192fb1c39562fbc530b6a6","head":{"label":"biniambekele:DPPTSBGTC-2838-remove-requirements-txt","ref":"DPPTSBGTC-2838-remove-requirements-txt","sha":"be7d9c52e42c43d224192fb1c39562fbc530b6a6","user":{"login":"biniambekele","id":9507109,"avatar_url":"https://avatars.githubusercontent.com/u/9507109?v=3","gravatar_id":"","url":"https://api.github.com/users/biniambekele","html_url":"https://github.com/biniambekele","followers_url":"https://api.github.com/users/biniambekele/followers","following_url":"https://api.github.com/users/biniambekele/following{/other_user}","gists_url":"https://api.github.com/users/biniambekele/gists{/gist_id}","starred_url":"https://api.github.com/users/biniambekele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biniambekele/subscriptions","organizations_url":"https://api.github.com/users/biniambekele/orgs","repos_url":"https://api.github.com/users/biniambekele/repos","events_url":"https://api.github.com/users/biniambekele/events{/privacy}","received_events_url":"https://api.github.com/users/biniambekele/received_events","type":"User","site_admin":false},"repo":{"id":53084914,"name":"PyLCP","full_name":"biniambekele/PyLCP","owner":{"login":"biniambekele","id":9507109,"avatar_url":"https://avatars.githubusercontent.com/u/9507109?v=3","gravatar_id":"","url":"https://api.github.com/users/biniambekele","html_url":"https://github.com/biniambekele","followers_url":"https://api.github.com/users/biniambekele/followers","following_url":"https://api.github.com/users/biniambekele/following{/other_user}","gists_url":"https://api.github.com/users/biniambekele/gists{/gist_id}","starred_url":"https://api.github.com/users/biniambekele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biniambekele/subscriptions","organizations_url":"https://api.github.com/users/biniambekele/orgs","repos_url":"https://api.github.com/users/biniambekele/repos","events_url":"https://api.github.com/users/biniambekele/events{/privacy}","received_events_url":"https://api.github.com/users/biniambekele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biniambekele/PyLCP","description":"","fork":true,"url":"https://api.github.com/repos/biniambekele/PyLCP","forks_url":"https://api.github.com/repos/biniambekele/PyLCP/forks","keys_url":"https://api.github.com/repos/biniambekele/PyLCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biniambekele/PyLCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biniambekele/PyLCP/teams","hooks_url":"https://api.github.com/repos/biniambekele/PyLCP/hooks","issue_events_url":"https://api.github.com/repos/biniambekele/PyLCP/issues/events{/number}","events_url":"https://api.github.com/repos/biniambekele/PyLCP/events","assignees_url":"https://api.github.com/repos/biniambekele/PyLCP/assignees{/user}","branches_url":"https://api.github.com/repos/biniambekele/PyLCP/branches{/branch}","tags_url":"https://api.github.com/repos/biniambekele/PyLCP/tags","blobs_url":"https://api.github.com/repos/biniambekele/PyLCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biniambekele/PyLCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biniambekele/PyLCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/biniambekele/PyLCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biniambekele/PyLCP/statuses/{sha}","languages_url":"https://api.github.com/repos/biniambekele/PyLCP/languages","stargazers_url":"https://api.github.com/repos/biniambekele/PyLCP/stargazers","contributors_url":"https://api.github.com/repos/biniambekele/PyLCP/contributors","subscribers_url":"https://api.github.com/repos/biniambekele/PyLCP/subscribers","subscription_url":"https://api.github.com/repos/biniambekele/PyLCP/subscription","commits_url":"https://api.github.com/repos/biniambekele/PyLCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/biniambekele/PyLCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/biniambekele/PyLCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/biniambekele/PyLCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/biniambekele/PyLCP/contents/{+path}","compare_url":"https://api.github.com/repos/biniambekele/PyLCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biniambekele/PyLCP/merges","archive_url":"https://api.github.com/repos/biniambekele/PyLCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biniambekele/PyLCP/downloads","issues_url":"https://api.github.com/repos/biniambekele/PyLCP/issues{/number}","pulls_url":"https://api.github.com/repos/biniambekele/PyLCP/pulls{/number}","milestones_url":"https://api.github.com/repos/biniambekele/PyLCP/milestones{/number}","notifications_url":"https://api.github.com/repos/biniambekele/PyLCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biniambekele/PyLCP/labels{/name}","releases_url":"https://api.github.com/repos/biniambekele/PyLCP/releases{/id}","deployments_url":"https://api.github.com/repos/biniambekele/PyLCP/deployments","created_at":"2016-03-03T21:20:52Z","updated_at":"2016-03-03T21:20:53Z","pushed_at":"2016-03-04T15:44:09Z","git_url":"git://github.com/biniambekele/PyLCP.git","ssh_url":"git@github.com:biniambekele/PyLCP.git","clone_url":"https://github.com/biniambekele/PyLCP.git","svn_url":"https://github.com/biniambekele/PyLCP","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Points:master","ref":"master","sha":"4fb37385e8f1e06c8c5bb67ac1d4434c751ba31c","user":{"login":"Points","id":4116228,"avatar_url":"https://avatars.githubusercontent.com/u/4116228?v=3","gravatar_id":"","url":"https://api.github.com/users/Points","html_url":"https://github.com/Points","followers_url":"https://api.github.com/users/Points/followers","following_url":"https://api.github.com/users/Points/following{/other_user}","gists_url":"https://api.github.com/users/Points/gists{/gist_id}","starred_url":"https://api.github.com/users/Points/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Points/subscriptions","organizations_url":"https://api.github.com/users/Points/orgs","repos_url":"https://api.github.com/users/Points/repos","events_url":"https://api.github.com/users/Points/events{/privacy}","received_events_url":"https://api.github.com/users/Points/received_events","type":"Organization","site_admin":false},"repo":{"id":15798200,"name":"PyLCP","full_name":"Points/PyLCP","owner":{"login":"Points","id":4116228,"avatar_url":"https://avatars.githubusercontent.com/u/4116228?v=3","gravatar_id":"","url":"https://api.github.com/users/Points","html_url":"https://github.com/Points","followers_url":"https://api.github.com/users/Points/followers","following_url":"https://api.github.com/users/Points/following{/other_user}","gists_url":"https://api.github.com/users/Points/gists{/gist_id}","starred_url":"https://api.github.com/users/Points/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Points/subscriptions","organizations_url":"https://api.github.com/users/Points/orgs","repos_url":"https://api.github.com/users/Points/repos","events_url":"https://api.github.com/users/Points/events{/privacy}","received_events_url":"https://api.github.com/users/Points/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Points/PyLCP","description":"","fork":false,"url":"https://api.github.com/repos/Points/PyLCP","forks_url":"https://api.github.com/repos/Points/PyLCP/forks","keys_url":"https://api.github.com/repos/Points/PyLCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Points/PyLCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Points/PyLCP/teams","hooks_url":"https://api.github.com/repos/Points/PyLCP/hooks","issue_events_url":"https://api.github.com/repos/Points/PyLCP/issues/events{/number}","events_url":"https://api.github.com/repos/Points/PyLCP/events","assignees_url":"https://api.github.com/repos/Points/PyLCP/assignees{/user}","branches_url":"https://api.github.com/repos/Points/PyLCP/branches{/branch}","tags_url":"https://api.github.com/repos/Points/PyLCP/tags","blobs_url":"https://api.github.com/repos/Points/PyLCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Points/PyLCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Points/PyLCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Points/PyLCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Points/PyLCP/statuses/{sha}","languages_url":"https://api.github.com/repos/Points/PyLCP/languages","stargazers_url":"https://api.github.com/repos/Points/PyLCP/stargazers","contributors_url":"https://api.github.com/repos/Points/PyLCP/contributors","subscribers_url":"https://api.github.com/repos/Points/PyLCP/subscribers","subscription_url":"https://api.github.com/repos/Points/PyLCP/subscription","commits_url":"https://api.github.com/repos/Points/PyLCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Points/PyLCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Points/PyLCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Points/PyLCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Points/PyLCP/contents/{+path}","compare_url":"https://api.github.com/repos/Points/PyLCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Points/PyLCP/merges","archive_url":"https://api.github.com/repos/Points/PyLCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Points/PyLCP/downloads","issues_url":"https://api.github.com/repos/Points/PyLCP/issues{/number}","pulls_url":"https://api.github.com/repos/Points/PyLCP/pulls{/number}","milestones_url":"https://api.github.com/repos/Points/PyLCP/milestones{/number}","notifications_url":"https://api.github.com/repos/Points/PyLCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Points/PyLCP/labels{/name}","releases_url":"https://api.github.com/repos/Points/PyLCP/releases{/id}","deployments_url":"https://api.github.com/repos/Points/PyLCP/deployments","created_at":"2014-01-10T13:01:07Z","updated_at":"2015-12-30T22:14:14Z","pushed_at":"2016-03-04T15:44:10Z","git_url":"git://github.com/Points/PyLCP.git","ssh_url":"git@github.com:Points/PyLCP.git","clone_url":"https://github.com/Points/PyLCP.git","svn_url":"https://github.com/Points/PyLCP","homepage":null,"size":658,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/46"},"html":{"href":"https://github.com/Points/PyLCP/pull/46"},"issue":{"href":"https://api.github.com/repos/Points/PyLCP/issues/46"},"comments":{"href":"https://api.github.com/repos/Points/PyLCP/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Points/PyLCP/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/Points/PyLCP/statuses/be7d9c52e42c43d224192fb1c39562fbc530b6a6"}}}}