{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2969","repository_url":"https://api.github.com/repos/DataDog/dd-agent","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2969/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2969/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2969/events","html_url":"https://github.com/DataDog/dd-agent/pull/2969","id":185776910,"number":2969,"title":"Add cpuacct.usage as docker.cpu.usage to docker_daemon stats.","user":{"login":"ckiickA","id":13279101,"avatar_url":"https://avatars.githubusercontent.com/u/13279101?v=3","gravatar_id":"","url":"https://api.github.com/users/ckiickA","html_url":"https://github.com/ckiickA","followers_url":"https://api.github.com/users/ckiickA/followers","following_url":"https://api.github.com/users/ckiickA/following{/other_user}","gists_url":"https://api.github.com/users/ckiickA/gists{/gist_id}","starred_url":"https://api.github.com/users/ckiickA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckiickA/subscriptions","organizations_url":"https://api.github.com/users/ckiickA/orgs","repos_url":"https://api.github.com/users/ckiickA/repos","events_url":"https://api.github.com/users/ckiickA/events{/privacy}","received_events_url":"https://api.github.com/users/ckiickA/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/76","html_url":"https://github.com/DataDog/dd-agent/milestones/5.11.0","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/76/labels","id":2085757,"number":76,"title":"5.11.0","description":"","creator":{"login":"olivielpeau","id":4912500,"avatar_url":"https://avatars.githubusercontent.com/u/4912500?v=3","gravatar_id":"","url":"https://api.github.com/users/olivielpeau","html_url":"https://github.com/olivielpeau","followers_url":"https://api.github.com/users/olivielpeau/followers","following_url":"https://api.github.com/users/olivielpeau/following{/other_user}","gists_url":"https://api.github.com/users/olivielpeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olivielpeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivielpeau/subscriptions","organizations_url":"https://api.github.com/users/olivielpeau/orgs","repos_url":"https://api.github.com/users/olivielpeau/repos","events_url":"https://api.github.com/users/olivielpeau/events{/privacy}","received_events_url":"https://api.github.com/users/olivielpeau/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":0,"state":"open","created_at":"2016-10-21T19:48:58Z","updated_at":"2016-10-28T14:06:53Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-10-27T20:50:52Z","updated_at":"2016-10-28T14:11:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2969","html_url":"https://github.com/DataDog/dd-agent/pull/2969","diff_url":"https://github.com/DataDog/dd-agent/pull/2969.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2969.patch"},"body":"*Note: Please remember to review the Datadog [Contribution Guidelines](https://github.com/DataDog/dd-agent/blob/master/CONTRIBUTING.md)\r\nif you have not yet done so.*\r\n\r\n\r\n### What does this PR do?\r\n\r\nAdds a new stat 'docker.cpu.usage' which tracks the value in the cgroup accounting file cpuacct.usage for a docker container.  The values are normalized to yield CPU usage a a percentage.\r\n\r\n### Motivation\r\n\r\nThe user and system cpu usage reported in cpuacct.stat is much less accurate than other mechanisms.  Over a short sampling period they can be as much a 30% lower than what /proc or cpuacct.usage reports.  For a long running container, the difference can be an order of magnitude.\r\n\r\nIn order to get more accurate cpu usage numbers, I have added a new metric 'docker.cpu.usage', which gets the data from cpuacct.usage, converts it to jiffies, and reports it as a rate called docker.cpu.usage.  It is a parallel construction to the existing docker.cpu stats.\r\n\r\n### Testing Guidelines\r\n\r\nSame as for other docker stats.\r\nAn overview on [testing](https://github.com/DataDog/dd-agent/blob/master/tests/README.md)\r\nis available in our contribution guidelines.\r\n\r\n### Additional Notes\r\n"},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/256930432","html_url":"https://github.com/DataDog/dd-agent/pull/2969#issuecomment-256930432","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2969","id":256930432,"user":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T14:11:46Z","updated_at":"2016-10-28T14:11:46Z","body":"Thanks a lot @ckiickA !\r\n\r\nWe are currently in the process of releasing Datadog Agent `5.10.0`. I am adding your contribution to the next milestone: we'll review and test it for the next release 🚢 . "}}
{"actor":{"display_login":"yannmh"}}