{"action":"created","comment":{"url":"https://api.github.com/repos/picocms/Pico/pulls/comments/84793374","pull_request_review_id":5548537,"id":84793374,"diff_hunk":"@@ -86,6 +86,10 @@ Heading\n \n : The name of your theme or plugin.\n \n+View\n+\n+: Choose between the image oriented `jumbovision` layout, or the text-oriented `card` layout.  The default for Themes is `jumbovision`, while plugins use `card`.  This option only needs to be specified if you'd like to use the opposite layout.","path":"in-depth/submission_guidelines.md","position":null,"original_position":6,"commit_id":"34c24e616c6af67a315b7ad0a452d367933ec93e","original_commit_id":"34c24e616c6af67a315b7ad0a452d367933ec93e","user":{"login":"PhrozenByte","id":920356,"avatar_url":"https://avatars.githubusercontent.com/u/920356?v=3","gravatar_id":"","url":"https://api.github.com/users/PhrozenByte","html_url":"https://github.com/PhrozenByte","followers_url":"https://api.github.com/users/PhrozenByte/followers","following_url":"https://api.github.com/users/PhrozenByte/following{/other_user}","gists_url":"https://api.github.com/users/PhrozenByte/gists{/gist_id}","starred_url":"https://api.github.com/users/PhrozenByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhrozenByte/subscriptions","organizations_url":"https://api.github.com/users/PhrozenByte/orgs","repos_url":"https://api.github.com/users/PhrozenByte/repos","events_url":"https://api.github.com/users/PhrozenByte/events{/privacy}","received_events_url":"https://api.github.com/users/PhrozenByte/received_events","type":"User","site_admin":false},"body":"Using a different layout leads in 99% of the cases to rejecting the submission (I even can't think of a single reason why a plugin/theme should use a non-default layout, this parameter actually is for things like `zz_contribute.md` only), so I don't think it's necessary to mention `view` at all.","created_at":"2016-10-24T22:00:30Z","updated_at":"2016-10-24T22:00:30Z","html_url":"https://github.com/picocms/Pico/pull/358#discussion_r84793374","pull_request_url":"https://api.github.com/repos/picocms/Pico/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/picocms/Pico/pulls/comments/84793374"},"html":{"href":"https://github.com/picocms/Pico/pull/358#discussion_r84793374"},"pull_request":{"href":"https://api.github.com/repos/picocms/Pico/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/picocms/Pico/pulls/358","id":73496780,"html_url":"https://github.com/picocms/Pico/pull/358","diff_url":"https://github.com/picocms/Pico/pull/358.diff","patch_url":"https://github.com/picocms/Pico/pull/358.patch","issue_url":"https://api.github.com/repos/picocms/Pico/issues/358","number":358,"state":"open","locked":false,"title":"Customization Redesign & Portfolio","user":{"login":"smcdougall","id":12779160,"avatar_url":"https://avatars.githubusercontent.com/u/12779160?v=3","gravatar_id":"","url":"https://api.github.com/users/smcdougall","html_url":"https://github.com/smcdougall","followers_url":"https://api.github.com/users/smcdougall/followers","following_url":"https://api.github.com/users/smcdougall/following{/other_user}","gists_url":"https://api.github.com/users/smcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/smcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcdougall/subscriptions","organizations_url":"https://api.github.com/users/smcdougall/orgs","repos_url":"https://api.github.com/users/smcdougall/repos","events_url":"https://api.github.com/users/smcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/smcdougall/received_events","type":"User","site_admin":false},"body":"Redesigned Customization page using Webpaint's Portfolio style.\r\n\r\nViewable here: [Themes](http://testing3.mcdougallhome.net/themes/) and [Plugins](http://testing3.mcdougallhome.net/plugins/)\r\n\r\nThis PR is both for the page itself and for the portfolio framework that generates it.\r\n\r\nAlso note that it contains currently unmerged changes from #352 that are unrelated to this PR.  Actual changes begin at `Implemented Portfolio and Revamped Customization.` https://github.com/picocms/Pico/pull/358/commits/8819d4379aea0814e1bae513660cc65abdba0bb3\r\n\r\nPreviously discussed in #352.\r\n\r\nAreas to improve on:\r\n* [x] Customizable \"Launch Site\" Button Text.\r\n  * [ ] What should the text be on `customization`?  Download? Launch Site? View on GitHub? (since I think all but NotePaper go to GitHub).\r\n* [x] Better utilization of `Meta` text in existing tiles...\r\n* [x] Separate Plugins and Themes\r\n* [x] Improve Javascript on `portfolio-detail-view`.\r\n* [x] Multiple categories for themes/plugins - Started, but always room for improvements / more\r\n  * For Themes: Single-page, Static Website, Blog-Style, etc.\r\n  * For Plugins: Blogging, Social, Developer, etc\r\n* [x] Better representation of Plugins (especially when too abstract for a screenshot)\r\n    * [x] Possible Style: \"muted\", gray puzzle piece background with persistent overlay text, but only turns green on hover.\r\n    * [x] Initial Styles and Effect\r\n    * [x] Better Puzzle Piece graphic.\r\n      * [ ] Upload Source Files\r\n* [x] Use Jekyll \"Collections\" to separate each theme and plugin into its own file.\r\n  * [x] Migrate Heading and Description to `content`\r\n    * [x] ~~Migrate Heading~~\r\n      * Markdownified Heading instead, since it's not contiguous with the Description.\r\n      * Also, it's used for the Overlay, so it needs to be in an isolated variable for that.\r\n    * [x] Migrate Description\r\n   * [x] Provide backwards compatibility with YAML method for non-collection based portfolio pages.\r\n  * [x] Provide a blank YAML template that contributors can fill out to easily add their content.\r\n    * [x] Include submission guidelines / readme with things like screenshot resolution and location.\r\n     * [ ] Fork and PR instructions?  ~~This is probably out-of-scope.~~ As Links.\r\n  * [x] Move images into collection\r\n    * [x] Remove \"Theme\" from the names of theme screenshots, as it's redundant now.\r\n    * [ ] Remove \"Default Theme\" images.  Maybe re-purpose them elsewhere.\r\n    * [ ] Use *these* images for the About Page, instead of its own?  This is more likely to be a \"permanent home\" for these theme images, and it's redundant to have two copies.  (Putting this task *here* instead of on #352 because it'll rely on the new customization page collections being committed first.)\r\n      * Probably for Fullsize only, at this point.\r\n* [x] `a` tags in the info section should be white, not green.\r\n* ~~Captions for carousel items?~~ Probably not worth the effort, since we already have a content area.\r\n* [x] Escape *all* variables that are vulnerable to apostrophes.\r\n* ~~Provide \"Documentation\" on how to use `gallery` and `portfolio`.~~ \"Unnecessary\" \r\n  * ~~Don't forget about things like `info._blank`, `page.portfolio.categories`, `include categories=variable` and other examples that may not be represented on the current page.~~\r\n* [x] Fix whitespace on either side of `:` in the Item-Details `<span>`.\r\n* [x] Customize or slow carousel.\r\n  * [x] Slowed\r\n* [x] Second, text-focused, pop-up content area for Plugins page.\r\n* [x] Fix odd cut-off on right edge.\r\n* [x] Update About page URLs ~~(and image locations)~~\r\n* [x] Add styles for `portfolio-detail-view code`\r\n* [x] Better implementation of ~~plugin~~ defaultThumbnail styles trigger\r\n* [ ] Merge new styles with regular styles.\r\n* [x] Correct image paths (and any others) with `{{ site.github.url }}`.  Remove leading `/` from paths.\r\n* [x] Change `myCarousel` ID to `entry-{{ forloop.index0 }}-carousel` or something similar.\r\n* [x] Check commented JS from https://github.com/picocms/Pico/pull/358/commits/e3cd95b4fe3a30d8a3aa82c8db9c38d9d53843fa\r\n* [x] Use the \"active item\" class to make active item stay lit.\r\n* [x] Don't break the styles for \"standalone\" overlay images\r\n* [ ] Make sure that the bg color transitions are located in the right CSS file (pico.css) for consistency with other styles.\r\n* [ ] IE8 Compatible Styles (https://github.com/picocms/Pico/pull/358#issuecomment-247850979)\r\n* [x] Change `meta` to `description`\r\n* [x] New blank `info` lines implementation.\r\n* [ ] Find a replacement for the `None` category? (created when I removed `multi-page`)\r\n* [x] Create Theme/Code image for \"Plus\" tile.\r\n* [ ] Bigger plugin content (excerpts or whole readme's)\r\n* [x] Standardize Description (meta) punctuation.\r\n* [x] Set \"Contribute\" tile layout.\r\n* [x] Change name of `layout` variable.\r\n\r\n---\r\n\r\n* [ ] Investigate odd YAML behavior that is treating my categories as an array instead of a string.  For now, I'm treating this variable as an array (and maybe converting the syntax) since it probably *should* be an array.  It was just confusing because I was expecting a string of HTML ID's separated by spaces.  For comparison, `description` is correctly treated as a string (otherwise it'd be a spaceless jumble of letters).\r\n\r\n```yaml\r\ndescription: Google Analytics for Pico with basic options.<br><br>This plugin will automatically add the Google Analytics tracking script to the < head > section of each page generated by Pico.\r\ncategories: plugin developer. Why is this an array and not a string?\r\n```\r\n\r\nIs creating:\r\n\r\n```json\r\ndescription: \"Google Analytics for Pico with basic options.<br><br>This plugin will automatically add the Google Analytics tracking script to the < head > section of each page generated by Pico.\"\r\ncategories: [\"plugin\",\"developer.\",\"Why\",\"is\",\"this\",\"an\",\"array\",\"and\",\"not\",\"a\",\"string?\"]\r\n```\r\n\r\n","created_at":"2016-06-12T13:46:03Z","updated_at":"2016-10-24T22:00:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f24588f3daa962c0462c17baf0b715f6818f846c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/picocms/Pico/pulls/358/commits","review_comments_url":"https://api.github.com/repos/picocms/Pico/pulls/358/comments","review_comment_url":"https://api.github.com/repos/picocms/Pico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/picocms/Pico/issues/358/comments","statuses_url":"https://api.github.com/repos/picocms/Pico/statuses/34c24e616c6af67a315b7ad0a452d367933ec93e","head":{"label":"smcdougall:customization","ref":"customization","sha":"34c24e616c6af67a315b7ad0a452d367933ec93e","user":{"login":"smcdougall","id":12779160,"avatar_url":"https://avatars.githubusercontent.com/u/12779160?v=3","gravatar_id":"","url":"https://api.github.com/users/smcdougall","html_url":"https://github.com/smcdougall","followers_url":"https://api.github.com/users/smcdougall/followers","following_url":"https://api.github.com/users/smcdougall/following{/other_user}","gists_url":"https://api.github.com/users/smcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/smcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcdougall/subscriptions","organizations_url":"https://api.github.com/users/smcdougall/orgs","repos_url":"https://api.github.com/users/smcdougall/repos","events_url":"https://api.github.com/users/smcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/smcdougall/received_events","type":"User","site_admin":false},"repo":{"id":46181517,"name":"Pico","full_name":"smcdougall/Pico","owner":{"login":"smcdougall","id":12779160,"avatar_url":"https://avatars.githubusercontent.com/u/12779160?v=3","gravatar_id":"","url":"https://api.github.com/users/smcdougall","html_url":"https://github.com/smcdougall","followers_url":"https://api.github.com/users/smcdougall/followers","following_url":"https://api.github.com/users/smcdougall/following{/other_user}","gists_url":"https://api.github.com/users/smcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/smcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcdougall/subscriptions","organizations_url":"https://api.github.com/users/smcdougall/orgs","repos_url":"https://api.github.com/users/smcdougall/repos","events_url":"https://api.github.com/users/smcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/smcdougall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smcdougall/Pico","description":"Pico is a stupidly simple, blazing fast, flat file CMS.","fork":true,"url":"https://api.github.com/repos/smcdougall/Pico","forks_url":"https://api.github.com/repos/smcdougall/Pico/forks","keys_url":"https://api.github.com/repos/smcdougall/Pico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smcdougall/Pico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smcdougall/Pico/teams","hooks_url":"https://api.github.com/repos/smcdougall/Pico/hooks","issue_events_url":"https://api.github.com/repos/smcdougall/Pico/issues/events{/number}","events_url":"https://api.github.com/repos/smcdougall/Pico/events","assignees_url":"https://api.github.com/repos/smcdougall/Pico/assignees{/user}","branches_url":"https://api.github.com/repos/smcdougall/Pico/branches{/branch}","tags_url":"https://api.github.com/repos/smcdougall/Pico/tags","blobs_url":"https://api.github.com/repos/smcdougall/Pico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smcdougall/Pico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smcdougall/Pico/git/refs{/sha}","trees_url":"https://api.github.com/repos/smcdougall/Pico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smcdougall/Pico/statuses/{sha}","languages_url":"https://api.github.com/repos/smcdougall/Pico/languages","stargazers_url":"https://api.github.com/repos/smcdougall/Pico/stargazers","contributors_url":"https://api.github.com/repos/smcdougall/Pico/contributors","subscribers_url":"https://api.github.com/repos/smcdougall/Pico/subscribers","subscription_url":"https://api.github.com/repos/smcdougall/Pico/subscription","commits_url":"https://api.github.com/repos/smcdougall/Pico/commits{/sha}","git_commits_url":"https://api.github.com/repos/smcdougall/Pico/git/commits{/sha}","comments_url":"https://api.github.com/repos/smcdougall/Pico/comments{/number}","issue_comment_url":"https://api.github.com/repos/smcdougall/Pico/issues/comments{/number}","contents_url":"https://api.github.com/repos/smcdougall/Pico/contents/{+path}","compare_url":"https://api.github.com/repos/smcdougall/Pico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smcdougall/Pico/merges","archive_url":"https://api.github.com/repos/smcdougall/Pico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smcdougall/Pico/downloads","issues_url":"https://api.github.com/repos/smcdougall/Pico/issues{/number}","pulls_url":"https://api.github.com/repos/smcdougall/Pico/pulls{/number}","milestones_url":"https://api.github.com/repos/smcdougall/Pico/milestones{/number}","notifications_url":"https://api.github.com/repos/smcdougall/Pico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smcdougall/Pico/labels{/name}","releases_url":"https://api.github.com/repos/smcdougall/Pico/releases{/id}","deployments_url":"https://api.github.com/repos/smcdougall/Pico/deployments","created_at":"2015-11-14T16:12:39Z","updated_at":"2016-04-20T15:45:49Z","pushed_at":"2016-10-24T21:54:00Z","git_url":"git://github.com/smcdougall/Pico.git","ssh_url":"git@github.com:smcdougall/Pico.git","clone_url":"https://github.com/smcdougall/Pico.git","svn_url":"https://github.com/smcdougall/Pico","homepage":"http://picocms.org/","size":11186,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"picocms:gh-pages","ref":"gh-pages","sha":"223353316134e99ea91592d3d46606f8d1c85960","user":{"login":"picocms","id":7042563,"avatar_url":"https://avatars.githubusercontent.com/u/7042563?v=3","gravatar_id":"","url":"https://api.github.com/users/picocms","html_url":"https://github.com/picocms","followers_url":"https://api.github.com/users/picocms/followers","following_url":"https://api.github.com/users/picocms/following{/other_user}","gists_url":"https://api.github.com/users/picocms/gists{/gist_id}","starred_url":"https://api.github.com/users/picocms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picocms/subscriptions","organizations_url":"https://api.github.com/users/picocms/orgs","repos_url":"https://api.github.com/users/picocms/repos","events_url":"https://api.github.com/users/picocms/events{/privacy}","received_events_url":"https://api.github.com/users/picocms/received_events","type":"User","site_admin":false},"repo":{"id":3929096,"name":"Pico","full_name":"picocms/Pico","owner":{"login":"picocms","id":7042563,"avatar_url":"https://avatars.githubusercontent.com/u/7042563?v=3","gravatar_id":"","url":"https://api.github.com/users/picocms","html_url":"https://github.com/picocms","followers_url":"https://api.github.com/users/picocms/followers","following_url":"https://api.github.com/users/picocms/following{/other_user}","gists_url":"https://api.github.com/users/picocms/gists{/gist_id}","starred_url":"https://api.github.com/users/picocms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picocms/subscriptions","organizations_url":"https://api.github.com/users/picocms/orgs","repos_url":"https://api.github.com/users/picocms/repos","events_url":"https://api.github.com/users/picocms/events{/privacy}","received_events_url":"https://api.github.com/users/picocms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/picocms/Pico","description":"Pico is a stupidly simple, blazing fast, flat file CMS.","fork":false,"url":"https://api.github.com/repos/picocms/Pico","forks_url":"https://api.github.com/repos/picocms/Pico/forks","keys_url":"https://api.github.com/repos/picocms/Pico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/picocms/Pico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/picocms/Pico/teams","hooks_url":"https://api.github.com/repos/picocms/Pico/hooks","issue_events_url":"https://api.github.com/repos/picocms/Pico/issues/events{/number}","events_url":"https://api.github.com/repos/picocms/Pico/events","assignees_url":"https://api.github.com/repos/picocms/Pico/assignees{/user}","branches_url":"https://api.github.com/repos/picocms/Pico/branches{/branch}","tags_url":"https://api.github.com/repos/picocms/Pico/tags","blobs_url":"https://api.github.com/repos/picocms/Pico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/picocms/Pico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/picocms/Pico/git/refs{/sha}","trees_url":"https://api.github.com/repos/picocms/Pico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/picocms/Pico/statuses/{sha}","languages_url":"https://api.github.com/repos/picocms/Pico/languages","stargazers_url":"https://api.github.com/repos/picocms/Pico/stargazers","contributors_url":"https://api.github.com/repos/picocms/Pico/contributors","subscribers_url":"https://api.github.com/repos/picocms/Pico/subscribers","subscription_url":"https://api.github.com/repos/picocms/Pico/subscription","commits_url":"https://api.github.com/repos/picocms/Pico/commits{/sha}","git_commits_url":"https://api.github.com/repos/picocms/Pico/git/commits{/sha}","comments_url":"https://api.github.com/repos/picocms/Pico/comments{/number}","issue_comment_url":"https://api.github.com/repos/picocms/Pico/issues/comments{/number}","contents_url":"https://api.github.com/repos/picocms/Pico/contents/{+path}","compare_url":"https://api.github.com/repos/picocms/Pico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/picocms/Pico/merges","archive_url":"https://api.github.com/repos/picocms/Pico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/picocms/Pico/downloads","issues_url":"https://api.github.com/repos/picocms/Pico/issues{/number}","pulls_url":"https://api.github.com/repos/picocms/Pico/pulls{/number}","milestones_url":"https://api.github.com/repos/picocms/Pico/milestones{/number}","notifications_url":"https://api.github.com/repos/picocms/Pico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/picocms/Pico/labels{/name}","releases_url":"https://api.github.com/repos/picocms/Pico/releases{/id}","deployments_url":"https://api.github.com/repos/picocms/Pico/deployments","created_at":"2012-04-04T13:46:20Z","updated_at":"2016-10-22T23:40:20Z","pushed_at":"2016-10-24T21:54:01Z","git_url":"git://github.com/picocms/Pico.git","ssh_url":"git@github.com:picocms/Pico.git","clone_url":"https://github.com/picocms/Pico.git","svn_url":"https://github.com/picocms/Pico","homepage":"http://picocms.org/","size":12252,"stargazers_count":2419,"watchers_count":2419,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":459,"mirror_url":null,"open_issues_count":12,"forks":459,"open_issues":12,"watchers":2419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/picocms/Pico/pulls/358"},"html":{"href":"https://github.com/picocms/Pico/pull/358"},"issue":{"href":"https://api.github.com/repos/picocms/Pico/issues/358"},"comments":{"href":"https://api.github.com/repos/picocms/Pico/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/picocms/Pico/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/picocms/Pico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/picocms/Pico/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/picocms/Pico/statuses/34c24e616c6af67a315b7ad0a452d367933ec93e"}}}}
{"actor":{"display_login":"PhrozenByte"}}