{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/74651294","id":74651294,"diff_hunk":"@@ -39,11 +39,13 @@\n           <select\n              ng-if=\"line.type === 'structured' && line.updateText.length > 1\"\n              ng-model=\"line.updateSelectOption\"\n+             title=\"{{loggedIn() ? '' : 'Must be logged in'}}\"\n+             ng-disabled=\"!loggedIn\"","path":"ui/plugins/auto_classification/main.html","position":14,"original_position":14,"commit_id":"44082d6d29d33adcb9d9f1aaa0d8a2c70ec2787d","original_commit_id":"44082d6d29d33adcb9d9f1aaa0d8a2c70ec2787d","user":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"body":"You need to call loggedIn() as a function, not just get the value of the variable (which is always true).","created_at":"2016-08-12T19:55:00Z","updated_at":"2016-08-12T19:55:00Z","html_url":"https://github.com/mozilla/treeherder/pull/1784#discussion_r74651294","pull_request_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1784","_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/74651294"},"html":{"href":"https://github.com/mozilla/treeherder/pull/1784#discussion_r74651294"},"pull_request":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1784"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/1784","id":81172811,"html_url":"https://github.com/mozilla/treeherder/pull/1784","diff_url":"https://github.com/mozilla/treeherder/pull/1784.diff","patch_url":"https://github.com/mozilla/treeherder/pull/1784.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/1784","number":1784,"state":"open","locked":false,"title":"Bug 1294746 - Disable more autoclassify buttons when not logged in","user":{"login":"KWierso","id":172215,"avatar_url":"https://avatars.githubusercontent.com/u/172215?v=3","gravatar_id":"","url":"https://api.github.com/users/KWierso","html_url":"https://github.com/KWierso","followers_url":"https://api.github.com/users/KWierso/followers","following_url":"https://api.github.com/users/KWierso/following{/other_user}","gists_url":"https://api.github.com/users/KWierso/gists{/gist_id}","starred_url":"https://api.github.com/users/KWierso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWierso/subscriptions","organizations_url":"https://api.github.com/users/KWierso/orgs","repos_url":"https://api.github.com/users/KWierso/repos","events_url":"https://api.github.com/users/KWierso/events{/privacy}","received_events_url":"https://api.github.com/users/KWierso/received_events","type":"User","site_admin":false},"body":"So, this PR as-is:\r\n1) Disables the \"ignore others\" button and changes the title for the button when not signed in.\r\n2) Changes the titles for the line-specific \"save\" buttons and a select dropdown, and attempts to disable both when not signed in.\r\n\r\nBut those attempts to disable them don't appear to work, and I don't know why, since \"loggedIn()\" is working just above the ng-disabled's as part of the titles... @jgraham ?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/1784)\n<!-- Reviewable:end -->\n","created_at":"2016-08-12T19:45:28Z","updated_at":"2016-08-12T19:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"165516a2c3a04c36e526bae46a87f1ca48d90f43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1784/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1784/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/1784/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/44082d6d29d33adcb9d9f1aaa0d8a2c70ec2787d","head":{"label":"KWierso:loggedoutautoclassify","ref":"loggedoutautoclassify","sha":"44082d6d29d33adcb9d9f1aaa0d8a2c70ec2787d","user":{"login":"KWierso","id":172215,"avatar_url":"https://avatars.githubusercontent.com/u/172215?v=3","gravatar_id":"","url":"https://api.github.com/users/KWierso","html_url":"https://github.com/KWierso","followers_url":"https://api.github.com/users/KWierso/followers","following_url":"https://api.github.com/users/KWierso/following{/other_user}","gists_url":"https://api.github.com/users/KWierso/gists{/gist_id}","starred_url":"https://api.github.com/users/KWierso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWierso/subscriptions","organizations_url":"https://api.github.com/users/KWierso/orgs","repos_url":"https://api.github.com/users/KWierso/repos","events_url":"https://api.github.com/users/KWierso/events{/privacy}","received_events_url":"https://api.github.com/users/KWierso/received_events","type":"User","site_admin":false},"repo":{"id":34485965,"name":"treeherder","full_name":"KWierso/treeherder","owner":{"login":"KWierso","id":172215,"avatar_url":"https://avatars.githubusercontent.com/u/172215?v=3","gravatar_id":"","url":"https://api.github.com/users/KWierso","html_url":"https://github.com/KWierso","followers_url":"https://api.github.com/users/KWierso/followers","following_url":"https://api.github.com/users/KWierso/following{/other_user}","gists_url":"https://api.github.com/users/KWierso/gists{/gist_id}","starred_url":"https://api.github.com/users/KWierso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWierso/subscriptions","organizations_url":"https://api.github.com/users/KWierso/orgs","repos_url":"https://api.github.com/users/KWierso/repos","events_url":"https://api.github.com/users/KWierso/events{/privacy}","received_events_url":"https://api.github.com/users/KWierso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KWierso/treeherder","description":"The backend of treeherder, a replacement for TBPL. See wiki page for where to file bugs.","fork":true,"url":"https://api.github.com/repos/KWierso/treeherder","forks_url":"https://api.github.com/repos/KWierso/treeherder/forks","keys_url":"https://api.github.com/repos/KWierso/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KWierso/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KWierso/treeherder/teams","hooks_url":"https://api.github.com/repos/KWierso/treeherder/hooks","issue_events_url":"https://api.github.com/repos/KWierso/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/KWierso/treeherder/events","assignees_url":"https://api.github.com/repos/KWierso/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/KWierso/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/KWierso/treeherder/tags","blobs_url":"https://api.github.com/repos/KWierso/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KWierso/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KWierso/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/KWierso/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KWierso/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/KWierso/treeherder/languages","stargazers_url":"https://api.github.com/repos/KWierso/treeherder/stargazers","contributors_url":"https://api.github.com/repos/KWierso/treeherder/contributors","subscribers_url":"https://api.github.com/repos/KWierso/treeherder/subscribers","subscription_url":"https://api.github.com/repos/KWierso/treeherder/subscription","commits_url":"https://api.github.com/repos/KWierso/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/KWierso/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/KWierso/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/KWierso/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/KWierso/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/KWierso/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KWierso/treeherder/merges","archive_url":"https://api.github.com/repos/KWierso/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KWierso/treeherder/downloads","issues_url":"https://api.github.com/repos/KWierso/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/KWierso/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/KWierso/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/KWierso/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KWierso/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/KWierso/treeherder/releases{/id}","deployments_url":"https://api.github.com/repos/KWierso/treeherder/deployments","created_at":"2015-04-23T22:58:25Z","updated_at":"2016-05-06T00:18:53Z","pushed_at":"2016-08-12T19:42:13Z","git_url":"git://github.com/KWierso/treeherder.git","ssh_url":"git@github.com:KWierso/treeherder.git","clone_url":"https://github.com/KWierso/treeherder.git","svn_url":"https://github.com/KWierso/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":43202,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ff6734dfdc01a68f763ab604e3febeeeb9582aa5","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"A system for managing CI data for Mozilla projects","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/treeherder/deployments","created_at":"2013-02-27T19:17:37Z","updated_at":"2016-08-12T14:46:21Z","pushed_at":"2016-08-12T19:45:32Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/EngineeringProductivity/Projects/Treeherder","size":399735,"stargazers_count":65,"watchers_count":65,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":26,"forks":112,"open_issues":26,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1784"},"html":{"href":"https://github.com/mozilla/treeherder/pull/1784"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1784"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1784/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1784/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1784/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/44082d6d29d33adcb9d9f1aaa0d8a2c70ec2787d"}}}}
{"actor":{"display_login":"wlach"}}