{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/89910172","pull_request_review_id":10439429,"id":89910172,"diff_hunk":"@@ -240,6 +240,25 @@ inline bool IsValidReturnKind(ReturnKind returnKind)\n         ;\n }\n \n+inline bool IsGCReturnKind(ReturnKind returnKind)\n+{\n+    switch (returnKind)\n+    {\n+    case RT_Object:","path":"src/inc/gcinfotypes.h","position":8,"original_position":8,"commit_id":"11316a8c58977f1b9058370d364bdde377c416e3","original_commit_id":"11316a8c58977f1b9058370d364bdde377c416e3","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"When we protect the value using `FrameWithCookie<GCFrame> gcFrame;` later, we always assume that the return value is `RT_Object`. Are all the other cases except `RT_Object`  broken?","created_at":"2016-11-28T23:29:49Z","updated_at":"2016-11-28T23:29:49Z","html_url":"https://github.com/dotnet/coreclr/pull/8241#discussion_r89910172","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8241","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/89910172"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8241#discussion_r89910172"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8241"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/8241","id":94724823,"html_url":"https://github.com/dotnet/coreclr/pull/8241","diff_url":"https://github.com/dotnet/coreclr/pull/8241.diff","patch_url":"https://github.com/dotnet/coreclr/pull/8241.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/8241","number":8241,"state":"open","locked":false,"title":"GCStress After Direct Calls","user":{"login":"swaroop-sridhar","id":8977622,"avatar_url":"https://avatars.githubusercontent.com/u/8977622?v=3","gravatar_id":"","url":"https://api.github.com/users/swaroop-sridhar","html_url":"https://github.com/swaroop-sridhar","followers_url":"https://api.github.com/users/swaroop-sridhar/followers","following_url":"https://api.github.com/users/swaroop-sridhar/following{/other_user}","gists_url":"https://api.github.com/users/swaroop-sridhar/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroop-sridhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroop-sridhar/subscriptions","organizations_url":"https://api.github.com/users/swaroop-sridhar/orgs","repos_url":"https://api.github.com/users/swaroop-sridhar/repos","events_url":"https://api.github.com/users/swaroop-sridhar/events{/privacy}","received_events_url":"https://api.github.com/users/swaroop-sridhar/received_events","type":"User","site_admin":false},"body":"During GCStress 0xC, this change enables stopping for GC\r\nafter direct calls, when the GCInfo for the target is available.\r\n\r\nFixes #4220","created_at":"2016-11-22T00:21:23Z","updated_at":"2016-11-28T23:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e9f4a07b72dad6a69ac9160f7e8e8a53b791700","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8241/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8241/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/8241/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/11316a8c58977f1b9058370d364bdde377c416e3","head":{"label":"swaroop-sridhar:gcd","ref":"gcd","sha":"11316a8c58977f1b9058370d364bdde377c416e3","user":{"login":"swaroop-sridhar","id":8977622,"avatar_url":"https://avatars.githubusercontent.com/u/8977622?v=3","gravatar_id":"","url":"https://api.github.com/users/swaroop-sridhar","html_url":"https://github.com/swaroop-sridhar","followers_url":"https://api.github.com/users/swaroop-sridhar/followers","following_url":"https://api.github.com/users/swaroop-sridhar/following{/other_user}","gists_url":"https://api.github.com/users/swaroop-sridhar/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroop-sridhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroop-sridhar/subscriptions","organizations_url":"https://api.github.com/users/swaroop-sridhar/orgs","repos_url":"https://api.github.com/users/swaroop-sridhar/repos","events_url":"https://api.github.com/users/swaroop-sridhar/events{/privacy}","received_events_url":"https://api.github.com/users/swaroop-sridhar/received_events","type":"User","site_admin":false},"repo":{"id":31568014,"name":"coreclr","full_name":"swaroop-sridhar/coreclr","owner":{"login":"swaroop-sridhar","id":8977622,"avatar_url":"https://avatars.githubusercontent.com/u/8977622?v=3","gravatar_id":"","url":"https://api.github.com/users/swaroop-sridhar","html_url":"https://github.com/swaroop-sridhar","followers_url":"https://api.github.com/users/swaroop-sridhar/followers","following_url":"https://api.github.com/users/swaroop-sridhar/following{/other_user}","gists_url":"https://api.github.com/users/swaroop-sridhar/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroop-sridhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroop-sridhar/subscriptions","organizations_url":"https://api.github.com/users/swaroop-sridhar/orgs","repos_url":"https://api.github.com/users/swaroop-sridhar/repos","events_url":"https://api.github.com/users/swaroop-sridhar/events{/privacy}","received_events_url":"https://api.github.com/users/swaroop-sridhar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swaroop-sridhar/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/swaroop-sridhar/coreclr","forks_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/forks","keys_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/teams","hooks_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/hooks","issue_events_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/events","assignees_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/tags","blobs_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/languages","stargazers_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/stargazers","contributors_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/contributors","subscribers_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/subscribers","subscription_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/subscription","commits_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/merges","archive_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/downloads","issues_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/swaroop-sridhar/coreclr/deployments","created_at":"2015-03-02T22:57:03Z","updated_at":"2016-01-13T22:05:44Z","pushed_at":"2016-11-28T00:48:27Z","git_url":"git://github.com/swaroop-sridhar/coreclr.git","ssh_url":"git@github.com:swaroop-sridhar/coreclr.git","clone_url":"https://github.com/swaroop-sridhar/coreclr.git","svn_url":"https://github.com/swaroop-sridhar/coreclr","homepage":"","size":120398,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0c0e872d4ff27f37eecb8e24e1da89fa34975370","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-11-28T14:06:06Z","pushed_at":"2016-11-28T23:21:39Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":137084,"stargazers_count":7090,"watchers_count":7090,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1726,"mirror_url":null,"open_issues_count":1038,"forks":1726,"open_issues":1038,"watchers":7090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8241"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8241"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8241"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8241/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8241/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8241/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/11316a8c58977f1b9058370d364bdde377c416e3"}}}}
{"actor":{"display_login":"jkotas"}}