{"action":"created","comment":{"url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/comments/63119180","id":63119180,"diff_hunk":"@@ -150,48 +150,74 @@ def _read_info_volumes(self, **kwargs):\n         return info\n \n     def _read_info_quota(self):\n-        admin_tenant_id = self.identity_client.get_tenant_id_by_name(\n-            self.config.cloud.tenant)\n-        service_tenant_id = self.identity_client.get_tenant_id_by_name(\n-            self.config.cloud.service_tenant)\n+        \"\"\"cinderclient allows user to update cinder quotas for tenant ID\n+        and tenant name, and it treats those quotas as different objects,\n+        so user may get confused to see different output for `cinder\n+        quota-show <tenant ID>` and `cinder quota-show <tenant name>`. This\n+        behavior is ignored during migration and only quotas by tenant ID\n+        are migrated.\"\"\"\n+\n         if self.cloud.position == 'src' and self.filter_tenant_id:\n-            tmp_list = \\\n-                [admin_tenant_id, service_tenant_id]\n-            tmp_list.extend(self.filter_tenant_id)\n-            tmp_list = list(set(tmp_list))\n-            tenant_ids = \\\n-                [tenant.id for tenant in\n-                 self.identity_client.get_tenants_list()\n-                 if tenant.id in tmp_list]\n+            if isinstance(self.filter_tenant_id, list):\n+                filtered_tenants = self.filter_tenant_id\n+            else:\n+                filtered_tenants = [self.filter_tenant_id]\n+            tenants = [self.identity_client.try_get_tenant_by_id(t) for t in\n+                       filtered_tenants]\n         else:\n-            tenant_ids = \\\n-                [tenant.id for tenant in\n-                 self.identity_client.get_tenants_list()\n-                    if tenant.id != service_tenant_id]\n+            tenants = [tenant for tenant in","path":"cloudferry/lib/os/storage/cinder_storage.py","position":35,"original_position":35,"commit_id":"70a2213a1da1bd318c6cffc0a7fcccd98c9200e4","original_commit_id":"70a2213a1da1bd318c6cffc0a7fcccd98c9200e4","user":{"login":"SVilgelm","id":523825,"avatar_url":"https://avatars.githubusercontent.com/u/523825?v=3","gravatar_id":"","url":"https://api.github.com/users/SVilgelm","html_url":"https://github.com/SVilgelm","followers_url":"https://api.github.com/users/SVilgelm/followers","following_url":"https://api.github.com/users/SVilgelm/following{/other_user}","gists_url":"https://api.github.com/users/SVilgelm/gists{/gist_id}","starred_url":"https://api.github.com/users/SVilgelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SVilgelm/subscriptions","organizations_url":"https://api.github.com/users/SVilgelm/orgs","repos_url":"https://api.github.com/users/SVilgelm/repos","events_url":"https://api.github.com/users/SVilgelm/events{/privacy}","received_events_url":"https://api.github.com/users/SVilgelm/received_events","type":"User","site_admin":false},"body":"`tenants = self.identity_client.get_tenants_list()` ???","created_at":"2016-05-13T00:38:14Z","updated_at":"2016-05-13T00:38:14Z","html_url":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011#discussion_r63119180","pull_request_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011","_links":{"self":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/comments/63119180"},"html":{"href":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011#discussion_r63119180"},"pull_request":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011"}}},"pull_request":{"url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011","id":69928065,"html_url":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011","diff_url":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011.diff","patch_url":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011.patch","issue_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/1011","number":1011,"state":"open","locked":false,"title":"CF-465 Cinder quota migration fix","user":{"login":"roman-verchikov","id":386276,"avatar_url":"https://avatars.githubusercontent.com/u/386276?v=3","gravatar_id":"","url":"https://api.github.com/users/roman-verchikov","html_url":"https://github.com/roman-verchikov","followers_url":"https://api.github.com/users/roman-verchikov/followers","following_url":"https://api.github.com/users/roman-verchikov/following{/other_user}","gists_url":"https://api.github.com/users/roman-verchikov/gists{/gist_id}","starred_url":"https://api.github.com/users/roman-verchikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roman-verchikov/subscriptions","organizations_url":"https://api.github.com/users/roman-verchikov/orgs","repos_url":"https://api.github.com/users/roman-verchikov/repos","events_url":"https://api.github.com/users/roman-verchikov/events{/privacy}","received_events_url":"https://api.github.com/users/roman-verchikov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-13T00:35:45Z","updated_at":"2016-05-13T00:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab01fc5bd678aac1b16db4651da5598dfb2c28da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011/commits","review_comments_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011/comments","review_comment_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/1011/comments","statuses_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/statuses/70a2213a1da1bd318c6cffc0a7fcccd98c9200e4","head":{"label":"roman-verchikov:bugs/465-cinder-quota","ref":"bugs/465-cinder-quota","sha":"70a2213a1da1bd318c6cffc0a7fcccd98c9200e4","user":{"login":"roman-verchikov","id":386276,"avatar_url":"https://avatars.githubusercontent.com/u/386276?v=3","gravatar_id":"","url":"https://api.github.com/users/roman-verchikov","html_url":"https://github.com/roman-verchikov","followers_url":"https://api.github.com/users/roman-verchikov/followers","following_url":"https://api.github.com/users/roman-verchikov/following{/other_user}","gists_url":"https://api.github.com/users/roman-verchikov/gists{/gist_id}","starred_url":"https://api.github.com/users/roman-verchikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roman-verchikov/subscriptions","organizations_url":"https://api.github.com/users/roman-verchikov/orgs","repos_url":"https://api.github.com/users/roman-verchikov/repos","events_url":"https://api.github.com/users/roman-verchikov/events{/privacy}","received_events_url":"https://api.github.com/users/roman-verchikov/received_events","type":"User","site_admin":false},"repo":{"id":31573764,"name":"CloudFerry","full_name":"roman-verchikov/CloudFerry","owner":{"login":"roman-verchikov","id":386276,"avatar_url":"https://avatars.githubusercontent.com/u/386276?v=3","gravatar_id":"","url":"https://api.github.com/users/roman-verchikov","html_url":"https://github.com/roman-verchikov","followers_url":"https://api.github.com/users/roman-verchikov/followers","following_url":"https://api.github.com/users/roman-verchikov/following{/other_user}","gists_url":"https://api.github.com/users/roman-verchikov/gists{/gist_id}","starred_url":"https://api.github.com/users/roman-verchikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roman-verchikov/subscriptions","organizations_url":"https://api.github.com/users/roman-verchikov/orgs","repos_url":"https://api.github.com/users/roman-verchikov/repos","events_url":"https://api.github.com/users/roman-verchikov/events{/privacy}","received_events_url":"https://api.github.com/users/roman-verchikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roman-verchikov/CloudFerry","description":"CloudFerry is a cloud virtual workloads migration tool designed and developed by Mirantis Inc. ","fork":true,"url":"https://api.github.com/repos/roman-verchikov/CloudFerry","forks_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/forks","keys_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/teams","hooks_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/hooks","issue_events_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/issues/events{/number}","events_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/events","assignees_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/assignees{/user}","branches_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/branches{/branch}","tags_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/tags","blobs_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/git/refs{/sha}","trees_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/statuses/{sha}","languages_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/languages","stargazers_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/stargazers","contributors_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/contributors","subscribers_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/subscribers","subscription_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/subscription","commits_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/commits{/sha}","git_commits_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/git/commits{/sha}","comments_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/comments{/number}","issue_comment_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/issues/comments{/number}","contents_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/contents/{+path}","compare_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/merges","archive_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/downloads","issues_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/issues{/number}","pulls_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/pulls{/number}","milestones_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/milestones{/number}","notifications_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/labels{/name}","releases_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/releases{/id}","deployments_url":"https://api.github.com/repos/roman-verchikov/CloudFerry/deployments","created_at":"2015-03-03T01:48:42Z","updated_at":"2015-03-03T01:48:44Z","pushed_at":"2016-05-13T00:33:33Z","git_url":"git://github.com/roman-verchikov/CloudFerry.git","ssh_url":"git@github.com:roman-verchikov/CloudFerry.git","clone_url":"https://github.com/roman-verchikov/CloudFerry.git","svn_url":"https://github.com/roman-verchikov/CloudFerry","homepage":null,"size":4951,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MirantisWorkloadMobility:devel","ref":"devel","sha":"a3860c07dd58cdde92d046e0269645a8ff4755d5","user":{"login":"MirantisWorkloadMobility","id":8500817,"avatar_url":"https://avatars.githubusercontent.com/u/8500817?v=3","gravatar_id":"","url":"https://api.github.com/users/MirantisWorkloadMobility","html_url":"https://github.com/MirantisWorkloadMobility","followers_url":"https://api.github.com/users/MirantisWorkloadMobility/followers","following_url":"https://api.github.com/users/MirantisWorkloadMobility/following{/other_user}","gists_url":"https://api.github.com/users/MirantisWorkloadMobility/gists{/gist_id}","starred_url":"https://api.github.com/users/MirantisWorkloadMobility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirantisWorkloadMobility/subscriptions","organizations_url":"https://api.github.com/users/MirantisWorkloadMobility/orgs","repos_url":"https://api.github.com/users/MirantisWorkloadMobility/repos","events_url":"https://api.github.com/users/MirantisWorkloadMobility/events{/privacy}","received_events_url":"https://api.github.com/users/MirantisWorkloadMobility/received_events","type":"User","site_admin":false},"repo":{"id":23142392,"name":"CloudFerry","full_name":"MirantisWorkloadMobility/CloudFerry","owner":{"login":"MirantisWorkloadMobility","id":8500817,"avatar_url":"https://avatars.githubusercontent.com/u/8500817?v=3","gravatar_id":"","url":"https://api.github.com/users/MirantisWorkloadMobility","html_url":"https://github.com/MirantisWorkloadMobility","followers_url":"https://api.github.com/users/MirantisWorkloadMobility/followers","following_url":"https://api.github.com/users/MirantisWorkloadMobility/following{/other_user}","gists_url":"https://api.github.com/users/MirantisWorkloadMobility/gists{/gist_id}","starred_url":"https://api.github.com/users/MirantisWorkloadMobility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirantisWorkloadMobility/subscriptions","organizations_url":"https://api.github.com/users/MirantisWorkloadMobility/orgs","repos_url":"https://api.github.com/users/MirantisWorkloadMobility/repos","events_url":"https://api.github.com/users/MirantisWorkloadMobility/events{/privacy}","received_events_url":"https://api.github.com/users/MirantisWorkloadMobility/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MirantisWorkloadMobility/CloudFerry","description":"\"CloudFerry Framework\" is a cloud virtual workloads migration framework designed and developed by Mirantis Inc. ","fork":false,"url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry","forks_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/forks","keys_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/teams","hooks_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/hooks","issue_events_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/events{/number}","events_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/events","assignees_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/assignees{/user}","branches_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/branches{/branch}","tags_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/tags","blobs_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/git/refs{/sha}","trees_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/statuses/{sha}","languages_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/languages","stargazers_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/stargazers","contributors_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/contributors","subscribers_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/subscribers","subscription_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/subscription","commits_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/commits{/sha}","git_commits_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/git/commits{/sha}","comments_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/comments{/number}","issue_comment_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/comments{/number}","contents_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/contents/{+path}","compare_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/merges","archive_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/downloads","issues_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues{/number}","pulls_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls{/number}","milestones_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/milestones{/number}","notifications_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/labels{/name}","releases_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/releases{/id}","deployments_url":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/deployments","created_at":"2014-08-20T09:00:38Z","updated_at":"2016-03-02T10:20:17Z","pushed_at":"2016-05-13T00:35:46Z","git_url":"git://github.com/MirantisWorkloadMobility/CloudFerry.git","ssh_url":"git@github.com:MirantisWorkloadMobility/CloudFerry.git","clone_url":"https://github.com/MirantisWorkloadMobility/CloudFerry.git","svn_url":"https://github.com/MirantisWorkloadMobility/CloudFerry","homepage":"","size":5828,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":12,"forks":40,"open_issues":12,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011"},"html":{"href":"https://github.com/MirantisWorkloadMobility/CloudFerry/pull/1011"},"issue":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/1011"},"comments":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/issues/1011/comments"},"review_comments":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011/comments"},"review_comment":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/pulls/1011/commits"},"statuses":{"href":"https://api.github.com/repos/MirantisWorkloadMobility/CloudFerry/statuses/70a2213a1da1bd318c6cffc0a7fcccd98c9200e4"}}}}