{"action":"opened","number":655,"pull_request":{"url":"https://api.github.com/repos/finagle/finch/pulls/655","id":89915903,"html_url":"https://github.com/finagle/finch/pull/655","diff_url":"https://github.com/finagle/finch/pull/655.diff","patch_url":"https://github.com/finagle/finch/pull/655.patch","issue_url":"https://api.github.com/repos/finagle/finch/issues/655","number":655,"state":"open","locked":false,"title":"Add basic support for Server Sent Events.","user":{"login":"rpless","id":2407674,"avatar_url":"https://avatars.githubusercontent.com/u/2407674?v=3","gravatar_id":"","url":"https://api.github.com/users/rpless","html_url":"https://github.com/rpless","followers_url":"https://api.github.com/users/rpless/followers","following_url":"https://api.github.com/users/rpless/following{/other_user}","gists_url":"https://api.github.com/users/rpless/gists{/gist_id}","starred_url":"https://api.github.com/users/rpless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpless/subscriptions","organizations_url":"https://api.github.com/users/rpless/orgs","repos_url":"https://api.github.com/users/rpless/repos","events_url":"https://api.github.com/users/rpless/events{/privacy}","received_events_url":"https://api.github.com/users/rpless/received_events","type":"User","site_admin":false},"body":"Adds a ToResponse to create to hook into the asyncBodyResponse\r\nAdds an example of SSE\r\nAdds a section to the cookbook about SSE\r\n\r\nTwo things to call out:\r\n- This support is very bare-bones and makes it the responsibility of the user to provide properly formatted events\r\n- The [EventSource Standards](https://html.spec.whatwg.org/multipage/comms.html#authoring-notes) advises against using chunked requests, but `asyncResponseBuilder` does use chunked requests. When I tried implementing my own version of `asyncResponseBuilder` that didn't use chunking the `writer` would not write any data into the event. Not sure if it just isn't possible or if there was some method on the writer that I missed that would get it to write.","created_at":"2016-10-18T23:13:54Z","updated_at":"2016-10-18T23:13:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/finagle/finch/pulls/655/commits","review_comments_url":"https://api.github.com/repos/finagle/finch/pulls/655/comments","review_comment_url":"https://api.github.com/repos/finagle/finch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finagle/finch/issues/655/comments","statuses_url":"https://api.github.com/repos/finagle/finch/statuses/3572c6a9a99295ae0f7f455bd950d95432067686","head":{"label":"rpless:wip-sse","ref":"wip-sse","sha":"3572c6a9a99295ae0f7f455bd950d95432067686","user":{"login":"rpless","id":2407674,"avatar_url":"https://avatars.githubusercontent.com/u/2407674?v=3","gravatar_id":"","url":"https://api.github.com/users/rpless","html_url":"https://github.com/rpless","followers_url":"https://api.github.com/users/rpless/followers","following_url":"https://api.github.com/users/rpless/following{/other_user}","gists_url":"https://api.github.com/users/rpless/gists{/gist_id}","starred_url":"https://api.github.com/users/rpless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpless/subscriptions","organizations_url":"https://api.github.com/users/rpless/orgs","repos_url":"https://api.github.com/users/rpless/repos","events_url":"https://api.github.com/users/rpless/events{/privacy}","received_events_url":"https://api.github.com/users/rpless/received_events","type":"User","site_admin":false},"repo":{"id":22566885,"name":"finch","full_name":"rpless/finch","owner":{"login":"rpless","id":2407674,"avatar_url":"https://avatars.githubusercontent.com/u/2407674?v=3","gravatar_id":"","url":"https://api.github.com/users/rpless","html_url":"https://github.com/rpless","followers_url":"https://api.github.com/users/rpless/followers","following_url":"https://api.github.com/users/rpless/following{/other_user}","gists_url":"https://api.github.com/users/rpless/gists{/gist_id}","starred_url":"https://api.github.com/users/rpless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpless/subscriptions","organizations_url":"https://api.github.com/users/rpless/orgs","repos_url":"https://api.github.com/users/rpless/repos","events_url":"https://api.github.com/users/rpless/events{/privacy}","received_events_url":"https://api.github.com/users/rpless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpless/finch","description":"Purely Functional REST API atop of Finagle","fork":true,"url":"https://api.github.com/repos/rpless/finch","forks_url":"https://api.github.com/repos/rpless/finch/forks","keys_url":"https://api.github.com/repos/rpless/finch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpless/finch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpless/finch/teams","hooks_url":"https://api.github.com/repos/rpless/finch/hooks","issue_events_url":"https://api.github.com/repos/rpless/finch/issues/events{/number}","events_url":"https://api.github.com/repos/rpless/finch/events","assignees_url":"https://api.github.com/repos/rpless/finch/assignees{/user}","branches_url":"https://api.github.com/repos/rpless/finch/branches{/branch}","tags_url":"https://api.github.com/repos/rpless/finch/tags","blobs_url":"https://api.github.com/repos/rpless/finch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpless/finch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpless/finch/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpless/finch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpless/finch/statuses/{sha}","languages_url":"https://api.github.com/repos/rpless/finch/languages","stargazers_url":"https://api.github.com/repos/rpless/finch/stargazers","contributors_url":"https://api.github.com/repos/rpless/finch/contributors","subscribers_url":"https://api.github.com/repos/rpless/finch/subscribers","subscription_url":"https://api.github.com/repos/rpless/finch/subscription","commits_url":"https://api.github.com/repos/rpless/finch/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpless/finch/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpless/finch/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpless/finch/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpless/finch/contents/{+path}","compare_url":"https://api.github.com/repos/rpless/finch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpless/finch/merges","archive_url":"https://api.github.com/repos/rpless/finch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpless/finch/downloads","issues_url":"https://api.github.com/repos/rpless/finch/issues{/number}","pulls_url":"https://api.github.com/repos/rpless/finch/pulls{/number}","milestones_url":"https://api.github.com/repos/rpless/finch/milestones{/number}","notifications_url":"https://api.github.com/repos/rpless/finch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpless/finch/labels{/name}","releases_url":"https://api.github.com/repos/rpless/finch/releases{/id}","deployments_url":"https://api.github.com/repos/rpless/finch/deployments","created_at":"2014-08-03T04:04:29Z","updated_at":"2016-02-02T02:57:31Z","pushed_at":"2016-10-18T23:06:59Z","git_url":"git://github.com/rpless/finch.git","ssh_url":"git@github.com:rpless/finch.git","clone_url":"https://github.com/rpless/finch.git","svn_url":"https://github.com/rpless/finch","homepage":"","size":2404,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"finagle:master","ref":"master","sha":"b44651122ef78fb2b8768d1dad4b2e9cd0083ada","user":{"login":"finagle","id":7944306,"avatar_url":"https://avatars.githubusercontent.com/u/7944306?v=3","gravatar_id":"","url":"https://api.github.com/users/finagle","html_url":"https://github.com/finagle","followers_url":"https://api.github.com/users/finagle/followers","following_url":"https://api.github.com/users/finagle/following{/other_user}","gists_url":"https://api.github.com/users/finagle/gists{/gist_id}","starred_url":"https://api.github.com/users/finagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finagle/subscriptions","organizations_url":"https://api.github.com/users/finagle/orgs","repos_url":"https://api.github.com/users/finagle/repos","events_url":"https://api.github.com/users/finagle/events{/privacy}","received_events_url":"https://api.github.com/users/finagle/received_events","type":"Organization","site_admin":false},"repo":{"id":18798826,"name":"finch","full_name":"finagle/finch","owner":{"login":"finagle","id":7944306,"avatar_url":"https://avatars.githubusercontent.com/u/7944306?v=3","gravatar_id":"","url":"https://api.github.com/users/finagle","html_url":"https://github.com/finagle","followers_url":"https://api.github.com/users/finagle/followers","following_url":"https://api.github.com/users/finagle/following{/other_user}","gists_url":"https://api.github.com/users/finagle/gists{/gist_id}","starred_url":"https://api.github.com/users/finagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finagle/subscriptions","organizations_url":"https://api.github.com/users/finagle/orgs","repos_url":"https://api.github.com/users/finagle/repos","events_url":"https://api.github.com/users/finagle/events{/privacy}","received_events_url":"https://api.github.com/users/finagle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finagle/finch","description":"Scala combinator library for building Finagle HTTP services","fork":false,"url":"https://api.github.com/repos/finagle/finch","forks_url":"https://api.github.com/repos/finagle/finch/forks","keys_url":"https://api.github.com/repos/finagle/finch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finagle/finch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finagle/finch/teams","hooks_url":"https://api.github.com/repos/finagle/finch/hooks","issue_events_url":"https://api.github.com/repos/finagle/finch/issues/events{/number}","events_url":"https://api.github.com/repos/finagle/finch/events","assignees_url":"https://api.github.com/repos/finagle/finch/assignees{/user}","branches_url":"https://api.github.com/repos/finagle/finch/branches{/branch}","tags_url":"https://api.github.com/repos/finagle/finch/tags","blobs_url":"https://api.github.com/repos/finagle/finch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finagle/finch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finagle/finch/git/refs{/sha}","trees_url":"https://api.github.com/repos/finagle/finch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finagle/finch/statuses/{sha}","languages_url":"https://api.github.com/repos/finagle/finch/languages","stargazers_url":"https://api.github.com/repos/finagle/finch/stargazers","contributors_url":"https://api.github.com/repos/finagle/finch/contributors","subscribers_url":"https://api.github.com/repos/finagle/finch/subscribers","subscription_url":"https://api.github.com/repos/finagle/finch/subscription","commits_url":"https://api.github.com/repos/finagle/finch/commits{/sha}","git_commits_url":"https://api.github.com/repos/finagle/finch/git/commits{/sha}","comments_url":"https://api.github.com/repos/finagle/finch/comments{/number}","issue_comment_url":"https://api.github.com/repos/finagle/finch/issues/comments{/number}","contents_url":"https://api.github.com/repos/finagle/finch/contents/{+path}","compare_url":"https://api.github.com/repos/finagle/finch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finagle/finch/merges","archive_url":"https://api.github.com/repos/finagle/finch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finagle/finch/downloads","issues_url":"https://api.github.com/repos/finagle/finch/issues{/number}","pulls_url":"https://api.github.com/repos/finagle/finch/pulls{/number}","milestones_url":"https://api.github.com/repos/finagle/finch/milestones{/number}","notifications_url":"https://api.github.com/repos/finagle/finch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finagle/finch/labels{/name}","releases_url":"https://api.github.com/repos/finagle/finch/releases{/id}","deployments_url":"https://api.github.com/repos/finagle/finch/deployments","created_at":"2014-04-15T12:17:44Z","updated_at":"2016-10-18T13:42:30Z","pushed_at":"2016-10-18T23:13:54Z","git_url":"git://github.com/finagle/finch.git","ssh_url":"git@github.com:finagle/finch.git","clone_url":"https://github.com/finagle/finch.git","svn_url":"https://github.com/finagle/finch","homepage":"https://gitter.im/finagle/finch","size":5596,"stargazers_count":820,"watchers_count":820,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":131,"mirror_url":null,"open_issues_count":38,"forks":131,"open_issues":38,"watchers":820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finagle/finch/pulls/655"},"html":{"href":"https://github.com/finagle/finch/pull/655"},"issue":{"href":"https://api.github.com/repos/finagle/finch/issues/655"},"comments":{"href":"https://api.github.com/repos/finagle/finch/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/finagle/finch/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/finagle/finch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finagle/finch/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/finagle/finch/statuses/3572c6a9a99295ae0f7f455bd950d95432067686"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":94,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"rpless"}}