{"action":"created","issue":{"url":"https://api.github.com/repos/webdriverio/webdriverio/issues/969","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/969/labels{/name}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/969/comments","events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/969/events","html_url":"https://github.com/webdriverio/webdriverio/pull/969","id":123836995,"number":969,"title":"Onerror hook (includes staleElementRetry)","user":{"login":"christian-bromann","id":731337,"avatar_url":"https://avatars.githubusercontent.com/u/731337?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"georgecrawford","id":84737,"avatar_url":"https://avatars.githubusercontent.com/u/84737?v=3","gravatar_id":"","url":"https://api.github.com/users/georgecrawford","html_url":"https://github.com/georgecrawford","followers_url":"https://api.github.com/users/georgecrawford/followers","following_url":"https://api.github.com/users/georgecrawford/following{/other_user}","gists_url":"https://api.github.com/users/georgecrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/georgecrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgecrawford/subscriptions","organizations_url":"https://api.github.com/users/georgecrawford/orgs","repos_url":"https://api.github.com/users/georgecrawford/repos","events_url":"https://api.github.com/users/georgecrawford/events{/privacy}","received_events_url":"https://api.github.com/users/georgecrawford/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-12-24T22:25:36Z","updated_at":"2016-01-08T13:28:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/969","html_url":"https://github.com/webdriverio/webdriverio/pull/969","diff_url":"https://github.com/webdriverio/webdriverio/pull/969.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/969.patch"},"body":"please review @georgecrawford \r\n\r\nThis is my approach to retry stale element errors. Before the command promise gets resolved I basically resolve it with another promise that executes a set of `onError` handlers. We can now have internal error handlers to interfere on a variety on problems in the Selenium world. I really appreciate your effort you put into solving this issue but if it's okay for you I would like to go with this one as it comes with the following advantages:\r\n\r\n- all necessary changes were made webdriverio.js\r\n- no need to attach an error handler in each command or modify error objects\r\n- works also without wdio test runner\r\n\r\nLet me know what do you think?"},"comment":{"url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments/170004159","html_url":"https://github.com/webdriverio/webdriverio/pull/969#issuecomment-170004159","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/969","id":170004159,"user":{"login":"christian-bromann","id":731337,"avatar_url":"https://avatars.githubusercontent.com/u/731337?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T13:28:50Z","updated_at":"2016-01-08T13:28:50Z","body":"Thanks for investigating. I will have to take a look."}}