{"action":"closed","issue":{"url":"https://api.github.com/repos/cbergmeir/RSNNS/issues/1","repository_url":"https://api.github.com/repos/cbergmeir/RSNNS","labels_url":"https://api.github.com/repos/cbergmeir/RSNNS/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/cbergmeir/RSNNS/issues/1/comments","events_url":"https://api.github.com/repos/cbergmeir/RSNNS/issues/1/events","html_url":"https://github.com/cbergmeir/RSNNS/issues/1","id":42744963,"number":1,"title":"RBF sites/links handling","user":{"login":"TamerRizk","id":812888,"avatar_url":"https://avatars.githubusercontent.com/u/812888?v=3","gravatar_id":"","url":"https://api.github.com/users/TamerRizk","html_url":"https://github.com/TamerRizk","followers_url":"https://api.github.com/users/TamerRizk/followers","following_url":"https://api.github.com/users/TamerRizk/following{/other_user}","gists_url":"https://api.github.com/users/TamerRizk/gists{/gist_id}","starred_url":"https://api.github.com/users/TamerRizk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TamerRizk/subscriptions","organizations_url":"https://api.github.com/users/TamerRizk/orgs","repos_url":"https://api.github.com/users/TamerRizk/repos","events_url":"https://api.github.com/users/TamerRizk/events{/privacy}","received_events_url":"https://api.github.com/users/TamerRizk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-09-15T06:37:12Z","updated_at":"2016-03-21T06:45:36Z","closed_at":"2016-03-21T06:45:36Z","body":"krui_getSiteName chokes when using sites within the network and at least RadialBasisLearning due to incomplete link handling. Solution for learn_f.cpp:3724 as follows:\r\n```\r\nif (NetInitialize || LearnFuncHasChanged) {\r\n  FOR_ALL_UNITS(unit_ptr) {\r\n    if UNIT_HAS_SITES( unit_ptr ){\r\n      FOR_ALL_SITES_AND_LINKS(unit_ptr, site_ptr, link_ptr) {\r\n        link_ptr->value_a = 0.0;\r\n      }\r\n    }else{\r\n      FOR_ALL_LINKS(unit_ptr, link_ptr) {\r\n        link_ptr->value_a = 0.0;\r\n      }\r\n    }\r\n  }\r\n}\r\n```\r\nAlso, the following pointer operations in kr_mem.cpp look kind of suspicious. Should post increments be used instead? \r\n```\r\ntmp_ptr = ++link_array;\r\ntmp_ptr = ++site_array;\r\n``` \r\n"}}