{"action":"created","comment":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/69834061","id":69834061,"diff_hunk":"@@ -0,0 +1,38 @@\n+// Sandstorm - Personal Cloud Sandbox\n+// Copyright (c) 2016 Sandstorm Development Group, Inc. and contributors\n+// All rights reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//   http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+const Capnp = Npm.require(\"capnp\");\n+const IdentityRpc = Capnp.importSystem(\"sandstorm/identity-impl.capnp\");\n+\n+class IdentityImpl {","path":"shell/server/identity.js","position":20,"original_position":20,"commit_id":"34ca0526bf4cc96d3e572bcc5119472e462cc9c2","original_commit_id":"265c0c4019eabb352de7c6c6a712e2155a15666b","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"`class` declarations are not global AFAICT.","created_at":"2016-07-07T00:13:59Z","updated_at":"2016-07-07T00:13:59Z","html_url":"https://github.com/sandstorm-io/sandstorm/pull/2174#discussion_r69834061","pull_request_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174","_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/69834061"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/2174#discussion_r69834061"},"pull_request":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174"}}},"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174","id":76141127,"html_url":"https://github.com/sandstorm-io/sandstorm/pull/2174","diff_url":"https://github.com/sandstorm-io/sandstorm/pull/2174.diff","patch_url":"https://github.com/sandstorm-io/sandstorm/pull/2174.patch","issue_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2174","number":2174,"state":"open","locked":false,"title":"Activity events / notifications","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"When an app reports activity in a grain that you aren't looking at, it is highlighted on the sidebar and in the grain list. When you look at the grain, the highlight is cleared.\r\n\r\n![screenshot from 2016-07-04 02-56-06](https://cloud.githubusercontent.com/assets/4001805/16557337/fd388596-4193-11e6-8574-b145ffe185a7.png)\r\n\r\nAn app can indicate that you were explicitly mentioned/tagged/whatever. In this case, you get a bell notification. The sidebar also indicates the number of mentions outstanding for the grain. As soon as you visit the specific path in the grain where the mentions occurred (either by clicking on the notification, or otherwise), the notification is dismissed. This implies that you never receive notifications for the thing you're currently looking at.\r\n\r\n**The design is bad.** Sorry, Nena is on vacation, so I did what I could. Frankly I think a complete redesign of the notification popup is in order.\r\n\r\n![screenshot from 2016-07-04 02-56-55](https://cloud.githubusercontent.com/assets/4001805/16557374/346e33c6-4194-11e6-9189-5e7a6c278d5b.png)\r\n\r\nThe following Etherpad build that uses this API. Changes to the documentation cause the basic highlight. Comments send a notification to the document owner. Replies to comments send a notification to the comment author.\r\n\r\n    /install/4fa739c2f7f6d951e6df40723ca3da6a?url=https://cac5go56oaqt71vtfj43.oasis.sandstorm.io/etherpad-notify.spk\r\n\r\nThe following are *not* implemented and not likely to be anytime soon, as they are big projects in themselves:\r\n* Notification filter settings.\r\n* Reviewable activity logs.\r\n\r\nThe following are not implemented but likely will come soon:\r\n* Desktop notification integration.\r\n* Email notifications / digests.","created_at":"2016-07-04T10:11:56Z","updated_at":"2016-07-07T00:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0c8ea6d551b78640d8e77f66686eacbe7fd4421","assignee":{"login":"zarvox","id":307325,"avatar_url":"https://avatars.githubusercontent.com/u/307325?v=3","gravatar_id":"","url":"https://api.github.com/users/zarvox","html_url":"https://github.com/zarvox","followers_url":"https://api.github.com/users/zarvox/followers","following_url":"https://api.github.com/users/zarvox/following{/other_user}","gists_url":"https://api.github.com/users/zarvox/gists{/gist_id}","starred_url":"https://api.github.com/users/zarvox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarvox/subscriptions","organizations_url":"https://api.github.com/users/zarvox/orgs","repos_url":"https://api.github.com/users/zarvox/repos","events_url":"https://api.github.com/users/zarvox/events{/privacy}","received_events_url":"https://api.github.com/users/zarvox/received_events","type":"User","site_admin":false},"assignees":[{"login":"zarvox","id":307325,"avatar_url":"https://avatars.githubusercontent.com/u/307325?v=3","gravatar_id":"","url":"https://api.github.com/users/zarvox","html_url":"https://github.com/zarvox","followers_url":"https://api.github.com/users/zarvox/followers","following_url":"https://api.github.com/users/zarvox/following{/other_user}","gists_url":"https://api.github.com/users/zarvox/gists{/gist_id}","starred_url":"https://api.github.com/users/zarvox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarvox/subscriptions","organizations_url":"https://api.github.com/users/zarvox/orgs","repos_url":"https://api.github.com/users/zarvox/repos","events_url":"https://api.github.com/users/zarvox/events{/privacy}","received_events_url":"https://api.github.com/users/zarvox/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174/commits","review_comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174/comments","review_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2174/comments","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/34ca0526bf4cc96d3e572bcc5119472e462cc9c2","head":{"label":"sandstorm-io:activity","ref":"activity","sha":"34ca0526bf4cc96d3e572bcc5119472e462cc9c2","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":15728293,"name":"sandstorm","full_name":"sandstorm-io/sandstorm","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/sandstorm","description":"Personal Cloud Sandbox","fork":false,"url":"https://api.github.com/repos/sandstorm-io/sandstorm","forks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/forks","keys_url":"https://api.github.com/repos/sandstorm-io/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/sandstorm/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/events","assignees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/sandstorm/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/sandstorm/merges","archive_url":"https://api.github.com/repos/sandstorm-io/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/sandstorm/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/deployments","created_at":"2014-01-08T07:10:33Z","updated_at":"2016-07-06T04:11:22Z","pushed_at":"2016-07-06T23:56:09Z","git_url":"git://github.com/sandstorm-io/sandstorm.git","ssh_url":"git@github.com:sandstorm-io/sandstorm.git","clone_url":"https://github.com/sandstorm-io/sandstorm.git","svn_url":"https://github.com/sandstorm-io/sandstorm","homepage":"https://sandstorm.io","size":37648,"stargazers_count":3612,"watchers_count":3612,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":435,"forks":322,"open_issues":435,"watchers":3612,"default_branch":"master"}},"base":{"label":"sandstorm-io:master","ref":"master","sha":"22a1cc080ce32ba993362746d1c55c979f34442b","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":15728293,"name":"sandstorm","full_name":"sandstorm-io/sandstorm","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/sandstorm","description":"Personal Cloud Sandbox","fork":false,"url":"https://api.github.com/repos/sandstorm-io/sandstorm","forks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/forks","keys_url":"https://api.github.com/repos/sandstorm-io/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/sandstorm/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/events","assignees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/sandstorm/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/sandstorm/merges","archive_url":"https://api.github.com/repos/sandstorm-io/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/sandstorm/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/deployments","created_at":"2014-01-08T07:10:33Z","updated_at":"2016-07-06T04:11:22Z","pushed_at":"2016-07-06T23:56:09Z","git_url":"git://github.com/sandstorm-io/sandstorm.git","ssh_url":"git@github.com:sandstorm-io/sandstorm.git","clone_url":"https://github.com/sandstorm-io/sandstorm.git","svn_url":"https://github.com/sandstorm-io/sandstorm","homepage":"https://sandstorm.io","size":37648,"stargazers_count":3612,"watchers_count":3612,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":435,"forks":322,"open_issues":435,"watchers":3612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/2174"},"issue":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2174"},"comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2174/comments"},"review_comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174/comments"},"review_comment":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2174/commits"},"statuses":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/34ca0526bf4cc96d3e572bcc5119472e462cc9c2"}}}}
{"actor":{"display_login":"kentonv"}}