{"push_id":1003368971,"size":2,"distinct_size":1,"ref":"refs/heads/release-2.6.x","head":"3ed03593cfeb25c89fc3c13f52e524655720e7f4","before":"2bca11894bbe710e3d92c26b6378bf7a164524d7","commits":[{"sha":"9d5f2e1c7cadfb6d922e77d52c3d6dc16a7e636c","author":{"email":"be3138f63deb8c41fbf94334463b03a80b85e114@ualberta.ca","name":"weijie sun"},"message":"Fix deletion of file attachments which have never been made public.\n\nFile attachments which are added to a draft and then deleted before that draft\nis published are entirely invisible to all users of the server, but the\ndatabase entries and files on disk were still present. This wasn't critical but\nit's not nice to leak these when they'll never be shown to anyone.\n\nWith this change, if a file attachment has never been made public, instead of\nmoving it to the inactive file attachments relation, we instead delete the\nmodel.\n\nTesting Done:\n1. Added a single file, then deleted it before publishing. The url\n   r/xxxx/file/yyyy returns 404.\n2. Added a single file, then deleted it after publishing. The file exists.\n3. Added 2 files, one before publishing and another after publishing. The result\n   is same as above.\n\nRan unit tests.\n\nBugs closed: 4054\n\nReviewed at https://reviews.reviewboard.org/r/7879/","distinct":false,"url":"https://api.github.com/repos/reviewboard/reviewboard/commits/9d5f2e1c7cadfb6d922e77d52c3d6dc16a7e636c"},{"sha":"3ed03593cfeb25c89fc3c13f52e524655720e7f4","author":{"email":"d48e92e0fe6588b5a3f3112bd87e4d5c011e10af@beanbaginc.com","name":"Barret Rennie"},"message":"Merge branch 'release-2.5.x' into release-2.6.x","distinct":true,"url":"https://api.github.com/repos/reviewboard/reviewboard/commits/3ed03593cfeb25c89fc3c13f52e524655720e7f4"}]}