{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/55248094","id":55248094,"diff_hunk":"@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault() const{\n   default:\n       break;\n   }\n-  if (nac && nac->isAddedColumn() && nac->getDefaultValue())\n+  if (nac &&  nac->getDefaultValue() && strcmp(nac->getDefaultValue(),\"NULL\") != 0)","path":"core/sql/optimizer/ValueDesc.cpp","position":14,"original_position":14,"commit_id":"11c58b6d9e4331f01236bd588397189f2b626352","original_commit_id":"11c58b6d9e4331f01236bd588397189f2b626352","user":{"login":"eowhadi","id":12662542,"avatar_url":"https://avatars.githubusercontent.com/u/12662542?v=3","gravatar_id":"","url":"https://api.github.com/users/eowhadi","html_url":"https://github.com/eowhadi","followers_url":"https://api.github.com/users/eowhadi/followers","following_url":"https://api.github.com/users/eowhadi/following{/other_user}","gists_url":"https://api.github.com/users/eowhadi/gists{/gist_id}","starred_url":"https://api.github.com/users/eowhadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eowhadi/subscriptions","organizations_url":"https://api.github.com/users/eowhadi/orgs","repos_url":"https://api.github.com/users/eowhadi/repos","events_url":"https://api.github.com/users/eowhadi/events{/privacy}","received_events_url":"https://api.github.com/users/eowhadi/received_events","type":"User","site_admin":false},"body":"why is it better? I know what I do work. I don't know about the alternative. But I know how much a re run of regression cost :-)","created_at":"2016-03-07T18:31:37Z","updated_at":"2016-03-07T18:31:37Z","html_url":"https://github.com/apache/incubator-trafodion/pull/364#discussion_r55248094","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/55248094"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/364#discussion_r55248094"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364","id":61780552,"html_url":"https://github.com/apache/incubator-trafodion/pull/364","diff_url":"https://github.com/apache/incubator-trafodion/pull/364.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/364.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/364","number":364,"state":"open","locked":false,"title":"[TRAFODION-1863] PR340 caused PushdownV2 issues with column having non null default","user":{"login":"eowhadi","id":12662542,"avatar_url":"https://avatars.githubusercontent.com/u/12662542?v=3","gravatar_id":"","url":"https://api.github.com/users/eowhadi","html_url":"https://github.com/eowhadi","followers_url":"https://api.github.com/users/eowhadi/followers","following_url":"https://api.github.com/users/eowhadi/following{/other_user}","gists_url":"https://api.github.com/users/eowhadi/gists{/gist_id}","starred_url":"https://api.github.com/users/eowhadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eowhadi/subscriptions","organizations_url":"https://api.github.com/users/eowhadi/orgs","repos_url":"https://api.github.com/users/eowhadi/repos","events_url":"https://api.github.com/users/eowhadi/events{/privacy}","received_events_url":"https://api.github.com/users/eowhadi/received_events","type":"User","site_admin":false},"body":"since non null default columns are sometime resolved at select time, we need to disable pushdown for these.","created_at":"2016-03-04T22:23:32Z","updated_at":"2016-03-07T18:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"063016a9bd49e51bf989e680a55469438b5184c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/364/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/11c58b6d9e4331f01236bd588397189f2b626352","head":{"label":"eowhadi:jira1863","ref":"jira1863","sha":"11c58b6d9e4331f01236bd588397189f2b626352","user":{"login":"eowhadi","id":12662542,"avatar_url":"https://avatars.githubusercontent.com/u/12662542?v=3","gravatar_id":"","url":"https://api.github.com/users/eowhadi","html_url":"https://github.com/eowhadi","followers_url":"https://api.github.com/users/eowhadi/followers","following_url":"https://api.github.com/users/eowhadi/following{/other_user}","gists_url":"https://api.github.com/users/eowhadi/gists{/gist_id}","starred_url":"https://api.github.com/users/eowhadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eowhadi/subscriptions","organizations_url":"https://api.github.com/users/eowhadi/orgs","repos_url":"https://api.github.com/users/eowhadi/repos","events_url":"https://api.github.com/users/eowhadi/events{/privacy}","received_events_url":"https://api.github.com/users/eowhadi/received_events","type":"User","site_admin":false},"repo":{"id":38838590,"name":"incubator-trafodion","full_name":"eowhadi/incubator-trafodion","owner":{"login":"eowhadi","id":12662542,"avatar_url":"https://avatars.githubusercontent.com/u/12662542?v=3","gravatar_id":"","url":"https://api.github.com/users/eowhadi","html_url":"https://github.com/eowhadi","followers_url":"https://api.github.com/users/eowhadi/followers","following_url":"https://api.github.com/users/eowhadi/following{/other_user}","gists_url":"https://api.github.com/users/eowhadi/gists{/gist_id}","starred_url":"https://api.github.com/users/eowhadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eowhadi/subscriptions","organizations_url":"https://api.github.com/users/eowhadi/orgs","repos_url":"https://api.github.com/users/eowhadi/repos","events_url":"https://api.github.com/users/eowhadi/events{/privacy}","received_events_url":"https://api.github.com/users/eowhadi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eowhadi/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/eowhadi/incubator-trafodion","forks_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/eowhadi/incubator-trafodion/deployments","created_at":"2015-07-09T18:40:03Z","updated_at":"2015-07-09T18:40:42Z","pushed_at":"2016-03-04T22:13:45Z","git_url":"git://github.com/eowhadi/incubator-trafodion.git","ssh_url":"git@github.com:eowhadi/incubator-trafodion.git","clone_url":"https://github.com/eowhadi/incubator-trafodion.git","svn_url":"https://github.com/eowhadi/incubator-trafodion","homepage":null,"size":67908,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e24ea17da12d6e470d677e442e26cef360b95cf1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-trafodion/deployments","created_at":"2015-05-27T07:00:05Z","updated_at":"2016-03-03T12:47:40Z","pushed_at":"2016-03-07T18:27:59Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":69083,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":15,"forks":61,"open_issues":15,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/364"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/364"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/11c58b6d9e4331f01236bd588397189f2b626352"}}}}