{"action":"opened","number":14187,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/14187","id":92574526,"html_url":"https://github.com/odoo/odoo/pull/14187","diff_url":"https://github.com/odoo/odoo/pull/14187.diff","patch_url":"https://github.com/odoo/odoo/pull/14187.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/14187","number":14187,"state":"open","locked":false,"title":"[FIX][account] Update amounts on type change.","user":{"login":"Yajo","id":973709,"avatar_url":"https://avatars.githubusercontent.com/u/973709?v=3","gravatar_id":"","url":"https://api.github.com/users/Yajo","html_url":"https://github.com/Yajo","followers_url":"https://api.github.com/users/Yajo/followers","following_url":"https://api.github.com/users/Yajo/following{/other_user}","gists_url":"https://api.github.com/users/Yajo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yajo/subscriptions","organizations_url":"https://api.github.com/users/Yajo/orgs","repos_url":"https://api.github.com/users/Yajo/repos","events_url":"https://api.github.com/users/Yajo/events{/privacy}","received_events_url":"https://api.github.com/users/Yajo/received_events","type":"User","site_admin":false},"body":"Description of the issue/feature this PR addresses:\r\nType is used inside the method, but it is not added to its dependencies. If you change an invoice to be a refund, the signed amounts should be negative, but they are not until `_compute_amount` is manually called. This fixes that.\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n\r\n@Tecnativa","created_at":"2016-11-07T12:28:47Z","updated_at":"2016-11-07T12:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/14187/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/14187/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/14187/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/395120533afb02eda9d922f28757baa294c0e20c","head":{"label":"Tecnativa:9.0-account-amount_depends_on_type","ref":"9.0-account-amount_depends_on_type","sha":"395120533afb02eda9d922f28757baa294c0e20c","user":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars.githubusercontent.com/u/18120193?v=3","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"repo":{"id":58449069,"name":"odoo","full_name":"Tecnativa/odoo","owner":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars.githubusercontent.com/u/18120193?v=3","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tecnativa/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":true,"url":"https://api.github.com/repos/Tecnativa/odoo","forks_url":"https://api.github.com/repos/Tecnativa/odoo/forks","keys_url":"https://api.github.com/repos/Tecnativa/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tecnativa/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tecnativa/odoo/teams","hooks_url":"https://api.github.com/repos/Tecnativa/odoo/hooks","issue_events_url":"https://api.github.com/repos/Tecnativa/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/Tecnativa/odoo/events","assignees_url":"https://api.github.com/repos/Tecnativa/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/Tecnativa/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/Tecnativa/odoo/tags","blobs_url":"https://api.github.com/repos/Tecnativa/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tecnativa/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tecnativa/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tecnativa/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tecnativa/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/Tecnativa/odoo/languages","stargazers_url":"https://api.github.com/repos/Tecnativa/odoo/stargazers","contributors_url":"https://api.github.com/repos/Tecnativa/odoo/contributors","subscribers_url":"https://api.github.com/repos/Tecnativa/odoo/subscribers","subscription_url":"https://api.github.com/repos/Tecnativa/odoo/subscription","commits_url":"https://api.github.com/repos/Tecnativa/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tecnativa/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tecnativa/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tecnativa/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tecnativa/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/Tecnativa/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tecnativa/odoo/merges","archive_url":"https://api.github.com/repos/Tecnativa/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tecnativa/odoo/downloads","issues_url":"https://api.github.com/repos/Tecnativa/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/Tecnativa/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/Tecnativa/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/Tecnativa/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tecnativa/odoo/labels{/name}","releases_url":"https://api.github.com/repos/Tecnativa/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/Tecnativa/odoo/deployments","created_at":"2016-05-10T09:46:53Z","updated_at":"2016-05-10T09:48:09Z","pushed_at":"2016-11-07T12:23:31Z","git_url":"git://github.com/Tecnativa/odoo.git","ssh_url":"git@github.com:Tecnativa/odoo.git","clone_url":"https://github.com/Tecnativa/odoo.git","svn_url":"https://github.com/Tecnativa/odoo","homepage":"https://www.odoo.com","size":1800969,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"odoo:9.0","ref":"9.0","sha":"62b3de52dccc1c6b9e16e5a86320524efb474ad4","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2016-11-07T12:07:06Z","pushed_at":"2016-11-07T12:28:47Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2066867,"stargazers_count":5347,"watchers_count":5347,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5075,"mirror_url":null,"open_issues_count":3232,"forks":5075,"open_issues":3232,"watchers":5347,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/14187"},"html":{"href":"https://github.com/odoo/odoo/pull/14187"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/14187"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/14187/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/14187/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/14187/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/395120533afb02eda9d922f28757baa294c0e20c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"Yajo"}}