{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/88256758","pull_request_review_id":8835005,"id":88256758,"diff_hunk":"@@ -1714,19 +1705,14 @@ class All(CAReduce):\n     Equivalent to `CAReduce(scalar.and\\_, axis=axis)`.\n \n     \"\"\"\n+    __props__ = (\"axis\",)\n \n     def __init__(self, axis=None):\n         CAReduce.__init__(self, scalar.and_, axis)\n \n     def _output_dtype(self, idtype):\n         return \"int8\"\n \n-    def __str__(self):","path":"theano/tensor/elemwise.py","position":39,"original_position":39,"commit_id":"3b819206a2a21ff9f1bb53cc49fe7b0d63a9daae","original_commit_id":"3b819206a2a21ff9f1bb53cc49fe7b0d63a9daae","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"Add this back. This class (All) inherit from CAReduce that implement \\__str__. We don't want CARedure \\__str__.","created_at":"2016-11-16T15:23:40Z","updated_at":"2016-11-16T15:23:40Z","html_url":"https://github.com/Theano/Theano/pull/4749#discussion_r88256758","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4749","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/88256758"},"html":{"href":"https://github.com/Theano/Theano/pull/4749#discussion_r88256758"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4749"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4749","id":77720856,"html_url":"https://github.com/Theano/Theano/pull/4749","diff_url":"https://github.com/Theano/Theano/pull/4749.diff","patch_url":"https://github.com/Theano/Theano/pull/4749.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4749","number":4749,"state":"open","locked":false,"title":"Adding __props__ to all the Ops that has __init__","user":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"body":"Currently Raising error from the `__new__` of the Op class so that we could get to know better what classes don't have **props** implemented. I ran few tests and added the `__props__` , but for the remaining, i'll fix it from the error that travis would give. \n","created_at":"2016-07-16T22:15:25Z","updated_at":"2016-11-16T15:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7b9b9769701edca8df656128359a27afae8965a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4749/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4749/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4749/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/3b819206a2a21ff9f1bb53cc49fe7b0d63a9daae","head":{"label":"Sentient07:Props","ref":"Props","sha":"3b819206a2a21ff9f1bb53cc49fe7b0d63a9daae","user":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"repo":{"id":46736322,"name":"Theano","full_name":"Sentient07/Theano","owner":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sentient07/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/Sentient07/Theano","forks_url":"https://api.github.com/repos/Sentient07/Theano/forks","keys_url":"https://api.github.com/repos/Sentient07/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sentient07/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sentient07/Theano/teams","hooks_url":"https://api.github.com/repos/Sentient07/Theano/hooks","issue_events_url":"https://api.github.com/repos/Sentient07/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Sentient07/Theano/events","assignees_url":"https://api.github.com/repos/Sentient07/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Sentient07/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Sentient07/Theano/tags","blobs_url":"https://api.github.com/repos/Sentient07/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sentient07/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sentient07/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sentient07/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sentient07/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Sentient07/Theano/languages","stargazers_url":"https://api.github.com/repos/Sentient07/Theano/stargazers","contributors_url":"https://api.github.com/repos/Sentient07/Theano/contributors","subscribers_url":"https://api.github.com/repos/Sentient07/Theano/subscribers","subscription_url":"https://api.github.com/repos/Sentient07/Theano/subscription","commits_url":"https://api.github.com/repos/Sentient07/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sentient07/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sentient07/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sentient07/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sentient07/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Sentient07/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sentient07/Theano/merges","archive_url":"https://api.github.com/repos/Sentient07/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sentient07/Theano/downloads","issues_url":"https://api.github.com/repos/Sentient07/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Sentient07/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Sentient07/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Sentient07/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sentient07/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Sentient07/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Sentient07/Theano/deployments","created_at":"2015-11-23T17:21:47Z","updated_at":"2016-11-15T14:43:34Z","pushed_at":"2016-11-15T14:49:20Z","git_url":"git://github.com/Sentient07/Theano.git","ssh_url":"git@github.com:Sentient07/Theano.git","clone_url":"https://github.com/Sentient07/Theano.git","svn_url":"https://github.com/Sentient07/Theano","homepage":"http://www.deeplearning.net/software/theano","size":59853,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"173826a7bf5f042d78355b61d31c81fa572a3b9f","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-11-16T15:16:53Z","pushed_at":"2016-11-16T03:23:20Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":78976,"stargazers_count":4994,"watchers_count":4994,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1757,"mirror_url":null,"open_issues_count":734,"forks":1757,"open_issues":734,"watchers":4994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4749"},"html":{"href":"https://github.com/Theano/Theano/pull/4749"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4749"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4749/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4749/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4749/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/3b819206a2a21ff9f1bb53cc49fe7b0d63a9daae"}}}}
{"actor":{"display_login":"nouiz"}}