{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/ds2/pulls/comments/62138480","id":62138480,"diff_hunk":"@@ -201,8 +201,7 @@ ErrorCode Process::wait() {\n \n   switch (_currentThread->_stopInfo.event) {\n   case StopInfo::kEventNone:\n-    switch (_currentThread->_stopInfo.reason) {\n-    case StopInfo::kReasonNone:\n+    if (_currentThread->_stopInfo.reason == StopInfo::kReasonNone) {","path":"Sources/Target/FreeBSD/Process.cpp","position":6,"original_position":6,"commit_id":"10d4ef2852629e266a8ed2430f4a52cfe3bae5bb","original_commit_id":"7bcf7bd356c59e4fa33495a78eb710ee1de39d5f","user":{"login":"kokarez","id":2339063,"avatar_url":"https://avatars.githubusercontent.com/u/2339063?v=3","gravatar_id":"","url":"https://api.github.com/users/kokarez","html_url":"https://github.com/kokarez","followers_url":"https://api.github.com/users/kokarez/followers","following_url":"https://api.github.com/users/kokarez/following{/other_user}","gists_url":"https://api.github.com/users/kokarez/gists{/gist_id}","starred_url":"https://api.github.com/users/kokarez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokarez/subscriptions","organizations_url":"https://api.github.com/users/kokarez/orgs","repos_url":"https://api.github.com/users/kokarez/repos","events_url":"https://api.github.com/users/kokarez/events{/privacy}","received_events_url":"https://api.github.com/users/kokarez/received_events","type":"User","site_admin":false},"body":"Ahah :D I don't know if it make sense. But I can't really test, and we don't have tests, so I try to fix compilation with changing any behavior. If it's ok I will prefer to keep it like that until someone review/clean the freebsd code.","created_at":"2016-05-05T01:00:19Z","updated_at":"2016-05-05T01:00:19Z","html_url":"https://github.com/facebook/ds2/pull/314#discussion_r62138480","pull_request_url":"https://api.github.com/repos/facebook/ds2/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/facebook/ds2/pulls/comments/62138480"},"html":{"href":"https://github.com/facebook/ds2/pull/314#discussion_r62138480"},"pull_request":{"href":"https://api.github.com/repos/facebook/ds2/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/ds2/pulls/314","id":68830770,"html_url":"https://github.com/facebook/ds2/pull/314","diff_url":"https://github.com/facebook/ds2/pull/314.diff","patch_url":"https://github.com/facebook/ds2/pull/314.patch","issue_url":"https://api.github.com/repos/facebook/ds2/issues/314","number":314,"state":"open","locked":false,"title":"Fix compilation error on freebsd build","user":{"login":"kokarez","id":2339063,"avatar_url":"https://avatars.githubusercontent.com/u/2339063?v=3","gravatar_id":"","url":"https://api.github.com/users/kokarez","html_url":"https://github.com/kokarez","followers_url":"https://api.github.com/users/kokarez/followers","following_url":"https://api.github.com/users/kokarez/following{/other_user}","gists_url":"https://api.github.com/users/kokarez/gists{/gist_id}","starred_url":"https://api.github.com/users/kokarez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokarez/subscriptions","organizations_url":"https://api.github.com/users/kokarez/orgs","repos_url":"https://api.github.com/users/kokarez/repos","events_url":"https://api.github.com/users/kokarez/events{/privacy}","received_events_url":"https://api.github.com/users/kokarez/received_events","type":"User","site_admin":false},"body":"freebsd 10.1 have clang 3.4.1 by default and this doesn't sound to manage the flag inconsistent-missing-override. Since freebsd is compile with clang, not sure we want to force the simple user to upgrade clang version :-D\r\n\r\nThe other are just simple compilation fixes.","created_at":"2016-05-04T09:10:22Z","updated_at":"2016-05-05T01:00:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86476683b361903bf46a7b776a980afb20f05df5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/ds2/pulls/314/commits","review_comments_url":"https://api.github.com/repos/facebook/ds2/pulls/314/comments","review_comment_url":"https://api.github.com/repos/facebook/ds2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/ds2/issues/314/comments","statuses_url":"https://api.github.com/repos/facebook/ds2/statuses/10d4ef2852629e266a8ed2430f4a52cfe3bae5bb","head":{"label":"kokarez:issue/freebsdCompile","ref":"issue/freebsdCompile","sha":"10d4ef2852629e266a8ed2430f4a52cfe3bae5bb","user":{"login":"kokarez","id":2339063,"avatar_url":"https://avatars.githubusercontent.com/u/2339063?v=3","gravatar_id":"","url":"https://api.github.com/users/kokarez","html_url":"https://github.com/kokarez","followers_url":"https://api.github.com/users/kokarez/followers","following_url":"https://api.github.com/users/kokarez/following{/other_user}","gists_url":"https://api.github.com/users/kokarez/gists{/gist_id}","starred_url":"https://api.github.com/users/kokarez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokarez/subscriptions","organizations_url":"https://api.github.com/users/kokarez/orgs","repos_url":"https://api.github.com/users/kokarez/repos","events_url":"https://api.github.com/users/kokarez/events{/privacy}","received_events_url":"https://api.github.com/users/kokarez/received_events","type":"User","site_admin":false},"repo":{"id":51998638,"name":"ds2","full_name":"kokarez/ds2","owner":{"login":"kokarez","id":2339063,"avatar_url":"https://avatars.githubusercontent.com/u/2339063?v=3","gravatar_id":"","url":"https://api.github.com/users/kokarez","html_url":"https://github.com/kokarez","followers_url":"https://api.github.com/users/kokarez/followers","following_url":"https://api.github.com/users/kokarez/following{/other_user}","gists_url":"https://api.github.com/users/kokarez/gists{/gist_id}","starred_url":"https://api.github.com/users/kokarez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokarez/subscriptions","organizations_url":"https://api.github.com/users/kokarez/orgs","repos_url":"https://api.github.com/users/kokarez/repos","events_url":"https://api.github.com/users/kokarez/events{/privacy}","received_events_url":"https://api.github.com/users/kokarez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kokarez/ds2","description":"Debug server for lldb.","fork":true,"url":"https://api.github.com/repos/kokarez/ds2","forks_url":"https://api.github.com/repos/kokarez/ds2/forks","keys_url":"https://api.github.com/repos/kokarez/ds2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokarez/ds2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokarez/ds2/teams","hooks_url":"https://api.github.com/repos/kokarez/ds2/hooks","issue_events_url":"https://api.github.com/repos/kokarez/ds2/issues/events{/number}","events_url":"https://api.github.com/repos/kokarez/ds2/events","assignees_url":"https://api.github.com/repos/kokarez/ds2/assignees{/user}","branches_url":"https://api.github.com/repos/kokarez/ds2/branches{/branch}","tags_url":"https://api.github.com/repos/kokarez/ds2/tags","blobs_url":"https://api.github.com/repos/kokarez/ds2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokarez/ds2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokarez/ds2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokarez/ds2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokarez/ds2/statuses/{sha}","languages_url":"https://api.github.com/repos/kokarez/ds2/languages","stargazers_url":"https://api.github.com/repos/kokarez/ds2/stargazers","contributors_url":"https://api.github.com/repos/kokarez/ds2/contributors","subscribers_url":"https://api.github.com/repos/kokarez/ds2/subscribers","subscription_url":"https://api.github.com/repos/kokarez/ds2/subscription","commits_url":"https://api.github.com/repos/kokarez/ds2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokarez/ds2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokarez/ds2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokarez/ds2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokarez/ds2/contents/{+path}","compare_url":"https://api.github.com/repos/kokarez/ds2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokarez/ds2/merges","archive_url":"https://api.github.com/repos/kokarez/ds2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokarez/ds2/downloads","issues_url":"https://api.github.com/repos/kokarez/ds2/issues{/number}","pulls_url":"https://api.github.com/repos/kokarez/ds2/pulls{/number}","milestones_url":"https://api.github.com/repos/kokarez/ds2/milestones{/number}","notifications_url":"https://api.github.com/repos/kokarez/ds2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokarez/ds2/labels{/name}","releases_url":"https://api.github.com/repos/kokarez/ds2/releases{/id}","deployments_url":"https://api.github.com/repos/kokarez/ds2/deployments","created_at":"2016-02-18T10:12:42Z","updated_at":"2016-02-18T10:12:44Z","pushed_at":"2016-05-04T09:24:44Z","git_url":"git://github.com/kokarez/ds2.git","ssh_url":"git@github.com:kokarez/ds2.git","clone_url":"https://github.com/kokarez/ds2.git","svn_url":"https://github.com/kokarez/ds2","homepage":null,"size":1673,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5a73c473e4ce4d940c306af2307d0c470ae74627","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":25325140,"name":"ds2","full_name":"facebook/ds2","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/ds2","description":"Debug server for lldb.","fork":false,"url":"https://api.github.com/repos/facebook/ds2","forks_url":"https://api.github.com/repos/facebook/ds2/forks","keys_url":"https://api.github.com/repos/facebook/ds2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/ds2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/ds2/teams","hooks_url":"https://api.github.com/repos/facebook/ds2/hooks","issue_events_url":"https://api.github.com/repos/facebook/ds2/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/ds2/events","assignees_url":"https://api.github.com/repos/facebook/ds2/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/ds2/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/ds2/tags","blobs_url":"https://api.github.com/repos/facebook/ds2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/ds2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/ds2/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/ds2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/ds2/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/ds2/languages","stargazers_url":"https://api.github.com/repos/facebook/ds2/stargazers","contributors_url":"https://api.github.com/repos/facebook/ds2/contributors","subscribers_url":"https://api.github.com/repos/facebook/ds2/subscribers","subscription_url":"https://api.github.com/repos/facebook/ds2/subscription","commits_url":"https://api.github.com/repos/facebook/ds2/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/ds2/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/ds2/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/ds2/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/ds2/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/ds2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/ds2/merges","archive_url":"https://api.github.com/repos/facebook/ds2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/ds2/downloads","issues_url":"https://api.github.com/repos/facebook/ds2/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/ds2/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/ds2/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/ds2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/ds2/labels{/name}","releases_url":"https://api.github.com/repos/facebook/ds2/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/ds2/deployments","created_at":"2014-10-16T22:32:52Z","updated_at":"2016-05-04T20:03:04Z","pushed_at":"2016-05-04T09:24:44Z","git_url":"git://github.com/facebook/ds2.git","ssh_url":"git@github.com:facebook/ds2.git","clone_url":"https://github.com/facebook/ds2.git","svn_url":"https://github.com/facebook/ds2","homepage":null,"size":2211,"stargazers_count":135,"watchers_count":135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/ds2/pulls/314"},"html":{"href":"https://github.com/facebook/ds2/pull/314"},"issue":{"href":"https://api.github.com/repos/facebook/ds2/issues/314"},"comments":{"href":"https://api.github.com/repos/facebook/ds2/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/ds2/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/ds2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/ds2/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/ds2/statuses/10d4ef2852629e266a8ed2430f4a52cfe3bae5bb"}}}}