{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/dev-kit/issues/89","repository_url":"https://api.github.com/repos/sonata-project/dev-kit","labels_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/89/comments","events_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/89/events","html_url":"https://github.com/sonata-project/dev-kit/issues/89","id":155911130,"number":89,"title":"Recommend using Prophecy for mocking","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-05-20T08:27:46Z","updated_at":"2016-05-26T16:22:04Z","closed_at":null,"body":"Prophecy comes with phpunit [since version 4.5](https://thephp.cc/news/2015/02/phpunit-4-5-and-prophecy) , and I think we should default to using it for mocking things, because it is way way more concise unless you are mocking a class with a no arguments constructor and adding no expectations.\r\n\r\nSo several questions follow this : \r\n\r\n1. Should we allow using prophecy in tests : I vote :+1: \r\n1. Should we recommend using prophecy in new tests : I vote :+1: \r\n1. Should we refuse phpunit mocks in new tests : I vote :-1: \r\n1. Should we migrate all tests to prophecy, for consistency's sake  I vote :-1:\r\n1. Should we refuse mixing Prophecy and Mocks in the same test (method or class) :+1: \r\n"},"comment":{"url":"https://api.github.com/repos/sonata-project/dev-kit/issues/comments/221921377","html_url":"https://github.com/sonata-project/dev-kit/issues/89#issuecomment-221921377","issue_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/89","id":221921377,"user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T16:22:03Z","updated_at":"2016-05-26T16:22:03Z","body":"Should we refuse phpunit mocks in new tests : I vote :-1:\r\n"}}
{"actor":{"display_login":"greg0ire"}}