{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56714462","id":56714462,"diff_hunk":"@@ -2,39 +2,22 @@\n // The .NET Foundation licenses this file to you under the MIT license.\n // See the LICENSE file in the project root for more information.\n \n-using System;\n-using System.Globalization;\n using Xunit;\n \n namespace System.Globalization.Tests\n {\n     public class CultureInfoClone\n     {\n-        [Fact]\n-        public void TestClone1()\n+        [Theory]\n+        [InlineData(\"\")]\n+        [InlineData(\"fr-FR\")]\n+        [InlineData(\"en\")]\n+        public void TestClone(string name)\n         {\n-            CultureInfo myCultureInfo = new CultureInfo(\"fr-FR\");\n-            CultureInfo myClone = myCultureInfo.Clone() as CultureInfo;\n-            Assert.True(myClone.Equals(myCultureInfo));\n-            Assert.NotSame(myClone, myCultureInfo);\n-        }\n-\n-        [Fact]\n-        public void TestClone2()\n-        {\n-            CultureInfo myCultureInfo = new CultureInfo(\"en\");\n-            CultureInfo myClone = myCultureInfo.Clone() as CultureInfo;\n-            Assert.True(myClone.Equals(myCultureInfo));\n-            Assert.NotSame(myClone, myCultureInfo);\n-        }\n-\n-        [Fact]\n-        public void TestClone3()\n-        {\n-            CultureInfo myTestCulture = CultureInfo.InvariantCulture;\n-            CultureInfo myClone = myTestCulture.Clone() as CultureInfo;\n-            Assert.True(myClone.Equals(myTestCulture));\n-            Assert.NotSame(myClone, myTestCulture);\n+            CultureInfo culture = new CultureInfo(name);","path":"src/System.Globalization/tests/CultureInfo/CultureInfoClone.cs","position":42,"original_position":42,"commit_id":"02ed061eb0baf003b1be207027cc90833afb244c","original_commit_id":"02ed061eb0baf003b1be207027cc90833afb244c","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"I realize that \"\" represents an invariant culture, but it'd be good not to lose the test for CultureInfo.InvariantCulture explicitly.","created_at":"2016-03-18T20:04:39Z","updated_at":"2016-03-18T20:04:39Z","html_url":"https://github.com/dotnet/corefx/pull/6683#discussion_r56714462","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6683","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56714462"},"html":{"href":"https://github.com/dotnet/corefx/pull/6683#discussion_r56714462"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6683"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6683","id":61811267,"html_url":"https://github.com/dotnet/corefx/pull/6683","diff_url":"https://github.com/dotnet/corefx/pull/6683.diff","patch_url":"https://github.com/dotnet/corefx/pull/6683.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6683","number":6683,"state":"open","locked":false,"title":"Cleanup CultureInfo tests","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"- Removed/merged duplicate tests\r\n- Renamed tests from \"PostTest1\" etc.\r\n- Fixes some todos for Windows 10 tests\r\n\r\nContributes to #2103","created_at":"2016-03-05T12:50:10Z","updated_at":"2016-03-18T20:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2e0160a26cd8037e7757b4a417d7e8d049d8949","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6683/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6683/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6683/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/02ed061eb0baf003b1be207027cc90833afb244c","head":{"label":"hughbe:globalization-tests-culture-info","ref":"globalization-tests-culture-info","sha":"02ed061eb0baf003b1be207027cc90833afb244c","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":47085914,"name":"corefx","full_name":"hughbe/corefx","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hughbe/corefx","forks_url":"https://api.github.com/repos/hughbe/corefx/forks","keys_url":"https://api.github.com/repos/hughbe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/corefx/teams","hooks_url":"https://api.github.com/repos/hughbe/corefx/hooks","issue_events_url":"https://api.github.com/repos/hughbe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/corefx/events","assignees_url":"https://api.github.com/repos/hughbe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/corefx/tags","blobs_url":"https://api.github.com/repos/hughbe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/corefx/languages","stargazers_url":"https://api.github.com/repos/hughbe/corefx/stargazers","contributors_url":"https://api.github.com/repos/hughbe/corefx/contributors","subscribers_url":"https://api.github.com/repos/hughbe/corefx/subscribers","subscription_url":"https://api.github.com/repos/hughbe/corefx/subscription","commits_url":"https://api.github.com/repos/hughbe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/corefx/merges","archive_url":"https://api.github.com/repos/hughbe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/corefx/downloads","issues_url":"https://api.github.com/repos/hughbe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/corefx/deployments","created_at":"2015-11-30T00:15:59Z","updated_at":"2016-01-17T12:57:11Z","pushed_at":"2016-03-18T16:39:50Z","git_url":"git://github.com/hughbe/corefx.git","ssh_url":"git@github.com:hughbe/corefx.git","clone_url":"https://github.com/hughbe/corefx.git","svn_url":"https://github.com/hughbe/corefx","homepage":"http://dotnet.github.io/","size":60098,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"33c49f5c643f1313e92df471d75c345460bdbe02","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-03-18T11:44:45Z","pushed_at":"2016-03-18T19:56:50Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":80629,"stargazers_count":9338,"watchers_count":9338,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2197,"mirror_url":null,"open_issues_count":928,"forks":2197,"open_issues":928,"watchers":9338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6683"},"html":{"href":"https://github.com/dotnet/corefx/pull/6683"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6683"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6683/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6683/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6683/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/02ed061eb0baf003b1be207027cc90833afb244c"}}}}