{"action":"created","comment":{"url":"https://api.github.com/repos/beamly/q-combinators/pulls/comments/66255594","id":66255594,"diff_hunk":"@@ -1,4 +1,4 @@\n-var Q = require('q');\n+var promise = require('./promise');","path":"src/object.js","position":2,"original_position":2,"commit_id":"cb7f834d549aee6664f8d1c6ddd5e03484a5ffcc","original_commit_id":"cb7f834d549aee6664f8d1c6ddd5e03484a5ffcc","user":{"login":"jonathan-fielding","id":630034,"avatar_url":"https://avatars.githubusercontent.com/u/630034?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathan-fielding","html_url":"https://github.com/jonathan-fielding","followers_url":"https://api.github.com/users/jonathan-fielding/followers","following_url":"https://api.github.com/users/jonathan-fielding/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-fielding/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-fielding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-fielding/subscriptions","organizations_url":"https://api.github.com/users/jonathan-fielding/orgs","repos_url":"https://api.github.com/users/jonathan-fielding/repos","events_url":"https://api.github.com/users/jonathan-fielding/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-fielding/received_events","type":"User","site_admin":false},"body":"could this be named something different, it feels like Promise is a key word so shouldn't be a variable you use, perhaps promiseImp or even promiseLib","created_at":"2016-06-08T13:32:46Z","updated_at":"2016-06-08T13:32:46Z","html_url":"https://github.com/beamly/q-combinators/pull/18#discussion_r66255594","pull_request_url":"https://api.github.com/repos/beamly/q-combinators/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/comments/66255594"},"html":{"href":"https://github.com/beamly/q-combinators/pull/18#discussion_r66255594"},"pull_request":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/beamly/q-combinators/pulls/18","id":73013660,"html_url":"https://github.com/beamly/q-combinators/pull/18","diff_url":"https://github.com/beamly/q-combinators/pull/18.diff","patch_url":"https://github.com/beamly/q-combinators/pull/18.patch","issue_url":"https://api.github.com/repos/beamly/q-combinators/issues/18","number":18,"state":"open","locked":false,"title":"Support other promise implementations","user":{"login":"ixalon","id":206188,"avatar_url":"https://avatars.githubusercontent.com/u/206188?v=3","gravatar_id":"","url":"https://api.github.com/users/ixalon","html_url":"https://github.com/ixalon","followers_url":"https://api.github.com/users/ixalon/followers","following_url":"https://api.github.com/users/ixalon/following{/other_user}","gists_url":"https://api.github.com/users/ixalon/gists{/gist_id}","starred_url":"https://api.github.com/users/ixalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixalon/subscriptions","organizations_url":"https://api.github.com/users/ixalon/orgs","repos_url":"https://api.github.com/users/ixalon/repos","events_url":"https://api.github.com/users/ixalon/events{/privacy}","received_events_url":"https://api.github.com/users/ixalon/received_events","type":"User","site_admin":false},"body":"But leave Q as the default for backwards compatibility.","created_at":"2016-06-08T09:29:44Z","updated_at":"2016-06-08T13:32:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdc9addd37659751ded18eadb3196d50fdf405b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/beamly/q-combinators/pulls/18/commits","review_comments_url":"https://api.github.com/repos/beamly/q-combinators/pulls/18/comments","review_comment_url":"https://api.github.com/repos/beamly/q-combinators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beamly/q-combinators/issues/18/comments","statuses_url":"https://api.github.com/repos/beamly/q-combinators/statuses/cb7f834d549aee6664f8d1c6ddd5e03484a5ffcc","head":{"label":"beamly:chris/support-other-promise-libs","ref":"chris/support-other-promise-libs","sha":"cb7f834d549aee6664f8d1c6ddd5e03484a5ffcc","user":{"login":"beamly","id":6714950,"avatar_url":"https://avatars.githubusercontent.com/u/6714950?v=3","gravatar_id":"","url":"https://api.github.com/users/beamly","html_url":"https://github.com/beamly","followers_url":"https://api.github.com/users/beamly/followers","following_url":"https://api.github.com/users/beamly/following{/other_user}","gists_url":"https://api.github.com/users/beamly/gists{/gist_id}","starred_url":"https://api.github.com/users/beamly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamly/subscriptions","organizations_url":"https://api.github.com/users/beamly/orgs","repos_url":"https://api.github.com/users/beamly/repos","events_url":"https://api.github.com/users/beamly/events{/privacy}","received_events_url":"https://api.github.com/users/beamly/received_events","type":"Organization","site_admin":false},"repo":{"id":16137967,"name":"q-combinators","full_name":"beamly/q-combinators","owner":{"login":"beamly","id":6714950,"avatar_url":"https://avatars.githubusercontent.com/u/6714950?v=3","gravatar_id":"","url":"https://api.github.com/users/beamly","html_url":"https://github.com/beamly","followers_url":"https://api.github.com/users/beamly/followers","following_url":"https://api.github.com/users/beamly/following{/other_user}","gists_url":"https://api.github.com/users/beamly/gists{/gist_id}","starred_url":"https://api.github.com/users/beamly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamly/subscriptions","organizations_url":"https://api.github.com/users/beamly/orgs","repos_url":"https://api.github.com/users/beamly/repos","events_url":"https://api.github.com/users/beamly/events{/privacy}","received_events_url":"https://api.github.com/users/beamly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beamly/q-combinators","description":"Functions to combine q promises, capturing lots of useful, real world patterns used across Beamly's node.js services.","fork":false,"url":"https://api.github.com/repos/beamly/q-combinators","forks_url":"https://api.github.com/repos/beamly/q-combinators/forks","keys_url":"https://api.github.com/repos/beamly/q-combinators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beamly/q-combinators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beamly/q-combinators/teams","hooks_url":"https://api.github.com/repos/beamly/q-combinators/hooks","issue_events_url":"https://api.github.com/repos/beamly/q-combinators/issues/events{/number}","events_url":"https://api.github.com/repos/beamly/q-combinators/events","assignees_url":"https://api.github.com/repos/beamly/q-combinators/assignees{/user}","branches_url":"https://api.github.com/repos/beamly/q-combinators/branches{/branch}","tags_url":"https://api.github.com/repos/beamly/q-combinators/tags","blobs_url":"https://api.github.com/repos/beamly/q-combinators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beamly/q-combinators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beamly/q-combinators/git/refs{/sha}","trees_url":"https://api.github.com/repos/beamly/q-combinators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beamly/q-combinators/statuses/{sha}","languages_url":"https://api.github.com/repos/beamly/q-combinators/languages","stargazers_url":"https://api.github.com/repos/beamly/q-combinators/stargazers","contributors_url":"https://api.github.com/repos/beamly/q-combinators/contributors","subscribers_url":"https://api.github.com/repos/beamly/q-combinators/subscribers","subscription_url":"https://api.github.com/repos/beamly/q-combinators/subscription","commits_url":"https://api.github.com/repos/beamly/q-combinators/commits{/sha}","git_commits_url":"https://api.github.com/repos/beamly/q-combinators/git/commits{/sha}","comments_url":"https://api.github.com/repos/beamly/q-combinators/comments{/number}","issue_comment_url":"https://api.github.com/repos/beamly/q-combinators/issues/comments{/number}","contents_url":"https://api.github.com/repos/beamly/q-combinators/contents/{+path}","compare_url":"https://api.github.com/repos/beamly/q-combinators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beamly/q-combinators/merges","archive_url":"https://api.github.com/repos/beamly/q-combinators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beamly/q-combinators/downloads","issues_url":"https://api.github.com/repos/beamly/q-combinators/issues{/number}","pulls_url":"https://api.github.com/repos/beamly/q-combinators/pulls{/number}","milestones_url":"https://api.github.com/repos/beamly/q-combinators/milestones{/number}","notifications_url":"https://api.github.com/repos/beamly/q-combinators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beamly/q-combinators/labels{/name}","releases_url":"https://api.github.com/repos/beamly/q-combinators/releases{/id}","deployments_url":"https://api.github.com/repos/beamly/q-combinators/deployments","created_at":"2014-01-22T11:52:28Z","updated_at":"2016-03-09T08:07:47Z","pushed_at":"2016-06-08T12:35:24Z","git_url":"git://github.com/beamly/q-combinators.git","ssh_url":"git@github.com:beamly/q-combinators.git","clone_url":"https://github.com/beamly/q-combinators.git","svn_url":"https://github.com/beamly/q-combinators","homepage":"","size":48,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"base":{"label":"beamly:master","ref":"master","sha":"50683014c5de7286c69dd07ff14a6f833e521b79","user":{"login":"beamly","id":6714950,"avatar_url":"https://avatars.githubusercontent.com/u/6714950?v=3","gravatar_id":"","url":"https://api.github.com/users/beamly","html_url":"https://github.com/beamly","followers_url":"https://api.github.com/users/beamly/followers","following_url":"https://api.github.com/users/beamly/following{/other_user}","gists_url":"https://api.github.com/users/beamly/gists{/gist_id}","starred_url":"https://api.github.com/users/beamly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamly/subscriptions","organizations_url":"https://api.github.com/users/beamly/orgs","repos_url":"https://api.github.com/users/beamly/repos","events_url":"https://api.github.com/users/beamly/events{/privacy}","received_events_url":"https://api.github.com/users/beamly/received_events","type":"Organization","site_admin":false},"repo":{"id":16137967,"name":"q-combinators","full_name":"beamly/q-combinators","owner":{"login":"beamly","id":6714950,"avatar_url":"https://avatars.githubusercontent.com/u/6714950?v=3","gravatar_id":"","url":"https://api.github.com/users/beamly","html_url":"https://github.com/beamly","followers_url":"https://api.github.com/users/beamly/followers","following_url":"https://api.github.com/users/beamly/following{/other_user}","gists_url":"https://api.github.com/users/beamly/gists{/gist_id}","starred_url":"https://api.github.com/users/beamly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beamly/subscriptions","organizations_url":"https://api.github.com/users/beamly/orgs","repos_url":"https://api.github.com/users/beamly/repos","events_url":"https://api.github.com/users/beamly/events{/privacy}","received_events_url":"https://api.github.com/users/beamly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beamly/q-combinators","description":"Functions to combine q promises, capturing lots of useful, real world patterns used across Beamly's node.js services.","fork":false,"url":"https://api.github.com/repos/beamly/q-combinators","forks_url":"https://api.github.com/repos/beamly/q-combinators/forks","keys_url":"https://api.github.com/repos/beamly/q-combinators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beamly/q-combinators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beamly/q-combinators/teams","hooks_url":"https://api.github.com/repos/beamly/q-combinators/hooks","issue_events_url":"https://api.github.com/repos/beamly/q-combinators/issues/events{/number}","events_url":"https://api.github.com/repos/beamly/q-combinators/events","assignees_url":"https://api.github.com/repos/beamly/q-combinators/assignees{/user}","branches_url":"https://api.github.com/repos/beamly/q-combinators/branches{/branch}","tags_url":"https://api.github.com/repos/beamly/q-combinators/tags","blobs_url":"https://api.github.com/repos/beamly/q-combinators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beamly/q-combinators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beamly/q-combinators/git/refs{/sha}","trees_url":"https://api.github.com/repos/beamly/q-combinators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beamly/q-combinators/statuses/{sha}","languages_url":"https://api.github.com/repos/beamly/q-combinators/languages","stargazers_url":"https://api.github.com/repos/beamly/q-combinators/stargazers","contributors_url":"https://api.github.com/repos/beamly/q-combinators/contributors","subscribers_url":"https://api.github.com/repos/beamly/q-combinators/subscribers","subscription_url":"https://api.github.com/repos/beamly/q-combinators/subscription","commits_url":"https://api.github.com/repos/beamly/q-combinators/commits{/sha}","git_commits_url":"https://api.github.com/repos/beamly/q-combinators/git/commits{/sha}","comments_url":"https://api.github.com/repos/beamly/q-combinators/comments{/number}","issue_comment_url":"https://api.github.com/repos/beamly/q-combinators/issues/comments{/number}","contents_url":"https://api.github.com/repos/beamly/q-combinators/contents/{+path}","compare_url":"https://api.github.com/repos/beamly/q-combinators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beamly/q-combinators/merges","archive_url":"https://api.github.com/repos/beamly/q-combinators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beamly/q-combinators/downloads","issues_url":"https://api.github.com/repos/beamly/q-combinators/issues{/number}","pulls_url":"https://api.github.com/repos/beamly/q-combinators/pulls{/number}","milestones_url":"https://api.github.com/repos/beamly/q-combinators/milestones{/number}","notifications_url":"https://api.github.com/repos/beamly/q-combinators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beamly/q-combinators/labels{/name}","releases_url":"https://api.github.com/repos/beamly/q-combinators/releases{/id}","deployments_url":"https://api.github.com/repos/beamly/q-combinators/deployments","created_at":"2014-01-22T11:52:28Z","updated_at":"2016-03-09T08:07:47Z","pushed_at":"2016-06-08T12:35:24Z","git_url":"git://github.com/beamly/q-combinators.git","ssh_url":"git@github.com:beamly/q-combinators.git","clone_url":"https://github.com/beamly/q-combinators.git","svn_url":"https://github.com/beamly/q-combinators","homepage":"","size":48,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/18"},"html":{"href":"https://github.com/beamly/q-combinators/pull/18"},"issue":{"href":"https://api.github.com/repos/beamly/q-combinators/issues/18"},"comments":{"href":"https://api.github.com/repos/beamly/q-combinators/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beamly/q-combinators/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/beamly/q-combinators/statuses/cb7f834d549aee6664f8d1c6ddd5e03484a5ffcc"}}}}
{"actor":{"display_login":"jonathan-fielding"}}