{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/comments/48884417","id":48884417,"diff_hunk":"@@ -1,12 +1,22 @@\n var EsLint = require(\"eslint\").linter;\n+var EsLintConfigFile = require(\"eslint/lib/config/config-file\");","path":"lib/linter.js","position":2,"original_position":2,"commit_id":"651688be0c9e4cd060df400c5940d0858d2d18c1","original_commit_id":"651688be0c9e4cd060df400c5940d0858d2d18c1","user":{"login":"teoljungberg","id":810650,"avatar_url":"https://avatars.githubusercontent.com/u/810650?v=3","gravatar_id":"","url":"https://api.github.com/users/teoljungberg","html_url":"https://github.com/teoljungberg","followers_url":"https://api.github.com/users/teoljungberg/followers","following_url":"https://api.github.com/users/teoljungberg/following{/other_user}","gists_url":"https://api.github.com/users/teoljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/teoljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teoljungberg/subscriptions","organizations_url":"https://api.github.com/users/teoljungberg/orgs","repos_url":"https://api.github.com/users/teoljungberg/repos","events_url":"https://api.github.com/users/teoljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/teoljungberg/received_events","type":"User","site_admin":false},"body":"It sadly is private, https://github.com/eslint/eslint/blob/master/lib/config/config-file.js. I didn't see any other way of solving this.","created_at":"2016-01-05T19:21:15Z","updated_at":"2016-01-05T19:21:15Z","html_url":"https://github.com/thoughtbot/hound-eslint/pull/6#discussion_r48884417","pull_request_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/comments/48884417"},"html":{"href":"https://github.com/thoughtbot/hound-eslint/pull/6#discussion_r48884417"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6","id":55110466,"html_url":"https://github.com/thoughtbot/hound-eslint/pull/6","diff_url":"https://github.com/thoughtbot/hound-eslint/pull/6.diff","patch_url":"https://github.com/thoughtbot/hound-eslint/pull/6.patch","issue_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/6","number":6,"state":"open","locked":false,"title":"Parse configuration files using ESLint","user":{"login":"teoljungberg","id":810650,"avatar_url":"https://avatars.githubusercontent.com/u/810650?v=3","gravatar_id":"","url":"https://api.github.com/users/teoljungberg","html_url":"https://github.com/teoljungberg","followers_url":"https://api.github.com/users/teoljungberg/followers","following_url":"https://api.github.com/users/teoljungberg/following{/other_user}","gists_url":"https://api.github.com/users/teoljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/teoljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teoljungberg/subscriptions","organizations_url":"https://api.github.com/users/teoljungberg/orgs","repos_url":"https://api.github.com/users/teoljungberg/repos","events_url":"https://api.github.com/users/teoljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/teoljungberg/received_events","type":"User","site_admin":false},"body":"This changes how the parsing logic works in hound-eslint, by using how\nESLint parses its configuration files internally. Which means the users\nwill be less surprised using hound-eslint, since their configuration\nfiles will work as intended.\n\nChanges:\n\n- Add `temp` to create a tempfile with the content of the configuration\n  files. All this, since `ESLint` expects real files - which is\n  something that we do not have.\n- Promote `parseConfig` to live on the prototype on `Linter`.\n- Add unit tests for parsing a sample ESLint configuration file, which\n  has trailing commas in it. Which are invalid JSON, but a valid ESLint\n  configuration file.\n\nhttps://trello.com/c/mriKkZaE","created_at":"2016-01-05T16:22:28Z","updated_at":"2016-01-05T19:21:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d10969c86396cf3455a4f55e4aa3a67a35aabbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/6/comments","statuses_url":"https://api.github.com/repos/thoughtbot/hound-eslint/statuses/651688be0c9e4cd060df400c5940d0858d2d18c1","head":{"label":"thoughtbot:extend-config-parsing","ref":"extend-config-parsing","sha":"651688be0c9e4cd060df400c5940d0858d2d18c1","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":44117622,"name":"hound-eslint","full_name":"thoughtbot/hound-eslint","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/hound-eslint","description":"ESLint review service for Hound","fork":false,"url":"https://api.github.com/repos/thoughtbot/hound-eslint","forks_url":"https://api.github.com/repos/thoughtbot/hound-eslint/forks","keys_url":"https://api.github.com/repos/thoughtbot/hound-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/hound-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/hound-eslint/teams","hooks_url":"https://api.github.com/repos/thoughtbot/hound-eslint/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/hound-eslint/events","assignees_url":"https://api.github.com/repos/thoughtbot/hound-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/hound-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/hound-eslint/tags","blobs_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/hound-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/hound-eslint/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/hound-eslint/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/hound-eslint/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/hound-eslint/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/hound-eslint/subscription","commits_url":"https://api.github.com/repos/thoughtbot/hound-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/hound-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/hound-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/hound-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/hound-eslint/merges","archive_url":"https://api.github.com/repos/thoughtbot/hound-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/hound-eslint/downloads","issues_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/hound-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/hound-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/hound-eslint/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/hound-eslint/releases{/id}","created_at":"2015-10-12T15:49:40Z","updated_at":"2015-12-03T02:03:49Z","pushed_at":"2016-01-05T16:22:29Z","git_url":"git://github.com/thoughtbot/hound-eslint.git","ssh_url":"git@github.com:thoughtbot/hound-eslint.git","clone_url":"https://github.com/thoughtbot/hound-eslint.git","svn_url":"https://github.com/thoughtbot/hound-eslint","homepage":"https://houndci.com","size":14,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"a63cc442f7262643dda5e7afad63b56d5f4d4c1a","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":44117622,"name":"hound-eslint","full_name":"thoughtbot/hound-eslint","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/hound-eslint","description":"ESLint review service for Hound","fork":false,"url":"https://api.github.com/repos/thoughtbot/hound-eslint","forks_url":"https://api.github.com/repos/thoughtbot/hound-eslint/forks","keys_url":"https://api.github.com/repos/thoughtbot/hound-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/hound-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/hound-eslint/teams","hooks_url":"https://api.github.com/repos/thoughtbot/hound-eslint/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/hound-eslint/events","assignees_url":"https://api.github.com/repos/thoughtbot/hound-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/hound-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/hound-eslint/tags","blobs_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/hound-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/hound-eslint/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/hound-eslint/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/hound-eslint/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/hound-eslint/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/hound-eslint/subscription","commits_url":"https://api.github.com/repos/thoughtbot/hound-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/hound-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/hound-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/hound-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/hound-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/hound-eslint/merges","archive_url":"https://api.github.com/repos/thoughtbot/hound-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/hound-eslint/downloads","issues_url":"https://api.github.com/repos/thoughtbot/hound-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/hound-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/hound-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/hound-eslint/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/hound-eslint/releases{/id}","created_at":"2015-10-12T15:49:40Z","updated_at":"2015-12-03T02:03:49Z","pushed_at":"2016-01-05T16:22:29Z","git_url":"git://github.com/thoughtbot/hound-eslint.git","ssh_url":"git@github.com:thoughtbot/hound-eslint.git","clone_url":"https://github.com/thoughtbot/hound-eslint.git","svn_url":"https://github.com/thoughtbot/hound-eslint","homepage":"https://houndci.com","size":14,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6"},"html":{"href":"https://github.com/thoughtbot/hound-eslint/pull/6"},"issue":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/6"},"comments":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/hound-eslint/statuses/651688be0c9e4cd060df400c5940d0858d2d18c1"}}}}