{"action":"created","issue":{"url":"https://api.github.com/repos/fisherman/fisherman/issues/174","repository_url":"https://api.github.com/repos/fisherman/fisherman","labels_url":"https://api.github.com/repos/fisherman/fisherman/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/fisherman/fisherman/issues/174/comments","events_url":"https://api.github.com/repos/fisherman/fisherman/issues/174/events","html_url":"https://github.com/fisherman/fisherman/pull/174","id":143792835,"number":174,"title":"Usual Makefile","user":{"login":"orangecms","id":4245199,"avatar_url":"https://avatars.githubusercontent.com/u/4245199?v=3","gravatar_id":"","url":"https://api.github.com/users/orangecms","html_url":"https://github.com/orangecms","followers_url":"https://api.github.com/users/orangecms/followers","following_url":"https://api.github.com/users/orangecms/following{/other_user}","gists_url":"https://api.github.com/users/orangecms/gists{/gist_id}","starred_url":"https://api.github.com/users/orangecms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangecms/subscriptions","organizations_url":"https://api.github.com/users/orangecms/orgs","repos_url":"https://api.github.com/users/orangecms/repos","events_url":"https://api.github.com/users/orangecms/events{/privacy}","received_events_url":"https://api.github.com/users/orangecms/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fisherman/fisherman/labels/DISCUSSION","name":"DISCUSSION","color":"00A3FF"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-03-27T09:43:12Z","updated_at":"2016-03-27T13:08:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fisherman/fisherman/pulls/174","html_url":"https://github.com/fisherman/fisherman/pull/174","diff_url":"https://github.com/fisherman/fisherman/pull/174.diff","patch_url":"https://github.com/fisherman/fisherman/pull/174.patch"},"body":"A `Makefile` usually offers two things, allowing for easy packaging and installation:\r\n- a `make` step which creates a build (not yet necessary for Fisherman)\r\n- a `make install` step which copies the resulting files to a given `$PREFIX` directory\r\n\r\nSo you could run e.g. `PREFIX=/usr/local make && make install`.\r\n\r\nThe current Makefile, however, manipulates a user's `config.fish` without their consent and doesn't create something like a build. This means that packagers cannot use it at all and have to find their own way of copying the files, figuring out which are needed and where to put them, etc..\r\n\r\nI haven't yet really investigated the `make test` step, but it should finally be offered as well. It should be possible to run it easily, but currently requires `fishtape` to be present."},"comment":{"url":"https://api.github.com/repos/fisherman/fisherman/issues/comments/202058641","html_url":"https://github.com/fisherman/fisherman/pull/174#issuecomment-202058641","issue_url":"https://api.github.com/repos/fisherman/fisherman/issues/174","id":202058641,"user":{"login":"orangecms","id":4245199,"avatar_url":"https://avatars.githubusercontent.com/u/4245199?v=3","gravatar_id":"","url":"https://api.github.com/users/orangecms","html_url":"https://github.com/orangecms","followers_url":"https://api.github.com/users/orangecms/followers","following_url":"https://api.github.com/users/orangecms/following{/other_user}","gists_url":"https://api.github.com/users/orangecms/gists{/gist_id}","starred_url":"https://api.github.com/users/orangecms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangecms/subscriptions","organizations_url":"https://api.github.com/users/orangecms/orgs","repos_url":"https://api.github.com/users/orangecms/repos","events_url":"https://api.github.com/users/orangecms/events{/privacy}","received_events_url":"https://api.github.com/users/orangecms/received_events","type":"User","site_admin":false},"created_at":"2016-03-27T13:08:33Z","updated_at":"2016-03-27T13:08:33Z","body":"That would only work as long as fish works though, since fisher is not a standalone tool. We should discuss that in another issue."}}