{"action":"created","comment":{"url":"https://api.github.com/repos/github/git-lfs/pulls/comments/87366096","pull_request_review_id":7970022,"id":87366096,"diff_hunk":"@@ -41,11 +43,13 @@ var (\n \t\tProperties: map[string]string{\n \t\t\t\"clean\":    \"git-lfs clean -- %f\",\n \t\t\t\"smudge\":   \"git-lfs smudge --skip -- %f\",\n+\t\t\t\"process\":  \"git-lfs filter-process --skip\",\n \t\t\t\"required\": \"true\",\n \t\t},\n \t\tUpgradeables: map[string][]string{\n-\t\t\t\"clean\":  []string{\"git-lfs clean %f\"},\n-\t\t\t\"smudge\": []string{\"git-lfs smudge --skip %f\"},\n+\t\t\t\"clean\":   []string{\"git-lfs clean %f\"},\n+\t\t\t\"smudge\":  []string{\"git-lfs smudge --skip %f\"},\n+\t\t\t\"process\": []string{\"git-lfs filter --skip\"},","path":"lfs/setup.go","position":28,"original_position":28,"commit_id":"d236d06a578215dd4500300aaa85ff01df041ffa","original_commit_id":"d236d06a578215dd4500300aaa85ff01df041ffa","user":{"login":"larsxschneider","id":477434,"avatar_url":"https://avatars.githubusercontent.com/u/477434?v=3","gravatar_id":"","url":"https://api.github.com/users/larsxschneider","html_url":"https://github.com/larsxschneider","followers_url":"https://api.github.com/users/larsxschneider/followers","following_url":"https://api.github.com/users/larsxschneider/following{/other_user}","gists_url":"https://api.github.com/users/larsxschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/larsxschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsxschneider/subscriptions","organizations_url":"https://api.github.com/users/larsxschneider/orgs","repos_url":"https://api.github.com/users/larsxschneider/repos","events_url":"https://api.github.com/users/larsxschneider/events{/privacy}","received_events_url":"https://api.github.com/users/larsxschneider/received_events","type":"User","site_admin":false},"body":"**Important:** Shouldn't that be `filter-process` here?","created_at":"2016-11-10T10:25:23Z","updated_at":"2016-11-10T10:31:06Z","html_url":"https://github.com/github/git-lfs/pull/1617#discussion_r87366096","pull_request_url":"https://api.github.com/repos/github/git-lfs/pulls/1617","_links":{"self":{"href":"https://api.github.com/repos/github/git-lfs/pulls/comments/87366096"},"html":{"href":"https://github.com/github/git-lfs/pull/1617#discussion_r87366096"},"pull_request":{"href":"https://api.github.com/repos/github/git-lfs/pulls/1617"}}},"pull_request":{"url":"https://api.github.com/repos/github/git-lfs/pulls/1617","id":92016779,"html_url":"https://github.com/github/git-lfs/pull/1617","diff_url":"https://github.com/github/git-lfs/pull/1617.diff","patch_url":"https://github.com/github/git-lfs/pull/1617.patch","issue_url":"https://api.github.com/repos/github/git-lfs/issues/1617","number":1617,"state":"open","locked":false,"title":"Filter Protocol Support","user":{"login":"ttaylorr","id":443245,"avatar_url":"https://avatars.githubusercontent.com/u/443245?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaylorr","html_url":"https://github.com/ttaylorr","followers_url":"https://api.github.com/users/ttaylorr/followers","following_url":"https://api.github.com/users/ttaylorr/following{/other_user}","gists_url":"https://api.github.com/users/ttaylorr/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaylorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaylorr/subscriptions","organizations_url":"https://api.github.com/users/ttaylorr/orgs","repos_url":"https://api.github.com/users/ttaylorr/repos","events_url":"https://api.github.com/users/ttaylorr/events{/privacy}","received_events_url":"https://api.github.com/users/ttaylorr/received_events","type":"User","site_admin":true},"body":"This pull-request is a continuation of #1382, originally authored by @larsxschneider.\r\n\r\nIt should serve as a place to merge in all of PRs in the filter-stream series (see description below), and then be merged into master as one huge thing. I'm suggesting this since the PR as of https://github.com/github/git-lfs/commit/46a8ee599d0da1fdee59bcdcdbfcbdc966e5db8e is incomplete, and not in a state that I would feel comfortable landing into master.\r\n\r\nIn terms of the PR series, here's what I'm thinking:\r\n\r\n1. https://github.com/github/git-lfs/pull/1617: Initial implementation of the filter protocol from @larsxschneider, that's this PR. \r\n2. https://github.com/github/git-lfs/pull/1618: Integration tests to make sure that all subsequent PRs keep working\r\n3. https://github.com/github/git-lfs/pull/1619: Unit tests around the protocol reading/writing to verify that its behavior is correct.\r\n4. https://github.com/github/git-lfs/pull/1620: Make the ObjectScanner behave like a Scanner. \r\n5. https://github.com/github/git-lfs/pull/1621: An `io.Reader` implementation for reading data off of the filter stream, and wiring that `io.Reader` up throughout the code\r\n6. https://github.com/github/git-lfs/pull/1622: An `io.Writer` implementation for writing streams of data to the filter stream, and wiring that up\r\n7. ~~[pending]:~~ A cleanup PR to rename types, document anything that I missed, and generally apply some 💅  EDIT: this was done in place\r\n\r\n-----\r\n\r\n/cc @larsxschneider @technoweenie @sinbad @rubyist @sschuberth ","created_at":"2016-11-02T17:23:34Z","updated_at":"2016-11-10T10:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56d8474878c82658303656627dc067d9164a881d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/github/git-lfs/milestones/2","html_url":"https://github.com/github/git-lfs/milestones/v1.5.0","labels_url":"https://api.github.com/repos/github/git-lfs/milestones/2/labels","id":2124678,"number":2,"title":"v1.5.0","description":"","creator":{"login":"technoweenie","id":21,"avatar_url":"https://avatars.githubusercontent.com/u/21?v=3","gravatar_id":"","url":"https://api.github.com/users/technoweenie","html_url":"https://github.com/technoweenie","followers_url":"https://api.github.com/users/technoweenie/followers","following_url":"https://api.github.com/users/technoweenie/following{/other_user}","gists_url":"https://api.github.com/users/technoweenie/gists{/gist_id}","starred_url":"https://api.github.com/users/technoweenie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technoweenie/subscriptions","organizations_url":"https://api.github.com/users/technoweenie/orgs","repos_url":"https://api.github.com/users/technoweenie/repos","events_url":"https://api.github.com/users/technoweenie/events{/privacy}","received_events_url":"https://api.github.com/users/technoweenie/received_events","type":"User","site_admin":true},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2016-11-09T14:12:54Z","updated_at":"2016-11-09T16:22:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/github/git-lfs/pulls/1617/commits","review_comments_url":"https://api.github.com/repos/github/git-lfs/pulls/1617/comments","review_comment_url":"https://api.github.com/repos/github/git-lfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/git-lfs/issues/1617/comments","statuses_url":"https://api.github.com/repos/github/git-lfs/statuses/d236d06a578215dd4500300aaa85ff01df041ffa","head":{"label":"github:filter-stream","ref":"filter-stream","sha":"d236d06a578215dd4500300aaa85ff01df041ffa","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":13021798,"name":"git-lfs","full_name":"github/git-lfs","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/git-lfs","description":"Git extension for versioning large files","fork":false,"url":"https://api.github.com/repos/github/git-lfs","forks_url":"https://api.github.com/repos/github/git-lfs/forks","keys_url":"https://api.github.com/repos/github/git-lfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/git-lfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/git-lfs/teams","hooks_url":"https://api.github.com/repos/github/git-lfs/hooks","issue_events_url":"https://api.github.com/repos/github/git-lfs/issues/events{/number}","events_url":"https://api.github.com/repos/github/git-lfs/events","assignees_url":"https://api.github.com/repos/github/git-lfs/assignees{/user}","branches_url":"https://api.github.com/repos/github/git-lfs/branches{/branch}","tags_url":"https://api.github.com/repos/github/git-lfs/tags","blobs_url":"https://api.github.com/repos/github/git-lfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/git-lfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/git-lfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/git-lfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/git-lfs/statuses/{sha}","languages_url":"https://api.github.com/repos/github/git-lfs/languages","stargazers_url":"https://api.github.com/repos/github/git-lfs/stargazers","contributors_url":"https://api.github.com/repos/github/git-lfs/contributors","subscribers_url":"https://api.github.com/repos/github/git-lfs/subscribers","subscription_url":"https://api.github.com/repos/github/git-lfs/subscription","commits_url":"https://api.github.com/repos/github/git-lfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/git-lfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/git-lfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/git-lfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/git-lfs/contents/{+path}","compare_url":"https://api.github.com/repos/github/git-lfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/git-lfs/merges","archive_url":"https://api.github.com/repos/github/git-lfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/git-lfs/downloads","issues_url":"https://api.github.com/repos/github/git-lfs/issues{/number}","pulls_url":"https://api.github.com/repos/github/git-lfs/pulls{/number}","milestones_url":"https://api.github.com/repos/github/git-lfs/milestones{/number}","notifications_url":"https://api.github.com/repos/github/git-lfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/git-lfs/labels{/name}","releases_url":"https://api.github.com/repos/github/git-lfs/releases{/id}","deployments_url":"https://api.github.com/repos/github/git-lfs/deployments","created_at":"2013-09-22T22:03:28Z","updated_at":"2016-11-09T21:56:28Z","pushed_at":"2016-11-10T01:01:49Z","git_url":"git://github.com/github/git-lfs.git","ssh_url":"git@github.com:github/git-lfs.git","clone_url":"https://github.com/github/git-lfs.git","svn_url":"https://github.com/github/git-lfs","homepage":"https://git-lfs.github.com","size":12943,"stargazers_count":4030,"watchers_count":4030,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":163,"forks":580,"open_issues":163,"watchers":4030,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"a45eaee6fa35993763f87aa7611586faea08dfd5","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":13021798,"name":"git-lfs","full_name":"github/git-lfs","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/git-lfs","description":"Git extension for versioning large files","fork":false,"url":"https://api.github.com/repos/github/git-lfs","forks_url":"https://api.github.com/repos/github/git-lfs/forks","keys_url":"https://api.github.com/repos/github/git-lfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/git-lfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/git-lfs/teams","hooks_url":"https://api.github.com/repos/github/git-lfs/hooks","issue_events_url":"https://api.github.com/repos/github/git-lfs/issues/events{/number}","events_url":"https://api.github.com/repos/github/git-lfs/events","assignees_url":"https://api.github.com/repos/github/git-lfs/assignees{/user}","branches_url":"https://api.github.com/repos/github/git-lfs/branches{/branch}","tags_url":"https://api.github.com/repos/github/git-lfs/tags","blobs_url":"https://api.github.com/repos/github/git-lfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/git-lfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/git-lfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/git-lfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/git-lfs/statuses/{sha}","languages_url":"https://api.github.com/repos/github/git-lfs/languages","stargazers_url":"https://api.github.com/repos/github/git-lfs/stargazers","contributors_url":"https://api.github.com/repos/github/git-lfs/contributors","subscribers_url":"https://api.github.com/repos/github/git-lfs/subscribers","subscription_url":"https://api.github.com/repos/github/git-lfs/subscription","commits_url":"https://api.github.com/repos/github/git-lfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/git-lfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/git-lfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/git-lfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/git-lfs/contents/{+path}","compare_url":"https://api.github.com/repos/github/git-lfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/git-lfs/merges","archive_url":"https://api.github.com/repos/github/git-lfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/git-lfs/downloads","issues_url":"https://api.github.com/repos/github/git-lfs/issues{/number}","pulls_url":"https://api.github.com/repos/github/git-lfs/pulls{/number}","milestones_url":"https://api.github.com/repos/github/git-lfs/milestones{/number}","notifications_url":"https://api.github.com/repos/github/git-lfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/git-lfs/labels{/name}","releases_url":"https://api.github.com/repos/github/git-lfs/releases{/id}","deployments_url":"https://api.github.com/repos/github/git-lfs/deployments","created_at":"2013-09-22T22:03:28Z","updated_at":"2016-11-09T21:56:28Z","pushed_at":"2016-11-10T01:01:49Z","git_url":"git://github.com/github/git-lfs.git","ssh_url":"git@github.com:github/git-lfs.git","clone_url":"https://github.com/github/git-lfs.git","svn_url":"https://github.com/github/git-lfs","homepage":"https://git-lfs.github.com","size":12943,"stargazers_count":4030,"watchers_count":4030,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":163,"forks":580,"open_issues":163,"watchers":4030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/git-lfs/pulls/1617"},"html":{"href":"https://github.com/github/git-lfs/pull/1617"},"issue":{"href":"https://api.github.com/repos/github/git-lfs/issues/1617"},"comments":{"href":"https://api.github.com/repos/github/git-lfs/issues/1617/comments"},"review_comments":{"href":"https://api.github.com/repos/github/git-lfs/pulls/1617/comments"},"review_comment":{"href":"https://api.github.com/repos/github/git-lfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/git-lfs/pulls/1617/commits"},"statuses":{"href":"https://api.github.com/repos/github/git-lfs/statuses/d236d06a578215dd4500300aaa85ff01df041ffa"}}}}
{"actor":{"display_login":"larsxschneider"}}