{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/81351147","pull_request_review_id":2338169,"id":81351147,"diff_hunk":"@@ -168,16 +179,29 @@ func newServer(s *state.State, lis net.Listener, cfg ServerConfig) (_ *Server, e\n \treturn srv, nil\n }\n \n-func (srv *Server) newTLSConfig() *tls.Config {\n+func (srv *Server) newTLSConfig(cfg ServerConfig) *tls.Config {\n+\ttlsConfig := utils.SecureTLSConfig()\n+\tlogger.Infof(\"newTLSConfig, OfficialDNSName %q\", cfg.OfficialDNSName)","path":"apiserver/apiserver.go","position":41,"original_position":41,"commit_id":"dce514aa0d3d199ca49e43236b3e6f793ca3a500","original_commit_id":"dce514aa0d3d199ca49e43236b3e6f793ca3a500","user":{"login":"frankban","id":1408172,"avatar_url":"https://avatars.githubusercontent.com/u/1408172?v=3","gravatar_id":"","url":"https://api.github.com/users/frankban","html_url":"https://github.com/frankban","followers_url":"https://api.github.com/users/frankban/followers","following_url":"https://api.github.com/users/frankban/following{/other_user}","gists_url":"https://api.github.com/users/frankban/gists{/gist_id}","starred_url":"https://api.github.com/users/frankban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankban/subscriptions","organizations_url":"https://api.github.com/users/frankban/orgs","repos_url":"https://api.github.com/users/frankban/repos","events_url":"https://api.github.com/users/frankban/events{/privacy}","received_events_url":"https://api.github.com/users/frankban/received_events","type":"User","site_admin":false},"body":"leftover?","created_at":"2016-09-30T14:37:51Z","updated_at":"2016-09-30T14:37:51Z","html_url":"https://github.com/juju/juju/pull/6363#discussion_r81351147","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/6363","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/81351147"},"html":{"href":"https://github.com/juju/juju/pull/6363#discussion_r81351147"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/6363"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6363","id":87488451,"html_url":"https://github.com/juju/juju/pull/6363","diff_url":"https://github.com/juju/juju/pull/6363.diff","patch_url":"https://github.com/juju/juju/pull/6363.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6363","number":6363,"state":"open","locked":false,"title":"controller: add official-dns-name and autocert-url attributes","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"This adds a controller configuration option to explicitly enable\r\nautocert retrieval - a request at any other DNS name will use\r\nthe self-generated certificate.\r\n\r\nAs autocert generation doesn't work unless the controller is listening\r\non port 443, we make the bootstrap command warn if that's not the\r\ncase (but provide an override in case someone wants to do port\r\nforwarding).\r\n\r\nTo QA, bootstrap a controller with:\r\n\r\n    juju bootstrap --debug --config 'official-dns-name=<your domain name>' --config 'api-port=443' ec2 aws\r\n\r\nThen configure the DNS record for your domain name to point to the IP address of the newly\r\nbootstrapped controller, and change the api-endpoints entries in controllers.yaml to refer to <your domain name>:443 and delete the ca-cert entry.\r\n\r\nThen you should be able to connect OK to it.\r\n","created_at":"2016-09-30T12:53:29Z","updated_at":"2016-09-30T14:46:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4404928851c7d408fe9a84a715527915a47ee665","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6363/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6363/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6363/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/dce514aa0d3d199ca49e43236b3e6f793ca3a500","head":{"label":"rogpeppe:105-official-dns-name","ref":"105-official-dns-name","sha":"dce514aa0d3d199ca49e43236b3e6f793ca3a500","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":20528487,"name":"juju","full_name":"rogpeppe/juju","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/rogpeppe/juju","forks_url":"https://api.github.com/repos/rogpeppe/juju/forks","keys_url":"https://api.github.com/repos/rogpeppe/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/juju/teams","hooks_url":"https://api.github.com/repos/rogpeppe/juju/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/juju/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/juju/events","assignees_url":"https://api.github.com/repos/rogpeppe/juju/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/juju/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/juju/tags","blobs_url":"https://api.github.com/repos/rogpeppe/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/juju/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/juju/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/juju/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/juju/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/juju/subscription","commits_url":"https://api.github.com/repos/rogpeppe/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogpeppe/juju/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/juju/merges","archive_url":"https://api.github.com/repos/rogpeppe/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/juju/downloads","issues_url":"https://api.github.com/repos/rogpeppe/juju/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/juju/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/juju/releases{/id}","deployments_url":"https://api.github.com/repos/rogpeppe/juju/deployments","created_at":"2014-06-05T14:36:16Z","updated_at":"2014-06-13T17:22:25Z","pushed_at":"2016-09-30T12:51:27Z","git_url":"git://github.com/rogpeppe/juju.git","ssh_url":"git@github.com:rogpeppe/juju.git","clone_url":"https://github.com/rogpeppe/juju.git","svn_url":"https://github.com/rogpeppe/juju","homepage":"juju.ubuntu.com","size":90746,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"d0ff839ae327c44fe70da49e52da55e4c742778d","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-09-30T06:21:28Z","pushed_at":"2016-09-30T14:49:16Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":126235,"stargazers_count":513,"watchers_count":513,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":23,"forks":158,"open_issues":23,"watchers":513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6363"},"html":{"href":"https://github.com/juju/juju/pull/6363"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6363"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6363/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6363/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6363/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/dce514aa0d3d199ca49e43236b3e6f793ca3a500"}}}}
{"actor":{"display_login":"frankban"}}