{"action":"created","comment":{"url":"https://api.github.com/repos/AquiTCD/protospace/pulls/comments/83829621","pull_request_review_id":4646022,"id":83829621,"diff_hunk":"@@ -7,4 +7,9 @@ class User < ActiveRecord::Base\n   has_many :prototypes\n   has_many :likes, dependent: :destroy\n   has_many :comments, dependent: :destroy\n+\n+  validates_presence_of :name, :email, :password, :password_confirmation\n+  VALID_EMAIL_REGEX = /\\A[\\w+\\-.]+@[a-z\\d\\-.]+\\.[a-z]+\\z/i","path":"app/models/user.rb","position":6,"original_position":6,"commit_id":"7b38d307f9763aae54fe69ef1871f3eae42751be","original_commit_id":"7b38d307f9763aae54fe69ef1871f3eae42751be","user":{"login":"hand12","id":15228193,"avatar_url":"https://avatars.githubusercontent.com/u/15228193?v=3","gravatar_id":"","url":"https://api.github.com/users/hand12","html_url":"https://github.com/hand12","followers_url":"https://api.github.com/users/hand12/followers","following_url":"https://api.github.com/users/hand12/following{/other_user}","gists_url":"https://api.github.com/users/hand12/gists{/gist_id}","starred_url":"https://api.github.com/users/hand12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hand12/subscriptions","organizations_url":"https://api.github.com/users/hand12/orgs","repos_url":"https://api.github.com/users/hand12/repos","events_url":"https://api.github.com/users/hand12/events{/privacy}","received_events_url":"https://api.github.com/users/hand12/received_events","type":"User","site_admin":false},"body":"deviseにdefaultでemailの書式のvalidationは書いてあるので設定しなくてもvalidationはできています！","created_at":"2016-10-18T11:03:21Z","updated_at":"2016-10-18T11:03:21Z","html_url":"https://github.com/AquiTCD/protospace/pull/23#discussion_r83829621","pull_request_url":"https://api.github.com/repos/AquiTCD/protospace/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/comments/83829621"},"html":{"href":"https://github.com/AquiTCD/protospace/pull/23#discussion_r83829621"},"pull_request":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/AquiTCD/protospace/pulls/23","id":89488067,"html_url":"https://github.com/AquiTCD/protospace/pull/23","diff_url":"https://github.com/AquiTCD/protospace/pull/23.diff","patch_url":"https://github.com/AquiTCD/protospace/pull/23.patch","issue_url":"https://api.github.com/repos/AquiTCD/protospace/issues/23","number":23,"state":"open","locked":false,"title":"Rspecによるモデルテスト","user":{"login":"AquiTCD","id":7114503,"avatar_url":"https://avatars.githubusercontent.com/u/7114503?v=3","gravatar_id":"","url":"https://api.github.com/users/AquiTCD","html_url":"https://github.com/AquiTCD","followers_url":"https://api.github.com/users/AquiTCD/followers","following_url":"https://api.github.com/users/AquiTCD/following{/other_user}","gists_url":"https://api.github.com/users/AquiTCD/gists{/gist_id}","starred_url":"https://api.github.com/users/AquiTCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquiTCD/subscriptions","organizations_url":"https://api.github.com/users/AquiTCD/orgs","repos_url":"https://api.github.com/users/AquiTCD/repos","events_url":"https://api.github.com/users/AquiTCD/events{/privacy}","received_events_url":"https://api.github.com/users/AquiTCD/received_events","type":"User","site_admin":false},"body":"What I want\r\n----------------------------------------\r\n- Rspecの環境構築\r\n- モデルのテスト\r\n  - prototype\r\n  - user\r\n  - captured_image\r\n\r\nWhy I need\r\n----------------------------------------\r\n- 各モデルの正常系、異常系のチェック\r\n\r\nWhat I did\r\n----------------------------------------\r\n- 必要だったが不足していたバリデーションを追加\r\n\r\nWhat I did NOT\r\n----------------------------------------\r\n- メソッドなどのリファクタリング\r\n\r\nAdditional image(s)\r\n----------------------------------------\r\nna\r\n\r\nnotes\r\n----------------------------------------\r\n- バリデーションが正常にできてなかったことで苦戦した\r\n- factrory girlと仲良くなれなくて苦戦した\r\n- 合計で三日以上つまると泣きたくなる\r\n\r\nTodo\r\n----------------------------------------\r\n- [x] Rspecの環境構築\r\n- [x] モデルのテスト\r\n  - [x] prototype\r\n  - [x] captured_image\r\n  - [x] user\r\n- [ ] コントローラのテスト\r\n  - [ ] prototype\r\n  - [ ] user","created_at":"2016-10-15T09:46:23Z","updated_at":"2016-10-18T11:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d55b06f41c2fa8540bb855359938a48880266189","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AquiTCD/protospace/pulls/23/commits","review_comments_url":"https://api.github.com/repos/AquiTCD/protospace/pulls/23/comments","review_comment_url":"https://api.github.com/repos/AquiTCD/protospace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AquiTCD/protospace/issues/23/comments","statuses_url":"https://api.github.com/repos/AquiTCD/protospace/statuses/7b38d307f9763aae54fe69ef1871f3eae42751be","head":{"label":"AquiTCD:feature/rspec-test","ref":"feature/rspec-test","sha":"7b38d307f9763aae54fe69ef1871f3eae42751be","user":{"login":"AquiTCD","id":7114503,"avatar_url":"https://avatars.githubusercontent.com/u/7114503?v=3","gravatar_id":"","url":"https://api.github.com/users/AquiTCD","html_url":"https://github.com/AquiTCD","followers_url":"https://api.github.com/users/AquiTCD/followers","following_url":"https://api.github.com/users/AquiTCD/following{/other_user}","gists_url":"https://api.github.com/users/AquiTCD/gists{/gist_id}","starred_url":"https://api.github.com/users/AquiTCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquiTCD/subscriptions","organizations_url":"https://api.github.com/users/AquiTCD/orgs","repos_url":"https://api.github.com/users/AquiTCD/repos","events_url":"https://api.github.com/users/AquiTCD/events{/privacy}","received_events_url":"https://api.github.com/users/AquiTCD/received_events","type":"User","site_admin":false},"repo":{"id":68073318,"name":"protospace","full_name":"AquiTCD/protospace","owner":{"login":"AquiTCD","id":7114503,"avatar_url":"https://avatars.githubusercontent.com/u/7114503?v=3","gravatar_id":"","url":"https://api.github.com/users/AquiTCD","html_url":"https://github.com/AquiTCD","followers_url":"https://api.github.com/users/AquiTCD/followers","following_url":"https://api.github.com/users/AquiTCD/following{/other_user}","gists_url":"https://api.github.com/users/AquiTCD/gists{/gist_id}","starred_url":"https://api.github.com/users/AquiTCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquiTCD/subscriptions","organizations_url":"https://api.github.com/users/AquiTCD/orgs","repos_url":"https://api.github.com/users/AquiTCD/repos","events_url":"https://api.github.com/users/AquiTCD/events{/privacy}","received_events_url":"https://api.github.com/users/AquiTCD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AquiTCD/protospace","description":"a web application from tech-camp carriculum","fork":false,"url":"https://api.github.com/repos/AquiTCD/protospace","forks_url":"https://api.github.com/repos/AquiTCD/protospace/forks","keys_url":"https://api.github.com/repos/AquiTCD/protospace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AquiTCD/protospace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AquiTCD/protospace/teams","hooks_url":"https://api.github.com/repos/AquiTCD/protospace/hooks","issue_events_url":"https://api.github.com/repos/AquiTCD/protospace/issues/events{/number}","events_url":"https://api.github.com/repos/AquiTCD/protospace/events","assignees_url":"https://api.github.com/repos/AquiTCD/protospace/assignees{/user}","branches_url":"https://api.github.com/repos/AquiTCD/protospace/branches{/branch}","tags_url":"https://api.github.com/repos/AquiTCD/protospace/tags","blobs_url":"https://api.github.com/repos/AquiTCD/protospace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AquiTCD/protospace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AquiTCD/protospace/git/refs{/sha}","trees_url":"https://api.github.com/repos/AquiTCD/protospace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AquiTCD/protospace/statuses/{sha}","languages_url":"https://api.github.com/repos/AquiTCD/protospace/languages","stargazers_url":"https://api.github.com/repos/AquiTCD/protospace/stargazers","contributors_url":"https://api.github.com/repos/AquiTCD/protospace/contributors","subscribers_url":"https://api.github.com/repos/AquiTCD/protospace/subscribers","subscription_url":"https://api.github.com/repos/AquiTCD/protospace/subscription","commits_url":"https://api.github.com/repos/AquiTCD/protospace/commits{/sha}","git_commits_url":"https://api.github.com/repos/AquiTCD/protospace/git/commits{/sha}","comments_url":"https://api.github.com/repos/AquiTCD/protospace/comments{/number}","issue_comment_url":"https://api.github.com/repos/AquiTCD/protospace/issues/comments{/number}","contents_url":"https://api.github.com/repos/AquiTCD/protospace/contents/{+path}","compare_url":"https://api.github.com/repos/AquiTCD/protospace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AquiTCD/protospace/merges","archive_url":"https://api.github.com/repos/AquiTCD/protospace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AquiTCD/protospace/downloads","issues_url":"https://api.github.com/repos/AquiTCD/protospace/issues{/number}","pulls_url":"https://api.github.com/repos/AquiTCD/protospace/pulls{/number}","milestones_url":"https://api.github.com/repos/AquiTCD/protospace/milestones{/number}","notifications_url":"https://api.github.com/repos/AquiTCD/protospace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AquiTCD/protospace/labels{/name}","releases_url":"https://api.github.com/repos/AquiTCD/protospace/releases{/id}","deployments_url":"https://api.github.com/repos/AquiTCD/protospace/deployments","created_at":"2016-09-13T04:10:08Z","updated_at":"2016-10-06T11:00:34Z","pushed_at":"2016-10-18T10:47:44Z","git_url":"git://github.com/AquiTCD/protospace.git","ssh_url":"git@github.com:AquiTCD/protospace.git","clone_url":"https://github.com/AquiTCD/protospace.git","svn_url":"https://github.com/AquiTCD/protospace","homepage":null,"size":674,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AquiTCD:master","ref":"master","sha":"625fdcb5a75dab0a49a45c3131084c84b40801bd","user":{"login":"AquiTCD","id":7114503,"avatar_url":"https://avatars.githubusercontent.com/u/7114503?v=3","gravatar_id":"","url":"https://api.github.com/users/AquiTCD","html_url":"https://github.com/AquiTCD","followers_url":"https://api.github.com/users/AquiTCD/followers","following_url":"https://api.github.com/users/AquiTCD/following{/other_user}","gists_url":"https://api.github.com/users/AquiTCD/gists{/gist_id}","starred_url":"https://api.github.com/users/AquiTCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquiTCD/subscriptions","organizations_url":"https://api.github.com/users/AquiTCD/orgs","repos_url":"https://api.github.com/users/AquiTCD/repos","events_url":"https://api.github.com/users/AquiTCD/events{/privacy}","received_events_url":"https://api.github.com/users/AquiTCD/received_events","type":"User","site_admin":false},"repo":{"id":68073318,"name":"protospace","full_name":"AquiTCD/protospace","owner":{"login":"AquiTCD","id":7114503,"avatar_url":"https://avatars.githubusercontent.com/u/7114503?v=3","gravatar_id":"","url":"https://api.github.com/users/AquiTCD","html_url":"https://github.com/AquiTCD","followers_url":"https://api.github.com/users/AquiTCD/followers","following_url":"https://api.github.com/users/AquiTCD/following{/other_user}","gists_url":"https://api.github.com/users/AquiTCD/gists{/gist_id}","starred_url":"https://api.github.com/users/AquiTCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquiTCD/subscriptions","organizations_url":"https://api.github.com/users/AquiTCD/orgs","repos_url":"https://api.github.com/users/AquiTCD/repos","events_url":"https://api.github.com/users/AquiTCD/events{/privacy}","received_events_url":"https://api.github.com/users/AquiTCD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AquiTCD/protospace","description":"a web application from tech-camp carriculum","fork":false,"url":"https://api.github.com/repos/AquiTCD/protospace","forks_url":"https://api.github.com/repos/AquiTCD/protospace/forks","keys_url":"https://api.github.com/repos/AquiTCD/protospace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AquiTCD/protospace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AquiTCD/protospace/teams","hooks_url":"https://api.github.com/repos/AquiTCD/protospace/hooks","issue_events_url":"https://api.github.com/repos/AquiTCD/protospace/issues/events{/number}","events_url":"https://api.github.com/repos/AquiTCD/protospace/events","assignees_url":"https://api.github.com/repos/AquiTCD/protospace/assignees{/user}","branches_url":"https://api.github.com/repos/AquiTCD/protospace/branches{/branch}","tags_url":"https://api.github.com/repos/AquiTCD/protospace/tags","blobs_url":"https://api.github.com/repos/AquiTCD/protospace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AquiTCD/protospace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AquiTCD/protospace/git/refs{/sha}","trees_url":"https://api.github.com/repos/AquiTCD/protospace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AquiTCD/protospace/statuses/{sha}","languages_url":"https://api.github.com/repos/AquiTCD/protospace/languages","stargazers_url":"https://api.github.com/repos/AquiTCD/protospace/stargazers","contributors_url":"https://api.github.com/repos/AquiTCD/protospace/contributors","subscribers_url":"https://api.github.com/repos/AquiTCD/protospace/subscribers","subscription_url":"https://api.github.com/repos/AquiTCD/protospace/subscription","commits_url":"https://api.github.com/repos/AquiTCD/protospace/commits{/sha}","git_commits_url":"https://api.github.com/repos/AquiTCD/protospace/git/commits{/sha}","comments_url":"https://api.github.com/repos/AquiTCD/protospace/comments{/number}","issue_comment_url":"https://api.github.com/repos/AquiTCD/protospace/issues/comments{/number}","contents_url":"https://api.github.com/repos/AquiTCD/protospace/contents/{+path}","compare_url":"https://api.github.com/repos/AquiTCD/protospace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AquiTCD/protospace/merges","archive_url":"https://api.github.com/repos/AquiTCD/protospace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AquiTCD/protospace/downloads","issues_url":"https://api.github.com/repos/AquiTCD/protospace/issues{/number}","pulls_url":"https://api.github.com/repos/AquiTCD/protospace/pulls{/number}","milestones_url":"https://api.github.com/repos/AquiTCD/protospace/milestones{/number}","notifications_url":"https://api.github.com/repos/AquiTCD/protospace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AquiTCD/protospace/labels{/name}","releases_url":"https://api.github.com/repos/AquiTCD/protospace/releases{/id}","deployments_url":"https://api.github.com/repos/AquiTCD/protospace/deployments","created_at":"2016-09-13T04:10:08Z","updated_at":"2016-10-06T11:00:34Z","pushed_at":"2016-10-18T10:47:44Z","git_url":"git://github.com/AquiTCD/protospace.git","ssh_url":"git@github.com:AquiTCD/protospace.git","clone_url":"https://github.com/AquiTCD/protospace.git","svn_url":"https://github.com/AquiTCD/protospace","homepage":null,"size":674,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/23"},"html":{"href":"https://github.com/AquiTCD/protospace/pull/23"},"issue":{"href":"https://api.github.com/repos/AquiTCD/protospace/issues/23"},"comments":{"href":"https://api.github.com/repos/AquiTCD/protospace/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AquiTCD/protospace/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/AquiTCD/protospace/statuses/7b38d307f9763aae54fe69ef1871f3eae42751be"}}}}
{"actor":{"display_login":"hand12"}}