{"action":"created","issue":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1744","repository_url":"https://api.github.com/repos/paparazzi/paparazzi","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1744/labels{/name}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1744/comments","events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1744/events","html_url":"https://github.com/paparazzi/paparazzi/pull/1744","id":161018066,"number":1744,"title":"[rpm sensor] compiler error feedback","user":{"login":"bartslinger","id":8672355,"avatar_url":"https://avatars.githubusercontent.com/u/8672355?v=3","gravatar_id":"","url":"https://api.github.com/users/bartslinger","html_url":"https://github.com/bartslinger","followers_url":"https://api.github.com/users/bartslinger/followers","following_url":"https://api.github.com/users/bartslinger/following{/other_user}","gists_url":"https://api.github.com/users/bartslinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bartslinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartslinger/subscriptions","organizations_url":"https://api.github.com/users/bartslinger/orgs","repos_url":"https://api.github.com/users/bartslinger/repos","events_url":"https://api.github.com/users/bartslinger/events{/privacy}","received_events_url":"https://api.github.com/users/bartslinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-18T10:35:34Z","updated_at":"2016-06-18T21:01:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1744","html_url":"https://github.com/paparazzi/paparazzi/pull/1744","diff_url":"https://github.com/paparazzi/paparazzi/pull/1744.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1744.patch"},"body":"Make it slightly more user-friendly. This thing does not work without pwm_meas."},"comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments/226964590","html_url":"https://github.com/paparazzi/paparazzi/pull/1744#issuecomment-226964590","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1744","id":226964590,"user":{"login":"bartslinger","id":8672355,"avatar_url":"https://avatars.githubusercontent.com/u/8672355?v=3","gravatar_id":"","url":"https://api.github.com/users/bartslinger","html_url":"https://github.com/bartslinger","followers_url":"https://api.github.com/users/bartslinger/followers","following_url":"https://api.github.com/users/bartslinger/following{/other_user}","gists_url":"https://api.github.com/users/bartslinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bartslinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartslinger/subscriptions","organizations_url":"https://api.github.com/users/bartslinger/orgs","repos_url":"https://api.github.com/users/bartslinger/repos","events_url":"https://api.github.com/users/bartslinger/events{/privacy}","received_events_url":"https://api.github.com/users/bartslinger/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T21:01:03Z","updated_at":"2016-06-18T21:01:03Z","body":"Ok I see what you mean, there is this `<depends>` section in the xml. What does this do exactly? I find the following compile error not very descriptive, that's why I suggested this addition.\r\n\r\n```\r\nmodules/sensors/rpm_sensor.c: In function 'rpm_sensor_get_rpm':\r\nmodules/sensors/rpm_sensor.c:56:3: warning: implicit declaration of function 'get_pwm_input_period_in_usec' [-Wimplicit-function-declaration]\r\n   uint32_t period_us = get_pwm_input_period_in_usec(RPM_PWM_CHANNEL) * RPM_PULSE_PER_RND;\r\n   ^\r\nmodules/sensors/rpm_sensor.c:56:3: warning: nested extern declaration of 'get_pwm_input_period_in_usec' [-Wnested-externs]\r\n<command-line>:0:17: error: 'PWM_INPUT1' undeclared (first use in this function)\r\nmodules/sensors/rpm_sensor.c:56:53: note: in expansion of macro 'RPM_PWM_CHANNEL'\r\n   uint32_t period_us = get_pwm_input_period_in_usec(RPM_PWM_CHANNEL) * RPM_PULSE_PER_RND;\r\n                                                     ^\r\n<command-line>:0:17: note: each undeclared identifier is reported only once for each function it appears in\r\nmodules/sensors/rpm_sensor.c:56:53: note: in expansion of macro 'RPM_PWM_CHANNEL'\r\n   uint32_t period_us = get_pwm_input_period_in_usec(RPM_PWM_CHANNEL) * RPM_PULSE_PER_RND;\r\n                                                     ^\r\nCC /home/bart/paparazzi/var/aircrafts/Helisa/ap/peripherals/sdcard_spi.o\r\nmake[1]: *** [/home/bart/paparazzi/var/aircrafts/Helisa/ap/modules/sensors/rpm_sensor.o] Error 1\r\nmake[1]: *** Waiting for unfinished jobs....\r\nmake[1]: Leaving directory `/home/bart/paparazzi/sw/airborne'\r\nmake: *** [ap.compile] Error 2\r\nmake: Leaving directory `/home/bart/paparazzi'\r\n```"}}
{"actor":{"display_login":"bartslinger"}}