{"action":"created","issue":{"url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/2","repository_url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles","labels_url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/2/comments","events_url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/2/events","html_url":"https://github.com/aqueduct/Aqueduct.Toggles/issues/2","id":160430390,"number":2,"title":"Error when rendering is missing","user":{"login":"drachele","id":825135,"avatar_url":"https://avatars.githubusercontent.com/u/825135?v=3","gravatar_id":"","url":"https://api.github.com/users/drachele","html_url":"https://github.com/drachele","followers_url":"https://api.github.com/users/drachele/followers","following_url":"https://api.github.com/users/drachele/following{/other_user}","gists_url":"https://api.github.com/users/drachele/gists{/gist_id}","starred_url":"https://api.github.com/users/drachele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drachele/subscriptions","organizations_url":"https://api.github.com/users/drachele/orgs","repos_url":"https://api.github.com/users/drachele/repos","events_url":"https://api.github.com/users/drachele/events{/privacy}","received_events_url":"https://api.github.com/users/drachele/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-15T14:04:18Z","updated_at":"2016-09-12T16:50:00Z","closed_at":null,"body":"An error is thrown by the **ProcessXmlBasedLayoutDefinition** pipeline if a rendering is missing.\r\n\r\nStack trace as follows:\r\n\r\n[NullReferenceException: Object reference not set to an instance of an object.]\r\n   Aqueduct.Toggles.Sitecore.ProcessXmlBasedLayoutDefinition.ProcessRenderings(List`1 renderings, RenderingReplacement replacement, RenderingBuilder renderingBuilder) +99\r\n   Aqueduct.Toggles.Sitecore.ProcessXmlBasedLayoutDefinition.Process(BuildPageDefinitionArgs args) +758\r\n   (Object , Object[] ) +73\r\n   Sitecore.Pipelines.CorePipeline.Run(PipelineArgs args) +326\r\n   Sitecore.Mvc.Pipelines.PipelineService.RunPipeline(String pipelineName, TArgs args) +164\r\n.....\r\n\r\nHandle gracefully if the rendering is missing, rather than throwing an exception?\r\n\r\nLog a warning that a rendering couldn't be found?"},"comment":{"url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/comments/246411729","html_url":"https://github.com/aqueduct/Aqueduct.Toggles/issues/2#issuecomment-246411729","issue_url":"https://api.github.com/repos/aqueduct/Aqueduct.Toggles/issues/2","id":246411729,"user":{"login":"neilduncan","id":652579,"avatar_url":"https://avatars.githubusercontent.com/u/652579?v=3","gravatar_id":"","url":"https://api.github.com/users/neilduncan","html_url":"https://github.com/neilduncan","followers_url":"https://api.github.com/users/neilduncan/followers","following_url":"https://api.github.com/users/neilduncan/following{/other_user}","gists_url":"https://api.github.com/users/neilduncan/gists{/gist_id}","starred_url":"https://api.github.com/users/neilduncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilduncan/subscriptions","organizations_url":"https://api.github.com/users/neilduncan/orgs","repos_url":"https://api.github.com/users/neilduncan/repos","events_url":"https://api.github.com/users/neilduncan/events{/privacy}","received_events_url":"https://api.github.com/users/neilduncan/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T16:50:00Z","updated_at":"2016-09-12T16:50:00Z","body":"> Dan - \"Doctor, It hurts when I smack myself in the face!\"\r\n> Doctor Neil - \"Have you tried not smacking yourself in the face?\"\r\n\r\nAnyway... I'm working on this one. \r\n\r\nI added the relevant null check, but for some reason, it's causing Sitecore to drop into my 404 resolver rather than falling back to the old Layout. \r\n\r\nI'll try and investigate more tomorrow. "}}
{"actor":{"display_login":"neilduncan"}}