{"action":"closed","number":9167,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167","id":68496642,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9167","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9167.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9167.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9167","number":9167,"state":"closed","locked":false,"title":"Jasmine: Document `Env.throwOnExpectationFailure`","user":{"login":"swissspidy","id":841956,"avatar_url":"https://avatars.githubusercontent.com/u/841956?v=3","gravatar_id":"","url":"https://api.github.com/users/swissspidy","html_url":"https://github.com/swissspidy","followers_url":"https://api.github.com/users/swissspidy/followers","following_url":"https://api.github.com/users/swissspidy/following{/other_user}","gists_url":"https://api.github.com/users/swissspidy/gists{/gist_id}","starred_url":"https://api.github.com/users/swissspidy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swissspidy/subscriptions","organizations_url":"https://api.github.com/users/swissspidy/orgs","repos_url":"https://api.github.com/users/swissspidy/repos","events_url":"https://api.github.com/users/swissspidy/events{/privacy}","received_events_url":"https://api.github.com/users/swissspidy/received_events","type":"User","site_admin":false},"body":"The definitions for the `Env` interface in Jasmine are quite incomplete. `throwOnExpectationFailure` stood out immediately.\r\n\r\nSee current source code: https://github.com/jasmine/jasmine/blob/v2.4.1/src/core/Env.js\r\n\r\nOnce I identify all missing methods I'll create a new PR for adding them, but for now I just need `throwOnExpectationFailure` in my own code and would love to see it being added to the definitions list.\r\n","created_at":"2016-05-01T14:00:33Z","updated_at":"2016-06-21T22:42:55Z","closed_at":"2016-06-21T22:42:55Z","merged_at":"2016-06-21T22:42:55Z","merge_commit_sha":"c49913aa9ea419ea46c1c684e488cf2a10303b1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9167/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/fbe96b9a971ede4e42aab0a839ca533f6ffd7b12","head":{"label":"swissspidy:patch-1","ref":"patch-1","sha":"fbe96b9a971ede4e42aab0a839ca533f6ffd7b12","user":{"login":"swissspidy","id":841956,"avatar_url":"https://avatars.githubusercontent.com/u/841956?v=3","gravatar_id":"","url":"https://api.github.com/users/swissspidy","html_url":"https://github.com/swissspidy","followers_url":"https://api.github.com/users/swissspidy/followers","following_url":"https://api.github.com/users/swissspidy/following{/other_user}","gists_url":"https://api.github.com/users/swissspidy/gists{/gist_id}","starred_url":"https://api.github.com/users/swissspidy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swissspidy/subscriptions","organizations_url":"https://api.github.com/users/swissspidy/orgs","repos_url":"https://api.github.com/users/swissspidy/repos","events_url":"https://api.github.com/users/swissspidy/events{/privacy}","received_events_url":"https://api.github.com/users/swissspidy/received_events","type":"User","site_admin":false},"repo":{"id":57054536,"name":"DefinitelyTyped","full_name":"swissspidy/DefinitelyTyped","owner":{"login":"swissspidy","id":841956,"avatar_url":"https://avatars.githubusercontent.com/u/841956?v=3","gravatar_id":"","url":"https://api.github.com/users/swissspidy","html_url":"https://github.com/swissspidy","followers_url":"https://api.github.com/users/swissspidy/followers","following_url":"https://api.github.com/users/swissspidy/following{/other_user}","gists_url":"https://api.github.com/users/swissspidy/gists{/gist_id}","starred_url":"https://api.github.com/users/swissspidy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swissspidy/subscriptions","organizations_url":"https://api.github.com/users/swissspidy/orgs","repos_url":"https://api.github.com/users/swissspidy/repos","events_url":"https://api.github.com/users/swissspidy/events{/privacy}","received_events_url":"https://api.github.com/users/swissspidy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swissspidy/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/swissspidy/DefinitelyTyped","forks_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/swissspidy/DefinitelyTyped/deployments","created_at":"2016-04-25T15:43:44Z","updated_at":"2016-04-25T15:43:51Z","pushed_at":"2016-05-05T20:41:45Z","git_url":"git://github.com/swissspidy/DefinitelyTyped.git","ssh_url":"git@github.com:swissspidy/DefinitelyTyped.git","clone_url":"https://github.com/swissspidy/DefinitelyTyped.git","svn_url":"https://github.com/swissspidy/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":101433,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"58f922ff73c04d28af44b56a02b6adc899c7598e","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-06-21T22:30:45Z","pushed_at":"2016-06-21T22:42:55Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":146576,"stargazers_count":7409,"watchers_count":7409,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5451,"mirror_url":null,"open_issues_count":1224,"forks":5451,"open_issues":1224,"watchers":7409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9167"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9167"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9167/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9167/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/fbe96b9a971ede4e42aab0a839ca533f6ffd7b12"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars.githubusercontent.com/u/8000722?v=3","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"mhegazy"}}