{"action":"created","issue":{"url":"https://api.github.com/repos/bmcfee/muda/issues/40","repository_url":"https://api.github.com/repos/bmcfee/muda","labels_url":"https://api.github.com/repos/bmcfee/muda/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/bmcfee/muda/issues/40/comments","events_url":"https://api.github.com/repos/bmcfee/muda/issues/40/events","html_url":"https://github.com/bmcfee/muda/pull/40","id":188022860,"number":40,"title":"Fixed background state","user":{"login":"mcartwright","id":1934349,"avatar_url":"https://avatars.githubusercontent.com/u/1934349?v=3","gravatar_id":"","url":"https://api.github.com/users/mcartwright","html_url":"https://github.com/mcartwright","followers_url":"https://api.github.com/users/mcartwright/followers","following_url":"https://api.github.com/users/mcartwright/following{/other_user}","gists_url":"https://api.github.com/users/mcartwright/gists{/gist_id}","starred_url":"https://api.github.com/users/mcartwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcartwright/subscriptions","organizations_url":"https://api.github.com/users/mcartwright/orgs","repos_url":"https://api.github.com/users/mcartwright/repos","events_url":"https://api.github.com/users/mcartwright/events{/privacy}","received_events_url":"https://api.github.com/users/mcartwright/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-08T15:33:02Z","updated_at":"2016-11-08T16:22:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bmcfee/muda/pulls/40","html_url":"https://github.com/bmcfee/muda/pull/40","diff_url":"https://github.com/bmcfee/muda/pull/40.diff","patch_url":"https://github.com/bmcfee/muda/pull/40.patch"},"body":"Added start and stop indices of the noise source files to background state. This is in response to Issue #39\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bmcfee/muda/40)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/bmcfee/muda/issues/comments/259183545","html_url":"https://github.com/bmcfee/muda/pull/40#issuecomment-259183545","issue_url":"https://api.github.com/repos/bmcfee/muda/issues/40","id":259183545,"user":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T16:22:56Z","updated_at":"2016-11-08T16:22:56Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[a discussion](https://reviewable.io:443/reviews/bmcfee/muda/40#-KW3jqKNQd_jeuExi07S:-KW3jqKNQd_jeuExi07T:b7cwupx) (no related file):*\nLooks good so far.  Can you add a test case to verify that the state variables are correct?\n\n---\n\n*[muda/deformers/background.py, line 42 at r1](https://reviewable.io:443/reviews/bmcfee/muda/40#-KW3iu9Q2amobk2wnjTM:-KW3iu9Q2amobk2wnjTN:b-465pej) ([raw file](https://github.com/bmcfee/muda/blob/8b6b2b855d8a7f650145a57ae134d9fa1bac184c/muda/deformers/background.py#L42)):*\n> ```Python\n>     with psf.SoundFile(str(filename), mode='r') as soundf:\n> \n>         n_target = int(np.ceil(n_samples * soundf.samplerate / sr))\n> ```\n\nYou might want to explicitly `float(sr)` in the div here so that we can be sure it's doing floating division in python 2.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/bmcfee/muda/40)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bmcfee"}}