{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/73869605","id":73869605,"diff_hunk":"@@ -320,9 +320,10 @@ define([\n             ui: {\n                 tbody: 'tbody'\n             },\n+            viewComparator: 'label',\n             initialize: function() {\n                 this.collection.each(function(model) {","path":"catalog/ui/search-ui/standard/src/main/webapp/js/view/preferences/PreferencesModal.view.js","position":24,"original_position":24,"commit_id":"174c80ebec7e248809f7150d96b85665e13cfc86","original_commit_id":"174c80ebec7e248809f7150d96b85665e13cfc86","user":{"login":"stustison","id":4391679,"avatar_url":"https://avatars.githubusercontent.com/u/4391679?v=3","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},"body":"It doesn't flow the change in the model up, which is why I looped over the models.","created_at":"2016-08-08T12:54:19Z","updated_at":"2016-08-08T12:54:19Z","html_url":"https://github.com/codice/ddf/pull/1091#discussion_r73869605","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1091","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/73869605"},"html":{"href":"https://github.com/codice/ddf/pull/1091#discussion_r73869605"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1091"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1091","id":80150664,"html_url":"https://github.com/codice/ddf/pull/1091","diff_url":"https://github.com/codice/ddf/pull/1091.diff","patch_url":"https://github.com/codice/ddf/pull/1091.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1091","number":1091,"state":"open","locked":false,"title":"DDF-2307 Fix map preferences restore button","user":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nFixes regressions caused by the original DDF-2307 commit.\r\n\r\n- Fix restore button to use properties\r\n- Sort views by label instead of alpha\r\n- Fix render order to avoid model binder errors when sorting the\r\n  collection\r\n- Fix user model to not modify the original layer from properties\r\n\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@djblue \r\n@andrewkfiedler \r\n\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@pklinef\r\n@stustison\r\n\r\n#### How should this be tested?\r\nUse the restore defaults button in the Standard UI map preferences.\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets?\r\nhttps://codice.atlassian.net/browse/DDF-2307\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### Checklist:\r\n- [ n/a ] Documentation Updated\r\n- [ n/a ] Update / Add Unit Tests\r\n- [ n/a ] Update / Add Integration Tests\r\n","created_at":"2016-08-04T21:12:38Z","updated_at":"2016-08-08T12:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9271c6f76015e19b1a658cb4fbe0b92db052117","assignee":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"assignees":[{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},{"login":"stustison","id":4391679,"avatar_url":"https://avatars.githubusercontent.com/u/4391679?v=3","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/codice/ddf/milestones/2","html_url":"https://github.com/codice/ddf/milestones/2.9.2","labels_url":"https://api.github.com/repos/codice/ddf/milestones/2/labels","id":1866261,"number":2,"title":"2.9.2","description":"Bug fixes since 2.9.1","creator":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":29,"state":"open","created_at":"2016-07-05T22:33:27Z","updated_at":"2016-08-05T20:19:37Z","due_on":"2016-08-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1091/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1091/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1091/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/174c80ebec7e248809f7150d96b85665e13cfc86","head":{"label":"pklinef:ddf-2307-map-preference-regression-fix","ref":"ddf-2307-map-preference-regression-fix","sha":"174c80ebec7e248809f7150d96b85665e13cfc86","user":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"repo":{"id":25168751,"name":"ddf","full_name":"pklinef/ddf","owner":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pklinef/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/pklinef/ddf","forks_url":"https://api.github.com/repos/pklinef/ddf/forks","keys_url":"https://api.github.com/repos/pklinef/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pklinef/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pklinef/ddf/teams","hooks_url":"https://api.github.com/repos/pklinef/ddf/hooks","issue_events_url":"https://api.github.com/repos/pklinef/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/pklinef/ddf/events","assignees_url":"https://api.github.com/repos/pklinef/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/pklinef/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/pklinef/ddf/tags","blobs_url":"https://api.github.com/repos/pklinef/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pklinef/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pklinef/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/pklinef/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pklinef/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/pklinef/ddf/languages","stargazers_url":"https://api.github.com/repos/pklinef/ddf/stargazers","contributors_url":"https://api.github.com/repos/pklinef/ddf/contributors","subscribers_url":"https://api.github.com/repos/pklinef/ddf/subscribers","subscription_url":"https://api.github.com/repos/pklinef/ddf/subscription","commits_url":"https://api.github.com/repos/pklinef/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/pklinef/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/pklinef/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/pklinef/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/pklinef/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/pklinef/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pklinef/ddf/merges","archive_url":"https://api.github.com/repos/pklinef/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pklinef/ddf/downloads","issues_url":"https://api.github.com/repos/pklinef/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/pklinef/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/pklinef/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/pklinef/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pklinef/ddf/labels{/name}","releases_url":"https://api.github.com/repos/pklinef/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/pklinef/ddf/deployments","created_at":"2014-10-13T17:07:54Z","updated_at":"2015-08-07T01:47:44Z","pushed_at":"2016-08-05T15:48:01Z","git_url":"git://github.com/pklinef/ddf.git","ssh_url":"git@github.com:pklinef/ddf.git","clone_url":"https://github.com/pklinef/ddf.git","svn_url":"https://github.com/pklinef/ddf","homepage":"","size":145530,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:2.9.x","ref":"2.9.x","sha":"4336bcbabda67103d504c797c9850cc05d61b226","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-08-03T16:08:03Z","pushed_at":"2016-08-05T22:05:36Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":281726,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":24,"forks":84,"open_issues":24,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1091"},"html":{"href":"https://github.com/codice/ddf/pull/1091"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1091"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1091/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1091/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1091/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/174c80ebec7e248809f7150d96b85665e13cfc86"}}}}
{"actor":{"display_login":"stustison"}}