{"action":"created","issue":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3210","repository_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3210/labels{/name}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3210/comments","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3210/events","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/3210","id":168082480,"number":3210,"title":"Support Safari, or stop advertising that you support Safari","user":{"login":"int3h","id":567398,"avatar_url":"https://avatars.githubusercontent.com/u/567398?v=3","gravatar_id":"","url":"https://api.github.com/users/int3h","html_url":"https://github.com/int3h","followers_url":"https://api.github.com/users/int3h/followers","following_url":"https://api.github.com/users/int3h/following{/other_user}","gists_url":"https://api.github.com/users/int3h/gists{/gist_id}","starred_url":"https://api.github.com/users/int3h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int3h/subscriptions","organizations_url":"https://api.github.com/users/int3h/orgs","repos_url":"https://api.github.com/users/int3h/repos","events_url":"https://api.github.com/users/int3h/events{/privacy}","received_events_url":"https://api.github.com/users/int3h/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-28T12:23:14Z","updated_at":"2016-07-28T18:50:39Z","closed_at":"2016-07-28T16:49:51Z","body":"Safari is not actually supported by the dev team in any way. As far as I can tell, no core dev runs Safari, even for testing purposes. Further, no reference sources are consulted when making code changes to see if they are Safari compatible.\r\n\r\nAs evidence, see #3192 and #3209. The former completely broke the extension in Safari for over three months because of a blatant bug in Safari-specific code, and no developer noticed; the latter broke drag-to-zoom on images due to relying on Safari incompatible mouse event attributes.\r\n\r\n[MDN](https://developer.mozilla.org/en-US/) documents cross-platform support for nearly every web feature, and a quick glance at [`MouseEvent.buttons`](https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons), for example, shows that it is not supported in Safari. Checking this could have prevented breaking click-to-zoom in Safari.\r\n\r\nLooking at @larsjohnsen's recent commits, you'll see \"checked on Chrome, Firefox and Edge\", and no sign of Safari. (Not picking on him, but using him as an example, since he committed the Safari incompatible code in click-to-zoom.) There is no CI server or other automated testing infrastructure to catch the regression either, for devs that don't have Macs. And apparently, no other dev ever thinks to start up Safari and install RES to check if it still works by hand.\r\n\r\nIf RES supports Safari, then support Safari. If, on the other hand, Safari isn't considered during development, or even run, then stop saying RES supports Safari."},"comment":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments/235989473","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/3210#issuecomment-235989473","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3210","id":235989473,"user":{"login":"int3h","id":567398,"avatar_url":"https://avatars.githubusercontent.com/u/567398?v=3","gravatar_id":"","url":"https://api.github.com/users/int3h","html_url":"https://github.com/int3h","followers_url":"https://api.github.com/users/int3h/followers","following_url":"https://api.github.com/users/int3h/following{/other_user}","gists_url":"https://api.github.com/users/int3h/gists{/gist_id}","starred_url":"https://api.github.com/users/int3h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int3h/subscriptions","organizations_url":"https://api.github.com/users/int3h/orgs","repos_url":"https://api.github.com/users/int3h/repos","events_url":"https://api.github.com/users/int3h/events{/privacy}","received_events_url":"https://api.github.com/users/int3h/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T18:50:39Z","updated_at":"2016-07-28T18:50:39Z","body":"You're right that my wording could have been better, and I apologize for that. I don't mean to create a toxic environment by any means, and I do appreciate the work you guys do on RES.\r\n\r\nI think my frustration stems from hearing that Safari support was being worked on, and getting my hopes up that RES was always just on the verge of working in Safari again, once Apple approves it. Then I try to install and run the current code myself, and find that it has been broken for three months, on top of other bugs. The frustration comes from being led to believe it was all on Apple, but then seeing the code has a long way to go on Safari, and nobody seems to be working on it.\r\n\r\nI also sincerely didn't mean to insult anybody by saying Apple rejected the extension because of the fatal bug I fixed in the PR. My thinking was that Apple's communication is so terrible, they probably would just not say anything, rather than tell you they couldn't get it to work. Since the fatal bug had gone unnoticed for three months, and I didn't know when the last re-submission of the extension to Apple was, I (incorrectly) assumed that the broken version could have been submitted without anybody realizing it, and without Apple informing you of it.\r\n\r\nI definitely recognize the difficulties in Safari extension development. The $99 developer program requirement is really balling any way you look at it, and if you're running Windows, there's no good way to test with Safari directly. Still, if you are trying to support Safari, then some sort of solution has to be found? If not, Safari will keep breaking, to the frustration of Safari users of RES. \r\n\r\nAgain, I apologize for my tone, and I do appreciate all the hard work put into RES. I will be more respectful with my issues/PRs. Hopefully by submitting one working PR that fixed a major Safari bug, and tracking down another to the specific lines and commits, I have shown my good faith and willingness to help. I'll try to make my wording reflect that better."}}
{"actor":{"display_login":"int3h"}}