{"action":"created","comment":{"url":"https://api.github.com/repos/dodger487/dplython/pulls/comments/64912837","id":64912837,"diff_hunk":"@@ -434,13 +434,17 @@ def addColumns(df):\n @ApplyToDataframe\n def group_by(*args, **kwargs):\n   def GroupDF(df):\n-    if args and max([len(arg.todo) for arg in args]) > 1:\n-      raise ValueError(\n-        \"Expressions not allowed as positional args. Use keyword args.\")\n-    group_columns = [arg.name for arg in args]\n-    if kwargs:\n-      group_columns.extend(kwargs.keys())\n-      df = df >> mutate(**kwargs)\n+    group_columns = kwargs.keys()","path":"dplython/dplython.py","position":11,"original_position":11,"commit_id":"a8d7c6084dc8096b6cab787a033d8697d5a44140","original_commit_id":"a8d7c6084dc8096b6cab787a033d8697d5a44140","user":{"login":"dodger487","id":179794,"avatar_url":"https://avatars.githubusercontent.com/u/179794?v=3","gravatar_id":"","url":"https://api.github.com/users/dodger487","html_url":"https://github.com/dodger487","followers_url":"https://api.github.com/users/dodger487/followers","following_url":"https://api.github.com/users/dodger487/following{/other_user}","gists_url":"https://api.github.com/users/dodger487/gists{/gist_id}","starred_url":"https://api.github.com/users/dodger487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodger487/subscriptions","organizations_url":"https://api.github.com/users/dodger487/orgs","repos_url":"https://api.github.com/users/dodger487/repos","events_url":"https://api.github.com/users/dodger487/events{/privacy}","received_events_url":"https://api.github.com/users/dodger487/received_events","type":"User","site_admin":false},"body":"I think this is breaking your code in Python 3. Try\r\n`group_columns = list(kwargs.keys())`\r\ninstead","created_at":"2016-05-27T14:28:35Z","updated_at":"2016-05-27T14:28:35Z","html_url":"https://github.com/dodger487/dplython/pull/45#discussion_r64912837","pull_request_url":"https://api.github.com/repos/dodger487/dplython/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/comments/64912837"},"html":{"href":"https://github.com/dodger487/dplython/pull/45#discussion_r64912837"},"pull_request":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/dodger487/dplython/pulls/45","id":71653775,"html_url":"https://github.com/dodger487/dplython/pull/45","diff_url":"https://github.com/dodger487/dplython/pull/45.diff","patch_url":"https://github.com/dodger487/dplython/pull/45.patch","issue_url":"https://api.github.com/repos/dodger487/dplython/issues/45","number":45,"state":"open","locked":false,"title":"Allow group by args and iterables","user":{"login":"ngould","id":3130631,"avatar_url":"https://avatars.githubusercontent.com/u/3130631?v=3","gravatar_id":"","url":"https://api.github.com/users/ngould","html_url":"https://github.com/ngould","followers_url":"https://api.github.com/users/ngould/followers","following_url":"https://api.github.com/users/ngould/following{/other_user}","gists_url":"https://api.github.com/users/ngould/gists{/gist_id}","starred_url":"https://api.github.com/users/ngould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngould/subscriptions","organizations_url":"https://api.github.com/users/ngould/orgs","repos_url":"https://api.github.com/users/ngould/repos","events_url":"https://api.github.com/users/ngould/events{/privacy}","received_events_url":"https://api.github.com/users/ngould/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-27T02:56:35Z","updated_at":"2016-05-27T14:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"457597eafa884bff01397b93d1f6a5c0b439837e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dodger487/dplython/pulls/45/commits","review_comments_url":"https://api.github.com/repos/dodger487/dplython/pulls/45/comments","review_comment_url":"https://api.github.com/repos/dodger487/dplython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dodger487/dplython/issues/45/comments","statuses_url":"https://api.github.com/repos/dodger487/dplython/statuses/a8d7c6084dc8096b6cab787a033d8697d5a44140","head":{"label":"ngould:master","ref":"master","sha":"a8d7c6084dc8096b6cab787a033d8697d5a44140","user":{"login":"ngould","id":3130631,"avatar_url":"https://avatars.githubusercontent.com/u/3130631?v=3","gravatar_id":"","url":"https://api.github.com/users/ngould","html_url":"https://github.com/ngould","followers_url":"https://api.github.com/users/ngould/followers","following_url":"https://api.github.com/users/ngould/following{/other_user}","gists_url":"https://api.github.com/users/ngould/gists{/gist_id}","starred_url":"https://api.github.com/users/ngould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngould/subscriptions","organizations_url":"https://api.github.com/users/ngould/orgs","repos_url":"https://api.github.com/users/ngould/repos","events_url":"https://api.github.com/users/ngould/events{/privacy}","received_events_url":"https://api.github.com/users/ngould/received_events","type":"User","site_admin":false},"repo":{"id":54854857,"name":"dplython","full_name":"ngould/dplython","owner":{"login":"ngould","id":3130631,"avatar_url":"https://avatars.githubusercontent.com/u/3130631?v=3","gravatar_id":"","url":"https://api.github.com/users/ngould","html_url":"https://github.com/ngould","followers_url":"https://api.github.com/users/ngould/followers","following_url":"https://api.github.com/users/ngould/following{/other_user}","gists_url":"https://api.github.com/users/ngould/gists{/gist_id}","starred_url":"https://api.github.com/users/ngould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngould/subscriptions","organizations_url":"https://api.github.com/users/ngould/orgs","repos_url":"https://api.github.com/users/ngould/repos","events_url":"https://api.github.com/users/ngould/events{/privacy}","received_events_url":"https://api.github.com/users/ngould/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngould/dplython","description":"dplyr for python","fork":true,"url":"https://api.github.com/repos/ngould/dplython","forks_url":"https://api.github.com/repos/ngould/dplython/forks","keys_url":"https://api.github.com/repos/ngould/dplython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngould/dplython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngould/dplython/teams","hooks_url":"https://api.github.com/repos/ngould/dplython/hooks","issue_events_url":"https://api.github.com/repos/ngould/dplython/issues/events{/number}","events_url":"https://api.github.com/repos/ngould/dplython/events","assignees_url":"https://api.github.com/repos/ngould/dplython/assignees{/user}","branches_url":"https://api.github.com/repos/ngould/dplython/branches{/branch}","tags_url":"https://api.github.com/repos/ngould/dplython/tags","blobs_url":"https://api.github.com/repos/ngould/dplython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngould/dplython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngould/dplython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngould/dplython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngould/dplython/statuses/{sha}","languages_url":"https://api.github.com/repos/ngould/dplython/languages","stargazers_url":"https://api.github.com/repos/ngould/dplython/stargazers","contributors_url":"https://api.github.com/repos/ngould/dplython/contributors","subscribers_url":"https://api.github.com/repos/ngould/dplython/subscribers","subscription_url":"https://api.github.com/repos/ngould/dplython/subscription","commits_url":"https://api.github.com/repos/ngould/dplython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngould/dplython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngould/dplython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngould/dplython/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngould/dplython/contents/{+path}","compare_url":"https://api.github.com/repos/ngould/dplython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngould/dplython/merges","archive_url":"https://api.github.com/repos/ngould/dplython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngould/dplython/downloads","issues_url":"https://api.github.com/repos/ngould/dplython/issues{/number}","pulls_url":"https://api.github.com/repos/ngould/dplython/pulls{/number}","milestones_url":"https://api.github.com/repos/ngould/dplython/milestones{/number}","notifications_url":"https://api.github.com/repos/ngould/dplython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngould/dplython/labels{/name}","releases_url":"https://api.github.com/repos/ngould/dplython/releases{/id}","deployments_url":"https://api.github.com/repos/ngould/dplython/deployments","created_at":"2016-03-28T00:39:14Z","updated_at":"2016-03-28T00:39:16Z","pushed_at":"2016-05-27T02:55:36Z","git_url":"git://github.com/ngould/dplython.git","ssh_url":"git@github.com:ngould/dplython.git","clone_url":"https://github.com/ngould/dplython.git","svn_url":"https://github.com/ngould/dplython","homepage":null,"size":989,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dodger487:master","ref":"master","sha":"0cbf4abf95e49e14e04f79381ecc77a50bc2b275","user":{"login":"dodger487","id":179794,"avatar_url":"https://avatars.githubusercontent.com/u/179794?v=3","gravatar_id":"","url":"https://api.github.com/users/dodger487","html_url":"https://github.com/dodger487","followers_url":"https://api.github.com/users/dodger487/followers","following_url":"https://api.github.com/users/dodger487/following{/other_user}","gists_url":"https://api.github.com/users/dodger487/gists{/gist_id}","starred_url":"https://api.github.com/users/dodger487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodger487/subscriptions","organizations_url":"https://api.github.com/users/dodger487/orgs","repos_url":"https://api.github.com/users/dodger487/repos","events_url":"https://api.github.com/users/dodger487/events{/privacy}","received_events_url":"https://api.github.com/users/dodger487/received_events","type":"User","site_admin":false},"repo":{"id":52316552,"name":"dplython","full_name":"dodger487/dplython","owner":{"login":"dodger487","id":179794,"avatar_url":"https://avatars.githubusercontent.com/u/179794?v=3","gravatar_id":"","url":"https://api.github.com/users/dodger487","html_url":"https://github.com/dodger487","followers_url":"https://api.github.com/users/dodger487/followers","following_url":"https://api.github.com/users/dodger487/following{/other_user}","gists_url":"https://api.github.com/users/dodger487/gists{/gist_id}","starred_url":"https://api.github.com/users/dodger487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodger487/subscriptions","organizations_url":"https://api.github.com/users/dodger487/orgs","repos_url":"https://api.github.com/users/dodger487/repos","events_url":"https://api.github.com/users/dodger487/events{/privacy}","received_events_url":"https://api.github.com/users/dodger487/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dodger487/dplython","description":"dplyr for python","fork":false,"url":"https://api.github.com/repos/dodger487/dplython","forks_url":"https://api.github.com/repos/dodger487/dplython/forks","keys_url":"https://api.github.com/repos/dodger487/dplython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dodger487/dplython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dodger487/dplython/teams","hooks_url":"https://api.github.com/repos/dodger487/dplython/hooks","issue_events_url":"https://api.github.com/repos/dodger487/dplython/issues/events{/number}","events_url":"https://api.github.com/repos/dodger487/dplython/events","assignees_url":"https://api.github.com/repos/dodger487/dplython/assignees{/user}","branches_url":"https://api.github.com/repos/dodger487/dplython/branches{/branch}","tags_url":"https://api.github.com/repos/dodger487/dplython/tags","blobs_url":"https://api.github.com/repos/dodger487/dplython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dodger487/dplython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dodger487/dplython/git/refs{/sha}","trees_url":"https://api.github.com/repos/dodger487/dplython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dodger487/dplython/statuses/{sha}","languages_url":"https://api.github.com/repos/dodger487/dplython/languages","stargazers_url":"https://api.github.com/repos/dodger487/dplython/stargazers","contributors_url":"https://api.github.com/repos/dodger487/dplython/contributors","subscribers_url":"https://api.github.com/repos/dodger487/dplython/subscribers","subscription_url":"https://api.github.com/repos/dodger487/dplython/subscription","commits_url":"https://api.github.com/repos/dodger487/dplython/commits{/sha}","git_commits_url":"https://api.github.com/repos/dodger487/dplython/git/commits{/sha}","comments_url":"https://api.github.com/repos/dodger487/dplython/comments{/number}","issue_comment_url":"https://api.github.com/repos/dodger487/dplython/issues/comments{/number}","contents_url":"https://api.github.com/repos/dodger487/dplython/contents/{+path}","compare_url":"https://api.github.com/repos/dodger487/dplython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dodger487/dplython/merges","archive_url":"https://api.github.com/repos/dodger487/dplython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dodger487/dplython/downloads","issues_url":"https://api.github.com/repos/dodger487/dplython/issues{/number}","pulls_url":"https://api.github.com/repos/dodger487/dplython/pulls{/number}","milestones_url":"https://api.github.com/repos/dodger487/dplython/milestones{/number}","notifications_url":"https://api.github.com/repos/dodger487/dplython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dodger487/dplython/labels{/name}","releases_url":"https://api.github.com/repos/dodger487/dplython/releases{/id}","deployments_url":"https://api.github.com/repos/dodger487/dplython/deployments","created_at":"2016-02-23T00:21:58Z","updated_at":"2016-05-25T22:10:25Z","pushed_at":"2016-05-27T14:24:42Z","git_url":"git://github.com/dodger487/dplython.git","ssh_url":"git@github.com:dodger487/dplython.git","clone_url":"https://github.com/dodger487/dplython.git","svn_url":"https://github.com/dodger487/dplython","homepage":null,"size":1043,"stargazers_count":433,"watchers_count":433,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":11,"forks":28,"open_issues":11,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/45"},"html":{"href":"https://github.com/dodger487/dplython/pull/45"},"issue":{"href":"https://api.github.com/repos/dodger487/dplython/issues/45"},"comments":{"href":"https://api.github.com/repos/dodger487/dplython/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dodger487/dplython/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/dodger487/dplython/statuses/a8d7c6084dc8096b6cab787a033d8697d5a44140"}}}}
{"actor":{"display_login":"dodger487"}}