{"action":"created","issue":{"url":"https://api.github.com/repos/Theano/Theano/issues/4587","repository_url":"https://api.github.com/repos/Theano/Theano","labels_url":"https://api.github.com/repos/Theano/Theano/issues/4587/labels{/name}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4587/comments","events_url":"https://api.github.com/repos/Theano/Theano/issues/4587/events","html_url":"https://github.com/Theano/Theano/pull/4587","id":158571320,"number":4587,"title":"Implementation of 2D dilated convolution/correlation.","user":{"login":"niasla","id":2981820,"avatar_url":"https://avatars.githubusercontent.com/u/2981820?v=3","gravatar_id":"","url":"https://api.github.com/users/niasla","html_url":"https://github.com/niasla","followers_url":"https://api.github.com/users/niasla/followers","following_url":"https://api.github.com/users/niasla/following{/other_user}","gists_url":"https://api.github.com/users/niasla/gists{/gist_id}","starred_url":"https://api.github.com/users/niasla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niasla/subscriptions","organizations_url":"https://api.github.com/users/niasla/orgs","repos_url":"https://api.github.com/users/niasla/repos","events_url":"https://api.github.com/users/niasla/events{/privacy}","received_events_url":"https://api.github.com/users/niasla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-06-05T19:58:04Z","updated_at":"2016-06-15T01:11:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4587","html_url":"https://github.com/Theano/Theano/pull/4587","diff_url":"https://github.com/Theano/Theano/pull/4587.diff","patch_url":"https://github.com/Theano/Theano/pull/4587.patch"},"body":"Comments:\r\n- For some reason when tensor.nnet.conv2d is called then convop is implemented with the debug slow version in abstract_conv.py. Modified already opt.py (both cpu and gpu versions) and dnn.py (both gpuarray and cuda). The idea is that whenever tensor.nnet.conv2d is called we need to check wether there is dilation and if there is the call conv_gemm implementation. \r\n- Following the previous point, the TestDnnConv2d in test_sandbox/cuda/tests/abstractconv.py fails. The reason is the use of cuDNN implementation of dilated architectures in tests (should we skip them or adapt with the abstract iface?)\r\n"},"comment":{"url":"https://api.github.com/repos/Theano/Theano/issues/comments/226062196","html_url":"https://github.com/Theano/Theano/pull/4587#issuecomment-226062196","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4587","id":226062196,"user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T01:11:26Z","updated_at":"2016-06-15T01:11:26Z","body":"I think this should cover all optimizations indeed."}}
{"actor":{"display_login":"lamblin"}}