{"action":"created","issue":{"url":"https://api.github.com/repos/steveklabnik/request_store/issues/52","repository_url":"https://api.github.com/repos/steveklabnik/request_store","labels_url":"https://api.github.com/repos/steveklabnik/request_store/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/steveklabnik/request_store/issues/52/comments","events_url":"https://api.github.com/repos/steveklabnik/request_store/issues/52/events","html_url":"https://github.com/steveklabnik/request_store/pull/52","id":159083214,"number":52,"title":"Make compatible with Rails streaming","user":{"login":"aasmith","id":12484,"avatar_url":"https://avatars.githubusercontent.com/u/12484?v=3","gravatar_id":"","url":"https://api.github.com/users/aasmith","html_url":"https://github.com/aasmith","followers_url":"https://api.github.com/users/aasmith/followers","following_url":"https://api.github.com/users/aasmith/following{/other_user}","gists_url":"https://api.github.com/users/aasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/aasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aasmith/subscriptions","organizations_url":"https://api.github.com/users/aasmith/orgs","repos_url":"https://api.github.com/users/aasmith/repos","events_url":"https://api.github.com/users/aasmith/events{/privacy}","received_events_url":"https://api.github.com/users/aasmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-08T05:37:01Z","updated_at":"2016-06-08T14:22:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/steveklabnik/request_store/pulls/52","html_url":"https://github.com/steveklabnik/request_store/pull/52","diff_url":"https://github.com/steveklabnik/request_store/pull/52.diff","patch_url":"https://github.com/steveklabnik/request_store/pull/52.patch"},"body":"When rendering a view with `render stream: true` the middleware clears the request store prematurely. This is because the request is considered complete shortly after the controller returns and not when all of the view fragments have been rendered. By wrapping the response in a `Rack::BodyProxy`, the middleware will instead clear out the request store after all of the streamed view is rendered and the body is complete.\r\n\r\nI'm not sure if this is a common enough use case to accommodate in this gem, but I thought it might be useful to have the discussion, as well as help anyone else who may be seeing this behavior."},"comment":{"url":"https://api.github.com/repos/steveklabnik/request_store/issues/comments/224604728","html_url":"https://github.com/steveklabnik/request_store/pull/52#issuecomment-224604728","issue_url":"https://api.github.com/repos/steveklabnik/request_store/issues/52","id":224604728,"user":{"login":"aasmith","id":12484,"avatar_url":"https://avatars.githubusercontent.com/u/12484?v=3","gravatar_id":"","url":"https://api.github.com/users/aasmith","html_url":"https://github.com/aasmith","followers_url":"https://api.github.com/users/aasmith/followers","following_url":"https://api.github.com/users/aasmith/following{/other_user}","gists_url":"https://api.github.com/users/aasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/aasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aasmith/subscriptions","organizations_url":"https://api.github.com/users/aasmith/orgs","repos_url":"https://api.github.com/users/aasmith/repos","events_url":"https://api.github.com/users/aasmith/events{/privacy}","received_events_url":"https://api.github.com/users/aasmith/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T14:22:10Z","updated_at":"2016-06-08T14:22:10Z","body":"Re: test failures; I didn't spot the support for 1.8, I will update the patch accordingly."}}
{"actor":{"display_login":"aasmith"}}