{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/68506529","id":68506529,"diff_hunk":"@@ -165,7 +297,10 @@ def _union(self, other):\n \n         Used within the :class:`Union` class\n         \"\"\"\n-        return None\n+        try:\n+            return self._union_simplify(other)\n+        except:","path":"sympy/sets/sets.py","position":156,"original_position":146,"commit_id":"c300981e5a26fcaeafe0859e1484200a546178a7","original_commit_id":"70201786670b8bfee847b9c05ab74f90d942b6c7","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"body":"Thanks. I will not repeat this again.","created_at":"2016-06-26T17:57:17Z","updated_at":"2016-06-26T17:57:17Z","html_url":"https://github.com/sympy/sympy/pull/11188#discussion_r68506529","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/11188","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/68506529"},"html":{"href":"https://github.com/sympy/sympy/pull/11188#discussion_r68506529"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11188"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11188","id":72408014,"html_url":"https://github.com/sympy/sympy/pull/11188","diff_url":"https://github.com/sympy/sympy/pull/11188.diff","patch_url":"https://github.com/sympy/sympy/pull/11188.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11188","number":11188,"state":"open","locked":false,"title":"simplified solution for trigonometric equations.","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"body":"######  Master Branch : \r\n\r\n```\r\nIn [ ]: solveset(cos(x) + cos(3*x) + cos(5*x), x, S.Reals)\r\nOut[ ]: \r\n⎧        π        ⎫   ⎧        3⋅π        ⎫   ⎧        4⋅π        ⎫   ⎧        2⋅π        ⎫   ⎧        5⋅π        ⎫   ⎧        π        ⎫   ⎧       \r\n⎨2⋅n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π +\r\n⎩        2        ⎭   ⎩         2         ⎭   ⎩         3         ⎭   ⎩         3         ⎭   ⎩         3         ⎭   ⎩        3        ⎭   ⎩       \r\n\r\n 7⋅π        ⎫   ⎧        5⋅π        ⎫   ⎧        11⋅π        ⎫   ⎧        π        ⎫\r\n ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ──── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─ | n ∊ ℤ⎬\r\n  6         ⎭   ⎩         6         ⎭   ⎩         6          ⎭   ⎩        6        ⎭\r\n\r\n\r\nIn [ ]:  solveset(sin(x),  x, S.Reals)\r\nOut[ ]: {2⋅n⋅π | n ∊ ℤ} ∪ {2⋅n⋅π + π | n ∊ ℤ}\r\n\r\nIn [ ]: solveset(tan(x) - 1, x, S.Reals)\r\nOut[ ]: \r\n⎧        5⋅π        ⎫   ⎧        π        ⎫\r\n⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─ | n ∊ ℤ⎬\r\n⎩         4         ⎭   ⎩        4        ⎭\r\n\r\nIn [ ]: solveset(cos(x) , x , S.Reals\r\nOut[ ]: \r\n⎧        π        ⎫   ⎧        3⋅π        ⎫\r\n⎨2⋅n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬\r\n⎩        2        ⎭   ⎩         2         ⎭\r\n\r\nIn [ ]: solveset(cos(x) + sin(x),  x, S.Reals)\r\nOut[ ]: \r\n⎧        3⋅π        ⎫   ⎧        7⋅π        ⎫\r\n⎨2⋅n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨2⋅n⋅π + ─── | n ∊ ℤ⎬\r\n⎩         4         ⎭   ⎩         4         ⎭\r\n\r\n```\r\n\r\n###### This branch : \r\n\r\n```\r\nIn [ ]: solveset(cos(x) + cos(3*x) + cos(5*x), x, S.Reals)\r\nOut[ ]: \r\n⎧      π        ⎫   ⎧      π        ⎫   ⎧      π        ⎫   ⎧      2⋅π        ⎫   ⎧      5⋅π        ⎫\r\n⎨n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨n⋅π + ─ | n ∊ ℤ⎬ ∪ ⎨n⋅π + ─── | n ∊ ℤ⎬ ∪ ⎨n⋅π + ─── | n ∊ ℤ⎬\r\n⎩      6        ⎭   ⎩      3        ⎭   ⎩      2        ⎭   ⎩       3         ⎭   ⎩       6         ⎭\r\n\r\n\r\nIn [ ]: solveset(sin(x),  x, S.Reals)\r\nOut[ ]: {n⋅π | n ∊ ℤ}\r\n\r\nIn [ ]: solveset(tan(x) - 1,  x, S.Reals)\r\nOut[ ]: \r\n⎧      π        ⎫\r\n⎨n⋅π + ─ | n ∊ ℤ⎬\r\n⎩      4        ⎭\r\n\r\n\r\nIn [ ]: solveset(cos(x),  x, S.Reals)\r\nOut[ ]: \r\n⎧      π        ⎫\r\n⎨n⋅π + ─ | n ∊ ℤ⎬\r\n⎩      2        ⎭\r\n\r\nIn [ ]: solveset(cos(x) + sin(x),  x, S.Reals)\r\nOut[ ]: \r\n⎧      π        ⎫\r\n⎨n⋅π - ─ | n ∊ ℤ⎬\r\n⎩      4        ⎭\r\n\r\n\r\n```\r\n\r\nAlso Fixes #10671, #7914, #9606, #9531, #9824\r\n\r\n- [x]  Description `_reduce_imageset method` ","created_at":"2016-06-02T20:00:44Z","updated_at":"2016-06-26T17:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a831736e8647c315f8f6f21344161d4da0680a83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/11188/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/11188/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11188/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/c300981e5a26fcaeafe0859e1484200a546178a7","head":{"label":"Shekharrajak:gsoc_trig_general","ref":"gsoc_trig_general","sha":"c300981e5a26fcaeafe0859e1484200a546178a7","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"repo":{"id":42365606,"name":"sympy","full_name":"Shekharrajak/sympy","owner":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shekharrajak/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/Shekharrajak/sympy","forks_url":"https://api.github.com/repos/Shekharrajak/sympy/forks","keys_url":"https://api.github.com/repos/Shekharrajak/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shekharrajak/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shekharrajak/sympy/teams","hooks_url":"https://api.github.com/repos/Shekharrajak/sympy/hooks","issue_events_url":"https://api.github.com/repos/Shekharrajak/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/Shekharrajak/sympy/events","assignees_url":"https://api.github.com/repos/Shekharrajak/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/Shekharrajak/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/Shekharrajak/sympy/tags","blobs_url":"https://api.github.com/repos/Shekharrajak/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shekharrajak/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shekharrajak/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shekharrajak/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shekharrajak/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shekharrajak/sympy/languages","stargazers_url":"https://api.github.com/repos/Shekharrajak/sympy/stargazers","contributors_url":"https://api.github.com/repos/Shekharrajak/sympy/contributors","subscribers_url":"https://api.github.com/repos/Shekharrajak/sympy/subscribers","subscription_url":"https://api.github.com/repos/Shekharrajak/sympy/subscription","commits_url":"https://api.github.com/repos/Shekharrajak/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shekharrajak/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shekharrajak/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shekharrajak/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shekharrajak/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/Shekharrajak/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shekharrajak/sympy/merges","archive_url":"https://api.github.com/repos/Shekharrajak/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shekharrajak/sympy/downloads","issues_url":"https://api.github.com/repos/Shekharrajak/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/Shekharrajak/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shekharrajak/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shekharrajak/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shekharrajak/sympy/labels{/name}","releases_url":"https://api.github.com/repos/Shekharrajak/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/Shekharrajak/sympy/deployments","created_at":"2015-09-12T17:09:44Z","updated_at":"2016-02-09T11:08:45Z","pushed_at":"2016-06-25T17:40:04Z","git_url":"git://github.com/Shekharrajak/sympy.git","ssh_url":"git@github.com:Shekharrajak/sympy.git","clone_url":"https://github.com/Shekharrajak/sympy.git","svn_url":"https://github.com/Shekharrajak/sympy","homepage":"http://sympy.org/","size":78360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"230b1bf3a3a67c0621a3b4a8f2a45e950f82393f","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-06-25T20:01:50Z","pushed_at":"2016-06-26T16:15:37Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":119391,"stargazers_count":2940,"watchers_count":2940,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1485,"mirror_url":null,"open_issues_count":2411,"forks":1485,"open_issues":2411,"watchers":2940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11188"},"html":{"href":"https://github.com/sympy/sympy/pull/11188"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/11188"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/11188/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11188/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11188/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/c300981e5a26fcaeafe0859e1484200a546178a7"}}}}
{"actor":{"display_login":"Shekharrajak"}}