{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/750","repository_url":"https://api.github.com/repos/edx/edx-app-android","labels_url":"https://api.github.com/repos/edx/edx-app-android/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/750/comments","events_url":"https://api.github.com/repos/edx/edx-app-android/issues/750/events","html_url":"https://github.com/edx/edx-app-android/pull/750","id":161268335,"number":750,"title":"Remove Commons IO Dependency","user":{"login":"bguertin","id":1685613,"avatar_url":"https://avatars.githubusercontent.com/u/1685613?v=3","gravatar_id":"","url":"https://api.github.com/users/bguertin","html_url":"https://github.com/bguertin","followers_url":"https://api.github.com/users/bguertin/followers","following_url":"https://api.github.com/users/bguertin/following{/other_user}","gists_url":"https://api.github.com/users/bguertin/gists{/gist_id}","starred_url":"https://api.github.com/users/bguertin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bguertin/subscriptions","organizations_url":"https://api.github.com/users/bguertin/orgs","repos_url":"https://api.github.com/users/bguertin/repos","events_url":"https://api.github.com/users/bguertin/events{/privacy}","received_events_url":"https://api.github.com/users/bguertin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-20T18:57:30Z","updated_at":"2016-06-21T13:47:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/750","html_url":"https://github.com/edx/edx-app-android/pull/750","diff_url":"https://github.com/edx/edx-app-android/pull/750.diff","patch_url":"https://github.com/edx/edx-app-android/pull/750.patch"},"body":"We are needlessly using commons IO for reading/copying input streams, something which we can already trivially accomplish with Okio, which is part of OkHttp.\r\n\r\nSo, I moved our only TWO usages of commons IO behind an interface in our project (`IOUtils`) and changed the implementation to use Okio instead.\r\n\r\nPlease review?\r\n- [ ] @1zaman \r\n- [ ] @BenjiLee "},"comment":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/comments/227444716","html_url":"https://github.com/edx/edx-app-android/pull/750#issuecomment-227444716","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/750","id":227444716,"user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T13:47:34Z","updated_at":"2016-06-21T13:47:34Z","body":":+1:\r\n\r\nBy the way, contrary to what I thought previously, the Apache Commons Lang 2.4 library that we're importing isn't a transitive dependency of Commons IO, but instead is imported as a dependency of the [Apache Velocity Engine][] library, which itself is a transitive dependency of [RoboBlender][], which is an annotation preprocessor that is used by RoboGuice. It's imported using the `provided` configuration, which should import it only for compiling the project, but it's transitive dependencies seem to be retained at runtime as well 😕\r\n\r\n[Apache Velocity Engine]: https://velocity.apache.org/engine/index.html\r\n[RoboBlender]: https://github.com/roboguice/roboguice/wiki/RoboBlender-wiki"}}
{"actor":{"display_login":"1zaman"}}