{"action":"created","issue":{"url":"https://api.github.com/repos/davisking/dlib/issues/155","repository_url":"https://api.github.com/repos/davisking/dlib","labels_url":"https://api.github.com/repos/davisking/dlib/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/davisking/dlib/issues/155/comments","events_url":"https://api.github.com/repos/davisking/dlib/issues/155/events","html_url":"https://github.com/davisking/dlib/pull/155","id":164726190,"number":155,"title":"Spport to discontiguous Numpy arrays","user":{"login":"mljli","id":7010007,"avatar_url":"https://avatars.githubusercontent.com/u/7010007?v=3","gravatar_id":"","url":"https://api.github.com/users/mljli","html_url":"https://github.com/mljli","followers_url":"https://api.github.com/users/mljli/followers","following_url":"https://api.github.com/users/mljli/following{/other_user}","gists_url":"https://api.github.com/users/mljli/gists{/gist_id}","starred_url":"https://api.github.com/users/mljli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljli/subscriptions","organizations_url":"https://api.github.com/users/mljli/orgs","repos_url":"https://api.github.com/users/mljli/repos","events_url":"https://api.github.com/users/mljli/events{/privacy}","received_events_url":"https://api.github.com/users/mljli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-10T17:48:59Z","updated_at":"2016-07-13T12:43:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davisking/dlib/pulls/155","html_url":"https://github.com/davisking/dlib/pull/155","diff_url":"https://github.com/davisking/dlib/pull/155.diff","patch_url":"https://github.com/davisking/dlib/pull/155.patch"},"body":"One problem is the function name `get_numpy_ndarray_parts` suggests that its a generic function. While I have to check for pixel type's consistency where  I assume the array to be no more than 3-D before copying the data. Otherwise, Python core dumps.  I know we could assign the pointer outside the function but that means we need to change the function prototype. So is this PR acceptable?"},"comment":{"url":"https://api.github.com/repos/davisking/dlib/issues/comments/232343379","html_url":"https://github.com/davisking/dlib/pull/155#issuecomment-232343379","issue_url":"https://api.github.com/repos/davisking/dlib/issues/155","id":232343379,"user":{"login":"mljli","id":7010007,"avatar_url":"https://avatars.githubusercontent.com/u/7010007?v=3","gravatar_id":"","url":"https://api.github.com/users/mljli","html_url":"https://github.com/mljli","followers_url":"https://api.github.com/users/mljli/followers","following_url":"https://api.github.com/users/mljli/following{/other_user}","gists_url":"https://api.github.com/users/mljli/gists{/gist_id}","starred_url":"https://api.github.com/users/mljli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljli/subscriptions","organizations_url":"https://api.github.com/users/mljli/orgs","repos_url":"https://api.github.com/users/mljli/repos","events_url":"https://api.github.com/users/mljli/events{/privacy}","received_events_url":"https://api.github.com/users/mljli/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T12:43:23Z","updated_at":"2016-07-13T12:43:23Z","body":"Sorry for not seeing your update. So what you mean is if no copying occurs, `_data` will be `pybuf.buf` and `array2d` is not used. Otherwise, `_data` points to `array2d`? In that way, `array2d` should be a member of `numpy_image` as well as `_data`. It's somewhat weird...OK, I'll code it later."}}
{"actor":{"display_login":"mljli"}}