{"action":"created","issue":{"url":"https://api.github.com/repos/xyzz/acquisition/issues/236","repository_url":"https://api.github.com/repos/xyzz/acquisition","labels_url":"https://api.github.com/repos/xyzz/acquisition/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/xyzz/acquisition/issues/236/comments","events_url":"https://api.github.com/repos/xyzz/acquisition/issues/236/events","html_url":"https://github.com/xyzz/acquisition/pull/236","id":132564536,"number":236,"title":"Update to CurrencyManager","user":{"login":"Gloorf","id":8601327,"avatar_url":"https://avatars.githubusercontent.com/u/8601327?v=3","gravatar_id":"","url":"https://api.github.com/users/Gloorf","html_url":"https://github.com/Gloorf","followers_url":"https://api.github.com/users/Gloorf/followers","following_url":"https://api.github.com/users/Gloorf/following{/other_user}","gists_url":"https://api.github.com/users/Gloorf/gists{/gist_id}","starred_url":"https://api.github.com/users/Gloorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gloorf/subscriptions","organizations_url":"https://api.github.com/users/Gloorf/orgs","repos_url":"https://api.github.com/users/Gloorf/repos","events_url":"https://api.github.com/users/Gloorf/events{/privacy}","received_events_url":"https://api.github.com/users/Gloorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-09T23:11:59Z","updated_at":"2016-02-12T10:10:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xyzz/acquisition/pulls/236","html_url":"https://github.com/xyzz/acquisition/pull/236","diff_url":"https://github.com/xyzz/acquisition/pull/236.diff","patch_url":"https://github.com/xyzz/acquisition/pull/236.patch"},"body":"* Allow user to have both of chaos / exalted value conversion (or one of them, or none if he wants to)\r\n* CurrencyItem now uses CurrencyRatio to store the chaos/exalted conversion, with one of the two currency in the ratio beeing fixed (to chaos or exalted)\r\n* Changed the way CurrencyRatios are saved in the database, now use json for serializing/deserializing.\r\n* Should be much more robust if new currencies are added\r\n* Automatically migrates old ratio to new one (yay user experience)\r\n* Slightly altered the visual aspect of the currency dialog\r\n\r\nThe main goal is to be able to easily support currency.poe.trade APi (if one is coming) since all ratio are between two currencies. It should be fairly easy to add others ratio (simply need 2 QDropDown to select the currency, and QDoubleSpinBox to select the ratio).\r\n\r\nI also tried to make the dialog not so shitty (visually speaking), but it's still pretty hard to do. We could consider moving it to a fixed tab (in the searches), the code would stay the same (except we have to inherit from QWidget instead of QDialog, but that's it)\r\n\r\nI haven't touched to the export to CSV feature for now, but clearly the way data is saved should be changed : at the moment, adding another currency and moving a header (for example, to add the total in chaos) more or less break the formatting. I was also thinking about serializing to json (since it's fairly easy to do and we already use it elsewhere)\r\n\r\n![capture d ecran de 2016-02-09 23-56-28](https://cloud.githubusercontent.com/assets/8601327/12933875/dc07b782-cf8a-11e5-8290-cb6302141ec6.png)\r\n![capture d ecran de 2016-02-09 23-56-25](https://cloud.githubusercontent.com/assets/8601327/12933877/de523a8a-cf8a-11e5-8e1e-222b1c41bb06.png)\r\n![capture d ecran de 2016-02-09 23-56-32](https://cloud.githubusercontent.com/assets/8601327/12933881/e4c9fef2-cf8a-11e5-83e0-69ebe7cb92b5.png)\r\n"},"comment":{"url":"https://api.github.com/repos/xyzz/acquisition/issues/comments/183260691","html_url":"https://github.com/xyzz/acquisition/pull/236#issuecomment-183260691","issue_url":"https://api.github.com/repos/xyzz/acquisition/issues/236","id":183260691,"user":{"login":"xyzz","id":1065521,"avatar_url":"https://avatars.githubusercontent.com/u/1065521?v=3","gravatar_id":"","url":"https://api.github.com/users/xyzz","html_url":"https://github.com/xyzz","followers_url":"https://api.github.com/users/xyzz/followers","following_url":"https://api.github.com/users/xyzz/following{/other_user}","gists_url":"https://api.github.com/users/xyzz/gists{/gist_id}","starred_url":"https://api.github.com/users/xyzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyzz/subscriptions","organizations_url":"https://api.github.com/users/xyzz/orgs","repos_url":"https://api.github.com/users/xyzz/repos","events_url":"https://api.github.com/users/xyzz/events{/privacy}","received_events_url":"https://api.github.com/users/xyzz/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T10:10:56Z","updated_at":"2016-02-12T10:10:56Z","body":"Now after clicking \"Login\" I'm getting a window \"flash\" (appear/hide multiple times?) and some warnings in the console:\r\n\r\n![untitled](https://cloud.githubusercontent.com/assets/1065521/13004033/0294de6a-d18a-11e5-8299-df2ff74e5697.png)\r\n\r\nI'm assuming this is from the currency window, could it be hidden until it's actually needed?"}}