{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/72610557","id":72610557,"diff_hunk":"@@ -195,19 +195,11 @@ class SparseBlockDom: BaseSparseDom {\n     }\n   }\n \n-  proc dsiNumIndices {\n-    var total:atomic int;\n-    coforall locDom in locDoms do on locDom {\n-      var localNum = locDom.dsiNumIndices;\n-      total.add(localNum);\n-    }\n-    return total.read();\n-  }\n-\n   //\n   // how to allocate a new array over this domain\n   //\n   proc dsiBuildArray(type eltType) {\n+    /*writeln(\"Build array called\");*/","path":"modules/dists/SparseBlockDist.chpl","position":102,"original_position":102,"commit_id":"ea1177fac2dbd07af3cf8f2ae6107c4dc244bcdc","original_commit_id":"ea1177fac2dbd07af3cf8f2ae6107c4dc244bcdc","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"Remove this debug comment?","created_at":"2016-07-28T12:17:28Z","updated_at":"2016-07-28T12:17:28Z","html_url":"https://github.com/chapel-lang/chapel/pull/4071#discussion_r72610557","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/72610557"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4071#discussion_r72610557"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071","id":75034648,"html_url":"https://github.com/chapel-lang/chapel/pull/4071","diff_url":"https://github.com/chapel-lang/chapel/pull/4071.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/4071.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4071","number":4071,"state":"open","locked":false,"title":"Refactor Sparse Domains","user":{"login":"e-kayrakli","id":4141670,"avatar_url":"https://avatars.githubusercontent.com/u/4141670?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kayrakli","html_url":"https://github.com/e-kayrakli","followers_url":"https://api.github.com/users/e-kayrakli/followers","following_url":"https://api.github.com/users/e-kayrakli/following{/other_user}","gists_url":"https://api.github.com/users/e-kayrakli/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kayrakli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kayrakli/subscriptions","organizations_url":"https://api.github.com/users/e-kayrakli/orgs","repos_url":"https://api.github.com/users/e-kayrakli/repos","events_url":"https://api.github.com/users/e-kayrakli/events{/privacy}","received_events_url":"https://api.github.com/users/e-kayrakli/received_events","type":"User","site_admin":false},"body":"Due to the lack of good generics and inheritance support in the early days; distribution, domain and array class hierarchies hasn't been used effectively.\r\n\r\nThis PR is a prototype of a refactoring that tries to move fields and methods of sparse domains to BaseSparseDom. I will try to create similar PRs on other domains/dists/arrays.\r\n\r\nSome of the higlights of changes:\r\n- Fields moved to BaseSparseDom: `rank`, `idxType`, `parentDom`, `nnz`, `nnzDom`\r\n- Methods moved to BaseSparseDom: `dsiBulkAdd` and its helpers, `boundsCheck` and one-liner simple dsi* functions. (I had opened and closed a PR that adds this in a dirtier way: #4025 ) I don't know if we really need those that deal with alignment, but they are there.\r\n- Now that we have `nnz` in all sparse domains, I changed add/remove methods to return actual number of indices added/removed. I think return value can be useful for users, too. But add/remove methods are important part of user-facing API, so this change is _very_ open to question.\r\n- += overloads of sparse domains moved from ChapelArray to ChapelDistribution to be close to BaseSparseDom.\r\n- In SparseBlockDom `whole` is replaced by `parentDom`.\r\n\r\nIssues\r\n- `super` keyword is still not implemented fully. With the help of the ability to call superclass' methods things can be moved around a bit more, to have simpler child classes.\r\n- `dist` wasn't moved due to a compiler bug, which @lydia-duncan knows a bit about, I will create a future for that shortly.\r\n- I wanted to write a BaseSparseArr class in ChapelDistribution. There are many fields/methods that can be moved to BaseSparseArr(likewise for BaseArr, of course). I got blocked by the same bug as I discussed above, but this time on a more important generic field. Lack of that renders BaseSparseArr useless for now. I tried to have a simple implementation of it, but hit another one that I couldn't reproduce in a simpler case.\r\n\r\nI have been using a subset of correctness tests that I know to be relevant. Full correctness test is underway.","created_at":"2016-06-23T21:59:48Z","updated_at":"2016-07-28T12:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd9f50538bcff0fade6238275e399ca92436b17","assignee":{"login":"mppf","id":3653132,"avatar_url":"https://avatars.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"assignees":[{"login":"mppf","id":3653132,"avatar_url":"https://avatars.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},{"login":"e-kayrakli","id":4141670,"avatar_url":"https://avatars.githubusercontent.com/u/4141670?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kayrakli","html_url":"https://github.com/e-kayrakli","followers_url":"https://api.github.com/users/e-kayrakli/followers","following_url":"https://api.github.com/users/e-kayrakli/following{/other_user}","gists_url":"https://api.github.com/users/e-kayrakli/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kayrakli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kayrakli/subscriptions","organizations_url":"https://api.github.com/users/e-kayrakli/orgs","repos_url":"https://api.github.com/users/e-kayrakli/repos","events_url":"https://api.github.com/users/e-kayrakli/events{/privacy}","received_events_url":"https://api.github.com/users/e-kayrakli/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4071/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/ea1177fac2dbd07af3cf8f2ae6107c4dc244bcdc","head":{"label":"e-kayrakli:sparse-refactor","ref":"sparse-refactor","sha":"ea1177fac2dbd07af3cf8f2ae6107c4dc244bcdc","user":{"login":"e-kayrakli","id":4141670,"avatar_url":"https://avatars.githubusercontent.com/u/4141670?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kayrakli","html_url":"https://github.com/e-kayrakli","followers_url":"https://api.github.com/users/e-kayrakli/followers","following_url":"https://api.github.com/users/e-kayrakli/following{/other_user}","gists_url":"https://api.github.com/users/e-kayrakli/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kayrakli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kayrakli/subscriptions","organizations_url":"https://api.github.com/users/e-kayrakli/orgs","repos_url":"https://api.github.com/users/e-kayrakli/repos","events_url":"https://api.github.com/users/e-kayrakli/events{/privacy}","received_events_url":"https://api.github.com/users/e-kayrakli/received_events","type":"User","site_admin":false},"repo":{"id":58942509,"name":"chapel","full_name":"e-kayrakli/chapel","owner":{"login":"e-kayrakli","id":4141670,"avatar_url":"https://avatars.githubusercontent.com/u/4141670?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kayrakli","html_url":"https://github.com/e-kayrakli","followers_url":"https://api.github.com/users/e-kayrakli/followers","following_url":"https://api.github.com/users/e-kayrakli/following{/other_user}","gists_url":"https://api.github.com/users/e-kayrakli/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kayrakli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kayrakli/subscriptions","organizations_url":"https://api.github.com/users/e-kayrakli/orgs","repos_url":"https://api.github.com/users/e-kayrakli/repos","events_url":"https://api.github.com/users/e-kayrakli/events{/privacy}","received_events_url":"https://api.github.com/users/e-kayrakli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/e-kayrakli/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/e-kayrakli/chapel","forks_url":"https://api.github.com/repos/e-kayrakli/chapel/forks","keys_url":"https://api.github.com/repos/e-kayrakli/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e-kayrakli/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e-kayrakli/chapel/teams","hooks_url":"https://api.github.com/repos/e-kayrakli/chapel/hooks","issue_events_url":"https://api.github.com/repos/e-kayrakli/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/e-kayrakli/chapel/events","assignees_url":"https://api.github.com/repos/e-kayrakli/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/e-kayrakli/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/e-kayrakli/chapel/tags","blobs_url":"https://api.github.com/repos/e-kayrakli/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e-kayrakli/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e-kayrakli/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/e-kayrakli/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e-kayrakli/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/e-kayrakli/chapel/languages","stargazers_url":"https://api.github.com/repos/e-kayrakli/chapel/stargazers","contributors_url":"https://api.github.com/repos/e-kayrakli/chapel/contributors","subscribers_url":"https://api.github.com/repos/e-kayrakli/chapel/subscribers","subscription_url":"https://api.github.com/repos/e-kayrakli/chapel/subscription","commits_url":"https://api.github.com/repos/e-kayrakli/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/e-kayrakli/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/e-kayrakli/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/e-kayrakli/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/e-kayrakli/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/e-kayrakli/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e-kayrakli/chapel/merges","archive_url":"https://api.github.com/repos/e-kayrakli/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e-kayrakli/chapel/downloads","issues_url":"https://api.github.com/repos/e-kayrakli/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/e-kayrakli/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/e-kayrakli/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/e-kayrakli/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e-kayrakli/chapel/labels{/name}","releases_url":"https://api.github.com/repos/e-kayrakli/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/e-kayrakli/chapel/deployments","created_at":"2016-05-16T15:13:42Z","updated_at":"2016-05-16T15:14:09Z","pushed_at":"2016-07-22T23:48:09Z","git_url":"git://github.com/e-kayrakli/chapel.git","ssh_url":"git@github.com:e-kayrakli/chapel.git","clone_url":"https://github.com/e-kayrakli/chapel.git","svn_url":"https://github.com/e-kayrakli/chapel","homepage":"http://chapel.cray.com/","size":366836,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"15dca72c3645f0777d8b033a1c517db15ca7e4a0","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2016-07-25T19:47:48Z","pushed_at":"2016-07-28T07:23:04Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":478788,"stargazers_count":296,"watchers_count":296,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":20,"forks":102,"open_issues":20,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4071"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4071"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4071/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4071/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/ea1177fac2dbd07af3cf8f2ae6107c4dc244bcdc"}}}}
{"actor":{"display_login":"mppf"}}