{"action":"created","issue":{"url":"https://api.github.com/repos/zmap/zgrab/issues/170","repository_url":"https://api.github.com/repos/zmap/zgrab","labels_url":"https://api.github.com/repos/zmap/zgrab/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/zmap/zgrab/issues/170/comments","events_url":"https://api.github.com/repos/zmap/zgrab/issues/170/events","html_url":"https://github.com/zmap/zgrab/pull/170","id":169018154,"number":170,"title":"Added support for reading additional Subject Alternative Name fields","user":{"login":"mhyder13","id":15119376,"avatar_url":"https://avatars.githubusercontent.com/u/15119376?v=3","gravatar_id":"","url":"https://api.github.com/users/mhyder13","html_url":"https://github.com/mhyder13","followers_url":"https://api.github.com/users/mhyder13/followers","following_url":"https://api.github.com/users/mhyder13/following{/other_user}","gists_url":"https://api.github.com/users/mhyder13/gists{/gist_id}","starred_url":"https://api.github.com/users/mhyder13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhyder13/subscriptions","organizations_url":"https://api.github.com/users/mhyder13/orgs","repos_url":"https://api.github.com/users/mhyder13/repos","events_url":"https://api.github.com/users/mhyder13/events{/privacy}","received_events_url":"https://api.github.com/users/mhyder13/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-03T00:11:30Z","updated_at":"2016-08-04T14:39:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zmap/zgrab/pulls/170","html_url":"https://github.com/zmap/zgrab/pull/170","diff_url":"https://github.com/zmap/zgrab/pull/170.diff","patch_url":"https://github.com/zmap/zgrab/pull/170.patch"},"body":"Support was added for SAN types otherName, directoryName, ediPartyName, uniformResourceIdentifier, and registeredID in certificate parsing. New structs to describe the OtherName and EDIPartyName types were added to the pkix package. Due to limitations of how encoding/asn1 parses DirectoryStrings, ediPartyName and directoryName only support parsing of names encoded with PrintableString and UTF8String. Note that this is the same limitation that applies to parsing the issuer and subject fields of the certificate.\r\n\r\nUnit test cases were added to ztools/x509 to test parseSANExtension. Further testing on the ParseCertificate function was done, but not included.\r\n\r\nEDIPartyName was verified only with an ASN.1 compiler and multiple checks of the standards since I couldn't find a program that supports it or an example or a properly encoded one. All other types are verified as correctly working with the Windows certificate viewer."},"comment":{"url":"https://api.github.com/repos/zmap/zgrab/issues/comments/237573601","html_url":"https://github.com/zmap/zgrab/pull/170#issuecomment-237573601","issue_url":"https://api.github.com/repos/zmap/zgrab/issues/170","id":237573601,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T14:39:55Z","updated_at":"2016-08-04T14:39:55Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7306465/badge)](https://coveralls.io/builds/7306465)\n\nCoverage increased (+0.008%) to 70.099% when pulling **8c61954595515ca1074b33c3eda03bfed430201f on teamnsrg:master** into **8188e7889060ab38a4977de85be8435baffcbb42 on zmap:master**.\n"}}
{"actor":{"display_login":"coveralls"}}