{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments/75756443","id":75756443,"diff_hunk":"@@ -1,37 +1,79 @@\n+// Please also update VALID_VERSION_PATTERN in forms.py\n+// Changing the bracket orders may require to update INDEXES and TYPE_INDEXES\n+// TODO: Read the pattern from a centralized file\n+var VALID_VERSION_PATTERN_STRING  = '^(\\\\d+)\\\\.(' + // Major version number","path":"kickoff/static/model/release.js","position":4,"original_position":4,"commit_id":"8c7322a54d83e3132420d699eaef484174bae591","original_commit_id":"8c7322a54d83e3132420d699eaef484174bae591","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"From @sylvestre in [this \"outdated\" comment](https://github.com/mozilla-releng/ship-it/pull/114/files/acd88ee4f32cce2c01894bda260972fcc69a8f28#r75752029):\r\n\r\n> Oh, this is duplicating code... What about creating a library for this? I am sure we would have other places to use it.\r\n\r\nI agree.  Like said [in the bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1297011#c5), I'd prefer to handle that in a follow. What do you think of it?","created_at":"2016-08-22T20:53:03Z","updated_at":"2016-08-22T20:53:03Z","html_url":"https://github.com/mozilla-releng/ship-it/pull/114#discussion_r75756443","pull_request_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments/75756443"},"html":{"href":"https://github.com/mozilla-releng/ship-it/pull/114#discussion_r75756443"},"pull_request":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114","id":82256731,"html_url":"https://github.com/mozilla-releng/ship-it/pull/114","diff_url":"https://github.com/mozilla-releng/ship-it/pull/114.diff","patch_url":"https://github.com/mozilla-releng/ship-it/pull/114.patch","issue_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/114","number":114,"state":"open","locked":false,"title":"Bug 1297011 - Invalid versions should not fetch l10n changesets","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-22T20:24:50Z","updated_at":"2016-08-22T20:53:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5183f0db9fb5a0baf8d19f71e8ad904b85db72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114/commits","review_comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114/comments","review_comment_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/114/comments","statuses_url":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/8c7322a54d83e3132420d699eaef484174bae591","head":{"label":"JohanLorenzo:bug-1297011","ref":"bug-1297011","sha":"8c7322a54d83e3132420d699eaef484174bae591","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"repo":{"id":63788367,"name":"ship-it","full_name":"JohanLorenzo/ship-it","owner":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohanLorenzo/ship-it","description":"Internal tool to manage release builds","fork":true,"url":"https://api.github.com/repos/JohanLorenzo/ship-it","forks_url":"https://api.github.com/repos/JohanLorenzo/ship-it/forks","keys_url":"https://api.github.com/repos/JohanLorenzo/ship-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohanLorenzo/ship-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohanLorenzo/ship-it/teams","hooks_url":"https://api.github.com/repos/JohanLorenzo/ship-it/hooks","issue_events_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues/events{/number}","events_url":"https://api.github.com/repos/JohanLorenzo/ship-it/events","assignees_url":"https://api.github.com/repos/JohanLorenzo/ship-it/assignees{/user}","branches_url":"https://api.github.com/repos/JohanLorenzo/ship-it/branches{/branch}","tags_url":"https://api.github.com/repos/JohanLorenzo/ship-it/tags","blobs_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohanLorenzo/ship-it/statuses/{sha}","languages_url":"https://api.github.com/repos/JohanLorenzo/ship-it/languages","stargazers_url":"https://api.github.com/repos/JohanLorenzo/ship-it/stargazers","contributors_url":"https://api.github.com/repos/JohanLorenzo/ship-it/contributors","subscribers_url":"https://api.github.com/repos/JohanLorenzo/ship-it/subscribers","subscription_url":"https://api.github.com/repos/JohanLorenzo/ship-it/subscription","commits_url":"https://api.github.com/repos/JohanLorenzo/ship-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohanLorenzo/ship-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohanLorenzo/ship-it/contents/{+path}","compare_url":"https://api.github.com/repos/JohanLorenzo/ship-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohanLorenzo/ship-it/merges","archive_url":"https://api.github.com/repos/JohanLorenzo/ship-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohanLorenzo/ship-it/downloads","issues_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues{/number}","pulls_url":"https://api.github.com/repos/JohanLorenzo/ship-it/pulls{/number}","milestones_url":"https://api.github.com/repos/JohanLorenzo/ship-it/milestones{/number}","notifications_url":"https://api.github.com/repos/JohanLorenzo/ship-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohanLorenzo/ship-it/labels{/name}","releases_url":"https://api.github.com/repos/JohanLorenzo/ship-it/releases{/id}","deployments_url":"https://api.github.com/repos/JohanLorenzo/ship-it/deployments","created_at":"2016-07-20T14:31:15Z","updated_at":"2016-07-20T14:31:16Z","pushed_at":"2016-08-22T20:50:41Z","git_url":"git://github.com/JohanLorenzo/ship-it.git","ssh_url":"git@github.com:JohanLorenzo/ship-it.git","clone_url":"https://github.com/JohanLorenzo/ship-it.git","svn_url":"https://github.com/JohanLorenzo/ship-it","homepage":null,"size":2943,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-releng:master","ref":"master","sha":"f0288cc69e58968bdda13c84a8698f2b0cda048f","user":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"repo":{"id":31218912,"name":"ship-it","full_name":"mozilla-releng/ship-it","owner":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-releng/ship-it","description":"Internal tool to manage release builds","fork":false,"url":"https://api.github.com/repos/mozilla-releng/ship-it","forks_url":"https://api.github.com/repos/mozilla-releng/ship-it/forks","keys_url":"https://api.github.com/repos/mozilla-releng/ship-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-releng/ship-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-releng/ship-it/teams","hooks_url":"https://api.github.com/repos/mozilla-releng/ship-it/hooks","issue_events_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-releng/ship-it/events","assignees_url":"https://api.github.com/repos/mozilla-releng/ship-it/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-releng/ship-it/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-releng/ship-it/tags","blobs_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-releng/ship-it/languages","stargazers_url":"https://api.github.com/repos/mozilla-releng/ship-it/stargazers","contributors_url":"https://api.github.com/repos/mozilla-releng/ship-it/contributors","subscribers_url":"https://api.github.com/repos/mozilla-releng/ship-it/subscribers","subscription_url":"https://api.github.com/repos/mozilla-releng/ship-it/subscription","commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-releng/ship-it/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-releng/ship-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-releng/ship-it/merges","archive_url":"https://api.github.com/repos/mozilla-releng/ship-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-releng/ship-it/downloads","issues_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-releng/ship-it/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-releng/ship-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-releng/ship-it/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-releng/ship-it/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-releng/ship-it/deployments","created_at":"2015-02-23T17:07:32Z","updated_at":"2016-08-01T13:59:21Z","pushed_at":"2016-08-22T20:50:42Z","git_url":"git://github.com/mozilla-releng/ship-it.git","ssh_url":"git@github.com:mozilla-releng/ship-it.git","clone_url":"https://github.com/mozilla-releng/ship-it.git","svn_url":"https://github.com/mozilla-releng/ship-it","homepage":null,"size":3115,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114"},"html":{"href":"https://github.com/mozilla-releng/ship-it/pull/114"},"issue":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/issues/114"},"comments":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/8c7322a54d83e3132420d699eaef484174bae591"}}}}
{"actor":{"display_login":"JohanLorenzo"}}