{"action":"created","issue":{"url":"https://api.github.com/repos/nengo/nengo/issues/1068","repository_url":"https://api.github.com/repos/nengo/nengo","labels_url":"https://api.github.com/repos/nengo/nengo/issues/1068/labels{/name}","comments_url":"https://api.github.com/repos/nengo/nengo/issues/1068/comments","events_url":"https://api.github.com/repos/nengo/nengo/issues/1068/events","html_url":"https://github.com/nengo/nengo/pull/1068","id":155309988,"number":1068,"title":"Only cache things in a registry","user":{"login":"tbekolay","id":203709,"avatar_url":"https://avatars.githubusercontent.com/u/203709?v=3","gravatar_id":"","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nengo/nengo/labels/discussion","name":"discussion","color":"207de5"},{"url":"https://api.github.com/repos/nengo/nengo/labels/needs%20review","name":"needs review","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-05-17T16:57:11Z","updated_at":"2016-08-26T00:14:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nengo/nengo/pulls/1068","html_url":"https://github.com/nengo/nengo/pull/1068","diff_url":"https://github.com/nengo/nengo/pull/1068.diff","patch_url":"https://github.com/nengo/nengo/pull/1068.patch"},"body":"This is an alternative implementation of #1066 that uses a class registry in the `Fingerprint` rather than modifying frontend objects.\r\n\r\nIt occurred to me that the cache system (at least for now) is specific to the reference backend, so it would be best to keep any cache-specific code local to the cache, rather than modifying frontend objects. So that's what this branch does.\r\n\r\nI think the amount of code is, in the end, about the same. `Fingerprint.__init__` is more clear this way (IMO) but we don't get the benefit of subclassing inheriting things, so each class that should be fingerprinted needs a separate call to `Fingerprint.whitelist`. But perhaps that's desirable anyhow?"},"comment":{"url":"https://api.github.com/repos/nengo/nengo/issues/comments/242585326","html_url":"https://github.com/nengo/nengo/pull/1068#issuecomment-242585326","issue_url":"https://api.github.com/repos/nengo/nengo/issues/1068","id":242585326,"user":{"login":"jgosmann","id":850157,"avatar_url":"https://avatars.githubusercontent.com/u/850157?v=3","gravatar_id":"","url":"https://api.github.com/users/jgosmann","html_url":"https://github.com/jgosmann","followers_url":"https://api.github.com/users/jgosmann/followers","following_url":"https://api.github.com/users/jgosmann/following{/other_user}","gists_url":"https://api.github.com/users/jgosmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jgosmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgosmann/subscriptions","organizations_url":"https://api.github.com/users/jgosmann/orgs","repos_url":"https://api.github.com/users/jgosmann/repos","events_url":"https://api.github.com/users/jgosmann/events{/privacy}","received_events_url":"https://api.github.com/users/jgosmann/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T00:14:55Z","updated_at":"2016-08-26T00:14:55Z","body":"I think I'm ok with and without that additional commit. I think the additional commit makes this more conservative because it checks more."}}
{"actor":{"display_login":"jgosmann"}}