{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/65920858","id":65920858,"diff_hunk":"@@ -407,6 +409,28 @@ define([\n         }\n     }\n \n+    function initYellowPlayButton() {\n+        $('.fc-item__video-fallback', document.body).each(function (el) {\n+            bonzo(el).addClass('vjs-big-play-button--yellow');\n+        });\n+\n+        var selector = '.fc-item__video';\n+        var hoverStateClassName = 'u-faux-block-link--hover';\n+\n+        var showIntentToPlay = function (e) {\n+            fastdom.write(function () {","path":"static/src/javascripts/bootstraps/enhanced/media/main.js","position":29,"original_position":29,"commit_id":"2ba0bcb7b268347b8dc387e1856ab7406bb49830","original_commit_id":"2ba0bcb7b268347b8dc387e1856ab7406bb49830","user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars.githubusercontent.com/u/31692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"body":"You'll need to apply fastdom everywhere else.","created_at":"2016-06-06T16:19:14Z","updated_at":"2016-06-06T16:19:14Z","html_url":"https://github.com/guardian/frontend/pull/13217#discussion_r65920858","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/13217","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/65920858"},"html":{"href":"https://github.com/guardian/frontend/pull/13217#discussion_r65920858"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13217"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/13217","id":72721241,"html_url":"https://github.com/guardian/frontend/pull/13217","diff_url":"https://github.com/guardian/frontend/pull/13217.diff","patch_url":"https://github.com/guardian/frontend/pull/13217.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/13217","number":13217,"state":"open","locked":false,"title":"make big play button yellow on fronts","user":{"login":"akash1810","id":836140,"avatar_url":"https://avatars.githubusercontent.com/u/836140?v=3","gravatar_id":"","url":"https://api.github.com/users/akash1810","html_url":"https://github.com/akash1810","followers_url":"https://api.github.com/users/akash1810/followers","following_url":"https://api.github.com/users/akash1810/following{/other_user}","gists_url":"https://api.github.com/users/akash1810/gists{/gist_id}","starred_url":"https://api.github.com/users/akash1810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash1810/subscriptions","organizations_url":"https://api.github.com/users/akash1810/orgs","repos_url":"https://api.github.com/users/akash1810/repos","events_url":"https://api.github.com/users/akash1810/events{/privacy}","received_events_url":"https://api.github.com/users/akash1810/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\na similar test had positive results on main media so testing the effect on fronts\r\n\r\nusing similar principle as https://github.com/guardian/frontend/blob/master/static/src/javascripts/projects/common/modules/ui/faux-block-link.js to achieve a hover state on the whole card as the play button is going from yellow to yellow rather than grey to yellow, therefore hover state needs to be more obvious\r\n\r\n## What is the value of this and can you measure success?\r\nincrease in video starts on fronts\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nno\r\n\r\n## Screenshots\r\n![yellow](https://cloud.githubusercontent.com/assets/836140/15825827/26a21ad4-2bfd-11e6-8652-cff7c03d6766.gif)\r\n\r\n## Request for comment\r\n@jamesgorrie \r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->","created_at":"2016-06-06T14:44:31Z","updated_at":"2016-06-06T16:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cbb93f89cae09ceeed965fb143f02643e9a7361","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/13217/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/13217/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/13217/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/2ba0bcb7b268347b8dc387e1856ab7406bb49830","head":{"label":"guardian:aa-video-yellow-button-test","ref":"aa-video-yellow-button-test","sha":"2ba0bcb7b268347b8dc387e1856ab7406bb49830","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-06-02T22:25:34Z","pushed_at":"2016-06-06T16:17:54Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":483061,"stargazers_count":3208,"watchers_count":3208,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":56,"forks":334,"open_issues":56,"watchers":3208,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"f3b9840a11d250aeec53a84cb6e89918e3cd93b4","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-06-02T22:25:34Z","pushed_at":"2016-06-06T16:17:54Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":483061,"stargazers_count":3208,"watchers_count":3208,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":56,"forks":334,"open_issues":56,"watchers":3208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13217"},"html":{"href":"https://github.com/guardian/frontend/pull/13217"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/13217"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/13217/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13217/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/13217/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/2ba0bcb7b268347b8dc387e1856ab7406bb49830"}}}}
{"actor":{"display_login":"jamesgorrie"}}