{"action":"created","comment":{"url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/comments/88475833","pull_request_review_id":9048681,"id":88475833,"diff_hunk":"@@ -12,6 +12,24 @@ Logger.logExternalMessage = (eventName, eventDetails) => {\n   window.logExternal(eventName, window.RiseVision.Viewer.EntryPoint.getDisplayId(), Global.VIEWER_VERSION, eventDetails);\n };\n \n+Logger.logException = (methodName, err, identifier) => {\n+  try {","path":"src-js/Viewer/Logger.js","position":5,"original_position":5,"commit_id":"ce6a703788718bb7623fe9676ff04c78d46f94c7","original_commit_id":"ce6a703788718bb7623fe9676ff04c78d46f94c7","user":{"login":"alex-deaconu","id":6218188,"avatar_url":"https://avatars.githubusercontent.com/u/6218188?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-deaconu","html_url":"https://github.com/alex-deaconu","followers_url":"https://api.github.com/users/alex-deaconu/followers","following_url":"https://api.github.com/users/alex-deaconu/following{/other_user}","gists_url":"https://api.github.com/users/alex-deaconu/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-deaconu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-deaconu/subscriptions","organizations_url":"https://api.github.com/users/alex-deaconu/orgs","repos_url":"https://api.github.com/users/alex-deaconu/repos","events_url":"https://api.github.com/users/alex-deaconu/events{/privacy}","received_events_url":"https://api.github.com/users/alex-deaconu/received_events","type":"User","site_admin":false},"body":"@settinghead wondering why you chose to add a new function and modify all those files rather than just add BQ logging functionality and improve to the Logger.log function. Thoughts? Thanks.","created_at":"2016-11-17T15:31:39Z","updated_at":"2016-11-17T15:31:40Z","html_url":"https://github.com/Rise-Vision/viewer/pull/187#discussion_r88475833","pull_request_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/comments/88475833"},"html":{"href":"https://github.com/Rise-Vision/viewer/pull/187#discussion_r88475833"},"pull_request":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187","id":94136421,"html_url":"https://github.com/Rise-Vision/viewer/pull/187","diff_url":"https://github.com/Rise-Vision/viewer/pull/187.diff","patch_url":"https://github.com/Rise-Vision/viewer/pull/187.patch","issue_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/187","number":187,"state":"open","locked":false,"title":"Exception logging into BQ","user":{"login":"settinghead","id":794516,"avatar_url":"https://avatars.githubusercontent.com/u/794516?v=3","gravatar_id":"","url":"https://api.github.com/users/settinghead","html_url":"https://github.com/settinghead","followers_url":"https://api.github.com/users/settinghead/followers","following_url":"https://api.github.com/users/settinghead/following{/other_user}","gists_url":"https://api.github.com/users/settinghead/gists{/gist_id}","starred_url":"https://api.github.com/users/settinghead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/settinghead/subscriptions","organizations_url":"https://api.github.com/users/settinghead/orgs","repos_url":"https://api.github.com/users/settinghead/repos","events_url":"https://api.github.com/users/settinghead/events{/privacy}","received_events_url":"https://api.github.com/users/settinghead/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-17T10:06:04Z","updated_at":"2016-11-17T15:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"686b29a872d9d407f838438016402ff1f3a6c09b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187/commits","review_comments_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187/comments","review_comment_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/187/comments","statuses_url":"https://api.github.com/repos/Rise-Vision/viewer/statuses/ce6a703788718bb7623fe9676ff04c78d46f94c7","head":{"label":"Rise-Vision:chore/bigdata-logging","ref":"chore/bigdata-logging","sha":"ce6a703788718bb7623fe9676ff04c78d46f94c7","user":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":19825628,"name":"viewer","full_name":"Rise-Vision/viewer","owner":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rise-Vision/viewer","description":null,"fork":false,"url":"https://api.github.com/repos/Rise-Vision/viewer","forks_url":"https://api.github.com/repos/Rise-Vision/viewer/forks","keys_url":"https://api.github.com/repos/Rise-Vision/viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/viewer/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/viewer/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/viewer/events","assignees_url":"https://api.github.com/repos/Rise-Vision/viewer/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/viewer/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/viewer/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/viewer/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/viewer/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/viewer/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/viewer/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/viewer/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/viewer/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/viewer/merges","archive_url":"https://api.github.com/repos/Rise-Vision/viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/viewer/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/viewer/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/viewer/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/viewer/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/viewer/deployments","created_at":"2014-05-15T15:52:48Z","updated_at":"2016-10-31T15:39:20Z","pushed_at":"2016-11-17T10:18:57Z","git_url":"git://github.com/Rise-Vision/viewer.git","ssh_url":"git@github.com:Rise-Vision/viewer.git","clone_url":"https://github.com/Rise-Vision/viewer.git","svn_url":"https://github.com/Rise-Vision/viewer","homepage":"http://preview.risevision.com","size":1547,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"Rise-Vision:master","ref":"master","sha":"535fae7c0e78161cfcb5d5c6316a7486d3b36d06","user":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":19825628,"name":"viewer","full_name":"Rise-Vision/viewer","owner":{"login":"Rise-Vision","id":6840223,"avatar_url":"https://avatars.githubusercontent.com/u/6840223?v=3","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rise-Vision/viewer","description":null,"fork":false,"url":"https://api.github.com/repos/Rise-Vision/viewer","forks_url":"https://api.github.com/repos/Rise-Vision/viewer/forks","keys_url":"https://api.github.com/repos/Rise-Vision/viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/viewer/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/viewer/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/viewer/events","assignees_url":"https://api.github.com/repos/Rise-Vision/viewer/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/viewer/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/viewer/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/viewer/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/viewer/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/viewer/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/viewer/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/viewer/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/viewer/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/viewer/merges","archive_url":"https://api.github.com/repos/Rise-Vision/viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/viewer/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/viewer/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/viewer/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/viewer/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/viewer/deployments","created_at":"2014-05-15T15:52:48Z","updated_at":"2016-10-31T15:39:20Z","pushed_at":"2016-11-17T10:18:57Z","git_url":"git://github.com/Rise-Vision/viewer.git","ssh_url":"git@github.com:Rise-Vision/viewer.git","clone_url":"https://github.com/Rise-Vision/viewer.git","svn_url":"https://github.com/Rise-Vision/viewer","homepage":"http://preview.risevision.com","size":1547,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187"},"html":{"href":"https://github.com/Rise-Vision/viewer/pull/187"},"issue":{"href":"https://api.github.com/repos/Rise-Vision/viewer/issues/187"},"comments":{"href":"https://api.github.com/repos/Rise-Vision/viewer/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rise-Vision/viewer/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/Rise-Vision/viewer/statuses/ce6a703788718bb7623fe9676ff04c78d46f94c7"}}}}
{"actor":{"display_login":"alex-deaconu"}}