{"action":"created","issue":{"url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/265","repository_url":"https://api.github.com/repos/SharePoint/sp-dev-docs","labels_url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/265/comments","events_url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/265/events","html_url":"https://github.com/SharePoint/sp-dev-docs/issues/265","id":185970703,"number":265,"title":"Conflict between @Types and tsd definitions","user":{"login":"patrick-rodgers","id":13154702,"avatar_url":"https://avatars.githubusercontent.com/u/13154702?v=3","gravatar_id":"","url":"https://api.github.com/users/patrick-rodgers","html_url":"https://github.com/patrick-rodgers","followers_url":"https://api.github.com/users/patrick-rodgers/followers","following_url":"https://api.github.com/users/patrick-rodgers/following{/other_user}","gists_url":"https://api.github.com/users/patrick-rodgers/gists{/gist_id}","starred_url":"https://api.github.com/users/patrick-rodgers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrick-rodgers/subscriptions","organizations_url":"https://api.github.com/users/patrick-rodgers/orgs","repos_url":"https://api.github.com/users/patrick-rodgers/repos","events_url":"https://api.github.com/users/patrick-rodgers/events{/privacy}","received_events_url":"https://api.github.com/users/patrick-rodgers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-28T16:52:56Z","updated_at":"2016-11-29T07:36:33Z","closed_at":null,"body":"#### Category\r\n- [ ] Question\r\n- [ ] Typo\r\n- [X] Bug\r\n- [X] Enhancement / Suggestion\r\n- [ ] Additional article idea\r\n#### Expected or Desired Behavior\r\n\r\nAble to load libraries which have @Types dependencies and not get duplicate definition errors. This can be accomplished by moving the typings system used by SP Fx to @Types which works with TS2.0\r\n#### Observed Behavior\r\n\r\nWhen importing the sp-pnp-js library which uses the @Types definitions for typing support in TS 2.0 there are conflicts (duplicate definitions) due to the two typing systems being used.\r\n#### Steps to Reproduce\r\n\r\n`npm install --save sp-pnp-js`\r\n\r\nin a webpart file:\r\n\r\n```\r\nimport pnp from \"sp-pnp-js\";\r\npnp.web.get().then(w => console.log(JSON.stringify(w));\r\n```\r\n\r\nin command window:\r\n`gulp serve`\r\n\n---\r\n\r\nWhen I update the local webpart project with the following dependencies and remove the tsd refs things build as expected. Did have to comment out the test file as the mocha types weren't resolving, despite their installation. I could not locate src to see how tests are compiled but likely a fairly easy update.\r\n\r\n```\r\n   \"@types/assertion-error\": \"^1.0.30\",\r\n   \"@types/chai\": \"^3.4.34\",\r\n   \"@types/combokeys\": \"^2.4.5\",\r\n   \"@types/es6-collections\": \"^0.5.29\",\r\n   \"@types/es6-promise\": \"0.0.32\",\r\n   \"@types/knockout\": \"^3.4.36\",\r\n   \"@types/lodash\": \"^4.14.37\",\r\n   \"@types/mocha\": \"^2.2.32\",\r\n   \"@types/node\": \"^6.0.46\",\r\n   \"@types/react\": \"^0.14.43\",\r\n   \"@types/react-addons-shallow-compare\": \"^0.14.17\",\r\n   \"@types/react-addons-test-utils\": \"^0.14.15\",\r\n   \"@types/react-addons-update\": \"^0.14.14\",\r\n   \"@types/react-dom\": \"^0.14.18\",\r\n   \"@types/systemjs\": \"^0.19.31\",\r\n   \"@types/whatwg-fetch\": \"0.0.32\",\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/comments/263497827","html_url":"https://github.com/SharePoint/sp-dev-docs/issues/265#issuecomment-263497827","issue_url":"https://api.github.com/repos/SharePoint/sp-dev-docs/issues/265","id":263497827,"user":{"login":"chakkaradeep","id":7882052,"avatar_url":"https://avatars.githubusercontent.com/u/7882052?v=3","gravatar_id":"","url":"https://api.github.com/users/chakkaradeep","html_url":"https://github.com/chakkaradeep","followers_url":"https://api.github.com/users/chakkaradeep/followers","following_url":"https://api.github.com/users/chakkaradeep/following{/other_user}","gists_url":"https://api.github.com/users/chakkaradeep/gists{/gist_id}","starred_url":"https://api.github.com/users/chakkaradeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakkaradeep/subscriptions","organizations_url":"https://api.github.com/users/chakkaradeep/orgs","repos_url":"https://api.github.com/users/chakkaradeep/repos","events_url":"https://api.github.com/users/chakkaradeep/events{/privacy}","received_events_url":"https://api.github.com/users/chakkaradeep/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T07:36:33Z","updated_at":"2016-11-29T07:36:33Z","body":"@patrick-rodgers do you still have this issue in Drop 6?"}}
{"actor":{"display_login":"chakkaradeep"}}