{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/67051412","id":67051412,"diff_hunk":"@@ -5,6 +5,7 @@\n \t_color = \"webbing\"\n \tvar/slots = 3\n \tvar/list/can_only_hold = list() //I would add the other storage item variables, but nothing would use them yet, so there's no point.\n+\tvar/list/cant_hold = list(\"/obj/item/clothing/accessory/storage\", \"/obj/item/clothing/under\") //NO RECURSION","path":"code/modules/clothing/under/accessories/storage.dm","position":null,"original_position":4,"commit_id":"657fc2bf76d40c928ec0721321ebb98ce8b667ad","original_commit_id":"657fc2bf76d40c928ec0721321ebb98ce8b667ad","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"body":"That's built into `cant_hold`\r\nIt's only a strict type check if there's an = at the beginning of the string\r\nOtherwise, it checks `typesof()`","created_at":"2016-06-14T20:36:04Z","updated_at":"2016-06-14T20:36:04Z","html_url":"https://github.com/d3athrow/vgstation13/pull/10551#discussion_r67051412","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/67051412"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/10551#discussion_r67051412"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551","id":73671854,"html_url":"https://github.com/d3athrow/vgstation13/pull/10551","diff_url":"https://github.com/d3athrow/vgstation13/pull/10551.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/10551.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/10551","number":10551,"state":"open","locked":false,"title":"Bandoliers are now accessories","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"body":"For such a simple change, this sure required changing a lot of files.\r\n\r\nBandoliers are now accessories, so they clip to your jumpsuit rather than going in your exosuit slot. Otherwise they work essentially the same.\r\n\r\nThe buff seems reasonable because:\r\n\r\n1. Bandoliers are rare. No more than five exist on any given map and there's nowhere else to get them (as far as I know).\r\n2. Plastic bags hold way more shells than bandoliers do and are much more common.\r\n3. Hell, the boxes the shells come in hold almost three times as many shells as a bandolier.\r\n\r\nThis also adds missing `Destroy()` procs for base accessories and storage accessories. Someone more experienced with `Destroy()` procs should probably take a look at those.\r\nIt also fixes storage accessories not having `..()` in their `New()` and thus not showing up on jumpsuits in the inventory, as well as probably some other stuff associated with not inheriting `/atom/New()`.\r\n\r\nFixes #7704\r\nCloses #10541","created_at":"2016-06-14T02:33:10Z","updated_at":"2016-06-14T20:36:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9710456b5cfb70e50bc3e35a8f103002e184a2f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/10551/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/657fc2bf76d40c928ec0721321ebb98ce8b667ad","head":{"label":"Exxion:bandolier","ref":"bandolier","sha":"657fc2bf76d40c928ec0721321ebb98ce8b667ad","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"repo":{"id":30894557,"name":"vgstation13","full_name":"Exxion/vgstation13","owner":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Exxion/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/Exxion/vgstation13","forks_url":"https://api.github.com/repos/Exxion/vgstation13/forks","keys_url":"https://api.github.com/repos/Exxion/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exxion/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exxion/vgstation13/teams","hooks_url":"https://api.github.com/repos/Exxion/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/Exxion/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/Exxion/vgstation13/events","assignees_url":"https://api.github.com/repos/Exxion/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/Exxion/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/Exxion/vgstation13/tags","blobs_url":"https://api.github.com/repos/Exxion/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exxion/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exxion/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exxion/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exxion/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/Exxion/vgstation13/languages","stargazers_url":"https://api.github.com/repos/Exxion/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/Exxion/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/Exxion/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/Exxion/vgstation13/subscription","commits_url":"https://api.github.com/repos/Exxion/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exxion/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exxion/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exxion/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exxion/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/Exxion/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exxion/vgstation13/merges","archive_url":"https://api.github.com/repos/Exxion/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exxion/vgstation13/downloads","issues_url":"https://api.github.com/repos/Exxion/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/Exxion/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/Exxion/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/Exxion/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exxion/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/Exxion/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/Exxion/vgstation13/deployments","created_at":"2015-02-16T23:51:09Z","updated_at":"2016-05-26T07:59:37Z","pushed_at":"2016-06-14T20:14:42Z","git_url":"git://github.com/Exxion/vgstation13.git","ssh_url":"git@github.com:Exxion/vgstation13.git","clone_url":"https://github.com/Exxion/vgstation13.git","svn_url":"https://github.com/Exxion/vgstation13","homepage":"","size":889218,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"1becd2a4a47c15e7289a20a5ea42c4f649152ecf","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/d3athrow/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2016-06-11T15:47:15Z","pushed_at":"2016-06-14T20:21:17Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1125995,"stargazers_count":85,"watchers_count":85,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":1625,"forks":247,"open_issues":1625,"watchers":85,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/10551"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/10551"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/10551/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/10551/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/657fc2bf76d40c928ec0721321ebb98ce8b667ad"}}}}
{"actor":{"display_login":"Exxion"}}