{"action":"closed","number":34623,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34623","id":77199301,"html_url":"https://github.com/saltstack/salt/pull/34623","diff_url":"https://github.com/saltstack/salt/pull/34623.diff","patch_url":"https://github.com/saltstack/salt/pull/34623.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34623","number":34623,"state":"closed","locked":false,"title":"Properly pass in userdata as string","user":{"login":"techhat","id":287147,"avatar_url":"https://avatars.githubusercontent.com/u/287147?v=3","gravatar_id":"","url":"https://api.github.com/users/techhat","html_url":"https://github.com/techhat","followers_url":"https://api.github.com/users/techhat/followers","following_url":"https://api.github.com/users/techhat/following{/other_user}","gists_url":"https://api.github.com/users/techhat/gists{/gist_id}","starred_url":"https://api.github.com/users/techhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techhat/subscriptions","organizations_url":"https://api.github.com/users/techhat/orgs","repos_url":"https://api.github.com/users/techhat/repos","events_url":"https://api.github.com/users/techhat/events{/privacy}","received_events_url":"https://api.github.com/users/techhat/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n`compile_template` expects a file name, not a string. Normally we would just pass in `userdata_file`, but we want to be able to handle raw `userdata` as well. Because of situations like this, `compile_template()` was modified to accept a token to let it know that it's getting raw data.\r\n\r\n### What issues does this PR fix or reference?\r\n#34610\r\n\r\n### Previous Behavior\r\nData was passed in improperly.\r\n\r\n### Tests written?\r\nNo.","created_at":"2016-07-12T22:01:03Z","updated_at":"2016-07-13T15:13:22Z","closed_at":"2016-07-13T15:13:22Z","merged_at":"2016-07-13T15:13:22Z","merge_commit_sha":"dd855c2148175fe8225d4153cf0173b2107115c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/34623/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/34623/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34623/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/2e9d1b96b91ab1c71e4faf49b5a3f91dcd3a8cfd","head":{"label":"techhat:issue34610","ref":"issue34610","sha":"2e9d1b96b91ab1c71e4faf49b5a3f91dcd3a8cfd","user":{"login":"techhat","id":287147,"avatar_url":"https://avatars.githubusercontent.com/u/287147?v=3","gravatar_id":"","url":"https://api.github.com/users/techhat","html_url":"https://github.com/techhat","followers_url":"https://api.github.com/users/techhat/followers","following_url":"https://api.github.com/users/techhat/following{/other_user}","gists_url":"https://api.github.com/users/techhat/gists{/gist_id}","starred_url":"https://api.github.com/users/techhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techhat/subscriptions","organizations_url":"https://api.github.com/users/techhat/orgs","repos_url":"https://api.github.com/users/techhat/repos","events_url":"https://api.github.com/users/techhat/events{/privacy}","received_events_url":"https://api.github.com/users/techhat/received_events","type":"User","site_admin":false},"repo":{"id":2743096,"name":"salt","full_name":"techhat/salt","owner":{"login":"techhat","id":287147,"avatar_url":"https://avatars.githubusercontent.com/u/287147?v=3","gravatar_id":"","url":"https://api.github.com/users/techhat","html_url":"https://github.com/techhat","followers_url":"https://api.github.com/users/techhat/followers","following_url":"https://api.github.com/users/techhat/following{/other_user}","gists_url":"https://api.github.com/users/techhat/gists{/gist_id}","starred_url":"https://api.github.com/users/techhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techhat/subscriptions","organizations_url":"https://api.github.com/users/techhat/orgs","repos_url":"https://api.github.com/users/techhat/repos","events_url":"https://api.github.com/users/techhat/events{/privacy}","received_events_url":"https://api.github.com/users/techhat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/techhat/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/techhat/salt","forks_url":"https://api.github.com/repos/techhat/salt/forks","keys_url":"https://api.github.com/repos/techhat/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/techhat/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/techhat/salt/teams","hooks_url":"https://api.github.com/repos/techhat/salt/hooks","issue_events_url":"https://api.github.com/repos/techhat/salt/issues/events{/number}","events_url":"https://api.github.com/repos/techhat/salt/events","assignees_url":"https://api.github.com/repos/techhat/salt/assignees{/user}","branches_url":"https://api.github.com/repos/techhat/salt/branches{/branch}","tags_url":"https://api.github.com/repos/techhat/salt/tags","blobs_url":"https://api.github.com/repos/techhat/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/techhat/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/techhat/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/techhat/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/techhat/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/techhat/salt/languages","stargazers_url":"https://api.github.com/repos/techhat/salt/stargazers","contributors_url":"https://api.github.com/repos/techhat/salt/contributors","subscribers_url":"https://api.github.com/repos/techhat/salt/subscribers","subscription_url":"https://api.github.com/repos/techhat/salt/subscription","commits_url":"https://api.github.com/repos/techhat/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/techhat/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/techhat/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/techhat/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/techhat/salt/contents/{+path}","compare_url":"https://api.github.com/repos/techhat/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/techhat/salt/merges","archive_url":"https://api.github.com/repos/techhat/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/techhat/salt/downloads","issues_url":"https://api.github.com/repos/techhat/salt/issues{/number}","pulls_url":"https://api.github.com/repos/techhat/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/techhat/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/techhat/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/techhat/salt/labels{/name}","releases_url":"https://api.github.com/repos/techhat/salt/releases{/id}","deployments_url":"https://api.github.com/repos/techhat/salt/deployments","created_at":"2011-11-09T17:21:46Z","updated_at":"2015-06-18T19:07:19Z","pushed_at":"2016-07-12T21:55:31Z","git_url":"git://github.com/techhat/salt.git","ssh_url":"git@github.com:techhat/salt.git","clone_url":"https://github.com/techhat/salt.git","svn_url":"https://github.com/techhat/salt","homepage":"saltstack.org","size":166403,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"f83e81371a0e480db1ff43512f0cb4082c91d0fa","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-07-13T15:10:08Z","pushed_at":"2016-07-13T15:13:22Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":245424,"stargazers_count":6691,"watchers_count":6691,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3009,"mirror_url":null,"open_issues_count":3654,"forks":3009,"open_issues":3654,"watchers":6691,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34623"},"html":{"href":"https://github.com/saltstack/salt/pull/34623"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/34623"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/34623/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34623/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34623/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/2e9d1b96b91ab1c71e4faf49b5a3f91dcd3a8cfd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"rallytime"}}