{"action":"created","comment":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/75578924","id":75578924,"diff_hunk":"@@ -1,11 +1,11 @@\n package org.easyrpg.player.button_mapping;\n ","path":"builds/android/app/src/main/java/org/easyrpg/player/button_mapping/ButtonMappingActivity.java","position":2,"original_position":2,"commit_id":"c0f7fb3c056eec3028931954ecfd1c1fb3d66e7c","original_commit_id":"c0f7fb3c056eec3028931954ecfd1c1fb3d66e7c","user":{"login":"Ghabry","id":1331889,"avatar_url":"https://avatars.githubusercontent.com/u/1331889?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false},"body":"This class has mixed identation (spac e+ tab)","created_at":"2016-08-20T13:54:28Z","updated_at":"2016-08-20T13:54:28Z","html_url":"https://github.com/EasyRPG/Player/pull/980#discussion_r75578924","pull_request_url":"https://api.github.com/repos/EasyRPG/Player/pulls/980","_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/75578924"},"html":{"href":"https://github.com/EasyRPG/Player/pull/980#discussion_r75578924"},"pull_request":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/980"}}},"pull_request":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/980","id":80525938,"html_url":"https://github.com/EasyRPG/Player/pull/980","diff_url":"https://github.com/EasyRPG/Player/pull/980.diff","patch_url":"https://github.com/EasyRPG/Player/pull/980.patch","issue_url":"https://api.github.com/repos/EasyRPG/Player/issues/980","number":980,"state":"open","locked":false,"title":"[Android] New UI and Code Clean","user":{"login":"BlisterB","id":2387475,"avatar_url":"https://avatars.githubusercontent.com/u/2387475?v=3","gravatar_id":"","url":"https://api.github.com/users/BlisterB","html_url":"https://github.com/BlisterB","followers_url":"https://api.github.com/users/BlisterB/followers","following_url":"https://api.github.com/users/BlisterB/following{/other_user}","gists_url":"https://api.github.com/users/BlisterB/gists{/gist_id}","starred_url":"https://api.github.com/users/BlisterB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlisterB/subscriptions","organizations_url":"https://api.github.com/users/BlisterB/orgs","repos_url":"https://api.github.com/users/BlisterB/repos","events_url":"https://api.github.com/users/BlisterB/events{/privacy}","received_events_url":"https://api.github.com/users/BlisterB/received_events","type":"User","site_admin":false},"body":"Hi everyone.\r\n\r\nThis PR doesn't bring any new feature and is only focused on code clean related to Preferences.\r\n\r\nDealing with user's settings was a little annoying, but not anymore.\r\n- Setting's Controller and Activity are separated.\r\n- No need to pass the Context everywhere in order to modify/access a preference variable. This is cool because before this PR you had to put the context on too much function argument (thanks Android).\r\n- No need to update the Preferences class to be sure that data are updated.\r\n- With the facade design pattern used in SettingManager, element to modify are now clearer.\r\n\r\nPS : I intend to do 1 code clean commit tomorrow (and I have to remove the 2 .iml files).\r\nPS2 : I rebased on master.","created_at":"2016-08-08T21:33:13Z","updated_at":"2016-08-20T13:54:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ff0047b803a3769caec2149e5c287e9f0cf94b4","assignee":{"login":"Ghabry","id":1331889,"avatar_url":"https://avatars.githubusercontent.com/u/1331889?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ghabry","id":1331889,"avatar_url":"https://avatars.githubusercontent.com/u/1331889?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/EasyRPG/Player/pulls/980/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/Player/pulls/980/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/Player/issues/980/comments","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/c0f7fb3c056eec3028931954ecfd1c1fb3d66e7c","head":{"label":"BlisterB:master","ref":"master","sha":"c0f7fb3c056eec3028931954ecfd1c1fb3d66e7c","user":{"login":"BlisterB","id":2387475,"avatar_url":"https://avatars.githubusercontent.com/u/2387475?v=3","gravatar_id":"","url":"https://api.github.com/users/BlisterB","html_url":"https://github.com/BlisterB","followers_url":"https://api.github.com/users/BlisterB/followers","following_url":"https://api.github.com/users/BlisterB/following{/other_user}","gists_url":"https://api.github.com/users/BlisterB/gists{/gist_id}","starred_url":"https://api.github.com/users/BlisterB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlisterB/subscriptions","organizations_url":"https://api.github.com/users/BlisterB/orgs","repos_url":"https://api.github.com/users/BlisterB/repos","events_url":"https://api.github.com/users/BlisterB/events{/privacy}","received_events_url":"https://api.github.com/users/BlisterB/received_events","type":"User","site_admin":false},"repo":{"id":30117614,"name":"Player","full_name":"BlisterB/Player","owner":{"login":"BlisterB","id":2387475,"avatar_url":"https://avatars.githubusercontent.com/u/2387475?v=3","gravatar_id":"","url":"https://api.github.com/users/BlisterB","html_url":"https://github.com/BlisterB","followers_url":"https://api.github.com/users/BlisterB/followers","following_url":"https://api.github.com/users/BlisterB/following{/other_user}","gists_url":"https://api.github.com/users/BlisterB/gists{/gist_id}","starred_url":"https://api.github.com/users/BlisterB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlisterB/subscriptions","organizations_url":"https://api.github.com/users/BlisterB/orgs","repos_url":"https://api.github.com/users/BlisterB/repos","events_url":"https://api.github.com/users/BlisterB/events{/privacy}","received_events_url":"https://api.github.com/users/BlisterB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BlisterB/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":true,"url":"https://api.github.com/repos/BlisterB/Player","forks_url":"https://api.github.com/repos/BlisterB/Player/forks","keys_url":"https://api.github.com/repos/BlisterB/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlisterB/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlisterB/Player/teams","hooks_url":"https://api.github.com/repos/BlisterB/Player/hooks","issue_events_url":"https://api.github.com/repos/BlisterB/Player/issues/events{/number}","events_url":"https://api.github.com/repos/BlisterB/Player/events","assignees_url":"https://api.github.com/repos/BlisterB/Player/assignees{/user}","branches_url":"https://api.github.com/repos/BlisterB/Player/branches{/branch}","tags_url":"https://api.github.com/repos/BlisterB/Player/tags","blobs_url":"https://api.github.com/repos/BlisterB/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlisterB/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlisterB/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlisterB/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlisterB/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/BlisterB/Player/languages","stargazers_url":"https://api.github.com/repos/BlisterB/Player/stargazers","contributors_url":"https://api.github.com/repos/BlisterB/Player/contributors","subscribers_url":"https://api.github.com/repos/BlisterB/Player/subscribers","subscription_url":"https://api.github.com/repos/BlisterB/Player/subscription","commits_url":"https://api.github.com/repos/BlisterB/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlisterB/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlisterB/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlisterB/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlisterB/Player/contents/{+path}","compare_url":"https://api.github.com/repos/BlisterB/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlisterB/Player/merges","archive_url":"https://api.github.com/repos/BlisterB/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlisterB/Player/downloads","issues_url":"https://api.github.com/repos/BlisterB/Player/issues{/number}","pulls_url":"https://api.github.com/repos/BlisterB/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/BlisterB/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/BlisterB/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlisterB/Player/labels{/name}","releases_url":"https://api.github.com/repos/BlisterB/Player/releases{/id}","deployments_url":"https://api.github.com/repos/BlisterB/Player/deployments","created_at":"2015-01-31T16:14:54Z","updated_at":"2016-01-13T14:17:33Z","pushed_at":"2016-08-20T13:48:41Z","git_url":"git://github.com/BlisterB/Player.git","ssh_url":"git@github.com:BlisterB/Player.git","clone_url":"https://github.com/BlisterB/Player.git","svn_url":"https://github.com/BlisterB/Player","homepage":"https://easy-rpg.org/","size":25152,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"0966754fd3e44559c5980b3983ae0beb4e426b8d","user":{"login":"EasyRPG","id":1331871,"avatar_url":"https://avatars.githubusercontent.com/u/1331871?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3297519,"name":"Player","full_name":"EasyRPG/Player","owner":{"login":"EasyRPG","id":1331871,"avatar_url":"https://avatars.githubusercontent.com/u/1331871?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EasyRPG/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":false,"url":"https://api.github.com/repos/EasyRPG/Player","forks_url":"https://api.github.com/repos/EasyRPG/Player/forks","keys_url":"https://api.github.com/repos/EasyRPG/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/Player/teams","hooks_url":"https://api.github.com/repos/EasyRPG/Player/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/Player/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/Player/events","assignees_url":"https://api.github.com/repos/EasyRPG/Player/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/Player/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/Player/tags","blobs_url":"https://api.github.com/repos/EasyRPG/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/Player/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/Player/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/Player/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/Player/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/Player/subscription","commits_url":"https://api.github.com/repos/EasyRPG/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/Player/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/Player/merges","archive_url":"https://api.github.com/repos/EasyRPG/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/Player/downloads","issues_url":"https://api.github.com/repos/EasyRPG/Player/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/Player/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/Player/releases{/id}","deployments_url":"https://api.github.com/repos/EasyRPG/Player/deployments","created_at":"2012-01-29T14:35:47Z","updated_at":"2016-08-19T22:12:34Z","pushed_at":"2016-08-20T13:48:41Z","git_url":"git://github.com/EasyRPG/Player.git","ssh_url":"git@github.com:EasyRPG/Player.git","clone_url":"https://github.com/EasyRPG/Player.git","svn_url":"https://github.com/EasyRPG/Player","homepage":"https://easyrpg.org","size":68215,"stargazers_count":181,"watchers_count":181,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":102,"forks":51,"open_issues":102,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/980"},"html":{"href":"https://github.com/EasyRPG/Player/pull/980"},"issue":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/980"},"comments":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/980/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/980/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/980/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/Player/statuses/c0f7fb3c056eec3028931954ecfd1c1fb3d66e7c"}}}}
{"actor":{"display_login":"Ghabry"}}