{"action":"created","comment":{"url":"https://api.github.com/repos/micropython/micropython/pulls/comments/92307876","pull_request_review_id":12820372,"id":92307876,"diff_hunk":"@@ -111,11 +111,6 @@ Methods\n \n        Returns the number of bytes waiting (may be 0).\n \n-    .. method:: UART.writechar(char)\n-\n-      Write a single character on the bus.  ``char`` is an integer to write.\n-      Return value: ``None``. See note below if CTS flow control is used.\n-","path":"docs/library/pyb.UART.rst","position":17,"original_position":17,"commit_id":"569de801801d484ce01a72f957d30833839b9ea6","original_commit_id":"569de801801d484ce01a72f957d30833839b9ea6","user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars.githubusercontent.com/u/6187689?v=3","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"body":"Reordering the description for this method is a separate thing, nothing to do with timeout, so please put it in a separate commit (but same PR if you like).","created_at":"2016-12-14T01:44:59Z","updated_at":"2016-12-14T01:45:03Z","html_url":"https://github.com/micropython/micropython/pull/2675#discussion_r92307876","pull_request_url":"https://api.github.com/repos/micropython/micropython/pulls/2675","_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/92307876"},"html":{"href":"https://github.com/micropython/micropython/pull/2675#discussion_r92307876"},"pull_request":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2675"}}},"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/2675","id":97471953,"html_url":"https://github.com/micropython/micropython/pull/2675","diff_url":"https://github.com/micropython/micropython/pull/2675.diff","patch_url":"https://github.com/micropython/micropython/pull/2675.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/2675","number":2675,"state":"open","locked":false,"title":"docs: Added clarification about UART timeouts","user":{"login":"lorenzschmid","id":3830671,"avatar_url":"https://avatars.githubusercontent.com/u/3830671?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzschmid","html_url":"https://github.com/lorenzschmid","followers_url":"https://api.github.com/users/lorenzschmid/followers","following_url":"https://api.github.com/users/lorenzschmid/following{/other_user}","gists_url":"https://api.github.com/users/lorenzschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzschmid/subscriptions","organizations_url":"https://api.github.com/users/lorenzschmid/orgs","repos_url":"https://api.github.com/users/lorenzschmid/repos","events_url":"https://api.github.com/users/lorenzschmid/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzschmid/received_events","type":"User","site_admin":false},"body":"As discussed in #2660 the two UART timeouts given to the constructor (first char, between chars) is valid for reading **and** writing. Updated the documentation to clarify.","created_at":"2016-12-11T20:44:27Z","updated_at":"2016-12-14T01:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"687944a658edddb5d21d5e0c921d9af944aa83aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/2675/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/2675/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/2675/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/569de801801d484ce01a72f957d30833839b9ea6","head":{"label":"lorenzschmid:master","ref":"master","sha":"569de801801d484ce01a72f957d30833839b9ea6","user":{"login":"lorenzschmid","id":3830671,"avatar_url":"https://avatars.githubusercontent.com/u/3830671?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzschmid","html_url":"https://github.com/lorenzschmid","followers_url":"https://api.github.com/users/lorenzschmid/followers","following_url":"https://api.github.com/users/lorenzschmid/following{/other_user}","gists_url":"https://api.github.com/users/lorenzschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzschmid/subscriptions","organizations_url":"https://api.github.com/users/lorenzschmid/orgs","repos_url":"https://api.github.com/users/lorenzschmid/repos","events_url":"https://api.github.com/users/lorenzschmid/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzschmid/received_events","type":"User","site_admin":false},"repo":{"id":76186812,"name":"micropython","full_name":"lorenzschmid/micropython","owner":{"login":"lorenzschmid","id":3830671,"avatar_url":"https://avatars.githubusercontent.com/u/3830671?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzschmid","html_url":"https://github.com/lorenzschmid","followers_url":"https://api.github.com/users/lorenzschmid/followers","following_url":"https://api.github.com/users/lorenzschmid/following{/other_user}","gists_url":"https://api.github.com/users/lorenzschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzschmid/subscriptions","organizations_url":"https://api.github.com/users/lorenzschmid/orgs","repos_url":"https://api.github.com/users/lorenzschmid/repos","events_url":"https://api.github.com/users/lorenzschmid/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzschmid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorenzschmid/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":true,"url":"https://api.github.com/repos/lorenzschmid/micropython","forks_url":"https://api.github.com/repos/lorenzschmid/micropython/forks","keys_url":"https://api.github.com/repos/lorenzschmid/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorenzschmid/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorenzschmid/micropython/teams","hooks_url":"https://api.github.com/repos/lorenzschmid/micropython/hooks","issue_events_url":"https://api.github.com/repos/lorenzschmid/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/lorenzschmid/micropython/events","assignees_url":"https://api.github.com/repos/lorenzschmid/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/lorenzschmid/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/lorenzschmid/micropython/tags","blobs_url":"https://api.github.com/repos/lorenzschmid/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorenzschmid/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorenzschmid/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorenzschmid/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorenzschmid/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/lorenzschmid/micropython/languages","stargazers_url":"https://api.github.com/repos/lorenzschmid/micropython/stargazers","contributors_url":"https://api.github.com/repos/lorenzschmid/micropython/contributors","subscribers_url":"https://api.github.com/repos/lorenzschmid/micropython/subscribers","subscription_url":"https://api.github.com/repos/lorenzschmid/micropython/subscription","commits_url":"https://api.github.com/repos/lorenzschmid/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorenzschmid/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorenzschmid/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorenzschmid/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorenzschmid/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/lorenzschmid/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorenzschmid/micropython/merges","archive_url":"https://api.github.com/repos/lorenzschmid/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorenzschmid/micropython/downloads","issues_url":"https://api.github.com/repos/lorenzschmid/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/lorenzschmid/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/lorenzschmid/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/lorenzschmid/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorenzschmid/micropython/labels{/name}","releases_url":"https://api.github.com/repos/lorenzschmid/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/lorenzschmid/micropython/deployments","created_at":"2016-12-11T16:44:52Z","updated_at":"2016-12-11T16:45:04Z","pushed_at":"2016-12-11T20:41:01Z","git_url":"git://github.com/lorenzschmid/micropython.git","ssh_url":"git@github.com:lorenzschmid/micropython.git","clone_url":"https://github.com/lorenzschmid/micropython.git","svn_url":"https://github.com/lorenzschmid/micropython","homepage":"","size":29075,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"aee13ef3f219a7a2e19c017323694b946d500d14","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/micropython/micropython/deployments","created_at":"2013-12-20T11:47:07Z","updated_at":"2016-12-13T19:52:43Z","pushed_at":"2016-12-14T00:42:28Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":"","size":29168,"stargazers_count":4123,"watchers_count":4123,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":910,"mirror_url":null,"open_issues_count":353,"forks":910,"open_issues":353,"watchers":4123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2675"},"html":{"href":"https://github.com/micropython/micropython/pull/2675"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/2675"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/2675/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2675/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2675/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/569de801801d484ce01a72f957d30833839b9ea6"}}}}
{"actor":{"display_login":"dpgeorge"}}