{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman-installer/issues/203","repository_url":"https://api.github.com/repos/theforeman/foreman-installer","labels_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/203/comments","events_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/203/events","html_url":"https://github.com/theforeman/foreman-installer/pull/203","id":183625098,"number":203,"title":"Added foreman hooks check","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman-installer/labels/Waiting%20on%20contributor","name":"Waiting on contributor","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-18T08:47:42Z","updated_at":"2016-10-19T09:00:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/203","html_url":"https://github.com/theforeman/foreman-installer/pull/203","diff_url":"https://github.com/theforeman/foreman-installer/pull/203.diff","patch_url":"https://github.com/theforeman/foreman-installer/pull/203.patch"},"body":"Added check:\n\nThere are foreman hooks installed on this instance, please either remove them\nor make them non-executable in order to continue. Foreman hooks often change\nbehavior and are not tested across releases.\n\nWhen upgrading, test all workflows before re-enabling any of these hooks to\nverify clean installation. Remember, it can be required to remove all Foreman\nhooks completely when requesting support."},"comment":{"url":"https://api.github.com/repos/theforeman/foreman-installer/issues/comments/254755289","html_url":"https://github.com/theforeman/foreman-installer/pull/203#issuecomment-254755289","issue_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/203","id":254755289,"user":{"login":"sean797","id":13135483,"avatar_url":"https://avatars.githubusercontent.com/u/13135483?v=3","gravatar_id":"","url":"https://api.github.com/users/sean797","html_url":"https://github.com/sean797","followers_url":"https://api.github.com/users/sean797/followers","following_url":"https://api.github.com/users/sean797/following{/other_user}","gists_url":"https://api.github.com/users/sean797/gists{/gist_id}","starred_url":"https://api.github.com/users/sean797/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean797/subscriptions","organizations_url":"https://api.github.com/users/sean797/orgs","repos_url":"https://api.github.com/users/sean797/repos","events_url":"https://api.github.com/users/sean797/events{/privacy}","received_events_url":"https://api.github.com/users/sean797/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T09:00:28Z","updated_at":"2016-10-19T09:00:28Z","body":"I also think that someone who has written a hook should know that something may change during a upgrade, though displaying a message saying hooks may or may not break after an upgrade if they are using hooks wouldn't be a bad thing, but the upgrade should continue.\r\n\r\nDisabling something because you cannot guarantee that it will work afterwards is not the solution. Would you be annoyed if #your-favorite-distro disabled the proprietary video card drivers every time you ran the equivalent of `dnf update -y` because they cannot guarantee that it will still work? I would, not that I run an proprietary video card drivers ;)"}}
{"actor":{"display_login":"sean797"}}