{"action":"closed","number":3881,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881","id":72635770,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3881","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3881.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3881.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3881","number":3881,"state":"closed","locked":false,"title":"Add iOS version of Dolphin Old","user":{"login":"WilliamLCobb","id":870904,"avatar_url":"https://avatars.githubusercontent.com/u/870904?v=3","gravatar_id":"","url":"https://api.github.com/users/WilliamLCobb","html_url":"https://github.com/WilliamLCobb","followers_url":"https://api.github.com/users/WilliamLCobb/followers","following_url":"https://api.github.com/users/WilliamLCobb/following{/other_user}","gists_url":"https://api.github.com/users/WilliamLCobb/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamLCobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamLCobb/subscriptions","organizations_url":"https://api.github.com/users/WilliamLCobb/orgs","repos_url":"https://api.github.com/users/WilliamLCobb/repos","events_url":"https://api.github.com/users/WilliamLCobb/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamLCobb/received_events","type":"User","site_admin":false},"body":"Most of the changes are pretty straightforward. \r\n\r\nAdded iOS directory in Source.\r\nAdded new IOS definition when building for iOS\r\nAdded build steps for in readme.\r\n\r\nCmake will generate an Xcode project in the build directory and copy in the Xcode project and workspace from the iOS directory. The workspace will combine these two projects, allowing full compatibility with future cmake and source changes while also giving control of all of the build settings for iOS. Since iOS is not inherently supported by cmake, this would have been very hard if not impossible without this step. The iOS app can be built in the Xcode GUI and also built from the command line. \r\n\r\nOnly one commit has a chance of affecting other builds: \"IOS macro workaround\" (0a22fb7). IOS was being used as a variable in a struct in Network.cpp and Network.h. Since I was using this as a definition for building iOS, i changed all instances of this variable to _IOS. This probably needs to be changed to something else, I just wasn't sure what\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3881)\n<!-- Reviewable:end -->\n","created_at":"2016-06-05T17:55:24Z","updated_at":"2016-06-06T04:16:28Z","closed_at":"2016-06-06T04:16:28Z","merged_at":null,"merge_commit_sha":"5420ef35a39d1f5bba7d57eeba163b43e11205cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3881/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d43c893571895dcd99d083adc8cf83b550a424fa","head":{"label":"WilliamLCobb:master","ref":"master","sha":"d43c893571895dcd99d083adc8cf83b550a424fa","user":{"login":"WilliamLCobb","id":870904,"avatar_url":"https://avatars.githubusercontent.com/u/870904?v=3","gravatar_id":"","url":"https://api.github.com/users/WilliamLCobb","html_url":"https://github.com/WilliamLCobb","followers_url":"https://api.github.com/users/WilliamLCobb/followers","following_url":"https://api.github.com/users/WilliamLCobb/following{/other_user}","gists_url":"https://api.github.com/users/WilliamLCobb/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamLCobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamLCobb/subscriptions","organizations_url":"https://api.github.com/users/WilliamLCobb/orgs","repos_url":"https://api.github.com/users/WilliamLCobb/repos","events_url":"https://api.github.com/users/WilliamLCobb/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamLCobb/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"dolphin-emu:master","ref":"master","sha":"00c21e7859e2939232d8c88dc308884e8e5878df","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-06-06T03:51:06Z","pushed_at":"2016-06-05T20:55:23Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":290208,"stargazers_count":2268,"watchers_count":2268,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":131,"forks":667,"open_issues":131,"watchers":2268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3881"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3881"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3881/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3881/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d43c893571895dcd99d083adc8cf83b550a424fa"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":10,"review_comments":4,"commits":25,"additions":18702,"deletions":29,"changed_files":246}}
{"actor":{"display_login":"WilliamLCobb"}}