{"action":"closed","number":1018,"pull_request":{"url":"https://api.github.com/repos/alphagov/frontend/pulls/1018","id":87133197,"html_url":"https://github.com/alphagov/frontend/pull/1018","diff_url":"https://github.com/alphagov/frontend/pull/1018.diff","patch_url":"https://github.com/alphagov/frontend/pull/1018.patch","issue_url":"https://api.github.com/repos/alphagov/frontend/issues/1018","number":1018,"state":"closed","locked":false,"title":"Correct some linting issues","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"This application is currently configured to only test changed files on lint. When doing large scale refactoring (like #1004) this causes a lot of noise, since you're forced to change a lot of unrelated code. It makes the diff hard to read and is fairly frustrating, since linting runs before tests when running rake.\r\n\r\nOriginally I intended to fix all the linting warnings in this app. However, it's so creaky at some places that Rubocop's autocorrect will actually break the tests.\r\n\r\nInstead, this adds a .rubocop.yml file (generated with --auto-gen-config). It allows us to fix some issues selectively, while not introducing any more.\r\n","created_at":"2016-09-28T14:38:08Z","updated_at":"2016-09-29T09:07:10Z","closed_at":"2016-09-29T09:07:10Z","merged_at":"2016-09-29T09:07:10Z","merge_commit_sha":"2ffd7f7a05f4d6c0831e02b79a846980f5818e94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/frontend/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/alphagov/frontend/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/alphagov/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/frontend/issues/1018/comments","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/f7ebc49d157d57529fde1577e6038e6843ec51f0","head":{"label":"alphagov:fix-all-linting-issues","ref":"fix-all-linting-issues","sha":"f7ebc49d157d57529fde1577e6038e6843ec51f0","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2331534,"name":"frontend","full_name":"alphagov/frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/frontend","description":"Serves mainstream formats, the homepage, and search on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/frontend","forks_url":"https://api.github.com/repos/alphagov/frontend/forks","keys_url":"https://api.github.com/repos/alphagov/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/frontend/events","assignees_url":"https://api.github.com/repos/alphagov/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/frontend/merges","archive_url":"https://api.github.com/repos/alphagov/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/frontend/deployments","created_at":"2011-09-06T00:16:08Z","updated_at":"2016-09-09T14:41:37Z","pushed_at":"2016-09-29T09:07:10Z","git_url":"git://github.com/alphagov/frontend.git","ssh_url":"git@github.com:alphagov/frontend.git","clone_url":"https://github.com/alphagov/frontend.git","svn_url":"https://github.com/alphagov/frontend","homepage":"https://www.gov.uk/","size":28656,"stargazers_count":209,"watchers_count":209,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":2,"forks":46,"open_issues":2,"watchers":209,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"ad68ad6c3b7116b932e8af561904a36c1e5d049e","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2331534,"name":"frontend","full_name":"alphagov/frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/frontend","description":"Serves mainstream formats, the homepage, and search on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/frontend","forks_url":"https://api.github.com/repos/alphagov/frontend/forks","keys_url":"https://api.github.com/repos/alphagov/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/frontend/events","assignees_url":"https://api.github.com/repos/alphagov/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/frontend/merges","archive_url":"https://api.github.com/repos/alphagov/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/frontend/deployments","created_at":"2011-09-06T00:16:08Z","updated_at":"2016-09-09T14:41:37Z","pushed_at":"2016-09-29T09:07:10Z","git_url":"git://github.com/alphagov/frontend.git","ssh_url":"git@github.com:alphagov/frontend.git","clone_url":"https://github.com/alphagov/frontend.git","svn_url":"https://github.com/alphagov/frontend","homepage":"https://www.gov.uk/","size":28656,"stargazers_count":209,"watchers_count":209,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":2,"forks":46,"open_issues":2,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1018"},"html":{"href":"https://github.com/alphagov/frontend/pull/1018"},"issue":{"href":"https://api.github.com/repos/alphagov/frontend/issues/1018"},"comments":{"href":"https://api.github.com/repos/alphagov/frontend/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/frontend/statuses/f7ebc49d157d57529fde1577e6038e6843ec51f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MatMoore","id":87579,"avatar_url":"https://avatars.githubusercontent.com/u/87579?v=3","gravatar_id":"","url":"https://api.github.com/users/MatMoore","html_url":"https://github.com/MatMoore","followers_url":"https://api.github.com/users/MatMoore/followers","following_url":"https://api.github.com/users/MatMoore/following{/other_user}","gists_url":"https://api.github.com/users/MatMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/MatMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatMoore/subscriptions","organizations_url":"https://api.github.com/users/MatMoore/orgs","repos_url":"https://api.github.com/users/MatMoore/repos","events_url":"https://api.github.com/users/MatMoore/events{/privacy}","received_events_url":"https://api.github.com/users/MatMoore/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":830,"deletions":751,"changed_files":82}}
{"actor":{"display_login":"MatMoore"}}