{"action":"created","issue":{"url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/39","repository_url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards","labels_url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/39/comments","events_url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/39/events","html_url":"https://github.com/WPTRT/WordPress-Coding-Standards/issues/39","id":167079695,"number":39,"title":"[Implement sniff] Enqueue all scripts and styles","user":{"login":"fklein-lu","id":1221942,"avatar_url":"https://avatars.githubusercontent.com/u/1221942?v=3","gravatar_id":"","url":"https://api.github.com/users/fklein-lu","html_url":"https://github.com/fklein-lu","followers_url":"https://api.github.com/users/fklein-lu/followers","following_url":"https://api.github.com/users/fklein-lu/following{/other_user}","gists_url":"https://api.github.com/users/fklein-lu/gists{/gist_id}","starred_url":"https://api.github.com/users/fklein-lu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fklein-lu/subscriptions","organizations_url":"https://api.github.com/users/fklein-lu/orgs","repos_url":"https://api.github.com/users/fklein-lu/repos","events_url":"https://api.github.com/users/fklein-lu/events{/privacy}","received_events_url":"https://api.github.com/users/fklein-lu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/labels/approved%20/%20in%20handbook","name":"approved / in handbook","color":"d93f0b"},{"url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/labels/has%20PR","name":"has PR","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-22T16:09:52Z","updated_at":"2016-07-26T19:57:53Z","closed_at":null,"body":"**Rule type:**\r\nError \r\n\r\n**Rule:**\r\n\r\n> No hard coding of scripts and styles unless a browser workaround script. Everything should be enqueued.\r\n\r\nRef: https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts\r\n\r\n**Existing Sniff:**\r\n\r\nhttps://github.com/WPTRT/WordPress-Coding-Standards/blob/feature/theme-review-sniffs/WordPress/Sniffs/WP/EnqueuedResourcesSniff.php\r\n\r\n**Theme check file covering this rule:**\r\n\r\nNone.\r\n\r\n**Decision needed:**\r\n\r\nThe sniff looks for scripts and stylesheets included in the templates (via `<script src=[...]>` and `<link rel=[...]>`).\r\n\r\nThe rule makes an exception for browser workaround scripts.\r\n\r\n**Request for decision**:\r\n\r\nGiven that since WordPress 4.2, `wp_script_add_data()` exists, and browser workaround scripts now can be enqueued (see [TwentySixteen](https://github.com/WordPress/twentysixteen/blob/master/functions.php#L267)), should the rule be changed to encompass _all_ scripts and stylesheets?"},"comment":{"url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/comments/235386001","html_url":"https://github.com/WPTRT/WordPress-Coding-Standards/issues/39#issuecomment-235386001","issue_url":"https://api.github.com/repos/WPTRT/WordPress-Coding-Standards/issues/39","id":235386001,"user":{"login":"grappler","id":1785641,"avatar_url":"https://avatars.githubusercontent.com/u/1785641?v=3","gravatar_id":"","url":"https://api.github.com/users/grappler","html_url":"https://github.com/grappler","followers_url":"https://api.github.com/users/grappler/followers","following_url":"https://api.github.com/users/grappler/following{/other_user}","gists_url":"https://api.github.com/users/grappler/gists{/gist_id}","starred_url":"https://api.github.com/users/grappler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grappler/subscriptions","organizations_url":"https://api.github.com/users/grappler/orgs","repos_url":"https://api.github.com/users/grappler/repos","events_url":"https://api.github.com/users/grappler/events{/privacy}","received_events_url":"https://api.github.com/users/grappler/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T19:57:53Z","updated_at":"2016-07-26T19:57:53Z","body":"The requirement will be changed once WP 4.6 is released. https://make.wordpress.org/themes/2016/07/26/meeting-notes-for-2016-july-26/"}}
{"actor":{"display_login":"grappler"}}