{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic/issues/9530","repository_url":"https://api.github.com/repos/driftyco/ionic","labels_url":"https://api.github.com/repos/driftyco/ionic/issues/9530/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/9530/comments","events_url":"https://api.github.com/repos/driftyco/ionic/issues/9530/events","html_url":"https://github.com/driftyco/ionic/pull/9530","id":193993891,"number":9530,"title":"fix(virtual-scroll): replace implicit any's","user":{"login":"Manduro","id":2545042,"avatar_url":"https://avatars.githubusercontent.com/u/2545042?v=3","gravatar_id":"","url":"https://api.github.com/users/Manduro","html_url":"https://github.com/Manduro","followers_url":"https://api.github.com/users/Manduro/followers","following_url":"https://api.github.com/users/Manduro/following{/other_user}","gists_url":"https://api.github.com/users/Manduro/gists{/gist_id}","starred_url":"https://api.github.com/users/Manduro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manduro/subscriptions","organizations_url":"https://api.github.com/users/Manduro/orgs","repos_url":"https://api.github.com/users/Manduro/repos","events_url":"https://api.github.com/users/Manduro/events{/privacy}","received_events_url":"https://api.github.com/users/Manduro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-07T09:07:53Z","updated_at":"2016-12-07T16:02:16Z","closed_at":"2016-12-07T16:02:08Z","pull_request":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/9530","html_url":"https://github.com/driftyco/ionic/pull/9530","diff_url":"https://github.com/driftyco/ionic/pull/9530.diff","patch_url":"https://github.com/driftyco/ionic/pull/9530.patch"},"body":"#### Short description of what this resolves:\r\nSame idea as #9511 from yesterday. Is it possible to have the tests for Ionic run with `noImplicitAny` to prevent this in the future?\r\n\r\nLatest nightly throws me some errors on serve.\r\n```\r\n[10:01:32]  typescript: node_modules/ionic-angular/components/virtual-scroll/virtual-util.d.ts, line: 22 \r\n[10:01:32]  typescript: node_modules/ionic-angular/components/virtual-scroll/virtual-util.d.ts, line: 25 \r\n            Call signature, which lacks return-type annotation, implicitly has an 'any' return type. \r\n\r\n      L21:  add: {\r\n      L22:      (name: string);\r\n      L23:  };\r\n\r\n            Call signature, which lacks return-type annotation, implicitly has an 'any' return type. \r\n\r\n      L24:  remove: {\r\n      L25:      (name: string);\r\n      L26:  };\r\n\r\n            Call signature, which lacks return-type annotation, implicitly has an 'any' return type. \r\n\r\n      L28:  setAttribute: {\r\n      L29:      (name: string, value: any);\r\n      L30:  };\r\n\r\n[10:01:32]  typescript: node_modules/ionic-angular/components/virtual-scroll/virtual-util.d.ts, line: 29 \r\n```\r\n\r\nI'm using `\"noImplicitAny\": true` in my `tsconfig.json` `compilerOptions`, which some other developers will probably be using as well.\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Add an explicit `void` return type\r\n\r\n**Ionic Version**: 2.0.0-rc.3-201612062256\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/driftyco/ionic/issues/comments/265487696","html_url":"https://github.com/driftyco/ionic/pull/9530#issuecomment-265487696","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/9530","id":265487696,"user":{"login":"adamdbradley","id":452425,"avatar_url":"https://avatars.githubusercontent.com/u/452425?v=3","gravatar_id":"","url":"https://api.github.com/users/adamdbradley","html_url":"https://github.com/adamdbradley","followers_url":"https://api.github.com/users/adamdbradley/followers","following_url":"https://api.github.com/users/adamdbradley/following{/other_user}","gists_url":"https://api.github.com/users/adamdbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdbradley/subscriptions","organizations_url":"https://api.github.com/users/adamdbradley/orgs","repos_url":"https://api.github.com/users/adamdbradley/repos","events_url":"https://api.github.com/users/adamdbradley/events{/privacy}","received_events_url":"https://api.github.com/users/adamdbradley/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T16:02:16Z","updated_at":"2016-12-07T16:02:16Z","body":"thanks!"}}
{"actor":{"display_login":"adamdbradley"}}