{"action":"created","issue":{"url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/4","repository_url":"https://api.github.com/repos/Zylann/godot_terrain_plugin","labels_url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/4/comments","events_url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/4/events","html_url":"https://github.com/Zylann/godot_terrain_plugin/issues/4","id":170732450,"number":4,"title":"Undo and Nil Error.","user":{"login":"suptoasty","id":16758490,"avatar_url":"https://avatars.githubusercontent.com/u/16758490?v=3","gravatar_id":"","url":"https://api.github.com/users/suptoasty","html_url":"https://github.com/suptoasty","followers_url":"https://api.github.com/users/suptoasty/followers","following_url":"https://api.github.com/users/suptoasty/following{/other_user}","gists_url":"https://api.github.com/users/suptoasty/gists{/gist_id}","starred_url":"https://api.github.com/users/suptoasty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suptoasty/subscriptions","organizations_url":"https://api.github.com/users/suptoasty/orgs","repos_url":"https://api.github.com/users/suptoasty/repos","events_url":"https://api.github.com/users/suptoasty/events{/privacy}","received_events_url":"https://api.github.com/users/suptoasty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-11T19:59:27Z","updated_at":"2016-08-12T01:28:37Z","closed_at":null,"body":"Hi, @Zylann . I was testing your plug-in and found that when I hit the Undo Shortcut keys too many times, that the Terrain node (which was the root node of the scene) was deleted, but failed to free the actual node from the scene view. I don't know if the node being freed by the Undo command is a flaw in the new plug-in system or not, so I thought I would post here to notify you before going to the Godot git page. And I would recommend checks using weakref or something to fix the Nil instance errors, if possible.\r\n\r\nLinux Mint 18, Godot Engine 2.1\r\n\r\nSteps to reproduce:\r\n   1. Start A New Scene\r\n   2. Make A Terrain Node The Root\r\n   3. Possible Set A Size For The Node\r\n   4. Hit The Undo Command A Few Times\r\n\r\nHere is a screenshot of what happend.\r\n\r\n![screenshot at 2016-08-11 14-51-47](https://cloud.githubusercontent.com/assets/16758490/17602657/30e27b24-5fd3-11e6-95ef-0a39aa0dc31b.png)\r\n\r\nPS:\r\n    Love the plug-in so far, it is fast and easy to use. I love that It gives more control to developers than the old method of sketching a map in 'your preferred imaging tools here' and makes the process fun. Can't wait for this to mature into something along the lines of world machine or unity's terrain system (if you are willing to take it that far)."},"comment":{"url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/comments/239340317","html_url":"https://github.com/Zylann/godot_terrain_plugin/issues/4#issuecomment-239340317","issue_url":"https://api.github.com/repos/Zylann/godot_terrain_plugin/issues/4","id":239340317,"user":{"login":"suptoasty","id":16758490,"avatar_url":"https://avatars.githubusercontent.com/u/16758490?v=3","gravatar_id":"","url":"https://api.github.com/users/suptoasty","html_url":"https://github.com/suptoasty","followers_url":"https://api.github.com/users/suptoasty/followers","following_url":"https://api.github.com/users/suptoasty/following{/other_user}","gists_url":"https://api.github.com/users/suptoasty/gists{/gist_id}","starred_url":"https://api.github.com/users/suptoasty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suptoasty/subscriptions","organizations_url":"https://api.github.com/users/suptoasty/orgs","repos_url":"https://api.github.com/users/suptoasty/repos","events_url":"https://api.github.com/users/suptoasty/events{/privacy}","received_events_url":"https://api.github.com/users/suptoasty/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T01:28:37Z","updated_at":"2016-08-12T01:28:37Z","body":"I have not come across any errors again. Hopefully, the errors I got were some freak accident. I have gotten errors in things like the ogre3d rendering engine, that disappeared after another run of the project I was using it for, so fingers crossed :four_leaf_clover: ."}}
{"actor":{"display_login":"suptoasty"}}