{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21326","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21326/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21326/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21326/events","html_url":"https://github.com/NixOS/nixpkgs/pull/21326","id":196819582,"number":21326,"title":"docker: update service units from upstream","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-21T00:55:21Z","updated_at":"2016-12-21T08:21:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21326","html_url":"https://github.com/NixOS/nixpkgs/pull/21326","diff_url":"https://github.com/NixOS/nixpkgs/pull/21326.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/21326.patch"},"body":"All the new options in detail:\r\n\r\nEnable docker in multi-user.target make container created with restart=always\r\nto start. We still want socket activation as it decouples dependencies between\r\nthe existing of /var/run/docker.sock and the docker daemon. This means that\r\nservices can rely on the availability of this socket. Fixes #11478 #21303\r\n\r\n  wantedBy = [\"multi-user.target\"];\r\n\r\nThis allows us to remove the postStart hack, as docker reports on its own when\r\nit is ready.\r\n\r\n  Type=notify\r\n\r\nThe following will set unset some limits because overhead in kernel's ressource\r\naccounting was observed. Note that these limit only apply to containerd.\r\nContainers will have their own limit set.\r\n\r\n  LimitNPROC=infinity\r\n  LimitCORE=infinity\r\n  TasksMax=infinity\r\n\r\nUpgrades may require schema migrations. This can delay the startup of dockerd.\r\n\r\n  TimeoutStartSec=0\r\n\r\nAllows docker to create its own cgroup subhierarchy to apply ressource limits on\r\ncontainers.\r\n\r\n  Delegate=true\r\n\r\nWhen dockerd is killed, container should be not affected to allow\r\n`live restore` to work.\r\n\r\n  KillMode=process\r\n\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/268463482","html_url":"https://github.com/NixOS/nixpkgs/pull/21326#issuecomment-268463482","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21326","id":268463482,"user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T08:21:04Z","updated_at":"2016-12-21T08:21:04Z","body":"A future todo, would be to look into user namespaces: https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-user-namespace-options"}}
{"actor":{"display_login":"Mic92"}}