{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/49852636","id":49852636,"diff_hunk":"@@ -58,13 +58,16 @@ VideoPlayer.prototype = {\n   },\n \n   invokeControls: function() {\n-    if (!this.visibleControls()) {\n-      this.rootElement.tap();\n-\n+    if(this.visibleControls()) {\n+      this.rootElement.tap(0, 0);","path":"apps/system/test/marionette/lib/video_player.js","position":8,"original_position":8,"commit_id":"f4593e03da5dcabcd630929438104fd6ebb41a31","original_commit_id":"f4593e03da5dcabcd630929438104fd6ebb41a31","user":{"login":"mikehenrty","id":635365,"avatar_url":"https://avatars.githubusercontent.com/u/635365?v=3","gravatar_id":"","url":"https://api.github.com/users/mikehenrty","html_url":"https://github.com/mikehenrty","followers_url":"https://api.github.com/users/mikehenrty/followers","following_url":"https://api.github.com/users/mikehenrty/following{/other_user}","gists_url":"https://api.github.com/users/mikehenrty/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehenrty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehenrty/subscriptions","organizations_url":"https://api.github.com/users/mikehenrty/orgs","repos_url":"https://api.github.com/users/mikehenrty/repos","events_url":"https://api.github.com/users/mikehenrty/events{/privacy}","received_events_url":"https://api.github.com/users/mikehenrty/received_events","type":"User","site_admin":false},"body":"Yeah again the problem here is `visibleControls()` doesn't tell us if the controls are about to disappear, but the problem is this tap can be a toggle and if controls are visible, then disappear, and then we tap, we can get in a state where we just activated the controls. But this is a minefield, so I would say we do whatever makes the test the most robust.","created_at":"2016-01-15T13:29:06Z","updated_at":"2016-01-15T13:29:06Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/33870#discussion_r49852636","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/49852636"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33870#discussion_r49852636"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870","id":56065042,"html_url":"https://github.com/mozilla-b2g/gaia/pull/33870","diff_url":"https://github.com/mozilla-b2g/gaia/pull/33870.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/33870.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33870","number":33870,"state":"open","locked":false,"title":"Bug 1235881 - Changed invokeControls, added some delay and a longer test video R=mhenretty","user":{"login":"tilmankamp","id":5991088,"avatar_url":"https://avatars.githubusercontent.com/u/5991088?v=3","gravatar_id":"","url":"https://api.github.com/users/tilmankamp","html_url":"https://github.com/tilmankamp","followers_url":"https://api.github.com/users/tilmankamp/followers","following_url":"https://api.github.com/users/tilmankamp/following{/other_user}","gists_url":"https://api.github.com/users/tilmankamp/gists{/gist_id}","starred_url":"https://api.github.com/users/tilmankamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilmankamp/subscriptions","organizations_url":"https://api.github.com/users/tilmankamp/orgs","repos_url":"https://api.github.com/users/tilmankamp/repos","events_url":"https://api.github.com/users/tilmankamp/events{/privacy}","received_events_url":"https://api.github.com/users/tilmankamp/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-14T17:14:25Z","updated_at":"2016-01-15T13:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1a9b09d8c4e6919a464ef9aae412b9a8ffe516","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33870/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f4593e03da5dcabcd630929438104fd6ebb41a31","head":{"label":"tilmankamp:u1235881","ref":"u1235881","sha":"f4593e03da5dcabcd630929438104fd6ebb41a31","user":{"login":"tilmankamp","id":5991088,"avatar_url":"https://avatars.githubusercontent.com/u/5991088?v=3","gravatar_id":"","url":"https://api.github.com/users/tilmankamp","html_url":"https://github.com/tilmankamp","followers_url":"https://api.github.com/users/tilmankamp/followers","following_url":"https://api.github.com/users/tilmankamp/following{/other_user}","gists_url":"https://api.github.com/users/tilmankamp/gists{/gist_id}","starred_url":"https://api.github.com/users/tilmankamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilmankamp/subscriptions","organizations_url":"https://api.github.com/users/tilmankamp/orgs","repos_url":"https://api.github.com/users/tilmankamp/repos","events_url":"https://api.github.com/users/tilmankamp/events{/privacy}","received_events_url":"https://api.github.com/users/tilmankamp/received_events","type":"User","site_admin":false},"repo":{"id":48997244,"name":"gaia","full_name":"tilmankamp/gaia","owner":{"login":"tilmankamp","id":5991088,"avatar_url":"https://avatars.githubusercontent.com/u/5991088?v=3","gravatar_id":"","url":"https://api.github.com/users/tilmankamp","html_url":"https://github.com/tilmankamp","followers_url":"https://api.github.com/users/tilmankamp/followers","following_url":"https://api.github.com/users/tilmankamp/following{/other_user}","gists_url":"https://api.github.com/users/tilmankamp/gists{/gist_id}","starred_url":"https://api.github.com/users/tilmankamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilmankamp/subscriptions","organizations_url":"https://api.github.com/users/tilmankamp/orgs","repos_url":"https://api.github.com/users/tilmankamp/repos","events_url":"https://api.github.com/users/tilmankamp/events{/privacy}","received_events_url":"https://api.github.com/users/tilmankamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tilmankamp/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/tilmankamp/gaia","forks_url":"https://api.github.com/repos/tilmankamp/gaia/forks","keys_url":"https://api.github.com/repos/tilmankamp/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilmankamp/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilmankamp/gaia/teams","hooks_url":"https://api.github.com/repos/tilmankamp/gaia/hooks","issue_events_url":"https://api.github.com/repos/tilmankamp/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/tilmankamp/gaia/events","assignees_url":"https://api.github.com/repos/tilmankamp/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/tilmankamp/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/tilmankamp/gaia/tags","blobs_url":"https://api.github.com/repos/tilmankamp/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilmankamp/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilmankamp/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilmankamp/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilmankamp/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/tilmankamp/gaia/languages","stargazers_url":"https://api.github.com/repos/tilmankamp/gaia/stargazers","contributors_url":"https://api.github.com/repos/tilmankamp/gaia/contributors","subscribers_url":"https://api.github.com/repos/tilmankamp/gaia/subscribers","subscription_url":"https://api.github.com/repos/tilmankamp/gaia/subscription","commits_url":"https://api.github.com/repos/tilmankamp/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilmankamp/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilmankamp/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilmankamp/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilmankamp/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/tilmankamp/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilmankamp/gaia/merges","archive_url":"https://api.github.com/repos/tilmankamp/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilmankamp/gaia/downloads","issues_url":"https://api.github.com/repos/tilmankamp/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/tilmankamp/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/tilmankamp/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/tilmankamp/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilmankamp/gaia/labels{/name}","releases_url":"https://api.github.com/repos/tilmankamp/gaia/releases{/id}","created_at":"2016-01-04T13:00:13Z","updated_at":"2016-01-11T16:01:38Z","pushed_at":"2016-01-15T11:05:56Z","git_url":"git://github.com/tilmankamp/gaia.git","ssh_url":"git@github.com:tilmankamp/gaia.git","clone_url":"https://github.com/tilmankamp/gaia.git","svn_url":"https://github.com/tilmankamp/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1003200,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ddf58ac88425479f729b244c69b35961414380f9","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2016-01-15T11:54:32Z","pushed_at":"2016-01-15T13:21:51Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1196162,"stargazers_count":2027,"watchers_count":2027,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2577,"mirror_url":null,"open_issues_count":1305,"forks":2577,"open_issues":1305,"watchers":2027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33870"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33870"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33870/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33870/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f4593e03da5dcabcd630929438104fd6ebb41a31"}}}}