{"action":"created","issue":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/493","repository_url":"https://api.github.com/repos/vert-x3/vertx-web","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/493/labels{/name}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/493/comments","events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/493/events","html_url":"https://github.com/vert-x3/vertx-web/pull/493","id":194918254,"number":493,"title":"Vert.x Web Client - fixes #492","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"labels":[{"id":234665676,"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/to%20review","name":"to review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-12T08:45:30Z","updated_at":"2016-12-14T08:56:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/493","html_url":"https://github.com/vert-x3/vertx-web/pull/493","diff_url":"https://github.com/vert-x3/vertx-web/pull/493.diff","patch_url":"https://github.com/vert-x3/vertx-web/pull/493.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments/266978797","html_url":"https://github.com/vert-x3/vertx-web/pull/493#issuecomment-266978797","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/493","id":266978797,"user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T08:56:48Z","updated_at":"2016-12-14T08:56:48Z","body":"So you will update the doc?\n\n2016-12-14 9:25 GMT+01:00 Julien Viet <notifications@github.com>:\n\n> *@vietj* commented on this pull request.\n> ------------------------------\n>\n> In vertx-web-client/src/main/java/io/vertx/webclient/impl/\n> HttpRequestImpl.java <https://github.com/vert-x3/vertx-web/pull/493>:\n>\n> > +import io.vertx.core.http.HttpMethod;\n> +import io.vertx.core.json.Json;\n> +import io.vertx.core.json.JsonObject;\n> +import io.vertx.core.streams.Pump;\n> +import io.vertx.core.streams.ReadStream;\n> +import io.vertx.webclient.BodyCodec;\n> +import io.vertx.webclient.HttpRequest;\n> +import io.vertx.webclient.HttpResponse;\n> +import io.vertx.webclient.spi.BodyStream;\n> +\n> +import java.util.Map;\n> +\n> +/**\n> + * @author <a href=\"mailto:julien@julienviet.com\">Julien Viet</a>\n> + */\n> +class HttpRequestImpl implements HttpRequest {\n>\n> the request is mutable for its configuration state (headers, params) but\n> it does not have any state related to the actual performed request, so it\n> can be used multiple times. The dev decides to update the state and can\n> eventually call request.copy() to copy the state and make a new request\n> based on an existing one.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/vert-x3/vertx-web/pull/493>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABbltshTS0dKwK_4IWZizhfCwid2i13qks5rH6gXgaJpZM4LKTXp>\n> .\n>\n"}}
{"actor":{"display_login":"tsegismont"}}