{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/81393500","pull_request_review_id":2378631,"id":81393500,"diff_hunk":"@@ -95,4 +97,20 @@ class LibraryService (protected val userInfo: UserInfo, val rawlsDAO: RawlsDAO)(\n       }\n     }\n   }\n+\n+  def setWorkspaceIsPublished(ns: String, name: String, value: Boolean): Future[PerRequestMessage] = {\n+    rawlsDAO.getWorkspace(ns, name) flatMap { workspaceResponse =>\n+      // verify owner on workspace\n+      if (!workspaceResponse.accessLevel.contains(\"OWNER\")) {\n+        Future(RequestCompleteWithErrorReport(Forbidden, \"must be an owner\"))\n+      } else {\n+        val operations: Seq[AttributeUpdateOperation] = Seq()\n+        // either add or remove the library attribute\n+        if (value) operations :+ AddUpdateAttribute(\"library\", AttributeString(\"published\"))\n+        else operations :+ RemoveAttribute(\"library\")","path":"src/main/scala/org/broadinstitute/dsde/firecloud/service/LibraryService.scala","position":30,"original_position":30,"commit_id":"33d45d7a42184aa821131e6f6ea5124767084e9c","original_commit_id":"33d45d7a42184aa821131e6f6ea5124767084e9c","user":{"login":"skwalker","id":4933056,"avatar_url":"https://avatars.githubusercontent.com/u/4933056?v=3","gravatar_id":"","url":"https://api.github.com/users/skwalker","html_url":"https://github.com/skwalker","followers_url":"https://api.github.com/users/skwalker/followers","following_url":"https://api.github.com/users/skwalker/following{/other_user}","gists_url":"https://api.github.com/users/skwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/skwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwalker/subscriptions","organizations_url":"https://api.github.com/users/skwalker/orgs","repos_url":"https://api.github.com/users/skwalker/repos","events_url":"https://api.github.com/users/skwalker/events{/privacy}","received_events_url":"https://api.github.com/users/skwalker/received_events","type":"User","site_admin":false},"body":"Creating one seq instead of doing it twice makes sense, thanks!\r\n\r\nI think true/false sounds better to use for this case (especially if it's just a POST/DELETE with no additional parameters). \r\nShould there be a ticket for supporting boolean attributes?","created_at":"2016-09-30T18:31:39Z","updated_at":"2016-09-30T18:31:39Z","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/257#discussion_r81393500","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/81393500"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/257#discussion_r81393500"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257","id":87528773,"html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/257","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/257.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/257.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/257","number":257,"state":"open","locked":false,"title":"GAWB-1057:  add publish endpoint to orchestration","user":{"login":"skwalker","id":4933056,"avatar_url":"https://avatars.githubusercontent.com/u/4933056?v=3","gravatar_id":"","url":"https://api.github.com/users/skwalker","html_url":"https://github.com/skwalker","followers_url":"https://api.github.com/users/skwalker/followers","following_url":"https://api.github.com/users/skwalker/following{/other_user}","gists_url":"https://api.github.com/users/skwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/skwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwalker/subscriptions","organizations_url":"https://api.github.com/users/skwalker/orgs","repos_url":"https://api.github.com/users/skwalker/repos","events_url":"https://api.github.com/users/skwalker/events{/privacy}","received_events_url":"https://api.github.com/users/skwalker/received_events","type":"User","site_admin":false},"body":"- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Make sure Swagger is updated if API changes\r\n- [ ] **Submitter**: If updating admin endpoints, also update [firecloud-admin-cli](https://github.com/broadinstitute/firecloud-admin-cli)\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * Add notes on what you've tested\r\n- [ ] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [ ] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [ ] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [ ] Tell the tech lead (TL) that the PR exists if they wants to look at it\r\n- [ ] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n","created_at":"2016-09-30T16:52:12Z","updated_at":"2016-09-30T18:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5c7740ebf7b4706b4ee4dda435b5cc984cec82f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/257/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/33d45d7a42184aa821131e6f6ea5124767084e9c","head":{"label":"broadinstitute:skw_1057","ref":"skw_1057","sha":"33d45d7a42184aa821131e6f6ea5124767084e9c","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-09-28T07:29:16Z","pushed_at":"2016-09-30T17:50:31Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":776,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":7,"default_branch":"develop"}},"base":{"label":"broadinstitute:da_GAWB-1081_libraryAttributes","ref":"da_GAWB-1081_libraryAttributes","sha":"bbb378bbd88b1d046a07c20e89db4041dbb70e14","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/deployments","created_at":"2015-06-11T16:26:34Z","updated_at":"2016-09-28T07:29:16Z","pushed_at":"2016-09-30T17:50:31Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":776,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/257"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/257"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/33d45d7a42184aa821131e6f6ea5124767084e9c"}}}}
{"actor":{"display_login":"skwalker"}}