{"action":"created","issue":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2728","repository_url":"https://api.github.com/repos/sandstorm-io/sandstorm","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2728/labels{/name}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2728/comments","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2728/events","html_url":"https://github.com/sandstorm-io/sandstorm/pull/2728","id":187203070,"number":2728,"title":"Keep grains alive if they have recent API session activity.","user":{"login":"dwrensha","id":495768,"avatar_url":"https://avatars.githubusercontent.com/u/495768?v=3","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-03T22:04:36Z","updated_at":"2016-11-04T18:27:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2728","html_url":"https://github.com/sandstorm-io/sandstorm/pull/2728","diff_url":"https://github.com/sandstorm-io/sandstorm/pull/2728.diff","patch_url":"https://github.com/sandstorm-io/sandstorm/pull/2728.patch"},"body":"We already have logic that periodically culls the proxy objects being used by API sessions. This patch adds a call to `proxy.supervisor.keepAlive()` for each proxy that we decide not to clean up. It also accounts for requests and responses that are streaming.\r\n\r\nThis handles the most urgent pieces of #2462 and #2218."},"comment":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments/258511589","html_url":"https://github.com/sandstorm-io/sandstorm/pull/2728#issuecomment-258511589","issue_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2728","id":258511589,"user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T18:27:32Z","updated_at":"2016-11-04T18:27:32Z","body":"The code looks good but this is a somewhat-scary change, in that a bug could mean that we leak grains. Any thoughts on how to test this / how to roll it out safely?"}}
{"actor":{"display_login":"kentonv"}}