{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/62707855","id":62707855,"diff_hunk":"@@ -443,8 +476,9 @@ const luaL_reg LuaItemStack::methods[] = {\n \tluamethod(LuaItemStack, set_count),\n \tluamethod(LuaItemStack, get_wear),\n \tluamethod(LuaItemStack, set_wear),\n-\tluamethod(LuaItemStack, get_metadata),\n-\tluamethod(LuaItemStack, set_metadata),\n+\tluamethod(LuaItemStack, get_meta),\n+\tluamethod(LuaItemStack, get_metadata),//legacy\n+\tluamethod(LuaItemStack, set_metadata),//legacy","path":"src/script/lua_api/l_item.cpp","position":92,"original_position":92,"commit_id":"46bc51e4b5c08b4505739a6266368c883cc8bbe4","original_commit_id":"46bc51e4b5c08b4505739a6266368c883cc8bbe4","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"body":"Spaces and capialization: `...),  // Legacy`.","created_at":"2016-05-10T16:44:57Z","updated_at":"2016-05-10T16:44:57Z","html_url":"https://github.com/minetest/minetest/pull/3984#discussion_r62707855","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3984","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/62707855"},"html":{"href":"https://github.com/minetest/minetest/pull/3984#discussion_r62707855"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3984"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3984","id":65918047,"html_url":"https://github.com/minetest/minetest/pull/3984","diff_url":"https://github.com/minetest/minetest/pull/3984.diff","patch_url":"https://github.com/minetest/minetest/pull/3984.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3984","number":3984,"state":"open","locked":false,"title":"Turn item metadata into a key-value store while keeping compatibility to the old interface via the empty string field","user":{"login":"orwell96","id":13201701,"avatar_url":"https://avatars.githubusercontent.com/u/13201701?v=3","gravatar_id":"","url":"https://api.github.com/users/orwell96","html_url":"https://github.com/orwell96","followers_url":"https://api.github.com/users/orwell96/followers","following_url":"https://api.github.com/users/orwell96/following{/other_user}","gists_url":"https://api.github.com/users/orwell96/gists{/gist_id}","starred_url":"https://api.github.com/users/orwell96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orwell96/subscriptions","organizations_url":"https://api.github.com/users/orwell96/orgs","repos_url":"https://api.github.com/users/orwell96/repos","events_url":"https://api.github.com/users/orwell96/events{/privacy}","received_events_url":"https://api.github.com/users/orwell96/received_events","type":"User","site_admin":false},"body":"This is the implementation of ideas presented in #3449. The key-value store works the same way it did for node metadata, except without an inventory. Metadata are serialized in a strange but working way.\r\nThe change works as expected, is documented in lua_api.txt and has been tested.\r\nNext steps:\r\n- Add uses for metadata fields (description, damage groups, image...)\r\n- Is the client notified when metadata change? (write something into ItemStackMetaRef::reportMetadataChange() )","created_at":"2016-04-10T18:16:21Z","updated_at":"2016-05-10T16:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6b51e8b29d82b9203129d458bcdc2ed0da5c0e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3984/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3984/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3984/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/46bc51e4b5c08b4505739a6266368c883cc8bbe4","head":{"label":"orwell96:master","ref":"master","sha":"46bc51e4b5c08b4505739a6266368c883cc8bbe4","user":{"login":"orwell96","id":13201701,"avatar_url":"https://avatars.githubusercontent.com/u/13201701?v=3","gravatar_id":"","url":"https://api.github.com/users/orwell96","html_url":"https://github.com/orwell96","followers_url":"https://api.github.com/users/orwell96/followers","following_url":"https://api.github.com/users/orwell96/following{/other_user}","gists_url":"https://api.github.com/users/orwell96/gists{/gist_id}","starred_url":"https://api.github.com/users/orwell96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orwell96/subscriptions","organizations_url":"https://api.github.com/users/orwell96/orgs","repos_url":"https://api.github.com/users/orwell96/repos","events_url":"https://api.github.com/users/orwell96/events{/privacy}","received_events_url":"https://api.github.com/users/orwell96/received_events","type":"User","site_admin":false},"repo":{"id":55886974,"name":"minetest","full_name":"orwell96/minetest","owner":{"login":"orwell96","id":13201701,"avatar_url":"https://avatars.githubusercontent.com/u/13201701?v=3","gravatar_id":"","url":"https://api.github.com/users/orwell96","html_url":"https://github.com/orwell96","followers_url":"https://api.github.com/users/orwell96/followers","following_url":"https://api.github.com/users/orwell96/following{/other_user}","gists_url":"https://api.github.com/users/orwell96/gists{/gist_id}","starred_url":"https://api.github.com/users/orwell96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orwell96/subscriptions","organizations_url":"https://api.github.com/users/orwell96/orgs","repos_url":"https://api.github.com/users/orwell96/repos","events_url":"https://api.github.com/users/orwell96/events{/privacy}","received_events_url":"https://api.github.com/users/orwell96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orwell96/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/orwell96/minetest","forks_url":"https://api.github.com/repos/orwell96/minetest/forks","keys_url":"https://api.github.com/repos/orwell96/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orwell96/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orwell96/minetest/teams","hooks_url":"https://api.github.com/repos/orwell96/minetest/hooks","issue_events_url":"https://api.github.com/repos/orwell96/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/orwell96/minetest/events","assignees_url":"https://api.github.com/repos/orwell96/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/orwell96/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/orwell96/minetest/tags","blobs_url":"https://api.github.com/repos/orwell96/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orwell96/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orwell96/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/orwell96/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orwell96/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/orwell96/minetest/languages","stargazers_url":"https://api.github.com/repos/orwell96/minetest/stargazers","contributors_url":"https://api.github.com/repos/orwell96/minetest/contributors","subscribers_url":"https://api.github.com/repos/orwell96/minetest/subscribers","subscription_url":"https://api.github.com/repos/orwell96/minetest/subscription","commits_url":"https://api.github.com/repos/orwell96/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/orwell96/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/orwell96/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/orwell96/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/orwell96/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/orwell96/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orwell96/minetest/merges","archive_url":"https://api.github.com/repos/orwell96/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orwell96/minetest/downloads","issues_url":"https://api.github.com/repos/orwell96/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/orwell96/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/orwell96/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/orwell96/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orwell96/minetest/labels{/name}","releases_url":"https://api.github.com/repos/orwell96/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/orwell96/minetest/deployments","created_at":"2016-04-10T07:46:42Z","updated_at":"2016-04-10T07:46:47Z","pushed_at":"2016-04-20T20:13:56Z","git_url":"git://github.com/orwell96/minetest.git","ssh_url":"git@github.com:orwell96/minetest.git","clone_url":"https://github.com/orwell96/minetest.git","svn_url":"https://github.com/orwell96/minetest","homepage":"http://minetest.net/","size":47276,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"4d9dbceb39324ee0aef6520b8193fa093470cc01","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-05-10T10:15:54Z","pushed_at":"2016-05-10T01:22:47Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":113955,"stargazers_count":1979,"watchers_count":1979,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":630,"mirror_url":null,"open_issues_count":739,"forks":630,"open_issues":739,"watchers":1979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3984"},"html":{"href":"https://github.com/minetest/minetest/pull/3984"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3984"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3984/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3984/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3984/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/46bc51e4b5c08b4505739a6266368c883cc8bbe4"}}}}