{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/75600166","id":75600166,"diff_hunk":"@@ -32,7 +32,7 @@\n   end\n \n   it \"#process_conditions\" do\n-    processed = LiveMetric.process_conditions(conditions)\n+    processed = LiveMetric.process_conditions([conditions])","path":"spec/models/live_metric_spec.rb","position":null,"original_position":5,"commit_id":"39cdbb48fc39fdd66dbaf2bd7cccee3f18b92cc9","original_commit_id":"f3487658196121420be7a7c3e4a25de42ca2a6c4","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"Adressed.\r\nparse_conditions works over raw_conditions and process_conditions on the wrapped one.\r\nThis is updated on the test.","created_at":"2016-08-21T17:58:55Z","updated_at":"2016-08-21T17:58:55Z","html_url":"https://github.com/ManageIQ/manageiq/pull/10570#discussion_r75600166","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/75600166"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10570#discussion_r75600166"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570","id":81729060,"html_url":"https://github.com/ManageIQ/manageiq/pull/10570","diff_url":"https://github.com/ManageIQ/manageiq/pull/10570.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10570.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10570","number":10570,"state":"open","locked":false,"title":"Adjust LiveMetric conditions parsing","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"Fix needed to resolve https://github.com/ManageIQ/manageiq/issues/10087.\r\nAfter changes on AAArM conditions are wrapped into an array that needs minor adjustment on live_metrics side.\r\n","created_at":"2016-08-17T22:34:49Z","updated_at":"2016-08-21T17:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcaa5c8ed3c2b98f7382947757c0c543fff36886","assignee":{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"assignees":[{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10570/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/39cdbb48fc39fdd66dbaf2bd7cccee3f18b92cc9","head":{"label":"lucasponce:fix-livemetrics-change-conditions-format","ref":"fix-livemetrics-change-conditions-format","sha":"39cdbb48fc39fdd66dbaf2bd7cccee3f18b92cc9","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":52009210,"name":"manageiq","full_name":"lucasponce/manageiq","owner":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasponce/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/lucasponce/manageiq","forks_url":"https://api.github.com/repos/lucasponce/manageiq/forks","keys_url":"https://api.github.com/repos/lucasponce/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/manageiq/teams","hooks_url":"https://api.github.com/repos/lucasponce/manageiq/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/manageiq/events","assignees_url":"https://api.github.com/repos/lucasponce/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/manageiq/tags","blobs_url":"https://api.github.com/repos/lucasponce/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/manageiq/languages","stargazers_url":"https://api.github.com/repos/lucasponce/manageiq/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/manageiq/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/manageiq/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/manageiq/subscription","commits_url":"https://api.github.com/repos/lucasponce/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/manageiq/merges","archive_url":"https://api.github.com/repos/lucasponce/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/manageiq/downloads","issues_url":"https://api.github.com/repos/lucasponce/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/lucasponce/manageiq/deployments","created_at":"2016-02-18T13:31:38Z","updated_at":"2016-02-18T13:31:56Z","pushed_at":"2016-08-21T17:57:57Z","git_url":"git://github.com/lucasponce/manageiq.git","ssh_url":"git@github.com:lucasponce/manageiq.git","clone_url":"https://github.com/lucasponce/manageiq.git","svn_url":"https://github.com/lucasponce/manageiq","homepage":"manageiq.org","size":149626,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a309eb6ca3f97b1167a1da4fef9e67bfd140fa6f","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-08-19T18:14:29Z","pushed_at":"2016-08-21T17:57:58Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":194462,"stargazers_count":305,"watchers_count":305,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":785,"forks":339,"open_issues":785,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10570"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10570"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10570/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10570/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/39cdbb48fc39fdd66dbaf2bd7cccee3f18b92cc9"}}}}
{"actor":{"display_login":"lucasponce"}}