{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936/events","html_url":"https://github.com/kubernetes/kubernetes/pull/28936","id":165470240,"number":28936,"title":"Allow to set permission mode bits on secrets, configmaps and downwardAPI files","user":{"login":"rata","id":70861,"avatar_url":"https://avatars.githubusercontent.com/u/70861?v=3","gravatar_id":"","url":"https://api.github.com/users/rata","html_url":"https://github.com/rata","followers_url":"https://api.github.com/users/rata/followers","following_url":"https://api.github.com/users/rata/following{/other_user}","gists_url":"https://api.github.com/users/rata/gists{/gist_id}","starred_url":"https://api.github.com/users/rata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rata/subscriptions","organizations_url":"https://api.github.com/users/rata/orgs","repos_url":"https://api.github.com/users/rata/repos","events_url":"https://api.github.com/users/rata/events{/privacy}","received_events_url":"https://api.github.com/users/rata/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000"}],"state":"open","locked":false,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false}],"milestone":null,"comments":89,"created_at":"2016-07-14T03:49:52Z","updated_at":"2016-08-16T13:36:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28936","html_url":"https://github.com/kubernetes/kubernetes/pull/28936","diff_url":"https://github.com/kubernetes/kubernetes/pull/28936.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28936.patch"},"body":"cc @thockin @pmorie \r\n\r\nHere is the first round to implement: https://github.com/kubernetes/kubernetes/pull/28733.\r\n\r\nI made two commits: one with the actual change and the other with the auto-generated code. I think it's easier to review this way, but let me know if you prefer in some other way.\r\n\r\nI haven't written any tests yet, I wanted to have a first glance and not write them till this (and the API) are more close to the \"LGTM\" :)\r\n\r\nThere are some things:\r\n * I'm not sure where to do the \"AND 0777\". I'll try to look better in the code base, but suggestions are always welcome :)\r\n * The write permission on group and others is not set when you do an `ls -l` on the running container. It does work with write permissions to the owner. Debugging seems to show that is something happening after this is correctly set on creation. Will look closer.\r\n * The default permission (when the new fields are not specified) are the same that on kubernetes v1.3\r\n * I do realize there are conflicts with master, but I think this is good enough to have a look. The conflicts is with the autog-enerated code, so the actual code is actually the same (and it takes like ~30 minutes to generate it here)\r\n * I didn't generate the docs (`generated-docs` and `generated-swagger-docs` from `hack/update-all.sh`) because my machine runs out of mem. So that's why it isn't in this first PR, will try to investigate and see why it happens.\r\n\r\nOther than that, this works fine here with some silly scripts I did to create a secret&configmap&downwardAPI, a pod and check the file permissions. Tested the \"defaultMode\" and \"mode\" for all. But of course, will write tests once this is looking fine :)\r\n\r\n\r\nThanks a lot again!\r\nRodrigo\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/28936)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/240103674","html_url":"https://github.com/kubernetes/kubernetes/pull/28936#issuecomment-240103674","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28936","id":240103674,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T13:36:55Z","updated_at":"2016-08-16T13:36:55Z","body":"GCE e2e build/test **passed** for commit 8a391ec849617b4314b0721c750c7d080b928575.\n* [Test Results](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/28936/kubernetes-pull-build-test-e2e-gce/53751)\n* [Build Log](http://pr-test.k8s.io/28936/kubernetes-pull-build-test-e2e-gce/53751/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/28936/kubernetes-pull-build-test-e2e-gce/53751/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//53751)\n\n"}}
{"actor":{"display_login":"k8s-bot"}}