{"action":"closed","number":336,"pull_request":{"url":"https://api.github.com/repos/apiman/apiman/pulls/336","id":56806646,"html_url":"https://github.com/apiman/apiman/pull/336","diff_url":"https://github.com/apiman/apiman/pull/336.diff","patch_url":"https://github.com/apiman/apiman/pull/336.patch","issue_url":"https://api.github.com/repos/apiman/apiman/issues/336","number":336,"state":"closed","locked":false,"title":"Ignore Resources Policy: enhance to allow shading by VERB","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars.githubusercontent.com/u/981838?v=3","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"body":"## What was done\r\n- Added verb (http method) support for Ignore resources policy rule.\r\n- Adjusted tests to cover new cases. \r\n- Reshaped UI to support new functionalities. \r\n\r\n## Gui changes\r\n\r\n`IgnoredAligators`\r\nhttp://gfycat.com/ThatBowedAlligatorgar\r\n\r\n`AuthBorer`\r\nhttp://gfycat.com/AliveKindlyBorer\r\n\r\n## Technical comments\r\n\r\n1. Policies gui components\r\nI think we may improve a little bit the way we style policies. \r\nCurrently we use nested style (which is slightly invalid) or direct style on elements. \r\nI think that we can have separate style templates for this (with gulp support). \r\nIt might look better to clean all rules at the same time so I'm not pushing that here.\r\n\r\n2. Separate ts files per policy.\r\nIt may be better to have separate ts files per policy (this may speed up gulp building)\r\nDo we have any reasons to keep it in one file?","created_at":"2016-01-21T20:46:31Z","updated_at":"2016-01-25T17:12:40Z","closed_at":"2016-01-25T17:12:40Z","merged_at":"2016-01-25T17:12:40Z","merge_commit_sha":"008aa910113f4158b511ade67e684fa5875032d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apiman/apiman/pulls/336/commits","review_comments_url":"https://api.github.com/repos/apiman/apiman/pulls/336/comments","review_comment_url":"https://api.github.com/repos/apiman/apiman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apiman/apiman/issues/336/comments","statuses_url":"https://api.github.com/repos/apiman/apiman/statuses/f658cd0b1e0e65cefa955d62c67d557facde5a28","head":{"label":"wtrocki:APIMAN-568","ref":"APIMAN-568","sha":"f658cd0b1e0e65cefa955d62c67d557facde5a28","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars.githubusercontent.com/u/981838?v=3","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"repo":{"id":49751999,"name":"apiman","full_name":"wtrocki/apiman","owner":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars.githubusercontent.com/u/981838?v=3","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wtrocki/apiman","description":"API Management","fork":true,"url":"https://api.github.com/repos/wtrocki/apiman","forks_url":"https://api.github.com/repos/wtrocki/apiman/forks","keys_url":"https://api.github.com/repos/wtrocki/apiman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wtrocki/apiman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wtrocki/apiman/teams","hooks_url":"https://api.github.com/repos/wtrocki/apiman/hooks","issue_events_url":"https://api.github.com/repos/wtrocki/apiman/issues/events{/number}","events_url":"https://api.github.com/repos/wtrocki/apiman/events","assignees_url":"https://api.github.com/repos/wtrocki/apiman/assignees{/user}","branches_url":"https://api.github.com/repos/wtrocki/apiman/branches{/branch}","tags_url":"https://api.github.com/repos/wtrocki/apiman/tags","blobs_url":"https://api.github.com/repos/wtrocki/apiman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wtrocki/apiman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wtrocki/apiman/git/refs{/sha}","trees_url":"https://api.github.com/repos/wtrocki/apiman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wtrocki/apiman/statuses/{sha}","languages_url":"https://api.github.com/repos/wtrocki/apiman/languages","stargazers_url":"https://api.github.com/repos/wtrocki/apiman/stargazers","contributors_url":"https://api.github.com/repos/wtrocki/apiman/contributors","subscribers_url":"https://api.github.com/repos/wtrocki/apiman/subscribers","subscription_url":"https://api.github.com/repos/wtrocki/apiman/subscription","commits_url":"https://api.github.com/repos/wtrocki/apiman/commits{/sha}","git_commits_url":"https://api.github.com/repos/wtrocki/apiman/git/commits{/sha}","comments_url":"https://api.github.com/repos/wtrocki/apiman/comments{/number}","issue_comment_url":"https://api.github.com/repos/wtrocki/apiman/issues/comments{/number}","contents_url":"https://api.github.com/repos/wtrocki/apiman/contents/{+path}","compare_url":"https://api.github.com/repos/wtrocki/apiman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wtrocki/apiman/merges","archive_url":"https://api.github.com/repos/wtrocki/apiman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wtrocki/apiman/downloads","issues_url":"https://api.github.com/repos/wtrocki/apiman/issues{/number}","pulls_url":"https://api.github.com/repos/wtrocki/apiman/pulls{/number}","milestones_url":"https://api.github.com/repos/wtrocki/apiman/milestones{/number}","notifications_url":"https://api.github.com/repos/wtrocki/apiman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wtrocki/apiman/labels{/name}","releases_url":"https://api.github.com/repos/wtrocki/apiman/releases{/id}","deployments_url":"https://api.github.com/repos/wtrocki/apiman/deployments","created_at":"2016-01-16T00:17:26Z","updated_at":"2016-01-16T00:17:31Z","pushed_at":"2016-01-22T14:56:38Z","git_url":"git://github.com/wtrocki/apiman.git","ssh_url":"git@github.com:wtrocki/apiman.git","clone_url":"https://github.com/wtrocki/apiman.git","svn_url":"https://github.com/wtrocki/apiman","homepage":null,"size":33336,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apiman:master","ref":"master","sha":"fe814c918266430fa7db9e629a177d108d798749","user":{"login":"apiman","id":9597575,"avatar_url":"https://avatars.githubusercontent.com/u/9597575?v=3","gravatar_id":"","url":"https://api.github.com/users/apiman","html_url":"https://github.com/apiman","followers_url":"https://api.github.com/users/apiman/followers","following_url":"https://api.github.com/users/apiman/following{/other_user}","gists_url":"https://api.github.com/users/apiman/gists{/gist_id}","starred_url":"https://api.github.com/users/apiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiman/subscriptions","organizations_url":"https://api.github.com/users/apiman/orgs","repos_url":"https://api.github.com/users/apiman/repos","events_url":"https://api.github.com/users/apiman/events{/privacy}","received_events_url":"https://api.github.com/users/apiman/received_events","type":"Organization","site_admin":false},"repo":{"id":12319410,"name":"apiman","full_name":"apiman/apiman","owner":{"login":"apiman","id":9597575,"avatar_url":"https://avatars.githubusercontent.com/u/9597575?v=3","gravatar_id":"","url":"https://api.github.com/users/apiman","html_url":"https://github.com/apiman","followers_url":"https://api.github.com/users/apiman/followers","following_url":"https://api.github.com/users/apiman/following{/other_user}","gists_url":"https://api.github.com/users/apiman/gists{/gist_id}","starred_url":"https://api.github.com/users/apiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiman/subscriptions","organizations_url":"https://api.github.com/users/apiman/orgs","repos_url":"https://api.github.com/users/apiman/repos","events_url":"https://api.github.com/users/apiman/events{/privacy}","received_events_url":"https://api.github.com/users/apiman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiman/apiman","description":"API Management","fork":false,"url":"https://api.github.com/repos/apiman/apiman","forks_url":"https://api.github.com/repos/apiman/apiman/forks","keys_url":"https://api.github.com/repos/apiman/apiman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiman/apiman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiman/apiman/teams","hooks_url":"https://api.github.com/repos/apiman/apiman/hooks","issue_events_url":"https://api.github.com/repos/apiman/apiman/issues/events{/number}","events_url":"https://api.github.com/repos/apiman/apiman/events","assignees_url":"https://api.github.com/repos/apiman/apiman/assignees{/user}","branches_url":"https://api.github.com/repos/apiman/apiman/branches{/branch}","tags_url":"https://api.github.com/repos/apiman/apiman/tags","blobs_url":"https://api.github.com/repos/apiman/apiman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiman/apiman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiman/apiman/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiman/apiman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiman/apiman/statuses/{sha}","languages_url":"https://api.github.com/repos/apiman/apiman/languages","stargazers_url":"https://api.github.com/repos/apiman/apiman/stargazers","contributors_url":"https://api.github.com/repos/apiman/apiman/contributors","subscribers_url":"https://api.github.com/repos/apiman/apiman/subscribers","subscription_url":"https://api.github.com/repos/apiman/apiman/subscription","commits_url":"https://api.github.com/repos/apiman/apiman/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiman/apiman/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiman/apiman/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiman/apiman/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiman/apiman/contents/{+path}","compare_url":"https://api.github.com/repos/apiman/apiman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiman/apiman/merges","archive_url":"https://api.github.com/repos/apiman/apiman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiman/apiman/downloads","issues_url":"https://api.github.com/repos/apiman/apiman/issues{/number}","pulls_url":"https://api.github.com/repos/apiman/apiman/pulls{/number}","milestones_url":"https://api.github.com/repos/apiman/apiman/milestones{/number}","notifications_url":"https://api.github.com/repos/apiman/apiman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiman/apiman/labels{/name}","releases_url":"https://api.github.com/repos/apiman/apiman/releases{/id}","deployments_url":"https://api.github.com/repos/apiman/apiman/deployments","created_at":"2013-08-23T09:29:20Z","updated_at":"2016-01-25T09:10:38Z","pushed_at":"2016-01-25T17:12:40Z","git_url":"git://github.com/apiman/apiman.git","ssh_url":"git@github.com:apiman/apiman.git","clone_url":"https://github.com/apiman/apiman.git","svn_url":"https://github.com/apiman/apiman","homepage":null,"size":34193,"stargazers_count":124,"watchers_count":124,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":6,"forks":83,"open_issues":6,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiman/apiman/pulls/336"},"html":{"href":"https://github.com/apiman/apiman/pull/336"},"issue":{"href":"https://api.github.com/repos/apiman/apiman/issues/336"},"comments":{"href":"https://api.github.com/repos/apiman/apiman/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/apiman/apiman/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/apiman/apiman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apiman/apiman/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/apiman/apiman/statuses/f658cd0b1e0e65cefa955d62c67d557facde5a28"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"EricWittmann","id":1890703,"avatar_url":"https://avatars.githubusercontent.com/u/1890703?v=3","gravatar_id":"","url":"https://api.github.com/users/EricWittmann","html_url":"https://github.com/EricWittmann","followers_url":"https://api.github.com/users/EricWittmann/followers","following_url":"https://api.github.com/users/EricWittmann/following{/other_user}","gists_url":"https://api.github.com/users/EricWittmann/gists{/gist_id}","starred_url":"https://api.github.com/users/EricWittmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricWittmann/subscriptions","organizations_url":"https://api.github.com/users/EricWittmann/orgs","repos_url":"https://api.github.com/users/EricWittmann/repos","events_url":"https://api.github.com/users/EricWittmann/events{/privacy}","received_events_url":"https://api.github.com/users/EricWittmann/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":365,"deletions":142,"changed_files":12}}