{"action":"created","issue":{"url":"https://api.github.com/repos/CoolProp/IF97/issues/3","repository_url":"https://api.github.com/repos/CoolProp/IF97","labels_url":"https://api.github.com/repos/CoolProp/IF97/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/CoolProp/IF97/issues/3/comments","events_url":"https://api.github.com/repos/CoolProp/IF97/issues/3/events","html_url":"https://github.com/CoolProp/IF97/pull/3","id":141481763,"number":3,"title":"Saturation Functions","user":{"login":"henningjp","id":17114032,"avatar_url":"https://avatars.githubusercontent.com/u/17114032?v=3","gravatar_id":"","url":"https://api.github.com/users/henningjp","html_url":"https://github.com/henningjp","followers_url":"https://api.github.com/users/henningjp/followers","following_url":"https://api.github.com/users/henningjp/following{/other_user}","gists_url":"https://api.github.com/users/henningjp/gists{/gist_id}","starred_url":"https://api.github.com/users/henningjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningjp/subscriptions","organizations_url":"https://api.github.com/users/henningjp/orgs","repos_url":"https://api.github.com/users/henningjp/repos","events_url":"https://api.github.com/users/henningjp/events{/privacy}","received_events_url":"https://api.github.com/users/henningjp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-17T05:02:01Z","updated_at":"2016-03-23T10:33:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CoolProp/IF97/pulls/3","html_url":"https://github.com/CoolProp/IF97/pull/3","diff_url":"https://github.com/CoolProp/IF97/pull/3.diff","patch_url":"https://github.com/CoolProp/IF97/pull/3.patch"},"body":"Added Saturated Vapor and Liquid Functions, both in the IF97.h API definitions as well as the Mathcad wrapper.  See commit notes for details.  The validation PDF in the Mathcad directory shows some continuity plots for specific volume and Enthalpy that demonstrates usage of the saturated liquid/vapor functions.\r\n\r\nSaturated vapor/liquid logic requires new enumeration values always remain in a certain order (General, then sat. liquid, then sat vapor).  Added comments to that effect, but it may be fragile.  Open to suggestions on a better method."},"comment":{"url":"https://api.github.com/repos/CoolProp/IF97/issues/comments/200287636","html_url":"https://github.com/CoolProp/IF97/pull/3#issuecomment-200287636","issue_url":"https://api.github.com/repos/CoolProp/IF97/issues/3","id":200287636,"user":{"login":"henningjp","id":17114032,"avatar_url":"https://avatars.githubusercontent.com/u/17114032?v=3","gravatar_id":"","url":"https://api.github.com/users/henningjp","html_url":"https://github.com/henningjp","followers_url":"https://api.github.com/users/henningjp/followers","following_url":"https://api.github.com/users/henningjp/following{/other_user}","gists_url":"https://api.github.com/users/henningjp/gists{/gist_id}","starred_url":"https://api.github.com/users/henningjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningjp/subscriptions","organizations_url":"https://api.github.com/users/henningjp/orgs","repos_url":"https://api.github.com/users/henningjp/repos","events_url":"https://api.github.com/users/henningjp/events{/privacy}","received_events_url":"https://api.github.com/users/henningjp/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T10:33:10Z","updated_at":"2016-03-23T10:33:10Z","body":"See notes on last commit.  May still be too many API functions, but they fit the \"style\" of the original six API functions.  CoolProp uses a different paradigm by passing in the desired input/output parameters to a single function, but the IF97 API was not started that way (six separate functions, one for each property call).  I'm happy to go the other way; it's just a style decision of simplicity of the number of functions (with a more complex parameter list) over simplicity of the parameter list with more complex function list."}}