{"action":"created","comment":{"url":"https://api.github.com/repos/holidays/holidays/pulls/comments/79292421","id":79292421,"diff_hunk":"@@ -6,25 +6,30 @@ There are multiple ways to help! We rely on users around the world to help keep\n \n Please read our [Code of Conduct](CODE_OF_CONDUCT.md) before contributing. Everyone interacting with this project (or associated projects) is expected to abide by its terms.\n \n+## General note\n+\n+The definitions for this project are housed in a submodule. Please make sure to run `git clone --recursive git@github.com/holidays/holidays`","path":"CONTRIBUTING.md","position":6,"original_position":6,"commit_id":"498271854b7277b2b468854e91569dd3b09f44ec","original_commit_id":"498271854b7277b2b468854e91569dd3b09f44ec","user":{"login":"ttwo32","id":4888909,"avatar_url":"https://avatars.githubusercontent.com/u/4888909?v=3","gravatar_id":"","url":"https://api.github.com/users/ttwo32","html_url":"https://github.com/ttwo32","followers_url":"https://api.github.com/users/ttwo32/followers","following_url":"https://api.github.com/users/ttwo32/following{/other_user}","gists_url":"https://api.github.com/users/ttwo32/gists{/gist_id}","starred_url":"https://api.github.com/users/ttwo32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttwo32/subscriptions","organizations_url":"https://api.github.com/users/ttwo32/orgs","repos_url":"https://api.github.com/users/ttwo32/repos","events_url":"https://api.github.com/users/ttwo32/events{/privacy}","received_events_url":"https://api.github.com/users/ttwo32/received_events","type":"User","site_admin":false},"body":"@ptrimble When i did 'make update_defs', but submodules didn't checkout.\r\nI checked [help](https://git-scm.com/docs/git-submodule) and executed  'git submodule update --init', submodule was checked out.\r\nSo 'git submodule update --init' is needed in makefile.","created_at":"2016-09-17T21:29:44Z","updated_at":"2016-09-17T21:29:44Z","html_url":"https://github.com/holidays/holidays/pull/222#discussion_r79292421","pull_request_url":"https://api.github.com/repos/holidays/holidays/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/holidays/holidays/pulls/comments/79292421"},"html":{"href":"https://github.com/holidays/holidays/pull/222#discussion_r79292421"},"pull_request":{"href":"https://api.github.com/repos/holidays/holidays/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/holidays/holidays/pulls/222","id":85324318,"html_url":"https://github.com/holidays/holidays/pull/222","diff_url":"https://github.com/holidays/holidays/pull/222.diff","patch_url":"https://github.com/holidays/holidays/pull/222.patch","issue_url":"https://api.github.com/repos/holidays/holidays/issues/222","number":222,"state":"open","locked":false,"title":"Issue-221: go back to lazy loading of definition files","user":{"login":"ptrimble","id":2753372,"avatar_url":"https://avatars.githubusercontent.com/u/2753372?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrimble","html_url":"https://github.com/ptrimble","followers_url":"https://api.github.com/users/ptrimble/followers","following_url":"https://api.github.com/users/ptrimble/following{/other_user}","gists_url":"https://api.github.com/users/ptrimble/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrimble/subscriptions","organizations_url":"https://api.github.com/users/ptrimble/orgs","repos_url":"https://api.github.com/users/ptrimble/repos","events_url":"https://api.github.com/users/ptrimble/events{/privacy}","received_events_url":"https://api.github.com/users/ptrimble/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/holidays/holidays/issues/221","created_at":"2016-09-14T23:36:51Z","updated_at":"2016-09-17T21:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa9c3f4d8bf45b2c84769239027884f43b911c2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/holidays/holidays/pulls/222/commits","review_comments_url":"https://api.github.com/repos/holidays/holidays/pulls/222/comments","review_comment_url":"https://api.github.com/repos/holidays/holidays/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidays/holidays/issues/222/comments","statuses_url":"https://api.github.com/repos/holidays/holidays/statuses/498271854b7277b2b468854e91569dd3b09f44ec","head":{"label":"ptrimble:issue-221","ref":"issue-221","sha":"498271854b7277b2b468854e91569dd3b09f44ec","user":{"login":"ptrimble","id":2753372,"avatar_url":"https://avatars.githubusercontent.com/u/2753372?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrimble","html_url":"https://github.com/ptrimble","followers_url":"https://api.github.com/users/ptrimble/followers","following_url":"https://api.github.com/users/ptrimble/following{/other_user}","gists_url":"https://api.github.com/users/ptrimble/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrimble/subscriptions","organizations_url":"https://api.github.com/users/ptrimble/orgs","repos_url":"https://api.github.com/users/ptrimble/repos","events_url":"https://api.github.com/users/ptrimble/events{/privacy}","received_events_url":"https://api.github.com/users/ptrimble/received_events","type":"User","site_admin":false},"repo":{"id":32357424,"name":"holidays","full_name":"ptrimble/holidays","owner":{"login":"ptrimble","id":2753372,"avatar_url":"https://avatars.githubusercontent.com/u/2753372?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrimble","html_url":"https://github.com/ptrimble","followers_url":"https://api.github.com/users/ptrimble/followers","following_url":"https://api.github.com/users/ptrimble/following{/other_user}","gists_url":"https://api.github.com/users/ptrimble/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrimble/subscriptions","organizations_url":"https://api.github.com/users/ptrimble/orgs","repos_url":"https://api.github.com/users/ptrimble/repos","events_url":"https://api.github.com/users/ptrimble/events{/privacy}","received_events_url":"https://api.github.com/users/ptrimble/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptrimble/holidays","description":"A collection of Ruby methods to deal with statutory and other holidays.  You deserve a holiday!","fork":true,"url":"https://api.github.com/repos/ptrimble/holidays","forks_url":"https://api.github.com/repos/ptrimble/holidays/forks","keys_url":"https://api.github.com/repos/ptrimble/holidays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptrimble/holidays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptrimble/holidays/teams","hooks_url":"https://api.github.com/repos/ptrimble/holidays/hooks","issue_events_url":"https://api.github.com/repos/ptrimble/holidays/issues/events{/number}","events_url":"https://api.github.com/repos/ptrimble/holidays/events","assignees_url":"https://api.github.com/repos/ptrimble/holidays/assignees{/user}","branches_url":"https://api.github.com/repos/ptrimble/holidays/branches{/branch}","tags_url":"https://api.github.com/repos/ptrimble/holidays/tags","blobs_url":"https://api.github.com/repos/ptrimble/holidays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptrimble/holidays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptrimble/holidays/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptrimble/holidays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptrimble/holidays/statuses/{sha}","languages_url":"https://api.github.com/repos/ptrimble/holidays/languages","stargazers_url":"https://api.github.com/repos/ptrimble/holidays/stargazers","contributors_url":"https://api.github.com/repos/ptrimble/holidays/contributors","subscribers_url":"https://api.github.com/repos/ptrimble/holidays/subscribers","subscription_url":"https://api.github.com/repos/ptrimble/holidays/subscription","commits_url":"https://api.github.com/repos/ptrimble/holidays/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptrimble/holidays/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptrimble/holidays/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptrimble/holidays/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptrimble/holidays/contents/{+path}","compare_url":"https://api.github.com/repos/ptrimble/holidays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptrimble/holidays/merges","archive_url":"https://api.github.com/repos/ptrimble/holidays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptrimble/holidays/downloads","issues_url":"https://api.github.com/repos/ptrimble/holidays/issues{/number}","pulls_url":"https://api.github.com/repos/ptrimble/holidays/pulls{/number}","milestones_url":"https://api.github.com/repos/ptrimble/holidays/milestones{/number}","notifications_url":"https://api.github.com/repos/ptrimble/holidays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptrimble/holidays/labels{/name}","releases_url":"https://api.github.com/repos/ptrimble/holidays/releases{/id}","deployments_url":"https://api.github.com/repos/ptrimble/holidays/deployments","created_at":"2015-03-16T22:44:24Z","updated_at":"2016-01-17T02:51:13Z","pushed_at":"2016-09-16T03:51:11Z","git_url":"git://github.com/ptrimble/holidays.git","ssh_url":"git@github.com:ptrimble/holidays.git","clone_url":"https://github.com/ptrimble/holidays.git","svn_url":"https://github.com/ptrimble/holidays","homepage":"","size":1426,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"holidays:master","ref":"master","sha":"fcd0700d4b475c18990474943bbf868fbff48eec","user":{"login":"holidays","id":11636900,"avatar_url":"https://avatars.githubusercontent.com/u/11636900?v=3","gravatar_id":"","url":"https://api.github.com/users/holidays","html_url":"https://github.com/holidays","followers_url":"https://api.github.com/users/holidays/followers","following_url":"https://api.github.com/users/holidays/following{/other_user}","gists_url":"https://api.github.com/users/holidays/gists{/gist_id}","starred_url":"https://api.github.com/users/holidays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidays/subscriptions","organizations_url":"https://api.github.com/users/holidays/orgs","repos_url":"https://api.github.com/users/holidays/repos","events_url":"https://api.github.com/users/holidays/events{/privacy}","received_events_url":"https://api.github.com/users/holidays/received_events","type":"Organization","site_admin":false},"repo":{"id":98540,"name":"holidays","full_name":"holidays/holidays","owner":{"login":"holidays","id":11636900,"avatar_url":"https://avatars.githubusercontent.com/u/11636900?v=3","gravatar_id":"","url":"https://api.github.com/users/holidays","html_url":"https://github.com/holidays","followers_url":"https://api.github.com/users/holidays/followers","following_url":"https://api.github.com/users/holidays/following{/other_user}","gists_url":"https://api.github.com/users/holidays/gists{/gist_id}","starred_url":"https://api.github.com/users/holidays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidays/subscriptions","organizations_url":"https://api.github.com/users/holidays/orgs","repos_url":"https://api.github.com/users/holidays/repos","events_url":"https://api.github.com/users/holidays/events{/privacy}","received_events_url":"https://api.github.com/users/holidays/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidays/holidays","description":"A collection of Ruby methods to deal with statutory and other holidays.  You deserve a holiday!","fork":false,"url":"https://api.github.com/repos/holidays/holidays","forks_url":"https://api.github.com/repos/holidays/holidays/forks","keys_url":"https://api.github.com/repos/holidays/holidays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidays/holidays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidays/holidays/teams","hooks_url":"https://api.github.com/repos/holidays/holidays/hooks","issue_events_url":"https://api.github.com/repos/holidays/holidays/issues/events{/number}","events_url":"https://api.github.com/repos/holidays/holidays/events","assignees_url":"https://api.github.com/repos/holidays/holidays/assignees{/user}","branches_url":"https://api.github.com/repos/holidays/holidays/branches{/branch}","tags_url":"https://api.github.com/repos/holidays/holidays/tags","blobs_url":"https://api.github.com/repos/holidays/holidays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidays/holidays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidays/holidays/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidays/holidays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidays/holidays/statuses/{sha}","languages_url":"https://api.github.com/repos/holidays/holidays/languages","stargazers_url":"https://api.github.com/repos/holidays/holidays/stargazers","contributors_url":"https://api.github.com/repos/holidays/holidays/contributors","subscribers_url":"https://api.github.com/repos/holidays/holidays/subscribers","subscription_url":"https://api.github.com/repos/holidays/holidays/subscription","commits_url":"https://api.github.com/repos/holidays/holidays/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidays/holidays/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidays/holidays/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidays/holidays/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidays/holidays/contents/{+path}","compare_url":"https://api.github.com/repos/holidays/holidays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidays/holidays/merges","archive_url":"https://api.github.com/repos/holidays/holidays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidays/holidays/downloads","issues_url":"https://api.github.com/repos/holidays/holidays/issues{/number}","pulls_url":"https://api.github.com/repos/holidays/holidays/pulls{/number}","milestones_url":"https://api.github.com/repos/holidays/holidays/milestones{/number}","notifications_url":"https://api.github.com/repos/holidays/holidays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidays/holidays/labels{/name}","releases_url":"https://api.github.com/repos/holidays/holidays/releases{/id}","deployments_url":"https://api.github.com/repos/holidays/holidays/deployments","created_at":"2008-12-30T18:33:59Z","updated_at":"2016-09-15T09:33:08Z","pushed_at":"2016-09-16T05:33:23Z","git_url":"git://github.com/holidays/holidays.git","ssh_url":"git@github.com:holidays/holidays.git","clone_url":"https://github.com/holidays/holidays.git","svn_url":"https://github.com/holidays/holidays","homepage":"","size":1618,"stargazers_count":340,"watchers_count":340,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":9,"forks":182,"open_issues":9,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidays/holidays/pulls/222"},"html":{"href":"https://github.com/holidays/holidays/pull/222"},"issue":{"href":"https://api.github.com/repos/holidays/holidays/issues/222"},"comments":{"href":"https://api.github.com/repos/holidays/holidays/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/holidays/holidays/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/holidays/holidays/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidays/holidays/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/holidays/holidays/statuses/498271854b7277b2b468854e91569dd3b09f44ec"}}}}
{"actor":{"display_login":"ttwo32"}}