{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/comments/82907190","pull_request_review_id":3767123,"id":82907190,"diff_hunk":"@@ -0,0 +1,48 @@\n+# Blender v2.73 (sub 0) OBJ File: 'mt_torch_full_vertices3.blend'\n+# www.blender.org\n+mtllib torch_wall4.mtl\n+o Cube_Cube.001\n+v 0.061653 -0.554493 -0.328908\n+v 0.061653 -0.442208 -0.381835\n+v -0.059258 -0.554493 -0.328908\n+v -0.059258 -0.442208 -0.381835\n+v -0.059994 -0.948766 -0.143618","path":"mods/default/models/torch_wall.obj","position":9,"original_position":9,"commit_id":"b4d3769ecaa8bcfdc66011c80b718d68f46f3b63","original_commit_id":"b4d3769ecaa8bcfdc66011c80b718d68f46f3b63","user":{"login":"t4im","id":1937987,"avatar_url":"https://avatars.githubusercontent.com/u/1937987?v=3","gravatar_id":"","url":"https://api.github.com/users/t4im","html_url":"https://github.com/t4im","followers_url":"https://api.github.com/users/t4im/followers","following_url":"https://api.github.com/users/t4im/following{/other_user}","gists_url":"https://api.github.com/users/t4im/gists{/gist_id}","starred_url":"https://api.github.com/users/t4im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4im/subscriptions","organizations_url":"https://api.github.com/users/t4im/orgs","repos_url":"https://api.github.com/users/t4im/repos","events_url":"https://api.github.com/users/t4im/events{/privacy}","received_events_url":"https://api.github.com/users/t4im/received_events","type":"User","site_admin":false},"body":"Okay... So you rotated the former geometry to keep it simple, i assume. But that vertice and the other face's V16(L20) are practically already in the middle of the node below. Are you sure about this?\r\nLooks kinda odd now.","created_at":"2016-10-11T23:00:00Z","updated_at":"2016-10-11T23:09:56Z","html_url":"https://github.com/minetest/minetest_game/pull/1322#discussion_r82907190","pull_request_url":"https://api.github.com/repos/minetest/minetest_game/pulls/1322","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/comments/82907190"},"html":{"href":"https://github.com/minetest/minetest_game/pull/1322#discussion_r82907190"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/1322"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/1322","id":88888856,"html_url":"https://github.com/minetest/minetest_game/pull/1322","diff_url":"https://github.com/minetest/minetest_game/pull/1322.diff","patch_url":"https://github.com/minetest/minetest_game/pull/1322.patch","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/1322","number":1322,"state":"open","locked":false,"title":"3D Torches","user":{"login":"octacian","id":15371866,"avatar_url":"https://avatars.githubusercontent.com/u/15371866?v=3","gravatar_id":"","url":"https://api.github.com/users/octacian","html_url":"https://github.com/octacian","followers_url":"https://api.github.com/users/octacian/followers","following_url":"https://api.github.com/users/octacian/following{/other_user}","gists_url":"https://api.github.com/users/octacian/gists{/gist_id}","starred_url":"https://api.github.com/users/octacian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octacian/subscriptions","organizations_url":"https://api.github.com/users/octacian/orgs","repos_url":"https://api.github.com/users/octacian/repos","events_url":"https://api.github.com/users/octacian/events{/privacy}","received_events_url":"https://api.github.com/users/octacian/received_events","type":"User","site_admin":false},"body":"![3D Torches](https://cloud.githubusercontent.com/assets/15371866/19283910/9f2c2c1a-8fa8-11e6-999f-c25fb429bbca.png)\r\n\r\nThe title says it all. This PR makes torches 3D. Aside from using a mesh drawtype instead of torchlike, the only major difference is that you cannot place torches on the ceiling (like @BlockMen's [torches](https://forum.minetest.net/viewtopic.php?t=6099) mod).\r\n\r\nThe textures and models are from @BlockMen's [torches](https://forum.minetest.net/viewtopic.php?t=6099) mod, and much of the code I was able to write as a result of looking through the mod.\r\n\r\nI am working on making torches drop when placed on ceilings (instead of simply staying in your inventory), adding particles, and torch decay (latter two optional).\r\n\r\n**Note:** three commits need to be squashed. I'll attempt to do it, but I'm terrible at squashing commits. Either that, or I just messed up the first time.","created_at":"2016-10-11T18:49:59Z","updated_at":"2016-10-11T23:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89d6742489dd2160457a41e6d80a8ca0f9f8adf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest_game/pulls/1322/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest_game/pulls/1322/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest_game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/1322/comments","statuses_url":"https://api.github.com/repos/minetest/minetest_game/statuses/b4d3769ecaa8bcfdc66011c80b718d68f46f3b63","head":{"label":"octacian:better-torches","ref":"better-torches","sha":"b4d3769ecaa8bcfdc66011c80b718d68f46f3b63","user":{"login":"octacian","id":15371866,"avatar_url":"https://avatars.githubusercontent.com/u/15371866?v=3","gravatar_id":"","url":"https://api.github.com/users/octacian","html_url":"https://github.com/octacian","followers_url":"https://api.github.com/users/octacian/followers","following_url":"https://api.github.com/users/octacian/following{/other_user}","gists_url":"https://api.github.com/users/octacian/gists{/gist_id}","starred_url":"https://api.github.com/users/octacian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octacian/subscriptions","organizations_url":"https://api.github.com/users/octacian/orgs","repos_url":"https://api.github.com/users/octacian/repos","events_url":"https://api.github.com/users/octacian/events{/privacy}","received_events_url":"https://api.github.com/users/octacian/received_events","type":"User","site_admin":false},"repo":{"id":70607032,"name":"minetest_game","full_name":"octacian/minetest_game","owner":{"login":"octacian","id":15371866,"avatar_url":"https://avatars.githubusercontent.com/u/15371866?v=3","gravatar_id":"","url":"https://api.github.com/users/octacian","html_url":"https://github.com/octacian","followers_url":"https://api.github.com/users/octacian/followers","following_url":"https://api.github.com/users/octacian/following{/other_user}","gists_url":"https://api.github.com/users/octacian/gists{/gist_id}","starred_url":"https://api.github.com/users/octacian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octacian/subscriptions","organizations_url":"https://api.github.com/users/octacian/orgs","repos_url":"https://api.github.com/users/octacian/repos","events_url":"https://api.github.com/users/octacian/events{/privacy}","received_events_url":"https://api.github.com/users/octacian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/octacian/minetest_game","description":"Minetest Game - The default game for the Minetest engine [https://github.com/minetest/minetest/]","fork":true,"url":"https://api.github.com/repos/octacian/minetest_game","forks_url":"https://api.github.com/repos/octacian/minetest_game/forks","keys_url":"https://api.github.com/repos/octacian/minetest_game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octacian/minetest_game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octacian/minetest_game/teams","hooks_url":"https://api.github.com/repos/octacian/minetest_game/hooks","issue_events_url":"https://api.github.com/repos/octacian/minetest_game/issues/events{/number}","events_url":"https://api.github.com/repos/octacian/minetest_game/events","assignees_url":"https://api.github.com/repos/octacian/minetest_game/assignees{/user}","branches_url":"https://api.github.com/repos/octacian/minetest_game/branches{/branch}","tags_url":"https://api.github.com/repos/octacian/minetest_game/tags","blobs_url":"https://api.github.com/repos/octacian/minetest_game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octacian/minetest_game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octacian/minetest_game/git/refs{/sha}","trees_url":"https://api.github.com/repos/octacian/minetest_game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octacian/minetest_game/statuses/{sha}","languages_url":"https://api.github.com/repos/octacian/minetest_game/languages","stargazers_url":"https://api.github.com/repos/octacian/minetest_game/stargazers","contributors_url":"https://api.github.com/repos/octacian/minetest_game/contributors","subscribers_url":"https://api.github.com/repos/octacian/minetest_game/subscribers","subscription_url":"https://api.github.com/repos/octacian/minetest_game/subscription","commits_url":"https://api.github.com/repos/octacian/minetest_game/commits{/sha}","git_commits_url":"https://api.github.com/repos/octacian/minetest_game/git/commits{/sha}","comments_url":"https://api.github.com/repos/octacian/minetest_game/comments{/number}","issue_comment_url":"https://api.github.com/repos/octacian/minetest_game/issues/comments{/number}","contents_url":"https://api.github.com/repos/octacian/minetest_game/contents/{+path}","compare_url":"https://api.github.com/repos/octacian/minetest_game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octacian/minetest_game/merges","archive_url":"https://api.github.com/repos/octacian/minetest_game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octacian/minetest_game/downloads","issues_url":"https://api.github.com/repos/octacian/minetest_game/issues{/number}","pulls_url":"https://api.github.com/repos/octacian/minetest_game/pulls{/number}","milestones_url":"https://api.github.com/repos/octacian/minetest_game/milestones{/number}","notifications_url":"https://api.github.com/repos/octacian/minetest_game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octacian/minetest_game/labels{/name}","releases_url":"https://api.github.com/repos/octacian/minetest_game/releases{/id}","deployments_url":"https://api.github.com/repos/octacian/minetest_game/deployments","created_at":"2016-10-11T15:21:37Z","updated_at":"2016-10-11T15:21:39Z","pushed_at":"2016-10-11T19:03:02Z","git_url":"git://github.com/octacian/minetest_game.git","ssh_url":"git@github.com:octacian/minetest_game.git","clone_url":"https://github.com/octacian/minetest_game.git","svn_url":"https://github.com/octacian/minetest_game","homepage":"http://minetest.net/","size":4898,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"6fdfd2554c23535530a5750d3b362e6399b00b55","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":3834571,"name":"minetest_game","full_name":"minetest/minetest_game","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest_game","description":"Minetest Game - The default game for the Minetest engine [https://github.com/minetest/minetest/]","fork":false,"url":"https://api.github.com/repos/minetest/minetest_game","forks_url":"https://api.github.com/repos/minetest/minetest_game/forks","keys_url":"https://api.github.com/repos/minetest/minetest_game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest_game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest_game/teams","hooks_url":"https://api.github.com/repos/minetest/minetest_game/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest_game/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest_game/events","assignees_url":"https://api.github.com/repos/minetest/minetest_game/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest_game/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest_game/tags","blobs_url":"https://api.github.com/repos/minetest/minetest_game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest_game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest_game/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest_game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest_game/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest_game/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest_game/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest_game/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest_game/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest_game/subscription","commits_url":"https://api.github.com/repos/minetest/minetest_game/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest_game/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest_game/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest_game/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest_game/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest_game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest_game/merges","archive_url":"https://api.github.com/repos/minetest/minetest_game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest_game/downloads","issues_url":"https://api.github.com/repos/minetest/minetest_game/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest_game/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest_game/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest_game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest_game/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest_game/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest_game/deployments","created_at":"2012-03-26T16:03:29Z","updated_at":"2016-10-11T01:38:41Z","pushed_at":"2016-10-11T19:03:02Z","git_url":"git://github.com/minetest/minetest_game.git","ssh_url":"git@github.com:minetest/minetest_game.git","clone_url":"https://github.com/minetest/minetest_game.git","svn_url":"https://github.com/minetest/minetest_game","homepage":"http://minetest.net/","size":14125,"stargazers_count":464,"watchers_count":464,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":62,"forks":263,"open_issues":62,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/1322"},"html":{"href":"https://github.com/minetest/minetest_game/pull/1322"},"issue":{"href":"https://api.github.com/repos/minetest/minetest_game/issues/1322"},"comments":{"href":"https://api.github.com/repos/minetest/minetest_game/issues/1322/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/1322/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/1322/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest_game/statuses/b4d3769ecaa8bcfdc66011c80b718d68f46f3b63"}}}}
{"actor":{"display_login":"t4im"}}