{"action":"created","comment":{"url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/comments/63963206","id":63963206,"diff_hunk":"@@ -43,7 +43,7 @@ PWM::PWM(uint32_t channel) {\n \n   m_channel = channel;\n \n-  setPWM(m_pwm_ports[m_channel], kPwmDisabled, &status);\n+  setPWMRaw(m_pwm_ports[m_channel], kPwmDisabled, &status);","path":"wpilibc/Athena/src/PWM.cpp","position":5,"original_position":5,"commit_id":"b7fa9051a4d7c6d3029b51f86152f1e640e078b3","original_commit_id":"b7fa9051a4d7c6d3029b51f86152f1e640e078b3","user":{"login":"virtuald","id":567900,"avatar_url":"https://avatars.githubusercontent.com/u/567900?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"body":"I know you didn't do this, but why is there an array of pwm ports? This doesn't exist on the Java side. ","created_at":"2016-05-19T22:14:01Z","updated_at":"2016-05-19T22:14:01Z","html_url":"https://github.com/wpilibsuite/allwpilib/pull/39#discussion_r63963206","pull_request_url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/comments/63963206"},"html":{"href":"https://github.com/wpilibsuite/allwpilib/pull/39#discussion_r63963206"},"pull_request":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39","id":70627662,"html_url":"https://github.com/wpilibsuite/allwpilib/pull/39","diff_url":"https://github.com/wpilibsuite/allwpilib/pull/39.diff","patch_url":"https://github.com/wpilibsuite/allwpilib/pull/39.patch","issue_url":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/39","number":39,"state":"open","locked":false,"title":"Changes HAL PWM to take -1 to 1, and scale at the HAL Level","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"body":"As discussed in #33, here is the start to the PWM changes. Currently I have done the HAL portion, and the C++ portion. Still needed to do the JNI and Java portions, but wanted to make sure I wasn't on a bad path with the new API.\r\n\r\nOne thing I did have to do, and am going to have to do more in the resource management portion of the changes, is split Digital.cpp and Digital.hpp in the HAL into multiple files. It was getting way too big and hard to deal with. Does anybody disagree with doing this, and did I put the files in good spots?","created_at":"2016-05-19T02:15:42Z","updated_at":"2016-05-19T22:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300d6c5f587150f3ab9ba8564743a3b99e26d334","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39/commits","review_comments_url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39/comments","review_comment_url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/39/comments","statuses_url":"https://api.github.com/repos/wpilibsuite/allwpilib/statuses/b7fa9051a4d7c6d3029b51f86152f1e640e078b3","head":{"label":"ThadHouse:HALPWMChange","ref":"HALPWMChange","sha":"b7fa9051a4d7c6d3029b51f86152f1e640e078b3","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"repo":{"id":44621879,"name":"allwpilib","full_name":"ThadHouse/allwpilib","owner":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThadHouse/allwpilib","description":"Mirror of FIRST's WPILib repository for 2015+","fork":true,"url":"https://api.github.com/repos/ThadHouse/allwpilib","forks_url":"https://api.github.com/repos/ThadHouse/allwpilib/forks","keys_url":"https://api.github.com/repos/ThadHouse/allwpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThadHouse/allwpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThadHouse/allwpilib/teams","hooks_url":"https://api.github.com/repos/ThadHouse/allwpilib/hooks","issue_events_url":"https://api.github.com/repos/ThadHouse/allwpilib/issues/events{/number}","events_url":"https://api.github.com/repos/ThadHouse/allwpilib/events","assignees_url":"https://api.github.com/repos/ThadHouse/allwpilib/assignees{/user}","branches_url":"https://api.github.com/repos/ThadHouse/allwpilib/branches{/branch}","tags_url":"https://api.github.com/repos/ThadHouse/allwpilib/tags","blobs_url":"https://api.github.com/repos/ThadHouse/allwpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThadHouse/allwpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThadHouse/allwpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThadHouse/allwpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThadHouse/allwpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/ThadHouse/allwpilib/languages","stargazers_url":"https://api.github.com/repos/ThadHouse/allwpilib/stargazers","contributors_url":"https://api.github.com/repos/ThadHouse/allwpilib/contributors","subscribers_url":"https://api.github.com/repos/ThadHouse/allwpilib/subscribers","subscription_url":"https://api.github.com/repos/ThadHouse/allwpilib/subscription","commits_url":"https://api.github.com/repos/ThadHouse/allwpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThadHouse/allwpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThadHouse/allwpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThadHouse/allwpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThadHouse/allwpilib/contents/{+path}","compare_url":"https://api.github.com/repos/ThadHouse/allwpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThadHouse/allwpilib/merges","archive_url":"https://api.github.com/repos/ThadHouse/allwpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThadHouse/allwpilib/downloads","issues_url":"https://api.github.com/repos/ThadHouse/allwpilib/issues{/number}","pulls_url":"https://api.github.com/repos/ThadHouse/allwpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/ThadHouse/allwpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/ThadHouse/allwpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThadHouse/allwpilib/labels{/name}","releases_url":"https://api.github.com/repos/ThadHouse/allwpilib/releases{/id}","deployments_url":"https://api.github.com/repos/ThadHouse/allwpilib/deployments","created_at":"2015-10-20T17:07:36Z","updated_at":"2016-01-13T00:22:31Z","pushed_at":"2016-05-19T18:40:14Z","git_url":"git://github.com/ThadHouse/allwpilib.git","ssh_url":"git@github.com:ThadHouse/allwpilib.git","clone_url":"https://github.com/ThadHouse/allwpilib.git","svn_url":"https://github.com/ThadHouse/allwpilib","homepage":"","size":63508,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpilibsuite:master","ref":"master","sha":"05a208981651c3b9dea1620637162ca504583068","user":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars.githubusercontent.com/u/19267233?v=3","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":24655143,"name":"allwpilib","full_name":"wpilibsuite/allwpilib","owner":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars.githubusercontent.com/u/19267233?v=3","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpilibsuite/allwpilib","description":"Official Repository of WPILibJ and WPILibC","fork":false,"url":"https://api.github.com/repos/wpilibsuite/allwpilib","forks_url":"https://api.github.com/repos/wpilibsuite/allwpilib/forks","keys_url":"https://api.github.com/repos/wpilibsuite/allwpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpilibsuite/allwpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpilibsuite/allwpilib/teams","hooks_url":"https://api.github.com/repos/wpilibsuite/allwpilib/hooks","issue_events_url":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/events{/number}","events_url":"https://api.github.com/repos/wpilibsuite/allwpilib/events","assignees_url":"https://api.github.com/repos/wpilibsuite/allwpilib/assignees{/user}","branches_url":"https://api.github.com/repos/wpilibsuite/allwpilib/branches{/branch}","tags_url":"https://api.github.com/repos/wpilibsuite/allwpilib/tags","blobs_url":"https://api.github.com/repos/wpilibsuite/allwpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpilibsuite/allwpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpilibsuite/allwpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpilibsuite/allwpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpilibsuite/allwpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/wpilibsuite/allwpilib/languages","stargazers_url":"https://api.github.com/repos/wpilibsuite/allwpilib/stargazers","contributors_url":"https://api.github.com/repos/wpilibsuite/allwpilib/contributors","subscribers_url":"https://api.github.com/repos/wpilibsuite/allwpilib/subscribers","subscription_url":"https://api.github.com/repos/wpilibsuite/allwpilib/subscription","commits_url":"https://api.github.com/repos/wpilibsuite/allwpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpilibsuite/allwpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpilibsuite/allwpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpilibsuite/allwpilib/contents/{+path}","compare_url":"https://api.github.com/repos/wpilibsuite/allwpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpilibsuite/allwpilib/merges","archive_url":"https://api.github.com/repos/wpilibsuite/allwpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpilibsuite/allwpilib/downloads","issues_url":"https://api.github.com/repos/wpilibsuite/allwpilib/issues{/number}","pulls_url":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/wpilibsuite/allwpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/wpilibsuite/allwpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpilibsuite/allwpilib/labels{/name}","releases_url":"https://api.github.com/repos/wpilibsuite/allwpilib/releases{/id}","deployments_url":"https://api.github.com/repos/wpilibsuite/allwpilib/deployments","created_at":"2014-09-30T20:51:33Z","updated_at":"2016-05-17T14:38:21Z","pushed_at":"2016-05-19T20:30:05Z","git_url":"git://github.com/wpilibsuite/allwpilib.git","ssh_url":"git@github.com:wpilibsuite/allwpilib.git","clone_url":"https://github.com/wpilibsuite/allwpilib.git","svn_url":"https://github.com/wpilibsuite/allwpilib","homepage":"","size":69915,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":27,"forks":19,"open_issues":27,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39"},"html":{"href":"https://github.com/wpilibsuite/allwpilib/pull/39"},"issue":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/39"},"comments":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/wpilibsuite/allwpilib/statuses/b7fa9051a4d7c6d3029b51f86152f1e640e078b3"}}}}
{"actor":{"display_login":"virtuald"}}