{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53732281","id":53732281,"diff_hunk":"@@ -26,14 +26,36 @@ extern \"C\" int32_t SystemNative_GetUnixVersion(char* version, int* capacity)\n /* Returns an int representing the OS Architecture:\n  0 - x86\n  1 - x64\n- 2 - ARM */\n-extern \"C\" int32_t SystemNative_GetUnixArchitecture()\n+ 2 - ARM\n+ 3 - ARM64 */\n+extern \"C\" int32_t SystemNative_GetOSArchitecture()\n {\n-#if defined(ARM)\n+#if defined(_ARM_)\n     return ARCH_ARM;\n-#elif defined(X64)\n+#elif defined(_ARM64_)\n+    return ARCH_ARM64;\n+#elif defined(_AMD64_)\n     return ARCH_X64;\n-#elif defined(X86)\n+#elif defined(_X86_)\n+    return ARCH_X86;\n+#error Unidentified Architecture\n+#endif\n+}\n+\n+/* Returns an int representing the OS Architecture:\n+0 - x86\n+1 - x64\n+2 - ARM\n+3 - ARM64 */\n+extern \"C\" int32_t SystemNative_GetProcessArchitecture()\n+{\n+#if defined(_ARM_)\n+    return ARCH_ARM;\n+#elif defined(_ARM64_)\n+    return ARCH_ARM64;\n+#elif defined(_AMD64_)\n+    return ARCH_X64;\n+#elif defined(_X86_)\n     return ARCH_X86;\n #error Unidentified Architecture","path":"src/Native/System.Native/pal_runtimeinformation.cpp","position":null,"original_position":40,"commit_id":"ac2aa4e7b1cdfbd9e4f05b38323bfdb2eaddd681","original_commit_id":"30303bd7db00157d801eef6194670e4b7c6c3c35","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"> Semantically same meaning\r\n\r\nIt's not, though.  This is a compile-time rather than run-time error... you're not seeing it when you do your native build because you're not building for X86, but if you were, you'd see this error fail the compilation.  Try moving the #error up to after the return in the AMD64 case and you'll see what I mean.","created_at":"2016-02-23T03:26:38Z","updated_at":"2016-02-23T03:26:38Z","html_url":"https://github.com/dotnet/corefx/pull/6320#discussion_r53732281","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6320","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53732281"},"html":{"href":"https://github.com/dotnet/corefx/pull/6320#discussion_r53732281"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6320"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6320","id":60249642,"html_url":"https://github.com/dotnet/corefx/pull/6320","diff_url":"https://github.com/dotnet/corefx/pull/6320.diff","patch_url":"https://github.com/dotnet/corefx/pull/6320.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6320","number":6320,"state":"open","locked":false,"title":"[Api-Addition] Add Arm64 to RuntimeInformation APIs.","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"body":"Issue #6276 \r\n\r\ncc @jkotas @stephentoub @manu-silicon ","created_at":"2016-02-22T22:07:47Z","updated_at":"2016-02-23T03:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db9c4478a7de9f6c2971bd42731317b262f5ba3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6320/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6320/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6320/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/ac2aa4e7b1cdfbd9e4f05b38323bfdb2eaddd681","head":{"label":"Priya91:arm64","ref":"arm64","sha":"ac2aa4e7b1cdfbd9e4f05b38323bfdb2eaddd681","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"repo":{"id":27062349,"name":"corefx-1","full_name":"Priya91/corefx-1","owner":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Priya91/corefx-1","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/Priya91/corefx-1","forks_url":"https://api.github.com/repos/Priya91/corefx-1/forks","keys_url":"https://api.github.com/repos/Priya91/corefx-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Priya91/corefx-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Priya91/corefx-1/teams","hooks_url":"https://api.github.com/repos/Priya91/corefx-1/hooks","issue_events_url":"https://api.github.com/repos/Priya91/corefx-1/issues/events{/number}","events_url":"https://api.github.com/repos/Priya91/corefx-1/events","assignees_url":"https://api.github.com/repos/Priya91/corefx-1/assignees{/user}","branches_url":"https://api.github.com/repos/Priya91/corefx-1/branches{/branch}","tags_url":"https://api.github.com/repos/Priya91/corefx-1/tags","blobs_url":"https://api.github.com/repos/Priya91/corefx-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Priya91/corefx-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Priya91/corefx-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Priya91/corefx-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Priya91/corefx-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Priya91/corefx-1/languages","stargazers_url":"https://api.github.com/repos/Priya91/corefx-1/stargazers","contributors_url":"https://api.github.com/repos/Priya91/corefx-1/contributors","subscribers_url":"https://api.github.com/repos/Priya91/corefx-1/subscribers","subscription_url":"https://api.github.com/repos/Priya91/corefx-1/subscription","commits_url":"https://api.github.com/repos/Priya91/corefx-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Priya91/corefx-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Priya91/corefx-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Priya91/corefx-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Priya91/corefx-1/contents/{+path}","compare_url":"https://api.github.com/repos/Priya91/corefx-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Priya91/corefx-1/merges","archive_url":"https://api.github.com/repos/Priya91/corefx-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Priya91/corefx-1/downloads","issues_url":"https://api.github.com/repos/Priya91/corefx-1/issues{/number}","pulls_url":"https://api.github.com/repos/Priya91/corefx-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Priya91/corefx-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Priya91/corefx-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Priya91/corefx-1/labels{/name}","releases_url":"https://api.github.com/repos/Priya91/corefx-1/releases{/id}","deployments_url":"https://api.github.com/repos/Priya91/corefx-1/deployments","created_at":"2014-11-24T05:35:16Z","updated_at":"2015-01-07T23:48:56Z","pushed_at":"2016-02-23T03:26:02Z","git_url":"git://github.com/Priya91/corefx-1.git","ssh_url":"git@github.com:Priya91/corefx-1.git","clone_url":"https://github.com/Priya91/corefx-1.git","svn_url":"https://github.com/Priya91/corefx-1","homepage":"","size":56672,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c657cc9957704d8c284d56119f2204e9f6641b09","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-23T00:57:23Z","pushed_at":"2016-02-23T03:26:03Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":67047,"stargazers_count":9177,"watchers_count":9177,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2146,"mirror_url":null,"open_issues_count":836,"forks":2146,"open_issues":836,"watchers":9177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6320"},"html":{"href":"https://github.com/dotnet/corefx/pull/6320"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6320"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6320/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6320/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6320/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/ac2aa4e7b1cdfbd9e4f05b38323bfdb2eaddd681"}}}}