{"action":"opened","number":136,"pull_request":{"url":"https://api.github.com/repos/lxc/lxcfs/pulls/136","id":82847266,"html_url":"https://github.com/lxc/lxcfs/pull/136","diff_url":"https://github.com/lxc/lxcfs/pull/136.diff","patch_url":"https://github.com/lxc/lxcfs/pull/136.patch","issue_url":"https://api.github.com/repos/lxc/lxcfs/issues/136","number":136,"state":"open","locked":false,"title":"bindings: revert cgroup check","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"We do not need to check whether mode & W_OK is passed in. Even if the cgroup\r\nroot mount is writeable operations like cg_mkdir() et al. will fail with e.g.\r\nEPERM. Basically all operations will fail on the cgroup root mount point because\r\nthe first operation they perform is pick_controller_from_path(). That is to say\r\nthey try to e.g. pick \"blkio\" from /var/lib/lxcfs/cgroup/blkio/some/cgroups an\r\nsimiliar for all other controllers. If pick_controller_from_path() fails they\r\nall return an appropriate errno. For example, cg_mkdir() does:\r\n\r\n        controller = pick_controller_from_path(fc, path);\r\n        if (!controller)\r\n                return errno == ENOENT ? -EPERM : -errno;\r\n\r\nThis means, we do not need to return an errno already in cg_access when\r\nmode & W_OK is passed in. This has the advantage that users are still able to\r\ndescend into /var/lib/lxcfs/cgroup via:\r\n\r\n        cd /var/lib/lxcfs/cgroup\r\n\r\nbut are still blocked from doing any write operations.\r\n\r\nSigned-off-by: Christian Brauner <cbrauner@suse.de>","created_at":"2016-08-26T08:04:39Z","updated_at":"2016-08-26T08:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxcfs/pulls/136/commits","review_comments_url":"https://api.github.com/repos/lxc/lxcfs/pulls/136/comments","review_comment_url":"https://api.github.com/repos/lxc/lxcfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxcfs/issues/136/comments","statuses_url":"https://api.github.com/repos/lxc/lxcfs/statuses/5ccc353f1fb14ce36ad6ec738ca709336fe4d312","head":{"label":"brauner:2016-08-21/bugfixes","ref":"2016-08-21/bugfixes","sha":"5ccc353f1fb14ce36ad6ec738ca709336fe4d312","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"repo":{"id":30824376,"name":"lxcfs","full_name":"brauner/lxcfs","owner":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brauner/lxcfs","description":"FUSE filesystem for LXC","fork":true,"url":"https://api.github.com/repos/brauner/lxcfs","forks_url":"https://api.github.com/repos/brauner/lxcfs/forks","keys_url":"https://api.github.com/repos/brauner/lxcfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brauner/lxcfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brauner/lxcfs/teams","hooks_url":"https://api.github.com/repos/brauner/lxcfs/hooks","issue_events_url":"https://api.github.com/repos/brauner/lxcfs/issues/events{/number}","events_url":"https://api.github.com/repos/brauner/lxcfs/events","assignees_url":"https://api.github.com/repos/brauner/lxcfs/assignees{/user}","branches_url":"https://api.github.com/repos/brauner/lxcfs/branches{/branch}","tags_url":"https://api.github.com/repos/brauner/lxcfs/tags","blobs_url":"https://api.github.com/repos/brauner/lxcfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brauner/lxcfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brauner/lxcfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/brauner/lxcfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brauner/lxcfs/statuses/{sha}","languages_url":"https://api.github.com/repos/brauner/lxcfs/languages","stargazers_url":"https://api.github.com/repos/brauner/lxcfs/stargazers","contributors_url":"https://api.github.com/repos/brauner/lxcfs/contributors","subscribers_url":"https://api.github.com/repos/brauner/lxcfs/subscribers","subscription_url":"https://api.github.com/repos/brauner/lxcfs/subscription","commits_url":"https://api.github.com/repos/brauner/lxcfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/brauner/lxcfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/brauner/lxcfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/brauner/lxcfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/brauner/lxcfs/contents/{+path}","compare_url":"https://api.github.com/repos/brauner/lxcfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brauner/lxcfs/merges","archive_url":"https://api.github.com/repos/brauner/lxcfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brauner/lxcfs/downloads","issues_url":"https://api.github.com/repos/brauner/lxcfs/issues{/number}","pulls_url":"https://api.github.com/repos/brauner/lxcfs/pulls{/number}","milestones_url":"https://api.github.com/repos/brauner/lxcfs/milestones{/number}","notifications_url":"https://api.github.com/repos/brauner/lxcfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brauner/lxcfs/labels{/name}","releases_url":"https://api.github.com/repos/brauner/lxcfs/releases{/id}","deployments_url":"https://api.github.com/repos/brauner/lxcfs/deployments","created_at":"2015-02-15T10:26:24Z","updated_at":"2015-02-16T18:09:19Z","pushed_at":"2016-08-26T08:03:49Z","git_url":"git://github.com/brauner/lxcfs.git","ssh_url":"git@github.com:brauner/lxcfs.git","clone_url":"https://github.com/brauner/lxcfs.git","svn_url":"https://github.com/brauner/lxcfs","homepage":"https://linuxcontainers.org","size":595,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"3d65132fedf79613ba2766e04e6acfdbc0f1a071","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":27918935,"name":"lxcfs","full_name":"lxc/lxcfs","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxcfs","description":"FUSE filesystem for LXC","fork":false,"url":"https://api.github.com/repos/lxc/lxcfs","forks_url":"https://api.github.com/repos/lxc/lxcfs/forks","keys_url":"https://api.github.com/repos/lxc/lxcfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxcfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxcfs/teams","hooks_url":"https://api.github.com/repos/lxc/lxcfs/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxcfs/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxcfs/events","assignees_url":"https://api.github.com/repos/lxc/lxcfs/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxcfs/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxcfs/tags","blobs_url":"https://api.github.com/repos/lxc/lxcfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxcfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxcfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxcfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxcfs/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxcfs/languages","stargazers_url":"https://api.github.com/repos/lxc/lxcfs/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxcfs/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxcfs/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxcfs/subscription","commits_url":"https://api.github.com/repos/lxc/lxcfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxcfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxcfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxcfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxcfs/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxcfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxcfs/merges","archive_url":"https://api.github.com/repos/lxc/lxcfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxcfs/downloads","issues_url":"https://api.github.com/repos/lxc/lxcfs/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxcfs/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxcfs/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxcfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxcfs/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxcfs/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxcfs/deployments","created_at":"2014-12-12T12:07:40Z","updated_at":"2016-08-22T21:21:07Z","pushed_at":"2016-08-26T07:37:01Z","git_url":"git://github.com/lxc/lxcfs.git","ssh_url":"git@github.com:lxc/lxcfs.git","clone_url":"https://github.com/lxc/lxcfs.git","svn_url":"https://github.com/lxc/lxcfs","homepage":"https://linuxcontainers.org/lxcfs","size":644,"stargazers_count":104,"watchers_count":104,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":9,"forks":45,"open_issues":9,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxcfs/pulls/136"},"html":{"href":"https://github.com/lxc/lxcfs/pull/136"},"issue":{"href":"https://api.github.com/repos/lxc/lxcfs/issues/136"},"comments":{"href":"https://api.github.com/repos/lxc/lxcfs/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxcfs/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxcfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxcfs/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxcfs/statuses/5ccc353f1fb14ce36ad6ec738ca709336fe4d312"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"brauner"}}