{"action":"created","issue":{"url":"https://api.github.com/repos/mholt/caddy/issues/924","repository_url":"https://api.github.com/repos/mholt/caddy","labels_url":"https://api.github.com/repos/mholt/caddy/issues/924/labels{/name}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/924/comments","events_url":"https://api.github.com/repos/mholt/caddy/issues/924/events","html_url":"https://github.com/mholt/caddy/issues/924","id":164149877,"number":924,"title":"Proxy preset \"transparent\" should use X-Forwarded-For","user":{"login":"cederberg","id":11371,"avatar_url":"https://avatars.githubusercontent.com/u/11371?v=3","gravatar_id":"","url":"https://api.github.com/users/cederberg","html_url":"https://github.com/cederberg","followers_url":"https://api.github.com/users/cederberg/followers","following_url":"https://api.github.com/users/cederberg/following{/other_user}","gists_url":"https://api.github.com/users/cederberg/gists{/gist_id}","starred_url":"https://api.github.com/users/cederberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cederberg/subscriptions","organizations_url":"https://api.github.com/users/cederberg/orgs","repos_url":"https://api.github.com/users/cederberg/repos","events_url":"https://api.github.com/users/cederberg/events{/privacy}","received_events_url":"https://api.github.com/users/cederberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-06T19:02:11Z","updated_at":"2016-07-07T09:58:22Z","closed_at":null,"body":"The new proxy `transparent` preset is defined to used `X-Real-IP`, but should probably use `X-Forwarded-For` instead. Wikipedia actually has great docs for this: https://en.wikipedia.org/wiki/X-Forwarded-For\r\n\r\nSame goes for the docs example that currently recommends `X-Real-IP`.\r\n\r\nWeirdly, Nginx seems to default to `X-Real-IP`. No reason stated though. And a quick googling shows that `X-Real-IP` has caused lots of confusion and config errors. Should be avoided."},"comment":{"url":"https://api.github.com/repos/mholt/caddy/issues/comments/231035495","html_url":"https://github.com/mholt/caddy/issues/924#issuecomment-231035495","issue_url":"https://api.github.com/repos/mholt/caddy/issues/924","id":231035495,"user":{"login":"stp-ip","id":3768412,"avatar_url":"https://avatars.githubusercontent.com/u/3768412?v=3","gravatar_id":"","url":"https://api.github.com/users/stp-ip","html_url":"https://github.com/stp-ip","followers_url":"https://api.github.com/users/stp-ip/followers","following_url":"https://api.github.com/users/stp-ip/following{/other_user}","gists_url":"https://api.github.com/users/stp-ip/gists{/gist_id}","starred_url":"https://api.github.com/users/stp-ip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stp-ip/subscriptions","organizations_url":"https://api.github.com/users/stp-ip/orgs","repos_url":"https://api.github.com/users/stp-ip/repos","events_url":"https://api.github.com/users/stp-ip/events{/privacy}","received_events_url":"https://api.github.com/users/stp-ip/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T09:58:22Z","updated_at":"2016-07-07T09:58:22Z","body":"That should in my opinion not prevent us from using both as default. "}}
{"actor":{"display_login":"stp-ip"}}