{"action":"created","comment":{"url":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments/61013241","id":61013241,"diff_hunk":"@@ -27,26 +27,132 @@ import (\n \t\"github.com/intelsdi-x/snap/core/cdata\"\n )\n \n-type Label struct {\n-\tIndex int    `json:\"index\"`\n-\tName  string `json:\"name\"`\n-}\n+var (\n+\t// Standard Tags are in added to the metric by the framework on plugin load.\n+\t// STD_TAG_PLUGIN_RUNNING_ON describes where the plugin is running (hostname).\n+\tSTD_TAG_PLUGIN_RUNNING_ON = \"plugin_running_on\"\n+)\n \n // Metric represents a snap metric collected or to be collected\n type Metric interface {\n \tRequestedMetric\n \tConfig() *cdata.ConfigDataNode\n \tLastAdvertisedTime() time.Time\n \tData() interface{}\n-\tSource() string\n-\tLabels() []Label\n \tTags() map[string]string\n \tTimestamp() time.Time\n+\tDescription() string\n+\tUnit() string\n+}\n+\n+type Namespace []NamespaceElement\n+\n+// String returns the string representation of the namespace with \"/\" joining\n+// the elements of the namespace.  A leading \"/\" is added.\n+func (n Namespace) String() string {\n+\tns := \"\"\n+\tfor i, x := range n {\n+\t\tif i == 0 {\n+\t\t\tns = \"/\"\n+\t\t}","path":"core/metric.go","position":37,"original_position":37,"commit_id":"e3576b78e665d04f1d6127c53cda9d83f1375b7c","original_commit_id":"e3576b78e665d04f1d6127c53cda9d83f1375b7c","user":{"login":"jcooklin","id":862968,"avatar_url":"https://avatars.githubusercontent.com/u/862968?v=3","gravatar_id":"","url":"https://api.github.com/users/jcooklin","html_url":"https://github.com/jcooklin","followers_url":"https://api.github.com/users/jcooklin/followers","following_url":"https://api.github.com/users/jcooklin/following{/other_user}","gists_url":"https://api.github.com/users/jcooklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcooklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcooklin/subscriptions","organizations_url":"https://api.github.com/users/jcooklin/orgs","repos_url":"https://api.github.com/users/jcooklin/repos","events_url":"https://api.github.com/users/jcooklin/events{/privacy}","received_events_url":"https://api.github.com/users/jcooklin/received_events","type":"User","site_admin":false},"body":"Yep.","created_at":"2016-04-26T00:30:23Z","updated_at":"2016-04-26T00:30:23Z","html_url":"https://github.com/intelsdi-x/snap/pull/872#discussion_r61013241","pull_request_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/872","_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments/61013241"},"html":{"href":"https://github.com/intelsdi-x/snap/pull/872#discussion_r61013241"},"pull_request":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/872"}}},"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap/pulls/872","id":67455440,"html_url":"https://github.com/intelsdi-x/snap/pull/872","diff_url":"https://github.com/intelsdi-x/snap/pull/872.diff","patch_url":"https://github.com/intelsdi-x/snap/pull/872.patch","issue_url":"https://api.github.com/repos/intelsdi-x/snap/issues/872","number":872,"state":"open","locked":false,"title":"Metric schema and metadata","user":{"login":"jcooklin","id":862968,"avatar_url":"https://avatars.githubusercontent.com/u/862968?v=3","gravatar_id":"","url":"https://api.github.com/users/jcooklin","html_url":"https://github.com/jcooklin","followers_url":"https://api.github.com/users/jcooklin/followers","following_url":"https://api.github.com/users/jcooklin/following{/other_user}","gists_url":"https://api.github.com/users/jcooklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcooklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcooklin/subscriptions","organizations_url":"https://api.github.com/users/jcooklin/orgs","repos_url":"https://api.github.com/users/jcooklin/repos","events_url":"https://api.github.com/users/jcooklin/events{/privacy}","received_events_url":"https://api.github.com/users/jcooklin/received_events","type":"User","site_admin":false},"body":"Fixes #871 - Metric schema metadata \r\n\r\nSummary of changes:\r\n- [x] Add (long) description to a cataloged metric\r\n- [x] Add (short) description of namespace elements\r\n- [x] Add the field 'unit'\r\n- [x] Remove the field 'source'\r\n- [x] Add standard tags\r\n- [x] Replace the field label with the same behavior on the namespace \r\n\r\n\r\nTesting done:\r\n- unit\r\n- functional\r\n- manual\r\n\r\n@intelsdi-x/snap-maintainers","created_at":"2016-04-22T03:43:53Z","updated_at":"2016-04-26T00:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98fb0542c7bb7b3b2a45649cc360c2113ced7720","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/872/commits","review_comments_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/872/comments","review_comment_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intelsdi-x/snap/issues/872/comments","statuses_url":"https://api.github.com/repos/intelsdi-x/snap/statuses/e3576b78e665d04f1d6127c53cda9d83f1375b7c","head":{"label":"jcooklin:schema","ref":"schema","sha":"e3576b78e665d04f1d6127c53cda9d83f1375b7c","user":{"login":"jcooklin","id":862968,"avatar_url":"https://avatars.githubusercontent.com/u/862968?v=3","gravatar_id":"","url":"https://api.github.com/users/jcooklin","html_url":"https://github.com/jcooklin","followers_url":"https://api.github.com/users/jcooklin/followers","following_url":"https://api.github.com/users/jcooklin/following{/other_user}","gists_url":"https://api.github.com/users/jcooklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcooklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcooklin/subscriptions","organizations_url":"https://api.github.com/users/jcooklin/orgs","repos_url":"https://api.github.com/users/jcooklin/repos","events_url":"https://api.github.com/users/jcooklin/events{/privacy}","received_events_url":"https://api.github.com/users/jcooklin/received_events","type":"User","site_admin":false},"repo":{"id":47266708,"name":"snap","full_name":"jcooklin/snap","owner":{"login":"jcooklin","id":862968,"avatar_url":"https://avatars.githubusercontent.com/u/862968?v=3","gravatar_id":"","url":"https://api.github.com/users/jcooklin","html_url":"https://github.com/jcooklin","followers_url":"https://api.github.com/users/jcooklin/followers","following_url":"https://api.github.com/users/jcooklin/following{/other_user}","gists_url":"https://api.github.com/users/jcooklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcooklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcooklin/subscriptions","organizations_url":"https://api.github.com/users/jcooklin/orgs","repos_url":"https://api.github.com/users/jcooklin/repos","events_url":"https://api.github.com/users/jcooklin/events{/privacy}","received_events_url":"https://api.github.com/users/jcooklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcooklin/snap","description":"A powerful telemetry framework","fork":true,"url":"https://api.github.com/repos/jcooklin/snap","forks_url":"https://api.github.com/repos/jcooklin/snap/forks","keys_url":"https://api.github.com/repos/jcooklin/snap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcooklin/snap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcooklin/snap/teams","hooks_url":"https://api.github.com/repos/jcooklin/snap/hooks","issue_events_url":"https://api.github.com/repos/jcooklin/snap/issues/events{/number}","events_url":"https://api.github.com/repos/jcooklin/snap/events","assignees_url":"https://api.github.com/repos/jcooklin/snap/assignees{/user}","branches_url":"https://api.github.com/repos/jcooklin/snap/branches{/branch}","tags_url":"https://api.github.com/repos/jcooklin/snap/tags","blobs_url":"https://api.github.com/repos/jcooklin/snap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcooklin/snap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcooklin/snap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcooklin/snap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcooklin/snap/statuses/{sha}","languages_url":"https://api.github.com/repos/jcooklin/snap/languages","stargazers_url":"https://api.github.com/repos/jcooklin/snap/stargazers","contributors_url":"https://api.github.com/repos/jcooklin/snap/contributors","subscribers_url":"https://api.github.com/repos/jcooklin/snap/subscribers","subscription_url":"https://api.github.com/repos/jcooklin/snap/subscription","commits_url":"https://api.github.com/repos/jcooklin/snap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcooklin/snap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcooklin/snap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcooklin/snap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcooklin/snap/contents/{+path}","compare_url":"https://api.github.com/repos/jcooklin/snap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcooklin/snap/merges","archive_url":"https://api.github.com/repos/jcooklin/snap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcooklin/snap/downloads","issues_url":"https://api.github.com/repos/jcooklin/snap/issues{/number}","pulls_url":"https://api.github.com/repos/jcooklin/snap/pulls{/number}","milestones_url":"https://api.github.com/repos/jcooklin/snap/milestones{/number}","notifications_url":"https://api.github.com/repos/jcooklin/snap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcooklin/snap/labels{/name}","releases_url":"https://api.github.com/repos/jcooklin/snap/releases{/id}","deployments_url":"https://api.github.com/repos/jcooklin/snap/deployments","created_at":"2015-12-02T14:35:42Z","updated_at":"2015-12-02T14:35:44Z","pushed_at":"2016-04-25T21:35:42Z","git_url":"git://github.com/jcooklin/snap.git","ssh_url":"git@github.com:jcooklin/snap.git","clone_url":"https://github.com/jcooklin/snap.git","svn_url":"https://github.com/jcooklin/snap","homepage":"http://github.com/intelsdi-x/snap","size":10018,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intelsdi-x:master","ref":"master","sha":"d122e471137e1e61f65e70fa5835c907846eb211","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":22931257,"name":"snap","full_name":"intelsdi-x/snap","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/snap","description":"The open telemetry framework","fork":false,"url":"https://api.github.com/repos/intelsdi-x/snap","forks_url":"https://api.github.com/repos/intelsdi-x/snap/forks","keys_url":"https://api.github.com/repos/intelsdi-x/snap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/snap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/snap/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/snap/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/snap/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/snap/events","assignees_url":"https://api.github.com/repos/intelsdi-x/snap/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/snap/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/snap/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/snap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/snap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/snap/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/snap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/snap/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/snap/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/snap/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/snap/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/snap/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/snap/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/snap/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/snap/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/snap/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/snap/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/snap/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/snap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/snap/merges","archive_url":"https://api.github.com/repos/intelsdi-x/snap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/snap/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/snap/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/snap/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/snap/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/snap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/snap/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/snap/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/snap/deployments","created_at":"2014-08-13T21:04:51Z","updated_at":"2016-04-25T14:04:46Z","pushed_at":"2016-04-25T21:35:42Z","git_url":"git://github.com/intelsdi-x/snap.git","ssh_url":"git@github.com:intelsdi-x/snap.git","clone_url":"https://github.com/intelsdi-x/snap.git","svn_url":"https://github.com/intelsdi-x/snap","homepage":"http://intelsdi-x.github.io/snap/","size":23005,"stargazers_count":674,"watchers_count":674,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":80,"mirror_url":null,"open_issues_count":81,"forks":80,"open_issues":81,"watchers":674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/872"},"html":{"href":"https://github.com/intelsdi-x/snap/pull/872"},"issue":{"href":"https://api.github.com/repos/intelsdi-x/snap/issues/872"},"comments":{"href":"https://api.github.com/repos/intelsdi-x/snap/issues/872/comments"},"review_comments":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/872/comments"},"review_comment":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/872/commits"},"statuses":{"href":"https://api.github.com/repos/intelsdi-x/snap/statuses/e3576b78e665d04f1d6127c53cda9d83f1375b7c"}}}}