{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/80159842","id":80159842,"diff_hunk":"@@ -85,13 +82,24 @@ exports.init = function (cli) {\n         }\n       })();\n \n-      var keyType = options.keyType ? options.keyType : 'AsymmetricX509Cert';\n-      var keyUsage = options.keyUsage ? options.keyUsage : 'Verify';\n+      if (options.available) {\n+        if (options.available.toLowerCase() === 'true') {\n+          options.available = true;\n+        }\n+        else if (options.available.toLowerCase() === 'false') {\n+          options.available = false;\n+        } else {\n+          throw new Error($('Invalid value for --available parameter. Please specify \"true\" for a multi-tenant application or \"false\" for a single-tenant application.'));\n+        }\n+      }","path":"lib/commands/arm/ad/ad.application._js","position":50,"original_position":50,"commit_id":"c187dd5a4990af06594e996d28a49b7dc918cf03","original_commit_id":"c187dd5a4990af06594e996d28a49b7dc918cf03","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"The entire above logic goes away. Simply pass options.available to the sdk ","created_at":"2016-09-22T23:50:18Z","updated_at":"2016-09-22T23:50:18Z","html_url":"https://github.com/Azure/azure-xplat-cli/pull/3194#discussion_r80159842","pull_request_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/80159842"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/3194#discussion_r80159842"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194","id":86425748,"html_url":"https://github.com/Azure/azure-xplat-cli/pull/3194","diff_url":"https://github.com/Azure/azure-xplat-cli/pull/3194.diff","patch_url":"https://github.com/Azure/azure-xplat-cli/pull/3194.patch","issue_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3194","number":3194,"state":"open","locked":false,"title":"Modify AD graph commands to sync credential management in app/sp and other fixes","user":{"login":"shuagarw","id":10227276,"avatar_url":"https://avatars.githubusercontent.com/u/10227276?v=3","gravatar_id":"","url":"https://api.github.com/users/shuagarw","html_url":"https://github.com/shuagarw","followers_url":"https://api.github.com/users/shuagarw/followers","following_url":"https://api.github.com/users/shuagarw/following{/other_user}","gists_url":"https://api.github.com/users/shuagarw/gists{/gist_id}","starred_url":"https://api.github.com/users/shuagarw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuagarw/subscriptions","organizations_url":"https://api.github.com/users/shuagarw/orgs","repos_url":"https://api.github.com/users/shuagarw/repos","events_url":"https://api.github.com/users/shuagarw/events{/privacy}","received_events_url":"https://api.github.com/users/shuagarw/received_events","type":"User","site_admin":false},"body":"The content to be added to Changelog is as follows:\r\n* Simplify ServicePrincipal creation when there is no corresponding existing application.\r\n* Simplify credential creation for new/update app and servicePrincipal \r\n","created_at":"2016-09-22T22:28:08Z","updated_at":"2016-09-22T23:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d352ae99bd6371faa87a038f41f5ff721004e4a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3194/comments","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/c187dd5a4990af06594e996d28a49b7dc918cf03","head":{"label":"shuagarw:releaseBranch","ref":"releaseBranch","sha":"c187dd5a4990af06594e996d28a49b7dc918cf03","user":{"login":"shuagarw","id":10227276,"avatar_url":"https://avatars.githubusercontent.com/u/10227276?v=3","gravatar_id":"","url":"https://api.github.com/users/shuagarw","html_url":"https://github.com/shuagarw","followers_url":"https://api.github.com/users/shuagarw/followers","following_url":"https://api.github.com/users/shuagarw/following{/other_user}","gists_url":"https://api.github.com/users/shuagarw/gists{/gist_id}","starred_url":"https://api.github.com/users/shuagarw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuagarw/subscriptions","organizations_url":"https://api.github.com/users/shuagarw/orgs","repos_url":"https://api.github.com/users/shuagarw/repos","events_url":"https://api.github.com/users/shuagarw/events{/privacy}","received_events_url":"https://api.github.com/users/shuagarw/received_events","type":"User","site_admin":false},"repo":{"id":40202798,"name":"azure-xplat-cli","full_name":"shuagarw/azure-xplat-cli","owner":{"login":"shuagarw","id":10227276,"avatar_url":"https://avatars.githubusercontent.com/u/10227276?v=3","gravatar_id":"","url":"https://api.github.com/users/shuagarw","html_url":"https://github.com/shuagarw","followers_url":"https://api.github.com/users/shuagarw/followers","following_url":"https://api.github.com/users/shuagarw/following{/other_user}","gists_url":"https://api.github.com/users/shuagarw/gists{/gist_id}","starred_url":"https://api.github.com/users/shuagarw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuagarw/subscriptions","organizations_url":"https://api.github.com/users/shuagarw/orgs","repos_url":"https://api.github.com/users/shuagarw/repos","events_url":"https://api.github.com/users/shuagarw/events{/privacy}","received_events_url":"https://api.github.com/users/shuagarw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuagarw/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":true,"url":"https://api.github.com/repos/shuagarw/azure-xplat-cli","forks_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/shuagarw/azure-xplat-cli/deployments","created_at":"2015-08-04T18:42:48Z","updated_at":"2016-02-26T22:06:14Z","pushed_at":"2016-09-22T22:23:01Z","git_url":"git://github.com/shuagarw/azure-xplat-cli.git","ssh_url":"git@github.com:shuagarw/azure-xplat-cli.git","clone_url":"https://github.com/shuagarw/azure-xplat-cli.git","svn_url":"https://github.com/shuagarw/azure-xplat-cli","homepage":"","size":86721,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:release-0.10.5","ref":"release-0.10.5","sha":"a4bc9dfc8c940a79b8b635c95fe156b81d1e3096","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":6506651,"name":"azure-xplat-cli","full_name":"Azure/azure-xplat-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Azure/azure-xplat-cli","forks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/deployments","created_at":"2012-11-02T13:43:50Z","updated_at":"2016-09-21T10:16:01Z","pushed_at":"2016-09-22T22:28:09Z","git_url":"git://github.com/Azure/azure-xplat-cli.git","ssh_url":"git@github.com:Azure/azure-xplat-cli.git","clone_url":"https://github.com/Azure/azure-xplat-cli.git","svn_url":"https://github.com/Azure/azure-xplat-cli","homepage":"","size":104119,"stargazers_count":486,"watchers_count":486,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":187,"forks":348,"open_issues":187,"watchers":486,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/3194"},"issue":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3194"},"comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3194/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3194/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/c187dd5a4990af06594e996d28a49b7dc918cf03"}}}}
{"actor":{"display_login":"amarzavery"}}