{"action":"created","issue":{"url":"https://api.github.com/repos/stevenjack/cfndsl/issues/171","repository_url":"https://api.github.com/repos/stevenjack/cfndsl","labels_url":"https://api.github.com/repos/stevenjack/cfndsl/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/stevenjack/cfndsl/issues/171/comments","events_url":"https://api.github.com/repos/stevenjack/cfndsl/issues/171/events","html_url":"https://github.com/stevenjack/cfndsl/issues/171","id":145635226,"number":171,"title":"Code cleanup and improvments - Help needed","user":{"login":"stevenjack","id":527874,"avatar_url":"https://avatars.githubusercontent.com/u/527874?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenjack","html_url":"https://github.com/stevenjack","followers_url":"https://api.github.com/users/stevenjack/followers","following_url":"https://api.github.com/users/stevenjack/following{/other_user}","gists_url":"https://api.github.com/users/stevenjack/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenjack/subscriptions","organizations_url":"https://api.github.com/users/stevenjack/orgs","repos_url":"https://api.github.com/users/stevenjack/repos","events_url":"https://api.github.com/users/stevenjack/events{/privacy}","received_events_url":"https://api.github.com/users/stevenjack/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stevenjack/cfndsl/labels/Enhancement","name":"Enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-04T09:50:16Z","updated_at":"2016-04-09T14:21:04Z","closed_at":null,"body":"We're working to improve the code base allowing easier contributions and better test coverage.\r\n\r\nOne of the first passes on this is to get rubocop passing with a minimal set of cops, then gradually increase them as we clean the code base.\r\n\r\nThe first step has been completed and I'd like to ask anyone using `cfndsl` to try out this pre release gem (work in [this](https://github.com/stevenjack/cfndsl/pull/161) PR):\r\n\r\n`$: gem install cfndsl --pre`\r\n\r\nto make sure that we're not breaking any of the more complex templates people have out there. Obviously this would be covered by a test suite, although as we moved things around the code base a little we started to notice quite a few holes in the current test suite.\r\n\r\nPlease let me know of any issues you encounter in this issue.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stevenjack/cfndsl/issues/comments/207795069","html_url":"https://github.com/stevenjack/cfndsl/issues/171#issuecomment-207795069","issue_url":"https://api.github.com/repos/stevenjack/cfndsl/issues/171","id":207795069,"user":{"login":"kornypoet","id":260766,"avatar_url":"https://avatars.githubusercontent.com/u/260766?v=3","gravatar_id":"","url":"https://api.github.com/users/kornypoet","html_url":"https://github.com/kornypoet","followers_url":"https://api.github.com/users/kornypoet/followers","following_url":"https://api.github.com/users/kornypoet/following{/other_user}","gists_url":"https://api.github.com/users/kornypoet/gists{/gist_id}","starred_url":"https://api.github.com/users/kornypoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kornypoet/subscriptions","organizations_url":"https://api.github.com/users/kornypoet/orgs","repos_url":"https://api.github.com/users/kornypoet/repos","events_url":"https://api.github.com/users/kornypoet/events{/privacy}","received_events_url":"https://api.github.com/users/kornypoet/received_events","type":"User","site_admin":false},"created_at":"2016-04-09T14:21:04Z","updated_at":"2016-04-09T14:21:04Z","body":"Nothing unexpected. I have some more types to add to `aws_types.yaml` and I wanted to make the PR against the latest `pre` branch."}}