{"action":"created","issue":{"url":"https://api.github.com/repos/betaflight/betaflight/issues/535","repository_url":"https://api.github.com/repos/betaflight/betaflight","labels_url":"https://api.github.com/repos/betaflight/betaflight/issues/535/labels{/name}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/535/comments","events_url":"https://api.github.com/repos/betaflight/betaflight/issues/535/events","html_url":"https://github.com/betaflight/betaflight/issues/535","id":160791094,"number":535,"title":"Hardware Revisions - should a build specifically deal with a hardware revision","user":{"login":"blckmn","id":6168871,"avatar_url":"https://avatars.githubusercontent.com/u/6168871?v=3","gravatar_id":"","url":"https://api.github.com/users/blckmn","html_url":"https://github.com/blckmn","followers_url":"https://api.github.com/users/blckmn/followers","following_url":"https://api.github.com/users/blckmn/following{/other_user}","gists_url":"https://api.github.com/users/blckmn/gists{/gist_id}","starred_url":"https://api.github.com/users/blckmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blckmn/subscriptions","organizations_url":"https://api.github.com/users/blckmn/orgs","repos_url":"https://api.github.com/users/blckmn/repos","events_url":"https://api.github.com/users/blckmn/events{/privacy}","received_events_url":"https://api.github.com/users/blckmn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/betaflight/betaflight/labels/Discussion%20Needed","name":"Discussion Needed","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-06-17T00:41:56Z","updated_at":"2016-06-17T07:15:23Z","closed_at":null,"body":"At the moment there is a code associated with detecting hardware revisions etc - which is needed in a lot of places.\r\n\r\nSuggestion for discussion:\r\nNow that we have a new target directory based setup, would it be suitable to use the same (i.e. alternate targets) for hardware revisions.\r\n\r\ne.g. NAZE_REV4.mk, add the REV4 define to device flags (adjust target.h based on the define), and then strip out any hardware revision specific code.\r\n\r\n@martinbudden @borisbstyle your thoughts?"},"comment":{"url":"https://api.github.com/repos/betaflight/betaflight/issues/comments/226697805","html_url":"https://github.com/betaflight/betaflight/issues/535#issuecomment-226697805","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/535","id":226697805,"user":{"login":"martinbudden","id":194586,"avatar_url":"https://avatars.githubusercontent.com/u/194586?v=3","gravatar_id":"","url":"https://api.github.com/users/martinbudden","html_url":"https://github.com/martinbudden","followers_url":"https://api.github.com/users/martinbudden/followers","following_url":"https://api.github.com/users/martinbudden/following{/other_user}","gists_url":"https://api.github.com/users/martinbudden/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbudden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbudden/subscriptions","organizations_url":"https://api.github.com/users/martinbudden/orgs","repos_url":"https://api.github.com/users/martinbudden/repos","events_url":"https://api.github.com/users/martinbudden/events{/privacy}","received_events_url":"https://api.github.com/users/martinbudden/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T07:15:23Z","updated_at":"2016-06-17T07:15:23Z","body":"Yes, I think moving it into config is probably the way to go.\r\n\r\nI am, however, a bit wary of doing to much work in this area just at the moment. Changes to init and config can accidentally break things, and I don't think either of us have the hardware or the time to test all the different boards.\r\n\r\nWe are already in the desirable position whereby new targets can be added by just adding a new target directory, and we have shown this with a handful of boards.\r\n\r\nThere is nothing that is essential to get into the 3.0 release, and so I think I would be in favour of deferring further improvements to 3.0.1. I know we are on a bit of a roll at the moment and it is tempting to carry on, but sometimes it is best to stop and consolidate and then move on later.\r\n\r\nI'm also wary of getting too far ahead of Cleanflight. I'm pretty sure when @hydra sees these changes he'll have suggestions for improvements and changes he'll want to make before accepting them into Cleanflight.\r\n\r\n"}}
{"actor":{"display_login":"martinbudden"}}