{"action":"created","comment":{"url":"https://api.github.com/repos/cvogt/cbt/pulls/comments/69689994","id":69689994,"diff_hunk":"@@ -113,13 +113,44 @@ public static ClassLoader classLoader( String file, ClassLoader parent ) throws\n       new URL[]{ new URL(\"file:\"+file) }, parent\n     );\n   }\n+\n+  private static void updateProxyPropOrEnv(String envKey, String pHost, String pPort) {\n+    String value = System.getProperty(pHost);\n+    if(value==null || value.isEmpty()) {\n+      String proxy = System.getenv(envKey);\n+      if(proxy==null || proxy.isEmpty()) {\n+        proxy = System.getenv(envKey.toUpperCase());\n+      }\n+      if(proxy!=null && !proxy.isEmpty()) {\n+        String[] s = proxy.replaceFirst(\"^https?://\", \"\").split(\":\", 2);","path":"nailgun_launcher/Stage0Lib.java","position":22,"original_position":22,"commit_id":"457369577eb52cf187ef4eb109f50ef56cdd21bd","original_commit_id":"0944d40621ad8c459018c14a47b1b5b354c984fa","user":{"login":"benjaminfrank","id":13114612,"avatar_url":"https://avatars.githubusercontent.com/u/13114612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminfrank","html_url":"https://github.com/benjaminfrank","followers_url":"https://api.github.com/users/benjaminfrank/followers","following_url":"https://api.github.com/users/benjaminfrank/following{/other_user}","gists_url":"https://api.github.com/users/benjaminfrank/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminfrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminfrank/subscriptions","organizations_url":"https://api.github.com/users/benjaminfrank/orgs","repos_url":"https://api.github.com/users/benjaminfrank/repos","events_url":"https://api.github.com/users/benjaminfrank/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminfrank/received_events","type":"User","site_admin":false},"body":"mildly interesting, that link(s) above are real links and i just made them up when I wrote the comment :)","created_at":"2016-07-06T08:12:32Z","updated_at":"2016-07-06T08:12:32Z","html_url":"https://github.com/cvogt/cbt/pull/200#discussion_r69689994","pull_request_url":"https://api.github.com/repos/cvogt/cbt/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/comments/69689994"},"html":{"href":"https://github.com/cvogt/cbt/pull/200#discussion_r69689994"},"pull_request":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/cvogt/cbt/pulls/200","id":76331797,"html_url":"https://github.com/cvogt/cbt/pull/200","diff_url":"https://github.com/cvogt/cbt/pull/200.diff","patch_url":"https://github.com/cvogt/cbt/pull/200.patch","issue_url":"https://api.github.com/repos/cvogt/cbt/issues/200","number":200,"state":"open","locked":false,"title":"Support proxy settings in CBT.","user":{"login":"benjaminfrank","id":13114612,"avatar_url":"https://avatars.githubusercontent.com/u/13114612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminfrank","html_url":"https://github.com/benjaminfrank","followers_url":"https://api.github.com/users/benjaminfrank/followers","following_url":"https://api.github.com/users/benjaminfrank/following{/other_user}","gists_url":"https://api.github.com/users/benjaminfrank/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminfrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminfrank/subscriptions","organizations_url":"https://api.github.com/users/benjaminfrank/orgs","repos_url":"https://api.github.com/users/benjaminfrank/repos","events_url":"https://api.github.com/users/benjaminfrank/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminfrank/received_events","type":"User","site_admin":false},"body":"Proxy settings can be supplied either via Java systemproperties or via\r\nenvironment variables (http_proxy / https_proxy). Java systemproperties\r\ntake precedence over env vars.\r\nEvaluation of proxy settings happens only during nailgun startup for now.","created_at":"2016-07-05T19:48:27Z","updated_at":"2016-07-06T08:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86895c17540acef0a5bc77bfeddccca922674464","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cvogt/cbt/pulls/200/commits","review_comments_url":"https://api.github.com/repos/cvogt/cbt/pulls/200/comments","review_comment_url":"https://api.github.com/repos/cvogt/cbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cvogt/cbt/issues/200/comments","statuses_url":"https://api.github.com/repos/cvogt/cbt/statuses/457369577eb52cf187ef4eb109f50ef56cdd21bd","head":{"label":"benjaminfrank:feature/proxy_support","ref":"feature/proxy_support","sha":"457369577eb52cf187ef4eb109f50ef56cdd21bd","user":{"login":"benjaminfrank","id":13114612,"avatar_url":"https://avatars.githubusercontent.com/u/13114612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminfrank","html_url":"https://github.com/benjaminfrank","followers_url":"https://api.github.com/users/benjaminfrank/followers","following_url":"https://api.github.com/users/benjaminfrank/following{/other_user}","gists_url":"https://api.github.com/users/benjaminfrank/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminfrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminfrank/subscriptions","organizations_url":"https://api.github.com/users/benjaminfrank/orgs","repos_url":"https://api.github.com/users/benjaminfrank/repos","events_url":"https://api.github.com/users/benjaminfrank/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminfrank/received_events","type":"User","site_admin":false},"repo":{"id":62637907,"name":"cbt","full_name":"benjaminfrank/cbt","owner":{"login":"benjaminfrank","id":13114612,"avatar_url":"https://avatars.githubusercontent.com/u/13114612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminfrank","html_url":"https://github.com/benjaminfrank","followers_url":"https://api.github.com/users/benjaminfrank/followers","following_url":"https://api.github.com/users/benjaminfrank/following{/other_user}","gists_url":"https://api.github.com/users/benjaminfrank/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminfrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminfrank/subscriptions","organizations_url":"https://api.github.com/users/benjaminfrank/orgs","repos_url":"https://api.github.com/users/benjaminfrank/repos","events_url":"https://api.github.com/users/benjaminfrank/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminfrank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminfrank/cbt","description":"CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala","fork":true,"url":"https://api.github.com/repos/benjaminfrank/cbt","forks_url":"https://api.github.com/repos/benjaminfrank/cbt/forks","keys_url":"https://api.github.com/repos/benjaminfrank/cbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminfrank/cbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminfrank/cbt/teams","hooks_url":"https://api.github.com/repos/benjaminfrank/cbt/hooks","issue_events_url":"https://api.github.com/repos/benjaminfrank/cbt/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminfrank/cbt/events","assignees_url":"https://api.github.com/repos/benjaminfrank/cbt/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminfrank/cbt/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminfrank/cbt/tags","blobs_url":"https://api.github.com/repos/benjaminfrank/cbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminfrank/cbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminfrank/cbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminfrank/cbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminfrank/cbt/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminfrank/cbt/languages","stargazers_url":"https://api.github.com/repos/benjaminfrank/cbt/stargazers","contributors_url":"https://api.github.com/repos/benjaminfrank/cbt/contributors","subscribers_url":"https://api.github.com/repos/benjaminfrank/cbt/subscribers","subscription_url":"https://api.github.com/repos/benjaminfrank/cbt/subscription","commits_url":"https://api.github.com/repos/benjaminfrank/cbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminfrank/cbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminfrank/cbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminfrank/cbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminfrank/cbt/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminfrank/cbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminfrank/cbt/merges","archive_url":"https://api.github.com/repos/benjaminfrank/cbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminfrank/cbt/downloads","issues_url":"https://api.github.com/repos/benjaminfrank/cbt/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminfrank/cbt/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminfrank/cbt/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminfrank/cbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminfrank/cbt/labels{/name}","releases_url":"https://api.github.com/repos/benjaminfrank/cbt/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminfrank/cbt/deployments","created_at":"2016-07-05T13:11:59Z","updated_at":"2016-07-05T13:12:00Z","pushed_at":"2016-07-05T21:05:39Z","git_url":"git://github.com/benjaminfrank/cbt.git","ssh_url":"git@github.com:benjaminfrank/cbt.git","clone_url":"https://github.com/benjaminfrank/cbt.git","svn_url":"https://github.com/benjaminfrank/cbt","homepage":"","size":398,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cvogt:master","ref":"master","sha":"bc2231720d3620b5e0459fa12c467bf675fcfdf5","user":{"login":"cvogt","id":274947,"avatar_url":"https://avatars.githubusercontent.com/u/274947?v=3","gravatar_id":"","url":"https://api.github.com/users/cvogt","html_url":"https://github.com/cvogt","followers_url":"https://api.github.com/users/cvogt/followers","following_url":"https://api.github.com/users/cvogt/following{/other_user}","gists_url":"https://api.github.com/users/cvogt/gists{/gist_id}","starred_url":"https://api.github.com/users/cvogt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvogt/subscriptions","organizations_url":"https://api.github.com/users/cvogt/orgs","repos_url":"https://api.github.com/users/cvogt/repos","events_url":"https://api.github.com/users/cvogt/events{/privacy}","received_events_url":"https://api.github.com/users/cvogt/received_events","type":"User","site_admin":false},"repo":{"id":43394868,"name":"cbt","full_name":"cvogt/cbt","owner":{"login":"cvogt","id":274947,"avatar_url":"https://avatars.githubusercontent.com/u/274947?v=3","gravatar_id":"","url":"https://api.github.com/users/cvogt","html_url":"https://github.com/cvogt","followers_url":"https://api.github.com/users/cvogt/followers","following_url":"https://api.github.com/users/cvogt/following{/other_user}","gists_url":"https://api.github.com/users/cvogt/gists{/gist_id}","starred_url":"https://api.github.com/users/cvogt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvogt/subscriptions","organizations_url":"https://api.github.com/users/cvogt/orgs","repos_url":"https://api.github.com/users/cvogt/repos","events_url":"https://api.github.com/users/cvogt/events{/privacy}","received_events_url":"https://api.github.com/users/cvogt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvogt/cbt","description":"CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala","fork":false,"url":"https://api.github.com/repos/cvogt/cbt","forks_url":"https://api.github.com/repos/cvogt/cbt/forks","keys_url":"https://api.github.com/repos/cvogt/cbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvogt/cbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvogt/cbt/teams","hooks_url":"https://api.github.com/repos/cvogt/cbt/hooks","issue_events_url":"https://api.github.com/repos/cvogt/cbt/issues/events{/number}","events_url":"https://api.github.com/repos/cvogt/cbt/events","assignees_url":"https://api.github.com/repos/cvogt/cbt/assignees{/user}","branches_url":"https://api.github.com/repos/cvogt/cbt/branches{/branch}","tags_url":"https://api.github.com/repos/cvogt/cbt/tags","blobs_url":"https://api.github.com/repos/cvogt/cbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvogt/cbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvogt/cbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvogt/cbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvogt/cbt/statuses/{sha}","languages_url":"https://api.github.com/repos/cvogt/cbt/languages","stargazers_url":"https://api.github.com/repos/cvogt/cbt/stargazers","contributors_url":"https://api.github.com/repos/cvogt/cbt/contributors","subscribers_url":"https://api.github.com/repos/cvogt/cbt/subscribers","subscription_url":"https://api.github.com/repos/cvogt/cbt/subscription","commits_url":"https://api.github.com/repos/cvogt/cbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvogt/cbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvogt/cbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvogt/cbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cvogt/cbt/contents/{+path}","compare_url":"https://api.github.com/repos/cvogt/cbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvogt/cbt/merges","archive_url":"https://api.github.com/repos/cvogt/cbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvogt/cbt/downloads","issues_url":"https://api.github.com/repos/cvogt/cbt/issues{/number}","pulls_url":"https://api.github.com/repos/cvogt/cbt/pulls{/number}","milestones_url":"https://api.github.com/repos/cvogt/cbt/milestones{/number}","notifications_url":"https://api.github.com/repos/cvogt/cbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvogt/cbt/labels{/name}","releases_url":"https://api.github.com/repos/cvogt/cbt/releases{/id}","deployments_url":"https://api.github.com/repos/cvogt/cbt/deployments","created_at":"2015-09-29T21:14:08Z","updated_at":"2016-07-04T04:57:58Z","pushed_at":"2016-07-05T21:05:39Z","git_url":"git://github.com/cvogt/cbt.git","ssh_url":"git@github.com:cvogt/cbt.git","clone_url":"https://github.com/cvogt/cbt.git","svn_url":"https://github.com/cvogt/cbt","homepage":"","size":468,"stargazers_count":180,"watchers_count":180,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":90,"forks":27,"open_issues":90,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/200"},"html":{"href":"https://github.com/cvogt/cbt/pull/200"},"issue":{"href":"https://api.github.com/repos/cvogt/cbt/issues/200"},"comments":{"href":"https://api.github.com/repos/cvogt/cbt/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cvogt/cbt/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/cvogt/cbt/statuses/457369577eb52cf187ef4eb109f50ef56cdd21bd"}}}}
{"actor":{"display_login":"benjaminfrank"}}