{"push_id":1212733466,"size":31,"distinct_size":31,"ref":"refs/heads/master","head":"0319082e7c60d29ae5de84d24964808a14a98a97","before":"b451a0a709facde9196c39e4e6db2bf1a30aa481","commits":[{"sha":"0d2bde8553c1385ba127c53d1d792629e5ca2529","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"go/ast/astutil: describe fewer CallExprs as \"conversions\"\n\nOnly unary CallExprs with no ellipsis, f(x), are ambiguous.\n\nChange-Id: If4f17445ab0725dee916992db133eac5536133a7\nReviewed-on: https://go-review.googlesource.com/24552\nReviewed-by: Robert Griesemer <gri@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/0d2bde8553c1385ba127c53d1d792629e5ca2529"},{"sha":"6c3528d5c186efa3a569b9bf311e3db54c825ff6","author":{"name":"Robert Griesemer","email":"325c28426ab01037dbfd12dcc94baae0089d35fe@golang.org"},"message":"go/gcimporter15: backport https://golang.org/cl/24648/\n\nChange-Id: Id85050b236f5da2c705c45163c90fef1a396e8f8\nReviewed-on: https://go-review.googlesource.com/24700\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/6c3528d5c186efa3a569b9bf311e3db54c825ff6"},{"sha":"527b253f588776e5f72a0a0d1e93195cd3f82707","author":{"name":"glorieux","email":"edb3700cb030201f42b3fff206017a76e87aede3@gmail.com"},"message":"x/tools/cmd/present: Fix present not working on Safari\n\nAs described on https://github.com/golang/go/issues/16216 present is not\ncurrently working on Safari because of the use of ES6 JavaScript let\nstatements.\nThe solution is to use var statements instead of let.\n\nFixes golang/go#16216\n\nChange-Id: I44c84f920aa41dfc8de5997ab50a440de6d57093\nReviewed-on: https://go-review.googlesource.com/24721\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/527b253f588776e5f72a0a0d1e93195cd3f82707"},{"sha":"2b3249681bcba9b3687b094eb0f2112c2961ea5a","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"cmd/guru: add menu to Emacs\n\nChange-Id: Ife18d22f8f9b81a0e898a2b5da202feb1df23852\nReviewed-on: https://go-review.googlesource.com/24832\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/2b3249681bcba9b3687b094eb0f2112c2961ea5a"},{"sha":"35c6e68a1a5ffc3e3afef71586710e9b0515582d","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"cmd/guru: update link to documentation\n\nChange-Id: Ia50c7878b0ba3c6576acf56b033beda122812c76\nReviewed-on: https://go-review.googlesource.com/24835\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/35c6e68a1a5ffc3e3afef71586710e9b0515582d"},{"sha":"130914b00446972075490fae5951ccee5a902147","author":{"name":"Parker Moore","email":"3101275e9870dfc82dfc770888db43fb16f1638a@gmail.com"},"message":"tip: update package doc to refer to stable code\n\nThis comment was written and has not been changed since this package was\ncreated: https://www.youtube.com/watch?v=1rZ-JorHJEY\n\nIt is no longer called 'tipgodoc', and it is no longer all that 'new'. This\nchange request updates that text to reflect the current state of the 'tip'\ncommand.\n\nChange-Id: I4ce56fb9a3bd617cf92f8d53df5a2d4726085a9a\nReviewed-on: https://go-review.googlesource.com/24860\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/130914b00446972075490fae5951ccee5a902147"},{"sha":"cda5280914a6bccec2b76d8d4341f4f4c5d62592","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"cmd/guru: fix quoting bug in Emacs binding\n\ncombine-and-quote-strings is buggy.  The value of this expression:\n (split-string-and-unquote (combine-and-quote-strings '(\"a\" \"\" \"b\")))\nis (\"a\" \"b\").  Consequently, if go-guru-scope is \"\", the following\n\"-tags\" flag is interpreted as the scope.\n\nChange-Id: I2955ffa2b95914e01d44b52690e810f816076d5c\nReviewed-on: https://go-review.googlesource.com/24746\nReviewed-by: Dominik Honnef <dominik@honnef.co>\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/cda5280914a6bccec2b76d8d4341f4f4c5d62592"},{"sha":"0835c735343e0d8e375f0b980b358619ff0853a2","author":{"name":"Brad Fitzpatrick","email":"9b57cd4de34ef5e00ba5b6ee67d7b6e836d0dbaa@golang.org"},"message":"imports: special case rand.Read, prevent math/rand by chance\n\nIn Go 1.7, math/rand.Read was added. Previously, the only package\ncontaining \"rand.Read\" was \"crypto/rand\".\n\ngoimports was updated to know that, and zstdlib.go contains a note\nthat it's ambiguous:\n\n        \"rand.Perm\":        \"math/rand\",\n        \"rand.Prime\":       \"crypto/rand\",\n        \"rand.Rand\":        \"math/rand\",\n        // \"rand.Read\" is ambiguous\n        \"rand.Reader\":                   \"crypto/rand\",\n        \"rand.Seed\":                     \"math/rand\",\n        \"rand.Source\":                   \"math/rand\",\n\nThe intention originally was that such ambiguous things would\nnever be resolved, even randomly.\n\nBut a later change added support for build.Default.SrcDirs, which\nmeant GOROOT was also searched for ambiguous things. Or maybe I forget\nthe history.\n\nIn any case, when goimports tried to resolve \"rand.Read\", the\nfindImportStdlib check was returning nothing, which lead to the\n$GOROOT being searched, where math/rand was picked by chance. That's a\ndangerous default when the intentional might've been crypto/rand.\n\nSpecial case it and prefer crypto/rand if there's no more specific\nclue either way.\n\nChange-Id: Ib5f8f297f72fa309d5ca9b15a37493df2e17567c\nReviewed-on: https://go-review.googlesource.com/24847\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/0835c735343e0d8e375f0b980b358619ff0853a2"},{"sha":"b3887f7a17a5421126693d97f9015d00d396f6fb","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"refactor/rename: fix spurious conflict report when renaming x/foo to y/foo\n\nThere is no need to check for import conflicts when the package name\ndoesn't change.  Add test.\n\nAlso, when reporting a (non-spurious) import conflict, make clear that\nthe error is just a warning.  Add a test for same.\n\nChange-Id: Idde0483b502cd041fd893230fec06b8533f54f3c\nReviewed-on: https://go-review.googlesource.com/24917\nReviewed-by: Michael Matloob <matloob@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/b3887f7a17a5421126693d97f9015d00d396f6fb"},{"sha":"e047ae774b027ae958a270598c5ac2591e457afc","author":{"name":"Brad Fitzpatrick","email":"9b57cd4de34ef5e00ba5b6ee67d7b6e836d0dbaa@golang.org"},"message":"cmd/goimports, imports: make goimports great again\n\nI felt the burn of my laptop on my legs, spinning away while processing\ngoimports, and felt that it was time to make goimports great again.\n\nOver the past few years goimports fell into a slow state of disrepair\nwith too many feature additions and no attention to the performance\ndeath by a thousand cuts. This was particularly terrible on OS X with\nits lackluster filesystem buffering.\n\nThis CL makes goimports stronger, together with various optimizations\nand more visibility into what goimports is doing.\n\n* adds more internal documentation\n\n* avoids scanning $GOPATH for answers when running goimports on a file\n  under $GOROOT (for Go core hackers)\n\n* don't read all $GOROOT & $GOPATH directories' Go code looking for\n  their package names until much later. Require the package name of\n  missing imports to be present in the last two directory path\n  components.  Then only try importing them in order from best to\n  worst (shortest to longest, as before), so we can stop early.\n\n* when adding imports, add names to imports when the imported package name\n  doesn't match the baes of its import path. For example:\n        import foo \"example.net/foo/v1\"\n\n* don't read all *.go files in a package directory once the first file\n  in a directory has revealed itself to be a package we're not looking\n  for. For example, if we're looking for the right \"client\" for \"client.Foo\",\n  we used to consider a directory \"bar/client\" as a candidate and read\n  all 50 of its *.go files instead of stopping after its first *.go\n  file had a \"package main\" line.\n\n* add some fast paths to remove allocations\n\n* add some fast paths to remove disk I/O when looking up the base\n  package name of a standard library import (of existing imports in a\n  file, which are very common)\n\n* adds a special case for import \"C\", to avoid some disk I/O.\n\n* add a -verbose flag to goimports for debugging\n\nOn my Mac laptop with a huge $GOPATH, with a test file like:\n\n\tpackage foo\n\timport (\n\t       \"fmt\"\n\t       \"net/http\"\n\t)\n\n\t/*\n\n\t*/\n\timport \"C\"\n\n\tvar _ = cloudbilling.New\n\tvar _ = http.NewRequest\n\tvar _ = client.New\n\n... this took like 10 seconds before, and now 1.3 seconds. (Still\nslow; disk-based caching can come later)\n\nUpdates golang/go#16367 (goimports is slow)\nUpdates golang/go#16384 (refactor TestRename is broken on Windows)\n\nChange-Id: I97e85d3016afc9f2ad5501f97babad30c7989183\nReviewed-on: https://go-review.googlesource.com/24941\nReviewed-by: Andrew Gerrand <adg@golang.org>\nReviewed-by: Rob Pike <r@golang.org>\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/e047ae774b027ae958a270598c5ac2591e457afc"},{"sha":"9c3986db53d305e3872da341e84daa265dc74a64","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"refactor/rename: fix two bugs related to MS Windows' path separator\n\nIn the package, the added import declarations used backslashes.\nIn the test, filenames in warning messages used backslashes.\nNow both use forward slash.\n\nFixes golang/go#16384\n\nChange-Id: I43116aab0b3209305f23ed9def7c4adf3259941e\nReviewed-on: https://go-review.googlesource.com/24943\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/9c3986db53d305e3872da341e84daa265dc74a64"},{"sha":"92480e476063dbeb161fff66c62da6e55c10310a","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"cmd/guru: update Emacs installation documentation\n\nI was going to add a hook to enable go-guru-hl-identifier-mode\nas a side effect of go-mode, but a person I consulted said that\nwas bad form; instead I merely documented it.\n\nChange-Id: I48b00b71c7ba485b3d632211923509a74281acbe\nReviewed-on: https://go-review.googlesource.com/24834\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/92480e476063dbeb161fff66c62da6e55c10310a"},{"sha":"ef6b6ebf3bae8fcf7070dc621fa12c7ea08ea3c7","author":{"name":"Alan Donovan","email":"b4de885ea7dd2122dd17724bfd78a10d7dedc05b@google.com"},"message":"cmd/guru: what: include imported package names in sameids\n\n+ Test.\n\nChange-Id: Ib7ef99786f5b60bb3e56ced9588d2ba5725576e1\nReviewed-on: https://go-review.googlesource.com/24949\nReviewed-by: Robert Griesemer <gri@golang.org>\nRun-TryBot: Robert Griesemer <gri@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/ef6b6ebf3bae8fcf7070dc621fa12c7ea08ea3c7"},{"sha":"7c26c999737b6551aa3656490a29843433ca6f1d","author":{"name":"Brad Fitzpatrick","email":"9b57cd4de34ef5e00ba5b6ee67d7b6e836d0dbaa@golang.org"},"message":"imports: do less I/O finding the package name of an import\n\nWhen goimports was run on a file like:\n\n    package main\n\n    import (\n        \"example.net/foo\"\n        \"example.net/bar\"\n    )\n\n    var _, _ = foo.Foo, bar.Bar\n\n... even though there looks to be no work to do, it still needs to\nverify that \"example.net/foo\" is really package \"foo\" (even though it\nlooks like it) and \"example.net/bar\" is really package\n\"bar\". (Packages in the standard library are hard-coded since the\nprevious commit and not verified for consistency since they're always consistent)\n\nTo do that verification for non-std packages, go/build.Import was\nbeing used before, but Import reads all files in the directory to make\nsure they're consistent. That's unnecessary. Instead, stop after the\nfirst file. If example.net/foo has foo.go with \"package foo\" and\njust_kidding.go with \"package other\", we never read that far to find\nthe inconsistency. Oh well. Prefer speed.\n\nUpdates golang/go#16367\n\nChange-Id: I9fc3fefbee0e8a6bc287bf2a565257fb9523fd5c\nReviewed-on: https://go-review.googlesource.com/24948\nReviewed-by: Josh Bleecher Snyder <josharian@gmail.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/7c26c999737b6551aa3656490a29843433ca6f1d"},{"sha":"ffe4e61c6496f07d2bdbb590286f0b13bd51a158","author":{"name":"Brad Fitzpatrick","email":"9b57cd4de34ef5e00ba5b6ee67d7b6e836d0dbaa@golang.org"},"message":"imports: add configuration mechanism to exclude directories\n\nEach $GOPATH entry may have a file $GOPATH/src/.goimportsignore which\nmay contain blank lines, #comment lines, or lines naming a directory\nrelative to the configuration file to ignore when scanning.  No\nglobbing or regex patterns are allowed.\n\nUpdates golang/go#16367 (goimports speed)\nFixes golang/go#16386 (add mechanism to ignore directories)\n\nChange-Id: I8f1a88ae6c4d0ed3075444d70aec3e2228c5ce6a\nReviewed-on: https://go-review.googlesource.com/24971\nReviewed-by: Rob Pike <r@golang.org>\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/ffe4e61c6496f07d2bdbb590286f0b13bd51a158"},{"sha":"3f933d433a6940406a52011e5caf459e7e0cb273","author":{"name":"Robert Griesemer","email":"325c28426ab01037dbfd12dcc94baae0089d35fe@golang.org"},"message":"go/gcimporter15: backport of https://golang.org/cl/23012/\n\nFixes golang/go#16365.\n\nChange-Id: I8e33fbd9f1bf1b4b5d85a5c972ad43414cea57cb\nReviewed-on: https://go-review.googlesource.com/24973\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/3f933d433a6940406a52011e5caf459e7e0cb273"},{"sha":"c550f66b0b48fb80f7076e0a5f8a0d736e3bb7bd","author":{"name":"Robert Griesemer","email":"325c28426ab01037dbfd12dcc94baae0089d35fe@golang.org"},"message":"go/gcimporter15: backport of https://golang.org/cl/23606/\n\nChange-Id: I24a6a844e179dd1b69c90c5834d7998cb963c543\nReviewed-on: https://go-review.googlesource.com/24974\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/c550f66b0b48fb80f7076e0a5f8a0d736e3bb7bd"},{"sha":"6d32be89d569efd9d2426c967e8d133fd4abb9f0","author":{"name":"Josh Bleecher Snyder","email":"ff3b63923c772c177a8220d1d1461f9401b867dd@gmail.com"},"message":"imports: minor fixes\n\nThese are mostly comments for CL 24941 that didn't\nget sent quickly enough.\n\nstrings.Trim(`\\\"`) works, but by accident.\nIt trims all leading and trailing \"s and \\s,\nbut there are never leading or trailing \\s.\n\nSemantic line breaks and punctuation cleanup.\n\nThe reflow of comments in the pkgName == \"main\" if\nblock is to silence this spurious vet failure:\n\nfix.go:247: +build comment must appear before package clause and be followed by a blank line\n\nPlain sync.Once values are enough.\n\nChange-Id: I241f3025031b6f21605da78ea52066713a203327\nReviewed-on: https://go-review.googlesource.com/24983\nRun-TryBot: Josh Bleecher Snyder <josharian@gmail.com>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/6d32be89d569efd9d2426c967e8d133fd4abb9f0"},{"sha":"681db090d94e07d421e8ec0d2c5d29e40c4ac2f5","author":{"name":"Andrew Gerrand","email":"db67cfd622ff8faeae46fddb76d1b6430ef13fce@golang.org"},"message":"godoc/static: use window scope for checking notesEnabled\n\nThis prevents a JS error when the notes are not present.\n\nChange-Id: Ib8875306027b7e43441310d4228c690e2249056e\nReviewed-on: https://go-review.googlesource.com/24963\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/681db090d94e07d421e8ec0d2c5d29e40c4ac2f5"},{"sha":"29481a356d4ec9c4badb3e4239ba69dc979f8d03","author":{"name":"Brad Fitzpatrick","email":"9b57cd4de34ef5e00ba5b6ee67d7b6e836d0dbaa@golang.org"},"message":"imports: skip test on plan9\n\nChange-Id: I608a1ba47a049b7eb5f4ded481744d8b25e68800\nReviewed-on: https://go-review.googlesource.com/24988\nReviewed-by: Josh Bleecher Snyder <josharian@gmail.com>","distinct":true,"url":"https://api.github.com/repos/tsaikd/tools/commits/29481a356d4ec9c4badb3e4239ba69dc979f8d03"}]}
{"actor":{"display_login":"tsaikd"}}