{"action":"created","issue":{"url":"https://api.github.com/repos/crystal-lang/crystal/issues/2708","repository_url":"https://api.github.com/repos/crystal-lang/crystal","labels_url":"https://api.github.com/repos/crystal-lang/crystal/issues/2708/labels{/name}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/2708/comments","events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/2708/events","html_url":"https://github.com/crystal-lang/crystal/pull/2708","id":157880415,"number":2708,"title":"TLS hostname check","user":{"login":"jhass","id":141294,"avatar_url":"https://avatars.githubusercontent.com/u/141294?v=3","gravatar_id":"","url":"https://api.github.com/users/jhass","html_url":"https://github.com/jhass","followers_url":"https://api.github.com/users/jhass/followers","following_url":"https://api.github.com/users/jhass/following{/other_user}","gists_url":"https://api.github.com/users/jhass/gists{/gist_id}","starred_url":"https://api.github.com/users/jhass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhass/subscriptions","organizations_url":"https://api.github.com/users/jhass/orgs","repos_url":"https://api.github.com/users/jhass/repos","events_url":"https://api.github.com/users/jhass/events{/privacy}","received_events_url":"https://api.github.com/users/jhass/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-01T11:06:57Z","updated_at":"2016-06-01T13:10:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/2708","html_url":"https://github.com/crystal-lang/crystal/pull/2708","diff_url":"https://github.com/crystal-lang/crystal/pull/2708.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/2708.patch"},"body":"Based on #2707 \r\n\r\nWith 1.0.2 OpenSSL gained support for doing hostname checks, see https://wiki.openssl.org/index.php/Hostname_validation\r\n\r\nHowever is it okay to depend on 1.0.2? Should we implement our own hostname checking [like Ruby does](https://github.com/ruby/ruby/blob/c57c719e4ab00e4b7a9fc8af21b4140945167554/ext/openssl/lib/openssl/ssl.rb#L162-L244)? Or given we find a way to detect the OpenSSL version (how?), should we use this only for OpenSSL 1.0.2+ or either this or a manual check?\r\n\r\nI included a network dependent integration spec that should only manually be run."},"comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments/222987159","html_url":"https://github.com/crystal-lang/crystal/pull/2708#issuecomment-222987159","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/2708","id":222987159,"user":{"login":"fernandes","id":517743,"avatar_url":"https://avatars.githubusercontent.com/u/517743?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandes","html_url":"https://github.com/fernandes","followers_url":"https://api.github.com/users/fernandes/followers","following_url":"https://api.github.com/users/fernandes/following{/other_user}","gists_url":"https://api.github.com/users/fernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandes/subscriptions","organizations_url":"https://api.github.com/users/fernandes/orgs","repos_url":"https://api.github.com/users/fernandes/repos","events_url":"https://api.github.com/users/fernandes/events{/privacy}","received_events_url":"https://api.github.com/users/fernandes/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T13:10:45Z","updated_at":"2016-06-01T13:10:45Z","body":"@bcardiff is right\r\nPackage: openssl (1.0.1f-1ubuntu2.19 and others)  [source](http://packages.ubuntu.com/trusty/openssl)"}}
{"actor":{"display_login":"fernandes"}}