{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15962","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15962/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15962/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15962/events","html_url":"https://github.com/mantidproject/mantid/pull/15962","id":150121499,"number":15962,"title":"TOFTOF find EPP","user":{"login":"mganeva","id":7290767,"avatar_url":"https://avatars.githubusercontent.com/u/7290767?v=3","gravatar_id":"","url":"https://api.github.com/users/mganeva","html_url":"https://github.com/mganeva","followers_url":"https://api.github.com/users/mganeva/followers","following_url":"https://api.github.com/users/mganeva/following{/other_user}","gists_url":"https://api.github.com/users/mganeva/gists{/gist_id}","starred_url":"https://api.github.com/users/mganeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mganeva/subscriptions","organizations_url":"https://api.github.com/users/mganeva/orgs","repos_url":"https://api.github.com/users/mganeva/repos","events_url":"https://api.github.com/users/mganeva/events{/privacy}","received_events_url":"https://api.github.com/users/mganeva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Direct%20Inelastic","name":"Component: Direct Inelastic","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"Code Freeze:13-May-2016\r\nBeta Testing: 17-May-2016 to 31-May-2016\r\n","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":590,"closed_issues":706,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-05-06T11:41:53Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":8,"created_at":"2016-04-21T16:18:29Z","updated_at":"2016-05-06T11:49:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15962","html_url":"https://github.com/mantidproject/mantid/pull/15962","diff_url":"https://github.com/mantidproject/mantid/pull/15962.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15962.patch"},"body":"This is the second part of the refactoring of the TOFTOF workflow. Following has been done:\r\n1. Created FindEPP algorithm to search for an elastic peak position. It performs Gaussian fit of the TOF data and creates a table as an output. This table is further used by other workflow algorithms. This saves the data reduction time: the fitting can be done only once, but the result can be used for multiple workspaces.\r\n2. Algorithms ComputeCalibrationCoefVan and TOFTOFConvertTofToDeltaE are adjusted to take the elastic peak parameters from the table. \r\n\r\nAlgorithm FitGaussian is not used any more and can be deprecated and removed if nobody needs it.\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\nReview the source code, tests and documentation. The algorithm can be tested on the sample workspaces in a following way:\r\n\r\n``` python\r\nws = CreateSampleWorkspace(Function=\"User Defined\", UserDefinedFunction=\"name=LinearBackground, \\\r\n                A0=0.3;name=Gaussian, PeakCentre=8000, Height=5, Sigma=75\", NumBanks=2, BankPixelWidth=1, XMin=6005.75, XMax=9995.75, BinWidth=10.5, BankDistanceFromSample=4.0)\r\n#search for elastic peak positions\r\ntable = FindEPP(ws)\r\n#the unit conversion \r\nlognames = \"channel_width,EPP,TOF1\"\r\nlogvalues = \"10.5,190.0,2000.0\"\r\nAddSampleLogMultiple(ws, lognames, logvalues)\r\nws_dE=TOFTOFConvertTofToDeltaE(ws, table)  # elastic peak should be at 0 meV\r\n#computation of Vanadium calibration coeficients\r\nAddSampleLog(ws, LogName='wavelength', LogText='6.0', LogType='Number', LogUnit='Angstrom')\r\ncoefs = ComputeCalibrationCoefVan(ws, table)\r\n\r\n#TOFTOF sample data can also be used for tests:\r\nwsVana = LoadMLZ(Filename='TOFTOFTestdata.nxs')\r\n\r\n```\r\nFixes #xxxx.\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\nDoes not need to be in the release notes, I think.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [x] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/217419550","html_url":"https://github.com/mantidproject/mantid/pull/15962#issuecomment-217419550","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15962","id":217419550,"user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T11:49:00Z","updated_at":"2016-05-06T11:49:00Z","body":"Ah, I see, for the moment feel free to create issues and put that information in the description and/or comments. Then someone with the required permissions can set the label, milestone, etc. from that."}}