{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/419","repository_url":"https://api.github.com/repos/Automattic/simplenote-electron","labels_url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/419/comments","events_url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/419/events","html_url":"https://github.com/Automattic/simplenote-electron/pull/419","id":185489396,"number":419,"title":"Fix PageUp/Down Keys from Showing Info Panel","user":{"login":"roundhill","id":789137,"avatar_url":"https://avatars.githubusercontent.com/u/789137?v=3","gravatar_id":"","url":"https://api.github.com/users/roundhill","html_url":"https://github.com/roundhill","followers_url":"https://api.github.com/users/roundhill/followers","following_url":"https://api.github.com/users/roundhill/following{/other_user}","gists_url":"https://api.github.com/users/roundhill/gists{/gist_id}","starred_url":"https://api.github.com/users/roundhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roundhill/subscriptions","organizations_url":"https://api.github.com/users/roundhill/orgs","repos_url":"https://api.github.com/users/roundhill/repos","events_url":"https://api.github.com/users/roundhill/events{/privacy}","received_events_url":"https://api.github.com/users/roundhill/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/simplenote-electron/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-26T19:37:19Z","updated_at":"2016-10-26T20:49:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/simplenote-electron/pulls/419","html_url":"https://github.com/Automattic/simplenote-electron/pull/419","diff_url":"https://github.com/Automattic/simplenote-electron/pull/419.diff","patch_url":"https://github.com/Automattic/simplenote-electron/pull/419.patch"},"body":"Something about adding `drafts-js` was causing the note info panel to appear when you pressed the Page Up or Page Down keys when the editor had focus.\r\n\r\nIt looks to me like the form elements that are present in the info panel are getting focus when these keys are pressed. The info panel is absolutely positioned 100% to the left to sort of hide it, so the browser window actually moves over to show the element that received focus.\r\n\r\nAt first, I thought I could fix this by changing where the note info panel was rendered to be _before_ where the editor renders, but it didn't fix the issue.\r\n\r\nThe solution I came up with was to simply not render the note info panel until we want to show it. It might have a slightly longer delay when animating in, but I haven't noticed any difference.\r\n\r\n**To Test**\r\n1. Compile a windows or linux version, and sign in.\r\n2. Select a long note in the editor, and press the page up or page down keys.\r\n3. The editor should scroll down or up, and the note info panel should remain hidden.\r\n\r\n Fixes #408"},"comment":{"url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/comments/256472574","html_url":"https://github.com/Automattic/simplenote-electron/pull/419#issuecomment-256472574","issue_url":"https://api.github.com/repos/Automattic/simplenote-electron/issues/419","id":256472574,"user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T20:49:21Z","updated_at":"2016-10-26T20:49:21Z","body":"@roundhill I can't test because I don't have a PageUp/PageDown key, but the code looks good!\r\n\r\n🚢 at your leisure!"}}
{"actor":{"display_login":"dmsnell"}}