{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/comments/88024899","pull_request_review_id":8610838,"id":88024899,"diff_hunk":"@@ -15,48 +15,62 @@ import (\n \t\"github.com/weaveworks/scope/report\"\n )\n \n-const apiTopologyURL = \"/api/topology/\"\n+const (\n+\tapiTopologyURL                     = \"/api/topology/\"\n+\tprocessesTopologyDescID            = \"processes\"\n+\tprocessesByNameTopologyDescID      = \"processes-by-name\"\n+\tcontainerLabelFiltersGroupID       = \"container_label_filters_group\"\n+\tcontainersTopologyDescID           = \"containers\"\n+\tcontainersByHostnameTopologyDescID = \"containers-by-hostname\"\n+\tcontainersByImageTopologyDescID    = \"containers-by-image\"\n+\tpodsTopologyDescID                 = \"pods\"\n+\treplicaSetsTopologyDescID          = \"replica-sets\"\n+\tdeploymentsTopologyDescID          = \"deployments\"\n+\tservicesTopologyDescID             = \"services\"\n+\thostsTopologyDescID                = \"hosts\"\n+)\n \n var (\n-\ttopologyRegistry = &registry{\n+\ttopologyRegistry = &Registry{\n \t\titems: map[string]APITopologyDesc{},\n \t}\n \tk8sPseudoFilter = APITopologyOptionGroup{\n \t\tID:      \"pseudo\",\n \t\tDefault: \"hide\",\n \t\tOptions: []APITopologyOption{\n-\t\t\t{\"show\", \"Show Unmanaged\", nil, false},\n-\t\t\t{\"hide\", \"Hide Unmanaged\", render.IsNotPseudo, true},\n+\t\t\t{Value: \"show\", Label: \"Show Unmanaged\", filter: nil, filterPseudo: false},\n+\t\t\t{Value: \"hide\", Label: \"Hide Unmanaged\", filter: render.IsNotPseudo, filterPseudo: true},\n \t\t},\n \t}\n )\n \n func init() {\n+\tAddInitialTopologiesToRegistry(topologyRegistry)\n+}\n+\n+// AddInitialTopologiesToRegistry does the initial setup for a Registry\n+func AddInitialTopologiesToRegistry(tRegistry *Registry) {","path":"app/api_topologies.go","position":42,"original_position":42,"commit_id":"1c73fa4361c8c3279ed025b589dd63a74ea28602","original_commit_id":"1c73fa4361c8c3279ed025b589dd63a74ea28602","user":{"login":"2opremio","id":2362916,"avatar_url":"https://avatars.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false},"body":"Minor: s/tRegistry/registry/","created_at":"2016-11-15T14:21:13Z","updated_at":"2016-11-15T14:21:13Z","html_url":"https://github.com/weaveworks/scope/pull/1895#discussion_r88024899","pull_request_url":"https://api.github.com/repos/weaveworks/scope/pulls/1895","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments/88024899"},"html":{"href":"https://github.com/weaveworks/scope/pull/1895#discussion_r88024899"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1895"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/1895","id":86765058,"html_url":"https://github.com/weaveworks/scope/pull/1895","diff_url":"https://github.com/weaveworks/scope/pull/1895.diff","patch_url":"https://github.com/weaveworks/scope/pull/1895.patch","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/1895","number":1895,"state":"open","locked":false,"title":"Add custom label-based filters in container view","user":{"login":"CarltonSemple","id":6462396,"avatar_url":"https://avatars.githubusercontent.com/u/6462396?v=3","gravatar_id":"","url":"https://api.github.com/users/CarltonSemple","html_url":"https://github.com/CarltonSemple","followers_url":"https://api.github.com/users/CarltonSemple/followers","following_url":"https://api.github.com/users/CarltonSemple/following{/other_user}","gists_url":"https://api.github.com/users/CarltonSemple/gists{/gist_id}","starred_url":"https://api.github.com/users/CarltonSemple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarltonSemple/subscriptions","organizations_url":"https://api.github.com/users/CarltonSemple/orgs","repos_url":"https://api.github.com/users/CarltonSemple/repos","events_url":"https://api.github.com/users/CarltonSemple/events{/privacy}","received_events_url":"https://api.github.com/users/CarltonSemple/received_events","type":"User","site_admin":false},"body":"Added the ability to add container filters by editing an environment variable, and kept the ability to filter out weavescope system containers\n","created_at":"2016-09-26T15:30:16Z","updated_at":"2016-11-15T14:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b86368369b5397b17d49aca28ec776a93606259","assignee":{"login":"2opremio","id":2362916,"avatar_url":"https://avatars.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false},"assignees":[{"login":"2opremio","id":2362916,"avatar_url":"https://avatars.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/scope/pulls/1895/commits","review_comments_url":"https://api.github.com/repos/weaveworks/scope/pulls/1895/comments","review_comment_url":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/1895/comments","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/1c73fa4361c8c3279ed025b589dd63a74ea28602","head":{"label":"CarltonSemple:container-filters","ref":"container-filters","sha":"1c73fa4361c8c3279ed025b589dd63a74ea28602","user":{"login":"CarltonSemple","id":6462396,"avatar_url":"https://avatars.githubusercontent.com/u/6462396?v=3","gravatar_id":"","url":"https://api.github.com/users/CarltonSemple","html_url":"https://github.com/CarltonSemple","followers_url":"https://api.github.com/users/CarltonSemple/followers","following_url":"https://api.github.com/users/CarltonSemple/following{/other_user}","gists_url":"https://api.github.com/users/CarltonSemple/gists{/gist_id}","starred_url":"https://api.github.com/users/CarltonSemple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarltonSemple/subscriptions","organizations_url":"https://api.github.com/users/CarltonSemple/orgs","repos_url":"https://api.github.com/users/CarltonSemple/repos","events_url":"https://api.github.com/users/CarltonSemple/events{/privacy}","received_events_url":"https://api.github.com/users/CarltonSemple/received_events","type":"User","site_admin":false},"repo":{"id":69261856,"name":"scope","full_name":"CarltonSemple/scope","owner":{"login":"CarltonSemple","id":6462396,"avatar_url":"https://avatars.githubusercontent.com/u/6462396?v=3","gravatar_id":"","url":"https://api.github.com/users/CarltonSemple","html_url":"https://github.com/CarltonSemple","followers_url":"https://api.github.com/users/CarltonSemple/followers","following_url":"https://api.github.com/users/CarltonSemple/following{/other_user}","gists_url":"https://api.github.com/users/CarltonSemple/gists{/gist_id}","starred_url":"https://api.github.com/users/CarltonSemple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarltonSemple/subscriptions","organizations_url":"https://api.github.com/users/CarltonSemple/orgs","repos_url":"https://api.github.com/users/CarltonSemple/repos","events_url":"https://api.github.com/users/CarltonSemple/events{/privacy}","received_events_url":"https://api.github.com/users/CarltonSemple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarltonSemple/scope","description":"Monitoring, visualisation & management for Docker & Kubernetes","fork":true,"url":"https://api.github.com/repos/CarltonSemple/scope","forks_url":"https://api.github.com/repos/CarltonSemple/scope/forks","keys_url":"https://api.github.com/repos/CarltonSemple/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarltonSemple/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarltonSemple/scope/teams","hooks_url":"https://api.github.com/repos/CarltonSemple/scope/hooks","issue_events_url":"https://api.github.com/repos/CarltonSemple/scope/issues/events{/number}","events_url":"https://api.github.com/repos/CarltonSemple/scope/events","assignees_url":"https://api.github.com/repos/CarltonSemple/scope/assignees{/user}","branches_url":"https://api.github.com/repos/CarltonSemple/scope/branches{/branch}","tags_url":"https://api.github.com/repos/CarltonSemple/scope/tags","blobs_url":"https://api.github.com/repos/CarltonSemple/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarltonSemple/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarltonSemple/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarltonSemple/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarltonSemple/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/CarltonSemple/scope/languages","stargazers_url":"https://api.github.com/repos/CarltonSemple/scope/stargazers","contributors_url":"https://api.github.com/repos/CarltonSemple/scope/contributors","subscribers_url":"https://api.github.com/repos/CarltonSemple/scope/subscribers","subscription_url":"https://api.github.com/repos/CarltonSemple/scope/subscription","commits_url":"https://api.github.com/repos/CarltonSemple/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarltonSemple/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarltonSemple/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarltonSemple/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarltonSemple/scope/contents/{+path}","compare_url":"https://api.github.com/repos/CarltonSemple/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarltonSemple/scope/merges","archive_url":"https://api.github.com/repos/CarltonSemple/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarltonSemple/scope/downloads","issues_url":"https://api.github.com/repos/CarltonSemple/scope/issues{/number}","pulls_url":"https://api.github.com/repos/CarltonSemple/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/CarltonSemple/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/CarltonSemple/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarltonSemple/scope/labels{/name}","releases_url":"https://api.github.com/repos/CarltonSemple/scope/releases{/id}","deployments_url":"https://api.github.com/repos/CarltonSemple/scope/deployments","created_at":"2016-09-26T15:01:56Z","updated_at":"2016-09-26T15:01:58Z","pushed_at":"2016-11-14T18:54:39Z","git_url":"git://github.com/CarltonSemple/scope.git","ssh_url":"git@github.com:CarltonSemple/scope.git","clone_url":"https://github.com/CarltonSemple/scope.git","svn_url":"https://github.com/CarltonSemple/scope","homepage":"https://www.weave.works/product/weave-scope/","size":45937,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"b11cfb0fc63cba9c141921bec347f2ac6b035a23","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":34659664,"name":"scope","full_name":"weaveworks/scope","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/scope","description":"Monitoring, visualisation & management for Docker & Kubernetes","fork":false,"url":"https://api.github.com/repos/weaveworks/scope","forks_url":"https://api.github.com/repos/weaveworks/scope/forks","keys_url":"https://api.github.com/repos/weaveworks/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/scope/teams","hooks_url":"https://api.github.com/repos/weaveworks/scope/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/scope/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/scope/events","assignees_url":"https://api.github.com/repos/weaveworks/scope/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/scope/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/scope/tags","blobs_url":"https://api.github.com/repos/weaveworks/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/scope/languages","stargazers_url":"https://api.github.com/repos/weaveworks/scope/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/scope/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/scope/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/scope/subscription","commits_url":"https://api.github.com/repos/weaveworks/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/scope/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/scope/merges","archive_url":"https://api.github.com/repos/weaveworks/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/scope/downloads","issues_url":"https://api.github.com/repos/weaveworks/scope/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/scope/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/scope/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/scope/deployments","created_at":"2015-04-27T10:12:35Z","updated_at":"2016-11-15T12:58:41Z","pushed_at":"2016-11-15T14:12:36Z","git_url":"git://github.com/weaveworks/scope.git","ssh_url":"git@github.com:weaveworks/scope.git","clone_url":"https://github.com/weaveworks/scope.git","svn_url":"https://github.com/weaveworks/scope","homepage":"https://www.weave.works/product/weave-scope/","size":66800,"stargazers_count":880,"watchers_count":880,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":281,"forks":82,"open_issues":281,"watchers":880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1895"},"html":{"href":"https://github.com/weaveworks/scope/pull/1895"},"issue":{"href":"https://api.github.com/repos/weaveworks/scope/issues/1895"},"comments":{"href":"https://api.github.com/repos/weaveworks/scope/issues/1895/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1895/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/1895/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/scope/statuses/1c73fa4361c8c3279ed025b589dd63a74ea28602"}}}}
{"actor":{"display_login":"2opremio"}}