{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/88140373","pull_request_review_id":8723285,"id":88140373,"diff_hunk":"@@ -87,7 +87,7 @@ namespace libtorrent\n \t\tvoid write_dont_have(int) {}\n \t\tvoid write_piece(peer_request const&, disk_buffer_holder)\n \t\t{ TORRENT_ASSERT_FAIL(); }\n-\t\tvoid write_keepalive() {}\n+\t\tbool write_keepalive() { return false; }","path":"include/libtorrent/web_connection_base.hpp","position":5,"original_position":5,"commit_id":"43979051e1065164cf4395c412db76476e8ad790","original_commit_id":"43979051e1065164cf4395c412db76476e8ad790","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"I don't think you meant to mix this PR in here, right?","created_at":"2016-11-15T23:45:31Z","updated_at":"2016-11-15T23:45:31Z","html_url":"https://github.com/arvidn/libtorrent/pull/1321#discussion_r88140373","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/88140373"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1321#discussion_r88140373"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321","id":93564559,"html_url":"https://github.com/arvidn/libtorrent/pull/1321","diff_url":"https://github.com/arvidn/libtorrent/pull/1321.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1321.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1321","number":1321,"state":"open","locked":false,"title":"fix bug: urlseed never timeout","user":{"login":"tnextday","id":1772562,"avatar_url":"https://avatars.githubusercontent.com/u/1772562?v=3","gravatar_id":"","url":"https://api.github.com/users/tnextday","html_url":"https://github.com/tnextday","followers_url":"https://api.github.com/users/tnextday/followers","following_url":"https://api.github.com/users/tnextday/following{/other_user}","gists_url":"https://api.github.com/users/tnextday/gists{/gist_id}","starred_url":"https://api.github.com/users/tnextday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnextday/subscriptions","organizations_url":"https://api.github.com/users/tnextday/orgs","repos_url":"https://api.github.com/users/tnextday/repos","events_url":"https://api.github.com/users/tnextday/events{/privacy}","received_events_url":"https://api.github.com/users/tnextday/received_events","type":"User","site_admin":false},"body":"\r\n`m_last_sent` has updated in `peer_connection::on_send_data` function,  update in `peer_connection::keep_alive()` will case `web_connection_base` never timeout.","created_at":"2016-11-14T13:17:08Z","updated_at":"2016-11-15T23:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"121c008239cc5d589689cb866cd937928253077c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1321/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/43979051e1065164cf4395c412db76476e8ad790","head":{"label":"tnextday:master","ref":"master","sha":"43979051e1065164cf4395c412db76476e8ad790","user":{"login":"tnextday","id":1772562,"avatar_url":"https://avatars.githubusercontent.com/u/1772562?v=3","gravatar_id":"","url":"https://api.github.com/users/tnextday","html_url":"https://github.com/tnextday","followers_url":"https://api.github.com/users/tnextday/followers","following_url":"https://api.github.com/users/tnextday/following{/other_user}","gists_url":"https://api.github.com/users/tnextday/gists{/gist_id}","starred_url":"https://api.github.com/users/tnextday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnextday/subscriptions","organizations_url":"https://api.github.com/users/tnextday/orgs","repos_url":"https://api.github.com/users/tnextday/repos","events_url":"https://api.github.com/users/tnextday/events{/privacy}","received_events_url":"https://api.github.com/users/tnextday/received_events","type":"User","site_admin":false},"repo":{"id":73704656,"name":"libtorrent","full_name":"tnextday/libtorrent","owner":{"login":"tnextday","id":1772562,"avatar_url":"https://avatars.githubusercontent.com/u/1772562?v=3","gravatar_id":"","url":"https://api.github.com/users/tnextday","html_url":"https://github.com/tnextday","followers_url":"https://api.github.com/users/tnextday/followers","following_url":"https://api.github.com/users/tnextday/following{/other_user}","gists_url":"https://api.github.com/users/tnextday/gists{/gist_id}","starred_url":"https://api.github.com/users/tnextday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnextday/subscriptions","organizations_url":"https://api.github.com/users/tnextday/orgs","repos_url":"https://api.github.com/users/tnextday/repos","events_url":"https://api.github.com/users/tnextday/events{/privacy}","received_events_url":"https://api.github.com/users/tnextday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tnextday/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/tnextday/libtorrent","forks_url":"https://api.github.com/repos/tnextday/libtorrent/forks","keys_url":"https://api.github.com/repos/tnextday/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnextday/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnextday/libtorrent/teams","hooks_url":"https://api.github.com/repos/tnextday/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/tnextday/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/tnextday/libtorrent/events","assignees_url":"https://api.github.com/repos/tnextday/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/tnextday/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/tnextday/libtorrent/tags","blobs_url":"https://api.github.com/repos/tnextday/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnextday/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnextday/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnextday/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnextday/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/tnextday/libtorrent/languages","stargazers_url":"https://api.github.com/repos/tnextday/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/tnextday/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/tnextday/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/tnextday/libtorrent/subscription","commits_url":"https://api.github.com/repos/tnextday/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnextday/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnextday/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnextday/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/tnextday/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/tnextday/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnextday/libtorrent/merges","archive_url":"https://api.github.com/repos/tnextday/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnextday/libtorrent/downloads","issues_url":"https://api.github.com/repos/tnextday/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/tnextday/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/tnextday/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/tnextday/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnextday/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/tnextday/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/tnextday/libtorrent/deployments","created_at":"2016-11-14T12:57:09Z","updated_at":"2016-11-14T12:57:13Z","pushed_at":"2016-11-15T08:48:40Z","git_url":"git://github.com/tnextday/libtorrent.git","ssh_url":"git@github.com:tnextday/libtorrent.git","clone_url":"https://github.com/tnextday/libtorrent.git","svn_url":"https://github.com/tnextday/libtorrent","homepage":"http://libtorrent.org","size":52894,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"13f9c110789df67c10f223d02eb9ed8633f6b7c7","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2016-11-12T12:42:53Z","pushed_at":"2016-11-15T18:32:56Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":76662,"stargazers_count":585,"watchers_count":585,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":81,"forks":193,"open_issues":81,"watchers":585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1321"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1321"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1321/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1321/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/43979051e1065164cf4395c412db76476e8ad790"}}}}
{"actor":{"display_login":"arvidn"}}