{"action":"created","issue":{"url":"https://api.github.com/repos/gap-system/gap/issues/894","repository_url":"https://api.github.com/repos/gap-system/gap","labels_url":"https://api.github.com/repos/gap-system/gap/issues/894/labels{/name}","comments_url":"https://api.github.com/repos/gap-system/gap/issues/894/comments","events_url":"https://api.github.com/repos/gap-system/gap/issues/894/events","html_url":"https://github.com/gap-system/gap/pull/894","id":173963260,"number":894,"title":"Powerful p-Groups Feature","user":{"login":"grouptheoryenthusiast","id":15360696,"avatar_url":"https://avatars.githubusercontent.com/u/15360696?v=3","gravatar_id":"","url":"https://api.github.com/users/grouptheoryenthusiast","html_url":"https://github.com/grouptheoryenthusiast","followers_url":"https://api.github.com/users/grouptheoryenthusiast/followers","following_url":"https://api.github.com/users/grouptheoryenthusiast/following{/other_user}","gists_url":"https://api.github.com/users/grouptheoryenthusiast/gists{/gist_id}","starred_url":"https://api.github.com/users/grouptheoryenthusiast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouptheoryenthusiast/subscriptions","organizations_url":"https://api.github.com/users/grouptheoryenthusiast/orgs","repos_url":"https://api.github.com/users/grouptheoryenthusiast/repos","events_url":"https://api.github.com/users/grouptheoryenthusiast/events{/privacy}","received_events_url":"https://api.github.com/users/grouptheoryenthusiast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-30T08:49:46Z","updated_at":"2016-08-30T13:10:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gap-system/gap/pulls/894","html_url":"https://github.com/gap-system/gap/pull/894","diff_url":"https://github.com/gap-system/gap/pull/894.diff","patch_url":"https://github.com/gap-system/gap/pull/894.patch"},"body":"Please make sure that this pull request:\r\n\r\n- [x] is submitted to the correct branch (the stable branch is only for bugfixes)\r\n\r\n- [x] contains an accurate description of changes for the release notes below\r\n\r\n- [x] provides new tests or relies on existing ones\r\n\r\n- [ ] correctly refers to other issues and related pull requests\r\n\r\n### Description of changes (for the release notes)\r\nThis feature adds the property`IsPowerfulPGroup` for groups, and the method `IsPowerfulPGroup(G)` . \r\nA finite p-group G is said to be a Powerful p-group if the commutator subgroup [G,G] is contained in\r\nG^{p} if the prime p is odd, or if [G,G] is contained in G^{4} if p=2.\r\nIn the case a p- group is powerful, then FrattiniSubgroup(G)=G^{p} . Therefore, if GAP knows a group is powerful and has the computed Agemos (which is most likely the case if it has tested if G is powerful), then using this feature it can quickly return the FrattiniSubgroup without doing any extra work.\r\n\r\n\r\nThis is my first time uploading a GAP feature, I hope everything seems okay.\r\n\r\n(Note: For more details on Powerful p-Groups, see:\r\nPowerful p-groups. I. Finite groups, Alexander Lubotzky, Avinoam Mann )\r\n"},"comment":{"url":"https://api.github.com/repos/gap-system/gap/issues/comments/243433191","html_url":"https://github.com/gap-system/gap/pull/894#issuecomment-243433191","issue_url":"https://api.github.com/repos/gap-system/gap/issues/894","id":243433191,"user":{"login":"grouptheoryenthusiast","id":15360696,"avatar_url":"https://avatars.githubusercontent.com/u/15360696?v=3","gravatar_id":"","url":"https://api.github.com/users/grouptheoryenthusiast","html_url":"https://github.com/grouptheoryenthusiast","followers_url":"https://api.github.com/users/grouptheoryenthusiast/followers","following_url":"https://api.github.com/users/grouptheoryenthusiast/following{/other_user}","gists_url":"https://api.github.com/users/grouptheoryenthusiast/gists{/gist_id}","starred_url":"https://api.github.com/users/grouptheoryenthusiast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouptheoryenthusiast/subscriptions","organizations_url":"https://api.github.com/users/grouptheoryenthusiast/orgs","repos_url":"https://api.github.com/users/grouptheoryenthusiast/repos","events_url":"https://api.github.com/users/grouptheoryenthusiast/events{/privacy}","received_events_url":"https://api.github.com/users/grouptheoryenthusiast/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T13:10:34Z","updated_at":"2016-08-30T13:10:34Z","body":"Hi @ChrisJefferson ,\r\nThank you for your suggestions. I have removed the white space and also changed the error to  instead `return false` as you suggested . I have pushed these commits to the branch. \r\nAs I am still learning git I think on this occasion I would prefer one of you to 'rebase' the code. \r\nThank you\r\nJames "}}
{"actor":{"display_login":"grouptheoryenthusiast"}}