{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/comments/70479891","id":70479891,"diff_hunk":"@@ -68,11 +70,55 @@\n         }\n     }\n \n+    /**\n+     * Looks for a {@link Descriptor} that has the given symbol\n+     *\n+     * @param type\n+     *      Restrict the search to a subset of {@link Describable}\n+     */\n+    public <T> Descriptor<? extends T> findDescriptor(Class<T> type, String symbol) {\n+        try {\n+            Key k = new Key(\"findDescriptor\",type,symbol);\n+            Object i = cache.get(k);\n+            if (i!=null)    return (Descriptor)i;\n+\n+            // not allowing @Symbol to use an invalid identifier.\n+            // TODO: compile time check","path":"plugin/src/main/java/org/jenkinsci/plugins/structs/SymbolLookup.java","position":35,"original_position":35,"commit_id":"17d61bd90f10d932d32e71201752cb0dfda3ad38","original_commit_id":"17d61bd90f10d932d32e71201752cb0dfda3ad38","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Should be easy enough with an `AnnotationProcessor`, no?","created_at":"2016-07-12T17:13:06Z","updated_at":"2016-07-12T17:13:06Z","html_url":"https://github.com/jenkinsci/structs-plugin/pull/7#discussion_r70479891","pull_request_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/comments/70479891"},"html":{"href":"https://github.com/jenkinsci/structs-plugin/pull/7#discussion_r70479891"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7","id":75734775,"html_url":"https://github.com/jenkinsci/structs-plugin/pull/7","diff_url":"https://github.com/jenkinsci/structs-plugin/pull/7.diff","patch_url":"https://github.com/jenkinsci/structs-plugin/pull/7.patch","issue_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/7","number":7,"state":"open","locked":false,"title":"[JENKINS-29922] make structs plugin aware of symbols","user":{"login":"kohsuke","id":50003,"avatar_url":"https://avatars.githubusercontent.com/u/50003?v=3","gravatar_id":"","url":"https://api.github.com/users/kohsuke","html_url":"https://github.com/kohsuke","followers_url":"https://api.github.com/users/kohsuke/followers","following_url":"https://api.github.com/users/kohsuke/following{/other_user}","gists_url":"https://api.github.com/users/kohsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/kohsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohsuke/subscriptions","organizations_url":"https://api.github.com/users/kohsuke/orgs","repos_url":"https://api.github.com/users/kohsuke/repos","events_url":"https://api.github.com/users/kohsuke/events{/privacy}","received_events_url":"https://api.github.com/users/kohsuke/received_events","type":"User","site_admin":false},"body":"Introduced a new `UninstantiatedDescribable` type that represents a de-composed instance with possible symbol & class annotation.","created_at":"2016-06-29T22:48:42Z","updated_at":"2016-07-12T17:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"499627d30ff31818b76c946e505c3f7a4286a6bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/7/comments","statuses_url":"https://api.github.com/repos/jenkinsci/structs-plugin/statuses/17d61bd90f10d932d32e71201752cb0dfda3ad38","head":{"label":"jenkinsci:JENKINS-29922","ref":"JENKINS-29922","sha":"17d61bd90f10d932d32e71201752cb0dfda3ad38","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":48337544,"name":"structs-plugin","full_name":"jenkinsci/structs-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/structs-plugin","description":"Library plugin for DSL plugins that need concise names for Jenkins extensions","fork":false,"url":"https://api.github.com/repos/jenkinsci/structs-plugin","forks_url":"https://api.github.com/repos/jenkinsci/structs-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/structs-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/structs-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/structs-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/structs-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/structs-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/structs-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/structs-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/structs-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/structs-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/structs-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/structs-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/structs-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/structs-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/structs-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/structs-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/structs-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/structs-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/structs-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/structs-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/structs-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/structs-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/structs-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/structs-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/structs-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/deployments","created_at":"2015-12-20T21:18:38Z","updated_at":"2016-04-14T07:49:43Z","pushed_at":"2016-07-12T17:03:53Z","git_url":"git://github.com/jenkinsci/structs-plugin.git","ssh_url":"git@github.com:jenkinsci/structs-plugin.git","clone_url":"https://github.com/jenkinsci/structs-plugin.git","svn_url":"https://github.com/jenkinsci/structs-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Structs+plugin","size":159,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"987035fe16b52f0e4419a59df93fd23284ce52b8","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":48337544,"name":"structs-plugin","full_name":"jenkinsci/structs-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/structs-plugin","description":"Library plugin for DSL plugins that need concise names for Jenkins extensions","fork":false,"url":"https://api.github.com/repos/jenkinsci/structs-plugin","forks_url":"https://api.github.com/repos/jenkinsci/structs-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/structs-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/structs-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/structs-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/structs-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/structs-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/structs-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/structs-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/structs-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/structs-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/structs-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/structs-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/structs-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/structs-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/structs-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/structs-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/structs-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/structs-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/structs-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/structs-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/structs-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/structs-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/structs-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/structs-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/structs-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/structs-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/structs-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/structs-plugin/deployments","created_at":"2015-12-20T21:18:38Z","updated_at":"2016-04-14T07:49:43Z","pushed_at":"2016-07-12T17:03:53Z","git_url":"git://github.com/jenkinsci/structs-plugin.git","ssh_url":"git@github.com:jenkinsci/structs-plugin.git","clone_url":"https://github.com/jenkinsci/structs-plugin.git","svn_url":"https://github.com/jenkinsci/structs-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Structs+plugin","size":159,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7"},"html":{"href":"https://github.com/jenkinsci/structs-plugin/pull/7"},"issue":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/7"},"comments":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/structs-plugin/statuses/17d61bd90f10d932d32e71201752cb0dfda3ad38"}}}}
{"actor":{"display_login":"jglick"}}