{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3432","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3432/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3432/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3432/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/3432","id":188747335,"number":3432,"title":"Fix issue in adding RAW disk in block storage domain","user":{"login":"nijinashok","id":15168927,"avatar_url":"https://avatars.githubusercontent.com/u/15168927?v=3","gravatar_id":"","url":"https://api.github.com/users/nijinashok","html_url":"https://github.com/nijinashok","followers_url":"https://api.github.com/users/nijinashok/followers","following_url":"https://api.github.com/users/nijinashok/following{/other_user}","gists_url":"https://api.github.com/users/nijinashok/gists{/gist_id}","starred_url":"https://api.github.com/users/nijinashok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijinashok/subscriptions","organizations_url":"https://api.github.com/users/nijinashok/orgs","repos_url":"https://api.github.com/users/nijinashok/repos","events_url":"https://api.github.com/users/nijinashok/events{/privacy}","received_events_url":"https://api.github.com/users/nijinashok/received_events","type":"User","site_admin":false},"labels":[{"id":132898045,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270","default":false},{"id":132898074,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":229425764,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/community_review","name":"community_review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-11T12:11:47Z","updated_at":"2016-11-16T17:24:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3432","html_url":"https://github.com/ansible/ansible-modules-extras/pull/3432","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/3432.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/3432.patch"},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nOvirt\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.3.0 (devel)\r\n```\r\n\r\n##### SUMMARY\r\nOvirt won't allow to add RAW sparse disk in block storage domain and is only available in file based storage domain. By default, sparse option is true in ovirt. So currently the raw disk creation using this module in a block storage domain will fail with error \"Disk configuration (RAW Sparse) is incompatible with the storage domain type\". \r\n\r\nThe commit adds sparse option where user can pass it as \"True/False\". So while creating RAW disk in block storage domain, we can pass \"sparse = False\" to make it work."},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/261011638","html_url":"https://github.com/ansible/ansible-modules-extras/pull/3432#issuecomment-261011638","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3432","id":261011638,"user":{"login":"machacekondra","id":3384302,"avatar_url":"https://avatars.githubusercontent.com/u/3384302?v=3","gravatar_id":"","url":"https://api.github.com/users/machacekondra","html_url":"https://github.com/machacekondra","followers_url":"https://api.github.com/users/machacekondra/followers","following_url":"https://api.github.com/users/machacekondra/following{/other_user}","gists_url":"https://api.github.com/users/machacekondra/gists{/gist_id}","starred_url":"https://api.github.com/users/machacekondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machacekondra/subscriptions","organizations_url":"https://api.github.com/users/machacekondra/orgs","repos_url":"https://api.github.com/users/machacekondra/repos","events_url":"https://api.github.com/users/machacekondra/events{/privacy}","received_events_url":"https://api.github.com/users/machacekondra/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T17:24:05Z","updated_at":"2016-11-16T17:24:05Z","body":"Thank you, looks good to me. Maybe I would replace ```False if self._module.params.get('format') == 'raw' else True``` with ```self._module.params.get('format').lower() != 'raw'```, but not critical I guess.\r\n\r\n@mperina Can you please review? As oVirt support following matrix:\r\n\r\nfile based storage:\r\n - RAW preallocated\r\n - RAW sparse\r\n - qcow2 sparse\r\n\r\nblock storage:\r\n - RAW preallocated\r\n - qcow2 sparse\r\n\r\nSo in my opinion we should create always this options:\r\n  - RAW preallocated\r\n  - qcow2 sparse\r\n\r\nunless oVirt will support more."}}
{"actor":{"display_login":"machacekondra"}}