{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/91056198","pull_request_review_id":11566037,"id":91056198,"diff_hunk":"@@ -34,6 +33,7 @@\n                 <argument>Symfony\\Component\\ClassLoader\\ClassCollectionLoader</argument>","path":"src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml","position":9,"original_position":9,"commit_id":"ea2602885d452dd5db73d2e455ce419f0366404f","original_commit_id":"ea2602885d452dd5db73d2e455ce419f0366404f","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"you should remove this line","created_at":"2016-12-06T11:07:38Z","updated_at":"2016-12-06T11:07:38Z","html_url":"https://github.com/symfony/symfony/pull/20735#discussion_r91056198","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20735","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/91056198"},"html":{"href":"https://github.com/symfony/symfony/pull/20735#discussion_r91056198"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20735"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20735","id":96394426,"html_url":"https://github.com/symfony/symfony/pull/20735","diff_url":"https://github.com/symfony/symfony/pull/20735.diff","patch_url":"https://github.com/symfony/symfony/pull/20735.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20735","number":20735,"state":"open","locked":false,"title":"Deprecate ClassCollectionLoader and Kernel::loadClassCache","user":{"login":"dbrumann","id":2952726,"avatar_url":"https://avatars.githubusercontent.com/u/2952726?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrumann","html_url":"https://github.com/dbrumann","followers_url":"https://api.github.com/users/dbrumann/followers","following_url":"https://api.github.com/users/dbrumann/following{/other_user}","gists_url":"https://api.github.com/users/dbrumann/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrumann/subscriptions","organizations_url":"https://api.github.com/users/dbrumann/orgs","repos_url":"https://api.github.com/users/dbrumann/repos","events_url":"https://api.github.com/users/dbrumann/events{/privacy}","received_events_url":"https://api.github.com/users/dbrumann/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | \"master\"\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #20668\r\n| License       | MIT\r\n\r\nAs suggested by @nicolas-grekas in #20668 I added deprecation notices to ClassCollectionLoader and Kernel::loadClassCache.","created_at":"2016-12-03T10:57:47Z","updated_at":"2016-12-06T11:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"522ad8c20fc724c16c629294bcbcb25cbc10a973","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20735/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20735/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20735/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ea2602885d452dd5db73d2e455ce419f0366404f","head":{"label":"dbrumann:class_cache_deprecations","ref":"class_cache_deprecations","sha":"ea2602885d452dd5db73d2e455ce419f0366404f","user":{"login":"dbrumann","id":2952726,"avatar_url":"https://avatars.githubusercontent.com/u/2952726?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrumann","html_url":"https://github.com/dbrumann","followers_url":"https://api.github.com/users/dbrumann/followers","following_url":"https://api.github.com/users/dbrumann/following{/other_user}","gists_url":"https://api.github.com/users/dbrumann/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrumann/subscriptions","organizations_url":"https://api.github.com/users/dbrumann/orgs","repos_url":"https://api.github.com/users/dbrumann/repos","events_url":"https://api.github.com/users/dbrumann/events{/privacy}","received_events_url":"https://api.github.com/users/dbrumann/received_events","type":"User","site_admin":false},"repo":{"id":75464646,"name":"symfony","full_name":"dbrumann/symfony","owner":{"login":"dbrumann","id":2952726,"avatar_url":"https://avatars.githubusercontent.com/u/2952726?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrumann","html_url":"https://github.com/dbrumann","followers_url":"https://api.github.com/users/dbrumann/followers","following_url":"https://api.github.com/users/dbrumann/following{/other_user}","gists_url":"https://api.github.com/users/dbrumann/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrumann/subscriptions","organizations_url":"https://api.github.com/users/dbrumann/orgs","repos_url":"https://api.github.com/users/dbrumann/repos","events_url":"https://api.github.com/users/dbrumann/events{/privacy}","received_events_url":"https://api.github.com/users/dbrumann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbrumann/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/dbrumann/symfony","forks_url":"https://api.github.com/repos/dbrumann/symfony/forks","keys_url":"https://api.github.com/repos/dbrumann/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbrumann/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbrumann/symfony/teams","hooks_url":"https://api.github.com/repos/dbrumann/symfony/hooks","issue_events_url":"https://api.github.com/repos/dbrumann/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/dbrumann/symfony/events","assignees_url":"https://api.github.com/repos/dbrumann/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/dbrumann/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/dbrumann/symfony/tags","blobs_url":"https://api.github.com/repos/dbrumann/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbrumann/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbrumann/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbrumann/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbrumann/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/dbrumann/symfony/languages","stargazers_url":"https://api.github.com/repos/dbrumann/symfony/stargazers","contributors_url":"https://api.github.com/repos/dbrumann/symfony/contributors","subscribers_url":"https://api.github.com/repos/dbrumann/symfony/subscribers","subscription_url":"https://api.github.com/repos/dbrumann/symfony/subscription","commits_url":"https://api.github.com/repos/dbrumann/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbrumann/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbrumann/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbrumann/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbrumann/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/dbrumann/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbrumann/symfony/merges","archive_url":"https://api.github.com/repos/dbrumann/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbrumann/symfony/downloads","issues_url":"https://api.github.com/repos/dbrumann/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/dbrumann/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/dbrumann/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/dbrumann/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbrumann/symfony/labels{/name}","releases_url":"https://api.github.com/repos/dbrumann/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/dbrumann/symfony/deployments","created_at":"2016-12-03T09:30:34Z","updated_at":"2016-12-03T09:30:52Z","pushed_at":"2016-12-05T06:33:53Z","git_url":"git://github.com/dbrumann/symfony.git","ssh_url":"git@github.com:dbrumann/symfony.git","clone_url":"https://github.com/dbrumann/symfony.git","svn_url":"https://github.com/dbrumann/symfony","homepage":"symfony.com","size":76924,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"60b4dd05145e2069361d4e1ccceaddb495210100","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-12-06T09:57:43Z","pushed_at":"2016-12-06T11:00:18Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":145015,"stargazers_count":13406,"watchers_count":13406,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5199,"mirror_url":null,"open_issues_count":860,"forks":5199,"open_issues":860,"watchers":13406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20735"},"html":{"href":"https://github.com/symfony/symfony/pull/20735"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20735"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20735/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20735/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20735/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ea2602885d452dd5db73d2e455ce419f0366404f"}}}}
{"actor":{"display_login":"nicolas-grekas"}}