{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments/72211134","id":72211134,"diff_hunk":"@@ -221,37 +217,64 @@ describe('test-reader', function() {\n             }\n         };\n \n+        glob\n+            .withArgs('some/path').yields(null, 'some/path');\n+\n         pathUtils.expandPaths\n             .withArgs(['some/path']).returns(q(['/some/path/file.js']));\n \n         return readTests_({config: config})\n-            .then(function() {\n+            .then(() => {\n                 assert.calledWith(testsApi, sinon.match.any, ['b1']);\n                 assert.callOrder(testsApi, utils.requireWithNoCache);\n             });\n     });\n \n-    it('should configure suite for all browsers if file not configured in sets', function() {\n-        var config = {\n+    it('should configure suite for all browsers if file not configured in sets', () => {\n+        const config = {\n             sets: {\n                 all: {\n                     files: ['some/path'],\n                     browsers: ['b1']\n                 }\n             },\n-            getBrowserIds: function() {\n-                return ['b1', 'b2'];\n-            }\n+            getBrowserIds: () => ['b1', 'b2']\n         };\n \n+        glob\n+            .withArgs('some/path').yields(null, 'some/path');\n         pathUtils.expandPaths\n             .withArgs(['some/path']).returns(q(['/some/path/file.js']))\n             .withArgs(['other/path']).returns(q(['/other/path/file2.js']));\n \n         return readTests_({paths: ['other/path'], config: config})\n-            .then(function() {\n+            .then(() => {\n                 assert.calledOnce(testsApi);\n                 assert.calledWith(testsApi, sinon.match.any, ['b1', 'b2']);\n             });\n     });\n+\n+    it('should get files using all templates', () => {\n+        const config = {\n+            sets: {\n+                set1: {\n+                    files: ['some/path']\n+                },\n+                set2: {\n+                    files: ['other/path']\n+                }\n+            }\n+        };\n+\n+        pathUtils.expandPaths.returns(q([]));\n+        glob\n+            .withArgs('some/path').yields(null, 'some/path')\n+            .withArgs('other/path').yields(null, 'other/path');\n+\n+        return readTests_({config: config})","path":"test/unit/test-reader.test.js","position":335,"original_position":335,"commit_id":"833c0cc4d1fa9802b60a9fa19657ef2491b15961","original_commit_id":"833c0cc4d1fa9802b60a9fa19657ef2491b15961","user":{"login":"tormozz48","id":996162,"avatar_url":"https://avatars.githubusercontent.com/u/996162?v=3","gravatar_id":"","url":"https://api.github.com/users/tormozz48","html_url":"https://github.com/tormozz48","followers_url":"https://api.github.com/users/tormozz48/followers","following_url":"https://api.github.com/users/tormozz48/following{/other_user}","gists_url":"https://api.github.com/users/tormozz48/gists{/gist_id}","starred_url":"https://api.github.com/users/tormozz48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormozz48/subscriptions","organizations_url":"https://api.github.com/users/tormozz48/orgs","repos_url":"https://api.github.com/users/tormozz48/repos","events_url":"https://api.github.com/users/tormozz48/events{/privacy}","received_events_url":"https://api.github.com/users/tormozz48/received_events","type":"User","site_admin":false},"body":"```\r\nreturn readTests_({config})\r\n```","created_at":"2016-07-26T08:54:07Z","updated_at":"2016-07-26T08:54:07Z","html_url":"https://github.com/gemini-testing/gemini/pull/531#discussion_r72211134","pull_request_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/531","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments/72211134"},"html":{"href":"https://github.com/gemini-testing/gemini/pull/531#discussion_r72211134"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/531"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/gemini/pulls/531","id":78695422,"html_url":"https://github.com/gemini-testing/gemini/pull/531","diff_url":"https://github.com/gemini-testing/gemini/pull/531.diff","patch_url":"https://github.com/gemini-testing/gemini/pull/531.patch","issue_url":"https://api.github.com/repos/gemini-testing/gemini/issues/531","number":531,"state":"open","locked":false,"title":"Saving test-suites in a block folder","user":{"login":"RostislavShtanko","id":8089139,"avatar_url":"https://avatars.githubusercontent.com/u/8089139?v=3","gravatar_id":"","url":"https://api.github.com/users/RostislavShtanko","html_url":"https://github.com/RostislavShtanko","followers_url":"https://api.github.com/users/RostislavShtanko/followers","following_url":"https://api.github.com/users/RostislavShtanko/following{/other_user}","gists_url":"https://api.github.com/users/RostislavShtanko/gists{/gist_id}","starred_url":"https://api.github.com/users/RostislavShtanko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RostislavShtanko/subscriptions","organizations_url":"https://api.github.com/users/RostislavShtanko/orgs","repos_url":"https://api.github.com/users/RostislavShtanko/repos","events_url":"https://api.github.com/users/RostislavShtanko/events{/privacy}","received_events_url":"https://api.github.com/users/RostislavShtanko/received_events","type":"User","site_admin":false},"body":"@j0tunn, @sipayRT, @eGavr, @tormozz48 ","created_at":"2016-07-25T14:53:15Z","updated_at":"2016-07-26T08:54:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97c7370da6add99d0bb5bc1ad5a58695f81363ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/531/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/531/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/gemini/issues/531/comments","statuses_url":"https://api.github.com/repos/gemini-testing/gemini/statuses/833c0cc4d1fa9802b60a9fa19657ef2491b15961","head":{"label":"gemini-testing:test-suites-in-block-folder","ref":"test-suites-in-block-folder","sha":"833c0cc4d1fa9802b60a9fa19657ef2491b15961","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":16734168,"name":"gemini","full_name":"gemini-testing/gemini","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/gemini","description":"Utility for regression testing of web pages using screenshots","fork":false,"url":"https://api.github.com/repos/gemini-testing/gemini","forks_url":"https://api.github.com/repos/gemini-testing/gemini/forks","keys_url":"https://api.github.com/repos/gemini-testing/gemini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/gemini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/gemini/teams","hooks_url":"https://api.github.com/repos/gemini-testing/gemini/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/gemini/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/gemini/events","assignees_url":"https://api.github.com/repos/gemini-testing/gemini/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/gemini/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/gemini/tags","blobs_url":"https://api.github.com/repos/gemini-testing/gemini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/gemini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/gemini/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/gemini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/gemini/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/gemini/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/gemini/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/gemini/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/gemini/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/gemini/subscription","commits_url":"https://api.github.com/repos/gemini-testing/gemini/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/gemini/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/gemini/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/gemini/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/gemini/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/gemini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/gemini/merges","archive_url":"https://api.github.com/repos/gemini-testing/gemini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/gemini/downloads","issues_url":"https://api.github.com/repos/gemini-testing/gemini/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/gemini/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/gemini/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/gemini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/gemini/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/gemini/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/gemini/deployments","created_at":"2014-02-11T14:58:41Z","updated_at":"2016-07-26T08:33:52Z","pushed_at":"2016-07-26T08:47:22Z","git_url":"git://github.com/gemini-testing/gemini.git","ssh_url":"git@github.com:gemini-testing/gemini.git","clone_url":"https://github.com/gemini-testing/gemini.git","svn_url":"https://github.com/gemini-testing/gemini","homepage":"http://gemini-testing.github.io/gemini/","size":1929,"stargazers_count":614,"watchers_count":614,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":63,"forks":72,"open_issues":63,"watchers":614,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"d8f5caabca6f51e4645248d693a55ad45d15c5c3","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":16734168,"name":"gemini","full_name":"gemini-testing/gemini","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/gemini","description":"Utility for regression testing of web pages using screenshots","fork":false,"url":"https://api.github.com/repos/gemini-testing/gemini","forks_url":"https://api.github.com/repos/gemini-testing/gemini/forks","keys_url":"https://api.github.com/repos/gemini-testing/gemini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/gemini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/gemini/teams","hooks_url":"https://api.github.com/repos/gemini-testing/gemini/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/gemini/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/gemini/events","assignees_url":"https://api.github.com/repos/gemini-testing/gemini/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/gemini/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/gemini/tags","blobs_url":"https://api.github.com/repos/gemini-testing/gemini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/gemini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/gemini/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/gemini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/gemini/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/gemini/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/gemini/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/gemini/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/gemini/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/gemini/subscription","commits_url":"https://api.github.com/repos/gemini-testing/gemini/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/gemini/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/gemini/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/gemini/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/gemini/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/gemini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/gemini/merges","archive_url":"https://api.github.com/repos/gemini-testing/gemini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/gemini/downloads","issues_url":"https://api.github.com/repos/gemini-testing/gemini/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/gemini/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/gemini/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/gemini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/gemini/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/gemini/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/gemini/deployments","created_at":"2014-02-11T14:58:41Z","updated_at":"2016-07-26T08:33:52Z","pushed_at":"2016-07-26T08:47:22Z","git_url":"git://github.com/gemini-testing/gemini.git","ssh_url":"git@github.com:gemini-testing/gemini.git","clone_url":"https://github.com/gemini-testing/gemini.git","svn_url":"https://github.com/gemini-testing/gemini","homepage":"http://gemini-testing.github.io/gemini/","size":1929,"stargazers_count":614,"watchers_count":614,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":63,"forks":72,"open_issues":63,"watchers":614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/531"},"html":{"href":"https://github.com/gemini-testing/gemini/pull/531"},"issue":{"href":"https://api.github.com/repos/gemini-testing/gemini/issues/531"},"comments":{"href":"https://api.github.com/repos/gemini-testing/gemini/issues/531/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/531/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/531/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/gemini/statuses/833c0cc4d1fa9802b60a9fa19657ef2491b15961"}}}}
{"actor":{"display_login":"tormozz48"}}