{"action":"created","comment":{"url":"https://api.github.com/repos/chaijs/chai/pulls/comments/77221854","id":77221854,"diff_hunk":"@@ -732,6 +732,26 @@ module.exports = function (chai, util) {\n     new Assertion(val, msg).to.not.be.a('number');\n   };\n \n+   /**\n+   * ### .isFinite(value, [message])\n+   *\n+   * Asserts that `value` is a finite number. This will fail for NaN, unlike `.isNumber`\n+   * Asserts that `value` is a finite number. Unlike `.isNumber`, this will fail for `NaN` and `Infinity`","path":"lib/chai/interface/assert.js","position":8,"original_position":8,"commit_id":"9d914143fc77ffbfc2f750c4116fc7a8d1e5894c","original_commit_id":"9d914143fc77ffbfc2f750c4116fc7a8d1e5894c","user":{"login":"lucasfcosta","id":6868147,"avatar_url":"https://avatars.githubusercontent.com/u/6868147?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasfcosta","html_url":"https://github.com/lucasfcosta","followers_url":"https://api.github.com/users/lucasfcosta/followers","following_url":"https://api.github.com/users/lucasfcosta/following{/other_user}","gists_url":"https://api.github.com/users/lucasfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasfcosta/subscriptions","organizations_url":"https://api.github.com/users/lucasfcosta/orgs","repos_url":"https://api.github.com/users/lucasfcosta/repos","events_url":"https://api.github.com/users/lucasfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/lucasfcosta/received_events","type":"User","site_admin":false},"body":"Agreed.\r\nIMO leaving only the last one would be more appropriate.","created_at":"2016-09-01T17:53:44Z","updated_at":"2016-09-01T17:53:44Z","html_url":"https://github.com/chaijs/chai/pull/779#discussion_r77221854","pull_request_url":"https://api.github.com/repos/chaijs/chai/pulls/779","_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments/77221854"},"html":{"href":"https://github.com/chaijs/chai/pull/779#discussion_r77221854"},"pull_request":{"href":"https://api.github.com/repos/chaijs/chai/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/779","id":83675271,"html_url":"https://github.com/chaijs/chai/pull/779","diff_url":"https://github.com/chaijs/chai/pull/779.diff","patch_url":"https://github.com/chaijs/chai/pull/779.patch","issue_url":"https://api.github.com/repos/chaijs/chai/issues/779","number":779,"state":"open","locked":false,"title":"Adding `.finite`. Fixes #271","user":{"login":"TheSavior","id":249164,"avatar_url":"https://avatars.githubusercontent.com/u/249164?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSavior","html_url":"https://github.com/TheSavior","followers_url":"https://api.github.com/users/TheSavior/followers","following_url":"https://api.github.com/users/TheSavior/following{/other_user}","gists_url":"https://api.github.com/users/TheSavior/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSavior/subscriptions","organizations_url":"https://api.github.com/users/TheSavior/orgs","repos_url":"https://api.github.com/users/TheSavior/repos","events_url":"https://api.github.com/users/TheSavior/events{/privacy}","received_events_url":"https://api.github.com/users/TheSavior/received_events","type":"User","site_admin":false},"body":"As discussed in #271, `.isNumber` currently passes for `NaN`. This issue recently bit our team and so we wanted to move forward on the proposal in that issue. \r\n\r\nThe implementation is the polyfill from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite.","created_at":"2016-09-01T17:37:38Z","updated_at":"2016-09-01T17:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a524665b975b2c49c0fd5cf731d7c95a085757a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaijs/chai/pulls/779/commits","review_comments_url":"https://api.github.com/repos/chaijs/chai/pulls/779/comments","review_comment_url":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/779/comments","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/9d914143fc77ffbfc2f750c4116fc7a8d1e5894c","head":{"label":"TheSavior:is-finite","ref":"is-finite","sha":"9d914143fc77ffbfc2f750c4116fc7a8d1e5894c","user":{"login":"TheSavior","id":249164,"avatar_url":"https://avatars.githubusercontent.com/u/249164?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSavior","html_url":"https://github.com/TheSavior","followers_url":"https://api.github.com/users/TheSavior/followers","following_url":"https://api.github.com/users/TheSavior/following{/other_user}","gists_url":"https://api.github.com/users/TheSavior/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSavior/subscriptions","organizations_url":"https://api.github.com/users/TheSavior/orgs","repos_url":"https://api.github.com/users/TheSavior/repos","events_url":"https://api.github.com/users/TheSavior/events{/privacy}","received_events_url":"https://api.github.com/users/TheSavior/received_events","type":"User","site_admin":false},"repo":{"id":67149484,"name":"chai","full_name":"TheSavior/chai","owner":{"login":"TheSavior","id":249164,"avatar_url":"https://avatars.githubusercontent.com/u/249164?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSavior","html_url":"https://github.com/TheSavior","followers_url":"https://api.github.com/users/TheSavior/followers","following_url":"https://api.github.com/users/TheSavior/following{/other_user}","gists_url":"https://api.github.com/users/TheSavior/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSavior/subscriptions","organizations_url":"https://api.github.com/users/TheSavior/orgs","repos_url":"https://api.github.com/users/TheSavior/repos","events_url":"https://api.github.com/users/TheSavior/events{/privacy}","received_events_url":"https://api.github.com/users/TheSavior/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheSavior/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":true,"url":"https://api.github.com/repos/TheSavior/chai","forks_url":"https://api.github.com/repos/TheSavior/chai/forks","keys_url":"https://api.github.com/repos/TheSavior/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheSavior/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheSavior/chai/teams","hooks_url":"https://api.github.com/repos/TheSavior/chai/hooks","issue_events_url":"https://api.github.com/repos/TheSavior/chai/issues/events{/number}","events_url":"https://api.github.com/repos/TheSavior/chai/events","assignees_url":"https://api.github.com/repos/TheSavior/chai/assignees{/user}","branches_url":"https://api.github.com/repos/TheSavior/chai/branches{/branch}","tags_url":"https://api.github.com/repos/TheSavior/chai/tags","blobs_url":"https://api.github.com/repos/TheSavior/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheSavior/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheSavior/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheSavior/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheSavior/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/TheSavior/chai/languages","stargazers_url":"https://api.github.com/repos/TheSavior/chai/stargazers","contributors_url":"https://api.github.com/repos/TheSavior/chai/contributors","subscribers_url":"https://api.github.com/repos/TheSavior/chai/subscribers","subscription_url":"https://api.github.com/repos/TheSavior/chai/subscription","commits_url":"https://api.github.com/repos/TheSavior/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheSavior/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheSavior/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheSavior/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheSavior/chai/contents/{+path}","compare_url":"https://api.github.com/repos/TheSavior/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheSavior/chai/merges","archive_url":"https://api.github.com/repos/TheSavior/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheSavior/chai/downloads","issues_url":"https://api.github.com/repos/TheSavior/chai/issues{/number}","pulls_url":"https://api.github.com/repos/TheSavior/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/TheSavior/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/TheSavior/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheSavior/chai/labels{/name}","releases_url":"https://api.github.com/repos/TheSavior/chai/releases{/id}","deployments_url":"https://api.github.com/repos/TheSavior/chai/deployments","created_at":"2016-09-01T16:47:41Z","updated_at":"2016-09-01T16:47:42Z","pushed_at":"2016-09-01T17:35:07Z","git_url":"git://github.com/TheSavior/chai.git","ssh_url":"git@github.com:TheSavior/chai.git","clone_url":"https://github.com/TheSavior/chai.git","svn_url":"https://github.com/TheSavior/chai","homepage":"http://chaijs.com","size":3450,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaijs:master","ref":"master","sha":"93905a7441242565d36e805549767c3d2bd35461","user":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"repo":{"id":2931111,"name":"chai","full_name":"chaijs/chai","owner":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chaijs/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":false,"url":"https://api.github.com/repos/chaijs/chai","forks_url":"https://api.github.com/repos/chaijs/chai/forks","keys_url":"https://api.github.com/repos/chaijs/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaijs/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaijs/chai/teams","hooks_url":"https://api.github.com/repos/chaijs/chai/hooks","issue_events_url":"https://api.github.com/repos/chaijs/chai/issues/events{/number}","events_url":"https://api.github.com/repos/chaijs/chai/events","assignees_url":"https://api.github.com/repos/chaijs/chai/assignees{/user}","branches_url":"https://api.github.com/repos/chaijs/chai/branches{/branch}","tags_url":"https://api.github.com/repos/chaijs/chai/tags","blobs_url":"https://api.github.com/repos/chaijs/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaijs/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaijs/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaijs/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/chaijs/chai/languages","stargazers_url":"https://api.github.com/repos/chaijs/chai/stargazers","contributors_url":"https://api.github.com/repos/chaijs/chai/contributors","subscribers_url":"https://api.github.com/repos/chaijs/chai/subscribers","subscription_url":"https://api.github.com/repos/chaijs/chai/subscription","commits_url":"https://api.github.com/repos/chaijs/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaijs/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaijs/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaijs/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaijs/chai/contents/{+path}","compare_url":"https://api.github.com/repos/chaijs/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaijs/chai/merges","archive_url":"https://api.github.com/repos/chaijs/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaijs/chai/downloads","issues_url":"https://api.github.com/repos/chaijs/chai/issues{/number}","pulls_url":"https://api.github.com/repos/chaijs/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/chaijs/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/chaijs/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaijs/chai/labels{/name}","releases_url":"https://api.github.com/repos/chaijs/chai/releases{/id}","deployments_url":"https://api.github.com/repos/chaijs/chai/deployments","created_at":"2011-12-07T08:06:35Z","updated_at":"2016-09-01T12:31:15Z","pushed_at":"2016-09-01T17:37:38Z","git_url":"git://github.com/chaijs/chai.git","ssh_url":"git@github.com:chaijs/chai.git","clone_url":"https://github.com/chaijs/chai.git","svn_url":"https://github.com/chaijs/chai","homepage":"http://chaijs.com","size":3450,"stargazers_count":3287,"watchers_count":3287,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":306,"mirror_url":null,"open_issues_count":31,"forks":306,"open_issues":31,"watchers":3287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/779"},"html":{"href":"https://github.com/chaijs/chai/pull/779"},"issue":{"href":"https://api.github.com/repos/chaijs/chai/issues/779"},"comments":{"href":"https://api.github.com/repos/chaijs/chai/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/chaijs/chai/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaijs/chai/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/chaijs/chai/statuses/9d914143fc77ffbfc2f750c4116fc7a8d1e5894c"}}}}
{"actor":{"display_login":"lucasfcosta"}}