{"action":"created","issue":{"url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/1808","repository_url":"https://api.github.com/repos/fusionpbx/fusionpbx","labels_url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/1808/labels{/name}","comments_url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/1808/comments","events_url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/1808/events","html_url":"https://github.com/fusionpbx/fusionpbx/issues/1808","id":170445136,"number":1808,"title":"New ring's in vars.xml are not imported","user":{"login":"mafoo","id":15364279,"avatar_url":"https://avatars.githubusercontent.com/u/15364279?v=3","gravatar_id":"","url":"https://api.github.com/users/mafoo","html_url":"https://github.com/mafoo","followers_url":"https://api.github.com/users/mafoo/followers","following_url":"https://api.github.com/users/mafoo/following{/other_user}","gists_url":"https://api.github.com/users/mafoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mafoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafoo/subscriptions","organizations_url":"https://api.github.com/users/mafoo/orgs","repos_url":"https://api.github.com/users/mafoo/repos","events_url":"https://api.github.com/users/mafoo/events{/privacy}","received_events_url":"https://api.github.com/users/mafoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-10T15:23:31Z","updated_at":"2016-08-11T19:14:03Z","closed_at":null,"body":"Currently if someone updates https://github.com/fusionpbx/fusionpbx/blob/master/resources/templates/conf/vars.xml to include a new ring type it won't get imported to fusionpbx as it only takes it's list of rings from https://github.com/fusionpbx/fusionpbx/blob/master/app/vars/app_defaults.php\r\nShould we either\r\n- remove the ring's from app_defaults and scan vars.xml for them\r\n  - Pro's\r\n    - Most obvious logical place to maintain the rings for people familiar with FreeSWITCH\r\n   - Con's\r\n     - cannot set attributes such as enabled or description (not that they are used at the moment)\r\n- migrate all but us-ring from vars.xml and add comment explaining to add them to app/vars/app_defaults\r\n  - Pro's\r\n    - Tells user what file to update and single point of maintenance\r\n    - Attributes such and enabled and description can be set\r\n\r\nLet me know or catch me on IRC and will implement it."},"comment":{"url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/comments/239261751","html_url":"https://github.com/fusionpbx/fusionpbx/issues/1808#issuecomment-239261751","issue_url":"https://api.github.com/repos/fusionpbx/fusionpbx/issues/1808","id":239261751,"user":{"login":"markjcrane","id":3408509,"avatar_url":"https://avatars.githubusercontent.com/u/3408509?v=3","gravatar_id":"","url":"https://api.github.com/users/markjcrane","html_url":"https://github.com/markjcrane","followers_url":"https://api.github.com/users/markjcrane/followers","following_url":"https://api.github.com/users/markjcrane/following{/other_user}","gists_url":"https://api.github.com/users/markjcrane/gists{/gist_id}","starred_url":"https://api.github.com/users/markjcrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markjcrane/subscriptions","organizations_url":"https://api.github.com/users/markjcrane/orgs","repos_url":"https://api.github.com/users/markjcrane/repos","events_url":"https://api.github.com/users/markjcrane/events{/privacy}","received_events_url":"https://api.github.com/users/markjcrane/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T19:14:03Z","updated_at":"2016-08-11T19:14:03Z","body":"Advanced -> Variables -> Ring Tones should have their own category called 'Ring Tones'\r\nVariables could be read from vars.xml and you can add additional attributes like enabled and description to the xml.\r\n\r\nOther option would be add an array to the app_config.php. Same way as permissions are handled or device vendors added to app/devices/app_config.php."}}
{"actor":{"display_login":"markjcrane"}}