{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/370","repository_url":"https://api.github.com/repos/strongloop/strong-remoting","labels_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/370/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/370/comments","events_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/370/events","html_url":"https://github.com/strongloop/strong-remoting/pull/370","id":182778774,"number":370,"title":"Don't asume 'file' resultType if type is 'File'","user":{"login":"fabien","id":2749,"avatar_url":"https://avatars.githubusercontent.com/u/2749?v=3","gravatar_id":"","url":"https://api.github.com/users/fabien","html_url":"https://github.com/fabien","followers_url":"https://api.github.com/users/fabien/followers","following_url":"https://api.github.com/users/fabien/following{/other_user}","gists_url":"https://api.github.com/users/fabien/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien/subscriptions","organizations_url":"https://api.github.com/users/fabien/orgs","repos_url":"https://api.github.com/users/fabien/repos","events_url":"https://api.github.com/users/fabien/events{/privacy}","received_events_url":"https://api.github.com/users/fabien/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/strongloop/strong-remoting/labels/%23review","name":"#review","color":"eeeeee"},{"url":"https://api.github.com/repos/strongloop/strong-remoting/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"assignees":[{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-10-13T12:42:05Z","updated_at":"2016-10-14T13:24:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/370","html_url":"https://github.com/strongloop/strong-remoting/pull/370","diff_url":"https://github.com/strongloop/strong-remoting/pull/370.diff","patch_url":"https://github.com/strongloop/strong-remoting/pull/370.patch"},"body":"If you have a Loopback model called `File` you'll receive following error when it is set as a return type: `Error: Cannot create a file response from object`\r\n\r\nIn other words, because `file` is now a reserved keyword with a very specific response handling logic, and `File` is lowercased during normalization into `resultType`, the error above would prevent any Loopback being named `File`. This introduced a breaking change for my apps.\r\n\r\nThis is loosely related to #318 but in the above case, it's actually not desirable to return a file (buffer/stream) response. Perhaps a more specific keyword than simply `file` would have been better in hindsight.\r\n\r\nSee also: https://github.com/strongloop/strong-remoting/commit/a85068ef1122751efbbf3e9b2a1b9439ae70fa3f#commitcomment-19410422\r\n\r\n@bajtos @richardpringle "},"comment":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/comments/253797794","html_url":"https://github.com/strongloop/strong-remoting/pull/370#issuecomment-253797794","issue_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/370","id":253797794,"user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T13:24:03Z","updated_at":"2016-10-14T13:24:03Z","body":"> Only concern would be the 3.0 release upgrade path for models named File, but I guess that's unavoidable.\r\n\r\nYes, I do realise this means users will have to rework their apps a bit when upgrading from 2.x to 3.0. As you said, this is unavoidable :("}}
{"actor":{"display_login":"bajtos"}}