{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/80323603","id":80323603,"diff_hunk":"@@ -123,7 +123,7 @@ def __init__(self):\n         self.preprocessors = None\n         self.outdated_settings = False\n         self.setup_layout()\n-        QTimer.singleShot(0, self.apply)\n+        QTimer.singleShot(0, self.update_learner)","path":"Orange/widgets/utils/owlearnerwidget.py","position":5,"original_position":5,"commit_id":"5c6b60a073e10b45c177693bce3b724982933a05","original_commit_id":"5c6b60a073e10b45c177693bce3b724982933a05","user":{"login":"janezd","id":2387315,"avatar_url":"https://avatars.githubusercontent.com/u/2387315?v=3","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"body":"@ales-erjavec, @astaric, please see #1601, which should also fix this problem. Two other widgets in education remove buttons, while (AFAIK) no widgets in core, bio, datafusion, network, prototypes or text extend `BaseLearner`.\r\n\r\nWhat about replacing the above line with\r\n`QTimer.singleShot(0, getattr(self, \"unconditional_apply\", self.apply))`?\r\n\r\nIf the widget does not have `unconditional_apply` it has either left `apply` as it is, hence calling it has the same effect as `unconditional_apply` would, or it has overridden `apply`, so we must call it anyway. If the widget creates its own Apply button with a callback with a different name, then it will have to reimplement the output initialization, too.","created_at":"2016-09-23T20:44:19Z","updated_at":"2016-09-23T20:44:19Z","html_url":"https://github.com/biolab/orange3/pull/1562#discussion_r80323603","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/1562","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/80323603"},"html":{"href":"https://github.com/biolab/orange3/pull/1562#discussion_r80323603"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1562"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1562","id":85532259,"html_url":"https://github.com/biolab/orange3/pull/1562","diff_url":"https://github.com/biolab/orange3/pull/1562.diff","patch_url":"https://github.com/biolab/orange3/pull/1562.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1562","number":1562,"state":"open","locked":false,"title":"[FIX] owlearnerwidget: Fix output initialization","user":{"login":"ales-erjavec","id":4716745,"avatar_url":"https://avatars.githubusercontent.com/u/4716745?v=3","gravatar_id":"","url":"https://api.github.com/users/ales-erjavec","html_url":"https://github.com/ales-erjavec","followers_url":"https://api.github.com/users/ales-erjavec/followers","following_url":"https://api.github.com/users/ales-erjavec/following{/other_user}","gists_url":"https://api.github.com/users/ales-erjavec/gists{/gist_id}","starred_url":"https://api.github.com/users/ales-erjavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ales-erjavec/subscriptions","organizations_url":"https://api.github.com/users/ales-erjavec/orgs","repos_url":"https://api.github.com/users/ales-erjavec/repos","events_url":"https://api.github.com/users/ales-erjavec/events{/privacy}","received_events_url":"https://api.github.com/users/ales-erjavec/received_events","type":"User","site_admin":false},"body":"<!--\r\nSquash the commits, as appropriate. See .github/CONTRIBUTING.md for\r\nmore information.\r\n\r\nDescribe the relevant changes in the commit messages, if they need explaining.\r\n \r\nIf the pull request introduces a new feature or an important bug fix, consider\r\nadding _one_ of the below tags, enclosed in square brackets, in its title:\r\n\r\n    ENH, FIX, DOC, WIP\r\n\r\nFor some example:\r\n\r\n    [ENH] CrossValidation: Parallelize computation\r\n    [FIX] NaiveBayesLearner: Don't crash on input containing nan values\r\n    [DOC] Extend documentation for widget development\r\n    [WIP] Working on X ... RFC please\r\n\r\nPull-requests not so tagged will be batched as \"other features and bugfixes,\"\r\nwhich is fine for stuff you don't go home and brag to your mother about.\r\n-->\r\n\r\nAlways output the initial learner, disregarding the `auto_apply`.","created_at":"2016-09-16T07:58:21Z","updated_at":"2016-09-23T20:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ae3a80adbf4c580be8c145cd7d167e2e5889e9e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/1562/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/1562/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1562/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/5c6b60a073e10b45c177693bce3b724982933a05","head":{"label":"ales-erjavec:base-learner-auto-commit-fix","ref":"base-learner-auto-commit-fix","sha":"5c6b60a073e10b45c177693bce3b724982933a05","user":{"login":"ales-erjavec","id":4716745,"avatar_url":"https://avatars.githubusercontent.com/u/4716745?v=3","gravatar_id":"","url":"https://api.github.com/users/ales-erjavec","html_url":"https://github.com/ales-erjavec","followers_url":"https://api.github.com/users/ales-erjavec/followers","following_url":"https://api.github.com/users/ales-erjavec/following{/other_user}","gists_url":"https://api.github.com/users/ales-erjavec/gists{/gist_id}","starred_url":"https://api.github.com/users/ales-erjavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ales-erjavec/subscriptions","organizations_url":"https://api.github.com/users/ales-erjavec/orgs","repos_url":"https://api.github.com/users/ales-erjavec/repos","events_url":"https://api.github.com/users/ales-erjavec/events{/privacy}","received_events_url":"https://api.github.com/users/ales-erjavec/received_events","type":"User","site_admin":false},"repo":{"id":23952313,"name":"orange3","full_name":"ales-erjavec/orange3","owner":{"login":"ales-erjavec","id":4716745,"avatar_url":"https://avatars.githubusercontent.com/u/4716745?v=3","gravatar_id":"","url":"https://api.github.com/users/ales-erjavec","html_url":"https://github.com/ales-erjavec","followers_url":"https://api.github.com/users/ales-erjavec/followers","following_url":"https://api.github.com/users/ales-erjavec/following{/other_user}","gists_url":"https://api.github.com/users/ales-erjavec/gists{/gist_id}","starred_url":"https://api.github.com/users/ales-erjavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ales-erjavec/subscriptions","organizations_url":"https://api.github.com/users/ales-erjavec/orgs","repos_url":"https://api.github.com/users/ales-erjavec/repos","events_url":"https://api.github.com/users/ales-erjavec/events{/privacy}","received_events_url":"https://api.github.com/users/ales-erjavec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ales-erjavec/orange3","description":"","fork":true,"url":"https://api.github.com/repos/ales-erjavec/orange3","forks_url":"https://api.github.com/repos/ales-erjavec/orange3/forks","keys_url":"https://api.github.com/repos/ales-erjavec/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ales-erjavec/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ales-erjavec/orange3/teams","hooks_url":"https://api.github.com/repos/ales-erjavec/orange3/hooks","issue_events_url":"https://api.github.com/repos/ales-erjavec/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/ales-erjavec/orange3/events","assignees_url":"https://api.github.com/repos/ales-erjavec/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/ales-erjavec/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/ales-erjavec/orange3/tags","blobs_url":"https://api.github.com/repos/ales-erjavec/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ales-erjavec/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ales-erjavec/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ales-erjavec/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ales-erjavec/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/ales-erjavec/orange3/languages","stargazers_url":"https://api.github.com/repos/ales-erjavec/orange3/stargazers","contributors_url":"https://api.github.com/repos/ales-erjavec/orange3/contributors","subscribers_url":"https://api.github.com/repos/ales-erjavec/orange3/subscribers","subscription_url":"https://api.github.com/repos/ales-erjavec/orange3/subscription","commits_url":"https://api.github.com/repos/ales-erjavec/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ales-erjavec/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ales-erjavec/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ales-erjavec/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ales-erjavec/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/ales-erjavec/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ales-erjavec/orange3/merges","archive_url":"https://api.github.com/repos/ales-erjavec/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ales-erjavec/orange3/downloads","issues_url":"https://api.github.com/repos/ales-erjavec/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/ales-erjavec/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/ales-erjavec/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/ales-erjavec/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ales-erjavec/orange3/labels{/name}","releases_url":"https://api.github.com/repos/ales-erjavec/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/ales-erjavec/orange3/deployments","created_at":"2014-09-12T08:09:36Z","updated_at":"2016-02-10T14:47:52Z","pushed_at":"2016-09-23T11:28:19Z","git_url":"git://github.com/ales-erjavec/orange3.git","ssh_url":"git@github.com:ales-erjavec/orange3.git","clone_url":"https://github.com/ales-erjavec/orange3.git","svn_url":"https://github.com/ales-erjavec/orange3","homepage":null,"size":39629,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"abbf69f429ea86558542e3cbbb12e99fb8641899","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-09-22T04:06:53Z","pushed_at":"2016-09-23T20:28:08Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":95248,"stargazers_count":493,"watchers_count":493,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":65,"forks":166,"open_issues":65,"watchers":493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1562"},"html":{"href":"https://github.com/biolab/orange3/pull/1562"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/1562"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/1562/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1562/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1562/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/5c6b60a073e10b45c177693bce3b724982933a05"}}}}
{"actor":{"display_login":"janezd"}}