{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4753","repository_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4753/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4753/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4753/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4753","id":166425253,"number":4753,"title":"Lut rnd","user":{"login":"jburel","id":1022396,"avatar_url":"https://avatars.githubusercontent.com/u/1022396?v=3","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-07-19T20:16:22Z","updated_at":"2016-08-11T15:57:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/4753","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4753","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4753.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4753.patch"},"body":"# What this PR does\r\nAdd support for LUT in the rendering engine.\r\nIf a LUt is set, the color on the rendering def is not used.\r\nIf a lut is not set or cannot be read, the color is used\r\n\r\nThumbnailBean and RenderingBean retrieve the luts using the ``scriptRepoHelper``.\r\nIntegration tests have been added/improved to test:\r\n * save of lut\r\n * read of lut. LUT readers are tested comparing the byte array of an image rendered with color and with lut.\r\n\r\n# Testing this PR\r\n\r\nCheck that the integration tests are green.\r\nCheck that the LUT are correctly applied using insight see PR https://github.com/openmicroscopy/openmicroscopy/pull/4752\r\n * Use a single channel image, e.g. ``single-channel.ome.tif``\r\n * compare display using the same lut in both insight and imagej or fiji\r\n\r\n# Related reading\r\nhttps://trello.com/c/9iAe3Sg9/95-lut-support"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/239205698","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4753#issuecomment-239205698","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4753","id":239205698,"user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars.githubusercontent.com/u/900055?v=3","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T15:57:42Z","updated_at":"2016-08-11T15:57:42Z","body":"Unionjack LUT and other new ones look correct (comparing with Fiji).\r\nColours are now being combined correctly. \r\nSmall issue with combining channels. E.g.\r\nhttps://eel.openmicroscopy.org/merge/webclient/?show=image-25351 (user 3)\r\nwhen mix \"yellow hot\" (channel 1) with Green (channel 2).\r\nNB: Don't see a problem with this same image if channel 2 is switched to Blue (No blue in the \"yellow hot\" LUT).\r\n\r\n![screen shot 2016-08-11 at 16 52 50](https://cloud.githubusercontent.com/assets/900055/17595301/616ca61e-5fe4-11e6-82b3-c2250dddf12f.png)"}}
{"actor":{"display_login":"will-moore"}}