{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/74960438","id":74960438,"diff_hunk":"@@ -1262,6 +1262,8 @@ def run(self):\n         except Exception as e:\n             self.error = e\n             self.is_ready.set()\n+        finally:\n+            connections.close_all()","path":"django/test/testcases.py","position":5,"original_position":5,"commit_id":"62329037a425f27d37408dc6a10a1210d0180e40","original_commit_id":"62329037a425f27d37408dc6a10a1210d0180e40","user":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"body":"Here all non-overriden connections should be closed. See the `self.connections_override` block above.","created_at":"2016-08-16T15:38:57Z","updated_at":"2016-08-16T15:38:57Z","html_url":"https://github.com/django/django/pull/7096#discussion_r74960438","pull_request_url":"https://api.github.com/repos/django/django/pulls/7096","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/74960438"},"html":{"href":"https://github.com/django/django/pull/7096#discussion_r74960438"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/7096"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/7096","id":81393726,"html_url":"https://github.com/django/django/pull/7096","diff_url":"https://github.com/django/django/pull/7096.diff","patch_url":"https://github.com/django/django/pull/7096.patch","issue_url":"https://api.github.com/repos/django/django/issues/7096","number":7096,"state":"open","locked":false,"title":"Fixed #22414 -- Ensured that LiveServerTestCase closes connections.","user":{"login":"cjerdonek","id":355822,"avatar_url":"https://avatars.githubusercontent.com/u/355822?v=3","gravatar_id":"","url":"https://api.github.com/users/cjerdonek","html_url":"https://github.com/cjerdonek","followers_url":"https://api.github.com/users/cjerdonek/followers","following_url":"https://api.github.com/users/cjerdonek/following{/other_user}","gists_url":"https://api.github.com/users/cjerdonek/gists{/gist_id}","starred_url":"https://api.github.com/users/cjerdonek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjerdonek/subscriptions","organizations_url":"https://api.github.com/users/cjerdonek/orgs","repos_url":"https://api.github.com/users/cjerdonek/repos","events_url":"https://api.github.com/users/cjerdonek/events{/privacy}","received_events_url":"https://api.github.com/users/cjerdonek/received_events","type":"User","site_admin":false},"body":"I confirmed on the CI servers that the test fails without the fix (on the mysql, postgres, and postgis configurations).","created_at":"2016-08-15T23:38:40Z","updated_at":"2016-08-16T15:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3400a28592cbc0bb973f13db25811cb728bb84f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/7096/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/7096/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/7096/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/62329037a425f27d37408dc6a10a1210d0180e40","head":{"label":"cjerdonek:ticket_22414","ref":"ticket_22414","sha":"62329037a425f27d37408dc6a10a1210d0180e40","user":{"login":"cjerdonek","id":355822,"avatar_url":"https://avatars.githubusercontent.com/u/355822?v=3","gravatar_id":"","url":"https://api.github.com/users/cjerdonek","html_url":"https://github.com/cjerdonek","followers_url":"https://api.github.com/users/cjerdonek/followers","following_url":"https://api.github.com/users/cjerdonek/following{/other_user}","gists_url":"https://api.github.com/users/cjerdonek/gists{/gist_id}","starred_url":"https://api.github.com/users/cjerdonek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjerdonek/subscriptions","organizations_url":"https://api.github.com/users/cjerdonek/orgs","repos_url":"https://api.github.com/users/cjerdonek/repos","events_url":"https://api.github.com/users/cjerdonek/events{/privacy}","received_events_url":"https://api.github.com/users/cjerdonek/received_events","type":"User","site_admin":false},"repo":{"id":15000001,"name":"django","full_name":"cjerdonek/django","owner":{"login":"cjerdonek","id":355822,"avatar_url":"https://avatars.githubusercontent.com/u/355822?v=3","gravatar_id":"","url":"https://api.github.com/users/cjerdonek","html_url":"https://github.com/cjerdonek","followers_url":"https://api.github.com/users/cjerdonek/followers","following_url":"https://api.github.com/users/cjerdonek/following{/other_user}","gists_url":"https://api.github.com/users/cjerdonek/gists{/gist_id}","starred_url":"https://api.github.com/users/cjerdonek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjerdonek/subscriptions","organizations_url":"https://api.github.com/users/cjerdonek/orgs","repos_url":"https://api.github.com/users/cjerdonek/repos","events_url":"https://api.github.com/users/cjerdonek/events{/privacy}","received_events_url":"https://api.github.com/users/cjerdonek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjerdonek/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/cjerdonek/django","forks_url":"https://api.github.com/repos/cjerdonek/django/forks","keys_url":"https://api.github.com/repos/cjerdonek/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjerdonek/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjerdonek/django/teams","hooks_url":"https://api.github.com/repos/cjerdonek/django/hooks","issue_events_url":"https://api.github.com/repos/cjerdonek/django/issues/events{/number}","events_url":"https://api.github.com/repos/cjerdonek/django/events","assignees_url":"https://api.github.com/repos/cjerdonek/django/assignees{/user}","branches_url":"https://api.github.com/repos/cjerdonek/django/branches{/branch}","tags_url":"https://api.github.com/repos/cjerdonek/django/tags","blobs_url":"https://api.github.com/repos/cjerdonek/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjerdonek/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjerdonek/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjerdonek/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjerdonek/django/statuses/{sha}","languages_url":"https://api.github.com/repos/cjerdonek/django/languages","stargazers_url":"https://api.github.com/repos/cjerdonek/django/stargazers","contributors_url":"https://api.github.com/repos/cjerdonek/django/contributors","subscribers_url":"https://api.github.com/repos/cjerdonek/django/subscribers","subscription_url":"https://api.github.com/repos/cjerdonek/django/subscription","commits_url":"https://api.github.com/repos/cjerdonek/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjerdonek/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjerdonek/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjerdonek/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjerdonek/django/contents/{+path}","compare_url":"https://api.github.com/repos/cjerdonek/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjerdonek/django/merges","archive_url":"https://api.github.com/repos/cjerdonek/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjerdonek/django/downloads","issues_url":"https://api.github.com/repos/cjerdonek/django/issues{/number}","pulls_url":"https://api.github.com/repos/cjerdonek/django/pulls{/number}","milestones_url":"https://api.github.com/repos/cjerdonek/django/milestones{/number}","notifications_url":"https://api.github.com/repos/cjerdonek/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjerdonek/django/labels{/name}","releases_url":"https://api.github.com/repos/cjerdonek/django/releases{/id}","deployments_url":"https://api.github.com/repos/cjerdonek/django/deployments","created_at":"2013-12-07T04:42:59Z","updated_at":"2015-03-10T00:45:00Z","pushed_at":"2016-08-16T00:16:42Z","git_url":"git://github.com/cjerdonek/django.git","ssh_url":"git@github.com:cjerdonek/django.git","clone_url":"https://github.com/cjerdonek/django.git","svn_url":"https://github.com/cjerdonek/django","homepage":"http://www.djangoproject.com/","size":131894,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"698be78d7438aade49d3cac5ea1f9de219d33e42","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-08-16T15:34:26Z","pushed_at":"2016-08-16T15:32:12Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":196306,"stargazers_count":20770,"watchers_count":20770,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8389,"mirror_url":null,"open_issues_count":102,"forks":8389,"open_issues":102,"watchers":20770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/7096"},"html":{"href":"https://github.com/django/django/pull/7096"},"issue":{"href":"https://api.github.com/repos/django/django/issues/7096"},"comments":{"href":"https://api.github.com/repos/django/django/issues/7096/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/7096/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/7096/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/62329037a425f27d37408dc6a10a1210d0180e40"}}}}
{"actor":{"display_login":"charettes"}}