{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-output/issues/84","repository_url":"https://api.github.com/repos/OPM/opm-output","labels_url":"https://api.github.com/repos/OPM/opm-output/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-output/issues/84/comments","events_url":"https://api.github.com/repos/OPM/opm-output/issues/84/events","html_url":"https://github.com/OPM/opm-output/pull/84","id":174512956,"number":84,"title":"Output writer cell data","user":{"login":"babrodtk","id":3326841,"avatar_url":"https://avatars.githubusercontent.com/u/3326841?v=3","gravatar_id":"","url":"https://api.github.com/users/babrodtk","html_url":"https://github.com/babrodtk","followers_url":"https://api.github.com/users/babrodtk/followers","following_url":"https://api.github.com/users/babrodtk/following{/other_user}","gists_url":"https://api.github.com/users/babrodtk/gists{/gist_id}","starred_url":"https://api.github.com/users/babrodtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babrodtk/subscriptions","organizations_url":"https://api.github.com/users/babrodtk/orgs","repos_url":"https://api.github.com/users/babrodtk/repos","events_url":"https://api.github.com/users/babrodtk/events{/privacy}","received_events_url":"https://api.github.com/users/babrodtk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-01T12:41:36Z","updated_at":"2016-09-07T10:20:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-output/pulls/84","html_url":"https://github.com/OPM/opm-output/pull/84","diff_url":"https://github.com/OPM/opm-output/pull/84.diff","patch_url":"https://github.com/OPM/opm-output/pull/84.patch"},"body":"Enables outputting cell data to UNRST files.\r\n\r\nSee also sibling pull requests in OPM/opm-simulators#805 and OPM/opm-core#1060"},"comment":{"url":"https://api.github.com/repos/OPM/opm-output/issues/comments/245238054","html_url":"https://github.com/OPM/opm-output/pull/84#issuecomment-245238054","issue_url":"https://api.github.com/repos/OPM/opm-output/issues/84","id":245238054,"user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T10:20:11Z","updated_at":"2016-09-07T10:20:11Z","body":"I must admit I have a slightly iffy feeling for adding a constructor to the `struct` - I prefer one of:\r\n\r\n1. Full blown C++ class with data encapsulation and methods and so on.\r\n2. Fully public C style struct which  only aggregates some related data.\r\n\r\nSo if you could just do `simProps.emplace_back(CellData{ \"Key\", unit , data });` in opm-simulators I would prefer that. If you consider that is a bad solution I will certainly merge the constructor, but then please also add a default constructor so that \r\n```\r\nCellData cd;\r\n```\r\nstill compiles."}}
{"actor":{"display_login":"joakim-hove"}}