{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments/75145730","id":75145730,"diff_hunk":"@@ -464,6 +471,9 @@ d0 d1   d2 d3           d0 d1   d2 d3  d4 d5</artwork>\n         <t>\n           Note that the ASN.1 length and the opaque vector length are identical in size (1 byte) and value, so the DER encoding of the OID can be reproduced simply by prepending an OBJECT IDENTIFIER tag (0x06) to the opaque vector length and contents.\n         </t>\n+        <t>\n+          OIDs used to identify logs are limited such that their DER encoding is less than 127 octets.","path":"rfc6962-bis.xml","position":58,"original_position":58,"commit_id":"475923f604670fbd49994f7980230f11a4924a19","original_commit_id":"475923f604670fbd49994f7980230f11a4924a19","user":{"login":"robstradling","id":958624,"avatar_url":"https://avatars.githubusercontent.com/u/958624?v=3","gravatar_id":"","url":"https://api.github.com/users/robstradling","html_url":"https://github.com/robstradling","followers_url":"https://api.github.com/users/robstradling/followers","following_url":"https://api.github.com/users/robstradling/following{/other_user}","gists_url":"https://api.github.com/users/robstradling/gists{/gist_id}","starred_url":"https://api.github.com/users/robstradling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstradling/subscriptions","organizations_url":"https://api.github.com/users/robstradling/orgs","repos_url":"https://api.github.com/users/robstradling/repos","events_url":"https://api.github.com/users/robstradling/events{/privacy}","received_events_url":"https://api.github.com/users/robstradling/received_events","type":"User","site_admin":false},"body":"\"less than 127\" isn't quite correct.\r\n\r\n\"less than 130\" would be correct: 1 byte for the OBJECT IDENTIFIER tag, 1 byte for the length (with value 0x7F), and a 127-byte long value.\r\n\r\nPerhaps change it to \"...such that the DER encodings of their values are each <= 127 octets\" ?\r\nOr else express it in the singular (i.e. \"An OID used to identify a log is limited such that the DER encoding of its value is <= 127 octets\")?","created_at":"2016-08-17T15:28:22Z","updated_at":"2016-08-17T15:28:22Z","html_url":"https://github.com/google/certificate-transparency-rfcs/pull/190#discussion_r75145730","pull_request_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments/75145730"},"html":{"href":"https://github.com/google/certificate-transparency-rfcs/pull/190#discussion_r75145730"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190","id":81655238,"html_url":"https://github.com/google/certificate-transparency-rfcs/pull/190","diff_url":"https://github.com/google/certificate-transparency-rfcs/pull/190.diff","patch_url":"https://github.com/google/certificate-transparency-rfcs/pull/190.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/190","number":190,"state":"open","locked":false,"title":"Address Feedback from David Drysdale","user":{"login":"eranmes","id":1072163,"avatar_url":"https://avatars.githubusercontent.com/u/1072163?v=3","gravatar_id":"","url":"https://api.github.com/users/eranmes","html_url":"https://github.com/eranmes","followers_url":"https://api.github.com/users/eranmes/followers","following_url":"https://api.github.com/users/eranmes/following{/other_user}","gists_url":"https://api.github.com/users/eranmes/gists{/gist_id}","starred_url":"https://api.github.com/users/eranmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eranmes/subscriptions","organizations_url":"https://api.github.com/users/eranmes/orgs","repos_url":"https://api.github.com/users/eranmes/repos","events_url":"https://api.github.com/users/eranmes/events{/privacy}","received_events_url":"https://api.github.com/users/eranmes/received_events","type":"User","site_admin":false},"body":"David Drysdale has provided detailed feedback on the -bis document.\r\nThis PR addresses most of the feedback.","created_at":"2016-08-17T14:40:54Z","updated_at":"2016-08-17T15:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e99c47f4d986c3348b95059fab586774dc3a096","assignee":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"assignees":[{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},{"login":"robstradling","id":958624,"avatar_url":"https://avatars.githubusercontent.com/u/958624?v=3","gravatar_id":"","url":"https://api.github.com/users/robstradling","html_url":"https://github.com/robstradling","followers_url":"https://api.github.com/users/robstradling/followers","following_url":"https://api.github.com/users/robstradling/following{/other_user}","gists_url":"https://api.github.com/users/robstradling/gists{/gist_id}","starred_url":"https://api.github.com/users/robstradling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstradling/subscriptions","organizations_url":"https://api.github.com/users/robstradling/orgs","repos_url":"https://api.github.com/users/robstradling/repos","events_url":"https://api.github.com/users/robstradling/events{/privacy}","received_events_url":"https://api.github.com/users/robstradling/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/190/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/475923f604670fbd49994f7980230f11a4924a19","head":{"label":"eranmes:drysdale_comments","ref":"drysdale_comments","sha":"475923f604670fbd49994f7980230f11a4924a19","user":{"login":"eranmes","id":1072163,"avatar_url":"https://avatars.githubusercontent.com/u/1072163?v=3","gravatar_id":"","url":"https://api.github.com/users/eranmes","html_url":"https://github.com/eranmes","followers_url":"https://api.github.com/users/eranmes/followers","following_url":"https://api.github.com/users/eranmes/following{/other_user}","gists_url":"https://api.github.com/users/eranmes/gists{/gist_id}","starred_url":"https://api.github.com/users/eranmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eranmes/subscriptions","organizations_url":"https://api.github.com/users/eranmes/orgs","repos_url":"https://api.github.com/users/eranmes/repos","events_url":"https://api.github.com/users/eranmes/events{/privacy}","received_events_url":"https://api.github.com/users/eranmes/received_events","type":"User","site_admin":false},"repo":{"id":21980702,"name":"certificate-transparency-rfcs","full_name":"eranmes/certificate-transparency-rfcs","owner":{"login":"eranmes","id":1072163,"avatar_url":"https://avatars.githubusercontent.com/u/1072163?v=3","gravatar_id":"","url":"https://api.github.com/users/eranmes","html_url":"https://github.com/eranmes","followers_url":"https://api.github.com/users/eranmes/followers","following_url":"https://api.github.com/users/eranmes/following{/other_user}","gists_url":"https://api.github.com/users/eranmes/gists{/gist_id}","starred_url":"https://api.github.com/users/eranmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eranmes/subscriptions","organizations_url":"https://api.github.com/users/eranmes/orgs","repos_url":"https://api.github.com/users/eranmes/repos","events_url":"https://api.github.com/users/eranmes/events{/privacy}","received_events_url":"https://api.github.com/users/eranmes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eranmes/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":true,"url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/eranmes/certificate-transparency-rfcs/deployments","created_at":"2014-07-18T13:12:17Z","updated_at":"2016-01-28T10:47:56Z","pushed_at":"2016-08-17T14:40:13Z","git_url":"git://github.com/eranmes/certificate-transparency-rfcs.git","ssh_url":"git@github.com:eranmes/certificate-transparency-rfcs.git","clone_url":"https://github.com/eranmes/certificate-transparency-rfcs.git","svn_url":"https://github.com/eranmes/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1791,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"3cf2e309f69a6995bcdc7c42caf4b3818b317f67","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20069953,"name":"certificate-transparency-rfcs","full_name":"google/certificate-transparency-rfcs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/deployments","created_at":"2014-05-22T17:15:59Z","updated_at":"2016-08-10T15:49:13Z","pushed_at":"2016-08-17T14:40:54Z","git_url":"git://github.com/google/certificate-transparency-rfcs.git","ssh_url":"git@github.com:google/certificate-transparency-rfcs.git","clone_url":"https://github.com/google/certificate-transparency-rfcs.git","svn_url":"https://github.com/google/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1921,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190"},"html":{"href":"https://github.com/google/certificate-transparency-rfcs/pull/190"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/190"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/475923f604670fbd49994f7980230f11a4924a19"}}}}
{"actor":{"display_login":"robstradling"}}