{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16828","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16828/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16828/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16828/events","html_url":"https://github.com/mantidproject/mantid/pull/16828","id":164642418,"number":16828,"title":"Find and remove redundant code","user":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Easy","name":"Misc: Easy","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20Clang-Tidy","name":"Quality: Clang-Tidy","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"assignees":[{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":648,"closed_issues":309,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-07-12T21:50:11Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-07-09T01:17:41Z","updated_at":"2016-07-13T06:44:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16828","html_url":"https://github.com/mantidproject/mantid/pull/16828","diff_url":"https://github.com/mantidproject/mantid/pull/16828.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16828.patch"},"body":"Description of work.\r\n\r\nThis uses the clang-tidy checks `readability-redundant-*` to find and remote redundant code. Most are unnecessary return statements in void functions and std::string constructed from an empty string literal. Removing unnecessary calls to `std::string::c_str()` and `boost::shared_ptr::get()` are more interesting.\r\n\r\n\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nThis is no GitHub issue associated with this PR\r\n\r\n*Does not need to be in the release notes.*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/232270240","html_url":"https://github.com/mantidproject/mantid/pull/16828#issuecomment-232270240","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16828","id":232270240,"user":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T06:44:11Z","updated_at":"2016-07-13T06:44:11Z","body":"Changes look good. As said in the description, most of them have to do with return statements in void functions and strings constructed from `\"\"`. A few places where `.c_str()` was not necessary and one occurrence of an unnecessary `boost::shared_ptr::get()`.\r\n\r\n:shipit: "}}
{"actor":{"display_login":"raquelalvarezbanos"}}