{"action":"opened","number":7238,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7238","id":56103224,"html_url":"https://github.com/ceph/ceph/pull/7238","diff_url":"https://github.com/ceph/ceph/pull/7238.diff","patch_url":"https://github.com/ceph/ceph/pull/7238.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7238","number":7238,"state":"open","locked":false,"title":"configure.ac: check for libedit when client is enabled","user":{"login":"awelzel","id":2100509,"avatar_url":"https://avatars.githubusercontent.com/u/2100509?v=3","gravatar_id":"","url":"https://api.github.com/users/awelzel","html_url":"https://github.com/awelzel","followers_url":"https://api.github.com/users/awelzel/followers","following_url":"https://api.github.com/users/awelzel/following{/other_user}","gists_url":"https://api.github.com/users/awelzel/gists{/gist_id}","starred_url":"https://api.github.com/users/awelzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelzel/subscriptions","organizations_url":"https://api.github.com/users/awelzel/orgs","repos_url":"https://api.github.com/users/awelzel/repos","events_url":"https://api.github.com/users/awelzel/events{/privacy}","received_events_url":"https://api.github.com/users/awelzel/received_events","type":"User","site_admin":false},"body":"In src/client/Makefile.am, libclient.la depends on -ledit. However, configure\r\nonly checks for libedit when radosgw is enabled. Linking can fail during\r\nthe build when libedit is missing:\r\n\r\n    CXXLD    libcephfs.la\r\n    /usr/lib64/gcc/x86_64-slackware-linux/5.3.0/../../../../x86_64-slackware-linux/bin/ld:\r\n    cannot find -ledit\r\n    collect2: error: ld returned 1 exit status\r\n    Makefile:10567: recipe for target 'libcephfs.la' failed\r\n\r\nSimply check for libedit whenever --enable-client is there.","created_at":"2016-01-14T22:25:31Z","updated_at":"2016-01-14T22:25:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/7238/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/7238/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7238/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/d60b7c4e072a55959523345614d826726e1ab2fd","head":{"label":"awelzel:configure_libedit","ref":"configure_libedit","sha":"d60b7c4e072a55959523345614d826726e1ab2fd","user":{"login":"awelzel","id":2100509,"avatar_url":"https://avatars.githubusercontent.com/u/2100509?v=3","gravatar_id":"","url":"https://api.github.com/users/awelzel","html_url":"https://github.com/awelzel","followers_url":"https://api.github.com/users/awelzel/followers","following_url":"https://api.github.com/users/awelzel/following{/other_user}","gists_url":"https://api.github.com/users/awelzel/gists{/gist_id}","starred_url":"https://api.github.com/users/awelzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelzel/subscriptions","organizations_url":"https://api.github.com/users/awelzel/orgs","repos_url":"https://api.github.com/users/awelzel/repos","events_url":"https://api.github.com/users/awelzel/events{/privacy}","received_events_url":"https://api.github.com/users/awelzel/received_events","type":"User","site_admin":false},"repo":{"id":49677659,"name":"ceph","full_name":"awelzel/ceph","owner":{"login":"awelzel","id":2100509,"avatar_url":"https://avatars.githubusercontent.com/u/2100509?v=3","gravatar_id":"","url":"https://api.github.com/users/awelzel","html_url":"https://github.com/awelzel","followers_url":"https://api.github.com/users/awelzel/followers","following_url":"https://api.github.com/users/awelzel/following{/other_user}","gists_url":"https://api.github.com/users/awelzel/gists{/gist_id}","starred_url":"https://api.github.com/users/awelzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelzel/subscriptions","organizations_url":"https://api.github.com/users/awelzel/orgs","repos_url":"https://api.github.com/users/awelzel/repos","events_url":"https://api.github.com/users/awelzel/events{/privacy}","received_events_url":"https://api.github.com/users/awelzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awelzel/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/awelzel/ceph","forks_url":"https://api.github.com/repos/awelzel/ceph/forks","keys_url":"https://api.github.com/repos/awelzel/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awelzel/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awelzel/ceph/teams","hooks_url":"https://api.github.com/repos/awelzel/ceph/hooks","issue_events_url":"https://api.github.com/repos/awelzel/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/awelzel/ceph/events","assignees_url":"https://api.github.com/repos/awelzel/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/awelzel/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/awelzel/ceph/tags","blobs_url":"https://api.github.com/repos/awelzel/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awelzel/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awelzel/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/awelzel/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awelzel/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/awelzel/ceph/languages","stargazers_url":"https://api.github.com/repos/awelzel/ceph/stargazers","contributors_url":"https://api.github.com/repos/awelzel/ceph/contributors","subscribers_url":"https://api.github.com/repos/awelzel/ceph/subscribers","subscription_url":"https://api.github.com/repos/awelzel/ceph/subscription","commits_url":"https://api.github.com/repos/awelzel/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/awelzel/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/awelzel/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/awelzel/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/awelzel/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/awelzel/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awelzel/ceph/merges","archive_url":"https://api.github.com/repos/awelzel/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awelzel/ceph/downloads","issues_url":"https://api.github.com/repos/awelzel/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/awelzel/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/awelzel/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/awelzel/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awelzel/ceph/labels{/name}","releases_url":"https://api.github.com/repos/awelzel/ceph/releases{/id}","created_at":"2016-01-14T21:52:23Z","updated_at":"2016-01-14T21:52:40Z","pushed_at":"2016-01-14T22:24:53Z","git_url":"git://github.com/awelzel/ceph.git","ssh_url":"git@github.com:awelzel/ceph.git","clone_url":"https://github.com/awelzel/ceph.git","svn_url":"https://github.com/awelzel/ceph","homepage":"http://ceph.com","size":151940,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"a290d34ebdfa571f62e69839ae0c3a9d11f075d1","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-01-14T15:00:53Z","pushed_at":"2016-01-14T21:54:11Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":177151,"stargazers_count":1809,"watchers_count":1809,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1086,"mirror_url":null,"open_issues_count":268,"forks":1086,"open_issues":268,"watchers":1809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7238"},"html":{"href":"https://github.com/ceph/ceph/pull/7238"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/7238"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/7238/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7238/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7238/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/d60b7c4e072a55959523345614d826726e1ab2fd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}