{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/51398425","id":51398425,"diff_hunk":"@@ -2,27 +2,53 @@\n \n class Netcdf(Package):\n     \"\"\"NetCDF is a set of software libraries and self-describing, machine-independent\n-        data formats that support the creation, access, and sharing of array-oriented\n-        scientific data.\"\"\"\n+    data formats that support the creation, access, and sharing of array-oriented\n+    scientific data.\"\"\"\n \n     homepage = \"http://www.unidata.ucar.edu/software/netcdf/\"\n     url      = \"ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-4.3.3.tar.gz\"\n \n+    version('4.4.0', 'f01cb26a0126dd9a6224e76472d25f6c')\n     version('4.3.3', '5fbd0e108a54bd82cb5702a73f56d2ae')\n \n+    variant('fortran', default=False, description=\"Download and install NetCDF-Fortran\")\n+    variant('hdf4', default=False, description=\"Enable HDF4 support\")\n+\n     patch('netcdf-4.3.3-mpi.patch')\n \n     # Dependencies:\n-    depends_on(\"cmake @2.8.12:\")\n-        # >HDF5\n-    depends_on(\"hdf5\")\n+    depends_on(\"curl\")  # required for DAP support\n+    depends_on(\"hdf\", when='+hdf4')\n+    depends_on(\"hdf5\")  # required for NetCDF-4 support\n+    depends_on(\"zlib\")  # required for NetCDF-4 support\n \n     def install(self, spec, prefix):\n-        with working_dir('spack-build', create=True):\n-            cmake('..',\n-                \"-DCMAKE_INSTALL_PREFIX:PATH=%s\" % prefix,\n-                \"-DENABLE_DAP:BOOL=OFF\", # Disable DAP.\n-                \"-DBUILD_SHARED_LIBS:BOOL=OFF\") # Don't build shared libraries (use static libs).\n-\n-            make()\n-            make(\"install\")\n+        config_args = [\n+            \"--enable-fsync\",\n+            \"--enable-v2\",\n+            \"--enable-utilities\",\n+            \"--enable-shared\",\n+            \"--enable-static\",\n+            \"--enable-largefile\",\n+            # necessary for HDF5 support\n+            \"--enable-netcdf-4\",\n+            \"--enable-dynamic-loading\",\n+            # necessary for DAP support\n+            \"--enable-dap\"\n+        ]\n+\n+        # HDF4 support\n+        if '+hdf4' in spec:\n+            config_args.append(\"--enable-hdf4\")\n+\n+        # Fortran support\n+        # In version 4.2+, NetCDF-C and NetCDF-Fortran have split.\n+        # They can be installed separately, but this bootstrap procedure\n+        # should be able to install both at the same time.\n+        # Note: this is a new experimental feature\n+        if '+fortran' in spec:\n+            config_args.append(\"--enable-remote-fortran-bootstrap\")","path":"var/spack/repos/builtin/packages/netcdf/package.py","position":62,"original_position":62,"commit_id":"c6bb00085f89b6db37a03674ba09714adab1f2f0","original_commit_id":"c6bb00085f89b6db37a03674ba09714adab1f2f0","user":{"login":"alalazo","id":4199709,"avatar_url":"https://avatars.githubusercontent.com/u/4199709?v=3","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"body":"Thanks for the clarification.","created_at":"2016-02-01T10:00:37Z","updated_at":"2016-02-01T10:00:37Z","html_url":"https://github.com/LLNL/spack/pull/400#discussion_r51398425","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/51398425"},"html":{"href":"https://github.com/LLNL/spack/pull/400#discussion_r51398425"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/400","id":57248832,"html_url":"https://github.com/LLNL/spack/pull/400","diff_url":"https://github.com/LLNL/spack/pull/400.diff","patch_url":"https://github.com/LLNL/spack/pull/400.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/400","number":400,"state":"closed","locked":false,"title":"Extensive modifications to NetCDF package","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"This pull request is currently blocked by #339. Until the new HDF package is added, I won't be able to test my changes. Please let me know if there is anything preventing #339 from being merged and I will fix it.\r\n\r\nI'm not sure how well the new experimental feature for building NetCDF-Fortran works. If it doesn't work, I'll just have to add a separate NetCDF-Fortran package.","created_at":"2016-01-26T18:10:55Z","updated_at":"2016-02-01T10:00:37Z","closed_at":"2016-01-27T02:31:14Z","merged_at":"2016-01-27T02:31:14Z","merge_commit_sha":"556eaa0453921758260e6bfc0f248bf067909c2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/400/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/400/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/400/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/c6bb00085f89b6db37a03674ba09714adab1f2f0","head":{"label":"adamjstewart:features/netcdf","ref":"features/netcdf","sha":"c6bb00085f89b6db37a03674ba09714adab1f2f0","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"repo":{"id":49444175,"name":"spack","full_name":"adamjstewart/spack","owner":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamjstewart/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/adamjstewart/spack","forks_url":"https://api.github.com/repos/adamjstewart/spack/forks","keys_url":"https://api.github.com/repos/adamjstewart/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamjstewart/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamjstewart/spack/teams","hooks_url":"https://api.github.com/repos/adamjstewart/spack/hooks","issue_events_url":"https://api.github.com/repos/adamjstewart/spack/issues/events{/number}","events_url":"https://api.github.com/repos/adamjstewart/spack/events","assignees_url":"https://api.github.com/repos/adamjstewart/spack/assignees{/user}","branches_url":"https://api.github.com/repos/adamjstewart/spack/branches{/branch}","tags_url":"https://api.github.com/repos/adamjstewart/spack/tags","blobs_url":"https://api.github.com/repos/adamjstewart/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamjstewart/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamjstewart/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamjstewart/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamjstewart/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/adamjstewart/spack/languages","stargazers_url":"https://api.github.com/repos/adamjstewart/spack/stargazers","contributors_url":"https://api.github.com/repos/adamjstewart/spack/contributors","subscribers_url":"https://api.github.com/repos/adamjstewart/spack/subscribers","subscription_url":"https://api.github.com/repos/adamjstewart/spack/subscription","commits_url":"https://api.github.com/repos/adamjstewart/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamjstewart/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamjstewart/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamjstewart/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamjstewart/spack/contents/{+path}","compare_url":"https://api.github.com/repos/adamjstewart/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamjstewart/spack/merges","archive_url":"https://api.github.com/repos/adamjstewart/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamjstewart/spack/downloads","issues_url":"https://api.github.com/repos/adamjstewart/spack/issues{/number}","pulls_url":"https://api.github.com/repos/adamjstewart/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/adamjstewart/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/adamjstewart/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamjstewart/spack/labels{/name}","releases_url":"https://api.github.com/repos/adamjstewart/spack/releases{/id}","deployments_url":"https://api.github.com/repos/adamjstewart/spack/deployments","created_at":"2016-01-11T18:04:18Z","updated_at":"2016-01-11T18:04:19Z","pushed_at":"2016-01-29T15:48:18Z","git_url":"git://github.com/adamjstewart/spack.git","ssh_url":"git@github.com:adamjstewart/spack.git","clone_url":"https://github.com/adamjstewart/spack.git","svn_url":"https://github.com/adamjstewart/spack","homepage":"http://llnl.github.io/spack","size":4214,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"1a5270023803303f07db507fa36139fb52111b9d","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-01-29T05:05:47Z","pushed_at":"2016-02-01T09:57:00Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://llnl.github.io/spack","size":5786,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":88,"forks":68,"open_issues":88,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/400"},"html":{"href":"https://github.com/LLNL/spack/pull/400"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/400"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/c6bb00085f89b6db37a03674ba09714adab1f2f0"}}}}