{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/comments/80881491","pull_request_review_id":1902380,"id":80881491,"diff_hunk":"@@ -40,21 +40,16 @@ node ('docker') {\n         // Build an image from the the local Dockerfile\n         def athImg = docker.build('blueocean-ath-builder')\n \n-        // Expose the port on which the ATH Jenkins instance runs (12345), allowing the\n-        // Firefox browser (running in the selenium container) to make requests back\n-        // in etc.\n-        //\n         // To bind in the local ~/.m2 when running in dev mode, simply add the following\n         // volume binding to the \"inside\" container run settings (change username from \"tfennelly\"):\n         //       -v /home/tfennelly/.m2:/home/bouser/.m2\n         //\n-        athImg.inside(\"--expose=12345 -p 12345:12345\") {\n+        athImg.inside {\n             withEnv([\"BLUEO_SELENIUM_SERVER_ADDR=${seleniumIP}\"]) {","path":"Jenkinsfile","position":null,"original_position":37,"commit_id":"4888fa36555a49fd9a2a532a0b14eed3e7f2c1df","original_commit_id":"dfaa85fd85eb44733c38698161eb7818b57fb820","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?v=3","gravatar_id":"","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"body":"@ydubreuil gotcha ... sorry for my confusion ... I actually twigged what you really meant after doing it. Certainly not the same things and certainly the way I'd prefer to do it. Thank you !!!","created_at":"2016-09-28T09:59:19Z","updated_at":"2016-09-28T09:59:19Z","html_url":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48#discussion_r80881491","pull_request_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/comments/80881491"},"html":{"href":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48#discussion_r80881491"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48","id":87071812,"html_url":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48","diff_url":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48.diff","patch_url":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48.patch","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/48","number":48,"state":"closed","locked":false,"title":"A few jenkinsfile tweaks","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?v=3","gravatar_id":"","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nSee [JENKINS-37918](https://issues.jenkins-ci.org/browse/JENKINS-37918).\r\n\r\nMisc tweaks trying to fix issues identified on the master branch.\r\n\r\nhttps://ci.blueocean.io/job/ATH-Jenkinsfile/job/Jenkinsfile-tweaks/\r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [x] Ran Acceptance Test Harness against PR changes.\r\n\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [ ] Reviewed the code\r\n- [ ] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@jenkinsci/code-reviewers @reviewbybees \r\n\r\n- deleteDir at the start of the build\r\n- remove sh to delete the blueocean-plugin dir as it was failing for some reason\r\n- Better message for when build aborted due to uninitialised build params\r\n- Support for etting plugins from the \"latest\" build on a branch","created_at":"2016-09-28T08:04:34Z","updated_at":"2016-09-28T09:59:19Z","closed_at":"2016-09-28T09:55:35Z","merged_at":"2016-09-28T09:55:35Z","merge_commit_sha":"3ccf85d5d04c80183af272d0fecc3b444eeb885d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/48/comments","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/statuses/4888fa36555a49fd9a2a532a0b14eed3e7f2c1df","head":{"label":"jenkinsci:Jenkinsfile-tweaks","ref":"Jenkinsfile-tweaks","sha":"4888fa36555a49fd9a2a532a0b14eed3e7f2c1df","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":61347089,"name":"blueocean-acceptance-test","full_name":"jenkinsci/blueocean-acceptance-test","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/blueocean-acceptance-test","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test","forks_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/forks","keys_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/teams","hooks_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/events","assignees_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/tags","blobs_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/subscription","commits_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/merges","archive_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/downloads","issues_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/deployments","created_at":"2016-06-17T05:10:25Z","updated_at":"2016-09-05T20:22:39Z","pushed_at":"2016-09-28T09:55:37Z","git_url":"git://github.com/jenkinsci/blueocean-acceptance-test.git","ssh_url":"git@github.com:jenkinsci/blueocean-acceptance-test.git","clone_url":"https://github.com/jenkinsci/blueocean-acceptance-test.git","svn_url":"https://github.com/jenkinsci/blueocean-acceptance-test","homepage":null,"size":979,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"1684b0b85c55045675fc733771ae44824258e05e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":61347089,"name":"blueocean-acceptance-test","full_name":"jenkinsci/blueocean-acceptance-test","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/blueocean-acceptance-test","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test","forks_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/forks","keys_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/teams","hooks_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/events","assignees_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/tags","blobs_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/subscription","commits_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/merges","archive_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/downloads","issues_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/deployments","created_at":"2016-06-17T05:10:25Z","updated_at":"2016-09-05T20:22:39Z","pushed_at":"2016-09-28T09:55:37Z","git_url":"git://github.com/jenkinsci/blueocean-acceptance-test.git","ssh_url":"git@github.com:jenkinsci/blueocean-acceptance-test.git","clone_url":"https://github.com/jenkinsci/blueocean-acceptance-test.git","svn_url":"https://github.com/jenkinsci/blueocean-acceptance-test","homepage":null,"size":979,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48"},"html":{"href":"https://github.com/jenkinsci/blueocean-acceptance-test/pull/48"},"issue":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/48"},"comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/blueocean-acceptance-test/statuses/4888fa36555a49fd9a2a532a0b14eed3e7f2c1df"}}}}
{"actor":{"display_login":"tfennelly"}}