{"action":"created","issue":{"url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/7","repository_url":"https://api.github.com/repos/milkcan/ionic-numberpicker","labels_url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/7/comments","events_url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/7/events","html_url":"https://github.com/milkcan/ionic-numberpicker/pull/7","id":156128809,"number":7,"title":"Feature: enabling continuous button press","user":{"login":"shaolin405mi16","id":3272935,"avatar_url":"https://avatars.githubusercontent.com/u/3272935?v=3","gravatar_id":"","url":"https://api.github.com/users/shaolin405mi16","html_url":"https://github.com/shaolin405mi16","followers_url":"https://api.github.com/users/shaolin405mi16/followers","following_url":"https://api.github.com/users/shaolin405mi16/following{/other_user}","gists_url":"https://api.github.com/users/shaolin405mi16/gists{/gist_id}","starred_url":"https://api.github.com/users/shaolin405mi16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaolin405mi16/subscriptions","organizations_url":"https://api.github.com/users/shaolin405mi16/orgs","repos_url":"https://api.github.com/users/shaolin405mi16/repos","events_url":"https://api.github.com/users/shaolin405mi16/events{/privacy}","received_events_url":"https://api.github.com/users/shaolin405mi16/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-22T00:49:27Z","updated_at":"2016-06-01T05:46:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/milkcan/ionic-numberpicker/pulls/7","html_url":"https://github.com/milkcan/ionic-numberpicker/pull/7","diff_url":"https://github.com/milkcan/ionic-numberpicker/pull/7.diff","patch_url":"https://github.com/milkcan/ionic-numberpicker/pull/7.patch"},"body":"Hi, this patch includes one bugfix (when returning negative value), and also a huge feature addition.\r\n\r\nThis enables \"**autorepeat**\" feature: numbers continuously up/down while pressing increment/decrement buttons. So you don't have to click/tap up/down buttons number of times anymore, in order to increase/decrease numbers plenty. To accomplish this, I changed the way negative sign and current value(s) are displayed (from `ng-bind` to direct DOM manipulation).\r\n\r\nAlso, since touchscreen devices (such as smartphones and tablets) cannot handle `mousedown` and `mouseup` events, I added `ng-touchstart` and `ng-touchend` directives. If you add **ngTouch** ( [https://github.com/nglar/ngTouch](https://github.com/nglar/ngTouch) ) module, autorepeat feature will be enabled on touchscreen devices as well. Without ngTouch module, these directives are simply ignored.\r\n\r\nHope you'll like this."},"comment":{"url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/comments/222898615","html_url":"https://github.com/milkcan/ionic-numberpicker/pull/7#issuecomment-222898615","issue_url":"https://api.github.com/repos/milkcan/ionic-numberpicker/issues/7","id":222898615,"user":{"login":"shaolin405mi16","id":3272935,"avatar_url":"https://avatars.githubusercontent.com/u/3272935?v=3","gravatar_id":"","url":"https://api.github.com/users/shaolin405mi16","html_url":"https://github.com/shaolin405mi16","followers_url":"https://api.github.com/users/shaolin405mi16/followers","following_url":"https://api.github.com/users/shaolin405mi16/following{/other_user}","gists_url":"https://api.github.com/users/shaolin405mi16/gists{/gist_id}","starred_url":"https://api.github.com/users/shaolin405mi16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaolin405mi16/subscriptions","organizations_url":"https://api.github.com/users/shaolin405mi16/orgs","repos_url":"https://api.github.com/users/shaolin405mi16/repos","events_url":"https://api.github.com/users/shaolin405mi16/events{/privacy}","received_events_url":"https://api.github.com/users/shaolin405mi16/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T05:46:24Z","updated_at":"2016-06-01T05:46:24Z","body":"further commits to make usable both on PC browsers and touchscreen devices. Introduced `useNgTouch` option (defaults to false). Probably nice as: `useNgTouch: ionic.Platform.isWebView() ? true : false`.\r\n\r\n* if `useNgTouch` is set to false, `mouseup` / `mousedown` events are detected.\r\n    * on PC browsers: auto-repeat is enabled\r\n    * on touchscreen devices: auto-repeat is disabled\r\n* if `useNgTouch` is set to true AND `ngTouch` module installed, `touchstart` / `touchend` events are detected.\r\n    * on PC browsers: don't increment/decrement at all (sigh)\r\n    * on touchscreen devices: auto-repeat is enabled\r\n\r\nAlso, introduced a 600ms delay before autorepeat for better usability."}}
{"actor":{"display_login":"shaolin405mi16"}}