{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/77458351","id":77458351,"diff_hunk":"@@ -171,23 +165,48 @@ def restart_homeassistant(*args):\n                 'Could not bind to SIGHUP. Are you running in a thread?')\n         except AttributeError:\n             pass\n+\n+        # Run forever and catch keyboard interrupt\n         try:\n-            while not request_shutdown.is_set():\n-                time.sleep(1)\n+            # Block until stopped\n+            _LOGGER.info(\"Starting Home Assistant core loop\")\n+            self.loop.run_forever()\n         except KeyboardInterrupt:\n             pass\n         finally:\n-            self.stop()\n+            self.loop.create_task(stop_homeassistant())\n+            self.loop.run_forever()\n \n-        return RESTART_EXIT_CODE if request_restart.is_set() else 0\n+    async def async_start(self):\n+        await create_async_timer(self)\n+        await self.bus.async_fire(EVENT_HOMEASSISTANT_START)\n+        await self.loop.run_in_executor(None, self.pool.block_till_done)\n+        self.state = CoreState.running\n+\n+    def add_job(self,\n+                target: Callable[..., None],\n+                *args: Any,\n+                priority: JobPriority=JobPriority.EVENT_DEFAULT) -> None:\n+        \"\"\"Add job to the worker pool.\n+\n+        target: target to call.\n+        args: parameters for method to call.\n+        \"\"\"\n+\n+        self.pool.add_job(priority, (target,) + args)\n \n     def stop(self) -> None:\n         \"\"\"Stop Home Assistant and shuts down all threads.\"\"\"\n+        future = asyncio.run_coroutine_threadsafe(self.async_stop)\n+        return future.stop()\n+\n+    async def async_stop(self) -> None:","path":"homeassistant/core.py","position":142,"original_position":142,"commit_id":"ce3db8de2baaf3142179761452e14447934886f9","original_commit_id":"ce3db8de2baaf3142179761452e14447934886f9","user":{"login":"balloobbot","id":16367972,"avatar_url":"https://avatars.githubusercontent.com/u/16367972?v=3","gravatar_id":"","url":"https://api.github.com/users/balloobbot","html_url":"https://github.com/balloobbot","followers_url":"https://api.github.com/users/balloobbot/followers","following_url":"https://api.github.com/users/balloobbot/following{/other_user}","gists_url":"https://api.github.com/users/balloobbot/gists{/gist_id}","starred_url":"https://api.github.com/users/balloobbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloobbot/subscriptions","organizations_url":"https://api.github.com/users/balloobbot/orgs","repos_url":"https://api.github.com/users/balloobbot/repos","events_url":"https://api.github.com/users/balloobbot/events{/privacy}","received_events_url":"https://api.github.com/users/balloobbot/received_events","type":"User","site_admin":false},"body":"_[farcy v1.1](https://github.com/appfolio/farcy)_\n* D102: Missing docstring in public method","created_at":"2016-09-04T20:46:23Z","updated_at":"2016-09-04T20:46:23Z","html_url":"https://github.com/home-assistant/home-assistant/pull/3190#discussion_r77458351","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/77458351"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/3190#discussion_r77458351"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190","id":83933561,"html_url":"https://github.com/home-assistant/home-assistant/pull/3190","diff_url":"https://github.com/home-assistant/home-assistant/pull/3190.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/3190.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3190","number":3190,"state":"open","locked":false,"title":"WIP: async awesomeness","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\nWIP: NOT READY FOR MERGE YET\r\n\r\nThis uses an asyncio event loop in the core, which EventBus, StateMachine, and ServiceRegistry then utilize.\r\n\r\nThe public API stays the same, and blocks as usual, while sending the actual calls into the event loop to be executed lock-free.\r\n","created_at":"2016-09-04T20:46:09Z","updated_at":"2016-09-04T20:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b244fb9498d40920daf9b195cf165c36740c602a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3190/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/ce3db8de2baaf3142179761452e14447934886f9","head":{"label":"bbangert:feat/async-core","ref":"feat/async-core","sha":"ce3db8de2baaf3142179761452e14447934886f9","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"repo":{"id":66284353,"name":"home-assistant","full_name":"bbangert/home-assistant","owner":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbangert/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/bbangert/home-assistant","forks_url":"https://api.github.com/repos/bbangert/home-assistant/forks","keys_url":"https://api.github.com/repos/bbangert/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbangert/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbangert/home-assistant/teams","hooks_url":"https://api.github.com/repos/bbangert/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/bbangert/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/bbangert/home-assistant/events","assignees_url":"https://api.github.com/repos/bbangert/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/bbangert/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/bbangert/home-assistant/tags","blobs_url":"https://api.github.com/repos/bbangert/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbangert/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbangert/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbangert/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbangert/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/bbangert/home-assistant/languages","stargazers_url":"https://api.github.com/repos/bbangert/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/bbangert/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/bbangert/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/bbangert/home-assistant/subscription","commits_url":"https://api.github.com/repos/bbangert/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbangert/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbangert/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbangert/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbangert/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/bbangert/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbangert/home-assistant/merges","archive_url":"https://api.github.com/repos/bbangert/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbangert/home-assistant/downloads","issues_url":"https://api.github.com/repos/bbangert/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/bbangert/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/bbangert/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/bbangert/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbangert/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/bbangert/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/bbangert/home-assistant/deployments","created_at":"2016-08-22T15:27:16Z","updated_at":"2016-08-22T15:27:19Z","pushed_at":"2016-09-04T20:37:33Z","git_url":"git://github.com/bbangert/home-assistant.git","ssh_url":"git@github.com:bbangert/home-assistant.git","clone_url":"https://github.com/bbangert/home-assistant.git","svn_url":"https://github.com/bbangert/home-assistant","homepage":"https://home-assistant.io","size":39027,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"ad528165953fca1fb5c1146f56b2545a44c36e10","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-09-04T11:31:28Z","pushed_at":"2016-09-04T20:46:11Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":77963,"stargazers_count":3988,"watchers_count":3988,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":956,"mirror_url":null,"open_issues_count":225,"forks":956,"open_issues":225,"watchers":3988,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/3190"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/3190"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/3190/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3190/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/ce3db8de2baaf3142179761452e14447934886f9"}}}}
{"actor":{"display_login":"balloobbot"}}