{"action":"created","comment":{"url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/comments/81619210","pull_request_review_id":2586205,"id":81619210,"diff_hunk":"@@ -76,6 +78,14 @@ class AsyncDnsResolverSpec extends AkkaSpec(\n       ))\n       answer.ipv6.toSet should be(empty)\n     }\n+    \"resolve SRV record\" in {\n+      val answer = Await.result(IO(Dns) ? Dns.Resolve(\"_http._tcp.mxtoolbox.com\"), duration).asInstanceOf[SrvResolved]","path":"src/test/scala/ru/smslv/akka/dns/AsyncDnsResolverSpec.scala","position":null,"original_position":21,"commit_id":"b06f2230f47345e06c245cf686b46117a2811655","original_commit_id":"50e917c8f781ad992563ddd17e29134193ead651","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Done. Thanks!","created_at":"2016-10-03T19:12:33Z","updated_at":"2016-10-03T19:12:33Z","html_url":"https://github.com/ilya-epifanov/akka-dns/pull/1#discussion_r81619210","pull_request_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/comments/81619210"},"html":{"href":"https://github.com/ilya-epifanov/akka-dns/pull/1#discussion_r81619210"},"pull_request":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1","id":86898971,"html_url":"https://github.com/ilya-epifanov/akka-dns/pull/1","diff_url":"https://github.com/ilya-epifanov/akka-dns/pull/1.diff","patch_url":"https://github.com/ilya-epifanov/akka-dns/pull/1.patch","issue_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/1","number":1,"state":"open","locked":false,"title":"Implement DNS-SRV","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Implements DNS-SRV capabilities. By default this is disabled in order to comply entirely with the existing implementation.\r\n\r\nWhen DNS-SRV is enabled via config, any `Resolve` request with a name starting with `_` will cause a new `SrvResolved` message to be in place of the existing `Dns.Resolved` message. Note that names beginning with `_` are a convention introduced by the [DNS SRV rfc](https://tools.ietf.org/html/rfc2782).\r\n\r\nUpon receiving an `SrvResolved` It is then up to the client to decide what more should be done, keeping this library as simple as can be. The client's responsibilities should include determining which of the `SRVRecord` elements passed back should be further resolved via its `target` property, perhaps as per \"Usage Rules\" of the [DNS SRV rfc](https://tools.ietf.org/html/rfc2782).","created_at":"2016-09-27T10:06:13Z","updated_at":"2016-10-03T19:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16c63f0259a8b24d06947fb83a060e9b2a8fb6ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/1/comments","statuses_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/statuses/b06f2230f47345e06c245cf686b46117a2811655","head":{"label":"huntc:dns-srv","ref":"dns-srv","sha":"b06f2230f47345e06c245cf686b46117a2811655","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"repo":{"id":69343711,"name":"akka-dns","full_name":"huntc/akka-dns","owner":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huntc/akka-dns","description":"Asynchronous DNS resolver for Akka","fork":true,"url":"https://api.github.com/repos/huntc/akka-dns","forks_url":"https://api.github.com/repos/huntc/akka-dns/forks","keys_url":"https://api.github.com/repos/huntc/akka-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huntc/akka-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huntc/akka-dns/teams","hooks_url":"https://api.github.com/repos/huntc/akka-dns/hooks","issue_events_url":"https://api.github.com/repos/huntc/akka-dns/issues/events{/number}","events_url":"https://api.github.com/repos/huntc/akka-dns/events","assignees_url":"https://api.github.com/repos/huntc/akka-dns/assignees{/user}","branches_url":"https://api.github.com/repos/huntc/akka-dns/branches{/branch}","tags_url":"https://api.github.com/repos/huntc/akka-dns/tags","blobs_url":"https://api.github.com/repos/huntc/akka-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huntc/akka-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huntc/akka-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/huntc/akka-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huntc/akka-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/huntc/akka-dns/languages","stargazers_url":"https://api.github.com/repos/huntc/akka-dns/stargazers","contributors_url":"https://api.github.com/repos/huntc/akka-dns/contributors","subscribers_url":"https://api.github.com/repos/huntc/akka-dns/subscribers","subscription_url":"https://api.github.com/repos/huntc/akka-dns/subscription","commits_url":"https://api.github.com/repos/huntc/akka-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/huntc/akka-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/huntc/akka-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/huntc/akka-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/huntc/akka-dns/contents/{+path}","compare_url":"https://api.github.com/repos/huntc/akka-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huntc/akka-dns/merges","archive_url":"https://api.github.com/repos/huntc/akka-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huntc/akka-dns/downloads","issues_url":"https://api.github.com/repos/huntc/akka-dns/issues{/number}","pulls_url":"https://api.github.com/repos/huntc/akka-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/huntc/akka-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/huntc/akka-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huntc/akka-dns/labels{/name}","releases_url":"https://api.github.com/repos/huntc/akka-dns/releases{/id}","deployments_url":"https://api.github.com/repos/huntc/akka-dns/deployments","created_at":"2016-09-27T10:03:39Z","updated_at":"2016-09-27T10:03:40Z","pushed_at":"2016-10-03T19:12:12Z","git_url":"git://github.com/huntc/akka-dns.git","ssh_url":"git@github.com:huntc/akka-dns.git","clone_url":"https://github.com/huntc/akka-dns.git","svn_url":"https://github.com/huntc/akka-dns","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ilya-epifanov:master","ref":"master","sha":"b85ca70d7a511c6d6ec3db7f051f03a1a1207652","user":{"login":"ilya-epifanov","id":92526,"avatar_url":"https://avatars.githubusercontent.com/u/92526?v=3","gravatar_id":"","url":"https://api.github.com/users/ilya-epifanov","html_url":"https://github.com/ilya-epifanov","followers_url":"https://api.github.com/users/ilya-epifanov/followers","following_url":"https://api.github.com/users/ilya-epifanov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-epifanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-epifanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-epifanov/subscriptions","organizations_url":"https://api.github.com/users/ilya-epifanov/orgs","repos_url":"https://api.github.com/users/ilya-epifanov/repos","events_url":"https://api.github.com/users/ilya-epifanov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-epifanov/received_events","type":"User","site_admin":false},"repo":{"id":21118744,"name":"akka-dns","full_name":"ilya-epifanov/akka-dns","owner":{"login":"ilya-epifanov","id":92526,"avatar_url":"https://avatars.githubusercontent.com/u/92526?v=3","gravatar_id":"","url":"https://api.github.com/users/ilya-epifanov","html_url":"https://github.com/ilya-epifanov","followers_url":"https://api.github.com/users/ilya-epifanov/followers","following_url":"https://api.github.com/users/ilya-epifanov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-epifanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-epifanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-epifanov/subscriptions","organizations_url":"https://api.github.com/users/ilya-epifanov/orgs","repos_url":"https://api.github.com/users/ilya-epifanov/repos","events_url":"https://api.github.com/users/ilya-epifanov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-epifanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilya-epifanov/akka-dns","description":"Asynchronous DNS resolver for Akka","fork":false,"url":"https://api.github.com/repos/ilya-epifanov/akka-dns","forks_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/forks","keys_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/teams","hooks_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/hooks","issue_events_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/events{/number}","events_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/events","assignees_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/assignees{/user}","branches_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/branches{/branch}","tags_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/tags","blobs_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/languages","stargazers_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/stargazers","contributors_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/contributors","subscribers_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/subscribers","subscription_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/subscription","commits_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/contents/{+path}","compare_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/merges","archive_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/downloads","issues_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues{/number}","pulls_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/labels{/name}","releases_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/releases{/id}","deployments_url":"https://api.github.com/repos/ilya-epifanov/akka-dns/deployments","created_at":"2014-06-23T08:15:10Z","updated_at":"2016-09-27T18:03:11Z","pushed_at":"2016-10-03T19:12:12Z","git_url":"git://github.com/ilya-epifanov/akka-dns.git","ssh_url":"git@github.com:ilya-epifanov/akka-dns.git","clone_url":"https://github.com/ilya-epifanov/akka-dns.git","svn_url":"https://github.com/ilya-epifanov/akka-dns","homepage":null,"size":22,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1"},"html":{"href":"https://github.com/ilya-epifanov/akka-dns/pull/1"},"issue":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/1"},"comments":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ilya-epifanov/akka-dns/statuses/b06f2230f47345e06c245cf686b46117a2811655"}}}}
{"actor":{"display_login":"huntc"}}