{"action":"closed","number":17071,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071","id":68596748,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/17071","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17071.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17071.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17071","number":17071,"state":"closed","locked":false,"title":"[3.3.5] Core/Scripts: zone_thousand_needles.cpp cleanup","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"**Changes proposed**:\r\n\r\n1 more text line removed in the ongoing series: \"Remove hardcoded text from core scripts\".\r\n\r\nCore script for \"Plucky\" Johnson :\r\n- move the actual gossip handling to DB\r\n- create new gossip_menu_option entry\r\n- link the option to gossip_menu.text_id\r\n- add correct default gossip to the NPC\r\n- create SAI script with alternate emotes\r\n- add condition check for quest taken\r\n- remove the script from zone script\r\n- extra enum cleanup in zone script\r\n\r\n**Target branch(es)**: 3.3.5 (quest 1950 \"Get the Scoop\" was removed in patch 4.0.3a)\r\nhttp://www.wowhead.com/quest=1950/get-the-scoop\r\nhttp://wow.gamepedia.com/Quest:Get_the_Scoop\r\n\r\n**Issues addressed**: Removes (and corrects) the hardcoded text line\r\n`#define GOSSIP_P    \"Please tell me the Phrase..\"` from the script in `zone_thousand_needles.cpp`.\r\nThe correct gossip_menu_option from `broadcast_text`.`ID` 2707 is:\r\n`\"Tell me the phrase to Tirth's lockbox.\"`\r\n\r\nAdded the correct default gossip to NPC 6266 (\"Plucky\" Johnson), which is :\r\n`Hey!  Are you on an errand for Tirth?  If I were you I'd get as far away from him as I could!  His mind's been pickled from too much drink but his magic's as strong as ever!`\r\n(This gossip is shown both with and without the quest.)\r\n\r\nUpdates https://github.com/velinath/TrinityCore/issues/2\r\n\r\n**Tests performed**: (Does it build, tested in-game, etc)\r\nBuilds without problems in VS2013 Update 5, works as intended in-game.\r\nTested multiple times both with and without the quest in the character's quest log.\r\n\r\n**Known issues and ToDo list**:\r\n\r\nNone, the script functionality is improved and working.","created_at":"2016-05-02T18:09:49Z","updated_at":"2016-06-12T06:36:42Z","closed_at":"2016-06-12T06:36:42Z","merged_at":"2016-06-12T06:36:42Z","merge_commit_sha":"d6f0e74cdba9c21e8fc506ecf06d0f3c4fc9b19a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17071/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/3dd4389d9c1256aa969412d2a6ee603258c10a9f","head":{"label":"tkrokli:npc_plucky","ref":"npc_plucky","sha":"3dd4389d9c1256aa969412d2a6ee603258c10a9f","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"repo":{"id":33367544,"name":"TrinityCore","full_name":"tkrokli/TrinityCore","owner":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkrokli/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/tkrokli/TrinityCore","forks_url":"https://api.github.com/repos/tkrokli/TrinityCore/forks","keys_url":"https://api.github.com/repos/tkrokli/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkrokli/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkrokli/TrinityCore/teams","hooks_url":"https://api.github.com/repos/tkrokli/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/tkrokli/TrinityCore/events","assignees_url":"https://api.github.com/repos/tkrokli/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/tkrokli/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/tags","blobs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkrokli/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/tkrokli/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/tkrokli/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/tkrokli/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscription","commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkrokli/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkrokli/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/tkrokli/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkrokli/TrinityCore/merges","archive_url":"https://api.github.com/repos/tkrokli/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkrokli/TrinityCore/downloads","issues_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/tkrokli/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/tkrokli/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/tkrokli/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkrokli/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/tkrokli/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/tkrokli/TrinityCore/deployments","created_at":"2015-04-03T14:46:13Z","updated_at":"2016-06-08T21:21:04Z","pushed_at":"2016-06-11T22:10:38Z","git_url":"git://github.com/tkrokli/TrinityCore.git","ssh_url":"git@github.com:tkrokli/TrinityCore.git","clone_url":"https://github.com/tkrokli/TrinityCore.git","svn_url":"https://github.com/tkrokli/TrinityCore","homepage":"http://www.trinitycore.org","size":270638,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":7,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"7db377c7f9743226ee18a496af8d2569917c15c9","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-06-12T03:30:12Z","pushed_at":"2016-06-12T06:36:42Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":777891,"stargazers_count":3367,"watchers_count":3367,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3431,"mirror_url":null,"open_issues_count":1374,"forks":3431,"open_issues":1374,"watchers":3367,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17071"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17071"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17071/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17071/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/3dd4389d9c1256aa969412d2a6ee603258c10a9f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Aokromes","id":539374,"avatar_url":"https://avatars.githubusercontent.com/u/539374?v=3","gravatar_id":"","url":"https://api.github.com/users/Aokromes","html_url":"https://github.com/Aokromes","followers_url":"https://api.github.com/users/Aokromes/followers","following_url":"https://api.github.com/users/Aokromes/following{/other_user}","gists_url":"https://api.github.com/users/Aokromes/gists{/gist_id}","starred_url":"https://api.github.com/users/Aokromes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aokromes/subscriptions","organizations_url":"https://api.github.com/users/Aokromes/orgs","repos_url":"https://api.github.com/users/Aokromes/repos","events_url":"https://api.github.com/users/Aokromes/events{/privacy}","received_events_url":"https://api.github.com/users/Aokromes/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":59,"deletions":157,"changed_files":2}}
{"actor":{"display_login":"Aokromes"}}