{"action":"created","issue":{"url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/5","repository_url":"https://api.github.com/repos/t1st3/cordova-plugin-ping","labels_url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/5/comments","events_url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/5/events","html_url":"https://github.com/t1st3/cordova-plugin-ping/pull/5","id":166512200,"number":5,"title":"Modifications for issue 1 - 4 ","user":{"login":"prernarana","id":7994600,"avatar_url":"https://avatars.githubusercontent.com/u/7994600?v=3","gravatar_id":"","url":"https://api.github.com/users/prernarana","html_url":"https://github.com/prernarana","followers_url":"https://api.github.com/users/prernarana/followers","following_url":"https://api.github.com/users/prernarana/following{/other_user}","gists_url":"https://api.github.com/users/prernarana/gists{/gist_id}","starred_url":"https://api.github.com/users/prernarana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prernarana/subscriptions","organizations_url":"https://api.github.com/users/prernarana/orgs","repos_url":"https://api.github.com/users/prernarana/repos","events_url":"https://api.github.com/users/prernarana/events{/privacy}","received_events_url":"https://api.github.com/users/prernarana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-20T07:12:04Z","updated_at":"2016-07-26T09:46:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/pulls/5","html_url":"https://github.com/t1st3/cordova-plugin-ping/pull/5","diff_url":"https://github.com/t1st3/cordova-plugin-ping/pull/5.diff","patch_url":"https://github.com/t1st3/cordova-plugin-ping/pull/5.patch"},"body":"Modifications for the following enhancements \r\n\r\n1) Ping 6 support added.\r\nUser can pass through request whether to run Ping command or ping 6 command.\r\n\r\nRequest will now be like \r\n\r\n```\r\n[{query: 'www.somesite.com', 'timeout': 1,'retry': 3,'version':\"v4\"},\r\n{query: 'www.somesite.com', 'timeout': 1,'retry': 3,'version':\"v6\"}]\r\n```\r\nversion parameter will now suggest Ping or Ping6 command.\r\n\r\n2) Support for additional parameters\r\n\r\nPlugin supports extra response parameters like max rtt,min rtt, packet Transmitted, packet Received and packet Loss.\r\n\r\n3) Configurable timeout and retry .\r\n\r\nPlugin supports configurable  retry (-c ) and timeout ( -W ) option in ping or ping6 commands\r\n\r\nRequest will now be like \r\n\r\n```\r\n[{query: 'www.somesite.com', 'timeout': 1,'retry': 3,'version':\"v4\"},\r\n{query: 'www.somesite.com', 'timeout': 1,'retry': 3,'version':\"v6\"}]\r\n```\r\n\r\n4) Change in response structure:\r\n\r\nResponse will now contain the request parameters. It will be helpful in applications where we store data in DB and analyse it later, analyzing will be easy if we have the exact request also.\r\n\r\nResponse will be like \r\n\r\n```\r\n[{\r\n \t\"response\": {\r\n \t\t\"status\": \"success\",\r\n \t\t\"result\": {\r\n \t\t\t\"target\": \"www.somesite.com\",\r\n \t\t\t\"avgRtt\": \"4.476\",\r\n \t\t\t\"maxRtt\": \"6.348\",\r\n \t\t\t\"minRtt\": \"1.007\",\r\n \t\t\t\"pctTransmitted\": \"3\",\r\n \t\t\t\"pctReceived\": \"3\",\r\n \t\t\t\"pctLoss\": \"0%\"\r\n \t\t}\r\n \t},\r\n \t\"request\": {\r\n \t\t\"query\": \"www.somesite.com\",\r\n \t\t\"timeout\": \"2\",\r\n \t\t\"retry\": \"3\",\r\n \t\t\"version\": \"v4\"\r\n \t}\r\n }, {\r\n \t\"response\": {\r\n \t\t\"status\": \"success\",\r\n \t\t\"result\": {\r\n \t\t\t\"target\": \"www.someothersite.com\",\r\n \t\t\t\"avgRtt\": \"4.811\",\r\n \t\t\t\"maxRtt\": \"7.294\",\r\n \t\t\t\"minRtt\": \"0.915\",\r\n \t\t\t\"pctTransmitted\": \"3\",\r\n \t\t\t\"pctReceived\": \"3\",\r\n \t\t\t\"pctLoss\": \"0%\"\r\n \t\t}\r\n \t},\r\n \t\"request\": {\r\n \t\t\"query\": \"www.someothersite.com\",\r\n \t\t\"timeout\": \"2\",\r\n \t\t\"retry\": \"3\",\r\n \t\t\"version\": \"v4\"\r\n \t}\r\n }, {\r\n \t\"response\": {\r\n \t\t\"status\": \"success\",\r\n \t\t\"result\": {\r\n \t\t\t\"target\": \"www.someothersite.com\",\r\n \t\t\t\"avgRtt\": \"4.781\",\r\n \t\t\t\"maxRtt\": \"8.362\",\r\n \t\t\t\"minRtt\": \"1.465\",\r\n \t\t\t\"pctTransmitted\": \"3\",\r\n \t\t\t\"pctReceived\": \"3\",\r\n \t\t\t\"pctLoss\": \"0%\"\r\n \t\t}\r\n \t},\r\n \t\"request\": {\r\n \t\t\"query\": \"www.someothersite.com\",\r\n \t\t\"timeout\": \"2\",\r\n \t\t\"retry\": \"3\",\r\n \t\t\"version\": \"v6\"\r\n \t}\r\n }]\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/comments/235220278","html_url":"https://github.com/t1st3/cordova-plugin-ping/pull/5#issuecomment-235220278","issue_url":"https://api.github.com/repos/t1st3/cordova-plugin-ping/issues/5","id":235220278,"user":{"login":"t1st3","id":1469638,"avatar_url":"https://avatars.githubusercontent.com/u/1469638?v=3","gravatar_id":"","url":"https://api.github.com/users/t1st3","html_url":"https://github.com/t1st3","followers_url":"https://api.github.com/users/t1st3/followers","following_url":"https://api.github.com/users/t1st3/following{/other_user}","gists_url":"https://api.github.com/users/t1st3/gists{/gist_id}","starred_url":"https://api.github.com/users/t1st3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t1st3/subscriptions","organizations_url":"https://api.github.com/users/t1st3/orgs","repos_url":"https://api.github.com/users/t1st3/repos","events_url":"https://api.github.com/users/t1st3/events{/privacy}","received_events_url":"https://api.github.com/users/t1st3/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T09:46:24Z","updated_at":"2016-07-26T09:46:24Z","body":"@prernarana that's great, thank you very much again!\r\nFair enough for the tests, I'm going to merge the PR as is, and I'll write some tests asap. Once I'm done with these tests, everything will be published to NPM with a new tag."}}
{"actor":{"display_login":"t1st3"}}