{"action":"created","comment":{"url":"https://api.github.com/repos/phenotips/phenotips/pulls/comments/85196406","pull_request_review_id":5925729,"id":85196406,"diff_hunk":"@@ -130,6 +130,17 @@ public String getId()\n     }\n \n     @Override\n+    public String getUnderlyingId()\n+    {\n+        if (\"hgnc\".equals(this.ontology.getIdentifier())) {\n+            @SuppressWarnings(\"unchecked\")\n+            List<String> ensemblList = (List<String>) this.get(\"ensembl_gene_id\");\n+            return ensemblList != null && !ensemblList.isEmpty() ? ensemblList.get(0) : (String) this.get(\"symbol\");","path":"components/vocabularies/api/src/main/java/org/phenotips/vocabulary/internal/solr/SolrVocabularyTerm.java","position":9,"original_position":9,"commit_id":"e44f404f0ef7339a07cb2e7a398cdef00ad50cf8","original_commit_id":"e44f404f0ef7339a07cb2e7a398cdef00ad50cf8","user":{"login":"buske","id":4251264,"avatar_url":"https://avatars.githubusercontent.com/u/4251264?v=3","gravatar_id":"","url":"https://api.github.com/users/buske","html_url":"https://github.com/buske","followers_url":"https://api.github.com/users/buske/followers","following_url":"https://api.github.com/users/buske/following{/other_user}","gists_url":"https://api.github.com/users/buske/gists{/gist_id}","starred_url":"https://api.github.com/users/buske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buske/subscriptions","organizations_url":"https://api.github.com/users/buske/orgs","repos_url":"https://api.github.com/users/buske/repos","events_url":"https://api.github.com/users/buske/events{/privacy}","received_events_url":"https://api.github.com/users/buske/received_events","type":"User","site_admin":false},"body":"I believe the SolrVocubularyTerm should be abstracted from the specific vocabularies as much as possible.","created_at":"2016-10-26T19:04:19Z","updated_at":"2016-10-26T19:42:39Z","html_url":"https://github.com/phenotips/phenotips/pull/2118#discussion_r85196406","pull_request_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2118","_links":{"self":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/comments/85196406"},"html":{"href":"https://github.com/phenotips/phenotips/pull/2118#discussion_r85196406"},"pull_request":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2118"}}},"pull_request":{"url":"https://api.github.com/repos/phenotips/phenotips/pulls/2118","id":90894218,"html_url":"https://github.com/phenotips/phenotips/pull/2118","diff_url":"https://github.com/phenotips/phenotips/pull/2118.diff","patch_url":"https://github.com/phenotips/phenotips/pull/2118.patch","issue_url":"https://api.github.com/repos/phenotips/phenotips/issues/2118","number":2118,"state":"open","locked":false,"title":"PT-2785: A gene is stored as Ensembl ID if it exist, and as a gene sy…","user":{"login":"a-gvo","id":7433568,"avatar_url":"https://avatars.githubusercontent.com/u/7433568?v=3","gravatar_id":"","url":"https://api.github.com/users/a-gvo","html_url":"https://github.com/a-gvo","followers_url":"https://api.github.com/users/a-gvo/followers","following_url":"https://api.github.com/users/a-gvo/following{/other_user}","gists_url":"https://api.github.com/users/a-gvo/gists{/gist_id}","starred_url":"https://api.github.com/users/a-gvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-gvo/subscriptions","organizations_url":"https://api.github.com/users/a-gvo/orgs","repos_url":"https://api.github.com/users/a-gvo/repos","events_url":"https://api.github.com/users/a-gvo/events{/privacy}","received_events_url":"https://api.github.com/users/a-gvo/received_events","type":"User","site_admin":false},"body":"…mbol or non-standard ID otherwise.\r\n\r\n@buske @marta- Please review.","created_at":"2016-10-25T21:20:55Z","updated_at":"2016-10-26T19:42:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"416ee327ed1459d56f11db566b3c6dae9958bd31","assignee":{"login":"marta-","id":651980,"avatar_url":"https://avatars.githubusercontent.com/u/651980?v=3","gravatar_id":"","url":"https://api.github.com/users/marta-","html_url":"https://github.com/marta-","followers_url":"https://api.github.com/users/marta-/followers","following_url":"https://api.github.com/users/marta-/following{/other_user}","gists_url":"https://api.github.com/users/marta-/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-/subscriptions","organizations_url":"https://api.github.com/users/marta-/orgs","repos_url":"https://api.github.com/users/marta-/repos","events_url":"https://api.github.com/users/marta-/events{/privacy}","received_events_url":"https://api.github.com/users/marta-/received_events","type":"User","site_admin":false},"assignees":[{"login":"marta-","id":651980,"avatar_url":"https://avatars.githubusercontent.com/u/651980?v=3","gravatar_id":"","url":"https://api.github.com/users/marta-","html_url":"https://github.com/marta-","followers_url":"https://api.github.com/users/marta-/followers","following_url":"https://api.github.com/users/marta-/following{/other_user}","gists_url":"https://api.github.com/users/marta-/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-/subscriptions","organizations_url":"https://api.github.com/users/marta-/orgs","repos_url":"https://api.github.com/users/marta-/repos","events_url":"https://api.github.com/users/marta-/events{/privacy}","received_events_url":"https://api.github.com/users/marta-/received_events","type":"User","site_admin":false},{"login":"buske","id":4251264,"avatar_url":"https://avatars.githubusercontent.com/u/4251264?v=3","gravatar_id":"","url":"https://api.github.com/users/buske","html_url":"https://github.com/buske","followers_url":"https://api.github.com/users/buske/followers","following_url":"https://api.github.com/users/buske/following{/other_user}","gists_url":"https://api.github.com/users/buske/gists{/gist_id}","starred_url":"https://api.github.com/users/buske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buske/subscriptions","organizations_url":"https://api.github.com/users/buske/orgs","repos_url":"https://api.github.com/users/buske/repos","events_url":"https://api.github.com/users/buske/events{/privacy}","received_events_url":"https://api.github.com/users/buske/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2118/commits","review_comments_url":"https://api.github.com/repos/phenotips/phenotips/pulls/2118/comments","review_comment_url":"https://api.github.com/repos/phenotips/phenotips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phenotips/phenotips/issues/2118/comments","statuses_url":"https://api.github.com/repos/phenotips/phenotips/statuses/e44f404f0ef7339a07cb2e7a398cdef00ad50cf8","head":{"label":"a-gvo:PT-2785","ref":"PT-2785","sha":"e44f404f0ef7339a07cb2e7a398cdef00ad50cf8","user":{"login":"a-gvo","id":7433568,"avatar_url":"https://avatars.githubusercontent.com/u/7433568?v=3","gravatar_id":"","url":"https://api.github.com/users/a-gvo","html_url":"https://github.com/a-gvo","followers_url":"https://api.github.com/users/a-gvo/followers","following_url":"https://api.github.com/users/a-gvo/following{/other_user}","gists_url":"https://api.github.com/users/a-gvo/gists{/gist_id}","starred_url":"https://api.github.com/users/a-gvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-gvo/subscriptions","organizations_url":"https://api.github.com/users/a-gvo/orgs","repos_url":"https://api.github.com/users/a-gvo/repos","events_url":"https://api.github.com/users/a-gvo/events{/privacy}","received_events_url":"https://api.github.com/users/a-gvo/received_events","type":"User","site_admin":false},"repo":{"id":66501345,"name":"phenotips","full_name":"a-gvo/phenotips","owner":{"login":"a-gvo","id":7433568,"avatar_url":"https://avatars.githubusercontent.com/u/7433568?v=3","gravatar_id":"","url":"https://api.github.com/users/a-gvo","html_url":"https://github.com/a-gvo","followers_url":"https://api.github.com/users/a-gvo/followers","following_url":"https://api.github.com/users/a-gvo/following{/other_user}","gists_url":"https://api.github.com/users/a-gvo/gists{/gist_id}","starred_url":"https://api.github.com/users/a-gvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-gvo/subscriptions","organizations_url":"https://api.github.com/users/a-gvo/orgs","repos_url":"https://api.github.com/users/a-gvo/repos","events_url":"https://api.github.com/users/a-gvo/events{/privacy}","received_events_url":"https://api.github.com/users/a-gvo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-gvo/phenotips","description":"PhenoTips provides an easy-to-use Web interface and standardized database back-end for collecting clinical findings observed in patients with possible genetic disorders.","fork":true,"url":"https://api.github.com/repos/a-gvo/phenotips","forks_url":"https://api.github.com/repos/a-gvo/phenotips/forks","keys_url":"https://api.github.com/repos/a-gvo/phenotips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-gvo/phenotips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-gvo/phenotips/teams","hooks_url":"https://api.github.com/repos/a-gvo/phenotips/hooks","issue_events_url":"https://api.github.com/repos/a-gvo/phenotips/issues/events{/number}","events_url":"https://api.github.com/repos/a-gvo/phenotips/events","assignees_url":"https://api.github.com/repos/a-gvo/phenotips/assignees{/user}","branches_url":"https://api.github.com/repos/a-gvo/phenotips/branches{/branch}","tags_url":"https://api.github.com/repos/a-gvo/phenotips/tags","blobs_url":"https://api.github.com/repos/a-gvo/phenotips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-gvo/phenotips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-gvo/phenotips/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-gvo/phenotips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-gvo/phenotips/statuses/{sha}","languages_url":"https://api.github.com/repos/a-gvo/phenotips/languages","stargazers_url":"https://api.github.com/repos/a-gvo/phenotips/stargazers","contributors_url":"https://api.github.com/repos/a-gvo/phenotips/contributors","subscribers_url":"https://api.github.com/repos/a-gvo/phenotips/subscribers","subscription_url":"https://api.github.com/repos/a-gvo/phenotips/subscription","commits_url":"https://api.github.com/repos/a-gvo/phenotips/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-gvo/phenotips/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-gvo/phenotips/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-gvo/phenotips/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-gvo/phenotips/contents/{+path}","compare_url":"https://api.github.com/repos/a-gvo/phenotips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-gvo/phenotips/merges","archive_url":"https://api.github.com/repos/a-gvo/phenotips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-gvo/phenotips/downloads","issues_url":"https://api.github.com/repos/a-gvo/phenotips/issues{/number}","pulls_url":"https://api.github.com/repos/a-gvo/phenotips/pulls{/number}","milestones_url":"https://api.github.com/repos/a-gvo/phenotips/milestones{/number}","notifications_url":"https://api.github.com/repos/a-gvo/phenotips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-gvo/phenotips/labels{/name}","releases_url":"https://api.github.com/repos/a-gvo/phenotips/releases{/id}","deployments_url":"https://api.github.com/repos/a-gvo/phenotips/deployments","created_at":"2016-08-24T21:34:31Z","updated_at":"2016-08-24T21:34:39Z","pushed_at":"2016-10-26T16:17:59Z","git_url":"git://github.com/a-gvo/phenotips.git","ssh_url":"git@github.com:a-gvo/phenotips.git","clone_url":"https://github.com/a-gvo/phenotips.git","svn_url":"https://github.com/a-gvo/phenotips","homepage":"http://phenotips.org/","size":927262,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phenotips:master","ref":"master","sha":"ca8cd50921d5e2fedad4f98324100198a41a91d1","user":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"repo":{"id":2685841,"name":"phenotips","full_name":"phenotips/phenotips","owner":{"login":"phenotips","id":4872353,"avatar_url":"https://avatars.githubusercontent.com/u/4872353?v=3","gravatar_id":"","url":"https://api.github.com/users/phenotips","html_url":"https://github.com/phenotips","followers_url":"https://api.github.com/users/phenotips/followers","following_url":"https://api.github.com/users/phenotips/following{/other_user}","gists_url":"https://api.github.com/users/phenotips/gists{/gist_id}","starred_url":"https://api.github.com/users/phenotips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenotips/subscriptions","organizations_url":"https://api.github.com/users/phenotips/orgs","repos_url":"https://api.github.com/users/phenotips/repos","events_url":"https://api.github.com/users/phenotips/events{/privacy}","received_events_url":"https://api.github.com/users/phenotips/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phenotips/phenotips","description":"PhenoTips provides an easy-to-use Web interface and standardized database back-end for collecting clinical findings observed in patients with possible genetic disorders.","fork":false,"url":"https://api.github.com/repos/phenotips/phenotips","forks_url":"https://api.github.com/repos/phenotips/phenotips/forks","keys_url":"https://api.github.com/repos/phenotips/phenotips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenotips/phenotips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenotips/phenotips/teams","hooks_url":"https://api.github.com/repos/phenotips/phenotips/hooks","issue_events_url":"https://api.github.com/repos/phenotips/phenotips/issues/events{/number}","events_url":"https://api.github.com/repos/phenotips/phenotips/events","assignees_url":"https://api.github.com/repos/phenotips/phenotips/assignees{/user}","branches_url":"https://api.github.com/repos/phenotips/phenotips/branches{/branch}","tags_url":"https://api.github.com/repos/phenotips/phenotips/tags","blobs_url":"https://api.github.com/repos/phenotips/phenotips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenotips/phenotips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenotips/phenotips/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenotips/phenotips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenotips/phenotips/statuses/{sha}","languages_url":"https://api.github.com/repos/phenotips/phenotips/languages","stargazers_url":"https://api.github.com/repos/phenotips/phenotips/stargazers","contributors_url":"https://api.github.com/repos/phenotips/phenotips/contributors","subscribers_url":"https://api.github.com/repos/phenotips/phenotips/subscribers","subscription_url":"https://api.github.com/repos/phenotips/phenotips/subscription","commits_url":"https://api.github.com/repos/phenotips/phenotips/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenotips/phenotips/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenotips/phenotips/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenotips/phenotips/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenotips/phenotips/contents/{+path}","compare_url":"https://api.github.com/repos/phenotips/phenotips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenotips/phenotips/merges","archive_url":"https://api.github.com/repos/phenotips/phenotips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenotips/phenotips/downloads","issues_url":"https://api.github.com/repos/phenotips/phenotips/issues{/number}","pulls_url":"https://api.github.com/repos/phenotips/phenotips/pulls{/number}","milestones_url":"https://api.github.com/repos/phenotips/phenotips/milestones{/number}","notifications_url":"https://api.github.com/repos/phenotips/phenotips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenotips/phenotips/labels{/name}","releases_url":"https://api.github.com/repos/phenotips/phenotips/releases{/id}","deployments_url":"https://api.github.com/repos/phenotips/phenotips/deployments","created_at":"2011-11-01T05:55:21Z","updated_at":"2016-10-23T00:55:44Z","pushed_at":"2016-10-26T19:09:21Z","git_url":"git://github.com/phenotips/phenotips.git","ssh_url":"git@github.com:phenotips/phenotips.git","clone_url":"https://github.com/phenotips/phenotips.git","svn_url":"https://github.com/phenotips/phenotips","homepage":"http://phenotips.org/","size":989208,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":301,"forks":39,"open_issues":301,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2118"},"html":{"href":"https://github.com/phenotips/phenotips/pull/2118"},"issue":{"href":"https://api.github.com/repos/phenotips/phenotips/issues/2118"},"comments":{"href":"https://api.github.com/repos/phenotips/phenotips/issues/2118/comments"},"review_comments":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2118/comments"},"review_comment":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phenotips/phenotips/pulls/2118/commits"},"statuses":{"href":"https://api.github.com/repos/phenotips/phenotips/statuses/e44f404f0ef7339a07cb2e7a398cdef00ad50cf8"}}}}
{"actor":{"display_login":"buske"}}