{"action":"created","comment":{"url":"https://api.github.com/repos/Tarsnap/spiped/pulls/comments/65008562","id":65008562,"diff_hunk":"@@ -340,6 +343,9 @@ main(int argc, char * argv[])\n \t\tgoto err6;\n \t}\n \n+\t/* Deregister the graceful_shutdown timer. */\n+\tevents_timer_cancel(graceful_shutdown_timer_cookie);","path":"spiped/main.c","position":33,"original_position":33,"commit_id":"42715b5ed42ed1bba6caf44c9ebe18bbd9232c9f","original_commit_id":"42715b5ed42ed1bba6caf44c9ebe18bbd9232c9f","user":{"login":"cperciva","id":5085436,"avatar_url":"https://avatars.githubusercontent.com/u/5085436?v=3","gravatar_id":"","url":"https://api.github.com/users/cperciva","html_url":"https://github.com/cperciva","followers_url":"https://api.github.com/users/cperciva/followers","following_url":"https://api.github.com/users/cperciva/following{/other_user}","gists_url":"https://api.github.com/users/cperciva/gists{/gist_id}","starred_url":"https://api.github.com/users/cperciva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cperciva/subscriptions","organizations_url":"https://api.github.com/users/cperciva/orgs","repos_url":"https://api.github.com/users/cperciva/repos","events_url":"https://api.github.com/users/cperciva/events{/privacy}","received_events_url":"https://api.github.com/users/cperciva/received_events","type":"User","site_admin":false},"body":"... then don't we end up trying to cancel a timer which doesn't exist here?\r\n\r\nI suggest setting to NULL when the callback is invoked and then checking for NULL here.","created_at":"2016-05-29T17:31:05Z","updated_at":"2016-05-29T17:31:05Z","html_url":"https://github.com/Tarsnap/spiped/pull/55#discussion_r65008562","pull_request_url":"https://api.github.com/repos/Tarsnap/spiped/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/comments/65008562"},"html":{"href":"https://github.com/Tarsnap/spiped/pull/55#discussion_r65008562"},"pull_request":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/Tarsnap/spiped/pulls/55","id":70722901,"html_url":"https://github.com/Tarsnap/spiped/pull/55","diff_url":"https://github.com/Tarsnap/spiped/pull/55.diff","patch_url":"https://github.com/Tarsnap/spiped/pull/55.patch","issue_url":"https://api.github.com/repos/Tarsnap/spiped/issues/55","number":55,"state":"open","locked":false,"title":"spiped: track & clean up graceful shutdown cookie","user":{"login":"gperciva","id":222157,"avatar_url":"https://avatars.githubusercontent.com/u/222157?v=3","gravatar_id":"","url":"https://api.github.com/users/gperciva","html_url":"https://github.com/gperciva","followers_url":"https://api.github.com/users/gperciva/followers","following_url":"https://api.github.com/users/gperciva/following{/other_user}","gists_url":"https://api.github.com/users/gperciva/gists{/gist_id}","starred_url":"https://api.github.com/users/gperciva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gperciva/subscriptions","organizations_url":"https://api.github.com/users/gperciva/orgs","repos_url":"https://api.github.com/users/gperciva/repos","events_url":"https://api.github.com/users/gperciva/events{/privacy}","received_events_url":"https://api.github.com/users/gperciva/received_events","type":"User","site_admin":false},"body":"    events_timer_cancel(graceful_shutdown_timer_cookie);\r\nmust happen before\r\n\r\n    dispatch_shutdown(dispatch_cookie);\r\n\r\nbecause otherwise the timer could trigger after the shutdown (which would try\r\nto use dispatch_cookie after it was freed).","created_at":"2016-05-19T16:14:15Z","updated_at":"2016-05-29T17:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0c5f782d72cafc0942ae41fd7d667a25c49ee19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tarsnap/spiped/pulls/55/commits","review_comments_url":"https://api.github.com/repos/Tarsnap/spiped/pulls/55/comments","review_comment_url":"https://api.github.com/repos/Tarsnap/spiped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tarsnap/spiped/issues/55/comments","statuses_url":"https://api.github.com/repos/Tarsnap/spiped/statuses/42715b5ed42ed1bba6caf44c9ebe18bbd9232c9f","head":{"label":"Tarsnap:spiped-cleanup-timer","ref":"spiped-cleanup-timer","sha":"42715b5ed42ed1bba6caf44c9ebe18bbd9232c9f","user":{"login":"Tarsnap","id":12490383,"avatar_url":"https://avatars.githubusercontent.com/u/12490383?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarsnap","html_url":"https://github.com/Tarsnap","followers_url":"https://api.github.com/users/Tarsnap/followers","following_url":"https://api.github.com/users/Tarsnap/following{/other_user}","gists_url":"https://api.github.com/users/Tarsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarsnap/subscriptions","organizations_url":"https://api.github.com/users/Tarsnap/orgs","repos_url":"https://api.github.com/users/Tarsnap/repos","events_url":"https://api.github.com/users/Tarsnap/events{/privacy}","received_events_url":"https://api.github.com/users/Tarsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":36114883,"name":"spiped","full_name":"Tarsnap/spiped","owner":{"login":"Tarsnap","id":12490383,"avatar_url":"https://avatars.githubusercontent.com/u/12490383?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarsnap","html_url":"https://github.com/Tarsnap","followers_url":"https://api.github.com/users/Tarsnap/followers","following_url":"https://api.github.com/users/Tarsnap/following{/other_user}","gists_url":"https://api.github.com/users/Tarsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarsnap/subscriptions","organizations_url":"https://api.github.com/users/Tarsnap/orgs","repos_url":"https://api.github.com/users/Tarsnap/repos","events_url":"https://api.github.com/users/Tarsnap/events{/privacy}","received_events_url":"https://api.github.com/users/Tarsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tarsnap/spiped","description":"Spiped is a utility for creating symmetrically encrypted and authenticated pipes between socket addresses.","fork":false,"url":"https://api.github.com/repos/Tarsnap/spiped","forks_url":"https://api.github.com/repos/Tarsnap/spiped/forks","keys_url":"https://api.github.com/repos/Tarsnap/spiped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tarsnap/spiped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tarsnap/spiped/teams","hooks_url":"https://api.github.com/repos/Tarsnap/spiped/hooks","issue_events_url":"https://api.github.com/repos/Tarsnap/spiped/issues/events{/number}","events_url":"https://api.github.com/repos/Tarsnap/spiped/events","assignees_url":"https://api.github.com/repos/Tarsnap/spiped/assignees{/user}","branches_url":"https://api.github.com/repos/Tarsnap/spiped/branches{/branch}","tags_url":"https://api.github.com/repos/Tarsnap/spiped/tags","blobs_url":"https://api.github.com/repos/Tarsnap/spiped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tarsnap/spiped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tarsnap/spiped/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tarsnap/spiped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tarsnap/spiped/statuses/{sha}","languages_url":"https://api.github.com/repos/Tarsnap/spiped/languages","stargazers_url":"https://api.github.com/repos/Tarsnap/spiped/stargazers","contributors_url":"https://api.github.com/repos/Tarsnap/spiped/contributors","subscribers_url":"https://api.github.com/repos/Tarsnap/spiped/subscribers","subscription_url":"https://api.github.com/repos/Tarsnap/spiped/subscription","commits_url":"https://api.github.com/repos/Tarsnap/spiped/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tarsnap/spiped/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tarsnap/spiped/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tarsnap/spiped/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tarsnap/spiped/contents/{+path}","compare_url":"https://api.github.com/repos/Tarsnap/spiped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tarsnap/spiped/merges","archive_url":"https://api.github.com/repos/Tarsnap/spiped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tarsnap/spiped/downloads","issues_url":"https://api.github.com/repos/Tarsnap/spiped/issues{/number}","pulls_url":"https://api.github.com/repos/Tarsnap/spiped/pulls{/number}","milestones_url":"https://api.github.com/repos/Tarsnap/spiped/milestones{/number}","notifications_url":"https://api.github.com/repos/Tarsnap/spiped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tarsnap/spiped/labels{/name}","releases_url":"https://api.github.com/repos/Tarsnap/spiped/releases{/id}","deployments_url":"https://api.github.com/repos/Tarsnap/spiped/deployments","created_at":"2015-05-23T08:47:44Z","updated_at":"2016-05-29T16:25:19Z","pushed_at":"2016-05-29T17:28:53Z","git_url":"git://github.com/Tarsnap/spiped.git","ssh_url":"git@github.com:Tarsnap/spiped.git","clone_url":"https://github.com/Tarsnap/spiped.git","svn_url":"https://github.com/Tarsnap/spiped","homepage":"http://www.tarsnap.com/spiped.html","size":517,"stargazers_count":157,"watchers_count":157,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":157,"default_branch":"master"}},"base":{"label":"Tarsnap:master","ref":"master","sha":"456de4b19279f486cbec468dd813f134b2309ca5","user":{"login":"Tarsnap","id":12490383,"avatar_url":"https://avatars.githubusercontent.com/u/12490383?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarsnap","html_url":"https://github.com/Tarsnap","followers_url":"https://api.github.com/users/Tarsnap/followers","following_url":"https://api.github.com/users/Tarsnap/following{/other_user}","gists_url":"https://api.github.com/users/Tarsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarsnap/subscriptions","organizations_url":"https://api.github.com/users/Tarsnap/orgs","repos_url":"https://api.github.com/users/Tarsnap/repos","events_url":"https://api.github.com/users/Tarsnap/events{/privacy}","received_events_url":"https://api.github.com/users/Tarsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":36114883,"name":"spiped","full_name":"Tarsnap/spiped","owner":{"login":"Tarsnap","id":12490383,"avatar_url":"https://avatars.githubusercontent.com/u/12490383?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarsnap","html_url":"https://github.com/Tarsnap","followers_url":"https://api.github.com/users/Tarsnap/followers","following_url":"https://api.github.com/users/Tarsnap/following{/other_user}","gists_url":"https://api.github.com/users/Tarsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarsnap/subscriptions","organizations_url":"https://api.github.com/users/Tarsnap/orgs","repos_url":"https://api.github.com/users/Tarsnap/repos","events_url":"https://api.github.com/users/Tarsnap/events{/privacy}","received_events_url":"https://api.github.com/users/Tarsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tarsnap/spiped","description":"Spiped is a utility for creating symmetrically encrypted and authenticated pipes between socket addresses.","fork":false,"url":"https://api.github.com/repos/Tarsnap/spiped","forks_url":"https://api.github.com/repos/Tarsnap/spiped/forks","keys_url":"https://api.github.com/repos/Tarsnap/spiped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tarsnap/spiped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tarsnap/spiped/teams","hooks_url":"https://api.github.com/repos/Tarsnap/spiped/hooks","issue_events_url":"https://api.github.com/repos/Tarsnap/spiped/issues/events{/number}","events_url":"https://api.github.com/repos/Tarsnap/spiped/events","assignees_url":"https://api.github.com/repos/Tarsnap/spiped/assignees{/user}","branches_url":"https://api.github.com/repos/Tarsnap/spiped/branches{/branch}","tags_url":"https://api.github.com/repos/Tarsnap/spiped/tags","blobs_url":"https://api.github.com/repos/Tarsnap/spiped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tarsnap/spiped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tarsnap/spiped/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tarsnap/spiped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tarsnap/spiped/statuses/{sha}","languages_url":"https://api.github.com/repos/Tarsnap/spiped/languages","stargazers_url":"https://api.github.com/repos/Tarsnap/spiped/stargazers","contributors_url":"https://api.github.com/repos/Tarsnap/spiped/contributors","subscribers_url":"https://api.github.com/repos/Tarsnap/spiped/subscribers","subscription_url":"https://api.github.com/repos/Tarsnap/spiped/subscription","commits_url":"https://api.github.com/repos/Tarsnap/spiped/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tarsnap/spiped/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tarsnap/spiped/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tarsnap/spiped/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tarsnap/spiped/contents/{+path}","compare_url":"https://api.github.com/repos/Tarsnap/spiped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tarsnap/spiped/merges","archive_url":"https://api.github.com/repos/Tarsnap/spiped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tarsnap/spiped/downloads","issues_url":"https://api.github.com/repos/Tarsnap/spiped/issues{/number}","pulls_url":"https://api.github.com/repos/Tarsnap/spiped/pulls{/number}","milestones_url":"https://api.github.com/repos/Tarsnap/spiped/milestones{/number}","notifications_url":"https://api.github.com/repos/Tarsnap/spiped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tarsnap/spiped/labels{/name}","releases_url":"https://api.github.com/repos/Tarsnap/spiped/releases{/id}","deployments_url":"https://api.github.com/repos/Tarsnap/spiped/deployments","created_at":"2015-05-23T08:47:44Z","updated_at":"2016-05-29T16:25:19Z","pushed_at":"2016-05-29T17:28:53Z","git_url":"git://github.com/Tarsnap/spiped.git","ssh_url":"git@github.com:Tarsnap/spiped.git","clone_url":"https://github.com/Tarsnap/spiped.git","svn_url":"https://github.com/Tarsnap/spiped","homepage":"http://www.tarsnap.com/spiped.html","size":517,"stargazers_count":157,"watchers_count":157,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/55"},"html":{"href":"https://github.com/Tarsnap/spiped/pull/55"},"issue":{"href":"https://api.github.com/repos/Tarsnap/spiped/issues/55"},"comments":{"href":"https://api.github.com/repos/Tarsnap/spiped/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tarsnap/spiped/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/Tarsnap/spiped/statuses/42715b5ed42ed1bba6caf44c9ebe18bbd9232c9f"}}}}
{"actor":{"display_login":"cperciva"}}