{"action":"created","issue":{"url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/2146","repository_url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack","labels_url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/2146/labels{/name}","comments_url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/2146/comments","events_url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/2146/events","html_url":"https://github.com/angular-fullstack/generator-angular-fullstack/issues/2146","id":170800076,"number":2146,"title":"gulp-filter@4.0.0 will miss file when building, while gulp-filter@3.0.1 OK","user":{"login":"jacinchan","id":6768811,"avatar_url":"https://avatars.githubusercontent.com/u/6768811?v=3","gravatar_id":"","url":"https://api.github.com/users/jacinchan","html_url":"https://github.com/jacinchan","followers_url":"https://api.github.com/users/jacinchan/followers","following_url":"https://api.github.com/users/jacinchan/following{/other_user}","gists_url":"https://api.github.com/users/jacinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jacinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacinchan/subscriptions","organizations_url":"https://api.github.com/users/jacinchan/orgs","repos_url":"https://api.github.com/users/jacinchan/repos","events_url":"https://api.github.com/users/jacinchan/events{/privacy}","received_events_url":"https://api.github.com/users/jacinchan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-12T05:12:01Z","updated_at":"2016-08-12T05:29:03Z","closed_at":null,"body":"Item | Version\r\n----- | -----\r\ngenerator-angular-fullstack | 3.7.6\r\nNode | 5.10.1\r\nnpm | x.x.x\r\nOperating System | OS X 10 / Windows 10 / Ubuntu 15.10 / etc\r\netc | etc\r\n\r\nItem | Answer\r\n----- | -----\r\nTranspiler | Babel \r\nMarkup | HTML \r\nCSS |  SCSS\r\nRouter | ui-router\r\nClient Tests |  Mocha\r\nDB | MongoDB \r\nAuth |  N\r\netc | etc\r\n\r\nwhen I use gulp build, i found app.js did not uglity or rev\r\nproblem is  \r\ngulp-filter@4.0.0 will miss some files.\r\nif i reset to gulp-filter@3.0.1, it's OK\r\nsee the gulp file here\r\n\r\nin gulp.task('build:client')\r\n\r\nreturn gulp.src(paths.client.mainView)\r\n        .pipe(plugins.useref())\r\n            .pipe(appFilter)\r\n                .pipe(plugins.addSrc.append('.tmp/templates.js'))\r\n                .pipe(plugins.concat('app/app.js'))\r\n            .pipe(appFilter.restore)     -------------   // **app/app.js is included**\r\n            .pipe(jsFilter)                     -------------    // **app/app.js is excluded!**\r\n                .pipe(plugins.ngAnnotate())\r\n                .pipe(plugins.uglify())\r\n            .pipe(jsFilter.restore)\r\n            .pipe(cssFilter)\r\n                .pipe(plugins.cleanCss({\r\n                    processImportFrom: ['!fonts.googleapis.com']\r\n                }))\r\n            .pipe(cssFilter.restore)\r\n            .pipe(htmlBlock)            //the same problem here\r\n                .pipe(plugins.rev())\r\n            .pipe(htmlBlock.restore)\r\n        .pipe(plugins.revReplace({manifest}))\r\n        .pipe(gulp.dest(`${paths.dist}/${clientPath}`));\r\n"},"comment":{"url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/comments/239364081","html_url":"https://github.com/angular-fullstack/generator-angular-fullstack/issues/2146#issuecomment-239364081","issue_url":"https://api.github.com/repos/angular-fullstack/generator-angular-fullstack/issues/2146","id":239364081,"user":{"login":"Awk34","id":5545474,"avatar_url":"https://avatars.githubusercontent.com/u/5545474?v=3","gravatar_id":"","url":"https://api.github.com/users/Awk34","html_url":"https://github.com/Awk34","followers_url":"https://api.github.com/users/Awk34/followers","following_url":"https://api.github.com/users/Awk34/following{/other_user}","gists_url":"https://api.github.com/users/Awk34/gists{/gist_id}","starred_url":"https://api.github.com/users/Awk34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Awk34/subscriptions","organizations_url":"https://api.github.com/users/Awk34/orgs","repos_url":"https://api.github.com/users/Awk34/repos","events_url":"https://api.github.com/users/Awk34/events{/privacy}","received_events_url":"https://api.github.com/users/Awk34/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T05:29:03Z","updated_at":"2016-08-12T05:29:03Z","body":"Could you elaborate more? Why would gulp-filter 4 break this while it works with 3?"}}
{"actor":{"display_login":"Awk34"}}