{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/7626","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/7626/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/7626/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/7626/events","html_url":"https://github.com/elastic/kibana/pull/7626","id":163861156,"number":7626,"title":"Dashboard: Load a default rather than starting new - Against master - Closing #5820","user":{"login":"LuudJanssen","id":12209111,"avatar_url":"https://avatars.githubusercontent.com/u/12209111?v=3","gravatar_id":"","url":"https://api.github.com/users/LuudJanssen","html_url":"https://github.com/LuudJanssen","followers_url":"https://api.github.com/users/LuudJanssen/followers","following_url":"https://api.github.com/users/LuudJanssen/following{/other_user}","gists_url":"https://api.github.com/users/LuudJanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/LuudJanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuudJanssen/subscriptions","organizations_url":"https://api.github.com/users/LuudJanssen/orgs","repos_url":"https://api.github.com/users/LuudJanssen/repos","events_url":"https://api.github.com/users/LuudJanssen/events{/privacy}","received_events_url":"https://api.github.com/users/LuudJanssen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"assignees":[{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-07-05T14:14:36Z","updated_at":"2016-08-19T15:03:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/7626","html_url":"https://github.com/elastic/kibana/pull/7626","diff_url":"https://github.com/elastic/kibana/pull/7626.diff","patch_url":"https://github.com/elastic/kibana/pull/7626.patch"},"body":"This is a pull request closing #5820 against master. I wasn't able to run the tests locally. Could someone test it for me? It implements the default dashboard setup in the config options in the dashboard:\r\n\r\n![Default dashboards in Kibana - Pull Request](https://cloud.githubusercontent.com/assets/12209111/16587636/e11975da-42cb-11e6-9f07-34ebab902126.png)\r\n\r\nIt does not use the suggestion from @dotfold to use a 'star' icon in the toolbar to set the dashboard as default, but this can be easily implemented since the logic is already there.\r\n\r\nI'm doing this pull request against 4.5 since that is the version we're running at our company, but I might do a pull request against master as well (or someone else can rewrite / merge it, if they have the time)."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/241043189","html_url":"https://github.com/elastic/kibana/pull/7626#issuecomment-241043189","issue_url":"https://api.github.com/repos/elastic/kibana/issues/7626","id":241043189,"user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T15:03:23Z","updated_at":"2016-08-19T15:03:23Z","body":"@LuudJanssen I did a preliminary code review and added some inline comments.\r\n\r\nIn general, I don't really like how this muddies the water between new and existing dashboards, so whenever you want to make a decision about templates and such, you need to also do a check on the `new` property.\r\n\r\nWhat do you think about this instead:\r\n\r\n```\r\n/dashboard - sole responsibility is checking whether we have a default dashboard and sending the user to where they need to go as a result (using .replace() as to ensure this doesn't remain in browser history)\r\n/dashboard/new - always used for creating a new dashboard\r\n/dashboard/:id - always used for loading an existing dashboard\r\n```"}}
{"actor":{"display_login":"epixa"}}