{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/6287","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/6287/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/6287/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/6287/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/6287","id":193777052,"number":6287,"title":"Reader / Splitview: Add fullscreen support for posts","user":{"login":"frosty","id":4780,"avatar_url":"https://avatars.githubusercontent.com/u/4780?v=3","gravatar_id":"","url":"https://api.github.com/users/frosty","html_url":"https://github.com/frosty","followers_url":"https://api.github.com/users/frosty/followers","following_url":"https://api.github.com/users/frosty/following{/other_user}","gists_url":"https://api.github.com/users/frosty/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty/subscriptions","organizations_url":"https://api.github.com/users/frosty/orgs","repos_url":"https://api.github.com/users/frosty/repos","events_url":"https://api.github.com/users/frosty/events{/privacy}","received_events_url":"https://api.github.com/users/frosty/received_events","type":"User","site_admin":false},"labels":[{"id":389844120,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/iPad","name":"iPad","color":"bfd4f2","default":false},{"id":88221256,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/Reader","name":"Reader","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"assignees":[{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},{"login":"kurzee","id":1873422,"avatar_url":"https://avatars.githubusercontent.com/u/1873422?v=3","gravatar_id":"","url":"https://api.github.com/users/kurzee","html_url":"https://github.com/kurzee","followers_url":"https://api.github.com/users/kurzee/followers","following_url":"https://api.github.com/users/kurzee/following{/other_user}","gists_url":"https://api.github.com/users/kurzee/gists{/gist_id}","starred_url":"https://api.github.com/users/kurzee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurzee/subscriptions","organizations_url":"https://api.github.com/users/kurzee/orgs","repos_url":"https://api.github.com/users/kurzee/repos","events_url":"https://api.github.com/users/kurzee/events{/privacy}","received_events_url":"https://api.github.com/users/kurzee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/65","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestones/6.9","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/65/labels","id":2168582,"number":65,"title":"6.9","description":"","creator":{"login":"koke","id":8739,"avatar_url":"https://avatars.githubusercontent.com/u/8739?v=3","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":9,"state":"open","created_at":"2016-12-01T12:32:18Z","updated_at":"2016-12-07T17:24:06Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2016-12-06T13:50:50Z","updated_at":"2016-12-07T18:09:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/6287","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/6287","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/6287.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/6287.patch"},"body":"This PR adds fullscreen support to the Reader when viewing post content.\r\n\r\n![reader-fullscreen](https://cloud.githubusercontent.com/assets/4780/20927775/f5ff2d06-bbba-11e6-9268-f214a01ec2f6.gif)\r\n\r\nDue to various issues with the built in splitview animation whilst pushing onto the detail navigation controller, I've used a trick @aerych suggested and we hide the navigation bar content whilst the animation takes place.\r\n\r\nTo test:\r\n\r\n* In the Reader, on a device / orientation that shows an expanded splitview (iPad, Plus phones in landscape), select a post from a stream\r\n* The splitview should transition to full screen, hiding the left pane.\r\n* Navigating back from the post detail should re-show the left pane.\r\n* Please test with different orientations / state restoration / etc.\r\n\r\nNeeds review: @kurzee @aerych "},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/265524946","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/6287#issuecomment-265524946","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/6287","id":265524946,"user":{"login":"kurzee","id":1873422,"avatar_url":"https://avatars.githubusercontent.com/u/1873422?v=3","gravatar_id":"","url":"https://api.github.com/users/kurzee","html_url":"https://github.com/kurzee","followers_url":"https://api.github.com/users/kurzee/followers","following_url":"https://api.github.com/users/kurzee/following{/other_user}","gists_url":"https://api.github.com/users/kurzee/gists{/gist_id}","starred_url":"https://api.github.com/users/kurzee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurzee/subscriptions","organizations_url":"https://api.github.com/users/kurzee/orgs","repos_url":"https://api.github.com/users/kurzee/repos","events_url":"https://api.github.com/users/kurzee/events{/privacy}","received_events_url":"https://api.github.com/users/kurzee/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T18:09:40Z","updated_at":"2016-12-07T18:09:40Z","body":"@aerych here's a different post with another interesting shift in layout\r\n\r\n![reader-detail-full-screen-back](https://cloud.githubusercontent.com/assets/1873422/20980400/016da94a-bc76-11e6-99a2-24b5e8b94b8c.gif)\r\n"}}
{"actor":{"display_login":"kurzee"}}