{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/guides/issues/137","repository_url":"https://api.github.com/repos/ManageIQ/guides","labels_url":"https://api.github.com/repos/ManageIQ/guides/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/guides/issues/137/comments","events_url":"https://api.github.com/repos/ManageIQ/guides/issues/137/events","html_url":"https://github.com/ManageIQ/guides/pull/137","id":165835228,"number":137,"title":"Removes rule enforcing no space in curly braces","user":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-07-15T17:11:08Z","updated_at":"2016-07-17T15:15:44Z","closed_at":"2016-07-15T23:58:28Z","pull_request":{"url":"https://api.github.com/repos/ManageIQ/guides/pulls/137","html_url":"https://github.com/ManageIQ/guides/pull/137","diff_url":"https://github.com/ManageIQ/guides/pull/137.diff","patch_url":"https://github.com/ManageIQ/guides/pull/137.patch"},"body":"Summary:\r\n![](http://wil.to/_/bikeshed.jpg)\r\n\r\n---\r\n\r\nJust kidding, I actually have been meaning to submit this since the beginning. This is what I'd consider pretty standard Ruby style across most projects.\r\n\r\nSee https://github.com/bbatsov/ruby-style-guide/blob/master/README.md#spaces-braces\r\nAlso see [how to vote for this change](https://github.com/ManageIQ/guides/pull/137#issuecomment-233012107)\r\n\r\nNo spaces after (, [ or before ], ). Use spaces around { and before }.\r\n\r\n```ruby\r\n# bad\r\nsome( arg ).other\r\n[ 1, 2, 3 ].each{|e| puts e}\r\n\r\n# good\r\nsome(arg).other\r\n[1, 2, 3].each { |e| puts e }\r\n```\r\n{ and } deserve a bit of clarification, since they are used for block and hash literals, as well as string interpolation.\r\n\r\nFrom the bbatsov styleguide:\r\nFor hash literals two styles are considered acceptable. **The first variant is slightly more readable (and arguably more popular in the Ruby community in general).** The second variant has the advantage of adding visual difference between block and hash literals. **Whichever one you pick—apply it consistently.**\r\n\r\n**Note that I am proposing that you should use the first one consistently**\r\n\r\n```ruby\r\n# good - space after { and before }\r\n{ one: 1, two: 2 }\r\n\r\n# ok - No bot rule preventing it, but previous example preferred\r\n{one: 1, two: 2}\r\n```\r\n\r\nWith interpolated expressions, there should be no padded-spacing inside the braces.\r\n\r\n```ruby\r\n# bad\r\n\"From: #{ user.first_name }, #{ user.last_name }\"\r\n\r\n# good\r\n\"From: #{user.first_name}, #{user.last_name}\"\r\n```\r\n\r\nr? @Fryguy"},"comment":{"url":"https://api.github.com/repos/ManageIQ/guides/issues/comments/233186889","html_url":"https://github.com/ManageIQ/guides/pull/137#issuecomment-233186889","issue_url":"https://api.github.com/repos/ManageIQ/guides/issues/137","id":233186889,"user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T15:15:44Z","updated_at":"2016-07-17T15:15:44Z","body":"@chrisarcand sorry I did not test your code. it looked good to me and so many people looked at this..."}}
{"actor":{"display_login":"kbrock"}}