{"action":"created","issue":{"url":"https://api.github.com/repos/marcj/topsort.php/issues/4","repository_url":"https://api.github.com/repos/marcj/topsort.php","labels_url":"https://api.github.com/repos/marcj/topsort.php/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/marcj/topsort.php/issues/4/comments","events_url":"https://api.github.com/repos/marcj/topsort.php/issues/4/events","html_url":"https://github.com/marcj/topsort.php/issues/4","id":193492263,"number":4,"title":"Description of flat implementations and recommendation","user":{"login":"PhrozenByte","id":920356,"avatar_url":"https://avatars.githubusercontent.com/u/920356?v=3","gravatar_id":"","url":"https://api.github.com/users/PhrozenByte","html_url":"https://github.com/PhrozenByte","followers_url":"https://api.github.com/users/PhrozenByte/followers","following_url":"https://api.github.com/users/PhrozenByte/following{/other_user}","gists_url":"https://api.github.com/users/PhrozenByte/gists{/gist_id}","starred_url":"https://api.github.com/users/PhrozenByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhrozenByte/subscriptions","organizations_url":"https://api.github.com/users/PhrozenByte/orgs","repos_url":"https://api.github.com/users/PhrozenByte/repos","events_url":"https://api.github.com/users/PhrozenByte/events{/privacy}","received_events_url":"https://api.github.com/users/PhrozenByte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-05T13:08:50Z","updated_at":"2016-12-05T13:47:07Z","closed_at":null,"body":"First of all: Great project! 👍 \r\n\r\nHowever, I've a bit trouble to comprehend why `FixedArraySort` is the recommended implementation. According to the benchmarks in your `README.md` (and my own benchmarks I run with PHP 5.6), `ArraySort` always wins against `FixedArraySort`. The execution times are virtually identical (between -1% and +2,5% difference), whereas `FixedArraySort` has a significant higher memory footprint (up to +30%).\r\n\r\nThe [Implementations section](https://github.com/marcj/topsort.php#implementations) of the non-grouped storages generally doesn't seem to match the benchmarks: You say that `\\SplFixedArray` is \"much more memory friendly\" compared to plain PHP arrays, but `\\SplFixedArray` always has a higher memory footprint. The string implementation is described as storage with \"no array overhead\" and as \"a bit faster and [..] almost equal memory footprint\". This doesn't seem to be true either, it's actually both slower and more memory-intensive as the other implementations.\r\n\r\nDo I miss something here?\r\n"},"comment":{"url":"https://api.github.com/repos/marcj/topsort.php/issues/comments/264857807","html_url":"https://github.com/marcj/topsort.php/issues/4#issuecomment-264857807","issue_url":"https://api.github.com/repos/marcj/topsort.php/issues/4","id":264857807,"user":{"login":"marcj","id":450980,"avatar_url":"https://avatars.githubusercontent.com/u/450980?v=3","gravatar_id":"","url":"https://api.github.com/users/marcj","html_url":"https://github.com/marcj","followers_url":"https://api.github.com/users/marcj/followers","following_url":"https://api.github.com/users/marcj/following{/other_user}","gists_url":"https://api.github.com/users/marcj/gists{/gist_id}","starred_url":"https://api.github.com/users/marcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcj/subscriptions","organizations_url":"https://api.github.com/users/marcj/orgs","repos_url":"https://api.github.com/users/marcj/repos","events_url":"https://api.github.com/users/marcj/events{/privacy}","received_events_url":"https://api.github.com/users/marcj/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T13:47:07Z","updated_at":"2016-12-05T13:47:07Z","body":"I updated lately the benchmarks with a new scripts and haven obviously updated the description/recommendation above :)"}}
{"actor":{"display_login":"marcj"}}