{"action":"created","issue":{"url":"https://api.github.com/repos/humhub/humhub/issues/2094","repository_url":"https://api.github.com/repos/humhub/humhub","labels_url":"https://api.github.com/repos/humhub/humhub/issues/2094/labels{/name}","comments_url":"https://api.github.com/repos/humhub/humhub/issues/2094/comments","events_url":"https://api.github.com/repos/humhub/humhub/issues/2094/events","html_url":"https://github.com/humhub/humhub/pull/2094","id":188877568,"number":2094,"title":"Attached files browser caching, fixes #2091","user":{"login":"acs-ferreira","id":12234510,"avatar_url":"https://avatars.githubusercontent.com/u/12234510?v=3","gravatar_id":"","url":"https://api.github.com/users/acs-ferreira","html_url":"https://github.com/acs-ferreira","followers_url":"https://api.github.com/users/acs-ferreira/followers","following_url":"https://api.github.com/users/acs-ferreira/following{/other_user}","gists_url":"https://api.github.com/users/acs-ferreira/gists{/gist_id}","starred_url":"https://api.github.com/users/acs-ferreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acs-ferreira/subscriptions","organizations_url":"https://api.github.com/users/acs-ferreira/orgs","repos_url":"https://api.github.com/users/acs-ferreira/repos","events_url":"https://api.github.com/users/acs-ferreira/events{/privacy}","received_events_url":"https://api.github.com/users/acs-ferreira/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-12T00:11:15Z","updated_at":"2016-11-12T19:25:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/humhub/humhub/pulls/2094","html_url":"https://github.com/humhub/humhub/pull/2094","diff_url":"https://github.com/humhub/humhub/pull/2094.diff","patch_url":"https://github.com/humhub/humhub/pull/2094.patch"},"body":"Using ETag and max-age"},"comment":{"url":"https://api.github.com/repos/humhub/humhub/issues/comments/260142688","html_url":"https://github.com/humhub/humhub/pull/2094#issuecomment-260142688","issue_url":"https://api.github.com/repos/humhub/humhub/issues/2094","id":260142688,"user":{"login":"acs-ferreira","id":12234510,"avatar_url":"https://avatars.githubusercontent.com/u/12234510?v=3","gravatar_id":"","url":"https://api.github.com/users/acs-ferreira","html_url":"https://github.com/acs-ferreira","followers_url":"https://api.github.com/users/acs-ferreira/followers","following_url":"https://api.github.com/users/acs-ferreira/following{/other_user}","gists_url":"https://api.github.com/users/acs-ferreira/gists{/gist_id}","starred_url":"https://api.github.com/users/acs-ferreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acs-ferreira/subscriptions","organizations_url":"https://api.github.com/users/acs-ferreira/orgs","repos_url":"https://api.github.com/users/acs-ferreira/repos","events_url":"https://api.github.com/users/acs-ferreira/events{/privacy}","received_events_url":"https://api.github.com/users/acs-ferreira/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T19:25:24Z","updated_at":"2016-11-12T19:25:24Z","body":"IMO, my approach is the best one, because:\r\n\r\n- it set a never expire header with the `max-age = 1 year`, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html\r\n\r\n> To mark a response as \"never expires,\" an origin server sends an Expires date approximately one year from the time the response is sent.\r\n\r\n- it generates a unique ETag for each file, it remains the same ETag even after cache clearing\r\n\r\nBut if in your opinion your approach is better, i'm just contributing after all, not owning ;)\r\n\r\n"}}
{"actor":{"display_login":"acs-ferreira"}}