{"action":"created","issue":{"url":"https://api.github.com/repos/hyperium/hyper/issues/970","repository_url":"https://api.github.com/repos/hyperium/hyper","labels_url":"https://api.github.com/repos/hyperium/hyper/issues/970/labels{/name}","comments_url":"https://api.github.com/repos/hyperium/hyper/issues/970/comments","events_url":"https://api.github.com/repos/hyperium/hyper/issues/970/events","html_url":"https://github.com/hyperium/hyper/issues/970","id":195148938,"number":970,"title":"[Tokio Branch] hyper::server::request::Request::deconstruct() does not return Request.body","user":{"login":"ashleysommer","id":402468,"avatar_url":"https://avatars.githubusercontent.com/u/402468?v=3","gravatar_id":"","url":"https://api.github.com/users/ashleysommer","html_url":"https://github.com/ashleysommer","followers_url":"https://api.github.com/users/ashleysommer/followers","following_url":"https://api.github.com/users/ashleysommer/following{/other_user}","gists_url":"https://api.github.com/users/ashleysommer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleysommer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleysommer/subscriptions","organizations_url":"https://api.github.com/users/ashleysommer/orgs","repos_url":"https://api.github.com/users/ashleysommer/repos","events_url":"https://api.github.com/users/ashleysommer/events{/privacy}","received_events_url":"https://api.github.com/users/ashleysommer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-13T03:15:43Z","updated_at":"2016-12-18T07:03:41Z","closed_at":null,"body":"As per title.\r\nYou can get a tuple with `(self.method, self.uri, self.version, self.headers)` by calling `request.deconstruct()`, that consumes `request`.\r\nAlternatively you can get just request body by using `request.body()` but that also consumes the request.\r\nThere is no way of getting both the deconstructed request items _and_ the request body from a single request."},"comment":{"url":"https://api.github.com/repos/hyperium/hyper/issues/comments/267807000","html_url":"https://github.com/hyperium/hyper/issues/970#issuecomment-267807000","issue_url":"https://api.github.com/repos/hyperium/hyper/issues/970","id":267807000,"user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"created_at":"2016-12-18T07:03:41Z","updated_at":"2016-12-18T07:03:41Z","body":"My reasoning for using an `Option<Body>` internally is because 1) you cannot query a `Body` to see if it is empty, so therefore 2) you cannot know from just the `Body` whether you should pass a `Message::WithBody(head, body)` or `Message::WithoutBody(head)` to tokio. Maybe it makes sense to add a method to `Body` to check if it is empty. But I don't think that it being an `Option<Body>` needs to be made known to a user. Actually, considering that it is only needed for constructing the `Message`, and `Request` is constructed **from** a Message, not into one, the option can probably be removed from `Request`..."}}
{"actor":{"display_login":"seanmonstar"}}