{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/61582381","id":61582381,"diff_hunk":"@@ -139,12 +140,23 @@ void UpdateBackgroundView()\n \n \t\tvoid UpdateRowHeight()\n \t\t{\n-\t\t\tvar height = Element.RowHeight;\n-\n-\t\t\tif (height <= 0)\n-\t\t\t\theight = 44;\n+\t\t\tvar rowHeight = Element.RowHeight;\n+\t\t\tif (Element.HasUnevenRows && rowHeight == -1 && Forms.IsiOS7OrNewer) {\n+\t\t\t\tif (Forms.IsiOS8OrNewer)\n+\t\t\t\t\tControl.RowHeight = UITableView.AutomaticDimension;\n+\t\t\t} else\n+\t\t\t\tControl.RowHeight = rowHeight <= 0 ? DefaultRowHeight : rowHeight;\n+\t\t}\n \n-\t\t\tControl.RowHeight = height;\n+\t\tvoid UpdateEstimatedRowHeight()","path":"Xamarin.Forms.Platform.iOS/Renderers/TableViewRenderer.cs","position":57,"original_position":57,"commit_id":"a9541818086086357268691d65e61180e65c2156","original_commit_id":"a9541818086086357268691d65e61180e65c2156","user":{"login":"kingces95","id":4120386,"avatar_url":"https://avatars.githubusercontent.com/u/4120386?v=3","gravatar_id":"","url":"https://api.github.com/users/kingces95","html_url":"https://github.com/kingces95","followers_url":"https://api.github.com/users/kingces95/followers","following_url":"https://api.github.com/users/kingces95/following{/other_user}","gists_url":"https://api.github.com/users/kingces95/gists{/gist_id}","starred_url":"https://api.github.com/users/kingces95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingces95/subscriptions","organizations_url":"https://api.github.com/users/kingces95/orgs","repos_url":"https://api.github.com/users/kingces95/repos","events_url":"https://api.github.com/users/kingces95/events{/privacy}","received_events_url":"https://api.github.com/users/kingces95/received_events","type":"User","site_admin":false},"body":"Adapted from https://github.com/scastria/Xamarin.Forms/blob/ed80514659855a22b1e398af7acf66c68000c2d9/Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs#L352-L352","created_at":"2016-04-29T14:05:27Z","updated_at":"2016-04-29T14:05:27Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/153#discussion_r61582381","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/61582381"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/153#discussion_r61582381"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153","id":68325237,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/153","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/153.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/153.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/153","number":153,"state":"open","locked":false,"title":"Fix Bug 39486","user":{"login":"scastria","id":4534494,"avatar_url":"https://avatars.githubusercontent.com/u/4534494?v=3","gravatar_id":"","url":"https://api.github.com/users/scastria","html_url":"https://github.com/scastria","followers_url":"https://api.github.com/users/scastria/followers","following_url":"https://api.github.com/users/scastria/following{/other_user}","gists_url":"https://api.github.com/users/scastria/gists{/gist_id}","starred_url":"https://api.github.com/users/scastria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scastria/subscriptions","organizations_url":"https://api.github.com/users/scastria/orgs","repos_url":"https://api.github.com/users/scastria/repos","events_url":"https://api.github.com/users/scastria/events{/privacy}","received_events_url":"https://api.github.com/users/scastria/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nCopied some row height code from ListViewRenderer into TableViewRenderer.  Verified it works with sample test project provided in bug report.\r\n\r\n### Bugs Fixed ###\r\n\r\nhttps://bugzilla.xamarin.com/show_bug.cgi?id=39486\r\n\r\n### API Changes ###\r\n\r\nNone\r\n\r\n### Behavioral Changes ###\r\n\r\nNone\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [ ] Rebased on top of master at time of PR\r\n- [ ] Changes adhere to coding standard\r\n- [ ] Consolidate commits as makes sense\r\n\r\n","created_at":"2016-04-29T05:06:23Z","updated_at":"2016-04-29T14:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a0754b7514fec9a6089796f25c9aa0f812a2cdb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/153/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/a9541818086086357268691d65e61180e65c2156","head":{"label":"scastria:master","ref":"master","sha":"a9541818086086357268691d65e61180e65c2156","user":{"login":"scastria","id":4534494,"avatar_url":"https://avatars.githubusercontent.com/u/4534494?v=3","gravatar_id":"","url":"https://api.github.com/users/scastria","html_url":"https://github.com/scastria","followers_url":"https://api.github.com/users/scastria/followers","following_url":"https://api.github.com/users/scastria/following{/other_user}","gists_url":"https://api.github.com/users/scastria/gists{/gist_id}","starred_url":"https://api.github.com/users/scastria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scastria/subscriptions","organizations_url":"https://api.github.com/users/scastria/orgs","repos_url":"https://api.github.com/users/scastria/repos","events_url":"https://api.github.com/users/scastria/events{/privacy}","received_events_url":"https://api.github.com/users/scastria/received_events","type":"User","site_admin":false},"repo":{"id":57355432,"name":"Xamarin.Forms","full_name":"scastria/Xamarin.Forms","owner":{"login":"scastria","id":4534494,"avatar_url":"https://avatars.githubusercontent.com/u/4534494?v=3","gravatar_id":"","url":"https://api.github.com/users/scastria","html_url":"https://github.com/scastria","followers_url":"https://api.github.com/users/scastria/followers","following_url":"https://api.github.com/users/scastria/following{/other_user}","gists_url":"https://api.github.com/users/scastria/gists{/gist_id}","starred_url":"https://api.github.com/users/scastria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scastria/subscriptions","organizations_url":"https://api.github.com/users/scastria/orgs","repos_url":"https://api.github.com/users/scastria/repos","events_url":"https://api.github.com/users/scastria/events{/privacy}","received_events_url":"https://api.github.com/users/scastria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scastria/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/scastria/Xamarin.Forms","forks_url":"https://api.github.com/repos/scastria/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/scastria/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scastria/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scastria/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/scastria/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/scastria/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/scastria/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/scastria/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/scastria/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/scastria/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/scastria/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scastria/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scastria/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/scastria/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scastria/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/scastria/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/scastria/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/scastria/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/scastria/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/scastria/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/scastria/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/scastria/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/scastria/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/scastria/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/scastria/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/scastria/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scastria/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/scastria/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scastria/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/scastria/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/scastria/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/scastria/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/scastria/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scastria/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/scastria/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/scastria/Xamarin.Forms/deployments","created_at":"2016-04-29T04:50:35Z","updated_at":"2016-04-29T04:50:39Z","pushed_at":"2016-04-29T05:04:11Z","git_url":"git://github.com/scastria/Xamarin.Forms.git","ssh_url":"git@github.com:scastria/Xamarin.Forms.git","clone_url":"https://github.com/scastria/Xamarin.Forms.git","svn_url":"https://github.com/scastria/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":12695,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"ed80514659855a22b1e398af7acf66c68000c2d9","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-04-29T13:59:14Z","pushed_at":"2016-04-29T05:06:23Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":22679,"stargazers_count":449,"watchers_count":449,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":12,"forks":70,"open_issues":12,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/153"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/153"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/a9541818086086357268691d65e61180e65c2156"}}}}