{"action":"closed","number":2234,"pull_request":{"url":"https://api.github.com/repos/aws/aws-cli/pulls/2234","id":89451531,"html_url":"https://github.com/aws/aws-cli/pull/2234","diff_url":"https://github.com/aws/aws-cli/pull/2234.diff","patch_url":"https://github.com/aws/aws-cli/pull/2234.patch","issue_url":"https://api.github.com/repos/aws/aws-cli/issues/2234","number":2234,"state":"closed","locked":false,"title":"Enable local file deletes from fileinfos","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"body":"This is specifically done for sync --delete downloads. The\r\nimplementation is a bit quirky because the functionality is needed\r\nfor the CLI but does not really belong in s3transfer. Essentially\r\nwhat happens if a local delete is seen, the CLI will submit the\r\ntransfer request and immediately delete the file in the main thread\r\nas a part of the submission. While it is not ideal to be\r\ndoing that in the main thread because it will slow down the process,\r\nit is acceptable as deleting a local file is pretty quick.\r\n\r\nFixes https://github.com/aws/aws-cli/issues/2233\r\n\r\ncc @jamesls @JordonPhillips  ","created_at":"2016-10-14T20:43:24Z","updated_at":"2016-10-14T22:11:00Z","closed_at":"2016-10-14T22:11:00Z","merged_at":"2016-10-14T22:11:00Z","merge_commit_sha":"9ba47674228c69bf0a2aa52ab25a965623ed8772","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-cli/pulls/2234/commits","review_comments_url":"https://api.github.com/repos/aws/aws-cli/pulls/2234/comments","review_comment_url":"https://api.github.com/repos/aws/aws-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-cli/issues/2234/comments","statuses_url":"https://api.github.com/repos/aws/aws-cli/statuses/d3241012c8a05ed1ebc30234e3cc2d63c6f2b32a","head":{"label":"kyleknap:fix-local-deletes-v2","ref":"fix-local-deletes-v2","sha":"d3241012c8a05ed1ebc30234e3cc2d63c6f2b32a","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"repo":{"id":12092925,"name":"aws-cli","full_name":"kyleknap/aws-cli","owner":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyleknap/aws-cli","description":"Universal Command Line Interface for Amazon Web Services","fork":true,"url":"https://api.github.com/repos/kyleknap/aws-cli","forks_url":"https://api.github.com/repos/kyleknap/aws-cli/forks","keys_url":"https://api.github.com/repos/kyleknap/aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyleknap/aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyleknap/aws-cli/teams","hooks_url":"https://api.github.com/repos/kyleknap/aws-cli/hooks","issue_events_url":"https://api.github.com/repos/kyleknap/aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/kyleknap/aws-cli/events","assignees_url":"https://api.github.com/repos/kyleknap/aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/kyleknap/aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/kyleknap/aws-cli/tags","blobs_url":"https://api.github.com/repos/kyleknap/aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyleknap/aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyleknap/aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyleknap/aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyleknap/aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/kyleknap/aws-cli/languages","stargazers_url":"https://api.github.com/repos/kyleknap/aws-cli/stargazers","contributors_url":"https://api.github.com/repos/kyleknap/aws-cli/contributors","subscribers_url":"https://api.github.com/repos/kyleknap/aws-cli/subscribers","subscription_url":"https://api.github.com/repos/kyleknap/aws-cli/subscription","commits_url":"https://api.github.com/repos/kyleknap/aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyleknap/aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyleknap/aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyleknap/aws-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyleknap/aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/kyleknap/aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyleknap/aws-cli/merges","archive_url":"https://api.github.com/repos/kyleknap/aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyleknap/aws-cli/downloads","issues_url":"https://api.github.com/repos/kyleknap/aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/kyleknap/aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/kyleknap/aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/kyleknap/aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyleknap/aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/kyleknap/aws-cli/releases{/id}","deployments_url":"https://api.github.com/repos/kyleknap/aws-cli/deployments","created_at":"2013-08-13T21:03:11Z","updated_at":"2014-07-28T21:42:02Z","pushed_at":"2016-10-14T20:59:21Z","git_url":"git://github.com/kyleknap/aws-cli.git","ssh_url":"git@github.com:kyleknap/aws-cli.git","clone_url":"https://github.com/kyleknap/aws-cli.git","svn_url":"https://github.com/kyleknap/aws-cli","homepage":null,"size":9267,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"aws:develop","ref":"develop","sha":"dc94ab87591d07b150ab0d4c5a4083659ea434ee","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":6780767,"name":"aws-cli","full_name":"aws/aws-cli","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-cli","description":"Universal Command Line Interface for Amazon Web Services","fork":false,"url":"https://api.github.com/repos/aws/aws-cli","forks_url":"https://api.github.com/repos/aws/aws-cli/forks","keys_url":"https://api.github.com/repos/aws/aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-cli/teams","hooks_url":"https://api.github.com/repos/aws/aws-cli/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-cli/events","assignees_url":"https://api.github.com/repos/aws/aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-cli/tags","blobs_url":"https://api.github.com/repos/aws/aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-cli/languages","stargazers_url":"https://api.github.com/repos/aws/aws-cli/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-cli/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-cli/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-cli/subscription","commits_url":"https://api.github.com/repos/aws/aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-cli/merges","archive_url":"https://api.github.com/repos/aws/aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-cli/downloads","issues_url":"https://api.github.com/repos/aws/aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-cli/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-cli/deployments","created_at":"2012-11-20T16:07:36Z","updated_at":"2016-10-14T21:19:28Z","pushed_at":"2016-10-14T22:11:00Z","git_url":"git://github.com/aws/aws-cli.git","ssh_url":"git@github.com:aws/aws-cli.git","clone_url":"https://github.com/aws/aws-cli.git","svn_url":"https://github.com/aws/aws-cli","homepage":null,"size":13010,"stargazers_count":4237,"watchers_count":4237,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":670,"mirror_url":null,"open_issues_count":171,"forks":670,"open_issues":171,"watchers":4237,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/2234"},"html":{"href":"https://github.com/aws/aws-cli/pull/2234"},"issue":{"href":"https://api.github.com/repos/aws/aws-cli/issues/2234"},"comments":{"href":"https://api.github.com/repos/aws/aws-cli/issues/2234/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/2234/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-cli/pulls/2234/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-cli/statuses/d3241012c8a05ed1ebc30234e3cc2d63c6f2b32a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":217,"deletions":6,"changed_files":5}}
{"actor":{"display_login":"kyleknap"}}