{"action":"created","comment":{"url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/comments/65992105","id":65992105,"diff_hunk":"@@ -8,11 +8,11 @@ Benchmarks for Rust crypto libraries\n \n |                                              |       *ring*       |       Octavo       |     rust-crypto    | rust-nettle (Nettle) | rust-openssl (OpenSSL) | sodiumoxide (libsodium) | Windows CNG | Mac/iOS Common Crypto |\n |----------------------------------------------|:------------------:|:------------------:|:------------------:|----------------------|:----------------------:|:-----------------------:|:-----------:|:---------------------:|\n-| SHA&#x2011;1 & SHA&#x2011;2                  | :white_check_mark: | :white_check_mark: | :white_check_mark: |                      | :white_check_mark:     |                         |             |                       |\n+| SHA&#x2011;1 & SHA&#x2011;2                  | :white_check_mark: | :white_check_mark: | :white_check_mark: |                      | :white_check_mark:     | SHA-256/512 only        |             |                       |","path":"README.md","position":5,"original_position":5,"commit_id":"aa54f387fd2312473071105836d2155634445e5e","original_commit_id":"aa54f387fd2312473071105836d2155634445e5e","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"body":"Please write this as \"SHA-{256, 512}\" only. The notation like SHA-512/256 refers to something else (truncated hashes).","created_at":"2016-06-07T00:16:59Z","updated_at":"2016-06-07T00:16:59Z","html_url":"https://github.com/briansmith/crypto-bench/pull/18#discussion_r65992105","pull_request_url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/comments/65992105"},"html":{"href":"https://github.com/briansmith/crypto-bench/pull/18#discussion_r65992105"},"pull_request":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18","id":72652407,"html_url":"https://github.com/briansmith/crypto-bench/pull/18","diff_url":"https://github.com/briansmith/crypto-bench/pull/18.diff","patch_url":"https://github.com/briansmith/crypto-bench/pull/18.patch","issue_url":"https://api.github.com/repos/briansmith/crypto-bench/issues/18","number":18,"state":"open","locked":false,"title":"Added SHA-256/512 and salsa20-poly1305 benches for sodiumoxide.","user":{"login":"JohnHeitmann","id":4282480,"avatar_url":"https://avatars.githubusercontent.com/u/4282480?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnHeitmann","html_url":"https://github.com/JohnHeitmann","followers_url":"https://api.github.com/users/JohnHeitmann/followers","following_url":"https://api.github.com/users/JohnHeitmann/following{/other_user}","gists_url":"https://api.github.com/users/JohnHeitmann/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnHeitmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnHeitmann/subscriptions","organizations_url":"https://api.github.com/users/JohnHeitmann/orgs","repos_url":"https://api.github.com/users/JohnHeitmann/repos","events_url":"https://api.github.com/users/JohnHeitmann/events{/privacy}","received_events_url":"https://api.github.com/users/JohnHeitmann/received_events","type":"User","site_admin":false},"body":"sodiumoxide doesn't support additional data, nor does it support AES-GCM. I don't see a reason for these gaps other than lack of interest. I'll take a crack at at least AES-GCM since that seems broadly useful outside of benchmarking. If you think the missing additional data support is hurting the benchmark comparison I'd be happy to take a crack at that too.\r\n\r\nring beats sodiumoxide by ~2x on SHA-512 on my laptop (Haswell i7 MacBook Pro).\r\n\r\nPartially fixes #13 ","created_at":"2016-06-06T03:28:36Z","updated_at":"2016-06-07T00:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4c428848c22c2a9c2537997f72175228626a351","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18/commits","review_comments_url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18/comments","review_comment_url":"https://api.github.com/repos/briansmith/crypto-bench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briansmith/crypto-bench/issues/18/comments","statuses_url":"https://api.github.com/repos/briansmith/crypto-bench/statuses/aa54f387fd2312473071105836d2155634445e5e","head":{"label":"JohnHeitmann:sodiumoxide","ref":"sodiumoxide","sha":"aa54f387fd2312473071105836d2155634445e5e","user":{"login":"JohnHeitmann","id":4282480,"avatar_url":"https://avatars.githubusercontent.com/u/4282480?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnHeitmann","html_url":"https://github.com/JohnHeitmann","followers_url":"https://api.github.com/users/JohnHeitmann/followers","following_url":"https://api.github.com/users/JohnHeitmann/following{/other_user}","gists_url":"https://api.github.com/users/JohnHeitmann/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnHeitmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnHeitmann/subscriptions","organizations_url":"https://api.github.com/users/JohnHeitmann/orgs","repos_url":"https://api.github.com/users/JohnHeitmann/repos","events_url":"https://api.github.com/users/JohnHeitmann/events{/privacy}","received_events_url":"https://api.github.com/users/JohnHeitmann/received_events","type":"User","site_admin":false},"repo":{"id":60445368,"name":"crypto-bench","full_name":"JohnHeitmann/crypto-bench","owner":{"login":"JohnHeitmann","id":4282480,"avatar_url":"https://avatars.githubusercontent.com/u/4282480?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnHeitmann","html_url":"https://github.com/JohnHeitmann","followers_url":"https://api.github.com/users/JohnHeitmann/followers","following_url":"https://api.github.com/users/JohnHeitmann/following{/other_user}","gists_url":"https://api.github.com/users/JohnHeitmann/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnHeitmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnHeitmann/subscriptions","organizations_url":"https://api.github.com/users/JohnHeitmann/orgs","repos_url":"https://api.github.com/users/JohnHeitmann/repos","events_url":"https://api.github.com/users/JohnHeitmann/events{/privacy}","received_events_url":"https://api.github.com/users/JohnHeitmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnHeitmann/crypto-bench","description":"Benchmarks for Rust crypto libraries","fork":true,"url":"https://api.github.com/repos/JohnHeitmann/crypto-bench","forks_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/forks","keys_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/teams","hooks_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/hooks","issue_events_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/issues/events{/number}","events_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/events","assignees_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/assignees{/user}","branches_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/branches{/branch}","tags_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/tags","blobs_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/languages","stargazers_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/stargazers","contributors_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/contributors","subscribers_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/subscribers","subscription_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/subscription","commits_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/contents/{+path}","compare_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/merges","archive_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/downloads","issues_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/issues{/number}","pulls_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/labels{/name}","releases_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/releases{/id}","deployments_url":"https://api.github.com/repos/JohnHeitmann/crypto-bench/deployments","created_at":"2016-06-05T05:50:16Z","updated_at":"2016-06-05T05:50:17Z","pushed_at":"2016-06-06T06:32:51Z","git_url":"git://github.com/JohnHeitmann/crypto-bench.git","ssh_url":"git@github.com:JohnHeitmann/crypto-bench.git","clone_url":"https://github.com/JohnHeitmann/crypto-bench.git","svn_url":"https://github.com/JohnHeitmann/crypto-bench","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briansmith:master","ref":"master","sha":"f371c43165b84af50ed15ae451b45c8f0970f589","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":44953050,"name":"crypto-bench","full_name":"briansmith/crypto-bench","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/crypto-bench","description":"Benchmarks for crypto libraries (in Rust, or with Rust bindings)","fork":false,"url":"https://api.github.com/repos/briansmith/crypto-bench","forks_url":"https://api.github.com/repos/briansmith/crypto-bench/forks","keys_url":"https://api.github.com/repos/briansmith/crypto-bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/crypto-bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/crypto-bench/teams","hooks_url":"https://api.github.com/repos/briansmith/crypto-bench/hooks","issue_events_url":"https://api.github.com/repos/briansmith/crypto-bench/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/crypto-bench/events","assignees_url":"https://api.github.com/repos/briansmith/crypto-bench/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/crypto-bench/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/crypto-bench/tags","blobs_url":"https://api.github.com/repos/briansmith/crypto-bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/crypto-bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/crypto-bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/crypto-bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/crypto-bench/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/crypto-bench/languages","stargazers_url":"https://api.github.com/repos/briansmith/crypto-bench/stargazers","contributors_url":"https://api.github.com/repos/briansmith/crypto-bench/contributors","subscribers_url":"https://api.github.com/repos/briansmith/crypto-bench/subscribers","subscription_url":"https://api.github.com/repos/briansmith/crypto-bench/subscription","commits_url":"https://api.github.com/repos/briansmith/crypto-bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/crypto-bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/crypto-bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/crypto-bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/crypto-bench/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/crypto-bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/crypto-bench/merges","archive_url":"https://api.github.com/repos/briansmith/crypto-bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/crypto-bench/downloads","issues_url":"https://api.github.com/repos/briansmith/crypto-bench/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/crypto-bench/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/crypto-bench/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/crypto-bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/crypto-bench/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/crypto-bench/releases{/id}","deployments_url":"https://api.github.com/repos/briansmith/crypto-bench/deployments","created_at":"2015-10-26T07:38:07Z","updated_at":"2016-06-06T20:52:30Z","pushed_at":"2016-06-06T06:32:51Z","git_url":"git://github.com/briansmith/crypto-bench.git","ssh_url":"git@github.com:briansmith/crypto-bench.git","clone_url":"https://github.com/briansmith/crypto-bench.git","svn_url":"https://github.com/briansmith/crypto-bench","homepage":"","size":32,"stargazers_count":8,"watchers_count":8,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18"},"html":{"href":"https://github.com/briansmith/crypto-bench/pull/18"},"issue":{"href":"https://api.github.com/repos/briansmith/crypto-bench/issues/18"},"comments":{"href":"https://api.github.com/repos/briansmith/crypto-bench/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briansmith/crypto-bench/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/briansmith/crypto-bench/statuses/aa54f387fd2312473071105836d2155634445e5e"}}}}
{"actor":{"display_login":"briansmith"}}