{"action":"created","issue":{"url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/139","repository_url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet","labels_url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/139/comments","events_url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/139/events","html_url":"https://github.com/cyberjunk/meridian59-dotnet/pull/139","id":157175170,"number":139,"title":"Hash rsb file on login, send hash to server.","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-05-27T10:19:06Z","updated_at":"2016-05-29T17:12:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/pulls/139","html_url":"https://github.com/cyberjunk/meridian59-dotnet/pull/139","diff_url":"https://github.com/cyberjunk/meridian59-dotnet/pull/139.diff","patch_url":"https://github.com/cyberjunk/meridian59-dotnet/pull/139.patch"},"body":"The rsb file is hashed on loading and the hash sent to the server during login. The server will trigger a client update if the rsb hash does not match the server's loaded one.\r\n\r\nThis is the .NET implementation of https://github.com/OpenMeridian105/Meridian59/pull/172. If this approach is correct I'd probably move the file hash function to Util.cs in case we need it elsewhere."},"comment":{"url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/comments/222371544","html_url":"https://github.com/cyberjunk/meridian59-dotnet/pull/139#issuecomment-222371544","issue_url":"https://api.github.com/repos/cyberjunk/meridian59-dotnet/issues/139","id":222371544,"user":{"login":"cyberjunk","id":780159,"avatar_url":"https://avatars.githubusercontent.com/u/780159?v=3","gravatar_id":"","url":"https://api.github.com/users/cyberjunk","html_url":"https://github.com/cyberjunk","followers_url":"https://api.github.com/users/cyberjunk/followers","following_url":"https://api.github.com/users/cyberjunk/following{/other_user}","gists_url":"https://api.github.com/users/cyberjunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberjunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberjunk/subscriptions","organizations_url":"https://api.github.com/users/cyberjunk/orgs","repos_url":"https://api.github.com/users/cyberjunk/repos","events_url":"https://api.github.com/users/cyberjunk/events{/privacy}","received_events_url":"https://api.github.com/users/cyberjunk/received_events","type":"User","site_admin":false},"created_at":"2016-05-29T17:12:09Z","updated_at":"2016-05-29T17:12:09Z","body":">> OK moved the function, but still have it returning byte[] rather than Hash128Bit. Should I have the RsbHash as Hash128Bit in ResourceManager and transfer it that way to LoginMessage...\r\n\r\nI think having the functions return the Hash128Bit struct instead of byte[] would probably be a bit cleaner, but I dunno what more changes it would cause at other places and it's technically not part of this pull/your job (unless you want to). It looks fine to me so far, so I can merge, until you want to add anything...."}}
{"actor":{"display_login":"cyberjunk"}}