{"action":"created","issue":{"url":"https://api.github.com/repos/gnachman/iTerm2/issues/292","repository_url":"https://api.github.com/repos/gnachman/iTerm2","labels_url":"https://api.github.com/repos/gnachman/iTerm2/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/gnachman/iTerm2/issues/292/comments","events_url":"https://api.github.com/repos/gnachman/iTerm2/issues/292/events","html_url":"https://github.com/gnachman/iTerm2/pull/292","id":159873084,"number":292,"title":"Adding a new color preference setting that defines a custom color for underlining.","user":{"login":"rsmmr","id":1934232,"avatar_url":"https://avatars.githubusercontent.com/u/1934232?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmmr","html_url":"https://github.com/rsmmr","followers_url":"https://api.github.com/users/rsmmr/followers","following_url":"https://api.github.com/users/rsmmr/following{/other_user}","gists_url":"https://api.github.com/users/rsmmr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmmr/subscriptions","organizations_url":"https://api.github.com/users/rsmmr/orgs","repos_url":"https://api.github.com/users/rsmmr/repos","events_url":"https://api.github.com/users/rsmmr/events{/privacy}","received_events_url":"https://api.github.com/users/rsmmr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-13T04:53:29Z","updated_at":"2016-06-15T23:20:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gnachman/iTerm2/pulls/292","html_url":"https://github.com/gnachman/iTerm2/pull/292","diff_url":"https://github.com/gnachman/iTerm2/pull/292.diff","patch_url":"https://github.com/gnachman/iTerm2/pull/292.patch"},"body":"This is on top of the v3.1 branch. I believe I have followed most of the instructions in #286, except for two things:\r\n\r\n- I had to modify `[self.colorMap colorForKey:kColorMapUnderline]` to account for the fact that we now expect it to return nil in this case. It would normally have returned a hardcoded red. Not so nice, maybe I'm missing something?\r\n\r\n- I only added 1 one of the 3 test images, the non-retina version, as that's what I'm working on here. Not sure if/how I can create a retina version on a non-retina system? Also, I wasn't sure what exactly \"run the test suite in Travis\" means, so I left that part out. I would appreciate if you could add the missing images for testing when merging.\r\n\r\nPlease have a look. Feel free to send back to me if there's more to do."},"comment":{"url":"https://api.github.com/repos/gnachman/iTerm2/issues/comments/226348025","html_url":"https://github.com/gnachman/iTerm2/pull/292#issuecomment-226348025","issue_url":"https://api.github.com/repos/gnachman/iTerm2/issues/292","id":226348025,"user":{"login":"rsmmr","id":1934232,"avatar_url":"https://avatars.githubusercontent.com/u/1934232?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmmr","html_url":"https://github.com/rsmmr","followers_url":"https://api.github.com/users/rsmmr/followers","following_url":"https://api.github.com/users/rsmmr/following{/other_user}","gists_url":"https://api.github.com/users/rsmmr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmmr/subscriptions","organizations_url":"https://api.github.com/users/rsmmr/orgs","repos_url":"https://api.github.com/users/rsmmr/repos","events_url":"https://api.github.com/users/rsmmr/events{/privacy}","received_events_url":"https://api.github.com/users/rsmmr/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T23:20:22Z","updated_at":"2016-06-15T23:20:22Z","body":"Thanks for merging and the feedback, and more generally for all your great work on iTerm2!"}}
{"actor":{"display_login":"rsmmr"}}