{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6673","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6673/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6673/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6673/events","html_url":"https://github.com/playframework/playframework/pull/6673","id":185564273,"number":6673,"title":"Use the Akka ExecutionContext to execute actions","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-27T03:21:42Z","updated_at":"2016-10-27T07:18:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6673","html_url":"https://github.com/playframework/playframework/pull/6673","diff_url":"https://github.com/playframework/playframework/pull/6673.diff","patch_url":"https://github.com/playframework/playframework/pull/6673.patch"},"body":"This makes sure the Netty server always uses Akka's ExecutionContext to execute actions (like we did in 2.4.x), rather than using the Netty thread.\r\n\r\n/cc @jroper "},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/256565619","html_url":"https://github.com/playframework/playframework/pull/6673#issuecomment-256565619","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6673","id":256565619,"user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T07:18:21Z","updated_at":"2016-10-27T07:18:21Z","body":"Shouldn't we add a test where we create a EssentialAction/EssentialFilter:\r\n```scala\r\n  def index = EssentialAction { rh =>\r\n    Accumulator.done(Ok(Thread.currentThread().getName))\r\n  }\r\n```\r\nwhile before it was `netty-event-loop-NUMBER` and now it will be `application-akka.actor.default-dispatcher-NUMBER`?\r\n\r\nAnd another question might also remain, if we change the `ExecutionContext` to Trampoline inside the `Action`/`Filter` Code, since I guess else it will switch Threads more than necessary?"}}
{"actor":{"display_login":"schmitch"}}