{"action":"created","issue":{"url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/79","repository_url":"https://api.github.com/repos/RetroPie/EmulationStation","labels_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/79/comments","events_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/79/events","html_url":"https://github.com/RetroPie/EmulationStation/issues/79","id":196583110,"number":79,"title":"crash on exit when save meta data on exit enabled ","user":{"login":"joolswills","id":5365574,"avatar_url":"https://avatars.githubusercontent.com/u/5365574?v=3","gravatar_id":"","url":"https://api.github.com/users/joolswills","html_url":"https://github.com/joolswills","followers_url":"https://api.github.com/users/joolswills/followers","following_url":"https://api.github.com/users/joolswills/following{/other_user}","gists_url":"https://api.github.com/users/joolswills/gists{/gist_id}","starred_url":"https://api.github.com/users/joolswills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joolswills/subscriptions","organizations_url":"https://api.github.com/users/joolswills/orgs","repos_url":"https://api.github.com/users/joolswills/repos","events_url":"https://api.github.com/users/joolswills/events{/privacy}","received_events_url":"https://api.github.com/users/joolswills/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-20T04:20:31Z","updated_at":"2016-12-20T04:37:05Z","closed_at":null,"body":"```\r\nterminate called after throwing an instance of 'std::out_of_range'\r\n  what():  map::at\r\n```\r\n\r\nbisect to\r\n\r\n```\r\n25e1067794760523a331c07c1c0b23922b9644f2 is the first bad commit\r\ncommit 25e1067794760523a331c07c1c0b23922b9644f2\r\nAuthor: fieldofcows <roy.hopkins@fieldofcows.com>\r\nDate:   Sun Dec 4 23:47:34 2016 +0000\r\n\r\n    Add video view that is based on detail view but allows themes to include a video preview of the selected game along with a marquee image\r\n\r\n:040000 040000 870543f5a291747436d97568977eb49d3241f6f8 5cfc9f879987eee2abf93357a847b9a2320df11d M\tCMake\r\n:100644 100644 784c2d0ac08327fb8a265a3d84e92a98e56e4516 48143a5230cf524c4ed06b5d8184cdca1e705bcd M\tCMakeLists.txt\r\n:100644 100644 ff02eae137f179a4e9dec892dc0f7f7780d307b4 1113c6d03f16d76b0a228abdb951f3f290e7cce9 M\tREADME.md\r\n:040000 040000 1f0a7355f01547cf2c2f1de4df1e031f8703b1ee 2ec7a288490bb57bf7f337db1648e89d5e743440 M\tes-app\r\n:040000 040000 2d1cbd2e9cc080603d42f7d790b4e178947e87e9 859ab29850438176f497f0047a28b8902c9226b0 M\tes-core\r\n```\r\n\r\n@fieldofcows unfortunately the video view has broken saving meta data on exit. I will rebuild ES binaries from an older version for now."},"comment":{"url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/comments/268152969","html_url":"https://github.com/RetroPie/EmulationStation/issues/79#issuecomment-268152969","issue_url":"https://api.github.com/repos/RetroPie/EmulationStation/issues/79","id":268152969,"user":{"login":"joolswills","id":5365574,"avatar_url":"https://avatars.githubusercontent.com/u/5365574?v=3","gravatar_id":"","url":"https://api.github.com/users/joolswills","html_url":"https://github.com/joolswills","followers_url":"https://api.github.com/users/joolswills/followers","following_url":"https://api.github.com/users/joolswills/following{/other_user}","gists_url":"https://api.github.com/users/joolswills/gists{/gist_id}","starred_url":"https://api.github.com/users/joolswills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joolswills/subscriptions","organizations_url":"https://api.github.com/users/joolswills/orgs","repos_url":"https://api.github.com/users/joolswills/repos","events_url":"https://api.github.com/users/joolswills/events{/privacy}","received_events_url":"https://api.github.com/users/joolswills/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T04:37:05Z","updated_at":"2016-12-20T04:37:05Z","body":"this fixes it for me - but I've not dug to see why the order matters and it might break your video functionality. \r\n\r\n```diff\r\ndiff --git a/es-app/src/MetaData.cpp b/es-app/src/MetaData.cpp\r\nindex 3f5da45..d592ac6 100644\r\n--- a/es-app/src/MetaData.cpp\r\n+++ b/es-app/src/MetaData.cpp\r\n@@ -10,8 +10,6 @@ MetaDataDecl gameDecls[] = {\r\n \t{\"name\",\t\tMD_STRING,\t\t\t\t\"\", \t\t\t\tfalse,\t\t\"name\",\t\t\t\t\t\"enter game name\"}, \r\n \t{\"desc\",\t\tMD_MULTILINE_STRING,\t\"\", \t\t\t\tfalse,\t\t\"description\",\t\t\t\"enter description\"},\r\n \t{\"image\",\t\tMD_PATH,\t\t\t\t\"\", \t\t\t\tfalse,\t\t\"image\",\t\t\t\t\"enter path to image\"},\r\n-\t{\"video\",\t\tMD_PATH\t\t,\t\t\t\"\", \t\t\t\tfalse,\t\t\"video\",\t\t\t\t\"enter path to video\"},\r\n-\t{\"marquee\",\t\tMD_PATH,\t\t\t\t\"\", \t\t\t\tfalse,\t\t\"marquee\",\t\t\t\t\"enter path to marquee\"},\r\n \t{\"thumbnail\",\tMD_PATH,\t\t\t\t\"\", \t\t\t\tfalse,\t\t\"thumbnail\",\t\t\t\"enter path to thumbnail\"},\r\n \t{\"rating\",\t\tMD_RATING,\t\t\t\t\"0.000000\", \t\tfalse,\t\t\"rating\",\t\t\t\t\"enter rating\"},\r\n \t{\"releasedate\", MD_DATE,\t\t\t\t\"not-a-date-time\", \tfalse,\t\t\"release date\",\t\t\t\"enter release date\"},\r\n@@ -20,7 +18,9 @@ MetaDataDecl gameDecls[] = {\r\n \t{\"genre\",\t\tMD_STRING,\t\t\t\t\"unknown\",\t\t\tfalse,\t\t\"genre\",\t\t\t\t\"enter game genre\"},\r\n \t{\"players\",\t\tMD_INT,\t\t\t\t\t\"1\",\t\t\t\tfalse,\t\t\"players\",\t\t\t\t\"enter number of players\"},\r\n \t{\"playcount\",\tMD_INT,\t\t\t\t\t\"0\",\t\t\t\ttrue,\t\t\"play count\",\t\t\t\"enter number of times played\"},\r\n-\t{\"lastplayed\",\tMD_TIME,\t\t\t\t\"0\", \t\t\t\ttrue,\t\t\"last played\",\t\t\t\"enter last played date\"}\r\n+\t{\"lastplayed\",\tMD_TIME,\t\t\t\t\"0\", \t\t\t\ttrue,\t\t\"last played\",\t\t\t\"enter last played date\"},\r\n+\t{\"video\",\t\tMD_PATH\t\t,\t\t\t\"\", \t\t\t\tfalse,\t\t\"video\",\t\t\t\t\"enter path to video\"},\r\n+\t{\"marquee\",\t\tMD_PATH,\t\t\t\t\"\", \t\t\t\tfalse,\t\t\"marquee\",\t\t\t\t\"enter path to marquee\"},\r\n };\r\n const std::vector<MetaDataDecl> gameMDD(gameDecls, gameDecls + sizeof(gameDecls) / sizeof(gameDecls[0]));\r\n \r\n```"}}
{"actor":{"display_login":"joolswills"}}