{"push_id":1216247482,"size":2,"distinct_size":2,"ref":"refs/heads/develop","head":"365fca3c60d85287488ed055487642592284b5f4","before":"bdafa60e6a9cd13adf0ada803ed8fde8a81fae3e","commits":[{"sha":"950cf79cd461a81af43b577b0d23658940ad33d4","author":{"name":"Sergey Kizunov","email":"fbccf01ea82b7316c550c2a120acdd27bebf5a30@ni.com"},"message":"Fix console and file logging on Windows\n\nOn Windows, only the main process properly logged to console and to\nfile. Things worked on other OSes due to the logging configuration\nbeing propogated via fork, something that won't work on Windows.\n\nThe new strategy for Windows is if multiprocessing mode is used,\nall console and file logging will be performed through the\nMultiprocessing Logging Listener except for the main process. The\nmain process does not send stuff to the Multiprocessing Logging Listener.\nHence the main process will still configure file and console logging\nseparately from the MP Logging Listener.\nIf multiprocessing mode is off, then logging will be done as before\n(which should be ok since there is only one process).\n\nsalt/utils/parsers.py:\n- Broke apart the logic that figures out the input options for\n`log.setup_logfile_logger` and `log.setup_console_logger`. This\nfunctionality is run before `self._setup_mp_logging_listener` so that\nthe options passed to the MP Logging Listener are appropriate for direct\nuse in the functions that setup the console and file logging in the\nMP Logging Listener process.\n- Moved the logic that verifies the path for the log file from\n`cli/daemons.py` to be able to run it before creating the MP Logging\nListener. Its original place in `cli/daemons.py` would run after the\nMP Logging Listener is created.\n\nsalt/log/setup.py:\n- Invoke `setup_console_logger` and `setup_logfile_logger` using the\nappropriate options if running on Windows.\n\nsalt/minion.py:\n- No longer need to invoke the functions to setup the console and file\nlogging on Windows multiprocessing mode due to the MP Logging\nListener taking care of that on Windows.\n\nsalt/cli/daemons.py:\n- Moved the logic that verifies the path for the log file to\n`utils/parsers.py`.\n\nSigned-off-by: Sergey Kizunov <sergey.kizunov@ni.com>","distinct":true,"url":"https://api.github.com/repos/saltstack/salt/commits/950cf79cd461a81af43b577b0d23658940ad33d4"},{"sha":"365fca3c60d85287488ed055487642592284b5f4","author":{"name":"Mike Place","email":"7166a69f428d22083b94cdce0f06f296964810e1@saltstack.com"},"message":"Merge pull request #34895 from skizunov/develop2\n\nFix console and file logging on Windows","distinct":true,"url":"https://api.github.com/repos/saltstack/salt/commits/365fca3c60d85287488ed055487642592284b5f4"}]}
{"actor":{"display_login":"cachedout"}}