{"action":"closed","number":2408,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/2408","id":95129295,"html_url":"https://github.com/zulip/zulip/pull/2408","diff_url":"https://github.com/zulip/zulip/pull/2408.diff","patch_url":"https://github.com/zulip/zulip/pull/2408.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/2408","number":2408,"state":"closed","locked":false,"title":"Switch no-loop-func eslint rule from warning to error (in .eslintrc)","user":{"login":"arpith","id":62899,"avatar_url":"https://avatars.githubusercontent.com/u/62899?v=3","gravatar_id":"","url":"https://api.github.com/users/arpith","html_url":"https://github.com/arpith","followers_url":"https://api.github.com/users/arpith/followers","following_url":"https://api.github.com/users/arpith/following{/other_user}","gists_url":"https://api.github.com/users/arpith/gists{/gist_id}","starred_url":"https://api.github.com/users/arpith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpith/subscriptions","organizations_url":"https://api.github.com/users/arpith/orgs","repos_url":"https://api.github.com/users/arpith/repos","events_url":"https://api.github.com/users/arpith/events{/privacy}","received_events_url":"https://api.github.com/users/arpith/received_events","type":"User","site_admin":false},"body":"The one error that needed to be fixed was in static/js/echo.js.\r\nThe function in the loop was being used by _.each(). This has been\r\nreplaced by iterating through the array using a while loop instead.","created_at":"2016-11-24T07:35:02Z","updated_at":"2016-11-25T22:03:01Z","closed_at":"2016-11-25T22:03:01Z","merged_at":null,"merge_commit_sha":"9bbe43cf23a1985063eface6292f2d20927686bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/2408/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/2408/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/2408/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/83c641f7cc866307bfd46aaac5e1453b179e8659","head":{"label":"arpith:eslint-no-loop-func","ref":"eslint-no-loop-func","sha":"83c641f7cc866307bfd46aaac5e1453b179e8659","user":{"login":"arpith","id":62899,"avatar_url":"https://avatars.githubusercontent.com/u/62899?v=3","gravatar_id":"","url":"https://api.github.com/users/arpith","html_url":"https://github.com/arpith","followers_url":"https://api.github.com/users/arpith/followers","following_url":"https://api.github.com/users/arpith/following{/other_user}","gists_url":"https://api.github.com/users/arpith/gists{/gist_id}","starred_url":"https://api.github.com/users/arpith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpith/subscriptions","organizations_url":"https://api.github.com/users/arpith/orgs","repos_url":"https://api.github.com/users/arpith/repos","events_url":"https://api.github.com/users/arpith/events{/privacy}","received_events_url":"https://api.github.com/users/arpith/received_events","type":"User","site_admin":false},"repo":{"id":68940308,"name":"zulip","full_name":"arpith/zulip","owner":{"login":"arpith","id":62899,"avatar_url":"https://avatars.githubusercontent.com/u/62899?v=3","gravatar_id":"","url":"https://api.github.com/users/arpith","html_url":"https://github.com/arpith","followers_url":"https://api.github.com/users/arpith/followers","following_url":"https://api.github.com/users/arpith/following{/other_user}","gists_url":"https://api.github.com/users/arpith/gists{/gist_id}","starred_url":"https://api.github.com/users/arpith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpith/subscriptions","organizations_url":"https://api.github.com/users/arpith/orgs","repos_url":"https://api.github.com/users/arpith/repos","events_url":"https://api.github.com/users/arpith/events{/privacy}","received_events_url":"https://api.github.com/users/arpith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arpith/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/arpith/zulip","forks_url":"https://api.github.com/repos/arpith/zulip/forks","keys_url":"https://api.github.com/repos/arpith/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arpith/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arpith/zulip/teams","hooks_url":"https://api.github.com/repos/arpith/zulip/hooks","issue_events_url":"https://api.github.com/repos/arpith/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/arpith/zulip/events","assignees_url":"https://api.github.com/repos/arpith/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/arpith/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/arpith/zulip/tags","blobs_url":"https://api.github.com/repos/arpith/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arpith/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arpith/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/arpith/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arpith/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/arpith/zulip/languages","stargazers_url":"https://api.github.com/repos/arpith/zulip/stargazers","contributors_url":"https://api.github.com/repos/arpith/zulip/contributors","subscribers_url":"https://api.github.com/repos/arpith/zulip/subscribers","subscription_url":"https://api.github.com/repos/arpith/zulip/subscription","commits_url":"https://api.github.com/repos/arpith/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/arpith/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/arpith/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/arpith/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/arpith/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/arpith/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arpith/zulip/merges","archive_url":"https://api.github.com/repos/arpith/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arpith/zulip/downloads","issues_url":"https://api.github.com/repos/arpith/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/arpith/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/arpith/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/arpith/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arpith/zulip/labels{/name}","releases_url":"https://api.github.com/repos/arpith/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/arpith/zulip/deployments","created_at":"2016-09-22T16:25:21Z","updated_at":"2016-09-22T16:25:28Z","pushed_at":"2016-11-25T09:34:57Z","git_url":"git://github.com/arpith/zulip.git","ssh_url":"git@github.com:arpith/zulip.git","clone_url":"https://github.com/arpith/zulip.git","svn_url":"https://github.com/arpith/zulip","homepage":"","size":119638,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"4d7920221cdf7a4636a20a086e64f77f6a06f6c3","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source group chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2016-11-25T13:27:23Z","pushed_at":"2016-11-25T22:02:51Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"","size":129695,"stargazers_count":4298,"watchers_count":4298,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":800,"mirror_url":null,"open_issues_count":595,"forks":800,"open_issues":595,"watchers":4298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/2408"},"html":{"href":"https://github.com/zulip/zulip/pull/2408"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/2408"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/2408/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/2408/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/2408/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/83c641f7cc866307bfd46aaac5e1453b179e8659"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"timabbott"}}