{"action":"created","comment":{"url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/comments/70656150","id":70656150,"diff_hunk":"@@ -0,0 +1,165 @@\n+package osgi.enroute.web.server.provider;\n+\n+import java.net.*;\n+import java.util.*;\n+\n+import javax.servlet.http.*;\n+\n+import org.osgi.dto.*;\n+import org.osgi.framework.*;\n+import org.osgi.service.component.annotations.*;\n+import org.osgi.service.log.*;\n+import org.osgi.util.tracker.*;\n+\n+import aQute.lib.io.*;\n+import aQute.lib.json.*;\n+import aQute.libg.sed.*;\n+import osgi.enroute.servlet.api.*;\n+import osgi.enroute.web.server.cache.*;\n+import osgi.enroute.web.server.config.*;\n+import osgi.enroute.web.server.exceptions.*;\n+import osgi.enroute.web.server.provider.EnrouteApplicationIndexServer.IndexDTO.*;\n+\n+@Component(\n+\t\tservice = { ConditionalServlet.class }, \n+\t\timmediate = true, \n+\t\tproperty = {\n+\t\t\t\t\"service.ranking:Integer=1001\", \n+\t\t\t\t\"name=\" + EnrouteApplicationIndexServer.NAME, \n+\t\t}, \n+\t\tname = EnrouteApplicationIndexServer.NAME, \n+\t\tconfigurationPid = BundleMixinServer.NAME,\n+\t\tconfigurationPolicy = ConfigurationPolicy.OPTIONAL)\n+public class EnrouteApplicationIndexServer implements ConditionalServlet {\n+\n+\tstatic final String NAME = \"osgi.enroute.simple.web.application\";\n+\n+\tstatic class IndexDTO extends DTO {\n+\n+\t\tList<ApplicationDTO>\tapplications\t= new ArrayList<>();\n+\t\tMap<String,Object> configuration;","path":"osgi.enroute.web.simple.provider/src/osgi/enroute/web/server/provider/EnrouteApplicationIndexServer.java","position":40,"original_position":40,"commit_id":"dd4eb11f054ba6609fe99737749227963e308f1d","original_commit_id":"dd4eb11f054ba6609fe99737749227963e308f1d","user":{"login":"pkriens","id":200494,"avatar_url":"https://avatars.githubusercontent.com/u/200494?v=3","gravatar_id":"","url":"https://api.github.com/users/pkriens","html_url":"https://github.com/pkriens","followers_url":"https://api.github.com/users/pkriens/followers","following_url":"https://api.github.com/users/pkriens/following{/other_user}","gists_url":"https://api.github.com/users/pkriens/gists{/gist_id}","starred_url":"https://api.github.com/users/pkriens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkriens/subscriptions","organizations_url":"https://api.github.com/users/pkriens/orgs","repos_url":"https://api.github.com/users/pkriens/repos","events_url":"https://api.github.com/users/pkriens/events{/privacy}","received_events_url":"https://api.github.com/users/pkriens/received_events","type":"User","site_admin":false},"body":"DTO fields must also be public","created_at":"2016-07-13T16:07:28Z","updated_at":"2016-07-13T16:07:28Z","html_url":"https://github.com/osgi/osgi.enroute.bundles/pull/28#discussion_r70656150","pull_request_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/comments/70656150"},"html":{"href":"https://github.com/osgi/osgi.enroute.bundles/pull/28#discussion_r70656150"},"pull_request":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28","id":70966396,"html_url":"https://github.com/osgi/osgi.enroute.bundles/pull/28","diff_url":"https://github.com/osgi/osgi.enroute.bundles/pull/28.diff","patch_url":"https://github.com/osgi/osgi.enroute.bundles/pull/28.patch","issue_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/28","number":28,"state":"open","locked":false,"title":"Refactor web provider","user":{"login":"dleangen","id":9663141,"avatar_url":"https://avatars.githubusercontent.com/u/9663141?v=3","gravatar_id":"","url":"https://api.github.com/users/dleangen","html_url":"https://github.com/dleangen","followers_url":"https://api.github.com/users/dleangen/followers","following_url":"https://api.github.com/users/dleangen/following{/other_user}","gists_url":"https://api.github.com/users/dleangen/gists{/gist_id}","starred_url":"https://api.github.com/users/dleangen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleangen/subscriptions","organizations_url":"https://api.github.com/users/dleangen/orgs","repos_url":"https://api.github.com/users/dleangen/repos","events_url":"https://api.github.com/users/dleangen/events{/privacy}","received_events_url":"https://api.github.com/users/dleangen/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI would like to refactor the web provider in order to make it more flexible and more readable.\r\n\r\nThe idea is to separate the different \"parts\" into configurable ConditionalServlets. This will provide more flexibility, as each servlet can be either configured, or easily replaced by implementing a different ConditionalServlet and updating the service.ranking.\r\n\r\nAs the first step, I have attempted to pull out the Cache functionality. This is just to get the dialogue started. Nothing is actually using it yet.\r\n\r\nIf you agree with what I'm doing so far, then I will continue step by step. Please let me know.\r\n\r\n\r\n","created_at":"2016-05-22T02:55:13Z","updated_at":"2016-07-13T16:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66deed595266af649b051047ee7b710b4483fbb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28/commits","review_comments_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28/comments","review_comment_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/28/comments","statuses_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/statuses/dd4eb11f054ba6609fe99737749227963e308f1d","head":{"label":"dleangen:refactor","ref":"refactor","sha":"dd4eb11f054ba6609fe99737749227963e308f1d","user":{"login":"dleangen","id":9663141,"avatar_url":"https://avatars.githubusercontent.com/u/9663141?v=3","gravatar_id":"","url":"https://api.github.com/users/dleangen","html_url":"https://github.com/dleangen","followers_url":"https://api.github.com/users/dleangen/followers","following_url":"https://api.github.com/users/dleangen/following{/other_user}","gists_url":"https://api.github.com/users/dleangen/gists{/gist_id}","starred_url":"https://api.github.com/users/dleangen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleangen/subscriptions","organizations_url":"https://api.github.com/users/dleangen/orgs","repos_url":"https://api.github.com/users/dleangen/repos","events_url":"https://api.github.com/users/dleangen/events{/privacy}","received_events_url":"https://api.github.com/users/dleangen/received_events","type":"User","site_admin":false},"repo":{"id":49410900,"name":"osgi.enroute.bundles","full_name":"dleangen/osgi.enroute.bundles","owner":{"login":"dleangen","id":9663141,"avatar_url":"https://avatars.githubusercontent.com/u/9663141?v=3","gravatar_id":"","url":"https://api.github.com/users/dleangen","html_url":"https://github.com/dleangen","followers_url":"https://api.github.com/users/dleangen/followers","following_url":"https://api.github.com/users/dleangen/following{/other_user}","gists_url":"https://api.github.com/users/dleangen/gists{/gist_id}","starred_url":"https://api.github.com/users/dleangen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleangen/subscriptions","organizations_url":"https://api.github.com/users/dleangen/orgs","repos_url":"https://api.github.com/users/dleangen/repos","events_url":"https://api.github.com/users/dleangen/events{/privacy}","received_events_url":"https://api.github.com/users/dleangen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dleangen/osgi.enroute.bundles","description":"Bundles for the OSGi enRoute project. These bundles are simple implementations that can be used to run enRoute for smaller applications and provide an example how to implement it more thoroughly. There are also examples in this repo.","fork":true,"url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles","forks_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/forks","keys_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/teams","hooks_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/hooks","issue_events_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/issues/events{/number}","events_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/events","assignees_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/assignees{/user}","branches_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/branches{/branch}","tags_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/tags","blobs_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/git/refs{/sha}","trees_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/statuses/{sha}","languages_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/languages","stargazers_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/stargazers","contributors_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/contributors","subscribers_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/subscribers","subscription_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/subscription","commits_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/commits{/sha}","git_commits_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/git/commits{/sha}","comments_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/comments{/number}","issue_comment_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/issues/comments{/number}","contents_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/contents/{+path}","compare_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/merges","archive_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/downloads","issues_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/issues{/number}","pulls_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/pulls{/number}","milestones_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/milestones{/number}","notifications_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/labels{/name}","releases_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/releases{/id}","deployments_url":"https://api.github.com/repos/dleangen/osgi.enroute.bundles/deployments","created_at":"2016-01-11T07:57:54Z","updated_at":"2016-01-11T07:57:56Z","pushed_at":"2016-07-13T12:20:29Z","git_url":"git://github.com/dleangen/osgi.enroute.bundles.git","ssh_url":"git@github.com:dleangen/osgi.enroute.bundles.git","clone_url":"https://github.com/dleangen/osgi.enroute.bundles.git","svn_url":"https://github.com/dleangen/osgi.enroute.bundles","homepage":null,"size":5453,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osgi:master","ref":"master","sha":"06b4ab964744e87ebfa9ab1d762b460c3ae9378c","user":{"login":"osgi","id":1123352,"avatar_url":"https://avatars.githubusercontent.com/u/1123352?v=3","gravatar_id":"","url":"https://api.github.com/users/osgi","html_url":"https://github.com/osgi","followers_url":"https://api.github.com/users/osgi/followers","following_url":"https://api.github.com/users/osgi/following{/other_user}","gists_url":"https://api.github.com/users/osgi/gists{/gist_id}","starred_url":"https://api.github.com/users/osgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osgi/subscriptions","organizations_url":"https://api.github.com/users/osgi/orgs","repos_url":"https://api.github.com/users/osgi/repos","events_url":"https://api.github.com/users/osgi/events{/privacy}","received_events_url":"https://api.github.com/users/osgi/received_events","type":"Organization","site_admin":false},"repo":{"id":25362464,"name":"osgi.enroute.bundles","full_name":"osgi/osgi.enroute.bundles","owner":{"login":"osgi","id":1123352,"avatar_url":"https://avatars.githubusercontent.com/u/1123352?v=3","gravatar_id":"","url":"https://api.github.com/users/osgi","html_url":"https://github.com/osgi","followers_url":"https://api.github.com/users/osgi/followers","following_url":"https://api.github.com/users/osgi/following{/other_user}","gists_url":"https://api.github.com/users/osgi/gists{/gist_id}","starred_url":"https://api.github.com/users/osgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osgi/subscriptions","organizations_url":"https://api.github.com/users/osgi/orgs","repos_url":"https://api.github.com/users/osgi/repos","events_url":"https://api.github.com/users/osgi/events{/privacy}","received_events_url":"https://api.github.com/users/osgi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osgi/osgi.enroute.bundles","description":"Bundles for the OSGi enRoute project. These bundles are simple implementations that can be used to run enRoute for smaller applications and provide an example how to implement it more thoroughly. There are also examples in this repo.","fork":false,"url":"https://api.github.com/repos/osgi/osgi.enroute.bundles","forks_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/forks","keys_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/teams","hooks_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/hooks","issue_events_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/events{/number}","events_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/events","assignees_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/assignees{/user}","branches_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/branches{/branch}","tags_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/tags","blobs_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/git/refs{/sha}","trees_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/statuses/{sha}","languages_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/languages","stargazers_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/stargazers","contributors_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/contributors","subscribers_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/subscribers","subscription_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/subscription","commits_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/commits{/sha}","git_commits_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/git/commits{/sha}","comments_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/comments{/number}","issue_comment_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/comments{/number}","contents_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/contents/{+path}","compare_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/merges","archive_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/downloads","issues_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues{/number}","pulls_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls{/number}","milestones_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/milestones{/number}","notifications_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/labels{/name}","releases_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/releases{/id}","deployments_url":"https://api.github.com/repos/osgi/osgi.enroute.bundles/deployments","created_at":"2014-10-17T14:41:42Z","updated_at":"2016-07-13T03:22:07Z","pushed_at":"2016-07-13T15:36:41Z","git_url":"git://github.com/osgi/osgi.enroute.bundles.git","ssh_url":"git@github.com:osgi/osgi.enroute.bundles.git","clone_url":"https://github.com/osgi/osgi.enroute.bundles.git","svn_url":"https://github.com/osgi/osgi.enroute.bundles","homepage":null,"size":14063,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":13,"forks":24,"open_issues":13,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28"},"html":{"href":"https://github.com/osgi/osgi.enroute.bundles/pull/28"},"issue":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/28"},"comments":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/osgi/osgi.enroute.bundles/statuses/dd4eb11f054ba6609fe99737749227963e308f1d"}}}}
{"actor":{"display_login":"pkriens"}}