{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments/64229650","id":64229650,"diff_hunk":"@@ -133,14 +133,15 @@ static int heap_alloc_internal_check(int16_t alloc_size)\n \n     if (alloc_size) {\n         //\n-        temp_sector = alloc_size;\n-        temp_int = (temp_sector % temp_size);\n-        if (temp_int) {\n-            temp_sector += (temp_size - temp_int);\n-        }\n+        temp_sector = (alloc_size+temp_size-1)/temp_size;","path":"source/nsdynmemLIB/nsdynmemLIB.c","position":9,"original_position":9,"commit_id":"7caddb6aa144f3eef93eed2b85bfbec7fdc3d71d","original_commit_id":"7caddb6aa144f3eef93eed2b85bfbec7fdc3d71d","user":{"login":"kjbracey-arm","id":11025917,"avatar_url":"https://avatars.githubusercontent.com/u/11025917?v=3","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"body":"Maths looks correct.\r\nLose the \"temp_size\" - just use \"sizeof(int)\" - it will be clearer.\r\nRemove the commented code.\r\nGet the formatting right - spaces around operators.","created_at":"2016-05-23T14:15:18Z","updated_at":"2016-05-23T14:15:18Z","html_url":"https://github.com/ARMmbed/nanostack-libservice/pull/33#discussion_r64229650","pull_request_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments/64229650"},"html":{"href":"https://github.com/ARMmbed/nanostack-libservice/pull/33#discussion_r64229650"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33","id":71025313,"html_url":"https://github.com/ARMmbed/nanostack-libservice/pull/33","diff_url":"https://github.com/ARMmbed/nanostack-libservice/pull/33.diff","patch_url":"https://github.com/ARMmbed/nanostack-libservice/pull/33.patch","issue_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/33","number":33,"state":"open","locked":false,"title":"Clean up & fix the alloc_sector count when using a slightly bigger bl…","user":{"login":"SeppoTakalo","id":3104794,"avatar_url":"https://avatars.githubusercontent.com/u/3104794?v=3","gravatar_id":"","url":"https://api.github.com/users/SeppoTakalo","html_url":"https://github.com/SeppoTakalo","followers_url":"https://api.github.com/users/SeppoTakalo/followers","following_url":"https://api.github.com/users/SeppoTakalo/following{/other_user}","gists_url":"https://api.github.com/users/SeppoTakalo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeppoTakalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeppoTakalo/subscriptions","organizations_url":"https://api.github.com/users/SeppoTakalo/orgs","repos_url":"https://api.github.com/users/SeppoTakalo/repos","events_url":"https://api.github.com/users/SeppoTakalo/events{/privacy}","received_events_url":"https://api.github.com/users/SeppoTakalo/received_events","type":"User","site_admin":false},"body":"…ock.\r\n\r\n@AnttiKauppila ","created_at":"2016-05-23T08:54:14Z","updated_at":"2016-05-23T14:15:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"875a73a460c94e22ed354ab6fcbb632572e20803","assignee":{"login":"AnttiKauppila","id":12407486,"avatar_url":"https://avatars.githubusercontent.com/u/12407486?v=3","gravatar_id":"","url":"https://api.github.com/users/AnttiKauppila","html_url":"https://github.com/AnttiKauppila","followers_url":"https://api.github.com/users/AnttiKauppila/followers","following_url":"https://api.github.com/users/AnttiKauppila/following{/other_user}","gists_url":"https://api.github.com/users/AnttiKauppila/gists{/gist_id}","starred_url":"https://api.github.com/users/AnttiKauppila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnttiKauppila/subscriptions","organizations_url":"https://api.github.com/users/AnttiKauppila/orgs","repos_url":"https://api.github.com/users/AnttiKauppila/repos","events_url":"https://api.github.com/users/AnttiKauppila/events{/privacy}","received_events_url":"https://api.github.com/users/AnttiKauppila/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/33/comments","statuses_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/7caddb6aa144f3eef93eed2b85bfbec7fdc3d71d","head":{"label":"ARMmbed:ONME-2389","ref":"ONME-2389","sha":"7caddb6aa144f3eef93eed2b85bfbec7fdc3d71d","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":38824282,"name":"nanostack-libservice","full_name":"ARMmbed/nanostack-libservice","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nanostack-libservice","description":"","fork":false,"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice","forks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/forks","keys_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/events","assignees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/merges","archive_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/deployments","created_at":"2015-07-09T14:11:00Z","updated_at":"2016-02-26T09:42:16Z","pushed_at":"2016-05-23T13:39:16Z","git_url":"git://github.com/ARMmbed/nanostack-libservice.git","ssh_url":"git@github.com:ARMmbed/nanostack-libservice.git","clone_url":"https://github.com/ARMmbed/nanostack-libservice.git","svn_url":"https://github.com/ARMmbed/nanostack-libservice","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"2dcdb5bd8eacac11f57f5a03efab06ad7b1a6606","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":38824282,"name":"nanostack-libservice","full_name":"ARMmbed/nanostack-libservice","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nanostack-libservice","description":"","fork":false,"url":"https://api.github.com/repos/ARMmbed/nanostack-libservice","forks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/forks","keys_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/events","assignees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/merges","archive_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/nanostack-libservice/deployments","created_at":"2015-07-09T14:11:00Z","updated_at":"2016-02-26T09:42:16Z","pushed_at":"2016-05-23T13:39:16Z","git_url":"git://github.com/ARMmbed/nanostack-libservice.git","ssh_url":"git@github.com:ARMmbed/nanostack-libservice.git","clone_url":"https://github.com/ARMmbed/nanostack-libservice.git","svn_url":"https://github.com/ARMmbed/nanostack-libservice","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33"},"html":{"href":"https://github.com/ARMmbed/nanostack-libservice/pull/33"},"issue":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/33"},"comments":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/nanostack-libservice/statuses/7caddb6aa144f3eef93eed2b85bfbec7fdc3d71d"}}}}
{"actor":{"display_login":"kjbracey-arm"}}