{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/197","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/197/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/197/events","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/197","id":179829875,"number":197,"title":"Enhancement/81 html resource load","user":{"login":"AllenBW","id":6640236,"avatar_url":"https://avatars.githubusercontent.com/u/6640236?v=3","gravatar_id":"","url":"https://api.github.com/users/AllenBW","html_url":"https://github.com/AllenBW","followers_url":"https://api.github.com/users/AllenBW/followers","following_url":"https://api.github.com/users/AllenBW/following{/other_user}","gists_url":"https://api.github.com/users/AllenBW/gists{/gist_id}","starred_url":"https://api.github.com/users/AllenBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllenBW/subscriptions","organizations_url":"https://api.github.com/users/AllenBW/orgs","repos_url":"https://api.github.com/users/AllenBW/repos","events_url":"https://api.github.com/users/AllenBW/events{/privacy}","received_events_url":"https://api.github.com/users/AllenBW/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-28T17:02:45Z","updated_at":"2016-09-28T17:12:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/pulls/197","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/197","diff_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/197.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/197.patch"},"body":"closes #81 :feelsgood: 🚑 \r\n\r\nSo this PR the SUI switching from passing a dependency loaded `index.html` to sideloading (via ejs) two dependency partials at runtime. In the process it was necessary to yugely refactor `server/.app.js` as it was making a mess all over the place 🌋 😷 😲 \r\n\r\nI expect in this pr you'll notice no difference from master, except maybe a shorter app boot time and no more mess merge nonsense with `index.html` (hah because its gone, jk its still there, but changed).\r\n- `gulp serve-dev` should behave as expected\r\n- `gulp build` should behave as expected\r\n- app proxy with miq should behave as expected\r\n\r\nSO @himdel @dtaylor113 @dclarizio @jeff-phillips-18 @AparnaKarve @chriskacerguis @chalettu \r\nsince all ya'll were mildly involved in this, one way or another gonna humbly demand some 👀 on the branch when you get a chance.  Yes yes review the code, but also if you can pop on the branch and confirm all works as expected.\r\n\r\n🙏 "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/comments/250232959","html_url":"https://github.com/ManageIQ/manageiq-ui-self_service/pull/197#issuecomment-250232959","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-self_service/issues/197","id":250232959,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T17:12:11Z","updated_at":"2016-09-28T17:12:11Z","body":"<rubocop />Checked commits https://github.com/AllenBW/manageiq-ui-self_service/compare/b4f0058d638fd0362576435e61f024f976810e63~...aa3c7a77571611f4888e2e02975d70e4a503486f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n0 files checked, 0 offenses detected\nEverything looks good. :cake:\n"}}
{"actor":{"display_login":"miq-bot"}}