{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/72520356","id":72520356,"diff_hunk":"@@ -531,6 +581,14 @@ ngx_http_lua_shdict_get_helper(lua_State *L, int get_stale)\n         lua_pushboolean(L, c ? 1 : 0);\n         break;\n \n+    case LUA_TTABLE:\n+\n+        ngx_shmtx_unlock(&ctx->shpool->mutex);\n+\n+        lua_pushnil(L);\n+        lua_pushliteral(L, \"wrongtype operation\");","path":"src/ngx_http_lua_shdict.c","position":131,"original_position":131,"commit_id":"5b8387ed2d3d356c17f7a0defd945f4c9c5530a6","original_commit_id":"5b8387ed2d3d356c17f7a0defd945f4c9c5530a6","user":{"login":"agentzh","id":56241,"avatar_url":"https://avatars.githubusercontent.com/u/56241?v=3","gravatar_id":"","url":"https://api.github.com/users/agentzh","html_url":"https://github.com/agentzh","followers_url":"https://api.github.com/users/agentzh/followers","following_url":"https://api.github.com/users/agentzh/following{/other_user}","gists_url":"https://api.github.com/users/agentzh/gists{/gist_id}","starred_url":"https://api.github.com/users/agentzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentzh/subscriptions","organizations_url":"https://api.github.com/users/agentzh/orgs","repos_url":"https://api.github.com/users/agentzh/repos","events_url":"https://api.github.com/users/agentzh/events{/privacy}","received_events_url":"https://api.github.com/users/agentzh/received_events","type":"User","site_admin":false},"body":"The error message needs to be more descriptive.","created_at":"2016-07-27T20:47:54Z","updated_at":"2016-07-27T20:47:54Z","html_url":"https://github.com/openresty/lua-nginx-module/pull/586#discussion_r72520356","pull_request_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586","_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/72520356"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/586#discussion_r72520356"},"pull_request":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586","id":48989752,"html_url":"https://github.com/openresty/lua-nginx-module/pull/586","diff_url":"https://github.com/openresty/lua-nginx-module/pull/586.diff","patch_url":"https://github.com/openresty/lua-nginx-module/pull/586.patch","issue_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/586","number":586,"state":"open","locked":false,"title":"feature: add api in shdict: lpush, lpop, rpush, rpop, llen, expire","user":{"login":"doujiang24","id":570391,"avatar_url":"https://avatars.githubusercontent.com/u/570391?v=3","gravatar_id":"","url":"https://api.github.com/users/doujiang24","html_url":"https://github.com/doujiang24","followers_url":"https://api.github.com/users/doujiang24/followers","following_url":"https://api.github.com/users/doujiang24/following{/other_user}","gists_url":"https://api.github.com/users/doujiang24/gists{/gist_id}","starred_url":"https://api.github.com/users/doujiang24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doujiang24/subscriptions","organizations_url":"https://api.github.com/users/doujiang24/orgs","repos_url":"https://api.github.com/users/doujiang24/repos","events_url":"https://api.github.com/users/doujiang24/events{/privacy}","received_events_url":"https://api.github.com/users/doujiang24/received_events","type":"User","site_admin":false},"body":"I'm not sure if it is an good idea to get the list queue head in the way:\r\n```\r\n#define ngx_http_lua_shdict_get_list_head(sd, key_len)                      \\\r\n    (ngx_queue_t *) ngx_align_ptr(((u_char *) &sd->data + key_len),         \\\r\n                                  NGX_ALIGNMENT)\r\n```\r\n\r\nAnything not suitable, let me know, thanks :)","created_at":"2015-10-28T10:51:52Z","updated_at":"2016-07-27T20:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8910b80c665213834cf09216e27c54ee55960e16","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586/commits","review_comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586/comments","review_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/586/comments","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/5b8387ed2d3d356c17f7a0defd945f4c9c5530a6","head":{"label":"doujiang24:shdict_list","ref":"shdict_list","sha":"5b8387ed2d3d356c17f7a0defd945f4c9c5530a6","user":{"login":"doujiang24","id":570391,"avatar_url":"https://avatars.githubusercontent.com/u/570391?v=3","gravatar_id":"","url":"https://api.github.com/users/doujiang24","html_url":"https://github.com/doujiang24","followers_url":"https://api.github.com/users/doujiang24/followers","following_url":"https://api.github.com/users/doujiang24/following{/other_user}","gists_url":"https://api.github.com/users/doujiang24/gists{/gist_id}","starred_url":"https://api.github.com/users/doujiang24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doujiang24/subscriptions","organizations_url":"https://api.github.com/users/doujiang24/orgs","repos_url":"https://api.github.com/users/doujiang24/repos","events_url":"https://api.github.com/users/doujiang24/events{/privacy}","received_events_url":"https://api.github.com/users/doujiang24/received_events","type":"User","site_admin":false},"repo":{"id":19924592,"name":"lua-nginx-module","full_name":"doujiang24/lua-nginx-module","owner":{"login":"doujiang24","id":570391,"avatar_url":"https://avatars.githubusercontent.com/u/570391?v=3","gravatar_id":"","url":"https://api.github.com/users/doujiang24","html_url":"https://github.com/doujiang24","followers_url":"https://api.github.com/users/doujiang24/followers","following_url":"https://api.github.com/users/doujiang24/following{/other_user}","gists_url":"https://api.github.com/users/doujiang24/gists{/gist_id}","starred_url":"https://api.github.com/users/doujiang24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doujiang24/subscriptions","organizations_url":"https://api.github.com/users/doujiang24/orgs","repos_url":"https://api.github.com/users/doujiang24/repos","events_url":"https://api.github.com/users/doujiang24/events{/privacy}","received_events_url":"https://api.github.com/users/doujiang24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doujiang24/lua-nginx-module","description":"Embed the Power of Lua into NGINX","fork":true,"url":"https://api.github.com/repos/doujiang24/lua-nginx-module","forks_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/doujiang24/lua-nginx-module/deployments","created_at":"2014-05-19T00:30:59Z","updated_at":"2016-01-23T11:04:31Z","pushed_at":"2016-07-24T14:16:04Z","git_url":"git://github.com/doujiang24/lua-nginx-module.git","ssh_url":"git@github.com:doujiang24/lua-nginx-module.git","clone_url":"https://github.com/doujiang24/lua-nginx-module.git","svn_url":"https://github.com/doujiang24/lua-nginx-module","homepage":"http://openresty.org","size":15001,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"a5ac9fa2e623854178c3fbb77f643cc95226a3e9","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":613829,"name":"lua-nginx-module","full_name":"openresty/lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/lua-nginx-module","description":"Embed the Power of Lua into NGINX HTTP servers","fork":false,"url":"https://api.github.com/repos/openresty/lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/lua-nginx-module/deployments","created_at":"2010-04-16T15:59:01Z","updated_at":"2016-07-27T12:07:52Z","pushed_at":"2016-07-27T10:25:10Z","git_url":"git://github.com/openresty/lua-nginx-module.git","ssh_url":"git@github.com:openresty/lua-nginx-module.git","clone_url":"https://github.com/openresty/lua-nginx-module.git","svn_url":"https://github.com/openresty/lua-nginx-module","homepage":"https://openresty.org/","size":19037,"stargazers_count":3195,"watchers_count":3195,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":725,"mirror_url":null,"open_issues_count":72,"forks":725,"open_issues":72,"watchers":3195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/586"},"issue":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/586"},"comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/5b8387ed2d3d356c17f7a0defd945f4c9c5530a6"}}}}
{"actor":{"display_login":"agentzh"}}