{"action":"created","comment":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/66944729","id":66944729,"diff_hunk":"@@ -282,8 +294,8 @@ tcp_attach(struct uip_conn *conn,\n   uip_tcp_appstate_t *s;\n \n   s = &conn->appstate;\n-  s->p = PROCESS_CURRENT();\n-  s->state = appstate;\n+\n+  setup_appstate(s, appstate);","path":"core/net/ip/tcpip.c","position":37,"original_position":37,"commit_id":"ef4b1ed0ae3fb42ae0de5e3ff517ba6b6843c52b","original_commit_id":"ef4b1ed0ae3fb42ae0de5e3ff517ba6b6843c52b","user":{"login":"greg-king5","id":4145570,"avatar_url":"https://avatars.githubusercontent.com/u/4145570?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-king5","html_url":"https://github.com/greg-king5","followers_url":"https://api.github.com/users/greg-king5/followers","following_url":"https://api.github.com/users/greg-king5/following{/other_user}","gists_url":"https://api.github.com/users/greg-king5/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-king5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-king5/subscriptions","organizations_url":"https://api.github.com/users/greg-king5/orgs","repos_url":"https://api.github.com/users/greg-king5/repos","events_url":"https://api.github.com/users/greg-king5/events{/privacy}","received_events_url":"https://api.github.com/users/greg-king5/received_events","type":"User","site_admin":false},"body":"In this function and the ones below it, the local variable `s` no longer is needed.\r\n```c\r\n  setup_appstate(&conn->appstate, appstate);\r\n```","created_at":"2016-06-14T10:22:10Z","updated_at":"2016-06-14T10:22:10Z","html_url":"https://github.com/contiki-os/contiki/pull/1725#discussion_r66944729","pull_request_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1725","_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/66944729"},"html":{"href":"https://github.com/contiki-os/contiki/pull/1725#discussion_r66944729"},"pull_request":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1725"}}},"pull_request":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/1725","id":73620160,"html_url":"https://github.com/contiki-os/contiki/pull/1725","diff_url":"https://github.com/contiki-os/contiki/pull/1725.diff","patch_url":"https://github.com/contiki-os/contiki/pull/1725.patch","issue_url":"https://api.github.com/repos/contiki-os/contiki/issues/1725","number":1725,"state":"open","locked":false,"title":"Refactor tcpip","user":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"body":"This PR performs some re-factoring of ```tcpip.c```, mainly focused on ```tcpip_ipv6_output()```.\r\n\r\nThe main purpose of this PR is to prepare for the changes proposed in #1186. As per the discussion on #1186, these commits were originally part of #1186 but were split apart.\r\n\r\nThese commits accomplish the following:\r\n1. Improve the readability of ```tcpip_ipv6_output()``` so as to make future modifications to this function easier.\r\n2. Reduce the size of generated code, esp. on the 6502 platforms where it is easy to run out of memory.","created_at":"2016-06-13T18:20:59Z","updated_at":"2016-06-14T10:22:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dde10340ac4edaad20c7844ad214c37d4bd5a46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1725/commits","review_comments_url":"https://api.github.com/repos/contiki-os/contiki/pulls/1725/comments","review_comment_url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiki-os/contiki/issues/1725/comments","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/ef4b1ed0ae3fb42ae0de5e3ff517ba6b6843c52b","head":{"label":"bkozak-scanimetrics:refactor_tcpip","ref":"refactor_tcpip","sha":"ef4b1ed0ae3fb42ae0de5e3ff517ba6b6843c52b","user":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"repo":{"id":37210139,"name":"contiki","full_name":"bkozak-scanimetrics/contiki","owner":{"login":"bkozak-scanimetrics","id":12412857,"avatar_url":"https://avatars.githubusercontent.com/u/12412857?v=3","gravatar_id":"","url":"https://api.github.com/users/bkozak-scanimetrics","html_url":"https://github.com/bkozak-scanimetrics","followers_url":"https://api.github.com/users/bkozak-scanimetrics/followers","following_url":"https://api.github.com/users/bkozak-scanimetrics/following{/other_user}","gists_url":"https://api.github.com/users/bkozak-scanimetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/bkozak-scanimetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkozak-scanimetrics/subscriptions","organizations_url":"https://api.github.com/users/bkozak-scanimetrics/orgs","repos_url":"https://api.github.com/users/bkozak-scanimetrics/repos","events_url":"https://api.github.com/users/bkozak-scanimetrics/events{/privacy}","received_events_url":"https://api.github.com/users/bkozak-scanimetrics/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkozak-scanimetrics/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/bkozak-scanimetrics/contiki","forks_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/forks","keys_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/teams","hooks_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/hooks","issue_events_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/events","assignees_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/tags","blobs_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/languages","stargazers_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/stargazers","contributors_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/contributors","subscribers_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/subscribers","subscription_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/subscription","commits_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/merges","archive_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/downloads","issues_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/labels{/name}","releases_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/bkozak-scanimetrics/contiki/deployments","created_at":"2015-06-10T16:55:37Z","updated_at":"2016-04-22T22:23:39Z","pushed_at":"2016-06-13T18:34:27Z","git_url":"git://github.com/bkozak-scanimetrics/contiki.git","ssh_url":"git@github.com:bkozak-scanimetrics/contiki.git","clone_url":"https://github.com/bkozak-scanimetrics/contiki.git","svn_url":"https://github.com/bkozak-scanimetrics/contiki","homepage":"http://www.contiki-os.org/","size":69344,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"contiki-os:master","ref":"master","sha":"4fd8f670530fd744c9576fcf20ecd1a34b2eb814","user":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"repo":{"id":6365284,"name":"contiki","full_name":"contiki-os/contiki","owner":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiki-os/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":false,"url":"https://api.github.com/repos/contiki-os/contiki","forks_url":"https://api.github.com/repos/contiki-os/contiki/forks","keys_url":"https://api.github.com/repos/contiki-os/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiki-os/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiki-os/contiki/teams","hooks_url":"https://api.github.com/repos/contiki-os/contiki/hooks","issue_events_url":"https://api.github.com/repos/contiki-os/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/contiki-os/contiki/events","assignees_url":"https://api.github.com/repos/contiki-os/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/contiki-os/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/contiki-os/contiki/tags","blobs_url":"https://api.github.com/repos/contiki-os/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiki-os/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiki-os/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiki-os/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/contiki-os/contiki/languages","stargazers_url":"https://api.github.com/repos/contiki-os/contiki/stargazers","contributors_url":"https://api.github.com/repos/contiki-os/contiki/contributors","subscribers_url":"https://api.github.com/repos/contiki-os/contiki/subscribers","subscription_url":"https://api.github.com/repos/contiki-os/contiki/subscription","commits_url":"https://api.github.com/repos/contiki-os/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiki-os/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiki-os/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiki-os/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiki-os/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/contiki-os/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiki-os/contiki/merges","archive_url":"https://api.github.com/repos/contiki-os/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiki-os/contiki/downloads","issues_url":"https://api.github.com/repos/contiki-os/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/contiki-os/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/contiki-os/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/contiki-os/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiki-os/contiki/labels{/name}","releases_url":"https://api.github.com/repos/contiki-os/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/contiki-os/contiki/deployments","created_at":"2012-10-24T05:59:36Z","updated_at":"2016-06-14T06:44:37Z","pushed_at":"2016-06-14T06:32:26Z","git_url":"git://github.com/contiki-os/contiki.git","ssh_url":"git@github.com:contiki-os/contiki.git","clone_url":"https://github.com/contiki-os/contiki.git","svn_url":"https://github.com/contiki-os/contiki","homepage":"http://www.contiki-os.org/","size":86186,"stargazers_count":1881,"watchers_count":1881,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1487,"mirror_url":null,"open_issues_count":187,"forks":1487,"open_issues":187,"watchers":1881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1725"},"html":{"href":"https://github.com/contiki-os/contiki/pull/1725"},"issue":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/1725"},"comments":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/1725/comments"},"review_comments":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1725/comments"},"review_comment":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/1725/commits"},"statuses":{"href":"https://api.github.com/repos/contiki-os/contiki/statuses/ef4b1ed0ae3fb42ae0de5e3ff517ba6b6843c52b"}}}}
{"actor":{"display_login":"greg-king5"}}