{"action":"created","issue":{"url":"https://api.github.com/repos/areaDetector/ADCore/issues/194","repository_url":"https://api.github.com/repos/areaDetector/ADCore","labels_url":"https://api.github.com/repos/areaDetector/ADCore/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/areaDetector/ADCore/issues/194/comments","events_url":"https://api.github.com/repos/areaDetector/ADCore/issues/194/events","html_url":"https://github.com/areaDetector/ADCore/pull/194","id":178975038,"number":194,"title":"Eliminate ADBinaries, add ADSupport","user":{"login":"MarkRivers","id":6115534,"avatar_url":"https://avatars.githubusercontent.com/u/6115534?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkRivers","html_url":"https://github.com/MarkRivers","followers_url":"https://api.github.com/users/MarkRivers/followers","following_url":"https://api.github.com/users/MarkRivers/following{/other_user}","gists_url":"https://api.github.com/users/MarkRivers/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkRivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkRivers/subscriptions","organizations_url":"https://api.github.com/users/MarkRivers/orgs","repos_url":"https://api.github.com/users/MarkRivers/repos","events_url":"https://api.github.com/users/MarkRivers/events{/privacy}","received_events_url":"https://api.github.com/users/MarkRivers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ulrikpedersen","id":6115544,"avatar_url":"https://avatars.githubusercontent.com/u/6115544?v=3","gravatar_id":"","url":"https://api.github.com/users/ulrikpedersen","html_url":"https://github.com/ulrikpedersen","followers_url":"https://api.github.com/users/ulrikpedersen/followers","following_url":"https://api.github.com/users/ulrikpedersen/following{/other_user}","gists_url":"https://api.github.com/users/ulrikpedersen/gists{/gist_id}","starred_url":"https://api.github.com/users/ulrikpedersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulrikpedersen/subscriptions","organizations_url":"https://api.github.com/users/ulrikpedersen/orgs","repos_url":"https://api.github.com/users/ulrikpedersen/repos","events_url":"https://api.github.com/users/ulrikpedersen/events{/privacy}","received_events_url":"https://api.github.com/users/ulrikpedersen/received_events","type":"User","site_admin":false},"assignees":[{"login":"ulrikpedersen","id":6115544,"avatar_url":"https://avatars.githubusercontent.com/u/6115544?v=3","gravatar_id":"","url":"https://api.github.com/users/ulrikpedersen","html_url":"https://github.com/ulrikpedersen","followers_url":"https://api.github.com/users/ulrikpedersen/followers","following_url":"https://api.github.com/users/ulrikpedersen/following{/other_user}","gists_url":"https://api.github.com/users/ulrikpedersen/gists{/gist_id}","starred_url":"https://api.github.com/users/ulrikpedersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulrikpedersen/subscriptions","organizations_url":"https://api.github.com/users/ulrikpedersen/orgs","repos_url":"https://api.github.com/users/ulrikpedersen/repos","events_url":"https://api.github.com/users/ulrikpedersen/events{/privacy}","received_events_url":"https://api.github.com/users/ulrikpedersen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2016-09-23T21:14:52Z","updated_at":"2016-09-29T12:51:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/areaDetector/ADCore/pulls/194","html_url":"https://github.com/areaDetector/ADCore/pull/194","diff_url":"https://github.com/areaDetector/ADCore/pull/194.diff","patch_url":"https://github.com/areaDetector/ADCore/pull/194.patch"},"body":"Add new ADSupport repository.  This repository contains:\r\n\r\n- Source code versions of the hdf5, xml2, szip, and zlib libraries that were in ADBinaries\r\n- Source code versions of the netCDF, Nexus, tiff, and jpeg libraries that were in ADCore\r\n\r\nThe change to ADCore is mostly to remove the source code for netCDF, Nexus, tiff, and jpeg.\r\n\r\nThe file plugin code, commonLibraryMakefile and commonDriverMakefile were also changed because jpeg and tiff are now supported on vxWorks, and there is new support for mingw."},"comment":{"url":"https://api.github.com/repos/areaDetector/ADCore/issues/comments/250456738","html_url":"https://github.com/areaDetector/ADCore/pull/194#issuecomment-250456738","issue_url":"https://api.github.com/repos/areaDetector/ADCore/issues/194","id":250456738,"user":{"login":"ulrikpedersen","id":6115544,"avatar_url":"https://avatars.githubusercontent.com/u/6115544?v=3","gravatar_id":"","url":"https://api.github.com/users/ulrikpedersen","html_url":"https://github.com/ulrikpedersen","followers_url":"https://api.github.com/users/ulrikpedersen/followers","following_url":"https://api.github.com/users/ulrikpedersen/following{/other_user}","gists_url":"https://api.github.com/users/ulrikpedersen/gists{/gist_id}","starred_url":"https://api.github.com/users/ulrikpedersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulrikpedersen/subscriptions","organizations_url":"https://api.github.com/users/ulrikpedersen/orgs","repos_url":"https://api.github.com/users/ulrikpedersen/repos","events_url":"https://api.github.com/users/ulrikpedersen/events{/privacy}","received_events_url":"https://api.github.com/users/ulrikpedersen/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T12:51:18Z","updated_at":"2016-09-29T12:51:18Z","body":"> I am also working to change the build system in ADSupport and ADCore to that each of the 3rd party libraries has the following flags, using HDF5 as an example:\r\n> \r\n> WITH_HDF5=[YES,NO] If this flag is NO then ADSupport and ADCore do not build any code that requires HDF5.\r\n> \r\n> HDF5=[path to external HDF library] If this is undefined then the code in ADSupport is built and used. If it is defined then the library is assumed to be present somewhere external to areaDetector.\r\n> \r\n> HDF5_INCLUDE=[path to external HDF5 include files]\r\n> HDF5_DIR=[path to external HDF5 libraries]\r\n\r\nPerfect! \r\n\r\n> We may not need both HDF5 and HDF5_DIR. I need to test this.\r\n\r\nYou may need to make some assumptions about where libs and include files have been installed. That may not be the same on all platforms...\r\n"}}
{"actor":{"display_login":"ulrikpedersen"}}