{"action":"created","issue":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/1127","labels_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1127/labels{/name}","comments_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1127/comments","events_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1127/events","html_url":"https://github.com/urho3d/Urho3D/pull/1127","id":124224749,"number":1127,"title":"Transfer some defines to Urho3D.h","user":{"login":"1vanK","id":13021826,"avatar_url":"https://avatars.githubusercontent.com/u/13021826?v=3","gravatar_id":"","url":"https://api.github.com/users/1vanK","html_url":"https://github.com/1vanK","followers_url":"https://api.github.com/users/1vanK/followers","following_url":"https://api.github.com/users/1vanK/following{/other_user}","gists_url":"https://api.github.com/users/1vanK/gists{/gist_id}","starred_url":"https://api.github.com/users/1vanK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1vanK/subscriptions","organizations_url":"https://api.github.com/users/1vanK/orgs","repos_url":"https://api.github.com/users/1vanK/repos","events_url":"https://api.github.com/users/1vanK/events{/privacy}","received_events_url":"https://api.github.com/users/1vanK/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-29T15:21:07Z","updated_at":"2016-01-04T07:49:21Z","closed_at":"2016-01-04T07:43:54Z","pull_request":{"url":"https://api.github.com/repos/urho3d/Urho3D/pulls/1127","html_url":"https://github.com/urho3d/Urho3D/pull/1127","diff_url":"https://github.com/urho3d/Urho3D/pull/1127.diff","patch_url":"https://github.com/urho3d/Urho3D/pull/1127.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/comments/168604714","html_url":"https://github.com/urho3d/Urho3D/pull/1127#issuecomment-168604714","issue_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1127","id":168604714,"user":{"login":"weitjong","id":5548048,"avatar_url":"https://avatars.githubusercontent.com/u/5548048?v=3","gravatar_id":"","url":"https://api.github.com/users/weitjong","html_url":"https://github.com/weitjong","followers_url":"https://api.github.com/users/weitjong/followers","following_url":"https://api.github.com/users/weitjong/following{/other_user}","gists_url":"https://api.github.com/users/weitjong/gists{/gist_id}","starred_url":"https://api.github.com/users/weitjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weitjong/subscriptions","organizations_url":"https://api.github.com/users/weitjong/orgs","repos_url":"https://api.github.com/users/weitjong/repos","events_url":"https://api.github.com/users/weitjong/events{/privacy}","received_events_url":"https://api.github.com/users/weitjong/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T07:49:21Z","updated_at":"2016-01-04T07:49:21Z","body":"Ok, I thought that was your main reason because you did not mention it in the description. Aside from those already baked in the export header currently, I don't think the other compiler defines needs to be set exactly the same as Urho3D library did. We could still have missed out a few though, so if you can give a valid reason on case by case basis why a define need to be baked then it can be considered but not wholesale like this. For example, I could have built my library with both AS and Lua enabled, but in my own downstream project, I may just want to use AS only or Lua only. Or another example, I could have built my library with logging turned off, but in my own downstream project I want to turn it back on, so I get the log entries just from my app."}}