{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6","id":88181075,"html_url":"https://github.com/walmartlabs/easy-fix/pull/6","diff_url":"https://github.com/walmartlabs/easy-fix/pull/6.diff","patch_url":"https://github.com/walmartlabs/easy-fix/pull/6.patch","issue_url":"https://api.github.com/repos/walmartlabs/easy-fix/issues/6","number":6,"state":"closed","locked":false,"title":"Include more information in error message when missing mocks","user":{"login":"ianwsperber","id":3731165,"avatar_url":"https://avatars.githubusercontent.com/u/3731165?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwsperber","html_url":"https://github.com/ianwsperber","followers_url":"https://api.github.com/users/ianwsperber/followers","following_url":"https://api.github.com/users/ianwsperber/following{/other_user}","gists_url":"https://api.github.com/users/ianwsperber/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwsperber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwsperber/subscriptions","organizations_url":"https://api.github.com/users/ianwsperber/orgs","repos_url":"https://api.github.com/users/ianwsperber/repos","events_url":"https://api.github.com/users/ianwsperber/events{/privacy}","received_events_url":"https://api.github.com/users/ianwsperber/received_events","type":"User","site_admin":false},"body":"Currently if we can't find mocks for a method wrapped with easy-fix we get an error with no details on _which_ method was wrapped and _what_ the mismatching data is. This can make it difficult to debug, particularly when you have multi easy-fix calls within a single test.\r\n\r\nThis PR aims to augment the error message with:\r\n\r\n1. The mock filename (which is derived from the method name by default)\r\n2. The serialized argument data\r\n\r\nWhile point 2 has the potential to create overly verbose error output I think it'll be worth it for the ease of debugging.\r\n\r\nSample output:\r\n\r\n```\r\n     Uncaught Error: This test (in replay mode) could not read the expected mock data from \"tmp/incStateNextTick-c156c7373216-response.json\"\r\n\r\nSerialized arguments:\r\n[\r\n  {\r\n    \"foo\": \"bar\"\r\n  },\r\n  null\r\n]\r\n\r\nIf you have not already, try running this test in capture mode to generate new test fixtures.  If you continue to see this error, a likely cause is differing (frequently changing) argument for the wrapped asynchronous task.  This can be mitigated by defining an argumentSerializer option that ignores the frequently-changing argument.\r\n```\r\n\r\nUnfortunately to test this feature I had to use the deprecated domain API. I'm open to suggestions for avoid it but I'm not aware of any other means for catching an uncaught error.","created_at":"2016-10-06T00:27:45Z","updated_at":"2016-10-11T02:02:40Z","closed_at":"2016-10-11T02:02:40Z","merged_at":"2016-10-11T02:02:40Z","merge_commit_sha":"99b523ed60b2a7c213e2f2dccd14246ad1030d63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6/commits","review_comments_url":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6/comments","review_comment_url":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/walmartlabs/easy-fix/issues/6/comments","statuses_url":"https://api.github.com/repos/walmartlabs/easy-fix/statuses/aab24039fd037c2eb04ad98db722c0ebca1bf583","head":{"label":"ianwsperber:more-information-for-missing-mocks","ref":"more-information-for-missing-mocks","sha":"aab24039fd037c2eb04ad98db722c0ebca1bf583","user":{"login":"ianwsperber","id":3731165,"avatar_url":"https://avatars.githubusercontent.com/u/3731165?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwsperber","html_url":"https://github.com/ianwsperber","followers_url":"https://api.github.com/users/ianwsperber/followers","following_url":"https://api.github.com/users/ianwsperber/following{/other_user}","gists_url":"https://api.github.com/users/ianwsperber/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwsperber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwsperber/subscriptions","organizations_url":"https://api.github.com/users/ianwsperber/orgs","repos_url":"https://api.github.com/users/ianwsperber/repos","events_url":"https://api.github.com/users/ianwsperber/events{/privacy}","received_events_url":"https://api.github.com/users/ianwsperber/received_events","type":"User","site_admin":false},"repo":{"id":70109857,"name":"easy-fix","full_name":"ianwsperber/easy-fix","owner":{"login":"ianwsperber","id":3731165,"avatar_url":"https://avatars.githubusercontent.com/u/3731165?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwsperber","html_url":"https://github.com/ianwsperber","followers_url":"https://api.github.com/users/ianwsperber/followers","following_url":"https://api.github.com/users/ianwsperber/following{/other_user}","gists_url":"https://api.github.com/users/ianwsperber/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwsperber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwsperber/subscriptions","organizations_url":"https://api.github.com/users/ianwsperber/orgs","repos_url":"https://api.github.com/users/ianwsperber/repos","events_url":"https://api.github.com/users/ianwsperber/events{/privacy}","received_events_url":"https://api.github.com/users/ianwsperber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianwsperber/easy-fix","description":"easy-fix: run integration tests like unit tests","fork":true,"url":"https://api.github.com/repos/ianwsperber/easy-fix","forks_url":"https://api.github.com/repos/ianwsperber/easy-fix/forks","keys_url":"https://api.github.com/repos/ianwsperber/easy-fix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianwsperber/easy-fix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianwsperber/easy-fix/teams","hooks_url":"https://api.github.com/repos/ianwsperber/easy-fix/hooks","issue_events_url":"https://api.github.com/repos/ianwsperber/easy-fix/issues/events{/number}","events_url":"https://api.github.com/repos/ianwsperber/easy-fix/events","assignees_url":"https://api.github.com/repos/ianwsperber/easy-fix/assignees{/user}","branches_url":"https://api.github.com/repos/ianwsperber/easy-fix/branches{/branch}","tags_url":"https://api.github.com/repos/ianwsperber/easy-fix/tags","blobs_url":"https://api.github.com/repos/ianwsperber/easy-fix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianwsperber/easy-fix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianwsperber/easy-fix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianwsperber/easy-fix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianwsperber/easy-fix/statuses/{sha}","languages_url":"https://api.github.com/repos/ianwsperber/easy-fix/languages","stargazers_url":"https://api.github.com/repos/ianwsperber/easy-fix/stargazers","contributors_url":"https://api.github.com/repos/ianwsperber/easy-fix/contributors","subscribers_url":"https://api.github.com/repos/ianwsperber/easy-fix/subscribers","subscription_url":"https://api.github.com/repos/ianwsperber/easy-fix/subscription","commits_url":"https://api.github.com/repos/ianwsperber/easy-fix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianwsperber/easy-fix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianwsperber/easy-fix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianwsperber/easy-fix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianwsperber/easy-fix/contents/{+path}","compare_url":"https://api.github.com/repos/ianwsperber/easy-fix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianwsperber/easy-fix/merges","archive_url":"https://api.github.com/repos/ianwsperber/easy-fix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianwsperber/easy-fix/downloads","issues_url":"https://api.github.com/repos/ianwsperber/easy-fix/issues{/number}","pulls_url":"https://api.github.com/repos/ianwsperber/easy-fix/pulls{/number}","milestones_url":"https://api.github.com/repos/ianwsperber/easy-fix/milestones{/number}","notifications_url":"https://api.github.com/repos/ianwsperber/easy-fix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianwsperber/easy-fix/labels{/name}","releases_url":"https://api.github.com/repos/ianwsperber/easy-fix/releases{/id}","deployments_url":"https://api.github.com/repos/ianwsperber/easy-fix/deployments","created_at":"2016-10-06T00:18:28Z","updated_at":"2016-10-06T00:18:29Z","pushed_at":"2016-10-06T00:19:09Z","git_url":"git://github.com/ianwsperber/easy-fix.git","ssh_url":"git@github.com:ianwsperber/easy-fix.git","clone_url":"https://github.com/ianwsperber/easy-fix.git","svn_url":"https://github.com/ianwsperber/easy-fix","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"walmartlabs:master","ref":"master","sha":"85af31e461a011efa0a13a545da33d72f64567e5","user":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66985130,"name":"easy-fix","full_name":"walmartlabs/easy-fix","owner":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?v=3","gravatar_id":"","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/walmartlabs/easy-fix","description":"easy-fix: run integration tests like unit tests","fork":false,"url":"https://api.github.com/repos/walmartlabs/easy-fix","forks_url":"https://api.github.com/repos/walmartlabs/easy-fix/forks","keys_url":"https://api.github.com/repos/walmartlabs/easy-fix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walmartlabs/easy-fix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walmartlabs/easy-fix/teams","hooks_url":"https://api.github.com/repos/walmartlabs/easy-fix/hooks","issue_events_url":"https://api.github.com/repos/walmartlabs/easy-fix/issues/events{/number}","events_url":"https://api.github.com/repos/walmartlabs/easy-fix/events","assignees_url":"https://api.github.com/repos/walmartlabs/easy-fix/assignees{/user}","branches_url":"https://api.github.com/repos/walmartlabs/easy-fix/branches{/branch}","tags_url":"https://api.github.com/repos/walmartlabs/easy-fix/tags","blobs_url":"https://api.github.com/repos/walmartlabs/easy-fix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walmartlabs/easy-fix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walmartlabs/easy-fix/git/refs{/sha}","trees_url":"https://api.github.com/repos/walmartlabs/easy-fix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walmartlabs/easy-fix/statuses/{sha}","languages_url":"https://api.github.com/repos/walmartlabs/easy-fix/languages","stargazers_url":"https://api.github.com/repos/walmartlabs/easy-fix/stargazers","contributors_url":"https://api.github.com/repos/walmartlabs/easy-fix/contributors","subscribers_url":"https://api.github.com/repos/walmartlabs/easy-fix/subscribers","subscription_url":"https://api.github.com/repos/walmartlabs/easy-fix/subscription","commits_url":"https://api.github.com/repos/walmartlabs/easy-fix/commits{/sha}","git_commits_url":"https://api.github.com/repos/walmartlabs/easy-fix/git/commits{/sha}","comments_url":"https://api.github.com/repos/walmartlabs/easy-fix/comments{/number}","issue_comment_url":"https://api.github.com/repos/walmartlabs/easy-fix/issues/comments{/number}","contents_url":"https://api.github.com/repos/walmartlabs/easy-fix/contents/{+path}","compare_url":"https://api.github.com/repos/walmartlabs/easy-fix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walmartlabs/easy-fix/merges","archive_url":"https://api.github.com/repos/walmartlabs/easy-fix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walmartlabs/easy-fix/downloads","issues_url":"https://api.github.com/repos/walmartlabs/easy-fix/issues{/number}","pulls_url":"https://api.github.com/repos/walmartlabs/easy-fix/pulls{/number}","milestones_url":"https://api.github.com/repos/walmartlabs/easy-fix/milestones{/number}","notifications_url":"https://api.github.com/repos/walmartlabs/easy-fix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walmartlabs/easy-fix/labels{/name}","releases_url":"https://api.github.com/repos/walmartlabs/easy-fix/releases{/id}","deployments_url":"https://api.github.com/repos/walmartlabs/easy-fix/deployments","created_at":"2016-08-30T23:29:45Z","updated_at":"2016-10-09T18:57:05Z","pushed_at":"2016-10-11T02:02:40Z","git_url":"git://github.com/walmartlabs/easy-fix.git","ssh_url":"git@github.com:walmartlabs/easy-fix.git","clone_url":"https://github.com/walmartlabs/easy-fix.git","svn_url":"https://github.com/walmartlabs/easy-fix","homepage":null,"size":27,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6"},"html":{"href":"https://github.com/walmartlabs/easy-fix/pull/6"},"issue":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/issues/6"},"comments":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/walmartlabs/easy-fix/statuses/aab24039fd037c2eb04ad98db722c0ebca1bf583"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rathbone1200cc","id":209337,"avatar_url":"https://avatars.githubusercontent.com/u/209337?v=3","gravatar_id":"","url":"https://api.github.com/users/rathbone1200cc","html_url":"https://github.com/rathbone1200cc","followers_url":"https://api.github.com/users/rathbone1200cc/followers","following_url":"https://api.github.com/users/rathbone1200cc/following{/other_user}","gists_url":"https://api.github.com/users/rathbone1200cc/gists{/gist_id}","starred_url":"https://api.github.com/users/rathbone1200cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathbone1200cc/subscriptions","organizations_url":"https://api.github.com/users/rathbone1200cc/orgs","repos_url":"https://api.github.com/users/rathbone1200cc/repos","events_url":"https://api.github.com/users/rathbone1200cc/events{/privacy}","received_events_url":"https://api.github.com/users/rathbone1200cc/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":36,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"rathbone1200cc"}}