{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/64849258","id":64849258,"diff_hunk":"@@ -17,17 +17,17 @@\n \n \n /**\n- * An interface to track a set of metrics for a network request\n+ * Tracks a set of metrics for a network request by a server\n  */\n-public class NetworkRequestMetrics {\n+public class ServerNetworkRequestMetrics implements NetworkRequestSend {","path":"ambry-api/src/main/java/com.github.ambry/network/ServerNetworkRequestMetrics.java","position":8,"original_position":8,"commit_id":"dc860cfed60c8aa776570f241a79e425f5fc7b50","original_commit_id":"dc860cfed60c8aa776570f241a79e425f5fc7b50","user":{"login":"vgkholla","id":288834,"avatar_url":"https://avatars.githubusercontent.com/u/288834?v=3","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"body":"why the rename?","created_at":"2016-05-27T02:14:29Z","updated_at":"2016-05-27T02:14:29Z","html_url":"https://github.com/linkedin/ambry/pull/331#discussion_r64849258","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/331","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/64849258"},"html":{"href":"https://github.com/linkedin/ambry/pull/331#discussion_r64849258"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/331","id":71159425,"html_url":"https://github.com/linkedin/ambry/pull/331","diff_url":"https://github.com/linkedin/ambry/pull/331.diff","patch_url":"https://github.com/linkedin/ambry/pull/331.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/331","number":331,"state":"open","locked":false,"title":"Adding metrics to NetworkClient","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"body":"Adding metrics to NetworkClient. Also added an interface NetworkRequestSend to assist in updating the Send time. \r\n\r\nSLA: 25 mins\r\nReviewers: Priyesh, Ming\r\n\r\nSome notes to assist in reviewing:\r\nStage1: 5 mins\r\nInterface NetworkRequestSend \r\nImplementing classes: ServerNetworkRequestMetrics(renamed from NetworkRequestMetrics), ClientNetworkRequestMetrics\r\nClasses that calls into ServerNetworkRequestMetrics (just renamed):\r\nNetworkSend, RequestResponseChannel, SocketRequestResponseChannel, AmbryRequests\r\n\r\nStage2: 15 mins\r\nNetworkClient and NetworkMetrics\r\nThis has the major change in this patch. Introduced new metrics to track metrics for NetworkClient. Also have rearranged existing metrics in NetworkMetrics a bit.\r\nMisc classes: NetworkClientFactory, NetworkClientTest, MockNetworkClientFactory, \r\n\r\nMisc: 2 mins\r\nHistogramMeasurement: New public class which was earlier an inner class in ServerMetrics. Since the NetworkClient uses it, had to do this.\r\nMisc class: ServerMetrics","created_at":"2016-05-24T05:23:42Z","updated_at":"2016-05-27T02:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76b24c7f6d888195444509b8fd2e87a23cea2c8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/331/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/331/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/331/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/dc860cfed60c8aa776570f241a79e425f5fc7b50","head":{"label":"nsivabalan:networkClientMetrics","ref":"networkClientMetrics","sha":"dc860cfed60c8aa776570f241a79e425f5fc7b50","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"repo":{"id":20119917,"name":"ambry","full_name":"nsivabalan/ambry","owner":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsivabalan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/nsivabalan/ambry","forks_url":"https://api.github.com/repos/nsivabalan/ambry/forks","keys_url":"https://api.github.com/repos/nsivabalan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsivabalan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsivabalan/ambry/teams","hooks_url":"https://api.github.com/repos/nsivabalan/ambry/hooks","issue_events_url":"https://api.github.com/repos/nsivabalan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/nsivabalan/ambry/events","assignees_url":"https://api.github.com/repos/nsivabalan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/nsivabalan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/nsivabalan/ambry/tags","blobs_url":"https://api.github.com/repos/nsivabalan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsivabalan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsivabalan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsivabalan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsivabalan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/nsivabalan/ambry/languages","stargazers_url":"https://api.github.com/repos/nsivabalan/ambry/stargazers","contributors_url":"https://api.github.com/repos/nsivabalan/ambry/contributors","subscribers_url":"https://api.github.com/repos/nsivabalan/ambry/subscribers","subscription_url":"https://api.github.com/repos/nsivabalan/ambry/subscription","commits_url":"https://api.github.com/repos/nsivabalan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsivabalan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsivabalan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsivabalan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsivabalan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/nsivabalan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsivabalan/ambry/merges","archive_url":"https://api.github.com/repos/nsivabalan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsivabalan/ambry/downloads","issues_url":"https://api.github.com/repos/nsivabalan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/nsivabalan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/nsivabalan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/nsivabalan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsivabalan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/nsivabalan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/nsivabalan/ambry/deployments","created_at":"2014-05-24T02:15:09Z","updated_at":"2016-05-04T20:45:58Z","pushed_at":"2016-05-25T17:47:59Z","git_url":"git://github.com/nsivabalan/ambry.git","ssh_url":"git@github.com:nsivabalan/ambry.git","clone_url":"https://github.com/nsivabalan/ambry.git","svn_url":"https://github.com/nsivabalan/ambry","homepage":null,"size":6730,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"b71aeb4bd8c0fcb3490940a0b474fe812d1724da","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2016-05-27T01:18:16Z","pushed_at":"2016-05-27T01:30:12Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":7112,"stargazers_count":419,"watchers_count":419,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":26,"forks":41,"open_issues":26,"watchers":419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/331"},"html":{"href":"https://github.com/linkedin/ambry/pull/331"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/331"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/dc860cfed60c8aa776570f241a79e425f5fc7b50"}}}}
{"actor":{"display_login":"vgkholla"}}