{"action":"created","issue":{"url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/78","repository_url":"https://api.github.com/repos/silinternational/ecs-deploy","labels_url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/78/comments","events_url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/78/events","html_url":"https://github.com/silinternational/ecs-deploy/pull/78","id":185631576,"number":78,"title":"Fix missing `taskRoleArn` parameter in new defintion","user":{"login":"mirague","id":178117,"avatar_url":"https://avatars.githubusercontent.com/u/178117?v=3","gravatar_id":"","url":"https://api.github.com/users/mirague","html_url":"https://github.com/mirague","followers_url":"https://api.github.com/users/mirague/followers","following_url":"https://api.github.com/users/mirague/following{/other_user}","gists_url":"https://api.github.com/users/mirague/gists{/gist_id}","starred_url":"https://api.github.com/users/mirague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirague/subscriptions","organizations_url":"https://api.github.com/users/mirague/orgs","repos_url":"https://api.github.com/users/mirague/repos","events_url":"https://api.github.com/users/mirague/events{/privacy}","received_events_url":"https://api.github.com/users/mirague/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-27T10:33:56Z","updated_at":"2016-10-27T14:52:09Z","closed_at":"2016-10-27T14:51:33Z","pull_request":{"url":"https://api.github.com/repos/silinternational/ecs-deploy/pulls/78","html_url":"https://github.com/silinternational/ecs-deploy/pull/78","diff_url":"https://github.com/silinternational/ecs-deploy/pull/78.diff","patch_url":"https://github.com/silinternational/ecs-deploy/pull/78.patch"},"body":"### Remove filtering when retrieving the entire task definition\r\nBy passing in the filter to `jq '.taskDefinition'` the `taskRoleArn` values are lost. The filter seems to be a legacy artifact, as the code-block underneath already checks for both `networkMode` and `taskRoleArn` and includes them in the new task definition when present in the old one.\r\n\r\nAddresses issue #76."},"comment":{"url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/comments/256664322","html_url":"https://github.com/silinternational/ecs-deploy/pull/78#issuecomment-256664322","issue_url":"https://api.github.com/repos/silinternational/ecs-deploy/issues/78","id":256664322,"user":{"login":"fillup","id":556105,"avatar_url":"https://avatars.githubusercontent.com/u/556105?v=3","gravatar_id":"","url":"https://api.github.com/users/fillup","html_url":"https://github.com/fillup","followers_url":"https://api.github.com/users/fillup/followers","following_url":"https://api.github.com/users/fillup/following{/other_user}","gists_url":"https://api.github.com/users/fillup/gists{/gist_id}","starred_url":"https://api.github.com/users/fillup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fillup/subscriptions","organizations_url":"https://api.github.com/users/fillup/orgs","repos_url":"https://api.github.com/users/fillup/repos","events_url":"https://api.github.com/users/fillup/events{/privacy}","received_events_url":"https://api.github.com/users/fillup/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T14:52:09Z","updated_at":"2016-10-27T14:52:09Z","body":"Thanks @mirague"}}
{"actor":{"display_login":"fillup"}}