{"push_id":1396668385,"size":58,"distinct_size":2,"ref":"refs/heads/dynamic-metadata","head":"5378558abc1690b37fd6fe7d28da95acbbf16d74","before":"c1f635e014377d9986a83677c931368b60702737","commits":[{"sha":"b85673ba39a5237ee22d476d2694e29e7c375669","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"*: replace err.Error() with err\n\nIn principle we should avoid returning err.Error(). Instead we should\njust return err, to be able to inspect the error in a flexible way.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/b85673ba39a5237ee22d476d2694e29e7c375669"},{"sha":"c27234a16bd9ca6f127e310c36041a1bae732b67","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"engine: check for an exact error code from etcd\n\nrpcRenewLeadership() should check for an exact error code from etcd,\nEcodeKeyNotFound, instead of comparing error string with a particular\nstring pattern. Doing that, we can also avoid using err.Error().","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/c27234a16bd9ca6f127e310c36041a1bae732b67"},{"sha":"dbc9102225be80c7857eed608c821dbff5be4346","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"vendor: add github.com/coreos/etcd/error\n\nAdd github.com/coreos/etcd/error for dependencies.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/dbc9102225be80c7857eed608c821dbff5be4346"},{"sha":"6ff839c8fc8d894f3212bf845417dd47d214bdd4","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"functional: skip TestReplaceSerialization for now\n\nAs on semaphoreci TestReplaceSerialization() started to fail much\nfrequently than before, it's a huge pain to make it succeed every time.\nThe failure brings a negative impact on productivity. So skip the\nentire test for now.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/6ff839c8fc8d894f3212bf845417dd47d214bdd4"},{"sha":"fa5aa3aa706baf3c07d679a082ff8018b79704ee","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1670 from endocode/dongsu/cleanup-error-method\n\n*: avoid using err.Error()","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/fa5aa3aa706baf3c07d679a082ff8018b79704ee"},{"sha":"8c9401b0ce35b210d68dbd5d63ce61311ce4c483","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1674 from endocode/dongsu/remove-replace-serial-fxtests\n\nfunctional: skip TestReplaceSerialization for now","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/8c9401b0ce35b210d68dbd5d63ce61311ce4c483"},{"sha":"853ce4857bb28105cb40fa3fb51c4930ddac3c3e","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"scripts: make schema-generator prepend license headers to *.go files\n\nAs each *.go file must have a license header, the schema-generator\nscript should also prepend license headers for both v1-json.go and\nv1-gen.go.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/853ce4857bb28105cb40fa3fb51c4930ddac3c3e"},{"sha":"5e48a6735301403bf8fe952e4932d9ff865b832e","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"travis: bump go 1.7 to 1.7.1","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/5e48a6735301403bf8fe952e4932d9ff865b832e"},{"sha":"d7cb2c3dc332403935f6ac59f652798adb1acf04","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"functional: bump go from 1.7 to 1.7.1","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/d7cb2c3dc332403935f6ac59f652798adb1acf04"},{"sha":"b0a7b5ea3a952411dd49038a087eaba5b6bba521","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1678 from endocode/dongsu/schema-gen-license-header\n\nscripts,golang: update schema-generator, bump golang to 1.7.1","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/b0a7b5ea3a952411dd49038a087eaba5b6bba521"},{"sha":"895b435823e2ac1a63ab98b9b59505a1fed8ca8d","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"fleetd,main: make github.com/coreos/fleet go-getable\n\nSo far it hasn't been possible to do \"go get github.com/coreos/fleet\"\nbecause there was no main.go in the top source directory.\nCreate main.go, a simple wrapper for fleetd to make it \"go-getable\".","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/895b435823e2ac1a63ab98b9b59505a1fed8ca8d"},{"sha":"ca8ad6ee1cd839afd808b688b5f742e73ecda505","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"build: change path to fleetd into the top source directory\n\nNow that fleetd/fleetd.go doesn't have main(), we need to make the\ndefault build script run go build on the top source directory, instead\nof ./fleetd/. Then it will end up building fleetd, as main() in main.go\nimports fleetd.Main() by default.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/ca8ad6ee1cd839afd808b688b5f742e73ecda505"},{"sha":"4a726363274a1a13bbc356156afd2c267ded3f48","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1681 from endocode/dongsu/fleetd-main-go-getable\n\nfleetd,main: make github.com/coreos/fleet go-getable","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/4a726363274a1a13bbc356156afd2c267ded3f48"},{"sha":"3c8e5c14faf5885effb0cc4fe72f5b0675037b1d","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Documentation: fix unavailable rkt options in examples\n\nApparently rkt doesn't support a single dash in its option\nany more. For example, \"rkt -volume\" doesn't work any more.\nUse double dash instead: \"rkt --volume\"\n\nAlso --insecure-skip-verify doesn't exist.\nUse --insecure-options=image instead.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/3c8e5c14faf5885effb0cc4fe72f5b0675037b1d"},{"sha":"39c7d4beec9cd5d189cc5b4b3fe3eb2579d7e377","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1683 from endocode/dongsu/docs-fix-rkt-options\n\nDocumentation: fix unavailable rkt options in examples","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/39c7d4beec9cd5d189cc5b4b3fe3eb2579d7e377"},{"sha":"37c87c2cb3b3e19b2662285a8559fef38c03f48b","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"scripts: move build-aci to scripts\n\nTo avoid confusion with ./build, we'd better have build-aci under\n./scripts directory.","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/37c87c2cb3b3e19b2662285a8559fef38c03f48b"},{"sha":"de1a0643841ee8a9efb237d98bfa0e1a8e1534e8","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"scripts: build ACI image using acbuild\n\nVarious changes on build-aci.\n\n* Use acbuild command for building the ACI image.\n* Remove unnecessary docker command. Actually we could build ACI\n  image without relying on docker, just like etcd does.\n* Remove unnecessary manifest definition, as it's automatically\n  generated by acbuild.\n* Improve the cleanup path using acbuildEnd().\n* Allow TCP ports 2379,4001 for etcd\n\nHow to test, for example:\n\n$ ./scripts/build-aci v0.12.0-amd64\n$ sudo rkt run --insecure-options=image \\\n  --stage1-name=coreos.com/rkt/stage1-fly:1.14.0 --inherit-env \\\n  --volume etc-fleet,kind=host,source=/etc/fleet \\\n  --volume machine-id,kind=host,source=/etc/machine-id \\\n  --volume dbus-socket,kind=host,source=/run/dbus/system_bus_socket \\\n  --volume fleet-units,kind=host,source=/run/fleet/units \\\n  ./fleetd-v0.12.0-amd64.aci","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/de1a0643841ee8a9efb237d98bfa0e1a8e1534e8"},{"sha":"e7f7f482d81329b5f72777bcc63f0b58cd2f503b","author":{"name":"Vito Caputo","email":"d082f07d33b760cb061a84655c39eca0a635bbff@coreos.com"},"message":"engine: remove vestigial trigger code","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/e7f7f482d81329b5f72777bcc63f0b58cd2f503b"},{"sha":"015aa0b53299a49f5c315f95578e1a358657e8df","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"Merge pull request #1684 from vcaputo/remove_unused_trigger\n\nengine: remove vestigial trigger code","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/015aa0b53299a49f5c315f95578e1a358657e8df"},{"sha":"07d31ce5e54803d98f2f370b24cd35395d0f6c29","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"fleetctl: fix up minor style issues\n\nTo be as idiomatic as possible, do so:\n\n  * make tryWaitForSystemdActiveState() return error instead of int\n  * pass getBlockAttempts(cCmd) to tryWaitForSystemdActiveState()\n    to handle such cases of --no-block or --block-attempts.\n  * make assertSystemdActiveState(), waitForSystemdActiveState() return\n    just error, not with 'found', as it's unnecessary.\n  * remove unnecessary checking against conn == nil.\n  * compare strings with '!=' instead of strings.Compare() != 0","distinct":false,"url":"https://api.github.com/repos/dalbani/fleet/commits/07d31ce5e54803d98f2f370b24cd35395d0f6c29"}]}
{"actor":{"display_login":"dalbani"}}