{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/55243459","id":55243459,"diff_hunk":"@@ -40,16 +40,15 @@ namespace ts.JsTyping {\n     export function discoverTypings(\r\n         host: TypingResolutionHost,\r\n         fileNames: string[],\r\n-        cachePath: Path,\r\n         projectRootPath: Path,\r\n         safeListPath: Path,\r\n-        packageNameToTypingLocation: Map<string>,\r\n+        packageNameToTypingLocation: Map<Path>,\r\n         typingOptions: TypingOptions,\r\n         compilerOptions: CompilerOptions):\r\n-        { cachedTypingPaths: string[], newTypingNames: string[], filesToWatch: string[] } {\r\n+        { cachedTypingPaths: Path[], newTypingNames: string[], filesToWatch: string[] } {\r","path":"src/services/jsTyping.ts","position":34,"original_position":34,"commit_id":"68ece172ba1f084a72cd441d9d934c38e7f4b5cb","original_commit_id":"68ece172ba1f084a72cd441d9d934c38e7f4b5cb","user":{"login":"jramsay","id":8161247,"avatar_url":"https://avatars.githubusercontent.com/u/8161247?v=3","gravatar_id":"","url":"https://api.github.com/users/jramsay","html_url":"https://github.com/jramsay","followers_url":"https://api.github.com/users/jramsay/followers","following_url":"https://api.github.com/users/jramsay/following{/other_user}","gists_url":"https://api.github.com/users/jramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/jramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jramsay/subscriptions","organizations_url":"https://api.github.com/users/jramsay/orgs","repos_url":"https://api.github.com/users/jramsay/repos","events_url":"https://api.github.com/users/jramsay/events{/privacy}","received_events_url":"https://api.github.com/users/jramsay/received_events","type":"User","site_admin":false},"body":"As discussed, I'm no longer using the filesToWatch on the VS host side.  (It is also currently returning package.json paths that don't actually exist).  It looks like you don't need this either.  Can we remove this?","created_at":"2016-03-07T18:01:02Z","updated_at":"2016-03-07T18:01:02Z","html_url":"https://github.com/Microsoft/TypeScript/pull/7406#discussion_r55243459","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/55243459"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/7406#discussion_r55243459"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406","id":61830577,"html_url":"https://github.com/Microsoft/TypeScript/pull/7406","diff_url":"https://github.com/Microsoft/TypeScript/pull/7406.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/7406.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7406","number":7406,"state":"open","locked":false,"title":"[Salsa] Acquire d.ts for tsserver","user":{"login":"zhengbli","id":1171301,"avatar_url":"https://avatars.githubusercontent.com/u/1171301?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengbli","html_url":"https://github.com/zhengbli","followers_url":"https://api.github.com/users/zhengbli/followers","following_url":"https://api.github.com/users/zhengbli/following{/other_user}","gists_url":"https://api.github.com/users/zhengbli/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengbli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengbli/subscriptions","organizations_url":"https://api.github.com/users/zhengbli/orgs","repos_url":"https://api.github.com/users/zhengbli/repos","events_url":"https://api.github.com/users/zhengbli/events{/privacy}","received_events_url":"https://api.github.com/users/zhengbli/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-06T01:31:35Z","updated_at":"2016-03-07T18:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f548f0fdeabf6b0f67c5eec4d2e7eb09cbd4b83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7406/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/68ece172ba1f084a72cd441d9d934c38e7f4b5cb","head":{"label":"zhengbli:acquireDtsForTsserver","ref":"acquireDtsForTsserver","sha":"68ece172ba1f084a72cd441d9d934c38e7f4b5cb","user":{"login":"zhengbli","id":1171301,"avatar_url":"https://avatars.githubusercontent.com/u/1171301?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengbli","html_url":"https://github.com/zhengbli","followers_url":"https://api.github.com/users/zhengbli/followers","following_url":"https://api.github.com/users/zhengbli/following{/other_user}","gists_url":"https://api.github.com/users/zhengbli/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengbli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengbli/subscriptions","organizations_url":"https://api.github.com/users/zhengbli/orgs","repos_url":"https://api.github.com/users/zhengbli/repos","events_url":"https://api.github.com/users/zhengbli/events{/privacy}","received_events_url":"https://api.github.com/users/zhengbli/received_events","type":"User","site_admin":false},"repo":{"id":31636477,"name":"TypeScript","full_name":"zhengbli/TypeScript","owner":{"login":"zhengbli","id":1171301,"avatar_url":"https://avatars.githubusercontent.com/u/1171301?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengbli","html_url":"https://github.com/zhengbli","followers_url":"https://api.github.com/users/zhengbli/followers","following_url":"https://api.github.com/users/zhengbli/following{/other_user}","gists_url":"https://api.github.com/users/zhengbli/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengbli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengbli/subscriptions","organizations_url":"https://api.github.com/users/zhengbli/orgs","repos_url":"https://api.github.com/users/zhengbli/repos","events_url":"https://api.github.com/users/zhengbli/events{/privacy}","received_events_url":"https://api.github.com/users/zhengbli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhengbli/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/zhengbli/TypeScript","forks_url":"https://api.github.com/repos/zhengbli/TypeScript/forks","keys_url":"https://api.github.com/repos/zhengbli/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhengbli/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhengbli/TypeScript/teams","hooks_url":"https://api.github.com/repos/zhengbli/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/zhengbli/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/zhengbli/TypeScript/events","assignees_url":"https://api.github.com/repos/zhengbli/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/zhengbli/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/zhengbli/TypeScript/tags","blobs_url":"https://api.github.com/repos/zhengbli/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhengbli/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhengbli/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhengbli/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhengbli/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/zhengbli/TypeScript/languages","stargazers_url":"https://api.github.com/repos/zhengbli/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/zhengbli/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/zhengbli/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/zhengbli/TypeScript/subscription","commits_url":"https://api.github.com/repos/zhengbli/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhengbli/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhengbli/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhengbli/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhengbli/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/zhengbli/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhengbli/TypeScript/merges","archive_url":"https://api.github.com/repos/zhengbli/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhengbli/TypeScript/downloads","issues_url":"https://api.github.com/repos/zhengbli/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/zhengbli/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/zhengbli/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/zhengbli/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhengbli/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/zhengbli/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/zhengbli/TypeScript/deployments","created_at":"2015-03-04T03:41:12Z","updated_at":"2015-05-05T17:16:07Z","pushed_at":"2016-03-06T01:30:06Z","git_url":"git://github.com/zhengbli/TypeScript.git","ssh_url":"git@github.com:zhengbli/TypeScript.git","clone_url":"https://github.com/zhengbli/TypeScript.git","svn_url":"https://github.com/zhengbli/TypeScript","homepage":"http://www.typescriptlang.org","size":229067,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a5354608fcafd986dcede6aa9832431a23cd3cdf","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2016-03-07T15:44:47Z","pushed_at":"2016-03-06T21:59:20Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":477645,"stargazers_count":9822,"watchers_count":9822,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1205,"mirror_url":null,"open_issues_count":893,"forks":1205,"open_issues":893,"watchers":9822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/7406"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/7406"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/7406/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7406/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/68ece172ba1f084a72cd441d9d934c38e7f4b5cb"}}}}