{"action":"created","comment":{"url":"https://api.github.com/repos/zmap/zgrab/pulls/comments/77013922","id":77013922,"diff_hunk":"@@ -625,6 +637,44 @@ type Certificate struct {\n \tSignedCertificateTimestampList []*ct.SignedCertificateTimestamp\n }\n \n+type NoticeNumber []int\n+\n+type GeneralSubtreeString struct {\n+\tData string\n+\tMax  int","path":"ztools/x509/x509.go","position":46,"original_position":46,"commit_id":"02200fcc9a3397fa03022b5c675ea5d4e1a39595","original_commit_id":"02200fcc9a3397fa03022b5c675ea5d4e1a39595","user":{"login":"dadrian","id":1158264,"avatar_url":"https://avatars.githubusercontent.com/u/1158264?v=3","gravatar_id":"","url":"https://api.github.com/users/dadrian","html_url":"https://github.com/dadrian","followers_url":"https://api.github.com/users/dadrian/followers","following_url":"https://api.github.com/users/dadrian/following{/other_user}","gists_url":"https://api.github.com/users/dadrian/gists{/gist_id}","starred_url":"https://api.github.com/users/dadrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadrian/subscriptions","organizations_url":"https://api.github.com/users/dadrian/orgs","repos_url":"https://api.github.com/users/dadrian/repos","events_url":"https://api.github.com/users/dadrian/events{/privacy}","received_events_url":"https://api.github.com/users/dadrian/received_events","type":"User","site_admin":false},"body":"What are the significance of `Max` and `Min`?","created_at":"2016-08-31T15:48:56Z","updated_at":"2016-08-31T15:48:56Z","html_url":"https://github.com/zmap/zgrab/pull/174#discussion_r77013922","pull_request_url":"https://api.github.com/repos/zmap/zgrab/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/comments/77013922"},"html":{"href":"https://github.com/zmap/zgrab/pull/174#discussion_r77013922"},"pull_request":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/zmap/zgrab/pulls/174","id":82992359,"html_url":"https://github.com/zmap/zgrab/pull/174","diff_url":"https://github.com/zmap/zgrab/pull/174.diff","patch_url":"https://github.com/zmap/zgrab/pull/174.patch","issue_url":"https://api.github.com/repos/zmap/zgrab/issues/174","number":174,"state":"open","locked":false,"title":"Pull Request: adding more name constraints support, and some bug fixes.","user":{"login":"zhengping12","id":11322882,"avatar_url":"https://avatars.githubusercontent.com/u/11322882?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengping12","html_url":"https://github.com/zhengping12","followers_url":"https://api.github.com/users/zhengping12/followers","following_url":"https://api.github.com/users/zhengping12/following{/other_user}","gists_url":"https://api.github.com/users/zhengping12/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengping12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengping12/subscriptions","organizations_url":"https://api.github.com/users/zhengping12/orgs","repos_url":"https://api.github.com/users/zhengping12/repos","events_url":"https://api.github.com/users/zhengping12/events{/privacy}","received_events_url":"https://api.github.com/users/zhengping12/received_events","type":"User","site_admin":false},"body":"x509.go: \r\nadded name constraints parsing for EdiPartyName, x400Address, DirectoryName, and RegisteredIds\r\nwrapped the name constraint field along with a maximum and minimum in structs\r\nextensions.go:\r\nadded more support to marshalJson and unmarshalJson of name contraints.\r\nfixed two bugs in the previous existing marshalJson code\r\nverify.go:\r\nmodified name constraint types to match the change in x509.go\r\nextensions_test.go:\r\nadded condition to skip hidden files from test certs list, to avoid the program reading .DS_Store file on macs.\r\nadded name constraint marshalJson and unmarshalJson test\r\njson_test.go:\r\nadded condition to skip hidden files from test certs list, to avoid the program reading .DS_Store file on macs.\r\n","created_at":"2016-08-27T16:38:26Z","updated_at":"2016-08-31T15:48:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61b1a8b9d45da9b88659d08f4a649818c74a8296","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zmap/zgrab/pulls/174/commits","review_comments_url":"https://api.github.com/repos/zmap/zgrab/pulls/174/comments","review_comment_url":"https://api.github.com/repos/zmap/zgrab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zmap/zgrab/issues/174/comments","statuses_url":"https://api.github.com/repos/zmap/zgrab/statuses/02200fcc9a3397fa03022b5c675ea5d4e1a39595","head":{"label":"teamnsrg:master","ref":"master","sha":"02200fcc9a3397fa03022b5c675ea5d4e1a39595","user":{"login":"teamnsrg","id":19825086,"avatar_url":"https://avatars.githubusercontent.com/u/19825086?v=3","gravatar_id":"","url":"https://api.github.com/users/teamnsrg","html_url":"https://github.com/teamnsrg","followers_url":"https://api.github.com/users/teamnsrg/followers","following_url":"https://api.github.com/users/teamnsrg/following{/other_user}","gists_url":"https://api.github.com/users/teamnsrg/gists{/gist_id}","starred_url":"https://api.github.com/users/teamnsrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamnsrg/subscriptions","organizations_url":"https://api.github.com/users/teamnsrg/orgs","repos_url":"https://api.github.com/users/teamnsrg/repos","events_url":"https://api.github.com/users/teamnsrg/events{/privacy}","received_events_url":"https://api.github.com/users/teamnsrg/received_events","type":"Organization","site_admin":false},"repo":{"id":64332138,"name":"zgrab","full_name":"teamnsrg/zgrab","owner":{"login":"teamnsrg","id":19825086,"avatar_url":"https://avatars.githubusercontent.com/u/19825086?v=3","gravatar_id":"","url":"https://api.github.com/users/teamnsrg","html_url":"https://github.com/teamnsrg","followers_url":"https://api.github.com/users/teamnsrg/followers","following_url":"https://api.github.com/users/teamnsrg/following{/other_user}","gists_url":"https://api.github.com/users/teamnsrg/gists{/gist_id}","starred_url":"https://api.github.com/users/teamnsrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamnsrg/subscriptions","organizations_url":"https://api.github.com/users/teamnsrg/orgs","repos_url":"https://api.github.com/users/teamnsrg/repos","events_url":"https://api.github.com/users/teamnsrg/events{/privacy}","received_events_url":"https://api.github.com/users/teamnsrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamnsrg/zgrab","description":"Application layer scanner that operates with ZMap","fork":true,"url":"https://api.github.com/repos/teamnsrg/zgrab","forks_url":"https://api.github.com/repos/teamnsrg/zgrab/forks","keys_url":"https://api.github.com/repos/teamnsrg/zgrab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamnsrg/zgrab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamnsrg/zgrab/teams","hooks_url":"https://api.github.com/repos/teamnsrg/zgrab/hooks","issue_events_url":"https://api.github.com/repos/teamnsrg/zgrab/issues/events{/number}","events_url":"https://api.github.com/repos/teamnsrg/zgrab/events","assignees_url":"https://api.github.com/repos/teamnsrg/zgrab/assignees{/user}","branches_url":"https://api.github.com/repos/teamnsrg/zgrab/branches{/branch}","tags_url":"https://api.github.com/repos/teamnsrg/zgrab/tags","blobs_url":"https://api.github.com/repos/teamnsrg/zgrab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamnsrg/zgrab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamnsrg/zgrab/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamnsrg/zgrab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamnsrg/zgrab/statuses/{sha}","languages_url":"https://api.github.com/repos/teamnsrg/zgrab/languages","stargazers_url":"https://api.github.com/repos/teamnsrg/zgrab/stargazers","contributors_url":"https://api.github.com/repos/teamnsrg/zgrab/contributors","subscribers_url":"https://api.github.com/repos/teamnsrg/zgrab/subscribers","subscription_url":"https://api.github.com/repos/teamnsrg/zgrab/subscription","commits_url":"https://api.github.com/repos/teamnsrg/zgrab/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamnsrg/zgrab/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamnsrg/zgrab/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamnsrg/zgrab/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamnsrg/zgrab/contents/{+path}","compare_url":"https://api.github.com/repos/teamnsrg/zgrab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamnsrg/zgrab/merges","archive_url":"https://api.github.com/repos/teamnsrg/zgrab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamnsrg/zgrab/downloads","issues_url":"https://api.github.com/repos/teamnsrg/zgrab/issues{/number}","pulls_url":"https://api.github.com/repos/teamnsrg/zgrab/pulls{/number}","milestones_url":"https://api.github.com/repos/teamnsrg/zgrab/milestones{/number}","notifications_url":"https://api.github.com/repos/teamnsrg/zgrab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamnsrg/zgrab/labels{/name}","releases_url":"https://api.github.com/repos/teamnsrg/zgrab/releases{/id}","deployments_url":"https://api.github.com/repos/teamnsrg/zgrab/deployments","created_at":"2016-07-27T18:25:05Z","updated_at":"2016-07-27T18:25:06Z","pushed_at":"2016-08-30T23:45:57Z","git_url":"git://github.com/teamnsrg/zgrab.git","ssh_url":"git@github.com:teamnsrg/zgrab.git","clone_url":"https://github.com/teamnsrg/zgrab.git","svn_url":"https://github.com/teamnsrg/zgrab","homepage":"","size":2243,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zmap:master","ref":"master","sha":"bb14ac8ccd08dc9ed57834709ced7b35ff9640e6","user":{"login":"zmap","id":3345672,"avatar_url":"https://avatars.githubusercontent.com/u/3345672?v=3","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"repo":{"id":18019738,"name":"zgrab","full_name":"zmap/zgrab","owner":{"login":"zmap","id":3345672,"avatar_url":"https://avatars.githubusercontent.com/u/3345672?v=3","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zmap/zgrab","description":"Application layer scanner that operates with ZMap","fork":false,"url":"https://api.github.com/repos/zmap/zgrab","forks_url":"https://api.github.com/repos/zmap/zgrab/forks","keys_url":"https://api.github.com/repos/zmap/zgrab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmap/zgrab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmap/zgrab/teams","hooks_url":"https://api.github.com/repos/zmap/zgrab/hooks","issue_events_url":"https://api.github.com/repos/zmap/zgrab/issues/events{/number}","events_url":"https://api.github.com/repos/zmap/zgrab/events","assignees_url":"https://api.github.com/repos/zmap/zgrab/assignees{/user}","branches_url":"https://api.github.com/repos/zmap/zgrab/branches{/branch}","tags_url":"https://api.github.com/repos/zmap/zgrab/tags","blobs_url":"https://api.github.com/repos/zmap/zgrab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmap/zgrab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmap/zgrab/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmap/zgrab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmap/zgrab/statuses/{sha}","languages_url":"https://api.github.com/repos/zmap/zgrab/languages","stargazers_url":"https://api.github.com/repos/zmap/zgrab/stargazers","contributors_url":"https://api.github.com/repos/zmap/zgrab/contributors","subscribers_url":"https://api.github.com/repos/zmap/zgrab/subscribers","subscription_url":"https://api.github.com/repos/zmap/zgrab/subscription","commits_url":"https://api.github.com/repos/zmap/zgrab/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmap/zgrab/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmap/zgrab/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmap/zgrab/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmap/zgrab/contents/{+path}","compare_url":"https://api.github.com/repos/zmap/zgrab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmap/zgrab/merges","archive_url":"https://api.github.com/repos/zmap/zgrab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmap/zgrab/downloads","issues_url":"https://api.github.com/repos/zmap/zgrab/issues{/number}","pulls_url":"https://api.github.com/repos/zmap/zgrab/pulls{/number}","milestones_url":"https://api.github.com/repos/zmap/zgrab/milestones{/number}","notifications_url":"https://api.github.com/repos/zmap/zgrab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmap/zgrab/labels{/name}","releases_url":"https://api.github.com/repos/zmap/zgrab/releases{/id}","deployments_url":"https://api.github.com/repos/zmap/zgrab/deployments","created_at":"2014-03-22T21:03:26Z","updated_at":"2016-08-26T05:08:07Z","pushed_at":"2016-08-31T05:01:10Z","git_url":"git://github.com/zmap/zgrab.git","ssh_url":"git@github.com:zmap/zgrab.git","clone_url":"https://github.com/zmap/zgrab.git","svn_url":"https://github.com/zmap/zgrab","homepage":"","size":3043,"stargazers_count":164,"watchers_count":164,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":50,"forks":49,"open_issues":50,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/174"},"html":{"href":"https://github.com/zmap/zgrab/pull/174"},"issue":{"href":"https://api.github.com/repos/zmap/zgrab/issues/174"},"comments":{"href":"https://api.github.com/repos/zmap/zgrab/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/zmap/zgrab/statuses/02200fcc9a3397fa03022b5c675ea5d4e1a39595"}}}}
{"actor":{"display_login":"dadrian"}}