{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/7337","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/7337/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7337/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/7337/events","html_url":"https://github.com/dotnet/corefx/pull/7337","id":144419312,"number":7337,"title":"Add more tests for HttpClient","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/System.Net","name":"System.Net","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-29T23:35:22Z","updated_at":"2016-03-30T01:33:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7337","html_url":"https://github.com/dotnet/corefx/pull/7337","diff_url":"https://github.com/dotnet/corefx/pull/7337.diff","patch_url":"https://github.com/dotnet/corefx/pull/7337.patch"},"body":"To have more confidence while refactoring (https://github.com/dotnet/corefx/pull/7315), added more HttpClient coverage, in particular of error paths.  Brings HttpClient line coverage from 64.7% to 98.3%, and branch coverage from 42.3% to 78.7%.\r\n\r\ncc: @davidsh, @cipop, @ericeil, @kapilash"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/203184444","html_url":"https://github.com/dotnet/corefx/pull/7337#issuecomment-203184444","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7337","id":203184444,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T01:33:32Z","updated_at":"2016-03-30T01:33:32Z","body":"> Some of the new tests are will take 60 seconds to complete. \r\n\r\nThey complete almost immediately: the tests that do this all immediately cancel the operations. \r\n\r\n> Some of the added tests duplicate coverage we already had (I thought) in the UnitTests of HttpClient. \r\n\r\nIn that case I can just close this, if you believe the coverage is already sufficient. If they need to be rewritten, rather than doing so I can just use these tests for my original purpose, helping to validate those refactorings, and they don't actually need to be checked in."}}