{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/examples/pulls/comments/90030091","pull_request_review_id":10555669,"id":90030091,"diff_hunk":"@@ -0,0 +1,24 @@\n+cmake_minimum_required(VERSION 3.5)\n+project(examples_rclcpp_minimal_publisher)\n+find_package(ament_cmake REQUIRED)\n+find_package(rclcpp REQUIRED)\n+find_package(std_msgs REQUIRED)\n+if (NOT WIN32)\n+  set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra\")\n+endif()\n+\n+add_executable(${PROJECT_NAME}_lambda lambda.cpp)\n+ament_target_dependencies(${PROJECT_NAME}_lambda rclcpp std_msgs)\n+\n+add_executable(${PROJECT_NAME}_member_function member_function.cpp)\n+ament_target_dependencies(${PROJECT_NAME}_member_function rclcpp std_msgs)\n+\n+add_executable(${PROJECT_NAME}_not_composable not_composable.cpp)\n+ament_target_dependencies(${PROJECT_NAME}_not_composable rclcpp std_msgs)\n+\n+install(TARGETS ${PROJECT_NAME}_lambda\n+                ${PROJECT_NAME}_member_function\n+                ${PROJECT_NAME}_not_composable\n+        DESTINATION bin)","path":"rclcpp/minimal_publisher/CMakeLists.txt","position":22,"original_position":22,"commit_id":"4fc7dd4244cf02567d6fbffe2088163a779b0309","original_commit_id":"4fc7dd4244cf02567d6fbffe2088163a779b0309","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Please avoid aligned indentation.","created_at":"2016-11-29T15:21:23Z","updated_at":"2016-11-29T15:21:23Z","html_url":"https://github.com/ros2/examples/pull/137#discussion_r90030091","pull_request_url":"https://api.github.com/repos/ros2/examples/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/ros2/examples/pulls/comments/90030091"},"html":{"href":"https://github.com/ros2/examples/pull/137#discussion_r90030091"},"pull_request":{"href":"https://api.github.com/repos/ros2/examples/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/examples/pulls/137","id":94914481,"html_url":"https://github.com/ros2/examples/pull/137","diff_url":"https://github.com/ros2/examples/pull/137.diff","patch_url":"https://github.com/ros2/examples/pull/137.patch","issue_url":"https://api.github.com/repos/ros2/examples/issues/137","number":137,"state":"open","locked":false,"title":"add examples_ prefix to package names to avoid future collisions","user":{"login":"codebot","id":5263834,"avatar_url":"https://avatars.githubusercontent.com/u/5263834?v=3","gravatar_id":"","url":"https://api.github.com/users/codebot","html_url":"https://github.com/codebot","followers_url":"https://api.github.com/users/codebot/followers","following_url":"https://api.github.com/users/codebot/following{/other_user}","gists_url":"https://api.github.com/users/codebot/gists{/gist_id}","starred_url":"https://api.github.com/users/codebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebot/subscriptions","organizations_url":"https://api.github.com/users/codebot/orgs","repos_url":"https://api.github.com/users/codebot/repos","events_url":"https://api.github.com/users/codebot/events{/privacy}","received_events_url":"https://api.github.com/users/codebot/received_events","type":"User","site_admin":false},"body":"Some of the package names we're coming up with in the `examples` repo are pretty generic. Prefixing them with `examples_` will reduce the likelihood of colliding with other package names.","created_at":"2016-11-22T22:51:00Z","updated_at":"2016-11-29T15:21:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3db31c07e79b26d26b88ed746ff47c5088d3c33","assignee":{"login":"codebot","id":5263834,"avatar_url":"https://avatars.githubusercontent.com/u/5263834?v=3","gravatar_id":"","url":"https://api.github.com/users/codebot","html_url":"https://github.com/codebot","followers_url":"https://api.github.com/users/codebot/followers","following_url":"https://api.github.com/users/codebot/following{/other_user}","gists_url":"https://api.github.com/users/codebot/gists{/gist_id}","starred_url":"https://api.github.com/users/codebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebot/subscriptions","organizations_url":"https://api.github.com/users/codebot/orgs","repos_url":"https://api.github.com/users/codebot/repos","events_url":"https://api.github.com/users/codebot/events{/privacy}","received_events_url":"https://api.github.com/users/codebot/received_events","type":"User","site_admin":false},"assignees":[{"login":"codebot","id":5263834,"avatar_url":"https://avatars.githubusercontent.com/u/5263834?v=3","gravatar_id":"","url":"https://api.github.com/users/codebot","html_url":"https://github.com/codebot","followers_url":"https://api.github.com/users/codebot/followers","following_url":"https://api.github.com/users/codebot/following{/other_user}","gists_url":"https://api.github.com/users/codebot/gists{/gist_id}","starred_url":"https://api.github.com/users/codebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebot/subscriptions","organizations_url":"https://api.github.com/users/codebot/orgs","repos_url":"https://api.github.com/users/codebot/repos","events_url":"https://api.github.com/users/codebot/events{/privacy}","received_events_url":"https://api.github.com/users/codebot/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/examples/pulls/137/commits","review_comments_url":"https://api.github.com/repos/ros2/examples/pulls/137/comments","review_comment_url":"https://api.github.com/repos/ros2/examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/examples/issues/137/comments","statuses_url":"https://api.github.com/repos/ros2/examples/statuses/4fc7dd4244cf02567d6fbffe2088163a779b0309","head":{"label":"ros2:prefix_package_names","ref":"prefix_package_names","sha":"4fc7dd4244cf02567d6fbffe2088163a779b0309","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":21909749,"name":"examples","full_name":"ros2/examples","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/examples","description":"Example packages for ROS2","fork":false,"url":"https://api.github.com/repos/ros2/examples","forks_url":"https://api.github.com/repos/ros2/examples/forks","keys_url":"https://api.github.com/repos/ros2/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/examples/teams","hooks_url":"https://api.github.com/repos/ros2/examples/hooks","issue_events_url":"https://api.github.com/repos/ros2/examples/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/examples/events","assignees_url":"https://api.github.com/repos/ros2/examples/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/examples/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/examples/tags","blobs_url":"https://api.github.com/repos/ros2/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/examples/languages","stargazers_url":"https://api.github.com/repos/ros2/examples/stargazers","contributors_url":"https://api.github.com/repos/ros2/examples/contributors","subscribers_url":"https://api.github.com/repos/ros2/examples/subscribers","subscription_url":"https://api.github.com/repos/ros2/examples/subscription","commits_url":"https://api.github.com/repos/ros2/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/examples/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/examples/merges","archive_url":"https://api.github.com/repos/ros2/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/examples/downloads","issues_url":"https://api.github.com/repos/ros2/examples/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/examples/labels{/name}","releases_url":"https://api.github.com/repos/ros2/examples/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/examples/deployments","created_at":"2014-07-16T17:11:20Z","updated_at":"2016-11-16T21:38:14Z","pushed_at":"2016-11-29T15:07:27Z","git_url":"git://github.com/ros2/examples.git","ssh_url":"git@github.com:ros2/examples.git","clone_url":"https://github.com/ros2/examples.git","svn_url":"https://github.com/ros2/examples","homepage":"https://github.com/ros2/examples/wiki","size":433,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":22,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"895843476f9a3f1180ac7d373fec48fe88ca8141","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":21909749,"name":"examples","full_name":"ros2/examples","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/examples","description":"Example packages for ROS2","fork":false,"url":"https://api.github.com/repos/ros2/examples","forks_url":"https://api.github.com/repos/ros2/examples/forks","keys_url":"https://api.github.com/repos/ros2/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/examples/teams","hooks_url":"https://api.github.com/repos/ros2/examples/hooks","issue_events_url":"https://api.github.com/repos/ros2/examples/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/examples/events","assignees_url":"https://api.github.com/repos/ros2/examples/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/examples/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/examples/tags","blobs_url":"https://api.github.com/repos/ros2/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/examples/languages","stargazers_url":"https://api.github.com/repos/ros2/examples/stargazers","contributors_url":"https://api.github.com/repos/ros2/examples/contributors","subscribers_url":"https://api.github.com/repos/ros2/examples/subscribers","subscription_url":"https://api.github.com/repos/ros2/examples/subscription","commits_url":"https://api.github.com/repos/ros2/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/examples/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/examples/merges","archive_url":"https://api.github.com/repos/ros2/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/examples/downloads","issues_url":"https://api.github.com/repos/ros2/examples/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/examples/labels{/name}","releases_url":"https://api.github.com/repos/ros2/examples/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/examples/deployments","created_at":"2014-07-16T17:11:20Z","updated_at":"2016-11-16T21:38:14Z","pushed_at":"2016-11-29T15:07:27Z","git_url":"git://github.com/ros2/examples.git","ssh_url":"git@github.com:ros2/examples.git","clone_url":"https://github.com/ros2/examples.git","svn_url":"https://github.com/ros2/examples","homepage":"https://github.com/ros2/examples/wiki","size":433,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/examples/pulls/137"},"html":{"href":"https://github.com/ros2/examples/pull/137"},"issue":{"href":"https://api.github.com/repos/ros2/examples/issues/137"},"comments":{"href":"https://api.github.com/repos/ros2/examples/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/examples/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/examples/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/examples/statuses/4fc7dd4244cf02567d6fbffe2088163a779b0309"}}}}
{"actor":{"display_login":"dirk-thomas"}}