{"action":"created","comment":{"url":"https://api.github.com/repos/Clever/saml2/pulls/comments/73467794","id":73467794,"diff_hunk":"@@ -459,6 +463,46 @@ describe 'saml2', ->\n         assert.deepEqual response, expected_response\n         done()\n \n+    it 'correctly parses an AuthnStatement with no session_index', (done) ->","path":"test/saml2.coffee","position":15,"original_position":15,"commit_id":"ad754235019770779ac51c2e2025e08b4014b0f2","original_commit_id":"ad754235019770779ac51c2e2025e08b4014b0f2","user":{"login":"cozmo","id":696340,"avatar_url":"https://avatars.githubusercontent.com/u/696340?v=3","gravatar_id":"","url":"https://api.github.com/users/cozmo","html_url":"https://github.com/cozmo","followers_url":"https://api.github.com/users/cozmo/followers","following_url":"https://api.github.com/users/cozmo/following{/other_user}","gists_url":"https://api.github.com/users/cozmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cozmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozmo/subscriptions","organizations_url":"https://api.github.com/users/cozmo/orgs","repos_url":"https://api.github.com/users/cozmo/repos","events_url":"https://api.github.com/users/cozmo/events{/privacy}","received_events_url":"https://api.github.com/users/cozmo/received_events","type":"User","site_admin":false},"body":"Awesome to have a test 👌 . If you wanted to do the extra credit it would be great to have a test to ensure that it continues to _fail_ to parse if you don't set the `require_session_index` flag. ","created_at":"2016-08-04T06:24:09Z","updated_at":"2016-08-04T06:24:09Z","html_url":"https://github.com/Clever/saml2/pull/73#discussion_r73467794","pull_request_url":"https://api.github.com/repos/Clever/saml2/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/Clever/saml2/pulls/comments/73467794"},"html":{"href":"https://github.com/Clever/saml2/pull/73#discussion_r73467794"},"pull_request":{"href":"https://api.github.com/repos/Clever/saml2/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/Clever/saml2/pulls/73","id":79929679,"html_url":"https://github.com/Clever/saml2/pull/73","diff_url":"https://github.com/Clever/saml2/pull/73.diff","patch_url":"https://github.com/Clever/saml2/pull/73.patch","issue_url":"https://api.github.com/repos/Clever/saml2/issues/73","number":73,"state":"open","locked":false,"title":"SessionIndex optional","user":{"login":"jalleyne","id":163205,"avatar_url":"https://avatars.githubusercontent.com/u/163205?v=3","gravatar_id":"","url":"https://api.github.com/users/jalleyne","html_url":"https://github.com/jalleyne","followers_url":"https://api.github.com/users/jalleyne/followers","following_url":"https://api.github.com/users/jalleyne/following{/other_user}","gists_url":"https://api.github.com/users/jalleyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jalleyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalleyne/subscriptions","organizations_url":"https://api.github.com/users/jalleyne/orgs","repos_url":"https://api.github.com/users/jalleyne/repos","events_url":"https://api.github.com/users/jalleyne/events{/privacy}","received_events_url":"https://api.github.com/users/jalleyne/received_events","type":"User","site_admin":false},"body":"Make SessionIndex optional behind a parameter `require_session_index` in response to issue #62.","created_at":"2016-08-03T15:43:55Z","updated_at":"2016-08-04T06:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad2f12c4b1ec9991005d2276e3157f46712cea6f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Clever/saml2/pulls/73/commits","review_comments_url":"https://api.github.com/repos/Clever/saml2/pulls/73/comments","review_comment_url":"https://api.github.com/repos/Clever/saml2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clever/saml2/issues/73/comments","statuses_url":"https://api.github.com/repos/Clever/saml2/statuses/ad754235019770779ac51c2e2025e08b4014b0f2","head":{"label":"jalleyne:master","ref":"master","sha":"ad754235019770779ac51c2e2025e08b4014b0f2","user":{"login":"jalleyne","id":163205,"avatar_url":"https://avatars.githubusercontent.com/u/163205?v=3","gravatar_id":"","url":"https://api.github.com/users/jalleyne","html_url":"https://github.com/jalleyne","followers_url":"https://api.github.com/users/jalleyne/followers","following_url":"https://api.github.com/users/jalleyne/following{/other_user}","gists_url":"https://api.github.com/users/jalleyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jalleyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalleyne/subscriptions","organizations_url":"https://api.github.com/users/jalleyne/orgs","repos_url":"https://api.github.com/users/jalleyne/repos","events_url":"https://api.github.com/users/jalleyne/events{/privacy}","received_events_url":"https://api.github.com/users/jalleyne/received_events","type":"User","site_admin":false},"repo":{"id":64852136,"name":"saml2","full_name":"jalleyne/saml2","owner":{"login":"jalleyne","id":163205,"avatar_url":"https://avatars.githubusercontent.com/u/163205?v=3","gravatar_id":"","url":"https://api.github.com/users/jalleyne","html_url":"https://github.com/jalleyne","followers_url":"https://api.github.com/users/jalleyne/followers","following_url":"https://api.github.com/users/jalleyne/following{/other_user}","gists_url":"https://api.github.com/users/jalleyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jalleyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalleyne/subscriptions","organizations_url":"https://api.github.com/users/jalleyne/orgs","repos_url":"https://api.github.com/users/jalleyne/repos","events_url":"https://api.github.com/users/jalleyne/events{/privacy}","received_events_url":"https://api.github.com/users/jalleyne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jalleyne/saml2","description":"Node module to abstract away the complexities of the SAML protocol behind an easy to use interface.","fork":true,"url":"https://api.github.com/repos/jalleyne/saml2","forks_url":"https://api.github.com/repos/jalleyne/saml2/forks","keys_url":"https://api.github.com/repos/jalleyne/saml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalleyne/saml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalleyne/saml2/teams","hooks_url":"https://api.github.com/repos/jalleyne/saml2/hooks","issue_events_url":"https://api.github.com/repos/jalleyne/saml2/issues/events{/number}","events_url":"https://api.github.com/repos/jalleyne/saml2/events","assignees_url":"https://api.github.com/repos/jalleyne/saml2/assignees{/user}","branches_url":"https://api.github.com/repos/jalleyne/saml2/branches{/branch}","tags_url":"https://api.github.com/repos/jalleyne/saml2/tags","blobs_url":"https://api.github.com/repos/jalleyne/saml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalleyne/saml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalleyne/saml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalleyne/saml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalleyne/saml2/statuses/{sha}","languages_url":"https://api.github.com/repos/jalleyne/saml2/languages","stargazers_url":"https://api.github.com/repos/jalleyne/saml2/stargazers","contributors_url":"https://api.github.com/repos/jalleyne/saml2/contributors","subscribers_url":"https://api.github.com/repos/jalleyne/saml2/subscribers","subscription_url":"https://api.github.com/repos/jalleyne/saml2/subscription","commits_url":"https://api.github.com/repos/jalleyne/saml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalleyne/saml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalleyne/saml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalleyne/saml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalleyne/saml2/contents/{+path}","compare_url":"https://api.github.com/repos/jalleyne/saml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalleyne/saml2/merges","archive_url":"https://api.github.com/repos/jalleyne/saml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalleyne/saml2/downloads","issues_url":"https://api.github.com/repos/jalleyne/saml2/issues{/number}","pulls_url":"https://api.github.com/repos/jalleyne/saml2/pulls{/number}","milestones_url":"https://api.github.com/repos/jalleyne/saml2/milestones{/number}","notifications_url":"https://api.github.com/repos/jalleyne/saml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalleyne/saml2/labels{/name}","releases_url":"https://api.github.com/repos/jalleyne/saml2/releases{/id}","deployments_url":"https://api.github.com/repos/jalleyne/saml2/deployments","created_at":"2016-08-03T14:22:59Z","updated_at":"2016-08-03T14:23:00Z","pushed_at":"2016-08-03T19:28:37Z","git_url":"git://github.com/jalleyne/saml2.git","ssh_url":"git@github.com:jalleyne/saml2.git","clone_url":"https://github.com/jalleyne/saml2.git","svn_url":"https://github.com/jalleyne/saml2","homepage":"","size":231,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Clever:master","ref":"master","sha":"31f503077ad61af47830c9036607c9b61653305c","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":17650054,"name":"saml2","full_name":"Clever/saml2","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/saml2","description":"Node module to abstract away the complexities of the SAML protocol behind an easy to use interface.","fork":false,"url":"https://api.github.com/repos/Clever/saml2","forks_url":"https://api.github.com/repos/Clever/saml2/forks","keys_url":"https://api.github.com/repos/Clever/saml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/saml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/saml2/teams","hooks_url":"https://api.github.com/repos/Clever/saml2/hooks","issue_events_url":"https://api.github.com/repos/Clever/saml2/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/saml2/events","assignees_url":"https://api.github.com/repos/Clever/saml2/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/saml2/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/saml2/tags","blobs_url":"https://api.github.com/repos/Clever/saml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/saml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/saml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/saml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/saml2/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/saml2/languages","stargazers_url":"https://api.github.com/repos/Clever/saml2/stargazers","contributors_url":"https://api.github.com/repos/Clever/saml2/contributors","subscribers_url":"https://api.github.com/repos/Clever/saml2/subscribers","subscription_url":"https://api.github.com/repos/Clever/saml2/subscription","commits_url":"https://api.github.com/repos/Clever/saml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/saml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/saml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/saml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/saml2/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/saml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/saml2/merges","archive_url":"https://api.github.com/repos/Clever/saml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/saml2/downloads","issues_url":"https://api.github.com/repos/Clever/saml2/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/saml2/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/saml2/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/saml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/saml2/labels{/name}","releases_url":"https://api.github.com/repos/Clever/saml2/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/saml2/deployments","created_at":"2014-03-12T00:23:44Z","updated_at":"2016-08-02T10:14:45Z","pushed_at":"2016-08-03T15:43:55Z","git_url":"git://github.com/Clever/saml2.git","ssh_url":"git@github.com:Clever/saml2.git","clone_url":"https://github.com/Clever/saml2.git","svn_url":"https://github.com/Clever/saml2","homepage":"","size":289,"stargazers_count":41,"watchers_count":41,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":14,"forks":23,"open_issues":14,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clever/saml2/pulls/73"},"html":{"href":"https://github.com/Clever/saml2/pull/73"},"issue":{"href":"https://api.github.com/repos/Clever/saml2/issues/73"},"comments":{"href":"https://api.github.com/repos/Clever/saml2/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/Clever/saml2/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/Clever/saml2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clever/saml2/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/Clever/saml2/statuses/ad754235019770779ac51c2e2025e08b4014b0f2"}}}}
{"actor":{"display_login":"cozmo"}}