{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/60030321","id":60030321,"diff_hunk":"@@ -3046,6 +3046,26 @@ describe('input', function() {\n       expect(inputElm[0].getAttribute('value')).toBe('something');\n     });\n \n+    they('should update the $prop \"value\" property and attribute after change the \"value\" property', {\n+      input: '<input type=\"text\" ng-value=\"value\">',\n+      textarea: '<textarea ng-value=\"value\">></textarea>'\n+    }, function(tmpl) {\n+      var element = helper.compileInput(tmpl);\n+\n+      $rootScope.$apply(function() {\n+        $rootScope.value = 'something';\n+      });\n+      expect(element[0].value).toBe('something');\n+      expect(element[0].getAttribute('value')).toBe('something');\n+\n+      helper.changeInputValueTo('newValue');","path":"test/ng/directive/inputSpec.js","position":16,"original_position":16,"commit_id":"bffe7433e08b7f13767771932c4687dd7e9f327c","original_commit_id":"bffe7433e08b7f13767771932c4687dd7e9f327c","user":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"body":"Yes, you should add an expect. Otherwise you can't be sure that the input / scope has really been changed.","created_at":"2016-04-18T09:38:31Z","updated_at":"2016-04-18T09:38:31Z","html_url":"https://github.com/angular/angular.js/pull/14031#discussion_r60030321","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/14031","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/60030321"},"html":{"href":"https://github.com/angular/angular.js/pull/14031#discussion_r60030321"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14031"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/14031","id":59267492,"html_url":"https://github.com/angular/angular.js/pull/14031","diff_url":"https://github.com/angular/angular.js/pull/14031.diff","patch_url":"https://github.com/angular/angular.js/pull/14031.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/14031","number":14031,"state":"open","locked":false,"title":"fix(ngValue): set value property instead of attr","user":{"login":"m-amr","id":6197215,"avatar_url":"https://avatars.githubusercontent.com/u/6197215?v=3","gravatar_id":"","url":"https://api.github.com/users/m-amr","html_url":"https://github.com/m-amr","followers_url":"https://api.github.com/users/m-amr/followers","following_url":"https://api.github.com/users/m-amr/following{/other_user}","gists_url":"https://api.github.com/users/m-amr/gists{/gist_id}","starred_url":"https://api.github.com/users/m-amr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-amr/subscriptions","organizations_url":"https://api.github.com/users/m-amr/orgs","repos_url":"https://api.github.com/users/m-amr/repos","events_url":"https://api.github.com/users/m-amr/events{/privacy}","received_events_url":"https://api.github.com/users/m-amr/received_events","type":"User","site_admin":false},"body":"in case of input element set value using property instead of attribute\r\nfixed #13984","created_at":"2016-02-13T13:46:38Z","updated_at":"2016-04-18T09:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf8029c32d548b68ad36ac9f03e320abed434f5b","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/27","html_url":"https://github.com/angular/angular.js/milestones/Backlog","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/27/labels","id":489171,"number":27,"title":"Backlog","description":"Holds the backlog of issues and pull requests that have been triaged.\r\n\r\nBefore assigning items to this milestone they should be labelled, at the very least with the correct \"type\" label (i.e. \"issue\", \"pr\", \"bug\", \"regression\", \"chore\", \"docs\", etc).  Preferably you should also check for duplicate issues/PRs, note CLA status and assign \"complexity\" and \"impact\" labels too.","creator":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"open_issues":588,"closed_issues":1205,"state":"open","created_at":"2013-11-18T23:30:35Z","updated_at":"2016-04-17T20:34:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/14031/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/14031/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14031/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/bffe7433e08b7f13767771932c4687dd7e9f327c","head":{"label":"m-amr:fix_ng-value_locally","ref":"fix_ng-value_locally","sha":"bffe7433e08b7f13767771932c4687dd7e9f327c","user":{"login":"m-amr","id":6197215,"avatar_url":"https://avatars.githubusercontent.com/u/6197215?v=3","gravatar_id":"","url":"https://api.github.com/users/m-amr","html_url":"https://github.com/m-amr","followers_url":"https://api.github.com/users/m-amr/followers","following_url":"https://api.github.com/users/m-amr/following{/other_user}","gists_url":"https://api.github.com/users/m-amr/gists{/gist_id}","starred_url":"https://api.github.com/users/m-amr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-amr/subscriptions","organizations_url":"https://api.github.com/users/m-amr/orgs","repos_url":"https://api.github.com/users/m-amr/repos","events_url":"https://api.github.com/users/m-amr/events{/privacy}","received_events_url":"https://api.github.com/users/m-amr/received_events","type":"User","site_admin":false},"repo":{"id":40380692,"name":"angular.js","full_name":"m-amr/angular.js","owner":{"login":"m-amr","id":6197215,"avatar_url":"https://avatars.githubusercontent.com/u/6197215?v=3","gravatar_id":"","url":"https://api.github.com/users/m-amr","html_url":"https://github.com/m-amr","followers_url":"https://api.github.com/users/m-amr/followers","following_url":"https://api.github.com/users/m-amr/following{/other_user}","gists_url":"https://api.github.com/users/m-amr/gists{/gist_id}","starred_url":"https://api.github.com/users/m-amr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-amr/subscriptions","organizations_url":"https://api.github.com/users/m-amr/orgs","repos_url":"https://api.github.com/users/m-amr/repos","events_url":"https://api.github.com/users/m-amr/events{/privacy}","received_events_url":"https://api.github.com/users/m-amr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m-amr/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/m-amr/angular.js","forks_url":"https://api.github.com/repos/m-amr/angular.js/forks","keys_url":"https://api.github.com/repos/m-amr/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-amr/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-amr/angular.js/teams","hooks_url":"https://api.github.com/repos/m-amr/angular.js/hooks","issue_events_url":"https://api.github.com/repos/m-amr/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/m-amr/angular.js/events","assignees_url":"https://api.github.com/repos/m-amr/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/m-amr/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/m-amr/angular.js/tags","blobs_url":"https://api.github.com/repos/m-amr/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-amr/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-amr/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-amr/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-amr/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/m-amr/angular.js/languages","stargazers_url":"https://api.github.com/repos/m-amr/angular.js/stargazers","contributors_url":"https://api.github.com/repos/m-amr/angular.js/contributors","subscribers_url":"https://api.github.com/repos/m-amr/angular.js/subscribers","subscription_url":"https://api.github.com/repos/m-amr/angular.js/subscription","commits_url":"https://api.github.com/repos/m-amr/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-amr/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-amr/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-amr/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-amr/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/m-amr/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-amr/angular.js/merges","archive_url":"https://api.github.com/repos/m-amr/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-amr/angular.js/downloads","issues_url":"https://api.github.com/repos/m-amr/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/m-amr/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/m-amr/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/m-amr/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-amr/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/m-amr/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/m-amr/angular.js/deployments","created_at":"2015-08-07T20:58:30Z","updated_at":"2016-02-27T00:54:59Z","pushed_at":"2016-04-14T00:28:27Z","git_url":"git://github.com/m-amr/angular.js.git","ssh_url":"git@github.com:m-amr/angular.js.git","clone_url":"https://github.com/m-amr/angular.js.git","svn_url":"https://github.com/m-amr/angular.js","homepage":"http://angularjs.org","size":69404,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"2840aec8f18cd082afcd78f4d3970309b7d3c874","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2016-04-18T08:25:42Z","pushed_at":"2016-04-17T21:50:33Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":142079,"stargazers_count":48604,"watchers_count":48604,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23112,"mirror_url":null,"open_issues_count":1126,"forks":23112,"open_issues":1126,"watchers":48604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14031"},"html":{"href":"https://github.com/angular/angular.js/pull/14031"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/14031"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/14031/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14031/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14031/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/bffe7433e08b7f13767771932c4687dd7e9f327c"}}}}