{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezplatform/issues/91","repository_url":"https://api.github.com/repos/ezsystems/ezplatform","labels_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/91/comments","events_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/91/events","html_url":"https://github.com/ezsystems/ezplatform/pull/91","id":133705385,"number":91,"title":"Document use of php's built-in web server using standard symfony routes","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-15T12:55:02Z","updated_at":"2016-02-19T13:33:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform/pulls/91","html_url":"https://github.com/ezsystems/ezplatform/pull/91","diff_url":"https://github.com/ezsystems/ezplatform/pull/91.diff","patch_url":"https://github.com/ezsystems/ezplatform/pull/91.patch"},"body":"Changes:\r\n- remove custom router file as was requred when we had legacy around\r\n- add app_dev.php as used by built in routes in symfony\r\n- add mention in install doc *(re arrange so install is done before starting server)*\r\n\r\nBenefit of these changes is that running server in dev env will now enable debug\r\n(and web debug-toolbar), and we reuse the router file in symfony.\r\n\r\nTodo:\r\n- [ ] Should not be merged before this is fixed: https://jira.ez.no/browse/EZP-25403\r\n- [ ] Ideally we should also run some of the behat/functional tests using this server."},"comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform/issues/comments/186214582","html_url":"https://github.com/ezsystems/ezplatform/pull/91#issuecomment-186214582","issue_url":"https://api.github.com/repos/ezsystems/ezplatform/issues/91","id":186214582,"user":{"login":"ezrobot","id":681611,"avatar_url":"https://avatars.githubusercontent.com/u/681611?v=3","gravatar_id":"","url":"https://api.github.com/users/ezrobot","html_url":"https://github.com/ezrobot","followers_url":"https://api.github.com/users/ezrobot/followers","following_url":"https://api.github.com/users/ezrobot/following{/other_user}","gists_url":"https://api.github.com/users/ezrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/ezrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezrobot/subscriptions","organizations_url":"https://api.github.com/users/ezrobot/orgs","repos_url":"https://api.github.com/users/ezrobot/repos","events_url":"https://api.github.com/users/ezrobot/events{/privacy}","received_events_url":"https://api.github.com/users/ezrobot/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T13:33:41Z","updated_at":"2016-02-19T13:33:41Z","body":"This Pull Request does not respect [PSR-2 Coding Standards](http://www.php-fig.org/psr/psr-2/), please, see the suggested diff below:\n\n```diff\nLoaded config from \"/jenkins/jenkins.std/jobs/ezplatform-Pull-Request-checker/workspace/.php_cs\"\nF\nLegend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error\n   1) web/app_dev.php (single_quote)\n      ---------- begin diff ----------\n      --- Original\n      +++ New\n      @@ @@\n       \n      -putenv(\"SYMFONY_ENV=dev\");\n      +putenv('SYMFONY_ENV=dev');\n       \n      -require \"app.php\";\n      +require 'app.php';\n       \n      \n      ---------- end diff ----------\n\nFixed all files in 0.382 seconds, 6.000 MB memory used\n```\n"}}