{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/51332889","id":51332889,"diff_hunk":"@@ -30,7 +32,22 @@ func mustClient(cmd *cobra.Command) *clientv3.Client {\n \tif err != nil {\n \t\tExitWithError(ExitError, err)\n \t}\n-\tclient, err := clientv3.NewFromURL(endpoint)\n+\n+\t// set tls if any one tls option set\n+\tvar cfgtls *transport.TLSInfo\n+\ttls := transport.TLSInfo{}\n+\tif tls.CertFile, err = cmd.Flags().GetString(\"cert-file\"); err == nil {\n+\t\tcfgtls = &tls\n+\t}\n+\tif tls.KeyFile, err = cmd.Flags().GetString(\"key-file\"); err == nil {","path":"etcdctlv3/command/global.go","position":27,"original_position":27,"commit_id":"2c92696e78257d536595d0fc5dd805cf21fc196b","original_commit_id":"2c92696e78257d536595d0fc5dd805cf21fc196b","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"key-file > key (curl uses key)\r\n\r\nbasically we wanted to copy curl flag options.","created_at":"2016-01-30T00:07:47Z","updated_at":"2016-01-30T00:07:47Z","html_url":"https://github.com/coreos/etcd/pull/4349#discussion_r51332889","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/4349","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/51332889"},"html":{"href":"https://github.com/coreos/etcd/pull/4349#discussion_r51332889"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4349"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/4349","id":57709397,"html_url":"https://github.com/coreos/etcd/pull/4349","diff_url":"https://github.com/coreos/etcd/pull/4349.diff","patch_url":"https://github.com/coreos/etcd/pull/4349.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/4349","number":4349,"state":"open","locked":false,"title":"V3 client TLS","user":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-29T22:05:16Z","updated_at":"2016-01-30T00:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49383c50fba93b450b77d6d134f0e0becf65ec6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/4349/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/4349/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/4349/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/2c92696e78257d536595d0fc5dd805cf21fc196b","head":{"label":"heyitsanthony:v3-client-conntls","ref":"v3-client-conntls","sha":"2c92696e78257d536595d0fc5dd805cf21fc196b","user":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"repo":{"id":47994854,"name":"etcd","full_name":"heyitsanthony/etcd","owner":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heyitsanthony/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/heyitsanthony/etcd","forks_url":"https://api.github.com/repos/heyitsanthony/etcd/forks","keys_url":"https://api.github.com/repos/heyitsanthony/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heyitsanthony/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heyitsanthony/etcd/teams","hooks_url":"https://api.github.com/repos/heyitsanthony/etcd/hooks","issue_events_url":"https://api.github.com/repos/heyitsanthony/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/heyitsanthony/etcd/events","assignees_url":"https://api.github.com/repos/heyitsanthony/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/heyitsanthony/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/heyitsanthony/etcd/tags","blobs_url":"https://api.github.com/repos/heyitsanthony/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heyitsanthony/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heyitsanthony/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/heyitsanthony/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heyitsanthony/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/heyitsanthony/etcd/languages","stargazers_url":"https://api.github.com/repos/heyitsanthony/etcd/stargazers","contributors_url":"https://api.github.com/repos/heyitsanthony/etcd/contributors","subscribers_url":"https://api.github.com/repos/heyitsanthony/etcd/subscribers","subscription_url":"https://api.github.com/repos/heyitsanthony/etcd/subscription","commits_url":"https://api.github.com/repos/heyitsanthony/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/heyitsanthony/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/heyitsanthony/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/heyitsanthony/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/heyitsanthony/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/heyitsanthony/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heyitsanthony/etcd/merges","archive_url":"https://api.github.com/repos/heyitsanthony/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heyitsanthony/etcd/downloads","issues_url":"https://api.github.com/repos/heyitsanthony/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/heyitsanthony/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/heyitsanthony/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/heyitsanthony/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heyitsanthony/etcd/labels{/name}","releases_url":"https://api.github.com/repos/heyitsanthony/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/heyitsanthony/etcd/deployments","created_at":"2015-12-14T18:57:05Z","updated_at":"2016-01-11T20:59:07Z","pushed_at":"2016-01-29T22:43:17Z","git_url":"git://github.com/heyitsanthony/etcd.git","ssh_url":"git@github.com:heyitsanthony/etcd.git","clone_url":"https://github.com/heyitsanthony/etcd.git","svn_url":"https://github.com/heyitsanthony/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":20561,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e5527914aa42cae3063f52892e1ca4518da0e4ae","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-01-29T23:29:35Z","pushed_at":"2016-01-30T00:02:15Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":23302,"stargazers_count":8596,"watchers_count":8596,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1387,"mirror_url":null,"open_issues_count":161,"forks":1387,"open_issues":161,"watchers":8596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4349"},"html":{"href":"https://github.com/coreos/etcd/pull/4349"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/4349"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/4349/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4349/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4349/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/2c92696e78257d536595d0fc5dd805cf21fc196b"}}}}