{"action":"created","issue":{"url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/1","repository_url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp","labels_url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/1/comments","events_url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/1/events","html_url":"https://github.com/boli2659/NYTAPIandroidapp/issues/1","id":168561749,"number":1,"title":"Assignment complete","user":{"login":"boli2659","id":10123296,"avatar_url":"https://avatars.githubusercontent.com/u/10123296?v=3","gravatar_id":"","url":"https://api.github.com/users/boli2659","html_url":"https://github.com/boli2659","followers_url":"https://api.github.com/users/boli2659/followers","following_url":"https://api.github.com/users/boli2659/following{/other_user}","gists_url":"https://api.github.com/users/boli2659/gists{/gist_id}","starred_url":"https://api.github.com/users/boli2659/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boli2659/subscriptions","organizations_url":"https://api.github.com/users/boli2659/orgs","repos_url":"https://api.github.com/users/boli2659/repos","events_url":"https://api.github.com/users/boli2659/events{/privacy}","received_events_url":"https://api.github.com/users/boli2659/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-01T03:56:29Z","updated_at":"2016-08-01T12:05:38Z","closed_at":null,"body":"@codepath @codepathreview\r\n\r\nMy assignment is complete for this week. \r\n\r\nI'm still having a couple issues with filters, so I'm going to keep working to improve that experience, plus adding on more optionals, but I wanted to make sure to get this in before the deadline. \r\n\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/comments/236562627","html_url":"https://github.com/boli2659/NYTAPIandroidapp/issues/1#issuecomment-236562627","issue_url":"https://api.github.com/repos/boli2659/NYTAPIandroidapp/issues/1","id":236562627,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T12:05:38Z","updated_at":"2016-08-01T12:05:38Z","body":"Decent submission, consider adding optional stories. A few notes after checking out the code:\r\n\r\n* Properly reused the single base method in search activity to fetch results for both initial load and the pagination\r\n* Properly used spinners & check-boxes (with populated values) to allow users to select appropriate values.\r\n* Nice to see you added the search box to the ActionBar!\r\n* Consider adding [progress bars](http://guides.codepath.com/android/Handling-ProgressBars#progress-within-actionbar) to your app whenever a network request goes out\r\n* Consider including a check to see if internet is available to detect any network failures. Show an approrpiate message in case of failure.\r\n* One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a parcelable model (i.e `SearchFilters.java`) representing all the filters which were passed back and forth between activities within the bundle.\r\n* Nice job adding the share intent to the article detail view!\r\n* Consider trying out the [RecyclerView](http://guides.codepath.com/android/Using-the-RecyclerView), the successor to the ListView and GridView.  \r\n* Try out the third-party ButterKnife library to simplify a lot of boilerplate `findViewById()` calls.\r\n\r\nAlso, here's a more detailed [Project 2 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) which covers the most common issues with this submitted project. Read through the [feedback guide point-by-point](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) to determine how you could improve your submission.\r\n\r\nLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation."}}
{"actor":{"display_login":"codepathreview"}}