{"action":"created","comment":{"url":"https://api.github.com/repos/excon/excon/pulls/comments/72505929","id":72505929,"diff_hunk":"@@ -29,9 +30,9 @@ module Excon\n \n   UNIX = 'unix'\n \n-  USER_AGENT = 'excon/' << VERSION\n+  USER_AGENT = 'excon/' + VERSION","path":"lib/excon/constants.rb","position":10,"original_position":10,"commit_id":"789218e4786f90ebc3201b89d7b00000aee9e411","original_commit_id":"789218e4786f90ebc3201b89d7b00000aee9e411","user":{"login":"kitop","id":143179,"avatar_url":"https://avatars.githubusercontent.com/u/143179?v=3","gravatar_id":"","url":"https://api.github.com/users/kitop","html_url":"https://github.com/kitop","followers_url":"https://api.github.com/users/kitop/followers","following_url":"https://api.github.com/users/kitop/following{/other_user}","gists_url":"https://api.github.com/users/kitop/gists{/gist_id}","starred_url":"https://api.github.com/users/kitop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitop/subscriptions","organizations_url":"https://api.github.com/users/kitop/orgs","repos_url":"https://api.github.com/users/kitop/repos","events_url":"https://api.github.com/users/kitop/events{/privacy}","received_events_url":"https://api.github.com/users/kitop/received_events","type":"User","site_admin":false},"body":"Yes, much cleaner I think.","created_at":"2016-07-27T19:24:49Z","updated_at":"2016-07-27T19:24:49Z","html_url":"https://github.com/excon/excon/pull/586#discussion_r72505929","pull_request_url":"https://api.github.com/repos/excon/excon/pulls/586","_links":{"self":{"href":"https://api.github.com/repos/excon/excon/pulls/comments/72505929"},"html":{"href":"https://github.com/excon/excon/pull/586#discussion_r72505929"},"pull_request":{"href":"https://api.github.com/repos/excon/excon/pulls/586"}}},"pull_request":{"url":"https://api.github.com/repos/excon/excon/pulls/586","id":77836780,"html_url":"https://github.com/excon/excon/pull/586","diff_url":"https://github.com/excon/excon/pull/586.diff","patch_url":"https://github.com/excon/excon/pull/586.patch","issue_url":"https://api.github.com/repos/excon/excon/issues/586","number":586,"state":"open","locked":false,"title":"Support for frozen string literals","user":{"login":"kitop","id":143179,"avatar_url":"https://avatars.githubusercontent.com/u/143179?v=3","gravatar_id":"","url":"https://api.github.com/users/kitop","html_url":"https://github.com/kitop","followers_url":"https://api.github.com/users/kitop/followers","following_url":"https://api.github.com/users/kitop/following{/other_user}","gists_url":"https://api.github.com/users/kitop/gists{/gist_id}","starred_url":"https://api.github.com/users/kitop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitop/subscriptions","organizations_url":"https://api.github.com/users/kitop/orgs","repos_url":"https://api.github.com/users/kitop/repos","events_url":"https://api.github.com/users/kitop/events{/privacy}","received_events_url":"https://api.github.com/users/kitop/received_events","type":"User","site_admin":false},"body":"In Ruby 3.0 string literals will be frozen by default. This commit adds\r\nthe `# frozen_string_literal: true` magic comment to all `lib` files,\r\nemulating that behavior.\r\n\r\nMost `<<` operators where changed by string interpolation or `+`, this\r\nshould present little to no performance impact.\r\n\r\nTests and specs were intentionally not changed, as they are being rewritten to use rspec, and seemed like it may be better to change it while moving it. This commit tries to do the minimum to start supporting frozen strings.\r\n\r\nFrom: https://github.com/excon/excon/issues/585","created_at":"2016-07-18T16:21:54Z","updated_at":"2016-07-27T19:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"679a48ec845b44c3af269bef94099739a5e2616e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/excon/excon/pulls/586/commits","review_comments_url":"https://api.github.com/repos/excon/excon/pulls/586/comments","review_comment_url":"https://api.github.com/repos/excon/excon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/excon/excon/issues/586/comments","statuses_url":"https://api.github.com/repos/excon/excon/statuses/789218e4786f90ebc3201b89d7b00000aee9e411","head":{"label":"kitop:frozen-literals","ref":"frozen-literals","sha":"789218e4786f90ebc3201b89d7b00000aee9e411","user":{"login":"kitop","id":143179,"avatar_url":"https://avatars.githubusercontent.com/u/143179?v=3","gravatar_id":"","url":"https://api.github.com/users/kitop","html_url":"https://github.com/kitop","followers_url":"https://api.github.com/users/kitop/followers","following_url":"https://api.github.com/users/kitop/following{/other_user}","gists_url":"https://api.github.com/users/kitop/gists{/gist_id}","starred_url":"https://api.github.com/users/kitop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitop/subscriptions","organizations_url":"https://api.github.com/users/kitop/orgs","repos_url":"https://api.github.com/users/kitop/repos","events_url":"https://api.github.com/users/kitop/events{/privacy}","received_events_url":"https://api.github.com/users/kitop/received_events","type":"User","site_admin":false},"repo":{"id":63447404,"name":"excon","full_name":"kitop/excon","owner":{"login":"kitop","id":143179,"avatar_url":"https://avatars.githubusercontent.com/u/143179?v=3","gravatar_id":"","url":"https://api.github.com/users/kitop","html_url":"https://github.com/kitop","followers_url":"https://api.github.com/users/kitop/followers","following_url":"https://api.github.com/users/kitop/following{/other_user}","gists_url":"https://api.github.com/users/kitop/gists{/gist_id}","starred_url":"https://api.github.com/users/kitop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitop/subscriptions","organizations_url":"https://api.github.com/users/kitop/orgs","repos_url":"https://api.github.com/users/kitop/repos","events_url":"https://api.github.com/users/kitop/events{/privacy}","received_events_url":"https://api.github.com/users/kitop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitop/excon","description":"Usable, fast, simple HTTP 1.1 for Ruby","fork":true,"url":"https://api.github.com/repos/kitop/excon","forks_url":"https://api.github.com/repos/kitop/excon/forks","keys_url":"https://api.github.com/repos/kitop/excon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitop/excon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitop/excon/teams","hooks_url":"https://api.github.com/repos/kitop/excon/hooks","issue_events_url":"https://api.github.com/repos/kitop/excon/issues/events{/number}","events_url":"https://api.github.com/repos/kitop/excon/events","assignees_url":"https://api.github.com/repos/kitop/excon/assignees{/user}","branches_url":"https://api.github.com/repos/kitop/excon/branches{/branch}","tags_url":"https://api.github.com/repos/kitop/excon/tags","blobs_url":"https://api.github.com/repos/kitop/excon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitop/excon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitop/excon/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitop/excon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitop/excon/statuses/{sha}","languages_url":"https://api.github.com/repos/kitop/excon/languages","stargazers_url":"https://api.github.com/repos/kitop/excon/stargazers","contributors_url":"https://api.github.com/repos/kitop/excon/contributors","subscribers_url":"https://api.github.com/repos/kitop/excon/subscribers","subscription_url":"https://api.github.com/repos/kitop/excon/subscription","commits_url":"https://api.github.com/repos/kitop/excon/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitop/excon/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitop/excon/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitop/excon/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitop/excon/contents/{+path}","compare_url":"https://api.github.com/repos/kitop/excon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitop/excon/merges","archive_url":"https://api.github.com/repos/kitop/excon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitop/excon/downloads","issues_url":"https://api.github.com/repos/kitop/excon/issues{/number}","pulls_url":"https://api.github.com/repos/kitop/excon/pulls{/number}","milestones_url":"https://api.github.com/repos/kitop/excon/milestones{/number}","notifications_url":"https://api.github.com/repos/kitop/excon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitop/excon/labels{/name}","releases_url":"https://api.github.com/repos/kitop/excon/releases{/id}","deployments_url":"https://api.github.com/repos/kitop/excon/deployments","created_at":"2016-07-15T19:54:14Z","updated_at":"2016-07-15T19:54:15Z","pushed_at":"2016-07-18T16:20:20Z","git_url":"git://github.com/kitop/excon.git","ssh_url":"git@github.com:kitop/excon.git","clone_url":"https://github.com/kitop/excon.git","svn_url":"https://github.com/kitop/excon","homepage":"http://excon.io","size":2052,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"excon:master","ref":"master","sha":"57053a20280945ab9105abee063930abc456b2ca","user":{"login":"excon","id":6210164,"avatar_url":"https://avatars.githubusercontent.com/u/6210164?v=3","gravatar_id":"","url":"https://api.github.com/users/excon","html_url":"https://github.com/excon","followers_url":"https://api.github.com/users/excon/followers","following_url":"https://api.github.com/users/excon/following{/other_user}","gists_url":"https://api.github.com/users/excon/gists{/gist_id}","starred_url":"https://api.github.com/users/excon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excon/subscriptions","organizations_url":"https://api.github.com/users/excon/orgs","repos_url":"https://api.github.com/users/excon/repos","events_url":"https://api.github.com/users/excon/events{/privacy}","received_events_url":"https://api.github.com/users/excon/received_events","type":"Organization","site_admin":false},"repo":{"id":349203,"name":"excon","full_name":"excon/excon","owner":{"login":"excon","id":6210164,"avatar_url":"https://avatars.githubusercontent.com/u/6210164?v=3","gravatar_id":"","url":"https://api.github.com/users/excon","html_url":"https://github.com/excon","followers_url":"https://api.github.com/users/excon/followers","following_url":"https://api.github.com/users/excon/following{/other_user}","gists_url":"https://api.github.com/users/excon/gists{/gist_id}","starred_url":"https://api.github.com/users/excon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excon/subscriptions","organizations_url":"https://api.github.com/users/excon/orgs","repos_url":"https://api.github.com/users/excon/repos","events_url":"https://api.github.com/users/excon/events{/privacy}","received_events_url":"https://api.github.com/users/excon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excon/excon","description":"Usable, fast, simple HTTP 1.1 for Ruby","fork":false,"url":"https://api.github.com/repos/excon/excon","forks_url":"https://api.github.com/repos/excon/excon/forks","keys_url":"https://api.github.com/repos/excon/excon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excon/excon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excon/excon/teams","hooks_url":"https://api.github.com/repos/excon/excon/hooks","issue_events_url":"https://api.github.com/repos/excon/excon/issues/events{/number}","events_url":"https://api.github.com/repos/excon/excon/events","assignees_url":"https://api.github.com/repos/excon/excon/assignees{/user}","branches_url":"https://api.github.com/repos/excon/excon/branches{/branch}","tags_url":"https://api.github.com/repos/excon/excon/tags","blobs_url":"https://api.github.com/repos/excon/excon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excon/excon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excon/excon/git/refs{/sha}","trees_url":"https://api.github.com/repos/excon/excon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excon/excon/statuses/{sha}","languages_url":"https://api.github.com/repos/excon/excon/languages","stargazers_url":"https://api.github.com/repos/excon/excon/stargazers","contributors_url":"https://api.github.com/repos/excon/excon/contributors","subscribers_url":"https://api.github.com/repos/excon/excon/subscribers","subscription_url":"https://api.github.com/repos/excon/excon/subscription","commits_url":"https://api.github.com/repos/excon/excon/commits{/sha}","git_commits_url":"https://api.github.com/repos/excon/excon/git/commits{/sha}","comments_url":"https://api.github.com/repos/excon/excon/comments{/number}","issue_comment_url":"https://api.github.com/repos/excon/excon/issues/comments{/number}","contents_url":"https://api.github.com/repos/excon/excon/contents/{+path}","compare_url":"https://api.github.com/repos/excon/excon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excon/excon/merges","archive_url":"https://api.github.com/repos/excon/excon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excon/excon/downloads","issues_url":"https://api.github.com/repos/excon/excon/issues{/number}","pulls_url":"https://api.github.com/repos/excon/excon/pulls{/number}","milestones_url":"https://api.github.com/repos/excon/excon/milestones{/number}","notifications_url":"https://api.github.com/repos/excon/excon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excon/excon/labels{/name}","releases_url":"https://api.github.com/repos/excon/excon/releases{/id}","deployments_url":"https://api.github.com/repos/excon/excon/deployments","created_at":"2009-10-25T17:50:46Z","updated_at":"2016-07-24T13:33:31Z","pushed_at":"2016-07-18T16:21:55Z","git_url":"git://github.com/excon/excon.git","ssh_url":"git@github.com:excon/excon.git","clone_url":"https://github.com/excon/excon.git","svn_url":"https://github.com/excon/excon","homepage":"http://excon.io","size":2268,"stargazers_count":741,"watchers_count":741,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"open_issues_count":55,"forks":188,"open_issues":55,"watchers":741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/excon/excon/pulls/586"},"html":{"href":"https://github.com/excon/excon/pull/586"},"issue":{"href":"https://api.github.com/repos/excon/excon/issues/586"},"comments":{"href":"https://api.github.com/repos/excon/excon/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/excon/excon/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/excon/excon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/excon/excon/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/excon/excon/statuses/789218e4786f90ebc3201b89d7b00000aee9e411"}}}}
{"actor":{"display_login":"kitop"}}