{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6","id":96401945,"html_url":"https://github.com/shinchiro/mpv-winbuild-cmake/pull/6","diff_url":"https://github.com/shinchiro/mpv-winbuild-cmake/pull/6.diff","patch_url":"https://github.com/shinchiro/mpv-winbuild-cmake/pull/6.patch","issue_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/6","number":6,"state":"closed","locked":false,"title":"toolchain: prevent using wrong mingw compilers","user":{"login":"pavelxdd","id":7561226,"avatar_url":"https://avatars.githubusercontent.com/u/7561226?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelxdd","html_url":"https://github.com/pavelxdd","followers_url":"https://api.github.com/users/pavelxdd/followers","following_url":"https://api.github.com/users/pavelxdd/following{/other_user}","gists_url":"https://api.github.com/users/pavelxdd/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelxdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelxdd/subscriptions","organizations_url":"https://api.github.com/users/pavelxdd/orgs","repos_url":"https://api.github.com/users/pavelxdd/repos","events_url":"https://api.github.com/users/pavelxdd/events{/privacy}","received_events_url":"https://api.github.com/users/pavelxdd/received_events","type":"User","site_admin":false},"body":"**Problem:**\r\npackages/game-music-emu.cmake\r\npackages/uchardet.cmake\r\npackages/libsoxr.cmake\r\npackages/openal-soft.cmake\r\n\r\nthese packages use ${CMAKE_MAKE_PROGRAM} and for some reason the build failed for them. According to the log files it appeared CMake tried to use the wrong MinGW compilers from my system PATH.\r\n\r\n**Description:**\r\nI launch this CMake toolchain in Cygwin, while I also have MSYS2 installed, and MSYS2 bin directory is in my system PATH. I don't want to remove MSYS2 from my PATH so I decided to find another way to fix it.\r\n\r\nI tried to add ${EXEC} before ${CMAKE_MAKE_PROGRAM} because ${EXEC} sets the correct PATH variable, but it didn't work. Then I found the following solution:\r\n\r\n**Solution:**\r\nCMAKE_SYSTEM_PROGRAM_PATH isn't supposed to be modified according to the CMake documentation:\r\nhttps://cmake.org/cmake/help/v3.0/variable/CMAKE_SYSTEM_PROGRAM_PATH.html\r\nCMAKE_PROGRAM_PATH should be modified instead.\r\nThis solves the problem when CMake could use the wrong compilers from the system PATH.","created_at":"2016-12-03T16:11:57Z","updated_at":"2016-12-04T01:38:01Z","closed_at":"2016-12-04T01:38:01Z","merged_at":null,"merge_commit_sha":"2f47b4189fc9ad8a848698168230e5b183a32d67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6/commits","review_comments_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6/comments","review_comment_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/6/comments","statuses_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/statuses/d1b3f2e8a43524a47b0d606fa3c67f4a028ae01a","head":{"label":"pavelxdd:master","ref":"master","sha":"d1b3f2e8a43524a47b0d606fa3c67f4a028ae01a","user":{"login":"pavelxdd","id":7561226,"avatar_url":"https://avatars.githubusercontent.com/u/7561226?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelxdd","html_url":"https://github.com/pavelxdd","followers_url":"https://api.github.com/users/pavelxdd/followers","following_url":"https://api.github.com/users/pavelxdd/following{/other_user}","gists_url":"https://api.github.com/users/pavelxdd/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelxdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelxdd/subscriptions","organizations_url":"https://api.github.com/users/pavelxdd/orgs","repos_url":"https://api.github.com/users/pavelxdd/repos","events_url":"https://api.github.com/users/pavelxdd/events{/privacy}","received_events_url":"https://api.github.com/users/pavelxdd/received_events","type":"User","site_admin":false},"repo":{"id":75483719,"name":"mpv-winbuild-cmake","full_name":"pavelxdd/mpv-winbuild-cmake","owner":{"login":"pavelxdd","id":7561226,"avatar_url":"https://avatars.githubusercontent.com/u/7561226?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelxdd","html_url":"https://github.com/pavelxdd","followers_url":"https://api.github.com/users/pavelxdd/followers","following_url":"https://api.github.com/users/pavelxdd/following{/other_user}","gists_url":"https://api.github.com/users/pavelxdd/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelxdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelxdd/subscriptions","organizations_url":"https://api.github.com/users/pavelxdd/orgs","repos_url":"https://api.github.com/users/pavelxdd/repos","events_url":"https://api.github.com/users/pavelxdd/events{/privacy}","received_events_url":"https://api.github.com/users/pavelxdd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavelxdd/mpv-winbuild-cmake","description":"CMake-based MinGW-w64 Cross Toolchain","fork":true,"url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake","forks_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/forks","keys_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/teams","hooks_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/hooks","issue_events_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/issues/events{/number}","events_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/events","assignees_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/assignees{/user}","branches_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/branches{/branch}","tags_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/tags","blobs_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/languages","stargazers_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/stargazers","contributors_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/contributors","subscribers_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/subscribers","subscription_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/subscription","commits_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/contents/{+path}","compare_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/merges","archive_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/downloads","issues_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/issues{/number}","pulls_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/labels{/name}","releases_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/releases{/id}","deployments_url":"https://api.github.com/repos/pavelxdd/mpv-winbuild-cmake/deployments","created_at":"2016-12-03T15:57:54Z","updated_at":"2016-12-03T15:57:55Z","pushed_at":"2016-12-03T17:30:25Z","git_url":"git://github.com/pavelxdd/mpv-winbuild-cmake.git","ssh_url":"git@github.com:pavelxdd/mpv-winbuild-cmake.git","clone_url":"https://github.com/pavelxdd/mpv-winbuild-cmake.git","svn_url":"https://github.com/pavelxdd/mpv-winbuild-cmake","homepage":null,"size":4109,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shinchiro:master","ref":"master","sha":"4915fb0f1fc8277273cbe453c5d7b5eae442d47f","user":{"login":"shinchiro","id":9623615,"avatar_url":"https://avatars.githubusercontent.com/u/9623615?v=3","gravatar_id":"","url":"https://api.github.com/users/shinchiro","html_url":"https://github.com/shinchiro","followers_url":"https://api.github.com/users/shinchiro/followers","following_url":"https://api.github.com/users/shinchiro/following{/other_user}","gists_url":"https://api.github.com/users/shinchiro/gists{/gist_id}","starred_url":"https://api.github.com/users/shinchiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinchiro/subscriptions","organizations_url":"https://api.github.com/users/shinchiro/orgs","repos_url":"https://api.github.com/users/shinchiro/repos","events_url":"https://api.github.com/users/shinchiro/events{/privacy}","received_events_url":"https://api.github.com/users/shinchiro/received_events","type":"User","site_admin":false},"repo":{"id":44826680,"name":"mpv-winbuild-cmake","full_name":"shinchiro/mpv-winbuild-cmake","owner":{"login":"shinchiro","id":9623615,"avatar_url":"https://avatars.githubusercontent.com/u/9623615?v=3","gravatar_id":"","url":"https://api.github.com/users/shinchiro","html_url":"https://github.com/shinchiro","followers_url":"https://api.github.com/users/shinchiro/followers","following_url":"https://api.github.com/users/shinchiro/following{/other_user}","gists_url":"https://api.github.com/users/shinchiro/gists{/gist_id}","starred_url":"https://api.github.com/users/shinchiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinchiro/subscriptions","organizations_url":"https://api.github.com/users/shinchiro/orgs","repos_url":"https://api.github.com/users/shinchiro/repos","events_url":"https://api.github.com/users/shinchiro/events{/privacy}","received_events_url":"https://api.github.com/users/shinchiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinchiro/mpv-winbuild-cmake","description":"CMake-based MinGW-w64 Cross Toolchain","fork":true,"url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake","forks_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/forks","keys_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/teams","hooks_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/hooks","issue_events_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/events{/number}","events_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/events","assignees_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/assignees{/user}","branches_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/branches{/branch}","tags_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/tags","blobs_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/languages","stargazers_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/stargazers","contributors_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/contributors","subscribers_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/subscribers","subscription_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/subscription","commits_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/contents/{+path}","compare_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/merges","archive_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/downloads","issues_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues{/number}","pulls_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/labels{/name}","releases_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/releases{/id}","deployments_url":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/deployments","created_at":"2015-10-23T17:02:02Z","updated_at":"2016-12-03T13:18:54Z","pushed_at":"2016-12-04T01:37:17Z","git_url":"git://github.com/shinchiro/mpv-winbuild-cmake.git","ssh_url":"git@github.com:shinchiro/mpv-winbuild-cmake.git","clone_url":"https://github.com/shinchiro/mpv-winbuild-cmake.git","svn_url":"https://github.com/shinchiro/mpv-winbuild-cmake","homepage":null,"size":4115,"stargazers_count":3,"watchers_count":3,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6"},"html":{"href":"https://github.com/shinchiro/mpv-winbuild-cmake/pull/6"},"issue":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/6"},"comments":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/shinchiro/mpv-winbuild-cmake/statuses/d1b3f2e8a43524a47b0d606fa3c67f4a028ae01a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"shinchiro"}}