{"push_id":1095956110,"size":47,"distinct_size":47,"ref":"refs/heads/upstream/master","head":"109830dad376a22aa24c3b268bd8c635fdc35ee9","before":"c292dbea40021754b47f0238a7d634e86066b53c","commits":[{"sha":"27ff09797f16087032584127e017605ea055dee5","author":{"email":"5fce32887d235858b7e7ca81f4a8e27f52e1c330@fwo.ch","name":"Urs Wolfer"},"message":"Fix 'gr-date-formatter' tests in Edge\n\nBug: Issue 3999\nChange-Id: I79029c70d274f34aa0ec0ef2d0f9a6016a769b40","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/27ff09797f16087032584127e017605ea055dee5"},{"sha":"424984b01b0257019adaa52358db0821d7c06c1d","author":{"email":"77397652b38ec60b50e56236b813774ce842bcdf@gmail.com","name":"Sebastian Schuberth"},"message":"doc: Clarify change dependency handling of submit types\n\nInstead of only saying that \"Cherry Pick\" ignores change dependencies,\nexplicitly say that all other submit types do adhere to change\ndependencies.\n\nChange-Id: Iaa141e7dc9c3031efa2f6cb921033c903cabed39","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/424984b01b0257019adaa52358db0821d7c06c1d"},{"sha":"a8614b750e2386bdc5dff15e267d8428356f9219","author":{"email":"a41b8149cd6e0b14f0d2e830dd9b39f67c832655@ericsson.com","name":"Marco Miller"},"message":"Fix doc for a few fields in rest-api-accounts PreferencesInfo and Input\n\nAdd 'optional' to the download_scheme field, since it can be null thus\nnot listed by PreferencesInfo.\n\nFix typo for PreferencesInfo email_ field name. Add the missing\nemail_strategy field doc to PreferencesInput.\n\nChange-Id: Iee3385dfcc55b093d8554e0646fddca9194818d7","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/a8614b750e2386bdc5dff15e267d8428356f9219"},{"sha":"13b86f7f8229f730a1f99f665e09881e00cd57ec","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"SubmoduleOp, GitModules, MergeOp: Share an OpenRepoManager\n\nThis is the logical progress after Ic621631031. SubmoduleOp/GitModules,\nwhich are invoked from MergeOp, can also benefit from the same cache\nstructure. By having one central manager for opening repositories in\nplace, this also fixes a bug for our backend, which doesn't like\nopening a repository multiple times with intermediate write backs.\n\nIntroduce a OpenRepoManager which can be shared across MergeOp,\nSubmoduleOp and GitModules.\n\nChange-Id: I8178e0150ef1f708e3026db8858846498c3adb9a","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/13b86f7f8229f730a1f99f665e09881e00cd57ec"},{"sha":"2ee0fb26727e87e62a1cffabc468dfa32798eb15","author":{"email":"5fce32887d235858b7e7ca81f4a8e27f52e1c330@fwo.ch","name":"Urs Wolfer"},"message":"Show old path for renamed files in file list\n\nChange-Id: If47ef8e86ba26fd284500f03a2277a47ecb91327","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/2ee0fb26727e87e62a1cffabc468dfa32798eb15"},{"sha":"bbb87d64f7f8400b9c7ae8bd7528408277240d45","author":{"email":"b162584c9d065018308db99337b5a9fbc8680008@sonymobile.com","name":"David Pursehouse"},"message":"Update replication plugin to latest revision\n\n- RefReplicatedEvent: Move toStatusString to RefPushResult.toString\n- Migrate tests to Google Truth\n- ReplicationState: Improve javadoc of RefPushResult values\n\nChange-Id: I3ac8053c896fa80a80884e49ec1655429dae421e","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/bbb87d64f7f8400b9c7ae8bd7528408277240d45"},{"sha":"ed2b896eeabe81569fe7bb607de5c32432d7bde1","author":{"email":"b162584c9d065018308db99337b5a9fbc8680008@sonymobile.com","name":"David Pursehouse"},"message":"Merge \"Fix doc for a few fields in rest-api-accounts PreferencesInfo and Input\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/ed2b896eeabe81569fe7bb607de5c32432d7bde1"},{"sha":"4b10c5466125d38ee0a0ad0de12f32a889b5229f","author":{"email":"b162584c9d065018308db99337b5a9fbc8680008@sonymobile.com","name":"David Pursehouse"},"message":"AsciiDoctor: Add missing @Override annotation\n\nChange-Id: Ifa1e5627c47449e81bf4d86e9e32eca668cf309b","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/4b10c5466125d38ee0a0ad0de12f32a889b5229f"},{"sha":"221415d298c765a3c847f0fe71737cf4e1704f77","author":{"email":"b162584c9d065018308db99337b5a9fbc8680008@sonymobile.com","name":"David Pursehouse"},"message":"Merge \"doc: Clarify change dependency handling of submit types\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/221415d298c765a3c847f0fe71737cf4e1704f77"},{"sha":"4c9c8e012cb41184564984a0be14debc5e978cc9","author":{"email":"b162584c9d065018308db99337b5a9fbc8680008@sonymobile.com","name":"David Pursehouse"},"message":"AccountService: Remove unused changeDiffPreferences method\n\nAlso remove ListenableAccountDiffPreference which is no longer used.\n\nChange-Id: I5cd58df3e3b37c41b52ff346f975a9953553756f","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/4c9c8e012cb41184564984a0be14debc5e978cc9"},{"sha":"b961a7d03d42de6ebc3d269b88f8837f93c4ea0a","author":{"email":"d43fb6c98c97e553b671ed9a9318100f1de386e7@google.com","name":"Edwin Kempin"},"message":"Always set VisibleRefFilter on UploadPack\n\nThere was an optimization to not add VisibleRefFilter if all refs of\nthe project were visible to the calling user, because in this case it\nis not needed to evaluate all rules. This optimization is unneeded\nbecause a similar optimization exists within VisibleRefFilter.\nVisibleRefFilter checks if all refs except refs/meta/config are\nvisible to the calling user and if yes only one separate permission\ncheck for refs/meta/config is done.\n\nRemoving the optimization for the case where all refs are visible to\nthe calling user makes this case only slightly slower, since there is\nonly one additional permission check for the refs/meta/config branch\nnow. On the other hand the case where a user can see all refs except\nrefs/meta/config is a little faster now, since the check if all refs\nare visible is removed.\n\nBy having VisibleRefFilter invoked always, we can now use it to add\nmagic refs to the advertised ref set, which is e.g. required to\nsupport a magic refs/users/self ref (implemented in the follow-up\nchange).\n\nChange-Id: Ic8f29b41f3abf23f99b59260956d543f815253cc\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/b961a7d03d42de6ebc3d269b88f8837f93c4ea0a"},{"sha":"03a508b6236f099de7fff157d71462fd6c12ec6b","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Merge \"SubmoduleOp, GitModules, MergeOp: Share an OpenRepoManager\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/03a508b6236f099de7fff157d71462fd6c12ec6b"},{"sha":"efec99df311d41aa8b434ceebd3aed8ee548f389","author":{"email":"d43fb6c98c97e553b671ed9a9318100f1de386e7@google.com","name":"Edwin Kempin"},"message":"Revert \"Reapply: Revert \"Use changeRefsById to track existing revisions\"\"\n\nThis commit broke pushing of a series of two commits for review when\nthe createNewChangeForAllNotInTarget option on the project was set.\nA new test case is added to cover this case.\n\nThis reverts commit 767fdb668e4aac23b5c36b371f7f43c229118c55.\n\nChange-Id: I0d6163ca4c656254a2c3dcdae6f996b1bf61b4a3\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/efec99df311d41aa8b434ceebd3aed8ee548f389"},{"sha":"378743cf4937e9e109aa8113fab65e6c072af8c3","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Merge \"AsciiDoctor: Add missing @Override annotation\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/378743cf4937e9e109aa8113fab65e6c072af8c3"},{"sha":"3cf19f686a93b5794b456f8eab66de9c97199dc4","author":{"email":"d43fb6c98c97e553b671ed9a9318100f1de386e7@google.com","name":"Edwin Kempin"},"message":"Support deletion of SSH keys in extension API\n\nUse the new method to add a test assertion for SSH key deletion.\n\nChange-Id: If7ddc88fd8387f1e85d78972310d7e1dbacb429a\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/3cf19f686a93b5794b456f8eab66de9c97199dc4"},{"sha":"07952c069abd75abd6d33e58561307d86e0cabb9","author":{"email":"d43fb6c98c97e553b671ed9a9318100f1de386e7@google.com","name":"Edwin Kempin"},"message":"Store SSH keys in git\n\nThe public SSH keys of a user are now stored in an authorized_keys\nfile in the All-Users repository in the refs/users/CD/ABCD branch of\nthe user.\n\nStoring SSH keys in an authorized_keys file is the standard way for\nSSH to store public keys. Each key is stored on a separate line.\n\nThe order of the keys in the file determines the sequence numbers of\nthe keys.\n\nInvalid keys are marked with the prefix '# INVALID'.\n\nTo keep the sequence numbers intact when a key is deleted, a\n'# DELETED' line is inserted at the position where the key was\ndeleted.\n\nOther comment lines are ignored on read, and are not written back when\nthe file is modified.\n\nSupporting a 2-step live migration for a multi-master Gerrit\ninstallation is not needed since the googlesource.com instances do not\nuse SSH and there are no other multi-master installations.\n\nOn creation of an SSH key, RFC 4716 style keys need to be converted to\nOpenSSH style keys. Also before adding a key it should be checked that\nthe key is parseable. Both of this requires classes from SSH libs that\nare only available in the SSH layer. This is why the SSH key creation\nmust be done there. So far this was done in SshKeyCacheImpl, but since\nSshKeyCacheImpl needs VersionedAuthorizedKeys to load keys and to mark\nkeys as invalid, VersionedAuthorizedKeys cannot not depend on\nSshKeyCacheImpl as this would be a cyclic dependency. Instead split\nout the SSH key creation from SshKeyCacheImpl into SshKeyCreatorImpl.\nThis way SshKeyCacheImpl depends on VersionedAuthorizedKeys and\nVersionedAuthorizedKeys depends on SshKeyCreatorImpl, and there is no\ndependency circle.\n\nChange-Id: I8fcc3c0f27e034fc2c8e8ae3612068099075467d\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/07952c069abd75abd6d33e58561307d86e0cabb9"},{"sha":"ea37c789179aae16e84548605e4d8640e6144c13","author":{"email":"d43fb6c98c97e553b671ed9a9318100f1de386e7@google.com","name":"Edwin Kempin"},"message":"Don't add the same SSH key several times\n\nTrying to add an SSH key that already exists succeeds, but no new SSH\nkey is persisted.\n\nChange-Id: If7dc8fba6741b6eba67eb29240e6b55dd6f5868b\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/ea37c789179aae16e84548605e4d8640e6144c13"},{"sha":"281dc411eee5a7e042d9a282ac70dfbdff19b131","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"BatchUpdate: Bump lastUpdatedOn by default\n\nThere are only two cases where we don't currently bump lastUpdatedOn:\nadding reviewers and adding draft comments. The vast majority of other\ncases we do want to bump lastUpdatedOn.\n\nChange the ChangeContext#saveChange method to #bumpLastUpdatedOn, to\nbe explicit about what this actually does. Default to true to make it\neasier on callers.\n\nChange-Id: I3d8b13f70b082f8f4ef15df02f72840ed42eed85","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/281dc411eee5a7e042d9a282ac70dfbdff19b131"},{"sha":"1827cff1b2abd0b1d453fcde69be3c6d509e4923","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Add gr-alert element\n\nChange-Id: Id44dcb2dc77e50c55f25eb7d5b3eaa618ccbce13","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/1827cff1b2abd0b1d453fcde69be3c6d509e4923"},{"sha":"edefc79f2afbab021763dfbde16c8b190d9be4b7","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Merge \"Add gr-alert element\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/gerrit/commits/edefc79f2afbab021763dfbde16c8b190d9be4b7"}]}