{"action":"created","issue":{"url":"https://api.github.com/repos/celery/celery/issues/3353","repository_url":"https://api.github.com/repos/celery/celery","labels_url":"https://api.github.com/repos/celery/celery/issues/3353/labels{/name}","comments_url":"https://api.github.com/repos/celery/celery/issues/3353/comments","events_url":"https://api.github.com/repos/celery/celery/issues/3353/events","html_url":"https://github.com/celery/celery/issues/3353","id":168823570,"number":3353,"title":"Documentation: Error in 'extending' page?","user":{"login":"someburner","id":9430255,"avatar_url":"https://avatars.githubusercontent.com/u/9430255?v=3","gravatar_id":"","url":"https://api.github.com/users/someburner","html_url":"https://github.com/someburner","followers_url":"https://api.github.com/users/someburner/followers","following_url":"https://api.github.com/users/someburner/following{/other_user}","gists_url":"https://api.github.com/users/someburner/gists{/gist_id}","starred_url":"https://api.github.com/users/someburner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/someburner/subscriptions","organizations_url":"https://api.github.com/users/someburner/orgs","repos_url":"https://api.github.com/users/someburner/repos","events_url":"https://api.github.com/users/someburner/events{/privacy}","received_events_url":"https://api.github.com/users/someburner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-02T08:05:42Z","updated_at":"2016-08-07T12:07:07Z","closed_at":null,"body":"Howdy\r\n\r\nIn the [extending](http://docs.celeryproject.org/en/latest/userguide/extending.html) docs, under **Example worker bootstep**, 2nd code block, it has:\r\n\r\n```\r\n    def detect(self, worker):\r\n        # update active requests\r\n        for req in self.worker.active_requests:\r\n            if req.time_start and time() - req.time_start > self.timeout:\r\n                raise SystemExit()\r\n```\r\n\r\nShould this not be\r\n```\r\nfor req in worker.active_requests:\r\n```\r\n? \r\n\r\nAlso, might be nice to have the requires be more verbose, ie:\r\n\r\n```\r\nclass DeadlockDetection(bootsteps.StartStopStep):\r\n    requires = ('celery.worker.components:Timer',)\r\n```"},"comment":{"url":"https://api.github.com/repos/celery/celery/issues/comments/238078791","html_url":"https://github.com/celery/celery/issues/3353#issuecomment-238078791","issue_url":"https://api.github.com/repos/celery/celery/issues/3353","id":238078791,"user":{"login":"berkerpeksag","id":26338,"avatar_url":"https://avatars.githubusercontent.com/u/26338?v=3","gravatar_id":"","url":"https://api.github.com/users/berkerpeksag","html_url":"https://github.com/berkerpeksag","followers_url":"https://api.github.com/users/berkerpeksag/followers","following_url":"https://api.github.com/users/berkerpeksag/following{/other_user}","gists_url":"https://api.github.com/users/berkerpeksag/gists{/gist_id}","starred_url":"https://api.github.com/users/berkerpeksag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkerpeksag/subscriptions","organizations_url":"https://api.github.com/users/berkerpeksag/orgs","repos_url":"https://api.github.com/users/berkerpeksag/repos","events_url":"https://api.github.com/users/berkerpeksag/events{/privacy}","received_events_url":"https://api.github.com/users/berkerpeksag/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T12:07:07Z","updated_at":"2016-08-07T12:07:07Z","body":"Both of your suggestions have been fixed in master in https://github.com/celery/celery/commit/b65c6991555e4b8c80364306a24b269b452be059. Perhaps it should be backported to 3.1?"}}
{"actor":{"display_login":"berkerpeksag"}}