{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/73372443","id":73372443,"diff_hunk":"@@ -80,9 +80,9 @@ - (BOOL)fb_scrollToVisibleWithNormalizedScrollDistance:(CGFloat)normalizedScroll\n   if (self.fb_isVisible) {\n     return YES;\n   }\n-  XCElementSnapshot *scrollView = [self.lastSnapshot fb_parentMatchingType:XCUIElementTypeScrollView];\n+  XCElementSnapshot *scrollView = [self.lastSnapshot fb_parentMatchingType:XCUIElementTypeCollectionView];\n   scrollView = scrollView ?: [self.lastSnapshot fb_parentMatchingType:XCUIElementTypeTable];\n-  scrollView = scrollView ?: [self.lastSnapshot fb_parentMatchingType:XCUIElementTypeCollectionView];\n+  scrollView = scrollView ?: [self.lastSnapshot fb_parentMatchingType:XCUIElementTypeScrollView];","path":"WebDriverAgentLib/Categories/XCUIElement+FBScrolling.m","position":8,"original_position":8,"commit_id":"c042af3da340af2f5479b7f45040088be83ad719","original_commit_id":"c042af3da340af2f5479b7f45040088be83ad719","user":{"login":"yaphatak","id":12143988,"avatar_url":"https://avatars.githubusercontent.com/u/12143988?v=3","gravatar_id":"","url":"https://api.github.com/users/yaphatak","html_url":"https://github.com/yaphatak","followers_url":"https://api.github.com/users/yaphatak/followers","following_url":"https://api.github.com/users/yaphatak/following{/other_user}","gists_url":"https://api.github.com/users/yaphatak/gists{/gist_id}","starred_url":"https://api.github.com/users/yaphatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaphatak/subscriptions","organizations_url":"https://api.github.com/users/yaphatak/orgs","repos_url":"https://api.github.com/users/yaphatak/repos","events_url":"https://api.github.com/users/yaphatak/events{/privacy}","received_events_url":"https://api.github.com/users/yaphatak/received_events","type":"User","site_admin":false},"body":"Yes you are right. I read your [comment](https://github.com/facebook/WebDriverAgent/issues/228#issuecomment-237214008) . Let me try to make this change. Because the current one only works if parent element is scrollview.","created_at":"2016-08-03T16:44:22Z","updated_at":"2016-08-03T16:44:22Z","html_url":"https://github.com/facebook/WebDriverAgent/pull/229#discussion_r73372443","pull_request_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/73372443"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/229#discussion_r73372443"},"pull_request":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229","id":79828694,"html_url":"https://github.com/facebook/WebDriverAgent/pull/229","diff_url":"https://github.com/facebook/WebDriverAgent/pull/229.diff","patch_url":"https://github.com/facebook/WebDriverAgent/pull/229.patch","issue_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/229","number":229,"state":"open","locked":false,"title":"picking parent in order of CollectionView, Table, ScrollView","user":{"login":"yaphatak","id":12143988,"avatar_url":"https://avatars.githubusercontent.com/u/12143988?v=3","gravatar_id":"","url":"https://api.github.com/users/yaphatak","html_url":"https://github.com/yaphatak","followers_url":"https://api.github.com/users/yaphatak/followers","following_url":"https://api.github.com/users/yaphatak/following{/other_user}","gists_url":"https://api.github.com/users/yaphatak/gists{/gist_id}","starred_url":"https://api.github.com/users/yaphatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaphatak/subscriptions","organizations_url":"https://api.github.com/users/yaphatak/orgs","repos_url":"https://api.github.com/users/yaphatak/repos","events_url":"https://api.github.com/users/yaphatak/events{/privacy}","received_events_url":"https://api.github.com/users/yaphatak/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-02T23:56:54Z","updated_at":"2016-08-03T16:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032dc06086fad0e0ae69e3295f0d68585f3509ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229/commits","review_comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229/comments","review_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/229/comments","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/c042af3da340af2f5479b7f45040088be83ad719","head":{"label":"yaphatak:scroll_logic_change","ref":"scroll_logic_change","sha":"c042af3da340af2f5479b7f45040088be83ad719","user":{"login":"yaphatak","id":12143988,"avatar_url":"https://avatars.githubusercontent.com/u/12143988?v=3","gravatar_id":"","url":"https://api.github.com/users/yaphatak","html_url":"https://github.com/yaphatak","followers_url":"https://api.github.com/users/yaphatak/followers","following_url":"https://api.github.com/users/yaphatak/following{/other_user}","gists_url":"https://api.github.com/users/yaphatak/gists{/gist_id}","starred_url":"https://api.github.com/users/yaphatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaphatak/subscriptions","organizations_url":"https://api.github.com/users/yaphatak/orgs","repos_url":"https://api.github.com/users/yaphatak/repos","events_url":"https://api.github.com/users/yaphatak/events{/privacy}","received_events_url":"https://api.github.com/users/yaphatak/received_events","type":"User","site_admin":false},"repo":{"id":64796266,"name":"WebDriverAgent","full_name":"yaphatak/WebDriverAgent","owner":{"login":"yaphatak","id":12143988,"avatar_url":"https://avatars.githubusercontent.com/u/12143988?v=3","gravatar_id":"","url":"https://api.github.com/users/yaphatak","html_url":"https://github.com/yaphatak","followers_url":"https://api.github.com/users/yaphatak/followers","following_url":"https://api.github.com/users/yaphatak/following{/other_user}","gists_url":"https://api.github.com/users/yaphatak/gists{/gist_id}","starred_url":"https://api.github.com/users/yaphatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaphatak/subscriptions","organizations_url":"https://api.github.com/users/yaphatak/orgs","repos_url":"https://api.github.com/users/yaphatak/repos","events_url":"https://api.github.com/users/yaphatak/events{/privacy}","received_events_url":"https://api.github.com/users/yaphatak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaphatak/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/yaphatak/WebDriverAgent","forks_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/yaphatak/WebDriverAgent/deployments","created_at":"2016-08-02T22:22:24Z","updated_at":"2016-08-02T22:22:27Z","pushed_at":"2016-08-02T23:54:40Z","git_url":"git://github.com/yaphatak/WebDriverAgent.git","ssh_url":"git@github.com:yaphatak/WebDriverAgent.git","clone_url":"https://github.com/yaphatak/WebDriverAgent.git","svn_url":"https://github.com/yaphatak/WebDriverAgent","homepage":null,"size":9835,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"523c5c2899685cb21a15025918b595bd4caa5d9c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":41855272,"name":"WebDriverAgent","full_name":"facebook/WebDriverAgent","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":false,"url":"https://api.github.com/repos/facebook/WebDriverAgent","forks_url":"https://api.github.com/repos/facebook/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/facebook/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/facebook/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/facebook/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/facebook/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/facebook/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/facebook/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/facebook/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/WebDriverAgent/deployments","created_at":"2015-09-03T11:00:00Z","updated_at":"2016-08-03T01:15:12Z","pushed_at":"2016-08-02T23:58:01Z","git_url":"git://github.com/facebook/WebDriverAgent.git","ssh_url":"git@github.com:facebook/WebDriverAgent.git","clone_url":"https://github.com/facebook/WebDriverAgent.git","svn_url":"https://github.com/facebook/WebDriverAgent","homepage":null,"size":10496,"stargazers_count":383,"watchers_count":383,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":10,"forks":86,"open_issues":10,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/229"},"issue":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/229"},"comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/c042af3da340af2f5479b7f45040088be83ad719"}}}}
{"actor":{"display_login":"yaphatak"}}