{"action":"closed","number":186,"pull_request":{"url":"https://api.github.com/repos/EDmodel/ED2/pulls/186","id":88476025,"html_url":"https://github.com/EDmodel/ED2/pull/186","diff_url":"https://github.com/EDmodel/ED2/pull/186.diff","patch_url":"https://github.com/EDmodel/ED2/pull/186.patch","issue_url":"https://api.github.com/repos/EDmodel/ED2/issues/186","number":186,"state":"closed","locked":false,"title":"Mortality bugfix","user":{"login":"ashiklom","id":5680221,"avatar_url":"https://avatars.githubusercontent.com/u/5680221?v=3","gravatar_id":"","url":"https://api.github.com/users/ashiklom","html_url":"https://github.com/ashiklom","followers_url":"https://api.github.com/users/ashiklom/followers","following_url":"https://api.github.com/users/ashiklom/following{/other_user}","gists_url":"https://api.github.com/users/ashiklom/gists{/gist_id}","starred_url":"https://api.github.com/users/ashiklom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashiklom/subscriptions","organizations_url":"https://api.github.com/users/ashiklom/orgs","repos_url":"https://api.github.com/users/ashiklom/repos","events_url":"https://api.github.com/users/ashiklom/events{/privacy}","received_events_url":"https://api.github.com/users/ashiklom/received_events","type":"User","site_admin":false},"body":"If `negligible_nplant` is 0 for a PFT, the `log` operation in the `monthly_dlnndt` calculation fails (`log(0)`) and causes the entire run to die. This introduces a simple check wherein the adjustment is only performed if `negligible_nplant(ipft)` is zero (to account for rounding errors, I define zero to be less than the smallest real of its type, as defined by `tiny`).\r\n\r\nAs far as I can tell, there are no edge cases where this would break something that should not have otherwise been broken. But, an alternative is to explicitly throw an error if `negligible_nplant` is zero -- that would be much less cryptic than the current mysterious `SIGFPE`.","created_at":"2016-10-07T17:20:04Z","updated_at":"2016-10-07T18:03:15Z","closed_at":"2016-10-07T18:03:15Z","merged_at":null,"merge_commit_sha":"3ea26d833bec0902490d3ef98627dbb452465322","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EDmodel/ED2/pulls/186/commits","review_comments_url":"https://api.github.com/repos/EDmodel/ED2/pulls/186/comments","review_comment_url":"https://api.github.com/repos/EDmodel/ED2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EDmodel/ED2/issues/186/comments","statuses_url":"https://api.github.com/repos/EDmodel/ED2/statuses/4095e40982e9097f6b43589020db2908845128f1","head":{"label":"ashiklom:mortality-bugfix","ref":"mortality-bugfix","sha":"4095e40982e9097f6b43589020db2908845128f1","user":{"login":"ashiklom","id":5680221,"avatar_url":"https://avatars.githubusercontent.com/u/5680221?v=3","gravatar_id":"","url":"https://api.github.com/users/ashiklom","html_url":"https://github.com/ashiklom","followers_url":"https://api.github.com/users/ashiklom/followers","following_url":"https://api.github.com/users/ashiklom/following{/other_user}","gists_url":"https://api.github.com/users/ashiklom/gists{/gist_id}","starred_url":"https://api.github.com/users/ashiklom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashiklom/subscriptions","organizations_url":"https://api.github.com/users/ashiklom/orgs","repos_url":"https://api.github.com/users/ashiklom/repos","events_url":"https://api.github.com/users/ashiklom/events{/privacy}","received_events_url":"https://api.github.com/users/ashiklom/received_events","type":"User","site_admin":false},"repo":{"id":50447318,"name":"ED2","full_name":"ashiklom/ED2","owner":{"login":"ashiklom","id":5680221,"avatar_url":"https://avatars.githubusercontent.com/u/5680221?v=3","gravatar_id":"","url":"https://api.github.com/users/ashiklom","html_url":"https://github.com/ashiklom","followers_url":"https://api.github.com/users/ashiklom/followers","following_url":"https://api.github.com/users/ashiklom/following{/other_user}","gists_url":"https://api.github.com/users/ashiklom/gists{/gist_id}","starred_url":"https://api.github.com/users/ashiklom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashiklom/subscriptions","organizations_url":"https://api.github.com/users/ashiklom/orgs","repos_url":"https://api.github.com/users/ashiklom/repos","events_url":"https://api.github.com/users/ashiklom/events{/privacy}","received_events_url":"https://api.github.com/users/ashiklom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashiklom/ED2","description":"Ecosystem Demography Model","fork":true,"url":"https://api.github.com/repos/ashiklom/ED2","forks_url":"https://api.github.com/repos/ashiklom/ED2/forks","keys_url":"https://api.github.com/repos/ashiklom/ED2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashiklom/ED2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashiklom/ED2/teams","hooks_url":"https://api.github.com/repos/ashiklom/ED2/hooks","issue_events_url":"https://api.github.com/repos/ashiklom/ED2/issues/events{/number}","events_url":"https://api.github.com/repos/ashiklom/ED2/events","assignees_url":"https://api.github.com/repos/ashiklom/ED2/assignees{/user}","branches_url":"https://api.github.com/repos/ashiklom/ED2/branches{/branch}","tags_url":"https://api.github.com/repos/ashiklom/ED2/tags","blobs_url":"https://api.github.com/repos/ashiklom/ED2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashiklom/ED2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashiklom/ED2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashiklom/ED2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashiklom/ED2/statuses/{sha}","languages_url":"https://api.github.com/repos/ashiklom/ED2/languages","stargazers_url":"https://api.github.com/repos/ashiklom/ED2/stargazers","contributors_url":"https://api.github.com/repos/ashiklom/ED2/contributors","subscribers_url":"https://api.github.com/repos/ashiklom/ED2/subscribers","subscription_url":"https://api.github.com/repos/ashiklom/ED2/subscription","commits_url":"https://api.github.com/repos/ashiklom/ED2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashiklom/ED2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashiklom/ED2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashiklom/ED2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashiklom/ED2/contents/{+path}","compare_url":"https://api.github.com/repos/ashiklom/ED2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashiklom/ED2/merges","archive_url":"https://api.github.com/repos/ashiklom/ED2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashiklom/ED2/downloads","issues_url":"https://api.github.com/repos/ashiklom/ED2/issues{/number}","pulls_url":"https://api.github.com/repos/ashiklom/ED2/pulls{/number}","milestones_url":"https://api.github.com/repos/ashiklom/ED2/milestones{/number}","notifications_url":"https://api.github.com/repos/ashiklom/ED2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashiklom/ED2/labels{/name}","releases_url":"https://api.github.com/repos/ashiklom/ED2/releases{/id}","deployments_url":"https://api.github.com/repos/ashiklom/ED2/deployments","created_at":"2016-01-26T17:49:39Z","updated_at":"2016-01-26T23:09:18Z","pushed_at":"2016-10-07T17:16:45Z","git_url":"git://github.com/ashiklom/ED2.git","ssh_url":"git@github.com:ashiklom/ED2.git","clone_url":"https://github.com/ashiklom/ED2.git","svn_url":"https://github.com/ashiklom/ED2","homepage":"","size":58048,"stargazers_count":1,"watchers_count":1,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"EDmodel:master","ref":"master","sha":"8b30126b214c100d851f959394c8b566f8f78d1c","user":{"login":"EDmodel","id":5766328,"avatar_url":"https://avatars.githubusercontent.com/u/5766328?v=3","gravatar_id":"","url":"https://api.github.com/users/EDmodel","html_url":"https://github.com/EDmodel","followers_url":"https://api.github.com/users/EDmodel/followers","following_url":"https://api.github.com/users/EDmodel/following{/other_user}","gists_url":"https://api.github.com/users/EDmodel/gists{/gist_id}","starred_url":"https://api.github.com/users/EDmodel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDmodel/subscriptions","organizations_url":"https://api.github.com/users/EDmodel/orgs","repos_url":"https://api.github.com/users/EDmodel/repos","events_url":"https://api.github.com/users/EDmodel/events{/privacy}","received_events_url":"https://api.github.com/users/EDmodel/received_events","type":"Organization","site_admin":false},"repo":{"id":19721494,"name":"ED2","full_name":"EDmodel/ED2","owner":{"login":"EDmodel","id":5766328,"avatar_url":"https://avatars.githubusercontent.com/u/5766328?v=3","gravatar_id":"","url":"https://api.github.com/users/EDmodel","html_url":"https://github.com/EDmodel","followers_url":"https://api.github.com/users/EDmodel/followers","following_url":"https://api.github.com/users/EDmodel/following{/other_user}","gists_url":"https://api.github.com/users/EDmodel/gists{/gist_id}","starred_url":"https://api.github.com/users/EDmodel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDmodel/subscriptions","organizations_url":"https://api.github.com/users/EDmodel/orgs","repos_url":"https://api.github.com/users/EDmodel/repos","events_url":"https://api.github.com/users/EDmodel/events{/privacy}","received_events_url":"https://api.github.com/users/EDmodel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EDmodel/ED2","description":"Ecosystem Demography Model","fork":false,"url":"https://api.github.com/repos/EDmodel/ED2","forks_url":"https://api.github.com/repos/EDmodel/ED2/forks","keys_url":"https://api.github.com/repos/EDmodel/ED2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EDmodel/ED2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EDmodel/ED2/teams","hooks_url":"https://api.github.com/repos/EDmodel/ED2/hooks","issue_events_url":"https://api.github.com/repos/EDmodel/ED2/issues/events{/number}","events_url":"https://api.github.com/repos/EDmodel/ED2/events","assignees_url":"https://api.github.com/repos/EDmodel/ED2/assignees{/user}","branches_url":"https://api.github.com/repos/EDmodel/ED2/branches{/branch}","tags_url":"https://api.github.com/repos/EDmodel/ED2/tags","blobs_url":"https://api.github.com/repos/EDmodel/ED2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EDmodel/ED2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EDmodel/ED2/git/refs{/sha}","trees_url":"https://api.github.com/repos/EDmodel/ED2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EDmodel/ED2/statuses/{sha}","languages_url":"https://api.github.com/repos/EDmodel/ED2/languages","stargazers_url":"https://api.github.com/repos/EDmodel/ED2/stargazers","contributors_url":"https://api.github.com/repos/EDmodel/ED2/contributors","subscribers_url":"https://api.github.com/repos/EDmodel/ED2/subscribers","subscription_url":"https://api.github.com/repos/EDmodel/ED2/subscription","commits_url":"https://api.github.com/repos/EDmodel/ED2/commits{/sha}","git_commits_url":"https://api.github.com/repos/EDmodel/ED2/git/commits{/sha}","comments_url":"https://api.github.com/repos/EDmodel/ED2/comments{/number}","issue_comment_url":"https://api.github.com/repos/EDmodel/ED2/issues/comments{/number}","contents_url":"https://api.github.com/repos/EDmodel/ED2/contents/{+path}","compare_url":"https://api.github.com/repos/EDmodel/ED2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EDmodel/ED2/merges","archive_url":"https://api.github.com/repos/EDmodel/ED2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EDmodel/ED2/downloads","issues_url":"https://api.github.com/repos/EDmodel/ED2/issues{/number}","pulls_url":"https://api.github.com/repos/EDmodel/ED2/pulls{/number}","milestones_url":"https://api.github.com/repos/EDmodel/ED2/milestones{/number}","notifications_url":"https://api.github.com/repos/EDmodel/ED2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EDmodel/ED2/labels{/name}","releases_url":"https://api.github.com/repos/EDmodel/ED2/releases{/id}","deployments_url":"https://api.github.com/repos/EDmodel/ED2/deployments","created_at":"2014-05-13T01:21:54Z","updated_at":"2016-08-21T16:45:09Z","pushed_at":"2016-10-07T17:20:05Z","git_url":"git://github.com/EDmodel/ED2.git","ssh_url":"git@github.com:EDmodel/ED2.git","clone_url":"https://github.com/EDmodel/ED2.git","svn_url":"https://github.com/EDmodel/ED2","homepage":"","size":60695,"stargazers_count":13,"watchers_count":13,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":55,"forks":43,"open_issues":55,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EDmodel/ED2/pulls/186"},"html":{"href":"https://github.com/EDmodel/ED2/pull/186"},"issue":{"href":"https://api.github.com/repos/EDmodel/ED2/issues/186"},"comments":{"href":"https://api.github.com/repos/EDmodel/ED2/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/EDmodel/ED2/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/EDmodel/ED2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EDmodel/ED2/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/EDmodel/ED2/statuses/4095e40982e9097f6b43589020db2908845128f1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":7,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"ashiklom"}}