{"action":"created","issue":{"url":"https://api.github.com/repos/sequelpro/sequelpro/issues/2557","repository_url":"https://api.github.com/repos/sequelpro/sequelpro","labels_url":"https://api.github.com/repos/sequelpro/sequelpro/issues/2557/labels{/name}","comments_url":"https://api.github.com/repos/sequelpro/sequelpro/issues/2557/comments","events_url":"https://api.github.com/repos/sequelpro/sequelpro/issues/2557/events","html_url":"https://github.com/sequelpro/sequelpro/pull/2557","id":174065349,"number":2557,"title":"Add possible socket locations for MariaDB via MacPorts.","user":{"login":"sebcode","id":508999,"avatar_url":"https://avatars.githubusercontent.com/u/508999?v=3","gravatar_id":"","url":"https://api.github.com/users/sebcode","html_url":"https://github.com/sebcode","followers_url":"https://api.github.com/users/sebcode/followers","following_url":"https://api.github.com/users/sebcode/following{/other_user}","gists_url":"https://api.github.com/users/sebcode/gists{/gist_id}","starred_url":"https://api.github.com/users/sebcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebcode/subscriptions","organizations_url":"https://api.github.com/users/sebcode/orgs","repos_url":"https://api.github.com/users/sebcode/repos","events_url":"https://api.github.com/users/sebcode/events{/privacy}","received_events_url":"https://api.github.com/users/sebcode/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-30T16:29:31Z","updated_at":"2016-08-31T21:20:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sequelpro/sequelpro/pulls/2557","html_url":"https://github.com/sequelpro/sequelpro/pull/2557","diff_url":"https://github.com/sequelpro/sequelpro/pull/2557.diff","patch_url":"https://github.com/sequelpro/sequelpro/pull/2557.patch"},"body":"MariaDB 10.1 seems to work great with Sequel Pro, maybe it's time to add some socket locations for it."},"comment":{"url":"https://api.github.com/repos/sequelpro/sequelpro/issues/comments/243905801","html_url":"https://github.com/sequelpro/sequelpro/pull/2557#issuecomment-243905801","issue_url":"https://api.github.com/repos/sequelpro/sequelpro/issues/2557","id":243905801,"user":{"login":"abhibeckert","id":266088,"avatar_url":"https://avatars.githubusercontent.com/u/266088?v=3","gravatar_id":"","url":"https://api.github.com/users/abhibeckert","html_url":"https://github.com/abhibeckert","followers_url":"https://api.github.com/users/abhibeckert/followers","following_url":"https://api.github.com/users/abhibeckert/following{/other_user}","gists_url":"https://api.github.com/users/abhibeckert/gists{/gist_id}","starred_url":"https://api.github.com/users/abhibeckert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhibeckert/subscriptions","organizations_url":"https://api.github.com/users/abhibeckert/orgs","repos_url":"https://api.github.com/users/abhibeckert/repos","events_url":"https://api.github.com/users/abhibeckert/events{/privacy}","received_events_url":"https://api.github.com/users/abhibeckert/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T21:20:24Z","updated_at":"2016-08-31T21:20:24Z","body":"> I guess it's just convenience.\r\n\r\nSocket connections require jumping through hoops if we compile with sandboxing enabled, and we would like to be sandboxed at some point in the future. This is the _only_ feature in Sequel Pro where sandboxing is a problem.\r\n\r\nBasically we'd have to present an open panel where the user selects the socket in order to connect (if the connection is saved as a favourite, this would only need to be done once).\r\n\r\nI was thinking of removing socket connections altogether, but after doing a bit more research, I found a good reason to use them – sockets make it easier to have multiple servers running at once on the same machine, without needing to configure custom ports. That's useful on a dev machine, where you might need different versions of MySQL depending on the project.\r\n\r\nSo, I'm going to accept this pull request. When we do add sandboxing, we'll just have to present an open panel.\r\n\r\n> IMHO the bigger problem here is, that if we were to automatically connect to a MariaDB 10 server this would likely be interpreted as \"supported configuration\", while in reality we explicitly don't support MySQL forks right now.\r\n\r\nI don't have a problem with that. MariaDB is quickly becoming the industry standard."}}
{"actor":{"display_login":"abhibeckert"}}