{"action":"created","issue":{"url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1377","repository_url":"https://api.github.com/repos/quasar-analytics/quasar","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1377/labels{/name}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1377/comments","events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1377/events","html_url":"https://github.com/quasar-analytics/quasar/pull/1377","id":172977411,"number":1377,"title":"Efficient execution of simple counts with appended limit/skip ops","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/quasar-analytics/quasar/labels/in%20review","name":"in review","color":"c0c0c0"}],"state":"open","locked":false,"assignee":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"assignees":[{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-24T15:05:58Z","updated_at":"2016-08-24T15:37:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1377","html_url":"https://github.com/quasar-analytics/quasar/pull/1377","diff_url":"https://github.com/quasar-analytics/quasar/pull/1377.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1377.patch"},"body":"Fixes #1376.\r\n\r\nWhen a simple `select count(*) from foo` is executed in the REPL, or saved as a view and then read with offset/limit parameters, `limit` and/or `offset` clauses are effectively added before the query is executed. Because the query always produces a single result, those clauses have no effect, but they were not being recognized when the query was executed, and so quasar was doing `aggregate` rather than `count`, which is potentially much slower. This commit just recognizes that pattern and disregards any skip/limit after a count operation, as long as they wouldn't affect the single result."},"comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments/242110070","html_url":"https://github.com/quasar-analytics/quasar/pull/1377#issuecomment-242110070","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1377","id":242110070,"user":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T15:37:30Z","updated_at":"2016-08-24T15:37:30Z","body":"Just the one thing, then I’ll merge."}}
{"actor":{"display_login":"sellout"}}