{"action":"created","issue":{"url":"https://api.github.com/repos/google/ggrc-core/issues/4260","repository_url":"https://api.github.com/repos/google/ggrc-core","labels_url":"https://api.github.com/repos/google/ggrc-core/issues/4260/labels{/name}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/4260/comments","events_url":"https://api.github.com/repos/google/ggrc-core/issues/4260/events","html_url":"https://github.com/google/ggrc-core/pull/4260","id":170161812,"number":4260,"title":"FEATURE Assessment Page UX changes version 2 ","user":{"login":"andrei-karalionak","id":10726105,"avatar_url":"https://avatars.githubusercontent.com/u/10726105?v=3","gravatar_id":"","url":"https://api.github.com/users/andrei-karalionak","html_url":"https://github.com/andrei-karalionak","followers_url":"https://api.github.com/users/andrei-karalionak/followers","following_url":"https://api.github.com/users/andrei-karalionak/following{/other_user}","gists_url":"https://api.github.com/users/andrei-karalionak/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei-karalionak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei-karalionak/subscriptions","organizations_url":"https://api.github.com/users/andrei-karalionak/orgs","repos_url":"https://api.github.com/users/andrei-karalionak/repos","events_url":"https://api.github.com/users/andrei-karalionak/events{/privacy}","received_events_url":"https://api.github.com/users/andrei-karalionak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/ggrc-core/labels/needs%20work","name":"needs work","color":"f9d0c4"},{"url":"https://api.github.com/repos/google/ggrc-core/labels/please%20review","name":"please review","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/21","html_url":"https://github.com/google/ggrc-core/milestones/0.9.7-Quince","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/21/labels","id":1845906,"number":21,"title":"0.9.7-Quince","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":236,"state":"open","created_at":"2016-06-23T17:56:25Z","updated_at":"2016-08-24T13:07:23Z","due_on":"2016-08-14T22:00:00Z","closed_at":null},"comments":22,"created_at":"2016-08-09T13:10:53Z","updated_at":"2016-08-24T14:09:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/4260","html_url":"https://github.com/google/ggrc-core/pull/4260","diff_url":"https://github.com/google/ggrc-core/pull/4260.diff","patch_url":"https://github.com/google/ggrc-core/pull/4260.patch"},"body":"Additional changes regarding Assessment Info Page: \r\n- Related Controls List - show description\r\n- Show/Hide Right section: test plan, notes, people, dates"},"comment":{"url":"https://api.github.com/repos/google/ggrc-core/issues/comments/242078318","html_url":"https://github.com/google/ggrc-core/pull/4260#issuecomment-242078318","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/4260","id":242078318,"user":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T14:09:41Z","updated_at":"2016-08-24T14:09:41Z","body":"@andrei-karalionak As I've mentioned above, I am not worried about your component. All the operations are done on content that is deemed safe and I have no issues about it.\r\n\r\nWhat I am worried is that you have wrote a function that strips HTML tags in a very unsafe way. Yes, as long as this function stays in your component it's all fine! But as soon as someone moves it to GGRC.Utils so that it can be used in other components it becomes a huge security vulnerability!\r\n\r\nYou are saying that this is something that that probably won't happen, but I have told you that a similar thing HAD HAPPENED in the past. You can't know for sure that this won't happen to this function as it's out of your control, but we can easily protect ourselves with a faster and safer alternative (e.g. `string.replace(/<[^>]+>/g, \"\");`). So why are we arguing about this?"}}
{"actor":{"display_login":"Smotko"}}