{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/11868","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/11868/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11868/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/11868/events","html_url":"https://github.com/openshift/origin/pull/11868","id":188472483,"number":11868,"title":"Allow to unlink deleted secrets from a service account","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/17","html_url":"https://github.com/openshift/origin/milestone/17","labels_url":"https://api.github.com/repos/openshift/origin/milestones/17/labels","id":2049440,"number":17,"title":"1.5.0","description":null,"creator":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":22,"state":"open","created_at":"2016-10-05T12:16:28Z","updated_at":"2016-12-15T09:14:46Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-11-10T10:32:43Z","updated_at":"2016-12-15T12:45:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11868","html_url":"https://github.com/openshift/origin/pull/11868","diff_url":"https://github.com/openshift/origin/pull/11868.diff","patch_url":"https://github.com/openshift/origin/pull/11868.patch"},"body":"Fixes: https://github.com/openshift/origin/issues/11851\r\n\r\n@fabianofranz PTAL this improves a logic around linking/unlinking the secrets a little bit:\r\n\r\n```console\r\n[@dev] .../openshift/origin # oc create secret generic test --from-literal=foo=bar\r\nsecret \"test\" created\r\n[@dev] .../openshift/origin # oc secrets unlink builder test\r\nerror: No valid secrets found or secrets not linked to service account\r\n[@dev] .../openshift/origin # oc secrets link builder test\r\n[@dev] .../openshift/origin # oc delete secret test\r\nsecret \"test\" deleted\r\n[@dev] .../openshift/origin # oc secrets unlink builder test\r\nsecret \"test\" not found\r\nerror: Unlinked deleted secrets from test/builder service account\r\n[@dev] .../openshift/origin # oc secrets unlink builder test\r\nsecret \"test\" not found\r\nerror: No valid secrets found or secrets not linked to service account\r\n[@dev] .../openshift/origin # oc secrets link builder test\r\nsecret \"test\" not found\r\nerror: No valid secrets found\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/267319029","html_url":"https://github.com/openshift/origin/pull/11868#issuecomment-267319029","issue_url":"https://api.github.com/repos/openshift/origin/issues/11868","id":267319029,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T12:45:20Z","updated_at":"2016-12-15T12:45:20Z","body":"Evaluated for origin merge up to 4443e8f7565cb87634652bab31cd67da3d74e00c"}}
{"actor":{"display_login":"openshift-bot"}}