{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/13861","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13861/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13861/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13861/events","html_url":"https://github.com/cms-sw/cmssw/pull/13861","id":144422725,"number":13861,"title":"Configurable hardcode conditions for HCAL","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":238,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-03-30T00:03:25Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-03-30T00:03:08Z","updated_at":"2016-03-30T05:43:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13861","html_url":"https://github.com/cms-sw/cmssw/pull/13861","diff_url":"https://github.com/cms-sw/cmssw/pull/13861.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/13861.patch"},"body":"This PR modifies HcalHardcodeConditions and HcalDbHardcode to make basic parameters configurable using Python. This change is intended to aid reconstruction development for the 2017 HF and HE upgrades, respectively: dual anode readout with QIE10 and SiPMs with QIE11 and increased depth segmentation.\r\n\r\n**NB**: Nothing should change in existing workflows, because the hardcode conditions are only used for development.\r\n\r\nElements of this PR:\r\n1. New class HcalHardcodeParameters (modeled after HcalSimParameters), currently contains pedestal, pedestal width, gain, gain width, QIE type, QIE offsets (range 0-3), QIE slopes (range 0-3)\r\n2. HcalDbHardcode now a class (instead of a namespace)\r\n3. Fixed any HcalDbHardcode dependencies accordingly (or removed unnecessary includes, in one case deleted an unused piece of code after [discussion on HCAL CMSSW hypernews](https://hypernews.cern.ch/HyperNews/CMS/get/hcal-cmssw/175.html))\r\n4. Hcal_Conditions_forGlobalTag_cff has PSets for:HB, HE, HF, HO, HB upgrade, HE upgrade, HF upgrade\r\n5. Each subdetector can be set to Run1 or upgrade independently (testHFQIE10 “mixed case” still available)\r\n6. Run1 parameters based on dump of DB conditions from 7_6_3 (GT auto:run2_mc) + HcalQIEData_NormalMode_v7.05_mc for QIEData (newer tag)\r\n7. SiPM lumi offset and pedestal width lumi dependence parameters also now configurable (may be supplanted by new noise & raddam models in the future)\r\n8. Added a customization function customise_HcalPhase0p5 (\"Phase 0.5\"). Currently this enables QIE10 digitization for all HF cells, but keeps Run1 conditions for HE (SiPM + QIE11 not ready yet).\r\n\r\nI've tested the 2017 mode with customise_HcalPhase0p5 and the Extended2017dev geometry, which has HF depths 3/4 and HE depths up to 7. I used the following script:\r\n```\r\n#!/bin/bash\r\n\r\n cmsDriver.py SinglePiE50HCAL_pythia8_cfi  --conditions auto:run2_mc -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent FEVTDEBUG -s GEN,SIM --datatier GEN-SIM --beamspot Realistic50ns13TeVCollision --fileout file:step1.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step1_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n \r\n cmsDriver.py step2  --conditions auto:run2_mc -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent FEVTDEBUGHLT --filein file:step1.root  --fileout file:step2.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step2_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n \r\n cmsDriver.py step3  --runUnscheduled  --conditions auto:run2_mc -s RAW2DIGI,L1Reco,RECO,EI,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --era Run2_2017 --geometry \"Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff\" --eventcontent RECOSIM,MINIAODSIM,DQM --filein file:step2.root  --fileout file:step3.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step3_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1\r\n```\r\n\r\nThe RECO step fails (somewhat predictably, at this point). The DIGI step runs, but has a lot of errors that we'll work on resolving."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/203257575","html_url":"https://github.com/cms-sw/cmssw/pull/13861#issuecomment-203257575","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13861","id":203257575,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T05:43:32Z","updated_at":"2016-03-30T05:43:32Z","body":"The tests are being triggered in jenkins."}}