{"action":"closed","issue":{"url":"https://api.github.com/repos/fdimuccio/play2-sockjs/issues/21","repository_url":"https://api.github.com/repos/fdimuccio/play2-sockjs","labels_url":"https://api.github.com/repos/fdimuccio/play2-sockjs/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/fdimuccio/play2-sockjs/issues/21/comments","events_url":"https://api.github.com/repos/fdimuccio/play2-sockjs/issues/21/events","html_url":"https://github.com/fdimuccio/play2-sockjs/issues/21","id":193967648,"number":21,"title":"Websocket message losses","user":{"login":"TheChifer","id":9582023,"avatar_url":"https://avatars.githubusercontent.com/u/9582023?v=3","gravatar_id":"","url":"https://api.github.com/users/TheChifer","html_url":"https://github.com/TheChifer","followers_url":"https://api.github.com/users/TheChifer/followers","following_url":"https://api.github.com/users/TheChifer/following{/other_user}","gists_url":"https://api.github.com/users/TheChifer/gists{/gist_id}","starred_url":"https://api.github.com/users/TheChifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheChifer/subscriptions","organizations_url":"https://api.github.com/users/TheChifer/orgs","repos_url":"https://api.github.com/users/TheChifer/repos","events_url":"https://api.github.com/users/TheChifer/events{/privacy}","received_events_url":"https://api.github.com/users/TheChifer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-07T06:22:28Z","updated_at":"2016-12-08T18:07:18Z","closed_at":"2016-12-08T18:07:18Z","body":"After upgrading to Play2.5.x & play2-sockjs 0.5.0/0.5.1 I am seeing message losses.\r\nSockJS setup\r\n\r\n```\r\npublic SockJSSettings settings() {\r\n        return  new SockJSSettings()\r\n            .withWebsocket(true)\r\n            .withHeartbeat(FiniteDuration.create(config.getInt(ConfigHelper.WEBSOCKET_HEARTBEAT), TimeUnit.MILLISECONDS))    \r\n            .withStreamingQuota(4*1024);\r\n    }\r\n```\r\nWith v2.5. upgrade I can see sockjs is buffering multiple messages emitted by the linked Actor, hence I see larger array frames sent to the client\r\nEg an 'a' frame with 8 array elements with the size of  21846\r\n\r\nthese large wrapped frames misses messages, for example about 3 messages in the middle are missing, it should be a frame having 11 message elements. Not all wrapping frames misses messages but happens often enough. \r\n\r\nFrom server logs I can see the actor is firing messages correctly to the sockjs router actor & from browser network tab can see the loss.\r\n\r\nSockJS client is white listed only to use websocket transport\r\n\r\nwith v2.4 I see smaller frames of 4k with a single message frames. 2.4 is NO loss and very stable."}}
{"actor":{"display_login":"fdimuccio"}}