{"action":"created","comment":{"url":"https://api.github.com/repos/IMQS/router-core/pulls/comments/80849111","pull_request_review_id":1873456,"id":80849111,"diff_hunk":"@@ -72,11 +72,18 @@ func authPassThrough(log *log.Logger, w http.ResponseWriter, req *http.Request,\n \t\treturn authInjectYellowfin(log, w, req, authData, target)\n \tcase AuthPassThroughSitePro:\n \t\treturn authInjectSitePro(log, w, req, target)\n+\tcase AuthPassThroughECS:\n+\t\treturn authInjectECS(log, w, req, target)\n \tdefault:\n \t\treturn true\n \t}\n }\n \n+func authInjectECS(log *log.Logger, w http.ResponseWriter, req *http.Request, target *targetPassThroughAuth) bool {\n+\treq.SetBasicAuth(target.config.Username, target.config.Password)","path":"router/auth.go","position":12,"original_position":12,"commit_id":"8eff54e3eb32bfc582c5f3b65d24e79047873c23","original_commit_id":"8eff54e3eb32bfc582c5f3b65d24e79047873c23","user":{"login":"JacoBriers","id":1818218,"avatar_url":"https://avatars.githubusercontent.com/u/1818218?v=3","gravatar_id":"","url":"https://api.github.com/users/JacoBriers","html_url":"https://github.com/JacoBriers","followers_url":"https://api.github.com/users/JacoBriers/followers","following_url":"https://api.github.com/users/JacoBriers/following{/other_user}","gists_url":"https://api.github.com/users/JacoBriers/gists{/gist_id}","starred_url":"https://api.github.com/users/JacoBriers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacoBriers/subscriptions","organizations_url":"https://api.github.com/users/JacoBriers/orgs","repos_url":"https://api.github.com/users/JacoBriers/repos","events_url":"https://api.github.com/users/JacoBriers/events{/privacy}","received_events_url":"https://api.github.com/users/JacoBriers/received_events","type":"User","site_admin":false},"body":"@LeonLeibbrandt  we can combine ECS and SitePro auth into `authInjectBasicAuth` because methods are identical","created_at":"2016-09-28T06:18:28Z","updated_at":"2016-09-28T06:18:32Z","html_url":"https://github.com/IMQS/router-core/pull/10#discussion_r80849111","pull_request_url":"https://api.github.com/repos/IMQS/router-core/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/comments/80849111"},"html":{"href":"https://github.com/IMQS/router-core/pull/10#discussion_r80849111"},"pull_request":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/IMQS/router-core/pulls/10","id":86908007,"html_url":"https://github.com/IMQS/router-core/pull/10","diff_url":"https://github.com/IMQS/router-core/pull/10.diff","patch_url":"https://github.com/IMQS/router-core/pull/10.patch","issue_url":"https://api.github.com/repos/IMQS/router-core/issues/10","number":10,"state":"closed","locked":false,"title":"TP-227 Added Auth Passthrough for ECS","user":{"login":"LeonLeibbrandt","id":4902348,"avatar_url":"https://avatars.githubusercontent.com/u/4902348?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonLeibbrandt","html_url":"https://github.com/LeonLeibbrandt","followers_url":"https://api.github.com/users/LeonLeibbrandt/followers","following_url":"https://api.github.com/users/LeonLeibbrandt/following{/other_user}","gists_url":"https://api.github.com/users/LeonLeibbrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonLeibbrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonLeibbrandt/subscriptions","organizations_url":"https://api.github.com/users/LeonLeibbrandt/orgs","repos_url":"https://api.github.com/users/LeonLeibbrandt/repos","events_url":"https://api.github.com/users/LeonLeibbrandt/events{/privacy}","received_events_url":"https://api.github.com/users/LeonLeibbrandt/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-27T11:06:55Z","updated_at":"2016-09-28T06:18:32Z","closed_at":"2016-09-28T06:09:35Z","merged_at":"2016-09-28T06:09:35Z","merge_commit_sha":"920ca4c93386f085268f9a6aa54d27ddc75f05eb","assignee":{"login":"JacoBriers","id":1818218,"avatar_url":"https://avatars.githubusercontent.com/u/1818218?v=3","gravatar_id":"","url":"https://api.github.com/users/JacoBriers","html_url":"https://github.com/JacoBriers","followers_url":"https://api.github.com/users/JacoBriers/followers","following_url":"https://api.github.com/users/JacoBriers/following{/other_user}","gists_url":"https://api.github.com/users/JacoBriers/gists{/gist_id}","starred_url":"https://api.github.com/users/JacoBriers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacoBriers/subscriptions","organizations_url":"https://api.github.com/users/JacoBriers/orgs","repos_url":"https://api.github.com/users/JacoBriers/repos","events_url":"https://api.github.com/users/JacoBriers/events{/privacy}","received_events_url":"https://api.github.com/users/JacoBriers/received_events","type":"User","site_admin":false},"assignees":[{"login":"JacoBriers","id":1818218,"avatar_url":"https://avatars.githubusercontent.com/u/1818218?v=3","gravatar_id":"","url":"https://api.github.com/users/JacoBriers","html_url":"https://github.com/JacoBriers","followers_url":"https://api.github.com/users/JacoBriers/followers","following_url":"https://api.github.com/users/JacoBriers/following{/other_user}","gists_url":"https://api.github.com/users/JacoBriers/gists{/gist_id}","starred_url":"https://api.github.com/users/JacoBriers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacoBriers/subscriptions","organizations_url":"https://api.github.com/users/JacoBriers/orgs","repos_url":"https://api.github.com/users/JacoBriers/repos","events_url":"https://api.github.com/users/JacoBriers/events{/privacy}","received_events_url":"https://api.github.com/users/JacoBriers/received_events","type":"User","site_admin":false},{"login":"RoanBrand","id":14920090,"avatar_url":"https://avatars.githubusercontent.com/u/14920090?v=3","gravatar_id":"","url":"https://api.github.com/users/RoanBrand","html_url":"https://github.com/RoanBrand","followers_url":"https://api.github.com/users/RoanBrand/followers","following_url":"https://api.github.com/users/RoanBrand/following{/other_user}","gists_url":"https://api.github.com/users/RoanBrand/gists{/gist_id}","starred_url":"https://api.github.com/users/RoanBrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoanBrand/subscriptions","organizations_url":"https://api.github.com/users/RoanBrand/orgs","repos_url":"https://api.github.com/users/RoanBrand/repos","events_url":"https://api.github.com/users/RoanBrand/events{/privacy}","received_events_url":"https://api.github.com/users/RoanBrand/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IMQS/router-core/pulls/10/commits","review_comments_url":"https://api.github.com/repos/IMQS/router-core/pulls/10/comments","review_comment_url":"https://api.github.com/repos/IMQS/router-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMQS/router-core/issues/10/comments","statuses_url":"https://api.github.com/repos/IMQS/router-core/statuses/8eff54e3eb32bfc582c5f3b65d24e79047873c23","head":{"label":"IMQS:phx-ll-add-ecs-passthrough-auth","ref":"phx-ll-add-ecs-passthrough-auth","sha":"8eff54e3eb32bfc582c5f3b65d24e79047873c23","user":{"login":"IMQS","id":2345243,"avatar_url":"https://avatars.githubusercontent.com/u/2345243?v=3","gravatar_id":"","url":"https://api.github.com/users/IMQS","html_url":"https://github.com/IMQS","followers_url":"https://api.github.com/users/IMQS/followers","following_url":"https://api.github.com/users/IMQS/following{/other_user}","gists_url":"https://api.github.com/users/IMQS/gists{/gist_id}","starred_url":"https://api.github.com/users/IMQS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMQS/subscriptions","organizations_url":"https://api.github.com/users/IMQS/orgs","repos_url":"https://api.github.com/users/IMQS/repos","events_url":"https://api.github.com/users/IMQS/events{/privacy}","received_events_url":"https://api.github.com/users/IMQS/received_events","type":"Organization","site_admin":false},"repo":{"id":14203117,"name":"router-core","full_name":"IMQS/router-core","owner":{"login":"IMQS","id":2345243,"avatar_url":"https://avatars.githubusercontent.com/u/2345243?v=3","gravatar_id":"","url":"https://api.github.com/users/IMQS","html_url":"https://github.com/IMQS","followers_url":"https://api.github.com/users/IMQS/followers","following_url":"https://api.github.com/users/IMQS/following{/other_user}","gists_url":"https://api.github.com/users/IMQS/gists{/gist_id}","starred_url":"https://api.github.com/users/IMQS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMQS/subscriptions","organizations_url":"https://api.github.com/users/IMQS/orgs","repos_url":"https://api.github.com/users/IMQS/repos","events_url":"https://api.github.com/users/IMQS/events{/privacy}","received_events_url":"https://api.github.com/users/IMQS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMQS/router-core","description":"HTTP Front Door","fork":false,"url":"https://api.github.com/repos/IMQS/router-core","forks_url":"https://api.github.com/repos/IMQS/router-core/forks","keys_url":"https://api.github.com/repos/IMQS/router-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMQS/router-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMQS/router-core/teams","hooks_url":"https://api.github.com/repos/IMQS/router-core/hooks","issue_events_url":"https://api.github.com/repos/IMQS/router-core/issues/events{/number}","events_url":"https://api.github.com/repos/IMQS/router-core/events","assignees_url":"https://api.github.com/repos/IMQS/router-core/assignees{/user}","branches_url":"https://api.github.com/repos/IMQS/router-core/branches{/branch}","tags_url":"https://api.github.com/repos/IMQS/router-core/tags","blobs_url":"https://api.github.com/repos/IMQS/router-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMQS/router-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMQS/router-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMQS/router-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMQS/router-core/statuses/{sha}","languages_url":"https://api.github.com/repos/IMQS/router-core/languages","stargazers_url":"https://api.github.com/repos/IMQS/router-core/stargazers","contributors_url":"https://api.github.com/repos/IMQS/router-core/contributors","subscribers_url":"https://api.github.com/repos/IMQS/router-core/subscribers","subscription_url":"https://api.github.com/repos/IMQS/router-core/subscription","commits_url":"https://api.github.com/repos/IMQS/router-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMQS/router-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMQS/router-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMQS/router-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMQS/router-core/contents/{+path}","compare_url":"https://api.github.com/repos/IMQS/router-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMQS/router-core/merges","archive_url":"https://api.github.com/repos/IMQS/router-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMQS/router-core/downloads","issues_url":"https://api.github.com/repos/IMQS/router-core/issues{/number}","pulls_url":"https://api.github.com/repos/IMQS/router-core/pulls{/number}","milestones_url":"https://api.github.com/repos/IMQS/router-core/milestones{/number}","notifications_url":"https://api.github.com/repos/IMQS/router-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMQS/router-core/labels{/name}","releases_url":"https://api.github.com/repos/IMQS/router-core/releases{/id}","deployments_url":"https://api.github.com/repos/IMQS/router-core/deployments","created_at":"2013-11-07T12:27:29Z","updated_at":"2016-01-15T08:12:59Z","pushed_at":"2016-09-28T06:09:40Z","git_url":"git://github.com/IMQS/router-core.git","ssh_url":"git@github.com:IMQS/router-core.git","clone_url":"https://github.com/IMQS/router-core.git","svn_url":"https://github.com/IMQS/router-core","homepage":null,"size":517,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMQS:master","ref":"master","sha":"3f93578aca2e5d41509b15a7b1135d35bd6d6ed9","user":{"login":"IMQS","id":2345243,"avatar_url":"https://avatars.githubusercontent.com/u/2345243?v=3","gravatar_id":"","url":"https://api.github.com/users/IMQS","html_url":"https://github.com/IMQS","followers_url":"https://api.github.com/users/IMQS/followers","following_url":"https://api.github.com/users/IMQS/following{/other_user}","gists_url":"https://api.github.com/users/IMQS/gists{/gist_id}","starred_url":"https://api.github.com/users/IMQS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMQS/subscriptions","organizations_url":"https://api.github.com/users/IMQS/orgs","repos_url":"https://api.github.com/users/IMQS/repos","events_url":"https://api.github.com/users/IMQS/events{/privacy}","received_events_url":"https://api.github.com/users/IMQS/received_events","type":"Organization","site_admin":false},"repo":{"id":14203117,"name":"router-core","full_name":"IMQS/router-core","owner":{"login":"IMQS","id":2345243,"avatar_url":"https://avatars.githubusercontent.com/u/2345243?v=3","gravatar_id":"","url":"https://api.github.com/users/IMQS","html_url":"https://github.com/IMQS","followers_url":"https://api.github.com/users/IMQS/followers","following_url":"https://api.github.com/users/IMQS/following{/other_user}","gists_url":"https://api.github.com/users/IMQS/gists{/gist_id}","starred_url":"https://api.github.com/users/IMQS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMQS/subscriptions","organizations_url":"https://api.github.com/users/IMQS/orgs","repos_url":"https://api.github.com/users/IMQS/repos","events_url":"https://api.github.com/users/IMQS/events{/privacy}","received_events_url":"https://api.github.com/users/IMQS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMQS/router-core","description":"HTTP Front Door","fork":false,"url":"https://api.github.com/repos/IMQS/router-core","forks_url":"https://api.github.com/repos/IMQS/router-core/forks","keys_url":"https://api.github.com/repos/IMQS/router-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMQS/router-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMQS/router-core/teams","hooks_url":"https://api.github.com/repos/IMQS/router-core/hooks","issue_events_url":"https://api.github.com/repos/IMQS/router-core/issues/events{/number}","events_url":"https://api.github.com/repos/IMQS/router-core/events","assignees_url":"https://api.github.com/repos/IMQS/router-core/assignees{/user}","branches_url":"https://api.github.com/repos/IMQS/router-core/branches{/branch}","tags_url":"https://api.github.com/repos/IMQS/router-core/tags","blobs_url":"https://api.github.com/repos/IMQS/router-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMQS/router-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMQS/router-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMQS/router-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMQS/router-core/statuses/{sha}","languages_url":"https://api.github.com/repos/IMQS/router-core/languages","stargazers_url":"https://api.github.com/repos/IMQS/router-core/stargazers","contributors_url":"https://api.github.com/repos/IMQS/router-core/contributors","subscribers_url":"https://api.github.com/repos/IMQS/router-core/subscribers","subscription_url":"https://api.github.com/repos/IMQS/router-core/subscription","commits_url":"https://api.github.com/repos/IMQS/router-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMQS/router-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMQS/router-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMQS/router-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMQS/router-core/contents/{+path}","compare_url":"https://api.github.com/repos/IMQS/router-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMQS/router-core/merges","archive_url":"https://api.github.com/repos/IMQS/router-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMQS/router-core/downloads","issues_url":"https://api.github.com/repos/IMQS/router-core/issues{/number}","pulls_url":"https://api.github.com/repos/IMQS/router-core/pulls{/number}","milestones_url":"https://api.github.com/repos/IMQS/router-core/milestones{/number}","notifications_url":"https://api.github.com/repos/IMQS/router-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMQS/router-core/labels{/name}","releases_url":"https://api.github.com/repos/IMQS/router-core/releases{/id}","deployments_url":"https://api.github.com/repos/IMQS/router-core/deployments","created_at":"2013-11-07T12:27:29Z","updated_at":"2016-01-15T08:12:59Z","pushed_at":"2016-09-28T06:09:40Z","git_url":"git://github.com/IMQS/router-core.git","ssh_url":"git@github.com:IMQS/router-core.git","clone_url":"https://github.com/IMQS/router-core.git","svn_url":"https://github.com/IMQS/router-core","homepage":null,"size":517,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/10"},"html":{"href":"https://github.com/IMQS/router-core/pull/10"},"issue":{"href":"https://api.github.com/repos/IMQS/router-core/issues/10"},"comments":{"href":"https://api.github.com/repos/IMQS/router-core/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMQS/router-core/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/IMQS/router-core/statuses/8eff54e3eb32bfc582c5f3b65d24e79047873c23"}}}}
{"actor":{"display_login":"JacoBriers"}}