{"action":"created","comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/55921252","id":55921252,"diff_hunk":"@@ -41,48 +41,51 @@\n \n #if defined(STM32F4)\n /* untested, should go into libopencm3 */\n-const clock_scale_t hse_24mhz_3v3[CLOCK_3V3_END] = {\n-\t{ /* 48MHz */\n-\t\t.pllm = 24,\n-\t\t.plln = 96,\n-\t\t.pllp = 2,\n-\t\t.pllq = 2,\n-\t\t.hpre = RCC_CFGR_HPRE_DIV_NONE,\n-\t\t.ppre1 = RCC_CFGR_PPRE_DIV_4,\n-\t\t.ppre2 = RCC_CFGR_PPRE_DIV_2,\n-\t\t.power_save = 1,\n-\t\t.flash_config = FLASH_ACR_ICE | FLASH_ACR_DCE |\n-\t\t\t\tFLASH_ACR_LATENCY_3WS,\n-\t\t.apb1_frequency = 12000000,\n-\t\t.apb2_frequency = 24000000,\n-\t},\n-\t{ /* 120MHz */\n-\t\t.pllm = 24,\n-\t\t.plln = 240,\n-\t\t.pllp = 2,\n-\t\t.pllq = 5,\n-\t\t.hpre = RCC_CFGR_HPRE_DIV_NONE,\n-\t\t.ppre1 = RCC_CFGR_PPRE_DIV_4,\n-\t\t.ppre2 = RCC_CFGR_PPRE_DIV_2,\n-\t\t.power_save = 1,\n-\t\t.flash_config = FLASH_ACR_ICE | FLASH_ACR_DCE |\n-\t\t\t\tFLASH_ACR_LATENCY_3WS,\n-\t\t.apb1_frequency = 30000000,\n-\t\t.apb2_frequency = 60000000,\n-\t},\n-\t{ /* 168MHz */\n-\t\t.pllm = 24,\n-\t\t.plln = 336,\n-\t\t.pllp = 2,\n-\t\t.pllq = 7,\n-\t\t.hpre = RCC_CFGR_HPRE_DIV_NONE,\n-\t\t.ppre1 = RCC_CFGR_PPRE_DIV_4,\n-\t\t.ppre2 = RCC_CFGR_PPRE_DIV_2,\n-\t\t.flash_config = FLASH_ACR_ICE | FLASH_ACR_DCE |\n-\t\t\t\tFLASH_ACR_LATENCY_5WS,\n-\t\t.apb1_frequency = 42000000,\n-\t\t.apb2_frequency = 84000000,\n-\t},\n+const struct rcc_clock_scale rcc_hse_24mhz_3v3[RCC_CLOCK_3V3_END] = {\n+  { /* 48MHz */\n+    .pllm = 24,\n+    .plln = 96,\n+    .pllp = 2,\n+    .pllq = 2,\n+    .hpre = RCC_CFGR_HPRE_DIV_NONE,\n+    .ppre1 = RCC_CFGR_PPRE_DIV_4,\n+    .ppre2 = RCC_CFGR_PPRE_DIV_2,\n+    .power_save = 1,\n+    .flash_config = FLASH_ACR_ICE | FLASH_ACR_DCE |\n+    FLASH_ACR_LATENCY_3WS,\n+    .ahb_frequency  = 48000000,\n+    .apb1_frequency = 12000000,\n+    .apb2_frequency = 24000000,\n+  },","path":"sw/airborne/arch/stm32/mcu_arch.c","position":61,"original_position":61,"commit_id":"30418694206b78fb9cd6edd7ad3fdb7400dbd7d8","original_commit_id":"30418694206b78fb9cd6edd7ad3fdb7400dbd7d8","user":{"login":"kevindehecker","id":5213220,"avatar_url":"https://avatars.githubusercontent.com/u/5213220?v=3","gravatar_id":"","url":"https://api.github.com/users/kevindehecker","html_url":"https://github.com/kevindehecker","followers_url":"https://api.github.com/users/kevindehecker/followers","following_url":"https://api.github.com/users/kevindehecker/following{/other_user}","gists_url":"https://api.github.com/users/kevindehecker/gists{/gist_id}","starred_url":"https://api.github.com/users/kevindehecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevindehecker/subscriptions","organizations_url":"https://api.github.com/users/kevindehecker/orgs","repos_url":"https://api.github.com/users/kevindehecker/repos","events_url":"https://api.github.com/users/kevindehecker/events{/privacy}","received_events_url":"https://api.github.com/users/kevindehecker/received_events","type":"User","site_admin":false},"body":"Yep, there should be another 84MHz config here! That solves my problem.","created_at":"2016-03-12T13:09:33Z","updated_at":"2016-03-12T13:09:33Z","html_url":"https://github.com/paparazzi/paparazzi/pull/1557#discussion_r55921252","pull_request_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/55921252"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1557#discussion_r55921252"},"pull_request":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557","id":62241382,"html_url":"https://github.com/paparazzi/paparazzi/pull/1557","diff_url":"https://github.com/paparazzi/paparazzi/pull/1557.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1557.patch","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1557","number":1557,"state":"open","locked":false,"title":"[ext] update to latest libopencm3","user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"body":"and update clock setup accordingly","created_at":"2016-03-09T15:03:39Z","updated_at":"2016-03-12T13:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2490d8cf745293ced85c13083c6db0c9da4de15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1557/comments","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/30418694206b78fb9cd6edd7ad3fdb7400dbd7d8","head":{"label":"paparazzi:update_locm3","ref":"update_locm3","sha":"30418694206b78fb9cd6edd7ad3fdb7400dbd7d8","user":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"name":"paparazzi","full_name":"paparazzi/paparazzi","owner":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/paparazzi/paparazzi/deployments","created_at":"2010-11-10T11:14:08Z","updated_at":"2016-03-12T01:00:27Z","pushed_at":"2016-03-11T17:07:45Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":85923,"stargazers_count":544,"watchers_count":544,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":565,"mirror_url":null,"open_issues_count":112,"forks":565,"open_issues":112,"watchers":544,"default_branch":"master"}},"base":{"label":"paparazzi:master","ref":"master","sha":"625d7558a523f706f4d9c41b5695e5d47e02cb47","user":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"name":"paparazzi","full_name":"paparazzi/paparazzi","owner":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/paparazzi/paparazzi/deployments","created_at":"2010-11-10T11:14:08Z","updated_at":"2016-03-12T01:00:27Z","pushed_at":"2016-03-11T17:07:45Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":85923,"stargazers_count":544,"watchers_count":544,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":565,"mirror_url":null,"open_issues_count":112,"forks":565,"open_issues":112,"watchers":544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1557"},"issue":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1557"},"comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/paparazzi/paparazzi/statuses/30418694206b78fb9cd6edd7ad3fdb7400dbd7d8"}}}}