{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/58830939","id":58830939,"diff_hunk":"@@ -567,13 +571,16 @@ public boolean hasLicensesXml() {\n             PluginWrapper dependency = parent.getPlugin(d.shortName);\n             if (dependency == null) {\n                 missingDependencies.add(d.toString());\n+                NOTICE.addErrorMessage(Messages.PluginWrapper_admonitor_MissingDependency(shortName, dependency.getLongName()));","path":"core/src/main/java/hudson/PluginWrapper.java","position":29,"original_position":29,"commit_id":"8381dbd4e076268b57f2cdf98cc59376a1d3843c","original_commit_id":"8381dbd4e076268b57f2cdf98cc59376a1d3843c","user":{"login":"Vlatombe","id":171459,"avatar_url":"https://avatars.githubusercontent.com/u/171459?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlatombe","html_url":"https://github.com/Vlatombe","followers_url":"https://api.github.com/users/Vlatombe/followers","following_url":"https://api.github.com/users/Vlatombe/following{/other_user}","gists_url":"https://api.github.com/users/Vlatombe/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlatombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlatombe/subscriptions","organizations_url":"https://api.github.com/users/Vlatombe/orgs","repos_url":"https://api.github.com/users/Vlatombe/repos","events_url":"https://api.github.com/users/Vlatombe/events{/privacy}","received_events_url":"https://api.github.com/users/Vlatombe/received_events","type":"User","site_admin":false},"body":"NPE here.","created_at":"2016-04-07T07:44:59Z","updated_at":"2016-04-07T07:44:59Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2234#discussion_r58830939","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/58830939"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2234#discussion_r58830939"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234","id":65525340,"html_url":"https://github.com/jenkinsci/jenkins/pull/2234","diff_url":"https://github.com/jenkinsci/jenkins/pull/2234.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2234.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2234","number":2234,"state":"open","locked":false,"title":"[FIXED JENKINS-21485] AdministrativeMonitor for plugins that have failed","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"body":"This PR substitute #2098 in case we keep @Vlatombe's PR #2172. \r\n\r\nNotice that I needed to do:\r\n\r\n```\r\npublic final static PluginWrapperAdministrativeMonitor NOTICE = new PluginWrapperAdministrativeMonitor();\r\n```\r\n\r\nbecause it looks like the Extensions are not leaded at this point.\r\n\r\nCC @jglick @daniel-beck @Vlatombe \r\n\r\n@reviewbybees","created_at":"2016-04-06T19:51:04Z","updated_at":"2016-04-07T07:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15272d57f6b9891651281354b0083875a7e271bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2234/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8381dbd4e076268b57f2cdf98cc59376a1d3843c","head":{"label":"fbelzunc:JENKINS-21485-v2","ref":"JENKINS-21485-v2","sha":"8381dbd4e076268b57f2cdf98cc59376a1d3843c","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"repo":{"id":28363598,"name":"jenkins","full_name":"fbelzunc/jenkins","owner":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbelzunc/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/fbelzunc/jenkins","forks_url":"https://api.github.com/repos/fbelzunc/jenkins/forks","keys_url":"https://api.github.com/repos/fbelzunc/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbelzunc/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbelzunc/jenkins/teams","hooks_url":"https://api.github.com/repos/fbelzunc/jenkins/hooks","issue_events_url":"https://api.github.com/repos/fbelzunc/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/fbelzunc/jenkins/events","assignees_url":"https://api.github.com/repos/fbelzunc/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/fbelzunc/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/fbelzunc/jenkins/tags","blobs_url":"https://api.github.com/repos/fbelzunc/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbelzunc/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbelzunc/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbelzunc/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbelzunc/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/fbelzunc/jenkins/languages","stargazers_url":"https://api.github.com/repos/fbelzunc/jenkins/stargazers","contributors_url":"https://api.github.com/repos/fbelzunc/jenkins/contributors","subscribers_url":"https://api.github.com/repos/fbelzunc/jenkins/subscribers","subscription_url":"https://api.github.com/repos/fbelzunc/jenkins/subscription","commits_url":"https://api.github.com/repos/fbelzunc/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbelzunc/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbelzunc/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbelzunc/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbelzunc/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/fbelzunc/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbelzunc/jenkins/merges","archive_url":"https://api.github.com/repos/fbelzunc/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbelzunc/jenkins/downloads","issues_url":"https://api.github.com/repos/fbelzunc/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/fbelzunc/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/fbelzunc/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/fbelzunc/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbelzunc/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/fbelzunc/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/fbelzunc/jenkins/deployments","created_at":"2014-12-22T22:48:05Z","updated_at":"2016-01-19T12:32:48Z","pushed_at":"2016-04-06T19:39:11Z","git_url":"git://github.com/fbelzunc/jenkins.git","ssh_url":"git@github.com:fbelzunc/jenkins.git","clone_url":"https://github.com/fbelzunc/jenkins.git","svn_url":"https://github.com/fbelzunc/jenkins","homepage":"http://jenkins-ci.org/","size":92774,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"511ccf0c836651d1d825c062d7d42338438c735c","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-04-07T07:42:37Z","pushed_at":"2016-04-07T04:21:41Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":99383,"stargazers_count":5519,"watchers_count":5519,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2429,"mirror_url":null,"open_issues_count":140,"forks":2429,"open_issues":140,"watchers":5519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2234"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2234"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2234/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2234/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8381dbd4e076268b57f2cdf98cc59376a1d3843c"}}}}