{"action":"closed","number":363,"pull_request":{"url":"https://api.github.com/repos/hadley/testthat/pulls/363","id":58701142,"html_url":"https://github.com/hadley/testthat/pull/363","diff_url":"https://github.com/hadley/testthat/pull/363.diff","patch_url":"https://github.com/hadley/testthat/pull/363.patch","issue_url":"https://api.github.com/repos/hadley/testthat/issues/363","number":363,"state":"closed","locked":false,"title":"add class check to throws_error","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars.githubusercontent.com/u/1222726?v=3","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"body":"I wasn't sure about adding this argument to `throws_error` rather than having two separate functions (one for the `regexp` check and one for the `class` check). I decided to put it all together so that people can concisely check both at the same time if they want to (and don't have to learn about a new function). Thoughts?\r\n\r\n(As expressed in my unit tests, the `expectation` fails if either the `regexp` check or the `class` check fails.)\r\n\r\nAlso, I struggled a bit to concisely explain what this is about in the help text. I really wanted to link to http://adv-r.had.co.nz/Exceptions-Debugging.html, since I haven't seen this explained well anywhere else and many users will need a full explanation if they want to use this option.","created_at":"2016-02-09T03:29:12Z","updated_at":"2016-02-20T22:09:14Z","closed_at":"2016-02-20T22:09:14Z","merged_at":null,"merge_commit_sha":"a37a3a34e69809bcb9cf2138180fe6f1530b5a3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hadley/testthat/pulls/363/commits","review_comments_url":"https://api.github.com/repos/hadley/testthat/pulls/363/comments","review_comment_url":"https://api.github.com/repos/hadley/testthat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hadley/testthat/issues/363/comments","statuses_url":"https://api.github.com/repos/hadley/testthat/statuses/971d4781025ffdef5f1ef6fe609f66c61c60bcfd","head":{"label":"dchudz:class-check-in-throws_error","ref":"class-check-in-throws_error","sha":"971d4781025ffdef5f1ef6fe609f66c61c60bcfd","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars.githubusercontent.com/u/1222726?v=3","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"repo":{"id":51341034,"name":"testthat","full_name":"dchudz/testthat","owner":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars.githubusercontent.com/u/1222726?v=3","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchudz/testthat","description":"An R package to make testing fun","fork":true,"url":"https://api.github.com/repos/dchudz/testthat","forks_url":"https://api.github.com/repos/dchudz/testthat/forks","keys_url":"https://api.github.com/repos/dchudz/testthat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchudz/testthat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchudz/testthat/teams","hooks_url":"https://api.github.com/repos/dchudz/testthat/hooks","issue_events_url":"https://api.github.com/repos/dchudz/testthat/issues/events{/number}","events_url":"https://api.github.com/repos/dchudz/testthat/events","assignees_url":"https://api.github.com/repos/dchudz/testthat/assignees{/user}","branches_url":"https://api.github.com/repos/dchudz/testthat/branches{/branch}","tags_url":"https://api.github.com/repos/dchudz/testthat/tags","blobs_url":"https://api.github.com/repos/dchudz/testthat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchudz/testthat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchudz/testthat/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchudz/testthat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchudz/testthat/statuses/{sha}","languages_url":"https://api.github.com/repos/dchudz/testthat/languages","stargazers_url":"https://api.github.com/repos/dchudz/testthat/stargazers","contributors_url":"https://api.github.com/repos/dchudz/testthat/contributors","subscribers_url":"https://api.github.com/repos/dchudz/testthat/subscribers","subscription_url":"https://api.github.com/repos/dchudz/testthat/subscription","commits_url":"https://api.github.com/repos/dchudz/testthat/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchudz/testthat/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchudz/testthat/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchudz/testthat/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchudz/testthat/contents/{+path}","compare_url":"https://api.github.com/repos/dchudz/testthat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchudz/testthat/merges","archive_url":"https://api.github.com/repos/dchudz/testthat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchudz/testthat/downloads","issues_url":"https://api.github.com/repos/dchudz/testthat/issues{/number}","pulls_url":"https://api.github.com/repos/dchudz/testthat/pulls{/number}","milestones_url":"https://api.github.com/repos/dchudz/testthat/milestones{/number}","notifications_url":"https://api.github.com/repos/dchudz/testthat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchudz/testthat/labels{/name}","releases_url":"https://api.github.com/repos/dchudz/testthat/releases{/id}","deployments_url":"https://api.github.com/repos/dchudz/testthat/deployments","created_at":"2016-02-09T01:59:09Z","updated_at":"2016-02-09T01:59:09Z","pushed_at":"2016-02-19T02:27:25Z","git_url":"git://github.com/dchudz/testthat.git","ssh_url":"git@github.com:dchudz/testthat.git","clone_url":"https://github.com/dchudz/testthat.git","svn_url":"https://github.com/dchudz/testthat","homepage":"","size":1251,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hadley:master","ref":"master","sha":"9ae7c4fc14045f57039679d47cc6e591d258d8c6","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"repo":{"id":295311,"name":"testthat","full_name":"hadley/testthat","owner":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hadley/testthat","description":"An R package to make testing fun","fork":false,"url":"https://api.github.com/repos/hadley/testthat","forks_url":"https://api.github.com/repos/hadley/testthat/forks","keys_url":"https://api.github.com/repos/hadley/testthat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadley/testthat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadley/testthat/teams","hooks_url":"https://api.github.com/repos/hadley/testthat/hooks","issue_events_url":"https://api.github.com/repos/hadley/testthat/issues/events{/number}","events_url":"https://api.github.com/repos/hadley/testthat/events","assignees_url":"https://api.github.com/repos/hadley/testthat/assignees{/user}","branches_url":"https://api.github.com/repos/hadley/testthat/branches{/branch}","tags_url":"https://api.github.com/repos/hadley/testthat/tags","blobs_url":"https://api.github.com/repos/hadley/testthat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadley/testthat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadley/testthat/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadley/testthat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadley/testthat/statuses/{sha}","languages_url":"https://api.github.com/repos/hadley/testthat/languages","stargazers_url":"https://api.github.com/repos/hadley/testthat/stargazers","contributors_url":"https://api.github.com/repos/hadley/testthat/contributors","subscribers_url":"https://api.github.com/repos/hadley/testthat/subscribers","subscription_url":"https://api.github.com/repos/hadley/testthat/subscription","commits_url":"https://api.github.com/repos/hadley/testthat/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadley/testthat/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadley/testthat/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadley/testthat/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadley/testthat/contents/{+path}","compare_url":"https://api.github.com/repos/hadley/testthat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadley/testthat/merges","archive_url":"https://api.github.com/repos/hadley/testthat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadley/testthat/downloads","issues_url":"https://api.github.com/repos/hadley/testthat/issues{/number}","pulls_url":"https://api.github.com/repos/hadley/testthat/pulls{/number}","milestones_url":"https://api.github.com/repos/hadley/testthat/milestones{/number}","notifications_url":"https://api.github.com/repos/hadley/testthat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadley/testthat/labels{/name}","releases_url":"https://api.github.com/repos/hadley/testthat/releases{/id}","deployments_url":"https://api.github.com/repos/hadley/testthat/deployments","created_at":"2009-09-02T12:51:44Z","updated_at":"2016-02-19T12:36:31Z","pushed_at":"2016-02-20T20:31:09Z","git_url":"git://github.com/hadley/testthat.git","ssh_url":"git@github.com:hadley/testthat.git","clone_url":"https://github.com/hadley/testthat.git","svn_url":"https://github.com/hadley/testthat","homepage":"","size":1619,"stargazers_count":292,"watchers_count":292,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":15,"forks":129,"open_issues":15,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hadley/testthat/pulls/363"},"html":{"href":"https://github.com/hadley/testthat/pull/363"},"issue":{"href":"https://api.github.com/repos/hadley/testthat/issues/363"},"comments":{"href":"https://api.github.com/repos/hadley/testthat/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/hadley/testthat/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/hadley/testthat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hadley/testthat/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/hadley/testthat/statuses/971d4781025ffdef5f1ef6fe609f66c61c60bcfd"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":16,"review_comments":10,"commits":5,"additions":97,"deletions":30,"changed_files":5}}