{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/myint/scspell/pulls/10","id":76908549,"html_url":"https://github.com/myint/scspell/pull/10","diff_url":"https://github.com/myint/scspell/pull/10.diff","patch_url":"https://github.com/myint/scspell/pull/10.patch","issue_url":"https://api.github.com/repos/myint/scspell/issues/10","number":10,"state":"closed","locked":false,"title":"Change \"make check\" to spell-check all of scpell/*.py","user":{"login":"cassella","id":590808,"avatar_url":"https://avatars.githubusercontent.com/u/590808?v=3","gravatar_id":"","url":"https://api.github.com/users/cassella","html_url":"https://github.com/cassella","followers_url":"https://api.github.com/users/cassella/followers","following_url":"https://api.github.com/users/cassella/following{/other_user}","gists_url":"https://api.github.com/users/cassella/gists{/gist_id}","starred_url":"https://api.github.com/users/cassella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cassella/subscriptions","organizations_url":"https://api.github.com/users/cassella/orgs","repos_url":"https://api.github.com/users/cassella/repos","events_url":"https://api.github.com/users/cassella/events{/privacy}","received_events_url":"https://api.github.com/users/cassella/received_events","type":"User","site_admin":false},"body":"The main change is to have \"make check\" spell-check scspell/*.py\r\n\r\nThe first commit changes the Makefile to include scspell/*.py (and\r\n--relative-to .), and adds all the resulting words to the dictionary.\r\nThe rest of the commits remove a word or two at a time from the\r\ndictionary, and fix up the code.\r\n\r\nExcept one commit that fixes a few not-words by simplifying the code:\r\nNone of CorporaFile._fn_to_fq_rel()'s callers actually used the fq\r\nportion of the return, so I changed it to _fn_to_rel(), returning only\r\nthe relative path.  (I hadn't noticed when I factored that out that\r\nall fo the callers generated a full-qualified path only to pass it to\r\nmake_relative().  None of them used it again after that.)\r\n\r\n\r\nThe remaining additions to the dictionary:\r\n\r\n1. A bunch of partial words from the scspell interactive prompt\r\noutput, such as \"(N)atural\" -> \"atural\".\r\n\r\n2. A few deliberate misspellings used as examples, e.g. \"varaible\".\r\n\r\n3. configparser, pgen, strerror: Python code.\r\n\r\n4. typerror: part of a URL.\r\n\r\n5. appdata: an environment variable\r\n\r\n6. wordlist/wordlists/workaround: I don't know if these need to change.\r\n\r\n7. fileid/fileids:\r\n\r\nI changed comments and strings printed to the user to say \"file ID\".\r\nBut I left \"fileid\" alone in function and variable names.  Mostly\r\nbecause there are so many instances.  But also because it'll have to\r\nbe in the dictionary as-is at some level, since scspell has been using\r\nit all along as a literal string in the per-file dictionaries (even\r\nwithout the .fileid.json mapping file.):\r\n\r\nDICT_TYPE_FILEID = 'FILEID'        # Identifies file-specific dictionary\r\n\r\n\r\nI can change the other functions and variables to use file_id if you'd\r\nprefer.\r\n\r\n\r\nI added per-file dictionaries using the .fileids.json file.  I could\r\nalso change them to use embedded file IDs if you'd prefer.\r\n\r\n\r\n(For some reason, scspell/data/dictionary.txt includes filetype as a\r\nword...)\r\n","created_at":"2016-07-11T07:13:15Z","updated_at":"2016-07-11T14:57:26Z","closed_at":"2016-07-11T14:57:25Z","merged_at":"2016-07-11T14:57:25Z","merge_commit_sha":"3294243baf33c1146104edeea54e2a5e42d8a740","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/myint/scspell/pulls/10/commits","review_comments_url":"https://api.github.com/repos/myint/scspell/pulls/10/comments","review_comment_url":"https://api.github.com/repos/myint/scspell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/myint/scspell/issues/10/comments","statuses_url":"https://api.github.com/repos/myint/scspell/statuses/cd8545b0095ff61c1fb09c046bc00adecc968617","head":{"label":"cassella:check-all","ref":"check-all","sha":"cd8545b0095ff61c1fb09c046bc00adecc968617","user":{"login":"cassella","id":590808,"avatar_url":"https://avatars.githubusercontent.com/u/590808?v=3","gravatar_id":"","url":"https://api.github.com/users/cassella","html_url":"https://github.com/cassella","followers_url":"https://api.github.com/users/cassella/followers","following_url":"https://api.github.com/users/cassella/following{/other_user}","gists_url":"https://api.github.com/users/cassella/gists{/gist_id}","starred_url":"https://api.github.com/users/cassella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cassella/subscriptions","organizations_url":"https://api.github.com/users/cassella/orgs","repos_url":"https://api.github.com/users/cassella/repos","events_url":"https://api.github.com/users/cassella/events{/privacy}","received_events_url":"https://api.github.com/users/cassella/received_events","type":"User","site_admin":false},"repo":{"id":58790559,"name":"scspell","full_name":"cassella/scspell","owner":{"login":"cassella","id":590808,"avatar_url":"https://avatars.githubusercontent.com/u/590808?v=3","gravatar_id":"","url":"https://api.github.com/users/cassella","html_url":"https://github.com/cassella","followers_url":"https://api.github.com/users/cassella/followers","following_url":"https://api.github.com/users/cassella/following{/other_user}","gists_url":"https://api.github.com/users/cassella/gists{/gist_id}","starred_url":"https://api.github.com/users/cassella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cassella/subscriptions","organizations_url":"https://api.github.com/users/cassella/orgs","repos_url":"https://api.github.com/users/cassella/repos","events_url":"https://api.github.com/users/cassella/events{/privacy}","received_events_url":"https://api.github.com/users/cassella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cassella/scspell","description":"Spell checker for source code.","fork":true,"url":"https://api.github.com/repos/cassella/scspell","forks_url":"https://api.github.com/repos/cassella/scspell/forks","keys_url":"https://api.github.com/repos/cassella/scspell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cassella/scspell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cassella/scspell/teams","hooks_url":"https://api.github.com/repos/cassella/scspell/hooks","issue_events_url":"https://api.github.com/repos/cassella/scspell/issues/events{/number}","events_url":"https://api.github.com/repos/cassella/scspell/events","assignees_url":"https://api.github.com/repos/cassella/scspell/assignees{/user}","branches_url":"https://api.github.com/repos/cassella/scspell/branches{/branch}","tags_url":"https://api.github.com/repos/cassella/scspell/tags","blobs_url":"https://api.github.com/repos/cassella/scspell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cassella/scspell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cassella/scspell/git/refs{/sha}","trees_url":"https://api.github.com/repos/cassella/scspell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cassella/scspell/statuses/{sha}","languages_url":"https://api.github.com/repos/cassella/scspell/languages","stargazers_url":"https://api.github.com/repos/cassella/scspell/stargazers","contributors_url":"https://api.github.com/repos/cassella/scspell/contributors","subscribers_url":"https://api.github.com/repos/cassella/scspell/subscribers","subscription_url":"https://api.github.com/repos/cassella/scspell/subscription","commits_url":"https://api.github.com/repos/cassella/scspell/commits{/sha}","git_commits_url":"https://api.github.com/repos/cassella/scspell/git/commits{/sha}","comments_url":"https://api.github.com/repos/cassella/scspell/comments{/number}","issue_comment_url":"https://api.github.com/repos/cassella/scspell/issues/comments{/number}","contents_url":"https://api.github.com/repos/cassella/scspell/contents/{+path}","compare_url":"https://api.github.com/repos/cassella/scspell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cassella/scspell/merges","archive_url":"https://api.github.com/repos/cassella/scspell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cassella/scspell/downloads","issues_url":"https://api.github.com/repos/cassella/scspell/issues{/number}","pulls_url":"https://api.github.com/repos/cassella/scspell/pulls{/number}","milestones_url":"https://api.github.com/repos/cassella/scspell/milestones{/number}","notifications_url":"https://api.github.com/repos/cassella/scspell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cassella/scspell/labels{/name}","releases_url":"https://api.github.com/repos/cassella/scspell/releases{/id}","deployments_url":"https://api.github.com/repos/cassella/scspell/deployments","created_at":"2016-05-14T05:08:12Z","updated_at":"2016-05-14T05:08:13Z","pushed_at":"2016-07-11T06:53:20Z","git_url":"git://github.com/cassella/scspell.git","ssh_url":"git@github.com:cassella/scspell.git","clone_url":"https://github.com/cassella/scspell.git","svn_url":"https://github.com/cassella/scspell","homepage":"https://pypi.python.org/pypi/scspell3k","size":607,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"myint:master","ref":"master","sha":"50c1357955106232f5c11a574b3b092903d204aa","user":{"login":"myint","id":1235108,"avatar_url":"https://avatars.githubusercontent.com/u/1235108?v=3","gravatar_id":"","url":"https://api.github.com/users/myint","html_url":"https://github.com/myint","followers_url":"https://api.github.com/users/myint/followers","following_url":"https://api.github.com/users/myint/following{/other_user}","gists_url":"https://api.github.com/users/myint/gists{/gist_id}","starred_url":"https://api.github.com/users/myint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myint/subscriptions","organizations_url":"https://api.github.com/users/myint/orgs","repos_url":"https://api.github.com/users/myint/repos","events_url":"https://api.github.com/users/myint/events{/privacy}","received_events_url":"https://api.github.com/users/myint/received_events","type":"User","site_admin":false},"repo":{"id":8818090,"name":"scspell","full_name":"myint/scspell","owner":{"login":"myint","id":1235108,"avatar_url":"https://avatars.githubusercontent.com/u/1235108?v=3","gravatar_id":"","url":"https://api.github.com/users/myint","html_url":"https://github.com/myint","followers_url":"https://api.github.com/users/myint/followers","following_url":"https://api.github.com/users/myint/following{/other_user}","gists_url":"https://api.github.com/users/myint/gists{/gist_id}","starred_url":"https://api.github.com/users/myint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myint/subscriptions","organizations_url":"https://api.github.com/users/myint/orgs","repos_url":"https://api.github.com/users/myint/repos","events_url":"https://api.github.com/users/myint/events{/privacy}","received_events_url":"https://api.github.com/users/myint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myint/scspell","description":"Spell checker for source code.","fork":false,"url":"https://api.github.com/repos/myint/scspell","forks_url":"https://api.github.com/repos/myint/scspell/forks","keys_url":"https://api.github.com/repos/myint/scspell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myint/scspell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myint/scspell/teams","hooks_url":"https://api.github.com/repos/myint/scspell/hooks","issue_events_url":"https://api.github.com/repos/myint/scspell/issues/events{/number}","events_url":"https://api.github.com/repos/myint/scspell/events","assignees_url":"https://api.github.com/repos/myint/scspell/assignees{/user}","branches_url":"https://api.github.com/repos/myint/scspell/branches{/branch}","tags_url":"https://api.github.com/repos/myint/scspell/tags","blobs_url":"https://api.github.com/repos/myint/scspell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myint/scspell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myint/scspell/git/refs{/sha}","trees_url":"https://api.github.com/repos/myint/scspell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myint/scspell/statuses/{sha}","languages_url":"https://api.github.com/repos/myint/scspell/languages","stargazers_url":"https://api.github.com/repos/myint/scspell/stargazers","contributors_url":"https://api.github.com/repos/myint/scspell/contributors","subscribers_url":"https://api.github.com/repos/myint/scspell/subscribers","subscription_url":"https://api.github.com/repos/myint/scspell/subscription","commits_url":"https://api.github.com/repos/myint/scspell/commits{/sha}","git_commits_url":"https://api.github.com/repos/myint/scspell/git/commits{/sha}","comments_url":"https://api.github.com/repos/myint/scspell/comments{/number}","issue_comment_url":"https://api.github.com/repos/myint/scspell/issues/comments{/number}","contents_url":"https://api.github.com/repos/myint/scspell/contents/{+path}","compare_url":"https://api.github.com/repos/myint/scspell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myint/scspell/merges","archive_url":"https://api.github.com/repos/myint/scspell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myint/scspell/downloads","issues_url":"https://api.github.com/repos/myint/scspell/issues{/number}","pulls_url":"https://api.github.com/repos/myint/scspell/pulls{/number}","milestones_url":"https://api.github.com/repos/myint/scspell/milestones{/number}","notifications_url":"https://api.github.com/repos/myint/scspell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myint/scspell/labels{/name}","releases_url":"https://api.github.com/repos/myint/scspell/releases{/id}","deployments_url":"https://api.github.com/repos/myint/scspell/deployments","created_at":"2013-03-16T12:02:49Z","updated_at":"2016-05-18T15:15:50Z","pushed_at":"2016-07-11T14:57:25Z","git_url":"git://github.com/myint/scspell.git","ssh_url":"git@github.com:myint/scspell.git","clone_url":"https://github.com/myint/scspell.git","svn_url":"https://github.com/myint/scspell","homepage":"https://pypi.python.org/pypi/scspell3k","size":587,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/myint/scspell/pulls/10"},"html":{"href":"https://github.com/myint/scspell/pull/10"},"issue":{"href":"https://api.github.com/repos/myint/scspell/issues/10"},"comments":{"href":"https://api.github.com/repos/myint/scspell/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/myint/scspell/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/myint/scspell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/myint/scspell/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/myint/scspell/statuses/cd8545b0095ff61c1fb09c046bc00adecc968617"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"myint","id":1235108,"avatar_url":"https://avatars.githubusercontent.com/u/1235108?v=3","gravatar_id":"","url":"https://api.github.com/users/myint","html_url":"https://github.com/myint","followers_url":"https://api.github.com/users/myint/followers","following_url":"https://api.github.com/users/myint/following{/other_user}","gists_url":"https://api.github.com/users/myint/gists{/gist_id}","starred_url":"https://api.github.com/users/myint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myint/subscriptions","organizations_url":"https://api.github.com/users/myint/orgs","repos_url":"https://api.github.com/users/myint/repos","events_url":"https://api.github.com/users/myint/events{/privacy}","received_events_url":"https://api.github.com/users/myint/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":17,"additions":134,"deletions":100,"changed_files":6}}
{"actor":{"display_login":"myint"}}