{"action":"created","issue":{"url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/42","repository_url":"https://api.github.com/repos/dhs-ncats/pshtt","labels_url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/42/comments","events_url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/42/events","html_url":"https://github.com/dhs-ncats/pshtt/pull/42","id":190851014,"number":42,"title":"Move policy decisions into pshtt","user":{"login":"h-m-f-t","id":603901,"avatar_url":"https://avatars.githubusercontent.com/u/603901?v=3","gravatar_id":"","url":"https://api.github.com/users/h-m-f-t","html_url":"https://github.com/h-m-f-t","followers_url":"https://api.github.com/users/h-m-f-t/followers","following_url":"https://api.github.com/users/h-m-f-t/following{/other_user}","gists_url":"https://api.github.com/users/h-m-f-t/gists{/gist_id}","starred_url":"https://api.github.com/users/h-m-f-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-m-f-t/subscriptions","organizations_url":"https://api.github.com/users/h-m-f-t/orgs","repos_url":"https://api.github.com/users/h-m-f-t/repos","events_url":"https://api.github.com/users/h-m-f-t/events{/privacy}","received_events_url":"https://api.github.com/users/h-m-f-t/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-21T22:13:22Z","updated_at":"2016-12-12T04:20:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dhs-ncats/pshtt/pulls/42","html_url":"https://github.com/dhs-ncats/pshtt/pull/42","diff_url":"https://github.com/dhs-ncats/pshtt/pull/42.diff","patch_url":"https://github.com/dhs-ncats/pshtt/pull/42.patch"},"body":"This PR fixes Issue #29, adding three new fields to the tool output: \r\n\r\n- **Domain Supports HTTPS**: A domain 'Supports HTTPS' when it doesn't downgrade and has valid HTTPS, or when it doesn't downgrade and has a bad chain but not a bad hostname. This is an attempt to capture whether the domain owner intentionally supports HTTPS: a bad chain shows an intent (though a misconfiguration), while a bad hostname often means support is not intended.\r\n- **Domain Enforces HTTPS**: A domain that 'Enforces HTTPS' must 'Support HTTPS' and default to HTTPS. 'Redirect domains' must also strictly enforce HTTPS.\r\n- **Domain Uses Strong HSTS**: A domain 'Uses Strong HSTS' when max-age ≥ 31536000.\r\n\r\nThese definitions closely follow the contours of M-15-13 compliance, and also match what [Pulse](https://pulse.cio.gov/https/agencies/#q=homeland%20security) calls \"Uses HTTPS\", \"Enforces HTTPS\", and \"Strict Transport Security (HSTS)\"."},"comment":{"url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/comments/266340139","html_url":"https://github.com/dhs-ncats/pshtt/pull/42#issuecomment-266340139","issue_url":"https://api.github.com/repos/dhs-ncats/pshtt/issues/42","id":266340139,"user":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T04:20:50Z","updated_at":"2016-12-12T04:20:50Z","body":"I added some changes in https://github.com/dhs-ncats/pshtt/pull/42/files/bb3461dd61a4388c581898f5a4f82e8f9dafc4c0..c9fc2e3acbbb3095241cc4f85121d502673b2fb7 that fix the `flake8` errors. \r\n\r\nIt was mostly indentation, but I also changed some `[condition] != True` lines to `not [condition]`. This is consistent with the other conditional statements in the tool, and meets `flake8`. @h-m-f-t I didn't test out those changes, but could you 👁 and test them the same as you've been testing this code generally before merging?"}}
{"actor":{"display_login":"konklone"}}