{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35075","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35075/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35075/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35075/events","html_url":"https://github.com/kubernetes/kubernetes/pull/35075","id":183826476,"number":35075,"title":"If token validation fails, give the user the expected format.","user":{"login":"pipejakob","id":1605981,"avatar_url":"https://avatars.githubusercontent.com/u/1605981?v=3","gravatar_id":"","url":"https://api.github.com/users/pipejakob","html_url":"https://github.com/pipejakob","followers_url":"https://api.github.com/users/pipejakob/followers","following_url":"https://api.github.com/users/pipejakob/following{/other_user}","gists_url":"https://api.github.com/users/pipejakob/gists{/gist_id}","starred_url":"https://api.github.com/users/pipejakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipejakob/subscriptions","organizations_url":"https://api.github.com/users/pipejakob/orgs","repos_url":"https://api.github.com/users/pipejakob/repos","events_url":"https://api.github.com/users/pipejakob/events{/privacy}","received_events_url":"https://api.github.com/users/pipejakob/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"jbeda","id":37310,"avatar_url":"https://avatars.githubusercontent.com/u/37310?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeda","html_url":"https://github.com/jbeda","followers_url":"https://api.github.com/users/jbeda/followers","following_url":"https://api.github.com/users/jbeda/following{/other_user}","gists_url":"https://api.github.com/users/jbeda/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeda/subscriptions","organizations_url":"https://api.github.com/users/jbeda/orgs","repos_url":"https://api.github.com/users/jbeda/repos","events_url":"https://api.github.com/users/jbeda/events{/privacy}","received_events_url":"https://api.github.com/users/jbeda/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbeda","id":37310,"avatar_url":"https://avatars.githubusercontent.com/u/37310?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeda","html_url":"https://github.com/jbeda","followers_url":"https://api.github.com/users/jbeda/followers","following_url":"https://api.github.com/users/jbeda/following{/other_user}","gists_url":"https://api.github.com/users/jbeda/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeda/subscriptions","organizations_url":"https://api.github.com/users/jbeda/orgs","repos_url":"https://api.github.com/users/jbeda/repos","events_url":"https://api.github.com/users/jbeda/events{/privacy}","received_events_url":"https://api.github.com/users/jbeda/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-10-18T23:10:05Z","updated_at":"2016-10-18T23:24:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35075","html_url":"https://github.com/kubernetes/kubernetes/pull/35075","diff_url":"https://github.com/kubernetes/kubernetes/pull/35075.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/35075.patch"},"body":"If a user specifies their own token to kubeadm, and it fails validation, the error they currently receive isn't the friendliest. This first change adds messaging for the expected token format, with more improvements to follow as part of #33930. It also adds some unit tests to document the behavior we have currently.\r\n\r\nCC: @mikedanese, @krousey, @kubernetes/sig-cluster-lifecycle\r\n\r\nPart of #33930.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/35075)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/254667899","html_url":"https://github.com/kubernetes/kubernetes/pull/35075#issuecomment-254667899","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35075","id":254667899,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T23:24:20Z","updated_at":"2016-10-18T23:24:20Z","body":"Jenkins GCI GKE smoke e2e [**failed**](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/35075/pull-kubernetes-e2e-gke-gci/201/) for commit 121f1fbb6e1c3118eaec19deeb35b19b476590c7. [Full PR test history](http://pr-test.k8s.io/35075).\n\nThe magic incantation to run this job again is `@k8s-bot gci gke e2e test this`. Please help us cut down flakes by linking to an [open flake issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open) when you hit one in your PR."}}
{"actor":{"display_login":"k8s-ci-robot"}}