{"action":"created","comment":{"url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/comments/75710204","id":75710204,"diff_hunk":"@@ -2,86 +2,73 @@\n  * Created by Anita on 07/08/2016.\n  */\n \n-myModuleI = {\n-    SemVer: function (major, minor, revision) {\n-        if (major < 0 || minor < 0 || revision < 0) {\n-            throw new Error('Error: negative number' );\n-        }else {\n-            this.major = major;\n-            this.minor = minor;\n-            this.revision = revision;\n-        }\n-        /* Code to see if major is valid, how implements that? And then, testing:\n \n-        var regex = /^[1-9][0-9][0-9]$|^[1-9][0-9]$|^[1-9]$/;\n-        if(regex.test(major)){\n-            return major;\n-        }else{\n-            return 'Value for major incorrect';\n-        }\n+function SemVer(major, minor, revision) {\n+    this.major = major;\n+    this.minor = minor;\n+    this.revision = revision;\n \n-        */\n+    var conditions = major < 0 || typeof(major) !== 'number' || minor < 0 || typeof(minor) !== 'number' || typeof(revision) !== 'number' || revision < 0;","path":"SemVer.js","position":null,"original_position":27,"commit_id":"d432bfa1587826e88147f436a22918ad05e44cce","original_commit_id":"d432bfa1587826e88147f436a22918ad05e44cce","user":{"login":"francovitali","id":1829654,"avatar_url":"https://avatars.githubusercontent.com/u/1829654?v=3","gravatar_id":"","url":"https://api.github.com/users/francovitali","html_url":"https://github.com/francovitali","followers_url":"https://api.github.com/users/francovitali/followers","following_url":"https://api.github.com/users/francovitali/following{/other_user}","gists_url":"https://api.github.com/users/francovitali/gists{/gist_id}","starred_url":"https://api.github.com/users/francovitali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francovitali/subscriptions","organizations_url":"https://api.github.com/users/francovitali/orgs","repos_url":"https://api.github.com/users/francovitali/repos","events_url":"https://api.github.com/users/francovitali/events{/privacy}","received_events_url":"https://api.github.com/users/francovitali/received_events","type":"User","site_admin":false},"body":"Tal vez comprobar el tipo de dato antes del valor del tipo?","created_at":"2016-08-22T16:26:17Z","updated_at":"2016-08-22T16:26:17Z","html_url":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1#discussion_r75710204","pull_request_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/comments/75710204"},"html":{"href":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1#discussion_r75710204"},"pull_request":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1","id":82096599,"html_url":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1","diff_url":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1.diff","patch_url":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1.patch","issue_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/1","number":1,"state":"open","locked":false,"title":"Primer ejercicio","user":{"login":"AnaLefinir","id":16769963,"avatar_url":"https://avatars.githubusercontent.com/u/16769963?v=3","gravatar_id":"","url":"https://api.github.com/users/AnaLefinir","html_url":"https://github.com/AnaLefinir","followers_url":"https://api.github.com/users/AnaLefinir/followers","following_url":"https://api.github.com/users/AnaLefinir/following{/other_user}","gists_url":"https://api.github.com/users/AnaLefinir/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaLefinir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaLefinir/subscriptions","organizations_url":"https://api.github.com/users/AnaLefinir/orgs","repos_url":"https://api.github.com/users/AnaLefinir/repos","events_url":"https://api.github.com/users/AnaLefinir/events{/privacy}","received_events_url":"https://api.github.com/users/AnaLefinir/received_events","type":"User","site_admin":false},"body":"Mi primer pull request!","created_at":"2016-08-21T04:24:46Z","updated_at":"2016-08-22T16:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c93f418a8b1ab83ca1ad25c1dd0d47998dbe9e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/1/comments","statuses_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/statuses/d432bfa1587826e88147f436a22918ad05e44cce","head":{"label":"AnaLefinir:Primer_Ejercicio","ref":"Primer_Ejercicio","sha":"d432bfa1587826e88147f436a22918ad05e44cce","user":{"login":"AnaLefinir","id":16769963,"avatar_url":"https://avatars.githubusercontent.com/u/16769963?v=3","gravatar_id":"","url":"https://api.github.com/users/AnaLefinir","html_url":"https://github.com/AnaLefinir","followers_url":"https://api.github.com/users/AnaLefinir/followers","following_url":"https://api.github.com/users/AnaLefinir/following{/other_user}","gists_url":"https://api.github.com/users/AnaLefinir/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaLefinir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaLefinir/subscriptions","organizations_url":"https://api.github.com/users/AnaLefinir/orgs","repos_url":"https://api.github.com/users/AnaLefinir/repos","events_url":"https://api.github.com/users/AnaLefinir/events{/privacy}","received_events_url":"https://api.github.com/users/AnaLefinir/received_events","type":"User","site_admin":false},"repo":{"id":65114104,"name":"EjerciciosDeFranco","full_name":"AnaLefinir/EjerciciosDeFranco","owner":{"login":"AnaLefinir","id":16769963,"avatar_url":"https://avatars.githubusercontent.com/u/16769963?v=3","gravatar_id":"","url":"https://api.github.com/users/AnaLefinir","html_url":"https://github.com/AnaLefinir","followers_url":"https://api.github.com/users/AnaLefinir/followers","following_url":"https://api.github.com/users/AnaLefinir/following{/other_user}","gists_url":"https://api.github.com/users/AnaLefinir/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaLefinir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaLefinir/subscriptions","organizations_url":"https://api.github.com/users/AnaLefinir/orgs","repos_url":"https://api.github.com/users/AnaLefinir/repos","events_url":"https://api.github.com/users/AnaLefinir/events{/privacy}","received_events_url":"https://api.github.com/users/AnaLefinir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnaLefinir/EjerciciosDeFranco","description":null,"fork":false,"url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco","forks_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/forks","keys_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/teams","hooks_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/hooks","issue_events_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/events{/number}","events_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/events","assignees_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/assignees{/user}","branches_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/branches{/branch}","tags_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/tags","blobs_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/statuses/{sha}","languages_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/languages","stargazers_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/stargazers","contributors_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/contributors","subscribers_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/subscribers","subscription_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/subscription","commits_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/contents/{+path}","compare_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/merges","archive_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/downloads","issues_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues{/number}","pulls_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls{/number}","milestones_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/milestones{/number}","notifications_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/labels{/name}","releases_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/releases{/id}","deployments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/deployments","created_at":"2016-08-07T03:41:35Z","updated_at":"2016-08-07T03:41:35Z","pushed_at":"2016-08-22T16:13:50Z","git_url":"git://github.com/AnaLefinir/EjerciciosDeFranco.git","ssh_url":"git@github.com:AnaLefinir/EjerciciosDeFranco.git","clone_url":"https://github.com/AnaLefinir/EjerciciosDeFranco.git","svn_url":"https://github.com/AnaLefinir/EjerciciosDeFranco","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AnaLefinir:master","ref":"master","sha":"94f6621cff24be55413f6e886f950d76c1043a3b","user":{"login":"AnaLefinir","id":16769963,"avatar_url":"https://avatars.githubusercontent.com/u/16769963?v=3","gravatar_id":"","url":"https://api.github.com/users/AnaLefinir","html_url":"https://github.com/AnaLefinir","followers_url":"https://api.github.com/users/AnaLefinir/followers","following_url":"https://api.github.com/users/AnaLefinir/following{/other_user}","gists_url":"https://api.github.com/users/AnaLefinir/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaLefinir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaLefinir/subscriptions","organizations_url":"https://api.github.com/users/AnaLefinir/orgs","repos_url":"https://api.github.com/users/AnaLefinir/repos","events_url":"https://api.github.com/users/AnaLefinir/events{/privacy}","received_events_url":"https://api.github.com/users/AnaLefinir/received_events","type":"User","site_admin":false},"repo":{"id":65114104,"name":"EjerciciosDeFranco","full_name":"AnaLefinir/EjerciciosDeFranco","owner":{"login":"AnaLefinir","id":16769963,"avatar_url":"https://avatars.githubusercontent.com/u/16769963?v=3","gravatar_id":"","url":"https://api.github.com/users/AnaLefinir","html_url":"https://github.com/AnaLefinir","followers_url":"https://api.github.com/users/AnaLefinir/followers","following_url":"https://api.github.com/users/AnaLefinir/following{/other_user}","gists_url":"https://api.github.com/users/AnaLefinir/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaLefinir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaLefinir/subscriptions","organizations_url":"https://api.github.com/users/AnaLefinir/orgs","repos_url":"https://api.github.com/users/AnaLefinir/repos","events_url":"https://api.github.com/users/AnaLefinir/events{/privacy}","received_events_url":"https://api.github.com/users/AnaLefinir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnaLefinir/EjerciciosDeFranco","description":null,"fork":false,"url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco","forks_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/forks","keys_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/teams","hooks_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/hooks","issue_events_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/events{/number}","events_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/events","assignees_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/assignees{/user}","branches_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/branches{/branch}","tags_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/tags","blobs_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/statuses/{sha}","languages_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/languages","stargazers_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/stargazers","contributors_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/contributors","subscribers_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/subscribers","subscription_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/subscription","commits_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/contents/{+path}","compare_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/merges","archive_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/downloads","issues_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues{/number}","pulls_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls{/number}","milestones_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/milestones{/number}","notifications_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/labels{/name}","releases_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/releases{/id}","deployments_url":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/deployments","created_at":"2016-08-07T03:41:35Z","updated_at":"2016-08-07T03:41:35Z","pushed_at":"2016-08-22T16:13:50Z","git_url":"git://github.com/AnaLefinir/EjerciciosDeFranco.git","ssh_url":"git@github.com:AnaLefinir/EjerciciosDeFranco.git","clone_url":"https://github.com/AnaLefinir/EjerciciosDeFranco.git","svn_url":"https://github.com/AnaLefinir/EjerciciosDeFranco","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1"},"html":{"href":"https://github.com/AnaLefinir/EjerciciosDeFranco/pull/1"},"issue":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/1"},"comments":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AnaLefinir/EjerciciosDeFranco/statuses/d432bfa1587826e88147f436a22918ad05e44cce"}}}}
{"actor":{"display_login":"francovitali"}}