{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/victorcoder/dkron/pulls/185","id":85284141,"html_url":"https://github.com/victorcoder/dkron/pull/185","diff_url":"https://github.com/victorcoder/dkron/pull/185.diff","patch_url":"https://github.com/victorcoder/dkron/pull/185.patch","issue_url":"https://api.github.com/repos/victorcoder/dkron/issues/185","number":185,"state":"closed","locked":false,"title":"#184 Hotfix: Performs nil check to mitigate a panic raised as described in #184","user":{"login":"sayden","id":4249331,"avatar_url":"https://avatars.githubusercontent.com/u/4249331?v=3","gravatar_id":"","url":"https://api.github.com/users/sayden","html_url":"https://github.com/sayden","followers_url":"https://api.github.com/users/sayden/followers","following_url":"https://api.github.com/users/sayden/following{/other_user}","gists_url":"https://api.github.com/users/sayden/gists{/gist_id}","starred_url":"https://api.github.com/users/sayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayden/subscriptions","organizations_url":"https://api.github.com/users/sayden/orgs","repos_url":"https://api.github.com/users/sayden/repos","events_url":"https://api.github.com/users/sayden/events{/privacy}","received_events_url":"https://api.github.com/users/sayden/received_events","type":"User","site_admin":false},"body":"#184 Panic is thrown on store.go:243. It is accessing to a store.Store member of the type Store which is nil.\r\n\r\nThis fix is doing the nil checking to return an error if client is not found.\r\n\r\nI have also take advantage of this PR to fix a panic raised in tests. It is generally not recommended and much more idiomatic to use t.Fatal in a test.","created_at":"2016-09-14T18:51:42Z","updated_at":"2016-09-23T13:55:07Z","closed_at":"2016-09-23T13:55:07Z","merged_at":null,"merge_commit_sha":"cc4fd9393964cf4e2d3de967e2bff0d8de76cf98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/victorcoder/dkron/pulls/185/commits","review_comments_url":"https://api.github.com/repos/victorcoder/dkron/pulls/185/comments","review_comment_url":"https://api.github.com/repos/victorcoder/dkron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/victorcoder/dkron/issues/185/comments","statuses_url":"https://api.github.com/repos/victorcoder/dkron/statuses/4adf2c05f6acc402b8c9fc93dfa4c54c2ddab890","head":{"label":"sayden:Issue_#184_Hotfix","ref":"Issue_#184_Hotfix","sha":"4adf2c05f6acc402b8c9fc93dfa4c54c2ddab890","user":{"login":"sayden","id":4249331,"avatar_url":"https://avatars.githubusercontent.com/u/4249331?v=3","gravatar_id":"","url":"https://api.github.com/users/sayden","html_url":"https://github.com/sayden","followers_url":"https://api.github.com/users/sayden/followers","following_url":"https://api.github.com/users/sayden/following{/other_user}","gists_url":"https://api.github.com/users/sayden/gists{/gist_id}","starred_url":"https://api.github.com/users/sayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayden/subscriptions","organizations_url":"https://api.github.com/users/sayden/orgs","repos_url":"https://api.github.com/users/sayden/repos","events_url":"https://api.github.com/users/sayden/events{/privacy}","received_events_url":"https://api.github.com/users/sayden/received_events","type":"User","site_admin":false},"repo":{"id":68232974,"name":"dkron","full_name":"sayden/dkron","owner":{"login":"sayden","id":4249331,"avatar_url":"https://avatars.githubusercontent.com/u/4249331?v=3","gravatar_id":"","url":"https://api.github.com/users/sayden","html_url":"https://github.com/sayden","followers_url":"https://api.github.com/users/sayden/followers","following_url":"https://api.github.com/users/sayden/following{/other_user}","gists_url":"https://api.github.com/users/sayden/gists{/gist_id}","starred_url":"https://api.github.com/users/sayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayden/subscriptions","organizations_url":"https://api.github.com/users/sayden/orgs","repos_url":"https://api.github.com/users/sayden/repos","events_url":"https://api.github.com/users/sayden/events{/privacy}","received_events_url":"https://api.github.com/users/sayden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sayden/dkron","description":"Dkron - Distributed, fault tolerant job scheduling system http://dkron.io","fork":true,"url":"https://api.github.com/repos/sayden/dkron","forks_url":"https://api.github.com/repos/sayden/dkron/forks","keys_url":"https://api.github.com/repos/sayden/dkron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sayden/dkron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sayden/dkron/teams","hooks_url":"https://api.github.com/repos/sayden/dkron/hooks","issue_events_url":"https://api.github.com/repos/sayden/dkron/issues/events{/number}","events_url":"https://api.github.com/repos/sayden/dkron/events","assignees_url":"https://api.github.com/repos/sayden/dkron/assignees{/user}","branches_url":"https://api.github.com/repos/sayden/dkron/branches{/branch}","tags_url":"https://api.github.com/repos/sayden/dkron/tags","blobs_url":"https://api.github.com/repos/sayden/dkron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sayden/dkron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sayden/dkron/git/refs{/sha}","trees_url":"https://api.github.com/repos/sayden/dkron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sayden/dkron/statuses/{sha}","languages_url":"https://api.github.com/repos/sayden/dkron/languages","stargazers_url":"https://api.github.com/repos/sayden/dkron/stargazers","contributors_url":"https://api.github.com/repos/sayden/dkron/contributors","subscribers_url":"https://api.github.com/repos/sayden/dkron/subscribers","subscription_url":"https://api.github.com/repos/sayden/dkron/subscription","commits_url":"https://api.github.com/repos/sayden/dkron/commits{/sha}","git_commits_url":"https://api.github.com/repos/sayden/dkron/git/commits{/sha}","comments_url":"https://api.github.com/repos/sayden/dkron/comments{/number}","issue_comment_url":"https://api.github.com/repos/sayden/dkron/issues/comments{/number}","contents_url":"https://api.github.com/repos/sayden/dkron/contents/{+path}","compare_url":"https://api.github.com/repos/sayden/dkron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sayden/dkron/merges","archive_url":"https://api.github.com/repos/sayden/dkron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sayden/dkron/downloads","issues_url":"https://api.github.com/repos/sayden/dkron/issues{/number}","pulls_url":"https://api.github.com/repos/sayden/dkron/pulls{/number}","milestones_url":"https://api.github.com/repos/sayden/dkron/milestones{/number}","notifications_url":"https://api.github.com/repos/sayden/dkron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sayden/dkron/labels{/name}","releases_url":"https://api.github.com/repos/sayden/dkron/releases{/id}","deployments_url":"https://api.github.com/repos/sayden/dkron/deployments","created_at":"2016-09-14T18:39:31Z","updated_at":"2016-09-14T18:39:32Z","pushed_at":"2016-09-14T18:50:40Z","git_url":"git://github.com/sayden/dkron.git","ssh_url":"git@github.com:sayden/dkron.git","clone_url":"https://github.com/sayden/dkron.git","svn_url":"https://github.com/sayden/dkron","homepage":"","size":17828,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"victorcoder:master","ref":"master","sha":"7c08fbe3d38e743c29c034f29f2280557ed32f69","user":{"login":"victorcoder","id":47026,"avatar_url":"https://avatars.githubusercontent.com/u/47026?v=3","gravatar_id":"","url":"https://api.github.com/users/victorcoder","html_url":"https://github.com/victorcoder","followers_url":"https://api.github.com/users/victorcoder/followers","following_url":"https://api.github.com/users/victorcoder/following{/other_user}","gists_url":"https://api.github.com/users/victorcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/victorcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorcoder/subscriptions","organizations_url":"https://api.github.com/users/victorcoder/orgs","repos_url":"https://api.github.com/users/victorcoder/repos","events_url":"https://api.github.com/users/victorcoder/events{/privacy}","received_events_url":"https://api.github.com/users/victorcoder/received_events","type":"User","site_admin":false},"repo":{"id":37184230,"name":"dkron","full_name":"victorcoder/dkron","owner":{"login":"victorcoder","id":47026,"avatar_url":"https://avatars.githubusercontent.com/u/47026?v=3","gravatar_id":"","url":"https://api.github.com/users/victorcoder","html_url":"https://github.com/victorcoder","followers_url":"https://api.github.com/users/victorcoder/followers","following_url":"https://api.github.com/users/victorcoder/following{/other_user}","gists_url":"https://api.github.com/users/victorcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/victorcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorcoder/subscriptions","organizations_url":"https://api.github.com/users/victorcoder/orgs","repos_url":"https://api.github.com/users/victorcoder/repos","events_url":"https://api.github.com/users/victorcoder/events{/privacy}","received_events_url":"https://api.github.com/users/victorcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorcoder/dkron","description":"Dkron - Distributed, fault tolerant job scheduling system http://dkron.io","fork":false,"url":"https://api.github.com/repos/victorcoder/dkron","forks_url":"https://api.github.com/repos/victorcoder/dkron/forks","keys_url":"https://api.github.com/repos/victorcoder/dkron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorcoder/dkron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorcoder/dkron/teams","hooks_url":"https://api.github.com/repos/victorcoder/dkron/hooks","issue_events_url":"https://api.github.com/repos/victorcoder/dkron/issues/events{/number}","events_url":"https://api.github.com/repos/victorcoder/dkron/events","assignees_url":"https://api.github.com/repos/victorcoder/dkron/assignees{/user}","branches_url":"https://api.github.com/repos/victorcoder/dkron/branches{/branch}","tags_url":"https://api.github.com/repos/victorcoder/dkron/tags","blobs_url":"https://api.github.com/repos/victorcoder/dkron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorcoder/dkron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorcoder/dkron/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorcoder/dkron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorcoder/dkron/statuses/{sha}","languages_url":"https://api.github.com/repos/victorcoder/dkron/languages","stargazers_url":"https://api.github.com/repos/victorcoder/dkron/stargazers","contributors_url":"https://api.github.com/repos/victorcoder/dkron/contributors","subscribers_url":"https://api.github.com/repos/victorcoder/dkron/subscribers","subscription_url":"https://api.github.com/repos/victorcoder/dkron/subscription","commits_url":"https://api.github.com/repos/victorcoder/dkron/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorcoder/dkron/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorcoder/dkron/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorcoder/dkron/issues/comments{/number}","contents_url":"https://api.github.com/repos/victorcoder/dkron/contents/{+path}","compare_url":"https://api.github.com/repos/victorcoder/dkron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorcoder/dkron/merges","archive_url":"https://api.github.com/repos/victorcoder/dkron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorcoder/dkron/downloads","issues_url":"https://api.github.com/repos/victorcoder/dkron/issues{/number}","pulls_url":"https://api.github.com/repos/victorcoder/dkron/pulls{/number}","milestones_url":"https://api.github.com/repos/victorcoder/dkron/milestones{/number}","notifications_url":"https://api.github.com/repos/victorcoder/dkron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorcoder/dkron/labels{/name}","releases_url":"https://api.github.com/repos/victorcoder/dkron/releases{/id}","deployments_url":"https://api.github.com/repos/victorcoder/dkron/deployments","created_at":"2015-06-10T08:13:17Z","updated_at":"2016-09-16T21:28:15Z","pushed_at":"2016-09-23T13:54:03Z","git_url":"git://github.com/victorcoder/dkron.git","ssh_url":"git@github.com:victorcoder/dkron.git","clone_url":"https://github.com/victorcoder/dkron.git","svn_url":"https://github.com/victorcoder/dkron","homepage":"","size":17909,"stargazers_count":789,"watchers_count":789,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":20,"forks":48,"open_issues":20,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/victorcoder/dkron/pulls/185"},"html":{"href":"https://github.com/victorcoder/dkron/pull/185"},"issue":{"href":"https://api.github.com/repos/victorcoder/dkron/issues/185"},"comments":{"href":"https://api.github.com/repos/victorcoder/dkron/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/victorcoder/dkron/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/victorcoder/dkron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/victorcoder/dkron/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/victorcoder/dkron/statuses/4adf2c05f6acc402b8c9fc93dfa4c54c2ddab890"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"victorcoder"}}