{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/ejson/issues/30","repository_url":"https://api.github.com/repos/Shopify/ejson","labels_url":"https://api.github.com/repos/Shopify/ejson/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/ejson/issues/30/comments","events_url":"https://api.github.com/repos/Shopify/ejson/issues/30/events","html_url":"https://github.com/Shopify/ejson/pull/30","id":186085057,"number":30,"title":"Refactor + Intefaces","user":{"login":"lxfontes","id":35205,"avatar_url":"https://avatars.githubusercontent.com/u/35205?v=3","gravatar_id":"","url":"https://api.github.com/users/lxfontes","html_url":"https://github.com/lxfontes","followers_url":"https://api.github.com/users/lxfontes/followers","following_url":"https://api.github.com/users/lxfontes/following{/other_user}","gists_url":"https://api.github.com/users/lxfontes/gists{/gist_id}","starred_url":"https://api.github.com/users/lxfontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxfontes/subscriptions","organizations_url":"https://api.github.com/users/lxfontes/orgs","repos_url":"https://api.github.com/users/lxfontes/repos","events_url":"https://api.github.com/users/lxfontes/events{/privacy}","received_events_url":"https://api.github.com/users/lxfontes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-29T15:43:31Z","updated_at":"2016-11-01T13:36:36Z","closed_at":"2016-11-01T13:36:36Z","pull_request":{"url":"https://api.github.com/repos/Shopify/ejson/pulls/30","html_url":"https://github.com/Shopify/ejson/pull/30","diff_url":"https://github.com/Shopify/ejson/pull/30.diff","patch_url":"https://github.com/Shopify/ejson/pull/30.patch"},"body":"- Implemented `Encrypt`, receiving an `io.Reader` and outputting to `io.Writer`\n  - refactored `EncryptFileInPlace`\n- Implemented `Decrypt`, also receiving `io.Reader` and outputting to `io.Writer`\n  - refactored `DecryptFile`\n- Refactored tests to use temporary directories and files instead of overwriting `readFile`, `fileMode`\n  - removed mocks\n- Migrated `godep` to `glide`\n- Updated to go 1.7\n- Updated dev.yml\n\nWhy ?\n- We didn't have an encrypt method that didn't overwrite files\n- Having those 2 methods dealing with interfaces facilitates key rotation\n\nr @burke \n\nThis diff sucks :(\n"},"comment":{"url":"https://api.github.com/repos/Shopify/ejson/issues/comments/257567825","html_url":"https://github.com/Shopify/ejson/pull/30#issuecomment-257567825","issue_url":"https://api.github.com/repos/Shopify/ejson/issues/30","id":257567825,"user":{"login":"lxfontes","id":35205,"avatar_url":"https://avatars.githubusercontent.com/u/35205?v=3","gravatar_id":"","url":"https://api.github.com/users/lxfontes","html_url":"https://github.com/lxfontes","followers_url":"https://api.github.com/users/lxfontes/followers","following_url":"https://api.github.com/users/lxfontes/following{/other_user}","gists_url":"https://api.github.com/users/lxfontes/gists{/gist_id}","starred_url":"https://api.github.com/users/lxfontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxfontes/subscriptions","organizations_url":"https://api.github.com/users/lxfontes/orgs","repos_url":"https://api.github.com/users/lxfontes/repos","events_url":"https://api.github.com/users/lxfontes/events{/privacy}","received_events_url":"https://api.github.com/users/lxfontes/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T13:36:36Z","updated_at":"2016-11-01T13:36:36Z","body":"🤘 \r\nsplitting this up into 2 "}}
{"actor":{"display_login":"lxfontes"}}