{"action":"created","comment":{"url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/comments/66154628","id":66154628,"diff_hunk":"@@ -1,15 +1,4 @@\n-source 'http://rubygems.org'\n+source 'https://rubygems.org'\n \n-# runtime deps\n-gem \"gobject-introspection\", \"~> 3.0\"\n-\n-# Add dependencies to develop your gem here.\n-# Include everything needed to run rake, tests, features, etc.\n-group :development do\n-    gem \"rspec\", \"~> 3.3\"\n-    gem \"yard\", \"~> 0.8\"\n-    gem \"redcarpet\", \"~> 3.3\"\n-    gem \"github-markup\", \"~> 1.4\"\n-    gem \"bundler\", \"~> 1.0\"\n-    gem \"jeweler\", \"~> 2.0\"\n-end\n+# all gems are handled by .gemspec (since this repo is for a gem)\n+gemspec","path":"Gemfile","position":18,"original_position":18,"commit_id":"d740709ce58369af93e9d07f8d8eb912004f0567","original_commit_id":"e862cb5f9487d64edbeb74ff11c6c810ae1d7576","user":{"login":"jcupitt","id":580843,"avatar_url":"https://avatars.githubusercontent.com/u/580843?v=3","gravatar_id":"","url":"https://api.github.com/users/jcupitt","html_url":"https://github.com/jcupitt","followers_url":"https://api.github.com/users/jcupitt/followers","following_url":"https://api.github.com/users/jcupitt/following{/other_user}","gists_url":"https://api.github.com/users/jcupitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jcupitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcupitt/subscriptions","organizations_url":"https://api.github.com/users/jcupitt/orgs","repos_url":"https://api.github.com/users/jcupitt/repos","events_url":"https://api.github.com/users/jcupitt/events{/privacy}","received_events_url":"https://api.github.com/users/jcupitt/received_events","type":"User","site_admin":false},"body":"does it matter that we don't list development dependencies like yard?","created_at":"2016-06-07T21:17:33Z","updated_at":"2016-06-07T21:17:33Z","html_url":"https://github.com/jcupitt/ruby-vips/pull/74#discussion_r66154628","pull_request_url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/comments/66154628"},"html":{"href":"https://github.com/jcupitt/ruby-vips/pull/74#discussion_r66154628"},"pull_request":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74","id":72929860,"html_url":"https://github.com/jcupitt/ruby-vips/pull/74","diff_url":"https://github.com/jcupitt/ruby-vips/pull/74.diff","patch_url":"https://github.com/jcupitt/ruby-vips/pull/74.patch","issue_url":"https://api.github.com/repos/jcupitt/ruby-vips/issues/74","number":74,"state":"open","locked":false,"title":"Simplify gem-handling","user":{"login":"sandstrom","id":122287,"avatar_url":"https://avatars.githubusercontent.com/u/122287?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstrom","html_url":"https://github.com/sandstrom","followers_url":"https://api.github.com/users/sandstrom/followers","following_url":"https://api.github.com/users/sandstrom/following{/other_user}","gists_url":"https://api.github.com/users/sandstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstrom/subscriptions","organizations_url":"https://api.github.com/users/sandstrom/orgs","repos_url":"https://api.github.com/users/sandstrom/repos","events_url":"https://api.github.com/users/sandstrom/events{/privacy}","received_events_url":"https://api.github.com/users/sandstrom/received_events","type":"User","site_admin":false},"body":"1. Calculate the list of files dynamically (easier than manual updates). Same method as the [official bundler gemspec template file](https://github.com/bundler/bundler/blob/master/lib/bundler/templates/newgem/newgem.gemspec.tt) use.\r\n\r\n2. Delete `Gemfile.lock` and point `Gemfile` to `ruby-vips.gemspec`.\r\n  \r\n  This is the canonical way of handling this stuff:\r\n  http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/","created_at":"2016-06-07T19:01:53Z","updated_at":"2016-06-07T21:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c6ea4a491cff00f331627e70df56b510606619f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74/commits","review_comments_url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74/comments","review_comment_url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcupitt/ruby-vips/issues/74/comments","statuses_url":"https://api.github.com/repos/jcupitt/ruby-vips/statuses/d740709ce58369af93e9d07f8d8eb912004f0567","head":{"label":"sandstrom:patch-2","ref":"patch-2","sha":"d740709ce58369af93e9d07f8d8eb912004f0567","user":{"login":"sandstrom","id":122287,"avatar_url":"https://avatars.githubusercontent.com/u/122287?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstrom","html_url":"https://github.com/sandstrom","followers_url":"https://api.github.com/users/sandstrom/followers","following_url":"https://api.github.com/users/sandstrom/following{/other_user}","gists_url":"https://api.github.com/users/sandstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstrom/subscriptions","organizations_url":"https://api.github.com/users/sandstrom/orgs","repos_url":"https://api.github.com/users/sandstrom/repos","events_url":"https://api.github.com/users/sandstrom/events{/privacy}","received_events_url":"https://api.github.com/users/sandstrom/received_events","type":"User","site_admin":false},"repo":{"id":60637479,"name":"ruby-vips-1","full_name":"sandstrom/ruby-vips-1","owner":{"login":"sandstrom","id":122287,"avatar_url":"https://avatars.githubusercontent.com/u/122287?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstrom","html_url":"https://github.com/sandstrom","followers_url":"https://api.github.com/users/sandstrom/followers","following_url":"https://api.github.com/users/sandstrom/following{/other_user}","gists_url":"https://api.github.com/users/sandstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstrom/subscriptions","organizations_url":"https://api.github.com/users/sandstrom/orgs","repos_url":"https://api.github.com/users/sandstrom/repos","events_url":"https://api.github.com/users/sandstrom/events{/privacy}","received_events_url":"https://api.github.com/users/sandstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandstrom/ruby-vips-1","description":"Ruby extension for the vips image processing library.","fork":true,"url":"https://api.github.com/repos/sandstrom/ruby-vips-1","forks_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/forks","keys_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/teams","hooks_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/hooks","issue_events_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/issues/events{/number}","events_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/events","assignees_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/assignees{/user}","branches_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/branches{/branch}","tags_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/tags","blobs_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/languages","stargazers_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/stargazers","contributors_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/contributors","subscribers_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/subscribers","subscription_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/subscription","commits_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/contents/{+path}","compare_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/merges","archive_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/downloads","issues_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/issues{/number}","pulls_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/labels{/name}","releases_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/releases{/id}","deployments_url":"https://api.github.com/repos/sandstrom/ruby-vips-1/deployments","created_at":"2016-06-07T18:41:53Z","updated_at":"2016-06-07T18:41:54Z","pushed_at":"2016-06-07T18:59:20Z","git_url":"git://github.com/sandstrom/ruby-vips-1.git","ssh_url":"git@github.com:sandstrom/ruby-vips-1.git","clone_url":"https://github.com/sandstrom/ruby-vips-1.git","svn_url":"https://github.com/sandstrom/ruby-vips-1","homepage":"","size":8898,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jcupitt:master","ref":"master","sha":"c3c6818f25e62e4d26b4c23f3984b7abfd5ea6dc","user":{"login":"jcupitt","id":580843,"avatar_url":"https://avatars.githubusercontent.com/u/580843?v=3","gravatar_id":"","url":"https://api.github.com/users/jcupitt","html_url":"https://github.com/jcupitt","followers_url":"https://api.github.com/users/jcupitt/followers","following_url":"https://api.github.com/users/jcupitt/following{/other_user}","gists_url":"https://api.github.com/users/jcupitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jcupitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcupitt/subscriptions","organizations_url":"https://api.github.com/users/jcupitt/orgs","repos_url":"https://api.github.com/users/jcupitt/repos","events_url":"https://api.github.com/users/jcupitt/events{/privacy}","received_events_url":"https://api.github.com/users/jcupitt/received_events","type":"User","site_admin":false},"repo":{"id":2556649,"name":"ruby-vips","full_name":"jcupitt/ruby-vips","owner":{"login":"jcupitt","id":580843,"avatar_url":"https://avatars.githubusercontent.com/u/580843?v=3","gravatar_id":"","url":"https://api.github.com/users/jcupitt","html_url":"https://github.com/jcupitt","followers_url":"https://api.github.com/users/jcupitt/followers","following_url":"https://api.github.com/users/jcupitt/following{/other_user}","gists_url":"https://api.github.com/users/jcupitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jcupitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcupitt/subscriptions","organizations_url":"https://api.github.com/users/jcupitt/orgs","repos_url":"https://api.github.com/users/jcupitt/repos","events_url":"https://api.github.com/users/jcupitt/events{/privacy}","received_events_url":"https://api.github.com/users/jcupitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcupitt/ruby-vips","description":"Ruby extension for the vips image processing library.","fork":false,"url":"https://api.github.com/repos/jcupitt/ruby-vips","forks_url":"https://api.github.com/repos/jcupitt/ruby-vips/forks","keys_url":"https://api.github.com/repos/jcupitt/ruby-vips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcupitt/ruby-vips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcupitt/ruby-vips/teams","hooks_url":"https://api.github.com/repos/jcupitt/ruby-vips/hooks","issue_events_url":"https://api.github.com/repos/jcupitt/ruby-vips/issues/events{/number}","events_url":"https://api.github.com/repos/jcupitt/ruby-vips/events","assignees_url":"https://api.github.com/repos/jcupitt/ruby-vips/assignees{/user}","branches_url":"https://api.github.com/repos/jcupitt/ruby-vips/branches{/branch}","tags_url":"https://api.github.com/repos/jcupitt/ruby-vips/tags","blobs_url":"https://api.github.com/repos/jcupitt/ruby-vips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcupitt/ruby-vips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcupitt/ruby-vips/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcupitt/ruby-vips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcupitt/ruby-vips/statuses/{sha}","languages_url":"https://api.github.com/repos/jcupitt/ruby-vips/languages","stargazers_url":"https://api.github.com/repos/jcupitt/ruby-vips/stargazers","contributors_url":"https://api.github.com/repos/jcupitt/ruby-vips/contributors","subscribers_url":"https://api.github.com/repos/jcupitt/ruby-vips/subscribers","subscription_url":"https://api.github.com/repos/jcupitt/ruby-vips/subscription","commits_url":"https://api.github.com/repos/jcupitt/ruby-vips/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcupitt/ruby-vips/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcupitt/ruby-vips/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcupitt/ruby-vips/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcupitt/ruby-vips/contents/{+path}","compare_url":"https://api.github.com/repos/jcupitt/ruby-vips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcupitt/ruby-vips/merges","archive_url":"https://api.github.com/repos/jcupitt/ruby-vips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcupitt/ruby-vips/downloads","issues_url":"https://api.github.com/repos/jcupitt/ruby-vips/issues{/number}","pulls_url":"https://api.github.com/repos/jcupitt/ruby-vips/pulls{/number}","milestones_url":"https://api.github.com/repos/jcupitt/ruby-vips/milestones{/number}","notifications_url":"https://api.github.com/repos/jcupitt/ruby-vips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcupitt/ruby-vips/labels{/name}","releases_url":"https://api.github.com/repos/jcupitt/ruby-vips/releases{/id}","deployments_url":"https://api.github.com/repos/jcupitt/ruby-vips/deployments","created_at":"2011-10-11T16:45:42Z","updated_at":"2016-06-06T21:25:15Z","pushed_at":"2016-06-07T21:09:34Z","git_url":"git://github.com/jcupitt/ruby-vips.git","ssh_url":"git@github.com:jcupitt/ruby-vips.git","clone_url":"https://github.com/jcupitt/ruby-vips.git","svn_url":"https://github.com/jcupitt/ruby-vips","homepage":"","size":8903,"stargazers_count":190,"watchers_count":190,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74"},"html":{"href":"https://github.com/jcupitt/ruby-vips/pull/74"},"issue":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/issues/74"},"comments":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/jcupitt/ruby-vips/statuses/d740709ce58369af93e9d07f8d8eb912004f0567"}}}}
{"actor":{"display_login":"jcupitt"}}