{"action":"created","comment":{"url":"https://api.github.com/repos/ideascube/ideascube/pulls/comments/70636778","id":70636778,"diff_hunk":"@@ -415,14 +439,22 @@ def __init__(self):\n         self._cache_base_dir = settings.CATALOG_CACHE_BASE_DIR\n         os.makedirs(self._cache_base_dir, exist_ok=True)\n \n-        self._cache_remote_dir = os.path.join(self._cache_base_dir, 'remotes')\n-        self._load_remotes()\n-\n-        self._cache_catalog = os.path.join(self._cache_base_dir, 'catalog.yml')\n+        self._catalog_cache = os.path.join(self._cache_base_dir, 'catalog.yml')\n         self._local_package_cache = os.path.join(\n             self._cache_base_dir, 'packages')\n+        os.makedirs(self._local_package_cache, exist_ok=True)\n+\n+        self._storage_base_dir = settings.CATALOG_STORAGE_BASE_DIR\n+        os.makedirs(self._storage_base_dir, exist_ok=True)","path":"ideascube/serveradmin/catalog.py","position":76,"original_position":76,"commit_id":"6b30174a5b4c57ac3405d1a1bd34b36cdffe284f","original_commit_id":"6b30174a5b4c57ac3405d1a1bd34b36cdffe284f","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"humm, then I'd vote for `self._storage_root`.\r\nI think it's OK that `Catalog._storage_root` is CATALOG_STORAGE_ROOT, and not STORAGE_ROOT itself.\r\nI think that one being named `base_dir` while the other is `root` does not really change this anyway.","created_at":"2016-07-13T14:34:10Z","updated_at":"2016-07-13T14:34:10Z","html_url":"https://github.com/ideascube/ideascube/pull/379#discussion_r70636778","pull_request_url":"https://api.github.com/repos/ideascube/ideascube/pulls/379","_links":{"self":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/comments/70636778"},"html":{"href":"https://github.com/ideascube/ideascube/pull/379#discussion_r70636778"},"pull_request":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/ideascube/ideascube/pulls/379","id":76625456,"html_url":"https://github.com/ideascube/ideascube/pull/379","diff_url":"https://github.com/ideascube/ideascube/pull/379.diff","patch_url":"https://github.com/ideascube/ideascube/pull/379.patch","issue_url":"https://api.github.com/repos/ideascube/ideascube/issues/379","number":379,"state":"open","locked":false,"title":"Split catalog cache","user":{"login":"bochecha","id":272170,"avatar_url":"https://avatars.githubusercontent.com/u/272170?v=3","gravatar_id":"","url":"https://api.github.com/users/bochecha","html_url":"https://github.com/bochecha","followers_url":"https://api.github.com/users/bochecha/followers","following_url":"https://api.github.com/users/bochecha/following{/other_user}","gists_url":"https://api.github.com/users/bochecha/gists{/gist_id}","starred_url":"https://api.github.com/users/bochecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bochecha/subscriptions","organizations_url":"https://api.github.com/users/bochecha/orgs","repos_url":"https://api.github.com/users/bochecha/repos","events_url":"https://api.github.com/users/bochecha/events{/privacy}","received_events_url":"https://api.github.com/users/bochecha/received_events","type":"User","site_admin":false},"body":"Relates to #376 \r\n\r\nI strongly suggest you review this one commit at a time, as it will make it much easier to grasp the changes. :wink: ","created_at":"2016-07-07T16:26:06Z","updated_at":"2016-07-13T14:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7951ffde5067b743d5d5266fe42ca9b70386644","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ideascube/ideascube/pulls/379/commits","review_comments_url":"https://api.github.com/repos/ideascube/ideascube/pulls/379/comments","review_comment_url":"https://api.github.com/repos/ideascube/ideascube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ideascube/ideascube/issues/379/comments","statuses_url":"https://api.github.com/repos/ideascube/ideascube/statuses/6b30174a5b4c57ac3405d1a1bd34b36cdffe284f","head":{"label":"ideascube:split-catalog-cache","ref":"split-catalog-cache","sha":"6b30174a5b4c57ac3405d1a1bd34b36cdffe284f","user":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars.githubusercontent.com/u/9719862?v=3","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"repo":{"id":26708471,"name":"ideascube","full_name":"ideascube/ideascube","owner":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars.githubusercontent.com/u/9719862?v=3","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ideascube/ideascube","description":"Ideas Box server core application","fork":false,"url":"https://api.github.com/repos/ideascube/ideascube","forks_url":"https://api.github.com/repos/ideascube/ideascube/forks","keys_url":"https://api.github.com/repos/ideascube/ideascube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ideascube/ideascube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ideascube/ideascube/teams","hooks_url":"https://api.github.com/repos/ideascube/ideascube/hooks","issue_events_url":"https://api.github.com/repos/ideascube/ideascube/issues/events{/number}","events_url":"https://api.github.com/repos/ideascube/ideascube/events","assignees_url":"https://api.github.com/repos/ideascube/ideascube/assignees{/user}","branches_url":"https://api.github.com/repos/ideascube/ideascube/branches{/branch}","tags_url":"https://api.github.com/repos/ideascube/ideascube/tags","blobs_url":"https://api.github.com/repos/ideascube/ideascube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ideascube/ideascube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ideascube/ideascube/git/refs{/sha}","trees_url":"https://api.github.com/repos/ideascube/ideascube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ideascube/ideascube/statuses/{sha}","languages_url":"https://api.github.com/repos/ideascube/ideascube/languages","stargazers_url":"https://api.github.com/repos/ideascube/ideascube/stargazers","contributors_url":"https://api.github.com/repos/ideascube/ideascube/contributors","subscribers_url":"https://api.github.com/repos/ideascube/ideascube/subscribers","subscription_url":"https://api.github.com/repos/ideascube/ideascube/subscription","commits_url":"https://api.github.com/repos/ideascube/ideascube/commits{/sha}","git_commits_url":"https://api.github.com/repos/ideascube/ideascube/git/commits{/sha}","comments_url":"https://api.github.com/repos/ideascube/ideascube/comments{/number}","issue_comment_url":"https://api.github.com/repos/ideascube/ideascube/issues/comments{/number}","contents_url":"https://api.github.com/repos/ideascube/ideascube/contents/{+path}","compare_url":"https://api.github.com/repos/ideascube/ideascube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ideascube/ideascube/merges","archive_url":"https://api.github.com/repos/ideascube/ideascube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ideascube/ideascube/downloads","issues_url":"https://api.github.com/repos/ideascube/ideascube/issues{/number}","pulls_url":"https://api.github.com/repos/ideascube/ideascube/pulls{/number}","milestones_url":"https://api.github.com/repos/ideascube/ideascube/milestones{/number}","notifications_url":"https://api.github.com/repos/ideascube/ideascube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ideascube/ideascube/labels{/name}","releases_url":"https://api.github.com/repos/ideascube/ideascube/releases{/id}","deployments_url":"https://api.github.com/repos/ideascube/ideascube/deployments","created_at":"2014-11-16T08:39:32Z","updated_at":"2016-07-02T11:31:49Z","pushed_at":"2016-07-13T14:18:07Z","git_url":"git://github.com/ideascube/ideascube.git","ssh_url":"git@github.com:ideascube/ideascube.git","clone_url":"https://github.com/ideascube/ideascube.git","svn_url":"https://github.com/ideascube/ideascube","homepage":"http://ideascube.readthedocs.org/","size":10304,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":127,"forks":24,"open_issues":127,"watchers":20,"default_branch":"master"}},"base":{"label":"ideascube:master","ref":"master","sha":"649e1af10b4268e9533f74e2362d24012e938a90","user":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars.githubusercontent.com/u/9719862?v=3","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"repo":{"id":26708471,"name":"ideascube","full_name":"ideascube/ideascube","owner":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars.githubusercontent.com/u/9719862?v=3","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ideascube/ideascube","description":"Ideas Box server core application","fork":false,"url":"https://api.github.com/repos/ideascube/ideascube","forks_url":"https://api.github.com/repos/ideascube/ideascube/forks","keys_url":"https://api.github.com/repos/ideascube/ideascube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ideascube/ideascube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ideascube/ideascube/teams","hooks_url":"https://api.github.com/repos/ideascube/ideascube/hooks","issue_events_url":"https://api.github.com/repos/ideascube/ideascube/issues/events{/number}","events_url":"https://api.github.com/repos/ideascube/ideascube/events","assignees_url":"https://api.github.com/repos/ideascube/ideascube/assignees{/user}","branches_url":"https://api.github.com/repos/ideascube/ideascube/branches{/branch}","tags_url":"https://api.github.com/repos/ideascube/ideascube/tags","blobs_url":"https://api.github.com/repos/ideascube/ideascube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ideascube/ideascube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ideascube/ideascube/git/refs{/sha}","trees_url":"https://api.github.com/repos/ideascube/ideascube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ideascube/ideascube/statuses/{sha}","languages_url":"https://api.github.com/repos/ideascube/ideascube/languages","stargazers_url":"https://api.github.com/repos/ideascube/ideascube/stargazers","contributors_url":"https://api.github.com/repos/ideascube/ideascube/contributors","subscribers_url":"https://api.github.com/repos/ideascube/ideascube/subscribers","subscription_url":"https://api.github.com/repos/ideascube/ideascube/subscription","commits_url":"https://api.github.com/repos/ideascube/ideascube/commits{/sha}","git_commits_url":"https://api.github.com/repos/ideascube/ideascube/git/commits{/sha}","comments_url":"https://api.github.com/repos/ideascube/ideascube/comments{/number}","issue_comment_url":"https://api.github.com/repos/ideascube/ideascube/issues/comments{/number}","contents_url":"https://api.github.com/repos/ideascube/ideascube/contents/{+path}","compare_url":"https://api.github.com/repos/ideascube/ideascube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ideascube/ideascube/merges","archive_url":"https://api.github.com/repos/ideascube/ideascube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ideascube/ideascube/downloads","issues_url":"https://api.github.com/repos/ideascube/ideascube/issues{/number}","pulls_url":"https://api.github.com/repos/ideascube/ideascube/pulls{/number}","milestones_url":"https://api.github.com/repos/ideascube/ideascube/milestones{/number}","notifications_url":"https://api.github.com/repos/ideascube/ideascube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ideascube/ideascube/labels{/name}","releases_url":"https://api.github.com/repos/ideascube/ideascube/releases{/id}","deployments_url":"https://api.github.com/repos/ideascube/ideascube/deployments","created_at":"2014-11-16T08:39:32Z","updated_at":"2016-07-02T11:31:49Z","pushed_at":"2016-07-13T14:18:07Z","git_url":"git://github.com/ideascube/ideascube.git","ssh_url":"git@github.com:ideascube/ideascube.git","clone_url":"https://github.com/ideascube/ideascube.git","svn_url":"https://github.com/ideascube/ideascube","homepage":"http://ideascube.readthedocs.org/","size":10304,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":127,"forks":24,"open_issues":127,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/379"},"html":{"href":"https://github.com/ideascube/ideascube/pull/379"},"issue":{"href":"https://api.github.com/repos/ideascube/ideascube/issues/379"},"comments":{"href":"https://api.github.com/repos/ideascube/ideascube/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ideascube/ideascube/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/ideascube/ideascube/statuses/6b30174a5b4c57ac3405d1a1bd34b36cdffe284f"}}}}
{"actor":{"display_login":"yohanboniface"}}