{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/13358","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/13358/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/13358/comments","events_url":"https://api.github.com/repos/servo/servo/issues/13358/events","html_url":"https://github.com/servo/servo/pull/13358","id":178435139,"number":13358,"title":"Form action url 11219","user":{"login":"rjgoldsborough","id":868959,"avatar_url":"https://avatars.githubusercontent.com/u/868959?v=3","gravatar_id":"","url":"https://api.github.com/users/rjgoldsborough","html_url":"https://github.com/rjgoldsborough","followers_url":"https://api.github.com/users/rjgoldsborough/followers","following_url":"https://api.github.com/users/rjgoldsborough/following{/other_user}","gists_url":"https://api.github.com/users/rjgoldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/rjgoldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjgoldsborough/subscriptions","organizations_url":"https://api.github.com/users/rjgoldsborough/orgs","repos_url":"https://api.github.com/users/rjgoldsborough/repos","events_url":"https://api.github.com/users/rjgoldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/rjgoldsborough/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-squash","name":"S-needs-squash","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false}],"milestone":null,"comments":26,"created_at":"2016-09-21T19:04:40Z","updated_at":"2016-09-27T19:12:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13358","html_url":"https://github.com/servo/servo/pull/13358","diff_url":"https://github.com/servo/servo/pull/13358.diff","patch_url":"https://github.com/servo/servo/pull/13358.patch"},"body":"First pass at fixing #10580.\r\nI've added a new macro that returns a DomString with either the attr val or the doc url.\r\nI then made the form element use that macro on the action attribute.\r\nI also added a test that contains an iframe with a form and base url that submits to a page in\r\na resources directory.\r\n\r\nI made all these changes based on https://github.com/servo/servo/pull/11219#issuecomment-223318881.\r\n\r\nThe only thing I'm confused on is how to change step 8. It looks to just be getting the action so I'm wondering if I need to change either step 9 or 10 instead?\r\n\r\n---\r\n\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #10580 (github issue number if applicable).\r\n\r\n- [X] There are tests for these changes OR\r\n\r\n\r\nusing that macro with the form action,\r\nmaking the form submit process use base url,\r\nadding tests.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13358)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/249967550","html_url":"https://github.com/servo/servo/pull/13358#issuecomment-249967550","issue_url":"https://api.github.com/repos/servo/servo/issues/13358","id":249967550,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T19:12:48Z","updated_at":"2016-09-27T19:12:48Z","body":":pushpin: Commit ce249d9 has been approved by `mbrubeck`\n\n<!-- @bors-servo r=mbrubeck ce249d9384a613a463781c673b8243658be69891 -->"}}
{"actor":{"display_login":"bors-servo"}}