{"action":"created","issue":{"url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/7","repository_url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim","labels_url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/7/comments","events_url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/7/events","html_url":"https://github.com/BusinessProcessSimulation/BPSim/issues/7","id":132187790,"number":7,"title":"PropertyParameters - no way to specifying the type of Property","user":{"login":"jhorgan","id":17126137,"avatar_url":"https://avatars.githubusercontent.com/u/17126137?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorgan","html_url":"https://github.com/jhorgan","followers_url":"https://api.github.com/users/jhorgan/followers","following_url":"https://api.github.com/users/jhorgan/following{/other_user}","gists_url":"https://api.github.com/users/jhorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorgan/subscriptions","organizations_url":"https://api.github.com/users/jhorgan/orgs","repos_url":"https://api.github.com/users/jhorgan/repos","events_url":"https://api.github.com/users/jhorgan/events{/privacy}","received_events_url":"https://api.github.com/users/jhorgan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-02-08T16:25:04Z","updated_at":"2016-07-12T20:07:34Z","closed_at":"2016-07-12T20:07:34Z","body":"Currently there is no way to specify the type of Property (int, double, string etc.) used during property value assignment. \r\n\r\nThe Car Repair Process example that is part of the Implementers Guide, uses the following to assign a value to the \"noOfIssues\" property. The \"noOfIssues\" property is intended to be an integer count value. However the TruncatedNormalDistribution will return a double precision value between 1 and 1000, for example: 3.565534.\r\n```\r\n<bpsim:PropertyParameters>\r\n  <bpsim:Property name=\"noOfIssues\">\r\n      <bpsim:TruncatedNormalDistribution max=\"1000\" mean=\"2\" min=\"1\" standardDeviation=\"1\"/>\r\n   </bpsim:Property>\r\n</bpsim:PropertyParameters>\r\n```\r\n\r\nThe logic in the model decrements the \"noOfIssues\" each time an issue is repaired. Having fixed an issue, the number of issues now remaining is now 2.565534 (3.565534 - 1)\r\n\r\nThe gateway which decides if there are more issue to be fixed uses the logic getProperty('noOfIssues') = 0. \r\n\r\nClearly, unless we are very luck we will never reach exactly zero.\r\n\r\nHere are some possible solutions:\r\n\r\n- Give a hint during property assignment as to what the expected expression type is e.g.\r\n```\r\n<bpsim:PropertyParameters>\r\n  <bpsim:Property name=\"noOfIssues\" **type=\"int\"**>\r\n      <bpsim:TruncatedNormalDistribution max=\"1000\" mean=\"2\" min=\"1\" standardDeviation=\"1\"/>\r\n   </bpsim:Property>\r\n</bpsim:PropertyParameters>\r\n```\r\nPossibly make this an optional attribute?\r\n\r\n- Declare somewhere in the ```<ScenarioParameters>``` or  at the ```<ElementParameters>``` what the type of each property is.\r\n"},"comment":{"url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/comments/232163808","html_url":"https://github.com/BusinessProcessSimulation/BPSim/issues/7#issuecomment-232163808","issue_url":"https://api.github.com/repos/BusinessProcessSimulation/BPSim/issues/7","id":232163808,"user":{"login":"SimonRinguette","id":521578,"avatar_url":"https://avatars.githubusercontent.com/u/521578?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonRinguette","html_url":"https://github.com/SimonRinguette","followers_url":"https://api.github.com/users/SimonRinguette/followers","following_url":"https://api.github.com/users/SimonRinguette/following{/other_user}","gists_url":"https://api.github.com/users/SimonRinguette/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRinguette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRinguette/subscriptions","organizations_url":"https://api.github.com/users/SimonRinguette/orgs","repos_url":"https://api.github.com/users/SimonRinguette/repos","events_url":"https://api.github.com/users/SimonRinguette/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRinguette/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T20:07:34Z","updated_at":"2016-07-12T20:07:34Z","body":"At the face to face meeting in montreal (July 2016) we have decided to add a type to the properties of Property Parameter that points to a new enumeration of possible types."}}
{"actor":{"display_login":"SimonRinguette"}}