{"action":"created","issue":{"url":"https://api.github.com/repos/mybb/mybb/issues/2158","labels_url":"https://api.github.com/repos/mybb/mybb/issues/2158/labels{/name}","comments_url":"https://api.github.com/repos/mybb/mybb/issues/2158/comments","events_url":"https://api.github.com/repos/mybb/mybb/issues/2158/events","html_url":"https://github.com/mybb/mybb/pull/2158","id":95911461,"number":2158,"title":"Fix #257: Forum Mail as 'from' adress","user":{"login":"Evenprime","id":616090,"avatar_url":"https://avatars.githubusercontent.com/u/616090?v=3","gravatar_id":"","url":"https://api.github.com/users/Evenprime","html_url":"https://github.com/Evenprime","followers_url":"https://api.github.com/users/Evenprime/followers","following_url":"https://api.github.com/users/Evenprime/following{/other_user}","gists_url":"https://api.github.com/users/Evenprime/gists{/gist_id}","starred_url":"https://api.github.com/users/Evenprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evenprime/subscriptions","organizations_url":"https://api.github.com/users/Evenprime/orgs","repos_url":"https://api.github.com/users/Evenprime/repos","events_url":"https://api.github.com/users/Evenprime/events{/privacy}","received_events_url":"https://api.github.com/users/Evenprime/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mybb/mybb/labels/1.8","name":"1.8","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-07-19T12:21:53Z","updated_at":"2016-01-29T22:15:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mybb/mybb/pulls/2158","html_url":"https://github.com/mybb/mybb/pull/2158","diff_url":"https://github.com/mybb/mybb/pull/2158.diff","patch_url":"https://github.com/mybb/mybb/pull/2158.patch"},"body":"Referencing Issue #257 :\r\n\r\nUsing a users mail adress in the \"from\" part of an email will always fail if the domain of that email has a strict SPF policy, like yahoo.com, aol.com and many more in the future, as this will probably become the new standard to prevent mail spoofing. It is impossible to send such emails, as these technically do have spoofed sender adresses.\r\n\r\nThe user-to-user mails already include all important information about who actually sent the message and that it originates from the forum, therefore the \"from\"-adress of the mail could and should simply be the default adress of the forum that is used for all other notifications etc. The reply-to part of the mail is already correctly set to the users mail adress."},"comment":{"url":"https://api.github.com/repos/mybb/mybb/issues/comments/176994021","html_url":"https://github.com/mybb/mybb/pull/2158#issuecomment-176994021","issue_url":"https://api.github.com/repos/mybb/mybb/issues/2158","id":176994021,"user":{"login":"Destroy666x","id":3606072,"avatar_url":"https://avatars.githubusercontent.com/u/3606072?v=3","gravatar_id":"","url":"https://api.github.com/users/Destroy666x","html_url":"https://github.com/Destroy666x","followers_url":"https://api.github.com/users/Destroy666x/followers","following_url":"https://api.github.com/users/Destroy666x/following{/other_user}","gists_url":"https://api.github.com/users/Destroy666x/gists{/gist_id}","starred_url":"https://api.github.com/users/Destroy666x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Destroy666x/subscriptions","organizations_url":"https://api.github.com/users/Destroy666x/orgs","repos_url":"https://api.github.com/users/Destroy666x/repos","events_url":"https://api.github.com/users/Destroy666x/events{/privacy}","received_events_url":"https://api.github.com/users/Destroy666x/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T22:15:38Z","updated_at":"2016-01-29T22:15:38Z","body":"See, you wouldn't expect that and yet we expect admins to expect it...\r\n\r\nIt's because of this PR: https://github.com/mybb/mybb/pull/1732 which mentioned admin Email exposal. Whether I agree? Probably, I think it's better the current way, but not if it's not described properly. It's not good either way if there's no understandable description."}}