{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/gitsh/issues/189","repository_url":"https://api.github.com/repos/thoughtbot/gitsh","labels_url":"https://api.github.com/repos/thoughtbot/gitsh/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/gitsh/issues/189/comments","events_url":"https://api.github.com/repos/thoughtbot/gitsh/issues/189/events","html_url":"https://github.com/thoughtbot/gitsh/issues/189","id":45651123,"number":189,"title":"Tab completion doesn't work for arguments containing spaces","user":{"login":"georgebrock","id":35861,"avatar_url":"https://avatars.githubusercontent.com/u/35861?v=3","gravatar_id":"","url":"https://api.github.com/users/georgebrock","html_url":"https://github.com/georgebrock","followers_url":"https://api.github.com/users/georgebrock/followers","following_url":"https://api.github.com/users/georgebrock/following{/other_user}","gists_url":"https://api.github.com/users/georgebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebrock/subscriptions","organizations_url":"https://api.github.com/users/georgebrock/orgs","repos_url":"https://api.github.com/users/georgebrock/repos","events_url":"https://api.github.com/users/georgebrock/events{/privacy}","received_events_url":"https://api.github.com/users/georgebrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thoughtbot/gitsh/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2014-10-13T14:56:01Z","updated_at":"2016-07-23T15:20:20Z","closed_at":null,"body":"A solution is in progress on the `gb-custom-readline-extension` branch, after which the `gb-tab-complete-spaces` branch may become relevant again.\r\n\r\nSee discussion on #121 for details."},"comment":{"url":"https://api.github.com/repos/thoughtbot/gitsh/issues/comments/234723665","html_url":"https://github.com/thoughtbot/gitsh/issues/189#issuecomment-234723665","issue_url":"https://api.github.com/repos/thoughtbot/gitsh/issues/189","id":234723665,"user":{"login":"georgebrock","id":35861,"avatar_url":"https://avatars.githubusercontent.com/u/35861?v=3","gravatar_id":"","url":"https://api.github.com/users/georgebrock","html_url":"https://github.com/georgebrock","followers_url":"https://api.github.com/users/georgebrock/followers","following_url":"https://api.github.com/users/georgebrock/following{/other_user}","gists_url":"https://api.github.com/users/georgebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebrock/subscriptions","organizations_url":"https://api.github.com/users/georgebrock/orgs","repos_url":"https://api.github.com/users/georgebrock/repos","events_url":"https://api.github.com/users/georgebrock/events{/privacy}","received_events_url":"https://api.github.com/users/georgebrock/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T15:20:20Z","updated_at":"2016-07-23T15:20:20Z","body":"This is work-in-progress on the `gb-tab-complete-spaces` branch.\r\n\r\n* [x] Support escaped literals in unquoted strings in `Gitsh::Parser`\r\n* [x] Quote output from the `Gitsh::Completer` (e.g. with `some file.txt` typing <kbd>add some<kbd>tab</kbd></kbd> results in `add some\\ file.txt` instead of `add some file.txt`)\r\n* [x] Don't quote output from the `Gitsh::Completer` when completing a quoted string (e.g. with `some file.txt` typing <kbd>add \"some<kbd>tab</kbd></kbd> results in `add \"some file.txt\"` instead of `add \"some\\ file.txt\"`)\r\n* [x] Expose Readline's `rl_char_is_quoted_p` function\r\n* [x] Write a quoting detection proc to handle `\\` escaped characters (so that typing <kbd>add some\\ f<kbd>tab</kbd></kbd> results in `\"some\\ f\"` being passed to `Gitsh::Completer` instead of just `\"f\"`)\r\n* [x] Handle escaped escape characters in the quoting detection proc (e.g. the space in `foo\\\\ bar` is not escaped, but the space in `foo\\\\\\ bar` is)\r\n* [ ] Unquote input to the `Gitsh::Completer` so it can match against the options (e.g. when `\"some\\ f\"` is passed to `Gitsh::Completer`, look for options matching `\"some f\"`)\r\n* [ ] Make sure the `Gitsh::Completer` escaping correctly handles completing an unquoted argument after a quoted argument (e.g. <kbd>add \"foo\" some<kbd>tab</kbd></kbd> should escape the completions for `\"some\"`; using `rl_completion_found_quote` and `rl_completion_quote_character` instead of the current naive quote detection will probably help here)\r\n* [ ] Ensure that the escape parsing in `Gitsh::Parser`, and the escaping and unescaping in `Gitsh::Completer` all agree on which characters can be escaped\r\n* [ ] Document escaping in the gitsh(1) manual page"}}
{"actor":{"display_login":"georgebrock"}}