{"action":"created","comment":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76483462","id":76483462,"diff_hunk":"@@ -109,37 +108,25 @@ public void showWarningMessage(String title, String message)\n \t\tLogging.log(Logging.WARNING, title + \" - \" + message);\n \t}\n \n-\t/**\n-\t * {@inheritDoc}\n-\t */\n \t@Override\n \tpublic boolean showGeneralChooser(ChooserFacade chooserFacade)\n \t{\n \t\treturn false;\n \t}\n \n-\t/**\n-\t * {@inheritDoc}\n-\t */\n \t@Override\n \tpublic String showInputDialog(String title, String message, String initialValue)\n \t{\n \t\treturn null;\n \t}\n \n-\t/**\n-\t * {@inheritDoc}\n-\t */\n \t@Override\n \tpublic CustomEquipResult showCustomEquipDialog(CharacterFacade character, \n \t\tEquipmentBuilderFacade equipBuilder)\n \t{\n \t\treturn CustomEquipResult.CANCELLED;\n \t}\n \n-\t/**\n-\t * {@inheritDoc}","path":"code/src/java/pcgen/system/ConsoleUIDelegate.java","position":41,"original_position":41,"commit_id":"d15359e9beac8185918d2d43ebc986e536c9dc04","original_commit_id":"d15359e9beac8185918d2d43ebc986e536c9dc04","user":{"login":"thpr","id":8837174,"avatar_url":"https://avatars.githubusercontent.com/u/8837174?v=3","gravatar_id":"","url":"https://api.github.com/users/thpr","html_url":"https://github.com/thpr","followers_url":"https://api.github.com/users/thpr/followers","following_url":"https://api.github.com/users/thpr/following{/other_user}","gists_url":"https://api.github.com/users/thpr/gists{/gist_id}","starred_url":"https://api.github.com/users/thpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thpr/subscriptions","organizations_url":"https://api.github.com/users/thpr/orgs","repos_url":"https://api.github.com/users/thpr/repos","events_url":"https://api.github.com/users/thpr/events{/privacy}","received_events_url":"https://api.github.com/users/thpr/received_events","type":"User","site_admin":false},"body":"Curious why we are deleting these?  It will then trigger an error from our Checkstyle setup.","created_at":"2016-08-26T20:31:57Z","updated_at":"2016-08-26T20:31:57Z","html_url":"https://github.com/PCGen/pcgen/pull/1432#discussion_r76483462","pull_request_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1432","_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76483462"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1432#discussion_r76483462"},"pull_request":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1432"}}},"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/1432","id":82183392,"html_url":"https://github.com/PCGen/pcgen/pull/1432","diff_url":"https://github.com/PCGen/pcgen/pull/1432.diff","patch_url":"https://github.com/PCGen/pcgen/pull/1432.patch","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/1432","number":1432,"state":"open","locked":false,"title":"modernize a variety of code","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"- weaken types\r\n- reduce visibility\r\n- prefer lambdas where they simplify code\r\n- delete unused code\r\n- removed useless javadoc comments\r\n\r\n(mostly I'm using this as a way to spelunk through the code)","created_at":"2016-08-22T12:38:00Z","updated_at":"2016-08-26T20:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b1b9b7f3844b4bdb2b49a569f1ad655912eb2d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1432/commits","review_comments_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1432/comments","review_comment_url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/1432/comments","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/d15359e9beac8185918d2d43ebc986e536c9dc04","head":{"label":"grimreaper:eax/modern-part-4","ref":"eax/modern-part-4","sha":"d15359e9beac8185918d2d43ebc986e536c9dc04","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":43053313,"name":"pcgen","full_name":"grimreaper/pcgen","owner":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grimreaper/pcgen","description":"Main code and data development for pcgen program release","fork":true,"url":"https://api.github.com/repos/grimreaper/pcgen","forks_url":"https://api.github.com/repos/grimreaper/pcgen/forks","keys_url":"https://api.github.com/repos/grimreaper/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/pcgen/teams","hooks_url":"https://api.github.com/repos/grimreaper/pcgen/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/pcgen/events","assignees_url":"https://api.github.com/repos/grimreaper/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/pcgen/tags","blobs_url":"https://api.github.com/repos/grimreaper/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/pcgen/languages","stargazers_url":"https://api.github.com/repos/grimreaper/pcgen/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/pcgen/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/pcgen/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/pcgen/subscription","commits_url":"https://api.github.com/repos/grimreaper/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/pcgen/merges","archive_url":"https://api.github.com/repos/grimreaper/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/pcgen/downloads","issues_url":"https://api.github.com/repos/grimreaper/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/grimreaper/pcgen/deployments","created_at":"2015-09-24T08:01:43Z","updated_at":"2016-08-26T10:41:32Z","pushed_at":"2016-08-26T10:40:07Z","git_url":"git://github.com/grimreaper/pcgen.git","ssh_url":"git@github.com:grimreaper/pcgen.git","clone_url":"https://github.com/grimreaper/pcgen.git","svn_url":"https://github.com/grimreaper/pcgen","homepage":"http://pcgen.org","size":217831,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCGen:master","ref":"master","sha":"af2b6480e67494e6153be11612a60763f8e79558","user":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"repo":{"id":28585874,"name":"pcgen","full_name":"PCGen/pcgen","owner":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCGen/pcgen","description":"Main code and data development for pcgen program release","fork":false,"url":"https://api.github.com/repos/PCGen/pcgen","forks_url":"https://api.github.com/repos/PCGen/pcgen/forks","keys_url":"https://api.github.com/repos/PCGen/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCGen/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCGen/pcgen/teams","hooks_url":"https://api.github.com/repos/PCGen/pcgen/hooks","issue_events_url":"https://api.github.com/repos/PCGen/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/PCGen/pcgen/events","assignees_url":"https://api.github.com/repos/PCGen/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/PCGen/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/PCGen/pcgen/tags","blobs_url":"https://api.github.com/repos/PCGen/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCGen/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCGen/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCGen/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/PCGen/pcgen/languages","stargazers_url":"https://api.github.com/repos/PCGen/pcgen/stargazers","contributors_url":"https://api.github.com/repos/PCGen/pcgen/contributors","subscribers_url":"https://api.github.com/repos/PCGen/pcgen/subscribers","subscription_url":"https://api.github.com/repos/PCGen/pcgen/subscription","commits_url":"https://api.github.com/repos/PCGen/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCGen/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCGen/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCGen/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCGen/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/PCGen/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCGen/pcgen/merges","archive_url":"https://api.github.com/repos/PCGen/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCGen/pcgen/downloads","issues_url":"https://api.github.com/repos/PCGen/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/PCGen/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/PCGen/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/PCGen/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCGen/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/PCGen/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/PCGen/pcgen/deployments","created_at":"2014-12-29T08:41:04Z","updated_at":"2016-08-23T17:12:52Z","pushed_at":"2016-08-26T16:37:29Z","git_url":"git://github.com/PCGen/pcgen.git","ssh_url":"git@github.com:PCGen/pcgen.git","clone_url":"https://github.com/PCGen/pcgen.git","svn_url":"https://github.com/PCGen/pcgen","homepage":"http://pcgen.org","size":237854,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":52,"forks":80,"open_issues":52,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1432"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1432"},"issue":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1432"},"comments":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1432/comments"},"review_comments":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1432/comments"},"review_comment":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1432/commits"},"statuses":{"href":"https://api.github.com/repos/PCGen/pcgen/statuses/d15359e9beac8185918d2d43ebc986e536c9dc04"}}}}
{"actor":{"display_login":"thpr"}}