{"action":"opened","number":53,"pull_request":{"url":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53","id":78708089,"html_url":"https://github.com/hmrc/back-office-adapter/pull/53","diff_url":"https://github.com/hmrc/back-office-adapter/pull/53.diff","patch_url":"https://github.com/hmrc/back-office-adapter/pull/53.patch","issue_url":"https://api.github.com/repos/hmrc/back-office-adapter/issues/53","number":53,"state":"open","locked":false,"title":"Is refactor tests","user":{"login":"ian-seddon","id":16226403,"avatar_url":"https://avatars.githubusercontent.com/u/16226403?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-seddon","html_url":"https://github.com/ian-seddon","followers_url":"https://api.github.com/users/ian-seddon/followers","following_url":"https://api.github.com/users/ian-seddon/following{/other_user}","gists_url":"https://api.github.com/users/ian-seddon/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-seddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-seddon/subscriptions","organizations_url":"https://api.github.com/users/ian-seddon/orgs","repos_url":"https://api.github.com/users/ian-seddon/repos","events_url":"https://api.github.com/users/ian-seddon/events{/privacy}","received_events_url":"https://api.github.com/users/ian-seddon/received_events","type":"User","site_admin":false},"body":"Simplified tests by creating a fixture which provides setup and reduces code within the individual tests.\r\nNext step is to implement traits ( interfaces ) so we can remove knowledge/coupling of mock implementation (except in the tests for the concrete repo implementation ). Happy to discuss Wednesday.","created_at":"2016-07-25T16:05:32Z","updated_at":"2016-07-25T16:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30d399444a06fe031524f79ff45915deaae85a87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53/commits","review_comments_url":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53/comments","review_comment_url":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/back-office-adapter/issues/53/comments","statuses_url":"https://api.github.com/repos/hmrc/back-office-adapter/statuses/dc95321293d29631e9a61f6d6c20d255448e57e7","head":{"label":"ian-seddon:is_refactor_tests","ref":"is_refactor_tests","sha":"dc95321293d29631e9a61f6d6c20d255448e57e7","user":{"login":"ian-seddon","id":16226403,"avatar_url":"https://avatars.githubusercontent.com/u/16226403?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-seddon","html_url":"https://github.com/ian-seddon","followers_url":"https://api.github.com/users/ian-seddon/followers","following_url":"https://api.github.com/users/ian-seddon/following{/other_user}","gists_url":"https://api.github.com/users/ian-seddon/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-seddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-seddon/subscriptions","organizations_url":"https://api.github.com/users/ian-seddon/orgs","repos_url":"https://api.github.com/users/ian-seddon/repos","events_url":"https://api.github.com/users/ian-seddon/events{/privacy}","received_events_url":"https://api.github.com/users/ian-seddon/received_events","type":"User","site_admin":false},"repo":{"id":64148046,"name":"back-office-adapter","full_name":"ian-seddon/back-office-adapter","owner":{"login":"ian-seddon","id":16226403,"avatar_url":"https://avatars.githubusercontent.com/u/16226403?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-seddon","html_url":"https://github.com/ian-seddon","followers_url":"https://api.github.com/users/ian-seddon/followers","following_url":"https://api.github.com/users/ian-seddon/following{/other_user}","gists_url":"https://api.github.com/users/ian-seddon/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-seddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-seddon/subscriptions","organizations_url":"https://api.github.com/users/ian-seddon/orgs","repos_url":"https://api.github.com/users/ian-seddon/repos","events_url":"https://api.github.com/users/ian-seddon/events{/privacy}","received_events_url":"https://api.github.com/users/ian-seddon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ian-seddon/back-office-adapter","description":null,"fork":true,"url":"https://api.github.com/repos/ian-seddon/back-office-adapter","forks_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/forks","keys_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/teams","hooks_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/hooks","issue_events_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/events","assignees_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/tags","blobs_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/languages","stargazers_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/stargazers","contributors_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/contributors","subscribers_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/subscribers","subscription_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/subscription","commits_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/merges","archive_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/downloads","issues_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/labels{/name}","releases_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/ian-seddon/back-office-adapter/deployments","created_at":"2016-07-25T15:52:12Z","updated_at":"2016-07-25T15:52:14Z","pushed_at":"2016-07-25T15:56:26Z","git_url":"git://github.com/ian-seddon/back-office-adapter.git","ssh_url":"git@github.com:ian-seddon/back-office-adapter.git","clone_url":"https://github.com/ian-seddon/back-office-adapter.git","svn_url":"https://github.com/ian-seddon/back-office-adapter","homepage":"","size":176,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"7897c10b119db87c13ade6f4d7c6f663433efe10","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":62150461,"name":"back-office-adapter","full_name":"hmrc/back-office-adapter","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/back-office-adapter","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/back-office-adapter","forks_url":"https://api.github.com/repos/hmrc/back-office-adapter/forks","keys_url":"https://api.github.com/repos/hmrc/back-office-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/back-office-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/back-office-adapter/teams","hooks_url":"https://api.github.com/repos/hmrc/back-office-adapter/hooks","issue_events_url":"https://api.github.com/repos/hmrc/back-office-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/back-office-adapter/events","assignees_url":"https://api.github.com/repos/hmrc/back-office-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/back-office-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/back-office-adapter/tags","blobs_url":"https://api.github.com/repos/hmrc/back-office-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/back-office-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/back-office-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/back-office-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/back-office-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/back-office-adapter/languages","stargazers_url":"https://api.github.com/repos/hmrc/back-office-adapter/stargazers","contributors_url":"https://api.github.com/repos/hmrc/back-office-adapter/contributors","subscribers_url":"https://api.github.com/repos/hmrc/back-office-adapter/subscribers","subscription_url":"https://api.github.com/repos/hmrc/back-office-adapter/subscription","commits_url":"https://api.github.com/repos/hmrc/back-office-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/back-office-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/back-office-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/back-office-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/back-office-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/back-office-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/back-office-adapter/merges","archive_url":"https://api.github.com/repos/hmrc/back-office-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/back-office-adapter/downloads","issues_url":"https://api.github.com/repos/hmrc/back-office-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/back-office-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/back-office-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/back-office-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/back-office-adapter/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/back-office-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/back-office-adapter/deployments","created_at":"2016-06-28T14:59:44Z","updated_at":"2016-06-28T16:08:41Z","pushed_at":"2016-07-25T16:05:32Z","git_url":"git://github.com/hmrc/back-office-adapter.git","ssh_url":"git@github.com:hmrc/back-office-adapter.git","clone_url":"https://github.com/hmrc/back-office-adapter.git","svn_url":"https://github.com/hmrc/back-office-adapter","homepage":"","size":176,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53"},"html":{"href":"https://github.com/hmrc/back-office-adapter/pull/53"},"issue":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/issues/53"},"comments":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/back-office-adapter/statuses/dc95321293d29631e9a61f6d6c20d255448e57e7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":297,"deletions":393,"changed_files":5}}
{"actor":{"display_login":"ian-seddon"}}