{"action":"created","issue":{"url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/353","repository_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor","labels_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/353/comments","events_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/353/events","html_url":"https://github.com/divio/djangocms-text-ckeditor/issues/353","id":173569022,"number":353,"title":"3.1.0 inline preview not working for some django-filer images","user":{"login":"jsma","id":24574,"avatar_url":"https://avatars.githubusercontent.com/u/24574?v=3","gravatar_id":"","url":"https://api.github.com/users/jsma","html_url":"https://github.com/jsma","followers_url":"https://api.github.com/users/jsma/followers","following_url":"https://api.github.com/users/jsma/following{/other_user}","gists_url":"https://api.github.com/users/jsma/gists{/gist_id}","starred_url":"https://api.github.com/users/jsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsma/subscriptions","organizations_url":"https://api.github.com/users/jsma/orgs","repos_url":"https://api.github.com/users/jsma/repos","events_url":"https://api.github.com/users/jsma/events{/privacy}","received_events_url":"https://api.github.com/users/jsma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false},"assignees":[{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-08-27T00:53:07Z","updated_at":"2016-09-11T06:05:50Z","closed_at":null,"body":"I have a page which has three instances of cmsplugin-filer image plugins on it. After upgrading to djangocms-text-ckeditor 3.1.0, only the first two can be double-clicked to edit (they both show the yellow border on hover and a blue border when single-clicked). \r\n\r\nFor the third image plugin instance, there is no border shown on hover or on single click. If I double-click the image, the editor becomes disabled, no clicks or scrolling possible within the editor (the minimize/maximize/'x' to close and the Cancel/Delete/Save buttons are the only things that still work):\r\n\r\n<img width=\"847\" alt=\"screen shot 2016-08-26 at 4 11 38 pm\" src=\"https://cloud.githubusercontent.com/assets/24574/18022890/e0e9c1a0-6ba7-11e6-9151-3498f58636a5.png\">\r\n\r\nThe only difference between the plugins is that the third image plugin instance uses the 'file link' option to link the image to a cmsplugin-filer file.\r\n\r\nIf I click the 'Source' button in the editor, the rendered markup for the third plugin is broken:\r\n\r\n\t<cms-plugin alt=\"Image - test.png \" id=\"11854\" render-plugin=\"true\" title=\"Image - test.png\"></cms-plugin>\r\n\r\n\t<p>&nbsp;</p>\r\n\r\n\t<figure id=\"image_plugin_700\"><a href=\"/media/filer_public/81/fa/81fa62ff-51aa-4bf0-891c-223f6cc54768/test.pdf\" target=\"_blank\"><img alt=\"test.png\" class=\"img-responsive\" src=\"/media/filer_public_thumbnails/filer_public/24/fb/24fb47ed-203d-4402-8904-90825f4cb116/test.png__726x941_q85_crop_subsampling-2_upscale.png\" /></a></figure>\r\n\r\nNote that the `<cms-plugin>` tag closed itself without wrapping the `<figure>` tag and an empty `<p>` was added.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/comments/246164041","html_url":"https://github.com/divio/djangocms-text-ckeditor/issues/353#issuecomment-246164041","issue_url":"https://api.github.com/repos/divio/djangocms-text-ckeditor/issues/353","id":246164041,"user":{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T06:05:50Z","updated_at":"2016-09-11T06:05:50Z","body":"@jsma it looks like you're getting cached old ckeditor javascript for some reason. if you see the image tag with plugin_obj_xxx id - it's definitely created by the older version of it. New version creates `<cms-plugin>` markup instead. you said you've cleaned the cache, but i've seen it on one of our production sites and only going to the chrome settings and removing cached files for last month actually helped\r\n\r\ni think if you compare the files served in safari and in chrome you would confirm it\r\n\r\ncompletely emptying text plugin is impossible, plugin contents can't be empty (should just delete a plugin in that case), so space of empty `<p></p>` can be used for clearing\r\n\r\nCaching issues should be fixed with https://github.com/divio/djangocms-text-ckeditor/pull/361 in place\r\n\r\ni'd love to hear more more about the extra `<p>` tags. Are they appearing around the image plugin you mentioned in original post or everywhere?  \r\n\r\n\r\n"}}
{"actor":{"display_login":"vxsx"}}