{"action":"created","comment":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/comments/53222790","id":53222790,"diff_hunk":"@@ -129,13 +128,49 @@ def write_target_ninja(ninja, target):\n     deps = [dep.output for dep in target.deps]\n     libs = [dep.output for dep in target.deps if dep.kind == LIB]\n     if target.kind == EXE:\n-        ninja.variable('ldflags', '-Wl,pie')\n+        # ninja.variable('ldflags', '-Wl,-pie')","path":"misc/write_fake_manifests.py","position":24,"original_position":24,"commit_id":"a4b3f8a8c3837380214ece1a75e05419d4bf512b","original_commit_id":"a4b3f8a8c3837380214ece1a75e05419d4bf512b","user":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"body":"?","created_at":"2016-02-17T20:03:59Z","updated_at":"2016-02-17T20:03:59Z","html_url":"https://github.com/ninja-build/ninja/pull/1109#discussion_r53222790","pull_request_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1109","_links":{"self":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/comments/53222790"},"html":{"href":"https://github.com/ninja-build/ninja/pull/1109#discussion_r53222790"},"pull_request":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1109"}}},"pull_request":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/1109","id":59372819,"html_url":"https://github.com/ninja-build/ninja/pull/1109","diff_url":"https://github.com/ninja-build/ninja/pull/1109.diff","patch_url":"https://github.com/ninja-build/ninja/pull/1109.patch","issue_url":"https://api.github.com/repos/ninja-build/ninja/issues/1109","number":1109,"state":"open","locked":false,"title":"enhance write_fake_manifest.py","user":{"login":"fbenkstein","id":7721507,"avatar_url":"https://avatars.githubusercontent.com/u/7721507?v=3","gravatar_id":"","url":"https://api.github.com/users/fbenkstein","html_url":"https://github.com/fbenkstein","followers_url":"https://api.github.com/users/fbenkstein/followers","following_url":"https://api.github.com/users/fbenkstein/following{/other_user}","gists_url":"https://api.github.com/users/fbenkstein/gists{/gist_id}","starred_url":"https://api.github.com/users/fbenkstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbenkstein/subscriptions","organizations_url":"https://api.github.com/users/fbenkstein/orgs","repos_url":"https://api.github.com/users/fbenkstein/repos","events_url":"https://api.github.com/users/fbenkstein/events{/privacy}","received_events_url":"https://api.github.com/users/fbenkstein/received_events","type":"User","site_admin":false},"body":"Add command line options to write_fake_manifest.py to change the number of\r\ntargets being generated and the seed.  More importantly, add an option to\r\ngenerate sources as well so the manifest generated can actually be executed\r\nsuccessfully.","created_at":"2016-02-15T14:47:51Z","updated_at":"2016-02-17T20:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5723f8012a64621f8f789f635200c64be863e076","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninja-build/ninja/issues/1109/comments","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/a4b3f8a8c3837380214ece1a75e05419d4bf512b","head":{"label":"fbenkstein:enhance_write_fake_manifest","ref":"enhance_write_fake_manifest","sha":"a4b3f8a8c3837380214ece1a75e05419d4bf512b","user":{"login":"fbenkstein","id":7721507,"avatar_url":"https://avatars.githubusercontent.com/u/7721507?v=3","gravatar_id":"","url":"https://api.github.com/users/fbenkstein","html_url":"https://github.com/fbenkstein","followers_url":"https://api.github.com/users/fbenkstein/followers","following_url":"https://api.github.com/users/fbenkstein/following{/other_user}","gists_url":"https://api.github.com/users/fbenkstein/gists{/gist_id}","starred_url":"https://api.github.com/users/fbenkstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbenkstein/subscriptions","organizations_url":"https://api.github.com/users/fbenkstein/orgs","repos_url":"https://api.github.com/users/fbenkstein/repos","events_url":"https://api.github.com/users/fbenkstein/events{/privacy}","received_events_url":"https://api.github.com/users/fbenkstein/received_events","type":"User","site_admin":false},"repo":{"id":51068881,"name":"ninja","full_name":"fbenkstein/ninja","owner":{"login":"fbenkstein","id":7721507,"avatar_url":"https://avatars.githubusercontent.com/u/7721507?v=3","gravatar_id":"","url":"https://api.github.com/users/fbenkstein","html_url":"https://github.com/fbenkstein","followers_url":"https://api.github.com/users/fbenkstein/followers","following_url":"https://api.github.com/users/fbenkstein/following{/other_user}","gists_url":"https://api.github.com/users/fbenkstein/gists{/gist_id}","starred_url":"https://api.github.com/users/fbenkstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbenkstein/subscriptions","organizations_url":"https://api.github.com/users/fbenkstein/orgs","repos_url":"https://api.github.com/users/fbenkstein/repos","events_url":"https://api.github.com/users/fbenkstein/events{/privacy}","received_events_url":"https://api.github.com/users/fbenkstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbenkstein/ninja","description":"a small build system with a focus on speed","fork":true,"url":"https://api.github.com/repos/fbenkstein/ninja","forks_url":"https://api.github.com/repos/fbenkstein/ninja/forks","keys_url":"https://api.github.com/repos/fbenkstein/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbenkstein/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbenkstein/ninja/teams","hooks_url":"https://api.github.com/repos/fbenkstein/ninja/hooks","issue_events_url":"https://api.github.com/repos/fbenkstein/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/fbenkstein/ninja/events","assignees_url":"https://api.github.com/repos/fbenkstein/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/fbenkstein/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/fbenkstein/ninja/tags","blobs_url":"https://api.github.com/repos/fbenkstein/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbenkstein/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbenkstein/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbenkstein/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbenkstein/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/fbenkstein/ninja/languages","stargazers_url":"https://api.github.com/repos/fbenkstein/ninja/stargazers","contributors_url":"https://api.github.com/repos/fbenkstein/ninja/contributors","subscribers_url":"https://api.github.com/repos/fbenkstein/ninja/subscribers","subscription_url":"https://api.github.com/repos/fbenkstein/ninja/subscription","commits_url":"https://api.github.com/repos/fbenkstein/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbenkstein/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbenkstein/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbenkstein/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbenkstein/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/fbenkstein/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbenkstein/ninja/merges","archive_url":"https://api.github.com/repos/fbenkstein/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbenkstein/ninja/downloads","issues_url":"https://api.github.com/repos/fbenkstein/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/fbenkstein/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/fbenkstein/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/fbenkstein/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbenkstein/ninja/labels{/name}","releases_url":"https://api.github.com/repos/fbenkstein/ninja/releases{/id}","deployments_url":"https://api.github.com/repos/fbenkstein/ninja/deployments","created_at":"2016-02-04T10:35:40Z","updated_at":"2016-02-04T10:35:41Z","pushed_at":"2016-02-16T09:37:19Z","git_url":"git://github.com/fbenkstein/ninja.git","ssh_url":"git@github.com:fbenkstein/ninja.git","clone_url":"https://github.com/fbenkstein/ninja.git","svn_url":"https://github.com/fbenkstein/ninja","homepage":"http://ninja-build.org/","size":2132,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ninja-build:master","ref":"master","sha":"4674e0dc4faaa8535fa8b2726764fa5f914eb050","user":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"repo":{"id":1335132,"name":"ninja","full_name":"ninja-build/ninja","owner":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninja-build/ninja","description":"a small build system with a focus on speed","fork":false,"url":"https://api.github.com/repos/ninja-build/ninja","forks_url":"https://api.github.com/repos/ninja-build/ninja/forks","keys_url":"https://api.github.com/repos/ninja-build/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninja-build/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninja-build/ninja/teams","hooks_url":"https://api.github.com/repos/ninja-build/ninja/hooks","issue_events_url":"https://api.github.com/repos/ninja-build/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/ninja-build/ninja/events","assignees_url":"https://api.github.com/repos/ninja-build/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/ninja-build/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/ninja-build/ninja/tags","blobs_url":"https://api.github.com/repos/ninja-build/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninja-build/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninja-build/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninja-build/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/ninja-build/ninja/languages","stargazers_url":"https://api.github.com/repos/ninja-build/ninja/stargazers","contributors_url":"https://api.github.com/repos/ninja-build/ninja/contributors","subscribers_url":"https://api.github.com/repos/ninja-build/ninja/subscribers","subscription_url":"https://api.github.com/repos/ninja-build/ninja/subscription","commits_url":"https://api.github.com/repos/ninja-build/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninja-build/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninja-build/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninja-build/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninja-build/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/ninja-build/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninja-build/ninja/merges","archive_url":"https://api.github.com/repos/ninja-build/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninja-build/ninja/downloads","issues_url":"https://api.github.com/repos/ninja-build/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/ninja-build/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/ninja-build/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/ninja-build/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninja-build/ninja/labels{/name}","releases_url":"https://api.github.com/repos/ninja-build/ninja/releases{/id}","deployments_url":"https://api.github.com/repos/ninja-build/ninja/deployments","created_at":"2011-02-06T19:07:12Z","updated_at":"2016-02-17T06:36:59Z","pushed_at":"2016-02-17T20:03:14Z","git_url":"git://github.com/ninja-build/ninja.git","ssh_url":"git@github.com:ninja-build/ninja.git","clone_url":"https://github.com/ninja-build/ninja.git","svn_url":"https://github.com/ninja-build/ninja","homepage":"http://ninja-build.org/","size":7916,"stargazers_count":1821,"watchers_count":1821,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":161,"forks":316,"open_issues":161,"watchers":1821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1109"},"html":{"href":"https://github.com/ninja-build/ninja/pull/1109"},"issue":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1109"},"comments":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/ninja-build/ninja/statuses/a4b3f8a8c3837380214ece1a75e05419d4bf512b"}}}}