{"push_id":1186265936,"size":14,"distinct_size":14,"ref":"refs/heads/error-highlight","head":"b8963f1398f33ea125f4ddf9df06afd2d370e7f2","before":"5eb178985b83f8a774ea1e37e068abe5da1ba21a","commits":[{"sha":"245e5c02d40d12699b381b622f0b0db78e0de112","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Uses ES bulk api only when there's more than one span (#1146)\n\nDuring a test where 100 single-span messages are sent to Kafka at the\r\nsame time, I noticed only 58-97 of them would end up in storage\r\neventhough all messages parsed properly and no operations failed.\r\n\r\nAfter a 100ms/message pause was added, the store rate of this test went\r\nto 100%, so figured it was some sort of state issue. I noticed the code\r\nwas using Bulk operations regardless of input size, so as a wild guess\r\nchanged the special-case single-span messages. At least in this test, it\r\nraised the success rate to 100% without any pausing needed.\r\n\r\nI don't know why this worked, but it seems sensible to not use bulk apis\r\nwhen there's no bulk action to perform.\r\n\r\nI started to write a unit test to validate single-length lists don't use\r\nbulk, but the Mockito involved became too verbose as the Elasticsearch\r\nclient uses chaining and other patterns that are tedious to mock.\r\n\r\nInstead, we should make a parallel integration test and apply them to\r\nall storage components.","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/245e5c02d40d12699b381b622f0b0db78e0de112"},{"sha":"bab1efd2e50c44614501c17148983f1235866874","author":{"name":"Dustin Spicuzza","email":"56b08fe8ce653d8a7a7096b8d075e915474fdbf3@virtualroadside.com"},"message":"Add useful documentation for doing zipkin-ui development (#1147)","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/bab1efd2e50c44614501c17148983f1235866874"},{"sha":"401ed0292e6465f2ecb2c635eb9238eff93e4bd1","author":{"name":"Kristian Klette","email":"8502bf29d1d18dba292797f1c96f63a7fe72b340@klette.us"},"message":"Exposes prometheus compatible metrics on /prometheus (#1144)\n\nWe run Zipkin in several kubernetes clusters and thus we need a sane way of collecting the metrics.\r\nAs Prometheus has all the built-in support for dealing with the moving parts of Kubernetes, it seems\r\nlike a rational choice.\r\n\r\nThis PR exposes Spring Actuator metrics on /prometheus\r\nusing the 0.0.4 version of their text format specified\r\nhere https://prometheus.io/docs/instrumenting/exposition_formats/.\r\n\r\nNot crazy about the path, but adding new controllers into /metrics/* seems like more complexity than needed.","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/401ed0292e6465f2ecb2c635eb9238eff93e4bd1"},{"sha":"26368aed3d89bf25d6d5cc4b8a0b13c71c154482","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Adds properties that affect Elasticsearch index scalability (#1150)\n\nThis adds the following properties, which help control the scalability\r\nof Zipkin's index in Elasticsearch.\r\n\r\n    * `ES_INDEX_SHARDS`: The number of shards to split the index into. Each shard and its replicas\r\n                         are assigned to a machine in the cluster. Increasing the number of shards\r\n                         and machines in the cluster will improve read and write performance. Number\r\n                         of shards cannot be changed for existing indices, but new daily indices\r\n                         will pick up changes to the setting. Defaults to 5.\r\n    * `ES_INDEX_REPLICAS`: The number of replica copies of each shard in the index. Each shard and\r\n                           its replicas are assigned to a machine in the cluster. Increasing the\r\n                           number of replicas and machines in the cluster will improve read\r\n                           performance, but not write performance. Number of replicas can be changed\r\n                           for existing indices. Defaults to 1. It is highly discouraged to set this\r\n                           to 0 as it would mean a machine failure results in data loss.","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/26368aed3d89bf25d6d5cc4b8a0b13c71c154482"},{"sha":"34b2bc9500a13338eb99678a3ce26ed112be0c67","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Fixes NPE when ES aggregations don't exist yet (#1152)","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/34b2bc9500a13338eb99678a3ce26ed112be0c67"},{"sha":"0d51d90a8859450f704e13faea3dee320e4bb080","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Fixes Cassandra indexes that lost traces in the same millisecond (#1153)\n\nA schema bug resulted in Cassandra not indexing more than bucket count\r\n(10) trace ids per millisecond+search input. This manifested as less\r\ntraces retrieved by UI search or Api query than expected. For example,\r\nif you had 1000 traces that happened on the same service in the same\r\nmillisecond, only 10 would return.\r\n\r\nThe indexes affected are `service_span_name_index`, `service_name_index`\r\nand `annotations_index` and this was a schema-only change. Those with\r\nexisting zipkin installations should recreate these indexes to solve the\r\nproblem.\r\n\r\nFixes #1142","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/0d51d90a8859450f704e13faea3dee320e4bb080"},{"sha":"1f09c99bc1b552113cf7533541ad7703a8ef5db7","author":{"name":"adriancole","email":"a5aaecb6ea219343eb269080b22ef0b90e34dfd9@pivotal.io"},"message":"[maven-release-plugin] prepare release 1.2.0","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/1f09c99bc1b552113cf7533541ad7703a8ef5db7"},{"sha":"d823ed05eef9c7c95d00a6c658f29719d1805342","author":{"name":"adriancole","email":"a5aaecb6ea219343eb269080b22ef0b90e34dfd9@pivotal.io"},"message":"[maven-release-plugin] prepare for next development iteration","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/d823ed05eef9c7c95d00a6c658f29719d1805342"},{"sha":"6d06d8df768e37eeccea4ee13ee7781415a260b8","author":{"name":"Adrian Cole","email":"a5aaecb6ea219343eb269080b22ef0b90e34dfd9@pivotal.io"},"message":"Revert \"Fixes Cassandra indexes that lost traces in the same millisecond (#1153)\"\n\nThis reverts commit 0d51d90a8859450f704e13faea3dee320e4bb080.\n\nThe change needs to be re-addressed as trace ids repeat in the indexes now. This\nmakes the limit problem worse.","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/6d06d8df768e37eeccea4ee13ee7781415a260b8"},{"sha":"eafc75543d1111f167e91f55214945d800360c39","author":{"name":"adriancole","email":"a5aaecb6ea219343eb269080b22ef0b90e34dfd9@pivotal.io"},"message":"[maven-release-plugin] prepare release 1.2.1","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/eafc75543d1111f167e91f55214945d800360c39"},{"sha":"9d1aae6c560228ee3b9b63fcf9d7ee19f69a1f4a","author":{"name":"adriancole","email":"a5aaecb6ea219343eb269080b22ef0b90e34dfd9@pivotal.io"},"message":"[maven-release-plugin] prepare for next development iteration","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/9d1aae6c560228ee3b9b63fcf9d7ee19f69a1f4a"},{"sha":"b295c3ab18eb2538f9144321d272601fe7d3dfba","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Coerces Span.timestamp to null when zero (#1155)","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/b295c3ab18eb2538f9144321d272601fe7d3dfba"},{"sha":"acc688e066223d31e8a6aae9c3ea967a1ab82570","author":{"name":"Adrian Cole","email":"1250a5b2ec39440f3426b56cafd814c6bc4717bd@users.noreply.github.com"},"message":"Replaces hand-written query logging with DataStax QueryLogger (#1156)\n\nHand-written query logging has resulted in bugs and also clutters the\r\ncodebase. This change replaces that with DataStax QueryLogger, which is\r\nenabled when the category \"com.datastax.driver.core.QueryLogger\" is at\r\ndebug or trace level. Trace level includes bound values.\r\n\r\nEx.\r\n\r\n```bash\r\n$ STORAGE_TYPE=cassandra java -jar zipkin-server/target/zipkin-server-*-exec.jar  --logging.level.zipkin=debug --logging.level.com.datastax.driver.core.QueryLogger=trace\r\n--snip--\r\n2016-06-30 15:28:05.742 TRACE 27669 --- [r2-nio-worker-1] c.d.driver.core.QueryLogger.NORMAL       : [cluster2] [localhost/127.0.0.1:9042] Query completed normally, took 10 ms: [4 bound values] INSERT INTO annotations_index (annotation,bucket,ts,trace_id) VALUES (:annotation,:bucket,:ts,:trace_id); [annotation:0x7a69706b696e2d7365727665723a4170706c69636174696f... [truncated output], bucket:9, ts:1467271680225, trace_id:3814895566661605459]\r\n```\r\n\r\nSee [Logging Query Latencies](http://docs.datastax.com/en/developer/java-driver/2.1/supplemental/manual/logging/#logging-query-latencies) for more details.\r\nFixes https://github.com/openzipkin/zipkin-java/issues/190","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/acc688e066223d31e8a6aae9c3ea967a1ab82570"},{"sha":"b8963f1398f33ea125f4ddf9df06afd2d370e7f2","author":{"name":"Dustin Spicuzza","email":"56b08fe8ce653d8a7a7096b8d075e915474fdbf3@virtualroadside.com"},"message":"Highlight spans with errors\n\n- Annotations: value must be 'error'\n- Binary annotations: key must be 'error'\n- Fixes #1140","distinct":true,"url":"https://api.github.com/repos/virtuald/zipkin/commits/b8963f1398f33ea125f4ddf9df06afd2d370e7f2"}]}
{"actor":{"display_login":"virtuald"}}