{"action":"closed","number":571,"pull_request":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/571","id":60902655,"html_url":"https://github.com/autotest/autotest-docker/pull/571","diff_url":"https://github.com/autotest/autotest-docker/pull/571.diff","patch_url":"https://github.com/autotest/autotest-docker/pull/571.patch","issue_url":"https://api.github.com/repos/autotest/autotest-docker/issues/571","number":571,"state":"closed","locked":false,"title":"Fix test failure in double_tag subsubtest.","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"body":"subtest tag:double_tag was failing. Root cause: too many\r\nto list. I don't think this test could have ever completed\r\nsuccessfully.\r\n\r\nFixes:\r\n + Principally, reworked the way we check exit status\r\n   when we're expecting the command to fail (i.e.\r\n   two 'docker tag' commands in a row without -f).\r\n\r\nRelated fixes:\r\n + moved some logic from the config file to the code:\r\n   1) docker_expected_result (PASS/FAIL): this absolutely\r\n      does not belong in a config file. There is no\r\n      circumstance under which an end user would want\r\n      to say \"oh hey let's expect double-tag to pass\"\r\n      or \"let's expect other-test to fail\". This is\r\n      code logic, not configuration logic.\r\n   2) -f flag (in double_tag_force): again, this is\r\n      code logic. It's the whole defining factor of\r\n      the test itself. It is harmful to imply that\r\n      an end user should be able to change this via\r\n      config file.\r\n\r\nUnrelated fixes:\r\n + differentiation of two previously identical debug\r\n   messages, so human debugger can identify which part\r\n   of the code a message is coming from;\r\n + variable name change, fixing a misleading reuse situation\r\n + make first docker command in double_tag verbose, making\r\n   test flow clearer in debug log\r\n + slightly more informative comments\r\n + minor typo fix\r\n\r\nSigned-off-by: Ed Santiago <santiago@redhat.com>","created_at":"2016-02-26T20:55:20Z","updated_at":"2016-02-29T18:20:42Z","closed_at":"2016-02-29T18:20:42Z","merged_at":"2016-02-29T18:20:42Z","merge_commit_sha":"b515e16d1e5749468d7c4ed75b594d5d594ace3b","assignee":null,"milestone":{"url":"https://api.github.com/repos/autotest/autotest-docker/milestones/21","html_url":"https://github.com/autotest/autotest-docker/milestones/Docker%20Autotest%20Version%200.8.5%20(NO%20API%20Changes)","labels_url":"https://api.github.com/repos/autotest/autotest-docker/milestones/21/labels","id":1079148,"number":21,"title":"Docker Autotest Version 0.8.5 (NO API Changes)","description":"","creator":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":36,"state":"open","created_at":"2015-04-22T15:55:31Z","updated_at":"2016-02-29T18:20:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/571/commits","review_comments_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/571/comments","review_comment_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/issues/571/comments","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/76fef6c90db38c247e27e5535f672e28c7e069f1","head":{"label":"edsantiago:fix_double_tag","ref":"fix_double_tag","sha":"76fef6c90db38c247e27e5535f672e28c7e069f1","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"repo":{"id":51094257,"name":"autotest-docker","full_name":"edsantiago/autotest-docker","owner":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edsantiago/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":true,"url":"https://api.github.com/repos/edsantiago/autotest-docker","forks_url":"https://api.github.com/repos/edsantiago/autotest-docker/forks","keys_url":"https://api.github.com/repos/edsantiago/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edsantiago/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edsantiago/autotest-docker/teams","hooks_url":"https://api.github.com/repos/edsantiago/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/edsantiago/autotest-docker/events","assignees_url":"https://api.github.com/repos/edsantiago/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/edsantiago/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/tags","blobs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edsantiago/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/edsantiago/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/edsantiago/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/edsantiago/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscription","commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/edsantiago/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/edsantiago/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/edsantiago/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edsantiago/autotest-docker/merges","archive_url":"https://api.github.com/repos/edsantiago/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edsantiago/autotest-docker/downloads","issues_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/edsantiago/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/edsantiago/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/edsantiago/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edsantiago/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/edsantiago/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/edsantiago/autotest-docker/deployments","created_at":"2016-02-04T17:56:14Z","updated_at":"2016-02-04T17:56:15Z","pushed_at":"2016-02-26T21:01:29Z","git_url":"git://github.com/edsantiago/autotest-docker.git","ssh_url":"git@github.com:edsantiago/autotest-docker.git","clone_url":"https://github.com/edsantiago/autotest-docker.git","svn_url":"https://github.com/edsantiago/autotest-docker","homepage":null,"size":1955,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"8c9fc5250eccad23b9deee2a937070def97a29ea","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":17869790,"name":"autotest-docker","full_name":"autotest/autotest-docker","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":false,"url":"https://api.github.com/repos/autotest/autotest-docker","forks_url":"https://api.github.com/repos/autotest/autotest-docker/forks","keys_url":"https://api.github.com/repos/autotest/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/autotest-docker/teams","hooks_url":"https://api.github.com/repos/autotest/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/autotest/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/autotest-docker/events","assignees_url":"https://api.github.com/repos/autotest/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/autotest-docker/tags","blobs_url":"https://api.github.com/repos/autotest/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/autotest/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/autotest/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/autotest/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/autotest/autotest-docker/subscription","commits_url":"https://api.github.com/repos/autotest/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/autotest-docker/merges","archive_url":"https://api.github.com/repos/autotest/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/autotest-docker/downloads","issues_url":"https://api.github.com/repos/autotest/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/autotest/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/autotest-docker/deployments","created_at":"2014-03-18T14:53:27Z","updated_at":"2016-01-21T21:48:31Z","pushed_at":"2016-02-29T18:20:42Z","git_url":"git://github.com/autotest/autotest-docker.git","ssh_url":"git@github.com:autotest/autotest-docker.git","clone_url":"https://github.com/autotest/autotest-docker.git","svn_url":"https://github.com/autotest/autotest-docker","homepage":null,"size":2444,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":53,"forks":21,"open_issues":53,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/571"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/571"},"issue":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/571"},"comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/571/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/571/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/571/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/autotest-docker/statuses/76fef6c90db38c247e27e5535f672e28c7e069f1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":32,"deletions":24,"changed_files":2}}