{"action":"created","comment":{"url":"https://api.github.com/repos/01org/ciao/pulls/comments/76278395","id":76278395,"diff_hunk":"@@ -136,6 +136,8 @@ func main() {\n \tidentityURL = clusterConfig.Configure.IdentityService.URL\n \tserviceUser = clusterConfig.Configure.Controller.IdentityUser\n \tservicePassword = clusterConfig.Configure.Controller.IdentityPassword\n+\tkeyringPath = clusterConfig.Configure.Storage.SecretPath","path":"ciao-controller/main.go","position":26,"original_position":26,"commit_id":"b9bceca1f50b7036492bb7fa742f59d1b5b555ca","original_commit_id":"b9bceca1f50b7036492bb7fa742f59d1b5b555ca","user":{"login":"sameo","id":1043863,"avatar_url":"https://avatars.githubusercontent.com/u/1043863?v=3","gravatar_id":"","url":"https://api.github.com/users/sameo","html_url":"https://github.com/sameo","followers_url":"https://api.github.com/users/sameo/followers","following_url":"https://api.github.com/users/sameo/following{/other_user}","gists_url":"https://api.github.com/users/sameo/gists{/gist_id}","starred_url":"https://api.github.com/users/sameo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameo/subscriptions","organizations_url":"https://api.github.com/users/sameo/orgs","repos_url":"https://api.github.com/users/sameo/repos","events_url":"https://api.github.com/users/sameo/events{/privacy}","received_events_url":"https://api.github.com/users/sameo/received_events","type":"User","site_admin":false},"body":"Yes, those 2 fields should be required through validMinConf() but you want to allow for a grace period and give people time to update their cluster configuration, i.e.:\r\n\r\n* `validMinConf()` should spit a warning for now if the storage config is not present for e.g. a couple of weeks. Then after that we make it a hard requirement.\r\n* Send an email to the ciao mailing list about the upcoming requirement for the storage configuration entry.\r\n* keyringPath should be set to the default value if we receive a \"\" string from the configuration server. And we should keep it like that for the long term.","created_at":"2016-08-25T16:33:25Z","updated_at":"2016-08-25T16:33:25Z","html_url":"https://github.com/01org/ciao/pull/488#discussion_r76278395","pull_request_url":"https://api.github.com/repos/01org/ciao/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments/76278395"},"html":{"href":"https://github.com/01org/ciao/pull/488#discussion_r76278395"},"pull_request":{"href":"https://api.github.com/repos/01org/ciao/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/488","id":82615225,"html_url":"https://github.com/01org/ciao/pull/488","diff_url":"https://github.com/01org/ciao/pull/488.diff","patch_url":"https://github.com/01org/ciao/pull/488.patch","issue_url":"https://api.github.com/repos/01org/ciao/issues/488","number":488,"state":"open","locked":false,"title":"Storage cluster config handling","user":{"login":"bryteise","id":15709,"avatar_url":"https://avatars.githubusercontent.com/u/15709?v=3","gravatar_id":"","url":"https://api.github.com/users/bryteise","html_url":"https://github.com/bryteise","followers_url":"https://api.github.com/users/bryteise/followers","following_url":"https://api.github.com/users/bryteise/following{/other_user}","gists_url":"https://api.github.com/users/bryteise/gists{/gist_id}","starred_url":"https://api.github.com/users/bryteise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryteise/subscriptions","organizations_url":"https://api.github.com/users/bryteise/orgs","repos_url":"https://api.github.com/users/bryteise/repos","events_url":"https://api.github.com/users/bryteise/events{/privacy}","received_events_url":"https://api.github.com/users/bryteise/received_events","type":"User","site_admin":false},"body":"Add storage cluster configuration module that adds CephDriver fields for the storage url and cephx secrets to be passed from the ssntp configuration frame.\r\n\r\nThis address #462 and partially #388.","created_at":"2016-08-24T20:51:58Z","updated_at":"2016-08-25T16:33:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4d03995c75e998b373fdffb006310559fbfac2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/ciao/pulls/488/commits","review_comments_url":"https://api.github.com/repos/01org/ciao/pulls/488/comments","review_comment_url":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/ciao/issues/488/comments","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/b9bceca1f50b7036492bb7fa742f59d1b5b555ca","head":{"label":"bryteise:storage-driver-config","ref":"storage-driver-config","sha":"b9bceca1f50b7036492bb7fa742f59d1b5b555ca","user":{"login":"bryteise","id":15709,"avatar_url":"https://avatars.githubusercontent.com/u/15709?v=3","gravatar_id":"","url":"https://api.github.com/users/bryteise","html_url":"https://github.com/bryteise","followers_url":"https://api.github.com/users/bryteise/followers","following_url":"https://api.github.com/users/bryteise/following{/other_user}","gists_url":"https://api.github.com/users/bryteise/gists{/gist_id}","starred_url":"https://api.github.com/users/bryteise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryteise/subscriptions","organizations_url":"https://api.github.com/users/bryteise/orgs","repos_url":"https://api.github.com/users/bryteise/repos","events_url":"https://api.github.com/users/bryteise/events{/privacy}","received_events_url":"https://api.github.com/users/bryteise/received_events","type":"User","site_admin":false},"repo":{"id":66491755,"name":"ciao","full_name":"bryteise/ciao","owner":{"login":"bryteise","id":15709,"avatar_url":"https://avatars.githubusercontent.com/u/15709?v=3","gravatar_id":"","url":"https://api.github.com/users/bryteise","html_url":"https://github.com/bryteise","followers_url":"https://api.github.com/users/bryteise/followers","following_url":"https://api.github.com/users/bryteise/following{/other_user}","gists_url":"https://api.github.com/users/bryteise/gists{/gist_id}","starred_url":"https://api.github.com/users/bryteise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryteise/subscriptions","organizations_url":"https://api.github.com/users/bryteise/orgs","repos_url":"https://api.github.com/users/bryteise/repos","events_url":"https://api.github.com/users/bryteise/events{/privacy}","received_events_url":"https://api.github.com/users/bryteise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryteise/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":true,"url":"https://api.github.com/repos/bryteise/ciao","forks_url":"https://api.github.com/repos/bryteise/ciao/forks","keys_url":"https://api.github.com/repos/bryteise/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryteise/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryteise/ciao/teams","hooks_url":"https://api.github.com/repos/bryteise/ciao/hooks","issue_events_url":"https://api.github.com/repos/bryteise/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/bryteise/ciao/events","assignees_url":"https://api.github.com/repos/bryteise/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/bryteise/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/bryteise/ciao/tags","blobs_url":"https://api.github.com/repos/bryteise/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryteise/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryteise/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryteise/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryteise/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/bryteise/ciao/languages","stargazers_url":"https://api.github.com/repos/bryteise/ciao/stargazers","contributors_url":"https://api.github.com/repos/bryteise/ciao/contributors","subscribers_url":"https://api.github.com/repos/bryteise/ciao/subscribers","subscription_url":"https://api.github.com/repos/bryteise/ciao/subscription","commits_url":"https://api.github.com/repos/bryteise/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryteise/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryteise/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryteise/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryteise/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/bryteise/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryteise/ciao/merges","archive_url":"https://api.github.com/repos/bryteise/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryteise/ciao/downloads","issues_url":"https://api.github.com/repos/bryteise/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/bryteise/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/bryteise/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/bryteise/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryteise/ciao/labels{/name}","releases_url":"https://api.github.com/repos/bryteise/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/bryteise/ciao/deployments","created_at":"2016-08-24T19:05:18Z","updated_at":"2016-08-24T19:05:20Z","pushed_at":"2016-08-24T20:20:33Z","git_url":"git://github.com/bryteise/ciao.git","ssh_url":"git@github.com:bryteise/ciao.git","clone_url":"https://github.com/bryteise/ciao.git","svn_url":"https://github.com/bryteise/ciao","homepage":"","size":6926,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:kaccardi/topic/storage","ref":"kaccardi/topic/storage","sha":"1deb0170e8b4fac0514c84245ef0039d5120e089","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"01org/ciao","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/01org/ciao","forks_url":"https://api.github.com/repos/01org/ciao/forks","keys_url":"https://api.github.com/repos/01org/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/ciao/teams","hooks_url":"https://api.github.com/repos/01org/ciao/hooks","issue_events_url":"https://api.github.com/repos/01org/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/01org/ciao/events","assignees_url":"https://api.github.com/repos/01org/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/01org/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/01org/ciao/tags","blobs_url":"https://api.github.com/repos/01org/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/ciao/languages","stargazers_url":"https://api.github.com/repos/01org/ciao/stargazers","contributors_url":"https://api.github.com/repos/01org/ciao/contributors","subscribers_url":"https://api.github.com/repos/01org/ciao/subscribers","subscription_url":"https://api.github.com/repos/01org/ciao/subscription","commits_url":"https://api.github.com/repos/01org/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/01org/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/ciao/merges","archive_url":"https://api.github.com/repos/01org/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/ciao/downloads","issues_url":"https://api.github.com/repos/01org/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/01org/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/ciao/labels{/name}","releases_url":"https://api.github.com/repos/01org/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/01org/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2016-08-24T21:05:23Z","pushed_at":"2016-08-25T16:16:48Z","git_url":"git://github.com/01org/ciao.git","ssh_url":"git@github.com:01org/ciao.git","clone_url":"https://github.com/01org/ciao.git","svn_url":"https://github.com/01org/ciao","homepage":"","size":7081,"stargazers_count":112,"watchers_count":112,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":147,"forks":26,"open_issues":147,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/488"},"html":{"href":"https://github.com/01org/ciao/pull/488"},"issue":{"href":"https://api.github.com/repos/01org/ciao/issues/488"},"comments":{"href":"https://api.github.com/repos/01org/ciao/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/ciao/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/ciao/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/01org/ciao/statuses/b9bceca1f50b7036492bb7fa742f59d1b5b555ca"}}}}
{"actor":{"display_login":"sameo"}}