{"action":"created","issue":{"url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/161","repository_url":"https://api.github.com/repos/savaslabs/savaslabs.github.io","labels_url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/161/comments","events_url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/161/events","html_url":"https://github.com/savaslabs/savaslabs.github.io/pull/161","id":174076075,"number":161,"title":"[Such WIP] Issue #1297: Add gulp and optimize assets","user":{"login":"AnneTee","id":8465998,"avatar_url":"https://avatars.githubusercontent.com/u/8465998?v=3","gravatar_id":"","url":"https://api.github.com/users/AnneTee","html_url":"https://github.com/AnneTee","followers_url":"https://api.github.com/users/AnneTee/followers","following_url":"https://api.github.com/users/AnneTee/following{/other_user}","gists_url":"https://api.github.com/users/AnneTee/gists{/gist_id}","starred_url":"https://api.github.com/users/AnneTee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnneTee/subscriptions","organizations_url":"https://api.github.com/users/AnneTee/orgs","repos_url":"https://api.github.com/users/AnneTee/repos","events_url":"https://api.github.com/users/AnneTee/events{/privacy}","received_events_url":"https://api.github.com/users/AnneTee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kostajh","id":208893,"avatar_url":"https://avatars.githubusercontent.com/u/208893?v=3","gravatar_id":"","url":"https://api.github.com/users/kostajh","html_url":"https://github.com/kostajh","followers_url":"https://api.github.com/users/kostajh/followers","following_url":"https://api.github.com/users/kostajh/following{/other_user}","gists_url":"https://api.github.com/users/kostajh/gists{/gist_id}","starred_url":"https://api.github.com/users/kostajh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostajh/subscriptions","organizations_url":"https://api.github.com/users/kostajh/orgs","repos_url":"https://api.github.com/users/kostajh/repos","events_url":"https://api.github.com/users/kostajh/events{/privacy}","received_events_url":"https://api.github.com/users/kostajh/received_events","type":"User","site_admin":false},"assignees":[{"login":"kostajh","id":208893,"avatar_url":"https://avatars.githubusercontent.com/u/208893?v=3","gravatar_id":"","url":"https://api.github.com/users/kostajh","html_url":"https://github.com/kostajh","followers_url":"https://api.github.com/users/kostajh/followers","following_url":"https://api.github.com/users/kostajh/following{/other_user}","gists_url":"https://api.github.com/users/kostajh/gists{/gist_id}","starred_url":"https://api.github.com/users/kostajh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostajh/subscriptions","organizations_url":"https://api.github.com/users/kostajh/orgs","repos_url":"https://api.github.com/users/kostajh/repos","events_url":"https://api.github.com/users/kostajh/events{/privacy}","received_events_url":"https://api.github.com/users/kostajh/received_events","type":"User","site_admin":false},{"login":"timstallmann","id":6741938,"avatar_url":"https://avatars.githubusercontent.com/u/6741938?v=3","gravatar_id":"","url":"https://api.github.com/users/timstallmann","html_url":"https://github.com/timstallmann","followers_url":"https://api.github.com/users/timstallmann/followers","following_url":"https://api.github.com/users/timstallmann/following{/other_user}","gists_url":"https://api.github.com/users/timstallmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timstallmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstallmann/subscriptions","organizations_url":"https://api.github.com/users/timstallmann/orgs","repos_url":"https://api.github.com/users/timstallmann/repos","events_url":"https://api.github.com/users/timstallmann/events{/privacy}","received_events_url":"https://api.github.com/users/timstallmann/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-30T17:19:45Z","updated_at":"2016-08-30T18:25:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/pulls/161","html_url":"https://github.com/savaslabs/savaslabs.github.io/pull/161","diff_url":"https://github.com/savaslabs/savaslabs.github.io/pull/161.diff","patch_url":"https://github.com/savaslabs/savaslabs.github.io/pull/161.patch"},"body":"This is becoming a beast of a branch so I'm opening a PR here for the addition of gulp to our site's build/serve processes (#2136). This also includes #1649, minifying CSS and concatenating/uglifying JS. I'm planning on opening a separate PR for #1647 and #1648 (optimizing images automatically and manually optimizing our current images, respectively), either against this branch or against source if this gets merged in first.\r\n\r\n**To do:** Get Travis to build site using gulp.\r\n\r\n## To test\r\n\r\nFollow the instructions in the README to install node modules and serve the site using gulp. Try running the test script, too.\r\n\r\n## To note\r\n\r\nThe `assets` directory was moved to `_assets`. When building the site, gulp creates a git-ignored directory called `assets` with the generated files. This is so when gulp watch detects a change to a non-asset file (HTML, markdown, yml, etc.) and the `jekyll build` process is run, jekyll will copy the `assets` directory. If we weren't doing this, `jekyll build`, which wipes the `_site` directory, would delete all the asset files and not regenerate them.\r\n\r\n## Further things we could do when we have the time\r\n\r\n- Allow devs to add a `--drafts` tag to the `gulp serve` command to publish drafts\r\n- Place scripts at the end of the HTML body\r\n- Inline critical CSS"},"comment":{"url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/comments/243533727","html_url":"https://github.com/savaslabs/savaslabs.github.io/pull/161#issuecomment-243533727","issue_url":"https://api.github.com/repos/savaslabs/savaslabs.github.io/issues/161","id":243533727,"user":{"login":"AnneTee","id":8465998,"avatar_url":"https://avatars.githubusercontent.com/u/8465998?v=3","gravatar_id":"","url":"https://api.github.com/users/AnneTee","html_url":"https://github.com/AnneTee","followers_url":"https://api.github.com/users/AnneTee/followers","following_url":"https://api.github.com/users/AnneTee/following{/other_user}","gists_url":"https://api.github.com/users/AnneTee/gists{/gist_id}","starred_url":"https://api.github.com/users/AnneTee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnneTee/subscriptions","organizations_url":"https://api.github.com/users/AnneTee/orgs","repos_url":"https://api.github.com/users/AnneTee/repos","events_url":"https://api.github.com/users/AnneTee/events{/privacy}","received_events_url":"https://api.github.com/users/AnneTee/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T18:25:58Z","updated_at":"2016-08-30T18:25:58Z","body":"@timstallmann Yay!!! Thanks for the tip, I'll make that update "}}
{"actor":{"display_login":"AnneTee"}}