{"action":"created","comment":{"url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments/77438528","id":77438528,"diff_hunk":"@@ -0,0 +1,28 @@\n+---\n+-- Used to generate unique identifier for specified node data.\n+--\n+HarvestNodeIdGenerator = {}\n+\n+--- Creates an instance of generator.\n+--\n+function HarvestNodeIdGenerator:new()\n+    local instance = {}\n+    self.__index = self\n+    setmetatable(instance, self)\n+    return instance\n+end\n+\n+--- Generates unique identifier for specified node data.\n+-- @param type type of node - typeId.\n+-- @param timestamp timestamp for tracking of age.\n+-- @param x local abscissa of node.\n+-- @param y local ordinate of node.\n+-- @param xg global abscissa of node.\n+-- @param yg global ordinate of node.\n+-- @param item item which found inside\n+-- @return unique identifier. !!!NOTE!!!: Not number, but string.\n+--\n+function HarvestNodeIdGenerator:generate(type, timestamp, x, y, xg, yg, item)","path":"HarvestMap/NodesCache/NodeIdGenerator.lua","position":25,"original_position":25,"commit_id":"a812f36b4b20a96adb53ae0a653550ad4cc19001","original_commit_id":"a812f36b4b20a96adb53ae0a653550ad4cc19001","user":{"login":"Binaryvector","id":5149088,"avatar_url":"https://avatars.githubusercontent.com/u/5149088?v=3","gravatar_id":"","url":"https://api.github.com/users/Binaryvector","html_url":"https://github.com/Binaryvector","followers_url":"https://api.github.com/users/Binaryvector/followers","following_url":"https://api.github.com/users/Binaryvector/following{/other_user}","gists_url":"https://api.github.com/users/Binaryvector/gists{/gist_id}","starred_url":"https://api.github.com/users/Binaryvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Binaryvector/subscriptions","organizations_url":"https://api.github.com/users/Binaryvector/orgs","repos_url":"https://api.github.com/users/Binaryvector/repos","events_url":"https://api.github.com/users/Binaryvector/events{/privacy}","received_events_url":"https://api.github.com/users/Binaryvector/received_events","type":"User","site_admin":false},"body":"If that unique key needs more memory than we save by structuring the data from {x, y, ...} to x = { ...} y = { ... }, then theres no point in restructuring the data.\r\n\r\nThe memory we gain from restructuring the data is probably really small. The pdf you posted in the chat ( https://www.lua.org/gems/sample.pdf ) had a million {x = number, y = number} tuples and restructuring those to x = { ... } y = { ... } saved only 70kb. They saved less than a byte per tuple. So if you have to generate a key that isn't an already existing string, then you probably won't save any memory from restructuring.","created_at":"2016-09-03T15:51:13Z","updated_at":"2016-09-03T15:51:13Z","html_url":"https://github.com/Binaryvector/HarvestMap/pull/4#discussion_r77438528","pull_request_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments/77438528"},"html":{"href":"https://github.com/Binaryvector/HarvestMap/pull/4#discussion_r77438528"},"pull_request":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4","id":83649910,"html_url":"https://github.com/Binaryvector/HarvestMap/pull/4","diff_url":"https://github.com/Binaryvector/HarvestMap/pull/4.diff","patch_url":"https://github.com/Binaryvector/HarvestMap/pull/4.patch","issue_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/4","number":4,"state":"open","locked":false,"title":"Just an example how we can work with events and splitted entities.","user":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"body":"Raw example of my vision, how it could be. Comment please","created_at":"2016-09-01T15:04:18Z","updated_at":"2016-09-03T15:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d4f990af4a0208b775351115826ea0b7b756609","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/4/comments","statuses_url":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/a812f36b4b20a96adb53ae0a653550ad4cc19001","head":{"label":"MrUpyachka:indev","ref":"indev","sha":"a812f36b4b20a96adb53ae0a653550ad4cc19001","user":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"repo":{"id":66851527,"name":"HarvestMap","full_name":"MrUpyachka/HarvestMap","owner":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrUpyachka/HarvestMap","description":null,"fork":true,"url":"https://api.github.com/repos/MrUpyachka/HarvestMap","forks_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/forks","keys_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/teams","hooks_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/hooks","issue_events_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues/events{/number}","events_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/events","assignees_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/assignees{/user}","branches_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/branches{/branch}","tags_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/tags","blobs_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/statuses/{sha}","languages_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/languages","stargazers_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/stargazers","contributors_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/contributors","subscribers_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/subscribers","subscription_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/subscription","commits_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/contents/{+path}","compare_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/merges","archive_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/downloads","issues_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues{/number}","pulls_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/pulls{/number}","milestones_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/milestones{/number}","notifications_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/labels{/name}","releases_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/releases{/id}","deployments_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/deployments","created_at":"2016-08-29T14:33:52Z","updated_at":"2016-08-29T14:33:54Z","pushed_at":"2016-09-02T19:49:43Z","git_url":"git://github.com/MrUpyachka/HarvestMap.git","ssh_url":"git@github.com:MrUpyachka/HarvestMap.git","clone_url":"https://github.com/MrUpyachka/HarvestMap.git","svn_url":"https://github.com/MrUpyachka/HarvestMap","homepage":"http://www.esoui.com/downloads/fileinfo.php?id=57","size":429,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Binaryvector:indev","ref":"indev","sha":"8a8c8d0c50283fe7595849fdf735fce1c7705c02","user":{"login":"Binaryvector","id":5149088,"avatar_url":"https://avatars.githubusercontent.com/u/5149088?v=3","gravatar_id":"","url":"https://api.github.com/users/Binaryvector","html_url":"https://github.com/Binaryvector","followers_url":"https://api.github.com/users/Binaryvector/followers","following_url":"https://api.github.com/users/Binaryvector/following{/other_user}","gists_url":"https://api.github.com/users/Binaryvector/gists{/gist_id}","starred_url":"https://api.github.com/users/Binaryvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Binaryvector/subscriptions","organizations_url":"https://api.github.com/users/Binaryvector/orgs","repos_url":"https://api.github.com/users/Binaryvector/repos","events_url":"https://api.github.com/users/Binaryvector/events{/privacy}","received_events_url":"https://api.github.com/users/Binaryvector/received_events","type":"User","site_admin":false},"repo":{"id":66766330,"name":"HarvestMap","full_name":"Binaryvector/HarvestMap","owner":{"login":"Binaryvector","id":5149088,"avatar_url":"https://avatars.githubusercontent.com/u/5149088?v=3","gravatar_id":"","url":"https://api.github.com/users/Binaryvector","html_url":"https://github.com/Binaryvector","followers_url":"https://api.github.com/users/Binaryvector/followers","following_url":"https://api.github.com/users/Binaryvector/following{/other_user}","gists_url":"https://api.github.com/users/Binaryvector/gists{/gist_id}","starred_url":"https://api.github.com/users/Binaryvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Binaryvector/subscriptions","organizations_url":"https://api.github.com/users/Binaryvector/orgs","repos_url":"https://api.github.com/users/Binaryvector/repos","events_url":"https://api.github.com/users/Binaryvector/events{/privacy}","received_events_url":"https://api.github.com/users/Binaryvector/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Binaryvector/HarvestMap","description":null,"fork":false,"url":"https://api.github.com/repos/Binaryvector/HarvestMap","forks_url":"https://api.github.com/repos/Binaryvector/HarvestMap/forks","keys_url":"https://api.github.com/repos/Binaryvector/HarvestMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Binaryvector/HarvestMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Binaryvector/HarvestMap/teams","hooks_url":"https://api.github.com/repos/Binaryvector/HarvestMap/hooks","issue_events_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/events{/number}","events_url":"https://api.github.com/repos/Binaryvector/HarvestMap/events","assignees_url":"https://api.github.com/repos/Binaryvector/HarvestMap/assignees{/user}","branches_url":"https://api.github.com/repos/Binaryvector/HarvestMap/branches{/branch}","tags_url":"https://api.github.com/repos/Binaryvector/HarvestMap/tags","blobs_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/{sha}","languages_url":"https://api.github.com/repos/Binaryvector/HarvestMap/languages","stargazers_url":"https://api.github.com/repos/Binaryvector/HarvestMap/stargazers","contributors_url":"https://api.github.com/repos/Binaryvector/HarvestMap/contributors","subscribers_url":"https://api.github.com/repos/Binaryvector/HarvestMap/subscribers","subscription_url":"https://api.github.com/repos/Binaryvector/HarvestMap/subscription","commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Binaryvector/HarvestMap/contents/{+path}","compare_url":"https://api.github.com/repos/Binaryvector/HarvestMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Binaryvector/HarvestMap/merges","archive_url":"https://api.github.com/repos/Binaryvector/HarvestMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Binaryvector/HarvestMap/downloads","issues_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues{/number}","pulls_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls{/number}","milestones_url":"https://api.github.com/repos/Binaryvector/HarvestMap/milestones{/number}","notifications_url":"https://api.github.com/repos/Binaryvector/HarvestMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Binaryvector/HarvestMap/labels{/name}","releases_url":"https://api.github.com/repos/Binaryvector/HarvestMap/releases{/id}","deployments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/deployments","created_at":"2016-08-28T12:11:54Z","updated_at":"2016-08-28T19:03:54Z","pushed_at":"2016-09-03T13:49:37Z","git_url":"git://github.com/Binaryvector/HarvestMap.git","ssh_url":"git@github.com:Binaryvector/HarvestMap.git","clone_url":"https://github.com/Binaryvector/HarvestMap.git","svn_url":"https://github.com/Binaryvector/HarvestMap","homepage":"http://www.esoui.com/downloads/fileinfo.php?id=57","size":532,"stargazers_count":1,"watchers_count":1,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4"},"html":{"href":"https://github.com/Binaryvector/HarvestMap/pull/4"},"issue":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/4"},"comments":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/a812f36b4b20a96adb53ae0a653550ad4cc19001"}}}}
{"actor":{"display_login":"Binaryvector"}}