{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/91823013","pull_request_review_id":12335968,"id":91823013,"diff_hunk":"@@ -768,8 +768,46 @@ newDF <- createDataFrame(data.frame(x = c(1.5, 3.2)))\n head(predict(isoregModel, newDF))\n ```\n \n-#### What's More?\n-We also expect Decision Tree, Random Forest, Kolmogorov-Smirnov Test coming in the next version 2.1.0.\n+### Logistic Regression Model\n+\n+(Added in 2.1.0)\n+\n+[Logistic regression](https://en.wikipedia.org/wiki/Logistic_regression) is a widely-used model when the response is categorical. It can be seen as a special case of the [Generalized Linear Model](https://en.wikipedia.org/wiki/Generalized_linear_model).\n+There are two types of logistic regression models, namely binomial logistic regression (i.e., response is binary) and multinomial\n+logistic regression (i.e., response falls into multiple classes). We provide `spark.logit` on top of `spark.glm` to support logistic regression with advanced hyper-parameters.\n+It supports both binary and multiclass classification, elastic-net regularization, and feature standardization, similar to `glmnet`.\n+\n+\n+`spark.logit` fits an Logistic Regression Model against a Spark DataFrame. The `family` parameter can be used to select between the\n+binomial and multinomial algorithms, or leave it unset and Spark will infer the correct variant.\n+\n+We use a simple example to demonstrate `spark.logit` usage. In general, there are three steps of using `spark.logit`:\n+1). Create a dataframe from proper data source; 2). Fit a logistic regression model using `spark.logit` with a proper parameter setting;\n+and 3). Obtain the coefficient matrix of the fitted model using `summary` and use the model for prediction with `predict`.\n+\n+Binomial logistic regression\n+```{r, warning=FALSE}\n+df <- createDataFrame(iris)\n+# Create a dataframe containing two classes\n+training <- df[df$Species %in% c(\"versicolor\", \"virginica\"), ]\n+model <- spark.logit(training, Species ~ ., regParam = 0.5)\n+summary <- summary(model)","path":"R/pkg/vignettes/sparkr-vignettes.Rmd","position":74,"original_position":74,"commit_id":"070d7fef6959f10238f288c5f677664bb20fe984","original_commit_id":"e7c424a3c1fe6753b208928842874cf2208bbe27","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"Unfortunately, we didn't implement `print.summary`. If `summary(model)` is still somewhat human-readable, we should use it. Once we implemented `print.summary`, we don't need to change code here.","created_at":"2016-12-10T01:01:55Z","updated_at":"2016-12-10T01:08:59Z","html_url":"https://github.com/apache/spark/pull/16222#discussion_r91823013","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16222","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/91823013"},"html":{"href":"https://github.com/apache/spark/pull/16222#discussion_r91823013"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16222"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16222","id":97223854,"html_url":"https://github.com/apache/spark/pull/16222","diff_url":"https://github.com/apache/spark/pull/16222.diff","patch_url":"https://github.com/apache/spark/pull/16222.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16222","number":16222,"state":"open","locked":false,"title":"[SPARK-18797][SparkR]:Update spark.logit in sparkr-vignettes","user":{"login":"wangmiao1981","id":5033592,"avatar_url":"https://avatars.githubusercontent.com/u/5033592?v=3","gravatar_id":"","url":"https://api.github.com/users/wangmiao1981","html_url":"https://github.com/wangmiao1981","followers_url":"https://api.github.com/users/wangmiao1981/followers","following_url":"https://api.github.com/users/wangmiao1981/following{/other_user}","gists_url":"https://api.github.com/users/wangmiao1981/gists{/gist_id}","starred_url":"https://api.github.com/users/wangmiao1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangmiao1981/subscriptions","organizations_url":"https://api.github.com/users/wangmiao1981/orgs","repos_url":"https://api.github.com/users/wangmiao1981/repos","events_url":"https://api.github.com/users/wangmiao1981/events{/privacy}","received_events_url":"https://api.github.com/users/wangmiao1981/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nspark.logit is added in 2.1. We need to update spark-vignettes to reflect the changes. This is part of SparkR QA work.\r\n\r\n## How was this patch tested?\r\n\r\nManual build html. Please see attached image for the result.\r\n![test](https://cloud.githubusercontent.com/assets/5033592/21032237/01b565fe-bd5d-11e6-8b59-4de4b6ef611d.jpeg)\r\n\r\n\r\n","created_at":"2016-12-08T23:43:12Z","updated_at":"2016-12-10T01:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf11833f144f0846b16ac5f12acccf1302ee14e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16222/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16222/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16222/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/070d7fef6959f10238f288c5f677664bb20fe984","head":{"label":"wangmiao1981:veg","ref":"veg","sha":"070d7fef6959f10238f288c5f677664bb20fe984","user":{"login":"wangmiao1981","id":5033592,"avatar_url":"https://avatars.githubusercontent.com/u/5033592?v=3","gravatar_id":"","url":"https://api.github.com/users/wangmiao1981","html_url":"https://github.com/wangmiao1981","followers_url":"https://api.github.com/users/wangmiao1981/followers","following_url":"https://api.github.com/users/wangmiao1981/following{/other_user}","gists_url":"https://api.github.com/users/wangmiao1981/gists{/gist_id}","starred_url":"https://api.github.com/users/wangmiao1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangmiao1981/subscriptions","organizations_url":"https://api.github.com/users/wangmiao1981/orgs","repos_url":"https://api.github.com/users/wangmiao1981/repos","events_url":"https://api.github.com/users/wangmiao1981/events{/privacy}","received_events_url":"https://api.github.com/users/wangmiao1981/received_events","type":"User","site_admin":false},"repo":{"id":41932153,"name":"spark","full_name":"wangmiao1981/spark","owner":{"login":"wangmiao1981","id":5033592,"avatar_url":"https://avatars.githubusercontent.com/u/5033592?v=3","gravatar_id":"","url":"https://api.github.com/users/wangmiao1981","html_url":"https://github.com/wangmiao1981","followers_url":"https://api.github.com/users/wangmiao1981/followers","following_url":"https://api.github.com/users/wangmiao1981/following{/other_user}","gists_url":"https://api.github.com/users/wangmiao1981/gists{/gist_id}","starred_url":"https://api.github.com/users/wangmiao1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangmiao1981/subscriptions","organizations_url":"https://api.github.com/users/wangmiao1981/orgs","repos_url":"https://api.github.com/users/wangmiao1981/repos","events_url":"https://api.github.com/users/wangmiao1981/events{/privacy}","received_events_url":"https://api.github.com/users/wangmiao1981/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangmiao1981/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wangmiao1981/spark","forks_url":"https://api.github.com/repos/wangmiao1981/spark/forks","keys_url":"https://api.github.com/repos/wangmiao1981/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangmiao1981/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangmiao1981/spark/teams","hooks_url":"https://api.github.com/repos/wangmiao1981/spark/hooks","issue_events_url":"https://api.github.com/repos/wangmiao1981/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wangmiao1981/spark/events","assignees_url":"https://api.github.com/repos/wangmiao1981/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wangmiao1981/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wangmiao1981/spark/tags","blobs_url":"https://api.github.com/repos/wangmiao1981/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangmiao1981/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangmiao1981/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangmiao1981/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangmiao1981/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wangmiao1981/spark/languages","stargazers_url":"https://api.github.com/repos/wangmiao1981/spark/stargazers","contributors_url":"https://api.github.com/repos/wangmiao1981/spark/contributors","subscribers_url":"https://api.github.com/repos/wangmiao1981/spark/subscribers","subscription_url":"https://api.github.com/repos/wangmiao1981/spark/subscription","commits_url":"https://api.github.com/repos/wangmiao1981/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangmiao1981/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangmiao1981/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangmiao1981/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangmiao1981/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wangmiao1981/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangmiao1981/spark/merges","archive_url":"https://api.github.com/repos/wangmiao1981/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangmiao1981/spark/downloads","issues_url":"https://api.github.com/repos/wangmiao1981/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wangmiao1981/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wangmiao1981/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wangmiao1981/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangmiao1981/spark/labels{/name}","releases_url":"https://api.github.com/repos/wangmiao1981/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wangmiao1981/spark/deployments","created_at":"2015-09-04T18:38:32Z","updated_at":"2016-01-19T18:24:03Z","pushed_at":"2016-12-10T01:04:52Z","git_url":"git://github.com/wangmiao1981/spark.git","ssh_url":"git@github.com:wangmiao1981/spark.git","clone_url":"https://github.com/wangmiao1981/spark.git","svn_url":"https://github.com/wangmiao1981/spark","homepage":null,"size":245418,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"202fcd21ce01393fa6dfaa1c2126e18e9b85ee96","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-12-10T00:31:14Z","pushed_at":"2016-12-10T01:04:54Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":621968,"stargazers_count":11022,"watchers_count":11022,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10311,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":451,"forks":10311,"open_issues":451,"watchers":11022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16222"},"html":{"href":"https://github.com/apache/spark/pull/16222"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16222"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16222/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16222/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16222/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/070d7fef6959f10238f288c5f677664bb20fe984"}}}}
{"actor":{"display_login":"mengxr"}}