{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/57455036","id":57455036,"diff_hunk":"@@ -293,6 +293,7 @@ struct loader_instance {\n \n     bool debug_report_enabled;\n     VkLayerDbgFunctionNode *DbgFunctionHead;\n+    VkDebugReportCallbackCreateInfoEXT *pDebugReportCreateInfo;","path":"loader/loader.h","position":4,"original_position":4,"commit_id":"98e77425930764def84c901b1b474c4d845e6609","original_commit_id":"98e77425930764def84c901b1b474c4d845e6609","user":{"login":"courtney-g","id":851793,"avatar_url":"https://avatars.githubusercontent.com/u/851793?v=3","gravatar_id":"","url":"https://api.github.com/users/courtney-g","html_url":"https://github.com/courtney-g","followers_url":"https://api.github.com/users/courtney-g/followers","following_url":"https://api.github.com/users/courtney-g/following{/other_user}","gists_url":"https://api.github.com/users/courtney-g/gists{/gist_id}","starred_url":"https://api.github.com/users/courtney-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtney-g/subscriptions","organizations_url":"https://api.github.com/users/courtney-g/orgs","repos_url":"https://api.github.com/users/courtney-g/repos","events_url":"https://api.github.com/users/courtney-g/events{/privacy}","received_events_url":"https://api.github.com/users/courtney-g/received_events","type":"User","site_admin":false},"body":"I think it would be a little better to avoid the malloc.\r\nJust make this a whole structure.\r\nCan use the sType as an indicator if there is something that should be enabled or not.","created_at":"2016-03-25T15:33:50Z","updated_at":"2016-03-25T15:33:50Z","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193#discussion_r57455036","pull_request_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/57455036"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193#discussion_r57455036"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193","id":64172670,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193","diff_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193.patch","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/193","number":193,"state":"open","locked":false,"title":"Temporary debug_report callback in VkDestroyInstance + Cube enables it","user":{"login":"ianelliottus","id":16325331,"avatar_url":"https://avatars.githubusercontent.com/u/16325331?v=3","gravatar_id":"","url":"https://api.github.com/users/ianelliottus","html_url":"https://github.com/ianelliottus","followers_url":"https://api.github.com/users/ianelliottus/followers","following_url":"https://api.github.com/users/ianelliottus/following{/other_user}","gists_url":"https://api.github.com/users/ianelliottus/gists{/gist_id}","starred_url":"https://api.github.com/users/ianelliottus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianelliottus/subscriptions","organizations_url":"https://api.github.com/users/ianelliottus/orgs","repos_url":"https://api.github.com/users/ianelliottus/repos","events_url":"https://api.github.com/users/ianelliottus/events{/privacy}","received_events_url":"https://api.github.com/users/ianelliottus/received_events","type":"User","site_admin":false},"body":"Courtney added the ability for a temporary callback to be created during vkCreateInstance, so that validation messages could be seen before the debug_report extension had been properly setup.  This pull request saves and reuses that for vkDestroyInstance, so that validation messages can be seen after debug_report is no longer setup.\r\n\r\nThis pull request also modifies the cube demo to call vkCreateInstance in such a manner that the temporary callback is setup in both vkCreateInstance and vkDestroyInstance.","created_at":"2016-03-25T15:23:00Z","updated_at":"2016-03-25T15:33:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcfe8e0c204e7ff67cce50d9979db587898166d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/193/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/98e77425930764def84c901b1b474c4d845e6609","head":{"label":"KhronosGroup:ian_160325_TempDbgCallback","ref":"ian_160325_TempDbgCallback","sha":"98e77425930764def84c901b1b474c4d845e6609","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-03-24T15:16:30Z","pushed_at":"2016-03-25T15:23:01Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":44693,"stargazers_count":150,"watchers_count":150,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":45,"forks":38,"open_issues":45,"watchers":150,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"885537d813d6fb3d199e76f6d63b6d3f78d0eeb0","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-03-24T15:16:30Z","pushed_at":"2016-03-25T15:23:01Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":44693,"stargazers_count":150,"watchers_count":150,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":45,"forks":38,"open_issues":45,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/193"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/193"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/98e77425930764def84c901b1b474c4d845e6609"}}}}