{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/1004","repository_url":"https://api.github.com/repos/svaarala/duktape","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/1004/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/1004/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/1004/events","html_url":"https://github.com/svaarala/duktape/pull/1004","id":181933437,"number":1004,"title":"Align Buffer.concat() behavior for one-element arrays with Node.js v6.7.0","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svaarala/duktape/labels/buffer","name":"buffer","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/5","html_url":"https://github.com/svaarala/duktape/milestones/v2.0.0","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/5/labels","id":840957,"number":5,"title":"v2.0.0","description":"","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":168,"state":"open","created_at":"2014-10-26T15:05:37Z","updated_at":"2016-10-10T10:39:47Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-10-10T03:51:02Z","updated_at":"2016-10-10T11:32:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/1004","html_url":"https://github.com/svaarala/duktape/pull/1004","diff_url":"https://github.com/svaarala/duktape/pull/1004.diff","patch_url":"https://github.com/svaarala/duktape/pull/1004.patch"},"body":"`Buffer.concat()` always returns a copy, even for an one-element array argument.\r\n\r\n- [x] Fix behavior\r\n- [ ] Fix testcases\r\n- [x] Migration notes\r\n- [x] Release notes"},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/252593877","html_url":"https://github.com/svaarala/duktape/pull/1004#issuecomment-252593877","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/1004","id":252593877,"user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T11:32:38Z","updated_at":"2016-10-10T11:32:38Z","body":"What I still find puzzling is the special handling for a zero length input but explicit totalLength:\r\n\r\n```\r\n$ nodejs\r\n> process.version\r\n'v6.7.0'\r\n> x = Buffer.concat([], 10)\r\n<Buffer >\r\n> x.length\r\n0\r\n> x = Buffer.concat([ new Buffer('') ], 10)\r\n<Buffer 00 00 00 00 00 00 00 00 00 00>\r\n> x.length\r\n10\r\n```\r\n\r\nBut I've kept that behavior because it's apparently intentional."}}
{"actor":{"display_login":"svaarala"}}