{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10895","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10895/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10895/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10895/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10895","id":174230208,"number":10895,"title":"[WIP] Topology cleanup","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/topology","name":"topology","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-31T09:48:03Z","updated_at":"2016-09-05T09:07:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10895","html_url":"https://github.com/ManageIQ/manageiq/pull/10895","diff_url":"https://github.com/ManageIQ/manageiq/pull/10895.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10895.patch"},"body":"Purpose or Intent\r\n-----------------\r\nDeduplicate and simplify topology code before adding more topology screens.\r\n\r\nSteps for Testing/QA\r\n--------------------\r\nGo to the topology screens (network, middleware, containers). Click around.\r\n\r\nTODO\r\n--------------------\r\n\r\n * The various `before/after_action` calls need deduplication.\r\n * `EmsContainerController` defines `generate_topology`, this is an anomaly compared to other topology screens. It would be better to follow a single pattern.\r\n * Ideally there would be only one topology controller. The code is pretty the same. The desired topology service can be passed in the URL and e.g. some route can place it in a variable.\r\n\r\nPing @himdel, @tzumainn, @abonas "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/244696888","html_url":"https://github.com/ManageIQ/manageiq/pull/10895#issuecomment-244696888","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10895","id":244696888,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T09:07:10Z","updated_at":"2016-09-05T09:07:10Z","body":"<rubocop />Checked commits https://github.com/martinpovolny/manageiq/compare/b377916876f50da95d486e7e6904032c240fc92e~...e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n12 files checked, 7 offenses detected\n\n**app/controllers/topology_controller.rb**\n- [ ] :exclamation: - [Line 44](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/controllers/topology_controller.rb#L44), Col 7 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n\n**app/models/mixins/ui_service_mixin.rb**\n- [ ] :grey_exclamation: - [Line 23](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L23), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [131/120]\n- [ ] :grey_exclamation: - [Line 24](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L24), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n- [ ] :grey_exclamation: - [Line 25](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L25), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [138/120]\n- [ ] :grey_exclamation: - [Line 26](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L26), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [130/120]\n- [ ] :grey_exclamation: - [Line 28](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L28), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [136/120]\n- [ ] :grey_exclamation: - [Line 29](https://github.com/martinpovolny/manageiq/blob/e56ed44e9ec98fd2bbe0ab7907ee057dd85394c1/app/models/mixins/ui_service_mixin.rb#L29), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [137/120]\n"}}
{"actor":{"display_login":"miq-bot"}}