{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4813","repository_url":"https://api.github.com/repos/Leaflet/Leaflet","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4813/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4813/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4813/events","html_url":"https://github.com/Leaflet/Leaflet/issues/4813","id":170784198,"number":4813,"title":".bindTooltip drawing tooltips without rounding on translate3d? Blurry bug again...","user":{"login":"futuretechmag","id":8509444,"avatar_url":"https://avatars.githubusercontent.com/u/8509444?v=3","gravatar_id":"","url":"https://api.github.com/users/futuretechmag","html_url":"https://github.com/futuretechmag","followers_url":"https://api.github.com/users/futuretechmag/followers","following_url":"https://api.github.com/users/futuretechmag/following{/other_user}","gists_url":"https://api.github.com/users/futuretechmag/gists{/gist_id}","starred_url":"https://api.github.com/users/futuretechmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futuretechmag/subscriptions","organizations_url":"https://api.github.com/users/futuretechmag/orgs","repos_url":"https://api.github.com/users/futuretechmag/repos","events_url":"https://api.github.com/users/futuretechmag/events{/privacy}","received_events_url":"https://api.github.com/users/futuretechmag/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Leaflet/Leaflet/labels/needs%20more%20info","name":"needs more info","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-12T01:47:21Z","updated_at":"2016-08-19T14:39:08Z","closed_at":null,"body":"leaflet.js version: \"1.0.0-rc.3+27f05a2\"\r\n\r\nTooltips were drawing half-pixel digits for the pos.x position (at least the only one it was doing it for me) so:\r\n\r\ntransform: translate3d(1024.5px, 359px, 0px); - was blurry\r\ntransform: translate3d(1024px, 359px, 0px); - was perfect (same with if I made it 1025px)\r\n\r\nSo, I hacked it (as in most likely not correct) line 1464 from:\r\n\r\n'translate3d(' + pos.x + 'px,' + pos.y + 'px,0)') +\r\n\r\n-to- \r\n\r\n'translate3d(' + Math.round(pos.x) + 'px,' + Math.round(pos.y) + 'px,0)') +\r\n\r\nAnd everything with my tooltips has been perfect."},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments/241036437","html_url":"https://github.com/Leaflet/Leaflet/issues/4813#issuecomment-241036437","issue_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/4813","id":241036437,"user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T14:39:08Z","updated_at":"2016-08-19T14:39:08Z","body":"> Can you explain (honestly, not being rude) why we need a fiddle?\r\n\r\nBecause the time of your beloved library maintainers is rare. So if you want them to help you, start by helping them.\r\nReporting an issue is nice. Reporting it with all the needed info for understanding it and fixing it is better. Doing a PR is even better.\r\nSee https://github.com/Leaflet/Leaflet/blob/master/CONTRIBUTING.md#reporting-bugs\r\nWe have *dozen* of examples of bug being reported being at then an issue on the user side (JS conflict, CSS conflict, buggish browser plugin, bad usage, etc.). I'm not saying that is the case here, but to be fair it's up to you to make the demonstration.\r\nRemember that we are at most five active maintainers, while people reporting issues are hundreds.\r\n\r\n> In my case, I've shown the line that caused the issue, with the replace line that fixes the issue.\r\n\r\nThat is not a fix. A fix is made in the src, not in the distributed files; tests should be ran without failures (and sometimes added); and a PR should be made.\r\nBTW, the line you are touching is impacting all Leaflet code, and adding a Math.round there is not without impact on performances, and can have a lot of side effects. The proper fix very luckily somewhere else (*if* this is an issue at all).\r\n\r\nSide note: writing \"blurry bug again…\" in an issue title *is* being rude."}}
{"actor":{"display_login":"yohanboniface"}}