{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/69172411","id":69172411,"diff_hunk":"@@ -1247,6 +1247,34 @@ fn confirm_callable_candidate<'cx, 'gcx, 'tcx>(\n                                               fn_sig,\n                                               flag);\n \n+    if selcx.projection_mode().is_any() {\n+        // Issue #33364: `ProjectionMode::Any` means trans, during\n+        // which there is no (good) reason for confirmation to fail\n+        // (because type check has already admitted the source code).","path":"src/librustc/traits/project.rs","position":7,"original_position":7,"commit_id":"99a44e653d0c0df83c9e1fd84fcfa5a285561d31","original_commit_id":"99a44e653d0c0df83c9e1fd84fcfa5a285561d31","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"That's not necessarily true if anything does probing (such as checking if a vtable needs to contain a specific method, based on where clauses of that method).","created_at":"2016-06-30T17:14:59Z","updated_at":"2016-06-30T17:14:59Z","html_url":"https://github.com/rust-lang/rust/pull/34573#discussion_r69172411","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/34573","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/69172411"},"html":{"href":"https://github.com/rust-lang/rust/pull/34573#discussion_r69172411"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34573"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/34573","id":75804570,"html_url":"https://github.com/rust-lang/rust/pull/34573","diff_url":"https://github.com/rust-lang/rust/pull/34573.diff","patch_url":"https://github.com/rust-lang/rust/pull/34573.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/34573","number":34573,"state":"open","locked":false,"title":"Fix ICE from #33364 by selectively skipping confirmation pass.","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"body":"Fix #33364: during trans, confirmation should never fail (because type check has already admitted the source code).\r\n\r\nSo skip confirmation in that context, unless there is some reason (i.e. unresolved unification variables, or a type undering a Binder for region variables) during projection of an associated item) that we still need to run it.","created_at":"2016-06-30T11:41:54Z","updated_at":"2016-06-30T17:14:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5678d15220ce8a80c26933f0b6a96e9060e5f0fa","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/34573/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/34573/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/34573/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/99a44e653d0c0df83c9e1fd84fcfa5a285561d31","head":{"label":"pnkfelix:redo-fix-33364","ref":"redo-fix-33364","sha":"99a44e653d0c0df83c9e1fd84fcfa5a285561d31","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"repo":{"id":7822507,"name":"rust","full_name":"pnkfelix/rust","owner":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnkfelix/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/pnkfelix/rust","forks_url":"https://api.github.com/repos/pnkfelix/rust/forks","keys_url":"https://api.github.com/repos/pnkfelix/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnkfelix/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnkfelix/rust/teams","hooks_url":"https://api.github.com/repos/pnkfelix/rust/hooks","issue_events_url":"https://api.github.com/repos/pnkfelix/rust/issues/events{/number}","events_url":"https://api.github.com/repos/pnkfelix/rust/events","assignees_url":"https://api.github.com/repos/pnkfelix/rust/assignees{/user}","branches_url":"https://api.github.com/repos/pnkfelix/rust/branches{/branch}","tags_url":"https://api.github.com/repos/pnkfelix/rust/tags","blobs_url":"https://api.github.com/repos/pnkfelix/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnkfelix/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnkfelix/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnkfelix/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnkfelix/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/pnkfelix/rust/languages","stargazers_url":"https://api.github.com/repos/pnkfelix/rust/stargazers","contributors_url":"https://api.github.com/repos/pnkfelix/rust/contributors","subscribers_url":"https://api.github.com/repos/pnkfelix/rust/subscribers","subscription_url":"https://api.github.com/repos/pnkfelix/rust/subscription","commits_url":"https://api.github.com/repos/pnkfelix/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnkfelix/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnkfelix/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnkfelix/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnkfelix/rust/contents/{+path}","compare_url":"https://api.github.com/repos/pnkfelix/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnkfelix/rust/merges","archive_url":"https://api.github.com/repos/pnkfelix/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnkfelix/rust/downloads","issues_url":"https://api.github.com/repos/pnkfelix/rust/issues{/number}","pulls_url":"https://api.github.com/repos/pnkfelix/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/pnkfelix/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/pnkfelix/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnkfelix/rust/labels{/name}","releases_url":"https://api.github.com/repos/pnkfelix/rust/releases{/id}","deployments_url":"https://api.github.com/repos/pnkfelix/rust/deployments","created_at":"2013-01-25T15:18:32Z","updated_at":"2014-06-24T13:41:54Z","pushed_at":"2016-06-30T12:14:32Z","git_url":"git://github.com/pnkfelix/rust.git","ssh_url":"git@github.com:pnkfelix/rust.git","clone_url":"https://github.com/pnkfelix/rust.git","svn_url":"https://github.com/pnkfelix/rust","homepage":"http://www.rust-lang.org","size":308468,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"c2b56fb7a0c24e04227318ca7e5950e9289ee3e4","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-06-30T16:03:28Z","pushed_at":"2016-06-30T17:02:16Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":515734,"stargazers_count":17283,"watchers_count":17283,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3293,"mirror_url":null,"open_issues_count":2591,"forks":3293,"open_issues":2591,"watchers":17283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34573"},"html":{"href":"https://github.com/rust-lang/rust/pull/34573"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34573"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34573/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34573/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34573/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/99a44e653d0c0df83c9e1fd84fcfa5a285561d31"}}}}
{"actor":{"display_login":"eddyb"}}