{"action":"created","issue":{"url":"https://api.github.com/repos/emoncms/dashboard/issues/47","repository_url":"https://api.github.com/repos/emoncms/dashboard","labels_url":"https://api.github.com/repos/emoncms/dashboard/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/emoncms/dashboard/issues/47/comments","events_url":"https://api.github.com/repos/emoncms/dashboard/issues/47/events","html_url":"https://github.com/emoncms/dashboard/pull/47","id":184243287,"number":47,"title":"Edit button reworked and double slash fixed","user":{"login":"firefox7518","id":12048408,"avatar_url":"https://avatars.githubusercontent.com/u/12048408?v=3","gravatar_id":"","url":"https://api.github.com/users/firefox7518","html_url":"https://github.com/firefox7518","followers_url":"https://api.github.com/users/firefox7518/followers","following_url":"https://api.github.com/users/firefox7518/following{/other_user}","gists_url":"https://api.github.com/users/firefox7518/gists{/gist_id}","starred_url":"https://api.github.com/users/firefox7518/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firefox7518/subscriptions","organizations_url":"https://api.github.com/users/firefox7518/orgs","repos_url":"https://api.github.com/users/firefox7518/repos","events_url":"https://api.github.com/users/firefox7518/events{/privacy}","received_events_url":"https://api.github.com/users/firefox7518/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-20T14:20:48Z","updated_at":"2016-10-21T09:56:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emoncms/dashboard/pulls/47","html_url":"https://github.com/emoncms/dashboard/pull/47","diff_url":"https://github.com/emoncms/dashboard/pull/47.diff","patch_url":"https://github.com/emoncms/dashboard/pull/47.patch"},"body":"Reworked edit button:\r\n- Flat style\r\n- Opacity 0.7 to help shine through stuff underneath\r\n- Invisible DIV around for moving it it still occupies something\r\n- Top right corner\r\n\r\nFixed double slashed when using the view button on the editor."},"comment":{"url":"https://api.github.com/repos/emoncms/dashboard/issues/comments/255341744","html_url":"https://github.com/emoncms/dashboard/pull/47#issuecomment-255341744","issue_url":"https://api.github.com/repos/emoncms/dashboard/issues/47","id":255341744,"user":{"login":"pb66","id":5606042,"avatar_url":"https://avatars.githubusercontent.com/u/5606042?v=3","gravatar_id":"","url":"https://api.github.com/users/pb66","html_url":"https://github.com/pb66","followers_url":"https://api.github.com/users/pb66/followers","following_url":"https://api.github.com/users/pb66/following{/other_user}","gists_url":"https://api.github.com/users/pb66/gists{/gist_id}","starred_url":"https://api.github.com/users/pb66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pb66/subscriptions","organizations_url":"https://api.github.com/users/pb66/orgs","repos_url":"https://api.github.com/users/pb66/repos","events_url":"https://api.github.com/users/pb66/events{/privacy}","received_events_url":"https://api.github.com/users/pb66/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T09:56:01Z","updated_at":"2016-10-21T09:56:01Z","body":"@firefox7518 - Andreas, I'm still don't understanding why you are so insistent on the almost solid button color, other than \"guidelines\".\r\n\r\nIF the button's background is almost solid then I guess you have a pretty good reason to have the button as small as possible, so it can still be clicked on a mobile, without it being annoying and also draggable because it is an obstruction.\r\n\r\nWhereas in contrast if the button's background was almost transparent then you could have the button larger without the need to move it, making it less obtrusive, easier to use and easier on the eye. I see no downside at all.\r\n\r\nPerhaps it strays slightly from these guidelines you refer to in some way, I cannot be sure but it would still be \r\n- clearly a button\r\n- the same size and shape as other buttons\r\n- grey background (albeit 0.1 opacity)\r\n- same icon size, colour and opacity\r\nso which guidelines does it break? not that it really matters they are only guidelines and a specific applications needs should always take president.\r\n\r\nI think it might be a good idea to try and limit the discussions on here to PR's and bug fixes etc, the styling and general development discussion should remain on the forum as it gets complicated with scattered discussions.\r\n\r\n@Paul - Don't worry about pulling in my PR it just complicates things, I had waited until you decided to pull in the previous days PR and didn't know Andreas was sitting on another unsubmitted PR, it doesn't really leave room other PR's. "}}
{"actor":{"display_login":"pb66"}}