{"action":"closed","number":566,"pull_request":{"url":"https://api.github.com/repos/twitter/algebird/pulls/566","id":90902196,"html_url":"https://github.com/twitter/algebird/pull/566","diff_url":"https://github.com/twitter/algebird/pull/566.diff","patch_url":"https://github.com/twitter/algebird/pull/566.patch","issue_url":"https://api.github.com/repos/twitter/algebird/issues/566","number":566,"state":"closed","locked":false,"title":"upgrade to new scalatest and scalacheck","user":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"body":"## Problem\r\nI'm trying to upgrade a monorepo to scalatest 3.x and scalacheck 1.13.1.  Because our repo depends on algebird-test, we now need a version of algebird that supports scalacheck 1.13.1.  This will also allow algebird to begin supporting 2.12, which should be released in the next few weeks.\r\n\r\n## Solution\r\nI'm cutting you over to scalatest 3.0.0 and scalacheck 1.13.1.  I tried only moving over scalacheck, but scalatest is compiled against a single version of scalacheck, and will break if you switch.\r\n\r\nSome of the Prop api has changed–NB that Prop is now sealed, so we need to use the Prop object to create a new Prop.\r\n\r\n## Other notable issues\r\nI've run into a problem with the Eventually tests that I'm not really equipped to solve.  It looks like algebird was using the Gen[A => B] implicit from scalacheck, but it used to be really dumb, and only supported constant functions.  It's [less dumb][0] now, which breaks this test.  I don't know how Eventually is actually supposed to behave, so I'd love some help from y'all.  I've enabled edits from maintainers, so please feel free to just fix it.\r\n\r\n## Protip\r\nThis change has a lot of whitespace changes–append ?w=1 to the url to ignore the whitespace changes.  Thanks!!!\r\n\r\n[0]: https://github.com/rickynils/scalacheck/pull/171","created_at":"2016-10-25T22:12:43Z","updated_at":"2016-10-27T01:10:37Z","closed_at":"2016-10-27T01:10:37Z","merged_at":null,"merge_commit_sha":"df135d3a21841f4058b3c41f66ba120302f9dfd1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/algebird/pulls/566/commits","review_comments_url":"https://api.github.com/repos/twitter/algebird/pulls/566/comments","review_comment_url":"https://api.github.com/repos/twitter/algebird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/algebird/issues/566/comments","statuses_url":"https://api.github.com/repos/twitter/algebird/statuses/6fb5fd5f1c1b1d8ae65a9b6c58a1ae1b86db34f8","head":{"label":"mosesn:mnakamura/scalacheck-bump-1.13.1","ref":"mnakamura/scalacheck-bump-1.13.1","sha":"6fb5fd5f1c1b1d8ae65a9b6c58a1ae1b86db34f8","user":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"repo":{"id":5557917,"name":"algebird","full_name":"mosesn/algebird","owner":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mosesn/algebird","description":"Abstract Algebra for Scala","fork":true,"url":"https://api.github.com/repos/mosesn/algebird","forks_url":"https://api.github.com/repos/mosesn/algebird/forks","keys_url":"https://api.github.com/repos/mosesn/algebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosesn/algebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosesn/algebird/teams","hooks_url":"https://api.github.com/repos/mosesn/algebird/hooks","issue_events_url":"https://api.github.com/repos/mosesn/algebird/issues/events{/number}","events_url":"https://api.github.com/repos/mosesn/algebird/events","assignees_url":"https://api.github.com/repos/mosesn/algebird/assignees{/user}","branches_url":"https://api.github.com/repos/mosesn/algebird/branches{/branch}","tags_url":"https://api.github.com/repos/mosesn/algebird/tags","blobs_url":"https://api.github.com/repos/mosesn/algebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosesn/algebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosesn/algebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosesn/algebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosesn/algebird/statuses/{sha}","languages_url":"https://api.github.com/repos/mosesn/algebird/languages","stargazers_url":"https://api.github.com/repos/mosesn/algebird/stargazers","contributors_url":"https://api.github.com/repos/mosesn/algebird/contributors","subscribers_url":"https://api.github.com/repos/mosesn/algebird/subscribers","subscription_url":"https://api.github.com/repos/mosesn/algebird/subscription","commits_url":"https://api.github.com/repos/mosesn/algebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosesn/algebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosesn/algebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosesn/algebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosesn/algebird/contents/{+path}","compare_url":"https://api.github.com/repos/mosesn/algebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosesn/algebird/merges","archive_url":"https://api.github.com/repos/mosesn/algebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosesn/algebird/downloads","issues_url":"https://api.github.com/repos/mosesn/algebird/issues{/number}","pulls_url":"https://api.github.com/repos/mosesn/algebird/pulls{/number}","milestones_url":"https://api.github.com/repos/mosesn/algebird/milestones{/number}","notifications_url":"https://api.github.com/repos/mosesn/algebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosesn/algebird/labels{/name}","releases_url":"https://api.github.com/repos/mosesn/algebird/releases{/id}","deployments_url":"https://api.github.com/repos/mosesn/algebird/deployments","created_at":"2012-08-26T06:18:51Z","updated_at":"2014-03-14T03:25:36Z","pushed_at":"2016-10-25T22:01:16Z","git_url":"git://github.com/mosesn/algebird.git","ssh_url":"git@github.com:mosesn/algebird.git","clone_url":"https://github.com/mosesn/algebird.git","svn_url":"https://github.com/mosesn/algebird","homepage":"https://twitter.com/scalding","size":2226,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"667c91419fcbd518e40b9fef13cc53c57c422bd9","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":5275507,"name":"algebird","full_name":"twitter/algebird","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/algebird","description":"Abstract Algebra for Scala","fork":false,"url":"https://api.github.com/repos/twitter/algebird","forks_url":"https://api.github.com/repos/twitter/algebird/forks","keys_url":"https://api.github.com/repos/twitter/algebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/algebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/algebird/teams","hooks_url":"https://api.github.com/repos/twitter/algebird/hooks","issue_events_url":"https://api.github.com/repos/twitter/algebird/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/algebird/events","assignees_url":"https://api.github.com/repos/twitter/algebird/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/algebird/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/algebird/tags","blobs_url":"https://api.github.com/repos/twitter/algebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/algebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/algebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/algebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/algebird/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/algebird/languages","stargazers_url":"https://api.github.com/repos/twitter/algebird/stargazers","contributors_url":"https://api.github.com/repos/twitter/algebird/contributors","subscribers_url":"https://api.github.com/repos/twitter/algebird/subscribers","subscription_url":"https://api.github.com/repos/twitter/algebird/subscription","commits_url":"https://api.github.com/repos/twitter/algebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/algebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/algebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/algebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/algebird/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/algebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/algebird/merges","archive_url":"https://api.github.com/repos/twitter/algebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/algebird/downloads","issues_url":"https://api.github.com/repos/twitter/algebird/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/algebird/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/algebird/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/algebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/algebird/labels{/name}","releases_url":"https://api.github.com/repos/twitter/algebird/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/algebird/deployments","created_at":"2012-08-02T17:24:42Z","updated_at":"2016-10-26T15:30:34Z","pushed_at":"2016-10-27T01:08:49Z","git_url":"git://github.com/twitter/algebird.git","ssh_url":"git@github.com:twitter/algebird.git","clone_url":"https://github.com/twitter/algebird.git","svn_url":"https://github.com/twitter/algebird","homepage":"https://twitter.com/scalding","size":5974,"stargazers_count":1351,"watchers_count":1351,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":213,"mirror_url":null,"open_issues_count":85,"forks":213,"open_issues":85,"watchers":1351,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/algebird/pulls/566"},"html":{"href":"https://github.com/twitter/algebird/pull/566"},"issue":{"href":"https://api.github.com/repos/twitter/algebird/issues/566"},"comments":{"href":"https://api.github.com/repos/twitter/algebird/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/algebird/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/algebird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/algebird/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/algebird/statuses/6fb5fd5f1c1b1d8ae65a9b6c58a1ae1b86db34f8"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":34,"deletions":36,"changed_files":2}}
{"actor":{"display_login":"johnynek"}}