{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/93029353","pull_request_review_id":13549310,"id":93029353,"diff_hunk":"@@ -39,7 +37,7 @@ export class <%=jhiPrefixCapitalized%>TrackerService {\n     connect () {\n         if (this.connectedPromise === null) this.connection = this.createConnection();\n         //building absolute path so that websocket doesnt fail when deploying with a context path\n-        var loc = this.$window.location;","path":"generators/client/templates/angular/src/main/webapp/app/shared/tracker/_tracker.service.ts","position":13,"original_position":13,"commit_id":"1eb3886f94b757caca54db10b1d2f7b0d3da7078","original_commit_id":"1eb3886f94b757caca54db10b1d2f7b0d3da7078","user":{"login":"deepu105","id":1107223,"avatar_url":"https://avatars.githubusercontent.com/u/1107223?v=3","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"body":"please change this","created_at":"2016-12-19T13:20:10Z","updated_at":"2016-12-19T13:20:13Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/4673#discussion_r93029353","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/93029353"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/4673#discussion_r93029353"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673","id":97711185,"html_url":"https://github.com/jhipster/generator-jhipster/pull/4673","diff_url":"https://github.com/jhipster/generator-jhipster/pull/4673.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/4673.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4673","number":4673,"state":"open","locked":false,"title":"[WIP] Ng2 tracker service","user":{"login":"flaviencathala","id":11872070,"avatar_url":"https://avatars.githubusercontent.com/u/11872070?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviencathala","html_url":"https://github.com/flaviencathala","followers_url":"https://api.github.com/users/flaviencathala/followers","following_url":"https://api.github.com/users/flaviencathala/following{/other_user}","gists_url":"https://api.github.com/users/flaviencathala/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviencathala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviencathala/subscriptions","organizations_url":"https://api.github.com/users/flaviencathala/orgs","repos_url":"https://api.github.com/users/flaviencathala/repos","events_url":"https://api.github.com/users/flaviencathala/events{/privacy}","received_events_url":"https://api.github.com/users/flaviencathala/received_events","type":"User","site_admin":false},"body":"@christopherthielen Could you please take a look we still have $rootScope in tracker service.","created_at":"2016-12-13T09:13:30Z","updated_at":"2016-12-19T13:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19e2ae2a3b716b3981abfe152e741af260569ca4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4673/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/1eb3886f94b757caca54db10b1d2f7b0d3da7078","head":{"label":"flaviencathala:ng2-tracker-service","ref":"ng2-tracker-service","sha":"1eb3886f94b757caca54db10b1d2f7b0d3da7078","user":{"login":"flaviencathala","id":11872070,"avatar_url":"https://avatars.githubusercontent.com/u/11872070?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviencathala","html_url":"https://github.com/flaviencathala","followers_url":"https://api.github.com/users/flaviencathala/followers","following_url":"https://api.github.com/users/flaviencathala/following{/other_user}","gists_url":"https://api.github.com/users/flaviencathala/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviencathala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviencathala/subscriptions","organizations_url":"https://api.github.com/users/flaviencathala/orgs","repos_url":"https://api.github.com/users/flaviencathala/repos","events_url":"https://api.github.com/users/flaviencathala/events{/privacy}","received_events_url":"https://api.github.com/users/flaviencathala/received_events","type":"User","site_admin":false},"repo":{"id":67419858,"name":"generator-jhipster","full_name":"flaviencathala/generator-jhipster","owner":{"login":"flaviencathala","id":11872070,"avatar_url":"https://avatars.githubusercontent.com/u/11872070?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviencathala","html_url":"https://github.com/flaviencathala","followers_url":"https://api.github.com/users/flaviencathala/followers","following_url":"https://api.github.com/users/flaviencathala/following{/other_user}","gists_url":"https://api.github.com/users/flaviencathala/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviencathala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviencathala/subscriptions","organizations_url":"https://api.github.com/users/flaviencathala/orgs","repos_url":"https://api.github.com/users/flaviencathala/repos","events_url":"https://api.github.com/users/flaviencathala/events{/privacy}","received_events_url":"https://api.github.com/users/flaviencathala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flaviencathala/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":true,"url":"https://api.github.com/repos/flaviencathala/generator-jhipster","forks_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/forks","keys_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/events","assignees_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/merges","archive_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/flaviencathala/generator-jhipster/deployments","created_at":"2016-09-05T12:41:42Z","updated_at":"2016-09-05T12:41:46Z","pushed_at":"2016-12-19T13:14:26Z","git_url":"git://github.com/flaviencathala/generator-jhipster.git","ssh_url":"git@github.com:flaviencathala/generator-jhipster.git","clone_url":"https://github.com/flaviencathala/generator-jhipster.git","svn_url":"https://github.com/flaviencathala/generator-jhipster","homepage":"http://jhipster.github.io","size":16051,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"248c4264a494bb2801c301fa500d1c55738651b7","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2016-12-19T11:46:02Z","pushed_at":"2016-12-19T13:19:15Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":16041,"stargazers_count":5635,"watchers_count":5635,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1266,"mirror_url":null,"open_issues_count":31,"forks":1266,"open_issues":31,"watchers":5635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/4673"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4673"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4673/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4673/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/1eb3886f94b757caca54db10b1d2f7b0d3da7078"}}}}
{"actor":{"display_login":"deepu105"}}