{"action":"created","comment":{"url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/comments/75128009","id":75128009,"diff_hunk":"@@ -15,33 +15,37 @@ public class TokenPaymentTests : JudoTestBase\n \n         private readonly string _consumerReference = Guid.NewGuid().ToString();\n \n-        [OneTimeSetUp]\n+\t\t[TestFixtureSetUp]\n         public void InitialPayment()\n-        {\n-            //Given I have a valid set of credentials not set up for 3d secure.\n-            SetConfiguration();\n+        {\n+            //Given I have a valid set of credentials not set up for 3d secure.\n+            SetConfiguration();\n \n-            var sut = GetPaymentService();\n+            var sut = GetPaymentService();\n \n-            //When I set up a card payment.\n-            var paymentViewModel = GetBasicPaymentModelBuilder()\n-                .WithConsumerReference(_consumerReference)\n-                .Build();\n+            //When I set up a card payment.\n+            var paymentViewModel = GetBasicPaymentModelBuilder()\n+                .WithConsumerReference(_consumerReference)\n+                .Build();\n \n-            //And call the payment service.\n-            var result = sut.MakePayment(paymentViewModel, GetClientService()).Result;\n+            //And call the payment service.\n+            var result = Task.Run(() => sut.MakePayment(paymentViewModel, GetClientService()));\n \n-            //Then the payment must succeed.\n-            Assertions.AssertSuccessfulPayment(result);\n+            result.Wait();\n \n-            var prm = result.Response as PaymentReceiptModel;\n+            var response = result.Result;","path":"src/JudoDotNetXamariniOS.Tests/TokenPaymentTests.cs","position":52,"original_position":52,"commit_id":"aaad9d761f522f77178fa81f52ea43906a7b0901","original_commit_id":"aaad9d761f522f77178fa81f52ea43906a7b0901","user":{"login":"James-Lappin","id":7825546,"avatar_url":"https://avatars.githubusercontent.com/u/7825546?v=3","gravatar_id":"","url":"https://api.github.com/users/James-Lappin","html_url":"https://github.com/James-Lappin","followers_url":"https://api.github.com/users/James-Lappin/followers","following_url":"https://api.github.com/users/James-Lappin/following{/other_user}","gists_url":"https://api.github.com/users/James-Lappin/gists{/gist_id}","starred_url":"https://api.github.com/users/James-Lappin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/James-Lappin/subscriptions","organizations_url":"https://api.github.com/users/James-Lappin/orgs","repos_url":"https://api.github.com/users/James-Lappin/repos","events_url":"https://api.github.com/users/James-Lappin/events{/privacy}","received_events_url":"https://api.github.com/users/James-Lappin/received_events","type":"User","site_admin":false},"body":"Dont use .Result if you can help it. Could you make the method async and use await?","created_at":"2016-08-17T14:00:41Z","updated_at":"2016-08-17T14:00:42Z","html_url":"https://github.com/JudoPay/Judo-Xamarin/pull/60#discussion_r75128009","pull_request_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/comments/75128009"},"html":{"href":"https://github.com/JudoPay/Judo-Xamarin/pull/60#discussion_r75128009"},"pull_request":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60","id":80991810,"html_url":"https://github.com/JudoPay/Judo-Xamarin/pull/60","diff_url":"https://github.com/JudoPay/Judo-Xamarin/pull/60.diff","patch_url":"https://github.com/JudoPay/Judo-Xamarin/pull/60.patch","issue_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/60","number":60,"state":"open","locked":false,"title":"Xamarinbuildci","user":{"login":"daningrey","id":15246115,"avatar_url":"https://avatars.githubusercontent.com/u/15246115?v=3","gravatar_id":"","url":"https://api.github.com/users/daningrey","html_url":"https://github.com/daningrey","followers_url":"https://api.github.com/users/daningrey/followers","following_url":"https://api.github.com/users/daningrey/following{/other_user}","gists_url":"https://api.github.com/users/daningrey/gists{/gist_id}","starred_url":"https://api.github.com/users/daningrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daningrey/subscriptions","organizations_url":"https://api.github.com/users/daningrey/orgs","repos_url":"https://api.github.com/users/daningrey/repos","events_url":"https://api.github.com/users/daningrey/events{/privacy}","received_events_url":"https://api.github.com/users/daningrey/received_events","type":"User","site_admin":false},"body":"First pass at Xamarin CI/CD: \r\n- Moved unit test project to an iOS unit test project so TLS will work on mac\r\n- Fixed build script for use with Team City\r\n- Team City builds and runs iOS unit tests and reports back test results\r\n\r\n@ashleybarrett @LukeFieldsend @JamesGoodwin","created_at":"2016-08-11T16:51:09Z","updated_at":"2016-08-17T14:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8e04eeb2f9b327f92f6bdac0d8ad429333ac90","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60/commits","review_comments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60/comments","review_comment_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/60/comments","statuses_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/statuses/aaad9d761f522f77178fa81f52ea43906a7b0901","head":{"label":"JudoPay:xamarinbuildci","ref":"xamarinbuildci","sha":"aaad9d761f522f77178fa81f52ea43906a7b0901","user":{"login":"JudoPay","id":3963274,"avatar_url":"https://avatars.githubusercontent.com/u/3963274?v=3","gravatar_id":"","url":"https://api.github.com/users/JudoPay","html_url":"https://github.com/JudoPay","followers_url":"https://api.github.com/users/JudoPay/followers","following_url":"https://api.github.com/users/JudoPay/following{/other_user}","gists_url":"https://api.github.com/users/JudoPay/gists{/gist_id}","starred_url":"https://api.github.com/users/JudoPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudoPay/subscriptions","organizations_url":"https://api.github.com/users/JudoPay/orgs","repos_url":"https://api.github.com/users/JudoPay/repos","events_url":"https://api.github.com/users/JudoPay/events{/privacy}","received_events_url":"https://api.github.com/users/JudoPay/received_events","type":"Organization","site_admin":false},"repo":{"id":42592739,"name":"Judo-Xamarin","full_name":"JudoPay/Judo-Xamarin","owner":{"login":"JudoPay","id":3963274,"avatar_url":"https://avatars.githubusercontent.com/u/3963274?v=3","gravatar_id":"","url":"https://api.github.com/users/JudoPay","html_url":"https://github.com/JudoPay","followers_url":"https://api.github.com/users/JudoPay/followers","following_url":"https://api.github.com/users/JudoPay/following{/other_user}","gists_url":"https://api.github.com/users/JudoPay/gists{/gist_id}","starred_url":"https://api.github.com/users/JudoPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudoPay/subscriptions","organizations_url":"https://api.github.com/users/JudoPay/orgs","repos_url":"https://api.github.com/users/JudoPay/repos","events_url":"https://api.github.com/users/JudoPay/events{/privacy}","received_events_url":"https://api.github.com/users/JudoPay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JudoPay/Judo-Xamarin","description":"Mobile Payments Xamarin SDK","fork":false,"url":"https://api.github.com/repos/JudoPay/Judo-Xamarin","forks_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/forks","keys_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/teams","hooks_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/hooks","issue_events_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/events{/number}","events_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/events","assignees_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/assignees{/user}","branches_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/branches{/branch}","tags_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/tags","blobs_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/statuses/{sha}","languages_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/languages","stargazers_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/stargazers","contributors_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/contributors","subscribers_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/subscribers","subscription_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/subscription","commits_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/contents/{+path}","compare_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/merges","archive_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/downloads","issues_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues{/number}","pulls_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls{/number}","milestones_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/milestones{/number}","notifications_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/labels{/name}","releases_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/releases{/id}","deployments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/deployments","created_at":"2015-09-16T14:35:27Z","updated_at":"2016-07-24T12:05:30Z","pushed_at":"2016-08-17T13:03:58Z","git_url":"git://github.com/JudoPay/Judo-Xamarin.git","ssh_url":"git@github.com:JudoPay/Judo-Xamarin.git","clone_url":"https://github.com/JudoPay/Judo-Xamarin.git","svn_url":"https://github.com/JudoPay/Judo-Xamarin","homepage":null,"size":63790,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"JudoPay:develop","ref":"develop","sha":"afa217e376abda2bedd4f1003e9b2cb5484a6d60","user":{"login":"JudoPay","id":3963274,"avatar_url":"https://avatars.githubusercontent.com/u/3963274?v=3","gravatar_id":"","url":"https://api.github.com/users/JudoPay","html_url":"https://github.com/JudoPay","followers_url":"https://api.github.com/users/JudoPay/followers","following_url":"https://api.github.com/users/JudoPay/following{/other_user}","gists_url":"https://api.github.com/users/JudoPay/gists{/gist_id}","starred_url":"https://api.github.com/users/JudoPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudoPay/subscriptions","organizations_url":"https://api.github.com/users/JudoPay/orgs","repos_url":"https://api.github.com/users/JudoPay/repos","events_url":"https://api.github.com/users/JudoPay/events{/privacy}","received_events_url":"https://api.github.com/users/JudoPay/received_events","type":"Organization","site_admin":false},"repo":{"id":42592739,"name":"Judo-Xamarin","full_name":"JudoPay/Judo-Xamarin","owner":{"login":"JudoPay","id":3963274,"avatar_url":"https://avatars.githubusercontent.com/u/3963274?v=3","gravatar_id":"","url":"https://api.github.com/users/JudoPay","html_url":"https://github.com/JudoPay","followers_url":"https://api.github.com/users/JudoPay/followers","following_url":"https://api.github.com/users/JudoPay/following{/other_user}","gists_url":"https://api.github.com/users/JudoPay/gists{/gist_id}","starred_url":"https://api.github.com/users/JudoPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudoPay/subscriptions","organizations_url":"https://api.github.com/users/JudoPay/orgs","repos_url":"https://api.github.com/users/JudoPay/repos","events_url":"https://api.github.com/users/JudoPay/events{/privacy}","received_events_url":"https://api.github.com/users/JudoPay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JudoPay/Judo-Xamarin","description":"Mobile Payments Xamarin SDK","fork":false,"url":"https://api.github.com/repos/JudoPay/Judo-Xamarin","forks_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/forks","keys_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/teams","hooks_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/hooks","issue_events_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/events{/number}","events_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/events","assignees_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/assignees{/user}","branches_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/branches{/branch}","tags_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/tags","blobs_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/statuses/{sha}","languages_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/languages","stargazers_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/stargazers","contributors_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/contributors","subscribers_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/subscribers","subscription_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/subscription","commits_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/contents/{+path}","compare_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/merges","archive_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/downloads","issues_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues{/number}","pulls_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls{/number}","milestones_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/milestones{/number}","notifications_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/labels{/name}","releases_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/releases{/id}","deployments_url":"https://api.github.com/repos/JudoPay/Judo-Xamarin/deployments","created_at":"2015-09-16T14:35:27Z","updated_at":"2016-07-24T12:05:30Z","pushed_at":"2016-08-17T13:03:58Z","git_url":"git://github.com/JudoPay/Judo-Xamarin.git","ssh_url":"git@github.com:JudoPay/Judo-Xamarin.git","clone_url":"https://github.com/JudoPay/Judo-Xamarin.git","svn_url":"https://github.com/JudoPay/Judo-Xamarin","homepage":null,"size":63790,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60"},"html":{"href":"https://github.com/JudoPay/Judo-Xamarin/pull/60"},"issue":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/60"},"comments":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/JudoPay/Judo-Xamarin/statuses/aaad9d761f522f77178fa81f52ea43906a7b0901"}}}}
{"actor":{"display_login":"James-Lappin"}}