{"action":"created","issue":{"url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/16","repository_url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script","labels_url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/16/comments","events_url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/16/events","html_url":"https://github.com/IRE-Mudlet-Mapping/ire-mapping-script/issues/16","id":176085854,"number":16,"title":"Several incorrect mmp.envids for Achaea.","user":{"login":"bbailey","id":162867,"avatar_url":"https://avatars.githubusercontent.com/u/162867?v=3","gravatar_id":"","url":"https://api.github.com/users/bbailey","html_url":"https://github.com/bbailey","followers_url":"https://api.github.com/users/bbailey/followers","following_url":"https://api.github.com/users/bbailey/following{/other_user}","gists_url":"https://api.github.com/users/bbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/bbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbailey/subscriptions","organizations_url":"https://api.github.com/users/bbailey/orgs","repos_url":"https://api.github.com/users/bbailey/repos","events_url":"https://api.github.com/users/bbailey/events{/privacy}","received_events_url":"https://api.github.com/users/bbailey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-09T19:10:14Z","updated_at":"2016-10-09T06:15:39Z","closed_at":null,"body":"mmp.envids as populated in register_achaeas_envdata() has several terrains in the table with duplicate ids. This serves to neuter the mmp.envidsr table when it is generated, which results in rooms reporting the incorrect terrain when translating back from the map's terrain id to a terrain type.\r\n\r\nThe latter entries in mmp.envids are preserved in mmp.envidsr while the earlier entries are overwritten.\r\n\r\nCatacombs and Mountains both share id 14, resulting in entry 14 in mmp.envidsr always returning Mountains. Thus the Azdun catacombs in the crowdmap will erroneously report as Mountains when trying to translate their terrain back from id 14. Even if you manually remap the rooms to Catacombs, it will again save as id 14 and be reported back as Mountains.\r\n\r\nShared ids are:\r\nCatacombs and Mountains share id 14\r\nRiver and Skies share id 10\r\nDeep Ocean floor and Water share id 30"},"comment":{"url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/comments/252467427","html_url":"https://github.com/IRE-Mudlet-Mapping/ire-mapping-script/issues/16#issuecomment-252467427","issue_url":"https://api.github.com/repos/IRE-Mudlet-Mapping/ire-mapping-script/issues/16","id":252467427,"user":{"login":"vadi2","id":110988,"avatar_url":"https://avatars.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T06:15:38Z","updated_at":"2016-10-09T06:15:38Z","body":"I think changing the colours in Mudlets options will change the colours on\nthe map as well.\n\nOn Sun, Oct 9, 2016 at 3:54 PM Stephen Lyons <notifications@github.com>\nwrote:\n\n> Howdy - as an actively contributing Mudlet Maker - I'm looking at the C++\n> in that area at the moment and that area of color/environment looks to be a\n> bit *convoluted*!\n>\n> I'd give a long winded explanation but simply put during the reading of a\n> Xml map file from the IRE MUD servers (including Achaea) there is a table\n> of envIds (a property of each map room) to a colorId where colors 1-15 are\n> the ANSI standard colours that the user can tweak in the game settings and\n> 16 upwards (I think) are what ever gets set by setCustomEnv commands. The\n> current Achaea Xml file has:\n>\n> <environments>\n>    <environment id=\"2\" name=\"Constructed underground\" color=\"8\" htmlcolor=\"#80735f\" />\n>    <environment id=\"3\" name=\"Natural underground\" color=\"8\" htmlcolor=\"#765116\" />\n>    <environment id=\"4\" name=\"Forest\" color=\"2\" htmlcolor=\"#36662e\" />\n>    <environment id=\"5\" name=\"Beach\" color=\"11\" htmlcolor=\"#ffffcc\" />\n>    <environment id=\"6\" name=\"Desert\" color=\"11\" htmlcolor=\"#f9fd00\" />\n>    <environment id=\"7\" name=\"Grasslands\" color=\"10\" htmlcolor=\"#1dc713\" />\n>    <environment id=\"8\" name=\"Urban\" color=\"13\" htmlcolor=\"#bda0cb\" />\n>    <environment id=\"9\" name=\"Hills\" color=\"3\" htmlcolor=\"#2d7720\" />\n>    <environment id=\"10\" name=\"River\" color=\"4\" htmlcolor=\"#00ddff\" />\n>    <environment id=\"11\" name=\"Path\" color=\"6\" htmlcolor=\"#837766\" />\n>    <environment id=\"12\" name=\"Road\" color=\"6\" htmlcolor=\"#7c7c7c\" />\n>    <environment id=\"13\" name=\"Valley\" color=\"5\" htmlcolor=\"#41ab2f\" />\n>    <environment id=\"14\" name=\"Mountains\" color=\"1\" htmlcolor=\"#584a34\" />\n>    <environment id=\"15\" name=\"Swamp\" color=\"10\" htmlcolor=\"#76843c\" />\n>    <environment id=\"16\" name=\"Tundra\" color=\"7\" htmlcolor=\"#c5fcff\" />\n>    <environment id=\"17\" name=\"Jungle\" color=\"10\" htmlcolor=\"#89e14b\" />\n>    <environment id=\"18\" name=\"Dwarven city\" color=\"13\" htmlcolor=\"#ab9e6d\" />\n>    <environment id=\"19\" name=\"Tsol'aa city\" color=\"13\" htmlcolor=\"#56a574\" />\n>    <environment id=\"20\" name=\"Ocean\" color=\"4\" htmlcolor=\"#0000ff\" />\n>    <environment id=\"21\" name=\"Garden\" color=\"11\" htmlcolor=\"#94e45d\" />\n>    <environment id=\"22\" name=\"Freshwater\" color=\"4\" htmlcolor=\"#5ff0f0\" />\n>    <environment id=\"23\" name=\"Sewer\" color=\"8\" htmlcolor=\"#918010\" />\n>    <environment id=\"24\" name=\"Deep Ocean\" color=\"4\" htmlcolor=\"#003366\" />\n>    <environment id=\"25\" name=\"Reef\" color=\"12\" htmlcolor=\"#f98167\" />\n>    <environment id=\"27\" name=\"Polar\" color=\"15\" htmlcolor=\"#ffffff\" />\n>    <environment id=\"28\" name=\"Trees\" color=\"2\" htmlcolor=\"#00e342\" />\n>    <environment id=\"29\" name=\"Blighted\" color=\"7\" htmlcolor=\"#990000\" />\n>    <environment id=\"30\" name=\"Water\" color=\"4\" htmlcolor=\"#4d42d4\" />\n>    <environment id=\"31\" name=\"Magma Caves\" color=\"9\" htmlcolor=\"#dd4400\" />\n>    <environment id=\"32\" name=\"Ruins\" color=\"7\" htmlcolor=\"#ddba82\" />\n>    <environment id=\"33\" name=\"Catacombs\" color=\"8\" htmlcolor=\"#837766\" />\n>    <environment id=\"34\" name=\"Ocean floor\" color=\"4\" htmlcolor=\"#0000ff\" />\n>    <environment id=\"35\" name=\"Skies\" color=\"14\" htmlcolor=\"#ffffff\" />\n>    <environment id=\"36\" name=\"Vessel\" color=\"3\" htmlcolor=\"#918010\" />\n>    <environment id=\"39\" name=\"Agrarian\" color=\"7\" htmlcolor=\"#918010\" />\n>    <environment id=\"41\" name=\"Wastelands\" color=\"7\" htmlcolor=\"#C0C0C0\" />\n>    <environment id=\"42\" name=\"Lava Fields\" color=\"1\" htmlcolor=\"#cf1020\" />\n> </environments>\n>\n> Mudlet only reads the \"id\" and \"color\" values at the moment and stores\n> them (\"id\" as key, \"color\" as value) in TMap::envColors which is NOT user\n> accessible or changed by anything else - it is stored in the Mudlet\n> specific map file (the .dat files in the maps sub-directory) so it then\n> persists in the game saves.\n>\n> When it comes to drawing a room it's environment value (readable with lua\n> getRoomEnv( <roomId> )) is looked up and if it is one in that table it is\n> drawn in the colour given. So for example a room with an envId of 5 is\n> drawn with colourId 11 which is the ANSI yellow colour I believe - but then\n> so is a room with an envId of 6 as that is also mapped to colour 11 above.\n>\n> If someone wishes to have different colour for those two they will\n> currently have to never use the IRE downloaded map (*I think*) or ensure\n> that they use envIds that are NOT used as a key in the TMap::envColor table\n> (i.e. listed in the XML downloaded file that was used) so that Mudlet will\n> use a customEnvColor entry instead. I have looked at all five (?) of the\n> current IRE XML maps and Aetolia has the highest envId of 126 - as you can\n> see Achaea uses up to 42 at the moment.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/IRE-Mudlet-Mapping/ire-mapping-script/issues/16#issuecomment-252466685>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAGxjDUiOni9c6-U8wH7-oSjjBKASx4qks5qyIGKgaJpZM4J5XVX>\n> .\n>\n"}}
{"actor":{"display_login":"vadi2"}}