{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/38","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/38/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/38/events","html_url":"https://github.com/Homebrew/brew/issues/38","id":146364489,"number":38,"title":"Make `revision` mean only one thing.","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Homebrew/brew/labels/usability","name":"usability","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-06T16:22:48Z","updated_at":"2016-04-08T14:31:29Z","closed_at":null,"body":"We keep confusing people by using the magical word `revision` to mean different things.\r\n\r\nWe have:\r\n\r\n* Bottle revisions:\r\n```ruby\r\nbottle do\r\n  revision 1\r\n  sha256 \"41af286dc0b172ed2f1ca934fd2278de4a1192302ffa07087cea2682e7d372e3\" => :blah\r\nend\r\n```\r\n* Git revisions:\r\n```ruby\r\nurl \"https://github.com/magic/unicorns.git\",\r\n    :tag => \"unicorn-1\",\r\n    :revision => \"eefc6ed865ca20447afc293c986676933dbfb137\"\r\n```\r\n* Formulae revisions:\r\n```ruby\r\nurl \"https://example.org/example.tar.gz\"\r\nsha256 \"13550350a8681c84c861aac2e5b440161c2b33a3e4f302ac680ca5b686de48de\"\r\nrevision 1\r\n```\r\n\r\nParticularly confusing to new contributors is that we have an audit mechanism that nudges people to remove an unnecessary `revision`, and we see repeated examples of people removing the git commit `revision` rather than the `revision 1`.\r\n\r\nWe need to move away, long-term, from using the same keyword to represent different things, particularly where those things are used in close proximity on a regular basis. It'd probably be easier to change formulae/bottle meaning of `revision`, IMO, but discuss at will."},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/207453749","html_url":"https://github.com/Homebrew/brew/issues/38#issuecomment-207453749","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/38","id":207453749,"user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"created_at":"2016-04-08T14:31:29Z","updated_at":"2016-04-08T14:31:29Z","body":"I'd propose bottle `revision`s become `bottle_version` or `bottle_revision`, SCM `revisions` become `commit` or `revision` becomes `subversion` or something."}}