{"action":"created","issue":{"url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/49","repository_url":"https://api.github.com/repos/mxenabled/action_subscriber","labels_url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/49/comments","events_url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/49/events","html_url":"https://github.com/mxenabled/action_subscriber/pull/49","id":132825060,"number":49,"title":"Provide error handler to the async publisher","user":{"login":"film42","id":1043908,"avatar_url":"https://avatars.githubusercontent.com/u/1043908?v=3","gravatar_id":"","url":"https://api.github.com/users/film42","html_url":"https://github.com/film42","followers_url":"https://api.github.com/users/film42/followers","following_url":"https://api.github.com/users/film42/following{/other_user}","gists_url":"https://api.github.com/users/film42/gists{/gist_id}","starred_url":"https://api.github.com/users/film42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/film42/subscriptions","organizations_url":"https://api.github.com/users/film42/orgs","repos_url":"https://api.github.com/users/film42/repos","events_url":"https://api.github.com/users/film42/events{/privacy}","received_events_url":"https://api.github.com/users/film42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-10T21:41:17Z","updated_at":"2016-02-10T21:42:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mxenabled/action_subscriber/pulls/49","html_url":"https://github.com/mxenabled/action_subscriber/pull/49","diff_url":"https://github.com/mxenabled/action_subscriber/pull/49.diff","patch_url":"https://github.com/mxenabled/action_subscriber/pull/49.patch"},"body":"Adding an error handler to the async publisher will let anyone bubble errors wherever they need to go. By default, however, exceptions are logged and swallowed (not new behavior).\r\n\r\nI think this PR is in an adequate state. What I'm unsure of is if this behavior should become a convention of action subscriber (set the default in the configuration), or leave this in the in-memory publisher so it's easier to extract into a publisher gem. You might think it's good enough as is, and that's cool too.\r\n\r\ncc @mmmries @abrandoned @liveh2o @brianstien @localshred @brettallred "},"comment":{"url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/comments/182594321","html_url":"https://github.com/mxenabled/action_subscriber/pull/49#issuecomment-182594321","issue_url":"https://api.github.com/repos/mxenabled/action_subscriber/issues/49","id":182594321,"user":{"login":"film42","id":1043908,"avatar_url":"https://avatars.githubusercontent.com/u/1043908?v=3","gravatar_id":"","url":"https://api.github.com/users/film42","html_url":"https://github.com/film42","followers_url":"https://api.github.com/users/film42/followers","following_url":"https://api.github.com/users/film42/following{/other_user}","gists_url":"https://api.github.com/users/film42/gists{/gist_id}","starred_url":"https://api.github.com/users/film42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/film42/subscriptions","organizations_url":"https://api.github.com/users/film42/orgs","repos_url":"https://api.github.com/users/film42/repos","events_url":"https://api.github.com/users/film42/events{/privacy}","received_events_url":"https://api.github.com/users/film42/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T21:42:27Z","updated_at":"2016-02-10T21:42:27Z","body":"P.S. Not sure what's up with the failing spec (seems unrelated). cc @mmmries "}}