{"action":"created","comment":{"url":"https://api.github.com/repos/codingmentor/homeworks/pulls/comments/73853575","id":73853575,"diff_hunk":"@@ -1,25 +1,37 @@\n-package com.norbertschmelhaus.eehomework2.singletons;\n+package com.norbertschmelhaus.database;\n \n-import com.norbertschmelhaus.eehomework2.dto.UserDTO;\n-import com.norbertschmelhaus.eehomework2.interceptor.BeanValidation;\n+import com.norbertschmelhaus.dto.UserDTO;\n+import com.norbertschmelhaus.interceptors.BeanValidation;\n+import java.io.Serializable;\n import java.util.Date;\n import java.util.HashMap;\n import java.util.Map;\n+import javax.ejb.Singleton;\n \n /**\n  *\n  * @author norbeee\n  */\n-public class UserDB {\n+@Singleton\n+public class UserDB implements Serializable {\n     \n     private final Map<String, UserDTO> users = new HashMap<>();\n+\n+    public Map<String, UserDTO> getUsers() {","path":"norbert.schmelhaus/2-2-hazi/2-Homework-Webshop-NS/2-Homework-Webshop-NS-ejb/src/main/java/com/norbertschmelhaus/database/UserDB.java","position":24,"original_position":24,"commit_id":"595c8b81ba85910b9cb4db3471d7c7e4e4c78e7d","original_commit_id":"595c8b81ba85910b9cb4db3471d7c7e4e4c78e7d","user":{"login":"deneslaszlo","id":16327999,"avatar_url":"https://avatars.githubusercontent.com/u/16327999?v=3","gravatar_id":"","url":"https://api.github.com/users/deneslaszlo","html_url":"https://github.com/deneslaszlo","followers_url":"https://api.github.com/users/deneslaszlo/followers","following_url":"https://api.github.com/users/deneslaszlo/following{/other_user}","gists_url":"https://api.github.com/users/deneslaszlo/gists{/gist_id}","starred_url":"https://api.github.com/users/deneslaszlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deneslaszlo/subscriptions","organizations_url":"https://api.github.com/users/deneslaszlo/orgs","repos_url":"https://api.github.com/users/deneslaszlo/repos","events_url":"https://api.github.com/users/deneslaszlo/events{/privacy}","received_events_url":"https://api.github.com/users/deneslaszlo/received_events","type":"User","site_admin":false},"body":"ilyen metódus ne legyen, ez a házi előző részében sem volt elfogadható","created_at":"2016-08-08T10:27:42Z","updated_at":"2016-08-08T10:27:42Z","html_url":"https://github.com/codingmentor/homeworks/pull/51#discussion_r73853575","pull_request_url":"https://api.github.com/repos/codingmentor/homeworks/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/comments/73853575"},"html":{"href":"https://github.com/codingmentor/homeworks/pull/51#discussion_r73853575"},"pull_request":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/codingmentor/homeworks/pulls/51","id":80381846,"html_url":"https://github.com/codingmentor/homeworks/pull/51","diff_url":"https://github.com/codingmentor/homeworks/pull/51.diff","patch_url":"https://github.com/codingmentor/homeworks/pull/51.patch","issue_url":"https://api.github.com/repos/codingmentor/homeworks/issues/51","number":51,"state":"open","locked":false,"title":"Add complete EE-2-2 rest project v1.0","user":{"login":"schnorbeee","id":20253897,"avatar_url":"https://avatars.githubusercontent.com/u/20253897?v=3","gravatar_id":"","url":"https://api.github.com/users/schnorbeee","html_url":"https://github.com/schnorbeee","followers_url":"https://api.github.com/users/schnorbeee/followers","following_url":"https://api.github.com/users/schnorbeee/following{/other_user}","gists_url":"https://api.github.com/users/schnorbeee/gists{/gist_id}","starred_url":"https://api.github.com/users/schnorbeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnorbeee/subscriptions","organizations_url":"https://api.github.com/users/schnorbeee/orgs","repos_url":"https://api.github.com/users/schnorbeee/repos","events_url":"https://api.github.com/users/schnorbeee/events{/privacy}","received_events_url":"https://api.github.com/users/schnorbeee/received_events","type":"User","site_admin":false},"body":"Sonar link: http://sonar.codingmentor.xyz/component_issues?id=com.norbertschmelhaus%3A2-Homework-Webshop-Norbert-Schmelhaus#resolved=false|severities=MINOR%2CMAJOR\r\n\r\n1db major hiba az exception lekezelesénél, azt mondtad hogy ezzel ne foglalkozzak és maradjon így a fejlécben a throws Exception.\r\n7db minor hiba pedig mind loggeres inject miatt.\r\n\r\nsh scriptekkel tesztelve git bashban + RESTClienttel is.\r\n\r\n","created_at":"2016-08-07T23:49:55Z","updated_at":"2016-08-08T10:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6704671287e56904181e36d075b049dd35772858","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codingmentor/homeworks/pulls/51/commits","review_comments_url":"https://api.github.com/repos/codingmentor/homeworks/pulls/51/comments","review_comment_url":"https://api.github.com/repos/codingmentor/homeworks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codingmentor/homeworks/issues/51/comments","statuses_url":"https://api.github.com/repos/codingmentor/homeworks/statuses/595c8b81ba85910b9cb4db3471d7c7e4e4c78e7d","head":{"label":"schnorbeee:EE-2-2","ref":"EE-2-2","sha":"595c8b81ba85910b9cb4db3471d7c7e4e4c78e7d","user":{"login":"schnorbeee","id":20253897,"avatar_url":"https://avatars.githubusercontent.com/u/20253897?v=3","gravatar_id":"","url":"https://api.github.com/users/schnorbeee","html_url":"https://github.com/schnorbeee","followers_url":"https://api.github.com/users/schnorbeee/followers","following_url":"https://api.github.com/users/schnorbeee/following{/other_user}","gists_url":"https://api.github.com/users/schnorbeee/gists{/gist_id}","starred_url":"https://api.github.com/users/schnorbeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnorbeee/subscriptions","organizations_url":"https://api.github.com/users/schnorbeee/orgs","repos_url":"https://api.github.com/users/schnorbeee/repos","events_url":"https://api.github.com/users/schnorbeee/events{/privacy}","received_events_url":"https://api.github.com/users/schnorbeee/received_events","type":"User","site_admin":false},"repo":{"id":63486514,"name":"homeworks","full_name":"schnorbeee/homeworks","owner":{"login":"schnorbeee","id":20253897,"avatar_url":"https://avatars.githubusercontent.com/u/20253897?v=3","gravatar_id":"","url":"https://api.github.com/users/schnorbeee","html_url":"https://github.com/schnorbeee","followers_url":"https://api.github.com/users/schnorbeee/followers","following_url":"https://api.github.com/users/schnorbeee/following{/other_user}","gists_url":"https://api.github.com/users/schnorbeee/gists{/gist_id}","starred_url":"https://api.github.com/users/schnorbeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnorbeee/subscriptions","organizations_url":"https://api.github.com/users/schnorbeee/orgs","repos_url":"https://api.github.com/users/schnorbeee/repos","events_url":"https://api.github.com/users/schnorbeee/events{/privacy}","received_events_url":"https://api.github.com/users/schnorbeee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schnorbeee/homeworks","description":"Homeworks of codingmentor training","fork":true,"url":"https://api.github.com/repos/schnorbeee/homeworks","forks_url":"https://api.github.com/repos/schnorbeee/homeworks/forks","keys_url":"https://api.github.com/repos/schnorbeee/homeworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schnorbeee/homeworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schnorbeee/homeworks/teams","hooks_url":"https://api.github.com/repos/schnorbeee/homeworks/hooks","issue_events_url":"https://api.github.com/repos/schnorbeee/homeworks/issues/events{/number}","events_url":"https://api.github.com/repos/schnorbeee/homeworks/events","assignees_url":"https://api.github.com/repos/schnorbeee/homeworks/assignees{/user}","branches_url":"https://api.github.com/repos/schnorbeee/homeworks/branches{/branch}","tags_url":"https://api.github.com/repos/schnorbeee/homeworks/tags","blobs_url":"https://api.github.com/repos/schnorbeee/homeworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schnorbeee/homeworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schnorbeee/homeworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/schnorbeee/homeworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schnorbeee/homeworks/statuses/{sha}","languages_url":"https://api.github.com/repos/schnorbeee/homeworks/languages","stargazers_url":"https://api.github.com/repos/schnorbeee/homeworks/stargazers","contributors_url":"https://api.github.com/repos/schnorbeee/homeworks/contributors","subscribers_url":"https://api.github.com/repos/schnorbeee/homeworks/subscribers","subscription_url":"https://api.github.com/repos/schnorbeee/homeworks/subscription","commits_url":"https://api.github.com/repos/schnorbeee/homeworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/schnorbeee/homeworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/schnorbeee/homeworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/schnorbeee/homeworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/schnorbeee/homeworks/contents/{+path}","compare_url":"https://api.github.com/repos/schnorbeee/homeworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schnorbeee/homeworks/merges","archive_url":"https://api.github.com/repos/schnorbeee/homeworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schnorbeee/homeworks/downloads","issues_url":"https://api.github.com/repos/schnorbeee/homeworks/issues{/number}","pulls_url":"https://api.github.com/repos/schnorbeee/homeworks/pulls{/number}","milestones_url":"https://api.github.com/repos/schnorbeee/homeworks/milestones{/number}","notifications_url":"https://api.github.com/repos/schnorbeee/homeworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schnorbeee/homeworks/labels{/name}","releases_url":"https://api.github.com/repos/schnorbeee/homeworks/releases{/id}","deployments_url":"https://api.github.com/repos/schnorbeee/homeworks/deployments","created_at":"2016-07-16T14:26:27Z","updated_at":"2016-07-16T14:00:02Z","pushed_at":"2016-08-07T23:40:42Z","git_url":"git://github.com/schnorbeee/homeworks.git","ssh_url":"git@github.com:schnorbeee/homeworks.git","clone_url":"https://github.com/schnorbeee/homeworks.git","svn_url":"https://github.com/schnorbeee/homeworks","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codingmentor:norbert.schmelhaus","ref":"norbert.schmelhaus","sha":"2ad7aa7d8680128fe8d39ad5c609d3d5ff197fd9","user":{"login":"codingmentor","id":17640460,"avatar_url":"https://avatars.githubusercontent.com/u/17640460?v=3","gravatar_id":"","url":"https://api.github.com/users/codingmentor","html_url":"https://github.com/codingmentor","followers_url":"https://api.github.com/users/codingmentor/followers","following_url":"https://api.github.com/users/codingmentor/following{/other_user}","gists_url":"https://api.github.com/users/codingmentor/gists{/gist_id}","starred_url":"https://api.github.com/users/codingmentor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingmentor/subscriptions","organizations_url":"https://api.github.com/users/codingmentor/orgs","repos_url":"https://api.github.com/users/codingmentor/repos","events_url":"https://api.github.com/users/codingmentor/events{/privacy}","received_events_url":"https://api.github.com/users/codingmentor/received_events","type":"Organization","site_admin":false},"repo":{"id":63485226,"name":"homeworks","full_name":"codingmentor/homeworks","owner":{"login":"codingmentor","id":17640460,"avatar_url":"https://avatars.githubusercontent.com/u/17640460?v=3","gravatar_id":"","url":"https://api.github.com/users/codingmentor","html_url":"https://github.com/codingmentor","followers_url":"https://api.github.com/users/codingmentor/followers","following_url":"https://api.github.com/users/codingmentor/following{/other_user}","gists_url":"https://api.github.com/users/codingmentor/gists{/gist_id}","starred_url":"https://api.github.com/users/codingmentor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingmentor/subscriptions","organizations_url":"https://api.github.com/users/codingmentor/orgs","repos_url":"https://api.github.com/users/codingmentor/repos","events_url":"https://api.github.com/users/codingmentor/events{/privacy}","received_events_url":"https://api.github.com/users/codingmentor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codingmentor/homeworks","description":"Homeworks of codingmentor training","fork":false,"url":"https://api.github.com/repos/codingmentor/homeworks","forks_url":"https://api.github.com/repos/codingmentor/homeworks/forks","keys_url":"https://api.github.com/repos/codingmentor/homeworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingmentor/homeworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingmentor/homeworks/teams","hooks_url":"https://api.github.com/repos/codingmentor/homeworks/hooks","issue_events_url":"https://api.github.com/repos/codingmentor/homeworks/issues/events{/number}","events_url":"https://api.github.com/repos/codingmentor/homeworks/events","assignees_url":"https://api.github.com/repos/codingmentor/homeworks/assignees{/user}","branches_url":"https://api.github.com/repos/codingmentor/homeworks/branches{/branch}","tags_url":"https://api.github.com/repos/codingmentor/homeworks/tags","blobs_url":"https://api.github.com/repos/codingmentor/homeworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingmentor/homeworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingmentor/homeworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingmentor/homeworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingmentor/homeworks/statuses/{sha}","languages_url":"https://api.github.com/repos/codingmentor/homeworks/languages","stargazers_url":"https://api.github.com/repos/codingmentor/homeworks/stargazers","contributors_url":"https://api.github.com/repos/codingmentor/homeworks/contributors","subscribers_url":"https://api.github.com/repos/codingmentor/homeworks/subscribers","subscription_url":"https://api.github.com/repos/codingmentor/homeworks/subscription","commits_url":"https://api.github.com/repos/codingmentor/homeworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingmentor/homeworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingmentor/homeworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingmentor/homeworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingmentor/homeworks/contents/{+path}","compare_url":"https://api.github.com/repos/codingmentor/homeworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingmentor/homeworks/merges","archive_url":"https://api.github.com/repos/codingmentor/homeworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingmentor/homeworks/downloads","issues_url":"https://api.github.com/repos/codingmentor/homeworks/issues{/number}","pulls_url":"https://api.github.com/repos/codingmentor/homeworks/pulls{/number}","milestones_url":"https://api.github.com/repos/codingmentor/homeworks/milestones{/number}","notifications_url":"https://api.github.com/repos/codingmentor/homeworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingmentor/homeworks/labels{/name}","releases_url":"https://api.github.com/repos/codingmentor/homeworks/releases{/id}","deployments_url":"https://api.github.com/repos/codingmentor/homeworks/deployments","created_at":"2016-07-16T13:54:09Z","updated_at":"2016-08-06T14:30:41Z","pushed_at":"2016-08-07T23:49:55Z","git_url":"git://github.com/codingmentor/homeworks.git","ssh_url":"git@github.com:codingmentor/homeworks.git","clone_url":"https://github.com/codingmentor/homeworks.git","svn_url":"https://github.com/codingmentor/homeworks","homepage":null,"size":2013,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/51"},"html":{"href":"https://github.com/codingmentor/homeworks/pull/51"},"issue":{"href":"https://api.github.com/repos/codingmentor/homeworks/issues/51"},"comments":{"href":"https://api.github.com/repos/codingmentor/homeworks/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codingmentor/homeworks/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/codingmentor/homeworks/statuses/595c8b81ba85910b9cb4db3471d7c7e4e4c78e7d"}}}}
{"actor":{"display_login":"deneslaszlo"}}