{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/superset/pulls/comments/88504213","pull_request_review_id":9076591,"id":88504213,"diff_hunk":"@@ -49,6 +53,33 @@ export function fetchFieldOptions(datasourceId, datasourceType) {\n   };\n }\n \n+export const FETCH_FAVE_STAR = 'FETCH_FAVE_STAR'\n+export function fetchFaveStar(sliceId) {\n+  return function (dispatch) {\n+    const url = `${FAVESTAR_BASE_URL}/${sliceId}/count`;\n+    $.get(url, (data) => {\n+      if (data.count > 0) {\n+        dispatch(toggleFaveStar(true));\n+      }\n+    });\n+  }\n+}\n+\n+export const SAVE_FAVE_STAR = 'SAVE_FAVE_STAR'\n+export function saveFaveStar(sliceId, isStarred) {\n+  return function (dispatch) {\n+    const urlSuffix = isStarred ? 'unselect' : 'select';\n+    const url = `${FAVESTAR_BASE_URL}/${sliceId}/${urlSuffix}/`;\n+    $.get(url);\n+    dispatch(toggleFaveStar(!isStarred));\n+  }","path":"superset/assets/javascripts/explorev2/actions/exploreActions.js","position":34,"original_position":34,"commit_id":"a2c964bbd6b9ec48a19ca29ee81eab7a8336dc87","original_commit_id":"a2c964bbd6b9ec48a19ca29ee81eab7a8336dc87","user":{"login":"bkyryliuk","id":5727938,"avatar_url":"https://avatars.githubusercontent.com/u/5727938?v=3","gravatar_id":"","url":"https://api.github.com/users/bkyryliuk","html_url":"https://github.com/bkyryliuk","followers_url":"https://api.github.com/users/bkyryliuk/followers","following_url":"https://api.github.com/users/bkyryliuk/following{/other_user}","gists_url":"https://api.github.com/users/bkyryliuk/gists{/gist_id}","starred_url":"https://api.github.com/users/bkyryliuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkyryliuk/subscriptions","organizations_url":"https://api.github.com/users/bkyryliuk/orgs","repos_url":"https://api.github.com/users/bkyryliuk/repos","events_url":"https://api.github.com/users/bkyryliuk/events{/privacy}","received_events_url":"https://api.github.com/users/bkyryliuk/received_events","type":"User","site_admin":false},"body":"codeclimate says: Missing semicolon. ","created_at":"2016-11-17T17:32:41Z","updated_at":"2016-11-17T17:32:42Z","html_url":"https://github.com/airbnb/superset/pull/1623#discussion_r88504213","pull_request_url":"https://api.github.com/repos/airbnb/superset/pulls/1623","_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments/88504213"},"html":{"href":"https://github.com/airbnb/superset/pull/1623#discussion_r88504213"},"pull_request":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1623"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/superset/pulls/1623","id":94109894,"html_url":"https://github.com/airbnb/superset/pull/1623","diff_url":"https://github.com/airbnb/superset/pull/1623.diff","patch_url":"https://github.com/airbnb/superset/pull/1623.patch","issue_url":"https://api.github.com/repos/airbnb/superset/issues/1623","number":1623,"state":"open","locked":false,"title":"[explore-v2] add fave star and edit button to chart header","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"body":"![screenshot 2016-11-16 22 33 07](https://cloud.githubusercontent.com/assets/130878/20378734/be11c5de-ac4c-11e6-8c85-99ef48e9525c.png)\r\n\r\nplz review @vera-liu @mistercrunch @bkyryliuk ","created_at":"2016-11-17T06:34:08Z","updated_at":"2016-11-17T17:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458e5060d612444b6ea4441deda722c58de1178c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/superset/pulls/1623/commits","review_comments_url":"https://api.github.com/repos/airbnb/superset/pulls/1623/comments","review_comment_url":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/superset/issues/1623/comments","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/a2c964bbd6b9ec48a19ca29ee81eab7a8336dc87","head":{"label":"ascott:alanna-expv2-fave-edit-btn","ref":"alanna-expv2-fave-edit-btn","sha":"a2c964bbd6b9ec48a19ca29ee81eab7a8336dc87","user":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"repo":{"id":73502399,"name":"superset","full_name":"ascott/superset","owner":{"login":"ascott","id":130878,"avatar_url":"https://avatars.githubusercontent.com/u/130878?v=3","gravatar_id":"","url":"https://api.github.com/users/ascott","html_url":"https://github.com/ascott","followers_url":"https://api.github.com/users/ascott/followers","following_url":"https://api.github.com/users/ascott/following{/other_user}","gists_url":"https://api.github.com/users/ascott/gists{/gist_id}","starred_url":"https://api.github.com/users/ascott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascott/subscriptions","organizations_url":"https://api.github.com/users/ascott/orgs","repos_url":"https://api.github.com/users/ascott/repos","events_url":"https://api.github.com/users/ascott/events{/privacy}","received_events_url":"https://api.github.com/users/ascott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ascott/superset","description":"Superset is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/ascott/superset","forks_url":"https://api.github.com/repos/ascott/superset/forks","keys_url":"https://api.github.com/repos/ascott/superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ascott/superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ascott/superset/teams","hooks_url":"https://api.github.com/repos/ascott/superset/hooks","issue_events_url":"https://api.github.com/repos/ascott/superset/issues/events{/number}","events_url":"https://api.github.com/repos/ascott/superset/events","assignees_url":"https://api.github.com/repos/ascott/superset/assignees{/user}","branches_url":"https://api.github.com/repos/ascott/superset/branches{/branch}","tags_url":"https://api.github.com/repos/ascott/superset/tags","blobs_url":"https://api.github.com/repos/ascott/superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ascott/superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ascott/superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/ascott/superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ascott/superset/statuses/{sha}","languages_url":"https://api.github.com/repos/ascott/superset/languages","stargazers_url":"https://api.github.com/repos/ascott/superset/stargazers","contributors_url":"https://api.github.com/repos/ascott/superset/contributors","subscribers_url":"https://api.github.com/repos/ascott/superset/subscribers","subscription_url":"https://api.github.com/repos/ascott/superset/subscription","commits_url":"https://api.github.com/repos/ascott/superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/ascott/superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/ascott/superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/ascott/superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/ascott/superset/contents/{+path}","compare_url":"https://api.github.com/repos/ascott/superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ascott/superset/merges","archive_url":"https://api.github.com/repos/ascott/superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ascott/superset/downloads","issues_url":"https://api.github.com/repos/ascott/superset/issues{/number}","pulls_url":"https://api.github.com/repos/ascott/superset/pulls{/number}","milestones_url":"https://api.github.com/repos/ascott/superset/milestones{/number}","notifications_url":"https://api.github.com/repos/ascott/superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ascott/superset/labels{/name}","releases_url":"https://api.github.com/repos/ascott/superset/releases{/id}","deployments_url":"https://api.github.com/repos/ascott/superset/deployments","created_at":"2016-11-11T18:43:15Z","updated_at":"2016-11-11T18:43:18Z","pushed_at":"2016-11-17T06:33:13Z","git_url":"git://github.com/ascott/superset.git","ssh_url":"git@github.com:ascott/superset.git","clone_url":"https://github.com/ascott/superset.git","svn_url":"https://github.com/ascott/superset","homepage":"","size":41125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"7531bb89429547fb541c36fe365791cd742d82a1","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"superset","full_name":"airbnb/superset","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/superset","description":"Superset is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/superset","forks_url":"https://api.github.com/repos/airbnb/superset/forks","keys_url":"https://api.github.com/repos/airbnb/superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/superset/teams","hooks_url":"https://api.github.com/repos/airbnb/superset/hooks","issue_events_url":"https://api.github.com/repos/airbnb/superset/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/superset/events","assignees_url":"https://api.github.com/repos/airbnb/superset/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/superset/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/superset/tags","blobs_url":"https://api.github.com/repos/airbnb/superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/superset/languages","stargazers_url":"https://api.github.com/repos/airbnb/superset/stargazers","contributors_url":"https://api.github.com/repos/airbnb/superset/contributors","subscribers_url":"https://api.github.com/repos/airbnb/superset/subscribers","subscription_url":"https://api.github.com/repos/airbnb/superset/subscription","commits_url":"https://api.github.com/repos/airbnb/superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/superset/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/superset/merges","archive_url":"https://api.github.com/repos/airbnb/superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/superset/downloads","issues_url":"https://api.github.com/repos/airbnb/superset/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/superset/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/superset/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/superset/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/superset/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-11-17T17:29:18Z","pushed_at":"2016-11-17T17:26:25Z","git_url":"git://github.com/airbnb/superset.git","ssh_url":"git@github.com:airbnb/superset.git","clone_url":"https://github.com/airbnb/superset.git","svn_url":"https://github.com/airbnb/superset","homepage":"","size":46565,"stargazers_count":8130,"watchers_count":8130,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1010,"mirror_url":null,"open_issues_count":329,"forks":1010,"open_issues":329,"watchers":8130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1623"},"html":{"href":"https://github.com/airbnb/superset/pull/1623"},"issue":{"href":"https://api.github.com/repos/airbnb/superset/issues/1623"},"comments":{"href":"https://api.github.com/repos/airbnb/superset/issues/1623/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1623/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1623/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/superset/statuses/a2c964bbd6b9ec48a19ca29ee81eab7a8336dc87"}}}}
{"actor":{"display_login":"bkyryliuk"}}