{"action":"created","comment":{"url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/comments/64750045","id":64750045,"diff_hunk":"@@ -1,57 +1,76 @@\n-module Tmp\n ####################################\n-# Explicit Adam-Bashforth solvers\n+# Implicit Adam-Bashforth solvers\n ####################################\n # (Hairer & Wanner 1996, Vol I, p.357-358\n-include(\"ODE.jl\")\n \n-##Fixed step, fixed order, multistep explicit method\n \n-function ode_ab(F,y0, tspan,order ::Integer)\n-    if !(2 <= order <= 4)\n-        error(\"Currently only orders 2,3, and 4 are implemented for Adam-Bashforth method\")\n+##Function: ode_imp_ab(F,y0, tspan, order(optional))\n+##order is set to 4 by default\n+##Adam Bashforth is a fixed step, fixed order, multistep Implicit method\n+function ode_imp_ab(F::Function,y0, tspan,order=4 ::Integer)\n+    if (0 <= order <= 3)\n+        coef = am_imp_coefficients3\n+        b = ms_coefficients4\n+    else\n+        #calculating higher order coefficients for implicit Adam Multon method\n+        coef = zeros(order+1, order+1)","path":"src/adam_bashforth.jl","position":23,"original_position":23,"commit_id":"eac554a0e9f1fa3f37567c11e787ab1ff96c6f39","original_commit_id":"eac554a0e9f1fa3f37567c11e787ab1ff96c6f39","user":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"body":"Yeah, this will be easier to read. I'll make the change.","created_at":"2016-05-26T14:00:40Z","updated_at":"2016-05-26T14:00:40Z","html_url":"https://github.com/obiajulu/ODE.jl/pull/1#discussion_r64750045","pull_request_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/comments/64750045"},"html":{"href":"https://github.com/obiajulu/ODE.jl/pull/1#discussion_r64750045"},"pull_request":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1","id":71328363,"html_url":"https://github.com/obiajulu/ODE.jl/pull/1","diff_url":"https://github.com/obiajulu/ODE.jl/pull/1.diff","patch_url":"https://github.com/obiajulu/ODE.jl/pull/1.patch","issue_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/1","number":1,"state":"open","locked":false,"title":"Initial work on Adam Bashforth methods","user":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"body":"First working build of Adam Bashforth methods integrated in local ODE.jl repo. I made a AdamBash module, which is mostly for testing purposes. It easily allowed me to include the solver 'ode_ab' in the test from test/runtests.jl  It passed the test. \r\n\r\n@mauro3 and @jiahao, it would be great to hear your thoughts and seek you advice for how I could best improve my coding practices, especially to suite existing Julia code best. I see this solver as more or less a warm up, and I think it's best to make the small, correctable mistakes here than later on!","created_at":"2016-05-25T04:17:36Z","updated_at":"2016-05-26T14:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71088df9fb58887b370cc3765d460c31b6cca743","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1/commits","review_comments_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1/comments","review_comment_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/1/comments","statuses_url":"https://api.github.com/repos/obiajulu/ODE.jl/statuses/eac554a0e9f1fa3f37567c11e787ab1ff96c6f39","head":{"label":"obiajulu:dev","ref":"dev","sha":"eac554a0e9f1fa3f37567c11e787ab1ff96c6f39","user":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"repo":{"id":59492718,"name":"ODE.jl","full_name":"obiajulu/ODE.jl","owner":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obiajulu/ODE.jl","description":"Assorted basic Ordinary Differential Equation solvers","fork":true,"url":"https://api.github.com/repos/obiajulu/ODE.jl","forks_url":"https://api.github.com/repos/obiajulu/ODE.jl/forks","keys_url":"https://api.github.com/repos/obiajulu/ODE.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obiajulu/ODE.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obiajulu/ODE.jl/teams","hooks_url":"https://api.github.com/repos/obiajulu/ODE.jl/hooks","issue_events_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/events{/number}","events_url":"https://api.github.com/repos/obiajulu/ODE.jl/events","assignees_url":"https://api.github.com/repos/obiajulu/ODE.jl/assignees{/user}","branches_url":"https://api.github.com/repos/obiajulu/ODE.jl/branches{/branch}","tags_url":"https://api.github.com/repos/obiajulu/ODE.jl/tags","blobs_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obiajulu/ODE.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/obiajulu/ODE.jl/languages","stargazers_url":"https://api.github.com/repos/obiajulu/ODE.jl/stargazers","contributors_url":"https://api.github.com/repos/obiajulu/ODE.jl/contributors","subscribers_url":"https://api.github.com/repos/obiajulu/ODE.jl/subscribers","subscription_url":"https://api.github.com/repos/obiajulu/ODE.jl/subscription","commits_url":"https://api.github.com/repos/obiajulu/ODE.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/obiajulu/ODE.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/obiajulu/ODE.jl/contents/{+path}","compare_url":"https://api.github.com/repos/obiajulu/ODE.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obiajulu/ODE.jl/merges","archive_url":"https://api.github.com/repos/obiajulu/ODE.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obiajulu/ODE.jl/downloads","issues_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues{/number}","pulls_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/obiajulu/ODE.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/obiajulu/ODE.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obiajulu/ODE.jl/labels{/name}","releases_url":"https://api.github.com/repos/obiajulu/ODE.jl/releases{/id}","deployments_url":"https://api.github.com/repos/obiajulu/ODE.jl/deployments","created_at":"2016-05-23T15:12:42Z","updated_at":"2016-05-23T15:12:55Z","pushed_at":"2016-05-25T21:54:42Z","git_url":"git://github.com/obiajulu/ODE.jl.git","ssh_url":"git@github.com:obiajulu/ODE.jl.git","clone_url":"https://github.com/obiajulu/ODE.jl.git","svn_url":"https://github.com/obiajulu/ODE.jl","homepage":null,"size":521,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"obiajulu:master","ref":"master","sha":"74b21a8eb20acaf93cf6dcb2498f825d88919d72","user":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"repo":{"id":59492718,"name":"ODE.jl","full_name":"obiajulu/ODE.jl","owner":{"login":"obiajulu","id":12954944,"avatar_url":"https://avatars.githubusercontent.com/u/12954944?v=3","gravatar_id":"","url":"https://api.github.com/users/obiajulu","html_url":"https://github.com/obiajulu","followers_url":"https://api.github.com/users/obiajulu/followers","following_url":"https://api.github.com/users/obiajulu/following{/other_user}","gists_url":"https://api.github.com/users/obiajulu/gists{/gist_id}","starred_url":"https://api.github.com/users/obiajulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiajulu/subscriptions","organizations_url":"https://api.github.com/users/obiajulu/orgs","repos_url":"https://api.github.com/users/obiajulu/repos","events_url":"https://api.github.com/users/obiajulu/events{/privacy}","received_events_url":"https://api.github.com/users/obiajulu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obiajulu/ODE.jl","description":"Assorted basic Ordinary Differential Equation solvers","fork":true,"url":"https://api.github.com/repos/obiajulu/ODE.jl","forks_url":"https://api.github.com/repos/obiajulu/ODE.jl/forks","keys_url":"https://api.github.com/repos/obiajulu/ODE.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obiajulu/ODE.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obiajulu/ODE.jl/teams","hooks_url":"https://api.github.com/repos/obiajulu/ODE.jl/hooks","issue_events_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/events{/number}","events_url":"https://api.github.com/repos/obiajulu/ODE.jl/events","assignees_url":"https://api.github.com/repos/obiajulu/ODE.jl/assignees{/user}","branches_url":"https://api.github.com/repos/obiajulu/ODE.jl/branches{/branch}","tags_url":"https://api.github.com/repos/obiajulu/ODE.jl/tags","blobs_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obiajulu/ODE.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/obiajulu/ODE.jl/languages","stargazers_url":"https://api.github.com/repos/obiajulu/ODE.jl/stargazers","contributors_url":"https://api.github.com/repos/obiajulu/ODE.jl/contributors","subscribers_url":"https://api.github.com/repos/obiajulu/ODE.jl/subscribers","subscription_url":"https://api.github.com/repos/obiajulu/ODE.jl/subscription","commits_url":"https://api.github.com/repos/obiajulu/ODE.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/obiajulu/ODE.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/obiajulu/ODE.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/obiajulu/ODE.jl/contents/{+path}","compare_url":"https://api.github.com/repos/obiajulu/ODE.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obiajulu/ODE.jl/merges","archive_url":"https://api.github.com/repos/obiajulu/ODE.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obiajulu/ODE.jl/downloads","issues_url":"https://api.github.com/repos/obiajulu/ODE.jl/issues{/number}","pulls_url":"https://api.github.com/repos/obiajulu/ODE.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/obiajulu/ODE.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/obiajulu/ODE.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obiajulu/ODE.jl/labels{/name}","releases_url":"https://api.github.com/repos/obiajulu/ODE.jl/releases{/id}","deployments_url":"https://api.github.com/repos/obiajulu/ODE.jl/deployments","created_at":"2016-05-23T15:12:42Z","updated_at":"2016-05-23T15:12:55Z","pushed_at":"2016-05-25T21:54:42Z","git_url":"git://github.com/obiajulu/ODE.jl.git","ssh_url":"git@github.com:obiajulu/ODE.jl.git","clone_url":"https://github.com/obiajulu/ODE.jl.git","svn_url":"https://github.com/obiajulu/ODE.jl","homepage":null,"size":521,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1"},"html":{"href":"https://github.com/obiajulu/ODE.jl/pull/1"},"issue":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/issues/1"},"comments":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/obiajulu/ODE.jl/statuses/eac554a0e9f1fa3f37567c11e787ab1ff96c6f39"}}}}
{"actor":{"display_login":"obiajulu"}}