{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/55889875","id":55889875,"diff_hunk":"@@ -64,10 +83,86 @@ private[sql] class SparkQl(conf: ParserConf = SimpleParserConf()) extends Cataly\n         val tableIdent = extractTableIdent(nameParts)\n         RefreshTable(tableIdent)\n \n+      // CREATE DATABASE [IF NOT EXISTS] database_name [COMMENT database_comment]\n+      // [LOCATION path] [WITH DBPROPERTIES (key1=val1, key2=val2, ...)];\n+      case Token(\"TOK_CREATEDATABASE\", Token(databaseName, Nil) :: args) =>\n+        val Seq(ifNotExists, dbLocation, databaseComment, dbprops) = getClauses(Seq(\n+          \"TOK_IFNOTEXISTS\",\n+          \"TOK_DATABASELOCATION\",\n+          \"TOK_DATABASECOMMENT\",\n+          \"TOK_DATABASEPROPERTIES\"), args)\n+        val location = dbLocation.map {\n+          case Token(\"TOK_DATABASELOCATION\", Token(loc, Nil) :: Nil) => unquoteString(loc)\n+          case _ => parseFailed(\"Invalid CREATE DATABASE command\", node)\n+        }\n+        val comment = databaseComment.map {\n+          case Token(\"TOK_DATABASECOMMENT\", Token(com, Nil) :: Nil) => unquoteString(com)\n+          case _ => parseFailed(\"Invalid CREATE DATABASE command\", node)\n+        }\n+        val props = dbprops.toSeq.flatMap {\n+          case Token(\"TOK_DATABASEPROPERTIES\", Token(\"TOK_DBPROPLIST\", propList) :: Nil) =>\n+            extractProps(propList, \"TOK_TABLEPROPERTY\")","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala","position":50,"original_position":50,"commit_id":"bd91b0f3c850da796b22c7e575658625d2486057","original_commit_id":"bd91b0f3c850da796b22c7e575658625d2486057","user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"body":"Maybe it will be also good to provide an example format like what we have for `TOK_CREATEFUNCTION`?","created_at":"2016-03-11T21:17:49Z","updated_at":"2016-03-11T21:17:49Z","html_url":"https://github.com/apache/spark/pull/11573#discussion_r55889875","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/11573","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/55889875"},"html":{"href":"https://github.com/apache/spark/pull/11573#discussion_r55889875"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/11573"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/11573","id":62024596,"html_url":"https://github.com/apache/spark/pull/11573","diff_url":"https://github.com/apache/spark/pull/11573.diff","patch_url":"https://github.com/apache/spark/pull/11573.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/11573","number":11573,"state":"open","locked":false,"title":"[SPARK-13139][SQL] Parse Hive DDL commands ourselves","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis patch is ported over from @viirya's changes in #11048. Currently for most DDLs we just pass the query text directly to Hive. Instead, we should parse these commands ourselves and in the future (not part of this patch) use the `HiveCatalog` to process these DDLs. This is a pretext to merging `SQLContext` and `HiveContext`.\r\n\r\nNote: As of this patch we still pass the query text to Hive. The difference is that we now parse the commands ourselves so in the future we can just use our own catalog.\r\n\r\n## How was this patch tested?\r\n\r\nJenkins, new `DDLCommandSuite`, which comprises of about 40% of the changes here.\r\n","created_at":"2016-03-08T04:53:49Z","updated_at":"2016-03-11T21:17:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac40616b360325e2e52b2159daece99b8cd05f4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/11573/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/11573/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/11573/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/bd91b0f3c850da796b22c7e575658625d2486057","head":{"label":"andrewor14:parser-plus-plus","ref":"parser-plus-plus","sha":"bd91b0f3c850da796b22c7e575658625d2486057","user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"repo":{"id":17231517,"name":"spark","full_name":"andrewor14/spark","owner":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewor14/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/andrewor14/spark","forks_url":"https://api.github.com/repos/andrewor14/spark/forks","keys_url":"https://api.github.com/repos/andrewor14/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewor14/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewor14/spark/teams","hooks_url":"https://api.github.com/repos/andrewor14/spark/hooks","issue_events_url":"https://api.github.com/repos/andrewor14/spark/issues/events{/number}","events_url":"https://api.github.com/repos/andrewor14/spark/events","assignees_url":"https://api.github.com/repos/andrewor14/spark/assignees{/user}","branches_url":"https://api.github.com/repos/andrewor14/spark/branches{/branch}","tags_url":"https://api.github.com/repos/andrewor14/spark/tags","blobs_url":"https://api.github.com/repos/andrewor14/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewor14/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewor14/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewor14/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewor14/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewor14/spark/languages","stargazers_url":"https://api.github.com/repos/andrewor14/spark/stargazers","contributors_url":"https://api.github.com/repos/andrewor14/spark/contributors","subscribers_url":"https://api.github.com/repos/andrewor14/spark/subscribers","subscription_url":"https://api.github.com/repos/andrewor14/spark/subscription","commits_url":"https://api.github.com/repos/andrewor14/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewor14/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewor14/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewor14/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewor14/spark/contents/{+path}","compare_url":"https://api.github.com/repos/andrewor14/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewor14/spark/merges","archive_url":"https://api.github.com/repos/andrewor14/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewor14/spark/downloads","issues_url":"https://api.github.com/repos/andrewor14/spark/issues{/number}","pulls_url":"https://api.github.com/repos/andrewor14/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewor14/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewor14/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewor14/spark/labels{/name}","releases_url":"https://api.github.com/repos/andrewor14/spark/releases{/id}","deployments_url":"https://api.github.com/repos/andrewor14/spark/deployments","created_at":"2014-02-27T00:52:37Z","updated_at":"2015-05-08T06:53:12Z","pushed_at":"2016-03-11T19:50:11Z","git_url":"git://github.com/andrewor14/spark.git","ssh_url":"git@github.com:andrewor14/spark.git","clone_url":"https://github.com/andrewor14/spark.git","svn_url":"https://github.com/andrewor14/spark","homepage":null,"size":159226,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"073bf9d4d91e0242a813f3d227e52e76c26a2200","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-03-11T20:43:24Z","pushed_at":"2016-03-11T20:59:07Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":440207,"stargazers_count":7769,"watchers_count":7769,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7085,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":390,"forks":7085,"open_issues":390,"watchers":7769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/11573"},"html":{"href":"https://github.com/apache/spark/pull/11573"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/11573"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/11573/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/11573/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/11573/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/bd91b0f3c850da796b22c7e575658625d2486057"}}}}