{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/dockyard/ember-cart/pulls/21","id":56513571,"html_url":"https://github.com/dockyard/ember-cart/pull/21","diff_url":"https://github.com/dockyard/ember-cart/pull/21.diff","patch_url":"https://github.com/dockyard/ember-cart/pull/21.patch","issue_url":"https://api.github.com/repos/dockyard/ember-cart/issues/21","number":21,"state":"open","locked":false,"title":"Fix isServiceFactory deprecation with Ember 1.13","user":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"body":"Since Ember 1.13, Ember expects that services either extend `Ember.Service`, or they should set `isServiceFactory` to `true` at the class level. Since the Cart service already extends `ArrayProxy`, this commit reopens the Cart service class to set `isServiceFactory` to `true`.\r\n\r\nSee https://github.com/emberjs/ember.js/pull/11261\r\n\r\nI noticed this from a deprecation warning in a 1.13.x ember app that depends on `ember-cart`.","created_at":"2016-01-19T19:31:39Z","updated_at":"2016-01-19T19:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dockyard/ember-cart/pulls/21/commits","review_comments_url":"https://api.github.com/repos/dockyard/ember-cart/pulls/21/comments","review_comment_url":"https://api.github.com/repos/dockyard/ember-cart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dockyard/ember-cart/issues/21/comments","statuses_url":"https://api.github.com/repos/dockyard/ember-cart/statuses/aeae23b0f88a929f16f0589ada0d226369f17f9c","head":{"label":"iancanderson:ia-service-factory-deprecation","ref":"ia-service-factory-deprecation","sha":"aeae23b0f88a929f16f0589ada0d226369f17f9c","user":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"repo":{"id":49976800,"name":"ember-cart","full_name":"iancanderson/ember-cart","owner":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iancanderson/ember-cart","description":"Shopping cart primitives for Ember","fork":true,"url":"https://api.github.com/repos/iancanderson/ember-cart","forks_url":"https://api.github.com/repos/iancanderson/ember-cart/forks","keys_url":"https://api.github.com/repos/iancanderson/ember-cart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iancanderson/ember-cart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iancanderson/ember-cart/teams","hooks_url":"https://api.github.com/repos/iancanderson/ember-cart/hooks","issue_events_url":"https://api.github.com/repos/iancanderson/ember-cart/issues/events{/number}","events_url":"https://api.github.com/repos/iancanderson/ember-cart/events","assignees_url":"https://api.github.com/repos/iancanderson/ember-cart/assignees{/user}","branches_url":"https://api.github.com/repos/iancanderson/ember-cart/branches{/branch}","tags_url":"https://api.github.com/repos/iancanderson/ember-cart/tags","blobs_url":"https://api.github.com/repos/iancanderson/ember-cart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iancanderson/ember-cart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iancanderson/ember-cart/git/refs{/sha}","trees_url":"https://api.github.com/repos/iancanderson/ember-cart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iancanderson/ember-cart/statuses/{sha}","languages_url":"https://api.github.com/repos/iancanderson/ember-cart/languages","stargazers_url":"https://api.github.com/repos/iancanderson/ember-cart/stargazers","contributors_url":"https://api.github.com/repos/iancanderson/ember-cart/contributors","subscribers_url":"https://api.github.com/repos/iancanderson/ember-cart/subscribers","subscription_url":"https://api.github.com/repos/iancanderson/ember-cart/subscription","commits_url":"https://api.github.com/repos/iancanderson/ember-cart/commits{/sha}","git_commits_url":"https://api.github.com/repos/iancanderson/ember-cart/git/commits{/sha}","comments_url":"https://api.github.com/repos/iancanderson/ember-cart/comments{/number}","issue_comment_url":"https://api.github.com/repos/iancanderson/ember-cart/issues/comments{/number}","contents_url":"https://api.github.com/repos/iancanderson/ember-cart/contents/{+path}","compare_url":"https://api.github.com/repos/iancanderson/ember-cart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iancanderson/ember-cart/merges","archive_url":"https://api.github.com/repos/iancanderson/ember-cart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iancanderson/ember-cart/downloads","issues_url":"https://api.github.com/repos/iancanderson/ember-cart/issues{/number}","pulls_url":"https://api.github.com/repos/iancanderson/ember-cart/pulls{/number}","milestones_url":"https://api.github.com/repos/iancanderson/ember-cart/milestones{/number}","notifications_url":"https://api.github.com/repos/iancanderson/ember-cart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iancanderson/ember-cart/labels{/name}","releases_url":"https://api.github.com/repos/iancanderson/ember-cart/releases{/id}","created_at":"2016-01-19T19:19:48Z","updated_at":"2016-01-19T19:19:49Z","pushed_at":"2016-01-19T19:29:40Z","git_url":"git://github.com/iancanderson/ember-cart.git","ssh_url":"git@github.com:iancanderson/ember-cart.git","clone_url":"https://github.com/iancanderson/ember-cart.git","svn_url":"https://github.com/iancanderson/ember-cart","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dockyard:master","ref":"master","sha":"6138d9696da6d1892ac243ed67ee9752bfb5cf63","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":36623155,"name":"ember-cart","full_name":"dockyard/ember-cart","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/ember-cart","description":"Shopping cart primitives for Ember","fork":false,"url":"https://api.github.com/repos/dockyard/ember-cart","forks_url":"https://api.github.com/repos/dockyard/ember-cart/forks","keys_url":"https://api.github.com/repos/dockyard/ember-cart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/ember-cart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/ember-cart/teams","hooks_url":"https://api.github.com/repos/dockyard/ember-cart/hooks","issue_events_url":"https://api.github.com/repos/dockyard/ember-cart/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/ember-cart/events","assignees_url":"https://api.github.com/repos/dockyard/ember-cart/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/ember-cart/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/ember-cart/tags","blobs_url":"https://api.github.com/repos/dockyard/ember-cart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/ember-cart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/ember-cart/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/ember-cart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/ember-cart/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/ember-cart/languages","stargazers_url":"https://api.github.com/repos/dockyard/ember-cart/stargazers","contributors_url":"https://api.github.com/repos/dockyard/ember-cart/contributors","subscribers_url":"https://api.github.com/repos/dockyard/ember-cart/subscribers","subscription_url":"https://api.github.com/repos/dockyard/ember-cart/subscription","commits_url":"https://api.github.com/repos/dockyard/ember-cart/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/ember-cart/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/ember-cart/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/ember-cart/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockyard/ember-cart/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/ember-cart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/ember-cart/merges","archive_url":"https://api.github.com/repos/dockyard/ember-cart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/ember-cart/downloads","issues_url":"https://api.github.com/repos/dockyard/ember-cart/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/ember-cart/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/ember-cart/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/ember-cart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/ember-cart/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/ember-cart/releases{/id}","created_at":"2015-05-31T21:33:43Z","updated_at":"2016-01-15T10:55:06Z","pushed_at":"2015-08-21T20:56:03Z","git_url":"git://github.com/dockyard/ember-cart.git","ssh_url":"git@github.com:dockyard/ember-cart.git","clone_url":"https://github.com/dockyard/ember-cart.git","svn_url":"https://github.com/dockyard/ember-cart","homepage":null,"size":260,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dockyard/ember-cart/pulls/21"},"html":{"href":"https://github.com/dockyard/ember-cart/pull/21"},"issue":{"href":"https://api.github.com/repos/dockyard/ember-cart/issues/21"},"comments":{"href":"https://api.github.com/repos/dockyard/ember-cart/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/dockyard/ember-cart/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/dockyard/ember-cart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dockyard/ember-cart/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/dockyard/ember-cart/statuses/aeae23b0f88a929f16f0589ada0d226369f17f9c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}