{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/comments/83066546","pull_request_review_id":3931362,"id":83066546,"diff_hunk":"@@ -6,6 +6,36 @@\n     subnets: \"{{ private_subnets }}\"\n \n - block:\n+    - name: Create postgres rds parameter group\n+      rds_param_group:\n+        name: 'postgres-db-params-{{ target }}'\n+        state: present\n+        engine: postgres9.3\n+        params: {'log_statement': 'none' }\n+        description: 'default postgres rds parameter group'\n+      register: postgres_param_group\n+\n+    #params added using awscli due to https://github.com/boto/boto/pull/3533\n+    - name: Add params to group\n+      command: \"aws rds modify-db-parameter-group --cli-input-json {{ postgres_params }}\"\n+      register: postgres_params\n+      failed_when: postgres_params.rc != 0\n+      changed_when: \"postgres_params.rc == 0\"\n+      when: postgres_param_group|changed\n+\n+  when: \"{{ rds_dbs | selectattr('db_engine', 'match', 'postgres')| list |count > 0 }}\"\n+\n+- name: Create mysql rds parameter group\n+  rds_param_group:\n+    name: 'mysql-db-params-{{ target }}'\n+    params: \"{{ mysql_params }}\"\n+    state: present\n+    engine: mysql5.5","path":"roles/ec2-app/tasks/rds.yml","position":28,"original_position":28,"commit_id":"72637b4cfabd6ec5d3012292928e721600ff43a4","original_commit_id":"72637b4cfabd6ec5d3012292928e721600ff43a4","user":{"login":"brettminnie","id":6124248,"avatar_url":"https://avatars.githubusercontent.com/u/6124248?v=3","gravatar_id":"","url":"https://api.github.com/users/brettminnie","html_url":"https://github.com/brettminnie","followers_url":"https://api.github.com/users/brettminnie/followers","following_url":"https://api.github.com/users/brettminnie/following{/other_user}","gists_url":"https://api.github.com/users/brettminnie/gists{/gist_id}","starred_url":"https://api.github.com/users/brettminnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettminnie/subscriptions","organizations_url":"https://api.github.com/users/brettminnie/orgs","repos_url":"https://api.github.com/users/brettminnie/repos","events_url":"https://api.github.com/users/brettminnie/events{/privacy}","received_events_url":"https://api.github.com/users/brettminnie/received_events","type":"User","site_admin":false},"body":"Likewise should this version not be a var","created_at":"2016-10-12T18:16:46Z","updated_at":"2016-10-12T18:17:09Z","html_url":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5#discussion_r83066546","pull_request_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/comments/83066546"},"html":{"href":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5#discussion_r83066546"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5","id":89058319,"html_url":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5","diff_url":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5.diff","patch_url":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5.patch","issue_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/5","number":5,"state":"open","locked":false,"title":"Opgops 1549","user":{"login":"tim-mcarthur-moj","id":17139613,"avatar_url":"https://avatars.githubusercontent.com/u/17139613?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-mcarthur-moj","html_url":"https://github.com/tim-mcarthur-moj","followers_url":"https://api.github.com/users/tim-mcarthur-moj/followers","following_url":"https://api.github.com/users/tim-mcarthur-moj/following{/other_user}","gists_url":"https://api.github.com/users/tim-mcarthur-moj/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-mcarthur-moj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-mcarthur-moj/subscriptions","organizations_url":"https://api.github.com/users/tim-mcarthur-moj/orgs","repos_url":"https://api.github.com/users/tim-mcarthur-moj/repos","events_url":"https://api.github.com/users/tim-mcarthur-moj/events{/privacy}","received_events_url":"https://api.github.com/users/tim-mcarthur-moj/received_events","type":"User","site_admin":false},"body":"Add rds parameter group for slow logging settings","created_at":"2016-10-12T17:28:57Z","updated_at":"2016-10-12T18:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4337be03ef36f18d6d7e13e542f3a6c346a2b325","assignee":{"login":"allensea","id":1949473,"avatar_url":"https://avatars.githubusercontent.com/u/1949473?v=3","gravatar_id":"","url":"https://api.github.com/users/allensea","html_url":"https://github.com/allensea","followers_url":"https://api.github.com/users/allensea/followers","following_url":"https://api.github.com/users/allensea/following{/other_user}","gists_url":"https://api.github.com/users/allensea/gists{/gist_id}","starred_url":"https://api.github.com/users/allensea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allensea/subscriptions","organizations_url":"https://api.github.com/users/allensea/orgs","repos_url":"https://api.github.com/users/allensea/repos","events_url":"https://api.github.com/users/allensea/events{/privacy}","received_events_url":"https://api.github.com/users/allensea/received_events","type":"User","site_admin":false},"assignees":[{"login":"allensea","id":1949473,"avatar_url":"https://avatars.githubusercontent.com/u/1949473?v=3","gravatar_id":"","url":"https://api.github.com/users/allensea","html_url":"https://github.com/allensea","followers_url":"https://api.github.com/users/allensea/followers","following_url":"https://api.github.com/users/allensea/following{/other_user}","gists_url":"https://api.github.com/users/allensea/gists{/gist_id}","starred_url":"https://api.github.com/users/allensea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allensea/subscriptions","organizations_url":"https://api.github.com/users/allensea/orgs","repos_url":"https://api.github.com/users/allensea/repos","events_url":"https://api.github.com/users/allensea/events{/privacy}","received_events_url":"https://api.github.com/users/allensea/received_events","type":"User","site_admin":false},{"login":"brettminnie","id":6124248,"avatar_url":"https://avatars.githubusercontent.com/u/6124248?v=3","gravatar_id":"","url":"https://api.github.com/users/brettminnie","html_url":"https://github.com/brettminnie","followers_url":"https://api.github.com/users/brettminnie/followers","following_url":"https://api.github.com/users/brettminnie/following{/other_user}","gists_url":"https://api.github.com/users/brettminnie/gists{/gist_id}","starred_url":"https://api.github.com/users/brettminnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettminnie/subscriptions","organizations_url":"https://api.github.com/users/brettminnie/orgs","repos_url":"https://api.github.com/users/brettminnie/repos","events_url":"https://api.github.com/users/brettminnie/events{/privacy}","received_events_url":"https://api.github.com/users/brettminnie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/5/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/statuses/72637b4cfabd6ec5d3012292928e721600ff43a4","head":{"label":"ministryofjustice:OPGOPS-1549","ref":"OPGOPS-1549","sha":"72637b4cfabd6ec5d3012292928e721600ff43a4","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":62559370,"name":"opg-ansible-roles","full_name":"ministryofjustice/opg-ansible-roles","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/opg-ansible-roles","description":"A collection of ansible roles to be used in provisioning an environment in AWS","fork":false,"url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles","forks_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/forks","keys_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/events","assignees_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/merges","archive_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/deployments","created_at":"2016-07-04T12:09:02Z","updated_at":"2016-07-04T12:26:03Z","pushed_at":"2016-10-12T17:28:57Z","git_url":"git://github.com/ministryofjustice/opg-ansible-roles.git","ssh_url":"git@github.com:ministryofjustice/opg-ansible-roles.git","clone_url":"https://github.com/ministryofjustice/opg-ansible-roles.git","svn_url":"https://github.com/ministryofjustice/opg-ansible-roles","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"dc12ff03cb718adbf4788f4b33535bf6d392d761","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":62559370,"name":"opg-ansible-roles","full_name":"ministryofjustice/opg-ansible-roles","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/opg-ansible-roles","description":"A collection of ansible roles to be used in provisioning an environment in AWS","fork":false,"url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles","forks_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/forks","keys_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/events","assignees_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/merges","archive_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/deployments","created_at":"2016-07-04T12:09:02Z","updated_at":"2016-07-04T12:26:03Z","pushed_at":"2016-10-12T17:28:57Z","git_url":"git://github.com/ministryofjustice/opg-ansible-roles.git","ssh_url":"git@github.com:ministryofjustice/opg-ansible-roles.git","clone_url":"https://github.com/ministryofjustice/opg-ansible-roles.git","svn_url":"https://github.com/ministryofjustice/opg-ansible-roles","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5"},"html":{"href":"https://github.com/ministryofjustice/opg-ansible-roles/pull/5"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/5"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/opg-ansible-roles/statuses/72637b4cfabd6ec5d3012292928e721600ff43a4"}}}}
{"actor":{"display_login":"brettminnie"}}