{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1499","repository_url":"https://api.github.com/repos/rockstor/rockstor-core","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1499/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1499/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1499/events","html_url":"https://github.com/rockstor/rockstor-core/pull/1499","id":185178781,"number":1499,"title":"null value in column \"details\" when parsing smart error log. Fixes #1498","user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-25T17:13:03Z","updated_at":"2016-10-25T17:18:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1499","html_url":"https://github.com/rockstor/rockstor-core/pull/1499","diff_url":"https://github.com/rockstor/rockstor-core/pull/1499.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1499.patch"},"body":"Using the smartctl outputs supplied by forum member alexey it was found that when no details are specified in the \"smartctl -l error\" output the resulting 'details' list element was given a \"None\" value, this caused an exception in the Web-UI code. The solution presented in this pull request involves replacing the None attribution to the 'details' list element with a string = 'No Sector Details Available'.\r\n\r\nThis change circumvents the \"null value in column \"details\" violates not-null constraint ...\" error and also informs the user via the details column that no such information is available.\r\n\r\nFixes #1498 \r\n\r\nThanks to alexey in the following forum thread for contributing the required smartctl outputs:\r\nhttps://forum.rockstor.com/t/smart-not-working/2137\r\n\r\nThe resulting code was tested both on the supplied smartctl dumps and on a qemu SATA drive emulation and on a real drive that had existing \"smartctl -l error\" log entries and a real drive that had not error log entries. All parsing was as expected with no observed regression.\r\n\r\nReady for review."},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/256100563","html_url":"https://github.com/rockstor/rockstor-core/pull/1499#issuecomment-256100563","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1499","id":256100563,"user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T17:18:47Z","updated_at":"2016-10-25T17:18:47Z","body":"Please see issue #1498 for details of the \"smartctl -l error\" output that triggered the rouge behaviour."}}
{"actor":{"display_login":"phillxnet"}}