{"action":"closed","number":297,"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/297","id":95327092,"html_url":"https://github.com/lagom/lagom/pull/297","diff_url":"https://github.com/lagom/lagom/pull/297.diff","patch_url":"https://github.com/lagom/lagom/pull/297.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/297","number":297,"state":"closed","locked":false,"title":"Adds OptionalSerializer (branch 1.2.x)","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"Fixes #277\r\n\r\nThe `OptionalSerializer` will use `Serializer`'s `includeManifest` to decide what manifest should be created. At the moment, is a manifest is required, the `Serializer` will be cast to a `SerializerWithStringManifest`. If when we support more `Serializer` using a manifest this casting will fail.\r\n\r\n@james, please review file location wrt package and module.","created_at":"2016-11-25T16:22:28Z","updated_at":"2016-12-12T09:28:09Z","closed_at":"2016-12-12T09:28:09Z","merged_at":null,"merge_commit_sha":"2831758709998b46539169686413a869c3eea34d","assignee":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"assignees":[{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/297/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/297/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/297/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/c8fc5dac7ba00cad72c9d876edb243348fff852d","head":{"label":"ignasi35:support-javautiloptional-on-persistent-entity-277","ref":"support-javautiloptional-on-persistent-entity-277","sha":"c8fc5dac7ba00cad72c9d876edb243348fff852d","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"repo":{"id":72645230,"name":"lagom","full_name":"ignasi35/lagom","owner":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignasi35/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/ignasi35/lagom","forks_url":"https://api.github.com/repos/ignasi35/lagom/forks","keys_url":"https://api.github.com/repos/ignasi35/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignasi35/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignasi35/lagom/teams","hooks_url":"https://api.github.com/repos/ignasi35/lagom/hooks","issue_events_url":"https://api.github.com/repos/ignasi35/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/ignasi35/lagom/events","assignees_url":"https://api.github.com/repos/ignasi35/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/ignasi35/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/ignasi35/lagom/tags","blobs_url":"https://api.github.com/repos/ignasi35/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignasi35/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignasi35/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignasi35/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignasi35/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/ignasi35/lagom/languages","stargazers_url":"https://api.github.com/repos/ignasi35/lagom/stargazers","contributors_url":"https://api.github.com/repos/ignasi35/lagom/contributors","subscribers_url":"https://api.github.com/repos/ignasi35/lagom/subscribers","subscription_url":"https://api.github.com/repos/ignasi35/lagom/subscription","commits_url":"https://api.github.com/repos/ignasi35/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignasi35/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignasi35/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignasi35/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignasi35/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/ignasi35/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignasi35/lagom/merges","archive_url":"https://api.github.com/repos/ignasi35/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignasi35/lagom/downloads","issues_url":"https://api.github.com/repos/ignasi35/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/ignasi35/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/ignasi35/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/ignasi35/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignasi35/lagom/labels{/name}","releases_url":"https://api.github.com/repos/ignasi35/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/ignasi35/lagom/deployments","created_at":"2016-11-02T13:59:39Z","updated_at":"2016-11-02T13:59:43Z","pushed_at":"2016-12-09T11:27:46Z","git_url":"git://github.com/ignasi35/lagom.git","ssh_url":"git@github.com:ignasi35/lagom.git","clone_url":"https://github.com/ignasi35/lagom.git","svn_url":"https://github.com/ignasi35/lagom","homepage":"https://lightbend.com/lagom","size":2543,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:1.2.x","ref":"1.2.x","sha":"663f0eedcc4dc35ea28ee3ec7779f908ca083316","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2016-12-11T15:54:21Z","pushed_at":"2016-12-12T08:57:21Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://lightbend.com/lagom","size":3060,"stargazers_count":1007,"watchers_count":1007,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":57,"forks":165,"open_issues":57,"watchers":1007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/297"},"html":{"href":"https://github.com/lagom/lagom/pull/297"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/297"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/c8fc5dac7ba00cad72c9d876edb243348fff852d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":2,"commits":2,"additions":119,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"jroper"}}