{"action":"created","issue":{"url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/64","repository_url":"https://api.github.com/repos/PitPik/tinyColorPicker","labels_url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/64/comments","events_url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/64/events","html_url":"https://github.com/PitPik/tinyColorPicker/issues/64","id":160207448,"number":64,"title":"error when bundling with webpack","user":{"login":"vishnu4","id":1782150,"avatar_url":"https://avatars.githubusercontent.com/u/1782150?v=3","gravatar_id":"","url":"https://api.github.com/users/vishnu4","html_url":"https://github.com/vishnu4","followers_url":"https://api.github.com/users/vishnu4/followers","following_url":"https://api.github.com/users/vishnu4/following{/other_user}","gists_url":"https://api.github.com/users/vishnu4/gists{/gist_id}","starred_url":"https://api.github.com/users/vishnu4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishnu4/subscriptions","organizations_url":"https://api.github.com/users/vishnu4/orgs","repos_url":"https://api.github.com/users/vishnu4/repos","events_url":"https://api.github.com/users/vishnu4/events{/privacy}","received_events_url":"https://api.github.com/users/vishnu4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-14T15:12:37Z","updated_at":"2016-06-30T15:51:18Z","closed_at":null,"body":"Trying to bundle colors.js and jqColorPicker.js with some other javascript files of mine into one file using webpack, and all the other files work except jqColorPicker, which gives me the following error:\r\n\r\nERROR in ./bower_components/tinyColorPicker/jqColorPicker.js\r\nModule not found: Error: Cannot resolve module 'colors' in C:\\Code\\StandardProject2020\\DEV\\Server\\MVC2\\CoBRAMVC4Portal\\bower_components\\tinyColorPicker\r\n @ ./bower_components/tinyColorPicker/jqColorPicker.js 3:58-75"},"comment":{"url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/comments/229702024","html_url":"https://github.com/PitPik/tinyColorPicker/issues/64#issuecomment-229702024","issue_url":"https://api.github.com/repos/PitPik/tinyColorPicker/issues/64","id":229702024,"user":{"login":"fredludlow","id":900535,"avatar_url":"https://avatars.githubusercontent.com/u/900535?v=3","gravatar_id":"","url":"https://api.github.com/users/fredludlow","html_url":"https://github.com/fredludlow","followers_url":"https://api.github.com/users/fredludlow/followers","following_url":"https://api.github.com/users/fredludlow/following{/other_user}","gists_url":"https://api.github.com/users/fredludlow/gists{/gist_id}","starred_url":"https://api.github.com/users/fredludlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredludlow/subscriptions","organizations_url":"https://api.github.com/users/fredludlow/orgs","repos_url":"https://api.github.com/users/fredludlow/repos","events_url":"https://api.github.com/users/fredludlow/events{/privacy}","received_events_url":"https://api.github.com/users/fredludlow/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T15:51:18Z","updated_at":"2016-06-30T15:51:18Z","body":"I had a few issues with commonJS style imports (browserify) - not sure if that's what webpack is using?\r\n\r\nSolution was to require(\"./colors.js\") rather than require(\"colors\") in line 3 of jqColorPicker.js. \r\nAlso needed to change the factory function signature from \r\n`function(window, $, Colors, undefined)` \r\nto \r\n`function(root, $, Colors, undefined)`\r\n\r\nI was planning to make a PR with this fix but I couldn't get it to work with the single minified file version so gave up... (I minify my whole bundle, but didn't want to make a PR that potentially breaks stuff for people including multiple minified files.)"}}
{"actor":{"display_login":"fredludlow"}}