{"action":"created","issue":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/5014","repository_url":"https://api.github.com/repos/bokeh/bokeh","labels_url":"https://api.github.com/repos/bokeh/bokeh/issues/5014/labels{/name}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/5014/comments","events_url":"https://api.github.com/repos/bokeh/bokeh/issues/5014/events","html_url":"https://github.com/bokeh/bokeh/pull/5014","id":172578214,"number":5014,"title":"Notebook output waits until bokehJS is loaded","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars.githubusercontent.com/u/1550771?v=3","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bokeh/bokeh/labels/status:%20WIP","name":"status: WIP","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-08-22T23:25:01Z","updated_at":"2016-08-26T19:55:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/5014","html_url":"https://github.com/bokeh/bokeh/pull/5014","diff_url":"https://github.com/bokeh/bokeh/pull/5014.diff","patch_url":"https://github.com/bokeh/bokeh/pull/5014.patch"},"body":"With this PR the code which initializes plots polls whether bokehJS is initialized, delaying rendering of the plot until it is fully loaded. It fixes the issue with Run All (#4987) and nbconvert works again (#4980). To test it you run ``output_notebook``, clear the notebook and reload the page to ensure bokehJS is no longer loaded and then display a plot. The plot will wait to display until you run ``output_notebook`` a second time to load bokehJS. \r\n\r\n- [x] Add a customizable timeout.\r\n- [x] Inject warning into DOM when timeout is reached.\r\n- [x] Update tests\r\n\r\nSince keeping around a registry of handles is quite expensive maybe there should be some way to explicitly request a comms handle to be created."},"comment":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/comments/242835294","html_url":"https://github.com/bokeh/bokeh/pull/5014#issuecomment-242835294","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/5014","id":242835294,"user":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars.githubusercontent.com/u/27600?v=3","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T19:55:41Z","updated_at":"2016-08-26T19:55:41Z","body":"How are you loading code on the page? The right way of doing it is to use something like require.js that will not run the code until all of the dependencies are loaded. If you are just throwing a script tag on the page, then you don't have any way of knowing when the code is ready."}}
{"actor":{"display_login":"ellisonbg"}}