{"action":"created","comment":{"url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/comments/53801041","id":53801041,"diff_hunk":"@@ -240,7 +240,10 @@ function dropDirective($parse) {\n         debugDroppable(scope, 'dragenter');\n \n         // Check if type is accepted.\n-        if (! accepts(scope.$eval(dropAccept), event)) return true;\n+        if (! accepts(scope.$eval(dropAccept), event)) {\n+          debugDroppable(scope, 'dragover rejected, draggable type not accepted');\n+          return true;\n+        }","path":"angular-draganddrop.js","position":8,"original_position":8,"commit_id":"fc5e9fc0b364a9c40a62c604e0d5750c1339932f","original_commit_id":"fc5e9fc0b364a9c40a62c604e0d5750c1339932f","user":{"login":"Yvem","id":481983,"avatar_url":"https://avatars.githubusercontent.com/u/481983?v=3","gravatar_id":"","url":"https://api.github.com/users/Yvem","html_url":"https://github.com/Yvem","followers_url":"https://api.github.com/users/Yvem/followers","following_url":"https://api.github.com/users/Yvem/following{/other_user}","gists_url":"https://api.github.com/users/Yvem/gists{/gist_id}","starred_url":"https://api.github.com/users/Yvem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yvem/subscriptions","organizations_url":"https://api.github.com/users/Yvem/orgs","repos_url":"https://api.github.com/users/Yvem/repos","events_url":"https://api.github.com/users/Yvem/events{/privacy}","received_events_url":"https://api.github.com/users/Yvem/received_events","type":"User","site_admin":false},"body":"ajouté le log sur les events de début de mauvais d&d mais pas sur les autres","created_at":"2016-02-23T16:01:58Z","updated_at":"2016-02-23T16:01:58Z","html_url":"https://github.com/lemonde/angular-draganddrop/pull/11#discussion_r53801041","pull_request_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/comments/53801041"},"html":{"href":"https://github.com/lemonde/angular-draganddrop/pull/11#discussion_r53801041"},"pull_request":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11","id":60362551,"html_url":"https://github.com/lemonde/angular-draganddrop/pull/11","diff_url":"https://github.com/lemonde/angular-draganddrop/pull/11.diff","patch_url":"https://github.com/lemonde/angular-draganddrop/pull/11.patch","issue_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/11","number":11,"state":"open","locked":false,"title":"bug: add missing type check in drop handler","user":{"login":"Yvem","id":481983,"avatar_url":"https://avatars.githubusercontent.com/u/481983?v=3","gravatar_id":"","url":"https://api.github.com/users/Yvem","html_url":"https://github.com/Yvem","followers_url":"https://api.github.com/users/Yvem/followers","following_url":"https://api.github.com/users/Yvem/following{/other_user}","gists_url":"https://api.github.com/users/Yvem/gists{/gist_id}","starred_url":"https://api.github.com/users/Yvem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yvem/subscriptions","organizations_url":"https://api.github.com/users/Yvem/orgs","repos_url":"https://api.github.com/users/Yvem/repos","events_url":"https://api.github.com/users/Yvem/events{/privacy}","received_events_url":"https://api.github.com/users/Yvem/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-23T16:01:09Z","updated_at":"2016-02-23T16:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146fdbc10d78d90b91d3c38892c30228b3b64dc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11/commits","review_comments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11/comments","review_comment_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/11/comments","statuses_url":"https://api.github.com/repos/lemonde/angular-draganddrop/statuses/fc5e9fc0b364a9c40a62c604e0d5750c1339932f","head":{"label":"lemonde:yvem-20160223-type_check","ref":"yvem-20160223-type_check","sha":"fc5e9fc0b364a9c40a62c604e0d5750c1339932f","user":{"login":"lemonde","id":1830638,"avatar_url":"https://avatars.githubusercontent.com/u/1830638?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonde","html_url":"https://github.com/lemonde","followers_url":"https://api.github.com/users/lemonde/followers","following_url":"https://api.github.com/users/lemonde/following{/other_user}","gists_url":"https://api.github.com/users/lemonde/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonde/subscriptions","organizations_url":"https://api.github.com/users/lemonde/orgs","repos_url":"https://api.github.com/users/lemonde/repos","events_url":"https://api.github.com/users/lemonde/events{/privacy}","received_events_url":"https://api.github.com/users/lemonde/received_events","type":"Organization","site_admin":false},"repo":{"id":31709861,"name":"angular-draganddrop","full_name":"lemonde/angular-draganddrop","owner":{"login":"lemonde","id":1830638,"avatar_url":"https://avatars.githubusercontent.com/u/1830638?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonde","html_url":"https://github.com/lemonde","followers_url":"https://api.github.com/users/lemonde/followers","following_url":"https://api.github.com/users/lemonde/following{/other_user}","gists_url":"https://api.github.com/users/lemonde/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonde/subscriptions","organizations_url":"https://api.github.com/users/lemonde/orgs","repos_url":"https://api.github.com/users/lemonde/repos","events_url":"https://api.github.com/users/lemonde/events{/privacy}","received_events_url":"https://api.github.com/users/lemonde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lemonde/angular-draganddrop","description":"Angular directive for drag and drop","fork":false,"url":"https://api.github.com/repos/lemonde/angular-draganddrop","forks_url":"https://api.github.com/repos/lemonde/angular-draganddrop/forks","keys_url":"https://api.github.com/repos/lemonde/angular-draganddrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lemonde/angular-draganddrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lemonde/angular-draganddrop/teams","hooks_url":"https://api.github.com/repos/lemonde/angular-draganddrop/hooks","issue_events_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/events{/number}","events_url":"https://api.github.com/repos/lemonde/angular-draganddrop/events","assignees_url":"https://api.github.com/repos/lemonde/angular-draganddrop/assignees{/user}","branches_url":"https://api.github.com/repos/lemonde/angular-draganddrop/branches{/branch}","tags_url":"https://api.github.com/repos/lemonde/angular-draganddrop/tags","blobs_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lemonde/angular-draganddrop/statuses/{sha}","languages_url":"https://api.github.com/repos/lemonde/angular-draganddrop/languages","stargazers_url":"https://api.github.com/repos/lemonde/angular-draganddrop/stargazers","contributors_url":"https://api.github.com/repos/lemonde/angular-draganddrop/contributors","subscribers_url":"https://api.github.com/repos/lemonde/angular-draganddrop/subscribers","subscription_url":"https://api.github.com/repos/lemonde/angular-draganddrop/subscription","commits_url":"https://api.github.com/repos/lemonde/angular-draganddrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/lemonde/angular-draganddrop/contents/{+path}","compare_url":"https://api.github.com/repos/lemonde/angular-draganddrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lemonde/angular-draganddrop/merges","archive_url":"https://api.github.com/repos/lemonde/angular-draganddrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lemonde/angular-draganddrop/downloads","issues_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues{/number}","pulls_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls{/number}","milestones_url":"https://api.github.com/repos/lemonde/angular-draganddrop/milestones{/number}","notifications_url":"https://api.github.com/repos/lemonde/angular-draganddrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lemonde/angular-draganddrop/labels{/name}","releases_url":"https://api.github.com/repos/lemonde/angular-draganddrop/releases{/id}","deployments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/deployments","created_at":"2015-03-05T11:00:22Z","updated_at":"2015-03-17T15:10:47Z","pushed_at":"2016-02-23T16:01:09Z","git_url":"git://github.com/lemonde/angular-draganddrop.git","ssh_url":"git@github.com:lemonde/angular-draganddrop.git","clone_url":"https://github.com/lemonde/angular-draganddrop.git","svn_url":"https://github.com/lemonde/angular-draganddrop","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"lemonde:master","ref":"master","sha":"4c9c0690bf93f77f2b225a08a00eedd247dc052f","user":{"login":"lemonde","id":1830638,"avatar_url":"https://avatars.githubusercontent.com/u/1830638?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonde","html_url":"https://github.com/lemonde","followers_url":"https://api.github.com/users/lemonde/followers","following_url":"https://api.github.com/users/lemonde/following{/other_user}","gists_url":"https://api.github.com/users/lemonde/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonde/subscriptions","organizations_url":"https://api.github.com/users/lemonde/orgs","repos_url":"https://api.github.com/users/lemonde/repos","events_url":"https://api.github.com/users/lemonde/events{/privacy}","received_events_url":"https://api.github.com/users/lemonde/received_events","type":"Organization","site_admin":false},"repo":{"id":31709861,"name":"angular-draganddrop","full_name":"lemonde/angular-draganddrop","owner":{"login":"lemonde","id":1830638,"avatar_url":"https://avatars.githubusercontent.com/u/1830638?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonde","html_url":"https://github.com/lemonde","followers_url":"https://api.github.com/users/lemonde/followers","following_url":"https://api.github.com/users/lemonde/following{/other_user}","gists_url":"https://api.github.com/users/lemonde/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonde/subscriptions","organizations_url":"https://api.github.com/users/lemonde/orgs","repos_url":"https://api.github.com/users/lemonde/repos","events_url":"https://api.github.com/users/lemonde/events{/privacy}","received_events_url":"https://api.github.com/users/lemonde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lemonde/angular-draganddrop","description":"Angular directive for drag and drop","fork":false,"url":"https://api.github.com/repos/lemonde/angular-draganddrop","forks_url":"https://api.github.com/repos/lemonde/angular-draganddrop/forks","keys_url":"https://api.github.com/repos/lemonde/angular-draganddrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lemonde/angular-draganddrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lemonde/angular-draganddrop/teams","hooks_url":"https://api.github.com/repos/lemonde/angular-draganddrop/hooks","issue_events_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/events{/number}","events_url":"https://api.github.com/repos/lemonde/angular-draganddrop/events","assignees_url":"https://api.github.com/repos/lemonde/angular-draganddrop/assignees{/user}","branches_url":"https://api.github.com/repos/lemonde/angular-draganddrop/branches{/branch}","tags_url":"https://api.github.com/repos/lemonde/angular-draganddrop/tags","blobs_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lemonde/angular-draganddrop/statuses/{sha}","languages_url":"https://api.github.com/repos/lemonde/angular-draganddrop/languages","stargazers_url":"https://api.github.com/repos/lemonde/angular-draganddrop/stargazers","contributors_url":"https://api.github.com/repos/lemonde/angular-draganddrop/contributors","subscribers_url":"https://api.github.com/repos/lemonde/angular-draganddrop/subscribers","subscription_url":"https://api.github.com/repos/lemonde/angular-draganddrop/subscription","commits_url":"https://api.github.com/repos/lemonde/angular-draganddrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/lemonde/angular-draganddrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/lemonde/angular-draganddrop/contents/{+path}","compare_url":"https://api.github.com/repos/lemonde/angular-draganddrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lemonde/angular-draganddrop/merges","archive_url":"https://api.github.com/repos/lemonde/angular-draganddrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lemonde/angular-draganddrop/downloads","issues_url":"https://api.github.com/repos/lemonde/angular-draganddrop/issues{/number}","pulls_url":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls{/number}","milestones_url":"https://api.github.com/repos/lemonde/angular-draganddrop/milestones{/number}","notifications_url":"https://api.github.com/repos/lemonde/angular-draganddrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lemonde/angular-draganddrop/labels{/name}","releases_url":"https://api.github.com/repos/lemonde/angular-draganddrop/releases{/id}","deployments_url":"https://api.github.com/repos/lemonde/angular-draganddrop/deployments","created_at":"2015-03-05T11:00:22Z","updated_at":"2015-03-17T15:10:47Z","pushed_at":"2016-02-23T16:01:09Z","git_url":"git://github.com/lemonde/angular-draganddrop.git","ssh_url":"git@github.com:lemonde/angular-draganddrop.git","clone_url":"https://github.com/lemonde/angular-draganddrop.git","svn_url":"https://github.com/lemonde/angular-draganddrop","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11"},"html":{"href":"https://github.com/lemonde/angular-draganddrop/pull/11"},"issue":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/11"},"comments":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/lemonde/angular-draganddrop/statuses/fc5e9fc0b364a9c40a62c604e0d5750c1339932f"}}}}