{"action":"created","issue":{"url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/41","repository_url":"https://api.github.com/repos/graphql-java/graphql-java-annotations","labels_url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/41/comments","events_url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/41/events","html_url":"https://github.com/graphql-java/graphql-java-annotations/issues/41","id":195076879,"number":41,"title":"Consider removing Lombok from implementation","user":{"login":"bbakerman","id":1661769,"avatar_url":"https://avatars.githubusercontent.com/u/1661769?v=3","gravatar_id":"","url":"https://api.github.com/users/bbakerman","html_url":"https://github.com/bbakerman","followers_url":"https://api.github.com/users/bbakerman/followers","following_url":"https://api.github.com/users/bbakerman/following{/other_user}","gists_url":"https://api.github.com/users/bbakerman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbakerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbakerman/subscriptions","organizations_url":"https://api.github.com/users/bbakerman/orgs","repos_url":"https://api.github.com/users/bbakerman/repos","events_url":"https://api.github.com/users/bbakerman/events{/privacy}","received_events_url":"https://api.github.com/users/bbakerman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-12T20:27:36Z","updated_at":"2016-12-12T20:35:46Z","closed_at":null,"body":"Could this project consider NOT use Lombok in the implementation of the library \r\n\r\nGood libraries tend to have a limited set of dependencies.  \r\n\r\nLombok is one of the most contentious dependencies out there because of its \"magic\" nature.\r\n\r\nWe have an informal ban on it inside my area in Atlassian because of debugging problems at runtime and the byte code weaving side of it at compile time.\r\n\r\nI would ask that this otherwise excellent library not use Lombok in its implementation.  I think this will increase its uptake, not just in my company but with others.\r\n\r\nI am in the process of creating a PR to see what the impact of removing Lombok would be."},"comment":{"url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/comments/266545098","html_url":"https://github.com/graphql-java/graphql-java-annotations/issues/41#issuecomment-266545098","issue_url":"https://api.github.com/repos/graphql-java/graphql-java-annotations/issues/41","id":266545098,"user":{"login":"yrashk","id":452,"avatar_url":"https://avatars.githubusercontent.com/u/452?v=3","gravatar_id":"","url":"https://api.github.com/users/yrashk","html_url":"https://github.com/yrashk","followers_url":"https://api.github.com/users/yrashk/followers","following_url":"https://api.github.com/users/yrashk/following{/other_user}","gists_url":"https://api.github.com/users/yrashk/gists{/gist_id}","starred_url":"https://api.github.com/users/yrashk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrashk/subscriptions","organizations_url":"https://api.github.com/users/yrashk/orgs","repos_url":"https://api.github.com/users/yrashk/repos","events_url":"https://api.github.com/users/yrashk/events{/privacy}","received_events_url":"https://api.github.com/users/yrashk/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T20:35:46Z","updated_at":"2016-12-12T20:35:46Z","body":"generally, removing lombok is as easy as running delombok on it, https://projectlombok.org/features/delombok.html\r\n\r\nOn my end, I think it might make sense to tweak these settings:\r\n\r\n```\r\n generated:\r\n    Either 'generate' or 'skip'. generate means: All lombok-generated\r\n    methods, types, and fields get a @Generated(\"lombok\") annotation.\r\n    Default: 'generate'\r\n  danceAroundIdeChecks:\r\n    Either 'generate' or 'skip'. generate means: Lombok will\r\n    intentionally obfuscate some generated code to avoid IDE warnings.\r\n    Default: 'generate'\r\n  generateDelombokComment:\r\n    Either 'generate' or 'skip'. generate means: Any file modified by\r\n    delombok will have a comment stating this at the top. Default:\r\n    'generate'\r\n```"}}
{"actor":{"display_login":"yrashk"}}