{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/72944246","id":72944246,"diff_hunk":"@@ -61,6 +69,9 @@ def install\n     else\n       system \"make\", \"install\"\n       system \"make\", \"install.info\"\n+      if build.with? \"texi2html\"\n+        system \"make\", \"install.html\"","path":"Formula/zsh.rb","position":26,"original_position":26,"commit_id":"affffdfc13a7325d06b73a63c540fa6d78a81b3f","original_commit_id":"affffdfc13a7325d06b73a63c540fa6d78a81b3f","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"Ah right. Had something else there which I later removed.","created_at":"2016-08-01T09:00:07Z","updated_at":"2016-08-01T09:00:07Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/3464#discussion_r72944246","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/72944246"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3464#discussion_r72944246"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464","id":79472832,"html_url":"https://github.com/Homebrew/homebrew-core/pull/3464","diff_url":"https://github.com/Homebrew/homebrew-core/pull/3464.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/3464.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3464","number":3464,"state":"open","locked":false,"title":"zsh: add --with-texi2html option to build HTML docs","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --strict --online <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nZsh's HTML documentation is somewhat more comprehensive, or at least better organized than its man pages — for instance, the indexes covering concepts, variables, options, functions are very useful. The HTML docs are hosted at http://zsh.sourceforge.net/Doc/Release/, but sometimes the user is offline and sometimes the site is offline — for instance, zsh.sourceforget.net was offline for two weeks last July when SF infrastructure failed. It's good to have the docs locally.\r\n\r\nOne complication here is that we can't build HTML docs on head, again due to yodl headache. Currently I have `--with-texi2html` as a non-head option.\r\n\r\nAnother option is to install HTML docs unconditionally for stable. The docs themselves only take ~3.6M of disk space, but they do introduce additional deps: `xz`, `gettext` and `texi2html`.\r\n\r\n**EDIT.** Actually, since `texi2html` is a buildtime dependency, bottle users won't need the additional deps.","created_at":"2016-07-31T01:04:04Z","updated_at":"2016-08-01T09:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e386e35e301b06606d33ae27092c0c63ea4f5f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3464/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/affffdfc13a7325d06b73a63c540fa6d78a81b3f","head":{"label":"zmwangx:zsh-with-texi2html","ref":"zsh-with-texi2html","sha":"affffdfc13a7325d06b73a63c540fa6d78a81b3f","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"repo":{"id":55401272,"name":"homebrew-core","full_name":"zmwangx/homebrew-core","owner":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmwangx/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/zmwangx/homebrew-core","forks_url":"https://api.github.com/repos/zmwangx/homebrew-core/forks","keys_url":"https://api.github.com/repos/zmwangx/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmwangx/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmwangx/homebrew-core/teams","hooks_url":"https://api.github.com/repos/zmwangx/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/zmwangx/homebrew-core/events","assignees_url":"https://api.github.com/repos/zmwangx/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/zmwangx/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/tags","blobs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmwangx/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zmwangx/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/zmwangx/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/zmwangx/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscription","commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmwangx/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmwangx/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/zmwangx/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmwangx/homebrew-core/merges","archive_url":"https://api.github.com/repos/zmwangx/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmwangx/homebrew-core/downloads","issues_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/zmwangx/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zmwangx/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zmwangx/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmwangx/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/zmwangx/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/zmwangx/homebrew-core/deployments","created_at":"2016-04-04T10:04:01Z","updated_at":"2016-04-04T10:04:16Z","pushed_at":"2016-08-01T02:12:37Z","git_url":"git://github.com/zmwangx/homebrew-core.git","ssh_url":"git@github.com:zmwangx/homebrew-core.git","clone_url":"https://github.com/zmwangx/homebrew-core.git","svn_url":"https://github.com/zmwangx/homebrew-core","homepage":"http://brew.sh","size":64211,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"cbdb70f423fd65274ec2667c52e4da0208b3401d","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-08-01T06:21:40Z","pushed_at":"2016-08-01T06:43:11Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":109971,"stargazers_count":619,"watchers_count":619,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1084,"mirror_url":null,"open_issues_count":178,"forks":1084,"open_issues":178,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3464"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3464"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3464/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3464/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/affffdfc13a7325d06b73a63c540fa6d78a81b3f"}}}}
{"actor":{"display_login":"zmwangx"}}