{"action":"created","issue":{"url":"https://api.github.com/repos/cznic/ql/issues/128","repository_url":"https://api.github.com/repos/cznic/ql","labels_url":"https://api.github.com/repos/cznic/ql/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/cznic/ql/issues/128/comments","events_url":"https://api.github.com/repos/cznic/ql/issues/128/events","html_url":"https://github.com/cznic/ql/issues/128","id":164094657,"number":128,"title":"Consider using go's native vendoring mechanism","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-07-06T14:50:18Z","updated_at":"2016-07-07T09:42:32Z","closed_at":null,"body":"Hello,\r\n\r\nWe recognized that starting from that commit:\r\n\r\nhttps://github.com/cznic/ql/commit/f50fc7d29ffc99ce551064ea56bacb92dbf4364c#diff-21ce9dcd10d134f8b0f327ac1ee4aa4dR24\r\n\r\nql started vendoring the `go4.org/lock` library as well as the `github.com/cznic/exp/lldb` library in a way that does not play well with other vendoring tools, i.e. glide.\r\n\r\nCan you elaborate on the reasoning why you chose \"vendored\" instead of the go \"vendor\" directory? I can personally think of many, but I have the impression, that vendor pruning in consuming applications becomes more ubiquitous as vendor tool support improves.\r\n\r\nxref https://github.com/coreos/rkt/pull/2875"},"comment":{"url":"https://api.github.com/repos/cznic/ql/issues/comments/231032034","html_url":"https://github.com/cznic/ql/issues/128#issuecomment-231032034","issue_url":"https://api.github.com/repos/cznic/ql/issues/128","id":231032034,"user":{"login":"cznic","id":729580,"avatar_url":"https://avatars.githubusercontent.com/u/729580?v=3","gravatar_id":"","url":"https://api.github.com/users/cznic","html_url":"https://github.com/cznic","followers_url":"https://api.github.com/users/cznic/followers","following_url":"https://api.github.com/users/cznic/following{/other_user}","gists_url":"https://api.github.com/users/cznic/gists{/gist_id}","starred_url":"https://api.github.com/users/cznic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cznic/subscriptions","organizations_url":"https://api.github.com/users/cznic/orgs","repos_url":"https://api.github.com/users/cznic/repos","events_url":"https://api.github.com/users/cznic/events{/privacy}","received_events_url":"https://api.github.com/users/cznic/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T09:42:32Z","updated_at":"2016-07-07T09:42:32Z","body":"I think I understand all of the problem(s) discussed above. My decision is to not take sides on this and to do whatever *all of you guys* agree to do (or not to do). I hope there's no hurry, so please discuss and please find a consensus, whatever it will be. Let me explicitly say that it means I don't want to *break* the #122 changes without @onlyjob feeling comfortable with it, regardless of what I now think about that change.\r\n\r\nMeanwhile, it seems to me that adding `glide` metadata would not break anything #122 brought, so I think this possible partial change may have a consensus already. Is that the case?"}}
{"actor":{"display_login":"cznic"}}