{"action":"created","comment":{"url":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments/82801467","pull_request_review_id":3682440,"id":82801467,"diff_hunk":"@@ -465,6 +471,16 @@ public void deactivate() {\n     }\n \n     @Override\n+    public void setRFC2833EventsOnly(boolean flag) {","path":"resources/telephony/dtmf/src/main/java/org/mobicents/media/server/impl/resource/dtmf/DetectorImpl.java","position":85,"original_position":85,"commit_id":"7e6528e26f0701757704f8829d9fb101351c6bba","original_commit_id":"7e6528e26f0701757704f8829d9fb101351c6bba","user":{"login":"hrosa","id":7796608,"avatar_url":"https://avatars.githubusercontent.com/u/7796608?v=3","gravatar_id":"","url":"https://api.github.com/users/hrosa","html_url":"https://github.com/hrosa","followers_url":"https://api.github.com/users/hrosa/followers","following_url":"https://api.github.com/users/hrosa/following{/other_user}","gists_url":"https://api.github.com/users/hrosa/gists{/gist_id}","starred_url":"https://api.github.com/users/hrosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrosa/subscriptions","organizations_url":"https://api.github.com/users/hrosa/orgs","repos_url":"https://api.github.com/users/hrosa/repos","events_url":"https://api.github.com/users/hrosa/events{/privacy}","received_events_url":"https://api.github.com/users/hrosa/received_events","type":"User","site_admin":false},"body":"Remove setter and pass this DTMF detection mode via constructor.","created_at":"2016-10-11T14:13:20Z","updated_at":"2016-10-11T14:14:32Z","html_url":"https://github.com/RestComm/mediaserver/pull/250#discussion_r82801467","pull_request_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments/82801467"},"html":{"href":"https://github.com/RestComm/mediaserver/pull/250#discussion_r82801467"},"pull_request":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/RestComm/mediaserver/pulls/250","id":84297937,"html_url":"https://github.com/RestComm/mediaserver/pull/250","diff_url":"https://github.com/RestComm/mediaserver/pull/250.diff","patch_url":"https://github.com/RestComm/mediaserver/pull/250.patch","issue_url":"https://api.github.com/repos/RestComm/mediaserver/issues/250","number":250,"state":"open","locked":false,"title":"Added support for configuring dtmf Detector + RFC2833 only mode","user":{"login":"pchlupacek","id":678560,"avatar_url":"https://avatars.githubusercontent.com/u/678560?v=3","gravatar_id":"","url":"https://api.github.com/users/pchlupacek","html_url":"https://github.com/pchlupacek","followers_url":"https://api.github.com/users/pchlupacek/followers","following_url":"https://api.github.com/users/pchlupacek/following{/other_user}","gists_url":"https://api.github.com/users/pchlupacek/gists{/gist_id}","starred_url":"https://api.github.com/users/pchlupacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchlupacek/subscriptions","organizations_url":"https://api.github.com/users/pchlupacek/orgs","repos_url":"https://api.github.com/users/pchlupacek/repos","events_url":"https://api.github.com/users/pchlupacek/events{/privacy}","received_events_url":"https://api.github.com/users/pchlupacek/received_events","type":"User","site_admin":false},"body":"@hrosa Found that dtmf detector is not using configuration in current RMS head, and added turn-off of in-band detection\r\n\r\nSpecifically on this RFC 2833 only mode can you take a look on it. Not sure If I did it correctly as the code flow is really hard to grasp, so essentially this only fixes my observation of telephone-event detection. ","created_at":"2016-09-07T13:16:06Z","updated_at":"2016-10-11T14:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c83a82365c40ed9172c323f4845547540b7d9724","assignee":{"login":"ghjansen","id":1459428,"avatar_url":"https://avatars.githubusercontent.com/u/1459428?v=3","gravatar_id":"","url":"https://api.github.com/users/ghjansen","html_url":"https://github.com/ghjansen","followers_url":"https://api.github.com/users/ghjansen/followers","following_url":"https://api.github.com/users/ghjansen/following{/other_user}","gists_url":"https://api.github.com/users/ghjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/ghjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghjansen/subscriptions","organizations_url":"https://api.github.com/users/ghjansen/orgs","repos_url":"https://api.github.com/users/ghjansen/repos","events_url":"https://api.github.com/users/ghjansen/events{/privacy}","received_events_url":"https://api.github.com/users/ghjansen/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghjansen","id":1459428,"avatar_url":"https://avatars.githubusercontent.com/u/1459428?v=3","gravatar_id":"","url":"https://api.github.com/users/ghjansen","html_url":"https://github.com/ghjansen","followers_url":"https://api.github.com/users/ghjansen/followers","following_url":"https://api.github.com/users/ghjansen/following{/other_user}","gists_url":"https://api.github.com/users/ghjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/ghjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghjansen/subscriptions","organizations_url":"https://api.github.com/users/ghjansen/orgs","repos_url":"https://api.github.com/users/ghjansen/repos","events_url":"https://api.github.com/users/ghjansen/events{/privacy}","received_events_url":"https://api.github.com/users/ghjansen/received_events","type":"User","site_admin":false},{"login":"hrosa","id":7796608,"avatar_url":"https://avatars.githubusercontent.com/u/7796608?v=3","gravatar_id":"","url":"https://api.github.com/users/hrosa","html_url":"https://github.com/hrosa","followers_url":"https://api.github.com/users/hrosa/followers","following_url":"https://api.github.com/users/hrosa/following{/other_user}","gists_url":"https://api.github.com/users/hrosa/gists{/gist_id}","starred_url":"https://api.github.com/users/hrosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrosa/subscriptions","organizations_url":"https://api.github.com/users/hrosa/orgs","repos_url":"https://api.github.com/users/hrosa/repos","events_url":"https://api.github.com/users/hrosa/events{/privacy}","received_events_url":"https://api.github.com/users/hrosa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/250/commits","review_comments_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/250/comments","review_comment_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RestComm/mediaserver/issues/250/comments","statuses_url":"https://api.github.com/repos/RestComm/mediaserver/statuses/7e6528e26f0701757704f8829d9fb101351c6bba","head":{"label":"Spinoco:dtmf-detector-config","ref":"dtmf-detector-config","sha":"7e6528e26f0701757704f8829d9fb101351c6bba","user":{"login":"Spinoco","id":1329603,"avatar_url":"https://avatars.githubusercontent.com/u/1329603?v=3","gravatar_id":"","url":"https://api.github.com/users/Spinoco","html_url":"https://github.com/Spinoco","followers_url":"https://api.github.com/users/Spinoco/followers","following_url":"https://api.github.com/users/Spinoco/following{/other_user}","gists_url":"https://api.github.com/users/Spinoco/gists{/gist_id}","starred_url":"https://api.github.com/users/Spinoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spinoco/subscriptions","organizations_url":"https://api.github.com/users/Spinoco/orgs","repos_url":"https://api.github.com/users/Spinoco/repos","events_url":"https://api.github.com/users/Spinoco/events{/privacy}","received_events_url":"https://api.github.com/users/Spinoco/received_events","type":"Organization","site_admin":false},"repo":{"id":44467656,"name":"mediaserver","full_name":"Spinoco/mediaserver","owner":{"login":"Spinoco","id":1329603,"avatar_url":"https://avatars.githubusercontent.com/u/1329603?v=3","gravatar_id":"","url":"https://api.github.com/users/Spinoco","html_url":"https://github.com/Spinoco","followers_url":"https://api.github.com/users/Spinoco/followers","following_url":"https://api.github.com/users/Spinoco/following{/other_user}","gists_url":"https://api.github.com/users/Spinoco/gists{/gist_id}","starred_url":"https://api.github.com/users/Spinoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spinoco/subscriptions","organizations_url":"https://api.github.com/users/Spinoco/orgs","repos_url":"https://api.github.com/users/Spinoco/repos","events_url":"https://api.github.com/users/Spinoco/events{/privacy}","received_events_url":"https://api.github.com/users/Spinoco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Spinoco/mediaserver","description":"MMS - Mobicents Multimedia Server for Real Time Cloud Communications","fork":true,"url":"https://api.github.com/repos/Spinoco/mediaserver","forks_url":"https://api.github.com/repos/Spinoco/mediaserver/forks","keys_url":"https://api.github.com/repos/Spinoco/mediaserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spinoco/mediaserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spinoco/mediaserver/teams","hooks_url":"https://api.github.com/repos/Spinoco/mediaserver/hooks","issue_events_url":"https://api.github.com/repos/Spinoco/mediaserver/issues/events{/number}","events_url":"https://api.github.com/repos/Spinoco/mediaserver/events","assignees_url":"https://api.github.com/repos/Spinoco/mediaserver/assignees{/user}","branches_url":"https://api.github.com/repos/Spinoco/mediaserver/branches{/branch}","tags_url":"https://api.github.com/repos/Spinoco/mediaserver/tags","blobs_url":"https://api.github.com/repos/Spinoco/mediaserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spinoco/mediaserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spinoco/mediaserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spinoco/mediaserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spinoco/mediaserver/statuses/{sha}","languages_url":"https://api.github.com/repos/Spinoco/mediaserver/languages","stargazers_url":"https://api.github.com/repos/Spinoco/mediaserver/stargazers","contributors_url":"https://api.github.com/repos/Spinoco/mediaserver/contributors","subscribers_url":"https://api.github.com/repos/Spinoco/mediaserver/subscribers","subscription_url":"https://api.github.com/repos/Spinoco/mediaserver/subscription","commits_url":"https://api.github.com/repos/Spinoco/mediaserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spinoco/mediaserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spinoco/mediaserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spinoco/mediaserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spinoco/mediaserver/contents/{+path}","compare_url":"https://api.github.com/repos/Spinoco/mediaserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spinoco/mediaserver/merges","archive_url":"https://api.github.com/repos/Spinoco/mediaserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spinoco/mediaserver/downloads","issues_url":"https://api.github.com/repos/Spinoco/mediaserver/issues{/number}","pulls_url":"https://api.github.com/repos/Spinoco/mediaserver/pulls{/number}","milestones_url":"https://api.github.com/repos/Spinoco/mediaserver/milestones{/number}","notifications_url":"https://api.github.com/repos/Spinoco/mediaserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spinoco/mediaserver/labels{/name}","releases_url":"https://api.github.com/repos/Spinoco/mediaserver/releases{/id}","deployments_url":"https://api.github.com/repos/Spinoco/mediaserver/deployments","created_at":"2015-10-18T06:09:49Z","updated_at":"2016-01-17T20:09:32Z","pushed_at":"2016-10-03T15:20:18Z","git_url":"git://github.com/Spinoco/mediaserver.git","ssh_url":"git@github.com:Spinoco/mediaserver.git","clone_url":"https://github.com/Spinoco/mediaserver.git","svn_url":"https://github.com/Spinoco/mediaserver","homepage":"","size":88537,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"5.0.0"}},"base":{"label":"RestComm:master","ref":"master","sha":"a1c612decb10872b31169aae07e0c3b743b8ab5a","user":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"repo":{"id":5455433,"name":"mediaserver","full_name":"RestComm/mediaserver","owner":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RestComm/mediaserver","description":"RMS - Restcomm Media Server for Real Time Cloud Communications","fork":false,"url":"https://api.github.com/repos/RestComm/mediaserver","forks_url":"https://api.github.com/repos/RestComm/mediaserver/forks","keys_url":"https://api.github.com/repos/RestComm/mediaserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RestComm/mediaserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RestComm/mediaserver/teams","hooks_url":"https://api.github.com/repos/RestComm/mediaserver/hooks","issue_events_url":"https://api.github.com/repos/RestComm/mediaserver/issues/events{/number}","events_url":"https://api.github.com/repos/RestComm/mediaserver/events","assignees_url":"https://api.github.com/repos/RestComm/mediaserver/assignees{/user}","branches_url":"https://api.github.com/repos/RestComm/mediaserver/branches{/branch}","tags_url":"https://api.github.com/repos/RestComm/mediaserver/tags","blobs_url":"https://api.github.com/repos/RestComm/mediaserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RestComm/mediaserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RestComm/mediaserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/RestComm/mediaserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RestComm/mediaserver/statuses/{sha}","languages_url":"https://api.github.com/repos/RestComm/mediaserver/languages","stargazers_url":"https://api.github.com/repos/RestComm/mediaserver/stargazers","contributors_url":"https://api.github.com/repos/RestComm/mediaserver/contributors","subscribers_url":"https://api.github.com/repos/RestComm/mediaserver/subscribers","subscription_url":"https://api.github.com/repos/RestComm/mediaserver/subscription","commits_url":"https://api.github.com/repos/RestComm/mediaserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/RestComm/mediaserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/RestComm/mediaserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/RestComm/mediaserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/RestComm/mediaserver/contents/{+path}","compare_url":"https://api.github.com/repos/RestComm/mediaserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RestComm/mediaserver/merges","archive_url":"https://api.github.com/repos/RestComm/mediaserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RestComm/mediaserver/downloads","issues_url":"https://api.github.com/repos/RestComm/mediaserver/issues{/number}","pulls_url":"https://api.github.com/repos/RestComm/mediaserver/pulls{/number}","milestones_url":"https://api.github.com/repos/RestComm/mediaserver/milestones{/number}","notifications_url":"https://api.github.com/repos/RestComm/mediaserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RestComm/mediaserver/labels{/name}","releases_url":"https://api.github.com/repos/RestComm/mediaserver/releases{/id}","deployments_url":"https://api.github.com/repos/RestComm/mediaserver/deployments","created_at":"2012-08-17T17:45:39Z","updated_at":"2016-09-26T12:21:24Z","pushed_at":"2016-10-11T10:09:49Z","git_url":"git://github.com/RestComm/mediaserver.git","ssh_url":"git@github.com:RestComm/mediaserver.git","clone_url":"https://github.com/RestComm/mediaserver.git","svn_url":"https://github.com/RestComm/mediaserver","homepage":"","size":90443,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":104,"forks":52,"open_issues":104,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/250"},"html":{"href":"https://github.com/RestComm/mediaserver/pull/250"},"issue":{"href":"https://api.github.com/repos/RestComm/mediaserver/issues/250"},"comments":{"href":"https://api.github.com/repos/RestComm/mediaserver/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/RestComm/mediaserver/statuses/7e6528e26f0701757704f8829d9fb101351c6bba"}}}}
{"actor":{"display_login":"hrosa"}}