{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/redux/issues/1637","repository_url":"https://api.github.com/repos/reactjs/redux","labels_url":"https://api.github.com/repos/reactjs/redux/issues/1637/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/redux/issues/1637/comments","events_url":"https://api.github.com/repos/reactjs/redux/issues/1637/events","html_url":"https://github.com/reactjs/redux/issues/1637","id":149489619,"number":1637,"title":"Where is \"happy medium\" between smart components and dumb components?","user":{"login":"amorphius","id":1895127,"avatar_url":"https://avatars.githubusercontent.com/u/1895127?v=3","gravatar_id":"","url":"https://api.github.com/users/amorphius","html_url":"https://github.com/amorphius","followers_url":"https://api.github.com/users/amorphius/followers","following_url":"https://api.github.com/users/amorphius/following{/other_user}","gists_url":"https://api.github.com/users/amorphius/gists{/gist_id}","starred_url":"https://api.github.com/users/amorphius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amorphius/subscriptions","organizations_url":"https://api.github.com/users/amorphius/orgs","repos_url":"https://api.github.com/users/amorphius/repos","events_url":"https://api.github.com/users/amorphius/events{/privacy}","received_events_url":"https://api.github.com/users/amorphius/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reactjs/redux/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-19T15:06:44Z","updated_at":"2016-04-19T16:44:59Z","closed_at":"2016-04-19T15:16:31Z","body":"I've been watching Dan's Redux tutorials on egghead and remember one advice that if parent component doesn't use some data but need it just to pass to children - don't do it. Use `connect` over child component that need this data.\r\n\r\nI like this advice because I hate passing tons of data through props. I thought this is commonly used approach but recently I was implementing \"mini twitter\" project as test assignment to the company which use redux in its project and that's why I want to work there.\r\n\r\nBut my code was rejected since \"React-way is too have maximum of dumb components\". Is that true? \r\nHere is my code if someone want to take a look https://bitbucket.org/amorphius/minitwitter/overview\r\nSo, the reason it was recognized as bad code is that there are too many `connect`'s in the code.\r\n\r\nWhere is happy medium?"},"comment":{"url":"https://api.github.com/repos/reactjs/redux/issues/comments/212011113","html_url":"https://github.com/reactjs/redux/issues/1637#issuecomment-212011113","issue_url":"https://api.github.com/repos/reactjs/redux/issues/1637","id":212011113,"user":{"login":"amorphius","id":1895127,"avatar_url":"https://avatars.githubusercontent.com/u/1895127?v=3","gravatar_id":"","url":"https://api.github.com/users/amorphius","html_url":"https://github.com/amorphius","followers_url":"https://api.github.com/users/amorphius/followers","following_url":"https://api.github.com/users/amorphius/following{/other_user}","gists_url":"https://api.github.com/users/amorphius/gists{/gist_id}","starred_url":"https://api.github.com/users/amorphius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amorphius/subscriptions","organizations_url":"https://api.github.com/users/amorphius/orgs","repos_url":"https://api.github.com/users/amorphius/repos","events_url":"https://api.github.com/users/amorphius/events{/privacy}","received_events_url":"https://api.github.com/users/amorphius/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T16:44:59Z","updated_at":"2016-04-19T16:44:59Z","body":"Thank you. At least I have now strong argument that my code is fine and probably get job in better company :)\r\n\r\nBut still I can't imaging scenario where `connect` is overkill. How to develop this skill to know which rule I have to break either pass data from parent control that does not use this data to child control or to have another `connect` in the code (especially if it reads small chunk of data from the store)?\r\n\r\nWhat kind of problems will arise with many `connect`'s in the app?"}}