{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/83458732","pull_request_review_id":4303589,"id":83458732,"diff_hunk":"@@ -632,39 +668,30 @@ User = ghostBookshelf.Model.extend({\n             ne2Password = object.ne2Password,\n             userId = parseInt(object.user_id),\n             oldPassword = object.oldPassword,\n+            isLoggedInUser = object.user_id === options.context.user,\n             user;\n \n         // If the two passwords do not match\n         if (newPassword !== ne2Password) {\n             return Promise.reject(new errors.ValidationError({message: i18n.t('errors.models.user.newPasswordsDoNotMatch')}));\n         }\n \n-        // If the old password is empty when changing current user's password\n-        if (userId === options.context.user && _.isEmpty(oldPassword)) {","path":"core/server/models/user.js","position":141,"original_position":141,"commit_id":"9571309f9b56301826fcd2d99df61c470b1aa4ea","original_commit_id":"9571309f9b56301826fcd2d99df61c470b1aa4ea","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"this check was redundant and `isPasswordCorrect` cares about a non value","created_at":"2016-10-14T16:43:55Z","updated_at":"2016-10-14T16:43:55Z","html_url":"https://github.com/TryGhost/Ghost/pull/7573#discussion_r83458732","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/83458732"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/7573#discussion_r83458732"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573","id":89416678,"html_url":"https://github.com/TryGhost/Ghost/pull/7573","diff_url":"https://github.com/TryGhost/Ghost/pull/7573.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/7573.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7573","number":7573,"state":"open","locked":false,"title":"✨  add isPasswordCorrect fn to User Model","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"refs #7432\r\nIn prepration to delete `generateResetToken` and `validateToken`!\r\n\r\n- clean code!\r\n- less code!","created_at":"2016-10-14T16:42:51Z","updated_at":"2016-10-14T16:43:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5354a3751308046869f66861dac771a0d70d6547","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7573/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/9571309f9b56301826fcd2d99df61c470b1aa4ea","head":{"label":"kirrg001:1.0.0-dev/is-password-correct-fn","ref":"1.0.0-dev/is-password-correct-fn","sha":"9571309f9b56301826fcd2d99df61c470b1aa4ea","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"repo":{"id":55587930,"name":"Ghost","full_name":"kirrg001/Ghost","owner":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars.githubusercontent.com/u/1160712?v=3","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirrg001/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/kirrg001/Ghost","forks_url":"https://api.github.com/repos/kirrg001/Ghost/forks","keys_url":"https://api.github.com/repos/kirrg001/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirrg001/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirrg001/Ghost/teams","hooks_url":"https://api.github.com/repos/kirrg001/Ghost/hooks","issue_events_url":"https://api.github.com/repos/kirrg001/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/kirrg001/Ghost/events","assignees_url":"https://api.github.com/repos/kirrg001/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/kirrg001/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/kirrg001/Ghost/tags","blobs_url":"https://api.github.com/repos/kirrg001/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirrg001/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirrg001/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirrg001/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirrg001/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/kirrg001/Ghost/languages","stargazers_url":"https://api.github.com/repos/kirrg001/Ghost/stargazers","contributors_url":"https://api.github.com/repos/kirrg001/Ghost/contributors","subscribers_url":"https://api.github.com/repos/kirrg001/Ghost/subscribers","subscription_url":"https://api.github.com/repos/kirrg001/Ghost/subscription","commits_url":"https://api.github.com/repos/kirrg001/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirrg001/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirrg001/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirrg001/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirrg001/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/kirrg001/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirrg001/Ghost/merges","archive_url":"https://api.github.com/repos/kirrg001/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirrg001/Ghost/downloads","issues_url":"https://api.github.com/repos/kirrg001/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/kirrg001/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/kirrg001/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/kirrg001/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirrg001/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/kirrg001/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/kirrg001/Ghost/deployments","created_at":"2016-04-06T08:16:39Z","updated_at":"2016-04-06T08:16:43Z","pushed_at":"2016-10-14T16:41:40Z","git_url":"git://github.com/kirrg001/Ghost.git","ssh_url":"git@github.com:kirrg001/Ghost.git","clone_url":"https://github.com/kirrg001/Ghost.git","svn_url":"https://github.com/kirrg001/Ghost","homepage":"https://ghost.org","size":23834,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"e1ac6a53dd587fcee6902b6702d6c2dd83530fb1","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"A simple, powerful publishing platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2016-10-14T12:37:19Z","pushed_at":"2016-10-14T16:42:51Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":71896,"stargazers_count":20900,"watchers_count":20900,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5049,"mirror_url":null,"open_issues_count":183,"forks":5049,"open_issues":183,"watchers":20900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/7573"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/7573"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/7573/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/7573/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/9571309f9b56301826fcd2d99df61c470b1aa4ea"}}}}
{"actor":{"display_login":"kirrg001"}}