{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10","id":82070321,"html_url":"https://github.com/awslabs/amazon-ecr-credential-helper/pull/10","diff_url":"https://github.com/awslabs/amazon-ecr-credential-helper/pull/10.diff","patch_url":"https://github.com/awslabs/amazon-ecr-credential-helper/pull/10.patch","issue_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/10","number":10,"state":"closed","locked":false,"title":"Make expiration logic more readable","user":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"body":"Fixes #7\r\n\r\nThis carries #8 from @f-barth and attempts to make the logic more readable.\r\n\r\nr? @sentientmonkey ","created_at":"2016-08-20T06:04:02Z","updated_at":"2016-08-24T01:15:23Z","closed_at":"2016-08-24T01:15:23Z","merged_at":"2016-08-24T01:15:23Z","merge_commit_sha":"1614bf09f10aaa1995647a631ba0f28536d8e417","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10/commits","review_comments_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10/comments","review_comment_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/10/comments","statuses_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/statuses/1614bf09f10aaa1995647a631ba0f28536d8e417","head":{"label":"samuelkarp:readable-expiry","ref":"readable-expiry","sha":"1614bf09f10aaa1995647a631ba0f28536d8e417","user":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"repo":{"id":60155474,"name":"amazon-ecr-credential-helper","full_name":"samuelkarp/amazon-ecr-credential-helper","owner":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelkarp/amazon-ecr-credential-helper","description":"Automatically gets credentials for Amazon ECR on docker push/docker pull","fork":true,"url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper","forks_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/forks","keys_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/teams","hooks_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/hooks","issue_events_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/issues/events{/number}","events_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/events","assignees_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/assignees{/user}","branches_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/branches{/branch}","tags_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/tags","blobs_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/languages","stargazers_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/stargazers","contributors_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/contributors","subscribers_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/subscribers","subscription_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/subscription","commits_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/contents/{+path}","compare_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/merges","archive_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/downloads","issues_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/issues{/number}","pulls_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/labels{/name}","releases_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/releases{/id}","deployments_url":"https://api.github.com/repos/samuelkarp/amazon-ecr-credential-helper/deployments","created_at":"2016-06-01T07:35:53Z","updated_at":"2016-06-01T07:35:54Z","pushed_at":"2016-08-24T00:55:19Z","git_url":"git://github.com/samuelkarp/amazon-ecr-credential-helper.git","ssh_url":"git@github.com:samuelkarp/amazon-ecr-credential-helper.git","clone_url":"https://github.com/samuelkarp/amazon-ecr-credential-helper.git","svn_url":"https://github.com/samuelkarp/amazon-ecr-credential-helper","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"77ede7e8c97aab375302fc8770a7a88a5a1af275","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":59514412,"name":"amazon-ecr-credential-helper","full_name":"awslabs/amazon-ecr-credential-helper","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/amazon-ecr-credential-helper","description":"Automatically gets credentials for Amazon ECR on docker push/docker pull","fork":false,"url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper","forks_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/forks","keys_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/teams","hooks_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/hooks","issue_events_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/events","assignees_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/tags","blobs_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/languages","stargazers_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/stargazers","contributors_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/contributors","subscribers_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/subscribers","subscription_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/subscription","commits_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/merges","archive_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/downloads","issues_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/deployments","created_at":"2016-05-23T20:01:21Z","updated_at":"2016-08-21T19:12:37Z","pushed_at":"2016-08-24T01:15:22Z","git_url":"git://github.com/awslabs/amazon-ecr-credential-helper.git","ssh_url":"git@github.com:awslabs/amazon-ecr-credential-helper.git","clone_url":"https://github.com/awslabs/amazon-ecr-credential-helper.git","svn_url":"https://github.com/awslabs/amazon-ecr-credential-helper","homepage":null,"size":265,"stargazers_count":51,"watchers_count":51,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10"},"html":{"href":"https://github.com/awslabs/amazon-ecr-credential-helper/pull/10"},"issue":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/10"},"comments":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/statuses/1614bf09f10aaa1995647a631ba0f28536d8e417"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":69,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"samuelkarp"}}