{"action":"closed","number":351,"pull_request":{"url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351","id":56481050,"html_url":"https://github.com/hmrc/assets-frontend/pull/351","diff_url":"https://github.com/hmrc/assets-frontend/pull/351.diff","patch_url":"https://github.com/hmrc/assets-frontend/pull/351.patch","issue_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/351","number":351,"state":"closed","locked":false,"title":"API-916 - Refactored tabs for accessibility + updated tests","user":{"login":"stingrayfunk","id":1764083,"avatar_url":"https://avatars.githubusercontent.com/u/1764083?v=3","gravatar_id":"","url":"https://api.github.com/users/stingrayfunk","html_url":"https://github.com/stingrayfunk","followers_url":"https://api.github.com/users/stingrayfunk/followers","following_url":"https://api.github.com/users/stingrayfunk/following{/other_user}","gists_url":"https://api.github.com/users/stingrayfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/stingrayfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stingrayfunk/subscriptions","organizations_url":"https://api.github.com/users/stingrayfunk/orgs","repos_url":"https://api.github.com/users/stingrayfunk/repos","events_url":"https://api.github.com/users/stingrayfunk/events{/privacy}","received_events_url":"https://api.github.com/users/stingrayfunk/received_events","type":"User","site_admin":false},"body":"# Tab Accessibility \r\n\r\nI've updated the Tabs JS module to ensure tabs are fully accessible via keyboard and screen readers. \r\nI've also moved the tabs SASS from navigation.scss into its own module, tabs.scss.\r\n\r\nThe tabs markup has been updated as shown below. The JS switches the states of the aria-selected attribute on the tab links, and the aria-hidden attribute on the tab panels.\r\n\r\n## Usage\r\n\r\n```html\r\n    <div data-tabs>\r\n\r\n      <ul role=\"tablist\">\r\n        <li id=\"tab1\" data-tab-link=\"1\" role=\"tab\" aria-selected=\"true\" aria-controls=\"tabContent1\" tabindex=\"0\">\r\n          <span class=\"tabs-nav__tab tabs-nav__tab--active\">Tab Link 1</span>\r\n        </li>\r\n        <li id=\"tab2\" data-tab-link=\"2\" role=\"tab\" aria-selected=\"false\" aria-controls=\"tabContent2\" tabindex=\"0\">\r\n          <a href=\"#\" class=\"tabs-nav__tab\">Tab Link 2</a>\r\n        </li>\r\n        <li id=\"tab3\" data-tab-link=\"3\" role=\"tab\" aria-selected=\"false\" aria-controls=\"tabContent3\" tabindex=\"0\">\r\n          <a href=\"#\" class=\"tabs-nav__tab\">Tab Link 3</a>\r\n        </li>\r\n      </ul>\r\n\r\n      <ul>\r\n        <li id=\"tabContent1\" data-tab-content=\"1\" class=\"tab-content\" role=\"tabpanel\" aria-labelledby=\"tab1\">\r\n          <p>Tab Content 1</p>\r\n        </li>\r\n        <li id=\"tabContent2\" data-tab-content=\"2\" class=\"tab-content\" role=\"tabpanel\" aria-labelledby=\"tab2\">\r\n          <p>Tab Content 2</p>\r\n        </li>\r\n        <li id=\"tabContent3\" data-tab-content=\"3\" class=\"tab-content\" role=\"tabpanel\" aria-labelledby=\"tab3\">\r\n          <p>Tab Content 3</p>\r\n        </li>\r\n      </ul>\r\n\r\n    </div>\r\n```\r\n\r\n\r\n\r\n","created_at":"2016-01-19T15:29:33Z","updated_at":"2016-01-20T10:48:59Z","closed_at":"2016-01-20T10:48:59Z","merged_at":"2016-01-20T10:48:59Z","merge_commit_sha":"8690fc403adc7057592413a13eababb0bcaa3f7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351/commits","review_comments_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351/comments","review_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/351/comments","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/14c8b229f8d2b0f6827a669a968719d4d5e7664a","head":{"label":"hmrc:API-916","ref":"API-916","sha":"14c8b229f8d2b0f6827a669a968719d4d5e7664a","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":26324661,"name":"assets-frontend","full_name":"hmrc/assets-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/assets-frontend","description":"Shared static assets for frontends on the Multichannel Digital Tax Platform","fork":false,"url":"https://api.github.com/repos/hmrc/assets-frontend","forks_url":"https://api.github.com/repos/hmrc/assets-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/assets-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/assets-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/assets-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/assets-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/assets-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/assets-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/assets-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/assets-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/assets-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/assets-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/assets-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/assets-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/assets-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/assets-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/assets-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/assets-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/assets-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/assets-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/assets-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/assets-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/assets-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/assets-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/assets-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/assets-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/assets-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/assets-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/assets-frontend/releases{/id}","created_at":"2014-11-07T15:11:39Z","updated_at":"2016-01-11T10:56:33Z","pushed_at":"2016-01-20T10:48:59Z","git_url":"git://github.com/hmrc/assets-frontend.git","ssh_url":"git@github.com:hmrc/assets-frontend.git","clone_url":"https://github.com/hmrc/assets-frontend.git","svn_url":"https://github.com/hmrc/assets-frontend","homepage":"","size":13873,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":15,"forks":28,"open_issues":15,"watchers":2,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"62be1c4d4184ccf31b89de5dc9f85854de892078","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":26324661,"name":"assets-frontend","full_name":"hmrc/assets-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/assets-frontend","description":"Shared static assets for frontends on the Multichannel Digital Tax Platform","fork":false,"url":"https://api.github.com/repos/hmrc/assets-frontend","forks_url":"https://api.github.com/repos/hmrc/assets-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/assets-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/assets-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/assets-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/assets-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/assets-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/assets-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/assets-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/assets-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/assets-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/assets-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/assets-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/assets-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/assets-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/assets-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/assets-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/assets-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/assets-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/assets-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/assets-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/assets-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/assets-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/assets-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/assets-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/assets-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/assets-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/assets-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/assets-frontend/releases{/id}","created_at":"2014-11-07T15:11:39Z","updated_at":"2016-01-11T10:56:33Z","pushed_at":"2016-01-20T10:48:59Z","git_url":"git://github.com/hmrc/assets-frontend.git","ssh_url":"git@github.com:hmrc/assets-frontend.git","clone_url":"https://github.com/hmrc/assets-frontend.git","svn_url":"https://github.com/hmrc/assets-frontend","homepage":"","size":13873,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":15,"forks":28,"open_issues":15,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351"},"html":{"href":"https://github.com/hmrc/assets-frontend/pull/351"},"issue":{"href":"https://api.github.com/repos/hmrc/assets-frontend/issues/351"},"comments":{"href":"https://api.github.com/repos/hmrc/assets-frontend/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/assets-frontend/statuses/14c8b229f8d2b0f6827a669a968719d4d5e7664a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"benaveryee","id":11385498,"avatar_url":"https://avatars.githubusercontent.com/u/11385498?v=3","gravatar_id":"","url":"https://api.github.com/users/benaveryee","html_url":"https://github.com/benaveryee","followers_url":"https://api.github.com/users/benaveryee/followers","following_url":"https://api.github.com/users/benaveryee/following{/other_user}","gists_url":"https://api.github.com/users/benaveryee/gists{/gist_id}","starred_url":"https://api.github.com/users/benaveryee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaveryee/subscriptions","organizations_url":"https://api.github.com/users/benaveryee/orgs","repos_url":"https://api.github.com/users/benaveryee/repos","events_url":"https://api.github.com/users/benaveryee/events{/privacy}","received_events_url":"https://api.github.com/users/benaveryee/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":297,"deletions":191,"changed_files":6}}