{"action":"closed","number":840,"pull_request":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/840","id":78447733,"html_url":"https://github.com/ros/ros_comm/pull/840","diff_url":"https://github.com/ros/ros_comm/pull/840.diff","patch_url":"https://github.com/ros/ros_comm/pull/840.patch","issue_url":"https://api.github.com/repos/ros/ros_comm/issues/840","number":840,"state":"closed","locked":false,"title":"roslaunch: Fix <param command=\"...\" /> for python3.","user":{"login":"de-vri-es","id":786213,"avatar_url":"https://avatars.githubusercontent.com/u/786213?v=3","gravatar_id":"","url":"https://api.github.com/users/de-vri-es","html_url":"https://github.com/de-vri-es","followers_url":"https://api.github.com/users/de-vri-es/followers","following_url":"https://api.github.com/users/de-vri-es/following{/other_user}","gists_url":"https://api.github.com/users/de-vri-es/gists{/gist_id}","starred_url":"https://api.github.com/users/de-vri-es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-vri-es/subscriptions","organizations_url":"https://api.github.com/users/de-vri-es/orgs","repos_url":"https://api.github.com/users/de-vri-es/repos","events_url":"https://api.github.com/users/de-vri-es/events{/privacy}","received_events_url":"https://api.github.com/users/de-vri-es/received_events","type":"User","site_admin":false},"body":"In python3, the standard output of the subprocess is of type bytes. That causes the data to be stored as a binary xmlrpc node which ends up base64 encoded when retrieving it later. Additionally, it crashed the `rosparam` command line utility which could not deal with that.\r\n\r\nThis PR checks if the read command output is not of type `str` and decodes it as UTF-8 in that case. This is a NOP in python2. We can't check if the read output is of type bytes, because in python2 `bytes` is just an alias for `str`.","created_at":"2016-07-22T09:19:56Z","updated_at":"2016-07-22T14:28:48Z","closed_at":"2016-07-22T14:28:48Z","merged_at":"2016-07-22T14:28:48Z","merge_commit_sha":"54398ba8bedf254abead9dfffd5bd8e6bb8d72a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/ros_comm/pulls/840/commits","review_comments_url":"https://api.github.com/repos/ros/ros_comm/pulls/840/comments","review_comment_url":"https://api.github.com/repos/ros/ros_comm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/ros_comm/issues/840/comments","statuses_url":"https://api.github.com/repos/ros/ros_comm/statuses/bf469c0c02b09e22195266e3b721e13009a13a26","head":{"label":"delftrobotics:roslaunch-param-command-python3","ref":"roslaunch-param-command-python3","sha":"bf469c0c02b09e22195266e3b721e13009a13a26","user":{"login":"delftrobotics","id":14974733,"avatar_url":"https://avatars.githubusercontent.com/u/14974733?v=3","gravatar_id":"","url":"https://api.github.com/users/delftrobotics","html_url":"https://github.com/delftrobotics","followers_url":"https://api.github.com/users/delftrobotics/followers","following_url":"https://api.github.com/users/delftrobotics/following{/other_user}","gists_url":"https://api.github.com/users/delftrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/delftrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delftrobotics/subscriptions","organizations_url":"https://api.github.com/users/delftrobotics/orgs","repos_url":"https://api.github.com/users/delftrobotics/repos","events_url":"https://api.github.com/users/delftrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/delftrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":63938683,"name":"ros_comm","full_name":"delftrobotics/ros_comm","owner":{"login":"delftrobotics","id":14974733,"avatar_url":"https://avatars.githubusercontent.com/u/14974733?v=3","gravatar_id":"","url":"https://api.github.com/users/delftrobotics","html_url":"https://github.com/delftrobotics","followers_url":"https://api.github.com/users/delftrobotics/followers","following_url":"https://api.github.com/users/delftrobotics/following{/other_user}","gists_url":"https://api.github.com/users/delftrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/delftrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delftrobotics/subscriptions","organizations_url":"https://api.github.com/users/delftrobotics/orgs","repos_url":"https://api.github.com/users/delftrobotics/repos","events_url":"https://api.github.com/users/delftrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/delftrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/delftrobotics/ros_comm","description":"ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).","fork":true,"url":"https://api.github.com/repos/delftrobotics/ros_comm","forks_url":"https://api.github.com/repos/delftrobotics/ros_comm/forks","keys_url":"https://api.github.com/repos/delftrobotics/ros_comm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delftrobotics/ros_comm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delftrobotics/ros_comm/teams","hooks_url":"https://api.github.com/repos/delftrobotics/ros_comm/hooks","issue_events_url":"https://api.github.com/repos/delftrobotics/ros_comm/issues/events{/number}","events_url":"https://api.github.com/repos/delftrobotics/ros_comm/events","assignees_url":"https://api.github.com/repos/delftrobotics/ros_comm/assignees{/user}","branches_url":"https://api.github.com/repos/delftrobotics/ros_comm/branches{/branch}","tags_url":"https://api.github.com/repos/delftrobotics/ros_comm/tags","blobs_url":"https://api.github.com/repos/delftrobotics/ros_comm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delftrobotics/ros_comm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delftrobotics/ros_comm/git/refs{/sha}","trees_url":"https://api.github.com/repos/delftrobotics/ros_comm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delftrobotics/ros_comm/statuses/{sha}","languages_url":"https://api.github.com/repos/delftrobotics/ros_comm/languages","stargazers_url":"https://api.github.com/repos/delftrobotics/ros_comm/stargazers","contributors_url":"https://api.github.com/repos/delftrobotics/ros_comm/contributors","subscribers_url":"https://api.github.com/repos/delftrobotics/ros_comm/subscribers","subscription_url":"https://api.github.com/repos/delftrobotics/ros_comm/subscription","commits_url":"https://api.github.com/repos/delftrobotics/ros_comm/commits{/sha}","git_commits_url":"https://api.github.com/repos/delftrobotics/ros_comm/git/commits{/sha}","comments_url":"https://api.github.com/repos/delftrobotics/ros_comm/comments{/number}","issue_comment_url":"https://api.github.com/repos/delftrobotics/ros_comm/issues/comments{/number}","contents_url":"https://api.github.com/repos/delftrobotics/ros_comm/contents/{+path}","compare_url":"https://api.github.com/repos/delftrobotics/ros_comm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delftrobotics/ros_comm/merges","archive_url":"https://api.github.com/repos/delftrobotics/ros_comm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delftrobotics/ros_comm/downloads","issues_url":"https://api.github.com/repos/delftrobotics/ros_comm/issues{/number}","pulls_url":"https://api.github.com/repos/delftrobotics/ros_comm/pulls{/number}","milestones_url":"https://api.github.com/repos/delftrobotics/ros_comm/milestones{/number}","notifications_url":"https://api.github.com/repos/delftrobotics/ros_comm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delftrobotics/ros_comm/labels{/name}","releases_url":"https://api.github.com/repos/delftrobotics/ros_comm/releases{/id}","deployments_url":"https://api.github.com/repos/delftrobotics/ros_comm/deployments","created_at":"2016-07-22T08:50:03Z","updated_at":"2016-07-22T08:50:06Z","pushed_at":"2016-07-22T09:17:48Z","git_url":"git://github.com/delftrobotics/ros_comm.git","ssh_url":"git@github.com:delftrobotics/ros_comm.git","clone_url":"https://github.com/delftrobotics/ros_comm.git","svn_url":"https://github.com/delftrobotics/ros_comm","homepage":"http://wiki.ros.org/ros_comm","size":10889,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros:kinetic-devel","ref":"kinetic-devel","sha":"04c9cb9d835121a3fef4ea45ad450f7b3a8635dc","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":5474834,"name":"ros_comm","full_name":"ros/ros_comm","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/ros_comm","description":"ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).","fork":false,"url":"https://api.github.com/repos/ros/ros_comm","forks_url":"https://api.github.com/repos/ros/ros_comm/forks","keys_url":"https://api.github.com/repos/ros/ros_comm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/ros_comm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/ros_comm/teams","hooks_url":"https://api.github.com/repos/ros/ros_comm/hooks","issue_events_url":"https://api.github.com/repos/ros/ros_comm/issues/events{/number}","events_url":"https://api.github.com/repos/ros/ros_comm/events","assignees_url":"https://api.github.com/repos/ros/ros_comm/assignees{/user}","branches_url":"https://api.github.com/repos/ros/ros_comm/branches{/branch}","tags_url":"https://api.github.com/repos/ros/ros_comm/tags","blobs_url":"https://api.github.com/repos/ros/ros_comm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/ros_comm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/ros_comm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/ros_comm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/ros_comm/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/ros_comm/languages","stargazers_url":"https://api.github.com/repos/ros/ros_comm/stargazers","contributors_url":"https://api.github.com/repos/ros/ros_comm/contributors","subscribers_url":"https://api.github.com/repos/ros/ros_comm/subscribers","subscription_url":"https://api.github.com/repos/ros/ros_comm/subscription","commits_url":"https://api.github.com/repos/ros/ros_comm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/ros_comm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/ros_comm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/ros_comm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/ros_comm/contents/{+path}","compare_url":"https://api.github.com/repos/ros/ros_comm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/ros_comm/merges","archive_url":"https://api.github.com/repos/ros/ros_comm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/ros_comm/downloads","issues_url":"https://api.github.com/repos/ros/ros_comm/issues{/number}","pulls_url":"https://api.github.com/repos/ros/ros_comm/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/ros_comm/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/ros_comm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/ros_comm/labels{/name}","releases_url":"https://api.github.com/repos/ros/ros_comm/releases{/id}","deployments_url":"https://api.github.com/repos/ros/ros_comm/deployments","created_at":"2012-08-19T22:26:34Z","updated_at":"2016-07-15T03:25:44Z","pushed_at":"2016-07-22T14:28:48Z","git_url":"git://github.com/ros/ros_comm.git","ssh_url":"git@github.com:ros/ros_comm.git","clone_url":"https://github.com/ros/ros_comm.git","svn_url":"https://github.com/ros/ros_comm","homepage":"http://wiki.ros.org/ros_comm","size":14358,"stargazers_count":92,"watchers_count":92,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":171,"forks":227,"open_issues":171,"watchers":92,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/840"},"html":{"href":"https://github.com/ros/ros_comm/pull/840"},"issue":{"href":"https://api.github.com/repos/ros/ros_comm/issues/840"},"comments":{"href":"https://api.github.com/repos/ros/ros_comm/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/ros/ros_comm/statuses/bf469c0c02b09e22195266e3b721e13009a13a26"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"dirk-thomas"}}