{"action":"created","issue":{"url":"https://api.github.com/repos/d3athrow/vgstation13/issues/12981","repository_url":"https://api.github.com/repos/d3athrow/vgstation13","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/12981/labels{/name}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/12981/comments","events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/12981/events","html_url":"https://github.com/d3athrow/vgstation13/issues/12981","id":196926444,"number":12981,"title":"apply_damage() Still Has Argument For Edge","user":{"login":"Shadowmech88","id":3991927,"avatar_url":"https://avatars.githubusercontent.com/u/3991927?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmech88","html_url":"https://github.com/Shadowmech88","followers_url":"https://api.github.com/users/Shadowmech88/followers","following_url":"https://api.github.com/users/Shadowmech88/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmech88/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmech88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmech88/subscriptions","organizations_url":"https://api.github.com/users/Shadowmech88/orgs","repos_url":"https://api.github.com/users/Shadowmech88/repos","events_url":"https://api.github.com/users/Shadowmech88/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmech88/received_events","type":"User","site_admin":false},"labels":[{"id":376814007,"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/100%25%20%20tested","name":"100%  tested","color":"c2e0c6","default":false},{"id":41962026,"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/Bug%20/%20Fix","name":"Bug / Fix","color":"FFCC33","default":false}],"state":"open","locked":false,"assignee":{"login":"9600bauds","id":6526157,"avatar_url":"https://avatars.githubusercontent.com/u/6526157?v=3","gravatar_id":"","url":"https://api.github.com/users/9600bauds","html_url":"https://github.com/9600bauds","followers_url":"https://api.github.com/users/9600bauds/followers","following_url":"https://api.github.com/users/9600bauds/following{/other_user}","gists_url":"https://api.github.com/users/9600bauds/gists{/gist_id}","starred_url":"https://api.github.com/users/9600bauds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9600bauds/subscriptions","organizations_url":"https://api.github.com/users/9600bauds/orgs","repos_url":"https://api.github.com/users/9600bauds/repos","events_url":"https://api.github.com/users/9600bauds/events{/privacy}","received_events_url":"https://api.github.com/users/9600bauds/received_events","type":"User","site_admin":false},"assignees":[{"login":"9600bauds","id":6526157,"avatar_url":"https://avatars.githubusercontent.com/u/6526157?v=3","gravatar_id":"","url":"https://api.github.com/users/9600bauds","html_url":"https://github.com/9600bauds","followers_url":"https://api.github.com/users/9600bauds/followers","following_url":"https://api.github.com/users/9600bauds/following{/other_user}","gists_url":"https://api.github.com/users/9600bauds/gists{/gist_id}","starred_url":"https://api.github.com/users/9600bauds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9600bauds/subscriptions","organizations_url":"https://api.github.com/users/9600bauds/orgs","repos_url":"https://api.github.com/users/9600bauds/repos","events_url":"https://api.github.com/users/9600bauds/events{/privacy}","received_events_url":"https://api.github.com/users/9600bauds/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-12-21T12:56:16Z","updated_at":"2016-12-21T16:01:47Z","closed_at":null,"body":"The `edge` var was removed from /obj in #12728, but the arguments made to take that var were not removed from `human/apply_damage()` as well as, I assume, other procs.\r\nThe existence of the argument may cause calls to it that don't name their arguments to misbehave.\r\n\r\nhttps://github.com/d3athrow/vgstation13/blob/Bleeding-Edge/code/modules/mob/living/carbon/human/human_damage.dm#L295\r\n\r\n@9600bauds \r\n"},"comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments/268559799","html_url":"https://github.com/d3athrow/vgstation13/issues/12981#issuecomment-268559799","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/12981","id":268559799,"user":{"login":"Shadowmech88","id":3991927,"avatar_url":"https://avatars.githubusercontent.com/u/3991927?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmech88","html_url":"https://github.com/Shadowmech88","followers_url":"https://api.github.com/users/Shadowmech88/followers","following_url":"https://api.github.com/users/Shadowmech88/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmech88/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmech88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmech88/subscriptions","organizations_url":"https://api.github.com/users/Shadowmech88/orgs","repos_url":"https://api.github.com/users/Shadowmech88/repos","events_url":"https://api.github.com/users/Shadowmech88/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmech88/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T16:01:47Z","updated_at":"2016-12-21T16:01:47Z","body":">oh god is it just not used anywhere\r\n\r\nIt's not used anywhere because you removed the `edge` var from `/obj`. That argument cannot possibly ever have an `edge` value actually passed to it now, which means it will always either equal zero or equal a value meant for a different argument.\r\n\r\nSo at best it's literally useless and at worst it'll cause unintended behavior like the bug you pointed out."}}
{"actor":{"display_login":"Shadowmech88"}}