{"action":"closed","number":884,"pull_request":{"url":"https://api.github.com/repos/stealjs/steal/pulls/884","id":90432609,"html_url":"https://github.com/stealjs/steal/pull/884","diff_url":"https://github.com/stealjs/steal/pull/884.diff","patch_url":"https://github.com/stealjs/steal/pull/884.patch","issue_url":"https://api.github.com/repos/stealjs/steal/issues/884","number":884,"state":"closed","locked":false,"title":"Warn when error thrown parsing JSON","user":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"body":"This does 2 things:\r\n\r\n1) Moves system-json into this project, the old project will be deprecated.\r\n2) When we catch JSON.parse errors (if the json has syntax errors) we return an empty object and warn the user of the error.\r\n\r\nBecause we detect if a module is JSON we cannot throw in the case where JSON fails to parse.\r\n\r\nCloses #763","created_at":"2016-10-21T19:41:59Z","updated_at":"2016-10-24T14:22:45Z","closed_at":"2016-10-24T14:22:45Z","merged_at":"2016-10-24T14:22:45Z","merge_commit_sha":"9e5b55e322c62eb90509cba5e7eb4e19ac96b36b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stealjs/steal/pulls/884/commits","review_comments_url":"https://api.github.com/repos/stealjs/steal/pulls/884/comments","review_comment_url":"https://api.github.com/repos/stealjs/steal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stealjs/steal/issues/884/comments","statuses_url":"https://api.github.com/repos/stealjs/steal/statuses/9e85d14db65ea24f53e456d0217cc0e0dcad7fad","head":{"label":"stealjs:json","ref":"json","sha":"9e85d14db65ea24f53e456d0217cc0e0dcad7fad","user":{"login":"stealjs","id":10838945,"avatar_url":"https://avatars.githubusercontent.com/u/10838945?v=3","gravatar_id":"","url":"https://api.github.com/users/stealjs","html_url":"https://github.com/stealjs","followers_url":"https://api.github.com/users/stealjs/followers","following_url":"https://api.github.com/users/stealjs/following{/other_user}","gists_url":"https://api.github.com/users/stealjs/gists{/gist_id}","starred_url":"https://api.github.com/users/stealjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealjs/subscriptions","organizations_url":"https://api.github.com/users/stealjs/orgs","repos_url":"https://api.github.com/users/stealjs/repos","events_url":"https://api.github.com/users/stealjs/events{/privacy}","received_events_url":"https://api.github.com/users/stealjs/received_events","type":"Organization","site_admin":false},"repo":{"id":507123,"name":"steal","full_name":"stealjs/steal","owner":{"login":"stealjs","id":10838945,"avatar_url":"https://avatars.githubusercontent.com/u/10838945?v=3","gravatar_id":"","url":"https://api.github.com/users/stealjs","html_url":"https://github.com/stealjs","followers_url":"https://api.github.com/users/stealjs/followers","following_url":"https://api.github.com/users/stealjs/following{/other_user}","gists_url":"https://api.github.com/users/stealjs/gists{/gist_id}","starred_url":"https://api.github.com/users/stealjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealjs/subscriptions","organizations_url":"https://api.github.com/users/stealjs/orgs","repos_url":"https://api.github.com/users/stealjs/repos","events_url":"https://api.github.com/users/stealjs/events{/privacy}","received_events_url":"https://api.github.com/users/stealjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stealjs/steal","description":"Gets JavaScript","fork":false,"url":"https://api.github.com/repos/stealjs/steal","forks_url":"https://api.github.com/repos/stealjs/steal/forks","keys_url":"https://api.github.com/repos/stealjs/steal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stealjs/steal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stealjs/steal/teams","hooks_url":"https://api.github.com/repos/stealjs/steal/hooks","issue_events_url":"https://api.github.com/repos/stealjs/steal/issues/events{/number}","events_url":"https://api.github.com/repos/stealjs/steal/events","assignees_url":"https://api.github.com/repos/stealjs/steal/assignees{/user}","branches_url":"https://api.github.com/repos/stealjs/steal/branches{/branch}","tags_url":"https://api.github.com/repos/stealjs/steal/tags","blobs_url":"https://api.github.com/repos/stealjs/steal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stealjs/steal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stealjs/steal/git/refs{/sha}","trees_url":"https://api.github.com/repos/stealjs/steal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stealjs/steal/statuses/{sha}","languages_url":"https://api.github.com/repos/stealjs/steal/languages","stargazers_url":"https://api.github.com/repos/stealjs/steal/stargazers","contributors_url":"https://api.github.com/repos/stealjs/steal/contributors","subscribers_url":"https://api.github.com/repos/stealjs/steal/subscribers","subscription_url":"https://api.github.com/repos/stealjs/steal/subscription","commits_url":"https://api.github.com/repos/stealjs/steal/commits{/sha}","git_commits_url":"https://api.github.com/repos/stealjs/steal/git/commits{/sha}","comments_url":"https://api.github.com/repos/stealjs/steal/comments{/number}","issue_comment_url":"https://api.github.com/repos/stealjs/steal/issues/comments{/number}","contents_url":"https://api.github.com/repos/stealjs/steal/contents/{+path}","compare_url":"https://api.github.com/repos/stealjs/steal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stealjs/steal/merges","archive_url":"https://api.github.com/repos/stealjs/steal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stealjs/steal/downloads","issues_url":"https://api.github.com/repos/stealjs/steal/issues{/number}","pulls_url":"https://api.github.com/repos/stealjs/steal/pulls{/number}","milestones_url":"https://api.github.com/repos/stealjs/steal/milestones{/number}","notifications_url":"https://api.github.com/repos/stealjs/steal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stealjs/steal/labels{/name}","releases_url":"https://api.github.com/repos/stealjs/steal/releases{/id}","deployments_url":"https://api.github.com/repos/stealjs/steal/deployments","created_at":"2010-02-08T00:22:42Z","updated_at":"2016-10-22T14:25:38Z","pushed_at":"2016-10-24T14:22:45Z","git_url":"git://github.com/stealjs/steal.git","ssh_url":"git@github.com:stealjs/steal.git","clone_url":"https://github.com/stealjs/steal.git","svn_url":"https://github.com/stealjs/steal","homepage":"http://stealjs.com","size":68604,"stargazers_count":987,"watchers_count":987,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"open_issues_count":59,"forks":561,"open_issues":59,"watchers":987,"default_branch":"master"}},"base":{"label":"stealjs:major","ref":"major","sha":"05a6875aeeb5474dc6f2459184f2a72eed4a6a75","user":{"login":"stealjs","id":10838945,"avatar_url":"https://avatars.githubusercontent.com/u/10838945?v=3","gravatar_id":"","url":"https://api.github.com/users/stealjs","html_url":"https://github.com/stealjs","followers_url":"https://api.github.com/users/stealjs/followers","following_url":"https://api.github.com/users/stealjs/following{/other_user}","gists_url":"https://api.github.com/users/stealjs/gists{/gist_id}","starred_url":"https://api.github.com/users/stealjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealjs/subscriptions","organizations_url":"https://api.github.com/users/stealjs/orgs","repos_url":"https://api.github.com/users/stealjs/repos","events_url":"https://api.github.com/users/stealjs/events{/privacy}","received_events_url":"https://api.github.com/users/stealjs/received_events","type":"Organization","site_admin":false},"repo":{"id":507123,"name":"steal","full_name":"stealjs/steal","owner":{"login":"stealjs","id":10838945,"avatar_url":"https://avatars.githubusercontent.com/u/10838945?v=3","gravatar_id":"","url":"https://api.github.com/users/stealjs","html_url":"https://github.com/stealjs","followers_url":"https://api.github.com/users/stealjs/followers","following_url":"https://api.github.com/users/stealjs/following{/other_user}","gists_url":"https://api.github.com/users/stealjs/gists{/gist_id}","starred_url":"https://api.github.com/users/stealjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealjs/subscriptions","organizations_url":"https://api.github.com/users/stealjs/orgs","repos_url":"https://api.github.com/users/stealjs/repos","events_url":"https://api.github.com/users/stealjs/events{/privacy}","received_events_url":"https://api.github.com/users/stealjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stealjs/steal","description":"Gets JavaScript","fork":false,"url":"https://api.github.com/repos/stealjs/steal","forks_url":"https://api.github.com/repos/stealjs/steal/forks","keys_url":"https://api.github.com/repos/stealjs/steal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stealjs/steal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stealjs/steal/teams","hooks_url":"https://api.github.com/repos/stealjs/steal/hooks","issue_events_url":"https://api.github.com/repos/stealjs/steal/issues/events{/number}","events_url":"https://api.github.com/repos/stealjs/steal/events","assignees_url":"https://api.github.com/repos/stealjs/steal/assignees{/user}","branches_url":"https://api.github.com/repos/stealjs/steal/branches{/branch}","tags_url":"https://api.github.com/repos/stealjs/steal/tags","blobs_url":"https://api.github.com/repos/stealjs/steal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stealjs/steal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stealjs/steal/git/refs{/sha}","trees_url":"https://api.github.com/repos/stealjs/steal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stealjs/steal/statuses/{sha}","languages_url":"https://api.github.com/repos/stealjs/steal/languages","stargazers_url":"https://api.github.com/repos/stealjs/steal/stargazers","contributors_url":"https://api.github.com/repos/stealjs/steal/contributors","subscribers_url":"https://api.github.com/repos/stealjs/steal/subscribers","subscription_url":"https://api.github.com/repos/stealjs/steal/subscription","commits_url":"https://api.github.com/repos/stealjs/steal/commits{/sha}","git_commits_url":"https://api.github.com/repos/stealjs/steal/git/commits{/sha}","comments_url":"https://api.github.com/repos/stealjs/steal/comments{/number}","issue_comment_url":"https://api.github.com/repos/stealjs/steal/issues/comments{/number}","contents_url":"https://api.github.com/repos/stealjs/steal/contents/{+path}","compare_url":"https://api.github.com/repos/stealjs/steal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stealjs/steal/merges","archive_url":"https://api.github.com/repos/stealjs/steal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stealjs/steal/downloads","issues_url":"https://api.github.com/repos/stealjs/steal/issues{/number}","pulls_url":"https://api.github.com/repos/stealjs/steal/pulls{/number}","milestones_url":"https://api.github.com/repos/stealjs/steal/milestones{/number}","notifications_url":"https://api.github.com/repos/stealjs/steal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stealjs/steal/labels{/name}","releases_url":"https://api.github.com/repos/stealjs/steal/releases{/id}","deployments_url":"https://api.github.com/repos/stealjs/steal/deployments","created_at":"2010-02-08T00:22:42Z","updated_at":"2016-10-22T14:25:38Z","pushed_at":"2016-10-24T14:22:45Z","git_url":"git://github.com/stealjs/steal.git","ssh_url":"git@github.com:stealjs/steal.git","clone_url":"https://github.com/stealjs/steal.git","svn_url":"https://github.com/stealjs/steal","homepage":"http://stealjs.com","size":68604,"stargazers_count":987,"watchers_count":987,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"open_issues_count":59,"forks":561,"open_issues":59,"watchers":987,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stealjs/steal/pulls/884"},"html":{"href":"https://github.com/stealjs/steal/pull/884"},"issue":{"href":"https://api.github.com/repos/stealjs/steal/issues/884"},"comments":{"href":"https://api.github.com/repos/stealjs/steal/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/stealjs/steal/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/stealjs/steal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stealjs/steal/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/stealjs/steal/statuses/9e85d14db65ea24f53e456d0217cc0e0dcad7fad"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":298,"deletions":47,"changed_files":18}}
{"actor":{"display_login":"matthewp"}}