{"action":"opened","number":275,"pull_request":{"url":"https://api.github.com/repos/redding/assert/pulls/275","id":69631431,"html_url":"https://github.com/redding/assert/pull/275","diff_url":"https://github.com/redding/assert/pull/275.diff","patch_url":"https://github.com/redding/assert/pull/275.patch","issue_url":"https://api.github.com/repos/redding/assert/issues/275","number":275,"state":"open","locked":false,"title":"accumulate: prep tests for removing `results` from test objects","user":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"body":"This reworks a bunch of the assertion tests and system tests to\r\nnot expect a test to know its results.  This is prep for removing\r\nthe `results` accessor from tests, which in turn is part of switching\r\nto accumulating test run data.\r\n\r\nI chose to break out a test helpers module so I could include it\r\non all the test contexts.  Since the tests all needed to accumulate\r\nresults and tested the results in a similar manner, this commonization\r\nworks.\r\n\r\nI chose to break this out into a separate PR to remove some noise\r\nfrom the coming effort where I remove the `results` accessor on\r\nthe Test class.\r\n\r\n@jcredding ready for review.","created_at":"2016-05-11T08:15:57Z","updated_at":"2016-05-11T08:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redding/assert/pulls/275/commits","review_comments_url":"https://api.github.com/repos/redding/assert/pulls/275/comments","review_comment_url":"https://api.github.com/repos/redding/assert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redding/assert/issues/275/comments","statuses_url":"https://api.github.com/repos/redding/assert/statuses/5eb2c408812ce8bf072f47e1984734a9471a1957","head":{"label":"redding:kr-prep-rm-results-from-tests","ref":"kr-prep-rm-results-from-tests","sha":"5eb2c408812ce8bf072f47e1984734a9471a1957","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":2175297,"name":"assert","full_name":"redding/assert","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/assert","description":"Assertion style testing framework.","fork":false,"url":"https://api.github.com/repos/redding/assert","forks_url":"https://api.github.com/repos/redding/assert/forks","keys_url":"https://api.github.com/repos/redding/assert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/assert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/assert/teams","hooks_url":"https://api.github.com/repos/redding/assert/hooks","issue_events_url":"https://api.github.com/repos/redding/assert/issues/events{/number}","events_url":"https://api.github.com/repos/redding/assert/events","assignees_url":"https://api.github.com/repos/redding/assert/assignees{/user}","branches_url":"https://api.github.com/repos/redding/assert/branches{/branch}","tags_url":"https://api.github.com/repos/redding/assert/tags","blobs_url":"https://api.github.com/repos/redding/assert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/assert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/assert/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/assert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/assert/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/assert/languages","stargazers_url":"https://api.github.com/repos/redding/assert/stargazers","contributors_url":"https://api.github.com/repos/redding/assert/contributors","subscribers_url":"https://api.github.com/repos/redding/assert/subscribers","subscription_url":"https://api.github.com/repos/redding/assert/subscription","commits_url":"https://api.github.com/repos/redding/assert/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/assert/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/assert/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/assert/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/assert/contents/{+path}","compare_url":"https://api.github.com/repos/redding/assert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/assert/merges","archive_url":"https://api.github.com/repos/redding/assert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/assert/downloads","issues_url":"https://api.github.com/repos/redding/assert/issues{/number}","pulls_url":"https://api.github.com/repos/redding/assert/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/assert/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/assert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/assert/labels{/name}","releases_url":"https://api.github.com/repos/redding/assert/releases{/id}","deployments_url":"https://api.github.com/repos/redding/assert/deployments","created_at":"2011-08-08T19:08:49Z","updated_at":"2016-01-16T22:29:09Z","pushed_at":"2016-05-11T08:14:58Z","git_url":"git://github.com/redding/assert.git","ssh_url":"git@github.com:redding/assert.git","clone_url":"https://github.com/redding/assert.git","svn_url":"https://github.com/redding/assert","homepage":"https://github.com/redding/assert","size":877,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":8,"default_branch":"master"}},"base":{"label":"redding:feature-accumulate-results","ref":"feature-accumulate-results","sha":"95833e3db918d6f8733fa65527d03393fb1a1ecf","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":2175297,"name":"assert","full_name":"redding/assert","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/assert","description":"Assertion style testing framework.","fork":false,"url":"https://api.github.com/repos/redding/assert","forks_url":"https://api.github.com/repos/redding/assert/forks","keys_url":"https://api.github.com/repos/redding/assert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/assert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/assert/teams","hooks_url":"https://api.github.com/repos/redding/assert/hooks","issue_events_url":"https://api.github.com/repos/redding/assert/issues/events{/number}","events_url":"https://api.github.com/repos/redding/assert/events","assignees_url":"https://api.github.com/repos/redding/assert/assignees{/user}","branches_url":"https://api.github.com/repos/redding/assert/branches{/branch}","tags_url":"https://api.github.com/repos/redding/assert/tags","blobs_url":"https://api.github.com/repos/redding/assert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/assert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/assert/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/assert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/assert/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/assert/languages","stargazers_url":"https://api.github.com/repos/redding/assert/stargazers","contributors_url":"https://api.github.com/repos/redding/assert/contributors","subscribers_url":"https://api.github.com/repos/redding/assert/subscribers","subscription_url":"https://api.github.com/repos/redding/assert/subscription","commits_url":"https://api.github.com/repos/redding/assert/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/assert/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/assert/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/assert/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/assert/contents/{+path}","compare_url":"https://api.github.com/repos/redding/assert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/assert/merges","archive_url":"https://api.github.com/repos/redding/assert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/assert/downloads","issues_url":"https://api.github.com/repos/redding/assert/issues{/number}","pulls_url":"https://api.github.com/repos/redding/assert/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/assert/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/assert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/assert/labels{/name}","releases_url":"https://api.github.com/repos/redding/assert/releases{/id}","deployments_url":"https://api.github.com/repos/redding/assert/deployments","created_at":"2011-08-08T19:08:49Z","updated_at":"2016-01-16T22:29:09Z","pushed_at":"2016-05-11T08:14:58Z","git_url":"git://github.com/redding/assert.git","ssh_url":"git@github.com:redding/assert.git","clone_url":"https://github.com/redding/assert.git","svn_url":"https://github.com/redding/assert","homepage":"https://github.com/redding/assert","size":877,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redding/assert/pulls/275"},"html":{"href":"https://github.com/redding/assert/pull/275"},"issue":{"href":"https://api.github.com/repos/redding/assert/issues/275"},"comments":{"href":"https://api.github.com/repos/redding/assert/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/redding/assert/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/redding/assert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redding/assert/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/redding/assert/statuses/5eb2c408812ce8bf072f47e1984734a9471a1957"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":352,"deletions":244,"changed_files":16}}