{"action":"opened","number":1598,"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598","id":58556373,"html_url":"https://github.com/SeleniumHQ/selenium/pull/1598","diff_url":"https://github.com/SeleniumHQ/selenium/pull/1598.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/1598.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/1598","number":1598,"state":"open","locked":false,"title":"Add encoding=utf-8 to add_on's open(install.rdf) line.","user":{"login":"DArtagan","id":69908,"avatar_url":"https://avatars.githubusercontent.com/u/69908?v=3","gravatar_id":"","url":"https://api.github.com/users/DArtagan","html_url":"https://github.com/DArtagan","followers_url":"https://api.github.com/users/DArtagan/followers","following_url":"https://api.github.com/users/DArtagan/following{/other_user}","gists_url":"https://api.github.com/users/DArtagan/gists{/gist_id}","starred_url":"https://api.github.com/users/DArtagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DArtagan/subscriptions","organizations_url":"https://api.github.com/users/DArtagan/orgs","repos_url":"https://api.github.com/users/DArtagan/repos","events_url":"https://api.github.com/users/DArtagan/events{/privacy}","received_events_url":"https://api.github.com/users/DArtagan/received_events","type":"User","site_admin":false},"body":"When running Selenium on windows, and installing an add-on to firefox, it chokes on this particular line:\r\n\r\n    File \"C:\\Python34\\lib\\site-packages\\selenium\\webdriver\\firefox\\firefox_profile.py\", line 343, in _addon_details\r\n        manifest = f.read()\r\n    File \"C:\\Python34\\lib\\encodings\\cp1252.py\", line 23, in decode\r\n        return codecs.charmap_decode(input,self.errors,decoding_table)[0]\r\n    UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 990: character maps to <undefined>\r\n\r\nSpecifying an encoding at the open line seems to resolve this.\r\nCLA signed.","created_at":"2016-02-07T20:35:29Z","updated_at":"2016-02-07T20:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61f943dd4e4bcdba3e937041778e9f0ebf3d03c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/1598/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/e6336cc736a2d97c5d8838a665542505c3f2ba17","head":{"label":"DArtagan:master","ref":"master","sha":"e6336cc736a2d97c5d8838a665542505c3f2ba17","user":{"login":"DArtagan","id":69908,"avatar_url":"https://avatars.githubusercontent.com/u/69908?v=3","gravatar_id":"","url":"https://api.github.com/users/DArtagan","html_url":"https://github.com/DArtagan","followers_url":"https://api.github.com/users/DArtagan/followers","following_url":"https://api.github.com/users/DArtagan/following{/other_user}","gists_url":"https://api.github.com/users/DArtagan/gists{/gist_id}","starred_url":"https://api.github.com/users/DArtagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DArtagan/subscriptions","organizations_url":"https://api.github.com/users/DArtagan/orgs","repos_url":"https://api.github.com/users/DArtagan/repos","events_url":"https://api.github.com/users/DArtagan/events{/privacy}","received_events_url":"https://api.github.com/users/DArtagan/received_events","type":"User","site_admin":false},"repo":{"id":51264610,"name":"selenium","full_name":"DArtagan/selenium","owner":{"login":"DArtagan","id":69908,"avatar_url":"https://avatars.githubusercontent.com/u/69908?v=3","gravatar_id":"","url":"https://api.github.com/users/DArtagan","html_url":"https://github.com/DArtagan","followers_url":"https://api.github.com/users/DArtagan/followers","following_url":"https://api.github.com/users/DArtagan/following{/other_user}","gists_url":"https://api.github.com/users/DArtagan/gists{/gist_id}","starred_url":"https://api.github.com/users/DArtagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DArtagan/subscriptions","organizations_url":"https://api.github.com/users/DArtagan/orgs","repos_url":"https://api.github.com/users/DArtagan/repos","events_url":"https://api.github.com/users/DArtagan/events{/privacy}","received_events_url":"https://api.github.com/users/DArtagan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DArtagan/selenium","description":"A browser automation framework and ecosystem.","fork":true,"url":"https://api.github.com/repos/DArtagan/selenium","forks_url":"https://api.github.com/repos/DArtagan/selenium/forks","keys_url":"https://api.github.com/repos/DArtagan/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DArtagan/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DArtagan/selenium/teams","hooks_url":"https://api.github.com/repos/DArtagan/selenium/hooks","issue_events_url":"https://api.github.com/repos/DArtagan/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/DArtagan/selenium/events","assignees_url":"https://api.github.com/repos/DArtagan/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/DArtagan/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/DArtagan/selenium/tags","blobs_url":"https://api.github.com/repos/DArtagan/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DArtagan/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DArtagan/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/DArtagan/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DArtagan/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/DArtagan/selenium/languages","stargazers_url":"https://api.github.com/repos/DArtagan/selenium/stargazers","contributors_url":"https://api.github.com/repos/DArtagan/selenium/contributors","subscribers_url":"https://api.github.com/repos/DArtagan/selenium/subscribers","subscription_url":"https://api.github.com/repos/DArtagan/selenium/subscription","commits_url":"https://api.github.com/repos/DArtagan/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/DArtagan/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/DArtagan/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/DArtagan/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/DArtagan/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/DArtagan/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DArtagan/selenium/merges","archive_url":"https://api.github.com/repos/DArtagan/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DArtagan/selenium/downloads","issues_url":"https://api.github.com/repos/DArtagan/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/DArtagan/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/DArtagan/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/DArtagan/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DArtagan/selenium/labels{/name}","releases_url":"https://api.github.com/repos/DArtagan/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/DArtagan/selenium/deployments","created_at":"2016-02-07T20:24:26Z","updated_at":"2016-02-07T20:24:38Z","pushed_at":"2016-02-07T20:27:21Z","git_url":"git://github.com/DArtagan/selenium.git","ssh_url":"git@github.com:DArtagan/selenium.git","clone_url":"https://github.com/DArtagan/selenium.git","svn_url":"https://github.com/DArtagan/selenium","homepage":"http://seleniumhq.org/","size":1309655,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"9b7a73b56da9b37fe692ce2f146f7cbdbdb3c837","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2016-02-07T19:41:42Z","pushed_at":"2016-02-07T20:35:30Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"http://seleniumhq.org/","size":1317019,"stargazers_count":2625,"watchers_count":2625,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1450,"mirror_url":null,"open_issues_count":248,"forks":1450,"open_issues":248,"watchers":2625,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/1598"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/1598"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/1598/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/1598/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/e6336cc736a2d97c5d8838a665542505c3f2ba17"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}