{"action":"created","comment":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/57580709","id":57580709,"diff_hunk":"@@ -1,4 +1,5 @@\n obj-$(FLOW_NODE_TYPE_OIC) += oic.mod\n obj-oic-$(FLOW_NODE_TYPE_OIC) := oic.json oic.o\n-obj-oic-$(FLOW_NODE_TYPE_OIC)-oic := core.light.json\n+obj-oic-$(FLOW_NODE_TYPE_OIC)-oic := y\n+obj-oic-$(FLOW_NODE_TYPE_OIC)-oic-dirs := $(OIC_DATA_MODELS)","path":"src/modules/flow/oic/Makefile","position":5,"original_position":5,"commit_id":"0fd35259d7a23439bdc952fc8fd3e0cb86fadabb","original_commit_id":"f438d38cbd2335892339bb276e0af0aa5f7d5de9","user":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"body":"If there is any way to represent the current dir all of them could be used on oic-dirs.\r\n\r\nBut I believe just using\r\n\r\nobj-oic-$(FLOW_NODE_TYPE_OIC)-oic := y\r\n\r\nwould be more frequent than including extra dirs anyway.","created_at":"2016-03-28T15:00:52Z","updated_at":"2016-03-28T15:00:52Z","html_url":"https://github.com/solettaproject/soletta/pull/1735#discussion_r57580709","pull_request_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1735","_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/57580709"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1735#discussion_r57580709"},"pull_request":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1735"}}},"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/1735","id":64115249,"html_url":"https://github.com/solettaproject/soletta/pull/1735","diff_url":"https://github.com/solettaproject/soletta/pull/1735.diff","patch_url":"https://github.com/solettaproject/soletta/pull/1735.patch","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/1735","number":1735,"state":"open","locked":false,"title":"[WIP] Use OIC Data Models","user":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"body":"It still fails on some points when building.\n\nI wasn't able to check all issues yet.","created_at":"2016-03-24T23:46:45Z","updated_at":"2016-03-28T15:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc3a4f8a60723c87cb75b58dee7bcf7bbebd850","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1735/commits","review_comments_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1735/comments","review_comment_url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/1735/comments","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/0fd35259d7a23439bdc952fc8fd3e0cb86fadabb","head":{"label":"bdilly:oic_json","ref":"oic_json","sha":"0fd35259d7a23439bdc952fc8fd3e0cb86fadabb","user":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"repo":{"id":37600910,"name":"soletta","full_name":"bdilly/soletta","owner":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdilly/soletta","description":"Soletta Project is a framework for making IoT devices.","fork":true,"url":"https://api.github.com/repos/bdilly/soletta","forks_url":"https://api.github.com/repos/bdilly/soletta/forks","keys_url":"https://api.github.com/repos/bdilly/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdilly/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdilly/soletta/teams","hooks_url":"https://api.github.com/repos/bdilly/soletta/hooks","issue_events_url":"https://api.github.com/repos/bdilly/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/bdilly/soletta/events","assignees_url":"https://api.github.com/repos/bdilly/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/bdilly/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/bdilly/soletta/tags","blobs_url":"https://api.github.com/repos/bdilly/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdilly/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdilly/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdilly/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdilly/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/bdilly/soletta/languages","stargazers_url":"https://api.github.com/repos/bdilly/soletta/stargazers","contributors_url":"https://api.github.com/repos/bdilly/soletta/contributors","subscribers_url":"https://api.github.com/repos/bdilly/soletta/subscribers","subscription_url":"https://api.github.com/repos/bdilly/soletta/subscription","commits_url":"https://api.github.com/repos/bdilly/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdilly/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdilly/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdilly/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdilly/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/bdilly/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdilly/soletta/merges","archive_url":"https://api.github.com/repos/bdilly/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdilly/soletta/downloads","issues_url":"https://api.github.com/repos/bdilly/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/bdilly/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/bdilly/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/bdilly/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdilly/soletta/labels{/name}","releases_url":"https://api.github.com/repos/bdilly/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/bdilly/soletta/deployments","created_at":"2015-06-17T14:45:11Z","updated_at":"2016-02-05T13:50:23Z","pushed_at":"2016-03-24T23:46:44Z","git_url":"git://github.com/bdilly/soletta.git","ssh_url":"git@github.com:bdilly/soletta.git","clone_url":"https://github.com/bdilly/soletta.git","svn_url":"https://github.com/bdilly/soletta","homepage":"","size":17721,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solettaproject:master","ref":"master","sha":"62f678362871cde1554e072212a0dde335669e08","user":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37087063,"name":"soletta","full_name":"solettaproject/soletta","owner":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solettaproject/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  ","fork":false,"url":"https://api.github.com/repos/solettaproject/soletta","forks_url":"https://api.github.com/repos/solettaproject/soletta/forks","keys_url":"https://api.github.com/repos/solettaproject/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solettaproject/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solettaproject/soletta/teams","hooks_url":"https://api.github.com/repos/solettaproject/soletta/hooks","issue_events_url":"https://api.github.com/repos/solettaproject/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/solettaproject/soletta/events","assignees_url":"https://api.github.com/repos/solettaproject/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/solettaproject/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/solettaproject/soletta/tags","blobs_url":"https://api.github.com/repos/solettaproject/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solettaproject/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solettaproject/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/solettaproject/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/solettaproject/soletta/languages","stargazers_url":"https://api.github.com/repos/solettaproject/soletta/stargazers","contributors_url":"https://api.github.com/repos/solettaproject/soletta/contributors","subscribers_url":"https://api.github.com/repos/solettaproject/soletta/subscribers","subscription_url":"https://api.github.com/repos/solettaproject/soletta/subscription","commits_url":"https://api.github.com/repos/solettaproject/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/solettaproject/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/solettaproject/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/solettaproject/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/solettaproject/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/solettaproject/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solettaproject/soletta/merges","archive_url":"https://api.github.com/repos/solettaproject/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solettaproject/soletta/downloads","issues_url":"https://api.github.com/repos/solettaproject/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/solettaproject/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/solettaproject/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/solettaproject/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solettaproject/soletta/labels{/name}","releases_url":"https://api.github.com/repos/solettaproject/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/solettaproject/soletta/deployments","created_at":"2015-06-08T19:13:18Z","updated_at":"2016-03-28T01:06:55Z","pushed_at":"2016-03-28T15:00:45Z","git_url":"git://github.com/solettaproject/soletta.git","ssh_url":"git@github.com:solettaproject/soletta.git","clone_url":"https://github.com/solettaproject/soletta.git","svn_url":"https://github.com/solettaproject/soletta","homepage":"http://solettaproject.org","size":24490,"stargazers_count":79,"watchers_count":79,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":168,"forks":63,"open_issues":168,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1735"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1735"},"issue":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1735"},"comments":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1735/comments"},"review_comments":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1735/comments"},"review_comment":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1735/commits"},"statuses":{"href":"https://api.github.com/repos/solettaproject/soletta/statuses/0fd35259d7a23439bdc952fc8fd3e0cb86fadabb"}}}}