{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/67034643","id":67034643,"diff_hunk":"@@ -1315,6 +1346,7 @@ namespace aspect\n     AdiabaticConditions::declare_parameters<dim> (prm);\n     VelocityBoundaryConditions::declare_parameters<dim> (prm);\n     TractionBoundaryConditions::declare_parameters<dim> (prm);\n+","path":"source/simulator/parameters.cc","position":77,"original_position":77,"commit_id":"462ec943f9fb530243edeecb84f17a830eefa351","original_commit_id":"462ec943f9fb530243edeecb84f17a830eefa351","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"no need for the empty line here.","created_at":"2016-06-14T18:58:41Z","updated_at":"2016-06-14T18:58:41Z","html_url":"https://github.com/geodynamics/aspect/pull/894#discussion_r67034643","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/894","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/67034643"},"html":{"href":"https://github.com/geodynamics/aspect/pull/894#discussion_r67034643"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/894"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/894","id":71591245,"html_url":"https://github.com/geodynamics/aspect/pull/894","diff_url":"https://github.com/geodynamics/aspect/pull/894.diff","patch_url":"https://github.com/geodynamics/aspect/pull/894.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/894","number":894,"state":"open","locked":false,"title":"[For review, do not merge] Squashed main melt implementation","user":{"login":"jdannberg","id":7517347,"avatar_url":"https://avatars.githubusercontent.com/u/7517347?v=3","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"body":"This is the core of the melt implementation (ripped out of the melt branch). \r\nTo make the pull request small enough for reviewing, we here include only the general implementation. All additional features such as melt material models, heating models and benchmarks will follow separately. The code also still contains a few todos that we plan to work on soon, but we would already  be glad about feedback regarding the structure and possible improvements. \r\nOverall, it would be great if we could merge the melt implementation before the hackathon, so that we can avoid getting additional conflicts.","created_at":"2016-05-26T17:10:14Z","updated_at":"2016-06-14T18:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e55080436fa4261ca970a70a445312f50e0650f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/894/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/894/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/894/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/462ec943f9fb530243edeecb84f17a830eefa351","head":{"label":"jdannberg:melt_review","ref":"melt_review","sha":"462ec943f9fb530243edeecb84f17a830eefa351","user":{"login":"jdannberg","id":7517347,"avatar_url":"https://avatars.githubusercontent.com/u/7517347?v=3","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"repo":{"id":19785028,"name":"aspect","full_name":"jdannberg/aspect","owner":{"login":"jdannberg","id":7517347,"avatar_url":"https://avatars.githubusercontent.com/u/7517347?v=3","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdannberg/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/jdannberg/aspect","forks_url":"https://api.github.com/repos/jdannberg/aspect/forks","keys_url":"https://api.github.com/repos/jdannberg/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdannberg/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdannberg/aspect/teams","hooks_url":"https://api.github.com/repos/jdannberg/aspect/hooks","issue_events_url":"https://api.github.com/repos/jdannberg/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/jdannberg/aspect/events","assignees_url":"https://api.github.com/repos/jdannberg/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/jdannberg/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/jdannberg/aspect/tags","blobs_url":"https://api.github.com/repos/jdannberg/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdannberg/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdannberg/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdannberg/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdannberg/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/jdannberg/aspect/languages","stargazers_url":"https://api.github.com/repos/jdannberg/aspect/stargazers","contributors_url":"https://api.github.com/repos/jdannberg/aspect/contributors","subscribers_url":"https://api.github.com/repos/jdannberg/aspect/subscribers","subscription_url":"https://api.github.com/repos/jdannberg/aspect/subscription","commits_url":"https://api.github.com/repos/jdannberg/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdannberg/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdannberg/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdannberg/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdannberg/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/jdannberg/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdannberg/aspect/merges","archive_url":"https://api.github.com/repos/jdannberg/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdannberg/aspect/downloads","issues_url":"https://api.github.com/repos/jdannberg/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/jdannberg/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/jdannberg/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/jdannberg/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdannberg/aspect/labels{/name}","releases_url":"https://api.github.com/repos/jdannberg/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/jdannberg/aspect/deployments","created_at":"2014-05-14T15:28:24Z","updated_at":"2015-09-22T19:25:32Z","pushed_at":"2016-06-13T18:12:21Z","git_url":"git://github.com/jdannberg/aspect.git","ssh_url":"git@github.com:jdannberg/aspect.git","clone_url":"https://github.com/jdannberg/aspect.git","svn_url":"https://github.com/jdannberg/aspect","homepage":null,"size":116281,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"59706cd901b3381efe63df06f6091d7269f55a92","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2016-05-24T08:27:31Z","pushed_at":"2016-06-11T00:41:54Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":136705,"stargazers_count":26,"watchers_count":26,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":90,"forks":55,"open_issues":90,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/894"},"html":{"href":"https://github.com/geodynamics/aspect/pull/894"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/894"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/462ec943f9fb530243edeecb84f17a830eefa351"}}}}
{"actor":{"display_login":"bangerth"}}