{"action":"created","issue":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340","repository_url":"https://api.github.com/repos/HubTurbo/HubTurbo","labels_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340/labels{/name}","comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340/comments","events_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340/events","html_url":"https://github.com/HubTurbo/HubTurbo/pull/1340","id":140404095,"number":1340,"title":"F1 key doesn't work when the focus is in a filter box #1167","user":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/labels/status.toMerge","name":"status.toMerge","color":"4D804D"}],"state":"open","locked":false,"assignee":{"login":"dariusf","id":4328341,"avatar_url":"https://avatars.githubusercontent.com/u/4328341?v=3","gravatar_id":"","url":"https://api.github.com/users/dariusf","html_url":"https://github.com/dariusf","followers_url":"https://api.github.com/users/dariusf/followers","following_url":"https://api.github.com/users/dariusf/following{/other_user}","gists_url":"https://api.github.com/users/dariusf/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusf/subscriptions","organizations_url":"https://api.github.com/users/dariusf/orgs","repos_url":"https://api.github.com/users/dariusf/repos","events_url":"https://api.github.com/users/dariusf/events{/privacy}","received_events_url":"https://api.github.com/users/dariusf/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2016-03-12T18:04:31Z","updated_at":"2016-03-19T15:29:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340","html_url":"https://github.com/HubTurbo/HubTurbo/pull/1340","diff_url":"https://github.com/HubTurbo/HubTurbo/pull/1340.diff","patch_url":"https://github.com/HubTurbo/HubTurbo/pull/1340.patch"},"body":"Fixes #1167.\r\n\r\n**REVIEW**\r\n\r\n**Current status**:\r\nWhen filter text box is in focus, pressing <kbd>F1</kbd> redirects the browser component to the filter docs page.\r\n\r\n**Work done**: \r\n- ~~`FilterPanel` now passes its `UI` reference to `FilterTextField`~~\r\n- ~~`FilterTextField` now maintains a final field to hold the `UI`reference~~\r\n- ~~`FilterTextField` setup method now includes handling for the `KeyboardShortcuts.SHOW_DOCS` key combination (<kbd>F1</kbd>), which calls UI's browser's`BrowserComponent.showDocs()` method.~~\r\n- ~~The above handling code is copied from a [slice](https://github.com/HubTurbo/HubTurbo/blob/880d65c081505c9e8a547c29d188293a56c5de24/src/main/java/ui/listpanel/ListPanel.java#L171-L173) of `ListPanel.setupKeyboardShorcuts()`~~\r\n- Make F1 link to 'filters' section of docs\r\n- Change implementation: expose help key press callback hook on `FilterTextField` to decouple from rest of app\r\n- All instantiations of `FilterTextField` now register the correct callback for help key press\r\n- Regression testing under `guitests.FilterTextFieldTest`\r\n\r\n**Future**:\r\nnull"},"comment":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/comments/198724160","html_url":"https://github.com/HubTurbo/HubTurbo/pull/1340#issuecomment-198724160","issue_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340","id":198724160,"user":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"created_at":"2016-03-19T15:29:50Z","updated_at":"2016-03-19T15:29:50Z","body":"@dariusf Strange all I did was merge `master` into this branch. When coveralls says `coverage increased/decreased to X`, what baseline are they comparing it to?"}}