{"action":"created","comment":{"url":"https://api.github.com/repos/docker/distribution/pulls/comments/55576324","id":55576324,"diff_hunk":"@@ -146,6 +157,8 @@ An implementation of the `storagedriver.StorageDriver` interface which uses Amaz\n \n `region`: The name of the aws region in which you would like to store objects (for example `us-east-1`). For a list of regions, you can look at http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html\n \n+`regionendpoint`: empty for Amazon S3 or url for S3 compatible APIs.","path":"docs/storage-drivers/s3.md","position":31,"original_position":31,"commit_id":"73ffb0457f3b14b3898695cdf191713c96a2e141","original_commit_id":"73ffb0457f3b14b3898695cdf191713c96a2e141","user":{"login":"BrianBland","id":2295742,"avatar_url":"https://avatars.githubusercontent.com/u/2295742?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianBland","html_url":"https://github.com/BrianBland","followers_url":"https://api.github.com/users/BrianBland/followers","following_url":"https://api.github.com/users/BrianBland/following{/other_user}","gists_url":"https://api.github.com/users/BrianBland/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBland/subscriptions","organizations_url":"https://api.github.com/users/BrianBland/orgs","repos_url":"https://api.github.com/users/BrianBland/repos","events_url":"https://api.github.com/users/BrianBland/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBland/received_events","type":"User","site_admin":false},"body":"```\r\n`regionendpoint`: (optional) Endpoint URL for S3 compatible APIs. This should not be provided when using Amazon S3.\r\n```","created_at":"2016-03-09T19:41:00Z","updated_at":"2016-03-09T19:41:00Z","html_url":"https://github.com/docker/distribution/pull/1512#discussion_r55576324","pull_request_url":"https://api.github.com/repos/docker/distribution/pulls/1512","_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments/55576324"},"html":{"href":"https://github.com/docker/distribution/pull/1512#discussion_r55576324"},"pull_request":{"href":"https://api.github.com/repos/docker/distribution/pulls/1512"}}},"pull_request":{"url":"https://api.github.com/repos/docker/distribution/pulls/1512","id":61822162,"html_url":"https://github.com/docker/distribution/pull/1512","diff_url":"https://github.com/docker/distribution/pull/1512.diff","patch_url":"https://github.com/docker/distribution/pull/1512.patch","issue_url":"https://api.github.com/repos/docker/distribution/issues/1512","number":1512,"state":"open","locked":false,"title":"Added support to specifiy custom endpoint","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"Main purpose of this PR is to enhance the support to provide custom endpoint url which can be used to connect to other S3 compatibly storage services like [Minio](https://github.com/minio/minio).\r\n\r\nI also want to know if there is any reason preventing from adding the extra condition to create a bucket if it doesn't exist similar to https://github.com/docker/distribution/blob/master/registry/storage/driver/azure/azure.go#L87","created_at":"2016-03-05T19:56:22Z","updated_at":"2016-03-09T19:41:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c270d15b3507b842def899269ba4124e736311bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/distribution/pulls/1512/commits","review_comments_url":"https://api.github.com/repos/docker/distribution/pulls/1512/comments","review_comment_url":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/distribution/issues/1512/comments","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/73ffb0457f3b14b3898695cdf191713c96a2e141","head":{"label":"kmala:master","ref":"master","sha":"73ffb0457f3b14b3898695cdf191713c96a2e141","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"repo":{"id":51877073,"name":"distribution","full_name":"kmala/distribution","owner":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmala/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":true,"url":"https://api.github.com/repos/kmala/distribution","forks_url":"https://api.github.com/repos/kmala/distribution/forks","keys_url":"https://api.github.com/repos/kmala/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmala/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmala/distribution/teams","hooks_url":"https://api.github.com/repos/kmala/distribution/hooks","issue_events_url":"https://api.github.com/repos/kmala/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/kmala/distribution/events","assignees_url":"https://api.github.com/repos/kmala/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/kmala/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/kmala/distribution/tags","blobs_url":"https://api.github.com/repos/kmala/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmala/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmala/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmala/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmala/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/kmala/distribution/languages","stargazers_url":"https://api.github.com/repos/kmala/distribution/stargazers","contributors_url":"https://api.github.com/repos/kmala/distribution/contributors","subscribers_url":"https://api.github.com/repos/kmala/distribution/subscribers","subscription_url":"https://api.github.com/repos/kmala/distribution/subscription","commits_url":"https://api.github.com/repos/kmala/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmala/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmala/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmala/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmala/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/kmala/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmala/distribution/merges","archive_url":"https://api.github.com/repos/kmala/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmala/distribution/downloads","issues_url":"https://api.github.com/repos/kmala/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/kmala/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/kmala/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/kmala/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmala/distribution/labels{/name}","releases_url":"https://api.github.com/repos/kmala/distribution/releases{/id}","deployments_url":"https://api.github.com/repos/kmala/distribution/deployments","created_at":"2016-02-16T23:04:13Z","updated_at":"2016-02-16T23:04:14Z","pushed_at":"2016-03-09T00:08:27Z","git_url":"git://github.com/kmala/distribution.git","ssh_url":"git@github.com:kmala/distribution.git","clone_url":"https://github.com/kmala/distribution.git","svn_url":"https://github.com/kmala/distribution","homepage":null,"size":8895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"46b2c3fadf295e399ae0c7558f00b3676cd4302e","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":28366058,"name":"distribution","full_name":"docker/distribution","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":false,"url":"https://api.github.com/repos/docker/distribution","forks_url":"https://api.github.com/repos/docker/distribution/forks","keys_url":"https://api.github.com/repos/docker/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/distribution/teams","hooks_url":"https://api.github.com/repos/docker/distribution/hooks","issue_events_url":"https://api.github.com/repos/docker/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/docker/distribution/events","assignees_url":"https://api.github.com/repos/docker/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/docker/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/docker/distribution/tags","blobs_url":"https://api.github.com/repos/docker/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/distribution/languages","stargazers_url":"https://api.github.com/repos/docker/distribution/stargazers","contributors_url":"https://api.github.com/repos/docker/distribution/contributors","subscribers_url":"https://api.github.com/repos/docker/distribution/subscribers","subscription_url":"https://api.github.com/repos/docker/distribution/subscription","commits_url":"https://api.github.com/repos/docker/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/docker/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/distribution/merges","archive_url":"https://api.github.com/repos/docker/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/distribution/downloads","issues_url":"https://api.github.com/repos/docker/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/docker/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/distribution/labels{/name}","releases_url":"https://api.github.com/repos/docker/distribution/releases{/id}","deployments_url":"https://api.github.com/repos/docker/distribution/deployments","created_at":"2014-12-22T23:49:26Z","updated_at":"2016-03-08T22:31:32Z","pushed_at":"2016-03-09T00:38:50Z","git_url":"git://github.com/docker/distribution.git","ssh_url":"git@github.com:docker/distribution.git","clone_url":"https://github.com/docker/distribution.git","svn_url":"https://github.com/docker/distribution","homepage":null,"size":11805,"stargazers_count":1804,"watchers_count":1804,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":176,"forks":667,"open_issues":176,"watchers":1804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/1512"},"html":{"href":"https://github.com/docker/distribution/pull/1512"},"issue":{"href":"https://api.github.com/repos/docker/distribution/issues/1512"},"comments":{"href":"https://api.github.com/repos/docker/distribution/issues/1512/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/distribution/pulls/1512/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/distribution/pulls/1512/commits"},"statuses":{"href":"https://api.github.com/repos/docker/distribution/statuses/73ffb0457f3b14b3898695cdf191713c96a2e141"}}}}