{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/53900487","id":53900487,"diff_hunk":"@@ -1,61 +1,61 @@\n-<nav class=\"menu\">\n-  <ul data-hook=\"admin_order_tabs\">\n+<nav>\n+  <ul class=\"tabs\" data-hook=\"admin_order_tabs\">\n     <% if (@order.shipments.count == 0 || @order.shipped_shipments.count == 0) %>\n-      <li<%== ' class=\"active\"' if current == 'Cart' %> data-hook='admin_order_tabs_order_details'>\n+      <li class=\"<%= \"active\" if current == \"Cart\" %>\" data-hook='admin_order_tabs_order_details'>\n         <%= link_to_with_icon 'shopping-cart', Spree.t(:cart), cart_admin_order_url(@order) %>\n       </li>\n     <% end %>\n \n     <% if checkout_steps.include?(\"address\") %>\n-      <li<%== ' class=\"active\"' if current == 'Customer Details' %> data-hook='admin_order_tabs_customer_details'>\n+      <li class=\"<%= \"active\" if (current == \"Customer Details\") %>\" data-hook='admin_order_tabs_customer_details'>\n         <% if can?(:update, @order) %>\n-          <%= link_to_with_icon 'user', Spree.t(:customer_details), edit_admin_order_customer_url(@order) %>\n+          <%= link_to_with_icon 'user', Spree.t(:customer), edit_admin_order_customer_url(@order) %>\n         <% else %>\n-          <%= link_to_with_icon 'user', Spree.t(:customer_details), admin_order_customer_url(@order) %>\n+          <%= link_to_with_icon 'user', Spree.t(:customer), admin_order_customer_url(@order) %>\n         <% end %>\n       </li>\n     <% end %>\n \n-    <li<%== ' class=\"active\"' if current == 'Shipments' %> data-hook='admin_order_tabs_order_details'>\n+    <li class=\"<%= \"active\" if current == \"Shipments\" %>\" data-hook='admin_order_tabs_order_details'>\n       <%= link_to_with_icon 'edit', Spree::Shipment.model_name.human(count: :other), edit_admin_order_url(@order) %>\n     </li>\n \n     <% if can? :display, Spree::Adjustment %>\n-      <li<%== ' class=\"active\"' if current == 'Adjustments' %> data-hook='admin_order_tabs_adjustments'>\n+      <li class=\"<%= \"active\" if current == \"Adjustments\" %>\" data-hook='admin_order_tabs_adjustments'>\n         <%= link_to_with_icon 'cogs', Spree::Adjustment.model_name.human(count: :other), admin_order_adjustments_url(@order) %>\n       </li>\n     <% end %>\n \n     <% if can?(:display, Spree::Payment) %>\n-      <li<%== ' class=\"active\"' if current == 'Payments' %> data-hook='admin_order_tabs_payments'>\n+      <li class=\"<%= \"active\" if current == \"Payments\" %>\" data-hook='admin_order_tabs_payments'>\n         <%= link_to_with_icon 'credit-card', Spree::Payment.model_name.human(count: :other), admin_order_payments_url(@order) %>\n       </li>\n     <% end %>\n \n     <% if !@order.completed? && can?(:update, @order) %>\n-      <li<%== ' class=\"active\"' if current == 'Confirm' %> data-hook='admin_order_tabs_confirm'>\n+      <li class=\"<%= \"active\" if current == \"Confirm\" %>\" data-hook='admin_order_tabs_confirm'>\n         <%= link_to_with_icon 'check', Spree.t(:confirm), confirm_admin_order_url(@order) %>\n       </li>\n     <% end %>\n \n     <% if can? :display, Spree::ReturnAuthorization %>\n       <% if @order.completed? %>\n-        <li<%== ' class=\"active\"' if current == 'Return Authorizations' %> data-hook='admin_order_tabs_return_authorizations'>\n-          <%= link_to_with_icon 'share', Spree::ReturnAuthorization.model_name.human(count: :other), admin_order_return_authorizations_url(@order) %>\n+        <li class=\"tab <%= \"active\" if current == \"Return Authorizations\" %>\" data-hook='admin_order_tabs_return_authorizations'>\n+          <%= link_to_with_icon 'share', Spree.t(:rma), admin_order_return_authorizations_url(@order) %>","path":"backend/app/views/spree/admin/shared/_order_submenu.html.erb","position":56,"original_position":56,"commit_id":"3385cde4a54d2d5735f323092e54cf479212a2fc","original_commit_id":"3385cde4a54d2d5735f323092e54cf479212a2fc","user":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"body":"We currently do a bunch of work to use `model_name.human` everywhere. So introducing a new `rma` key is not preferred here. So we should change the translation of the mode name here. Although this will have wider consequences. \r\n\r\nUsing the `admin.tab` scope would be ok for me. ","created_at":"2016-02-24T06:50:17Z","updated_at":"2016-02-24T06:50:17Z","html_url":"https://github.com/solidusio/solidus/pull/870#discussion_r53900487","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/870","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/53900487"},"html":{"href":"https://github.com/solidusio/solidus/pull/870#discussion_r53900487"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/870"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/870","id":59730046,"html_url":"https://github.com/solidusio/solidus/pull/870","diff_url":"https://github.com/solidusio/solidus/pull/870.diff","patch_url":"https://github.com/solidusio/solidus/pull/870.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/870","number":870,"state":"open","locked":false,"title":"Add Tabs Component","user":{"login":"graygilmore","id":836758,"avatar_url":"https://avatars.githubusercontent.com/u/836758?v=3","gravatar_id":"","url":"https://api.github.com/users/graygilmore","html_url":"https://github.com/graygilmore","followers_url":"https://api.github.com/users/graygilmore/followers","following_url":"https://api.github.com/users/graygilmore/following{/other_user}","gists_url":"https://api.github.com/users/graygilmore/gists{/gist_id}","starred_url":"https://api.github.com/users/graygilmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graygilmore/subscriptions","organizations_url":"https://api.github.com/users/graygilmore/orgs","repos_url":"https://api.github.com/users/graygilmore/repos","events_url":"https://api.github.com/users/graygilmore/events{/privacy}","received_events_url":"https://api.github.com/users/graygilmore/received_events","type":"User","site_admin":false},"body":"First step in https://github.com/solidusio/solidus/issues/633\r\n\r\nI would love some feedback on the JS. I liked bringing this in house. I know there's a library out there that probably does this plus a million things but that's a road I always try to avoid going down.\r\n\r\n- [x] Re-add the `<nav>` element: https://github.com/solidusio/solidus/commit/fecc715a4b3f10e09c5a3d4a3036fa81d9212bbe#commitcomment-16168308\r\n- [x] Don't trigger the window's resize: https://github.com/solidusio/solidus/commit/8c67bc3d7ce719ed31a0cc4ff644b577d6a988d7#commitcomment-16167954\r\n- [x] Drop the need for the `.tab` class: https://github.com/solidusio/solidus/commit/fecc715a4b3f10e09c5a3d4a3036fa81d9212bbe#commitcomment-16168251\r\n- [x] Initial page load on Safari is miscalculating widths and not creating the dropdown.\r\n- [x] Shorten the wording on the order submenu: https://github.com/solidusio/solidus/pull/870#issuecomment-185484812\r\n\r\n## Before\r\n<img width=\"1007\" alt=\"screen shot 2016-02-17 at 3 58 23 pm\" src=\"https://cloud.githubusercontent.com/assets/836758/13129073/51daa6f4-d58f-11e5-8687-326af4646fb7.png\">\r\n\r\n## After\r\n<img width=\"1003\" alt=\"screen shot 2016-02-17 at 3 57 46 pm\" src=\"https://cloud.githubusercontent.com/assets/836758/13129062/3e29d2f6-d58f-11e5-8338-e977e6b32fc4.png\">\r\n","created_at":"2016-02-17T23:59:50Z","updated_at":"2016-02-24T06:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc7ea20102c6c0e48d2c2fc99cf2814e8c7787e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/870/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/870/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/870/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/3385cde4a54d2d5735f323092e54cf479212a2fc","head":{"label":"graygilmore:replace_sidebar_with_tabs","ref":"replace_sidebar_with_tabs","sha":"3385cde4a54d2d5735f323092e54cf479212a2fc","user":{"login":"graygilmore","id":836758,"avatar_url":"https://avatars.githubusercontent.com/u/836758?v=3","gravatar_id":"","url":"https://api.github.com/users/graygilmore","html_url":"https://github.com/graygilmore","followers_url":"https://api.github.com/users/graygilmore/followers","following_url":"https://api.github.com/users/graygilmore/following{/other_user}","gists_url":"https://api.github.com/users/graygilmore/gists{/gist_id}","starred_url":"https://api.github.com/users/graygilmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graygilmore/subscriptions","organizations_url":"https://api.github.com/users/graygilmore/orgs","repos_url":"https://api.github.com/users/graygilmore/repos","events_url":"https://api.github.com/users/graygilmore/events{/privacy}","received_events_url":"https://api.github.com/users/graygilmore/received_events","type":"User","site_admin":false},"repo":{"id":45566083,"name":"solidus","full_name":"graygilmore/solidus","owner":{"login":"graygilmore","id":836758,"avatar_url":"https://avatars.githubusercontent.com/u/836758?v=3","gravatar_id":"","url":"https://api.github.com/users/graygilmore","html_url":"https://github.com/graygilmore","followers_url":"https://api.github.com/users/graygilmore/followers","following_url":"https://api.github.com/users/graygilmore/following{/other_user}","gists_url":"https://api.github.com/users/graygilmore/gists{/gist_id}","starred_url":"https://api.github.com/users/graygilmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graygilmore/subscriptions","organizations_url":"https://api.github.com/users/graygilmore/orgs","repos_url":"https://api.github.com/users/graygilmore/repos","events_url":"https://api.github.com/users/graygilmore/events{/privacy}","received_events_url":"https://api.github.com/users/graygilmore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graygilmore/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/graygilmore/solidus","forks_url":"https://api.github.com/repos/graygilmore/solidus/forks","keys_url":"https://api.github.com/repos/graygilmore/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graygilmore/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graygilmore/solidus/teams","hooks_url":"https://api.github.com/repos/graygilmore/solidus/hooks","issue_events_url":"https://api.github.com/repos/graygilmore/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/graygilmore/solidus/events","assignees_url":"https://api.github.com/repos/graygilmore/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/graygilmore/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/graygilmore/solidus/tags","blobs_url":"https://api.github.com/repos/graygilmore/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graygilmore/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graygilmore/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/graygilmore/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graygilmore/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/graygilmore/solidus/languages","stargazers_url":"https://api.github.com/repos/graygilmore/solidus/stargazers","contributors_url":"https://api.github.com/repos/graygilmore/solidus/contributors","subscribers_url":"https://api.github.com/repos/graygilmore/solidus/subscribers","subscription_url":"https://api.github.com/repos/graygilmore/solidus/subscription","commits_url":"https://api.github.com/repos/graygilmore/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/graygilmore/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/graygilmore/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/graygilmore/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/graygilmore/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/graygilmore/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graygilmore/solidus/merges","archive_url":"https://api.github.com/repos/graygilmore/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graygilmore/solidus/downloads","issues_url":"https://api.github.com/repos/graygilmore/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/graygilmore/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/graygilmore/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/graygilmore/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graygilmore/solidus/labels{/name}","releases_url":"https://api.github.com/repos/graygilmore/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/graygilmore/solidus/deployments","created_at":"2015-11-04T20:40:21Z","updated_at":"2016-02-01T18:24:22Z","pushed_at":"2016-02-23T23:58:38Z","git_url":"git://github.com/graygilmore/solidus.git","ssh_url":"git@github.com:graygilmore/solidus.git","clone_url":"https://github.com/graygilmore/solidus.git","svn_url":"https://github.com/graygilmore/solidus","homepage":"http://solidus.io/","size":61959,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"a6ad3e5d22d127119422cdc666df7c2a78c0aad6","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-02-24T01:59:08Z","pushed_at":"2016-02-24T02:12:54Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":67486,"stargazers_count":826,"watchers_count":826,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":105,"forks":204,"open_issues":105,"watchers":826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/870"},"html":{"href":"https://github.com/solidusio/solidus/pull/870"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/870"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/870/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/870/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/870/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/3385cde4a54d2d5735f323092e54cf479212a2fc"}}}}