{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/89046198","pull_request_review_id":9597492,"id":89046198,"diff_hunk":"@@ -150,12 +153,12 @@\n       </_SupplementalTestData>\n     </ItemGroup>\n     <ItemGroup>\n-      <SupplementalTestDataTestDir Include=\"@(_SupplementalTestData->'$(TestPath)/%(DestinationDir)%(Filename)%(Extension)')\" />","path":"src/Microsoft.DotNet.Build.Tasks/PackageFiles/publishtest.targets","position":112,"original_position":105,"commit_id":"7cc9126eedcfb1808f675532db5dabdce724faf0","original_commit_id":"3440ee63506f32d1dfcd28f6f5befd7852b41e71","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"I must have missed part of that discussion because while I'm OK with leaving CopySupplementalData as an item group I still believe it should be copied into Content as part of the build so we don't need to special case it anywhere else in our targets. ","created_at":"2016-11-22T05:38:21Z","updated_at":"2016-11-22T05:38:21Z","html_url":"https://github.com/dotnet/buildtools/pull/1228#discussion_r89046198","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1228","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/89046198"},"html":{"href":"https://github.com/dotnet/buildtools/pull/1228#discussion_r89046198"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1228"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/1228","id":93854213,"html_url":"https://github.com/dotnet/buildtools/pull/1228","diff_url":"https://github.com/dotnet/buildtools/pull/1228.diff","patch_url":"https://github.com/dotnet/buildtools/pull/1228.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/1228","number":1228,"state":"open","locked":false,"title":"Refactor testing targets","user":{"login":"naamunds","id":8249261,"avatar_url":"https://avatars.githubusercontent.com/u/8249261?v=3","gravatar_id":"","url":"https://api.github.com/users/naamunds","html_url":"https://github.com/naamunds","followers_url":"https://api.github.com/users/naamunds/followers","following_url":"https://api.github.com/users/naamunds/following{/other_user}","gists_url":"https://api.github.com/users/naamunds/gists{/gist_id}","starred_url":"https://api.github.com/users/naamunds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naamunds/subscriptions","organizations_url":"https://api.github.com/users/naamunds/orgs","repos_url":"https://api.github.com/users/naamunds/repos","events_url":"https://api.github.com/users/naamunds/events{/privacy}","received_events_url":"https://api.github.com/users/naamunds/received_events","type":"User","site_admin":false},"body":"- Eliminate duplication in the copying of files by having the test\r\nexecution script only copy the dependencies which aren't already copied\r\nin CopyTestToTestDir.  Also use a single ItemGroup to represent those\r\ntest dependencies.\r\n- Clarify the target names and behavior, e.g. by moving the logic to\r\ncalculate the test dependencies from CopyTestToTestDirectory to\r\nDiscoverTestDependencies.\r\n- Use MSBuild to copy dependencies to the test directory for all local\r\nbuilds instead of just when building in VS.  This ensures that all\r\ndependencies are updated when building incrementally.\r\n\r\nFixes #1098 \r\n\r\nSee also #1116, #1163\r\n\r\n/cc @weshaggard @MattGal @chcosta ","created_at":"2016-11-15T21:43:11Z","updated_at":"2016-11-22T05:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3006105fd038fe4e0887d0276461ee3630d8eb2e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1228/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1228/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/1228/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/7cc9126eedcfb1808f675532db5dabdce724faf0","head":{"label":"naamunds:FixIncrementalBuild","ref":"FixIncrementalBuild","sha":"7cc9126eedcfb1808f675532db5dabdce724faf0","user":{"login":"naamunds","id":8249261,"avatar_url":"https://avatars.githubusercontent.com/u/8249261?v=3","gravatar_id":"","url":"https://api.github.com/users/naamunds","html_url":"https://github.com/naamunds","followers_url":"https://api.github.com/users/naamunds/followers","following_url":"https://api.github.com/users/naamunds/following{/other_user}","gists_url":"https://api.github.com/users/naamunds/gists{/gist_id}","starred_url":"https://api.github.com/users/naamunds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naamunds/subscriptions","organizations_url":"https://api.github.com/users/naamunds/orgs","repos_url":"https://api.github.com/users/naamunds/repos","events_url":"https://api.github.com/users/naamunds/events{/privacy}","received_events_url":"https://api.github.com/users/naamunds/received_events","type":"User","site_admin":false},"repo":{"id":39912245,"name":"buildtools","full_name":"naamunds/buildtools","owner":{"login":"naamunds","id":8249261,"avatar_url":"https://avatars.githubusercontent.com/u/8249261?v=3","gravatar_id":"","url":"https://api.github.com/users/naamunds","html_url":"https://github.com/naamunds","followers_url":"https://api.github.com/users/naamunds/followers","following_url":"https://api.github.com/users/naamunds/following{/other_user}","gists_url":"https://api.github.com/users/naamunds/gists{/gist_id}","starred_url":"https://api.github.com/users/naamunds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naamunds/subscriptions","organizations_url":"https://api.github.com/users/naamunds/orgs","repos_url":"https://api.github.com/users/naamunds/repos","events_url":"https://api.github.com/users/naamunds/events{/privacy}","received_events_url":"https://api.github.com/users/naamunds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naamunds/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/naamunds/buildtools","forks_url":"https://api.github.com/repos/naamunds/buildtools/forks","keys_url":"https://api.github.com/repos/naamunds/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naamunds/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naamunds/buildtools/teams","hooks_url":"https://api.github.com/repos/naamunds/buildtools/hooks","issue_events_url":"https://api.github.com/repos/naamunds/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/naamunds/buildtools/events","assignees_url":"https://api.github.com/repos/naamunds/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/naamunds/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/naamunds/buildtools/tags","blobs_url":"https://api.github.com/repos/naamunds/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naamunds/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naamunds/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/naamunds/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naamunds/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/naamunds/buildtools/languages","stargazers_url":"https://api.github.com/repos/naamunds/buildtools/stargazers","contributors_url":"https://api.github.com/repos/naamunds/buildtools/contributors","subscribers_url":"https://api.github.com/repos/naamunds/buildtools/subscribers","subscription_url":"https://api.github.com/repos/naamunds/buildtools/subscription","commits_url":"https://api.github.com/repos/naamunds/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/naamunds/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/naamunds/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/naamunds/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/naamunds/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/naamunds/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naamunds/buildtools/merges","archive_url":"https://api.github.com/repos/naamunds/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naamunds/buildtools/downloads","issues_url":"https://api.github.com/repos/naamunds/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/naamunds/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/naamunds/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/naamunds/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naamunds/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/naamunds/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/naamunds/buildtools/deployments","created_at":"2015-07-29T19:30:18Z","updated_at":"2016-01-21T21:50:47Z","pushed_at":"2016-11-17T18:23:13Z","git_url":"git://github.com/naamunds/buildtools.git","ssh_url":"git@github.com:naamunds/buildtools.git","clone_url":"https://github.com/naamunds/buildtools.git","svn_url":"https://github.com/naamunds/buildtools","homepage":"","size":4117,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"807748beed881952b55fdee482164f9426ca62ef","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-11-08T04:07:07Z","pushed_at":"2016-11-22T02:30:05Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":5554,"stargazers_count":436,"watchers_count":436,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":226,"mirror_url":null,"open_issues_count":144,"forks":226,"open_issues":144,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1228"},"html":{"href":"https://github.com/dotnet/buildtools/pull/1228"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1228"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1228/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1228/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1228/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/7cc9126eedcfb1808f675532db5dabdce724faf0"}}}}
{"actor":{"display_login":"weshaggard"}}