{"action":"created","issue":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1341","repository_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js","labels_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1341/labels{/name}","comments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1341/comments","events_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1341/events","html_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1341","id":149486878,"number":1341,"title":"Fixes #1340 - make TTMLParser more permissive of non-EBU-TT-D","user":{"login":"bbcrddave","id":5390145,"avatar_url":"https://avatars.githubusercontent.com/u/5390145?v=3","gravatar_id":"","url":"https://api.github.com/users/bbcrddave","html_url":"https://github.com/bbcrddave","followers_url":"https://api.github.com/users/bbcrddave/followers","following_url":"https://api.github.com/users/bbcrddave/following{/other_user}","gists_url":"https://api.github.com/users/bbcrddave/gists{/gist_id}","starred_url":"https://api.github.com/users/bbcrddave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbcrddave/subscriptions","organizations_url":"https://api.github.com/users/bbcrddave/orgs","repos_url":"https://api.github.com/users/bbcrddave/repos","events_url":"https://api.github.com/users/bbcrddave/events{/privacy}","received_events_url":"https://api.github.com/users/bbcrddave/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-19T14:58:04Z","updated_at":"2016-04-20T09:47:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/pulls/1341","html_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1341","diff_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1341.diff","patch_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1341.patch"},"body":"Two problems were found in #1340:\r\n\r\n* if no `tts:origin` was set, the default values for `top` and `left` would attempt to place the text near the bottom. Set them to `auto` as specified in TTML1. @TobbeEdgeware, @nigelmegitt - do you agree this is sensible (esp. given that all compliant EBU-TT-D will have origin set)?\r\n\r\n* even if `tts:origin` (or any other region-specific styling) was specified, this was only honoured if found as an inline attribute of region, as required by EBU-TT-D. This constraint is not applicable for TTML, so made parsing of referenced styles on regions more lenient (ie allowed region-specific styling non-inline)."},"comment":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/comments/212354596","html_url":"https://github.com/Dash-Industry-Forum/dash.js/pull/1341#issuecomment-212354596","issue_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1341","id":212354596,"user":{"login":"nigelmegitt","id":4988915,"avatar_url":"https://avatars.githubusercontent.com/u/4988915?v=3","gravatar_id":"","url":"https://api.github.com/users/nigelmegitt","html_url":"https://github.com/nigelmegitt","followers_url":"https://api.github.com/users/nigelmegitt/followers","following_url":"https://api.github.com/users/nigelmegitt/following{/other_user}","gists_url":"https://api.github.com/users/nigelmegitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelmegitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelmegitt/subscriptions","organizations_url":"https://api.github.com/users/nigelmegitt/orgs","repos_url":"https://api.github.com/users/nigelmegitt/repos","events_url":"https://api.github.com/users/nigelmegitt/events{/privacy}","received_events_url":"https://api.github.com/users/nigelmegitt/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T09:47:09Z","updated_at":"2016-04-20T09:47:09Z","body":"By the way, `auto` isn't permitted in EBU-TT-D: I haven't checked if there's specific code for handling that value, but I can't see it in this PR. The alternative would be to replace it with `0% 0%` explicitly."}}