{"action":"created","comment":{"url":"https://api.github.com/repos/uber-go/fx/pulls/comments/92711501","pull_request_review_id":13232742,"id":92711501,"diff_hunk":"@@ -0,0 +1,81 @@\n+// Copyright (c) 2016 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package fxcontext\n+\n+import (\n+\tgcontext \"context\"\n+\n+\t\"go.uber.org/fx\"\n+\t\"go.uber.org/fx/service\"\n+\t\"go.uber.org/fx/ulog\"\n+)\n+\n+var _logger = \"logger\"","path":"internal/fxcontext/context.go","position":null,"original_position":31,"commit_id":"bc837038e1d3c163a33fb7025a4c41c90e80b344","original_commit_id":"334521633aaddc765afa5596710010ce8f95b747","user":{"login":"anuptalwalkar","id":11004015,"avatar_url":"https://avatars.githubusercontent.com/u/11004015?v=3","gravatar_id":"","url":"https://api.github.com/users/anuptalwalkar","html_url":"https://github.com/anuptalwalkar","followers_url":"https://api.github.com/users/anuptalwalkar/followers","following_url":"https://api.github.com/users/anuptalwalkar/following{/other_user}","gists_url":"https://api.github.com/users/anuptalwalkar/gists{/gist_id}","starred_url":"https://api.github.com/users/anuptalwalkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuptalwalkar/subscriptions","organizations_url":"https://api.github.com/users/anuptalwalkar/orgs","repos_url":"https://api.github.com/users/anuptalwalkar/repos","events_url":"https://api.github.com/users/anuptalwalkar/events{/privacy}","received_events_url":"https://api.github.com/users/anuptalwalkar/received_events","type":"User","site_admin":false},"body":"Thanks for the pointer. I added contextLogger as a custom contextType to for WithValue access.","created_at":"2016-12-15T22:11:56Z","updated_at":"2016-12-15T22:11:56Z","html_url":"https://github.com/uber-go/fx/pull/128#discussion_r92711501","pull_request_url":"https://api.github.com/repos/uber-go/fx/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments/92711501"},"html":{"href":"https://github.com/uber-go/fx/pull/128#discussion_r92711501"},"pull_request":{"href":"https://api.github.com/repos/uber-go/fx/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/uber-go/fx/pulls/128","id":98099062,"html_url":"https://github.com/uber-go/fx/pull/128","diff_url":"https://github.com/uber-go/fx/pull/128.diff","patch_url":"https://github.com/uber-go/fx/pull/128.patch","issue_url":"https://api.github.com/repos/uber-go/fx/issues/128","number":128,"state":"open","locked":false,"title":"Slim down Context and propogate through uhttp","user":{"login":"anuptalwalkar","id":11004015,"avatar_url":"https://avatars.githubusercontent.com/u/11004015?v=3","gravatar_id":"","url":"https://api.github.com/users/anuptalwalkar","html_url":"https://github.com/anuptalwalkar","followers_url":"https://api.github.com/users/anuptalwalkar/followers","following_url":"https://api.github.com/users/anuptalwalkar/following{/other_user}","gists_url":"https://api.github.com/users/anuptalwalkar/gists{/gist_id}","starred_url":"https://api.github.com/users/anuptalwalkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuptalwalkar/subscriptions","organizations_url":"https://api.github.com/users/anuptalwalkar/orgs","repos_url":"https://api.github.com/users/anuptalwalkar/repos","events_url":"https://api.github.com/users/anuptalwalkar/events{/privacy}","received_events_url":"https://api.github.com/users/anuptalwalkar/received_events","type":"User","site_admin":false},"body":"GFM-248, GFM-256\r\nFixes #126","created_at":"2016-12-15T07:23:45Z","updated_at":"2016-12-15T22:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592bd930c65df73e02bc6aa748e2c5f9c2a64f39","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-go/fx/pulls/128/commits","review_comments_url":"https://api.github.com/repos/uber-go/fx/pulls/128/comments","review_comment_url":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-go/fx/issues/128/comments","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/bc837038e1d3c163a33fb7025a4c41c90e80b344","head":{"label":"uber-go:fx-context-update","ref":"fx-context-update","sha":"bc837038e1d3c163a33fb7025a4c41c90e80b344","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"[ALPHA QUALITY] Service Framework","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2016-12-08T09:39:21Z","pushed_at":"2016-12-15T22:10:10Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"git@github.com:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":null,"size":527,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":20,"default_branch":"master"}},"base":{"label":"uber-go:master","ref":"master","sha":"8af54b1a294950a785751ee897aa85d37fcfbcee","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"[ALPHA QUALITY] Service Framework","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2016-12-08T09:39:21Z","pushed_at":"2016-12-15T22:10:10Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"git@github.com:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":null,"size":527,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/128"},"html":{"href":"https://github.com/uber-go/fx/pull/128"},"issue":{"href":"https://api.github.com/repos/uber-go/fx/issues/128"},"comments":{"href":"https://api.github.com/repos/uber-go/fx/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-go/fx/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-go/fx/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/uber-go/fx/statuses/bc837038e1d3c163a33fb7025a4c41c90e80b344"}}}}
{"actor":{"display_login":"anuptalwalkar"}}