{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/69658701","id":69658701,"diff_hunk":"@@ -35,17 +35,22 @@ public static bool TryParse(byte[] utf8Text, int index, out byte value, out int\n                         return true; // otherwise return true\n                     }\n                 }\n-                byte candidate = (byte)(value * 10); // left shift the value\n-                candidate += (byte)(nextByte - '0'); // parse the current digit to a byte and add it to the temporary value\n-                if (candidate >= value) // if it was a digit 0-9, this should be true\n+                try\n                 {\n-                    value = candidate;\n+                    byte candidate = checked((byte)(value * 10 + nextByte - '0')); // left shift the value and add the nextByte.\n+\n+                    if (candidate >= value) // if it was a digit 0-9, this should be true","path":"src/System.Text.Primitives/System/Text/InvariantParser_byte.cs","position":12,"original_position":12,"commit_id":"97b40ba14f920bf2dfe7c949def457e234fcddb7","original_commit_id":"97b40ba14f920bf2dfe7c949def457e234fcddb7","user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"body":"Can it be every smaller?","created_at":"2016-07-06T00:08:00Z","updated_at":"2016-07-06T00:08:00Z","html_url":"https://github.com/dotnet/corefxlab/pull/730#discussion_r69658701","pull_request_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/730","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/69658701"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/730#discussion_r69658701"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/730"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/730","id":75151941,"html_url":"https://github.com/dotnet/corefxlab/pull/730","diff_url":"https://github.com/dotnet/corefxlab/pull/730.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/730.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/730","number":730,"state":"open","locked":false,"title":"Added support for handling integer overflow","user":{"login":"jonfortescue","id":13228069,"avatar_url":"https://avatars.githubusercontent.com/u/13228069?v=3","gravatar_id":"","url":"https://api.github.com/users/jonfortescue","html_url":"https://github.com/jonfortescue","followers_url":"https://api.github.com/users/jonfortescue/followers","following_url":"https://api.github.com/users/jonfortescue/following{/other_user}","gists_url":"https://api.github.com/users/jonfortescue/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfortescue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfortescue/subscriptions","organizations_url":"https://api.github.com/users/jonfortescue/orgs","repos_url":"https://api.github.com/users/jonfortescue/repos","events_url":"https://api.github.com/users/jonfortescue/events{/privacy}","received_events_url":"https://api.github.com/users/jonfortescue/received_events","type":"User","site_admin":false},"body":"Primitive parsing APIs will now return false if overflow occurs (per #443). Also added tests for these cases, which should neatly fulfill #704 for now.","created_at":"2016-06-24T18:10:11Z","updated_at":"2016-07-06T00:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2953db08e87827c6c7b60966b5582c99fcf2cbe1","assignee":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"assignees":[{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/730/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/730/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/730/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/97b40ba14f920bf2dfe7c949def457e234fcddb7","head":{"label":"jonfortescue:OverflowHandling","ref":"OverflowHandling","sha":"97b40ba14f920bf2dfe7c949def457e234fcddb7","user":{"login":"jonfortescue","id":13228069,"avatar_url":"https://avatars.githubusercontent.com/u/13228069?v=3","gravatar_id":"","url":"https://api.github.com/users/jonfortescue","html_url":"https://github.com/jonfortescue","followers_url":"https://api.github.com/users/jonfortescue/followers","following_url":"https://api.github.com/users/jonfortescue/following{/other_user}","gists_url":"https://api.github.com/users/jonfortescue/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfortescue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfortescue/subscriptions","organizations_url":"https://api.github.com/users/jonfortescue/orgs","repos_url":"https://api.github.com/users/jonfortescue/repos","events_url":"https://api.github.com/users/jonfortescue/events{/privacy}","received_events_url":"https://api.github.com/users/jonfortescue/received_events","type":"User","site_admin":false},"repo":{"id":61159583,"name":"corefxlab","full_name":"jonfortescue/corefxlab","owner":{"login":"jonfortescue","id":13228069,"avatar_url":"https://avatars.githubusercontent.com/u/13228069?v=3","gravatar_id":"","url":"https://api.github.com/users/jonfortescue","html_url":"https://github.com/jonfortescue","followers_url":"https://api.github.com/users/jonfortescue/followers","following_url":"https://api.github.com/users/jonfortescue/following{/other_user}","gists_url":"https://api.github.com/users/jonfortescue/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfortescue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfortescue/subscriptions","organizations_url":"https://api.github.com/users/jonfortescue/orgs","repos_url":"https://api.github.com/users/jonfortescue/repos","events_url":"https://api.github.com/users/jonfortescue/events{/privacy}","received_events_url":"https://api.github.com/users/jonfortescue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonfortescue/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/jonfortescue/corefxlab","forks_url":"https://api.github.com/repos/jonfortescue/corefxlab/forks","keys_url":"https://api.github.com/repos/jonfortescue/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonfortescue/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonfortescue/corefxlab/teams","hooks_url":"https://api.github.com/repos/jonfortescue/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/jonfortescue/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/jonfortescue/corefxlab/events","assignees_url":"https://api.github.com/repos/jonfortescue/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/jonfortescue/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/jonfortescue/corefxlab/tags","blobs_url":"https://api.github.com/repos/jonfortescue/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonfortescue/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonfortescue/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonfortescue/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonfortescue/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jonfortescue/corefxlab/languages","stargazers_url":"https://api.github.com/repos/jonfortescue/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/jonfortescue/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/jonfortescue/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/jonfortescue/corefxlab/subscription","commits_url":"https://api.github.com/repos/jonfortescue/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonfortescue/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonfortescue/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonfortescue/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonfortescue/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/jonfortescue/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonfortescue/corefxlab/merges","archive_url":"https://api.github.com/repos/jonfortescue/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonfortescue/corefxlab/downloads","issues_url":"https://api.github.com/repos/jonfortescue/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/jonfortescue/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jonfortescue/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jonfortescue/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonfortescue/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/jonfortescue/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/jonfortescue/corefxlab/deployments","created_at":"2016-06-14T22:21:11Z","updated_at":"2016-06-14T22:21:12Z","pushed_at":"2016-07-05T22:19:28Z","git_url":"git://github.com/jonfortescue/corefxlab.git","ssh_url":"git@github.com:jonfortescue/corefxlab.git","clone_url":"https://github.com/jonfortescue/corefxlab.git","svn_url":"https://github.com/jonfortescue/corefxlab","homepage":"","size":29108,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"aa784e6bad5a020d1481fc2a04d7eba15bf4da96","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"name":"corefxlab","full_name":"dotnet/corefxlab","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2016-07-05T22:01:20Z","pushed_at":"2016-07-05T23:16:01Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"git@github.com:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":29662,"stargazers_count":304,"watchers_count":304,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":121,"forks":122,"open_issues":121,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/730"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/730"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/730"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/97b40ba14f920bf2dfe7c949def457e234fcddb7"}}}}
{"actor":{"display_login":"KrzysztofCwalina"}}