{"action":"created","issue":{"url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/112","repository_url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016","labels_url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/112/comments","events_url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/112/events","html_url":"https://github.com/ProgrammingLife2016/PL3-2016/pull/112","id":158647968,"number":112,"title":"Fix/phylocolours","user":{"login":"HugoKooijman","id":5989901,"avatar_url":"https://avatars.githubusercontent.com/u/5989901?v=3","gravatar_id":"","url":"https://api.github.com/users/HugoKooijman","html_url":"https://github.com/HugoKooijman","followers_url":"https://api.github.com/users/HugoKooijman/followers","following_url":"https://api.github.com/users/HugoKooijman/following{/other_user}","gists_url":"https://api.github.com/users/HugoKooijman/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoKooijman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoKooijman/subscriptions","organizations_url":"https://api.github.com/users/HugoKooijman/orgs","repos_url":"https://api.github.com/users/HugoKooijman/repos","events_url":"https://api.github.com/users/HugoKooijman/events{/privacy}","received_events_url":"https://api.github.com/users/HugoKooijman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-06T10:36:50Z","updated_at":"2016-06-06T10:39:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/pulls/112","html_url":"https://github.com/ProgrammingLife2016/PL3-2016/pull/112","diff_url":"https://github.com/ProgrammingLife2016/PL3-2016/pull/112.diff","patch_url":"https://github.com/ProgrammingLife2016/PL3-2016/pull/112.patch"},"body":"Parent nodes in the Phylogenetic tree now know the lineage of their children. Higher parent nodes with 2 children of different lineages remain coloured black, because there's not 1 colour that applies to these nodes.\r\n\r\nAlso cleaned up messy code, divided it more into smaller methods.\r\n\r\nAs for the edges, using the Path class makes it either really difficult or impossible to colour them. This is because HLineTo and VLineTo objects cannot be coloured.\r\nAlso, the pruneTree methods don't help in fixing the problem of overlapping nodes/edges, because they're basically a dirty fix to remove nodes after calculating the complete tree. The problem is, that the edges are still drawn, and to their individual moveTo's, not to the next node. So if you translate the startposition of a VLineTo or an HLineTo, it will stretch out VLineTo's and HLineTo's of nodes that were removed, resulting in many weird small lines.\r\nTrying to colour a pruned Tree will result in all kinds of weird half-coloured triangles, presumably caused by the HLineTo and VLineTo covering a certain area that is not readily apparent.\r\n\r\nI plan to replace the VLineTo and HLineTo objects with Line objects, which are vastly more customizable. The Path class just seems like a poor choice for a tree."},"comment":{"url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/comments/223924489","html_url":"https://github.com/ProgrammingLife2016/PL3-2016/pull/112#issuecomment-223924489","issue_url":"https://api.github.com/repos/ProgrammingLife2016/PL3-2016/issues/112","id":223924489,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T10:39:49Z","updated_at":"2016-06-06T10:39:49Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6475350/badge)](https://coveralls.io/builds/6475350)\n\nCoverage remained the same at 79.07% when pulling **37fcb8e9e0a5fb8a9945d6a823088ab9e3776ac3 on fix/phylocolours** into **eb6cd6d539da3404e17a9fa3c99a4a123379dfc5 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}