{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/70959500","id":70959500,"diff_hunk":"@@ -515,6 +515,7 @@ extern modal_callback gLoadSaveCallback;\n \n typedef void (*close_callback)();\n \n+#define MIN_WINDOW_COUNT 8\n #define MAX_WINDOW_COUNT 64","path":"src/interface/window.h","position":5,"original_position":5,"commit_id":"44202d0bd155386ab85ed6d809fa91769e0725e0","original_commit_id":"44202d0bd155386ab85ed6d809fa91769e0725e0","user":{"login":"Gymnasiast","id":1478678,"avatar_url":"https://avatars.githubusercontent.com/u/1478678?v=3","gravatar_id":"","url":"https://api.github.com/users/Gymnasiast","html_url":"https://github.com/Gymnasiast","followers_url":"https://api.github.com/users/Gymnasiast/followers","following_url":"https://api.github.com/users/Gymnasiast/following{/other_user}","gists_url":"https://api.github.com/users/Gymnasiast/gists{/gist_id}","starred_url":"https://api.github.com/users/Gymnasiast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gymnasiast/subscriptions","organizations_url":"https://api.github.com/users/Gymnasiast/orgs","repos_url":"https://api.github.com/users/Gymnasiast/repos","events_url":"https://api.github.com/users/Gymnasiast/events{/privacy}","received_events_url":"https://api.github.com/users/Gymnasiast/received_events","type":"User","site_admin":false},"body":"I'd rename these two defines to `WINDOW_LIMIT_MIN` and `WINDOW_LIMIT_MAX`.","created_at":"2016-07-15T11:42:24Z","updated_at":"2016-07-15T11:42:24Z","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/3805#discussion_r70959500","pull_request_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805","_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/70959500"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/3805#discussion_r70959500"},"pull_request":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805","id":72445575,"html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/3805","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/3805.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/3805.patch","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/3805","number":3805,"state":"open","locked":false,"title":"Option to set window limit","user":{"login":"wolfreak99","id":7704811,"avatar_url":"https://avatars.githubusercontent.com/u/7704811?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfreak99","html_url":"https://github.com/wolfreak99","followers_url":"https://api.github.com/users/wolfreak99/followers","following_url":"https://api.github.com/users/wolfreak99/following{/other_user}","gists_url":"https://api.github.com/users/wolfreak99/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfreak99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfreak99/subscriptions","organizations_url":"https://api.github.com/users/wolfreak99/orgs","repos_url":"https://api.github.com/users/wolfreak99/repos","events_url":"https://api.github.com/users/wolfreak99/events{/privacy}","received_events_url":"https://api.github.com/users/wolfreak99/received_events","type":"User","site_admin":false},"body":"EDIT: I have fixed the underlying issues below. What this does is allows a limit to be set on the number of windows that are open at a time. This will help problems related to windows with viewpoint frames, overflowing of staff members when hiring, and aid for people who have small screens and have no reason for alot of windows.\r\n\r\n\r\n--Original post below--\r\nI am currently having issues figuring out how to go about tracking if the amount of windows currently open are overflowing the newly set limit, and I don't think making a seperate int value that stores the amount of windows open would be very optimal. A goal is to keep this pull request as minimal and simple as possible, and not to modify too much of the core engine (as i am trying to ease myself into this idea of group development), so I was wondering if i could get some help with finding out how to tackle the \"if there is 14 windows open and the limit is set to 10, close 4 windows (without closing the options window)\" situation.\r\n\r\nSomewhere along the lines of trial-and-error with attempting to fix the issue above, i noticed there would be a glitch that would cause the viewports to glitch out or be a nullptr, followed by get_window_main() becoming a nullptr. I am fairly certain it is to do with the above issue, but I am not certain if i fixed it yet, but I would prefer if this was to be tested a few times by others after i possibly get some guidance on how to properly execute what i'm attempting to do. \r\n","created_at":"2016-06-03T02:25:29Z","updated_at":"2016-07-15T11:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3a4a3c8681e04a8391446fdc9775864bfdc6e60","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805/commits","review_comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805/comments","review_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/3805/comments","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/44202d0bd155386ab85ed6d809fa91769e0725e0","head":{"label":"wolfreak99:window_limit","ref":"window_limit","sha":"44202d0bd155386ab85ed6d809fa91769e0725e0","user":{"login":"wolfreak99","id":7704811,"avatar_url":"https://avatars.githubusercontent.com/u/7704811?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfreak99","html_url":"https://github.com/wolfreak99","followers_url":"https://api.github.com/users/wolfreak99/followers","following_url":"https://api.github.com/users/wolfreak99/following{/other_user}","gists_url":"https://api.github.com/users/wolfreak99/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfreak99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfreak99/subscriptions","organizations_url":"https://api.github.com/users/wolfreak99/orgs","repos_url":"https://api.github.com/users/wolfreak99/repos","events_url":"https://api.github.com/users/wolfreak99/events{/privacy}","received_events_url":"https://api.github.com/users/wolfreak99/received_events","type":"User","site_admin":false},"repo":{"id":59972792,"name":"OpenRCT2","full_name":"wolfreak99/OpenRCT2","owner":{"login":"wolfreak99","id":7704811,"avatar_url":"https://avatars.githubusercontent.com/u/7704811?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfreak99","html_url":"https://github.com/wolfreak99","followers_url":"https://api.github.com/users/wolfreak99/followers","following_url":"https://api.github.com/users/wolfreak99/following{/other_user}","gists_url":"https://api.github.com/users/wolfreak99/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfreak99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfreak99/subscriptions","organizations_url":"https://api.github.com/users/wolfreak99/orgs","repos_url":"https://api.github.com/users/wolfreak99/repos","events_url":"https://api.github.com/users/wolfreak99/events{/privacy}","received_events_url":"https://api.github.com/users/wolfreak99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolfreak99/OpenRCT2","description":"An open source re-implementation of Roller Coaster Tycoon 2.","fork":true,"url":"https://api.github.com/repos/wolfreak99/OpenRCT2","forks_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/forks","keys_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/events","assignees_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/merges","archive_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/wolfreak99/OpenRCT2/deployments","created_at":"2016-05-30T01:46:47Z","updated_at":"2016-05-30T01:46:49Z","pushed_at":"2016-07-15T11:08:09Z","git_url":"git://github.com/wolfreak99/OpenRCT2.git","ssh_url":"git@github.com:wolfreak99/OpenRCT2.git","clone_url":"https://github.com/wolfreak99/OpenRCT2.git","svn_url":"https://github.com/wolfreak99/OpenRCT2","homepage":"http://openrct2.website","size":38335,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenRCT2:develop","ref":"develop","sha":"6428e3e42d8bf26e6bde8f4ea94fb4ea1d31abd4","user":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"repo":{"id":18348651,"name":"OpenRCT2","full_name":"OpenRCT2/OpenRCT2","owner":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRCT2/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2.","fork":false,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","forks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/forks","keys_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/events","assignees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/merges","archive_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/deployments","created_at":"2014-04-01T23:32:25Z","updated_at":"2016-07-15T06:50:58Z","pushed_at":"2016-07-15T11:08:10Z","git_url":"git://github.com/OpenRCT2/OpenRCT2.git","ssh_url":"git@github.com:OpenRCT2/OpenRCT2.git","clone_url":"https://github.com/OpenRCT2/OpenRCT2.git","svn_url":"https://github.com/OpenRCT2/OpenRCT2","homepage":"http://openrct2.website","size":66250,"stargazers_count":1945,"watchers_count":1945,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"open_issues_count":596,"forks":362,"open_issues":596,"watchers":1945,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/3805"},"issue":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/3805"},"comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/3805/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/3805/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/44202d0bd155386ab85ed6d809fa91769e0725e0"}}}}
{"actor":{"display_login":"Gymnasiast"}}