{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/90303237","pull_request_review_id":10824535,"id":90303237,"diff_hunk":"@@ -0,0 +1,32 @@\n+# Reviewing and Merging Pull Requests\n+\n+This document is a guideline for how core contributors should review and merge\n+pull requests (PRs). It is intended to outline the lightweight process that\n+we’ll use for now. It’s assumed that we’ll operate on good faith for now in\n+situations for which process is not specified.\n+\n+PRs may only be merged after the following criteria are met:\n+\n+1. It has been open for at least 1 business day\n+1. It has no `veto` label on it\n+1. It has been 'LGTM'-ed by 3 different reviewers, each from a different","path":"REVIEWING.md","position":12,"original_position":12,"commit_id":"4debd748078d4f0daf26c067e012f188f1508d70","original_commit_id":"4debd748078d4f0daf26c067e012f188f1508d70","user":{"login":"bmelville","id":11277554,"avatar_url":"https://avatars.githubusercontent.com/u/11277554?v=3","gravatar_id":"","url":"https://api.github.com/users/bmelville","html_url":"https://github.com/bmelville","followers_url":"https://api.github.com/users/bmelville/followers","following_url":"https://api.github.com/users/bmelville/following{/other_user}","gists_url":"https://api.github.com/users/bmelville/gists{/gist_id}","starred_url":"https://api.github.com/users/bmelville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmelville/subscriptions","organizations_url":"https://api.github.com/users/bmelville/orgs","repos_url":"https://api.github.com/users/bmelville/repos","events_url":"https://api.github.com/users/bmelville/events{/privacy}","received_events_url":"https://api.github.com/users/bmelville/received_events","type":"User","site_admin":false},"body":"I know that we had a bunch of discussion around 3, but I thought that we backed out of that and all decided that 1 non-org LGTM was sufficient for now.","created_at":"2016-11-30T19:03:46Z","updated_at":"2016-11-30T19:03:46Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/61#discussion_r90303237","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/90303237"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/61#discussion_r90303237"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61","id":95789106,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/61","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/61.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/61.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/61","number":61,"state":"open","locked":false,"title":"Adding reviewing process document","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"This document is intended to outline the lightweight process that we’ll use for now. It’s assumed that we’ll operate on good faith for now in situations for which process is not specified.\r\n\r\nAlso note that this document mentions a `veto` label. It's created [here](https://github.com/kubernetes-incubator/service-catalog/labels/veto)\r\n\r\nMakes progress against https://github.com/kubernetes-incubator/service-catalog/issues/50","created_at":"2016-11-29T22:26:50Z","updated_at":"2016-11-30T19:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54a391d7626860ab0869b41f0973b39be7cceca4","assignee":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"assignees":[{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/61/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/4debd748078d4f0daf26c067e012f188f1508d70","head":{"label":"arschles:veto-label","ref":"veto-label","sha":"4debd748078d4f0daf26c067e012f188f1508d70","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"repo":{"id":70734213,"name":"kubernetes-incubator-service-catalog","full_name":"arschles/kubernetes-incubator-service-catalog","owner":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog","forks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/forks","keys_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/teams","hooks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/hooks","issue_events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/events","assignees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/tags","blobs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/languages","stargazers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/stargazers","contributors_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contributors","subscribers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscribers","subscription_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscription","commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/merges","archive_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/downloads","issues_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/deployments","created_at":"2016-10-12T19:28:49Z","updated_at":"2016-10-12T19:29:01Z","pushed_at":"2016-11-30T18:23:57Z","git_url":"git://github.com/arschles/kubernetes-incubator-service-catalog.git","ssh_url":"git@github.com:arschles/kubernetes-incubator-service-catalog.git","clone_url":"https://github.com/arschles/kubernetes-incubator-service-catalog.git","svn_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","homepage":"","size":39418,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"de332eaed247f072901164532c5c06a13f27cfde","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2016-11-30T16:00:37Z","pushed_at":"2016-11-30T18:59:07Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":39514,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":33,"forks":18,"open_issues":33,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/61"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/61"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/4debd748078d4f0daf26c067e012f188f1508d70"}}}}
{"actor":{"display_login":"bmelville"}}