{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/78647883","id":78647883,"diff_hunk":"@@ -195,7 +195,14 @@ void LIR::Use::ReplaceWith(Compiler* compiler, GenTree* replacement)\n     *m_edge = replacement;\n     if (!IsDummyUse() && m_user->IsCall())\n     {\n-        compiler->fgFixupArgTabEntryPtr(m_user, replacedNode, replacement);\n+        GenTreeCall* call = m_user->AsCall();\n+        const bool isCallArg = (replacement != call->gtControlExpr) && ((call->gtCallType != CT_INDIRECT) ||","path":"src/jit/lir.cpp","position":6,"original_position":6,"commit_id":"7cad0ca26ff7ad08285d5175a86f381e04ac74d8","original_commit_id":"7cad0ca26ff7ad08285d5175a86f381e04ac74d8","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"body":"I don't think it would be a good idea to use `gtGetArgEntryByNode` - it is unnecessarily expensive.\r\nInstead, one might add something like an `IsNonArgOperand()` to `GenTreeCall` that would check for these special cases - that way the checking would be with the declaration of the fields of that node.\r\n\r\n---\r\nIn reply to: [78644811](https://github.com/dotnet/coreclr/pull/7170#discussion_r78644811) [](ancestors = 78644811)","created_at":"2016-09-13T21:28:09Z","updated_at":"2016-09-13T21:28:09Z","html_url":"https://github.com/dotnet/coreclr/pull/7170#discussion_r78647883","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7170","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/78647883"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7170#discussion_r78647883"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7170"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7170","id":85122005,"html_url":"https://github.com/dotnet/coreclr/pull/7170","diff_url":"https://github.com/dotnet/coreclr/pull/7170.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7170.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7170","number":7170,"state":"open","locked":false,"title":"Fix a bug in `LIR::Use::ReplaceWith`.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"This method was calling `fgFixupArgTabEntryPtr` when any operand to a\r\n`GT_CALL` node was replaced. This call is only necessary when a call\r\nargument is replaced; it has been made appropriately conditional.\r\n\r\nFixes #7144.","created_at":"2016-09-13T20:46:02Z","updated_at":"2016-09-13T21:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e1bb1d7fd9eabd99b86f43dbb1b8c80eab8f562","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7170/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7170/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7170/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/7cad0ca26ff7ad08285d5175a86f381e04ac74d8","head":{"label":"pgavlin:gh7144","ref":"gh7144","sha":"7cad0ca26ff7ad08285d5175a86f381e04ac74d8","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":30321049,"name":"coreclr","full_name":"pgavlin/coreclr","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/pgavlin/coreclr","forks_url":"https://api.github.com/repos/pgavlin/coreclr/forks","keys_url":"https://api.github.com/repos/pgavlin/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/coreclr/teams","hooks_url":"https://api.github.com/repos/pgavlin/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/coreclr/events","assignees_url":"https://api.github.com/repos/pgavlin/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/coreclr/tags","blobs_url":"https://api.github.com/repos/pgavlin/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/coreclr/languages","stargazers_url":"https://api.github.com/repos/pgavlin/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/coreclr/subscription","commits_url":"https://api.github.com/repos/pgavlin/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/coreclr/merges","archive_url":"https://api.github.com/repos/pgavlin/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/coreclr/downloads","issues_url":"https://api.github.com/repos/pgavlin/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pgavlin/coreclr/deployments","created_at":"2015-02-04T21:04:39Z","updated_at":"2016-02-26T17:14:54Z","pushed_at":"2016-09-13T20:45:30Z","git_url":"git://github.com/pgavlin/coreclr.git","ssh_url":"git@github.com:pgavlin/coreclr.git","clone_url":"https://github.com/pgavlin/coreclr.git","svn_url":"https://github.com/pgavlin/coreclr","homepage":"","size":107230,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2ba19ec8b4c14c1e12bf1e3b8d8077029358a494","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-09-13T17:06:23Z","pushed_at":"2016-09-13T21:27:43Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":119698,"stargazers_count":6899,"watchers_count":6899,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1645,"mirror_url":null,"open_issues_count":957,"forks":1645,"open_issues":957,"watchers":6899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7170"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7170"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7170"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7170/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7170/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7170/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/7cad0ca26ff7ad08285d5175a86f381e04ac74d8"}}}}
{"actor":{"display_login":"CarolEidt"}}