{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1968","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1968/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1968/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1968/events","html_url":"https://github.com/ReactiveX/rxjs/pull/1968","id":178704910,"number":1968,"title":"chore(package.json): update typescript to v2.0","user":{"login":"saneyuki","id":180104,"avatar_url":"https://avatars.githubusercontent.com/u/180104?v=3","gravatar_id":"","url":"https://api.github.com/users/saneyuki","html_url":"https://github.com/saneyuki","followers_url":"https://api.github.com/users/saneyuki/followers","following_url":"https://api.github.com/users/saneyuki/following{/other_user}","gists_url":"https://api.github.com/users/saneyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/saneyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneyuki/subscriptions","organizations_url":"https://api.github.com/users/saneyuki/orgs","repos_url":"https://api.github.com/users/saneyuki/repos","events_url":"https://api.github.com/users/saneyuki/events{/privacy}","received_events_url":"https://api.github.com/users/saneyuki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-22T19:54:23Z","updated_at":"2016-09-22T20:00:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1968","html_url":"https://github.com/ReactiveX/rxjs/pull/1968","diff_url":"https://github.com/ReactiveX/rxjs/pull/1968.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/1968.patch"},"body":"BREAKING CHANGE: This changes type definitions which are compiled out.\r\n\r\nThis does not changes exist APIs, but if we use getter for class, they are marked with `readonly` properties in d.ts (`readonly` modifier is the new feature from TypeScript v2.0). For example:\r\n\r\n```typescript\r\nexport class BehaviorSubject<T> extends Subject<T> {\r\n\r\n  constructor(private _value: T) {\r\n    super();\r\n  }\r\n\r\n  get value(): T {\r\n    return this.getValue();\r\n  }\r\n\r\n  protected _subscribe(subscriber: Subscriber<T>): Subscription {\r\n    const subscription = super._subscribe(subscriber);\r\n    if (subscription && !(<ISubscription>subscription).closed) {\r\n      subscriber.next(this._value);\r\n    }\r\n    return subscription;\r\n  }\r\n\r\n  getValue(): T {\r\n    if (this.hasError) {\r\n      throw this.thrownError;\r\n    } else if (this.closed) {\r\n      throw new ObjectUnsubscribedError();\r\n    } else {\r\n      return this._value;\r\n    }\r\n  }\r\n\r\n  next(value: T): void {\r\n    super.next(this._value = value);\r\n  }\r\n}\r\n\r\n```\r\n\r\nwill be compiled to in d.ts\r\n\r\n```typescript\r\nexport declare class BehaviorSubject<T> extends Subject<T> {\r\n    private _value;\r\n    constructor(_value: T);\r\n    readonly value: T;\r\n    protected _subscribe(subscriber: Subscriber<T>): Subscription;\r\n    getValue(): T;\r\n    next(value: T): void;\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/249011692","html_url":"https://github.com/ReactiveX/rxjs/pull/1968#issuecomment-249011692","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1968","id":249011692,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T20:00:29Z","updated_at":"2016-09-22T20:00:29Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8011944/badge)](https://coveralls.io/builds/8011944)\n\nCoverage remained the same at 97.001% when pulling **4c5782b84566e107774f085d3cfbdd129bdb4ef5 on saneyuki:tsc** into **48a8689d8c750cf84b00586f963b6830b2589070 on ReactiveX:master**.\n"}}
{"actor":{"display_login":"coveralls"}}