{"action":"created","comment":{"url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/comments/78874689","id":78874689,"diff_hunk":"@@ -25,9 +24,9 @@ if (!fs.existsSync(workDir)) {\n     fs.mkdirSync(workDir);\n }\n \n-gulp.task('build', ['render-datasource-templates', 'list-ga-services']);\n-gulp.task('release', ['render-datasource-templates',/*'make-editor-schema', 'validate'*/]);\n-gulp.task('watch', ['watch-datasource-templates']);\n+gulp.task('build', ['update-lga-filter', 'render-datasource-templates', 'list-ga-services']);","path":"gulpfile.js","position":15,"original_position":15,"commit_id":"5f2b35f5c09734eea2eea92718ec755760c874db","original_commit_id":"5f2b35f5c09734eea2eea92718ec755760c874db","user":{"login":"kring","id":924374,"avatar_url":"https://avatars.githubusercontent.com/u/924374?v=3","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"body":"I don't think this will work.  `gulp` (in its infinite wisdom) executes all the tasks in the array in parallel.  So `render-datasource-templates` will happen before `update-lga-filter` finishes.","created_at":"2016-09-15T01:20:32Z","updated_at":"2016-09-15T01:20:32Z","html_url":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28#discussion_r78874689","pull_request_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/comments/78874689"},"html":{"href":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28#discussion_r78874689"},"pull_request":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28","id":84595792,"html_url":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28","diff_url":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28.diff","patch_url":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28.patch","issue_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/28","number":28,"state":"open","locked":false,"title":"Fix LGA updating infinite loop.","user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-09T05:29:54Z","updated_at":"2016-09-15T01:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2ad9617dfd1e5db949491e9236540b6b5d65041","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/28/comments","statuses_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/statuses/5f2b35f5c09734eea2eea92718ec755760c874db","head":{"label":"TerriaJS:lga-loop","ref":"lga-loop","sha":"5f2b35f5c09734eea2eea92718ec755760c874db","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":54089291,"name":"NationalMap-Catalog","full_name":"TerriaJS/NationalMap-Catalog","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/NationalMap-Catalog","description":"The catalog (init files) for National Map","fork":false,"url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog","forks_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/forks","keys_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/teams","hooks_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/events","assignees_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/tags","blobs_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/subscription","commits_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/merges","archive_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/downloads","issues_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/deployments","created_at":"2016-03-17T04:47:27Z","updated_at":"2016-07-08T06:53:55Z","pushed_at":"2016-09-09T05:29:54Z","git_url":"git://github.com/TerriaJS/NationalMap-Catalog.git","ssh_url":"git@github.com:TerriaJS/NationalMap-Catalog.git","clone_url":"https://github.com/TerriaJS/NationalMap-Catalog.git","svn_url":"https://github.com/TerriaJS/NationalMap-Catalog","homepage":null,"size":252,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"146d07b362b11c3c2f600be8fe335b196a7a5892","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":54089291,"name":"NationalMap-Catalog","full_name":"TerriaJS/NationalMap-Catalog","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/NationalMap-Catalog","description":"The catalog (init files) for National Map","fork":false,"url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog","forks_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/forks","keys_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/teams","hooks_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/events","assignees_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/tags","blobs_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/subscription","commits_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/merges","archive_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/downloads","issues_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/deployments","created_at":"2016-03-17T04:47:27Z","updated_at":"2016-07-08T06:53:55Z","pushed_at":"2016-09-09T05:29:54Z","git_url":"git://github.com/TerriaJS/NationalMap-Catalog.git","ssh_url":"git@github.com:TerriaJS/NationalMap-Catalog.git","clone_url":"https://github.com/TerriaJS/NationalMap-Catalog.git","svn_url":"https://github.com/TerriaJS/NationalMap-Catalog","homepage":null,"size":252,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28"},"html":{"href":"https://github.com/TerriaJS/NationalMap-Catalog/pull/28"},"issue":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/28"},"comments":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/NationalMap-Catalog/statuses/5f2b35f5c09734eea2eea92718ec755760c874db"}}}}
{"actor":{"display_login":"kring"}}