{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/comments/81544217","pull_request_review_id":2513523,"id":81544217,"diff_hunk":"@@ -254,21 +259,27 @@ public void createServerWithX509Cert(Certificate[] trustedCertificates) {\n         builder.setLocalAddress(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0));\n         builder.setLocalSecureAddress(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0));\n \n-        builder.setSecurityRegistry(new SecurityRegistryImpl(serverPrivateKeyFromCert, serverX509CertChain,\n-                trustedCertificates) {\n-            // TODO we should separate SecurityRegistryImpl in 2 registries :\n-            // InMemorySecurityRegistry and PersistentSecurityRegistry\n-            @Override\n-            protected void loadFromFile() {\n-                // do not load From File\n-            }\n-\n-            @Override\n-            protected void saveToFile() {\n-                // do not save to file\n-            }\n-        });\n+        builder.setSecurityRegistry(\n+                new SecurityRegistryImpl(serverPrivateKeyFromCert, serverX509CertChain, trustedCertificates) {\n+                    // TODO we should separate SecurityRegistryImpl in 2 registries :\n+                    // InMemorySecurityRegistry and PersistentSecurityRegistry\n+                    @Override\n+                    protected void loadFromFile() {\n+                        // do not load From File\n+                    }\n+\n+                    @Override\n+                    protected void saveToFile() {\n+                        // do not save to file\n+                    }\n+                });\n \n         server = builder.build();\n     }\n+\n+    @Override\n+    public void dispose() {","path":"leshan-integration-tests/src/test/java/org/eclipse/leshan/integration/tests/SecureIntegrationTestHelper.java","position":164,"original_position":164,"commit_id":"be419b89866ff819e1b4da3239d3bc28204d89dc","original_commit_id":"8019a5317cea26550a72abc81f7ae25f24a7ac53","user":{"login":"msangoi","id":3940991,"avatar_url":"https://avatars.githubusercontent.com/u/3940991?v=3","gravatar_id":"","url":"https://api.github.com/users/msangoi","html_url":"https://github.com/msangoi","followers_url":"https://api.github.com/users/msangoi/followers","following_url":"https://api.github.com/users/msangoi/following{/other_user}","gists_url":"https://api.github.com/users/msangoi/gists{/gist_id}","starred_url":"https://api.github.com/users/msangoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msangoi/subscriptions","organizations_url":"https://api.github.com/users/msangoi/orgs","repos_url":"https://api.github.com/users/msangoi/repos","events_url":"https://api.github.com/users/msangoi/events{/privacy}","received_events_url":"https://api.github.com/users/msangoi/received_events","type":"User","site_admin":false},"body":"super.dispose() to clear the endpoint identifier?","created_at":"2016-10-03T12:56:40Z","updated_at":"2016-10-03T13:04:13Z","html_url":"https://github.com/eclipse/leshan/pull/180#discussion_r81544217","pull_request_url":"https://api.github.com/repos/eclipse/leshan/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments/81544217"},"html":{"href":"https://github.com/eclipse/leshan/pull/180#discussion_r81544217"},"pull_request":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/180","id":86938494,"html_url":"https://github.com/eclipse/leshan/pull/180","diff_url":"https://github.com/eclipse/leshan/pull/180.diff","patch_url":"https://github.com/eclipse/leshan/pull/180.patch","issue_url":"https://api.github.com/repos/eclipse/leshan/issues/180","number":180,"state":"open","locked":false,"title":"Add profile to run integrations tests with Redis store simplementation","user":{"login":"sbernard31","id":840294,"avatar_url":"https://avatars.githubusercontent.com/u/840294?v=3","gravatar_id":"","url":"https://api.github.com/users/sbernard31","html_url":"https://github.com/sbernard31","followers_url":"https://api.github.com/users/sbernard31/followers","following_url":"https://api.github.com/users/sbernard31/following{/other_user}","gists_url":"https://api.github.com/users/sbernard31/gists{/gist_id}","starred_url":"https://api.github.com/users/sbernard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbernard31/subscriptions","organizations_url":"https://api.github.com/users/sbernard31/orgs","repos_url":"https://api.github.com/users/sbernard31/repos","events_url":"https://api.github.com/users/sbernard31/events{/privacy}","received_events_url":"https://api.github.com/users/sbernard31/received_events","type":"User","site_admin":false},"body":"To run the the integration-tests with redis implementation :\r\n\r\n```\r\nmvn clean install -Predis\r\n```","created_at":"2016-09-27T14:14:08Z","updated_at":"2016-10-03T13:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0411770c33ea8e4fdb9a2a8d7973affc0c3c4301","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/leshan/pulls/180/commits","review_comments_url":"https://api.github.com/repos/eclipse/leshan/pulls/180/comments","review_comment_url":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/leshan/issues/180/comments","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/be419b89866ff819e1b4da3239d3bc28204d89dc","head":{"label":"eclipse:redis_tests","ref":"redis_tests","sha":"be419b89866ff819e1b4da3239d3bc28204d89dc","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":30419413,"name":"leshan","full_name":"eclipse/leshan","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":false,"url":"https://api.github.com/repos/eclipse/leshan","forks_url":"https://api.github.com/repos/eclipse/leshan/forks","keys_url":"https://api.github.com/repos/eclipse/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/leshan/teams","hooks_url":"https://api.github.com/repos/eclipse/leshan/hooks","issue_events_url":"https://api.github.com/repos/eclipse/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/leshan/events","assignees_url":"https://api.github.com/repos/eclipse/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/leshan/tags","blobs_url":"https://api.github.com/repos/eclipse/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/leshan/languages","stargazers_url":"https://api.github.com/repos/eclipse/leshan/stargazers","contributors_url":"https://api.github.com/repos/eclipse/leshan/contributors","subscribers_url":"https://api.github.com/repos/eclipse/leshan/subscribers","subscription_url":"https://api.github.com/repos/eclipse/leshan/subscription","commits_url":"https://api.github.com/repos/eclipse/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/leshan/merges","archive_url":"https://api.github.com/repos/eclipse/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/leshan/downloads","issues_url":"https://api.github.com/repos/eclipse/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/leshan/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/leshan/deployments","created_at":"2015-02-06T15:44:24Z","updated_at":"2016-09-28T13:36:05Z","pushed_at":"2016-09-29T12:12:51Z","git_url":"git://github.com/eclipse/leshan.git","ssh_url":"git@github.com:eclipse/leshan.git","clone_url":"https://github.com/eclipse/leshan.git","svn_url":"https://github.com/eclipse/leshan","homepage":"","size":3538,"stargazers_count":104,"watchers_count":104,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":15,"forks":91,"open_issues":15,"watchers":104,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"cd0018f028b9c69f31db4237288af89107d262ec","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":30419413,"name":"leshan","full_name":"eclipse/leshan","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":false,"url":"https://api.github.com/repos/eclipse/leshan","forks_url":"https://api.github.com/repos/eclipse/leshan/forks","keys_url":"https://api.github.com/repos/eclipse/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/leshan/teams","hooks_url":"https://api.github.com/repos/eclipse/leshan/hooks","issue_events_url":"https://api.github.com/repos/eclipse/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/leshan/events","assignees_url":"https://api.github.com/repos/eclipse/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/leshan/tags","blobs_url":"https://api.github.com/repos/eclipse/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/leshan/languages","stargazers_url":"https://api.github.com/repos/eclipse/leshan/stargazers","contributors_url":"https://api.github.com/repos/eclipse/leshan/contributors","subscribers_url":"https://api.github.com/repos/eclipse/leshan/subscribers","subscription_url":"https://api.github.com/repos/eclipse/leshan/subscription","commits_url":"https://api.github.com/repos/eclipse/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/leshan/merges","archive_url":"https://api.github.com/repos/eclipse/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/leshan/downloads","issues_url":"https://api.github.com/repos/eclipse/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/leshan/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/leshan/deployments","created_at":"2015-02-06T15:44:24Z","updated_at":"2016-09-28T13:36:05Z","pushed_at":"2016-09-29T12:12:51Z","git_url":"git://github.com/eclipse/leshan.git","ssh_url":"git@github.com:eclipse/leshan.git","clone_url":"https://github.com/eclipse/leshan.git","svn_url":"https://github.com/eclipse/leshan","homepage":"","size":3538,"stargazers_count":104,"watchers_count":104,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":15,"forks":91,"open_issues":15,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/180"},"html":{"href":"https://github.com/eclipse/leshan/pull/180"},"issue":{"href":"https://api.github.com/repos/eclipse/leshan/issues/180"},"comments":{"href":"https://api.github.com/repos/eclipse/leshan/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/leshan/statuses/be419b89866ff819e1b4da3239d3bc28204d89dc"}}}}
{"actor":{"display_login":"msangoi"}}