{"action":"created","issue":{"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/561","repository_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation","labels_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/561/comments","events_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/561/events","html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/issues/561","id":139633916,"number":561,"title":"Biome code refactoring","user":{"login":"topisani","id":3133596,"avatar_url":"https://avatars.githubusercontent.com/u/3133596?v=3","gravatar_id":"","url":"https://api.github.com/users/topisani","html_url":"https://github.com/topisani","followers_url":"https://api.github.com/users/topisani/followers","following_url":"https://api.github.com/users/topisani/following{/other_user}","gists_url":"https://api.github.com/users/topisani/gists{/gist_id}","starred_url":"https://api.github.com/users/topisani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topisani/subscriptions","organizations_url":"https://api.github.com/users/topisani/orgs","repos_url":"https://api.github.com/users/topisani/repos","events_url":"https://api.github.com/users/topisani/events{/privacy}","received_events_url":"https://api.github.com/users/topisani/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/labels/in%20progress","name":"in progress","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/milestones/1","html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/milestones/0.8.0","labels_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/milestones/1/labels","id":1654980,"number":1,"title":"0.8.0","description":"","creator":{"login":"whichonespink44","id":10927161,"avatar_url":"https://avatars.githubusercontent.com/u/10927161?v=3","gravatar_id":"","url":"https://api.github.com/users/whichonespink44","html_url":"https://github.com/whichonespink44","followers_url":"https://api.github.com/users/whichonespink44/followers","following_url":"https://api.github.com/users/whichonespink44/following{/other_user}","gists_url":"https://api.github.com/users/whichonespink44/gists{/gist_id}","starred_url":"https://api.github.com/users/whichonespink44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whichonespink44/subscriptions","organizations_url":"https://api.github.com/users/whichonespink44/orgs","repos_url":"https://api.github.com/users/whichonespink44/repos","events_url":"https://api.github.com/users/whichonespink44/events{/privacy}","received_events_url":"https://api.github.com/users/whichonespink44/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-03-19T15:22:56Z","updated_at":"2016-03-20T08:05:37Z","due_on":"2016-04-02T23:00:00Z","closed_at":null},"comments":23,"created_at":"2016-03-09T16:46:54Z","updated_at":"2016-03-22T21:55:46Z","closed_at":null,"body":"Just thought we should create an issue for this, and keep the discussion centralised. \n\nThe point is I think we should consider rethinking the biome code. Specifically moving a lot of code out of the individual biome classes, a lot like the new terrain wrapping. If it was possible to get a list of decorations for a biome, it would also make quite a few features possible, both for us and 1st or 3rd party addons. \n\nThe main issue with this is we could be removing some level of customisability for the individual biomes by making things more preset based.\nHowever I think, with a few variables this is easily resolved.\nCurrently both savanna plateaus and all mesa plateau variations use the exact same terrain code with only a few variables changed. And mesa Bryce looks nothing like savanna plateau M."},"comment":{"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/comments/200048757","html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/issues/561#issuecomment-200048757","issue_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/561","id":200048757,"user":{"login":"Zeno410","id":5322776,"avatar_url":"https://avatars.githubusercontent.com/u/5322776?v=3","gravatar_id":"","url":"https://api.github.com/users/Zeno410","html_url":"https://github.com/Zeno410","followers_url":"https://api.github.com/users/Zeno410/followers","following_url":"https://api.github.com/users/Zeno410/following{/other_user}","gists_url":"https://api.github.com/users/Zeno410/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeno410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeno410/subscriptions","organizations_url":"https://api.github.com/users/Zeno410/orgs","repos_url":"https://api.github.com/users/Zeno410/repos","events_url":"https://api.github.com/users/Zeno410/events{/privacy}","received_events_url":"https://api.github.com/users/Zeno410/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T21:55:46Z","updated_at":"2016-03-22T21:55:46Z","body":"I'm getting a sense of deja vu here -\r\n\r\n> I suggested something like this a while back for terrains and Pink, who's the big proponent of individual classes, came up with the mass wrapping as a compromise.\r\n\r\nAnyway, there are currently *three* systems - calls to the wrapped routines (the vast majority), custom code in the class (mostly Highlands routines) and functional object juggling (a couple of classes in BoP, but there will be more to come, because it's proving a powerful approach). I find when I really care about a biome I rarely use the wrapped routines, although there are a lot of plains/rolling hills where I really *don't* care. "}}