{"action":"created","comment":{"url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/comments/54232187","id":54232187,"diff_hunk":"@@ -25,12 +25,56 @@ define([\n    * @name AbstractTreeFilter\n    * @memberOf pentaho.data.filter\n    * @class\n+   * @extends pentaho.data.filter.AbstractFilter\n    * @abstract\n    * @amd pentaho/data/filter/AbstractTreeFilter\n    *\n    * @classdesc The `AbstractTreeFilter` class is the abstract base class of\n    * classes that represent a filter.\n    *\n+   * @example\n+   * <caption> Create a new class <code>DerivedAbstractTreeFilter</code> what to put here???</caption>","path":"package-res/resources/web/pentaho/data/filter/AbstractTreeFilter.js","position":12,"original_position":12,"commit_id":"2e9387c0fcfe3b9f22eb5ed794381379980e9f75","original_commit_id":"2e9387c0fcfe3b9f22eb5ed794381379980e9f75","user":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"body":"A developer that needs to derive a class from `AbstractTreeFilter` would probably prefer to look at the code.\r\nIf we are to provide examples, they should be on how the filters are used.\r\n\r\nIf it is indeed useful to provide an example on deriving a class from `AbstractTreeFilter, why not use a concrete example such as an XOR, NAND?\r\n\r\nThis comment applies to most example blocks.","created_at":"2016-02-26T11:24:28Z","updated_at":"2016-02-26T11:24:28Z","html_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8#discussion_r54232187","pull_request_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/comments/54232187"},"html":{"href":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8#discussion_r54232187"},"pull_request":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8","id":60749703,"html_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8","diff_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8.diff","patch_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8.patch","issue_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/8","number":8,"state":"open","locked":false,"title":"[BACKLOG-6419] cleanup and create doc for selection filters","user":{"login":"scottyaslan","id":6797571,"avatar_url":"https://avatars.githubusercontent.com/u/6797571?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyaslan","html_url":"https://github.com/scottyaslan","followers_url":"https://api.github.com/users/scottyaslan/followers","following_url":"https://api.github.com/users/scottyaslan/following{/other_user}","gists_url":"https://api.github.com/users/scottyaslan/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyaslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyaslan/subscriptions","organizations_url":"https://api.github.com/users/scottyaslan/orgs","repos_url":"https://api.github.com/users/scottyaslan/repos","events_url":"https://api.github.com/users/scottyaslan/events{/privacy}","received_events_url":"https://api.github.com/users/scottyaslan/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-25T21:25:39Z","updated_at":"2016-02-26T11:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff86c0063bd1ea7ab06f35a759073921bd34f431","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8/commits","review_comments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8/comments","review_comment_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/8/comments","statuses_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/statuses/2e9387c0fcfe3b9f22eb5ed794381379980e9f75","head":{"label":"scottyaslan:carlosDevBranch","ref":"carlosDevBranch","sha":"2e9387c0fcfe3b9f22eb5ed794381379980e9f75","user":{"login":"scottyaslan","id":6797571,"avatar_url":"https://avatars.githubusercontent.com/u/6797571?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyaslan","html_url":"https://github.com/scottyaslan","followers_url":"https://api.github.com/users/scottyaslan/followers","following_url":"https://api.github.com/users/scottyaslan/following{/other_user}","gists_url":"https://api.github.com/users/scottyaslan/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyaslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyaslan/subscriptions","organizations_url":"https://api.github.com/users/scottyaslan/orgs","repos_url":"https://api.github.com/users/scottyaslan/repos","events_url":"https://api.github.com/users/scottyaslan/events{/privacy}","received_events_url":"https://api.github.com/users/scottyaslan/received_events","type":"User","site_admin":false},"repo":{"id":19469745,"name":"pentaho-platform-plugin-common-ui","full_name":"scottyaslan/pentaho-platform-plugin-common-ui","owner":{"login":"scottyaslan","id":6797571,"avatar_url":"https://avatars.githubusercontent.com/u/6797571?v=3","gravatar_id":"","url":"https://api.github.com/users/scottyaslan","html_url":"https://github.com/scottyaslan","followers_url":"https://api.github.com/users/scottyaslan/followers","following_url":"https://api.github.com/users/scottyaslan/following{/other_user}","gists_url":"https://api.github.com/users/scottyaslan/gists{/gist_id}","starred_url":"https://api.github.com/users/scottyaslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottyaslan/subscriptions","organizations_url":"https://api.github.com/users/scottyaslan/orgs","repos_url":"https://api.github.com/users/scottyaslan/repos","events_url":"https://api.github.com/users/scottyaslan/events{/privacy}","received_events_url":"https://api.github.com/users/scottyaslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottyaslan/pentaho-platform-plugin-common-ui","description":"","fork":true,"url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/scottyaslan/pentaho-platform-plugin-common-ui/deployments","created_at":"2014-05-05T20:16:55Z","updated_at":"2015-07-16T15:50:05Z","pushed_at":"2016-02-25T21:22:27Z","git_url":"git://github.com/scottyaslan/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:scottyaslan/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/scottyaslan/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/scottyaslan/pentaho-platform-plugin-common-ui","homepage":null,"size":14606,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carlosrusso:feature/BACKLOG-6419","ref":"feature/BACKLOG-6419","sha":"d62f9c2070a303465927e193c9fb0c8e90887bae","user":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"repo":{"id":49566600,"name":"pentaho-platform-plugin-common-ui","full_name":"carlosrusso/pentaho-platform-plugin-common-ui","owner":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui","description":"","fork":true,"url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/deployments","created_at":"2016-01-13T10:23:09Z","updated_at":"2016-01-13T10:23:12Z","pushed_at":"2016-02-25T21:25:39Z","git_url":"git://github.com/carlosrusso/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:carlosrusso/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui","homepage":null,"size":14782,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8"},"html":{"href":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui/pull/8"},"issue":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/8"},"comments":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/statuses/2e9387c0fcfe3b9f22eb5ed794381379980e9f75"}}}}