{"action":"created","issue":{"url":"https://api.github.com/repos/MTG/essentia/issues/377","repository_url":"https://api.github.com/repos/MTG/essentia","labels_url":"https://api.github.com/repos/MTG/essentia/issues/377/labels{/name}","comments_url":"https://api.github.com/repos/MTG/essentia/issues/377/comments","events_url":"https://api.github.com/repos/MTG/essentia/issues/377/events","html_url":"https://github.com/MTG/essentia/issues/377","id":134613753,"number":377,"title":"Add a real example test to PitchYin and PitchYinFFT unittests ","user":{"login":"dbogdanov","id":409668,"avatar_url":"https://avatars.githubusercontent.com/u/409668?v=3","gravatar_id":"","url":"https://api.github.com/users/dbogdanov","html_url":"https://github.com/dbogdanov","followers_url":"https://api.github.com/users/dbogdanov/followers","following_url":"https://api.github.com/users/dbogdanov/following{/other_user}","gists_url":"https://api.github.com/users/dbogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/dbogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbogdanov/subscriptions","organizations_url":"https://api.github.com/users/dbogdanov/orgs","repos_url":"https://api.github.com/users/dbogdanov/repos","events_url":"https://api.github.com/users/dbogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/dbogdanov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-18T15:38:03Z","updated_at":"2016-02-18T16:30:51Z","closed_at":null,"body":"Current test only checks if the algorithms' output has changed. A Mozart piece is used, but the reference pitch values are the values PitchYin / PitchYinFFT algorithms have output for it in the past. \r\n\r\nThis test now fails after updates introduced by #376 and should be updated with new \"fake\" reference values.\r\n\r\nAdd a new test with real reference values. Several monophonic recordings of various instruments playing scales from GoodSounds might work.\r\n\r\nIdeally, we need three types of tests: \r\n- regression test on real audio to detect if algorithm output has changed (before vs after)\r\n  - compare pitch estimation with previously registered estimation\r\n- test on synthesized pure tones (#230)\r\n- test on synthesized instruments playing a scale\r\n  - similar to pure tones but with multiple instruments synthesized using [TiMidity](http://timidity.sourceforge.net/)\r\n- test on real instruments playing a scale \r\n  - create reference annotation manually\r\n  - the estimated pitch is allowed to be within some deviation due to the nature of real instruments\r\n\r\nIt will be very helpful for Q/A purposed if these tests can generate reports with plots.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MTG/essentia/issues/comments/185803089","html_url":"https://github.com/MTG/essentia/issues/377#issuecomment-185803089","issue_url":"https://api.github.com/repos/MTG/essentia/issues/377","id":185803089,"user":{"login":"oriolromani","id":8613135,"avatar_url":"https://avatars.githubusercontent.com/u/8613135?v=3","gravatar_id":"","url":"https://api.github.com/users/oriolromani","html_url":"https://github.com/oriolromani","followers_url":"https://api.github.com/users/oriolromani/followers","following_url":"https://api.github.com/users/oriolromani/following{/other_user}","gists_url":"https://api.github.com/users/oriolromani/gists{/gist_id}","starred_url":"https://api.github.com/users/oriolromani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriolromani/subscriptions","organizations_url":"https://api.github.com/users/oriolromani/orgs","repos_url":"https://api.github.com/users/oriolromani/repos","events_url":"https://api.github.com/users/oriolromani/events{/privacy}","received_events_url":"https://api.github.com/users/oriolromani/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T16:30:51Z","updated_at":"2016-02-18T16:30:51Z","body":"We can create reference annotation for bullet 4 in a semi-manual way as it was done to build  [MedleyDB](http://medleydb.weebly.com/)"}}