{"action":"created","comment":{"url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/comments/83187099","pull_request_review_id":4031100,"id":83187099,"diff_hunk":"@@ -0,0 +1,21 @@\n+import Immutable from 'immutable'\n+\n+/**\n+ * The Icons reducer\n+ *\n+ * @param state\n+ * @param action\n+ * @returns {*}\n+ */\n+function icons (state, action) {\n+  state = state || Immutable.fromJS({})","path":"src/reducers/icons.js","position":11,"original_position":11,"commit_id":"c2709655fa4612967e96b33e35ef4f29a82f9907","original_commit_id":"c2709655fa4612967e96b33e35ef4f29a82f9907","user":{"login":"matobet","id":1173428,"avatar_url":"https://avatars.githubusercontent.com/u/1173428?v=3","gravatar_id":"","url":"https://api.github.com/users/matobet","html_url":"https://github.com/matobet","followers_url":"https://api.github.com/users/matobet/followers","following_url":"https://api.github.com/users/matobet/following{/other_user}","gists_url":"https://api.github.com/users/matobet/gists{/gist_id}","starred_url":"https://api.github.com/users/matobet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matobet/subscriptions","organizations_url":"https://api.github.com/users/matobet/orgs","repos_url":"https://api.github.com/users/matobet/repos","events_url":"https://api.github.com/users/matobet/events{/privacy}","received_events_url":"https://api.github.com/users/matobet/received_events","type":"User","site_admin":false},"body":"please prefer `Immutable.Map` to `Immutable.fromJS({})`. Overall I would suggest restructuring this code a bit:\r\n```javascript\r\nimport { Map } From 'immutable'\r\n\r\nfunction icons (state = Map(), action) {\r\n    // ... rest of the code\r\n}\r\n```","created_at":"2016-10-13T10:32:14Z","updated_at":"2016-10-13T10:32:14Z","html_url":"https://github.com/matobet/ovirt-ui-components/pull/3#discussion_r83187099","pull_request_url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/comments/83187099"},"html":{"href":"https://github.com/matobet/ovirt-ui-components/pull/3#discussion_r83187099"},"pull_request":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3","id":89162491,"html_url":"https://github.com/matobet/ovirt-ui-components/pull/3","diff_url":"https://github.com/matobet/ovirt-ui-components/pull/3.diff","patch_url":"https://github.com/matobet/ovirt-ui-components/pull/3.patch","issue_url":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/3","number":3,"state":"open","locked":false,"title":"Optimization","user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars.githubusercontent.com/u/17194943?v=3","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"body":"- Shared vm icons are loaded just once\r\n- the vms reducer supports bulk updates (less actions)","created_at":"2016-10-13T09:08:19Z","updated_at":"2016-10-13T10:39:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546938d131f59fcc7a3d575231025fb6199543ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3/commits","review_comments_url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3/comments","review_comment_url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/3/comments","statuses_url":"https://api.github.com/repos/matobet/ovirt-ui-components/statuses/c2709655fa4612967e96b33e35ef4f29a82f9907","head":{"label":"mareklibra:optimization","ref":"optimization","sha":"c2709655fa4612967e96b33e35ef4f29a82f9907","user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars.githubusercontent.com/u/17194943?v=3","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"repo":{"id":70064225,"name":"ovirt-ui-components","full_name":"mareklibra/ovirt-ui-components","owner":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars.githubusercontent.com/u/17194943?v=3","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mareklibra/ovirt-ui-components","description":"Reusable components for Open Virtualization UIs","fork":true,"url":"https://api.github.com/repos/mareklibra/ovirt-ui-components","forks_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/forks","keys_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/teams","hooks_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/hooks","issue_events_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/events","assignees_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/tags","blobs_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/languages","stargazers_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/stargazers","contributors_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/contributors","subscribers_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/subscribers","subscription_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/subscription","commits_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/merges","archive_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/downloads","issues_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/labels{/name}","releases_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/mareklibra/ovirt-ui-components/deployments","created_at":"2016-10-05T13:41:51Z","updated_at":"2016-10-05T13:41:52Z","pushed_at":"2016-10-13T10:07:57Z","git_url":"git://github.com/mareklibra/ovirt-ui-components.git","ssh_url":"git@github.com:mareklibra/ovirt-ui-components.git","clone_url":"https://github.com/mareklibra/ovirt-ui-components.git","svn_url":"https://github.com/mareklibra/ovirt-ui-components","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matobet:master","ref":"master","sha":"3f0df412598c51edc73621d630dc0b836e4e53f0","user":{"login":"matobet","id":1173428,"avatar_url":"https://avatars.githubusercontent.com/u/1173428?v=3","gravatar_id":"","url":"https://api.github.com/users/matobet","html_url":"https://github.com/matobet","followers_url":"https://api.github.com/users/matobet/followers","following_url":"https://api.github.com/users/matobet/following{/other_user}","gists_url":"https://api.github.com/users/matobet/gists{/gist_id}","starred_url":"https://api.github.com/users/matobet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matobet/subscriptions","organizations_url":"https://api.github.com/users/matobet/orgs","repos_url":"https://api.github.com/users/matobet/repos","events_url":"https://api.github.com/users/matobet/events{/privacy}","received_events_url":"https://api.github.com/users/matobet/received_events","type":"User","site_admin":false},"repo":{"id":68288089,"name":"ovirt-ui-components","full_name":"matobet/ovirt-ui-components","owner":{"login":"matobet","id":1173428,"avatar_url":"https://avatars.githubusercontent.com/u/1173428?v=3","gravatar_id":"","url":"https://api.github.com/users/matobet","html_url":"https://github.com/matobet","followers_url":"https://api.github.com/users/matobet/followers","following_url":"https://api.github.com/users/matobet/following{/other_user}","gists_url":"https://api.github.com/users/matobet/gists{/gist_id}","starred_url":"https://api.github.com/users/matobet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matobet/subscriptions","organizations_url":"https://api.github.com/users/matobet/orgs","repos_url":"https://api.github.com/users/matobet/repos","events_url":"https://api.github.com/users/matobet/events{/privacy}","received_events_url":"https://api.github.com/users/matobet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matobet/ovirt-ui-components","description":"Reusable components for Open Virtualization UIs","fork":false,"url":"https://api.github.com/repos/matobet/ovirt-ui-components","forks_url":"https://api.github.com/repos/matobet/ovirt-ui-components/forks","keys_url":"https://api.github.com/repos/matobet/ovirt-ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matobet/ovirt-ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matobet/ovirt-ui-components/teams","hooks_url":"https://api.github.com/repos/matobet/ovirt-ui-components/hooks","issue_events_url":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/matobet/ovirt-ui-components/events","assignees_url":"https://api.github.com/repos/matobet/ovirt-ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/matobet/ovirt-ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/matobet/ovirt-ui-components/tags","blobs_url":"https://api.github.com/repos/matobet/ovirt-ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matobet/ovirt-ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matobet/ovirt-ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/matobet/ovirt-ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matobet/ovirt-ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/matobet/ovirt-ui-components/languages","stargazers_url":"https://api.github.com/repos/matobet/ovirt-ui-components/stargazers","contributors_url":"https://api.github.com/repos/matobet/ovirt-ui-components/contributors","subscribers_url":"https://api.github.com/repos/matobet/ovirt-ui-components/subscribers","subscription_url":"https://api.github.com/repos/matobet/ovirt-ui-components/subscription","commits_url":"https://api.github.com/repos/matobet/ovirt-ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/matobet/ovirt-ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/matobet/ovirt-ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/matobet/ovirt-ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/matobet/ovirt-ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matobet/ovirt-ui-components/merges","archive_url":"https://api.github.com/repos/matobet/ovirt-ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matobet/ovirt-ui-components/downloads","issues_url":"https://api.github.com/repos/matobet/ovirt-ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/matobet/ovirt-ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/matobet/ovirt-ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matobet/ovirt-ui-components/labels{/name}","releases_url":"https://api.github.com/repos/matobet/ovirt-ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/matobet/ovirt-ui-components/deployments","created_at":"2016-09-15T11:25:02Z","updated_at":"2016-10-05T12:30:29Z","pushed_at":"2016-10-13T10:07:57Z","git_url":"git://github.com/matobet/ovirt-ui-components.git","ssh_url":"git@github.com:matobet/ovirt-ui-components.git","clone_url":"https://github.com/matobet/ovirt-ui-components.git","svn_url":"https://github.com/matobet/ovirt-ui-components","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3"},"html":{"href":"https://github.com/matobet/ovirt-ui-components/pull/3"},"issue":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/3"},"comments":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/matobet/ovirt-ui-components/statuses/c2709655fa4612967e96b33e35ef4f29a82f9907"}}}}
{"actor":{"display_login":"matobet"}}