{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/90321467","pull_request_review_id":10842580,"id":90321467,"diff_hunk":"@@ -23,12 +23,15 @@ assert.strictEqual(\n \n assert.throws(function() {\n   crypto.timingSafeEqual(Buffer.from([1, 2, 3]), Buffer.from([1, 2]));\n-}, 'should throw when given buffers with different lengths');\n+}, /^TypeError: Input buffers must have the same length$/,\n+   'should throw when given buffers with different lengths');","path":"test/sequential/test-crypto-timing-safe-equal.js","position":6,"original_position":6,"commit_id":"463a01630d68fb96abdc2af5a1f3c90f8069b8fa","original_commit_id":"463a01630d68fb96abdc2af5a1f3c90f8069b8fa","user":{"login":"lpinca","id":1443911,"avatar_url":"https://avatars.githubusercontent.com/u/1443911?v=3","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"body":"Actually rereading @targos comment above I think this correct, so ignore me :)","created_at":"2016-11-30T20:33:19Z","updated_at":"2016-11-30T20:33:19Z","html_url":"https://github.com/nodejs/node/pull/9843#discussion_r90321467","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9843","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/90321467"},"html":{"href":"https://github.com/nodejs/node/pull/9843#discussion_r90321467"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9843"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9843","id":95760343,"html_url":"https://github.com/nodejs/node/pull/9843","diff_url":"https://github.com/nodejs/node/pull/9843.diff","patch_url":"https://github.com/nodejs/node/pull/9843.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9843","number":9843,"state":"open","locked":false,"title":"test: refactor test-crypto-timing-safe-equal","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\ntest, crypto\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nAdd RegExp arguments to throws assertions.\r\n\r\nCI: https://ci.nodejs.org/job/node-test-pull-request/5023/","created_at":"2016-11-29T19:37:40Z","updated_at":"2016-11-30T20:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220f025ea5861c89998c755a310b1067e7cdb76b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9843/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9843/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9843/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/463a01630d68fb96abdc2af5a1f3c90f8069b8fa","head":{"label":"targos:refactor-test-crypto-timing","ref":"refactor-test-crypto-timing","sha":"463a01630d68fb96abdc2af5a1f3c90f8069b8fa","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"repo":{"id":29471300,"name":"node","full_name":"targos/node","owner":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/targos/node","description":"Node.js","fork":true,"url":"https://api.github.com/repos/targos/node","forks_url":"https://api.github.com/repos/targos/node/forks","keys_url":"https://api.github.com/repos/targos/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/targos/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/targos/node/teams","hooks_url":"https://api.github.com/repos/targos/node/hooks","issue_events_url":"https://api.github.com/repos/targos/node/issues/events{/number}","events_url":"https://api.github.com/repos/targos/node/events","assignees_url":"https://api.github.com/repos/targos/node/assignees{/user}","branches_url":"https://api.github.com/repos/targos/node/branches{/branch}","tags_url":"https://api.github.com/repos/targos/node/tags","blobs_url":"https://api.github.com/repos/targos/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/targos/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/targos/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/targos/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/targos/node/statuses/{sha}","languages_url":"https://api.github.com/repos/targos/node/languages","stargazers_url":"https://api.github.com/repos/targos/node/stargazers","contributors_url":"https://api.github.com/repos/targos/node/contributors","subscribers_url":"https://api.github.com/repos/targos/node/subscribers","subscription_url":"https://api.github.com/repos/targos/node/subscription","commits_url":"https://api.github.com/repos/targos/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/targos/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/targos/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/targos/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/targos/node/contents/{+path}","compare_url":"https://api.github.com/repos/targos/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/targos/node/merges","archive_url":"https://api.github.com/repos/targos/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/targos/node/downloads","issues_url":"https://api.github.com/repos/targos/node/issues{/number}","pulls_url":"https://api.github.com/repos/targos/node/pulls{/number}","milestones_url":"https://api.github.com/repos/targos/node/milestones{/number}","notifications_url":"https://api.github.com/repos/targos/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/targos/node/labels{/name}","releases_url":"https://api.github.com/repos/targos/node/releases{/id}","deployments_url":"https://api.github.com/repos/targos/node/deployments","created_at":"2015-01-19T13:07:04Z","updated_at":"2016-10-24T10:51:55Z","pushed_at":"2016-11-29T21:20:44Z","git_url":"git://github.com/targos/node.git","ssh_url":"git@github.com:targos/node.git","clone_url":"https://github.com/targos/node.git","svn_url":"https://github.com/targos/node","homepage":"https://nodejs.org","size":233740,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5887c2ba3840be81ab6e89481e771a5d277101ae","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-30T20:25:05Z","pushed_at":"2016-11-30T17:40:05Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":367082,"stargazers_count":29382,"watchers_count":29382,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5092,"mirror_url":null,"open_issues_count":970,"forks":5092,"open_issues":970,"watchers":29382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9843"},"html":{"href":"https://github.com/nodejs/node/pull/9843"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9843"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9843/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9843/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9843/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/463a01630d68fb96abdc2af5a1f3c90f8069b8fa"}}}}
{"actor":{"display_login":"lpinca"}}