{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/65422650","id":65422650,"diff_hunk":"@@ -34,15 +34,21 @@\n \n \tprivate final boolean inheritEnvironment;\n \n+\tprivate final boolean applicationProvided;\n+\n \t/**\n \t * @param binderType the binder type used by this configuration\n \t * @param properties the properties for setting up the binder\n-\t * @param inheritEnvironment whether the binder should inherit the environment of the module\n+\t * @param inheritEnvironment whether the binder should inherit the environment of the\n+\t * module\n+\t * @param applicationProvided whether the binder is user defined","path":"spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/BinderConfiguration.java","position":12,"original_position":12,"commit_id":"8b21e19d9841f334441811765e1d7ee487ecd132","original_commit_id":"8b21e19d9841f334441811765e1d7ee487ecd132","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"I think this would be more clear if it said something like:\r\n\r\n```\r\nwhether the binder is provided by an application, as opposed to being user defined\r\n```\r\n","created_at":"2016-06-01T19:04:01Z","updated_at":"2016-06-01T19:04:01Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/560#discussion_r65422650","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/65422650"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/560#discussion_r65422650"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560","id":72223856,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/560","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/560.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/560.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/560","number":560,"state":"open","locked":false,"title":"Allow for binder configurations that do not affect the defaulting process","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"Fixes #557\r\n\r\nAllow for a special `applicationProvided` flag on a binder configuration that\r\nmakes it transparent to the default configuration process.","created_at":"2016-06-01T17:51:24Z","updated_at":"2016-06-01T19:04:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e042ba517fbf8b86f73d793be81e5bf89ee105","assignee":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/560/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/8b21e19d9841f334441811765e1d7ee487ecd132","head":{"label":"mbogoevici:GH-557","ref":"GH-557","sha":"8b21e19d9841f334441811765e1d7ee487ecd132","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"repo":{"id":38768510,"name":"spring-cloud-stream","full_name":"mbogoevici/spring-cloud-stream","owner":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbogoevici/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream","forks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/deployments","created_at":"2015-07-08T17:15:48Z","updated_at":"2016-01-13T21:40:39Z","pushed_at":"2016-06-01T18:08:25Z","git_url":"git://github.com/mbogoevici/spring-cloud-stream.git","ssh_url":"git@github.com:mbogoevici/spring-cloud-stream.git","clone_url":"https://github.com/mbogoevici/spring-cloud-stream.git","svn_url":"https://github.com/mbogoevici/spring-cloud-stream","homepage":null,"size":2791,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"aef08a28a35d77dfcaa1a533feec00b832e5f400","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/deployments","created_at":"2015-07-08T15:51:38Z","updated_at":"2016-05-25T06:45:51Z","pushed_at":"2016-06-01T18:38:03Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":4492,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":59,"forks":49,"open_issues":59,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/560"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/560"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/560/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/560/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/8b21e19d9841f334441811765e1d7ee487ecd132"}}}}
{"actor":{"display_login":"markfisher"}}