{"action":"created","comment":{"url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/comments/57758485","id":57758485,"diff_hunk":"@@ -1,8 +1,24 @@\n diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc\n-index b5b0b78..aac6876 100644\n+index b5b0b78..1c42b6c 100644\n --- a/content/browser/web_contents/web_contents_impl.cc\n +++ b/content/browser/web_contents/web_contents_impl.cc\n-@@ -4353,6 +4353,7 @@ void WebContentsImpl::RendererUnresponsive(\n+@@ -1820,10 +1820,14 @@ void WebContentsImpl::CreateNewWindow(\n+       static_cast<SessionStorageNamespaceImpl*>(session_storage_namespace);\n+   CHECK(session_storage_namespace_impl->IsFromContext(dom_storage_context));\n+ \n++  WindowContainerType window_container_type = WINDOW_CONTAINER_TYPE_NORMAL;\n++  if (params.disposition == NEW_BACKGROUND_TAB)","path":"patches/web_contents_impl.patch","position":12,"original_position":12,"commit_id":"7ff3f24bf4aacb948aa0f63e56867962e0e91861","original_commit_id":"7ff3f24bf4aacb948aa0f63e56867962e0e91861","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Sure, would patching `CanCreateWindow` help ? the link you provided points to something other issue.","created_at":"2016-03-29T16:55:03Z","updated_at":"2016-03-29T16:55:03Z","html_url":"https://github.com/atom/libchromiumcontent/pull/187#discussion_r57758485","pull_request_url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/comments/57758485"},"html":{"href":"https://github.com/atom/libchromiumcontent/pull/187#discussion_r57758485"},"pull_request":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187","id":64199789,"html_url":"https://github.com/atom/libchromiumcontent/pull/187","diff_url":"https://github.com/atom/libchromiumcontent/pull/187.diff","patch_url":"https://github.com/atom/libchromiumcontent/pull/187.patch","issue_url":"https://api.github.com/repos/atom/libchromiumcontent/issues/187","number":187,"state":"open","locked":false,"title":"Update web_contents_impl.patch","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Minimal patch to obtain disposition with `ShouldCreateWebContents`.","created_at":"2016-03-25T19:45:48Z","updated_at":"2016-03-29T16:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"676a8f8b6917787c4b4549f8d5cf8d2d6adf2e4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187/commits","review_comments_url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187/comments","review_comment_url":"https://api.github.com/repos/atom/libchromiumcontent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/libchromiumcontent/issues/187/comments","statuses_url":"https://api.github.com/repos/atom/libchromiumcontent/statuses/7ff3f24bf4aacb948aa0f63e56867962e0e91861","head":{"label":"deepak1556:update_web_contents_patch","ref":"update_web_contents_patch","sha":"7ff3f24bf4aacb948aa0f63e56867962e0e91861","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":33873499,"name":"libchromiumcontent","full_name":"deepak1556/libchromiumcontent","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":true,"url":"https://api.github.com/repos/deepak1556/libchromiumcontent","forks_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/deepak1556/libchromiumcontent/deployments","created_at":"2015-04-13T14:31:34Z","updated_at":"2015-04-13T14:31:35Z","pushed_at":"2016-03-26T03:48:55Z","git_url":"git://github.com/deepak1556/libchromiumcontent.git","ssh_url":"git@github.com:deepak1556/libchromiumcontent.git","clone_url":"https://github.com/deepak1556/libchromiumcontent.git","svn_url":"https://github.com/deepak1556/libchromiumcontent","homepage":"","size":867,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b06d4c307b861cdb091f4ba26b1a185333889033","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":8479951,"name":"libchromiumcontent","full_name":"atom/libchromiumcontent","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/atom/libchromiumcontent","forks_url":"https://api.github.com/repos/atom/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/atom/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/atom/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/atom/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/atom/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/atom/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/atom/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/atom/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/atom/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/atom/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/atom/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/atom/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/atom/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/atom/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/atom/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/atom/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/atom/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/atom/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/atom/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/atom/libchromiumcontent/deployments","created_at":"2013-02-28T13:48:40Z","updated_at":"2016-03-27T11:16:07Z","pushed_at":"2016-03-26T07:12:53Z","git_url":"git://github.com/atom/libchromiumcontent.git","ssh_url":"git@github.com:atom/libchromiumcontent.git","clone_url":"https://github.com/atom/libchromiumcontent.git","svn_url":"https://github.com/atom/libchromiumcontent","homepage":"","size":1551,"stargazers_count":241,"watchers_count":241,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":10,"forks":66,"open_issues":10,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187"},"html":{"href":"https://github.com/atom/libchromiumcontent/pull/187"},"issue":{"href":"https://api.github.com/repos/atom/libchromiumcontent/issues/187"},"comments":{"href":"https://api.github.com/repos/atom/libchromiumcontent/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/libchromiumcontent/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/atom/libchromiumcontent/statuses/7ff3f24bf4aacb948aa0f63e56867962e0e91861"}}}}