{"action":"created","comment":{"url":"https://api.github.com/repos/mkoryak/floatThead/pulls/comments/74870550","id":74870550,"diff_hunk":"@@ -482,15 +514,20 @@\n               cells.push('<th class=\"floatThead-col\"/>');\n             }\n             cols.push('<col/>');\n-            psuedo.push(\"<fthtd style='display:table-cell;height:0;width:auto;'/>\");\n+            psuedo.push(\n+              $('<fthtd>').css({\n+                'display': 'table-cell',\n+                'height': 0,\n+                'width': 'auto'\n+              })\n+            );\n           }\n \n           cols = cols.join('');\n           cells = cells.join('');\n \n           if(createElements){\n-            psuedo = psuedo.join('');\n-            $fthRow.html(psuedo);\n+            $fthRow.append(psuedo);","path":"dist/jquery.floatThead-slim.js","position":105,"original_position":105,"commit_id":"0058cab337eb839bf8f268fce58ca077a363c2f0","original_commit_id":"0058cab337eb839bf8f268fce58ca077a363c2f0","user":{"login":"mkoryak","id":383817,"avatar_url":"https://avatars.githubusercontent.com/u/383817?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoryak","html_url":"https://github.com/mkoryak","followers_url":"https://api.github.com/users/mkoryak/followers","following_url":"https://api.github.com/users/mkoryak/following{/other_user}","gists_url":"https://api.github.com/users/mkoryak/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoryak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoryak/subscriptions","organizations_url":"https://api.github.com/users/mkoryak/orgs","repos_url":"https://api.github.com/users/mkoryak/repos","events_url":"https://api.github.com/users/mkoryak/events{/privacy}","received_events_url":"https://api.github.com/users/mkoryak/received_events","type":"User","site_admin":false},"body":"is appending an array actually any faster than `html` which i assume uses innerHTML? \r\n\r\nI am optimizing for speed vs clarity in most cases here.","created_at":"2016-08-16T03:13:08Z","updated_at":"2016-08-16T03:13:08Z","html_url":"https://github.com/mkoryak/floatThead/pull/321#discussion_r74870550","pull_request_url":"https://api.github.com/repos/mkoryak/floatThead/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/comments/74870550"},"html":{"href":"https://github.com/mkoryak/floatThead/pull/321#discussion_r74870550"},"pull_request":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/mkoryak/floatThead/pulls/321","id":81220230,"html_url":"https://github.com/mkoryak/floatThead/pull/321","diff_url":"https://github.com/mkoryak/floatThead/pull/321.diff","patch_url":"https://github.com/mkoryak/floatThead/pull/321.patch","issue_url":"https://api.github.com/repos/mkoryak/floatThead/issues/321","number":321,"state":"open","locked":false,"title":"do not require Content Security Policy (CSP) style-src 'unsafe-inline'","user":{"login":"jelhan","id":4965703,"avatar_url":"https://avatars.githubusercontent.com/u/4965703?v=3","gravatar_id":"","url":"https://api.github.com/users/jelhan","html_url":"https://github.com/jelhan","followers_url":"https://api.github.com/users/jelhan/followers","following_url":"https://api.github.com/users/jelhan/following{/other_user}","gists_url":"https://api.github.com/users/jelhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jelhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelhan/subscriptions","organizations_url":"https://api.github.com/users/jelhan/orgs","repos_url":"https://api.github.com/users/jelhan/repos","events_url":"https://api.github.com/users/jelhan/events{/privacy}","received_events_url":"https://api.github.com/users/jelhan/received_events","type":"User","site_admin":false},"body":"To not trigger a Content Security Policy (CSP) 'unsafe-inline' violation we have to modify CSSOM directly. This is what jQuery `.css()` method does. Therefore code like `$('<div style=\"width: 100\"');` should be avoided to not force consuming applications to lower CSP rules.","created_at":"2016-08-13T16:45:54Z","updated_at":"2016-08-16T03:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cf0c8a04040944a33dd782b8084d6b6f9f938e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mkoryak/floatThead/pulls/321/commits","review_comments_url":"https://api.github.com/repos/mkoryak/floatThead/pulls/321/comments","review_comment_url":"https://api.github.com/repos/mkoryak/floatThead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mkoryak/floatThead/issues/321/comments","statuses_url":"https://api.github.com/repos/mkoryak/floatThead/statuses/0058cab337eb839bf8f268fce58ca077a363c2f0","head":{"label":"jelhan:csp","ref":"csp","sha":"0058cab337eb839bf8f268fce58ca077a363c2f0","user":{"login":"jelhan","id":4965703,"avatar_url":"https://avatars.githubusercontent.com/u/4965703?v=3","gravatar_id":"","url":"https://api.github.com/users/jelhan","html_url":"https://github.com/jelhan","followers_url":"https://api.github.com/users/jelhan/followers","following_url":"https://api.github.com/users/jelhan/following{/other_user}","gists_url":"https://api.github.com/users/jelhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jelhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelhan/subscriptions","organizations_url":"https://api.github.com/users/jelhan/orgs","repos_url":"https://api.github.com/users/jelhan/repos","events_url":"https://api.github.com/users/jelhan/events{/privacy}","received_events_url":"https://api.github.com/users/jelhan/received_events","type":"User","site_admin":false},"repo":{"id":65621197,"name":"floatThead","full_name":"jelhan/floatThead","owner":{"login":"jelhan","id":4965703,"avatar_url":"https://avatars.githubusercontent.com/u/4965703?v=3","gravatar_id":"","url":"https://api.github.com/users/jelhan","html_url":"https://github.com/jelhan","followers_url":"https://api.github.com/users/jelhan/followers","following_url":"https://api.github.com/users/jelhan/following{/other_user}","gists_url":"https://api.github.com/users/jelhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jelhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelhan/subscriptions","organizations_url":"https://api.github.com/users/jelhan/orgs","repos_url":"https://api.github.com/users/jelhan/repos","events_url":"https://api.github.com/users/jelhan/events{/privacy}","received_events_url":"https://api.github.com/users/jelhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jelhan/floatThead","description":"fixed <thead>. no custom css/html, just works","fork":true,"url":"https://api.github.com/repos/jelhan/floatThead","forks_url":"https://api.github.com/repos/jelhan/floatThead/forks","keys_url":"https://api.github.com/repos/jelhan/floatThead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jelhan/floatThead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jelhan/floatThead/teams","hooks_url":"https://api.github.com/repos/jelhan/floatThead/hooks","issue_events_url":"https://api.github.com/repos/jelhan/floatThead/issues/events{/number}","events_url":"https://api.github.com/repos/jelhan/floatThead/events","assignees_url":"https://api.github.com/repos/jelhan/floatThead/assignees{/user}","branches_url":"https://api.github.com/repos/jelhan/floatThead/branches{/branch}","tags_url":"https://api.github.com/repos/jelhan/floatThead/tags","blobs_url":"https://api.github.com/repos/jelhan/floatThead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jelhan/floatThead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jelhan/floatThead/git/refs{/sha}","trees_url":"https://api.github.com/repos/jelhan/floatThead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jelhan/floatThead/statuses/{sha}","languages_url":"https://api.github.com/repos/jelhan/floatThead/languages","stargazers_url":"https://api.github.com/repos/jelhan/floatThead/stargazers","contributors_url":"https://api.github.com/repos/jelhan/floatThead/contributors","subscribers_url":"https://api.github.com/repos/jelhan/floatThead/subscribers","subscription_url":"https://api.github.com/repos/jelhan/floatThead/subscription","commits_url":"https://api.github.com/repos/jelhan/floatThead/commits{/sha}","git_commits_url":"https://api.github.com/repos/jelhan/floatThead/git/commits{/sha}","comments_url":"https://api.github.com/repos/jelhan/floatThead/comments{/number}","issue_comment_url":"https://api.github.com/repos/jelhan/floatThead/issues/comments{/number}","contents_url":"https://api.github.com/repos/jelhan/floatThead/contents/{+path}","compare_url":"https://api.github.com/repos/jelhan/floatThead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jelhan/floatThead/merges","archive_url":"https://api.github.com/repos/jelhan/floatThead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jelhan/floatThead/downloads","issues_url":"https://api.github.com/repos/jelhan/floatThead/issues{/number}","pulls_url":"https://api.github.com/repos/jelhan/floatThead/pulls{/number}","milestones_url":"https://api.github.com/repos/jelhan/floatThead/milestones{/number}","notifications_url":"https://api.github.com/repos/jelhan/floatThead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jelhan/floatThead/labels{/name}","releases_url":"https://api.github.com/repos/jelhan/floatThead/releases{/id}","deployments_url":"https://api.github.com/repos/jelhan/floatThead/deployments","created_at":"2016-08-13T14:28:40Z","updated_at":"2016-08-13T14:28:42Z","pushed_at":"2016-08-13T16:36:56Z","git_url":"git://github.com/jelhan/floatThead.git","ssh_url":"git@github.com:jelhan/floatThead.git","clone_url":"https://github.com/jelhan/floatThead.git","svn_url":"https://github.com/jelhan/floatThead","homepage":"http://mkoryak.github.io/floatThead/","size":1787,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mkoryak:master","ref":"master","sha":"8daf17c08e0768aa8c67172b18aa5d3cf0665579","user":{"login":"mkoryak","id":383817,"avatar_url":"https://avatars.githubusercontent.com/u/383817?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoryak","html_url":"https://github.com/mkoryak","followers_url":"https://api.github.com/users/mkoryak/followers","following_url":"https://api.github.com/users/mkoryak/following{/other_user}","gists_url":"https://api.github.com/users/mkoryak/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoryak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoryak/subscriptions","organizations_url":"https://api.github.com/users/mkoryak/orgs","repos_url":"https://api.github.com/users/mkoryak/repos","events_url":"https://api.github.com/users/mkoryak/events{/privacy}","received_events_url":"https://api.github.com/users/mkoryak/received_events","type":"User","site_admin":false},"repo":{"id":5937246,"name":"floatThead","full_name":"mkoryak/floatThead","owner":{"login":"mkoryak","id":383817,"avatar_url":"https://avatars.githubusercontent.com/u/383817?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoryak","html_url":"https://github.com/mkoryak","followers_url":"https://api.github.com/users/mkoryak/followers","following_url":"https://api.github.com/users/mkoryak/following{/other_user}","gists_url":"https://api.github.com/users/mkoryak/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoryak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoryak/subscriptions","organizations_url":"https://api.github.com/users/mkoryak/orgs","repos_url":"https://api.github.com/users/mkoryak/repos","events_url":"https://api.github.com/users/mkoryak/events{/privacy}","received_events_url":"https://api.github.com/users/mkoryak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkoryak/floatThead","description":"fixed <thead>. no custom css/html, just works","fork":false,"url":"https://api.github.com/repos/mkoryak/floatThead","forks_url":"https://api.github.com/repos/mkoryak/floatThead/forks","keys_url":"https://api.github.com/repos/mkoryak/floatThead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoryak/floatThead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoryak/floatThead/teams","hooks_url":"https://api.github.com/repos/mkoryak/floatThead/hooks","issue_events_url":"https://api.github.com/repos/mkoryak/floatThead/issues/events{/number}","events_url":"https://api.github.com/repos/mkoryak/floatThead/events","assignees_url":"https://api.github.com/repos/mkoryak/floatThead/assignees{/user}","branches_url":"https://api.github.com/repos/mkoryak/floatThead/branches{/branch}","tags_url":"https://api.github.com/repos/mkoryak/floatThead/tags","blobs_url":"https://api.github.com/repos/mkoryak/floatThead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoryak/floatThead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoryak/floatThead/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoryak/floatThead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoryak/floatThead/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoryak/floatThead/languages","stargazers_url":"https://api.github.com/repos/mkoryak/floatThead/stargazers","contributors_url":"https://api.github.com/repos/mkoryak/floatThead/contributors","subscribers_url":"https://api.github.com/repos/mkoryak/floatThead/subscribers","subscription_url":"https://api.github.com/repos/mkoryak/floatThead/subscription","commits_url":"https://api.github.com/repos/mkoryak/floatThead/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoryak/floatThead/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoryak/floatThead/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoryak/floatThead/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoryak/floatThead/contents/{+path}","compare_url":"https://api.github.com/repos/mkoryak/floatThead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoryak/floatThead/merges","archive_url":"https://api.github.com/repos/mkoryak/floatThead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoryak/floatThead/downloads","issues_url":"https://api.github.com/repos/mkoryak/floatThead/issues{/number}","pulls_url":"https://api.github.com/repos/mkoryak/floatThead/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoryak/floatThead/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoryak/floatThead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoryak/floatThead/labels{/name}","releases_url":"https://api.github.com/repos/mkoryak/floatThead/releases{/id}","deployments_url":"https://api.github.com/repos/mkoryak/floatThead/deployments","created_at":"2012-09-24T16:20:25Z","updated_at":"2016-08-15T21:14:39Z","pushed_at":"2016-08-13T16:45:56Z","git_url":"git://github.com/mkoryak/floatThead.git","ssh_url":"git@github.com:mkoryak/floatThead.git","clone_url":"https://github.com/mkoryak/floatThead.git","svn_url":"https://github.com/mkoryak/floatThead","homepage":"http://mkoryak.github.io/floatThead/","size":2041,"stargazers_count":702,"watchers_count":702,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":114,"mirror_url":null,"open_issues_count":2,"forks":114,"open_issues":2,"watchers":702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/321"},"html":{"href":"https://github.com/mkoryak/floatThead/pull/321"},"issue":{"href":"https://api.github.com/repos/mkoryak/floatThead/issues/321"},"comments":{"href":"https://api.github.com/repos/mkoryak/floatThead/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mkoryak/floatThead/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/mkoryak/floatThead/statuses/0058cab337eb839bf8f268fce58ca077a363c2f0"}}}}
{"actor":{"display_login":"mkoryak"}}