{"action":"created","issue":{"url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/722","repository_url":"https://api.github.com/repos/WebDevStudios/CMB2","labels_url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/722/labels{/name}","comments_url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/722/comments","events_url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/722/events","html_url":"https://github.com/WebDevStudios/CMB2/pull/722","id":173334873,"number":722,"title":"[#326] Included the usage of the before_field for the default currency","user":{"login":"jcchavezs","id":3075074,"avatar_url":"https://avatars.githubusercontent.com/u/3075074?v=3","gravatar_id":"","url":"https://api.github.com/users/jcchavezs","html_url":"https://github.com/jcchavezs","followers_url":"https://api.github.com/users/jcchavezs/followers","following_url":"https://api.github.com/users/jcchavezs/following{/other_user}","gists_url":"https://api.github.com/users/jcchavezs/gists{/gist_id}","starred_url":"https://api.github.com/users/jcchavezs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcchavezs/subscriptions","organizations_url":"https://api.github.com/users/jcchavezs/orgs","repos_url":"https://api.github.com/users/jcchavezs/repos","events_url":"https://api.github.com/users/jcchavezs/events{/privacy}","received_events_url":"https://api.github.com/users/jcchavezs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-25T23:25:06Z","updated_at":"2016-08-25T23:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WebDevStudios/CMB2/pulls/722","html_url":"https://github.com/WebDevStudios/CMB2/pull/722","diff_url":"https://github.com/WebDevStudios/CMB2/pull/722.diff","patch_url":"https://github.com/WebDevStudios/CMB2/pull/722.patch"},"body":"Fixes #326 .\r\n\r\n### Changes proposed in this pull request\r\n\r\n-  Possibility of defining a currency symbol for the ``text_money`` field type.\r\n\r\nPing @jtsternberg "},"comment":{"url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/comments/242578500","html_url":"https://github.com/WebDevStudios/CMB2/pull/722#issuecomment-242578500","issue_url":"https://api.github.com/repos/WebDevStudios/CMB2/issues/722","id":242578500,"user":{"login":"jtsternberg","id":1098900,"avatar_url":"https://avatars.githubusercontent.com/u/1098900?v=3","gravatar_id":"","url":"https://api.github.com/users/jtsternberg","html_url":"https://github.com/jtsternberg","followers_url":"https://api.github.com/users/jtsternberg/followers","following_url":"https://api.github.com/users/jtsternberg/following{/other_user}","gists_url":"https://api.github.com/users/jtsternberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jtsternberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtsternberg/subscriptions","organizations_url":"https://api.github.com/users/jtsternberg/orgs","repos_url":"https://api.github.com/users/jtsternberg/repos","events_url":"https://api.github.com/users/jtsternberg/events{/privacy}","received_events_url":"https://api.github.com/users/jtsternberg/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T23:30:40Z","updated_at":"2016-08-25T23:30:40Z","body":"The only way I'd be willing to merge this in is if the [back-compatibility concerns](https://github.com/WebDevStudios/CMB2/issues/326#issuecomment-126105079) are addressed. The only way I see that happening is to use a variable filter name with the `cmb_id` being part of the hook (example: https://github.com/WebDevStudios/CMB2/blob/trunk/includes/CMB2.php#L140). And `cmb_id` is not guaranteed in this specific method context, so this would likely be better off happening in the `add_field` method: https://github.com/WebDevStudios/CMB2/blob/trunk/includes/CMB2.php#L1071-L1096."}}
{"actor":{"display_login":"jtsternberg"}}