{"action":"created","issue":{"url":"https://api.github.com/repos/killbill/killbill/issues/683","repository_url":"https://api.github.com/repos/killbill/killbill","labels_url":"https://api.github.com/repos/killbill/killbill/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/killbill/killbill/issues/683/comments","events_url":"https://api.github.com/repos/killbill/killbill/issues/683/events","html_url":"https://github.com/killbill/killbill/issues/683","id":198199653,"number":683,"title":"BlockingStateOrdering code assessment and tests","user":{"login":"sbrossie","id":246910,"avatar_url":"https://avatars.githubusercontent.com/u/246910?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrossie","html_url":"https://github.com/sbrossie","followers_url":"https://api.github.com/users/sbrossie/followers","following_url":"https://api.github.com/users/sbrossie/following{/other_user}","gists_url":"https://api.github.com/users/sbrossie/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrossie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrossie/subscriptions","organizations_url":"https://api.github.com/users/sbrossie/orgs","repos_url":"https://api.github.com/users/sbrossie/repos","events_url":"https://api.github.com/users/sbrossie/events{/privacy}","received_events_url":"https://api.github.com/users/sbrossie/received_events","type":"User","site_admin":false},"labels":[{"id":17089649,"url":"https://api.github.com/repos/killbill/killbill/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":17090540,"url":"https://api.github.com/repos/killbill/killbill/labels/ENTITLEMENT","name":"ENTITLEMENT","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-30T22:05:49Z","updated_at":"2016-12-30T22:07:05Z","closed_at":null,"body":"The `BlockingStateOrdering` logic is a complicated piece because:\r\n1. We are lacking in the system the notion of a global ordering (ordering exists somehow at the sub-system level by looking at `effective_date, record_id`)\r\n2. The model associated with `BlockingState` event is quite powerful and complex with its multi dimensions: state_name, types (`ACCOUNT`, `BUNDLE`, `SUBSCRIPTION`) and additional flags `block_billing`,  `block_entitlement`\r\n\r\nI don't expect we will be to simplify greatly this class, but we should still revisit it and instrument our level of unit testing."},"comment":{"url":"https://api.github.com/repos/killbill/killbill/issues/comments/269827547","html_url":"https://github.com/killbill/killbill/issues/683#issuecomment-269827547","issue_url":"https://api.github.com/repos/killbill/killbill/issues/683","id":269827547,"user":{"login":"sbrossie","id":246910,"avatar_url":"https://avatars.githubusercontent.com/u/246910?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrossie","html_url":"https://github.com/sbrossie","followers_url":"https://api.github.com/users/sbrossie/followers","following_url":"https://api.github.com/users/sbrossie/following{/other_user}","gists_url":"https://api.github.com/users/sbrossie/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrossie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrossie/subscriptions","organizations_url":"https://api.github.com/users/sbrossie/orgs","repos_url":"https://api.github.com/users/sbrossie/repos","events_url":"https://api.github.com/users/sbrossie/events{/privacy}","received_events_url":"https://api.github.com/users/sbrossie/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T22:07:05Z","updated_at":"2016-12-30T22:07:05Z","body":"See 339309b3dffeb1ff102d89365971119ee2306d2b for issue on badly populated events. Probably we need to enhance our test assertion to verify more."}}
{"actor":{"display_login":"sbrossie"}}