{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/55791366","id":55791366,"diff_hunk":"@@ -95,7 +89,7 @@ func MonitorPodHealth(config *preparer.PreparerConfig, logger *logging.Logger, s\n \t\t\t// check if pods have been added or removed\n \t\t\t// starts monitor routine for new pods\n \t\t\t// kills monitor routine for removed pods\n-\t\t\tpods = updatePods(healthManager, client, pods, results, node, logger)\n+\t\t\tpods = updatePods(healthManager, config, pods, results, node, logger)","path":"pkg/watch/health.go","position":18,"original_position":18,"commit_id":"170f75042f385c34a5a74e747ca4126227a92541","original_commit_id":"170f75042f385c34a5a74e747ca4126227a92541","user":{"login":"csstaub","id":639883,"avatar_url":"https://avatars.githubusercontent.com/u/639883?v=3","gravatar_id":"","url":"https://api.github.com/users/csstaub","html_url":"https://github.com/csstaub","followers_url":"https://api.github.com/users/csstaub/followers","following_url":"https://api.github.com/users/csstaub/following{/other_user}","gists_url":"https://api.github.com/users/csstaub/gists{/gist_id}","starred_url":"https://api.github.com/users/csstaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstaub/subscriptions","organizations_url":"https://api.github.com/users/csstaub/orgs","repos_url":"https://api.github.com/users/csstaub/repos","events_url":"https://api.github.com/users/csstaub/events{/privacy}","received_events_url":"https://api.github.com/users/csstaub/received_events","type":"User","site_admin":false},"body":"Yeah, will fix. Sorry been busy the last few days.","created_at":"2016-03-11T05:38:36Z","updated_at":"2016-03-11T05:38:36Z","html_url":"https://github.com/square/p2/pull/394#discussion_r55791366","pull_request_url":"https://api.github.com/repos/square/p2/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/55791366"},"html":{"href":"https://github.com/square/p2/pull/394#discussion_r55791366"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/394","id":60439901,"html_url":"https://github.com/square/p2/pull/394","diff_url":"https://github.com/square/p2/pull/394.diff","patch_url":"https://github.com/square/p2/pull/394.patch","issue_url":"https://api.github.com/repos/square/p2/issues/394","number":394,"state":"open","locked":false,"title":"Query health through localhost","user":{"login":"csstaub","id":639883,"avatar_url":"https://avatars.githubusercontent.com/u/639883?v=3","gravatar_id":"","url":"https://api.github.com/users/csstaub","html_url":"https://github.com/csstaub","followers_url":"https://api.github.com/users/csstaub/followers","following_url":"https://api.github.com/users/csstaub/following{/other_user}","gists_url":"https://api.github.com/users/csstaub/gists{/gist_id}","starred_url":"https://api.github.com/users/csstaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstaub/subscriptions","organizations_url":"https://api.github.com/users/csstaub/orgs","repos_url":"https://api.github.com/users/csstaub/repos","events_url":"https://api.github.com/users/csstaub/events{/privacy}","received_events_url":"https://api.github.com/users/csstaub/received_events","type":"User","site_admin":false},"body":"Since p2-preparer runs on the same node, it can talk to the app on\r\nlocalhost in order to check its health. This way apps can serve the\r\nstatus port on the loopback interface only. In many cases, it's not\r\nnecessary to expose it to the outside world. Closes #392.","created_at":"2016-02-24T01:10:16Z","updated_at":"2016-03-11T05:38:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4f0809471d0c52965dd5dec3b374a244dc11db7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/394/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/394/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/394/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/170f75042f385c34a5a74e747ca4126227a92541","head":{"label":"csstaub:cs/health-on-localhost","ref":"cs/health-on-localhost","sha":"170f75042f385c34a5a74e747ca4126227a92541","user":{"login":"csstaub","id":639883,"avatar_url":"https://avatars.githubusercontent.com/u/639883?v=3","gravatar_id":"","url":"https://api.github.com/users/csstaub","html_url":"https://github.com/csstaub","followers_url":"https://api.github.com/users/csstaub/followers","following_url":"https://api.github.com/users/csstaub/following{/other_user}","gists_url":"https://api.github.com/users/csstaub/gists{/gist_id}","starred_url":"https://api.github.com/users/csstaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstaub/subscriptions","organizations_url":"https://api.github.com/users/csstaub/orgs","repos_url":"https://api.github.com/users/csstaub/repos","events_url":"https://api.github.com/users/csstaub/events{/privacy}","received_events_url":"https://api.github.com/users/csstaub/received_events","type":"User","site_admin":false},"repo":{"id":52401305,"name":"p2","full_name":"csstaub/p2","owner":{"login":"csstaub","id":639883,"avatar_url":"https://avatars.githubusercontent.com/u/639883?v=3","gravatar_id":"","url":"https://api.github.com/users/csstaub","html_url":"https://github.com/csstaub","followers_url":"https://api.github.com/users/csstaub/followers","following_url":"https://api.github.com/users/csstaub/following{/other_user}","gists_url":"https://api.github.com/users/csstaub/gists{/gist_id}","starred_url":"https://api.github.com/users/csstaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstaub/subscriptions","organizations_url":"https://api.github.com/users/csstaub/orgs","repos_url":"https://api.github.com/users/csstaub/repos","events_url":"https://api.github.com/users/csstaub/events{/privacy}","received_events_url":"https://api.github.com/users/csstaub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csstaub/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/csstaub/p2","forks_url":"https://api.github.com/repos/csstaub/p2/forks","keys_url":"https://api.github.com/repos/csstaub/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csstaub/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csstaub/p2/teams","hooks_url":"https://api.github.com/repos/csstaub/p2/hooks","issue_events_url":"https://api.github.com/repos/csstaub/p2/issues/events{/number}","events_url":"https://api.github.com/repos/csstaub/p2/events","assignees_url":"https://api.github.com/repos/csstaub/p2/assignees{/user}","branches_url":"https://api.github.com/repos/csstaub/p2/branches{/branch}","tags_url":"https://api.github.com/repos/csstaub/p2/tags","blobs_url":"https://api.github.com/repos/csstaub/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csstaub/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csstaub/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/csstaub/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csstaub/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/csstaub/p2/languages","stargazers_url":"https://api.github.com/repos/csstaub/p2/stargazers","contributors_url":"https://api.github.com/repos/csstaub/p2/contributors","subscribers_url":"https://api.github.com/repos/csstaub/p2/subscribers","subscription_url":"https://api.github.com/repos/csstaub/p2/subscription","commits_url":"https://api.github.com/repos/csstaub/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/csstaub/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/csstaub/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/csstaub/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/csstaub/p2/contents/{+path}","compare_url":"https://api.github.com/repos/csstaub/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csstaub/p2/merges","archive_url":"https://api.github.com/repos/csstaub/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csstaub/p2/downloads","issues_url":"https://api.github.com/repos/csstaub/p2/issues{/number}","pulls_url":"https://api.github.com/repos/csstaub/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/csstaub/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/csstaub/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csstaub/p2/labels{/name}","releases_url":"https://api.github.com/repos/csstaub/p2/releases{/id}","deployments_url":"https://api.github.com/repos/csstaub/p2/deployments","created_at":"2016-02-24T00:13:33Z","updated_at":"2016-02-24T00:13:34Z","pushed_at":"2016-03-02T20:46:58Z","git_url":"git://github.com/csstaub/p2.git","ssh_url":"git@github.com:csstaub/p2.git","clone_url":"https://github.com/csstaub/p2.git","svn_url":"https://github.com/csstaub/p2","homepage":"","size":32840,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"bac3af51bcead5c8989eafedbf1b6d62d1311c54","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","deployments_url":"https://api.github.com/repos/square/p2/deployments","created_at":"2014-10-16T20:31:12Z","updated_at":"2016-03-02T20:47:10Z","pushed_at":"2016-03-11T03:41:27Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":33129,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/394"},"html":{"href":"https://github.com/square/p2/pull/394"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/394"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/170f75042f385c34a5a74e747ca4126227a92541"}}}}