{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/700","repository_url":"https://api.github.com/repos/apple/swift-corelibs-foundation","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/700/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/700/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/700/events","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/700","id":185834274,"number":700,"title":"SR-2301 - Fix XMLParser","user":{"login":"KingOfBrian","id":114322,"avatar_url":"https://avatars.githubusercontent.com/u/114322?v=3","gravatar_id":"","url":"https://api.github.com/users/KingOfBrian","html_url":"https://github.com/KingOfBrian","followers_url":"https://api.github.com/users/KingOfBrian/followers","following_url":"https://api.github.com/users/KingOfBrian/following{/other_user}","gists_url":"https://api.github.com/users/KingOfBrian/gists{/gist_id}","starred_url":"https://api.github.com/users/KingOfBrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingOfBrian/subscriptions","organizations_url":"https://api.github.com/users/KingOfBrian/orgs","repos_url":"https://api.github.com/users/KingOfBrian/repos","events_url":"https://api.github.com/users/KingOfBrian/events{/privacy}","received_events_url":"https://api.github.com/users/KingOfBrian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-28T04:05:33Z","updated_at":"2016-10-28T17:02:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/700","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/700","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/700.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/700.patch"},"body":"XMLParser was completely broken, even though the bridging was available and things are 99% complete. This PR adds a number of tests to show the problem, and fixes a number of issues:\r\n\r\n- The contract was different from Foundation. Methods were not optional and NSError was still in use.\r\n- There was an incorrect nullability annotation on the C Shim between libxml2. This was causing a crash when processing namespaces.\r\n- The `bomChunk` parsing was broken. There was no way for the parser to actually be constructed.\r\n- Some of the logic as to what values get reported to `startElement` and `endElement` I believe was wrong. I had trouble fixing the logic for the nullability changes and decided that it was easier to re-write things.\r\n\r\nThere's a lot of code in this file hasn't been spruced up in a while and doesn't follow many swift best practices. I'm not sure what the policy was on cleaning things up was, so I tried to just focus on my bugs. However I would be surpised if a cleanup wouldn't flush out a few more issues.\r\n\r\nBrian King"},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments/256973834","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/700#issuecomment-256973834","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/700","id":256973834,"user":{"login":"parkera","id":144462,"avatar_url":"https://avatars.githubusercontent.com/u/144462?v=3","gravatar_id":"","url":"https://api.github.com/users/parkera","html_url":"https://github.com/parkera","followers_url":"https://api.github.com/users/parkera/followers","following_url":"https://api.github.com/users/parkera/following{/other_user}","gists_url":"https://api.github.com/users/parkera/gists{/gist_id}","starred_url":"https://api.github.com/users/parkera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkera/subscriptions","organizations_url":"https://api.github.com/users/parkera/orgs","repos_url":"https://api.github.com/users/parkera/repos","events_url":"https://api.github.com/users/parkera/events{/privacy}","received_events_url":"https://api.github.com/users/parkera/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T17:02:24Z","updated_at":"2016-10-28T17:02:24Z","body":"@swift-ci please test"}}
{"actor":{"display_login":"parkera"}}