{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/50584326","id":50584326,"diff_hunk":"@@ -58,8 +62,70 @@ export class Performance {\n \n     /** @const @private {!Array<TickEventDef>} */\n     this.events_ = [];\n+\n+    /** @private {?Viewer} */\n+    this.viewer_ = null;\n+\n+    /** @private {?Resources} */\n+    this.resources = null;\n+\n+    /** @private {?DocumentState} */\n+    this.docState_ = null;\n+  }\n+\n+  /**\n+   * Listens to viewer and resource events.\n+   */\n+  coreServicesAvailable() {\n+    this.viewer_ = viewerFor(this.win);\n+    this.resources_ = resourcesFor(this.win);\n+    this.docState_ = documentStateFor(this.win);\n+\n+    this.viewer_.onVisibilityChanged(this.flush.bind(this));\n+\n+    this.measureUserPerceivedVisualCompletenessTime_();\n   }\n \n+  /**\n+   * Measure the delay the user perceives of how long it takes\n+   * to load the initial viewport.\n+   * @private\n+   */\n+  measureUserPerceivedVisualCompletenessTime_() {\n+    let didStartInPrerender = !this.viewer_.hasBeenVisible();\n+    let docVisibleTime = didStartInPrerender ? -1 : timer.now();\n+\n+    // This is only relevant if the viewer is in prerender mode.\n+    // (hasn't been visible yet, ever at this point)\n+    if (didStartInPrerender) {\n+      this.viewer_.whenFirstVisible().then(() => {\n+        docVisibleTime = timer.now();\n+      });\n+    }\n+\n+    this.docState_.onReady(() => {\n+      // We need to add a delay, since this can execute earlier\n+      // than the machinery inside the `Resources` class finds any work\n+      // to do.\n+      // Another solution would be to make `getResourcesInViewport` async.\n+      timer.delay(() => {\n+        all(this.resources_.getResourcesInViewport().map((r) => {\n+          return r.whenFirstLayoutComplete();\n+        })).then(() => {\n+          // If it didnt start in prerender, no need to calculate anything\n+          // and we just need to tick `pc`. (it will give us the relative\n+          // time since the viewer initialized the timer)\n+          if (!didStartInPrerender) {","path":"src/performance.js","position":null,"original_position":70,"commit_id":"54a685ce26c06c910a5b13b7fa6f5ba50d19810c","original_commit_id":"fe2a512dcbb7b8d6885c6987100c93084ab9231a","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"done. :+1: ","created_at":"2016-01-22T20:07:09Z","updated_at":"2016-01-22T20:07:09Z","html_url":"https://github.com/ampproject/amphtml/pull/1400#discussion_r50584326","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1400","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/50584326"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1400#discussion_r50584326"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1400"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/1400","id":55815922,"html_url":"https://github.com/ampproject/amphtml/pull/1400","diff_url":"https://github.com/ampproject/amphtml/pull/1400.diff","patch_url":"https://github.com/ampproject/amphtml/pull/1400.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1400","number":1400,"state":"open","locked":false,"title":"add new instrumentation ticks","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"partially fulfills https://github.com/ampproject/amphtml/issues/918 (1, 2, 3)","created_at":"2016-01-12T20:58:57Z","updated_at":"2016-01-22T20:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1914ba2a504c60f82ec42f5f555511eacaacc0ab","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1400/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1400/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1400/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/54a685ce26c06c910a5b13b7fa6f5ba50d19810c","head":{"label":"erwinmombay:new-ticks","ref":"new-ticks","sha":"54a685ce26c06c910a5b13b7fa6f5ba50d19810c","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"repo":{"id":43843790,"name":"amphtml","full_name":"erwinmombay/amphtml","owner":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erwinmombay/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/erwinmombay/amphtml","forks_url":"https://api.github.com/repos/erwinmombay/amphtml/forks","keys_url":"https://api.github.com/repos/erwinmombay/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erwinmombay/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erwinmombay/amphtml/teams","hooks_url":"https://api.github.com/repos/erwinmombay/amphtml/hooks","issue_events_url":"https://api.github.com/repos/erwinmombay/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/erwinmombay/amphtml/events","assignees_url":"https://api.github.com/repos/erwinmombay/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/erwinmombay/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/erwinmombay/amphtml/tags","blobs_url":"https://api.github.com/repos/erwinmombay/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erwinmombay/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erwinmombay/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/erwinmombay/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erwinmombay/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/erwinmombay/amphtml/languages","stargazers_url":"https://api.github.com/repos/erwinmombay/amphtml/stargazers","contributors_url":"https://api.github.com/repos/erwinmombay/amphtml/contributors","subscribers_url":"https://api.github.com/repos/erwinmombay/amphtml/subscribers","subscription_url":"https://api.github.com/repos/erwinmombay/amphtml/subscription","commits_url":"https://api.github.com/repos/erwinmombay/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/erwinmombay/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/erwinmombay/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/erwinmombay/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/erwinmombay/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/erwinmombay/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erwinmombay/amphtml/merges","archive_url":"https://api.github.com/repos/erwinmombay/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erwinmombay/amphtml/downloads","issues_url":"https://api.github.com/repos/erwinmombay/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/erwinmombay/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/erwinmombay/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/erwinmombay/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erwinmombay/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/erwinmombay/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/erwinmombay/amphtml/deployments","created_at":"2015-10-07T20:45:56Z","updated_at":"2015-10-07T20:45:57Z","pushed_at":"2016-01-22T20:06:41Z","git_url":"git://github.com/erwinmombay/amphtml.git","ssh_url":"git@github.com:erwinmombay/amphtml.git","clone_url":"https://github.com/erwinmombay/amphtml.git","svn_url":"https://github.com/erwinmombay/amphtml","homepage":"","size":20532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"8653046d4ddf01f1fd717ac7121a8c90f7dd9f93","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-01-22T19:59:08Z","pushed_at":"2016-01-22T20:06:42Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":22417,"stargazers_count":5460,"watchers_count":5460,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":545,"mirror_url":null,"open_issues_count":266,"forks":545,"open_issues":266,"watchers":5460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1400"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1400"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1400"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1400/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1400/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1400/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/54a685ce26c06c910a5b13b7fa6f5ba50d19810c"}}}}