{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/73730125","id":73730125,"diff_hunk":"@@ -641,21 +641,27 @@\n     var array;\n     try {\n         array = new type(null);\n-        testFailed(\"Construction of \" + name + \" with null buffer should throw exception\");\n+        assertEq(\"Length of \" + name + \" constructed with null\", 0, array.length);\n+        testPassed(\"Construction of \" + name + \" with null produced a \" + name + \"of length 0\");\n     } catch (e) {\n-        testPassed(\"Construction of \" + name + \" with null buffer threw exception\");\n+        // This used to be correct, but TC39 has changed the behavior of these constructors.\n+        testPassed(\"Construction of \" + name + \" with null threw exception\");\n     }\n     try {\n         array = new type(null, 0, 0);\n-        testFailed(\"Construction of \" + name + \" with (null buffer, 0) should throw exception\");\n+        assertEq(\"Length of \" + name + \" constructed with null\", 0, array.length);\n+        testPassed(\"Construction of \" + name + \" with null produced a \" + name + \"of length 0\");\n     } catch (e) {\n-        testPassed(\"Construction of \" + name + \" with (null buffer, 0) threw exception\");\n+        // This used to be correct, but TC39 has changed the behavior of these constructors.\n+        testPassed(\"Construction of \" + name + \" with (null, 0) threw exception\");","path":"sdk/tests/conformance/typedarrays/array-unit-tests.html","position":20,"original_position":20,"commit_id":"de58bd29b6877b5257a5d908f8eb46d31e52cdd3","original_commit_id":"de58bd29b6877b5257a5d908f8eb46d31e52cdd3","user":{"login":"bterlson","id":11236,"avatar_url":"https://avatars.githubusercontent.com/u/11236?v=3","gravatar_id":"","url":"https://api.github.com/users/bterlson","html_url":"https://github.com/bterlson","followers_url":"https://api.github.com/users/bterlson/followers","following_url":"https://api.github.com/users/bterlson/following{/other_user}","gists_url":"https://api.github.com/users/bterlson/gists{/gist_id}","starred_url":"https://api.github.com/users/bterlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bterlson/subscriptions","organizations_url":"https://api.github.com/users/bterlson/orgs","repos_url":"https://api.github.com/users/bterlson/repos","events_url":"https://api.github.com/users/bterlson/events{/privacy}","received_events_url":"https://api.github.com/users/bterlson/received_events","type":"User","site_admin":false},"body":"`with (null, 0)` doesn't seem to match line 651?","created_at":"2016-08-05T17:34:38Z","updated_at":"2016-08-05T17:34:38Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1947#discussion_r73730125","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/73730125"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1947#discussion_r73730125"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947","id":79658843,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1947","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1947.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1947.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1947","number":1947,"state":"open","locked":false,"title":"Update tests for recent ECMAScript changes","user":{"login":"bakkot","id":1653598,"avatar_url":"https://avatars.githubusercontent.com/u/1653598?v=3","gravatar_id":"","url":"https://api.github.com/users/bakkot","html_url":"https://github.com/bakkot","followers_url":"https://api.github.com/users/bakkot/followers","following_url":"https://api.github.com/users/bakkot/following{/other_user}","gists_url":"https://api.github.com/users/bakkot/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkot/subscriptions","organizations_url":"https://api.github.com/users/bakkot/orgs","repos_url":"https://api.github.com/users/bakkot/repos","events_url":"https://api.github.com/users/bakkot/events{/privacy}","received_events_url":"https://api.github.com/users/bakkot/received_events","type":"User","site_admin":false},"body":"Several tests are making outdated assertions about various TypedArray and DataView related functions. Their behavior was changed by TC39 [recently](https://github.com/tc39/ecma262/pull/410).\r\n\r\nThis PR amends those tests so that either the old or new behavior is accepted. I'm not sure if there's a way to officially mark one behavior as deprecated. This PR doesn't update the snapshots, just the tests under sdk/.\r\n\r\nPing @kenrussell; we discussed this briefly over email a while ago. @littledan @leobalter","created_at":"2016-08-02T00:25:22Z","updated_at":"2016-08-05T17:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3e8f0f579dfc2503a12530682f9b568e3229e48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1947/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/de58bd29b6877b5257a5d908f8eb46d31e52cdd3","head":{"label":"bakkot:ecmascript-changes","ref":"ecmascript-changes","sha":"de58bd29b6877b5257a5d908f8eb46d31e52cdd3","user":{"login":"bakkot","id":1653598,"avatar_url":"https://avatars.githubusercontent.com/u/1653598?v=3","gravatar_id":"","url":"https://api.github.com/users/bakkot","html_url":"https://github.com/bakkot","followers_url":"https://api.github.com/users/bakkot/followers","following_url":"https://api.github.com/users/bakkot/following{/other_user}","gists_url":"https://api.github.com/users/bakkot/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkot/subscriptions","organizations_url":"https://api.github.com/users/bakkot/orgs","repos_url":"https://api.github.com/users/bakkot/repos","events_url":"https://api.github.com/users/bakkot/events{/privacy}","received_events_url":"https://api.github.com/users/bakkot/received_events","type":"User","site_admin":false},"repo":{"id":64687450,"name":"WebGL","full_name":"bakkot/WebGL","owner":{"login":"bakkot","id":1653598,"avatar_url":"https://avatars.githubusercontent.com/u/1653598?v=3","gravatar_id":"","url":"https://api.github.com/users/bakkot","html_url":"https://github.com/bakkot","followers_url":"https://api.github.com/users/bakkot/followers","following_url":"https://api.github.com/users/bakkot/following{/other_user}","gists_url":"https://api.github.com/users/bakkot/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkot/subscriptions","organizations_url":"https://api.github.com/users/bakkot/orgs","repos_url":"https://api.github.com/users/bakkot/repos","events_url":"https://api.github.com/users/bakkot/events{/privacy}","received_events_url":"https://api.github.com/users/bakkot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bakkot/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/bakkot/WebGL","forks_url":"https://api.github.com/repos/bakkot/WebGL/forks","keys_url":"https://api.github.com/repos/bakkot/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakkot/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakkot/WebGL/teams","hooks_url":"https://api.github.com/repos/bakkot/WebGL/hooks","issue_events_url":"https://api.github.com/repos/bakkot/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/bakkot/WebGL/events","assignees_url":"https://api.github.com/repos/bakkot/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/bakkot/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/bakkot/WebGL/tags","blobs_url":"https://api.github.com/repos/bakkot/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakkot/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakkot/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakkot/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakkot/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/bakkot/WebGL/languages","stargazers_url":"https://api.github.com/repos/bakkot/WebGL/stargazers","contributors_url":"https://api.github.com/repos/bakkot/WebGL/contributors","subscribers_url":"https://api.github.com/repos/bakkot/WebGL/subscribers","subscription_url":"https://api.github.com/repos/bakkot/WebGL/subscription","commits_url":"https://api.github.com/repos/bakkot/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakkot/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakkot/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakkot/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakkot/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/bakkot/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakkot/WebGL/merges","archive_url":"https://api.github.com/repos/bakkot/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakkot/WebGL/downloads","issues_url":"https://api.github.com/repos/bakkot/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/bakkot/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/bakkot/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/bakkot/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakkot/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/bakkot/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/bakkot/WebGL/deployments","created_at":"2016-08-01T17:28:34Z","updated_at":"2016-08-01T17:28:58Z","pushed_at":"2016-08-01T23:41:45Z","git_url":"git://github.com/bakkot/WebGL.git","ssh_url":"git@github.com:bakkot/WebGL.git","clone_url":"https://github.com/bakkot/WebGL.git","svn_url":"https://github.com/bakkot/WebGL","homepage":null,"size":22517,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"049c7a6e728d17f6ee22fd7f7be6ea912114cbef","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-08-02T02:12:24Z","pushed_at":"2016-08-05T10:02:38Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29503,"stargazers_count":649,"watchers_count":649,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":76,"forks":322,"open_issues":76,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1947"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1947"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/de58bd29b6877b5257a5d908f8eb46d31e52cdd3"}}}}
{"actor":{"display_login":"bterlson"}}