{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/6709","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/6709/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6709/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/6709/events","html_url":"https://github.com/nodejs/node/pull/6709","id":154405120,"number":6709,"title":"test: remove common.getServiceName()","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dns","name":"dns","color":"fbca04"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-12T06:13:27Z","updated_at":"2016-05-12T07:44:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6709","html_url":"https://github.com/nodejs/node/pull/6709","diff_url":"https://github.com/nodejs/node/pull/6709.diff","patch_url":"https://github.com/nodejs/node/pull/6709.patch"},"body":"<!--\r\nThank you for submitting a pull request to Node.js. Before you submit, please\r\nreview below requirements and walk through the checklist. You can 'tick'\r\na box by using the letter \"x\": [x].\r\n\r\nRun the test suite by invoking: `make -j4 lint test` on linux or\r\n`vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. Finally – if possible – a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\ntest dns\r\n\r\n##### Description of change\r\n\r\n<!-- provide a description of the change below this comment -->\r\n\r\nReplace lightly-used services file parsing in favor of\r\nconfirming one of a small number of allowable values in service name\r\nlookup tests.\r\n\r\nIn https://github.com/nodejs/node-v0.x-archive/issues/8047, it was\r\ndecided that this sort of service file parsing was superior to\r\nhardcoding acceptable values, but I'm not convinced:\r\n\r\n* No guarantee that the host uses /etc/services before, e.g., nscd.\r\n* Increases complexity of tests without guaranteeing robustness.\r\n\r\nI think that simply checking against a small set of expected values\r\nmay be a better solution. Ideally, there would also be a unit test that\r\nused a test double for the appropriate `cares` function and confirms\r\nthat it is called with the correct parameters, but now we're getting way\r\nahead of ourselves.\r\n\r\n@nodejs/test @nodejs/build @misterdjules "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/218683731","html_url":"https://github.com/nodejs/node/pull/6709#issuecomment-218683731","issue_url":"https://api.github.com/repos/nodejs/node/issues/6709","id":218683731,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T07:44:45Z","updated_at":"2016-05-12T07:44:45Z","body":"LGTM"}}