{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/872","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/872/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/872/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/872/events","html_url":"https://github.com/Microsoft/visualfsharp/pull/872","id":126495740,"number":872,"title":"[WIP] Migrate \"fsharpqa\" suite to use NUnit","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"labels":[{"id":197650126,"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-01-13T19:34:17Z","updated_at":"2016-11-08T17:25:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/872","html_url":"https://github.com/Microsoft/visualfsharp/pull/872","diff_url":"https://github.com/Microsoft/visualfsharp/pull/872.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/872.patch"},"body":"Use nunit instead of perl to run `tests\\fsharpqa` suite ( ref #697 )\n\nsome tests are missing, other fails, but the `tests\\fsharpqa\\Source\\run.pl` script is pretty much converted from perl to f#\n\nfsharpqa tests is only a single script, so fixing the `runpl` method, should make it pass all\n\nSome notes:\n- nunit 3\n- same configuration of cambridge suite ( path executables like fsc, fsi etc ), it's the same code :smile: \n- can be run in parallel with old perl runner, so easier to check migration\n- test runs in parallel by directory ( like cambridge )\n- test can be run/debugged inside visual studio test runner\n\ni'll implement only what's used now by fsharpqa test.\nFor example syntax like `//# Expects: success : text` it's not used => not implemented. \nOnly xml like `<Expect status=\"success\" ></Expect>` syntax is supported\n\nWhen possible i'll fix test spec instead of use a more forgiving parser. That's because code is more clean, and it's easier to spot bug in the parser/script\nAn example is the attribute `status`, was case insensitive, now is required lowercase.\nI'll change tests like that with `FIX TEST SPEC` commit message ( like a86bb3b or a86bb3b ).\n\ncomment/code with \"not implemented\" mean it's going to be fixed\n\"not supported\" mean i checked fsharpqa sources and it's unused => not going to implement it\n\nHosted compiler will be the last, because i think run in parallel by directory can be fast enough, so maybe it's not needed\n\n@KevinRansom @otawfik-ms the internal bat script set some special env var before call runall? for example `X_SKIPFULLDIAGCHECK` or others like that? \nsome stuff are useless, like `VISTA_ONLY`\nsome dont know, like `SIMULATOR_PIPE`, it' a test helper?\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/259201696","html_url":"https://github.com/Microsoft/visualfsharp/pull/872#issuecomment-259201696","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/872","id":259201696,"user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T17:25:48Z","updated_at":"2016-11-08T17:25:48Z","body":"@KevinRansom no, is not dead, just a bit sleepy 😄 thx for ping\r\n\r\ni think next week after the mvpsummit i'll start back on working on the tests pr (this one, fsharp suite and remove bat), because i got amazing help from community about .net core, so i have lots more of free time.\r\n\r\njust leave this open open for a bit more "}}
{"actor":{"display_login":"enricosada"}}