{"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/88536622","pull_request_review_id":9101387,"id":88536622,"diff_hunk":"@@ -70,6 +70,8 @@ export class ServerListPage {\n       console.debug('Pressed Add Button');\n       this.pressAddServer();\n     };\n+\n+    this.servers.onServer(this.addServer).restore();","path":"src/cca/ui_components/server_list.ts","position":5,"original_position":5,"commit_id":"150224bbd6b226ffce8b8dc9c86d9f9ded63a274","original_commit_id":"150224bbd6b226ffce8b8dc9c86d9f9ded63a274","user":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"body":"Why do you need a listener for a new server? Is there another way to add a server?\r\n\r\nI'd suggest this constructor get a list of servers from `servers` and add them to the UI here.","created_at":"2016-11-17T20:12:13Z","updated_at":"2016-11-17T20:12:13Z","html_url":"https://github.com/uProxy/uproxy/pull/2808#discussion_r88536622","pull_request_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2808","_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/88536622"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2808#discussion_r88536622"},"pull_request":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2808"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/2808","id":94220444,"html_url":"https://github.com/uProxy/uproxy/pull/2808","diff_url":"https://github.com/uProxy/uproxy/pull/2808.diff","patch_url":"https://github.com/uProxy/uproxy/pull/2808.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/2808","number":2808,"state":"open","locked":false,"title":"save contacts to HTML5 localStorage","user":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"body":"Still in draft but it seems to work:\r\n* saved contacts to HTML5 localStorage (same format as the cloud social provider)\r\n* to avoid nasty race conditions, `UproxyServerRepository` should be created with a core that has logged into social networks\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/2808)\n<!-- Reviewable:end -->\n","created_at":"2016-11-17T18:11:21Z","updated_at":"2016-11-17T20:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63327e52ae3a7c43613bca1035ad19423f73a7d8","assignee":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"assignees":[{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2808/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2808/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/2808/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/150224bbd6b226ffce8b8dc9c86d9f9ded63a274","head":{"label":"uProxy:trevj-air-save-servers","ref":"trevj-air-save-servers","sha":"150224bbd6b226ffce8b8dc9c86d9f9ded63a274","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Internet without borders","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/uproxy/deployments","created_at":"2014-04-07T20:34:40Z","updated_at":"2016-11-16T23:22:12Z","pushed_at":"2016-11-17T19:35:41Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":29066,"stargazers_count":461,"watchers_count":461,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":65,"forks":111,"open_issues":65,"watchers":461,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"2f85179d310a132b83523c9cb6bd2d68cd5df60a","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Internet without borders","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/uproxy/deployments","created_at":"2014-04-07T20:34:40Z","updated_at":"2016-11-16T23:22:12Z","pushed_at":"2016-11-17T19:35:41Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":29066,"stargazers_count":461,"watchers_count":461,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":65,"forks":111,"open_issues":65,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2808"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2808"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2808"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2808/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2808/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2808/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/150224bbd6b226ffce8b8dc9c86d9f9ded63a274"}}}}
{"actor":{"display_login":"fortuna"}}