{"action":"created","comment":{"url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/comments/91996124","pull_request_review_id":12505727,"id":91996124,"diff_hunk":"@@ -17,7 +17,7 @@ router.get('/', (req, res, next) => {\n     .findAllByAccountId(accountId)\n     .then((sortedActivities) => {\n       res.render('unsorted-activities', Object.assign({ accountId },\n-        new ActivityView(getUnsortedActivityNames(sortedActivities))));\n+        new ActivityModel(getUnsortedActivities(sortedActivities))));","path":"app/controllers/unsorted-activities-controller.js","position":20,"original_position":20,"commit_id":"e4be1a3ee5a736027c6a70578c1bf6131b2a1e68","original_commit_id":"e4be1a3ee5a736027c6a70578c1bf6131b2a1e68","user":{"login":"nathancashmoredwp","id":16591284,"avatar_url":"https://avatars.githubusercontent.com/u/16591284?v=3","gravatar_id":"","url":"https://api.github.com/users/nathancashmoredwp","html_url":"https://github.com/nathancashmoredwp","followers_url":"https://api.github.com/users/nathancashmoredwp/followers","following_url":"https://api.github.com/users/nathancashmoredwp/following{/other_user}","gists_url":"https://api.github.com/users/nathancashmoredwp/gists{/gist_id}","starred_url":"https://api.github.com/users/nathancashmoredwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathancashmoredwp/subscriptions","organizations_url":"https://api.github.com/users/nathancashmoredwp/orgs","repos_url":"https://api.github.com/users/nathancashmoredwp/repos","events_url":"https://api.github.com/users/nathancashmoredwp/events{/privacy}","received_events_url":"https://api.github.com/users/nathancashmoredwp/received_events","type":"User","site_admin":false},"body":"Not sure about ActivityModel as a name... for consistency if its ActivityModel I associate it with an extension of db.Model.  In this instance i still think View as a term should still be included somehow as that is still the intended purpose of this model ?","created_at":"2016-12-12T17:27:52Z","updated_at":"2016-12-12T17:39:37Z","html_url":"https://github.com/lm-tools/choose-your-activities/pull/12#discussion_r91996124","pull_request_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/comments/91996124"},"html":{"href":"https://github.com/lm-tools/choose-your-activities/pull/12#discussion_r91996124"},"pull_request":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12","id":97589174,"html_url":"https://github.com/lm-tools/choose-your-activities/pull/12","diff_url":"https://github.com/lm-tools/choose-your-activities/pull/12.diff","patch_url":"https://github.com/lm-tools/choose-your-activities/pull/12.patch","issue_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/12","number":12,"state":"open","locked":false,"title":"Make unsorted activities model similar to sorted","user":{"login":"lukasz-kaniowski","id":174123,"avatar_url":"https://avatars.githubusercontent.com/u/174123?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasz-kaniowski","html_url":"https://github.com/lukasz-kaniowski","followers_url":"https://api.github.com/users/lukasz-kaniowski/followers","following_url":"https://api.github.com/users/lukasz-kaniowski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-kaniowski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-kaniowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-kaniowski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-kaniowski/orgs","repos_url":"https://api.github.com/users/lukasz-kaniowski/repos","events_url":"https://api.github.com/users/lukasz-kaniowski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-kaniowski/received_events","type":"User","site_admin":false},"body":"- Instead of using only names for unsorted activities this change is representing model in similar way as sorted activities.\n- Adds tests to check for title and url on the unsorted activities page","created_at":"2016-12-12T16:47:32Z","updated_at":"2016-12-12T17:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09289300fa587cb0d0ec775ee5e52a6c1b6d37a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12/commits","review_comments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12/comments","review_comment_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/12/comments","statuses_url":"https://api.github.com/repos/lm-tools/choose-your-activities/statuses/e4be1a3ee5a736027c6a70578c1bf6131b2a1e68","head":{"label":"lm-tools:sorted-unsorted-activities-model","ref":"sorted-unsorted-activities-model","sha":"e4be1a3ee5a736027c6a70578c1bf6131b2a1e68","user":{"login":"lm-tools","id":12998430,"avatar_url":"https://avatars.githubusercontent.com/u/12998430?v=3","gravatar_id":"","url":"https://api.github.com/users/lm-tools","html_url":"https://github.com/lm-tools","followers_url":"https://api.github.com/users/lm-tools/followers","following_url":"https://api.github.com/users/lm-tools/following{/other_user}","gists_url":"https://api.github.com/users/lm-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/lm-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lm-tools/subscriptions","organizations_url":"https://api.github.com/users/lm-tools/orgs","repos_url":"https://api.github.com/users/lm-tools/repos","events_url":"https://api.github.com/users/lm-tools/events{/privacy}","received_events_url":"https://api.github.com/users/lm-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":75070443,"name":"choose-your-activities","full_name":"lm-tools/choose-your-activities","owner":{"login":"lm-tools","id":12998430,"avatar_url":"https://avatars.githubusercontent.com/u/12998430?v=3","gravatar_id":"","url":"https://api.github.com/users/lm-tools","html_url":"https://github.com/lm-tools","followers_url":"https://api.github.com/users/lm-tools/followers","following_url":"https://api.github.com/users/lm-tools/following{/other_user}","gists_url":"https://api.github.com/users/lm-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/lm-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lm-tools/subscriptions","organizations_url":"https://api.github.com/users/lm-tools/orgs","repos_url":"https://api.github.com/users/lm-tools/repos","events_url":"https://api.github.com/users/lm-tools/events{/privacy}","received_events_url":"https://api.github.com/users/lm-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lm-tools/choose-your-activities","description":null,"fork":false,"url":"https://api.github.com/repos/lm-tools/choose-your-activities","forks_url":"https://api.github.com/repos/lm-tools/choose-your-activities/forks","keys_url":"https://api.github.com/repos/lm-tools/choose-your-activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lm-tools/choose-your-activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lm-tools/choose-your-activities/teams","hooks_url":"https://api.github.com/repos/lm-tools/choose-your-activities/hooks","issue_events_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/events{/number}","events_url":"https://api.github.com/repos/lm-tools/choose-your-activities/events","assignees_url":"https://api.github.com/repos/lm-tools/choose-your-activities/assignees{/user}","branches_url":"https://api.github.com/repos/lm-tools/choose-your-activities/branches{/branch}","tags_url":"https://api.github.com/repos/lm-tools/choose-your-activities/tags","blobs_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lm-tools/choose-your-activities/statuses/{sha}","languages_url":"https://api.github.com/repos/lm-tools/choose-your-activities/languages","stargazers_url":"https://api.github.com/repos/lm-tools/choose-your-activities/stargazers","contributors_url":"https://api.github.com/repos/lm-tools/choose-your-activities/contributors","subscribers_url":"https://api.github.com/repos/lm-tools/choose-your-activities/subscribers","subscription_url":"https://api.github.com/repos/lm-tools/choose-your-activities/subscription","commits_url":"https://api.github.com/repos/lm-tools/choose-your-activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/lm-tools/choose-your-activities/contents/{+path}","compare_url":"https://api.github.com/repos/lm-tools/choose-your-activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lm-tools/choose-your-activities/merges","archive_url":"https://api.github.com/repos/lm-tools/choose-your-activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lm-tools/choose-your-activities/downloads","issues_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues{/number}","pulls_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls{/number}","milestones_url":"https://api.github.com/repos/lm-tools/choose-your-activities/milestones{/number}","notifications_url":"https://api.github.com/repos/lm-tools/choose-your-activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lm-tools/choose-your-activities/labels{/name}","releases_url":"https://api.github.com/repos/lm-tools/choose-your-activities/releases{/id}","deployments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/deployments","created_at":"2016-11-29T10:29:56Z","updated_at":"2016-11-29T10:30:16Z","pushed_at":"2016-12-12T16:47:32Z","git_url":"git://github.com/lm-tools/choose-your-activities.git","ssh_url":"git@github.com:lm-tools/choose-your-activities.git","clone_url":"https://github.com/lm-tools/choose-your-activities.git","svn_url":"https://github.com/lm-tools/choose-your-activities","homepage":null,"size":632,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lm-tools:master","ref":"master","sha":"1e3ff08c29872b38f31570525f95cf48fcecb5c5","user":{"login":"lm-tools","id":12998430,"avatar_url":"https://avatars.githubusercontent.com/u/12998430?v=3","gravatar_id":"","url":"https://api.github.com/users/lm-tools","html_url":"https://github.com/lm-tools","followers_url":"https://api.github.com/users/lm-tools/followers","following_url":"https://api.github.com/users/lm-tools/following{/other_user}","gists_url":"https://api.github.com/users/lm-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/lm-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lm-tools/subscriptions","organizations_url":"https://api.github.com/users/lm-tools/orgs","repos_url":"https://api.github.com/users/lm-tools/repos","events_url":"https://api.github.com/users/lm-tools/events{/privacy}","received_events_url":"https://api.github.com/users/lm-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":75070443,"name":"choose-your-activities","full_name":"lm-tools/choose-your-activities","owner":{"login":"lm-tools","id":12998430,"avatar_url":"https://avatars.githubusercontent.com/u/12998430?v=3","gravatar_id":"","url":"https://api.github.com/users/lm-tools","html_url":"https://github.com/lm-tools","followers_url":"https://api.github.com/users/lm-tools/followers","following_url":"https://api.github.com/users/lm-tools/following{/other_user}","gists_url":"https://api.github.com/users/lm-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/lm-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lm-tools/subscriptions","organizations_url":"https://api.github.com/users/lm-tools/orgs","repos_url":"https://api.github.com/users/lm-tools/repos","events_url":"https://api.github.com/users/lm-tools/events{/privacy}","received_events_url":"https://api.github.com/users/lm-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lm-tools/choose-your-activities","description":null,"fork":false,"url":"https://api.github.com/repos/lm-tools/choose-your-activities","forks_url":"https://api.github.com/repos/lm-tools/choose-your-activities/forks","keys_url":"https://api.github.com/repos/lm-tools/choose-your-activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lm-tools/choose-your-activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lm-tools/choose-your-activities/teams","hooks_url":"https://api.github.com/repos/lm-tools/choose-your-activities/hooks","issue_events_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/events{/number}","events_url":"https://api.github.com/repos/lm-tools/choose-your-activities/events","assignees_url":"https://api.github.com/repos/lm-tools/choose-your-activities/assignees{/user}","branches_url":"https://api.github.com/repos/lm-tools/choose-your-activities/branches{/branch}","tags_url":"https://api.github.com/repos/lm-tools/choose-your-activities/tags","blobs_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lm-tools/choose-your-activities/statuses/{sha}","languages_url":"https://api.github.com/repos/lm-tools/choose-your-activities/languages","stargazers_url":"https://api.github.com/repos/lm-tools/choose-your-activities/stargazers","contributors_url":"https://api.github.com/repos/lm-tools/choose-your-activities/contributors","subscribers_url":"https://api.github.com/repos/lm-tools/choose-your-activities/subscribers","subscription_url":"https://api.github.com/repos/lm-tools/choose-your-activities/subscription","commits_url":"https://api.github.com/repos/lm-tools/choose-your-activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/lm-tools/choose-your-activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/lm-tools/choose-your-activities/contents/{+path}","compare_url":"https://api.github.com/repos/lm-tools/choose-your-activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lm-tools/choose-your-activities/merges","archive_url":"https://api.github.com/repos/lm-tools/choose-your-activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lm-tools/choose-your-activities/downloads","issues_url":"https://api.github.com/repos/lm-tools/choose-your-activities/issues{/number}","pulls_url":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls{/number}","milestones_url":"https://api.github.com/repos/lm-tools/choose-your-activities/milestones{/number}","notifications_url":"https://api.github.com/repos/lm-tools/choose-your-activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lm-tools/choose-your-activities/labels{/name}","releases_url":"https://api.github.com/repos/lm-tools/choose-your-activities/releases{/id}","deployments_url":"https://api.github.com/repos/lm-tools/choose-your-activities/deployments","created_at":"2016-11-29T10:29:56Z","updated_at":"2016-11-29T10:30:16Z","pushed_at":"2016-12-12T16:47:32Z","git_url":"git://github.com/lm-tools/choose-your-activities.git","ssh_url":"git@github.com:lm-tools/choose-your-activities.git","clone_url":"https://github.com/lm-tools/choose-your-activities.git","svn_url":"https://github.com/lm-tools/choose-your-activities","homepage":null,"size":632,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12"},"html":{"href":"https://github.com/lm-tools/choose-your-activities/pull/12"},"issue":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/12"},"comments":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/lm-tools/choose-your-activities/statuses/e4be1a3ee5a736027c6a70578c1bf6131b2a1e68"}}}}
{"actor":{"display_login":"nathancashmoredwp"}}