{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/jasp00/signTextJS/pulls/3","id":95399965,"html_url":"https://github.com/jasp00/signTextJS/pull/3","diff_url":"https://github.com/jasp00/signTextJS/pull/3.diff","patch_url":"https://github.com/jasp00/signTextJS/pull/3.patch","issue_url":"https://api.github.com/repos/jasp00/signTextJS/issues/3","number":3,"state":"open","locked":false,"title":"fix Electrolysis  - don't merge in master yet, it is just a proposal","user":{"login":"sharapanoff","id":10178310,"avatar_url":"https://avatars.githubusercontent.com/u/10178310?v=3","gravatar_id":"","url":"https://api.github.com/users/sharapanoff","html_url":"https://github.com/sharapanoff","followers_url":"https://api.github.com/users/sharapanoff/followers","following_url":"https://api.github.com/users/sharapanoff/following{/other_user}","gists_url":"https://api.github.com/users/sharapanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sharapanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharapanoff/subscriptions","organizations_url":"https://api.github.com/users/sharapanoff/orgs","repos_url":"https://api.github.com/users/sharapanoff/repos","events_url":"https://api.github.com/users/sharapanoff/events{/privacy}","received_events_url":"https://api.github.com/users/sharapanoff/received_events","type":"User","site_admin":false},"body":"due to [Electrolysis](https://blog.mozilla.org/addons/2016/04/11/the-why-of-electrolysis/)  the addon is not working in ff51 and newer (these version are still test versions)\r\nsee second part of issue #1 \r\n\r\n## workaround\r\nset **Enable multi-process** in setting to **OFF**\r\n\r\n## Proposed fix\r\ncan be download from [here](https://github.com/sharapanoff/signTextJS/releases/download/v0.0.2/signtextjsplus_fix_e10s-0.0.1-fx.xpi) to see what is the user experience - it works but it is not user friendly\r\n\r\n### Changes:\r\n* split the code into content-script and addon-script\r\n* the content-script injects page-script via SCRIPT element\r\n\r\n### Workflow:\r\n* page calls its **signText**\r\n    * signText in the page-script is called\r\n   * calls signTextAsync\r\n     * sends a message to the content-script - **signText_msg_PageCallsSignText**\r\n     * returns a promise\r\n   * adds callback function to the promise, to receive the result\r\n   * blocks the calling thread by ALERT\r\n* the content-script sends a message to the addon-script - **signText_msg_ContentCallsSignText**\r\n* the addon-script \r\n  * calls its **signText** \r\n  * sends a result message to the content-script- **signText_msg_AddonReturnsSignTextResult**\r\n* the content-script sends a result message to the page-script- **signText_msg_ContentReturnsSignTextResult**\r\n* the page-script receives the result and resolves the promise\r\n* user unblocks the calling thread by closing the alert\r\n*  **signText** returns the result\r\n\r\n\r\n### TODO\r\nremove the call to **alert** - there must be other way to block the calling thread","created_at":"2016-11-27T11:34:35Z","updated_at":"2016-11-27T11:34:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jasp00/signTextJS/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jasp00/signTextJS/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jasp00/signTextJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasp00/signTextJS/issues/3/comments","statuses_url":"https://api.github.com/repos/jasp00/signTextJS/statuses/cdb43afbdb45fc8fa2475d8caefa1a355d041d04","head":{"label":"sharapanoff:jasp00_signTextJs_e10s","ref":"jasp00_signTextJs_e10s","sha":"cdb43afbdb45fc8fa2475d8caefa1a355d041d04","user":{"login":"sharapanoff","id":10178310,"avatar_url":"https://avatars.githubusercontent.com/u/10178310?v=3","gravatar_id":"","url":"https://api.github.com/users/sharapanoff","html_url":"https://github.com/sharapanoff","followers_url":"https://api.github.com/users/sharapanoff/followers","following_url":"https://api.github.com/users/sharapanoff/following{/other_user}","gists_url":"https://api.github.com/users/sharapanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sharapanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharapanoff/subscriptions","organizations_url":"https://api.github.com/users/sharapanoff/orgs","repos_url":"https://api.github.com/users/sharapanoff/repos","events_url":"https://api.github.com/users/sharapanoff/events{/privacy}","received_events_url":"https://api.github.com/users/sharapanoff/received_events","type":"User","site_admin":false},"repo":{"id":72863712,"name":"signTextJS","full_name":"sharapanoff/signTextJS","owner":{"login":"sharapanoff","id":10178310,"avatar_url":"https://avatars.githubusercontent.com/u/10178310?v=3","gravatar_id":"","url":"https://api.github.com/users/sharapanoff","html_url":"https://github.com/sharapanoff","followers_url":"https://api.github.com/users/sharapanoff/followers","following_url":"https://api.github.com/users/sharapanoff/following{/other_user}","gists_url":"https://api.github.com/users/sharapanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sharapanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharapanoff/subscriptions","organizations_url":"https://api.github.com/users/sharapanoff/orgs","repos_url":"https://api.github.com/users/sharapanoff/repos","events_url":"https://api.github.com/users/sharapanoff/events{/privacy}","received_events_url":"https://api.github.com/users/sharapanoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharapanoff/signTextJS","description":"fixes of firefox addons which implement window.crypto.signText ","fork":true,"url":"https://api.github.com/repos/sharapanoff/signTextJS","forks_url":"https://api.github.com/repos/sharapanoff/signTextJS/forks","keys_url":"https://api.github.com/repos/sharapanoff/signTextJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharapanoff/signTextJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharapanoff/signTextJS/teams","hooks_url":"https://api.github.com/repos/sharapanoff/signTextJS/hooks","issue_events_url":"https://api.github.com/repos/sharapanoff/signTextJS/issues/events{/number}","events_url":"https://api.github.com/repos/sharapanoff/signTextJS/events","assignees_url":"https://api.github.com/repos/sharapanoff/signTextJS/assignees{/user}","branches_url":"https://api.github.com/repos/sharapanoff/signTextJS/branches{/branch}","tags_url":"https://api.github.com/repos/sharapanoff/signTextJS/tags","blobs_url":"https://api.github.com/repos/sharapanoff/signTextJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharapanoff/signTextJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharapanoff/signTextJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharapanoff/signTextJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharapanoff/signTextJS/statuses/{sha}","languages_url":"https://api.github.com/repos/sharapanoff/signTextJS/languages","stargazers_url":"https://api.github.com/repos/sharapanoff/signTextJS/stargazers","contributors_url":"https://api.github.com/repos/sharapanoff/signTextJS/contributors","subscribers_url":"https://api.github.com/repos/sharapanoff/signTextJS/subscribers","subscription_url":"https://api.github.com/repos/sharapanoff/signTextJS/subscription","commits_url":"https://api.github.com/repos/sharapanoff/signTextJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharapanoff/signTextJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharapanoff/signTextJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharapanoff/signTextJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharapanoff/signTextJS/contents/{+path}","compare_url":"https://api.github.com/repos/sharapanoff/signTextJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharapanoff/signTextJS/merges","archive_url":"https://api.github.com/repos/sharapanoff/signTextJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharapanoff/signTextJS/downloads","issues_url":"https://api.github.com/repos/sharapanoff/signTextJS/issues{/number}","pulls_url":"https://api.github.com/repos/sharapanoff/signTextJS/pulls{/number}","milestones_url":"https://api.github.com/repos/sharapanoff/signTextJS/milestones{/number}","notifications_url":"https://api.github.com/repos/sharapanoff/signTextJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharapanoff/signTextJS/labels{/name}","releases_url":"https://api.github.com/repos/sharapanoff/signTextJS/releases{/id}","deployments_url":"https://api.github.com/repos/sharapanoff/signTextJS/deployments","created_at":"2016-11-04T16:07:14Z","updated_at":"2016-11-17T16:37:51Z","pushed_at":"2016-11-27T10:35:10Z","git_url":"git://github.com/sharapanoff/signTextJS.git","ssh_url":"git@github.com:sharapanoff/signTextJS.git","clone_url":"https://github.com/sharapanoff/signTextJS.git","svn_url":"https://github.com/sharapanoff/signTextJS","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jasp00:master","ref":"master","sha":"0d84bd07019afeb9cd07bb852c207b363878f10e","user":{"login":"jasp00","id":6378554,"avatar_url":"https://avatars.githubusercontent.com/u/6378554?v=3","gravatar_id":"","url":"https://api.github.com/users/jasp00","html_url":"https://github.com/jasp00","followers_url":"https://api.github.com/users/jasp00/followers","following_url":"https://api.github.com/users/jasp00/following{/other_user}","gists_url":"https://api.github.com/users/jasp00/gists{/gist_id}","starred_url":"https://api.github.com/users/jasp00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasp00/subscriptions","organizations_url":"https://api.github.com/users/jasp00/orgs","repos_url":"https://api.github.com/users/jasp00/repos","events_url":"https://api.github.com/users/jasp00/events{/privacy}","received_events_url":"https://api.github.com/users/jasp00/received_events","type":"User","site_admin":false},"repo":{"id":55099752,"name":"signTextJS","full_name":"jasp00/signTextJS","owner":{"login":"jasp00","id":6378554,"avatar_url":"https://avatars.githubusercontent.com/u/6378554?v=3","gravatar_id":"","url":"https://api.github.com/users/jasp00","html_url":"https://github.com/jasp00","followers_url":"https://api.github.com/users/jasp00/followers","following_url":"https://api.github.com/users/jasp00/following{/other_user}","gists_url":"https://api.github.com/users/jasp00/gists{/gist_id}","starred_url":"https://api.github.com/users/jasp00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasp00/subscriptions","organizations_url":"https://api.github.com/users/jasp00/orgs","repos_url":"https://api.github.com/users/jasp00/repos","events_url":"https://api.github.com/users/jasp00/events{/privacy}","received_events_url":"https://api.github.com/users/jasp00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasp00/signTextJS","description":"re-implements window.crypto.signText and exposes it to content","fork":true,"url":"https://api.github.com/repos/jasp00/signTextJS","forks_url":"https://api.github.com/repos/jasp00/signTextJS/forks","keys_url":"https://api.github.com/repos/jasp00/signTextJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasp00/signTextJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasp00/signTextJS/teams","hooks_url":"https://api.github.com/repos/jasp00/signTextJS/hooks","issue_events_url":"https://api.github.com/repos/jasp00/signTextJS/issues/events{/number}","events_url":"https://api.github.com/repos/jasp00/signTextJS/events","assignees_url":"https://api.github.com/repos/jasp00/signTextJS/assignees{/user}","branches_url":"https://api.github.com/repos/jasp00/signTextJS/branches{/branch}","tags_url":"https://api.github.com/repos/jasp00/signTextJS/tags","blobs_url":"https://api.github.com/repos/jasp00/signTextJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasp00/signTextJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasp00/signTextJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasp00/signTextJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasp00/signTextJS/statuses/{sha}","languages_url":"https://api.github.com/repos/jasp00/signTextJS/languages","stargazers_url":"https://api.github.com/repos/jasp00/signTextJS/stargazers","contributors_url":"https://api.github.com/repos/jasp00/signTextJS/contributors","subscribers_url":"https://api.github.com/repos/jasp00/signTextJS/subscribers","subscription_url":"https://api.github.com/repos/jasp00/signTextJS/subscription","commits_url":"https://api.github.com/repos/jasp00/signTextJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasp00/signTextJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasp00/signTextJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasp00/signTextJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasp00/signTextJS/contents/{+path}","compare_url":"https://api.github.com/repos/jasp00/signTextJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasp00/signTextJS/merges","archive_url":"https://api.github.com/repos/jasp00/signTextJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasp00/signTextJS/downloads","issues_url":"https://api.github.com/repos/jasp00/signTextJS/issues{/number}","pulls_url":"https://api.github.com/repos/jasp00/signTextJS/pulls{/number}","milestones_url":"https://api.github.com/repos/jasp00/signTextJS/milestones{/number}","notifications_url":"https://api.github.com/repos/jasp00/signTextJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasp00/signTextJS/labels{/name}","releases_url":"https://api.github.com/repos/jasp00/signTextJS/releases{/id}","deployments_url":"https://api.github.com/repos/jasp00/signTextJS/deployments","created_at":"2016-03-30T21:40:06Z","updated_at":"2016-11-26T19:45:42Z","pushed_at":"2016-11-26T20:08:50Z","git_url":"git://github.com/jasp00/signTextJS.git","ssh_url":"git@github.com:jasp00/signTextJS.git","clone_url":"https://github.com/jasp00/signTextJS.git","svn_url":"https://github.com/jasp00/signTextJS","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasp00/signTextJS/pulls/3"},"html":{"href":"https://github.com/jasp00/signTextJS/pull/3"},"issue":{"href":"https://api.github.com/repos/jasp00/signTextJS/issues/3"},"comments":{"href":"https://api.github.com/repos/jasp00/signTextJS/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jasp00/signTextJS/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jasp00/signTextJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasp00/signTextJS/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jasp00/signTextJS/statuses/cdb43afbdb45fc8fa2475d8caefa1a355d041d04"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":16,"additions":148,"deletions":54,"changed_files":2}}
{"actor":{"display_login":"sharapanoff"}}