{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/556","repository_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/556/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/556/comments","events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/556/events","html_url":"https://github.com/Automattic/woocommerce-connect-client/issues/556","id":177506011,"number":556,"title":"Replace catch( noop ) with at least console logging in shipping-label/state/actions.js","user":{"login":"allendav","id":1595739,"avatar_url":"https://avatars.githubusercontent.com/u/1595739?v=3","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/Code%20Cleanup","name":"Code Cleanup","color":"c5d5e5"},{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/[Pri]%20High","name":"[Pri] High","color":"ec9a71"},{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/[Type]%20Bug","name":"[Type] Bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/5","html_url":"https://github.com/Automattic/woocommerce-connect-client/milestones/Sprint%206","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/5/labels","id":1813858,"number":5,"title":"Sprint 6","description":"Setting end of September as a best guess","creator":{"login":"allendav","id":1595739,"avatar_url":"https://avatars.githubusercontent.com/u/1595739?v=3","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":4,"state":"open","created_at":"2016-06-07T16:24:16Z","updated_at":"2016-09-30T00:04:31Z","due_on":"2016-10-14T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-09-16T19:48:21Z","updated_at":"2016-09-30T00:26:55Z","closed_at":null,"body":"In three places (getRates, submitAddressForNormalization and purchaseLabel) we have catch( noop ) which silently consumes exceptions (like what was happening here: https://github.com/Automattic/woocommerce-connect-client/pull/555#issuecomment-247690790 )\r\n\r\nI think we should at least be console logging the exception. Otherwise debugging and happiness will have nothing to go on other than \"I clicked the (enabled) button and nothing happens\""},"comment":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/comments/250629028","html_url":"https://github.com/Automattic/woocommerce-connect-client/issues/556#issuecomment-250629028","issue_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/556","id":250629028,"user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T00:26:55Z","updated_at":"2016-09-30T00:26:55Z","body":"> Under what circumstances is the address \"invalid\"\r\n\r\nWhen the address doesn't exist, for example `Fake Street 123, San Francisco, Alabama`.\r\n\r\n> Are you sure? Isn't that what happened here? #555 (comment)\r\n\r\nYes, but not always. Sometimes a Promise being rejected just means that the server returned an error, but it's still a normal code path and should be handled by the form UI. I'll give this another try, it's important to show errors but we shouldn't treat all errors equally :)"}}
{"actor":{"display_login":"DanReyLop"}}