{"action":"created","issue":{"url":"https://api.github.com/repos/deis/builder/issues/294","repository_url":"https://api.github.com/repos/deis/builder","labels_url":"https://api.github.com/repos/deis/builder/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/deis/builder/issues/294/comments","events_url":"https://api.github.com/repos/deis/builder/issues/294/events","html_url":"https://github.com/deis/builder/pull/294","id":147555213,"number":294,"title":"fix(pkg/git/git.go): fix blank image pull policy","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deis/builder/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/deis/builder/labels/LGTM1","name":"LGTM1","color":"009800"},{"url":"https://api.github.com/repos/deis/builder/labels/LGTM2","name":"LGTM2","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/builder/milestones/7","html_url":"https://github.com/deis/builder/milestones/v2.0-beta2","labels_url":"https://api.github.com/repos/deis/builder/milestones/7/labels","id":1682297,"number":7,"title":"v2.0-beta2","description":null,"creator":{"login":"slack","id":28873,"avatar_url":"https://avatars.githubusercontent.com/u/28873?v=3","gravatar_id":"","url":"https://api.github.com/users/slack","html_url":"https://github.com/slack","followers_url":"https://api.github.com/users/slack/followers","following_url":"https://api.github.com/users/slack/following{/other_user}","gists_url":"https://api.github.com/users/slack/gists{/gist_id}","starred_url":"https://api.github.com/users/slack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack/subscriptions","organizations_url":"https://api.github.com/users/slack/orgs","repos_url":"https://api.github.com/users/slack/repos","events_url":"https://api.github.com/users/slack/events{/privacy}","received_events_url":"https://api.github.com/users/slack/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2016-04-04T15:54:11Z","updated_at":"2016-04-11T22:37:37Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-04-11T21:07:17Z","updated_at":"2016-04-11T22:39:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/builder/pulls/294","html_url":"https://github.com/deis/builder/pull/294","diff_url":"https://github.com/deis/builder/pull/294.diff","patch_url":"https://github.com/deis/builder/pull/294.patch"},"body":"# Summary of Changes\r\n\r\nThis PR removes the environment variable declarations from the git pre-receive hook script. When any one of the environment variables is not set in the main process, it's sent into the pre-receive hook process as the empty string, and that was leading to configuration errors in the hook, which was failing builds.\r\n\r\nFor example, if `SLUG_BUILDER_IMAGE_PULL_POLICY` was empty in the main process, it would be sent to `\"\"` in the hook before this change. Then, the hook would try to convert `\"\"` to a valid pull policy, which would fail, and the entire build would fail.\r\n\r\n# Issue(s) that this PR Closes\r\n\r\nFixes #293\r\n\r\n# Associated [End To End Test](https://github.com/deis/workflow-e2e) PR(s)\r\n\r\nNone\r\n\r\n# Associated [Documentation](https://github.com/deis/docs-v2) PR(s)\r\n\r\nNone\r\n\r\n# Associated [Design Document](http://docs.deis.io/en/latest/contributing/design-documents)(s)\r\n\r\nNone\r\n\r\n# Testing Instructions\r\n\r\n1. Start a builder with no `SLUG_BUILDER_IMAGE_PULL_POLICY` or `DOCKER_BUILDER_IMAGE_PULL_POLICY` image pull policy environment variables set\r\n2. Do a `git push` with a buildpack app\r\n3. Do a `git push` with a dockerfile app\r\n\r\nThe result of both steps 2 and 3 should be a successful build, and in both cases, the appropriate image (slugbuilder and dockerbuilder, respectively) should be pulled in all cases (i.e. with `imagePullPolicy: Always`)\r\n\r\n# Pull Request Hygiene TODOs\r\n\r\nPlease make sure the below checklist is complete.\r\n\r\n- [x] Your pull request is concise and to the point (make another PR for refactoring nearby code)\r\n- [x] Your commits are squashed into logical units of work\r\n- [x] Your commits follow the [commit style guidelines](http://docs.deis.io/en/latest/contributing/standards/#commit-style-guide)"},"comment":{"url":"https://api.github.com/repos/deis/builder/issues/comments/208595263","html_url":"https://github.com/deis/builder/pull/294#issuecomment-208595263","issue_url":"https://api.github.com/repos/deis/builder/issues/294","id":208595263,"user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T22:39:03Z","updated_at":"2016-04-11T22:39:03Z","body":"The second test run has failed, and the failures look to be unrelated to this change (and this change has eliminated the failures that it intended to fix). Merging..."}}