{"action":"closed","number":1206,"pull_request":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/1206","id":92714319,"html_url":"https://github.com/ninja-build/ninja/pull/1206","diff_url":"https://github.com/ninja-build/ninja/pull/1206.diff","patch_url":"https://github.com/ninja-build/ninja/pull/1206.patch","issue_url":"https://api.github.com/repos/ninja-build/ninja/issues/1206","number":1206,"state":"closed","locked":false,"title":"windows: replace deprecated GetVersionEx with recommended replacement","user":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"body":"The recommended replacement VerifyVersionInfo should work with the same\r\nSDKs that GetVersionEx worked with (while the wrappers in\r\nVersionHelpers.h require a recent SDK).  This patch should not change\r\nbehavior, and it's not supposed to increase build requirements.  If\r\nthis makes things harder to build, please let me know.","created_at":"2016-11-08T04:42:15Z","updated_at":"2016-11-08T04:49:45Z","closed_at":"2016-11-08T04:49:45Z","merged_at":"2016-11-08T04:49:45Z","merge_commit_sha":"3082aa69b7be2a2a0607441a7a2615d78aa983d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninja-build/ninja/issues/1206/comments","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/32c82da13e2d16792c79507be3d875a6e4624423","head":{"label":"nico:versioninfo","ref":"versioninfo","sha":"32c82da13e2d16792c79507be3d875a6e4624423","user":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"repo":{"id":2751508,"name":"ninja","full_name":"nico/ninja","owner":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nico/ninja","description":"a small build system similar to make","fork":true,"url":"https://api.github.com/repos/nico/ninja","forks_url":"https://api.github.com/repos/nico/ninja/forks","keys_url":"https://api.github.com/repos/nico/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nico/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nico/ninja/teams","hooks_url":"https://api.github.com/repos/nico/ninja/hooks","issue_events_url":"https://api.github.com/repos/nico/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/nico/ninja/events","assignees_url":"https://api.github.com/repos/nico/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/nico/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/nico/ninja/tags","blobs_url":"https://api.github.com/repos/nico/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nico/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nico/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/nico/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nico/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/nico/ninja/languages","stargazers_url":"https://api.github.com/repos/nico/ninja/stargazers","contributors_url":"https://api.github.com/repos/nico/ninja/contributors","subscribers_url":"https://api.github.com/repos/nico/ninja/subscribers","subscription_url":"https://api.github.com/repos/nico/ninja/subscription","commits_url":"https://api.github.com/repos/nico/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/nico/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/nico/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/nico/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/nico/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/nico/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nico/ninja/merges","archive_url":"https://api.github.com/repos/nico/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nico/ninja/downloads","issues_url":"https://api.github.com/repos/nico/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/nico/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/nico/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/nico/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nico/ninja/labels{/name}","releases_url":"https://api.github.com/repos/nico/ninja/releases{/id}","deployments_url":"https://api.github.com/repos/nico/ninja/deployments","created_at":"2011-11-10T20:39:52Z","updated_at":"2015-05-02T21:38:59Z","pushed_at":"2016-11-08T04:39:23Z","git_url":"git://github.com/nico/ninja.git","ssh_url":"git@github.com:nico/ninja.git","clone_url":"https://github.com/nico/ninja.git","svn_url":"https://github.com/nico/ninja","homepage":"http://martine.github.com/ninja/","size":4954,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ninja-build:master","ref":"master","sha":"2263f82beab801f5d0235790e651142dba202ae8","user":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"repo":{"id":1335132,"name":"ninja","full_name":"ninja-build/ninja","owner":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninja-build/ninja","description":"a small build system with a focus on speed","fork":false,"url":"https://api.github.com/repos/ninja-build/ninja","forks_url":"https://api.github.com/repos/ninja-build/ninja/forks","keys_url":"https://api.github.com/repos/ninja-build/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninja-build/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninja-build/ninja/teams","hooks_url":"https://api.github.com/repos/ninja-build/ninja/hooks","issue_events_url":"https://api.github.com/repos/ninja-build/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/ninja-build/ninja/events","assignees_url":"https://api.github.com/repos/ninja-build/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/ninja-build/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/ninja-build/ninja/tags","blobs_url":"https://api.github.com/repos/ninja-build/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninja-build/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninja-build/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninja-build/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/ninja-build/ninja/languages","stargazers_url":"https://api.github.com/repos/ninja-build/ninja/stargazers","contributors_url":"https://api.github.com/repos/ninja-build/ninja/contributors","subscribers_url":"https://api.github.com/repos/ninja-build/ninja/subscribers","subscription_url":"https://api.github.com/repos/ninja-build/ninja/subscription","commits_url":"https://api.github.com/repos/ninja-build/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninja-build/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninja-build/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninja-build/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninja-build/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/ninja-build/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninja-build/ninja/merges","archive_url":"https://api.github.com/repos/ninja-build/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninja-build/ninja/downloads","issues_url":"https://api.github.com/repos/ninja-build/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/ninja-build/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/ninja-build/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/ninja-build/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninja-build/ninja/labels{/name}","releases_url":"https://api.github.com/repos/ninja-build/ninja/releases{/id}","deployments_url":"https://api.github.com/repos/ninja-build/ninja/deployments","created_at":"2011-02-06T19:07:12Z","updated_at":"2016-11-07T17:15:39Z","pushed_at":"2016-11-08T04:49:46Z","git_url":"git://github.com/ninja-build/ninja.git","ssh_url":"git@github.com:ninja-build/ninja.git","clone_url":"https://github.com/ninja-build/ninja.git","svn_url":"https://github.com/ninja-build/ninja","homepage":"http://ninja-build.org/","size":8236,"stargazers_count":2282,"watchers_count":2282,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":193,"forks":383,"open_issues":193,"watchers":2282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1206"},"html":{"href":"https://github.com/ninja-build/ninja/pull/1206"},"issue":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1206"},"comments":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/ninja-build/ninja/statuses/32c82da13e2d16792c79507be3d875a6e4624423"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"nico"}}