{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16764","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16764/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16764/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16764/events","html_url":"https://github.com/mantidproject/mantid/pull/16764","id":163200548,"number":16764,"title":"Fix beam center finder masking in ISIS SANS","user":{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20SANS","name":"Component: SANS","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":630,"closed_issues":248,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-07-01T08:49:40Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-30T15:52:40Z","updated_at":"2016-07-01T09:52:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16764","html_url":"https://github.com/mantidproject/mantid/pull/16764","diff_url":"https://github.com/mantidproject/mantid/pull/16764.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16764.patch"},"body":"Description of work.\r\nFixes #16759 \r\n\r\nThe beam center finding suddenly stopped workgin for all instruments. The issue was an incorrect shape XML for masking out pizza-slices from wavelength workspaces.\r\n\r\n__Cause__\r\n\r\nThis seems to have been a case of \"bug fixes bug\". A bug fix before release 3.7.1 relating to the geometry xml was merged into master (see [here](https://github.com/mantidproject/mantid/pull/16004)). This bug fix also fixed system tests relating to the beam center finder.\r\n\r\nThe bug fix exposed the bug which has led to erratic behaviour of the beam center finder. As a fix we provide a correct geometry xml string and adjust the system test.\r\n\r\n\r\n**To test:**\r\n\r\nPlease find the relevant test data here: \\\\olympic\\Babylon5\\Scratch\\Anton\\Testing\\16759_LARMOR_Beam_Center_Issue\r\n\r\n1. Open the ISIS SANS interface\r\n1. Set the instrument to LARMOR\r\n1. Load the user file: USER_Pappas_RB1569004_162B_ISISStat_r9818.txt\r\n1. In sample scatter set the path to the workspace: LARMOR00009839.nxs\r\n1. On the Geometry tab, set the \"Max iterations\" to 0\r\n1. On the Geometry tab, press Run\r\n  * Opent the Up, Down, Left, Right workspaces which should have appeared in the WorkspaceWindow and plot them. Confirm that what you see is not all zero\r\n\r\n\r\n\r\n\r\n\r\n\r\n<!-- Instructions for testing. -->\r\n\r\n\r\n*Does not need to be in the release notes.*\r\n\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/229906779","html_url":"https://github.com/mantidproject/mantid/pull/16764#issuecomment-229906779","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16764","id":229906779,"user":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T09:52:30Z","updated_at":"2016-07-01T09:52:30Z","body":"Does the test data need to be copied to a directory that has been selected in \"Manage user directories\" as a \"Data search directory\"?"}}
{"actor":{"display_login":"KarlPalmen"}}