{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/57843226","id":57843226,"diff_hunk":"@@ -0,0 +1,358 @@\n+// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Security.Cryptography;\n+using System.Text;\n+using Microsoft.AspNetCore.Razor.TagHelpers;\n+using Microsoft.Extensions.Internal;\n+\n+namespace Microsoft.AspNetCore.Mvc.TagHelpers.Cache\n+{\n+    /// <summary>\n+    /// An instance of <see cref=\"CacheTagKey\"/> represents the state of <see cref=\"CacheTagHelper\"/>\n+    /// or <see cref=\"DistributedCacheTagHelper\"/> keys.\n+    /// </summary>\n+    public class CacheTagKey : IEquatable<CacheTagKey>\n+    {\n+        private static readonly char[] AttributeSeparator = new[] { ',' };\n+\n+        private const string CacheKeyTokenSeparator = \"||\";\n+        private const string VaryByName = \"VaryBy\";\n+        private const string VaryByHeaderName = \"VaryByHeader\";\n+        private const string VaryByQueryName = \"VaryByQuery\";\n+        private const string VaryByRouteName = \"VaryByRoute\";\n+        private const string VaryByCookieName = \"VaryByCookie\";\n+        private const string VaryByUserName = \"VaryByUser\";\n+\n+        private string _key;\n+        private string _prefix;\n+        private string _varyBy;\n+        private DateTimeOffset? _expiresOn;\n+        private TimeSpan? _expiresAfter;\n+        private TimeSpan? _expiresSliding;\n+        private IList<KeyValuePair<string, string>> _headers;\n+        private IList<KeyValuePair<string, string>> _queries;\n+        private IList<KeyValuePair<string, string>> _routeValues;\n+        private IList<KeyValuePair<string, string>> _cookies;\n+        private bool _varyByUser;\n+        private string _username;\n+\n+        private string _generatedKey;\n+        private int? _hashcode;\n+        \n+        private CacheTagKey()\n+        {\n+        }\n+\n+        /// <summary>\n+        /// Creates an instance of <see cref=\"CacheTagKey\"/> for a specific <see cref=\"CacheTagHelper\"/>.\n+        /// </summary>\n+        /// <param name=\"tagHelper\">The <see cref=\"CacheTagHelper\"/>.</param>\n+        /// <param name=\"context\">The <see cref=\"TagHelperContext\"/>.</param>\n+        /// <returns>A new <see cref=\"CacheTagKey\"/>.</returns>\n+        public static CacheTagKey From(CacheTagHelper tagHelper, TagHelperContext context)\n+        {\n+            var cacheKey = FromCore(tagHelper, context);\n+\n+            cacheKey._key = context.UniqueId;\n+            cacheKey._prefix = nameof(CacheTagHelper);\n+\n+            return cacheKey;\n+        }\n+\n+        /// <summary>\n+        /// Creates an instance of <see cref=\"CacheTagKey\"/> for a specific <see cref=\"DistributedCacheTagHelper\"/>.\n+        /// </summary>\n+        /// <param name=\"tagHelper\">The <see cref=\"DistributedCacheTagHelper\"/>.</param>\n+        /// <param name=\"context\">The <see cref=\"TagHelperContext\"/>.</param>\n+        /// <returns>A new <see cref=\"CacheTagKey\"/>.</returns>\n+        public static CacheTagKey From(DistributedCacheTagHelper tagHelper, TagHelperContext context)","path":"src/Microsoft.AspNetCore.Mvc.TagHelpers/Cache/CacheTagKey.cs","position":71,"original_position":71,"commit_id":"d28baa85d0fdabacccec04adf2c8469e6c105781","original_commit_id":"d28baa85d0fdabacccec04adf2c8469e6c105781","user":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars.githubusercontent.com/u/174281?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"body":"Seems like an odd API name. Couldn't we have regular ctors for this instead of factories?","created_at":"2016-03-30T06:48:35Z","updated_at":"2016-03-30T06:48:35Z","html_url":"https://github.com/aspnet/Mvc/pull/4369#discussion_r57843226","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4369","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/57843226"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4369#discussion_r57843226"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4369"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/4369","id":64499026,"html_url":"https://github.com/aspnet/Mvc/pull/4369","diff_url":"https://github.com/aspnet/Mvc/pull/4369.diff","patch_url":"https://github.com/aspnet/Mvc/pull/4369.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/4369","number":4369,"state":"open","locked":false,"title":"[Fixes #4246] Introducing CacheTagKey","user":{"login":"sebastienros","id":1165805,"avatar_url":"https://avatars.githubusercontent.com/u/1165805?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"Prevent string allocations in CacheTagHelper\r\nFix hash collision by checking the serialized key with the actual content for DistributedCacheTagHelper","created_at":"2016-03-29T17:03:08Z","updated_at":"2016-03-30T06:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a1346a5da59cc0d5f00fd7c84e7e75f27f499fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4369/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4369/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/4369/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/d28baa85d0fdabacccec04adf2c8469e6c105781","head":{"label":"aspnet:sebros/cachekey","ref":"sebros/cachekey","sha":"d28baa85d0fdabacccec04adf2c8469e6c105781","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-03-29T22:08:02Z","pushed_at":"2016-03-30T05:15:39Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":29992,"stargazers_count":2875,"watchers_count":2875,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1142,"mirror_url":null,"open_issues_count":333,"forks":1142,"open_issues":333,"watchers":2875,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"3924557b877266bf489e7b3d3ec6f703d36237bc","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-03-29T22:08:02Z","pushed_at":"2016-03-30T05:15:39Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":29992,"stargazers_count":2875,"watchers_count":2875,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1142,"mirror_url":null,"open_issues_count":333,"forks":1142,"open_issues":333,"watchers":2875,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4369"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4369"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4369"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4369/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4369/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4369/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/d28baa85d0fdabacccec04adf2c8469e6c105781"}}}}