{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/martensonbj/little_shop/pulls/49","id":55988548,"html_url":"https://github.com/martensonbj/little_shop/pull/49","diff_url":"https://github.com/martensonbj/little_shop/pull/49.diff","patch_url":"https://github.com/martensonbj/little_shop/pull/49.patch","issue_url":"https://api.github.com/repos/martensonbj/little_shop/issues/49","number":49,"state":"closed","locked":false,"title":"closes #36 sad path testing","user":{"login":"ToniRib","id":10429574,"avatar_url":"https://avatars.githubusercontent.com/u/10429574?v=3","gravatar_id":"","url":"https://api.github.com/users/ToniRib","html_url":"https://github.com/ToniRib","followers_url":"https://api.github.com/users/ToniRib/followers","following_url":"https://api.github.com/users/ToniRib/following{/other_user}","gists_url":"https://api.github.com/users/ToniRib/gists{/gist_id}","starred_url":"https://api.github.com/users/ToniRib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToniRib/subscriptions","organizations_url":"https://api.github.com/users/ToniRib/orgs","repos_url":"https://api.github.com/users/ToniRib/repos","events_url":"https://api.github.com/users/ToniRib/events{/privacy}","received_events_url":"https://api.github.com/users/ToniRib/received_events","type":"User","site_admin":false},"body":"Adds some sad-path feature tests for user's logging in and also completes the test we had skipped earlier where an already logged in user tries to check out a cart. Additionally, I fixed the issue where the login page wasn't displaying the navbar or any styling. @martensonbj @Tman22 check out the first file changed below. We had SessionController inheriting from ActionController::Base for some reason which was really screwing it up. I discovered this when writing the sad path tests so I left a comment in issue #47 and closed it.\r\n\r\nI also cleaned up the test_helper methods so they use instance variables and their names are more descriptive. I made sure to propagate the changes to the other tests so everything is passing now.","created_at":"2016-01-14T03:24:27Z","updated_at":"2016-01-14T05:17:08Z","closed_at":"2016-01-14T05:17:08Z","merged_at":"2016-01-14T05:17:08Z","merge_commit_sha":"1d8d0671a6e847c4d3dc840006bf4b3db24f9b4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/martensonbj/little_shop/pulls/49/commits","review_comments_url":"https://api.github.com/repos/martensonbj/little_shop/pulls/49/comments","review_comment_url":"https://api.github.com/repos/martensonbj/little_shop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martensonbj/little_shop/issues/49/comments","statuses_url":"https://api.github.com/repos/martensonbj/little_shop/statuses/69f1d37291657ecc0f3a76e33541ec3434e0a6d4","head":{"label":"martensonbj:36_sad-path-testing","ref":"36_sad-path-testing","sha":"69f1d37291657ecc0f3a76e33541ec3434e0a6d4","user":{"login":"martensonbj","id":13123158,"avatar_url":"https://avatars.githubusercontent.com/u/13123158?v=3","gravatar_id":"","url":"https://api.github.com/users/martensonbj","html_url":"https://github.com/martensonbj","followers_url":"https://api.github.com/users/martensonbj/followers","following_url":"https://api.github.com/users/martensonbj/following{/other_user}","gists_url":"https://api.github.com/users/martensonbj/gists{/gist_id}","starred_url":"https://api.github.com/users/martensonbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martensonbj/subscriptions","organizations_url":"https://api.github.com/users/martensonbj/orgs","repos_url":"https://api.github.com/users/martensonbj/repos","events_url":"https://api.github.com/users/martensonbj/events{/privacy}","received_events_url":"https://api.github.com/users/martensonbj/received_events","type":"User","site_admin":false},"repo":{"id":49446077,"name":"little_shop","full_name":"martensonbj/little_shop","owner":{"login":"martensonbj","id":13123158,"avatar_url":"https://avatars.githubusercontent.com/u/13123158?v=3","gravatar_id":"","url":"https://api.github.com/users/martensonbj","html_url":"https://github.com/martensonbj","followers_url":"https://api.github.com/users/martensonbj/followers","following_url":"https://api.github.com/users/martensonbj/following{/other_user}","gists_url":"https://api.github.com/users/martensonbj/gists{/gist_id}","starred_url":"https://api.github.com/users/martensonbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martensonbj/subscriptions","organizations_url":"https://api.github.com/users/martensonbj/orgs","repos_url":"https://api.github.com/users/martensonbj/repos","events_url":"https://api.github.com/users/martensonbj/events{/privacy}","received_events_url":"https://api.github.com/users/martensonbj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martensonbj/little_shop","description":null,"fork":false,"url":"https://api.github.com/repos/martensonbj/little_shop","forks_url":"https://api.github.com/repos/martensonbj/little_shop/forks","keys_url":"https://api.github.com/repos/martensonbj/little_shop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martensonbj/little_shop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martensonbj/little_shop/teams","hooks_url":"https://api.github.com/repos/martensonbj/little_shop/hooks","issue_events_url":"https://api.github.com/repos/martensonbj/little_shop/issues/events{/number}","events_url":"https://api.github.com/repos/martensonbj/little_shop/events","assignees_url":"https://api.github.com/repos/martensonbj/little_shop/assignees{/user}","branches_url":"https://api.github.com/repos/martensonbj/little_shop/branches{/branch}","tags_url":"https://api.github.com/repos/martensonbj/little_shop/tags","blobs_url":"https://api.github.com/repos/martensonbj/little_shop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martensonbj/little_shop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martensonbj/little_shop/git/refs{/sha}","trees_url":"https://api.github.com/repos/martensonbj/little_shop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martensonbj/little_shop/statuses/{sha}","languages_url":"https://api.github.com/repos/martensonbj/little_shop/languages","stargazers_url":"https://api.github.com/repos/martensonbj/little_shop/stargazers","contributors_url":"https://api.github.com/repos/martensonbj/little_shop/contributors","subscribers_url":"https://api.github.com/repos/martensonbj/little_shop/subscribers","subscription_url":"https://api.github.com/repos/martensonbj/little_shop/subscription","commits_url":"https://api.github.com/repos/martensonbj/little_shop/commits{/sha}","git_commits_url":"https://api.github.com/repos/martensonbj/little_shop/git/commits{/sha}","comments_url":"https://api.github.com/repos/martensonbj/little_shop/comments{/number}","issue_comment_url":"https://api.github.com/repos/martensonbj/little_shop/issues/comments{/number}","contents_url":"https://api.github.com/repos/martensonbj/little_shop/contents/{+path}","compare_url":"https://api.github.com/repos/martensonbj/little_shop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martensonbj/little_shop/merges","archive_url":"https://api.github.com/repos/martensonbj/little_shop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martensonbj/little_shop/downloads","issues_url":"https://api.github.com/repos/martensonbj/little_shop/issues{/number}","pulls_url":"https://api.github.com/repos/martensonbj/little_shop/pulls{/number}","milestones_url":"https://api.github.com/repos/martensonbj/little_shop/milestones{/number}","notifications_url":"https://api.github.com/repos/martensonbj/little_shop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martensonbj/little_shop/labels{/name}","releases_url":"https://api.github.com/repos/martensonbj/little_shop/releases{/id}","created_at":"2016-01-11T18:37:54Z","updated_at":"2016-01-11T18:40:37Z","pushed_at":"2016-01-14T05:17:08Z","git_url":"git://github.com/martensonbj/little_shop.git","ssh_url":"git@github.com:martensonbj/little_shop.git","clone_url":"https://github.com/martensonbj/little_shop.git","svn_url":"https://github.com/martensonbj/little_shop","homepage":null,"size":2745,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"martensonbj:master","ref":"master","sha":"be3d96eda6acdec7c4e9ed032e2f98c3a746c632","user":{"login":"martensonbj","id":13123158,"avatar_url":"https://avatars.githubusercontent.com/u/13123158?v=3","gravatar_id":"","url":"https://api.github.com/users/martensonbj","html_url":"https://github.com/martensonbj","followers_url":"https://api.github.com/users/martensonbj/followers","following_url":"https://api.github.com/users/martensonbj/following{/other_user}","gists_url":"https://api.github.com/users/martensonbj/gists{/gist_id}","starred_url":"https://api.github.com/users/martensonbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martensonbj/subscriptions","organizations_url":"https://api.github.com/users/martensonbj/orgs","repos_url":"https://api.github.com/users/martensonbj/repos","events_url":"https://api.github.com/users/martensonbj/events{/privacy}","received_events_url":"https://api.github.com/users/martensonbj/received_events","type":"User","site_admin":false},"repo":{"id":49446077,"name":"little_shop","full_name":"martensonbj/little_shop","owner":{"login":"martensonbj","id":13123158,"avatar_url":"https://avatars.githubusercontent.com/u/13123158?v=3","gravatar_id":"","url":"https://api.github.com/users/martensonbj","html_url":"https://github.com/martensonbj","followers_url":"https://api.github.com/users/martensonbj/followers","following_url":"https://api.github.com/users/martensonbj/following{/other_user}","gists_url":"https://api.github.com/users/martensonbj/gists{/gist_id}","starred_url":"https://api.github.com/users/martensonbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martensonbj/subscriptions","organizations_url":"https://api.github.com/users/martensonbj/orgs","repos_url":"https://api.github.com/users/martensonbj/repos","events_url":"https://api.github.com/users/martensonbj/events{/privacy}","received_events_url":"https://api.github.com/users/martensonbj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martensonbj/little_shop","description":null,"fork":false,"url":"https://api.github.com/repos/martensonbj/little_shop","forks_url":"https://api.github.com/repos/martensonbj/little_shop/forks","keys_url":"https://api.github.com/repos/martensonbj/little_shop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martensonbj/little_shop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martensonbj/little_shop/teams","hooks_url":"https://api.github.com/repos/martensonbj/little_shop/hooks","issue_events_url":"https://api.github.com/repos/martensonbj/little_shop/issues/events{/number}","events_url":"https://api.github.com/repos/martensonbj/little_shop/events","assignees_url":"https://api.github.com/repos/martensonbj/little_shop/assignees{/user}","branches_url":"https://api.github.com/repos/martensonbj/little_shop/branches{/branch}","tags_url":"https://api.github.com/repos/martensonbj/little_shop/tags","blobs_url":"https://api.github.com/repos/martensonbj/little_shop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martensonbj/little_shop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martensonbj/little_shop/git/refs{/sha}","trees_url":"https://api.github.com/repos/martensonbj/little_shop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martensonbj/little_shop/statuses/{sha}","languages_url":"https://api.github.com/repos/martensonbj/little_shop/languages","stargazers_url":"https://api.github.com/repos/martensonbj/little_shop/stargazers","contributors_url":"https://api.github.com/repos/martensonbj/little_shop/contributors","subscribers_url":"https://api.github.com/repos/martensonbj/little_shop/subscribers","subscription_url":"https://api.github.com/repos/martensonbj/little_shop/subscription","commits_url":"https://api.github.com/repos/martensonbj/little_shop/commits{/sha}","git_commits_url":"https://api.github.com/repos/martensonbj/little_shop/git/commits{/sha}","comments_url":"https://api.github.com/repos/martensonbj/little_shop/comments{/number}","issue_comment_url":"https://api.github.com/repos/martensonbj/little_shop/issues/comments{/number}","contents_url":"https://api.github.com/repos/martensonbj/little_shop/contents/{+path}","compare_url":"https://api.github.com/repos/martensonbj/little_shop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martensonbj/little_shop/merges","archive_url":"https://api.github.com/repos/martensonbj/little_shop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martensonbj/little_shop/downloads","issues_url":"https://api.github.com/repos/martensonbj/little_shop/issues{/number}","pulls_url":"https://api.github.com/repos/martensonbj/little_shop/pulls{/number}","milestones_url":"https://api.github.com/repos/martensonbj/little_shop/milestones{/number}","notifications_url":"https://api.github.com/repos/martensonbj/little_shop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martensonbj/little_shop/labels{/name}","releases_url":"https://api.github.com/repos/martensonbj/little_shop/releases{/id}","created_at":"2016-01-11T18:37:54Z","updated_at":"2016-01-11T18:40:37Z","pushed_at":"2016-01-14T05:17:08Z","git_url":"git://github.com/martensonbj/little_shop.git","ssh_url":"git@github.com:martensonbj/little_shop.git","clone_url":"https://github.com/martensonbj/little_shop.git","svn_url":"https://github.com/martensonbj/little_shop","homepage":null,"size":2745,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martensonbj/little_shop/pulls/49"},"html":{"href":"https://github.com/martensonbj/little_shop/pull/49"},"issue":{"href":"https://api.github.com/repos/martensonbj/little_shop/issues/49"},"comments":{"href":"https://api.github.com/repos/martensonbj/little_shop/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/martensonbj/little_shop/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/martensonbj/little_shop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martensonbj/little_shop/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/martensonbj/little_shop/statuses/69f1d37291657ecc0f3a76e33541ec3434e0a6d4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"martensonbj","id":13123158,"avatar_url":"https://avatars.githubusercontent.com/u/13123158?v=3","gravatar_id":"","url":"https://api.github.com/users/martensonbj","html_url":"https://github.com/martensonbj","followers_url":"https://api.github.com/users/martensonbj/followers","following_url":"https://api.github.com/users/martensonbj/following{/other_user}","gists_url":"https://api.github.com/users/martensonbj/gists{/gist_id}","starred_url":"https://api.github.com/users/martensonbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martensonbj/subscriptions","organizations_url":"https://api.github.com/users/martensonbj/orgs","repos_url":"https://api.github.com/users/martensonbj/repos","events_url":"https://api.github.com/users/martensonbj/events{/privacy}","received_events_url":"https://api.github.com/users/martensonbj/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":3,"additions":111,"deletions":39,"changed_files":10}}