{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10711","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10711/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10711/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10711/events","html_url":"https://github.com/joomla/joomla-cms/pull/10711","id":158112093,"number":10711,"title":"Fix updater sql files parser","user":{"login":"alex7r","id":18716997,"avatar_url":"https://avatars.githubusercontent.com/u/18716997?v=3","gravatar_id":"","url":"https://api.github.com/users/alex7r","html_url":"https://github.com/alex7r","followers_url":"https://api.github.com/users/alex7r/followers","following_url":"https://api.github.com/users/alex7r/following{/other_user}","gists_url":"https://api.github.com/users/alex7r/gists{/gist_id}","starred_url":"https://api.github.com/users/alex7r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex7r/subscriptions","organizations_url":"https://api.github.com/users/alex7r/orgs","repos_url":"https://api.github.com/users/alex7r/repos","events_url":"https://api.github.com/users/alex7r/events{/privacy}","received_events_url":"https://api.github.com/users/alex7r/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-02T10:48:03Z","updated_at":"2016-06-02T18:33:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10711","html_url":"https://github.com/joomla/joomla-cms/pull/10711","diff_url":"https://github.com/joomla/joomla-cms/pull/10711.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10711.patch"},"body":"Pull Request for **Installer run all SQL updates**.\r\nInstaller run all SQL updates starting from previous version, and not paying attention to current version that we are updating to.\r\n\r\n#### Summary of Changes\r\n\r\nAdded \"top_version\" range\r\n\r\n#### Testing Instructions\r\n\r\nUpdate extension from version 3.1.020 to 3.1.24\r\nWith \r\n3.1.019\r\n3.1.021\r\n3.1.024\r\n3.1.025\r\nsql update files\r\n*result*: version installed is 3.1.024 and DB version is **3.1.024** (instead of 3.1.024 and **3.1.025** as before)"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/223381571","html_url":"https://github.com/joomla/joomla-cms/pull/10711#issuecomment-223381571","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10711","id":223381571,"user":{"login":"alex7r","id":18716997,"avatar_url":"https://avatars.githubusercontent.com/u/18716997?v=3","gravatar_id":"","url":"https://api.github.com/users/alex7r","html_url":"https://github.com/alex7r","followers_url":"https://api.github.com/users/alex7r/followers","following_url":"https://api.github.com/users/alex7r/following{/other_user}","gists_url":"https://api.github.com/users/alex7r/gists{/gist_id}","starred_url":"https://api.github.com/users/alex7r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex7r/subscriptions","organizations_url":"https://api.github.com/users/alex7r/orgs","repos_url":"https://api.github.com/users/alex7r/repos","events_url":"https://api.github.com/users/alex7r/events{/privacy}","received_events_url":"https://api.github.com/users/alex7r/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T18:33:50Z","updated_at":"2016-06-02T18:33:50Z","body":"> Joomla's codestyle rules pre-date PSR-2 or PhpStorm becoming a top player in the IDE marketspace. It's not Joomla's responsibility to cater to market trends just because it's the cool thing to do.\r\n\r\nAnd that's how you planning on involving new developers to commit and spread Joomla!? You better be kidding me... Joomla real thirsty, young blood developers blood thirsty.\r\nYou know it will be good meme, or smth like: \r\n\r\n> You'll love Joomla it gives you so much space for extension of it's core\r\n> You'll hate Joomla it gives you 2 much \"space\" for committing to it's core\r\n\r\nSeriously - 2 or 10 000... to cater to market trends... Just remove those lines from build check and so much developers love you'll get. Nobody ask you to rebuild your core to be in this kind of trend. Seriously, think about it. Or think about forgiving about Joomla at all if 3 years trend is nothing for you. Don't use bootstrap and jquery, stick with mootools and table templates as it's not Joomla's responsibility.\r\n\r\n> Frankly the scenario you've presented wouldn't work correctly without providing a custom SQL diff specific to that installation, it's not something the API can automagically handle because Joomla doesn't have a real schema tracking/detection/management API\r\n\r\nWell you need to do some job definitely, but there is solution without custom sql. To preserve issues from happening you may create 0.0.001.sql and it will be applied only but \"db fix\" button.\r\nAnd it need to contain all tables in presented like: table creating + each column creating.\r\n\r\n\r\n\r\nThe one good question that you added is\r\n\r\n> With your \"top\" version argument, the 021 and 024 updates would be applied but all existing API tools would tell you that your schema is out of date because 025 is not applied.\r\n\r\nBut really to use API in your extension you need to call it right? In one extension I use this workaround - I call API one way. In other I don't - other way. And so there is issues.\r\nWhat better implement 2 ways by adding variable, or only one way of implementation? That's not flexible.\r\nAnd rhetorical question: did you seen many extensions using it? I mean I strongly believe this problem was not previously mentioned because there ain't much people using this API.\r\n\r\n**Also**: \"Oh this solution need to more changes in other file to be good... Well let's reject it and do nothing, as it needs some pointing to some additional work.\" - is not long ride solution."}}
{"actor":{"display_login":"alex7r"}}