{"action":"created","issue":{"url":"https://api.github.com/repos/haikuports/haikuports/issues/500","repository_url":"https://api.github.com/repos/haikuports/haikuports","labels_url":"https://api.github.com/repos/haikuports/haikuports/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/haikuports/haikuports/issues/500/comments","events_url":"https://api.github.com/repos/haikuports/haikuports/issues/500/events","html_url":"https://github.com/haikuports/haikuports/pull/500","id":139192561,"number":500,"title":"mksh: bump version, add x86{,_64} with a tiny conditional patch.","user":{"login":"fbrosson","id":8014660,"avatar_url":"https://avatars.githubusercontent.com/u/8014660?v=3","gravatar_id":"","url":"https://api.github.com/users/fbrosson","html_url":"https://github.com/fbrosson","followers_url":"https://api.github.com/users/fbrosson/followers","following_url":"https://api.github.com/users/fbrosson/following{/other_user}","gists_url":"https://api.github.com/users/fbrosson/gists{/gist_id}","starred_url":"https://api.github.com/users/fbrosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbrosson/subscriptions","organizations_url":"https://api.github.com/users/fbrosson/orgs","repos_url":"https://api.github.com/users/fbrosson/repos","events_url":"https://api.github.com/users/fbrosson/events{/privacy}","received_events_url":"https://api.github.com/users/fbrosson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-08T06:32:30Z","updated_at":"2016-03-08T07:04:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/500","html_url":"https://github.com/haikuports/haikuports/pull/500","diff_url":"https://github.com/haikuports/haikuports/pull/500.diff","patch_url":"https://github.com/haikuports/haikuports/pull/500.patch"},"body":"Also add cmd:awk to BUILD_PREREQUIRES and use portVersion where appropriate."},"comment":{"url":"https://api.github.com/repos/haikuports/haikuports/issues/comments/193635860","html_url":"https://github.com/haikuports/haikuports/pull/500#issuecomment-193635860","issue_url":"https://api.github.com/repos/haikuports/haikuports/issues/500","id":193635860,"user":{"login":"fbrosson","id":8014660,"avatar_url":"https://avatars.githubusercontent.com/u/8014660?v=3","gravatar_id":"","url":"https://api.github.com/users/fbrosson","html_url":"https://github.com/fbrosson","followers_url":"https://api.github.com/users/fbrosson/followers","following_url":"https://api.github.com/users/fbrosson/following{/other_user}","gists_url":"https://api.github.com/users/fbrosson/gists{/gist_id}","starred_url":"https://api.github.com/users/fbrosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbrosson/subscriptions","organizations_url":"https://api.github.com/users/fbrosson/orgs","repos_url":"https://api.github.com/users/fbrosson/repos","events_url":"https://api.github.com/users/fbrosson/events{/privacy}","received_events_url":"https://api.github.com/users/fbrosson/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T07:04:56Z","updated_at":"2016-03-08T07:04:56Z","body":"After trying some source patches for **`sh.h`** to fix an error about **`getrusage()`** being redeclared, I got another error which seemed to be related to stack protection. So I patched the build script to skip **`-fstack-protector-strong`** and **`-fstack-protector-all`** and noticed that without the stack protection switches everying seems to work both with and without the initial source patch. So I just kept the patch that drops the stack protection switches.\r\nAnd since the recipe builds and works fine on x86_gcc2 without any patch, probably because the patch is neutral with gcc2, I chose to not apply any patch on x86_gcc2.\r\nI don't know if disabling stack protection is acceptable, but since x86 and x86_64 were both missing in ARCHITECTURES I thought we could give it a try.\r\nBTW, I don't use mksh but I guess some other Haiku users do. This will allow them to have it on more arches."}}