{"action":"created","issue":{"url":"https://api.github.com/repos/teamed/qulice/issues/646","labels_url":"https://api.github.com/repos/teamed/qulice/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/teamed/qulice/issues/646/comments","events_url":"https://api.github.com/repos/teamed/qulice/issues/646/events","html_url":"https://github.com/teamed/qulice/issues/646","id":128641804,"number":646,"title":"Prohibit usage of plain JUnit assertions","user":{"login":"mkordas","id":5467276,"avatar_url":"https://avatars.githubusercontent.com/u/5467276?v=3","gravatar_id":"","url":"https://api.github.com/users/mkordas","html_url":"https://github.com/mkordas","followers_url":"https://api.github.com/users/mkordas/followers","following_url":"https://api.github.com/users/mkordas/following{/other_user}","gists_url":"https://api.github.com/users/mkordas/gists{/gist_id}","starred_url":"https://api.github.com/users/mkordas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkordas/subscriptions","organizations_url":"https://api.github.com/users/mkordas/orgs","repos_url":"https://api.github.com/users/mkordas/repos","events_url":"https://api.github.com/users/mkordas/events{/privacy}","received_events_url":"https://api.github.com/users/mkordas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-25T21:23:36Z","updated_at":"2016-01-25T21:28:32Z","closed_at":null,"body":"For consistency reasons Qulice should not allow JUnit assertions from the following families:\r\n* `org.junit.Assert.assert*`\r\n* `junit.framework.Assert.assert*`\r\n\r\nI'd expect Checkstyle or PMD violation on every such assertion. However, `Assert.fail()` should remain allowed.\r\n\r\nRationale is in http://www.yegor256.com/2014/04/28/xml-xpath-hamcrest-matchers.html:\r\n> Hamcrest is my favorite instrument in unit testing. It replaces the JUnit procedural assertions of `org.junit.Assert` with an object-oriented mechanism. \r\n\r\nMoreover, I've seen mixed assertions in some project which introduces confusion which one to use."},"comment":{"url":"https://api.github.com/repos/teamed/qulice/issues/comments/174670906","html_url":"https://github.com/teamed/qulice/issues/646#issuecomment-174670906","issue_url":"https://api.github.com/repos/teamed/qulice/issues/646","id":174670906,"user":{"login":"krzyk","id":105730,"avatar_url":"https://avatars.githubusercontent.com/u/105730?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyk","html_url":"https://github.com/krzyk","followers_url":"https://api.github.com/users/krzyk/followers","following_url":"https://api.github.com/users/krzyk/following{/other_user}","gists_url":"https://api.github.com/users/krzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyk/subscriptions","organizations_url":"https://api.github.com/users/krzyk/orgs","repos_url":"https://api.github.com/users/krzyk/repos","events_url":"https://api.github.com/users/krzyk/events{/privacy}","received_events_url":"https://api.github.com/users/krzyk/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T21:28:32Z","updated_at":"2016-01-25T21:28:32Z","body":"@davvd this is postponed"}}