{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/84310984","pull_request_review_id":5096453,"id":84310984,"diff_hunk":"@@ -26,11 +26,11 @@ ruleTester.run(\"no-invalid-regexp\", rule, {\n         { code: \"new RegExp('.', 'y')\", options: [{ allowConstructorFlags: [\"y\"] }]},\n         { code: \"new RegExp('.', 'u')\", options: [{ allowConstructorFlags: [\"U\"] }]},\n         { code: \"new RegExp('.', 'yu')\", options: [{ allowConstructorFlags: [\"y\", \"u\"] }]},\n-        { code: \"new RegExp('\\/', 'yu')\", options: [{ allowConstructorFlags: [\"y\", \"u\"] }]},\n+        { code: \"new RegExp('\\/', 'yu')\", options: [{ allowConstructorFlags: [\"y\", \"u\"] }]}, // eslint-disable-line no-useless-escape","path":"tests/lib/rules/no-invalid-regexp.js","position":5,"original_position":5,"commit_id":"9a5cfc62a6811df7901cb06b5b5dd729e32fa1b3","original_commit_id":"9a5cfc62a6811df7901cb06b5b5dd729e32fa1b3","user":{"login":"vitorbal","id":626038,"avatar_url":"https://avatars.githubusercontent.com/u/626038?v=3","gravatar_id":"","url":"https://api.github.com/users/vitorbal","html_url":"https://github.com/vitorbal","followers_url":"https://api.github.com/users/vitorbal/followers","following_url":"https://api.github.com/users/vitorbal/following{/other_user}","gists_url":"https://api.github.com/users/vitorbal/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorbal/subscriptions","organizations_url":"https://api.github.com/users/vitorbal/orgs","repos_url":"https://api.github.com/users/vitorbal/repos","events_url":"https://api.github.com/users/vitorbal/events{/privacy}","received_events_url":"https://api.github.com/users/vitorbal/received_events","type":"User","site_admin":false},"body":"I honestly cannot tell how this line is different from the one above it. Here's the original commit: https://github.com/eslint/eslint/commit/c0a7be609e420c6939330909bdb43d49b3670cf5#diff-9f7fae656233bad860f2ba8d46986835R26\r\nThose tests were added to test the new `y` and `u` flags, as it seems.","created_at":"2016-10-20T15:36:10Z","updated_at":"2016-10-20T15:36:10Z","html_url":"https://github.com/eslint/eslint/pull/7403#discussion_r84310984","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/7403","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/84310984"},"html":{"href":"https://github.com/eslint/eslint/pull/7403#discussion_r84310984"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7403"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/7403","id":90047491,"html_url":"https://github.com/eslint/eslint/pull/7403","diff_url":"https://github.com/eslint/eslint/pull/7403.diff","patch_url":"https://github.com/eslint/eslint/pull/7403.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7403","number":7403,"state":"open","locked":false,"title":"Chore: Enable `no-useless-escape`","user":{"login":"vitorbal","id":626038,"avatar_url":"https://avatars.githubusercontent.com/u/626038?v=3","gravatar_id":"","url":"https://api.github.com/users/vitorbal","html_url":"https://github.com/vitorbal","followers_url":"https://api.github.com/users/vitorbal/followers","following_url":"https://api.github.com/users/vitorbal/following{/other_user}","gists_url":"https://api.github.com/users/vitorbal/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorbal/subscriptions","organizations_url":"https://api.github.com/users/vitorbal/orgs","repos_url":"https://api.github.com/users/vitorbal/repos","events_url":"https://api.github.com/users/vitorbal/events{/privacy}","received_events_url":"https://api.github.com/users/vitorbal/received_events","type":"User","site_admin":false},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[ ] Add something to the core\r\n[x] Other, please explain:\r\nChore, see overview section below.\r\n\r\n**What changes did you make? (Give an overview)**\r\nAs per the discussion [here](https://github.com/eslint/eslint/pull/7357#discussion_r83376369), I've turned the `no-useless-escape` rule on and fixed all the pertinent errors in our codebase.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nNothing in specific, I guess just some extra eyes to make sure there were not any false-positives.\r\n\r\n\r\n\r\n","created_at":"2016-10-19T16:41:46Z","updated_at":"2016-10-20T15:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a24994f6e4666fccc038870627938e9d9d63c7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/7403/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/7403/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7403/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/9a5cfc62a6811df7901cb06b5b5dd729e32fa1b3","head":{"label":"eslint:no-useless-escape","ref":"no-useless-escape","sha":"9a5cfc62a6811df7901cb06b5b5dd729e32fa1b3","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-10-20T13:21:24Z","pushed_at":"2016-10-20T12:22:18Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":19358,"stargazers_count":6110,"watchers_count":6110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1179,"mirror_url":null,"open_issues_count":235,"forks":1179,"open_issues":235,"watchers":6110,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"e064a25a6ce46a496cc49679f3811d776c1d8ae4","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-10-20T13:21:24Z","pushed_at":"2016-10-20T12:22:18Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":19358,"stargazers_count":6110,"watchers_count":6110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1179,"mirror_url":null,"open_issues_count":235,"forks":1179,"open_issues":235,"watchers":6110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7403"},"html":{"href":"https://github.com/eslint/eslint/pull/7403"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/7403"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/7403/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7403/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7403/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/9a5cfc62a6811df7901cb06b5b5dd729e32fa1b3"}}}}
{"actor":{"display_login":"vitorbal"}}