{"push_id":1234654848,"size":19,"distinct_size":0,"ref":"refs/heads/deployed-to-integration","head":"a7ed717dd50e6be08bc7ec9ea3414a6b9fa822a6","before":"8b5f5e8898eead62294d36960fe1135c844c9fa2","commits":[{"sha":"6ad4884919876684656643ca7bd98b9f1a888fb0","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Remove acts_as_list\n\nIt doesn't do what we need it to, and even if it did we'd be using a tiny amount of its functionality, so we'll do it ourselves instead.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/6ad4884919876684656643ca7bd98b9f1a888fb0"},{"sha":"b48955e7083b38349ffe1f163abd9806baa8a843","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Add a failing test for reordering topic sections","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/b48955e7083b38349ffe1f163abd9806baa8a843"},{"sha":"43e1f6595d2c462fc4a30a649913e54d50c7fa90","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Make the re-ordering drag handles actually do something.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/43e1f6595d2c462fc4a30a649913e54d50c7fa90"},{"sha":"2580fdb98843aa68e08f8d3593493ecd346bf0dc","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Allow users to actually re-order guides within topic sections\n\nThe UI for this previously existed but didn't do anything, so this hooks it up so that it actually works.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/2580fdb98843aa68e08f8d3593493ecd346bf0dc"},{"sha":"fe30e0bbce03b7a3738f02baf5e768bd263e690e","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Tidy up reordering topic section feature spec helpers","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/fe30e0bbce03b7a3738f02baf5e768bd263e690e"},{"sha":"92ffc4998eccdcbc3ff2a3a73f1faabd5b479261","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Remove Sortable.js\n\nIt's not used anywhere.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/92ffc4998eccdcbc3ff2a3a73f1faabd5b479261"},{"sha":"ca606f103aee5bd27ffc5b421f1b82a0aa0ed035","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Add tests to ensure that sections and guides are displayed in position order","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/ca606f103aee5bd27ffc5b421f1b82a0aa0ed035"},{"sha":"ba578191503f710ecf41f5e7801ed46fc0a3e1f4","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Remember topic section order changes when adding new headings","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/ba578191503f710ecf41f5e7801ed46fc0a3e1f4"},{"sha":"bb1c94151219491f4e79ba8bf29d5d5c825cb33a","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Remember guide order changes when adding new headings","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/bb1c94151219491f4e79ba8bf29d5d5c825cb33a"},{"sha":"a8fb59a79aaddda40dc40c3e34ab86f786ea657d","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Fix adding topic sections to lists\n\nThe after initialise callback happens to early, before any attributes are actually set on the model. this means that self.topic_id is always nil, so it doesn't correctly set the position.\n\nInstead, make the topic model responsible for adding its own sections – setting the position as it does so.\n\nUnfortunately there are a number of places in the test that manually create! topic sections, so we also need to update them to use the topic section factory.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/a8fb59a79aaddda40dc40c3e34ab86f786ea657d"},{"sha":"6a4476a086318993713a77ad9d50ce34c64ed905","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Fix linter offences","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/6a4476a086318993713a77ad9d50ce34c64ed905"},{"sha":"97deb150590b5eb3ed8c13b2eee4cd469e0e4437","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Implement changes from PR feedback\n\n- Make default_position_to_next_in_list and next_position_in_list private\n- Split up highest_position_in_list to make it more readable","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/97deb150590b5eb3ed8c13b2eee4cd469e0e4437"},{"sha":"624843b14c6f365b11cac1eba5bcf10a41c070ef","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Refactor topic section ordering to work with topics that haven't been saved yet.\n\nWe can't always use the database because we might be working with a topic that doesn't yet exist, so let's calculate the next position from the form data instead.","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/624843b14c6f365b11cac1eba5bcf10a41c070ef"},{"sha":"cff5aca67dd67c0fcdffbbbe5a4f7eda0d5da1af","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Display the version number and type of the most recent edition on the Guide index","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/cff5aca67dd67c0fcdffbbbe5a4f7eda0d5da1af"},{"sha":"b26a516d33f9d272758357d12344c80819b57c8e","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Don't use muted style for edition number and update type","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/b26a516d33f9d272758357d12344c80819b57c8e"},{"sha":"7b8627e07931cae5c71b3952890846451a853d5e","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Remove unused topic section scope","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/7b8627e07931cae5c71b3952890846451a853d5e"},{"sha":"8347906adfc36ca343915bcb7b03c469dcd6af0b","author":{"name":"Oliver Byford","email":"8ca81a9b56c5b3a82c78587cd2cfdce8085f1ff8@digital.cabinet-office.gov.uk"},"message":"Fix test data positions to make test more explicit","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/8347906adfc36ca343915bcb7b03c469dcd6af0b"},{"sha":"9570b5e57a7879c816d6a4d41579897d160f43a6","author":{"name":"Henry","email":"375917a88bfbd9fd8a321a01c9d03973acc9e6f2@users.noreply.github.com"},"message":"Merge pull request #319 from alphagov/reorder-topic-sections-and-guides\n\nAllow users to reorder topic sections and guides","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/9570b5e57a7879c816d6a4d41579897d160f43a6"},{"sha":"a7ed717dd50e6be08bc7ec9ea3414a6b9fa822a6","author":{"name":"Oliver Byford","email":"20118480acc82dcb1481dfe8f21cb84160e1a1cb@byford.org"},"message":"Merge pull request #323 from alphagov/edition-number-type-on-index\n\nDisplay version # and type of the most recent edition on Guide Index","distinct":false,"url":"https://api.github.com/repos/alphagov/service-manual-publisher/commits/a7ed717dd50e6be08bc7ec9ea3414a6b9fa822a6"}]}
{"actor":{"display_login":"govuk-ci"}}