{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9","id":95042448,"html_url":"https://github.com/dsummersl/node-xml2js-xpath/pull/9","diff_url":"https://github.com/dsummersl/node-xml2js-xpath/pull/9.diff","patch_url":"https://github.com/dsummersl/node-xml2js-xpath/pull/9.patch","issue_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/9","number":9,"state":"open","locked":false,"title":"now with correct intermediate array results","user":{"login":"krugar","id":109856,"avatar_url":"https://avatars.githubusercontent.com/u/109856?v=3","gravatar_id":"","url":"https://api.github.com/users/krugar","html_url":"https://github.com/krugar","followers_url":"https://api.github.com/users/krugar/followers","following_url":"https://api.github.com/users/krugar/following{/other_user}","gists_url":"https://api.github.com/users/krugar/gists{/gist_id}","starred_url":"https://api.github.com/users/krugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krugar/subscriptions","organizations_url":"https://api.github.com/users/krugar/orgs","repos_url":"https://api.github.com/users/krugar/repos","events_url":"https://api.github.com/users/krugar/events{/privacy}","received_events_url":"https://api.github.com/users/krugar/received_events","type":"User","site_admin":false},"body":"i ran into a situation with the \"/Element[key=value]\" matching logic where `find(\"//a/b[@c='d']/e\")` would not return all possible results if there were multiple hits not just for `//a` and/or `/e` in the end, but for `b[@c='d']/e`. relevant testcases and new code in separate commits below. \r\n\r\nkinda messed up and put some performance improvements into the second commit as well, but they're easy to tell apart from the testcase-fixing parts, i hope (i switched out `String.prototype.replace(<RegExp>,'')` for `String.prototype.replace(<Template String>,'')` where possible).\r\n\r\nhth :)","created_at":"2016-11-23T16:58:34Z","updated_at":"2016-11-23T16:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9/commits","review_comments_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9/comments","review_comment_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/9/comments","statuses_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/statuses/f7c582cbc805cc64988c90d751721056cf965bf5","head":{"label":"krugar:intermediate_array_result","ref":"intermediate_array_result","sha":"f7c582cbc805cc64988c90d751721056cf965bf5","user":{"login":"krugar","id":109856,"avatar_url":"https://avatars.githubusercontent.com/u/109856?v=3","gravatar_id":"","url":"https://api.github.com/users/krugar","html_url":"https://github.com/krugar","followers_url":"https://api.github.com/users/krugar/followers","following_url":"https://api.github.com/users/krugar/following{/other_user}","gists_url":"https://api.github.com/users/krugar/gists{/gist_id}","starred_url":"https://api.github.com/users/krugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krugar/subscriptions","organizations_url":"https://api.github.com/users/krugar/orgs","repos_url":"https://api.github.com/users/krugar/repos","events_url":"https://api.github.com/users/krugar/events{/privacy}","received_events_url":"https://api.github.com/users/krugar/received_events","type":"User","site_admin":false},"repo":{"id":62877621,"name":"node-xml2js-xpath","full_name":"krugar/node-xml2js-xpath","owner":{"login":"krugar","id":109856,"avatar_url":"https://avatars.githubusercontent.com/u/109856?v=3","gravatar_id":"","url":"https://api.github.com/users/krugar","html_url":"https://github.com/krugar","followers_url":"https://api.github.com/users/krugar/followers","following_url":"https://api.github.com/users/krugar/following{/other_user}","gists_url":"https://api.github.com/users/krugar/gists{/gist_id}","starred_url":"https://api.github.com/users/krugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krugar/subscriptions","organizations_url":"https://api.github.com/users/krugar/orgs","repos_url":"https://api.github.com/users/krugar/repos","events_url":"https://api.github.com/users/krugar/events{/privacy}","received_events_url":"https://api.github.com/users/krugar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krugar/node-xml2js-xpath","description":"Search xml2js JSON documents with XPath query strings.","fork":true,"url":"https://api.github.com/repos/krugar/node-xml2js-xpath","forks_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/forks","keys_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/teams","hooks_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/hooks","issue_events_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/issues/events{/number}","events_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/events","assignees_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/assignees{/user}","branches_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/branches{/branch}","tags_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/tags","blobs_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/statuses/{sha}","languages_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/languages","stargazers_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/stargazers","contributors_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/contributors","subscribers_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/subscribers","subscription_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/subscription","commits_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/contents/{+path}","compare_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/merges","archive_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/downloads","issues_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/issues{/number}","pulls_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/pulls{/number}","milestones_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/milestones{/number}","notifications_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/labels{/name}","releases_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/releases{/id}","deployments_url":"https://api.github.com/repos/krugar/node-xml2js-xpath/deployments","created_at":"2016-07-08T09:36:51Z","updated_at":"2016-07-08T09:36:52Z","pushed_at":"2016-11-23T16:40:59Z","git_url":"git://github.com/krugar/node-xml2js-xpath.git","ssh_url":"git@github.com:krugar/node-xml2js-xpath.git","clone_url":"https://github.com/krugar/node-xml2js-xpath.git","svn_url":"https://github.com/krugar/node-xml2js-xpath","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dsummersl:master","ref":"master","sha":"f061edf89b12d961f8efe00c5e3679b84391b5bb","user":{"login":"dsummersl","id":30856,"avatar_url":"https://avatars.githubusercontent.com/u/30856?v=3","gravatar_id":"","url":"https://api.github.com/users/dsummersl","html_url":"https://github.com/dsummersl","followers_url":"https://api.github.com/users/dsummersl/followers","following_url":"https://api.github.com/users/dsummersl/following{/other_user}","gists_url":"https://api.github.com/users/dsummersl/gists{/gist_id}","starred_url":"https://api.github.com/users/dsummersl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsummersl/subscriptions","organizations_url":"https://api.github.com/users/dsummersl/orgs","repos_url":"https://api.github.com/users/dsummersl/repos","events_url":"https://api.github.com/users/dsummersl/events{/privacy}","received_events_url":"https://api.github.com/users/dsummersl/received_events","type":"User","site_admin":false},"repo":{"id":25699941,"name":"node-xml2js-xpath","full_name":"dsummersl/node-xml2js-xpath","owner":{"login":"dsummersl","id":30856,"avatar_url":"https://avatars.githubusercontent.com/u/30856?v=3","gravatar_id":"","url":"https://api.github.com/users/dsummersl","html_url":"https://github.com/dsummersl","followers_url":"https://api.github.com/users/dsummersl/followers","following_url":"https://api.github.com/users/dsummersl/following{/other_user}","gists_url":"https://api.github.com/users/dsummersl/gists{/gist_id}","starred_url":"https://api.github.com/users/dsummersl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsummersl/subscriptions","organizations_url":"https://api.github.com/users/dsummersl/orgs","repos_url":"https://api.github.com/users/dsummersl/repos","events_url":"https://api.github.com/users/dsummersl/events{/privacy}","received_events_url":"https://api.github.com/users/dsummersl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsummersl/node-xml2js-xpath","description":"Search xml2js JSON documents with XPath query strings.","fork":false,"url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath","forks_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/forks","keys_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/teams","hooks_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/hooks","issue_events_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/events{/number}","events_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/events","assignees_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/assignees{/user}","branches_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/branches{/branch}","tags_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/tags","blobs_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/statuses/{sha}","languages_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/languages","stargazers_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/stargazers","contributors_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/contributors","subscribers_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/subscribers","subscription_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/subscription","commits_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/contents/{+path}","compare_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/merges","archive_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/downloads","issues_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues{/number}","pulls_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls{/number}","milestones_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/milestones{/number}","notifications_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/labels{/name}","releases_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/releases{/id}","deployments_url":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/deployments","created_at":"2014-10-24T17:33:00Z","updated_at":"2016-11-10T09:10:46Z","pushed_at":"2016-08-29T02:00:15Z","git_url":"git://github.com/dsummersl/node-xml2js-xpath.git","ssh_url":"git@github.com:dsummersl/node-xml2js-xpath.git","clone_url":"https://github.com/dsummersl/node-xml2js-xpath.git","svn_url":"https://github.com/dsummersl/node-xml2js-xpath","homepage":null,"size":28,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9"},"html":{"href":"https://github.com/dsummersl/node-xml2js-xpath/pull/9"},"issue":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/9"},"comments":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/dsummersl/node-xml2js-xpath/statuses/f7c582cbc805cc64988c90d751721056cf965bf5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":42,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"krugar"}}