{"action":"created","issue":{"url":"https://api.github.com/repos/secdev/scapy/issues/27","labels_url":"https://api.github.com/repos/secdev/scapy/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/27/comments","events_url":"https://api.github.com/repos/secdev/scapy/issues/27/events","html_url":"https://github.com/secdev/scapy/pull/27","id":128159974,"number":27,"title":"Matplotlib support","user":{"login":"guedou","id":11683796,"avatar_url":"https://avatars.githubusercontent.com/u/11683796?v=3","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/secdev/scapy/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-22T13:47:16Z","updated_at":"2016-01-22T22:41:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/27","html_url":"https://github.com/secdev/scapy/pull/27","diff_url":"https://github.com/secdev/scapy/pull/27.diff","patch_url":"https://github.com/secdev/scapy/pull/27.patch"},"body":"Hi,\r\n\r\nHere is a modified version of the PR submitted on bitbucket. It aims to replace the dependency on gnuplot-py with maplotlib.\r\n\r\nThe main focus was on compatibility. Therefore, most of the time, old plot() commands will seamlessly work with this PR. Moreover, Scapy can now be used in IPython notebooks: plots are inlined.\r\n\r\nBesides the documentation that still refers to gnuplot, there is still one call to gnuplot in TracerouteResult.world_trace() which is broken since 2008, according to git blame (that is issue #28). \r\n\r\nGuillaume"},"comment":{"url":"https://api.github.com/repos/secdev/scapy/issues/comments/174077376","html_url":"https://github.com/secdev/scapy/pull/27#issuecomment-174077376","issue_url":"https://api.github.com/repos/secdev/scapy/issues/27","id":174077376,"user":{"login":"p-l-","id":5064814,"avatar_url":"https://avatars.githubusercontent.com/u/5064814?v=3","gravatar_id":"","url":"https://api.github.com/users/p-l-","html_url":"https://github.com/p-l-","followers_url":"https://api.github.com/users/p-l-/followers","following_url":"https://api.github.com/users/p-l-/following{/other_user}","gists_url":"https://api.github.com/users/p-l-/gists{/gist_id}","starred_url":"https://api.github.com/users/p-l-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-l-/subscriptions","organizations_url":"https://api.github.com/users/p-l-/orgs","repos_url":"https://api.github.com/users/p-l-/repos","events_url":"https://api.github.com/users/p-l-/events{/privacy}","received_events_url":"https://api.github.com/users/p-l-/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T22:41:13Z","updated_at":"2016-01-22T22:41:13Z","body":"Great work!\r\n\r\nUnless I'm wrong, `.multiplot()` behavior has changed: before, the expected result of the function was a two-element list/tuple (label, value), now it is (label, (xvalue, yvalue)).\r\n\r\nWhile it is great to have the ability to specify the xvalue as well as the yvalue, it would be nice to get the previous behavior by default?\r\n\r\nAlso, the (xvalue, yvalue) plots could be made available for `.plot()`?\r\n\r\nAlso, I don't get the caption with matplotlib and the dot are the same color, while the gnuplot code diplays a caption and uses different colors (see screenshots).\r\n\r\nCurrent code (using Gnuplot), using `ans.multiplot(lambda x: [x[1][IP].src, x[1][IP].id])`\r\n![scapy-multiplot-gnuplot](https://cloud.githubusercontent.com/assets/5064814/12524988/5d06583a-c161-11e5-8e87-bcfb0b33430e.png)\r\n\r\nThis code (using Matplotlib), using `ans.multiplot(lambda x: [x[1][IP].src, [x[1].time, x[1][IP].id]])`\r\n![scapy-multiplot-matplotlib](https://cloud.githubusercontent.com/assets/5064814/12524990/5fd12400-c161-11e5-9e09-6c24ba970a6a.png)\r\n"}}