{"action":"closed","number":304,"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304","id":87847956,"html_url":"https://github.com/cozy/cozy-proxy/pull/304","diff_url":"https://github.com/cozy/cozy-proxy/pull/304.diff","patch_url":"https://github.com/cozy/cozy-proxy/pull/304.patch","issue_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/304","number":304,"state":"closed","locked":false,"title":"Integrate onboarding component into existing application","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"body":"__Based on PR #303__\r\n\r\nThe main goal of this PR is to integrate previously commited onboarding into existing proxy application.\r\n\r\n## How it works\r\n\r\nThe idea is to get standalone and separated objects defining onboarding steps. They are located into the `steps` directory and listed into `steps/config.coffee`.\r\n\r\nThe application requires those steps objects and pass them to the onboarding component.\r\n\r\nSteps are minimal at this time, but we will enhance them in the next developments, and add methods dealing with validation logic, data fetching, etc. (if needed).\r\n\r\nAfter that, the application set up the router with specific routes for the steps. This part has been pretty poorly tested and it will surely need adjustment in the next improvements.\r\n\r\nThe main ideas are :\r\n* Set back the logic into the application class, to get all business code located in one place.\r\n* Configure and use the router externally, as his role should only be to route URL to methods.\r\n\r\nAll those points are of course discussable. However my opinion is that we should use it as it for now and implements one change at a time in the next developments.\r\n\r\n## Modelisation naive diagram\r\n![Diagram](https://raw.githubusercontent.com/gregorylegarec/cozy-proxy/9d5e6110e26215c67da621b3d4503daddfcd1fcf/client/doc/assets/onboarding-modelisation.jpg \"Modelisation naive diagram\")\r\n\r\n## Specific points\r\n### StepModel\r\nThe StepModel class may be a seen as a useless layer, but its role is to wrap our agnostic Step object to Backbone Model. So we can use it easily in Marionette View.\r\n\r\n## Next Steps\r\n* Our next work will be to plug it out with @misstick works on steps components API (or views); see https://github.com/cozy/cozy-proxy/pull/300\r\n\r\n* When all onboarding steps are done, nothing is implemented for the moment.\r\n\r\n__All this points are of course disccussable__.","created_at":"2016-10-04T08:00:06Z","updated_at":"2016-10-05T12:24:01Z","closed_at":"2016-10-05T12:24:01Z","merged_at":"2016-10-05T12:24:01Z","merge_commit_sha":"67e5504d14a836ee8036735f92b946c0fe4e0f6d","assignee":{"login":"CPatchane","id":10224453,"avatar_url":"https://avatars.githubusercontent.com/u/10224453?v=3","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"assignees":[{"login":"CPatchane","id":10224453,"avatar_url":"https://avatars.githubusercontent.com/u/10224453?v=3","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304/commits","review_comments_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304/comments","review_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/304/comments","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/d647282b8e6069aba0314fec75d599309ff5c720","head":{"label":"gregorylegarec:enhancement/onboarding-integration","ref":"enhancement/onboarding-integration","sha":"d647282b8e6069aba0314fec75d599309ff5c720","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"repo":{"id":69475341,"name":"cozy-proxy","full_name":"gregorylegarec/cozy-proxy","owner":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregorylegarec/cozy-proxy","description":"Cozy authentication and routing layer","fork":true,"url":"https://api.github.com/repos/gregorylegarec/cozy-proxy","forks_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/forks","keys_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/events","assignees_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/merges","archive_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/deployments","created_at":"2016-09-28T15:08:16Z","updated_at":"2016-09-28T15:08:17Z","pushed_at":"2016-10-05T12:20:58Z","git_url":"git://github.com/gregorylegarec/cozy-proxy.git","ssh_url":"git@github.com:gregorylegarec/cozy-proxy.git","clone_url":"https://github.com/gregorylegarec/cozy-proxy.git","svn_url":"https://github.com/gregorylegarec/cozy-proxy","homepage":"https://cozy.io","size":7302,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy:development","ref":"development","sha":"29a7b1f17697be8c92e0811a2eec10aef7c0c212","user":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"repo":{"id":3812481,"name":"cozy-proxy","full_name":"cozy/cozy-proxy","owner":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozy/cozy-proxy","description":"Cozy authentication and routing layer","fork":false,"url":"https://api.github.com/repos/cozy/cozy-proxy","forks_url":"https://api.github.com/repos/cozy/cozy-proxy/forks","keys_url":"https://api.github.com/repos/cozy/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/cozy/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/cozy/cozy-proxy/events","assignees_url":"https://api.github.com/repos/cozy/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/cozy/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/cozy/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/cozy/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/cozy/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/cozy/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/cozy/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/cozy/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/cozy/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy/cozy-proxy/merges","archive_url":"https://api.github.com/repos/cozy/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/cozy/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/cozy/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/cozy/cozy-proxy/deployments","created_at":"2012-03-23T20:53:26Z","updated_at":"2016-10-03T14:31:10Z","pushed_at":"2016-10-05T12:24:01Z","git_url":"git://github.com/cozy/cozy-proxy.git","ssh_url":"git@github.com:cozy/cozy-proxy.git","clone_url":"https://github.com/cozy/cozy-proxy.git","svn_url":"https://github.com/cozy/cozy-proxy","homepage":"https://cozy.io","size":7391,"stargazers_count":29,"watchers_count":29,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":30,"forks":35,"open_issues":30,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304"},"html":{"href":"https://github.com/cozy/cozy-proxy/pull/304"},"issue":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/304"},"comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/cozy/cozy-proxy/statuses/d647282b8e6069aba0314fec75d599309ff5c720"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"CPatchane","id":10224453,"avatar_url":"https://avatars.githubusercontent.com/u/10224453?v=3","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"comments":8,"review_comments":15,"commits":14,"additions":880,"deletions":4,"changed_files":21}}
{"actor":{"display_login":"CPatchane"}}