{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/58947391","id":58947391,"diff_hunk":"@@ -4,29 +4,35 @@ define('ext.wikia.recirculation.helpers.lateral', [\n \t'wikia.window',\n \t'wikia.abTest',\n ], function ($, w, abTest) {\n-\tvar libraryLoaded = false;\n+\tvar libraryLoaded = false,\n+\t\tqueue = [];\n \n \tfunction loadLateral(callback) {\n-\t\tif (libraryLoaded) {\n-\t\t\tif (callback) {\n-\t\t\t\tcallback(w.lateral);\n-\t\t\t}\n-\t\t\treturn;\n+\t\tqueue.push(callback);\n+\n+\t\tif (w.lateral) {\n+\t\t\tprocessQueue(w.lateral);\n \t\t}\n+\t\tif (!libraryLoaded) {\n+\t\t\tvar lateralScript = document.createElement('script');\n+\t\t\tlibraryLoaded = true;\n \n-\t\tvar lateralScript = document.createElement('script');\n+\t\t\tlateralScript.src = 'https://assets.lateral.io/recommendations.js';\n+\t\t\tdocument.getElementsByTagName('body')[0].appendChild(lateralScript);\n \n-\t\tlateralScript.src = 'https://assets.lateral.io/recommendations.js';\n-\t\tdocument.getElementsByTagName('body')[0].appendChild(lateralScript);\n+\t\t\t// This function is called when the Lateral script has loaded\n+\t\t\tw.onLoadLateral = function(lateral) {\n+\t\t\t\tw.lateral = lateral;\n+\t\t\t\tprocessQueue(lateral);\n+\t\t\t}\n+\t\t}\n+\t}\n \n-\t\t// This function is called when the Lateral script has loaded\n-\t\tw.onLoadLateral = function(lateral) {\n-\t\t\tw.lateral = lateral;\n-\t\t\tlibraryLoaded = true;\n+\tfunction processQueue(lateral) {\n+\t\twhile(queue.length > 0) {\n+\t\t\tvar callback = queue.pop();","path":"extensions/wikia/Recirculation/js/helpers/LateralHelper.js","position":43,"original_position":43,"commit_id":"939d6c8f1fee5e55c0f274330d86eaa2d25e33b5","original_commit_id":"939d6c8f1fee5e55c0f274330d86eaa2d25e33b5","user":{"login":"gabrys","id":74567,"avatar_url":"https://avatars.githubusercontent.com/u/74567?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrys","html_url":"https://github.com/gabrys","followers_url":"https://api.github.com/users/gabrys/followers","following_url":"https://api.github.com/users/gabrys/following{/other_user}","gists_url":"https://api.github.com/users/gabrys/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrys/subscriptions","organizations_url":"https://api.github.com/users/gabrys/orgs","repos_url":"https://api.github.com/users/gabrys/repos","events_url":"https://api.github.com/users/gabrys/events{/privacy}","received_events_url":"https://api.github.com/users/gabrys/received_events","type":"User","site_admin":false},"body":"`pop` will start with the item that was `push` most recently. `shift` should be better.","created_at":"2016-04-07T21:21:54Z","updated_at":"2016-04-07T21:21:54Z","html_url":"https://github.com/Wikia/app/pull/10188#discussion_r58947391","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/10188","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/58947391"},"html":{"href":"https://github.com/Wikia/app/pull/10188#discussion_r58947391"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/10188"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/10188","id":65698122,"html_url":"https://github.com/Wikia/app/pull/10188","diff_url":"https://github.com/Wikia/app/pull/10188.diff","patch_url":"https://github.com/Wikia/app/pull/10188.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/10188","number":10188,"state":"open","locked":false,"title":"RECIRC 94: Improve loading of Lateral","user":{"login":"pauloslund","id":1051164,"avatar_url":"https://avatars.githubusercontent.com/u/1051164?v=3","gravatar_id":"","url":"https://api.github.com/users/pauloslund","html_url":"https://github.com/pauloslund","followers_url":"https://api.github.com/users/pauloslund/followers","following_url":"https://api.github.com/users/pauloslund/following{/other_user}","gists_url":"https://api.github.com/users/pauloslund/gists{/gist_id}","starred_url":"https://api.github.com/users/pauloslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauloslund/subscriptions","organizations_url":"https://api.github.com/users/pauloslund/orgs","repos_url":"https://api.github.com/users/pauloslund/repos","events_url":"https://api.github.com/users/pauloslund/events{/privacy}","received_events_url":"https://api.github.com/users/pauloslund/received_events","type":"User","site_admin":false},"body":"There are currently instances where the Lateral script is getting loaded twice, which is causing issues with analytics data. This change makes it so the call to load lateral will only get run once, and callbacks get added to a queue to be run after Lateral has finished loading. This PR also adds client side error logging for the placement test.","created_at":"2016-04-07T20:55:13Z","updated_at":"2016-04-07T21:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92249c68411f4bfcdee2aae234b175d57c9397bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/10188/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/10188/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/10188/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/939d6c8f1fee5e55c0f274330d86eaa2d25e33b5","head":{"label":"Wikia:RECIRC-94","ref":"RECIRC-94","sha":"939d6c8f1fee5e55c0f274330d86eaa2d25e33b5","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-04-06T08:17:14Z","pushed_at":"2016-04-07T20:55:13Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":693764,"stargazers_count":96,"watchers_count":96,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":96,"forks":77,"open_issues":96,"watchers":96,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"953d1a11217d7a1945894fd45715de2d10935e57","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-04-06T08:17:14Z","pushed_at":"2016-04-07T20:55:13Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":693764,"stargazers_count":96,"watchers_count":96,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":96,"forks":77,"open_issues":96,"watchers":96,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/10188"},"html":{"href":"https://github.com/Wikia/app/pull/10188"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/10188"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/10188/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/10188/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/10188/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/939d6c8f1fee5e55c0f274330d86eaa2d25e33b5"}}}}