{"action":"created","comment":{"url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/comments/63939776","id":63939776,"diff_hunk":"@@ -156,24 +157,33 @@ def can_plot(self):\n \n     @property\n     def canvas(self):\n-        # print \"MANAGER CANVAS:\", self.source.canvas\n         return self.source.canvas\n \n     def gm(self):\n-        return self._gm\n+        return vcs.getgraphicsmethod(self._type, self._gm)\n \n     def set_gm(self, gm):\n-        # check gm vs vars\n-        self._gm = gm\n-        if self.can_plot():\n+        plot = True\n+        if isinstance(gm, tuple):\n+            plot = gm[1]\n+            gm = gm[0]\n+\n+        self._gm = gm.name\n+        self._type = vcs.graphicsmethodtype(gm)\n+        if plot and self.can_plot():\n             self.plot()\n+        self.source.gm_label.setText(self._gm)\n \n     graphics_method = property(gm, set_gm)\n \n     def get_vars(self):\n         return self._vars\n \n     def set_vars(self, v):\n+        plot = True","path":"cdatgui/cdat/plotter.py","position":57,"original_position":57,"commit_id":"a4ba92ce5eaad8b3667f402c6f580a3a9367b58e","original_commit_id":"a4ba92ce5eaad8b3667f402c6f580a3a9367b58e","user":{"login":"sampsonbryce","id":9360861,"avatar_url":"https://avatars.githubusercontent.com/u/9360861?v=3","gravatar_id":"","url":"https://api.github.com/users/sampsonbryce","html_url":"https://github.com/sampsonbryce","followers_url":"https://api.github.com/users/sampsonbryce/followers","following_url":"https://api.github.com/users/sampsonbryce/following{/other_user}","gists_url":"https://api.github.com/users/sampsonbryce/gists{/gist_id}","starred_url":"https://api.github.com/users/sampsonbryce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampsonbryce/subscriptions","organizations_url":"https://api.github.com/users/sampsonbryce/orgs","repos_url":"https://api.github.com/users/sampsonbryce/repos","events_url":"https://api.github.com/users/sampsonbryce/events{/privacy}","received_events_url":"https://api.github.com/users/sampsonbryce/received_events","type":"User","site_admin":false},"body":"I agree this is a hacky solution. \r\nMost of the uses are in the inspector widget. For example starting at line 236: \r\n`      if enabled and self.var_combos[1].currentIndex() == -1:\r\n            gm = vcs.getgraphicsmethod(gm_type, gm_name)\r\n            self.current_plot.graphics_method = (gm, False)\r\n        else:\r\n            gm = vcs.getgraphicsmethod(gm_type, gm_name)\r\n            self.current_plot.graphics_method = (gm, False)`","created_at":"2016-05-19T19:28:28Z","updated_at":"2016-05-19T19:28:28Z","html_url":"https://github.com/UV-CDAT/cdatgui/pull/24#discussion_r63939776","pull_request_url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/comments/63939776"},"html":{"href":"https://github.com/UV-CDAT/cdatgui/pull/24#discussion_r63939776"},"pull_request":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24","id":69737037,"html_url":"https://github.com/UV-CDAT/cdatgui/pull/24","diff_url":"https://github.com/UV-CDAT/cdatgui/pull/24.diff","patch_url":"https://github.com/UV-CDAT/cdatgui/pull/24.patch","issue_url":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/24","number":24,"state":"open","locked":false,"title":"Gm editors","user":{"login":"sampsonbryce","id":9360861,"avatar_url":"https://avatars.githubusercontent.com/u/9360861?v=3","gravatar_id":"","url":"https://api.github.com/users/sampsonbryce","html_url":"https://github.com/sampsonbryce","followers_url":"https://api.github.com/users/sampsonbryce/followers","following_url":"https://api.github.com/users/sampsonbryce/following{/other_user}","gists_url":"https://api.github.com/users/sampsonbryce/gists{/gist_id}","starred_url":"https://api.github.com/users/sampsonbryce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampsonbryce/subscriptions","organizations_url":"https://api.github.com/users/sampsonbryce/orgs","repos_url":"https://api.github.com/users/sampsonbryce/repos","events_url":"https://api.github.com/users/sampsonbryce/events{/privacy}","received_events_url":"https://api.github.com/users/sampsonbryce/received_events","type":"User","site_admin":false},"body":"biiiiiggg PR. Looking to start work on climateologies.","created_at":"2016-05-11T20:29:49Z","updated_at":"2016-05-19T19:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e583f0f53f8120e385d8a867fce6f0ed6948900e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24/commits","review_comments_url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24/comments","review_comment_url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/24/comments","statuses_url":"https://api.github.com/repos/UV-CDAT/cdatgui/statuses/a4ba92ce5eaad8b3667f402c6f580a3a9367b58e","head":{"label":"sampsonbryce:gm_editors","ref":"gm_editors","sha":"a4ba92ce5eaad8b3667f402c6f580a3a9367b58e","user":{"login":"sampsonbryce","id":9360861,"avatar_url":"https://avatars.githubusercontent.com/u/9360861?v=3","gravatar_id":"","url":"https://api.github.com/users/sampsonbryce","html_url":"https://github.com/sampsonbryce","followers_url":"https://api.github.com/users/sampsonbryce/followers","following_url":"https://api.github.com/users/sampsonbryce/following{/other_user}","gists_url":"https://api.github.com/users/sampsonbryce/gists{/gist_id}","starred_url":"https://api.github.com/users/sampsonbryce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampsonbryce/subscriptions","organizations_url":"https://api.github.com/users/sampsonbryce/orgs","repos_url":"https://api.github.com/users/sampsonbryce/repos","events_url":"https://api.github.com/users/sampsonbryce/events{/privacy}","received_events_url":"https://api.github.com/users/sampsonbryce/received_events","type":"User","site_admin":false},"repo":{"id":50063370,"name":"cdatgui","full_name":"sampsonbryce/cdatgui","owner":{"login":"sampsonbryce","id":9360861,"avatar_url":"https://avatars.githubusercontent.com/u/9360861?v=3","gravatar_id":"","url":"https://api.github.com/users/sampsonbryce","html_url":"https://github.com/sampsonbryce","followers_url":"https://api.github.com/users/sampsonbryce/followers","following_url":"https://api.github.com/users/sampsonbryce/following{/other_user}","gists_url":"https://api.github.com/users/sampsonbryce/gists{/gist_id}","starred_url":"https://api.github.com/users/sampsonbryce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampsonbryce/subscriptions","organizations_url":"https://api.github.com/users/sampsonbryce/orgs","repos_url":"https://api.github.com/users/sampsonbryce/repos","events_url":"https://api.github.com/users/sampsonbryce/events{/privacy}","received_events_url":"https://api.github.com/users/sampsonbryce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sampsonbryce/cdatgui","description":"Temporary home of UV-CDAT GUI refactor","fork":true,"url":"https://api.github.com/repos/sampsonbryce/cdatgui","forks_url":"https://api.github.com/repos/sampsonbryce/cdatgui/forks","keys_url":"https://api.github.com/repos/sampsonbryce/cdatgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sampsonbryce/cdatgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sampsonbryce/cdatgui/teams","hooks_url":"https://api.github.com/repos/sampsonbryce/cdatgui/hooks","issue_events_url":"https://api.github.com/repos/sampsonbryce/cdatgui/issues/events{/number}","events_url":"https://api.github.com/repos/sampsonbryce/cdatgui/events","assignees_url":"https://api.github.com/repos/sampsonbryce/cdatgui/assignees{/user}","branches_url":"https://api.github.com/repos/sampsonbryce/cdatgui/branches{/branch}","tags_url":"https://api.github.com/repos/sampsonbryce/cdatgui/tags","blobs_url":"https://api.github.com/repos/sampsonbryce/cdatgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sampsonbryce/cdatgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sampsonbryce/cdatgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sampsonbryce/cdatgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sampsonbryce/cdatgui/statuses/{sha}","languages_url":"https://api.github.com/repos/sampsonbryce/cdatgui/languages","stargazers_url":"https://api.github.com/repos/sampsonbryce/cdatgui/stargazers","contributors_url":"https://api.github.com/repos/sampsonbryce/cdatgui/contributors","subscribers_url":"https://api.github.com/repos/sampsonbryce/cdatgui/subscribers","subscription_url":"https://api.github.com/repos/sampsonbryce/cdatgui/subscription","commits_url":"https://api.github.com/repos/sampsonbryce/cdatgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sampsonbryce/cdatgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sampsonbryce/cdatgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sampsonbryce/cdatgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sampsonbryce/cdatgui/contents/{+path}","compare_url":"https://api.github.com/repos/sampsonbryce/cdatgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sampsonbryce/cdatgui/merges","archive_url":"https://api.github.com/repos/sampsonbryce/cdatgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sampsonbryce/cdatgui/downloads","issues_url":"https://api.github.com/repos/sampsonbryce/cdatgui/issues{/number}","pulls_url":"https://api.github.com/repos/sampsonbryce/cdatgui/pulls{/number}","milestones_url":"https://api.github.com/repos/sampsonbryce/cdatgui/milestones{/number}","notifications_url":"https://api.github.com/repos/sampsonbryce/cdatgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sampsonbryce/cdatgui/labels{/name}","releases_url":"https://api.github.com/repos/sampsonbryce/cdatgui/releases{/id}","deployments_url":"https://api.github.com/repos/sampsonbryce/cdatgui/deployments","created_at":"2016-01-20T21:59:06Z","updated_at":"2016-01-20T21:59:07Z","pushed_at":"2016-05-19T16:43:15Z","git_url":"git://github.com/sampsonbryce/cdatgui.git","ssh_url":"git@github.com:sampsonbryce/cdatgui.git","clone_url":"https://github.com/sampsonbryce/cdatgui.git","svn_url":"https://github.com/sampsonbryce/cdatgui","homepage":null,"size":2057,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UV-CDAT:master","ref":"master","sha":"5db988c2a29d64816a6b0ad2d9e6cc0290ffe521","user":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":39972820,"name":"cdatgui","full_name":"UV-CDAT/cdatgui","owner":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UV-CDAT/cdatgui","description":"Temporary home of UV-CDAT GUI refactor","fork":false,"url":"https://api.github.com/repos/UV-CDAT/cdatgui","forks_url":"https://api.github.com/repos/UV-CDAT/cdatgui/forks","keys_url":"https://api.github.com/repos/UV-CDAT/cdatgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UV-CDAT/cdatgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UV-CDAT/cdatgui/teams","hooks_url":"https://api.github.com/repos/UV-CDAT/cdatgui/hooks","issue_events_url":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/events{/number}","events_url":"https://api.github.com/repos/UV-CDAT/cdatgui/events","assignees_url":"https://api.github.com/repos/UV-CDAT/cdatgui/assignees{/user}","branches_url":"https://api.github.com/repos/UV-CDAT/cdatgui/branches{/branch}","tags_url":"https://api.github.com/repos/UV-CDAT/cdatgui/tags","blobs_url":"https://api.github.com/repos/UV-CDAT/cdatgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UV-CDAT/cdatgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UV-CDAT/cdatgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/UV-CDAT/cdatgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UV-CDAT/cdatgui/statuses/{sha}","languages_url":"https://api.github.com/repos/UV-CDAT/cdatgui/languages","stargazers_url":"https://api.github.com/repos/UV-CDAT/cdatgui/stargazers","contributors_url":"https://api.github.com/repos/UV-CDAT/cdatgui/contributors","subscribers_url":"https://api.github.com/repos/UV-CDAT/cdatgui/subscribers","subscription_url":"https://api.github.com/repos/UV-CDAT/cdatgui/subscription","commits_url":"https://api.github.com/repos/UV-CDAT/cdatgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/UV-CDAT/cdatgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/UV-CDAT/cdatgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/UV-CDAT/cdatgui/contents/{+path}","compare_url":"https://api.github.com/repos/UV-CDAT/cdatgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UV-CDAT/cdatgui/merges","archive_url":"https://api.github.com/repos/UV-CDAT/cdatgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UV-CDAT/cdatgui/downloads","issues_url":"https://api.github.com/repos/UV-CDAT/cdatgui/issues{/number}","pulls_url":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls{/number}","milestones_url":"https://api.github.com/repos/UV-CDAT/cdatgui/milestones{/number}","notifications_url":"https://api.github.com/repos/UV-CDAT/cdatgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UV-CDAT/cdatgui/labels{/name}","releases_url":"https://api.github.com/repos/UV-CDAT/cdatgui/releases{/id}","deployments_url":"https://api.github.com/repos/UV-CDAT/cdatgui/deployments","created_at":"2015-07-30T21:14:25Z","updated_at":"2016-04-13T17:26:56Z","pushed_at":"2016-05-11T20:29:50Z","git_url":"git://github.com/UV-CDAT/cdatgui.git","ssh_url":"git@github.com:UV-CDAT/cdatgui.git","clone_url":"https://github.com/UV-CDAT/cdatgui.git","svn_url":"https://github.com/UV-CDAT/cdatgui","homepage":null,"size":1972,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24"},"html":{"href":"https://github.com/UV-CDAT/cdatgui/pull/24"},"issue":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/24"},"comments":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/UV-CDAT/cdatgui/statuses/a4ba92ce5eaad8b3667f402c6f580a3a9367b58e"}}}}