{"action":"created","comment":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/comments/74533905","id":74533905,"diff_hunk":"@@ -82,22 +81,11 @@\n             jQuery(selector + ' a.cancel').on(\"click\", function(event) {\n               event.preventDefault();\n \n-              var returnToPointer = function(){\n-                _this.eventEmitter.publish('SET_STATE_MACHINE_POINTER.' + _this.windowId);\n+              var cancelCallback = function(){\n                 api.destroy();\n-                if (params.onCancel) { params.onCancel(); }\n               };\n \n-              if (_this.activeEditor.isDirty()) {\n-                new $.DialogBuilder().confirm(i18n.t('cancelAnnotation'),function(result){","path":"js/src/annotations/annotationTooltip.js","position":20,"original_position":20,"commit_id":"c0313d6183ae5b1840cd9c9e55ed54f95b957f88","original_commit_id":"c0313d6183ae5b1840cd9c9e55ed54f95b957f88","user":{"login":"rsinghal","id":2371632,"avatar_url":"https://avatars.githubusercontent.com/u/2371632?v=3","gravatar_id":"","url":"https://api.github.com/users/rsinghal","html_url":"https://github.com/rsinghal","followers_url":"https://api.github.com/users/rsinghal/followers","following_url":"https://api.github.com/users/rsinghal/following{/other_user}","gists_url":"https://api.github.com/users/rsinghal/gists{/gist_id}","starred_url":"https://api.github.com/users/rsinghal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsinghal/subscriptions","organizations_url":"https://api.github.com/users/rsinghal/orgs","repos_url":"https://api.github.com/users/rsinghal/repos","events_url":"https://api.github.com/users/rsinghal/events{/privacy}","received_events_url":"https://api.github.com/users/rsinghal/received_events","type":"User","site_admin":false},"body":"Looks like you are not passing the isDirty check in the event publisher so it's showing the dialog on an empty text editor.","created_at":"2016-08-12T02:19:54Z","updated_at":"2016-08-12T02:19:54Z","html_url":"https://github.com/IIIF/mirador/pull/1043#discussion_r74533905","pull_request_url":"https://api.github.com/repos/IIIF/mirador/pulls/1043","_links":{"self":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/comments/74533905"},"html":{"href":"https://github.com/IIIF/mirador/pull/1043#discussion_r74533905"},"pull_request":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1043"}}},"pull_request":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/1043","id":80964342,"html_url":"https://github.com/IIIF/mirador/pull/1043","diff_url":"https://github.com/IIIF/mirador/pull/1043.diff","patch_url":"https://github.com/IIIF/mirador/pull/1043.patch","issue_url":"https://api.github.com/repos/IIIF/mirador/issues/1043","number":1043,"state":"open","locked":false,"title":"Feature/integration improvements","user":{"login":"radpet","id":13572835,"avatar_url":"https://avatars.githubusercontent.com/u/13572835?v=3","gravatar_id":"","url":"https://api.github.com/users/radpet","html_url":"https://github.com/radpet","followers_url":"https://api.github.com/users/radpet/followers","following_url":"https://api.github.com/users/radpet/following{/other_user}","gists_url":"https://api.github.com/users/radpet/gists{/gist_id}","starred_url":"https://api.github.com/users/radpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radpet/subscriptions","organizations_url":"https://api.github.com/users/radpet/orgs","repos_url":"https://api.github.com/users/radpet/repos","events_url":"https://api.github.com/users/radpet/events{/privacy}","received_events_url":"https://api.github.com/users/radpet/received_events","type":"User","site_admin":false},"body":"# This pull request fixes:\r\n\r\nMemory leaks caused by not unsubscribing from events when object is not used any more\r\nHandle refresh annotation action properly\r\n\r\n# This pull request adds:\r\n\r\nEvents that handle all annotation logic inside overlay in order to remove them from the annotation-tooltip object\r\n\r\n\r\n","created_at":"2016-08-11T14:11:29Z","updated_at":"2016-08-12T02:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"886f0ed9750777571b1c67e64ff2c3703dbacd6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IIIF/mirador/pulls/1043/commits","review_comments_url":"https://api.github.com/repos/IIIF/mirador/pulls/1043/comments","review_comment_url":"https://api.github.com/repos/IIIF/mirador/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IIIF/mirador/issues/1043/comments","statuses_url":"https://api.github.com/repos/IIIF/mirador/statuses/c0313d6183ae5b1840cd9c9e55ed54f95b957f88","head":{"label":"SirmaITT:feature/integration-improvements","ref":"feature/integration-improvements","sha":"c0313d6183ae5b1840cd9c9e55ed54f95b957f88","user":{"login":"SirmaITT","id":8133646,"avatar_url":"https://avatars.githubusercontent.com/u/8133646?v=3","gravatar_id":"","url":"https://api.github.com/users/SirmaITT","html_url":"https://github.com/SirmaITT","followers_url":"https://api.github.com/users/SirmaITT/followers","following_url":"https://api.github.com/users/SirmaITT/following{/other_user}","gists_url":"https://api.github.com/users/SirmaITT/gists{/gist_id}","starred_url":"https://api.github.com/users/SirmaITT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirmaITT/subscriptions","organizations_url":"https://api.github.com/users/SirmaITT/orgs","repos_url":"https://api.github.com/users/SirmaITT/repos","events_url":"https://api.github.com/users/SirmaITT/events{/privacy}","received_events_url":"https://api.github.com/users/SirmaITT/received_events","type":"User","site_admin":false},"repo":{"id":47995293,"name":"mirador","full_name":"SirmaITT/mirador","owner":{"login":"SirmaITT","id":8133646,"avatar_url":"https://avatars.githubusercontent.com/u/8133646?v=3","gravatar_id":"","url":"https://api.github.com/users/SirmaITT","html_url":"https://github.com/SirmaITT","followers_url":"https://api.github.com/users/SirmaITT/followers","following_url":"https://api.github.com/users/SirmaITT/following{/other_user}","gists_url":"https://api.github.com/users/SirmaITT/gists{/gist_id}","starred_url":"https://api.github.com/users/SirmaITT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirmaITT/subscriptions","organizations_url":"https://api.github.com/users/SirmaITT/orgs","repos_url":"https://api.github.com/users/SirmaITT/repos","events_url":"https://api.github.com/users/SirmaITT/events{/privacy}","received_events_url":"https://api.github.com/users/SirmaITT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SirmaITT/mirador","description":"An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.","fork":true,"url":"https://api.github.com/repos/SirmaITT/mirador","forks_url":"https://api.github.com/repos/SirmaITT/mirador/forks","keys_url":"https://api.github.com/repos/SirmaITT/mirador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SirmaITT/mirador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SirmaITT/mirador/teams","hooks_url":"https://api.github.com/repos/SirmaITT/mirador/hooks","issue_events_url":"https://api.github.com/repos/SirmaITT/mirador/issues/events{/number}","events_url":"https://api.github.com/repos/SirmaITT/mirador/events","assignees_url":"https://api.github.com/repos/SirmaITT/mirador/assignees{/user}","branches_url":"https://api.github.com/repos/SirmaITT/mirador/branches{/branch}","tags_url":"https://api.github.com/repos/SirmaITT/mirador/tags","blobs_url":"https://api.github.com/repos/SirmaITT/mirador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SirmaITT/mirador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SirmaITT/mirador/git/refs{/sha}","trees_url":"https://api.github.com/repos/SirmaITT/mirador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SirmaITT/mirador/statuses/{sha}","languages_url":"https://api.github.com/repos/SirmaITT/mirador/languages","stargazers_url":"https://api.github.com/repos/SirmaITT/mirador/stargazers","contributors_url":"https://api.github.com/repos/SirmaITT/mirador/contributors","subscribers_url":"https://api.github.com/repos/SirmaITT/mirador/subscribers","subscription_url":"https://api.github.com/repos/SirmaITT/mirador/subscription","commits_url":"https://api.github.com/repos/SirmaITT/mirador/commits{/sha}","git_commits_url":"https://api.github.com/repos/SirmaITT/mirador/git/commits{/sha}","comments_url":"https://api.github.com/repos/SirmaITT/mirador/comments{/number}","issue_comment_url":"https://api.github.com/repos/SirmaITT/mirador/issues/comments{/number}","contents_url":"https://api.github.com/repos/SirmaITT/mirador/contents/{+path}","compare_url":"https://api.github.com/repos/SirmaITT/mirador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SirmaITT/mirador/merges","archive_url":"https://api.github.com/repos/SirmaITT/mirador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SirmaITT/mirador/downloads","issues_url":"https://api.github.com/repos/SirmaITT/mirador/issues{/number}","pulls_url":"https://api.github.com/repos/SirmaITT/mirador/pulls{/number}","milestones_url":"https://api.github.com/repos/SirmaITT/mirador/milestones{/number}","notifications_url":"https://api.github.com/repos/SirmaITT/mirador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SirmaITT/mirador/labels{/name}","releases_url":"https://api.github.com/repos/SirmaITT/mirador/releases{/id}","deployments_url":"https://api.github.com/repos/SirmaITT/mirador/deployments","created_at":"2015-12-14T19:05:33Z","updated_at":"2016-01-14T08:42:17Z","pushed_at":"2016-08-11T14:13:53Z","git_url":"git://github.com/SirmaITT/mirador.git","ssh_url":"git@github.com:SirmaITT/mirador.git","clone_url":"https://github.com/SirmaITT/mirador.git","svn_url":"https://github.com/SirmaITT/mirador","homepage":"","size":9628,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"release2.1"}},"base":{"label":"IIIF:annotation-work","ref":"annotation-work","sha":"5d67ac218d70232afe2198f642c62aab9f2e3717","user":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"repo":{"id":19078059,"name":"mirador","full_name":"IIIF/mirador","owner":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IIIF/mirador","description":"An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.","fork":false,"url":"https://api.github.com/repos/IIIF/mirador","forks_url":"https://api.github.com/repos/IIIF/mirador/forks","keys_url":"https://api.github.com/repos/IIIF/mirador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IIIF/mirador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IIIF/mirador/teams","hooks_url":"https://api.github.com/repos/IIIF/mirador/hooks","issue_events_url":"https://api.github.com/repos/IIIF/mirador/issues/events{/number}","events_url":"https://api.github.com/repos/IIIF/mirador/events","assignees_url":"https://api.github.com/repos/IIIF/mirador/assignees{/user}","branches_url":"https://api.github.com/repos/IIIF/mirador/branches{/branch}","tags_url":"https://api.github.com/repos/IIIF/mirador/tags","blobs_url":"https://api.github.com/repos/IIIF/mirador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IIIF/mirador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IIIF/mirador/git/refs{/sha}","trees_url":"https://api.github.com/repos/IIIF/mirador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IIIF/mirador/statuses/{sha}","languages_url":"https://api.github.com/repos/IIIF/mirador/languages","stargazers_url":"https://api.github.com/repos/IIIF/mirador/stargazers","contributors_url":"https://api.github.com/repos/IIIF/mirador/contributors","subscribers_url":"https://api.github.com/repos/IIIF/mirador/subscribers","subscription_url":"https://api.github.com/repos/IIIF/mirador/subscription","commits_url":"https://api.github.com/repos/IIIF/mirador/commits{/sha}","git_commits_url":"https://api.github.com/repos/IIIF/mirador/git/commits{/sha}","comments_url":"https://api.github.com/repos/IIIF/mirador/comments{/number}","issue_comment_url":"https://api.github.com/repos/IIIF/mirador/issues/comments{/number}","contents_url":"https://api.github.com/repos/IIIF/mirador/contents/{+path}","compare_url":"https://api.github.com/repos/IIIF/mirador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IIIF/mirador/merges","archive_url":"https://api.github.com/repos/IIIF/mirador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IIIF/mirador/downloads","issues_url":"https://api.github.com/repos/IIIF/mirador/issues{/number}","pulls_url":"https://api.github.com/repos/IIIF/mirador/pulls{/number}","milestones_url":"https://api.github.com/repos/IIIF/mirador/milestones{/number}","notifications_url":"https://api.github.com/repos/IIIF/mirador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IIIF/mirador/labels{/name}","releases_url":"https://api.github.com/repos/IIIF/mirador/releases{/id}","deployments_url":"https://api.github.com/repos/IIIF/mirador/deployments","created_at":"2014-04-23T17:02:00Z","updated_at":"2016-08-10T14:27:28Z","pushed_at":"2016-08-12T00:46:42Z","git_url":"git://github.com/IIIF/mirador.git","ssh_url":"git@github.com:IIIF/mirador.git","clone_url":"https://github.com/IIIF/mirador.git","svn_url":"https://github.com/IIIF/mirador","homepage":"","size":11856,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":201,"forks":63,"open_issues":201,"watchers":108,"default_branch":"release2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1043"},"html":{"href":"https://github.com/IIIF/mirador/pull/1043"},"issue":{"href":"https://api.github.com/repos/IIIF/mirador/issues/1043"},"comments":{"href":"https://api.github.com/repos/IIIF/mirador/issues/1043/comments"},"review_comments":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1043/comments"},"review_comment":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1043/commits"},"statuses":{"href":"https://api.github.com/repos/IIIF/mirador/statuses/c0313d6183ae5b1840cd9c9e55ed54f95b957f88"}}}}
{"actor":{"display_login":"rsinghal"}}