{"action":"created","comment":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/61085093","id":61085093,"diff_hunk":"@@ -318,21 +318,33 @@ def _get_features(params, extended=False):\n             yield _get_feature_db(featureId, params, models)\n \n \n+def is_valid_id_value(column, value):\n+    column_type = column.type\n+    python_type = column_type.python_type","path":"chsdi/views/features.py","position":15,"original_position":15,"commit_id":"e2200ad8030eb059d32fc73546d2305a5674c097","original_commit_id":"e2200ad8030eb059d32fc73546d2305a5674c097","user":{"login":"gjn","id":2572317,"avatar_url":"https://avatars.githubusercontent.com/u/2572317?v=3","gravatar_id":"","url":"https://api.github.com/users/gjn","html_url":"https://github.com/gjn","followers_url":"https://api.github.com/users/gjn/followers","following_url":"https://api.github.com/users/gjn/following{/other_user}","gists_url":"https://api.github.com/users/gjn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjn/subscriptions","organizations_url":"https://api.github.com/users/gjn/orgs","repos_url":"https://api.github.com/users/gjn/repos","events_url":"https://api.github.com/users/gjn/events{/privacy}","received_events_url":"https://api.github.com/users/gjn/received_events","type":"User","site_admin":false},"body":"Where is this coming from? (From sqlAlchemy?)","created_at":"2016-04-26T13:32:06Z","updated_at":"2016-04-26T13:32:06Z","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/2046#discussion_r61085093","pull_request_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/61085093"},"html":{"href":"https://github.com/geoadmin/mf-chsdi3/pull/2046#discussion_r61085093"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046"}}},"pull_request":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046","id":67883640,"html_url":"https://github.com/geoadmin/mf-chsdi3/pull/2046","diff_url":"https://github.com/geoadmin/mf-chsdi3/pull/2046.diff","patch_url":"https://github.com/geoadmin/mf-chsdi3/pull/2046.patch","issue_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/2046","number":2046,"state":"open","locked":false,"title":"Sanatize ids during getFeature","user":{"login":"loicgasser","id":3306154,"avatar_url":"https://avatars.githubusercontent.com/u/3306154?v=3","gravatar_id":"","url":"https://api.github.com/users/loicgasser","html_url":"https://github.com/loicgasser","followers_url":"https://api.github.com/users/loicgasser/followers","following_url":"https://api.github.com/users/loicgasser/following{/other_user}","gists_url":"https://api.github.com/users/loicgasser/gists{/gist_id}","starred_url":"https://api.github.com/users/loicgasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loicgasser/subscriptions","organizations_url":"https://api.github.com/users/loicgasser/orgs","repos_url":"https://api.github.com/users/loicgasser/repos","events_url":"https://api.github.com/users/loicgasser/events{/privacy}","received_events_url":"https://api.github.com/users/loicgasser/received_events","type":"User","site_admin":false},"body":"With the new geocover \"shop\" update we have primary keys of different types.\r\n\r\nFor some models the id is some text and for some other we have integers...\r\n\r\nThis is to handle the case where we would request a table using the wrong type.\r\n\r\nI would add that this is a temporary and I have a greater scheme to handle all these border line cases.\r\n\r\n@gjn Please have a look.","created_at":"2016-04-26T13:17:21Z","updated_at":"2016-04-26T13:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afaa6f931bb60620ad31b00a4c42d3829a0c0b5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046/commits","review_comments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046/comments","review_comment_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/2046/comments","statuses_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/statuses/e2200ad8030eb059d32fc73546d2305a5674c097","head":{"label":"geoadmin:gal_valid_id","ref":"gal_valid_id","sha":"e2200ad8030eb059d32fc73546d2305a5674c097","user":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=3","gravatar_id":"","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":10399553,"name":"mf-chsdi3","full_name":"geoadmin/mf-chsdi3","owner":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=3","gravatar_id":"","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoadmin/mf-chsdi3","description":"api3.geo.admin.ch source code. ","fork":false,"url":"https://api.github.com/repos/geoadmin/mf-chsdi3","forks_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/forks","keys_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/teams","hooks_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/hooks","issue_events_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/events{/number}","events_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/events","assignees_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/assignees{/user}","branches_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/branches{/branch}","tags_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/tags","blobs_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/statuses/{sha}","languages_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/languages","stargazers_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/stargazers","contributors_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/contributors","subscribers_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/subscribers","subscription_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/subscription","commits_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/contents/{+path}","compare_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/merges","archive_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/downloads","issues_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues{/number}","pulls_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls{/number}","milestones_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/milestones{/number}","notifications_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/labels{/name}","releases_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/releases{/id}","deployments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/deployments","created_at":"2013-05-31T06:59:44Z","updated_at":"2016-02-16T10:24:27Z","pushed_at":"2016-04-26T13:30:09Z","git_url":"git://github.com/geoadmin/mf-chsdi3.git","ssh_url":"git@github.com:geoadmin/mf-chsdi3.git","clone_url":"https://github.com/geoadmin/mf-chsdi3.git","svn_url":"https://github.com/geoadmin/mf-chsdi3","homepage":"api3.geo.admin.ch","size":405112,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":61,"forks":10,"open_issues":61,"watchers":13,"default_branch":"master"}},"base":{"label":"geoadmin:master","ref":"master","sha":"3659853235bc8c979b62caa77026cdbd9139f6d9","user":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=3","gravatar_id":"","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":10399553,"name":"mf-chsdi3","full_name":"geoadmin/mf-chsdi3","owner":{"login":"geoadmin","id":3369793,"avatar_url":"https://avatars.githubusercontent.com/u/3369793?v=3","gravatar_id":"","url":"https://api.github.com/users/geoadmin","html_url":"https://github.com/geoadmin","followers_url":"https://api.github.com/users/geoadmin/followers","following_url":"https://api.github.com/users/geoadmin/following{/other_user}","gists_url":"https://api.github.com/users/geoadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/geoadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoadmin/subscriptions","organizations_url":"https://api.github.com/users/geoadmin/orgs","repos_url":"https://api.github.com/users/geoadmin/repos","events_url":"https://api.github.com/users/geoadmin/events{/privacy}","received_events_url":"https://api.github.com/users/geoadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoadmin/mf-chsdi3","description":"api3.geo.admin.ch source code. ","fork":false,"url":"https://api.github.com/repos/geoadmin/mf-chsdi3","forks_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/forks","keys_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/teams","hooks_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/hooks","issue_events_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/events{/number}","events_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/events","assignees_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/assignees{/user}","branches_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/branches{/branch}","tags_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/tags","blobs_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/statuses/{sha}","languages_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/languages","stargazers_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/stargazers","contributors_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/contributors","subscribers_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/subscribers","subscription_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/subscription","commits_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/contents/{+path}","compare_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/merges","archive_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/downloads","issues_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues{/number}","pulls_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls{/number}","milestones_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/milestones{/number}","notifications_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/labels{/name}","releases_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/releases{/id}","deployments_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/deployments","created_at":"2013-05-31T06:59:44Z","updated_at":"2016-02-16T10:24:27Z","pushed_at":"2016-04-26T13:30:09Z","git_url":"git://github.com/geoadmin/mf-chsdi3.git","ssh_url":"git@github.com:geoadmin/mf-chsdi3.git","clone_url":"https://github.com/geoadmin/mf-chsdi3.git","svn_url":"https://github.com/geoadmin/mf-chsdi3","homepage":"api3.geo.admin.ch","size":405112,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":61,"forks":10,"open_issues":61,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046"},"html":{"href":"https://github.com/geoadmin/mf-chsdi3/pull/2046"},"issue":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/2046"},"comments":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/issues/2046/comments"},"review_comments":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046/comments"},"review_comment":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/2046/commits"},"statuses":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/statuses/e2200ad8030eb059d32fc73546d2305a5674c097"}}}}