{"action":"created","issue":{"url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/77","repository_url":"https://api.github.com/repos/BendingSpoons/katana-swift","labels_url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/77/comments","events_url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/77/events","html_url":"https://github.com/BendingSpoons/katana-swift/issues/77","id":191044442,"number":77,"title":"The fill method of PlasticView is ambiguously named","user":{"login":"frankdilo","id":715405,"avatar_url":"https://avatars.githubusercontent.com/u/715405?v=3","gravatar_id":"","url":"https://api.github.com/users/frankdilo","html_url":"https://github.com/frankdilo","followers_url":"https://api.github.com/users/frankdilo/followers","following_url":"https://api.github.com/users/frankdilo/following{/other_user}","gists_url":"https://api.github.com/users/frankdilo/gists{/gist_id}","starred_url":"https://api.github.com/users/frankdilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankdilo/subscriptions","organizations_url":"https://api.github.com/users/frankdilo/orgs","repos_url":"https://api.github.com/users/frankdilo/repos","events_url":"https://api.github.com/users/frankdilo/events{/privacy}","received_events_url":"https://api.github.com/users/frankdilo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-11-22T15:51:21Z","updated_at":"2016-11-23T12:30:59Z","closed_at":null,"body":"It has happened to me a few times that I wanted to use the [`fill`](https://github.com/BendingSpoons/katana-swift/blob/master/Katana/Plastic/PlasticView+Convenience.swift#L62) method and got surprised by the behaviour. I called it this way `view.fill(top: anchor1, left: anchor2, bottom: anchor3, right: anchor4)` and expected my view to stretch to the anchors, instead I got a square view.\r\n\r\nThis is because `fill` stretches the view preserving the aspect ratio (1, by default). I think the method should be renamed to something like `fillPreservingAspectRatio` to avoid confusion, or at least the `scale` argument shouldn't be optional.\r\n\r\nMoreover, I think it would be useful to have a `fill` method that does **not** preserve the aspect ratio."},"comment":{"url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/comments/262501103","html_url":"https://github.com/BendingSpoons/katana-swift/issues/77#issuecomment-262501103","issue_url":"https://api.github.com/repos/BendingSpoons/katana-swift/issues/77","id":262501103,"user":{"login":"bolismauro","id":771999,"avatar_url":"https://avatars.githubusercontent.com/u/771999?v=3","gravatar_id":"","url":"https://api.github.com/users/bolismauro","html_url":"https://github.com/bolismauro","followers_url":"https://api.github.com/users/bolismauro/followers","following_url":"https://api.github.com/users/bolismauro/following{/other_user}","gists_url":"https://api.github.com/users/bolismauro/gists{/gist_id}","starred_url":"https://api.github.com/users/bolismauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolismauro/subscriptions","organizations_url":"https://api.github.com/users/bolismauro/orgs","repos_url":"https://api.github.com/users/bolismauro/repos","events_url":"https://api.github.com/users/bolismauro/events{/privacy}","received_events_url":"https://api.github.com/users/bolismauro/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T12:30:59Z","updated_at":"2016-11-23T12:30:59Z","body":"Discussing with @frankdilo and @sroddy we realized that the best thing to do it two \r\n- remove the current fill method with aspect ratio\r\n- add a new method `fill(top:left:bottom:right:)`\r\n- add a new method `fit(top:left:bottom:right:aspectRatio)`\r\n\r\n"}}
{"actor":{"display_login":"bolismauro"}}