{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/javascript/pulls/comments/52847759","id":52847759,"diff_hunk":"@@ -96,8 +103,14 @@ module.exports = {\n     'no-sequences': 2,\n     // restrict what can be thrown as an exception\n     'no-throw-literal': 2,\n+    // disallow unmodified conditions of loops\n+    // http://eslint.org/docs/rules/no-unmodified-loop-condition\n+    'no-unmodified-loop-condition': 0,\n     // disallow usage of expressions in statement position\n     'no-unused-expressions': 2,\n+    // disallow unused labels\n+    // http://eslint.org/docs/rules/no-unused-labels\n+    'no-unused-labels': 0,","path":"packages/eslint-config-airbnb/rules/best-practices.js","position":54,"original_position":54,"commit_id":"dfc2edbedab9c691cef74b8be7d06ea4a5b1d985","original_commit_id":"dfc2edbedab9c691cef74b8be7d06ea4a5b1d985","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"same here re `no-labels`","created_at":"2016-02-14T19:52:43Z","updated_at":"2016-02-14T19:52:43Z","html_url":"https://github.com/airbnb/javascript/pull/730#discussion_r52847759","pull_request_url":"https://api.github.com/repos/airbnb/javascript/pulls/730","_links":{"self":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/comments/52847759"},"html":{"href":"https://github.com/airbnb/javascript/pull/730#discussion_r52847759"},"pull_request":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/730"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/javascript/pulls/730","id":59223326,"html_url":"https://github.com/airbnb/javascript/pull/730","diff_url":"https://github.com/airbnb/javascript/pull/730.diff","patch_url":"https://github.com/airbnb/javascript/pull/730.patch","issue_url":"https://api.github.com/repos/airbnb/javascript/issues/730","number":730,"state":"open","locked":false,"title":"Upgrade to eslint v2","user":{"login":"hshoff","id":339208,"avatar_url":"https://avatars.githubusercontent.com/u/339208?v=3","gravatar_id":"","url":"https://api.github.com/users/hshoff","html_url":"https://github.com/hshoff","followers_url":"https://api.github.com/users/hshoff/followers","following_url":"https://api.github.com/users/hshoff/following{/other_user}","gists_url":"https://api.github.com/users/hshoff/gists{/gist_id}","starred_url":"https://api.github.com/users/hshoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshoff/subscriptions","organizations_url":"https://api.github.com/users/hshoff/orgs","repos_url":"https://api.github.com/users/hshoff/repos","events_url":"https://api.github.com/users/hshoff/events{/privacy}","received_events_url":"https://api.github.com/users/hshoff/received_events","type":"User","site_admin":false},"body":"To the future we go. Couple more steps to go before publish:\r\n\r\n- [x] bump eslint \r\n- [x] review additional rules + features in v2\r\n- [x] add new rules set to 0 \r\n- [ ] add new rules we want to enforce + add explanations to Readme\r\n- [ ] bump eslint-plugin-react https://github.com/yannickcr/eslint-plugin-react/issues/436\r\n- [ ] update changelog\r\n- [ ] publish to npm\r\n\r\n","created_at":"2016-02-12T20:02:04Z","updated_at":"2016-02-14T19:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d093a010a17cc6aaf8e4b1d21f40b7b67a7d063f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/javascript/pulls/730/commits","review_comments_url":"https://api.github.com/repos/airbnb/javascript/pulls/730/comments","review_comment_url":"https://api.github.com/repos/airbnb/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/javascript/issues/730/comments","statuses_url":"https://api.github.com/repos/airbnb/javascript/statuses/dfc2edbedab9c691cef74b8be7d06ea4a5b1d985","head":{"label":"airbnb:harry-eslint-v2","ref":"harry-eslint-v2","sha":"dfc2edbedab9c691cef74b8be7d06ea4a5b1d985","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6498492,"name":"javascript","full_name":"airbnb/javascript","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/javascript","description":"JavaScript Style Guide","fork":false,"url":"https://api.github.com/repos/airbnb/javascript","forks_url":"https://api.github.com/repos/airbnb/javascript/forks","keys_url":"https://api.github.com/repos/airbnb/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/javascript/teams","hooks_url":"https://api.github.com/repos/airbnb/javascript/hooks","issue_events_url":"https://api.github.com/repos/airbnb/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/javascript/events","assignees_url":"https://api.github.com/repos/airbnb/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/javascript/tags","blobs_url":"https://api.github.com/repos/airbnb/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/javascript/languages","stargazers_url":"https://api.github.com/repos/airbnb/javascript/stargazers","contributors_url":"https://api.github.com/repos/airbnb/javascript/contributors","subscribers_url":"https://api.github.com/repos/airbnb/javascript/subscribers","subscription_url":"https://api.github.com/repos/airbnb/javascript/subscription","commits_url":"https://api.github.com/repos/airbnb/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/javascript/merges","archive_url":"https://api.github.com/repos/airbnb/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/javascript/downloads","issues_url":"https://api.github.com/repos/airbnb/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/javascript/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/javascript/deployments","created_at":"2012-11-01T23:13:50Z","updated_at":"2016-02-14T19:24:28Z","pushed_at":"2016-02-14T19:48:16Z","git_url":"git://github.com/airbnb/javascript.git","ssh_url":"git@github.com:airbnb/javascript.git","clone_url":"https://github.com/airbnb/javascript.git","svn_url":"https://github.com/airbnb/javascript","homepage":null,"size":2502,"stargazers_count":29773,"watchers_count":29773,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5567,"mirror_url":null,"open_issues_count":64,"forks":5567,"open_issues":64,"watchers":29773,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"44cc90f31cf09655a0363827af082335defd619a","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6498492,"name":"javascript","full_name":"airbnb/javascript","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/javascript","description":"JavaScript Style Guide","fork":false,"url":"https://api.github.com/repos/airbnb/javascript","forks_url":"https://api.github.com/repos/airbnb/javascript/forks","keys_url":"https://api.github.com/repos/airbnb/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/javascript/teams","hooks_url":"https://api.github.com/repos/airbnb/javascript/hooks","issue_events_url":"https://api.github.com/repos/airbnb/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/javascript/events","assignees_url":"https://api.github.com/repos/airbnb/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/javascript/tags","blobs_url":"https://api.github.com/repos/airbnb/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/javascript/languages","stargazers_url":"https://api.github.com/repos/airbnb/javascript/stargazers","contributors_url":"https://api.github.com/repos/airbnb/javascript/contributors","subscribers_url":"https://api.github.com/repos/airbnb/javascript/subscribers","subscription_url":"https://api.github.com/repos/airbnb/javascript/subscription","commits_url":"https://api.github.com/repos/airbnb/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/javascript/merges","archive_url":"https://api.github.com/repos/airbnb/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/javascript/downloads","issues_url":"https://api.github.com/repos/airbnb/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/javascript/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/javascript/deployments","created_at":"2012-11-01T23:13:50Z","updated_at":"2016-02-14T19:24:28Z","pushed_at":"2016-02-14T19:48:16Z","git_url":"git://github.com/airbnb/javascript.git","ssh_url":"git@github.com:airbnb/javascript.git","clone_url":"https://github.com/airbnb/javascript.git","svn_url":"https://github.com/airbnb/javascript","homepage":null,"size":2502,"stargazers_count":29773,"watchers_count":29773,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5567,"mirror_url":null,"open_issues_count":64,"forks":5567,"open_issues":64,"watchers":29773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/730"},"html":{"href":"https://github.com/airbnb/javascript/pull/730"},"issue":{"href":"https://api.github.com/repos/airbnb/javascript/issues/730"},"comments":{"href":"https://api.github.com/repos/airbnb/javascript/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/javascript/statuses/dfc2edbedab9c691cef74b8be7d06ea4a5b1d985"}}}}