{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/58716143","id":58716143,"diff_hunk":"@@ -1107,14 +1107,9 @@ WasmBytecodeGenerator::EmitReturnExpr(EmitInfo *lastStmtExprInfo)\n         }\n \n         m_writer.Conv(retOp, 0, retExprInfo.location);\n-        if (!lastStmtExprInfo)\n-        {\n-            ReleaseLocation(&retExprInfo);\n-        }\n     }\n     m_writer.AsmBr(m_funcInfo->GetExitLabel());\n-\n-    return EmitInfo();\n+    return retExprInfo;","path":"lib/WasmReader/WasmByteCodeGenerator.cpp","position":28,"original_position":28,"commit_id":"cc6ea371b8155938e98e2fe75b1d004ddcc584c9","original_commit_id":"cc6ea371b8155938e98e2fe75b1d004ddcc584c9","user":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"body":"Very good point. Somewhat misleading was the fact that the original example actually type checked under spec. I'll have to double check what is going on in spec. Closing.","created_at":"2016-04-06T14:37:05Z","updated_at":"2016-04-06T14:37:05Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/735#discussion_r58716143","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/58716143"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/735#discussion_r58716143"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735","id":65234723,"html_url":"https://github.com/Microsoft/ChakraCore/pull/735","diff_url":"https://github.com/Microsoft/ChakraCore/pull/735.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/735.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/735","number":735,"state":"open","locked":false,"title":"[wasm] Fixed return type check bug","user":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"body":"Previously, the type of the return was not passed up.\nThis precluded expressions with returns in the body.\n","created_at":"2016-04-05T00:34:35Z","updated_at":"2016-04-06T14:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3b620ec087b118e71022a0daaa5da5db55b245e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/735/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/cc6ea371b8155938e98e2fe75b1d004ddcc584c9","head":{"label":"commonlisp:wasm_ret_tc_bug","ref":"wasm_ret_tc_bug","sha":"cc6ea371b8155938e98e2fe75b1d004ddcc584c9","user":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"repo":{"id":49919332,"name":"ChakraCore","full_name":"commonlisp/ChakraCore","owner":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/commonlisp/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/commonlisp/ChakraCore","forks_url":"https://api.github.com/repos/commonlisp/ChakraCore/forks","keys_url":"https://api.github.com/repos/commonlisp/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commonlisp/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commonlisp/ChakraCore/teams","hooks_url":"https://api.github.com/repos/commonlisp/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/commonlisp/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/commonlisp/ChakraCore/events","assignees_url":"https://api.github.com/repos/commonlisp/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/commonlisp/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/commonlisp/ChakraCore/tags","blobs_url":"https://api.github.com/repos/commonlisp/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commonlisp/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commonlisp/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/commonlisp/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commonlisp/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/commonlisp/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/commonlisp/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/commonlisp/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/commonlisp/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/commonlisp/ChakraCore/subscription","commits_url":"https://api.github.com/repos/commonlisp/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/commonlisp/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/commonlisp/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/commonlisp/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/commonlisp/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/commonlisp/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commonlisp/ChakraCore/merges","archive_url":"https://api.github.com/repos/commonlisp/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commonlisp/ChakraCore/downloads","issues_url":"https://api.github.com/repos/commonlisp/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/commonlisp/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/commonlisp/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/commonlisp/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commonlisp/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/commonlisp/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/commonlisp/ChakraCore/deployments","created_at":"2016-01-19T02:11:38Z","updated_at":"2016-01-19T02:11:54Z","pushed_at":"2016-04-05T15:34:05Z","git_url":"git://github.com/commonlisp/ChakraCore.git","ssh_url":"git@github.com:commonlisp/ChakraCore.git","clone_url":"https://github.com/commonlisp/ChakraCore.git","svn_url":"https://github.com/commonlisp/ChakraCore","homepage":null,"size":22141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:WebAssembly","ref":"WebAssembly","sha":"64258332bc37a3220a63b705fb1ad2f81cf71695","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-04-06T14:00:48Z","pushed_at":"2016-04-06T14:35:49Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":29512,"stargazers_count":5061,"watchers_count":5061,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":548,"mirror_url":null,"open_issues_count":134,"forks":548,"open_issues":134,"watchers":5061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/735"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/735"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/cc6ea371b8155938e98e2fe75b1d004ddcc584c9"}}}}