{"action":"created","comment":{"url":"https://api.github.com/repos/zmap/zgrab/pulls/comments/56435778","id":56435778,"diff_hunk":"@@ -205,7 +205,64 @@\n         \"value\":Binary(),\n         \"length\":Integer(),\n         \"lifetime_hint\":Long()\n-    })\n+    }),\n+    \"key_material\":SubRecord({\n+        \"pre_master_secret\":SubRecord({\n+            \"value\":Binary(),\n+            \"length\":Integer()\n+        }),\n+        \"master_secret\":SubRecord({\n+            \"value\":Binary(),\n+            \"length\":Integer()\n+        }),\n+    }),\n+    \"client_finished\":SubRecord({\n+        \"verify_data\":Binary()\n+    }),\n+    \"client_key_exchange\":SubRecord({\n+        \"dh_params\":SubRecord({\n+            \"prime\":SubRecord({\n+                \"value\":Binary(),\n+                \"length\":Integer()\n+            }),\n+            \"generator\":SubRecord({\n+                \"value\":Binary(),\n+                \"length\":Integer()\n+            }),\n+            \"client_public\":SubRecord({\n+                \"value\":Binary(),\n+                \"length\":Integer()\n+            }),\n+            \"client_private\":SubRecord({\n+                \"value\":Binary(),\n+                \"length\":Integer()\n+            }),\n+        }),\n+        \"ecdh_params\":SubRecord({\n+            \"curve_id\":SubRecord({\n+                \"name\":String(),\n+                \"id\":Integer()\n+            }),\n+            \"client_public\":SubRecord({\n+                \"x\":SubRecord({\n+                    \"value\":Binary(),\n+                    \"length\":Integer()\n+                }),\n+                \"y\":SubRecord({\n+                    \"value\":Binary(),\n+                    \"length\":Integer()\n+                }),\n+            }),\n+            \"client_private\":SubRecord({\n+                \"value\":Binary(),\n+                \"length\":Integer()\n+            }),\n+        }),\n+        \"rsa_params\":SubRecord({\n+            \"length\":Integer(),\n+            \"encrypted_pre_master_secret\":Binary()","path":"zgrab_schema.py","position":60,"original_position":60,"commit_id":"aaa1549927271fb34cf94b8dbdbe8d89bf7127d4","original_commit_id":"aaa1549927271fb34cf94b8dbdbe8d89bf7127d4","user":{"login":"dadrian","id":1158264,"avatar_url":"https://avatars.githubusercontent.com/u/1158264?v=3","gravatar_id":"","url":"https://api.github.com/users/dadrian","html_url":"https://github.com/dadrian","followers_url":"https://api.github.com/users/dadrian/followers","following_url":"https://api.github.com/users/dadrian/following{/other_user}","gists_url":"https://api.github.com/users/dadrian/gists{/gist_id}","starred_url":"https://api.github.com/users/dadrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadrian/subscriptions","organizations_url":"https://api.github.com/users/dadrian/orgs","repos_url":"https://api.github.com/users/dadrian/repos","events_url":"https://api.github.com/users/dadrian/events{/privacy}","received_events_url":"https://api.github.com/users/dadrian/received_events","type":"User","site_admin":false},"body":"This will be the decrypted version, no?","created_at":"2016-03-16T23:49:19Z","updated_at":"2016-03-16T23:49:19Z","html_url":"https://github.com/zmap/zgrab/pull/112#discussion_r56435778","pull_request_url":"https://api.github.com/repos/zmap/zgrab/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/comments/56435778"},"html":{"href":"https://github.com/zmap/zgrab/pull/112#discussion_r56435778"},"pull_request":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/zmap/zgrab/pulls/112","id":60558109,"html_url":"https://github.com/zmap/zgrab/pull/112","diff_url":"https://github.com/zmap/zgrab/pull/112.diff","patch_url":"https://github.com/zmap/zgrab/pull/112.patch","issue_url":"https://api.github.com/repos/zmap/zgrab/issues/112","number":112,"state":"open","locked":false,"title":"Add --output-crypto-variables flag.","user":{"login":"aaspring","id":5420174,"avatar_url":"https://avatars.githubusercontent.com/u/5420174?v=3","gravatar_id":"","url":"https://api.github.com/users/aaspring","html_url":"https://github.com/aaspring","followers_url":"https://api.github.com/users/aaspring/followers","following_url":"https://api.github.com/users/aaspring/following{/other_user}","gists_url":"https://api.github.com/users/aaspring/gists{/gist_id}","starred_url":"https://api.github.com/users/aaspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaspring/subscriptions","organizations_url":"https://api.github.com/users/aaspring/orgs","repos_url":"https://api.github.com/users/aaspring/repos","events_url":"https://api.github.com/users/aaspring/events{/privacy}","received_events_url":"https://api.github.com/users/aaspring/received_events","type":"User","site_admin":false},"body":"Cmd flag adds premaster secret and master secret to the JSON output of\r\nthe ZGrab targets IOT avoid re-computation in post-processing and\r\nanalysis.","created_at":"2016-02-24T18:47:50Z","updated_at":"2016-03-16T23:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148e5759b95678fbec3bb66bb25ce446e4aaf316","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zmap/zgrab/pulls/112/commits","review_comments_url":"https://api.github.com/repos/zmap/zgrab/pulls/112/comments","review_comment_url":"https://api.github.com/repos/zmap/zgrab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zmap/zgrab/issues/112/comments","statuses_url":"https://api.github.com/repos/zmap/zgrab/statuses/aaa1549927271fb34cf94b8dbdbe8d89bf7127d4","head":{"label":"aaspring:feat/outputCryptoVariables","ref":"feat/outputCryptoVariables","sha":"aaa1549927271fb34cf94b8dbdbe8d89bf7127d4","user":{"login":"aaspring","id":5420174,"avatar_url":"https://avatars.githubusercontent.com/u/5420174?v=3","gravatar_id":"","url":"https://api.github.com/users/aaspring","html_url":"https://github.com/aaspring","followers_url":"https://api.github.com/users/aaspring/followers","following_url":"https://api.github.com/users/aaspring/following{/other_user}","gists_url":"https://api.github.com/users/aaspring/gists{/gist_id}","starred_url":"https://api.github.com/users/aaspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaspring/subscriptions","organizations_url":"https://api.github.com/users/aaspring/orgs","repos_url":"https://api.github.com/users/aaspring/repos","events_url":"https://api.github.com/users/aaspring/events{/privacy}","received_events_url":"https://api.github.com/users/aaspring/received_events","type":"User","site_admin":false},"repo":{"id":45348249,"name":"zgrab","full_name":"aaspring/zgrab","owner":{"login":"aaspring","id":5420174,"avatar_url":"https://avatars.githubusercontent.com/u/5420174?v=3","gravatar_id":"","url":"https://api.github.com/users/aaspring","html_url":"https://github.com/aaspring","followers_url":"https://api.github.com/users/aaspring/followers","following_url":"https://api.github.com/users/aaspring/following{/other_user}","gists_url":"https://api.github.com/users/aaspring/gists{/gist_id}","starred_url":"https://api.github.com/users/aaspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaspring/subscriptions","organizations_url":"https://api.github.com/users/aaspring/orgs","repos_url":"https://api.github.com/users/aaspring/repos","events_url":"https://api.github.com/users/aaspring/events{/privacy}","received_events_url":"https://api.github.com/users/aaspring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaspring/zgrab","description":"Application layer scanner that operates with ZMap","fork":true,"url":"https://api.github.com/repos/aaspring/zgrab","forks_url":"https://api.github.com/repos/aaspring/zgrab/forks","keys_url":"https://api.github.com/repos/aaspring/zgrab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaspring/zgrab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaspring/zgrab/teams","hooks_url":"https://api.github.com/repos/aaspring/zgrab/hooks","issue_events_url":"https://api.github.com/repos/aaspring/zgrab/issues/events{/number}","events_url":"https://api.github.com/repos/aaspring/zgrab/events","assignees_url":"https://api.github.com/repos/aaspring/zgrab/assignees{/user}","branches_url":"https://api.github.com/repos/aaspring/zgrab/branches{/branch}","tags_url":"https://api.github.com/repos/aaspring/zgrab/tags","blobs_url":"https://api.github.com/repos/aaspring/zgrab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaspring/zgrab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaspring/zgrab/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaspring/zgrab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaspring/zgrab/statuses/{sha}","languages_url":"https://api.github.com/repos/aaspring/zgrab/languages","stargazers_url":"https://api.github.com/repos/aaspring/zgrab/stargazers","contributors_url":"https://api.github.com/repos/aaspring/zgrab/contributors","subscribers_url":"https://api.github.com/repos/aaspring/zgrab/subscribers","subscription_url":"https://api.github.com/repos/aaspring/zgrab/subscription","commits_url":"https://api.github.com/repos/aaspring/zgrab/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaspring/zgrab/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaspring/zgrab/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaspring/zgrab/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaspring/zgrab/contents/{+path}","compare_url":"https://api.github.com/repos/aaspring/zgrab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaspring/zgrab/merges","archive_url":"https://api.github.com/repos/aaspring/zgrab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaspring/zgrab/downloads","issues_url":"https://api.github.com/repos/aaspring/zgrab/issues{/number}","pulls_url":"https://api.github.com/repos/aaspring/zgrab/pulls{/number}","milestones_url":"https://api.github.com/repos/aaspring/zgrab/milestones{/number}","notifications_url":"https://api.github.com/repos/aaspring/zgrab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaspring/zgrab/labels{/name}","releases_url":"https://api.github.com/repos/aaspring/zgrab/releases{/id}","deployments_url":"https://api.github.com/repos/aaspring/zgrab/deployments","created_at":"2015-11-01T16:36:26Z","updated_at":"2016-02-04T16:33:35Z","pushed_at":"2016-03-12T00:01:43Z","git_url":"git://github.com/aaspring/zgrab.git","ssh_url":"git@github.com:aaspring/zgrab.git","clone_url":"https://github.com/aaspring/zgrab.git","svn_url":"https://github.com/aaspring/zgrab","homepage":"","size":1690,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zmap:master","ref":"master","sha":"e58e6171eb4fe6624f7e15c9939c1132d29b52e9","user":{"login":"zmap","id":3345672,"avatar_url":"https://avatars.githubusercontent.com/u/3345672?v=3","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"repo":{"id":18019738,"name":"zgrab","full_name":"zmap/zgrab","owner":{"login":"zmap","id":3345672,"avatar_url":"https://avatars.githubusercontent.com/u/3345672?v=3","gravatar_id":"","url":"https://api.github.com/users/zmap","html_url":"https://github.com/zmap","followers_url":"https://api.github.com/users/zmap/followers","following_url":"https://api.github.com/users/zmap/following{/other_user}","gists_url":"https://api.github.com/users/zmap/gists{/gist_id}","starred_url":"https://api.github.com/users/zmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmap/subscriptions","organizations_url":"https://api.github.com/users/zmap/orgs","repos_url":"https://api.github.com/users/zmap/repos","events_url":"https://api.github.com/users/zmap/events{/privacy}","received_events_url":"https://api.github.com/users/zmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zmap/zgrab","description":"Application layer scanner that operates with ZMap","fork":false,"url":"https://api.github.com/repos/zmap/zgrab","forks_url":"https://api.github.com/repos/zmap/zgrab/forks","keys_url":"https://api.github.com/repos/zmap/zgrab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmap/zgrab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmap/zgrab/teams","hooks_url":"https://api.github.com/repos/zmap/zgrab/hooks","issue_events_url":"https://api.github.com/repos/zmap/zgrab/issues/events{/number}","events_url":"https://api.github.com/repos/zmap/zgrab/events","assignees_url":"https://api.github.com/repos/zmap/zgrab/assignees{/user}","branches_url":"https://api.github.com/repos/zmap/zgrab/branches{/branch}","tags_url":"https://api.github.com/repos/zmap/zgrab/tags","blobs_url":"https://api.github.com/repos/zmap/zgrab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmap/zgrab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmap/zgrab/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmap/zgrab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmap/zgrab/statuses/{sha}","languages_url":"https://api.github.com/repos/zmap/zgrab/languages","stargazers_url":"https://api.github.com/repos/zmap/zgrab/stargazers","contributors_url":"https://api.github.com/repos/zmap/zgrab/contributors","subscribers_url":"https://api.github.com/repos/zmap/zgrab/subscribers","subscription_url":"https://api.github.com/repos/zmap/zgrab/subscription","commits_url":"https://api.github.com/repos/zmap/zgrab/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmap/zgrab/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmap/zgrab/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmap/zgrab/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmap/zgrab/contents/{+path}","compare_url":"https://api.github.com/repos/zmap/zgrab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmap/zgrab/merges","archive_url":"https://api.github.com/repos/zmap/zgrab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmap/zgrab/downloads","issues_url":"https://api.github.com/repos/zmap/zgrab/issues{/number}","pulls_url":"https://api.github.com/repos/zmap/zgrab/pulls{/number}","milestones_url":"https://api.github.com/repos/zmap/zgrab/milestones{/number}","notifications_url":"https://api.github.com/repos/zmap/zgrab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmap/zgrab/labels{/name}","releases_url":"https://api.github.com/repos/zmap/zgrab/releases{/id}","deployments_url":"https://api.github.com/repos/zmap/zgrab/deployments","created_at":"2014-03-22T21:03:26Z","updated_at":"2016-03-15T19:51:18Z","pushed_at":"2016-03-14T06:41:41Z","git_url":"git://github.com/zmap/zgrab.git","ssh_url":"git@github.com:zmap/zgrab.git","clone_url":"https://github.com/zmap/zgrab.git","svn_url":"https://github.com/zmap/zgrab","homepage":"","size":2216,"stargazers_count":108,"watchers_count":108,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":47,"forks":31,"open_issues":47,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/112"},"html":{"href":"https://github.com/zmap/zgrab/pull/112"},"issue":{"href":"https://api.github.com/repos/zmap/zgrab/issues/112"},"comments":{"href":"https://api.github.com/repos/zmap/zgrab/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zmap/zgrab/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/zmap/zgrab/statuses/aaa1549927271fb34cf94b8dbdbe8d89bf7127d4"}}}}