{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/1511","repository_url":"https://api.github.com/repos/hyperledger/fabric","labels_url":"https://api.github.com/repos/hyperledger/fabric/issues/1511/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1511/comments","events_url":"https://api.github.com/repos/hyperledger/fabric/issues/1511/events","html_url":"https://github.com/hyperledger/fabric/issues/1511","id":155603558,"number":1511,"title":"DOC : Installation 3.3 Behave Tests - 'make images' is referenced but not defined in this doc","user":{"login":"jjjjibm","id":17887475,"avatar_url":"https://avatars.githubusercontent.com/u/17887475?v=3","gravatar_id":"","url":"https://api.github.com/users/jjjjibm","html_url":"https://github.com/jjjjibm","followers_url":"https://api.github.com/users/jjjjibm/followers","following_url":"https://api.github.com/users/jjjjibm/following{/other_user}","gists_url":"https://api.github.com/users/jjjjibm/gists{/gist_id}","starred_url":"https://api.github.com/users/jjjjibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjjjibm/subscriptions","organizations_url":"https://api.github.com/users/jjjjibm/orgs","repos_url":"https://api.github.com/users/jjjjibm/repos","events_url":"https://api.github.com/users/jjjjibm/events{/privacy}","received_events_url":"https://api.github.com/users/jjjjibm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hyperledger/fabric/labels/documentation","name":"documentation","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-18T21:16:07Z","updated_at":"2016-06-12T08:30:57Z","closed_at":null,"body":"## Description\r\nTesting the revised installation document here: https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/install.md\r\n\r\nIn step **3.3 Behave Tests,**  it says:\r\n_Note, in order to run behave directly, you must run **'make images'** first to build the necessary peer and member services docker images._\r\n\r\nHowever, no instructions are given to run 'make images'.  If it is simply the command 'make images', why not put it here: \r\ncd $GOPATH/src/github.com/hyperledger/fabric\r\nmake images \r\nmake behave\r\n\r\nYou'll have to ask development if that is a valid command sequence.   \r\n\r\nThe page used to say run the unit tests in section 3.1 first.  I had a chat with Greg Haskins about it, and he may be appropriate to resolve this issue: \r\n\r\n\r\njjjjibm [5:28 PM] \r\nI hear tell you wrote the makefile for the behave test cases as documented here: https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/install.md ?\r\n \r\nGitHub\r\nhyperledger/fabric\r\nfabric - Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N. Information on what Incubation entails can be found in the Hyperledger Proj...\r\n\r\nGregory Haskins [5:29 PM] \r\nthat would be a bit of an overstatement, heh, but yes\r\n\r\n[5:29] \r\nthe makefile just launches the behave test with a one-liner\r\n\r\n[5:29] \r\nthe real work is done outside of make\r\n\r\n[5:30] \r\nseeing a problem?\r\n\r\njjjjibm [5:30 PM] \r\nyes.  Here is the documenation for 'behave' ...\r\n\r\n[5:30] \r\n3.3 Behave Tests\r\n\r\nBehave tests will setup networks of peers with different security and consensus configurations and verify that transactions run properly. To run these tests\r\n\r\ncd $GOPATH/src/github.com/hyperledger/fabric\r\nmake behave\r\n\r\nSome of the Behave tests run inside Docker containers. If a test fails and you want to have the logs from the Docker containers, run the tests with this option\r\n\r\nbehave -D logs=Y\r\n\r\nNote, in order to run behave directly, you must run 'make images' first to build the necessary peer and member services docker images.\r\n\r\n[5:31] \r\nNotice it says to run 'make images' first, a step which is not described on the page\r\n\r\n[5:31] \r\nI reckoned it meant to say run 'make unit-test' as described here:\r\n\r\n[5:31] \r\n3.1 Go Unit Tests\r\n\r\nUse the following sequence to run all unit tests\r\n\r\ncd $GOPATH/src/github.com/hyperledger/fabric\r\nmake unit-test\r\n\r\nGregory Haskins [5:31 PM] \r\nwell, i think it does say what I meant, but it might need to be reworded\r\n\r\n[5:32] \r\n“images” is a pre-requisite of “make behave”, so if you followed the first steps its done for you\r\n\r\njjjjibm [5:32 PM] \r\nI got this error twice:\r\n\r\n[5:32] \r\ncom/hyperledger/fabric$ make behave\r\ncd peer; CGO_CFLAGS=\" \" CGO_LDFLAGS=\"-lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy\" go build\r\ngo install github.com/hyperledger/fabric/peer: open peer: text file busy\r\nmake: *** [peer] Error 1\r\nvagrant@hyperledger-devenv:v0.0.9-5cd67fd:/opt/gopath/src/github.com/hyperledger/fabric$\r\n\r\nGregory Haskins [5:32 PM] \r\nwhat i was trying to say was “if you want to run behave on your own, thats cool, but make sure you build the pre-requisites yourself with ‘make images'\r\n\r\njjjjibm [5:32 PM] \r\nRight before trying make behave, I ran make unit-test which seems to run ok\r\n\r\n[5:33] \r\nexcept for one timeout\r\n\r\nGregory Haskins [5:33 PM] \r\nive not seen that error before, but from the report it seems like perhaps you have a peer still running?\r\n\r\njjjjibm [5:33 PM] \r\nI do ... it's never made a difference before.  Should I cancel the peer and try again?\r\n\r\nGregory Haskins [5:33 PM] \r\nit seems that way\r\n\r\n[5:34] \r\ni suspect its because make it trying to satisify the prereq and you ahve it running\r\n\r\n[5:34] \r\nprior, there was no make file so no rebuild would have been attempted\r\n\r\n[5:34] \r\nnow, whether the rebuild is the right thing to do is another matter, heh\r\n\r\njjjjibm [5:34 PM] \r\nAFter cancelling peer:\r\n\r\n[5:34] \r\ncom/hyperledger/fabric$ make behave\r\ncd peer; CGO_CFLAGS=\" \" CGO_LDFLAGS=\"-lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy\" go build\r\nRunning behave tests\r\nFeature: lanching 3 peers # peer_basic.feature:11\r\n As a HyperLedger developer\r\n I want to be able to launch 3 peers\r\n Scenario: Peers list test, single peer issue #827                            # peer_basic.feature:16\r\n   Given we compose \"docker-compose-1.yml\"                                    # steps/peer_basic_impl.py:121\r\n\r\nGregory Haskins [5:35 PM] \r\nright now, its overly conservative and assumes we should always rebuild the peer\r\n\r\n[5:35] \r\nill see if I can make it smarter\r\n\r\njjjjibm [5:35 PM] \r\nSo, what words need to go into my issue against the doc?  That 'make images' appearing out of nowhere?  Could I have simply typed 'make images' before typing 'make behave'?\r\n\r\nGregory Haskins [5:35 PM] \r\nfor the time being, workaround is dont leave a peer running\r\n\r\njjjjibm [5:35 PM] \r\nyeah, I have a problem with that.  The doc doesn't remind you to cancel the peer\r\n\r\nGregory Haskins [5:36 PM] \r\nyes, you could have done “make images behave”, it just would be redundant\r\n\r\n[5:36] \r\nmake behave is a superset with images\r\n\r\njjjjibm [5:36 PM] \r\nI was thinking 'make images'  <newline> 'make behave'\r\n\r\nGregory Haskins [5:36 PM] \r\nnote that its always been a prerequisite to stop the peer before running behave though, make didnt change that\r\n\r\n[5:37] \r\nthere is no functional difference between the two (make images; make behave == make images behave)\r\n\r\njjjjibm [5:37 PM] \r\nNow I'm confused.  The web page says to run 'make images' first?\r\n\r\nGregory Haskins [5:37 PM] \r\nin fact, you could add “make behave” to that tuple since images is implied\r\n\r\n[5:37] \r\noh, let me look\r\n\r\njjjjibm [5:37 PM] \r\nOk\r\n\r\nGregory Haskins [5:38 PM] \r\nim not seeing that\r\n\r\n[5:38] \r\ntheres three occurances of “images” and they are all in the note about running behave by hand\r\n\r\n[5:39] \r\nam i missing some?\r\n\r\njjjjibm [5:39 PM] \r\nLook for this on the page:\r\n\r\n[5:39] \r\nNote, in order to run behave directly, you must run 'make images' first to build the necessary peer and member services docker images.\r\n\r\nGregory Haskins [5:39 PM] \r\nyep, those are the three I see\r\n\r\njjjjibm [5:39 PM] \r\nAs far as I can tell, that's the first reference to 'make images'\r\n\r\n[5:40] \r\nYOu just said (I think) I DON'T need to type 'make images' but the page says type 'make images'\r\n\r\nGregory Haskins [5:40 PM] \r\nok, theres two things going on here\r\n\r\n[5:40] \r\n1) full automated mode, aka “make behave”….for this mode, no, you dont need to run make images\r\n\r\n[5:41] \r\n2) manual mode, where you launch behave yourself…for this mode, you need to ensure that you run “make images” prior to running behave yourself\r\n\r\njjjjibm [5:41 PM] \r\nAh, I thought 'run behave directly' meant run it first thing :slightly_smiling_face: not run outside of make\r\n\r\n[5:42] \r\nfirst thing as oppposed to running unit-tests first\r\n\r\nGregory Haskins [5:42 PM] \r\nright, and if that isnt clear we should fix the doc\r\n\r\njjjjibm [5:42 PM] \r\nIs running make unit-test now optional/not required?\r\n\r\nGregory Haskins [5:42 PM] \r\nyeah, if you run unit-tests, that also builds the images\r\n\r\n[5:43] \r\ncorrect, to run behave, you can run the “make images”, or “make unit-tests” which also runs “make images” for you\r\n\r\njjjjibm [5:43 PM] \r\nOk.  I  am going to gut issue 1511 and paste this chat into it!\r\n\r\nGregory Haskins [5:43 PM] \r\nok\r\n\r\njjjjibm [5:43 PM] \r\nBecause it brings up more nuances of the problem.\r\n\r\n[5:43] \r\nThanks!\r\n\r\nGregory Haskins [5:44 PM] \r\nok, apologies for any grief this caused…it was a find/replace edit of the old instructions so maybe some nuance was lost in translation\r\n\r\njjjjibm [5:44 PM] \r\nThat's why we test :slightly_smiling_face:\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/comments/225416941","html_url":"https://github.com/hyperledger/fabric/issues/1511#issuecomment-225416941","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1511","id":225416941,"user":{"login":"cophey","id":7555270,"avatar_url":"https://avatars.githubusercontent.com/u/7555270?v=3","gravatar_id":"","url":"https://api.github.com/users/cophey","html_url":"https://github.com/cophey","followers_url":"https://api.github.com/users/cophey/followers","following_url":"https://api.github.com/users/cophey/following{/other_user}","gists_url":"https://api.github.com/users/cophey/gists{/gist_id}","starred_url":"https://api.github.com/users/cophey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cophey/subscriptions","organizations_url":"https://api.github.com/users/cophey/orgs","repos_url":"https://api.github.com/users/cophey/repos","events_url":"https://api.github.com/users/cophey/events{/privacy}","received_events_url":"https://api.github.com/users/cophey/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T08:30:57Z","updated_at":"2016-06-12T08:30:57Z","body":"@GrapeBaBa There is some worng with my environment.There is no pip and behave command.I install manually,and then i try again.thanks anyway."}}
{"actor":{"display_login":"cophey"}}