{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2548","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2548/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2548/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2548/events","html_url":"https://github.com/LMMS/lmms/pull/2548","id":131994256,"number":2548,"title":"Removes GUI dependencies from the core class ConfigManager","user":{"login":"michaelgregorius","id":9293269,"avatar_url":"https://avatars.githubusercontent.com/u/9293269?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgregorius","html_url":"https://github.com/michaelgregorius","followers_url":"https://api.github.com/users/michaelgregorius/followers","following_url":"https://api.github.com/users/michaelgregorius/following{/other_user}","gists_url":"https://api.github.com/users/michaelgregorius/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgregorius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgregorius/subscriptions","organizations_url":"https://api.github.com/users/michaelgregorius/orgs","repos_url":"https://api.github.com/users/michaelgregorius/repos","events_url":"https://api.github.com/users/michaelgregorius/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgregorius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-07T18:14:49Z","updated_at":"2016-02-08T20:04:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2548","html_url":"https://github.com/LMMS/lmms/pull/2548","diff_url":"https://github.com/LMMS/lmms/pull/2548.diff","patch_url":"https://github.com/LMMS/lmms/pull/2548.patch"},"body":"Adds a struct `ConfigManager::ConfigLoadResult` which holds the result of\r\nthe method `ConfigManager::loadConfigFile`. Doing it this way the caller\r\n(`main.cpp`) can act accordingly in case there is an error. The current\r\nimplementation shows the warning message box that was shown before when\r\nwe are on the GUI code path.\r\n\r\n`ConfigManager::saveConfigFile` now returns a boolean to indicate whether\r\nthe saving worked or not. Also in this case it's up to the caller to act\r\naccordingly. In this case the sole caller `SetupDialog` shows the previous\r\ncritical error message. To be able to include the config file's name a new\r\nmethod `ConfigManager::lmmsRcFile` was added."},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/181543644","html_url":"https://github.com/LMMS/lmms/pull/2548#issuecomment-181543644","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2548","id":181543644,"user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars.githubusercontent.com/u/6345473?v=3","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"created_at":"2016-02-08T20:04:44Z","updated_at":"2016-02-08T20:04:44Z","body":"> @tresf Are there any big blockers left with regards to a stable-1.2 branch/release?\r\n\r\nNone.  We're pretty much ready to start testing.\r\n\r\n> My reasoning was that although the changes should be low risk they would also get tested in the upcoming beta phase.\r\n\r\nYeah, that's fine too.  Progress is good, just hard to testing a moving target.  I do believe the changes to be mostly benign, so I'm not concerned as much as I am cautious. :+1: "}}