{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/7765","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/7765/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/7765/comments","events_url":"https://api.github.com/repos/facebook/react/issues/7765/events","html_url":"https://github.com/facebook/react/issues/7765","id":177678628,"number":7765,"title":"Can't isomorphically check propTypes in react-dom-stream SSR without warnings in React 15.2+","user":{"login":"jedwards1211","id":1448194,"avatar_url":"https://avatars.githubusercontent.com/u/1448194?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards1211","html_url":"https://github.com/jedwards1211","followers_url":"https://api.github.com/users/jedwards1211/followers","following_url":"https://api.github.com/users/jedwards1211/following{/other_user}","gists_url":"https://api.github.com/users/jedwards1211/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards1211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards1211/subscriptions","organizations_url":"https://api.github.com/users/jedwards1211/orgs","repos_url":"https://api.github.com/users/jedwards1211/repos","events_url":"https://api.github.com/users/jedwards1211/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards1211/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-18T21:27:39Z","updated_at":"2016-09-18T22:23:17Z","closed_at":"2016-09-18T21:39:20Z","body":"https://github.com/aickin/react-dom-stream/issues/22\r\n\r\n`react-dom-stream` helpfully checks `propTypes` while rendering static HTML to a stream.  But of  course React 15.2+ warns (in this case on a user `Html` `Component` with `propTypes.head`):\r\n\r\n> Warning: You are manually calling a React.PropTypes validation function for the head prop on Html. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.\r\n\r\nThe page at that link advises 3rd party libraries to use external `PropType` libraries, but that won't work in this case because `react-dom-stream` is trying to call the `propTypes` the user has put on their components, rather than providing helpers like the 3rd party libraries the author of that page seems to be considering (e.g. `ImmutablePropTypes`).  To prevent these errors, the user would have to remove the `propTypes` on their components or replace the usages of `React.PropTypes` in their own code with some other library.  If they were using 3rd party components that declare `propTypes`, they would be out of luck.\r\n\r\nIs there an intended solution to this or was this conflict unanticipated?"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/247884860","html_url":"https://github.com/facebook/react/issues/7765#issuecomment-247884860","issue_url":"https://api.github.com/repos/facebook/react/issues/7765","id":247884860,"user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"created_at":"2016-09-18T22:23:17Z","updated_at":"2016-09-18T22:23:17Z","body":">Okay, I was actually concerned that react@16 would break react-dom-stream entirely, but as long as it remains possible to call the validators in dev mode there's no problem.\r\n\r\nThe warning exists to make it clear for people who *call PropTypes manually* (e.g. to validate their API responses, or for other obscure reasons) that this won’t work in production in 16. We warn in development because that’s where people will see the warnings, as almost nobody looks into production warning logs. But PropTypes will keep working in development for sure, even in 16."}}
{"actor":{"display_login":"gaearon"}}