{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/1033","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/events","html_url":"https://github.com/triplea-game/triplea/issues/1033","id":169444214,"number":1033,"title":"Map XML Changes/Deletions Request","user":{"login":"Cernelius","id":19562310,"avatar_url":"https://avatars.githubusercontent.com/u/19562310?v=3","gravatar_id":"","url":"https://api.github.com/users/Cernelius","html_url":"https://github.com/Cernelius","followers_url":"https://api.github.com/users/Cernelius/followers","following_url":"https://api.github.com/users/Cernelius/following{/other_user}","gists_url":"https://api.github.com/users/Cernelius/gists{/gist_id}","starred_url":"https://api.github.com/users/Cernelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cernelius/subscriptions","organizations_url":"https://api.github.com/users/Cernelius/orgs","repos_url":"https://api.github.com/users/Cernelius/repos","events_url":"https://api.github.com/users/Cernelius/events{/privacy}","received_events_url":"https://api.github.com/users/Cernelius/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/triplea-game/triplea/labels/Discussion","name":"Discussion","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":43,"created_at":"2016-08-04T18:38:55Z","updated_at":"2016-08-15T20:08:49Z","closed_at":null,"body":"In addition to the already made:\r\nAttatch->Attach\r\nattatch->attach\r\n\r\nI wish to propose the following changes and deletions, to be included in the 1.9 engine:\r\n\r\nEngine behaviour changes:\r\n**Naval Bombard Casualties Return Fire Restricted** invert behaviour (to behave as true like it now does as false, and vice versa)\r\n\r\nXML related engine deletions (if not already done (I don't know)):\r\n**\"takeUnitControl\"**\r\n**\"occupiedTerrOf\"**\r\n**\"isParatroop\"**\r\n**\"isMechanized\"**\r\n**\"isTwoHit\"**\r\n**\"trigger\"**\r\n**\"SBR Affects Unit Production\"**\r\n\r\nXML related engine changes and XML changes:\r\n**isImpassible->isImpassable**\r\n**option name=\"victoryCity\" value=\"true\"->option name=\"victoryCity\" value=\"1\"**\r\n(stop supporting boolean only)\r\n**offence->offensive**\r\n**defence->defensive**\r\n**Battleships repair at end of round->Units Repair Hits End Turn**\r\n**Battleships repair at beginning of round->Units Repair Hits Start Turn**\r\n**option name=\"turns\"->option name=\"rounds\"**\r\n**option name=\"conditionType\" value=\"XOR\"->option name=\"conditionType\" value=\"1\"**\r\n\r\nXML only deletions:\r\n**option name=\"takeUnitControl\" value=\"true\"**\r\n**option name=\"takeUnitControl\" value=\"false\"**\r\n**option name=\"giveUnitControl\" value=\"true\"**\r\n**option name=\"giveUnitControl\" value=\"false\"**\r\n(all and only the boolean occurrences of giveUnitControl must be deleted)\r\n\r\nXML only changes:\r\n**\"occupiedTerrOf\"->\"originalOwner\"**\r\n**\"isParatroop\"->\"isAirTransportable\"**\r\n**\"isMechanized\"->\"isInfantry\"**\r\n**\"isTwoHit\" value=\"true\"->\"hitPoints\" value=\"2\"**\r\n**\"isTwoHit\" value=\"false\"->\"hitPoints\" value=\"1\"**\r\n**\"trigger\"->\"conditions\"**\r\n**\"Naval Bombard Casualties Return Fire Restricted\" value=\"true\"->\"Naval Bombard Casualties Return Fire Restricted\" value=\"false\"**\r\n**\"Naval Bombard Casualties Return Fire Restricted\" value=\"false\"->\"Naval Bombard Casualties Return Fire Restricted\" value=\"true\"**\r\n(on the assumption that the mapmakers set the option on what it does, not on what it says)\r\n**\"SBR Affects Unit Production\"->\"Damage From Bombing Done To Units Instead Of Territories\"**\r\n\r\nmap.properties related engine changes and map.properties changes:\r\n**color.Impassible=->color.Impassable=** \r\n\r\n And the current pos2 descriptions should be updated accordingly, in several of the above cases.\r\n\r\nI suggest these changes not being backward compatible (removed, not deprecated), just like the attatch to attach case.\r\n\r\nI believe this should reduce incorrect or redundant or deprecated elements to only \"artillerySupportable\", \"artillery\", and \"unitSupportCount\", that, albeit duplicative of what done via supportAttachment, I definitively suggest being kept, for some reasons.\r\n\r\nPlease, if any developer willingly to do any of the above changes don't want to make some of them or want to make some of them in a different way or just don't get the point of some of them, let me know specifically which ones you are in disagreement or in doubt with and I will explain you why you should do them the way I said.\r\nWhile I'm of course favourable if all the above changes are fully made exactly the way I said, I may be contrary to make any of them if only some of them are made or if they are made in a different way than I said.\r\n\r\nThanks!\r\n\r\nReferences:\r\nhttp://tripleadev.1671093.n2.nabble.com/Attatch-incorrect-spelling-fixed-tp7591892.html;cid=1470329274322-906\r\nhttp://tripleadev.1671093.n2.nabble.com/PRECONDITIONS-FOR-MAP-UPLOAD-tp7587348.html;cid=1470329274322-906"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/239913706","html_url":"https://github.com/triplea-game/triplea/issues/1033#issuecomment-239913706","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033","id":239913706,"user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T20:08:49Z","updated_at":"2016-08-15T20:08:49Z","body":"So just re-summarize the issue in a new one, and be patient as it'll be a tracker for the topic. WE have many yes, but again, there are ways to sort through them. We can't just have open only the items we are working on, most items need some consideration and agreement, so it's very valuable to have a list of agreed upon projects, and a list of outstanding bugs. WE have some other topics beyond bugs/features, but there are not terribly many of those."}}
{"actor":{"display_login":"DanVanAtta"}}