{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/608","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/608/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/608/events","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/608","id":194659174,"number":608,"title":"SAML De-Serializer","user":{"login":"omgitsbillryan","id":3077884,"avatar_url":"https://avatars.githubusercontent.com/u/3077884?v=3","gravatar_id":"","url":"https://api.github.com/users/omgitsbillryan","html_url":"https://github.com/omgitsbillryan","followers_url":"https://api.github.com/users/omgitsbillryan/followers","following_url":"https://api.github.com/users/omgitsbillryan/following{/other_user}","gists_url":"https://api.github.com/users/omgitsbillryan/gists{/gist_id}","starred_url":"https://api.github.com/users/omgitsbillryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgitsbillryan/subscriptions","organizations_url":"https://api.github.com/users/omgitsbillryan/orgs","repos_url":"https://api.github.com/users/omgitsbillryan/repos","events_url":"https://api.github.com/users/omgitsbillryan/events{/privacy}","received_events_url":"https://api.github.com/users/omgitsbillryan/received_events","type":"User","site_admin":false},"labels":[{"id":429165462,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels/2-in-progress","name":"2-in-progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-09T18:00:28Z","updated_at":"2016-12-09T18:01:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/608","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/608","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/608.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/608.patch"},"body":"**Context**\r\nsessions_controller had too much responsibility - mainly saml attribute de-serialization during `POST saml_callback`.  I did the following:\r\n\r\n- Refactored the de-serialization logic out of `sessions_controller` into it's own class `/lib/saml/de_serializer.rb`\r\n- Removed de-serialization specs from `sessions_controller_spec.rb` (along with a complete re-write of the spec which halved the LOC)\r\n- Created de-serialization spec `/spec/lib/saml/de_serializer_spec.rb`"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments/266079498","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/608#issuecomment-266079498","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/608","id":266079498,"user":{"login":"omgitsbillryan","id":3077884,"avatar_url":"https://avatars.githubusercontent.com/u/3077884?v=3","gravatar_id":"","url":"https://api.github.com/users/omgitsbillryan","html_url":"https://github.com/omgitsbillryan","followers_url":"https://api.github.com/users/omgitsbillryan/followers","following_url":"https://api.github.com/users/omgitsbillryan/following{/other_user}","gists_url":"https://api.github.com/users/omgitsbillryan/gists{/gist_id}","starred_url":"https://api.github.com/users/omgitsbillryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgitsbillryan/subscriptions","organizations_url":"https://api.github.com/users/omgitsbillryan/orgs","repos_url":"https://api.github.com/users/omgitsbillryan/repos","events_url":"https://api.github.com/users/omgitsbillryan/events{/privacy}","received_events_url":"https://api.github.com/users/omgitsbillryan/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T18:01:11Z","updated_at":"2016-12-09T18:01:11Z","body":"This is a low-priority refactor and _does not_ need to be in the Friday 3pm prod deploy"}}
{"actor":{"display_login":"omgitsbillryan"}}