{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/PileProject/drive/pulls/35","id":85700551,"html_url":"https://github.com/PileProject/drive/pull/35","diff_url":"https://github.com/PileProject/drive/pull/35.diff","patch_url":"https://github.com/PileProject/drive/pull/35.patch","issue_url":"https://api.github.com/repos/PileProject/drive/issues/35","number":35,"state":"closed","locked":false,"title":"Refactor Blocks","user":{"login":"myusak","id":5147779,"avatar_url":"https://avatars.githubusercontent.com/u/5147779?v=3","gravatar_id":"","url":"https://api.github.com/users/myusak","html_url":"https://github.com/myusak","followers_url":"https://api.github.com/users/myusak/followers","following_url":"https://api.github.com/users/myusak/following{/other_user}","gists_url":"https://api.github.com/users/myusak/gists{/gist_id}","starred_url":"https://api.github.com/users/myusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myusak/subscriptions","organizations_url":"https://api.github.com/users/myusak/orgs","repos_url":"https://api.github.com/users/myusak/repos","events_url":"https://api.github.com/users/myusak/events{/privacy}","received_events_url":"https://api.github.com/users/myusak/received_events","type":"User","site_admin":false},"body":"Following changes are made in this commit:\r\n* Rename classe\r\n    As we discussed offline\r\n\r\n* Extract common functions among block classes\r\n    Changed NumberTextHolder interface for better encapsulation\r\n\r\n* Change return value type of BlockBase#getKind\r\n    The previous code uses Class class, which does not represent actual\r\n    use case (e.g., ForwardSecBlock#getKind returns SequenceBlock.class).\r\n    Replaced Class<? extends Block> type with Enum.\r\n\r\n* Remove locale-dependent code on parsing numbers\r\n    The previous code relies on the Locale.US no matter what locale\r\n    this app runs on.\r\n    This commit fixes the locale dependent code by extracting the parsing\r\n    logic.\r\n\r\n* Fix the unspoken rule that using scaled values\r\n  for communicating between blocks and number pickers.\r\n    The previous code scaled values so that the value has no radix\r\n    point, which was confusing code.\r\n    Fixed by replacing the type with BigDecimal and explicitly use the raw\r\n    value.\r\n    In accordance with it, changed the type of \"number\"\r\n    in ProgramDataSpec for saving without data loss\r\n\r\n* Remove code in Unit class for handling quantities, which was ugly and cannot be used widely.\r\n    Changed second string (\"second/s\" -> just \"s\")","created_at":"2016-09-18T07:22:19Z","updated_at":"2016-09-30T15:30:57Z","closed_at":"2016-09-30T15:30:56Z","merged_at":"2016-09-30T15:30:56Z","merge_commit_sha":"17ea9c69b83d69f270913b69a09bf784bae37a8a","assignee":{"login":"tiwanari","id":2739915,"avatar_url":"https://avatars.githubusercontent.com/u/2739915?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanari","html_url":"https://github.com/tiwanari","followers_url":"https://api.github.com/users/tiwanari/followers","following_url":"https://api.github.com/users/tiwanari/following{/other_user}","gists_url":"https://api.github.com/users/tiwanari/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanari/subscriptions","organizations_url":"https://api.github.com/users/tiwanari/orgs","repos_url":"https://api.github.com/users/tiwanari/repos","events_url":"https://api.github.com/users/tiwanari/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanari/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiwanari","id":2739915,"avatar_url":"https://avatars.githubusercontent.com/u/2739915?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwanari","html_url":"https://github.com/tiwanari","followers_url":"https://api.github.com/users/tiwanari/followers","following_url":"https://api.github.com/users/tiwanari/following{/other_user}","gists_url":"https://api.github.com/users/tiwanari/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanari/subscriptions","organizations_url":"https://api.github.com/users/tiwanari/orgs","repos_url":"https://api.github.com/users/tiwanari/repos","events_url":"https://api.github.com/users/tiwanari/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanari/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PileProject/drive/pulls/35/commits","review_comments_url":"https://api.github.com/repos/PileProject/drive/pulls/35/comments","review_comment_url":"https://api.github.com/repos/PileProject/drive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PileProject/drive/issues/35/comments","statuses_url":"https://api.github.com/repos/PileProject/drive/statuses/e5fd256a3cd70ae841245367c149328d61f1f674","head":{"label":"myusak:refactor/block","ref":"refactor/block","sha":"e5fd256a3cd70ae841245367c149328d61f1f674","user":{"login":"myusak","id":5147779,"avatar_url":"https://avatars.githubusercontent.com/u/5147779?v=3","gravatar_id":"","url":"https://api.github.com/users/myusak","html_url":"https://github.com/myusak","followers_url":"https://api.github.com/users/myusak/followers","following_url":"https://api.github.com/users/myusak/following{/other_user}","gists_url":"https://api.github.com/users/myusak/gists{/gist_id}","starred_url":"https://api.github.com/users/myusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myusak/subscriptions","organizations_url":"https://api.github.com/users/myusak/orgs","repos_url":"https://api.github.com/users/myusak/repos","events_url":"https://api.github.com/users/myusak/events{/privacy}","received_events_url":"https://api.github.com/users/myusak/received_events","type":"User","site_admin":false},"repo":{"id":53857475,"name":"drive","full_name":"myusak/drive","owner":{"login":"myusak","id":5147779,"avatar_url":"https://avatars.githubusercontent.com/u/5147779?v=3","gravatar_id":"","url":"https://api.github.com/users/myusak","html_url":"https://github.com/myusak","followers_url":"https://api.github.com/users/myusak/followers","following_url":"https://api.github.com/users/myusak/following{/other_user}","gists_url":"https://api.github.com/users/myusak/gists{/gist_id}","starred_url":"https://api.github.com/users/myusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myusak/subscriptions","organizations_url":"https://api.github.com/users/myusak/orgs","repos_url":"https://api.github.com/users/myusak/repos","events_url":"https://api.github.com/users/myusak/events{/privacy}","received_events_url":"https://api.github.com/users/myusak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myusak/drive","description":"The drive project","fork":true,"url":"https://api.github.com/repos/myusak/drive","forks_url":"https://api.github.com/repos/myusak/drive/forks","keys_url":"https://api.github.com/repos/myusak/drive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myusak/drive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myusak/drive/teams","hooks_url":"https://api.github.com/repos/myusak/drive/hooks","issue_events_url":"https://api.github.com/repos/myusak/drive/issues/events{/number}","events_url":"https://api.github.com/repos/myusak/drive/events","assignees_url":"https://api.github.com/repos/myusak/drive/assignees{/user}","branches_url":"https://api.github.com/repos/myusak/drive/branches{/branch}","tags_url":"https://api.github.com/repos/myusak/drive/tags","blobs_url":"https://api.github.com/repos/myusak/drive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myusak/drive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myusak/drive/git/refs{/sha}","trees_url":"https://api.github.com/repos/myusak/drive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myusak/drive/statuses/{sha}","languages_url":"https://api.github.com/repos/myusak/drive/languages","stargazers_url":"https://api.github.com/repos/myusak/drive/stargazers","contributors_url":"https://api.github.com/repos/myusak/drive/contributors","subscribers_url":"https://api.github.com/repos/myusak/drive/subscribers","subscription_url":"https://api.github.com/repos/myusak/drive/subscription","commits_url":"https://api.github.com/repos/myusak/drive/commits{/sha}","git_commits_url":"https://api.github.com/repos/myusak/drive/git/commits{/sha}","comments_url":"https://api.github.com/repos/myusak/drive/comments{/number}","issue_comment_url":"https://api.github.com/repos/myusak/drive/issues/comments{/number}","contents_url":"https://api.github.com/repos/myusak/drive/contents/{+path}","compare_url":"https://api.github.com/repos/myusak/drive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myusak/drive/merges","archive_url":"https://api.github.com/repos/myusak/drive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myusak/drive/downloads","issues_url":"https://api.github.com/repos/myusak/drive/issues{/number}","pulls_url":"https://api.github.com/repos/myusak/drive/pulls{/number}","milestones_url":"https://api.github.com/repos/myusak/drive/milestones{/number}","notifications_url":"https://api.github.com/repos/myusak/drive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myusak/drive/labels{/name}","releases_url":"https://api.github.com/repos/myusak/drive/releases{/id}","deployments_url":"https://api.github.com/repos/myusak/drive/deployments","created_at":"2016-03-14T13:16:15Z","updated_at":"2016-03-14T13:16:16Z","pushed_at":"2016-09-29T14:30:42Z","git_url":"git://github.com/myusak/drive.git","ssh_url":"git@github.com:myusak/drive.git","clone_url":"https://github.com/myusak/drive.git","svn_url":"https://github.com/myusak/drive","homepage":null,"size":1490,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PileProject:develop","ref":"develop","sha":"888e27f925924e8775cfbd8b6ec0c6bc36bc0eba","user":{"login":"PileProject","id":4993284,"avatar_url":"https://avatars.githubusercontent.com/u/4993284?v=3","gravatar_id":"","url":"https://api.github.com/users/PileProject","html_url":"https://github.com/PileProject","followers_url":"https://api.github.com/users/PileProject/followers","following_url":"https://api.github.com/users/PileProject/following{/other_user}","gists_url":"https://api.github.com/users/PileProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PileProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PileProject/subscriptions","organizations_url":"https://api.github.com/users/PileProject/orgs","repos_url":"https://api.github.com/users/PileProject/repos","events_url":"https://api.github.com/users/PileProject/events{/privacy}","received_events_url":"https://api.github.com/users/PileProject/received_events","type":"Organization","site_admin":false},"repo":{"id":40538806,"name":"drive","full_name":"PileProject/drive","owner":{"login":"PileProject","id":4993284,"avatar_url":"https://avatars.githubusercontent.com/u/4993284?v=3","gravatar_id":"","url":"https://api.github.com/users/PileProject","html_url":"https://github.com/PileProject","followers_url":"https://api.github.com/users/PileProject/followers","following_url":"https://api.github.com/users/PileProject/following{/other_user}","gists_url":"https://api.github.com/users/PileProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PileProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PileProject/subscriptions","organizations_url":"https://api.github.com/users/PileProject/orgs","repos_url":"https://api.github.com/users/PileProject/repos","events_url":"https://api.github.com/users/PileProject/events{/privacy}","received_events_url":"https://api.github.com/users/PileProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PileProject/drive","description":"The drive project","fork":false,"url":"https://api.github.com/repos/PileProject/drive","forks_url":"https://api.github.com/repos/PileProject/drive/forks","keys_url":"https://api.github.com/repos/PileProject/drive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PileProject/drive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PileProject/drive/teams","hooks_url":"https://api.github.com/repos/PileProject/drive/hooks","issue_events_url":"https://api.github.com/repos/PileProject/drive/issues/events{/number}","events_url":"https://api.github.com/repos/PileProject/drive/events","assignees_url":"https://api.github.com/repos/PileProject/drive/assignees{/user}","branches_url":"https://api.github.com/repos/PileProject/drive/branches{/branch}","tags_url":"https://api.github.com/repos/PileProject/drive/tags","blobs_url":"https://api.github.com/repos/PileProject/drive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PileProject/drive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PileProject/drive/git/refs{/sha}","trees_url":"https://api.github.com/repos/PileProject/drive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PileProject/drive/statuses/{sha}","languages_url":"https://api.github.com/repos/PileProject/drive/languages","stargazers_url":"https://api.github.com/repos/PileProject/drive/stargazers","contributors_url":"https://api.github.com/repos/PileProject/drive/contributors","subscribers_url":"https://api.github.com/repos/PileProject/drive/subscribers","subscription_url":"https://api.github.com/repos/PileProject/drive/subscription","commits_url":"https://api.github.com/repos/PileProject/drive/commits{/sha}","git_commits_url":"https://api.github.com/repos/PileProject/drive/git/commits{/sha}","comments_url":"https://api.github.com/repos/PileProject/drive/comments{/number}","issue_comment_url":"https://api.github.com/repos/PileProject/drive/issues/comments{/number}","contents_url":"https://api.github.com/repos/PileProject/drive/contents/{+path}","compare_url":"https://api.github.com/repos/PileProject/drive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PileProject/drive/merges","archive_url":"https://api.github.com/repos/PileProject/drive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PileProject/drive/downloads","issues_url":"https://api.github.com/repos/PileProject/drive/issues{/number}","pulls_url":"https://api.github.com/repos/PileProject/drive/pulls{/number}","milestones_url":"https://api.github.com/repos/PileProject/drive/milestones{/number}","notifications_url":"https://api.github.com/repos/PileProject/drive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PileProject/drive/labels{/name}","releases_url":"https://api.github.com/repos/PileProject/drive/releases{/id}","deployments_url":"https://api.github.com/repos/PileProject/drive/deployments","created_at":"2015-08-11T11:48:17Z","updated_at":"2016-09-18T06:29:21Z","pushed_at":"2016-09-30T15:30:56Z","git_url":"git://github.com/PileProject/drive.git","ssh_url":"git@github.com:PileProject/drive.git","clone_url":"https://github.com/PileProject/drive.git","svn_url":"https://github.com/PileProject/drive","homepage":null,"size":1544,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PileProject/drive/pulls/35"},"html":{"href":"https://github.com/PileProject/drive/pull/35"},"issue":{"href":"https://api.github.com/repos/PileProject/drive/issues/35"},"comments":{"href":"https://api.github.com/repos/PileProject/drive/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/PileProject/drive/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/PileProject/drive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PileProject/drive/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/PileProject/drive/statuses/e5fd256a3cd70ae841245367c149328d61f1f674"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"myusak","id":5147779,"avatar_url":"https://avatars.githubusercontent.com/u/5147779?v=3","gravatar_id":"","url":"https://api.github.com/users/myusak","html_url":"https://github.com/myusak","followers_url":"https://api.github.com/users/myusak/followers","following_url":"https://api.github.com/users/myusak/following{/other_user}","gists_url":"https://api.github.com/users/myusak/gists{/gist_id}","starred_url":"https://api.github.com/users/myusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myusak/subscriptions","organizations_url":"https://api.github.com/users/myusak/orgs","repos_url":"https://api.github.com/users/myusak/repos","events_url":"https://api.github.com/users/myusak/events{/privacy}","received_events_url":"https://api.github.com/users/myusak/received_events","type":"User","site_admin":false},"comments":4,"review_comments":30,"commits":6,"additions":1445,"deletions":948,"changed_files":57}}
{"actor":{"display_login":"myusak"}}