{"action":"opened","number":5479,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5479","id":91255186,"html_url":"https://github.com/callemall/material-ui/pull/5479","diff_url":"https://github.com/callemall/material-ui/pull/5479.diff","patch_url":"https://github.com/callemall/material-ui/pull/5479.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5479","number":5479,"state":"open","locked":false,"title":"[FlatButton, FloatingActionButton, IconButton] Added target html attribute.","user":{"login":"jvhoven","id":5366355,"avatar_url":"https://avatars.githubusercontent.com/u/5366355?v=3","gravatar_id":"","url":"https://api.github.com/users/jvhoven","html_url":"https://github.com/jvhoven","followers_url":"https://api.github.com/users/jvhoven/followers","following_url":"https://api.github.com/users/jvhoven/following{/other_user}","gists_url":"https://api.github.com/users/jvhoven/gists{/gist_id}","starred_url":"https://api.github.com/users/jvhoven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvhoven/subscriptions","organizations_url":"https://api.github.com/users/jvhoven/orgs","repos_url":"https://api.github.com/users/jvhoven/repos","events_url":"https://api.github.com/users/jvhoven/events{/privacy}","received_events_url":"https://api.github.com/users/jvhoven/received_events","type":"User","site_admin":false},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! -->\r\n\r\nFixes #5459.\r\n\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\nAdded target properties on aforementioned components and written a test for FlatButton that validates the rendering with the target property.\r\n\r\nI've also updated the docs page of FlatButtonExampleIcon with the link to the github page with a target=\"_blank\". Not sure if that's desirable, see [target _blank vulnerability](https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/). I'd like to hear your thoughts on this matter.\r\n\r\nWhat I haven't done is implement the fifth feature of the target attribute: \r\n```\r\nframename - Opens the linked document in a named frame\r\n```\r\n\r\nThen again I'm not sure if this is desirable to be implemented aswell as it can be defined as an enum now :smiley:.","created_at":"2016-10-27T18:28:18Z","updated_at":"2016-10-27T18:28:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5479/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5479/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5479/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/204981bcd4138acfee631ee2d12fc46dfb60815a","head":{"label":"jvhoven:feature/target-attribute-on-buttons","ref":"feature/target-attribute-on-buttons","sha":"204981bcd4138acfee631ee2d12fc46dfb60815a","user":{"login":"jvhoven","id":5366355,"avatar_url":"https://avatars.githubusercontent.com/u/5366355?v=3","gravatar_id":"","url":"https://api.github.com/users/jvhoven","html_url":"https://github.com/jvhoven","followers_url":"https://api.github.com/users/jvhoven/followers","following_url":"https://api.github.com/users/jvhoven/following{/other_user}","gists_url":"https://api.github.com/users/jvhoven/gists{/gist_id}","starred_url":"https://api.github.com/users/jvhoven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvhoven/subscriptions","organizations_url":"https://api.github.com/users/jvhoven/orgs","repos_url":"https://api.github.com/users/jvhoven/repos","events_url":"https://api.github.com/users/jvhoven/events{/privacy}","received_events_url":"https://api.github.com/users/jvhoven/received_events","type":"User","site_admin":false},"repo":{"id":72132420,"name":"material-ui","full_name":"jvhoven/material-ui","owner":{"login":"jvhoven","id":5366355,"avatar_url":"https://avatars.githubusercontent.com/u/5366355?v=3","gravatar_id":"","url":"https://api.github.com/users/jvhoven","html_url":"https://github.com/jvhoven","followers_url":"https://api.github.com/users/jvhoven/followers","following_url":"https://api.github.com/users/jvhoven/following{/other_user}","gists_url":"https://api.github.com/users/jvhoven/gists{/gist_id}","starred_url":"https://api.github.com/users/jvhoven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvhoven/subscriptions","organizations_url":"https://api.github.com/users/jvhoven/orgs","repos_url":"https://api.github.com/users/jvhoven/repos","events_url":"https://api.github.com/users/jvhoven/events{/privacy}","received_events_url":"https://api.github.com/users/jvhoven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvhoven/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/jvhoven/material-ui","forks_url":"https://api.github.com/repos/jvhoven/material-ui/forks","keys_url":"https://api.github.com/repos/jvhoven/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvhoven/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvhoven/material-ui/teams","hooks_url":"https://api.github.com/repos/jvhoven/material-ui/hooks","issue_events_url":"https://api.github.com/repos/jvhoven/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jvhoven/material-ui/events","assignees_url":"https://api.github.com/repos/jvhoven/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jvhoven/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jvhoven/material-ui/tags","blobs_url":"https://api.github.com/repos/jvhoven/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvhoven/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvhoven/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvhoven/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvhoven/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jvhoven/material-ui/languages","stargazers_url":"https://api.github.com/repos/jvhoven/material-ui/stargazers","contributors_url":"https://api.github.com/repos/jvhoven/material-ui/contributors","subscribers_url":"https://api.github.com/repos/jvhoven/material-ui/subscribers","subscription_url":"https://api.github.com/repos/jvhoven/material-ui/subscription","commits_url":"https://api.github.com/repos/jvhoven/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvhoven/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvhoven/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvhoven/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvhoven/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jvhoven/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvhoven/material-ui/merges","archive_url":"https://api.github.com/repos/jvhoven/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvhoven/material-ui/downloads","issues_url":"https://api.github.com/repos/jvhoven/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jvhoven/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jvhoven/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jvhoven/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvhoven/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/jvhoven/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jvhoven/material-ui/deployments","created_at":"2016-10-27T17:35:59Z","updated_at":"2016-10-27T17:36:02Z","pushed_at":"2016-10-27T18:12:07Z","git_url":"git://github.com/jvhoven/material-ui.git","ssh_url":"git@github.com:jvhoven/material-ui.git","clone_url":"https://github.com/jvhoven/material-ui.git","svn_url":"https://github.com/jvhoven/material-ui","homepage":"http://www.material-ui.com","size":82284,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"b50c6551c9949ef1639abbf800cfada02b29a847","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-10-27T18:18:32Z","pushed_at":"2016-10-27T07:56:30Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":82284,"stargazers_count":20534,"watchers_count":20534,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3691,"mirror_url":null,"open_issues_count":642,"forks":3691,"open_issues":642,"watchers":20534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5479"},"html":{"href":"https://github.com/callemall/material-ui/pull/5479"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5479"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5479/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5479/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5479/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/204981bcd4138acfee631ee2d12fc46dfb60815a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"jvhoven"}}